From xen-devel-bounces@lists.xenproject.org Thu Jul 01 02:08:29 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 02:08:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148263.273997 (Exim 4.92) (envelope-from ) id 1lym7j-0006av-FC; Thu, 01 Jul 2021 02:08:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148263.273997; Thu, 01 Jul 2021 02:08:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lym7j-0006an-9K; Thu, 01 Jul 2021 02:08:15 +0000 Received: by outflank-mailman (input) for mailman id 148263; Thu, 01 Jul 2021 02:08:13 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lym7h-0006ad-7w; Thu, 01 Jul 2021 02:08:13 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lym7h-0001FR-0G; Thu, 01 Jul 2021 02:08:13 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lym7g-0004bz-LJ; Thu, 01 Jul 2021 02:08:12 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lym7g-0001AK-Km; Thu, 01 Jul 2021 02:08:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=bRKVqBYKc/+Z2YRe+ywFd8gEmx9KcEdszpZ4HsN7kHM=; b=U53VaXoK47GbN8xlC5BuHFiKEp AdtdkZduO9VRr3nq36Wk0x2zgjje/4zNviydepOObtq0R8CxF3eMofE7VqtZCmwLQXWy01XmYRTxj vVZBkkqtSJVua9Axhb5CMOIpYkYWkZxmN4OK4VaRLqKdMCEUR++6u6jHgTqhlDkCwPlk=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 163195: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-i386-qemut-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-coresched-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-examine:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-pvshim:xen-install:fail:regression linux-linus:test-amd64-i386-xl-raw:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-i386:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-xsm:xen-install:fail:regression linux-linus:test-amd64-amd64-libvirt-vhd:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-thunderx:debian-fixup:fail:regression linux-linus:test-arm64-arm64-xl-credit1:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-xsm:debian-fixup:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:debian-fixup:fail:regression linux-linus:test-amd64-amd64-amd64-pvgrub:guest-stop:fail:regression linux-linus:test-arm64-arm64-xl:guest-start:fail:regression linux-linus:test-amd64-amd64-i386-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-xl-qcow2:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-credit2:debian-fixup:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:regression linux-linus:test-armhf-armhf-xl-vhd:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=007b350a58754a93ca9fe50c498cc27780171153 X-Osstest-Versions-That: linux=deacdb3e3979979016fcd0ffd518c320a62ad166 From: osstest service owner Date: Thu, 01 Jul 2021 02:08:12 +0000 flight 163195 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/163195/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-qemut-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-coresched-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-examine 6 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-pvshim 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-raw 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-i386 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-amd64-libvirt-vhd 13 guest-start fail REGR. vs. 152332 test-arm64-arm64-xl-thunderx 13 debian-fixup fail REGR. vs. 152332 test-arm64-arm64-xl-credit1 14 guest-start fail REGR. vs. 152332 test-arm64-arm64-xl-xsm 13 debian-fixup fail REGR. vs. 152332 test-arm64-arm64-libvirt-xsm 13 debian-fixup fail REGR. vs. 152332 test-amd64-amd64-amd64-pvgrub 20 guest-stop fail REGR. vs. 152332 test-arm64-arm64-xl 14 guest-start fail REGR. vs. 152332 test-amd64-amd64-i386-pvgrub 20 guest-stop fail REGR. vs. 152332 test-amd64-amd64-xl-qcow2 13 guest-start fail REGR. vs. 152332 test-arm64-arm64-xl-credit2 13 debian-fixup fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 152332 test-armhf-armhf-xl-vhd 13 guest-start fail REGR. vs. 152332 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152332 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152332 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152332 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass version targeted for testing: linux 007b350a58754a93ca9fe50c498cc27780171153 baseline version: linux deacdb3e3979979016fcd0ffd518c320a62ad166 Last test of basis 152332 2020-07-31 19:41:23 Z 334 days Failing since 152366 2020-08-01 20:49:34 Z 333 days 567 attempts Testing same since 163195 2021-06-30 09:06:52 Z 0 days 1 attempts ------------------------------------------------------------ 6317 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl fail test-armhf-armhf-xl pass test-amd64-i386-xl fail test-amd64-coresched-i386-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm fail test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm fail test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine fail test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel fail test-amd64-i386-qemuu-rhel6hvm-intel fail test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-amd64-pvgrub fail test-amd64-amd64-i386-pvgrub fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 fail test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow fail test-arm64-arm64-xl-thunderx fail test-amd64-amd64-libvirt-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1744923 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Jul 01 06:23:21 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 06:23:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148269.274010 (Exim 4.92) (envelope-from ) id 1lyq6I-00047N-Vp; Thu, 01 Jul 2021 06:23:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148269.274010; Thu, 01 Jul 2021 06:23:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyq6I-00047G-Sr; Thu, 01 Jul 2021 06:23:02 +0000 Received: by outflank-mailman (input) for mailman id 148269; Thu, 01 Jul 2021 06:23:01 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyq6H-000475-6z; Thu, 01 Jul 2021 06:23:01 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyq6H-0005x8-1A; Thu, 01 Jul 2021 06:23:01 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyq6G-0001lA-Ox; Thu, 01 Jul 2021 06:23:00 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lyq6G-0006Ml-Ld; Thu, 01 Jul 2021 06:23:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=R3ez+fkC7xRSKcNK32PGzZXlH0Tpttdvjmqa5DCxGU8=; b=DFDxvzxete0XyAwg1PRkPbQV9Y N8MawmBMRn43JFe69Li6ycWEXcKvcIBGKioUTLpV4g46aGaGHYSf/4P15kpLeJ4hAP4Mr2C01iL3T HHnDM40WBxYf/cVejLW98wRmTP32cxLF/cjoavSK/vkV3SGQsoR3y2Erj77ozQEOrdfk=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [seabios test] 163203: tolerable FAIL - PUSHED X-Osstest-Failures: seabios:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking seabios:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking seabios:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking seabios:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking seabios:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking seabios:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking seabios:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: seabios=54082c81d96028ba8c76fbe6784085cf1df76b20 X-Osstest-Versions-That: seabios=e3c30795823672eec9bde75187e184f23ed98d70 From: osstest service owner Date: Thu, 01 Jul 2021 06:23:00 +0000 flight 163203 seabios real [real] http://logs.test-lab.xenproject.org/osstest/logs/163203/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 162576 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 162576 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 162576 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 162576 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 162576 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass version targeted for testing: seabios 54082c81d96028ba8c76fbe6784085cf1df76b20 baseline version: seabios e3c30795823672eec9bde75187e184f23ed98d70 Last test of basis 162576 2021-06-09 15:09:57 Z 21 days Testing same since 163203 2021-06-30 21:10:04 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alex Martens Alex Martens via SeaBIOS Stefan Berger jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/seabios.git e3c3079..54082c8 54082c81d96028ba8c76fbe6784085cf1df76b20 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Thu Jul 01 06:30:59 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 06:30:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148276.274025 (Exim 4.92) (envelope-from ) id 1lyqDw-0005ai-1J; Thu, 01 Jul 2021 06:30:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148276.274025; Thu, 01 Jul 2021 06:30:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyqDv-0005ab-UU; Thu, 01 Jul 2021 06:30:55 +0000 Received: by outflank-mailman (input) for mailman id 148276; Thu, 01 Jul 2021 06:30:54 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyqDu-0005aR-G6; Thu, 01 Jul 2021 06:30:54 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyqDu-00065C-92; Thu, 01 Jul 2021 06:30:54 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyqDt-00021H-Uy; Thu, 01 Jul 2021 06:30:54 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lyqDt-0002c6-US; Thu, 01 Jul 2021 06:30:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=9vY6NbhnLXrYZhykF9Kc8uNkB4M48sRE0+iIOQuslCc=; b=3lLauX2S4tPvXxs+YSa55c5JAZ 4ICy0iJqZ3NceGly19DCojQ5qbMqf6KuJfqxl4kGjFhFjHI/HgRo0MQQUcq433/MqQo2pfATI3+vI qzdp3n5ZRbcK850sB8OKylubi0EWkcZVm4ci667HYcW90POSmVIyrFYMkP3OLTQpCIr0=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 163198: tolerable FAIL - PUSHED X-Osstest-Failures: linux-5.4:test-amd64-amd64-libvirt-vhd:guest-start.2:fail:heisenbug linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=82ffbc138a1fc9076f55e626bd8352fc9a2ca9e9 X-Osstest-Versions-That: linux=4037804c55745738e0950658a5132790e6ac52e4 From: osstest service owner Date: Thu, 01 Jul 2021 06:30:53 +0000 flight 163198 linux-5.4 real [real] flight 163209 linux-5.4 real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/163198/ http://logs.test-lab.xenproject.org/osstest/logs/163209/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-libvirt-vhd 20 guest-start.2 fail pass in 163209-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 162998 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 162998 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 162998 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 162998 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 162998 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 162998 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 162998 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 162998 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 162998 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 162998 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 162998 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: linux 82ffbc138a1fc9076f55e626bd8352fc9a2ca9e9 baseline version: linux 4037804c55745738e0950658a5132790e6ac52e4 Last test of basis 162998 2021-06-23 13:11:21 Z 7 days Testing same since 163198 2021-06-30 13:43:03 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alex Deucher Alex Shi Andrew Morton Ard Biesheuvel Arnd Bergmann Austin Kim Bjorn Helgaas Catalin Marinas Christian König David Howells David S. Miller Du Cheng Eric Dumazet Eric Richter Eric Snowberg Esben Haabendal Fabien Dessenne Fuad Tabba Gang Deng Geet Modi Greg Kroah-Hartman Guenter Roeck Guillaume Ranquet Haibo Chen Hugh Dickins Hulk Robot Jarkko Sakkinen Jessica Yu Johan Hovold Johannes Berg Johannes Weiner Jue Wang Kees Cook Kirill A. Shutemov Linus Torvalds Linus Walleij Linux Kernel Functional Testing Marek Szyprowski Mark Brown Mark-PK Tsai Masahiro Yamada Miaohe Lin Michael Ellerman Michal Hocko Mikel Rychliski Mimi Zohar Nathan Chancellor Nathan Chancellor Nayna Jain Neil Armstrong Nicholas Piggin Nick Desaulniers Paolo Bonzini Pavel Skripkin Peter Zijlstra (Intel) Peter Zijlstra Petr Mladek Praneeth Bajjuri Rafael J. Wysocki Russell King Ryusuke Konishi Sami Tolvanen Sasha Levin Sedat Dilek Steven Rostedt (VMware) Sudip Mukherjee Thomas Bogendoerfer Thomas Gleixner Ulf Hansson Vinod Koul Wang Yugui Wolfram Sang Xu Yu Yang Shi Yifan Zhang Yu Kuai Zheng Yongjun Zou Wei jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd fail test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 4037804c5574..82ffbc138a1f 82ffbc138a1fc9076f55e626bd8352fc9a2ca9e9 -> tested/linux-5.4 From xen-devel-bounces@lists.xenproject.org Thu Jul 01 07:41:19 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 07:41:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148282.274039 (Exim 4.92) (envelope-from ) id 1lyrJm-0003lm-G4; Thu, 01 Jul 2021 07:41:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148282.274039; Thu, 01 Jul 2021 07:41:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyrJm-0003lf-D0; Thu, 01 Jul 2021 07:41:02 +0000 Received: by outflank-mailman (input) for mailman id 148282; Thu, 01 Jul 2021 07:41:00 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyrJk-0003lZ-T4 for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 07:41:00 +0000 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id bb3e45da-e714-4cc5-b356-85c13bb7c33c; Thu, 01 Jul 2021 07:40:59 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 0BF8F61490; Thu, 1 Jul 2021 07:40:49 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bb3e45da-e714-4cc5-b356-85c13bb7c33c DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1625125258; bh=V3O+3W7jB9kkeE64PRRWE2Y3UpoZf8XatBMI8/4BWL4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=F47xX0udIB6iAhzJO4OCoYXustVjtbNDusBM6+5rMT4M3Jwb59Ij6VbvwwiLyzT6q lVI9XKD0neOgmCNGZhPOuPRmgvUtcJwOJudRhNq8QU0qAxfZtInwaJU1ov8QiZuLeT DSyGO4DRrv/TOQGPwoVHvv2mYwNhMKcCDaJwQuNmTPf97jcrOnjcpDKJmqwAzkdem5 hHvVa4UcTux22+QKhFYM3yrVmN1Vb2rSgrqmfY6qt7l9uLrocYxekS5t84/HB7q0FV t30L31wv/VRZpgr/tSPS/Ve7LY6CjYBHT4Q7WRQAtBhB8uvBHYNybLCcdlqWGz6LE7 dIvbEvT0BuNHw== Date: Thu, 1 Jul 2021 08:40:46 +0100 From: Will Deacon To: Nathan Chancellor Cc: Claire Chang , Rob Herring , mpe@ellerman.id.au, Joerg Roedel , Frank Rowand , Konrad Rzeszutek Wilk , boris.ostrovsky@oracle.com, jgross@suse.com, Christoph Hellwig , Marek Szyprowski , benh@kernel.crashing.org, paulus@samba.org, "list@263.net:IOMMU DRIVERS" , Stefano Stabellini , Robin Murphy , grant.likely@arm.com, xypron.glpk@gmx.de, Thierry Reding , mingo@kernel.org, bauerman@linux.ibm.com, peterz@infradead.org, Greg KH , Saravana Kannan , "Rafael J . Wysocki" , heikki.krogerus@linux.intel.com, Andy Shevchenko , Randy Dunlap , Dan Williams , Bartosz Golaszewski , linux-devicetree , lkml , linuxppc-dev@lists.ozlabs.org, xen-devel@lists.xenproject.org, Nicolas Boichat , Jim Quinlan , Tomasz Figa , bskeggs@redhat.com, Bjorn Helgaas , chris@chris-wilson.co.uk, Daniel Vetter , airlied@linux.ie, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, jani.nikula@linux.intel.com, Jianxiong Gao , joonas.lahtinen@linux.intel.com, linux-pci@vger.kernel.org, maarten.lankhorst@linux.intel.com, matthew.auld@intel.com, rodrigo.vivi@intel.com, thomas.hellstrom@linux.intel.com, Tom Lendacky , Qian Cai Subject: Re: [PATCH v15 06/12] swiotlb: Use is_swiotlb_force_bounce for swiotlb data bouncing Message-ID: <20210701074045.GA9436@willie-the-truck> References: <20210624155526.2775863-1-tientzu@chromium.org> <20210624155526.2775863-7-tientzu@chromium.org> <20210630114348.GA8383@willie-the-truck> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) On Wed, Jun 30, 2021 at 08:56:51AM -0700, Nathan Chancellor wrote: > On Wed, Jun 30, 2021 at 12:43:48PM +0100, Will Deacon wrote: > > On Wed, Jun 30, 2021 at 05:17:27PM +0800, Claire Chang wrote: > > > `BUG: unable to handle page fault for address: 00000000003a8290` and > > > the fact it crashed at `_raw_spin_lock_irqsave` look like the memory > > > (maybe dev->dma_io_tlb_mem) was corrupted? > > > The dev->dma_io_tlb_mem should be set here > > > (https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/pci/probe.c#n2528) > > > through device_initialize. > > > > I'm less sure about this. 'dma_io_tlb_mem' should be pointing at > > 'io_tlb_default_mem', which is a page-aligned allocation from memblock. > > The spinlock is at offset 0x24 in that structure, and looking at the > > register dump from the crash: > > > > Jun 29 18:28:42 hp-4300G kernel: RSP: 0018:ffffadb4013db9e8 EFLAGS: 00010006 > > Jun 29 18:28:42 hp-4300G kernel: RAX: 00000000003a8290 RBX: 0000000000000000 RCX: ffff8900572ad580 > > Jun 29 18:28:42 hp-4300G kernel: RDX: ffff89005653f024 RSI: 00000000000c0000 RDI: 0000000000001d17 > > Jun 29 18:28:42 hp-4300G kernel: RBP: 000000000a20d000 R08: 00000000000c0000 R09: 0000000000000000 > > Jun 29 18:28:42 hp-4300G kernel: R10: 000000000a20d000 R11: ffff89005653f000 R12: 0000000000000212 > > Jun 29 18:28:42 hp-4300G kernel: R13: 0000000000001000 R14: 0000000000000002 R15: 0000000000200000 > > Jun 29 18:28:42 hp-4300G kernel: FS: 00007f1f8898ea40(0000) GS:ffff890057280000(0000) knlGS:0000000000000000 > > Jun 29 18:28:42 hp-4300G kernel: CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > > Jun 29 18:28:42 hp-4300G kernel: CR2: 00000000003a8290 CR3: 00000001020d0000 CR4: 0000000000350ee0 > > Jun 29 18:28:42 hp-4300G kernel: Call Trace: > > Jun 29 18:28:42 hp-4300G kernel: _raw_spin_lock_irqsave+0x39/0x50 > > Jun 29 18:28:42 hp-4300G kernel: swiotlb_tbl_map_single+0x12b/0x4c0 > > > > Then that correlates with R11 holding the 'dma_io_tlb_mem' pointer and > > RDX pointing at the spinlock. Yet RAX is holding junk :/ > > > > I agree that enabling KASAN would be a good idea, but I also think we > > probably need to get some more information out of swiotlb_tbl_map_single() > > to see see what exactly is going wrong in there. > > I can certainly enable KASAN and if there is any debug print I can add > or dump anything, let me know! I bit the bullet and took v5.13 with swiotlb/for-linus-5.14 merged in, built x86 defconfig and ran it on my laptop. However, it seems to work fine! Please can you share your .config? Will From xen-devel-bounces@lists.xenproject.org Thu Jul 01 07:52:46 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 07:52:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148287.274050 (Exim 4.92) (envelope-from ) id 1lyrV3-0005G6-Js; Thu, 01 Jul 2021 07:52:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148287.274050; Thu, 01 Jul 2021 07:52:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyrV3-0005Fz-Fs; Thu, 01 Jul 2021 07:52:41 +0000 Received: by outflank-mailman (input) for mailman id 148287; Thu, 01 Jul 2021 07:52:40 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyrV1-0005Ft-Sp for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 07:52:40 +0000 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 466e0b03-d9b0-4e8e-9057-56e1b2e8b14f; Thu, 01 Jul 2021 07:52:26 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 7BB4E61351; Thu, 1 Jul 2021 07:52:22 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 466e0b03-d9b0-4e8e-9057-56e1b2e8b14f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1625125945; bh=QndjmPenV8a1ARJ/CYAif4b2Us0jdUg0dSO79bVovDA=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=nnxCLJsKH74DPJHDm+HcQZih1fLSgaJVvC7j3cdPh/OF7r1B9tsxdPKQ5FxEtfhBM iZ0Yzf1KSEHevNGHP3EiUqmC6+XTZIETbzjx/GEc8bN9IUr26xhUElmwVhRm582nkG vH64jaARDtajCmxzKl95Y1zyhZpPYIWeQSENETStW3IMfcjGnC5D+sCj2uFwHv9zQ6 ovDoD3MYh/yUU9H2+Pm/AgE67sN4y2n7rYx+x6ill/khw6yUT/RJVDwLaoycXGkGr5 LPbJ41TFUMqqkG0VUBkpmpWlQQqwV0/4u41g3VMpXGT0JWIwiqnpogEzqOunG+jmb6 zZ+RAdMyuKqGA== Subject: Re: [PATCH v15 06/12] swiotlb: Use is_swiotlb_force_bounce for swiotlb data bouncing To: Will Deacon Cc: Claire Chang , Rob Herring , mpe@ellerman.id.au, Joerg Roedel , Frank Rowand , Konrad Rzeszutek Wilk , boris.ostrovsky@oracle.com, jgross@suse.com, Christoph Hellwig , Marek Szyprowski , benh@kernel.crashing.org, paulus@samba.org, "list@263.net:IOMMU DRIVERS" , Stefano Stabellini , Robin Murphy , grant.likely@arm.com, xypron.glpk@gmx.de, Thierry Reding , mingo@kernel.org, bauerman@linux.ibm.com, peterz@infradead.org, Greg KH , Saravana Kannan , "Rafael J . Wysocki" , heikki.krogerus@linux.intel.com, Andy Shevchenko , Randy Dunlap , Dan Williams , Bartosz Golaszewski , linux-devicetree , lkml , linuxppc-dev@lists.ozlabs.org, xen-devel@lists.xenproject.org, Nicolas Boichat , Jim Quinlan , Tomasz Figa , bskeggs@redhat.com, Bjorn Helgaas , chris@chris-wilson.co.uk, Daniel Vetter , airlied@linux.ie, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, jani.nikula@linux.intel.com, Jianxiong Gao , joonas.lahtinen@linux.intel.com, linux-pci@vger.kernel.org, maarten.lankhorst@linux.intel.com, matthew.auld@intel.com, rodrigo.vivi@intel.com, thomas.hellstrom@linux.intel.com, Tom Lendacky , Qian Cai References: <20210624155526.2775863-1-tientzu@chromium.org> <20210624155526.2775863-7-tientzu@chromium.org> <20210630114348.GA8383@willie-the-truck> <20210701074045.GA9436@willie-the-truck> From: Nathan Chancellor Message-ID: Date: Thu, 1 Jul 2021 00:52:20 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210701074045.GA9436@willie-the-truck> Content-Type: multipart/mixed; boundary="------------6AC692267CC088E7165122E4" Content-Language: en-US This is a multi-part message in MIME format. --------------6AC692267CC088E7165122E4 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 7/1/2021 12:40 AM, Will Deacon wrote: > On Wed, Jun 30, 2021 at 08:56:51AM -0700, Nathan Chancellor wrote: >> On Wed, Jun 30, 2021 at 12:43:48PM +0100, Will Deacon wrote: >>> On Wed, Jun 30, 2021 at 05:17:27PM +0800, Claire Chang wrote: >>>> `BUG: unable to handle page fault for address: 00000000003a8290` and >>>> the fact it crashed at `_raw_spin_lock_irqsave` look like the memory >>>> (maybe dev->dma_io_tlb_mem) was corrupted? >>>> The dev->dma_io_tlb_mem should be set here >>>> (https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/pci/probe.c#n2528) >>>> through device_initialize. >>> >>> I'm less sure about this. 'dma_io_tlb_mem' should be pointing at >>> 'io_tlb_default_mem', which is a page-aligned allocation from memblock. >>> The spinlock is at offset 0x24 in that structure, and looking at the >>> register dump from the crash: >>> >>> Jun 29 18:28:42 hp-4300G kernel: RSP: 0018:ffffadb4013db9e8 EFLAGS: 00010006 >>> Jun 29 18:28:42 hp-4300G kernel: RAX: 00000000003a8290 RBX: 0000000000000000 RCX: ffff8900572ad580 >>> Jun 29 18:28:42 hp-4300G kernel: RDX: ffff89005653f024 RSI: 00000000000c0000 RDI: 0000000000001d17 >>> Jun 29 18:28:42 hp-4300G kernel: RBP: 000000000a20d000 R08: 00000000000c0000 R09: 0000000000000000 >>> Jun 29 18:28:42 hp-4300G kernel: R10: 000000000a20d000 R11: ffff89005653f000 R12: 0000000000000212 >>> Jun 29 18:28:42 hp-4300G kernel: R13: 0000000000001000 R14: 0000000000000002 R15: 0000000000200000 >>> Jun 29 18:28:42 hp-4300G kernel: FS: 00007f1f8898ea40(0000) GS:ffff890057280000(0000) knlGS:0000000000000000 >>> Jun 29 18:28:42 hp-4300G kernel: CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 >>> Jun 29 18:28:42 hp-4300G kernel: CR2: 00000000003a8290 CR3: 00000001020d0000 CR4: 0000000000350ee0 >>> Jun 29 18:28:42 hp-4300G kernel: Call Trace: >>> Jun 29 18:28:42 hp-4300G kernel: _raw_spin_lock_irqsave+0x39/0x50 >>> Jun 29 18:28:42 hp-4300G kernel: swiotlb_tbl_map_single+0x12b/0x4c0 >>> >>> Then that correlates with R11 holding the 'dma_io_tlb_mem' pointer and >>> RDX pointing at the spinlock. Yet RAX is holding junk :/ >>> >>> I agree that enabling KASAN would be a good idea, but I also think we >>> probably need to get some more information out of swiotlb_tbl_map_single() >>> to see see what exactly is going wrong in there. >> >> I can certainly enable KASAN and if there is any debug print I can add >> or dump anything, let me know! > > I bit the bullet and took v5.13 with swiotlb/for-linus-5.14 merged in, built > x86 defconfig and ran it on my laptop. However, it seems to work fine! > > Please can you share your .config? Sure thing, it is attached. It is just Arch Linux's config run through olddefconfig. The original is below in case you need to diff it. https://raw.githubusercontent.com/archlinux/svntogit-packages/9045405dc835527164f3034b3ceb9a67c7a53cd4/trunk/config If there is anything more that I can provide, please let me know. Cheers, Nathan --------------6AC692267CC088E7165122E4 Content-Type: text/plain; charset=UTF-8; name=".config" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=".config" IwojIEF1dG9tYXRpY2FsbHkgZ2VuZXJhdGVkIGZpbGU7IERPIE5PVCBFRElULgojIExpbnV4 L3g4NiA1LjEyLjAtcmMzIEtlcm5lbCBDb25maWd1cmF0aW9uCiMKQ09ORklHX0NDX1ZFUlNJ T05fVEVYVD0iZ2NjIChHQ0MpIDExLjEuMCIKQ09ORklHX0NDX0lTX0dDQz15CkNPTkZJR19H Q0NfVkVSU0lPTj0xMTAxMDAKQ09ORklHX0NMQU5HX1ZFUlNJT049MApDT05GSUdfTERfSVNf QkZEPXkKQ09ORklHX0xEX1ZFUlNJT049MjM2MDEKQ09ORklHX0xMRF9WRVJTSU9OPTAKQ09O RklHX0NDX0NBTl9MSU5LPXkKQ09ORklHX0NDX0NBTl9MSU5LX1NUQVRJQz15CkNPTkZJR19D Q19IQVNfQVNNX0dPVE89eQpDT05GSUdfQ0NfSEFTX0FTTV9HT1RPX09VVFBVVD15CkNPTkZJ R19DQ19IQVNfQVNNX0lOTElORT15CkNPTkZJR19JUlFfV09SSz15CkNPTkZJR19CVUlMRFRJ TUVfVEFCTEVfU09SVD15CkNPTkZJR19USFJFQURfSU5GT19JTl9UQVNLPXkKCiMKIyBHZW5l cmFsIHNldHVwCiMKQ09ORklHX0lOSVRfRU5WX0FSR19MSU1JVD0zMgojIENPTkZJR19DT01Q SUxFX1RFU1QgaXMgbm90IHNldApDT05GSUdfTE9DQUxWRVJTSU9OPSIiCkNPTkZJR19MT0NB TFZFUlNJT05fQVVUTz15CkNPTkZJR19CVUlMRF9TQUxUPSIiCkNPTkZJR19IQVZFX0tFUk5F TF9HWklQPXkKQ09ORklHX0hBVkVfS0VSTkVMX0JaSVAyPXkKQ09ORklHX0hBVkVfS0VSTkVM X0xaTUE9eQpDT05GSUdfSEFWRV9LRVJORUxfWFo9eQpDT05GSUdfSEFWRV9LRVJORUxfTFpP PXkKQ09ORklHX0hBVkVfS0VSTkVMX0xaND15CkNPTkZJR19IQVZFX0tFUk5FTF9aU1REPXkK IyBDT05GSUdfS0VSTkVMX0daSVAgaXMgbm90IHNldAojIENPTkZJR19LRVJORUxfQlpJUDIg aXMgbm90IHNldAojIENPTkZJR19LRVJORUxfTFpNQSBpcyBub3Qgc2V0CiMgQ09ORklHX0tF Uk5FTF9YWiBpcyBub3Qgc2V0CiMgQ09ORklHX0tFUk5FTF9MWk8gaXMgbm90IHNldAojIENP TkZJR19LRVJORUxfTFo0IGlzIG5vdCBzZXQKQ09ORklHX0tFUk5FTF9aU1REPXkKQ09ORklH X0RFRkFVTFRfSU5JVD0iIgpDT05GSUdfREVGQVVMVF9IT1NUTkFNRT0iYXJjaGxpbnV4IgpD T05GSUdfU1dBUD15CkNPTkZJR19TWVNWSVBDPXkKQ09ORklHX1NZU1ZJUENfU1lTQ1RMPXkK Q09ORklHX1BPU0lYX01RVUVVRT15CkNPTkZJR19QT1NJWF9NUVVFVUVfU1lTQ1RMPXkKQ09O RklHX1dBVENIX1FVRVVFPXkKQ09ORklHX0NST1NTX01FTU9SWV9BVFRBQ0g9eQojIENPTkZJ R19VU0VMSUIgaXMgbm90IHNldApDT05GSUdfQVVESVQ9eQpDT05GSUdfSEFWRV9BUkNIX0FV RElUU1lTQ0FMTD15CkNPTkZJR19BVURJVFNZU0NBTEw9eQoKIwojIElSUSBzdWJzeXN0ZW0K IwpDT05GSUdfR0VORVJJQ19JUlFfUFJPQkU9eQpDT05GSUdfR0VORVJJQ19JUlFfU0hPVz15 CkNPTkZJR19HRU5FUklDX0lSUV9FRkZFQ1RJVkVfQUZGX01BU0s9eQpDT05GSUdfR0VORVJJ Q19QRU5ESU5HX0lSUT15CkNPTkZJR19HRU5FUklDX0lSUV9NSUdSQVRJT049eQpDT05GSUdf R0VORVJJQ19JUlFfSU5KRUNUSU9OPXkKQ09ORklHX0hBUkRJUlFTX1NXX1JFU0VORD15CkNP TkZJR19HRU5FUklDX0lSUV9DSElQPXkKQ09ORklHX0lSUV9ET01BSU49eQpDT05GSUdfSVJR X1NJTT15CkNPTkZJR19JUlFfRE9NQUlOX0hJRVJBUkNIWT15CkNPTkZJR19HRU5FUklDX01T SV9JUlE9eQpDT05GSUdfR0VORVJJQ19NU0lfSVJRX0RPTUFJTj15CkNPTkZJR19JUlFfTVNJ X0lPTU1VPXkKQ09ORklHX0dFTkVSSUNfSVJRX01BVFJJWF9BTExPQ0FUT1I9eQpDT05GSUdf R0VORVJJQ19JUlFfUkVTRVJWQVRJT05fTU9ERT15CkNPTkZJR19JUlFfRk9SQ0VEX1RIUkVB RElORz15CkNPTkZJR19TUEFSU0VfSVJRPXkKIyBDT05GSUdfR0VORVJJQ19JUlFfREVCVUdG UyBpcyBub3Qgc2V0CiMgZW5kIG9mIElSUSBzdWJzeXN0ZW0KCkNPTkZJR19DTE9DS1NPVVJD RV9XQVRDSERPRz15CkNPTkZJR19BUkNIX0NMT0NLU09VUkNFX0lOSVQ9eQpDT05GSUdfQ0xP Q0tTT1VSQ0VfVkFMSURBVEVfTEFTVF9DWUNMRT15CkNPTkZJR19HRU5FUklDX1RJTUVfVlNZ U0NBTEw9eQpDT05GSUdfR0VORVJJQ19DTE9DS0VWRU5UUz15CkNPTkZJR19HRU5FUklDX0NM T0NLRVZFTlRTX0JST0FEQ0FTVD15CkNPTkZJR19HRU5FUklDX0NMT0NLRVZFTlRTX01JTl9B REpVU1Q9eQpDT05GSUdfR0VORVJJQ19DTU9TX1VQREFURT15CkNPTkZJR19IQVZFX1BPU0lY X0NQVV9USU1FUlNfVEFTS19XT1JLPXkKQ09ORklHX1BPU0lYX0NQVV9USU1FUlNfVEFTS19X T1JLPXkKCiMKIyBUaW1lcnMgc3Vic3lzdGVtCiMKQ09ORklHX1RJQ0tfT05FU0hPVD15CkNP TkZJR19OT19IWl9DT01NT049eQojIENPTkZJR19IWl9QRVJJT0RJQyBpcyBub3Qgc2V0CkNP TkZJR19OT19IWl9JRExFPXkKIyBDT05GSUdfTk9fSFpfRlVMTCBpcyBub3Qgc2V0CkNPTkZJ R19OT19IWj15CkNPTkZJR19ISUdIX1JFU19USU1FUlM9eQojIGVuZCBvZiBUaW1lcnMgc3Vi c3lzdGVtCgojIENPTkZJR19QUkVFTVBUX05PTkUgaXMgbm90IHNldAojIENPTkZJR19QUkVF TVBUX1ZPTFVOVEFSWSBpcyBub3Qgc2V0CkNPTkZJR19QUkVFTVBUPXkKQ09ORklHX1BSRUVN UFRfQ09VTlQ9eQpDT05GSUdfUFJFRU1QVElPTj15CkNPTkZJR19QUkVFTVBUX0RZTkFNSUM9 eQoKIwojIENQVS9UYXNrIHRpbWUgYW5kIHN0YXRzIGFjY291bnRpbmcKIwpDT05GSUdfVElD S19DUFVfQUNDT1VOVElORz15CiMgQ09ORklHX1ZJUlRfQ1BVX0FDQ09VTlRJTkdfR0VOIGlz IG5vdCBzZXQKQ09ORklHX0lSUV9USU1FX0FDQ09VTlRJTkc9eQpDT05GSUdfSEFWRV9TQ0hF RF9BVkdfSVJRPXkKQ09ORklHX0JTRF9QUk9DRVNTX0FDQ1Q9eQpDT05GSUdfQlNEX1BST0NF U1NfQUNDVF9WMz15CkNPTkZJR19UQVNLU1RBVFM9eQpDT05GSUdfVEFTS19ERUxBWV9BQ0NU PXkKQ09ORklHX1RBU0tfWEFDQ1Q9eQpDT05GSUdfVEFTS19JT19BQ0NPVU5USU5HPXkKQ09O RklHX1BTST15CiMgQ09ORklHX1BTSV9ERUZBVUxUX0RJU0FCTEVEIGlzIG5vdCBzZXQKIyBl bmQgb2YgQ1BVL1Rhc2sgdGltZSBhbmQgc3RhdHMgYWNjb3VudGluZwoKQ09ORklHX0NQVV9J U09MQVRJT049eQoKIwojIFJDVSBTdWJzeXN0ZW0KIwpDT05GSUdfVFJFRV9SQ1U9eQpDT05G SUdfUFJFRU1QVF9SQ1U9eQpDT05GSUdfUkNVX0VYUEVSVD15CkNPTkZJR19TUkNVPXkKQ09O RklHX1RSRUVfU1JDVT15CkNPTkZJR19UQVNLU19SQ1VfR0VORVJJQz15CkNPTkZJR19UQVNL U19SQ1U9eQpDT05GSUdfVEFTS1NfUlVERV9SQ1U9eQpDT05GSUdfVEFTS1NfVFJBQ0VfUkNV PXkKQ09ORklHX1JDVV9TVEFMTF9DT01NT049eQpDT05GSUdfUkNVX05FRURfU0VHQ0JMSVNU PXkKQ09ORklHX1JDVV9GQU5PVVQ9NjQKQ09ORklHX1JDVV9GQU5PVVRfTEVBRj0xNgpDT05G SUdfUkNVX0ZBU1RfTk9fSFo9eQpDT05GSUdfUkNVX0JPT1NUPXkKQ09ORklHX1JDVV9CT09T VF9ERUxBWT01MDAKIyBDT05GSUdfUkNVX05PQ0JfQ1BVIGlzIG5vdCBzZXQKIyBDT05GSUdf VEFTS1NfVFJBQ0VfUkNVX1JFQURfTUIgaXMgbm90IHNldAojIGVuZCBvZiBSQ1UgU3Vic3lz dGVtCgpDT05GSUdfQlVJTERfQklOMkM9eQpDT05GSUdfSUtDT05GSUc9eQpDT05GSUdfSUtD T05GSUdfUFJPQz15CkNPTkZJR19JS0hFQURFUlM9bQpDT05GSUdfTE9HX0JVRl9TSElGVD0x NwpDT05GSUdfTE9HX0NQVV9NQVhfQlVGX1NISUZUPTEyCkNPTkZJR19QUklOVEtfU0FGRV9M T0dfQlVGX1NISUZUPTEzCkNPTkZJR19IQVZFX1VOU1RBQkxFX1NDSEVEX0NMT0NLPXkKCiMK IyBTY2hlZHVsZXIgZmVhdHVyZXMKIwpDT05GSUdfVUNMQU1QX1RBU0s9eQpDT05GSUdfVUNM QU1QX0JVQ0tFVFNfQ09VTlQ9NQojIGVuZCBvZiBTY2hlZHVsZXIgZmVhdHVyZXMKCkNPTkZJ R19BUkNIX1NVUFBPUlRTX05VTUFfQkFMQU5DSU5HPXkKQ09ORklHX0FSQ0hfV0FOVF9CQVRD SEVEX1VOTUFQX1RMQl9GTFVTSD15CkNPTkZJR19DQ19IQVNfSU5UMTI4PXkKQ09ORklHX0FS Q0hfU1VQUE9SVFNfSU5UMTI4PXkKQ09ORklHX05VTUFfQkFMQU5DSU5HPXkKQ09ORklHX05V TUFfQkFMQU5DSU5HX0RFRkFVTFRfRU5BQkxFRD15CkNPTkZJR19DR1JPVVBTPXkKQ09ORklH X1BBR0VfQ09VTlRFUj15CkNPTkZJR19NRU1DRz15CkNPTkZJR19NRU1DR19TV0FQPXkKQ09O RklHX01FTUNHX0tNRU09eQpDT05GSUdfQkxLX0NHUk9VUD15CkNPTkZJR19DR1JPVVBfV1JJ VEVCQUNLPXkKQ09ORklHX0NHUk9VUF9TQ0hFRD15CkNPTkZJR19GQUlSX0dST1VQX1NDSEVE PXkKQ09ORklHX0NGU19CQU5EV0lEVEg9eQojIENPTkZJR19SVF9HUk9VUF9TQ0hFRCBpcyBu b3Qgc2V0CkNPTkZJR19VQ0xBTVBfVEFTS19HUk9VUD15CkNPTkZJR19DR1JPVVBfUElEUz15 CkNPTkZJR19DR1JPVVBfUkRNQT15CkNPTkZJR19DR1JPVVBfRlJFRVpFUj15CkNPTkZJR19D R1JPVVBfSFVHRVRMQj15CkNPTkZJR19DUFVTRVRTPXkKQ09ORklHX1BST0NfUElEX0NQVVNF VD15CkNPTkZJR19DR1JPVVBfREVWSUNFPXkKQ09ORklHX0NHUk9VUF9DUFVBQ0NUPXkKQ09O RklHX0NHUk9VUF9QRVJGPXkKQ09ORklHX0NHUk9VUF9CUEY9eQojIENPTkZJR19DR1JPVVBf REVCVUcgaXMgbm90IHNldApDT05GSUdfU09DS19DR1JPVVBfREFUQT15CkNPTkZJR19OQU1F U1BBQ0VTPXkKQ09ORklHX1VUU19OUz15CkNPTkZJR19USU1FX05TPXkKQ09ORklHX0lQQ19O Uz15CkNPTkZJR19VU0VSX05TPXkKQ09ORklHX1BJRF9OUz15CkNPTkZJR19ORVRfTlM9eQpD T05GSUdfQ0hFQ0tQT0lOVF9SRVNUT1JFPXkKQ09ORklHX1NDSEVEX0FVVE9HUk9VUD15CiMg Q09ORklHX1NZU0ZTX0RFUFJFQ0FURUQgaXMgbm90IHNldApDT05GSUdfUkVMQVk9eQpDT05G SUdfQkxLX0RFVl9JTklUUkQ9eQpDT05GSUdfSU5JVFJBTUZTX1NPVVJDRT0iIgpDT05GSUdf UkRfR1pJUD15CkNPTkZJR19SRF9CWklQMj15CkNPTkZJR19SRF9MWk1BPXkKQ09ORklHX1JE X1haPXkKQ09ORklHX1JEX0xaTz15CkNPTkZJR19SRF9MWjQ9eQpDT05GSUdfUkRfWlNURD15 CkNPTkZJR19CT09UX0NPTkZJRz15CkNPTkZJR19DQ19PUFRJTUlaRV9GT1JfUEVSRk9STUFO Q0U9eQojIENPTkZJR19DQ19PUFRJTUlaRV9GT1JfU0laRSBpcyBub3Qgc2V0CkNPTkZJR19M RF9PUlBIQU5fV0FSTj15CkNPTkZJR19TWVNDVEw9eQpDT05GSUdfSEFWRV9VSUQxNj15CkNP TkZJR19TWVNDVExfRVhDRVBUSU9OX1RSQUNFPXkKQ09ORklHX0hBVkVfUENTUEtSX1BMQVRG T1JNPXkKQ09ORklHX0JQRj15CiMgQ09ORklHX0VYUEVSVCBpcyBub3Qgc2V0CkNPTkZJR19V SUQxNj15CkNPTkZJR19NVUxUSVVTRVI9eQpDT05GSUdfU0dFVE1BU0tfU1lTQ0FMTD15CkNP TkZJR19TWVNGU19TWVNDQUxMPXkKQ09ORklHX0ZIQU5ETEU9eQpDT05GSUdfUE9TSVhfVElN RVJTPXkKQ09ORklHX1BSSU5USz15CkNPTkZJR19QUklOVEtfTk1JPXkKQ09ORklHX0JVRz15 CkNPTkZJR19FTEZfQ09SRT15CkNPTkZJR19QQ1NQS1JfUExBVEZPUk09eQpDT05GSUdfQkFT RV9GVUxMPXkKQ09ORklHX0ZVVEVYPXkKQ09ORklHX0ZVVEVYX1BJPXkKQ09ORklHX0VQT0xM PXkKQ09ORklHX1NJR05BTEZEPXkKQ09ORklHX1RJTUVSRkQ9eQpDT05GSUdfRVZFTlRGRD15 CkNPTkZJR19TSE1FTT15CkNPTkZJR19BSU89eQpDT05GSUdfSU9fVVJJTkc9eQpDT05GSUdf QURWSVNFX1NZU0NBTExTPXkKQ09ORklHX0hBVkVfQVJDSF9VU0VSRkFVTFRGRF9XUD15CkNP TkZJR19NRU1CQVJSSUVSPXkKQ09ORklHX0tBTExTWU1TPXkKQ09ORklHX0tBTExTWU1TX0FM TD15CkNPTkZJR19LQUxMU1lNU19BQlNPTFVURV9QRVJDUFU9eQpDT05GSUdfS0FMTFNZTVNf QkFTRV9SRUxBVElWRT15CkNPTkZJR19CUEZfTFNNPXkKQ09ORklHX0JQRl9TWVNDQUxMPXkK Q09ORklHX0FSQ0hfV0FOVF9ERUZBVUxUX0JQRl9KSVQ9eQpDT05GSUdfQlBGX0pJVF9BTFdB WVNfT049eQpDT05GSUdfQlBGX0pJVF9ERUZBVUxUX09OPXkKQ09ORklHX1VTRVJNT0RFX0RS SVZFUj15CkNPTkZJR19CUEZfUFJFTE9BRD15CkNPTkZJR19CUEZfUFJFTE9BRF9VTUQ9bQpD T05GSUdfVVNFUkZBVUxURkQ9eQpDT05GSUdfQVJDSF9IQVNfTUVNQkFSUklFUl9TWU5DX0NP UkU9eQpDT05GSUdfS0NNUD15CkNPTkZJR19SU0VRPXkKIyBDT05GSUdfRU1CRURERUQgaXMg bm90IHNldApDT05GSUdfSEFWRV9QRVJGX0VWRU5UUz15CgojCiMgS2VybmVsIFBlcmZvcm1h bmNlIEV2ZW50cyBBbmQgQ291bnRlcnMKIwpDT05GSUdfUEVSRl9FVkVOVFM9eQojIENPTkZJ R19ERUJVR19QRVJGX1VTRV9WTUFMTE9DIGlzIG5vdCBzZXQKIyBlbmQgb2YgS2VybmVsIFBl cmZvcm1hbmNlIEV2ZW50cyBBbmQgQ291bnRlcnMKCkNPTkZJR19WTV9FVkVOVF9DT1VOVEVS Uz15CkNPTkZJR19TTFVCX0RFQlVHPXkKIyBDT05GSUdfQ09NUEFUX0JSSyBpcyBub3Qgc2V0 CiMgQ09ORklHX1NMQUIgaXMgbm90IHNldApDT05GSUdfU0xVQj15CkNPTkZJR19TTEFCX01F UkdFX0RFRkFVTFQ9eQpDT05GSUdfU0xBQl9GUkVFTElTVF9SQU5ET009eQpDT05GSUdfU0xB Ql9GUkVFTElTVF9IQVJERU5FRD15CkNPTkZJR19TSFVGRkxFX1BBR0VfQUxMT0NBVE9SPXkK Q09ORklHX1NMVUJfQ1BVX1BBUlRJQUw9eQpDT05GSUdfU1lTVEVNX0RBVEFfVkVSSUZJQ0FU SU9OPXkKQ09ORklHX1BST0ZJTElORz15CkNPTkZJR19UUkFDRVBPSU5UUz15CiMgZW5kIG9m IEdlbmVyYWwgc2V0dXAKCkNPTkZJR182NEJJVD15CkNPTkZJR19YODZfNjQ9eQpDT05GSUdf WDg2PXkKQ09ORklHX0lOU1RSVUNUSU9OX0RFQ09ERVI9eQpDT05GSUdfT1VUUFVUX0ZPUk1B VD0iZWxmNjQteDg2LTY0IgpDT05GSUdfTE9DS0RFUF9TVVBQT1JUPXkKQ09ORklHX1NUQUNL VFJBQ0VfU1VQUE9SVD15CkNPTkZJR19NTVU9eQpDT05GSUdfQVJDSF9NTUFQX1JORF9CSVRT X01JTj0yOApDT05GSUdfQVJDSF9NTUFQX1JORF9CSVRTX01BWD0zMgpDT05GSUdfQVJDSF9N TUFQX1JORF9DT01QQVRfQklUU19NSU49OApDT05GSUdfQVJDSF9NTUFQX1JORF9DT01QQVRf QklUU19NQVg9MTYKQ09ORklHX0dFTkVSSUNfSVNBX0RNQT15CkNPTkZJR19HRU5FUklDX0JV Rz15CkNPTkZJR19HRU5FUklDX0JVR19SRUxBVElWRV9QT0lOVEVSUz15CkNPTkZJR19BUkNI X01BWV9IQVZFX1BDX0ZEQz15CkNPTkZJR19HRU5FUklDX0NBTElCUkFURV9ERUxBWT15CkNP TkZJR19BUkNIX0hBU19DUFVfUkVMQVg9eQpDT05GSUdfQVJDSF9IQVNfQ0FDSEVfTElORV9T SVpFPXkKQ09ORklHX0FSQ0hfSEFTX0ZJTFRFUl9QR1BST1Q9eQpDT05GSUdfSEFWRV9TRVRV UF9QRVJfQ1BVX0FSRUE9eQpDT05GSUdfTkVFRF9QRVJfQ1BVX0VNQkVEX0ZJUlNUX0NIVU5L PXkKQ09ORklHX05FRURfUEVSX0NQVV9QQUdFX0ZJUlNUX0NIVU5LPXkKQ09ORklHX0FSQ0hf SElCRVJOQVRJT05fUE9TU0lCTEU9eQpDT05GSUdfQVJDSF9TVVNQRU5EX1BPU1NJQkxFPXkK Q09ORklHX0FSQ0hfV0FOVF9HRU5FUkFMX0hVR0VUTEI9eQpDT05GSUdfWk9ORV9ETUEzMj15 CkNPTkZJR19BVURJVF9BUkNIPXkKQ09ORklHX0hBVkVfSU5URUxfVFhUPXkKQ09ORklHX1g4 Nl82NF9TTVA9eQpDT05GSUdfQVJDSF9TVVBQT1JUU19VUFJPQkVTPXkKQ09ORklHX0ZJWF9F QVJMWUNPTl9NRU09eQpDT05GSUdfRFlOQU1JQ19QSFlTSUNBTF9NQVNLPXkKQ09ORklHX1BH VEFCTEVfTEVWRUxTPTUKQ09ORklHX0NDX0hBU19TQU5FX1NUQUNLUFJPVEVDVE9SPXkKCiMK IyBQcm9jZXNzb3IgdHlwZSBhbmQgZmVhdHVyZXMKIwpDT05GSUdfWk9ORV9ETUE9eQpDT05G SUdfU01QPXkKQ09ORklHX1g4Nl9GRUFUVVJFX05BTUVTPXkKQ09ORklHX1g4Nl9YMkFQSUM9 eQpDT05GSUdfWDg2X01QUEFSU0U9eQojIENPTkZJR19HT0xERklTSCBpcyBub3Qgc2V0CkNP TkZJR19SRVRQT0xJTkU9eQpDT05GSUdfWDg2X0NQVV9SRVNDVFJMPXkKIyBDT05GSUdfWDg2 X0VYVEVOREVEX1BMQVRGT1JNIGlzIG5vdCBzZXQKQ09ORklHX1g4Nl9JTlRFTF9MUFNTPXkK Q09ORklHX1g4Nl9BTURfUExBVEZPUk1fREVWSUNFPXkKQ09ORklHX0lPU0ZfTUJJPXkKIyBD T05GSUdfSU9TRl9NQklfREVCVUcgaXMgbm90IHNldApDT05GSUdfWDg2X1NVUFBPUlRTX01F TU9SWV9GQUlMVVJFPXkKQ09ORklHX1NDSEVEX09NSVRfRlJBTUVfUE9JTlRFUj15CkNPTkZJ R19IWVBFUlZJU09SX0dVRVNUPXkKQ09ORklHX1BBUkFWSVJUPXkKQ09ORklHX1BBUkFWSVJU X1hYTD15CiMgQ09ORklHX1BBUkFWSVJUX0RFQlVHIGlzIG5vdCBzZXQKQ09ORklHX1BBUkFW SVJUX1NQSU5MT0NLUz15CkNPTkZJR19YODZfSFZfQ0FMTEJBQ0tfVkVDVE9SPXkKQ09ORklH X1hFTj15CkNPTkZJR19YRU5fUFY9eQpDT05GSUdfWEVOXzUxMkdCPXkKQ09ORklHX1hFTl9Q Vl9TTVA9eQpDT05GSUdfWEVOX0RPTTA9eQpDT05GSUdfWEVOX1BWSFZNPXkKQ09ORklHX1hF Tl9QVkhWTV9TTVA9eQpDT05GSUdfWEVOX1BWSFZNX0dVRVNUPXkKQ09ORklHX1hFTl9TQVZF X1JFU1RPUkU9eQojIENPTkZJR19YRU5fREVCVUdfRlMgaXMgbm90IHNldApDT05GSUdfWEVO X1BWSD15CkNPTkZJR19LVk1fR1VFU1Q9eQpDT05GSUdfQVJDSF9DUFVJRExFX0hBTFRQT0xM PXkKQ09ORklHX1BWSD15CkNPTkZJR19QQVJBVklSVF9USU1FX0FDQ09VTlRJTkc9eQpDT05G SUdfUEFSQVZJUlRfQ0xPQ0s9eQpDT05GSUdfSkFJTEhPVVNFX0dVRVNUPXkKQ09ORklHX0FD Uk5fR1VFU1Q9eQojIENPTkZJR19NSzggaXMgbm90IHNldAojIENPTkZJR19NUFNDIGlzIG5v dCBzZXQKIyBDT05GSUdfTUNPUkUyIGlzIG5vdCBzZXQKIyBDT05GSUdfTUFUT00gaXMgbm90 IHNldApDT05GSUdfR0VORVJJQ19DUFU9eQpDT05GSUdfWDg2X0lOVEVSTk9ERV9DQUNIRV9T SElGVD02CkNPTkZJR19YODZfTDFfQ0FDSEVfU0hJRlQ9NgpDT05GSUdfWDg2X1RTQz15CkNP TkZJR19YODZfQ01QWENIRzY0PXkKQ09ORklHX1g4Nl9DTU9WPXkKQ09ORklHX1g4Nl9NSU5J TVVNX0NQVV9GQU1JTFk9NjQKQ09ORklHX1g4Nl9ERUJVR0NUTE1TUj15CkNPTkZJR19JQTMy X0ZFQVRfQ1RMPXkKQ09ORklHX1g4Nl9WTVhfRkVBVFVSRV9OQU1FUz15CkNPTkZJR19DUFVf U1VQX0lOVEVMPXkKQ09ORklHX0NQVV9TVVBfQU1EPXkKQ09ORklHX0NQVV9TVVBfSFlHT049 eQpDT05GSUdfQ1BVX1NVUF9DRU5UQVVSPXkKQ09ORklHX0NQVV9TVVBfWkhBT1hJTj15CkNP TkZJR19IUEVUX1RJTUVSPXkKQ09ORklHX0hQRVRfRU1VTEFURV9SVEM9eQpDT05GSUdfRE1J PXkKIyBDT05GSUdfR0FSVF9JT01NVSBpcyBub3Qgc2V0CiMgQ09ORklHX01BWFNNUCBpcyBu b3Qgc2V0CkNPTkZJR19OUl9DUFVTX1JBTkdFX0JFR0lOPTIKQ09ORklHX05SX0NQVVNfUkFO R0VfRU5EPTUxMgpDT05GSUdfTlJfQ1BVU19ERUZBVUxUPTY0CkNPTkZJR19OUl9DUFVTPTMy MApDT05GSUdfU0NIRURfU01UPXkKQ09ORklHX1NDSEVEX01DPXkKQ09ORklHX1NDSEVEX01D X1BSSU89eQpDT05GSUdfWDg2X0xPQ0FMX0FQSUM9eQpDT05GSUdfWDg2X0lPX0FQSUM9eQpD T05GSUdfWDg2X1JFUk9VVEVfRk9SX0JST0tFTl9CT09UX0lSUVM9eQpDT05GSUdfWDg2X01D RT15CiMgQ09ORklHX1g4Nl9NQ0VMT0dfTEVHQUNZIGlzIG5vdCBzZXQKQ09ORklHX1g4Nl9N Q0VfSU5URUw9eQpDT05GSUdfWDg2X01DRV9BTUQ9eQpDT05GSUdfWDg2X01DRV9USFJFU0hP TEQ9eQpDT05GSUdfWDg2X01DRV9JTkpFQ1Q9bQoKIwojIFBlcmZvcm1hbmNlIG1vbml0b3Jp bmcKIwpDT05GSUdfUEVSRl9FVkVOVFNfSU5URUxfVU5DT1JFPW0KQ09ORklHX1BFUkZfRVZF TlRTX0lOVEVMX1JBUEw9bQpDT05GSUdfUEVSRl9FVkVOVFNfSU5URUxfQ1NUQVRFPW0KQ09O RklHX1BFUkZfRVZFTlRTX0FNRF9QT1dFUj1tCiMgZW5kIG9mIFBlcmZvcm1hbmNlIG1vbml0 b3JpbmcKCkNPTkZJR19YODZfMTZCSVQ9eQpDT05GSUdfWDg2X0VTUEZJWDY0PXkKQ09ORklH X1g4Nl9WU1lTQ0FMTF9FTVVMQVRJT049eQpDT05GSUdfWDg2X0lPUExfSU9QRVJNPXkKQ09O RklHX0k4Sz1tCkNPTkZJR19NSUNST0NPREU9eQpDT05GSUdfTUlDUk9DT0RFX0lOVEVMPXkK Q09ORklHX01JQ1JPQ09ERV9BTUQ9eQojIENPTkZJR19NSUNST0NPREVfT0xEX0lOVEVSRkFD RSBpcyBub3Qgc2V0CkNPTkZJR19YODZfTVNSPXkKQ09ORklHX1g4Nl9DUFVJRD15CkNPTkZJ R19YODZfNUxFVkVMPXkKQ09ORklHX1g4Nl9ESVJFQ1RfR0JQQUdFUz15CkNPTkZJR19YODZf Q1BBX1NUQVRJU1RJQ1M9eQpDT05GSUdfQU1EX01FTV9FTkNSWVBUPXkKIyBDT05GSUdfQU1E X01FTV9FTkNSWVBUX0FDVElWRV9CWV9ERUZBVUxUIGlzIG5vdCBzZXQKQ09ORklHX05VTUE9 eQpDT05GSUdfQU1EX05VTUE9eQpDT05GSUdfWDg2XzY0X0FDUElfTlVNQT15CiMgQ09ORklH X05VTUFfRU1VIGlzIG5vdCBzZXQKQ09ORklHX05PREVTX1NISUZUPTUKQ09ORklHX0FSQ0hf U1BBUlNFTUVNX0VOQUJMRT15CkNPTkZJR19BUkNIX1NQQVJTRU1FTV9ERUZBVUxUPXkKQ09O RklHX0FSQ0hfU0VMRUNUX01FTU9SWV9NT0RFTD15CiMgQ09ORklHX0FSQ0hfTUVNT1JZX1BS T0JFIGlzIG5vdCBzZXQKQ09ORklHX0FSQ0hfUFJPQ19LQ09SRV9URVhUPXkKQ09ORklHX0lM TEVHQUxfUE9JTlRFUl9WQUxVRT0weGRlYWQwMDAwMDAwMDAwMDAKQ09ORklHX1g4Nl9QTUVN X0xFR0FDWV9ERVZJQ0U9eQpDT05GSUdfWDg2X1BNRU1fTEVHQUNZPW0KQ09ORklHX1g4Nl9D SEVDS19CSU9TX0NPUlJVUFRJT049eQpDT05GSUdfWDg2X0JPT1RQQVJBTV9NRU1PUllfQ09S UlVQVElPTl9DSEVDSz15CkNPTkZJR19YODZfUkVTRVJWRV9MT1c9NjQKQ09ORklHX01UUlI9 eQpDT05GSUdfTVRSUl9TQU5JVElaRVI9eQpDT05GSUdfTVRSUl9TQU5JVElaRVJfRU5BQkxF X0RFRkFVTFQ9MQpDT05GSUdfTVRSUl9TQU5JVElaRVJfU1BBUkVfUkVHX05SX0RFRkFVTFQ9 MApDT05GSUdfWDg2X1BBVD15CkNPTkZJR19BUkNIX1VTRVNfUEdfVU5DQUNIRUQ9eQpDT05G SUdfQVJDSF9SQU5ET009eQpDT05GSUdfWDg2X1NNQVA9eQpDT05GSUdfWDg2X1VNSVA9eQpD T05GSUdfWDg2X0lOVEVMX01FTU9SWV9QUk9URUNUSU9OX0tFWVM9eQojIENPTkZJR19YODZf SU5URUxfVFNYX01PREVfT0ZGIGlzIG5vdCBzZXQKIyBDT05GSUdfWDg2X0lOVEVMX1RTWF9N T0RFX09OIGlzIG5vdCBzZXQKQ09ORklHX1g4Nl9JTlRFTF9UU1hfTU9ERV9BVVRPPXkKQ09O RklHX1g4Nl9TR1g9eQpDT05GSUdfRUZJPXkKQ09ORklHX0VGSV9TVFVCPXkKQ09ORklHX0VG SV9NSVhFRD15CiMgQ09ORklHX0haXzEwMCBpcyBub3Qgc2V0CiMgQ09ORklHX0haXzI1MCBp cyBub3Qgc2V0CkNPTkZJR19IWl8zMDA9eQojIENPTkZJR19IWl8xMDAwIGlzIG5vdCBzZXQK Q09ORklHX0haPTMwMApDT05GSUdfU0NIRURfSFJUSUNLPXkKQ09ORklHX0tFWEVDPXkKQ09O RklHX0tFWEVDX0ZJTEU9eQpDT05GSUdfQVJDSF9IQVNfS0VYRUNfUFVSR0FUT1JZPXkKIyBD T05GSUdfS0VYRUNfU0lHIGlzIG5vdCBzZXQKQ09ORklHX0NSQVNIX0RVTVA9eQpDT05GSUdf S0VYRUNfSlVNUD15CkNPTkZJR19QSFlTSUNBTF9TVEFSVD0weDEwMDAwMDAKQ09ORklHX1JF TE9DQVRBQkxFPXkKQ09ORklHX1JBTkRPTUlaRV9CQVNFPXkKQ09ORklHX1g4Nl9ORUVEX1JF TE9DUz15CkNPTkZJR19QSFlTSUNBTF9BTElHTj0weDIwMDAwMApDT05GSUdfRFlOQU1JQ19N RU1PUllfTEFZT1VUPXkKQ09ORklHX1JBTkRPTUlaRV9NRU1PUlk9eQpDT05GSUdfUkFORE9N SVpFX01FTU9SWV9QSFlTSUNBTF9QQURESU5HPTB4YQpDT05GSUdfSE9UUExVR19DUFU9eQoj IENPTkZJR19CT09UUEFSQU1fSE9UUExVR19DUFUwIGlzIG5vdCBzZXQKIyBDT05GSUdfREVC VUdfSE9UUExVR19DUFUwIGlzIG5vdCBzZXQKIyBDT05GSUdfQ09NUEFUX1ZEU08gaXMgbm90 IHNldAojIENPTkZJR19MRUdBQ1lfVlNZU0NBTExfRU1VTEFURSBpcyBub3Qgc2V0CkNPTkZJ R19MRUdBQ1lfVlNZU0NBTExfWE9OTFk9eQojIENPTkZJR19MRUdBQ1lfVlNZU0NBTExfTk9O RSBpcyBub3Qgc2V0CiMgQ09ORklHX0NNRExJTkVfQk9PTCBpcyBub3Qgc2V0CkNPTkZJR19N T0RJRllfTERUX1NZU0NBTEw9eQpDT05GSUdfSEFWRV9MSVZFUEFUQ0g9eQojIENPTkZJR19M SVZFUEFUQ0ggaXMgbm90IHNldAojIGVuZCBvZiBQcm9jZXNzb3IgdHlwZSBhbmQgZmVhdHVy ZXMKCkNPTkZJR19BUkNIX0hBU19BRERfUEFHRVM9eQpDT05GSUdfQVJDSF9FTkFCTEVfTUVN T1JZX0hPVFBMVUc9eQpDT05GSUdfQVJDSF9FTkFCTEVfTUVNT1JZX0hPVFJFTU9WRT15CkNP TkZJR19VU0VfUEVSQ1BVX05VTUFfTk9ERV9JRD15CkNPTkZJR19BUkNIX0VOQUJMRV9TUExJ VF9QTURfUFRMT0NLPXkKQ09ORklHX0FSQ0hfRU5BQkxFX0hVR0VQQUdFX01JR1JBVElPTj15 CkNPTkZJR19BUkNIX0VOQUJMRV9USFBfTUlHUkFUSU9OPXkKCiMKIyBQb3dlciBtYW5hZ2Vt ZW50IGFuZCBBQ1BJIG9wdGlvbnMKIwpDT05GSUdfQVJDSF9ISUJFUk5BVElPTl9IRUFERVI9 eQpDT05GSUdfU1VTUEVORD15CkNPTkZJR19TVVNQRU5EX0ZSRUVaRVI9eQpDT05GSUdfSElC RVJOQVRFX0NBTExCQUNLUz15CkNPTkZJR19ISUJFUk5BVElPTj15CkNPTkZJR19ISUJFUk5B VElPTl9TTkFQU0hPVF9ERVY9eQpDT05GSUdfUE1fU1REX1BBUlRJVElPTj0iIgpDT05GSUdf UE1fU0xFRVA9eQpDT05GSUdfUE1fU0xFRVBfU01QPXkKIyBDT05GSUdfUE1fQVVUT1NMRUVQ IGlzIG5vdCBzZXQKIyBDT05GSUdfUE1fV0FLRUxPQ0tTIGlzIG5vdCBzZXQKQ09ORklHX1BN PXkKQ09ORklHX1BNX0RFQlVHPXkKIyBDT05GSUdfUE1fQURWQU5DRURfREVCVUcgaXMgbm90 IHNldAojIENPTkZJR19QTV9URVNUX1NVU1BFTkQgaXMgbm90IHNldApDT05GSUdfUE1fU0xF RVBfREVCVUc9eQpDT05GSUdfUE1fVFJBQ0U9eQpDT05GSUdfUE1fVFJBQ0VfUlRDPXkKQ09O RklHX1BNX0NMSz15CkNPTkZJR19QTV9HRU5FUklDX0RPTUFJTlM9eQpDT05GSUdfV1FfUE9X RVJfRUZGSUNJRU5UX0RFRkFVTFQ9eQpDT05GSUdfUE1fR0VORVJJQ19ET01BSU5TX1NMRUVQ PXkKQ09ORklHX0VORVJHWV9NT0RFTD15CkNPTkZJR19BUkNIX1NVUFBPUlRTX0FDUEk9eQpD T05GSUdfQUNQST15CkNPTkZJR19BQ1BJX0xFR0FDWV9UQUJMRVNfTE9PS1VQPXkKQ09ORklH X0FSQ0hfTUlHSFRfSEFWRV9BQ1BJX1BEQz15CkNPTkZJR19BQ1BJX1NZU1RFTV9QT1dFUl9T VEFURVNfU1VQUE9SVD15CiMgQ09ORklHX0FDUElfREVCVUdHRVIgaXMgbm90IHNldApDT05G SUdfQUNQSV9TUENSX1RBQkxFPXkKQ09ORklHX0FDUElfRlBEVD15CkNPTkZJR19BQ1BJX0xQ SVQ9eQpDT05GSUdfQUNQSV9TTEVFUD15CkNPTkZJR19BQ1BJX1JFVl9PVkVSUklERV9QT1NT SUJMRT15CkNPTkZJR19BQ1BJX0VDX0RFQlVHRlM9bQpDT05GSUdfQUNQSV9BQz15CkNPTkZJ R19BQ1BJX0JBVFRFUlk9eQpDT05GSUdfQUNQSV9CVVRUT049eQpDT05GSUdfQUNQSV9WSURF Tz1tCkNPTkZJR19BQ1BJX0ZBTj15CkNPTkZJR19BQ1BJX1RBRD1tCkNPTkZJR19BQ1BJX0RP Q0s9eQpDT05GSUdfQUNQSV9DUFVfRlJFUV9QU1M9eQpDT05GSUdfQUNQSV9QUk9DRVNTT1Jf Q1NUQVRFPXkKQ09ORklHX0FDUElfUFJPQ0VTU09SX0lETEU9eQpDT05GSUdfQUNQSV9DUFBD X0xJQj15CkNPTkZJR19BQ1BJX1BST0NFU1NPUj15CkNPTkZJR19BQ1BJX0lQTUk9bQpDT05G SUdfQUNQSV9IT1RQTFVHX0NQVT15CkNPTkZJR19BQ1BJX1BST0NFU1NPUl9BR0dSRUdBVE9S PW0KQ09ORklHX0FDUElfVEhFUk1BTD15CkNPTkZJR19BQ1BJX1BMQVRGT1JNX1BST0ZJTEU9 bQpDT05GSUdfQVJDSF9IQVNfQUNQSV9UQUJMRV9VUEdSQURFPXkKQ09ORklHX0FDUElfVEFC TEVfVVBHUkFERT15CkNPTkZJR19BQ1BJX0RFQlVHPXkKQ09ORklHX0FDUElfUENJX1NMT1Q9 eQpDT05GSUdfQUNQSV9DT05UQUlORVI9eQpDT05GSUdfQUNQSV9IT1RQTFVHX01FTU9SWT15 CkNPTkZJR19BQ1BJX0hPVFBMVUdfSU9BUElDPXkKQ09ORklHX0FDUElfU0JTPW0KQ09ORklH X0FDUElfSEVEPXkKQ09ORklHX0FDUElfQ1VTVE9NX01FVEhPRD1tCkNPTkZJR19BQ1BJX0JH UlQ9eQpDT05GSUdfQUNQSV9ORklUPW0KIyBDT05GSUdfTkZJVF9TRUNVUklUWV9ERUJVRyBp cyBub3Qgc2V0CkNPTkZJR19BQ1BJX05VTUE9eQpDT05GSUdfQUNQSV9ITUFUPXkKQ09ORklH X0hBVkVfQUNQSV9BUEVJPXkKQ09ORklHX0hBVkVfQUNQSV9BUEVJX05NST15CkNPTkZJR19B Q1BJX0FQRUk9eQpDT05GSUdfQUNQSV9BUEVJX0dIRVM9eQpDT05GSUdfQUNQSV9BUEVJX1BD SUVBRVI9eQpDT05GSUdfQUNQSV9BUEVJX01FTU9SWV9GQUlMVVJFPXkKQ09ORklHX0FDUElf QVBFSV9FSU5KPW0KQ09ORklHX0FDUElfQVBFSV9FUlNUX0RFQlVHPW0KQ09ORklHX0FDUElf RFBURj15CkNPTkZJR19EUFRGX1BPV0VSPW0KQ09ORklHX0RQVEZfUENIX0ZJVlI9bQpDT05G SUdfQUNQSV9XQVRDSERPRz15CkNPTkZJR19BQ1BJX0VYVExPRz1tCkNPTkZJR19BQ1BJX0FE WEw9eQpDT05GSUdfQUNQSV9DT05GSUdGUz1tCkNPTkZJR19QTUlDX09QUkVHSU9OPXkKQ09O RklHX0JZVENSQ19QTUlDX09QUkVHSU9OPXkKQ09ORklHX0NIVENSQ19QTUlDX09QUkVHSU9O PXkKQ09ORklHX1hQT1dFUl9QTUlDX09QUkVHSU9OPXkKQ09ORklHX0JYVF9XQ19QTUlDX09Q UkVHSU9OPXkKQ09ORklHX0NIVF9XQ19QTUlDX09QUkVHSU9OPXkKQ09ORklHX0NIVF9EQ19U SV9QTUlDX09QUkVHSU9OPXkKQ09ORklHX1RQUzY4NDcwX1BNSUNfT1BSRUdJT049eQpDT05G SUdfWDg2X1BNX1RJTUVSPXkKCiMKIyBDUFUgRnJlcXVlbmN5IHNjYWxpbmcKIwpDT05GSUdf Q1BVX0ZSRVE9eQpDT05GSUdfQ1BVX0ZSRVFfR09WX0FUVFJfU0VUPXkKQ09ORklHX0NQVV9G UkVRX0dPVl9DT01NT049eQpDT05GSUdfQ1BVX0ZSRVFfU1RBVD15CiMgQ09ORklHX0NQVV9G UkVRX0RFRkFVTFRfR09WX1BFUkZPUk1BTkNFIGlzIG5vdCBzZXQKIyBDT05GSUdfQ1BVX0ZS RVFfREVGQVVMVF9HT1ZfUE9XRVJTQVZFIGlzIG5vdCBzZXQKIyBDT05GSUdfQ1BVX0ZSRVFf REVGQVVMVF9HT1ZfVVNFUlNQQUNFIGlzIG5vdCBzZXQKQ09ORklHX0NQVV9GUkVRX0RFRkFV TFRfR09WX1NDSEVEVVRJTD15CkNPTkZJR19DUFVfRlJFUV9HT1ZfUEVSRk9STUFOQ0U9eQpD T05GSUdfQ1BVX0ZSRVFfR09WX1BPV0VSU0FWRT15CkNPTkZJR19DUFVfRlJFUV9HT1ZfVVNF UlNQQUNFPXkKQ09ORklHX0NQVV9GUkVRX0dPVl9PTkRFTUFORD15CkNPTkZJR19DUFVfRlJF UV9HT1ZfQ09OU0VSVkFUSVZFPXkKQ09ORklHX0NQVV9GUkVRX0dPVl9TQ0hFRFVUSUw9eQoK IwojIENQVSBmcmVxdWVuY3kgc2NhbGluZyBkcml2ZXJzCiMKQ09ORklHX1g4Nl9JTlRFTF9Q U1RBVEU9eQpDT05GSUdfWDg2X1BDQ19DUFVGUkVRPW0KQ09ORklHX1g4Nl9BQ1BJX0NQVUZS RVE9bQpDT05GSUdfWDg2X0FDUElfQ1BVRlJFUV9DUEI9eQpDT05GSUdfWDg2X1BPV0VSTk9X X0s4PW0KQ09ORklHX1g4Nl9BTURfRlJFUV9TRU5TSVRJVklUWT1tCiMgQ09ORklHX1g4Nl9T UEVFRFNURVBfQ0VOVFJJTk8gaXMgbm90IHNldApDT05GSUdfWDg2X1A0X0NMT0NLTU9EPW0K CiMKIyBzaGFyZWQgb3B0aW9ucwojCkNPTkZJR19YODZfU1BFRURTVEVQX0xJQj1tCiMgZW5k IG9mIENQVSBGcmVxdWVuY3kgc2NhbGluZwoKIwojIENQVSBJZGxlCiMKQ09ORklHX0NQVV9J RExFPXkKQ09ORklHX0NQVV9JRExFX0dPVl9MQURERVI9eQpDT05GSUdfQ1BVX0lETEVfR09W X01FTlU9eQpDT05GSUdfQ1BVX0lETEVfR09WX1RFTz15CkNPTkZJR19DUFVfSURMRV9HT1Zf SEFMVFBPTEw9eQpDT05GSUdfSEFMVFBPTExfQ1BVSURMRT1tCiMgZW5kIG9mIENQVSBJZGxl CgpDT05GSUdfSU5URUxfSURMRT15CiMgZW5kIG9mIFBvd2VyIG1hbmFnZW1lbnQgYW5kIEFD UEkgb3B0aW9ucwoKIwojIEJ1cyBvcHRpb25zIChQQ0kgZXRjLikKIwpDT05GSUdfUENJX0RJ UkVDVD15CkNPTkZJR19QQ0lfTU1DT05GSUc9eQpDT05GSUdfUENJX1hFTj15CkNPTkZJR19N TUNPTkZfRkFNMTBIPXkKQ09ORklHX0lTQV9ETUFfQVBJPXkKQ09ORklHX0FNRF9OQj15CiMg Q09ORklHX1g4Nl9TWVNGQiBpcyBub3Qgc2V0CiMgZW5kIG9mIEJ1cyBvcHRpb25zIChQQ0kg ZXRjLikKCiMKIyBCaW5hcnkgRW11bGF0aW9ucwojCkNPTkZJR19JQTMyX0VNVUxBVElPTj15 CiMgQ09ORklHX1g4Nl9YMzIgaXMgbm90IHNldApDT05GSUdfQ09NUEFUXzMyPXkKQ09ORklH X0NPTVBBVD15CkNPTkZJR19DT01QQVRfRk9SX1U2NF9BTElHTk1FTlQ9eQpDT05GSUdfU1lT VklQQ19DT01QQVQ9eQojIGVuZCBvZiBCaW5hcnkgRW11bGF0aW9ucwoKIwojIEZpcm13YXJl IERyaXZlcnMKIwpDT05GSUdfRUREPW0KIyBDT05GSUdfRUREX09GRiBpcyBub3Qgc2V0CkNP TkZJR19GSVJNV0FSRV9NRU1NQVA9eQpDT05GSUdfRE1JSUQ9eQpDT05GSUdfRE1JX1NZU0ZT PXkKQ09ORklHX0RNSV9TQ0FOX01BQ0hJTkVfTk9OX0VGSV9GQUxMQkFDSz15CkNPTkZJR19J U0NTSV9JQkZUX0ZJTkQ9eQpDT05GSUdfSVNDU0lfSUJGVD1tCkNPTkZJR19GV19DRkdfU1lT RlM9bQojIENPTkZJR19GV19DRkdfU1lTRlNfQ01ETElORSBpcyBub3Qgc2V0CkNPTkZJR19H T09HTEVfRklSTVdBUkU9eQojIENPTkZJR19HT09HTEVfU01JIGlzIG5vdCBzZXQKQ09ORklH X0dPT0dMRV9DT1JFQk9PVF9UQUJMRT1tCkNPTkZJR19HT09HTEVfTUVNQ09OU09MRT1tCiMg Q09ORklHX0dPT0dMRV9NRU1DT05TT0xFX1g4Nl9MRUdBQ1kgaXMgbm90IHNldApDT05GSUdf R09PR0xFX0ZSQU1FQlVGRkVSX0NPUkVCT09UPW0KQ09ORklHX0dPT0dMRV9NRU1DT05TT0xF X0NPUkVCT09UPW0KQ09ORklHX0dPT0dMRV9WUEQ9bQoKIwojIEVGSSAoRXh0ZW5zaWJsZSBG aXJtd2FyZSBJbnRlcmZhY2UpIFN1cHBvcnQKIwojIENPTkZJR19FRklfVkFSUyBpcyBub3Qg c2V0CkNPTkZJR19FRklfRVNSVD15CkNPTkZJR19FRklfVkFSU19QU1RPUkU9eQpDT05GSUdf RUZJX1ZBUlNfUFNUT1JFX0RFRkFVTFRfRElTQUJMRT15CkNPTkZJR19FRklfUlVOVElNRV9N QVA9eQojIENPTkZJR19FRklfRkFLRV9NRU1NQVAgaXMgbm90IHNldApDT05GSUdfRUZJX1NP RlRfUkVTRVJWRT15CkNPTkZJR19FRklfUlVOVElNRV9XUkFQUEVSUz15CkNPTkZJR19FRklf R0VORVJJQ19TVFVCX0lOSVRSRF9DTURMSU5FX0xPQURFUj15CkNPTkZJR19FRklfQk9PVExP QURFUl9DT05UUk9MPW0KQ09ORklHX0VGSV9DQVBTVUxFX0xPQURFUj1tCiMgQ09ORklHX0VG SV9URVNUIGlzIG5vdCBzZXQKQ09ORklHX0FQUExFX1BST1BFUlRJRVM9eQojIENPTkZJR19S RVNFVF9BVFRBQ0tfTUlUSUdBVElPTiBpcyBub3Qgc2V0CkNPTkZJR19FRklfUkNJMl9UQUJM RT15CiMgQ09ORklHX0VGSV9ESVNBQkxFX1BDSV9ETUEgaXMgbm90IHNldAojIGVuZCBvZiBF RkkgKEV4dGVuc2libGUgRmlybXdhcmUgSW50ZXJmYWNlKSBTdXBwb3J0CgpDT05GSUdfRUZJ X0VNQkVEREVEX0ZJUk1XQVJFPXkKQ09ORklHX1VFRklfQ1BFUj15CkNPTkZJR19VRUZJX0NQ RVJfWDg2PXkKQ09ORklHX0VGSV9ERVZfUEFUSF9QQVJTRVI9eQpDT05GSUdfRUZJX0VBUkxZ Q09OPXkKQ09ORklHX0VGSV9DVVNUT01fU1NEVF9PVkVSTEFZUz15CgojCiMgVGVncmEgZmly bXdhcmUgZHJpdmVyCiMKIyBlbmQgb2YgVGVncmEgZmlybXdhcmUgZHJpdmVyCiMgZW5kIG9m IEZpcm13YXJlIERyaXZlcnMKCkNPTkZJR19IQVZFX0tWTT15CkNPTkZJR19IQVZFX0tWTV9J UlFDSElQPXkKQ09ORklHX0hBVkVfS1ZNX0lSUUZEPXkKQ09ORklHX0hBVkVfS1ZNX0lSUV9S T1VUSU5HPXkKQ09ORklHX0hBVkVfS1ZNX0VWRU5URkQ9eQpDT05GSUdfS1ZNX01NSU89eQpD T05GSUdfS1ZNX0FTWU5DX1BGPXkKQ09ORklHX0hBVkVfS1ZNX01TST15CkNPTkZJR19IQVZF X0tWTV9DUFVfUkVMQVhfSU5URVJDRVBUPXkKQ09ORklHX0tWTV9WRklPPXkKQ09ORklHX0tW TV9HRU5FUklDX0RJUlRZTE9HX1JFQURfUFJPVEVDVD15CkNPTkZJR19LVk1fQ09NUEFUPXkK Q09ORklHX0hBVkVfS1ZNX0lSUV9CWVBBU1M9eQpDT05GSUdfSEFWRV9LVk1fTk9fUE9MTD15 CkNPTkZJR19LVk1fWEZFUl9UT19HVUVTVF9XT1JLPXkKQ09ORklHX1ZJUlRVQUxJWkFUSU9O PXkKQ09ORklHX0tWTT1tCkNPTkZJR19LVk1fSU5URUw9bQpDT05GSUdfS1ZNX0FNRD1tCkNP TkZJR19LVk1fQU1EX1NFVj15CkNPTkZJR19LVk1fWEVOPXkKQ09ORklHX0tWTV9NTVVfQVVE SVQ9eQpDT05GSUdfQVNfQVZYNTEyPXkKQ09ORklHX0FTX1NIQTFfTkk9eQpDT05GSUdfQVNf U0hBMjU2X05JPXkKQ09ORklHX0FTX1RQQVVTRT15CgojCiMgR2VuZXJhbCBhcmNoaXRlY3R1 cmUtZGVwZW5kZW50IG9wdGlvbnMKIwpDT05GSUdfQ1JBU0hfQ09SRT15CkNPTkZJR19LRVhF Q19DT1JFPXkKQ09ORklHX0hPVFBMVUdfU01UPXkKQ09ORklHX0dFTkVSSUNfRU5UUlk9eQpD T05GSUdfS1BST0JFUz15CkNPTkZJR19KVU1QX0xBQkVMPXkKIyBDT05GSUdfU1RBVElDX0tF WVNfU0VMRlRFU1QgaXMgbm90IHNldAojIENPTkZJR19TVEFUSUNfQ0FMTF9TRUxGVEVTVCBp cyBub3Qgc2V0CkNPTkZJR19PUFRQUk9CRVM9eQpDT05GSUdfS1BST0JFU19PTl9GVFJBQ0U9 eQpDT05GSUdfVVBST0JFUz15CkNPTkZJR19IQVZFX0VGRklDSUVOVF9VTkFMSUdORURfQUND RVNTPXkKQ09ORklHX0FSQ0hfVVNFX0JVSUxUSU5fQlNXQVA9eQpDT05GSUdfS1JFVFBST0JF Uz15CkNPTkZJR19VU0VSX1JFVFVSTl9OT1RJRklFUj15CkNPTkZJR19IQVZFX0lPUkVNQVBf UFJPVD15CkNPTkZJR19IQVZFX0tQUk9CRVM9eQpDT05GSUdfSEFWRV9LUkVUUFJPQkVTPXkK Q09ORklHX0hBVkVfT1BUUFJPQkVTPXkKQ09ORklHX0hBVkVfS1BST0JFU19PTl9GVFJBQ0U9 eQpDT05GSUdfSEFWRV9GVU5DVElPTl9FUlJPUl9JTkpFQ1RJT049eQpDT05GSUdfSEFWRV9O TUk9eQpDT05GSUdfSEFWRV9BUkNIX1RSQUNFSE9PSz15CkNPTkZJR19IQVZFX0RNQV9DT05U SUdVT1VTPXkKQ09ORklHX0dFTkVSSUNfU01QX0lETEVfVEhSRUFEPXkKQ09ORklHX0FSQ0hf SEFTX0ZPUlRJRllfU09VUkNFPXkKQ09ORklHX0FSQ0hfSEFTX1NFVF9NRU1PUlk9eQpDT05G SUdfQVJDSF9IQVNfU0VUX0RJUkVDVF9NQVA9eQpDT05GSUdfSEFWRV9BUkNIX1RIUkVBRF9T VFJVQ1RfV0hJVEVMSVNUPXkKQ09ORklHX0FSQ0hfV0FOVFNfRFlOQU1JQ19UQVNLX1NUUlVD VD15CkNPTkZJR19IQVZFX0FTTV9NT0RWRVJTSU9OUz15CkNPTkZJR19IQVZFX1JFR1NfQU5E X1NUQUNLX0FDQ0VTU19BUEk9eQpDT05GSUdfSEFWRV9SU0VRPXkKQ09ORklHX0hBVkVfRlVO Q1RJT05fQVJHX0FDQ0VTU19BUEk9eQpDT05GSUdfSEFWRV9IV19CUkVBS1BPSU5UPXkKQ09O RklHX0hBVkVfTUlYRURfQlJFQUtQT0lOVFNfUkVHUz15CkNPTkZJR19IQVZFX1VTRVJfUkVU VVJOX05PVElGSUVSPXkKQ09ORklHX0hBVkVfUEVSRl9FVkVOVFNfTk1JPXkKQ09ORklHX0hB VkVfSEFSRExPQ0tVUF9ERVRFQ1RPUl9QRVJGPXkKQ09ORklHX0hBVkVfUEVSRl9SRUdTPXkK Q09ORklHX0hBVkVfUEVSRl9VU0VSX1NUQUNLX0RVTVA9eQpDT05GSUdfSEFWRV9BUkNIX0pV TVBfTEFCRUw9eQpDT05GSUdfSEFWRV9BUkNIX0pVTVBfTEFCRUxfUkVMQVRJVkU9eQpDT05G SUdfTU1VX0dBVEhFUl9UQUJMRV9GUkVFPXkKQ09ORklHX01NVV9HQVRIRVJfUkNVX1RBQkxF X0ZSRUU9eQpDT05GSUdfQVJDSF9IQVZFX05NSV9TQUZFX0NNUFhDSEc9eQpDT05GSUdfSEFW RV9BTElHTkVEX1NUUlVDVF9QQUdFPXkKQ09ORklHX0hBVkVfQ01QWENIR19MT0NBTD15CkNP TkZJR19IQVZFX0NNUFhDSEdfRE9VQkxFPXkKQ09ORklHX0FSQ0hfV0FOVF9DT01QQVRfSVBD X1BBUlNFX1ZFUlNJT049eQpDT05GSUdfQVJDSF9XQU5UX09MRF9DT01QQVRfSVBDPXkKQ09O RklHX0hBVkVfQVJDSF9TRUNDT01QPXkKQ09ORklHX0hBVkVfQVJDSF9TRUNDT01QX0ZJTFRF Uj15CkNPTkZJR19TRUNDT01QPXkKQ09ORklHX1NFQ0NPTVBfRklMVEVSPXkKIyBDT05GSUdf U0VDQ09NUF9DQUNIRV9ERUJVRyBpcyBub3Qgc2V0CkNPTkZJR19IQVZFX0FSQ0hfU1RBQ0tM RUFLPXkKQ09ORklHX0hBVkVfU1RBQ0tQUk9URUNUT1I9eQpDT05GSUdfU1RBQ0tQUk9URUNU T1I9eQpDT05GSUdfU1RBQ0tQUk9URUNUT1JfU1RST05HPXkKQ09ORklHX0FSQ0hfU1VQUE9S VFNfTFRPX0NMQU5HPXkKQ09ORklHX0FSQ0hfU1VQUE9SVFNfTFRPX0NMQU5HX1RISU49eQpD T05GSUdfTFRPX05PTkU9eQpDT05GSUdfSEFWRV9BUkNIX1dJVEhJTl9TVEFDS19GUkFNRVM9 eQpDT05GSUdfSEFWRV9DT05URVhUX1RSQUNLSU5HPXkKQ09ORklHX0hBVkVfQ09OVEVYVF9U UkFDS0lOR19PRkZTVEFDSz15CkNPTkZJR19IQVZFX1ZJUlRfQ1BVX0FDQ09VTlRJTkdfR0VO PXkKQ09ORklHX0hBVkVfSVJRX1RJTUVfQUNDT1VOVElORz15CkNPTkZJR19IQVZFX01PVkVf UFVEPXkKQ09ORklHX0hBVkVfTU9WRV9QTUQ9eQpDT05GSUdfSEFWRV9BUkNIX1RSQU5TUEFS RU5UX0hVR0VQQUdFPXkKQ09ORklHX0hBVkVfQVJDSF9UUkFOU1BBUkVOVF9IVUdFUEFHRV9Q VUQ9eQpDT05GSUdfSEFWRV9BUkNIX0hVR0VfVk1BUD15CkNPTkZJR19BUkNIX1dBTlRfSFVH RV9QTURfU0hBUkU9eQpDT05GSUdfSEFWRV9BUkNIX1NPRlRfRElSVFk9eQpDT05GSUdfSEFW RV9NT0RfQVJDSF9TUEVDSUZJQz15CkNPTkZJR19NT0RVTEVTX1VTRV9FTEZfUkVMQT15CkNP TkZJR19IQVZFX0lSUV9FWElUX09OX0lSUV9TVEFDSz15CkNPTkZJR19IQVZFX1NPRlRJUlFf T05fT1dOX1NUQUNLPXkKQ09ORklHX0FSQ0hfSEFTX0VMRl9SQU5ET01JWkU9eQpDT05GSUdf SEFWRV9BUkNIX01NQVBfUk5EX0JJVFM9eQpDT05GSUdfSEFWRV9FWElUX1RIUkVBRD15CkNP TkZJR19BUkNIX01NQVBfUk5EX0JJVFM9MjgKQ09ORklHX0hBVkVfQVJDSF9NTUFQX1JORF9D T01QQVRfQklUUz15CkNPTkZJR19BUkNIX01NQVBfUk5EX0NPTVBBVF9CSVRTPTgKQ09ORklH X0hBVkVfQVJDSF9DT01QQVRfTU1BUF9CQVNFUz15CkNPTkZJR19IQVZFX1NUQUNLX1ZBTElE QVRJT049eQpDT05GSUdfSEFWRV9SRUxJQUJMRV9TVEFDS1RSQUNFPXkKQ09ORklHX0lTQV9C VVNfQVBJPXkKQ09ORklHX09MRF9TSUdTVVNQRU5EMz15CkNPTkZJR19DT01QQVRfT0xEX1NJ R0FDVElPTj15CkNPTkZJR19DT01QQVRfMzJCSVRfVElNRT15CkNPTkZJR19IQVZFX0FSQ0hf Vk1BUF9TVEFDSz15CkNPTkZJR19WTUFQX1NUQUNLPXkKQ09ORklHX0FSQ0hfSEFTX1NUUklD VF9LRVJORUxfUldYPXkKQ09ORklHX1NUUklDVF9LRVJORUxfUldYPXkKQ09ORklHX0FSQ0hf SEFTX1NUUklDVF9NT0RVTEVfUldYPXkKQ09ORklHX1NUUklDVF9NT0RVTEVfUldYPXkKQ09O RklHX0hBVkVfQVJDSF9QUkVMMzJfUkVMT0NBVElPTlM9eQpDT05GSUdfQVJDSF9VU0VfTUVN UkVNQVBfUFJPVD15CkNPTkZJR19MT0NLX0VWRU5UX0NPVU5UUz15CkNPTkZJR19BUkNIX0hB U19NRU1fRU5DUllQVD15CkNPTkZJR19IQVZFX1NUQVRJQ19DQUxMPXkKQ09ORklHX0hBVkVf U1RBVElDX0NBTExfSU5MSU5FPXkKQ09ORklHX0hBVkVfUFJFRU1QVF9EWU5BTUlDPXkKQ09O RklHX0FSQ0hfV0FOVF9MRF9PUlBIQU5fV0FSTj15CkNPTkZJR19BUkNIX1NVUFBPUlRTX0RF QlVHX1BBR0VBTExPQz15CkNPTkZJR19BUkNIX0hBU19FTEZDT1JFX0NPTVBBVD15CgojCiMg R0NPVi1iYXNlZCBrZXJuZWwgcHJvZmlsaW5nCiMKIyBDT05GSUdfR0NPVl9LRVJORUwgaXMg bm90IHNldApDT05GSUdfQVJDSF9IQVNfR0NPVl9QUk9GSUxFX0FMTD15CiMgZW5kIG9mIEdD T1YtYmFzZWQga2VybmVsIHByb2ZpbGluZwoKQ09ORklHX0hBVkVfR0NDX1BMVUdJTlM9eQpD T05GSUdfR0NDX1BMVUdJTlM9eQojIENPTkZJR19HQ0NfUExVR0lOX0xBVEVOVF9FTlRST1BZ IGlzIG5vdCBzZXQKIyBDT05GSUdfR0NDX1BMVUdJTl9SQU5EU1RSVUNUIGlzIG5vdCBzZXQK IyBlbmQgb2YgR2VuZXJhbCBhcmNoaXRlY3R1cmUtZGVwZW5kZW50IG9wdGlvbnMKCkNPTkZJ R19SVF9NVVRFWEVTPXkKQ09ORklHX0JBU0VfU01BTEw9MApDT05GSUdfTU9EVUxFX1NJR19G T1JNQVQ9eQpDT05GSUdfTU9EVUxFUz15CkNPTkZJR19NT0RVTEVfRk9SQ0VfTE9BRD15CkNP TkZJR19NT0RVTEVfVU5MT0FEPXkKQ09ORklHX01PRFVMRV9GT1JDRV9VTkxPQUQ9eQojIENP TkZJR19NT0RWRVJTSU9OUyBpcyBub3Qgc2V0CkNPTkZJR19NT0RVTEVfU1JDVkVSU0lPTl9B TEw9eQpDT05GSUdfTU9EVUxFX1NJRz15CiMgQ09ORklHX01PRFVMRV9TSUdfRk9SQ0UgaXMg bm90IHNldApDT05GSUdfTU9EVUxFX1NJR19BTEw9eQojIENPTkZJR19NT0RVTEVfU0lHX1NI QTEgaXMgbm90IHNldAojIENPTkZJR19NT0RVTEVfU0lHX1NIQTIyNCBpcyBub3Qgc2V0CiMg Q09ORklHX01PRFVMRV9TSUdfU0hBMjU2IGlzIG5vdCBzZXQKIyBDT05GSUdfTU9EVUxFX1NJ R19TSEEzODQgaXMgbm90IHNldApDT05GSUdfTU9EVUxFX1NJR19TSEE1MTI9eQpDT05GSUdf TU9EVUxFX1NJR19IQVNIPSJzaGE1MTIiCkNPTkZJR19NT0RVTEVfQ09NUFJFU1M9eQojIENP TkZJR19NT0RVTEVfQ09NUFJFU1NfR1pJUCBpcyBub3Qgc2V0CkNPTkZJR19NT0RVTEVfQ09N UFJFU1NfWFo9eQpDT05GSUdfTU9EVUxFX0FMTE9XX01JU1NJTkdfTkFNRVNQQUNFX0lNUE9S VFM9eQpDT05GSUdfTU9EVUxFU19UUkVFX0xPT0tVUD15CkNPTkZJR19CTE9DSz15CkNPTkZJ R19CTEtfUlFfQUxMT0NfVElNRT15CkNPTkZJR19CTEtfU0NTSV9SRVFVRVNUPXkKQ09ORklH X0JMS19DR1JPVVBfUldTVEFUPXkKQ09ORklHX0JMS19ERVZfQlNHPXkKQ09ORklHX0JMS19E RVZfQlNHTElCPXkKQ09ORklHX0JMS19ERVZfSU5URUdSSVRZPXkKQ09ORklHX0JMS19ERVZf SU5URUdSSVRZX1QxMD15CkNPTkZJR19CTEtfREVWX1pPTkVEPXkKQ09ORklHX0JMS19ERVZf VEhST1RUTElORz15CkNPTkZJR19CTEtfREVWX1RIUk9UVExJTkdfTE9XPXkKIyBDT05GSUdf QkxLX0NNRExJTkVfUEFSU0VSIGlzIG5vdCBzZXQKQ09ORklHX0JMS19XQlQ9eQpDT05GSUdf QkxLX0NHUk9VUF9JT0xBVEVOQ1k9eQpDT05GSUdfQkxLX0NHUk9VUF9JT0NPU1Q9eQpDT05G SUdfQkxLX1dCVF9NUT15CkNPTkZJR19CTEtfREVCVUdfRlM9eQpDT05GSUdfQkxLX0RFQlVH X0ZTX1pPTkVEPXkKQ09ORklHX0JMS19TRURfT1BBTD15CkNPTkZJR19CTEtfSU5MSU5FX0VO Q1JZUFRJT049eQpDT05GSUdfQkxLX0lOTElORV9FTkNSWVBUSU9OX0ZBTExCQUNLPXkKCiMK IyBQYXJ0aXRpb24gVHlwZXMKIwpDT05GSUdfUEFSVElUSU9OX0FEVkFOQ0VEPXkKIyBDT05G SUdfQUNPUk5fUEFSVElUSU9OIGlzIG5vdCBzZXQKQ09ORklHX0FJWF9QQVJUSVRJT049eQoj IENPTkZJR19PU0ZfUEFSVElUSU9OIGlzIG5vdCBzZXQKIyBDT05GSUdfQU1JR0FfUEFSVElU SU9OIGlzIG5vdCBzZXQKIyBDT05GSUdfQVRBUklfUEFSVElUSU9OIGlzIG5vdCBzZXQKQ09O RklHX01BQ19QQVJUSVRJT049eQpDT05GSUdfTVNET1NfUEFSVElUSU9OPXkKQ09ORklHX0JT RF9ESVNLTEFCRUw9eQpDT05GSUdfTUlOSVhfU1VCUEFSVElUSU9OPXkKQ09ORklHX1NPTEFS SVNfWDg2X1BBUlRJVElPTj15CiMgQ09ORklHX1VOSVhXQVJFX0RJU0tMQUJFTCBpcyBub3Qg c2V0CkNPTkZJR19MRE1fUEFSVElUSU9OPXkKIyBDT05GSUdfTERNX0RFQlVHIGlzIG5vdCBz ZXQKIyBDT05GSUdfU0dJX1BBUlRJVElPTiBpcyBub3Qgc2V0CiMgQ09ORklHX1VMVFJJWF9Q QVJUSVRJT04gaXMgbm90IHNldAojIENPTkZJR19TVU5fUEFSVElUSU9OIGlzIG5vdCBzZXQK Q09ORklHX0tBUk1BX1BBUlRJVElPTj15CkNPTkZJR19FRklfUEFSVElUSU9OPXkKIyBDT05G SUdfU1lTVjY4X1BBUlRJVElPTiBpcyBub3Qgc2V0CiMgQ09ORklHX0NNRExJTkVfUEFSVElU SU9OIGlzIG5vdCBzZXQKIyBlbmQgb2YgUGFydGl0aW9uIFR5cGVzCgpDT05GSUdfQkxPQ0tf Q09NUEFUPXkKQ09ORklHX0JMS19NUV9QQ0k9eQpDT05GSUdfQkxLX01RX1ZJUlRJTz15CkNP TkZJR19CTEtfTVFfUkRNQT15CkNPTkZJR19CTEtfUE09eQoKIwojIElPIFNjaGVkdWxlcnMK IwpDT05GSUdfTVFfSU9TQ0hFRF9ERUFETElORT15CkNPTkZJR19NUV9JT1NDSEVEX0tZQkVS PXkKQ09ORklHX0lPU0NIRURfQkZRPXkKQ09ORklHX0JGUV9HUk9VUF9JT1NDSEVEPXkKIyBD T05GSUdfQkZRX0NHUk9VUF9ERUJVRyBpcyBub3Qgc2V0CiMgZW5kIG9mIElPIFNjaGVkdWxl cnMKCkNPTkZJR19QUkVFTVBUX05PVElGSUVSUz15CkNPTkZJR19QQURBVEE9eQpDT05GSUdf QVNOMT15CkNPTkZJR19VTklOTElORV9TUElOX1VOTE9DSz15CkNPTkZJR19BUkNIX1NVUFBP UlRTX0FUT01JQ19STVc9eQpDT05GSUdfTVVURVhfU1BJTl9PTl9PV05FUj15CkNPTkZJR19S V1NFTV9TUElOX09OX09XTkVSPXkKQ09ORklHX0xPQ0tfU1BJTl9PTl9PV05FUj15CkNPTkZJ R19BUkNIX1VTRV9RVUVVRURfU1BJTkxPQ0tTPXkKQ09ORklHX1FVRVVFRF9TUElOTE9DS1M9 eQpDT05GSUdfQVJDSF9VU0VfUVVFVUVEX1JXTE9DS1M9eQpDT05GSUdfUVVFVUVEX1JXTE9D S1M9eQpDT05GSUdfQVJDSF9IQVNfTk9OX09WRVJMQVBQSU5HX0FERFJFU1NfU1BBQ0U9eQpD T05GSUdfQVJDSF9IQVNfU1lOQ19DT1JFX0JFRk9SRV9VU0VSTU9ERT15CkNPTkZJR19BUkNI X0hBU19TWVNDQUxMX1dSQVBQRVI9eQpDT05GSUdfRlJFRVpFUj15CgojCiMgRXhlY3V0YWJs ZSBmaWxlIGZvcm1hdHMKIwpDT05GSUdfQklORk1UX0VMRj15CkNPTkZJR19DT01QQVRfQklO Rk1UX0VMRj15CkNPTkZJR19FTEZDT1JFPXkKQ09ORklHX0NPUkVfRFVNUF9ERUZBVUxUX0VM Rl9IRUFERVJTPXkKQ09ORklHX0JJTkZNVF9TQ1JJUFQ9eQpDT05GSUdfQklORk1UX01JU0M9 eQpDT05GSUdfQ09SRURVTVA9eQojIGVuZCBvZiBFeGVjdXRhYmxlIGZpbGUgZm9ybWF0cwoK IwojIE1lbW9yeSBNYW5hZ2VtZW50IG9wdGlvbnMKIwpDT05GSUdfU0VMRUNUX01FTU9SWV9N T0RFTD15CkNPTkZJR19TUEFSU0VNRU1fTUFOVUFMPXkKQ09ORklHX1NQQVJTRU1FTT15CkNP TkZJR19ORUVEX01VTFRJUExFX05PREVTPXkKQ09ORklHX1NQQVJTRU1FTV9FWFRSRU1FPXkK Q09ORklHX1NQQVJTRU1FTV9WTUVNTUFQX0VOQUJMRT15CkNPTkZJR19TUEFSU0VNRU1fVk1F TU1BUD15CkNPTkZJR19IQVZFX0ZBU1RfR1VQPXkKQ09ORklHX05VTUFfS0VFUF9NRU1JTkZP PXkKQ09ORklHX01FTU9SWV9JU09MQVRJT049eQpDT05GSUdfSEFWRV9CT09UTUVNX0lORk9f Tk9ERT15CkNPTkZJR19NRU1PUllfSE9UUExVRz15CkNPTkZJR19NRU1PUllfSE9UUExVR19T UEFSU0U9eQpDT05GSUdfTUVNT1JZX0hPVFBMVUdfREVGQVVMVF9PTkxJTkU9eQpDT05GSUdf TUVNT1JZX0hPVFJFTU9WRT15CkNPTkZJR19TUExJVF9QVExPQ0tfQ1BVUz00CkNPTkZJR19N RU1PUllfQkFMTE9PTj15CkNPTkZJR19CQUxMT09OX0NPTVBBQ1RJT049eQpDT05GSUdfQ09N UEFDVElPTj15CkNPTkZJR19QQUdFX1JFUE9SVElORz15CkNPTkZJR19NSUdSQVRJT049eQpD T05GSUdfQ09OVElHX0FMTE9DPXkKQ09ORklHX1BIWVNfQUREUl9UXzY0QklUPXkKQ09ORklH X0JPVU5DRT15CkNPTkZJR19WSVJUX1RPX0JVUz15CkNPTkZJR19NTVVfTk9USUZJRVI9eQpD T05GSUdfS1NNPXkKQ09ORklHX0RFRkFVTFRfTU1BUF9NSU5fQUREUj02NTUzNgpDT05GSUdf QVJDSF9TVVBQT1JUU19NRU1PUllfRkFJTFVSRT15CkNPTkZJR19NRU1PUllfRkFJTFVSRT15 CkNPTkZJR19IV1BPSVNPTl9JTkpFQ1Q9bQpDT05GSUdfVFJBTlNQQVJFTlRfSFVHRVBBR0U9 eQojIENPTkZJR19UUkFOU1BBUkVOVF9IVUdFUEFHRV9BTFdBWVMgaXMgbm90IHNldApDT05G SUdfVFJBTlNQQVJFTlRfSFVHRVBBR0VfTUFEVklTRT15CkNPTkZJR19BUkNIX1dBTlRTX1RI UF9TV0FQPXkKQ09ORklHX1RIUF9TV0FQPXkKQ09ORklHX0NMRUFOQ0FDSEU9eQpDT05GSUdf RlJPTlRTV0FQPXkKQ09ORklHX0NNQT15CiMgQ09ORklHX0NNQV9ERUJVRyBpcyBub3Qgc2V0 CkNPTkZJR19DTUFfREVCVUdGUz15CkNPTkZJR19DTUFfQVJFQVM9NwpDT05GSUdfTUVNX1NP RlRfRElSVFk9eQpDT05GSUdfWlNXQVA9eQojIENPTkZJR19aU1dBUF9DT01QUkVTU09SX0RF RkFVTFRfREVGTEFURSBpcyBub3Qgc2V0CiMgQ09ORklHX1pTV0FQX0NPTVBSRVNTT1JfREVG QVVMVF9MWk8gaXMgbm90IHNldAojIENPTkZJR19aU1dBUF9DT01QUkVTU09SX0RFRkFVTFRf ODQyIGlzIG5vdCBzZXQKQ09ORklHX1pTV0FQX0NPTVBSRVNTT1JfREVGQVVMVF9MWjQ9eQoj IENPTkZJR19aU1dBUF9DT01QUkVTU09SX0RFRkFVTFRfTFo0SEMgaXMgbm90IHNldAojIENP TkZJR19aU1dBUF9DT01QUkVTU09SX0RFRkFVTFRfWlNURCBpcyBub3Qgc2V0CkNPTkZJR19a U1dBUF9DT01QUkVTU09SX0RFRkFVTFQ9Imx6NCIKIyBDT05GSUdfWlNXQVBfWlBPT0xfREVG QVVMVF9aQlVEIGlzIG5vdCBzZXQKQ09ORklHX1pTV0FQX1pQT09MX0RFRkFVTFRfWjNGT0xE PXkKIyBDT05GSUdfWlNXQVBfWlBPT0xfREVGQVVMVF9aU01BTExPQyBpcyBub3Qgc2V0CkNP TkZJR19aU1dBUF9aUE9PTF9ERUZBVUxUPSJ6M2ZvbGQiCkNPTkZJR19aU1dBUF9ERUZBVUxU X09OPXkKQ09ORklHX1pQT09MPXkKQ09ORklHX1pCVUQ9eQpDT05GSUdfWjNGT0xEPXkKQ09O RklHX1pTTUFMTE9DPXkKIyBDT05GSUdfWlNNQUxMT0NfU1RBVCBpcyBub3Qgc2V0CkNPTkZJ R19HRU5FUklDX0VBUkxZX0lPUkVNQVA9eQojIENPTkZJR19ERUZFUlJFRF9TVFJVQ1RfUEFH RV9JTklUIGlzIG5vdCBzZXQKQ09ORklHX0lETEVfUEFHRV9UUkFDS0lORz15CkNPTkZJR19B UkNIX0hBU19QVEVfREVWTUFQPXkKQ09ORklHX1pPTkVfREVWSUNFPXkKQ09ORklHX0RFVl9Q QUdFTUFQX09QUz15CkNPTkZJR19ITU1fTUlSUk9SPXkKQ09ORklHX0RFVklDRV9QUklWQVRF PXkKQ09ORklHX1ZNQVBfUEZOPXkKQ09ORklHX0FSQ0hfVVNFU19ISUdIX1ZNQV9GTEFHUz15 CkNPTkZJR19BUkNIX0hBU19QS0VZUz15CiMgQ09ORklHX1BFUkNQVV9TVEFUUyBpcyBub3Qg c2V0CiMgQ09ORklHX0dVUF9URVNUIGlzIG5vdCBzZXQKQ09ORklHX1JFQURfT05MWV9USFBf Rk9SX0ZTPXkKQ09ORklHX0FSQ0hfSEFTX1BURV9TUEVDSUFMPXkKQ09ORklHX01BUFBJTkdf RElSVFlfSEVMUEVSUz15CiMgZW5kIG9mIE1lbW9yeSBNYW5hZ2VtZW50IG9wdGlvbnMKCkNP TkZJR19ORVQ9eQpDT05GSUdfQ09NUEFUX05FVExJTktfTUVTU0FHRVM9eQpDT05GSUdfTkVU X0lOR1JFU1M9eQpDT05GSUdfTkVUX0VHUkVTUz15CkNPTkZJR19ORVRfUkVESVJFQ1Q9eQpD T05GSUdfU0tCX0VYVEVOU0lPTlM9eQoKIwojIE5ldHdvcmtpbmcgb3B0aW9ucwojCkNPTkZJ R19QQUNLRVQ9eQpDT05GSUdfUEFDS0VUX0RJQUc9bQpDT05GSUdfVU5JWD15CkNPTkZJR19V TklYX1NDTT15CkNPTkZJR19VTklYX0RJQUc9bQpDT05GSUdfVExTPW0KQ09ORklHX1RMU19E RVZJQ0U9eQojIENPTkZJR19UTFNfVE9FIGlzIG5vdCBzZXQKQ09ORklHX1hGUk09eQpDT05G SUdfWEZSTV9PRkZMT0FEPXkKQ09ORklHX1hGUk1fQUxHTz15CkNPTkZJR19YRlJNX1VTRVI9 eQojIENPTkZJR19YRlJNX1VTRVJfQ09NUEFUIGlzIG5vdCBzZXQKQ09ORklHX1hGUk1fSU5U RVJGQUNFPW0KQ09ORklHX1hGUk1fU1VCX1BPTElDWT15CkNPTkZJR19YRlJNX01JR1JBVEU9 eQpDT05GSUdfWEZSTV9TVEFUSVNUSUNTPXkKQ09ORklHX1hGUk1fQUg9bQpDT05GSUdfWEZS TV9FU1A9bQpDT05GSUdfWEZSTV9JUENPTVA9bQpDT05GSUdfTkVUX0tFWT1tCkNPTkZJR19O RVRfS0VZX01JR1JBVEU9eQpDT05GSUdfWEZSTV9FU1BJTlRDUD15CkNPTkZJR19TTUM9bQpD T05GSUdfU01DX0RJQUc9bQpDT05GSUdfWERQX1NPQ0tFVFM9eQpDT05GSUdfWERQX1NPQ0tF VFNfRElBRz1tCkNPTkZJR19JTkVUPXkKQ09ORklHX0lQX01VTFRJQ0FTVD15CkNPTkZJR19J UF9BRFZBTkNFRF9ST1VURVI9eQpDT05GSUdfSVBfRklCX1RSSUVfU1RBVFM9eQpDT05GSUdf SVBfTVVMVElQTEVfVEFCTEVTPXkKQ09ORklHX0lQX1JPVVRFX01VTFRJUEFUSD15CkNPTkZJ R19JUF9ST1VURV9WRVJCT1NFPXkKQ09ORklHX0lQX1JPVVRFX0NMQVNTSUQ9eQojIENPTkZJ R19JUF9QTlAgaXMgbm90IHNldApDT05GSUdfTkVUX0lQSVA9bQpDT05GSUdfTkVUX0lQR1JF X0RFTVVYPW0KQ09ORklHX05FVF9JUF9UVU5ORUw9bQpDT05GSUdfTkVUX0lQR1JFPW0KQ09O RklHX05FVF9JUEdSRV9CUk9BRENBU1Q9eQpDT05GSUdfSVBfTVJPVVRFX0NPTU1PTj15CkNP TkZJR19JUF9NUk9VVEU9eQpDT05GSUdfSVBfTVJPVVRFX01VTFRJUExFX1RBQkxFUz15CkNP TkZJR19JUF9QSU1TTV9WMT15CkNPTkZJR19JUF9QSU1TTV9WMj15CkNPTkZJR19TWU5fQ09P S0lFUz15CkNPTkZJR19ORVRfSVBWVEk9bQpDT05GSUdfTkVUX1VEUF9UVU5ORUw9bQpDT05G SUdfTkVUX0ZPVT1tCkNPTkZJR19ORVRfRk9VX0lQX1RVTk5FTFM9eQpDT05GSUdfSU5FVF9B SD1tCkNPTkZJR19JTkVUX0VTUD1tCkNPTkZJR19JTkVUX0VTUF9PRkZMT0FEPW0KQ09ORklH X0lORVRfRVNQSU5UQ1A9eQpDT05GSUdfSU5FVF9JUENPTVA9bQpDT05GSUdfSU5FVF9YRlJN X1RVTk5FTD1tCkNPTkZJR19JTkVUX1RVTk5FTD1tCkNPTkZJR19JTkVUX0RJQUc9bQpDT05G SUdfSU5FVF9UQ1BfRElBRz1tCkNPTkZJR19JTkVUX1VEUF9ESUFHPW0KQ09ORklHX0lORVRf UkFXX0RJQUc9bQpDT05GSUdfSU5FVF9ESUFHX0RFU1RST1k9eQpDT05GSUdfVENQX0NPTkdf QURWQU5DRUQ9eQpDT05GSUdfVENQX0NPTkdfQklDPW0KQ09ORklHX1RDUF9DT05HX0NVQklD PXkKQ09ORklHX1RDUF9DT05HX1dFU1RXT09EPW0KQ09ORklHX1RDUF9DT05HX0hUQ1A9bQpD T05GSUdfVENQX0NPTkdfSFNUQ1A9bQpDT05GSUdfVENQX0NPTkdfSFlCTEE9bQpDT05GSUdf VENQX0NPTkdfVkVHQVM9bQpDT05GSUdfVENQX0NPTkdfTlY9bQpDT05GSUdfVENQX0NPTkdf U0NBTEFCTEU9bQpDT05GSUdfVENQX0NPTkdfTFA9bQpDT05GSUdfVENQX0NPTkdfVkVOTz1t CkNPTkZJR19UQ1BfQ09OR19ZRUFIPW0KQ09ORklHX1RDUF9DT05HX0lMTElOT0lTPW0KQ09O RklHX1RDUF9DT05HX0RDVENQPW0KQ09ORklHX1RDUF9DT05HX0NERz1tCkNPTkZJR19UQ1Bf Q09OR19CQlI9bQpDT05GSUdfREVGQVVMVF9DVUJJQz15CiMgQ09ORklHX0RFRkFVTFRfUkVO TyBpcyBub3Qgc2V0CkNPTkZJR19ERUZBVUxUX1RDUF9DT05HPSJjdWJpYyIKQ09ORklHX1RD UF9NRDVTSUc9eQpDT05GSUdfSVBWNj15CkNPTkZJR19JUFY2X1JPVVRFUl9QUkVGPXkKQ09O RklHX0lQVjZfUk9VVEVfSU5GTz15CkNPTkZJR19JUFY2X09QVElNSVNUSUNfREFEPXkKQ09O RklHX0lORVQ2X0FIPW0KQ09ORklHX0lORVQ2X0VTUD1tCkNPTkZJR19JTkVUNl9FU1BfT0ZG TE9BRD1tCkNPTkZJR19JTkVUNl9FU1BJTlRDUD15CkNPTkZJR19JTkVUNl9JUENPTVA9bQpD T05GSUdfSVBWNl9NSVA2PW0KQ09ORklHX0lQVjZfSUxBPW0KQ09ORklHX0lORVQ2X1hGUk1f VFVOTkVMPW0KQ09ORklHX0lORVQ2X1RVTk5FTD1tCkNPTkZJR19JUFY2X1ZUST1tCkNPTkZJ R19JUFY2X1NJVD1tCkNPTkZJR19JUFY2X1NJVF82UkQ9eQpDT05GSUdfSVBWNl9ORElTQ19O T0RFVFlQRT15CkNPTkZJR19JUFY2X1RVTk5FTD1tCkNPTkZJR19JUFY2X0dSRT1tCkNPTkZJ R19JUFY2X0ZPVT1tCkNPTkZJR19JUFY2X0ZPVV9UVU5ORUw9bQpDT05GSUdfSVBWNl9NVUxU SVBMRV9UQUJMRVM9eQpDT05GSUdfSVBWNl9TVUJUUkVFUz15CkNPTkZJR19JUFY2X01ST1VU RT15CkNPTkZJR19JUFY2X01ST1VURV9NVUxUSVBMRV9UQUJMRVM9eQpDT05GSUdfSVBWNl9Q SU1TTV9WMj15CkNPTkZJR19JUFY2X1NFRzZfTFdUVU5ORUw9eQpDT05GSUdfSVBWNl9TRUc2 X0hNQUM9eQpDT05GSUdfSVBWNl9TRUc2X0JQRj15CkNPTkZJR19JUFY2X1JQTF9MV1RVTk5F TD15CkNPTkZJR19ORVRMQUJFTD15CkNPTkZJR19NUFRDUD15CkNPTkZJR19JTkVUX01QVENQ X0RJQUc9bQpDT05GSUdfTVBUQ1BfSVBWNj15CkNPTkZJR19ORVRXT1JLX1NFQ01BUks9eQpD T05GSUdfTkVUX1BUUF9DTEFTU0lGWT15CkNPTkZJR19ORVRXT1JLX1BIWV9USU1FU1RBTVBJ Tkc9eQpDT05GSUdfTkVURklMVEVSPXkKQ09ORklHX05FVEZJTFRFUl9BRFZBTkNFRD15CkNP TkZJR19CUklER0VfTkVURklMVEVSPW0KCiMKIyBDb3JlIE5ldGZpbHRlciBDb25maWd1cmF0 aW9uCiMKQ09ORklHX05FVEZJTFRFUl9JTkdSRVNTPXkKQ09ORklHX05FVEZJTFRFUl9ORVRM SU5LPW0KQ09ORklHX05FVEZJTFRFUl9GQU1JTFlfQlJJREdFPXkKQ09ORklHX05FVEZJTFRF Ul9GQU1JTFlfQVJQPXkKQ09ORklHX05FVEZJTFRFUl9ORVRMSU5LX0FDQ1Q9bQpDT05GSUdf TkVURklMVEVSX05FVExJTktfUVVFVUU9bQpDT05GSUdfTkVURklMVEVSX05FVExJTktfTE9H PW0KQ09ORklHX05FVEZJTFRFUl9ORVRMSU5LX09TRj1tCkNPTkZJR19ORl9DT05OVFJBQ0s9 bQpDT05GSUdfTkZfTE9HX0NPTU1PTj1tCkNPTkZJR19ORl9MT0dfTkVUREVWPW0KQ09ORklH X05FVEZJTFRFUl9DT05OQ09VTlQ9bQpDT05GSUdfTkZfQ09OTlRSQUNLX01BUks9eQpDT05G SUdfTkZfQ09OTlRSQUNLX1NFQ01BUks9eQpDT05GSUdfTkZfQ09OTlRSQUNLX1pPTkVTPXkK Q09ORklHX05GX0NPTk5UUkFDS19QUk9DRlM9eQpDT05GSUdfTkZfQ09OTlRSQUNLX0VWRU5U Uz15CkNPTkZJR19ORl9DT05OVFJBQ0tfVElNRU9VVD15CkNPTkZJR19ORl9DT05OVFJBQ0tf VElNRVNUQU1QPXkKQ09ORklHX05GX0NPTk5UUkFDS19MQUJFTFM9eQpDT05GSUdfTkZfQ1Rf UFJPVE9fRENDUD15CkNPTkZJR19ORl9DVF9QUk9UT19HUkU9eQpDT05GSUdfTkZfQ1RfUFJP VE9fU0NUUD15CkNPTkZJR19ORl9DVF9QUk9UT19VRFBMSVRFPXkKQ09ORklHX05GX0NPTk5U UkFDS19BTUFOREE9bQpDT05GSUdfTkZfQ09OTlRSQUNLX0ZUUD1tCkNPTkZJR19ORl9DT05O VFJBQ0tfSDMyMz1tCkNPTkZJR19ORl9DT05OVFJBQ0tfSVJDPW0KQ09ORklHX05GX0NPTk5U UkFDS19CUk9BRENBU1Q9bQpDT05GSUdfTkZfQ09OTlRSQUNLX05FVEJJT1NfTlM9bQpDT05G SUdfTkZfQ09OTlRSQUNLX1NOTVA9bQpDT05GSUdfTkZfQ09OTlRSQUNLX1BQVFA9bQpDT05G SUdfTkZfQ09OTlRSQUNLX1NBTkU9bQpDT05GSUdfTkZfQ09OTlRSQUNLX1NJUD1tCkNPTkZJ R19ORl9DT05OVFJBQ0tfVEZUUD1tCkNPTkZJR19ORl9DVF9ORVRMSU5LPW0KQ09ORklHX05G X0NUX05FVExJTktfVElNRU9VVD1tCkNPTkZJR19ORl9DVF9ORVRMSU5LX0hFTFBFUj1tCkNP TkZJR19ORVRGSUxURVJfTkVUTElOS19HTFVFX0NUPXkKQ09ORklHX05GX05BVD1tCkNPTkZJ R19ORl9OQVRfQU1BTkRBPW0KQ09ORklHX05GX05BVF9GVFA9bQpDT05GSUdfTkZfTkFUX0lS Qz1tCkNPTkZJR19ORl9OQVRfU0lQPW0KQ09ORklHX05GX05BVF9URlRQPW0KQ09ORklHX05G X05BVF9SRURJUkVDVD15CkNPTkZJR19ORl9OQVRfTUFTUVVFUkFERT15CkNPTkZJR19ORVRG SUxURVJfU1lOUFJPWFk9bQpDT05GSUdfTkZfVEFCTEVTPW0KQ09ORklHX05GX1RBQkxFU19J TkVUPXkKQ09ORklHX05GX1RBQkxFU19ORVRERVY9eQpDT05GSUdfTkZUX05VTUdFTj1tCkNP TkZJR19ORlRfQ1Q9bQpDT05GSUdfTkZUX0ZMT1dfT0ZGTE9BRD1tCkNPTkZJR19ORlRfQ09V TlRFUj1tCkNPTkZJR19ORlRfQ09OTkxJTUlUPW0KQ09ORklHX05GVF9MT0c9bQpDT05GSUdf TkZUX0xJTUlUPW0KQ09ORklHX05GVF9NQVNRPW0KQ09ORklHX05GVF9SRURJUj1tCkNPTkZJ R19ORlRfTkFUPW0KQ09ORklHX05GVF9UVU5ORUw9bQpDT05GSUdfTkZUX09CSlJFRj1tCkNP TkZJR19ORlRfUVVFVUU9bQpDT05GSUdfTkZUX1FVT1RBPW0KQ09ORklHX05GVF9SRUpFQ1Q9 bQpDT05GSUdfTkZUX1JFSkVDVF9JTkVUPW0KQ09ORklHX05GVF9DT01QQVQ9bQpDT05GSUdf TkZUX0hBU0g9bQpDT05GSUdfTkZUX0ZJQj1tCkNPTkZJR19ORlRfRklCX0lORVQ9bQpDT05G SUdfTkZUX1hGUk09bQpDT05GSUdfTkZUX1NPQ0tFVD1tCkNPTkZJR19ORlRfT1NGPW0KQ09O RklHX05GVF9UUFJPWFk9bQpDT05GSUdfTkZUX1NZTlBST1hZPW0KQ09ORklHX05GX0RVUF9O RVRERVY9bQpDT05GSUdfTkZUX0RVUF9ORVRERVY9bQpDT05GSUdfTkZUX0ZXRF9ORVRERVY9 bQpDT05GSUdfTkZUX0ZJQl9ORVRERVY9bQpDT05GSUdfTkZUX1JFSkVDVF9ORVRERVY9bQpD T05GSUdfTkZfRkxPV19UQUJMRV9JTkVUPW0KQ09ORklHX05GX0ZMT1dfVEFCTEU9bQpDT05G SUdfTkVURklMVEVSX1hUQUJMRVM9bQoKIwojIFh0YWJsZXMgY29tYmluZWQgbW9kdWxlcwoj CkNPTkZJR19ORVRGSUxURVJfWFRfTUFSSz1tCkNPTkZJR19ORVRGSUxURVJfWFRfQ09OTk1B Uks9bQpDT05GSUdfTkVURklMVEVSX1hUX1NFVD1tCgojCiMgWHRhYmxlcyB0YXJnZXRzCiMK Q09ORklHX05FVEZJTFRFUl9YVF9UQVJHRVRfQVVESVQ9bQpDT05GSUdfTkVURklMVEVSX1hU X1RBUkdFVF9DSEVDS1NVTT1tCkNPTkZJR19ORVRGSUxURVJfWFRfVEFSR0VUX0NMQVNTSUZZ PW0KQ09ORklHX05FVEZJTFRFUl9YVF9UQVJHRVRfQ09OTk1BUks9bQpDT05GSUdfTkVURklM VEVSX1hUX1RBUkdFVF9DT05OU0VDTUFSSz1tCkNPTkZJR19ORVRGSUxURVJfWFRfVEFSR0VU X0NUPW0KQ09ORklHX05FVEZJTFRFUl9YVF9UQVJHRVRfRFNDUD1tCkNPTkZJR19ORVRGSUxU RVJfWFRfVEFSR0VUX0hMPW0KQ09ORklHX05FVEZJTFRFUl9YVF9UQVJHRVRfSE1BUks9bQpD T05GSUdfTkVURklMVEVSX1hUX1RBUkdFVF9JRExFVElNRVI9bQpDT05GSUdfTkVURklMVEVS X1hUX1RBUkdFVF9MRUQ9bQpDT05GSUdfTkVURklMVEVSX1hUX1RBUkdFVF9MT0c9bQpDT05G SUdfTkVURklMVEVSX1hUX1RBUkdFVF9NQVJLPW0KQ09ORklHX05FVEZJTFRFUl9YVF9OQVQ9 bQpDT05GSUdfTkVURklMVEVSX1hUX1RBUkdFVF9ORVRNQVA9bQpDT05GSUdfTkVURklMVEVS X1hUX1RBUkdFVF9ORkxPRz1tCkNPTkZJR19ORVRGSUxURVJfWFRfVEFSR0VUX05GUVVFVUU9 bQpDT05GSUdfTkVURklMVEVSX1hUX1RBUkdFVF9OT1RSQUNLPW0KQ09ORklHX05FVEZJTFRF Ul9YVF9UQVJHRVRfUkFURUVTVD1tCkNPTkZJR19ORVRGSUxURVJfWFRfVEFSR0VUX1JFRElS RUNUPW0KQ09ORklHX05FVEZJTFRFUl9YVF9UQVJHRVRfTUFTUVVFUkFERT1tCkNPTkZJR19O RVRGSUxURVJfWFRfVEFSR0VUX1RFRT1tCkNPTkZJR19ORVRGSUxURVJfWFRfVEFSR0VUX1RQ Uk9YWT1tCkNPTkZJR19ORVRGSUxURVJfWFRfVEFSR0VUX1RSQUNFPW0KQ09ORklHX05FVEZJ TFRFUl9YVF9UQVJHRVRfU0VDTUFSSz1tCkNPTkZJR19ORVRGSUxURVJfWFRfVEFSR0VUX1RD UE1TUz1tCkNPTkZJR19ORVRGSUxURVJfWFRfVEFSR0VUX1RDUE9QVFNUUklQPW0KCiMKIyBY dGFibGVzIG1hdGNoZXMKIwpDT05GSUdfTkVURklMVEVSX1hUX01BVENIX0FERFJUWVBFPW0K Q09ORklHX05FVEZJTFRFUl9YVF9NQVRDSF9CUEY9bQpDT05GSUdfTkVURklMVEVSX1hUX01B VENIX0NHUk9VUD1tCkNPTkZJR19ORVRGSUxURVJfWFRfTUFUQ0hfQ0xVU1RFUj1tCkNPTkZJ R19ORVRGSUxURVJfWFRfTUFUQ0hfQ09NTUVOVD1tCkNPTkZJR19ORVRGSUxURVJfWFRfTUFU Q0hfQ09OTkJZVEVTPW0KQ09ORklHX05FVEZJTFRFUl9YVF9NQVRDSF9DT05OTEFCRUw9bQpD T05GSUdfTkVURklMVEVSX1hUX01BVENIX0NPTk5MSU1JVD1tCkNPTkZJR19ORVRGSUxURVJf WFRfTUFUQ0hfQ09OTk1BUks9bQpDT05GSUdfTkVURklMVEVSX1hUX01BVENIX0NPTk5UUkFD Sz1tCkNPTkZJR19ORVRGSUxURVJfWFRfTUFUQ0hfQ1BVPW0KQ09ORklHX05FVEZJTFRFUl9Y VF9NQVRDSF9EQ0NQPW0KQ09ORklHX05FVEZJTFRFUl9YVF9NQVRDSF9ERVZHUk9VUD1tCkNP TkZJR19ORVRGSUxURVJfWFRfTUFUQ0hfRFNDUD1tCkNPTkZJR19ORVRGSUxURVJfWFRfTUFU Q0hfRUNOPW0KQ09ORklHX05FVEZJTFRFUl9YVF9NQVRDSF9FU1A9bQpDT05GSUdfTkVURklM VEVSX1hUX01BVENIX0hBU0hMSU1JVD1tCkNPTkZJR19ORVRGSUxURVJfWFRfTUFUQ0hfSEVM UEVSPW0KQ09ORklHX05FVEZJTFRFUl9YVF9NQVRDSF9ITD1tCkNPTkZJR19ORVRGSUxURVJf WFRfTUFUQ0hfSVBDT01QPW0KQ09ORklHX05FVEZJTFRFUl9YVF9NQVRDSF9JUFJBTkdFPW0K Q09ORklHX05FVEZJTFRFUl9YVF9NQVRDSF9JUFZTPW0KQ09ORklHX05FVEZJTFRFUl9YVF9N QVRDSF9MMlRQPW0KQ09ORklHX05FVEZJTFRFUl9YVF9NQVRDSF9MRU5HVEg9bQpDT05GSUdf TkVURklMVEVSX1hUX01BVENIX0xJTUlUPW0KQ09ORklHX05FVEZJTFRFUl9YVF9NQVRDSF9N QUM9bQpDT05GSUdfTkVURklMVEVSX1hUX01BVENIX01BUks9bQpDT05GSUdfTkVURklMVEVS X1hUX01BVENIX01VTFRJUE9SVD1tCkNPTkZJR19ORVRGSUxURVJfWFRfTUFUQ0hfTkZBQ0NU PW0KQ09ORklHX05FVEZJTFRFUl9YVF9NQVRDSF9PU0Y9bQpDT05GSUdfTkVURklMVEVSX1hU X01BVENIX09XTkVSPW0KQ09ORklHX05FVEZJTFRFUl9YVF9NQVRDSF9QT0xJQ1k9bQpDT05G SUdfTkVURklMVEVSX1hUX01BVENIX1BIWVNERVY9bQpDT05GSUdfTkVURklMVEVSX1hUX01B VENIX1BLVFRZUEU9bQpDT05GSUdfTkVURklMVEVSX1hUX01BVENIX1FVT1RBPW0KQ09ORklH X05FVEZJTFRFUl9YVF9NQVRDSF9SQVRFRVNUPW0KQ09ORklHX05FVEZJTFRFUl9YVF9NQVRD SF9SRUFMTT1tCkNPTkZJR19ORVRGSUxURVJfWFRfTUFUQ0hfUkVDRU5UPW0KQ09ORklHX05F VEZJTFRFUl9YVF9NQVRDSF9TQ1RQPW0KQ09ORklHX05FVEZJTFRFUl9YVF9NQVRDSF9TT0NL RVQ9bQpDT05GSUdfTkVURklMVEVSX1hUX01BVENIX1NUQVRFPW0KQ09ORklHX05FVEZJTFRF Ul9YVF9NQVRDSF9TVEFUSVNUSUM9bQpDT05GSUdfTkVURklMVEVSX1hUX01BVENIX1NUUklO Rz1tCkNPTkZJR19ORVRGSUxURVJfWFRfTUFUQ0hfVENQTVNTPW0KQ09ORklHX05FVEZJTFRF Ul9YVF9NQVRDSF9USU1FPW0KQ09ORklHX05FVEZJTFRFUl9YVF9NQVRDSF9VMzI9bQojIGVu ZCBvZiBDb3JlIE5ldGZpbHRlciBDb25maWd1cmF0aW9uCgpDT05GSUdfSVBfU0VUPW0KQ09O RklHX0lQX1NFVF9NQVg9MjU2CkNPTkZJR19JUF9TRVRfQklUTUFQX0lQPW0KQ09ORklHX0lQ X1NFVF9CSVRNQVBfSVBNQUM9bQpDT05GSUdfSVBfU0VUX0JJVE1BUF9QT1JUPW0KQ09ORklH X0lQX1NFVF9IQVNIX0lQPW0KQ09ORklHX0lQX1NFVF9IQVNIX0lQTUFSSz1tCkNPTkZJR19J UF9TRVRfSEFTSF9JUFBPUlQ9bQpDT05GSUdfSVBfU0VUX0hBU0hfSVBQT1JUSVA9bQpDT05G SUdfSVBfU0VUX0hBU0hfSVBQT1JUTkVUPW0KQ09ORklHX0lQX1NFVF9IQVNIX0lQTUFDPW0K Q09ORklHX0lQX1NFVF9IQVNIX01BQz1tCkNPTkZJR19JUF9TRVRfSEFTSF9ORVRQT1JUTkVU PW0KQ09ORklHX0lQX1NFVF9IQVNIX05FVD1tCkNPTkZJR19JUF9TRVRfSEFTSF9ORVRORVQ9 bQpDT05GSUdfSVBfU0VUX0hBU0hfTkVUUE9SVD1tCkNPTkZJR19JUF9TRVRfSEFTSF9ORVRJ RkFDRT1tCkNPTkZJR19JUF9TRVRfTElTVF9TRVQ9bQpDT05GSUdfSVBfVlM9bQpDT05GSUdf SVBfVlNfSVBWNj15CiMgQ09ORklHX0lQX1ZTX0RFQlVHIGlzIG5vdCBzZXQKQ09ORklHX0lQ X1ZTX1RBQl9CSVRTPTE1CgojCiMgSVBWUyB0cmFuc3BvcnQgcHJvdG9jb2wgbG9hZCBiYWxh bmNpbmcgc3VwcG9ydAojCkNPTkZJR19JUF9WU19QUk9UT19UQ1A9eQpDT05GSUdfSVBfVlNf UFJPVE9fVURQPXkKQ09ORklHX0lQX1ZTX1BST1RPX0FIX0VTUD15CkNPTkZJR19JUF9WU19Q Uk9UT19FU1A9eQpDT05GSUdfSVBfVlNfUFJPVE9fQUg9eQpDT05GSUdfSVBfVlNfUFJPVE9f U0NUUD15CgojCiMgSVBWUyBzY2hlZHVsZXIKIwpDT05GSUdfSVBfVlNfUlI9bQpDT05GSUdf SVBfVlNfV1JSPW0KQ09ORklHX0lQX1ZTX0xDPW0KQ09ORklHX0lQX1ZTX1dMQz1tCkNPTkZJ R19JUF9WU19GTz1tCkNPTkZJR19JUF9WU19PVkY9bQpDT05GSUdfSVBfVlNfTEJMQz1tCkNP TkZJR19JUF9WU19MQkxDUj1tCkNPTkZJR19JUF9WU19ESD1tCkNPTkZJR19JUF9WU19TSD1t CkNPTkZJR19JUF9WU19NSD1tCkNPTkZJR19JUF9WU19TRUQ9bQpDT05GSUdfSVBfVlNfTlE9 bQpDT05GSUdfSVBfVlNfVFdPUz1tCgojCiMgSVBWUyBTSCBzY2hlZHVsZXIKIwpDT05GSUdf SVBfVlNfU0hfVEFCX0JJVFM9OAoKIwojIElQVlMgTUggc2NoZWR1bGVyCiMKQ09ORklHX0lQ X1ZTX01IX1RBQl9JTkRFWD0xMgoKIwojIElQVlMgYXBwbGljYXRpb24gaGVscGVyCiMKQ09O RklHX0lQX1ZTX0ZUUD1tCkNPTkZJR19JUF9WU19ORkNUPXkKQ09ORklHX0lQX1ZTX1BFX1NJ UD1tCgojCiMgSVA6IE5ldGZpbHRlciBDb25maWd1cmF0aW9uCiMKQ09ORklHX05GX0RFRlJB R19JUFY0PW0KQ09ORklHX05GX1NPQ0tFVF9JUFY0PW0KQ09ORklHX05GX1RQUk9YWV9JUFY0 PW0KQ09ORklHX05GX1RBQkxFU19JUFY0PXkKQ09ORklHX05GVF9SRUpFQ1RfSVBWND1tCkNP TkZJR19ORlRfRFVQX0lQVjQ9bQpDT05GSUdfTkZUX0ZJQl9JUFY0PW0KQ09ORklHX05GX1RB QkxFU19BUlA9eQpDT05GSUdfTkZfRkxPV19UQUJMRV9JUFY0PW0KQ09ORklHX05GX0RVUF9J UFY0PW0KQ09ORklHX05GX0xPR19BUlA9bQpDT05GSUdfTkZfTE9HX0lQVjQ9bQpDT05GSUdf TkZfUkVKRUNUX0lQVjQ9bQpDT05GSUdfTkZfTkFUX1NOTVBfQkFTSUM9bQpDT05GSUdfTkZf TkFUX1BQVFA9bQpDT05GSUdfTkZfTkFUX0gzMjM9bQpDT05GSUdfSVBfTkZfSVBUQUJMRVM9 bQpDT05GSUdfSVBfTkZfTUFUQ0hfQUg9bQpDT05GSUdfSVBfTkZfTUFUQ0hfRUNOPW0KQ09O RklHX0lQX05GX01BVENIX1JQRklMVEVSPW0KQ09ORklHX0lQX05GX01BVENIX1RUTD1tCkNP TkZJR19JUF9ORl9GSUxURVI9bQpDT05GSUdfSVBfTkZfVEFSR0VUX1JFSkVDVD1tCkNPTkZJ R19JUF9ORl9UQVJHRVRfU1lOUFJPWFk9bQpDT05GSUdfSVBfTkZfTkFUPW0KQ09ORklHX0lQ X05GX1RBUkdFVF9NQVNRVUVSQURFPW0KQ09ORklHX0lQX05GX1RBUkdFVF9ORVRNQVA9bQpD T05GSUdfSVBfTkZfVEFSR0VUX1JFRElSRUNUPW0KQ09ORklHX0lQX05GX01BTkdMRT1tCkNP TkZJR19JUF9ORl9UQVJHRVRfQ0xVU1RFUklQPW0KQ09ORklHX0lQX05GX1RBUkdFVF9FQ049 bQpDT05GSUdfSVBfTkZfVEFSR0VUX1RUTD1tCkNPTkZJR19JUF9ORl9SQVc9bQpDT05GSUdf SVBfTkZfU0VDVVJJVFk9bQpDT05GSUdfSVBfTkZfQVJQVEFCTEVTPW0KQ09ORklHX0lQX05G X0FSUEZJTFRFUj1tCkNPTkZJR19JUF9ORl9BUlBfTUFOR0xFPW0KIyBlbmQgb2YgSVA6IE5l dGZpbHRlciBDb25maWd1cmF0aW9uCgojCiMgSVB2NjogTmV0ZmlsdGVyIENvbmZpZ3VyYXRp b24KIwpDT05GSUdfTkZfU09DS0VUX0lQVjY9bQpDT05GSUdfTkZfVFBST1hZX0lQVjY9bQpD T05GSUdfTkZfVEFCTEVTX0lQVjY9eQpDT05GSUdfTkZUX1JFSkVDVF9JUFY2PW0KQ09ORklH X05GVF9EVVBfSVBWNj1tCkNPTkZJR19ORlRfRklCX0lQVjY9bQpDT05GSUdfTkZfRkxPV19U QUJMRV9JUFY2PW0KQ09ORklHX05GX0RVUF9JUFY2PW0KQ09ORklHX05GX1JFSkVDVF9JUFY2 PW0KQ09ORklHX05GX0xPR19JUFY2PW0KQ09ORklHX0lQNl9ORl9JUFRBQkxFUz1tCkNPTkZJ R19JUDZfTkZfTUFUQ0hfQUg9bQpDT05GSUdfSVA2X05GX01BVENIX0VVSTY0PW0KQ09ORklH X0lQNl9ORl9NQVRDSF9GUkFHPW0KQ09ORklHX0lQNl9ORl9NQVRDSF9PUFRTPW0KQ09ORklH X0lQNl9ORl9NQVRDSF9ITD1tCkNPTkZJR19JUDZfTkZfTUFUQ0hfSVBWNkhFQURFUj1tCkNP TkZJR19JUDZfTkZfTUFUQ0hfTUg9bQpDT05GSUdfSVA2X05GX01BVENIX1JQRklMVEVSPW0K Q09ORklHX0lQNl9ORl9NQVRDSF9SVD1tCkNPTkZJR19JUDZfTkZfTUFUQ0hfU1JIPW0KQ09O RklHX0lQNl9ORl9UQVJHRVRfSEw9bQpDT05GSUdfSVA2X05GX0ZJTFRFUj1tCkNPTkZJR19J UDZfTkZfVEFSR0VUX1JFSkVDVD1tCkNPTkZJR19JUDZfTkZfVEFSR0VUX1NZTlBST1hZPW0K Q09ORklHX0lQNl9ORl9NQU5HTEU9bQpDT05GSUdfSVA2X05GX1JBVz1tCkNPTkZJR19JUDZf TkZfU0VDVVJJVFk9bQpDT05GSUdfSVA2X05GX05BVD1tCkNPTkZJR19JUDZfTkZfVEFSR0VU X01BU1FVRVJBREU9bQpDT05GSUdfSVA2X05GX1RBUkdFVF9OUFQ9bQojIGVuZCBvZiBJUHY2 OiBOZXRmaWx0ZXIgQ29uZmlndXJhdGlvbgoKQ09ORklHX05GX0RFRlJBR19JUFY2PW0KQ09O RklHX05GX1RBQkxFU19CUklER0U9bQpDT05GSUdfTkZUX0JSSURHRV9NRVRBPW0KQ09ORklH X05GVF9CUklER0VfUkVKRUNUPW0KQ09ORklHX05GX0xPR19CUklER0U9bQpDT05GSUdfTkZf Q09OTlRSQUNLX0JSSURHRT1tCkNPTkZJR19CUklER0VfTkZfRUJUQUJMRVM9bQpDT05GSUdf QlJJREdFX0VCVF9CUk9VVEU9bQpDT05GSUdfQlJJREdFX0VCVF9UX0ZJTFRFUj1tCkNPTkZJ R19CUklER0VfRUJUX1RfTkFUPW0KQ09ORklHX0JSSURHRV9FQlRfODAyXzM9bQpDT05GSUdf QlJJREdFX0VCVF9BTU9ORz1tCkNPTkZJR19CUklER0VfRUJUX0FSUD1tCkNPTkZJR19CUklE R0VfRUJUX0lQPW0KQ09ORklHX0JSSURHRV9FQlRfSVA2PW0KQ09ORklHX0JSSURHRV9FQlRf TElNSVQ9bQpDT05GSUdfQlJJREdFX0VCVF9NQVJLPW0KQ09ORklHX0JSSURHRV9FQlRfUEtU VFlQRT1tCkNPTkZJR19CUklER0VfRUJUX1NUUD1tCkNPTkZJR19CUklER0VfRUJUX1ZMQU49 bQpDT05GSUdfQlJJREdFX0VCVF9BUlBSRVBMWT1tCkNPTkZJR19CUklER0VfRUJUX0ROQVQ9 bQpDT05GSUdfQlJJREdFX0VCVF9NQVJLX1Q9bQpDT05GSUdfQlJJREdFX0VCVF9SRURJUkVD VD1tCkNPTkZJR19CUklER0VfRUJUX1NOQVQ9bQpDT05GSUdfQlJJREdFX0VCVF9MT0c9bQpD T05GSUdfQlJJREdFX0VCVF9ORkxPRz1tCiMgQ09ORklHX0JQRklMVEVSIGlzIG5vdCBzZXQK IyBDT05GSUdfSVBfRENDUCBpcyBub3Qgc2V0CkNPTkZJR19JUF9TQ1RQPW0KIyBDT05GSUdf U0NUUF9EQkdfT0JKQ05UIGlzIG5vdCBzZXQKIyBDT05GSUdfU0NUUF9ERUZBVUxUX0NPT0tJ RV9ITUFDX01ENSBpcyBub3Qgc2V0CkNPTkZJR19TQ1RQX0RFRkFVTFRfQ09PS0lFX0hNQUNf U0hBMT15CiMgQ09ORklHX1NDVFBfREVGQVVMVF9DT09LSUVfSE1BQ19OT05FIGlzIG5vdCBz ZXQKQ09ORklHX1NDVFBfQ09PS0lFX0hNQUNfTUQ1PXkKQ09ORklHX1NDVFBfQ09PS0lFX0hN QUNfU0hBMT15CkNPTkZJR19JTkVUX1NDVFBfRElBRz1tCkNPTkZJR19SRFM9bQpDT05GSUdf UkRTX1JETUE9bQpDT05GSUdfUkRTX1RDUD1tCiMgQ09ORklHX1JEU19ERUJVRyBpcyBub3Qg c2V0CkNPTkZJR19USVBDPW0KQ09ORklHX1RJUENfTUVESUFfSUI9eQpDT05GSUdfVElQQ19N RURJQV9VRFA9eQpDT05GSUdfVElQQ19DUllQVE89eQpDT05GSUdfVElQQ19ESUFHPW0KQ09O RklHX0FUTT1tCkNPTkZJR19BVE1fQ0xJUD1tCiMgQ09ORklHX0FUTV9DTElQX05PX0lDTVAg aXMgbm90IHNldApDT05GSUdfQVRNX0xBTkU9bQpDT05GSUdfQVRNX01QT0E9bQpDT05GSUdf QVRNX0JSMjY4ND1tCiMgQ09ORklHX0FUTV9CUjI2ODRfSVBGSUxURVIgaXMgbm90IHNldApD T05GSUdfTDJUUD1tCkNPTkZJR19MMlRQX0RFQlVHRlM9bQpDT05GSUdfTDJUUF9WMz15CkNP TkZJR19MMlRQX0lQPW0KQ09ORklHX0wyVFBfRVRIPW0KQ09ORklHX1NUUD1tCkNPTkZJR19H QVJQPW0KQ09ORklHX01SUD1tCkNPTkZJR19CUklER0U9bQpDT05GSUdfQlJJREdFX0lHTVBf U05PT1BJTkc9eQpDT05GSUdfQlJJREdFX1ZMQU5fRklMVEVSSU5HPXkKQ09ORklHX0JSSURH RV9NUlA9eQpDT05GSUdfQlJJREdFX0NGTT15CkNPTkZJR19IQVZFX05FVF9EU0E9eQpDT05G SUdfTkVUX0RTQT1tCkNPTkZJR19ORVRfRFNBX1RBR184MDIxUT1tCkNPTkZJR19ORVRfRFNB X1RBR19BUjkzMzE9bQpDT05GSUdfTkVUX0RTQV9UQUdfQlJDTV9DT01NT049bQpDT05GSUdf TkVUX0RTQV9UQUdfQlJDTT1tCkNPTkZJR19ORVRfRFNBX1RBR19CUkNNX1BSRVBFTkQ9bQpD T05GSUdfTkVUX0RTQV9UQUdfSEVMTENSRUVLPW0KQ09ORklHX05FVF9EU0FfVEFHX0dTV0lQ PW0KQ09ORklHX05FVF9EU0FfVEFHX0RTQV9DT01NT049bQpDT05GSUdfTkVUX0RTQV9UQUdf RFNBPW0KQ09ORklHX05FVF9EU0FfVEFHX0VEU0E9bQpDT05GSUdfTkVUX0RTQV9UQUdfTVRL PW0KQ09ORklHX05FVF9EU0FfVEFHX0tTWj1tCkNPTkZJR19ORVRfRFNBX1RBR19SVEw0X0E9 bQpDT05GSUdfTkVUX0RTQV9UQUdfT0NFTE9UPW0KQ09ORklHX05FVF9EU0FfVEFHX09DRUxP VF84MDIxUT1tCkNPTkZJR19ORVRfRFNBX1RBR19RQ0E9bQpDT05GSUdfTkVUX0RTQV9UQUdf TEFOOTMwMz1tCkNPTkZJR19ORVRfRFNBX1RBR19TSkExMTA1PW0KQ09ORklHX05FVF9EU0Ff VEFHX1RSQUlMRVI9bQpDT05GSUdfTkVUX0RTQV9UQUdfWFJTNzAwWD1tCkNPTkZJR19WTEFO XzgwMjFRPW0KQ09ORklHX1ZMQU5fODAyMVFfR1ZSUD15CkNPTkZJR19WTEFOXzgwMjFRX01W UlA9eQojIENPTkZJR19ERUNORVQgaXMgbm90IHNldApDT05GSUdfTExDPW0KQ09ORklHX0xM QzI9bQpDT05GSUdfQVRBTEs9bQpDT05GSUdfREVWX0FQUExFVEFMSz1tCkNPTkZJR19JUERE UD1tCkNPTkZJR19JUEREUF9FTkNBUD15CiMgQ09ORklHX1gyNSBpcyBub3Qgc2V0CiMgQ09O RklHX0xBUEIgaXMgbm90IHNldApDT05GSUdfUEhPTkVUPW0KQ09ORklHXzZMT1dQQU49bQpD T05GSUdfNkxPV1BBTl9ERUJVR0ZTPXkKQ09ORklHXzZMT1dQQU5fTkhDPW0KQ09ORklHXzZM T1dQQU5fTkhDX0RFU1Q9bQpDT05GSUdfNkxPV1BBTl9OSENfRlJBR01FTlQ9bQpDT05GSUdf NkxPV1BBTl9OSENfSE9QPW0KQ09ORklHXzZMT1dQQU5fTkhDX0lQVjY9bQpDT05GSUdfNkxP V1BBTl9OSENfTU9CSUxJVFk9bQpDT05GSUdfNkxPV1BBTl9OSENfUk9VVElORz1tCkNPTkZJ R182TE9XUEFOX05IQ19VRFA9bQpDT05GSUdfNkxPV1BBTl9HSENfRVhUX0hEUl9IT1A9bQpD T05GSUdfNkxPV1BBTl9HSENfVURQPW0KQ09ORklHXzZMT1dQQU5fR0hDX0lDTVBWNj1tCkNP TkZJR182TE9XUEFOX0dIQ19FWFRfSERSX0RFU1Q9bQpDT05GSUdfNkxPV1BBTl9HSENfRVhU X0hEUl9GUkFHPW0KQ09ORklHXzZMT1dQQU5fR0hDX0VYVF9IRFJfUk9VVEU9bQpDT05GSUdf SUVFRTgwMjE1ND1tCkNPTkZJR19JRUVFODAyMTU0X05MODAyMTU0X0VYUEVSSU1FTlRBTD15 CkNPTkZJR19JRUVFODAyMTU0X1NPQ0tFVD1tCkNPTkZJR19JRUVFODAyMTU0XzZMT1dQQU49 bQpDT05GSUdfTUFDODAyMTU0PW0KQ09ORklHX05FVF9TQ0hFRD15CgojCiMgUXVldWVpbmcv U2NoZWR1bGluZwojCkNPTkZJR19ORVRfU0NIX0NCUT1tCkNPTkZJR19ORVRfU0NIX0hUQj1t CkNPTkZJR19ORVRfU0NIX0hGU0M9bQpDT05GSUdfTkVUX1NDSF9BVE09bQpDT05GSUdfTkVU X1NDSF9QUklPPW0KQ09ORklHX05FVF9TQ0hfTVVMVElRPW0KQ09ORklHX05FVF9TQ0hfUkVE PW0KQ09ORklHX05FVF9TQ0hfU0ZCPW0KQ09ORklHX05FVF9TQ0hfU0ZRPW0KQ09ORklHX05F VF9TQ0hfVEVRTD1tCkNPTkZJR19ORVRfU0NIX1RCRj1tCkNPTkZJR19ORVRfU0NIX0NCUz1t CkNPTkZJR19ORVRfU0NIX0VURj1tCkNPTkZJR19ORVRfU0NIX1RBUFJJTz1tCkNPTkZJR19O RVRfU0NIX0dSRUQ9bQpDT05GSUdfTkVUX1NDSF9EU01BUks9bQpDT05GSUdfTkVUX1NDSF9O RVRFTT1tCkNPTkZJR19ORVRfU0NIX0RSUj1tCkNPTkZJR19ORVRfU0NIX01RUFJJTz1tCkNP TkZJR19ORVRfU0NIX1NLQlBSSU89bQpDT05GSUdfTkVUX1NDSF9DSE9LRT1tCkNPTkZJR19O RVRfU0NIX1FGUT1tCkNPTkZJR19ORVRfU0NIX0NPREVMPW0KQ09ORklHX05FVF9TQ0hfRlFf Q09ERUw9eQpDT05GSUdfTkVUX1NDSF9DQUtFPW0KQ09ORklHX05FVF9TQ0hfRlE9bQpDT05G SUdfTkVUX1NDSF9ISEY9bQpDT05GSUdfTkVUX1NDSF9QSUU9bQpDT05GSUdfTkVUX1NDSF9G UV9QSUU9bQpDT05GSUdfTkVUX1NDSF9JTkdSRVNTPW0KQ09ORklHX05FVF9TQ0hfUExVRz1t CkNPTkZJR19ORVRfU0NIX0VUUz1tCkNPTkZJR19ORVRfU0NIX0RFRkFVTFQ9eQojIENPTkZJ R19ERUZBVUxUX0ZRIGlzIG5vdCBzZXQKIyBDT05GSUdfREVGQVVMVF9DT0RFTCBpcyBub3Qg c2V0CkNPTkZJR19ERUZBVUxUX0ZRX0NPREVMPXkKIyBDT05GSUdfREVGQVVMVF9GUV9QSUUg aXMgbm90IHNldAojIENPTkZJR19ERUZBVUxUX1NGUSBpcyBub3Qgc2V0CiMgQ09ORklHX0RF RkFVTFRfUEZJRk9fRkFTVCBpcyBub3Qgc2V0CkNPTkZJR19ERUZBVUxUX05FVF9TQ0g9ImZx X2NvZGVsIgoKIwojIENsYXNzaWZpY2F0aW9uCiMKQ09ORklHX05FVF9DTFM9eQpDT05GSUdf TkVUX0NMU19CQVNJQz1tCkNPTkZJR19ORVRfQ0xTX1RDSU5ERVg9bQpDT05GSUdfTkVUX0NM U19ST1VURTQ9bQpDT05GSUdfTkVUX0NMU19GVz1tCkNPTkZJR19ORVRfQ0xTX1UzMj1tCkNP TkZJR19DTFNfVTMyX1BFUkY9eQpDT05GSUdfQ0xTX1UzMl9NQVJLPXkKQ09ORklHX05FVF9D TFNfUlNWUD1tCkNPTkZJR19ORVRfQ0xTX1JTVlA2PW0KQ09ORklHX05FVF9DTFNfRkxPVz1t CkNPTkZJR19ORVRfQ0xTX0NHUk9VUD1tCkNPTkZJR19ORVRfQ0xTX0JQRj1tCkNPTkZJR19O RVRfQ0xTX0ZMT1dFUj1tCkNPTkZJR19ORVRfQ0xTX01BVENIQUxMPW0KQ09ORklHX05FVF9F TUFUQ0g9eQpDT05GSUdfTkVUX0VNQVRDSF9TVEFDSz0zMgpDT05GSUdfTkVUX0VNQVRDSF9D TVA9bQpDT05GSUdfTkVUX0VNQVRDSF9OQllURT1tCkNPTkZJR19ORVRfRU1BVENIX1UzMj1t CkNPTkZJR19ORVRfRU1BVENIX01FVEE9bQpDT05GSUdfTkVUX0VNQVRDSF9URVhUPW0KQ09O RklHX05FVF9FTUFUQ0hfQ0FOSUQ9bQpDT05GSUdfTkVUX0VNQVRDSF9JUFNFVD1tCkNPTkZJ R19ORVRfRU1BVENIX0lQVD1tCkNPTkZJR19ORVRfQ0xTX0FDVD15CkNPTkZJR19ORVRfQUNU X1BPTElDRT1tCkNPTkZJR19ORVRfQUNUX0dBQ1Q9bQpDT05GSUdfR0FDVF9QUk9CPXkKQ09O RklHX05FVF9BQ1RfTUlSUkVEPW0KQ09ORklHX05FVF9BQ1RfU0FNUExFPW0KQ09ORklHX05F VF9BQ1RfSVBUPW0KQ09ORklHX05FVF9BQ1RfTkFUPW0KQ09ORklHX05FVF9BQ1RfUEVESVQ9 bQpDT05GSUdfTkVUX0FDVF9TSU1QPW0KQ09ORklHX05FVF9BQ1RfU0tCRURJVD1tCkNPTkZJ R19ORVRfQUNUX0NTVU09bQpDT05GSUdfTkVUX0FDVF9NUExTPW0KQ09ORklHX05FVF9BQ1Rf VkxBTj1tCkNPTkZJR19ORVRfQUNUX0JQRj1tCkNPTkZJR19ORVRfQUNUX0NPTk5NQVJLPW0K Q09ORklHX05FVF9BQ1RfQ1RJTkZPPW0KQ09ORklHX05FVF9BQ1RfU0tCTU9EPW0KQ09ORklH X05FVF9BQ1RfSUZFPW0KQ09ORklHX05FVF9BQ1RfVFVOTkVMX0tFWT1tCkNPTkZJR19ORVRf QUNUX0NUPW0KQ09ORklHX05FVF9BQ1RfR0FURT1tCkNPTkZJR19ORVRfSUZFX1NLQk1BUks9 bQpDT05GSUdfTkVUX0lGRV9TS0JQUklPPW0KQ09ORklHX05FVF9JRkVfU0tCVENJTkRFWD1t CkNPTkZJR19ORVRfVENfU0tCX0VYVD15CkNPTkZJR19ORVRfU0NIX0ZJRk89eQpDT05GSUdf RENCPXkKQ09ORklHX0ROU19SRVNPTFZFUj1tCkNPTkZJR19CQVRNQU5fQURWPW0KQ09ORklH X0JBVE1BTl9BRFZfQkFUTUFOX1Y9eQpDT05GSUdfQkFUTUFOX0FEVl9CTEE9eQpDT05GSUdf QkFUTUFOX0FEVl9EQVQ9eQpDT05GSUdfQkFUTUFOX0FEVl9OQz15CkNPTkZJR19CQVRNQU5f QURWX01DQVNUPXkKIyBDT05GSUdfQkFUTUFOX0FEVl9ERUJVRyBpcyBub3Qgc2V0CiMgQ09O RklHX0JBVE1BTl9BRFZfVFJBQ0lORyBpcyBub3Qgc2V0CkNPTkZJR19PUEVOVlNXSVRDSD1t CkNPTkZJR19PUEVOVlNXSVRDSF9HUkU9bQpDT05GSUdfT1BFTlZTV0lUQ0hfVlhMQU49bQpD T05GSUdfT1BFTlZTV0lUQ0hfR0VORVZFPW0KQ09ORklHX1ZTT0NLRVRTPW0KQ09ORklHX1ZT T0NLRVRTX0RJQUc9bQpDT05GSUdfVlNPQ0tFVFNfTE9PUEJBQ0s9bQpDT05GSUdfVk1XQVJF X1ZNQ0lfVlNPQ0tFVFM9bQpDT05GSUdfVklSVElPX1ZTT0NLRVRTPW0KQ09ORklHX1ZJUlRJ T19WU09DS0VUU19DT01NT049bQpDT05GSUdfSFlQRVJWX1ZTT0NLRVRTPW0KQ09ORklHX05F VExJTktfRElBRz1tCkNPTkZJR19NUExTPXkKQ09ORklHX05FVF9NUExTX0dTTz1tCkNPTkZJ R19NUExTX1JPVVRJTkc9bQpDT05GSUdfTVBMU19JUFRVTk5FTD1tCkNPTkZJR19ORVRfTlNI PW0KQ09ORklHX0hTUj1tCkNPTkZJR19ORVRfU1dJVENIREVWPXkKQ09ORklHX05FVF9MM19N QVNURVJfREVWPXkKQ09ORklHX1FSVFI9bQpDT05GSUdfUVJUUl9TTUQ9bQpDT05GSUdfUVJU Ul9UVU49bQpDT05GSUdfUVJUUl9NSEk9bQpDT05GSUdfTkVUX05DU0k9eQpDT05GSUdfTkNT SV9PRU1fQ01EX0dFVF9NQUM9eQpDT05GSUdfUlBTPXkKQ09ORklHX1JGU19BQ0NFTD15CkNP TkZJR19TT0NLX1JYX1FVRVVFX01BUFBJTkc9eQpDT05GSUdfWFBTPXkKQ09ORklHX0NHUk9V UF9ORVRfUFJJTz15CkNPTkZJR19DR1JPVVBfTkVUX0NMQVNTSUQ9eQpDT05GSUdfTkVUX1JY X0JVU1lfUE9MTD15CkNPTkZJR19CUUw9eQpDT05GSUdfQlBGX0pJVD15CkNPTkZJR19CUEZf U1RSRUFNX1BBUlNFUj15CkNPTkZJR19ORVRfRkxPV19MSU1JVD15CgojCiMgTmV0d29yayB0 ZXN0aW5nCiMKQ09ORklHX05FVF9QS1RHRU49bQpDT05GSUdfTkVUX0RST1BfTU9OSVRPUj15 CiMgZW5kIG9mIE5ldHdvcmsgdGVzdGluZwojIGVuZCBvZiBOZXR3b3JraW5nIG9wdGlvbnMK CkNPTkZJR19IQU1SQURJTz15CgojCiMgUGFja2V0IFJhZGlvIHByb3RvY29scwojCkNPTkZJ R19BWDI1PW0KQ09ORklHX0FYMjVfREFNQV9TTEFWRT15CkNPTkZJR19ORVRST009bQpDT05G SUdfUk9TRT1tCgojCiMgQVguMjUgbmV0d29yayBkZXZpY2UgZHJpdmVycwojCkNPTkZJR19N S0lTUz1tCkNPTkZJR182UEFDSz1tCkNPTkZJR19CUFFFVEhFUj1tCkNPTkZJR19CQVlDT01f U0VSX0ZEWD1tCkNPTkZJR19CQVlDT01fU0VSX0hEWD1tCkNPTkZJR19CQVlDT01fUEFSPW0K Q09ORklHX1lBTT1tCiMgZW5kIG9mIEFYLjI1IG5ldHdvcmsgZGV2aWNlIGRyaXZlcnMKCkNP TkZJR19DQU49bQpDT05GSUdfQ0FOX1JBVz1tCkNPTkZJR19DQU5fQkNNPW0KQ09ORklHX0NB Tl9HVz1tCkNPTkZJR19DQU5fSjE5Mzk9bQpDT05GSUdfQ0FOX0lTT1RQPW0KCiMKIyBDQU4g RGV2aWNlIERyaXZlcnMKIwpDT05GSUdfQ0FOX1ZDQU49bQpDT05GSUdfQ0FOX1ZYQ0FOPW0K Q09ORklHX0NBTl9TTENBTj1tCkNPTkZJR19DQU5fREVWPW0KQ09ORklHX0NBTl9DQUxDX0JJ VFRJTUlORz15CkNPTkZJR19DQU5fSkFOWl9JQ0FOMz1tCkNPTkZJR19DQU5fS1ZBU0VSX1BD SUVGRD1tCkNPTkZJR19DQU5fQ19DQU49bQpDT05GSUdfQ0FOX0NfQ0FOX1BMQVRGT1JNPW0K Q09ORklHX0NBTl9DX0NBTl9QQ0k9bQpDT05GSUdfQ0FOX0NDNzcwPW0KIyBDT05GSUdfQ0FO X0NDNzcwX0lTQSBpcyBub3Qgc2V0CkNPTkZJR19DQU5fQ0M3NzBfUExBVEZPUk09bQpDT05G SUdfQ0FOX0lGSV9DQU5GRD1tCkNPTkZJR19DQU5fTV9DQU49bQpDT05GSUdfQ0FOX01fQ0FO X1BDST1tCkNPTkZJR19DQU5fTV9DQU5fUExBVEZPUk09bQpDT05GSUdfQ0FOX01fQ0FOX1RD QU40WDVYPW0KQ09ORklHX0NBTl9QRUFLX1BDSUVGRD1tCkNPTkZJR19DQU5fU0pBMTAwMD1t CkNPTkZJR19DQU5fRU1TX1BDST1tCiMgQ09ORklHX0NBTl9FTVNfUENNQ0lBIGlzIG5vdCBz ZXQKQ09ORklHX0NBTl9GODE2MDE9bQpDT05GSUdfQ0FOX0tWQVNFUl9QQ0k9bQpDT05GSUdf Q0FOX1BFQUtfUENJPW0KQ09ORklHX0NBTl9QRUFLX1BDSUVDPXkKQ09ORklHX0NBTl9QRUFL X1BDTUNJQT1tCkNPTkZJR19DQU5fUExYX1BDST1tCiMgQ09ORklHX0NBTl9TSkExMDAwX0lT QSBpcyBub3Qgc2V0CkNPTkZJR19DQU5fU0pBMTAwMF9QTEFURk9STT1tCkNPTkZJR19DQU5f U09GVElORz1tCkNPTkZJR19DQU5fU09GVElOR19DUz1tCgojCiMgQ0FOIFNQSSBpbnRlcmZh Y2VzCiMKQ09ORklHX0NBTl9ISTMxMVg9bQpDT05GSUdfQ0FOX01DUDI1MVg9bQpDT05GSUdf Q0FOX01DUDI1MVhGRD1tCiMgQ09ORklHX0NBTl9NQ1AyNTFYRkRfU0FOSVRZIGlzIG5vdCBz ZXQKIyBlbmQgb2YgQ0FOIFNQSSBpbnRlcmZhY2VzCgojCiMgQ0FOIFVTQiBpbnRlcmZhY2Vz CiMKQ09ORklHX0NBTl84REVWX1VTQj1tCkNPTkZJR19DQU5fRU1TX1VTQj1tCkNPTkZJR19D QU5fRVNEX1VTQjI9bQpDT05GSUdfQ0FOX0dTX1VTQj1tCkNPTkZJR19DQU5fS1ZBU0VSX1VT Qj1tCkNPTkZJR19DQU5fTUNCQV9VU0I9bQpDT05GSUdfQ0FOX1BFQUtfVVNCPW0KQ09ORklH X0NBTl9VQ0FOPW0KIyBlbmQgb2YgQ0FOIFVTQiBpbnRlcmZhY2VzCgojIENPTkZJR19DQU5f REVCVUdfREVWSUNFUyBpcyBub3Qgc2V0CiMgZW5kIG9mIENBTiBEZXZpY2UgRHJpdmVycwoK Q09ORklHX0JUPW0KQ09ORklHX0JUX0JSRURSPXkKQ09ORklHX0JUX1JGQ09NTT1tCkNPTkZJ R19CVF9SRkNPTU1fVFRZPXkKQ09ORklHX0JUX0JORVA9bQpDT05GSUdfQlRfQk5FUF9NQ19G SUxURVI9eQpDT05GSUdfQlRfQk5FUF9QUk9UT19GSUxURVI9eQpDT05GSUdfQlRfQ01UUD1t CkNPTkZJR19CVF9ISURQPW0KIyBDT05GSUdfQlRfSFMgaXMgbm90IHNldApDT05GSUdfQlRf TEU9eQpDT05GSUdfQlRfNkxPV1BBTj1tCkNPTkZJR19CVF9MRURTPXkKQ09ORklHX0JUX01T RlRFWFQ9eQpDT05GSUdfQlRfREVCVUdGUz15CiMgQ09ORklHX0JUX1NFTEZURVNUIGlzIG5v dCBzZXQKCiMKIyBCbHVldG9vdGggZGV2aWNlIGRyaXZlcnMKIwpDT05GSUdfQlRfSU5URUw9 bQpDT05GSUdfQlRfQkNNPW0KQ09ORklHX0JUX1JUTD1tCkNPTkZJR19CVF9RQ0E9bQpDT05G SUdfQlRfSENJQlRVU0I9bQpDT05GSUdfQlRfSENJQlRVU0JfQVVUT1NVU1BFTkQ9eQpDT05G SUdfQlRfSENJQlRVU0JfQkNNPXkKQ09ORklHX0JUX0hDSUJUVVNCX01USz15CkNPTkZJR19C VF9IQ0lCVFVTQl9SVEw9eQpDT05GSUdfQlRfSENJQlRTRElPPW0KQ09ORklHX0JUX0hDSVVB UlQ9bQpDT05GSUdfQlRfSENJVUFSVF9TRVJERVY9eQpDT05GSUdfQlRfSENJVUFSVF9IND15 CkNPTkZJR19CVF9IQ0lVQVJUX05PS0lBPW0KQ09ORklHX0JUX0hDSVVBUlRfQkNTUD15CkNP TkZJR19CVF9IQ0lVQVJUX0FUSDNLPXkKQ09ORklHX0JUX0hDSVVBUlRfTEw9eQpDT05GSUdf QlRfSENJVUFSVF8zV0lSRT15CkNPTkZJR19CVF9IQ0lVQVJUX0lOVEVMPXkKQ09ORklHX0JU X0hDSVVBUlRfQkNNPXkKQ09ORklHX0JUX0hDSVVBUlRfUlRMPXkKQ09ORklHX0JUX0hDSVVB UlRfUUNBPXkKQ09ORklHX0JUX0hDSVVBUlRfQUc2WFg9eQpDT05GSUdfQlRfSENJVUFSVF9N UlZMPXkKQ09ORklHX0JUX0hDSUJDTTIwM1g9bQpDT05GSUdfQlRfSENJQlBBMTBYPW0KQ09O RklHX0JUX0hDSUJGVVNCPW0KQ09ORklHX0JUX0hDSURUTDE9bQpDT05GSUdfQlRfSENJQlQz Qz1tCkNPTkZJR19CVF9IQ0lCTFVFQ0FSRD1tCkNPTkZJR19CVF9IQ0lWSENJPW0KQ09ORklH X0JUX01SVkw9bQpDT05GSUdfQlRfTVJWTF9TRElPPW0KQ09ORklHX0JUX0FUSDNLPW0KQ09O RklHX0JUX01US1NESU89bQpDT05GSUdfQlRfTVRLVUFSVD1tCkNPTkZJR19CVF9IQ0lSU0k9 bQojIGVuZCBvZiBCbHVldG9vdGggZGV2aWNlIGRyaXZlcnMKCkNPTkZJR19BRl9SWFJQQz1t CkNPTkZJR19BRl9SWFJQQ19JUFY2PXkKIyBDT05GSUdfQUZfUlhSUENfSU5KRUNUX0xPU1Mg aXMgbm90IHNldApDT05GSUdfQUZfUlhSUENfREVCVUc9eQpDT05GSUdfUlhLQUQ9eQpDT05G SUdfQUZfS0NNPW0KQ09ORklHX1NUUkVBTV9QQVJTRVI9eQpDT05GSUdfRklCX1JVTEVTPXkK Q09ORklHX1dJUkVMRVNTPXkKQ09ORklHX1dJUkVMRVNTX0VYVD15CkNPTkZJR19XRVhUX0NP UkU9eQpDT05GSUdfV0VYVF9QUk9DPXkKQ09ORklHX1dFWFRfU1BZPXkKQ09ORklHX1dFWFRf UFJJVj15CkNPTkZJR19DRkc4MDIxMT1tCiMgQ09ORklHX05MODAyMTFfVEVTVE1PREUgaXMg bm90IHNldAojIENPTkZJR19DRkc4MDIxMV9ERVZFTE9QRVJfV0FSTklOR1MgaXMgbm90IHNl dApDT05GSUdfQ0ZHODAyMTFfUkVRVUlSRV9TSUdORURfUkVHREI9eQpDT05GSUdfQ0ZHODAy MTFfVVNFX0tFUk5FTF9SRUdEQl9LRVlTPXkKQ09ORklHX0NGRzgwMjExX0RFRkFVTFRfUFM9 eQpDT05GSUdfQ0ZHODAyMTFfREVCVUdGUz15CkNPTkZJR19DRkc4MDIxMV9DUkRBX1NVUFBP UlQ9eQpDT05GSUdfQ0ZHODAyMTFfV0VYVD15CkNPTkZJR19DRkc4MDIxMV9XRVhUX0VYUE9S VD15CkNPTkZJR19MSUI4MDIxMT1tCkNPTkZJR19MSUI4MDIxMV9DUllQVF9XRVA9bQpDT05G SUdfTElCODAyMTFfQ1JZUFRfQ0NNUD1tCkNPTkZJR19MSUI4MDIxMV9DUllQVF9US0lQPW0K IyBDT05GSUdfTElCODAyMTFfREVCVUcgaXMgbm90IHNldApDT05GSUdfTUFDODAyMTE9bQpD T05GSUdfTUFDODAyMTFfSEFTX1JDPXkKQ09ORklHX01BQzgwMjExX1JDX01JTlNUUkVMPXkK Q09ORklHX01BQzgwMjExX1JDX0RFRkFVTFRfTUlOU1RSRUw9eQpDT05GSUdfTUFDODAyMTFf UkNfREVGQVVMVD0ibWluc3RyZWxfaHQiCkNPTkZJR19NQUM4MDIxMV9NRVNIPXkKQ09ORklH X01BQzgwMjExX0xFRFM9eQpDT05GSUdfTUFDODAyMTFfREVCVUdGUz15CiMgQ09ORklHX01B QzgwMjExX01FU1NBR0VfVFJBQ0lORyBpcyBub3Qgc2V0CiMgQ09ORklHX01BQzgwMjExX0RF QlVHX01FTlUgaXMgbm90IHNldApDT05GSUdfTUFDODAyMTFfU1RBX0hBU0hfTUFYX1NJWkU9 MApDT05GSUdfUkZLSUxMPW0KQ09ORklHX1JGS0lMTF9MRURTPXkKQ09ORklHX1JGS0lMTF9J TlBVVD15CkNPTkZJR19SRktJTExfR1BJTz1tCkNPTkZJR19ORVRfOVA9bQpDT05GSUdfTkVU XzlQX1ZJUlRJTz1tCkNPTkZJR19ORVRfOVBfWEVOPW0KQ09ORklHX05FVF85UF9SRE1BPW0K IyBDT05GSUdfTkVUXzlQX0RFQlVHIGlzIG5vdCBzZXQKIyBDT05GSUdfQ0FJRiBpcyBub3Qg c2V0CkNPTkZJR19DRVBIX0xJQj1tCkNPTkZJR19DRVBIX0xJQl9QUkVUVFlERUJVRz15CkNP TkZJR19DRVBIX0xJQl9VU0VfRE5TX1JFU09MVkVSPXkKQ09ORklHX05GQz1tCkNPTkZJR19O RkNfRElHSVRBTD1tCkNPTkZJR19ORkNfTkNJPW0KQ09ORklHX05GQ19OQ0lfU1BJPW0KQ09O RklHX05GQ19OQ0lfVUFSVD1tCkNPTkZJR19ORkNfSENJPW0KQ09ORklHX05GQ19TSERMQz15 CgojCiMgTmVhciBGaWVsZCBDb21tdW5pY2F0aW9uIChORkMpIGRldmljZXMKIwpDT05GSUdf TkZDX1RSRjc5NzBBPW0KQ09ORklHX05GQ19NRUlfUEhZPW0KQ09ORklHX05GQ19TSU09bQpD T05GSUdfTkZDX1BPUlQxMDA9bQpDT05GSUdfTkZDX1ZJUlRVQUxfTkNJPW0KQ09ORklHX05G Q19GRFA9bQpDT05GSUdfTkZDX0ZEUF9JMkM9bQpDT05GSUdfTkZDX1BONTQ0PW0KQ09ORklH X05GQ19QTjU0NF9JMkM9bQpDT05GSUdfTkZDX1BONTQ0X01FST1tCkNPTkZJR19ORkNfUE41 MzM9bQpDT05GSUdfTkZDX1BONTMzX1VTQj1tCkNPTkZJR19ORkNfUE41MzNfSTJDPW0KQ09O RklHX05GQ19QTjUzMl9VQVJUPW0KQ09ORklHX05GQ19NSUNST1JFQUQ9bQpDT05GSUdfTkZD X01JQ1JPUkVBRF9JMkM9bQpDT05GSUdfTkZDX01JQ1JPUkVBRF9NRUk9bQpDT05GSUdfTkZD X01SVkw9bQpDT05GSUdfTkZDX01SVkxfVVNCPW0KQ09ORklHX05GQ19NUlZMX1VBUlQ9bQpD T05GSUdfTkZDX01SVkxfSTJDPW0KQ09ORklHX05GQ19NUlZMX1NQST1tCkNPTkZJR19ORkNf U1QyMU5GQ0E9bQpDT05GSUdfTkZDX1NUMjFORkNBX0kyQz1tCkNPTkZJR19ORkNfU1RfTkNJ PW0KQ09ORklHX05GQ19TVF9OQ0lfSTJDPW0KQ09ORklHX05GQ19TVF9OQ0lfU1BJPW0KQ09O RklHX05GQ19OWFBfTkNJPW0KQ09ORklHX05GQ19OWFBfTkNJX0kyQz1tCkNPTkZJR19ORkNf UzNGV1JONT1tCkNPTkZJR19ORkNfUzNGV1JONV9JMkM9bQpDT05GSUdfTkZDX1MzRldSTjgy X1VBUlQ9bQpDT05GSUdfTkZDX1NUOTVIRj1tCiMgZW5kIG9mIE5lYXIgRmllbGQgQ29tbXVu aWNhdGlvbiAoTkZDKSBkZXZpY2VzCgpDT05GSUdfUFNBTVBMRT1tCkNPTkZJR19ORVRfSUZF PW0KQ09ORklHX0xXVFVOTkVMPXkKQ09ORklHX0xXVFVOTkVMX0JQRj15CkNPTkZJR19EU1Rf Q0FDSEU9eQpDT05GSUdfR1JPX0NFTExTPXkKQ09ORklHX1NPQ0tfVkFMSURBVEVfWE1JVD15 CkNPTkZJR19ORVRfU09DS19NU0c9eQpDT05GSUdfTkVUX0RFVkxJTks9eQpDT05GSUdfUEFH RV9QT09MPXkKQ09ORklHX0ZBSUxPVkVSPW0KQ09ORklHX0VUSFRPT0xfTkVUTElOSz15CkNP TkZJR19IQVZFX0VCUEZfSklUPXkKCiMKIyBEZXZpY2UgRHJpdmVycwojCkNPTkZJR19IQVZF X0VJU0E9eQojIENPTkZJR19FSVNBIGlzIG5vdCBzZXQKQ09ORklHX0hBVkVfUENJPXkKQ09O RklHX1BDST15CkNPTkZJR19QQ0lfRE9NQUlOUz15CkNPTkZJR19QQ0lFUE9SVEJVUz15CkNP TkZJR19IT1RQTFVHX1BDSV9QQ0lFPXkKQ09ORklHX1BDSUVBRVI9eQpDT05GSUdfUENJRUFF Ul9JTkpFQ1Q9bQpDT05GSUdfUENJRV9FQ1JDPXkKQ09ORklHX1BDSUVBU1BNPXkKQ09ORklH X1BDSUVBU1BNX0RFRkFVTFQ9eQojIENPTkZJR19QQ0lFQVNQTV9QT1dFUlNBVkUgaXMgbm90 IHNldAojIENPTkZJR19QQ0lFQVNQTV9QT1dFUl9TVVBFUlNBVkUgaXMgbm90IHNldAojIENP TkZJR19QQ0lFQVNQTV9QRVJGT1JNQU5DRSBpcyBub3Qgc2V0CkNPTkZJR19QQ0lFX1BNRT15 CkNPTkZJR19QQ0lFX0RQQz15CkNPTkZJR19QQ0lFX1BUTT15CkNPTkZJR19QQ0lFX0VEUj15 CkNPTkZJR19QQ0lfTVNJPXkKQ09ORklHX1BDSV9NU0lfSVJRX0RPTUFJTj15CkNPTkZJR19Q Q0lfUVVJUktTPXkKIyBDT05GSUdfUENJX0RFQlVHIGlzIG5vdCBzZXQKIyBDT05GSUdfUENJ X1JFQUxMT0NfRU5BQkxFX0FVVE8gaXMgbm90IHNldApDT05GSUdfUENJX1NUVUI9eQpDT05G SUdfUENJX1BGX1NUVUI9bQpDT05GSUdfWEVOX1BDSURFVl9GUk9OVEVORD1tCkNPTkZJR19Q Q0lfQVRTPXkKQ09ORklHX1BDSV9MT0NLTEVTU19DT05GSUc9eQpDT05GSUdfUENJX0lPVj15 CkNPTkZJR19QQ0lfUFJJPXkKQ09ORklHX1BDSV9QQVNJRD15CkNPTkZJR19QQ0lfUDJQRE1B PXkKQ09ORklHX1BDSV9MQUJFTD15CkNPTkZJR19QQ0lfSFlQRVJWPW0KQ09ORklHX0hPVFBM VUdfUENJPXkKQ09ORklHX0hPVFBMVUdfUENJX0FDUEk9eQpDT05GSUdfSE9UUExVR19QQ0lf QUNQSV9JQk09bQpDT05GSUdfSE9UUExVR19QQ0lfQ1BDST15CkNPTkZJR19IT1RQTFVHX1BD SV9DUENJX1pUNTU1MD1tCkNPTkZJR19IT1RQTFVHX1BDSV9DUENJX0dFTkVSSUM9bQpDT05G SUdfSE9UUExVR19QQ0lfU0hQQz15CgojCiMgUENJIGNvbnRyb2xsZXIgZHJpdmVycwojCkNP TkZJR19WTUQ9bQpDT05GSUdfUENJX0hZUEVSVl9JTlRFUkZBQ0U9bQoKIwojIERlc2lnbldh cmUgUENJIENvcmUgU3VwcG9ydAojCkNPTkZJR19QQ0lFX0RXPXkKQ09ORklHX1BDSUVfRFdf SE9TVD15CkNPTkZJR19QQ0lFX0RXX1BMQVQ9eQpDT05GSUdfUENJRV9EV19QTEFUX0hPU1Q9 eQpDT05GSUdfUENJX01FU09OPXkKIyBlbmQgb2YgRGVzaWduV2FyZSBQQ0kgQ29yZSBTdXBw b3J0CgojCiMgTW9iaXZlaWwgUENJZSBDb3JlIFN1cHBvcnQKIwojIGVuZCBvZiBNb2JpdmVp bCBQQ0llIENvcmUgU3VwcG9ydAoKIwojIENhZGVuY2UgUENJZSBjb250cm9sbGVycyBzdXBw b3J0CiMKIyBlbmQgb2YgQ2FkZW5jZSBQQ0llIGNvbnRyb2xsZXJzIHN1cHBvcnQKIyBlbmQg b2YgUENJIGNvbnRyb2xsZXIgZHJpdmVycwoKIwojIFBDSSBFbmRwb2ludAojCiMgQ09ORklH X1BDSV9FTkRQT0lOVCBpcyBub3Qgc2V0CiMgZW5kIG9mIFBDSSBFbmRwb2ludAoKIwojIFBD SSBzd2l0Y2ggY29udHJvbGxlciBkcml2ZXJzCiMKQ09ORklHX1BDSV9TV19TV0lUQ0hURUM9 bQojIGVuZCBvZiBQQ0kgc3dpdGNoIGNvbnRyb2xsZXIgZHJpdmVycwoKQ09ORklHX0NYTF9C VVM9bQpDT05GSUdfQ1hMX01FTT1tCiMgQ09ORklHX0NYTF9NRU1fUkFXX0NPTU1BTkRTIGlz IG5vdCBzZXQKQ09ORklHX1BDQ0FSRD1tCkNPTkZJR19QQ01DSUE9bQpDT05GSUdfUENNQ0lB X0xPQURfQ0lTPXkKQ09ORklHX0NBUkRCVVM9eQoKIwojIFBDLWNhcmQgYnJpZGdlcwojCkNP TkZJR19ZRU5UQT1tCkNPTkZJR19ZRU5UQV9PMj15CkNPTkZJR19ZRU5UQV9SSUNPSD15CkNP TkZJR19ZRU5UQV9UST15CkNPTkZJR19ZRU5UQV9FTkVfVFVORT15CkNPTkZJR19ZRU5UQV9U T1NISUJBPXkKQ09ORklHX1BENjcyOT1tCkNPTkZJR19JODIwOTI9bQpDT05GSUdfUENDQVJE X05PTlNUQVRJQz15CiMgQ09ORklHX1JBUElESU8gaXMgbm90IHNldAoKIwojIEdlbmVyaWMg RHJpdmVyIE9wdGlvbnMKIwpDT05GSUdfQVVYSUxJQVJZX0JVUz15CiMgQ09ORklHX1VFVkVO VF9IRUxQRVIgaXMgbm90IHNldApDT05GSUdfREVWVE1QRlM9eQpDT05GSUdfREVWVE1QRlNf TU9VTlQ9eQpDT05GSUdfU1RBTkRBTE9ORT15CkNPTkZJR19QUkVWRU5UX0ZJUk1XQVJFX0JV SUxEPXkKCiMKIyBGaXJtd2FyZSBsb2FkZXIKIwpDT05GSUdfRldfTE9BREVSPXkKQ09ORklH X0ZXX0xPQURFUl9QQUdFRF9CVUY9eQpDT05GSUdfRVhUUkFfRklSTVdBUkU9IiIKIyBDT05G SUdfRldfTE9BREVSX1VTRVJfSEVMUEVSIGlzIG5vdCBzZXQKQ09ORklHX0ZXX0xPQURFUl9D T01QUkVTUz15CkNPTkZJR19GV19DQUNIRT15CiMgZW5kIG9mIEZpcm13YXJlIGxvYWRlcgoK Q09ORklHX1dBTlRfREVWX0NPUkVEVU1QPXkKQ09ORklHX0FMTE9XX0RFVl9DT1JFRFVNUD15 CkNPTkZJR19ERVZfQ09SRURVTVA9eQojIENPTkZJR19ERUJVR19EUklWRVIgaXMgbm90IHNl dAojIENPTkZJR19ERUJVR19ERVZSRVMgaXMgbm90IHNldAojIENPTkZJR19ERUJVR19URVNU X0RSSVZFUl9SRU1PVkUgaXMgbm90IHNldApDT05GSUdfSE1FTV9SRVBPUlRJTkc9eQojIENP TkZJR19URVNUX0FTWU5DX0RSSVZFUl9QUk9CRSBpcyBub3Qgc2V0CkNPTkZJR19TWVNfSFlQ RVJWSVNPUj15CkNPTkZJR19HRU5FUklDX0NQVV9BVVRPUFJPQkU9eQpDT05GSUdfR0VORVJJ Q19DUFVfVlVMTkVSQUJJTElUSUVTPXkKQ09ORklHX1JFR01BUD15CkNPTkZJR19SRUdNQVBf STJDPXkKQ09ORklHX1JFR01BUF9TTElNQlVTPW0KQ09ORklHX1JFR01BUF9TUEk9eQpDT05G SUdfUkVHTUFQX1cxPW0KQ09ORklHX1JFR01BUF9NTUlPPXkKQ09ORklHX1JFR01BUF9JUlE9 eQpDT05GSUdfUkVHTUFQX1NPVU5EV0lSRT1tCkNPTkZJR19SRUdNQVBfU0NDQj1tCkNPTkZJ R19SRUdNQVBfU1BJX0FWTU09bQpDT05GSUdfRE1BX1NIQVJFRF9CVUZGRVI9eQojIENPTkZJ R19ETUFfRkVOQ0VfVFJBQ0UgaXMgbm90IHNldAojIGVuZCBvZiBHZW5lcmljIERyaXZlciBP cHRpb25zCgojCiMgQnVzIGRldmljZXMKIwpDT05GSUdfTUhJX0JVUz1tCiMgQ09ORklHX01I SV9CVVNfREVCVUcgaXMgbm90IHNldApDT05GSUdfTUhJX0JVU19QQ0lfR0VORVJJQz1tCiMg ZW5kIG9mIEJ1cyBkZXZpY2VzCgpDT05GSUdfQ09OTkVDVE9SPXkKQ09ORklHX1BST0NfRVZF TlRTPXkKQ09ORklHX0dOU1M9bQpDT05GSUdfR05TU19TRVJJQUw9bQpDT05GSUdfR05TU19N VEtfU0VSSUFMPW0KQ09ORklHX0dOU1NfU0lSRl9TRVJJQUw9bQpDT05GSUdfR05TU19VQlhf U0VSSUFMPW0KQ09ORklHX01URD1tCiMgQ09ORklHX01URF9URVNUUyBpcyBub3Qgc2V0Cgoj CiMgUGFydGl0aW9uIHBhcnNlcnMKIwojIENPTkZJR19NVERfQVI3X1BBUlRTIGlzIG5vdCBz ZXQKIyBDT05GSUdfTVREX0NNRExJTkVfUEFSVFMgaXMgbm90IHNldAojIENPTkZJR19NVERf UkVEQk9PVF9QQVJUUyBpcyBub3Qgc2V0CiMgZW5kIG9mIFBhcnRpdGlvbiBwYXJzZXJzCgoj CiMgVXNlciBNb2R1bGVzIEFuZCBUcmFuc2xhdGlvbiBMYXllcnMKIwpDT05GSUdfTVREX0JM S0RFVlM9bQpDT05GSUdfTVREX0JMT0NLPW0KIyBDT05GSUdfTVREX0JMT0NLX1JPIGlzIG5v dCBzZXQKIyBDT05GSUdfRlRMIGlzIG5vdCBzZXQKIyBDT05GSUdfTkZUTCBpcyBub3Qgc2V0 CiMgQ09ORklHX0lORlRMIGlzIG5vdCBzZXQKIyBDT05GSUdfUkZEX0ZUTCBpcyBub3Qgc2V0 CiMgQ09ORklHX1NTRkRDIGlzIG5vdCBzZXQKIyBDT05GSUdfU01fRlRMIGlzIG5vdCBzZXQK IyBDT05GSUdfTVREX09PUFMgaXMgbm90IHNldApDT05GSUdfTVREX1BTVE9SRT1tCiMgQ09O RklHX01URF9TV0FQIGlzIG5vdCBzZXQKIyBDT05GSUdfTVREX1BBUlRJVElPTkVEX01BU1RF UiBpcyBub3Qgc2V0CgojCiMgUkFNL1JPTS9GbGFzaCBjaGlwIGRyaXZlcnMKIwojIENPTkZJ R19NVERfQ0ZJIGlzIG5vdCBzZXQKIyBDT05GSUdfTVREX0pFREVDUFJPQkUgaXMgbm90IHNl dApDT05GSUdfTVREX01BUF9CQU5LX1dJRFRIXzE9eQpDT05GSUdfTVREX01BUF9CQU5LX1dJ RFRIXzI9eQpDT05GSUdfTVREX01BUF9CQU5LX1dJRFRIXzQ9eQpDT05GSUdfTVREX0NGSV9J MT15CkNPTkZJR19NVERfQ0ZJX0kyPXkKQ09ORklHX01URF9SQU09bQpDT05GSUdfTVREX1JP TT1tCiMgQ09ORklHX01URF9BQlNFTlQgaXMgbm90IHNldAojIGVuZCBvZiBSQU0vUk9NL0Zs YXNoIGNoaXAgZHJpdmVycwoKIwojIE1hcHBpbmcgZHJpdmVycyBmb3IgY2hpcCBhY2Nlc3MK IwojIENPTkZJR19NVERfQ09NUExFWF9NQVBQSU5HUyBpcyBub3Qgc2V0CiMgQ09ORklHX01U RF9QSFlTTUFQIGlzIG5vdCBzZXQKIyBDT05GSUdfTVREX0lOVEVMX1ZSX05PUiBpcyBub3Qg c2V0CkNPTkZJR19NVERfUExBVFJBTT1tCiMgZW5kIG9mIE1hcHBpbmcgZHJpdmVycyBmb3Ig Y2hpcCBhY2Nlc3MKCiMKIyBTZWxmLWNvbnRhaW5lZCBNVEQgZGV2aWNlIGRyaXZlcnMKIwoj IENPTkZJR19NVERfUE1DNTUxIGlzIG5vdCBzZXQKIyBDT05GSUdfTVREX0RBVEFGTEFTSCBp cyBub3Qgc2V0CiMgQ09ORklHX01URF9NQ0hQMjNLMjU2IGlzIG5vdCBzZXQKIyBDT05GSUdf TVREX1NTVDI1TCBpcyBub3Qgc2V0CiMgQ09ORklHX01URF9TTFJBTSBpcyBub3Qgc2V0CkNP TkZJR19NVERfUEhSQU09bQojIENPTkZJR19NVERfTVREUkFNIGlzIG5vdCBzZXQKQ09ORklH X01URF9CTE9DSzJNVEQ9bQoKIwojIERpc2stT24tQ2hpcCBEZXZpY2UgRHJpdmVycwojCiMg Q09ORklHX01URF9ET0NHMyBpcyBub3Qgc2V0CiMgZW5kIG9mIFNlbGYtY29udGFpbmVkIE1U RCBkZXZpY2UgZHJpdmVycwoKIwojIE5BTkQKIwpDT05GSUdfTVREX05BTkRfQ09SRT1tCiMg Q09ORklHX01URF9PTkVOQU5EIGlzIG5vdCBzZXQKQ09ORklHX01URF9SQVdfTkFORD1tCgoj CiMgUmF3L3BhcmFsbGVsIE5BTkQgZmxhc2ggY29udHJvbGxlcnMKIwojIENPTkZJR19NVERf TkFORF9ERU5BTElfUENJIGlzIG5vdCBzZXQKIyBDT05GSUdfTVREX05BTkRfQ0FGRSBpcyBu b3Qgc2V0CiMgQ09ORklHX01URF9OQU5EX01YSUMgaXMgbm90IHNldAojIENPTkZJR19NVERf TkFORF9HUElPIGlzIG5vdCBzZXQKIyBDT05GSUdfTVREX05BTkRfUExBVEZPUk0gaXMgbm90 IHNldAojIENPTkZJR19NVERfTkFORF9BUkFTQU4gaXMgbm90IHNldAoKIwojIE1pc2MKIwpD T05GSUdfTVREX05BTkRfTkFORFNJTT1tCiMgQ09ORklHX01URF9OQU5EX1JJQ09IIGlzIG5v dCBzZXQKIyBDT05GSUdfTVREX05BTkRfRElTS09OQ0hJUCBpcyBub3Qgc2V0CiMgQ09ORklH X01URF9TUElfTkFORCBpcyBub3Qgc2V0CgojCiMgRUNDIGVuZ2luZSBzdXBwb3J0CiMKQ09O RklHX01URF9OQU5EX0VDQz15CkNPTkZJR19NVERfTkFORF9FQ0NfU1dfSEFNTUlORz15CkNP TkZJR19NVERfTkFORF9FQ0NfU1dfSEFNTUlOR19TTUM9eQpDT05GSUdfTVREX05BTkRfRUND X1NXX0JDSD15CiMgZW5kIG9mIEVDQyBlbmdpbmUgc3VwcG9ydAojIGVuZCBvZiBOQU5ECgoj CiMgTFBERFIgJiBMUEREUjIgUENNIG1lbW9yeSBkcml2ZXJzCiMKIyBDT05GSUdfTVREX0xQ RERSIGlzIG5vdCBzZXQKIyBlbmQgb2YgTFBERFIgJiBMUEREUjIgUENNIG1lbW9yeSBkcml2 ZXJzCgpDT05GSUdfTVREX1NQSV9OT1I9bQpDT05GSUdfTVREX1NQSV9OT1JfVVNFXzRLX1NF Q1RPUlM9eQojIENPTkZJR19NVERfU1BJX05PUl9TV1BfRElTQUJMRSBpcyBub3Qgc2V0CkNP TkZJR19NVERfU1BJX05PUl9TV1BfRElTQUJMRV9PTl9WT0xBVElMRT15CiMgQ09ORklHX01U RF9TUElfTk9SX1NXUF9LRUVQIGlzIG5vdCBzZXQKQ09ORklHX1NQSV9JTlRFTF9TUEk9bQpD T05GSUdfU1BJX0lOVEVMX1NQSV9QQ0k9bQpDT05GSUdfU1BJX0lOVEVMX1NQSV9QTEFURk9S TT1tCkNPTkZJR19NVERfVUJJPW0KQ09ORklHX01URF9VQklfV0xfVEhSRVNIT0xEPTQwOTYK Q09ORklHX01URF9VQklfQkVCX0xJTUlUPTIwCiMgQ09ORklHX01URF9VQklfRkFTVE1BUCBp cyBub3Qgc2V0CiMgQ09ORklHX01URF9VQklfR0xVRUJJIGlzIG5vdCBzZXQKIyBDT05GSUdf TVREX1VCSV9CTE9DSyBpcyBub3Qgc2V0CiMgQ09ORklHX01URF9IWVBFUkJVUyBpcyBub3Qg c2V0CiMgQ09ORklHX09GIGlzIG5vdCBzZXQKQ09ORklHX0FSQ0hfTUlHSFRfSEFWRV9QQ19Q QVJQT1JUPXkKQ09ORklHX1BBUlBPUlQ9bQpDT05GSUdfUEFSUE9SVF9QQz1tCkNPTkZJR19Q QVJQT1JUX1NFUklBTD1tCkNPTkZJR19QQVJQT1JUX1BDX0ZJRk89eQpDT05GSUdfUEFSUE9S VF9QQ19TVVBFUklPPXkKQ09ORklHX1BBUlBPUlRfUENfUENNQ0lBPW0KQ09ORklHX1BBUlBP UlRfQVg4ODc5Nj1tCkNPTkZJR19QQVJQT1JUXzEyODQ9eQpDT05GSUdfUEFSUE9SVF9OT1Rf UEM9eQpDT05GSUdfUE5QPXkKQ09ORklHX1BOUF9ERUJVR19NRVNTQUdFUz15CgojCiMgUHJv dG9jb2xzCiMKQ09ORklHX1BOUEFDUEk9eQpDT05GSUdfQkxLX0RFVj15CkNPTkZJR19CTEtf REVWX05VTExfQkxLPW0KQ09ORklHX0JMS19ERVZfRkQ9bQpDT05GSUdfQ0RST009bQojIENP TkZJR19QQVJJREUgaXMgbm90IHNldApDT05GSUdfQkxLX0RFVl9QQ0lFU1NEX01USVAzMlhY PW0KQ09ORklHX1pSQU09bQpDT05GSUdfWlJBTV9ERUZfQ09NUF9MWk9STEU9eQojIENPTkZJ R19aUkFNX0RFRl9DT01QX1pTVEQgaXMgbm90IHNldAojIENPTkZJR19aUkFNX0RFRl9DT01Q X0xaNCBpcyBub3Qgc2V0CiMgQ09ORklHX1pSQU1fREVGX0NPTVBfTFpPIGlzIG5vdCBzZXQK IyBDT05GSUdfWlJBTV9ERUZfQ09NUF9MWjRIQyBpcyBub3Qgc2V0CiMgQ09ORklHX1pSQU1f REVGX0NPTVBfODQyIGlzIG5vdCBzZXQKQ09ORklHX1pSQU1fREVGX0NPTVA9Imx6by1ybGUi CkNPTkZJR19aUkFNX1dSSVRFQkFDSz15CiMgQ09ORklHX1pSQU1fTUVNT1JZX1RSQUNLSU5H IGlzIG5vdCBzZXQKQ09ORklHX0JMS19ERVZfVU1FTT1tCkNPTkZJR19CTEtfREVWX0xPT1A9 bQpDT05GSUdfQkxLX0RFVl9MT09QX01JTl9DT1VOVD0wCkNPTkZJR19CTEtfREVWX0NSWVBU T0xPT1A9bQpDT05GSUdfQkxLX0RFVl9EUkJEPW0KIyBDT05GSUdfRFJCRF9GQVVMVF9JTkpF Q1RJT04gaXMgbm90IHNldApDT05GSUdfQkxLX0RFVl9OQkQ9bQpDT05GSUdfQkxLX0RFVl9T WDg9bQpDT05GSUdfQkxLX0RFVl9SQU09bQpDT05GSUdfQkxLX0RFVl9SQU1fQ09VTlQ9MTYK Q09ORklHX0JMS19ERVZfUkFNX1NJWkU9MTYzODQKQ09ORklHX0NEUk9NX1BLVENEVkQ9bQpD T05GSUdfQ0RST01fUEtUQ0RWRF9CVUZGRVJTPTgKIyBDT05GSUdfQ0RST01fUEtUQ0RWRF9X Q0FDSEUgaXMgbm90IHNldApDT05GSUdfQVRBX09WRVJfRVRIPW0KQ09ORklHX1hFTl9CTEtE RVZfRlJPTlRFTkQ9bQpDT05GSUdfWEVOX0JMS0RFVl9CQUNLRU5EPW0KQ09ORklHX1ZJUlRJ T19CTEs9bQpDT05GSUdfQkxLX0RFVl9SQkQ9bQpDT05GSUdfQkxLX0RFVl9SU1hYPW0KQ09O RklHX0JMS19ERVZfUk5CRD15CkNPTkZJR19CTEtfREVWX1JOQkRfQ0xJRU5UPW0KQ09ORklH X0JMS19ERVZfUk5CRF9TRVJWRVI9bQoKIwojIE5WTUUgU3VwcG9ydAojCkNPTkZJR19OVk1F X0NPUkU9eQpDT05GSUdfQkxLX0RFVl9OVk1FPXkKQ09ORklHX05WTUVfTVVMVElQQVRIPXkK Q09ORklHX05WTUVfSFdNT049eQpDT05GSUdfTlZNRV9GQUJSSUNTPW0KQ09ORklHX05WTUVf UkRNQT1tCkNPTkZJR19OVk1FX0ZDPW0KQ09ORklHX05WTUVfVENQPW0KQ09ORklHX05WTUVf VEFSR0VUPW0KQ09ORklHX05WTUVfVEFSR0VUX1BBU1NUSFJVPXkKQ09ORklHX05WTUVfVEFS R0VUX0xPT1A9bQpDT05GSUdfTlZNRV9UQVJHRVRfUkRNQT1tCkNPTkZJR19OVk1FX1RBUkdF VF9GQz1tCkNPTkZJR19OVk1FX1RBUkdFVF9GQ0xPT1A9bQpDT05GSUdfTlZNRV9UQVJHRVRf VENQPW0KIyBlbmQgb2YgTlZNRSBTdXBwb3J0CgojCiMgTWlzYyBkZXZpY2VzCiMKQ09ORklH X1NFTlNPUlNfTElTM0xWMDJEPW0KQ09ORklHX0FENTI1WF9EUE9UPW0KQ09ORklHX0FENTI1 WF9EUE9UX0kyQz1tCkNPTkZJR19BRDUyNVhfRFBPVF9TUEk9bQojIENPTkZJR19EVU1NWV9J UlEgaXMgbm90IHNldApDT05GSUdfSUJNX0FTTT1tCkNPTkZJR19QSEFOVE9NPW0KQ09ORklH X1RJRk1fQ09SRT1tCkNPTkZJR19USUZNXzdYWDE9bQpDT05GSUdfSUNTOTMyUzQwMT1tCkNP TkZJR19FTkNMT1NVUkVfU0VSVklDRVM9bQpDT05GSUdfSFBfSUxPPW0KQ09ORklHX0FQRFM5 ODAyQUxTPW0KQ09ORklHX0lTTDI5MDAzPW0KQ09ORklHX0lTTDI5MDIwPW0KQ09ORklHX1NF TlNPUlNfVFNMMjU1MD1tCkNPTkZJR19TRU5TT1JTX0JIMTc3MD1tCkNPTkZJR19TRU5TT1JT X0FQRFM5OTBYPW0KQ09ORklHX0hNQzYzNTI9bQpDT05GSUdfRFMxNjgyPW0KQ09ORklHX1ZN V0FSRV9CQUxMT09OPW0KQ09ORklHX0xBVFRJQ0VfRUNQM19DT05GSUc9bQojIENPTkZJR19T UkFNIGlzIG5vdCBzZXQKQ09ORklHX1BDSV9FTkRQT0lOVF9URVNUPW0KQ09ORklHX1hJTElO WF9TREZFQz1tCkNPTkZJR19NSVNDX1JUU1g9bQpDT05GSUdfUFZQQU5JQz1tCkNPTkZJR19D MlBPUlQ9bQpDT05GSUdfQzJQT1JUX0RVUkFNQVJfMjE1MD1tCgojCiMgRUVQUk9NIHN1cHBv cnQKIwpDT05GSUdfRUVQUk9NX0FUMjQ9bQojIENPTkZJR19FRVBST01fQVQyNSBpcyBub3Qg c2V0CkNPTkZJR19FRVBST01fTEVHQUNZPW0KQ09ORklHX0VFUFJPTV9NQVg2ODc1PW0KQ09O RklHX0VFUFJPTV85M0NYNj1tCiMgQ09ORklHX0VFUFJPTV85M1hYNDYgaXMgbm90IHNldApD T05GSUdfRUVQUk9NX0lEVF84OUhQRVNYPW0KQ09ORklHX0VFUFJPTV9FRTEwMDQ9bQojIGVu ZCBvZiBFRVBST00gc3VwcG9ydAoKQ09ORklHX0NCNzEwX0NPUkU9bQojIENPTkZJR19DQjcx MF9ERUJVRyBpcyBub3Qgc2V0CkNPTkZJR19DQjcxMF9ERUJVR19BU1NVTVBUSU9OUz15Cgoj CiMgVGV4YXMgSW5zdHJ1bWVudHMgc2hhcmVkIHRyYW5zcG9ydCBsaW5lIGRpc2NpcGxpbmUK IwpDT05GSUdfVElfU1Q9bQojIGVuZCBvZiBUZXhhcyBJbnN0cnVtZW50cyBzaGFyZWQgdHJh bnNwb3J0IGxpbmUgZGlzY2lwbGluZQoKQ09ORklHX1NFTlNPUlNfTElTM19JMkM9bQpDT05G SUdfQUxURVJBX1NUQVBMPW0KQ09ORklHX0lOVEVMX01FST1tCkNPTkZJR19JTlRFTF9NRUlf TUU9bQpDT05GSUdfSU5URUxfTUVJX1RYRT1tCkNPTkZJR19JTlRFTF9NRUlfSERDUD1tCkNP TkZJR19WTVdBUkVfVk1DST1tCkNPTkZJR19HRU5XUUU9bQpDT05GSUdfR0VOV1FFX1BMQVRG T1JNX0VSUk9SX1JFQ09WRVJZPTAKQ09ORklHX0VDSE89bQpDT05GSUdfQkNNX1ZLPW0KQ09O RklHX0JDTV9WS19UVFk9eQpDT05GSUdfTUlTQ19BTENPUl9QQ0k9bQpDT05GSUdfTUlTQ19S VFNYX1BDST1tCkNPTkZJR19NSVNDX1JUU1hfVVNCPW0KQ09ORklHX0hBQkFOQV9BST1tCkNP TkZJR19VQUNDRT1tCiMgZW5kIG9mIE1pc2MgZGV2aWNlcwoKQ09ORklHX0hBVkVfSURFPXkK IyBDT05GSUdfSURFIGlzIG5vdCBzZXQKCiMKIyBTQ1NJIGRldmljZSBzdXBwb3J0CiMKQ09O RklHX1NDU0lfTU9EPXkKQ09ORklHX1JBSURfQVRUUlM9bQpDT05GSUdfU0NTST15CkNPTkZJ R19TQ1NJX0RNQT15CkNPTkZJR19TQ1NJX05FVExJTks9eQpDT05GSUdfU0NTSV9QUk9DX0ZT PXkKCiMKIyBTQ1NJIHN1cHBvcnQgdHlwZSAoZGlzaywgdGFwZSwgQ0QtUk9NKQojCkNPTkZJ R19CTEtfREVWX1NEPXkKQ09ORklHX0NIUl9ERVZfU1Q9bQpDT05GSUdfQkxLX0RFVl9TUj1t CkNPTkZJR19DSFJfREVWX1NHPW0KQ09ORklHX0NIUl9ERVZfU0NIPW0KQ09ORklHX1NDU0lf RU5DTE9TVVJFPW0KQ09ORklHX1NDU0lfQ09OU1RBTlRTPXkKQ09ORklHX1NDU0lfTE9HR0lO Rz15CkNPTkZJR19TQ1NJX1NDQU5fQVNZTkM9eQoKIwojIFNDU0kgVHJhbnNwb3J0cwojCkNP TkZJR19TQ1NJX1NQSV9BVFRSUz1tCkNPTkZJR19TQ1NJX0ZDX0FUVFJTPW0KQ09ORklHX1ND U0lfSVNDU0lfQVRUUlM9bQpDT05GSUdfU0NTSV9TQVNfQVRUUlM9bQpDT05GSUdfU0NTSV9T QVNfTElCU0FTPW0KQ09ORklHX1NDU0lfU0FTX0FUQT15CkNPTkZJR19TQ1NJX1NBU19IT1NU X1NNUD15CkNPTkZJR19TQ1NJX1NSUF9BVFRSUz1tCiMgZW5kIG9mIFNDU0kgVHJhbnNwb3J0 cwoKQ09ORklHX1NDU0lfTE9XTEVWRUw9eQpDT05GSUdfSVNDU0lfVENQPW0KQ09ORklHX0lT Q1NJX0JPT1RfU1lTRlM9bQpDT05GSUdfU0NTSV9DWEdCM19JU0NTST1tCkNPTkZJR19TQ1NJ X0NYR0I0X0lTQ1NJPW0KQ09ORklHX1NDU0lfQk5YMl9JU0NTST1tCkNPTkZJR19TQ1NJX0JO WDJYX0ZDT0U9bQpDT05GSUdfQkUySVNDU0k9bQpDT05GSUdfQkxLX0RFVl8zV19YWFhYX1JB SUQ9bQpDT05GSUdfU0NTSV9IUFNBPW0KQ09ORklHX1NDU0lfM1dfOVhYWD1tCkNPTkZJR19T Q1NJXzNXX1NBUz1tCkNPTkZJR19TQ1NJX0FDQVJEPW0KQ09ORklHX1NDU0lfQUFDUkFJRD1t CkNPTkZJR19TQ1NJX0FJQzdYWFg9bQpDT05GSUdfQUlDN1hYWF9DTURTX1BFUl9ERVZJQ0U9 MzIKQ09ORklHX0FJQzdYWFhfUkVTRVRfREVMQVlfTVM9MTUwMDAKQ09ORklHX0FJQzdYWFhf REVCVUdfRU5BQkxFPXkKQ09ORklHX0FJQzdYWFhfREVCVUdfTUFTSz0wCkNPTkZJR19BSUM3 WFhYX1JFR19QUkVUVFlfUFJJTlQ9eQpDT05GSUdfU0NTSV9BSUM3OVhYPW0KQ09ORklHX0FJ Qzc5WFhfQ01EU19QRVJfREVWSUNFPTMyCkNPTkZJR19BSUM3OVhYX1JFU0VUX0RFTEFZX01T PTE1MDAwCkNPTkZJR19BSUM3OVhYX0RFQlVHX0VOQUJMRT15CkNPTkZJR19BSUM3OVhYX0RF QlVHX01BU0s9MApDT05GSUdfQUlDNzlYWF9SRUdfUFJFVFRZX1BSSU5UPXkKQ09ORklHX1ND U0lfQUlDOTRYWD1tCkNPTkZJR19BSUM5NFhYX0RFQlVHPXkKQ09ORklHX1NDU0lfTVZTQVM9 bQpDT05GSUdfU0NTSV9NVlNBU19ERUJVRz15CkNPTkZJR19TQ1NJX01WU0FTX1RBU0tMRVQ9 eQpDT05GSUdfU0NTSV9NVlVNST1tCkNPTkZJR19TQ1NJX0RQVF9JMk89bQpDT05GSUdfU0NT SV9BRFZBTlNZUz1tCkNPTkZJR19TQ1NJX0FSQ01TUj1tCkNPTkZJR19TQ1NJX0VTQVMyUj1t CkNPTkZJR19NRUdBUkFJRF9ORVdHRU49eQpDT05GSUdfTUVHQVJBSURfTU09bQpDT05GSUdf TUVHQVJBSURfTUFJTEJPWD1tCkNPTkZJR19NRUdBUkFJRF9MRUdBQ1k9bQpDT05GSUdfTUVH QVJBSURfU0FTPW0KQ09ORklHX1NDU0lfTVBUM1NBUz1tCkNPTkZJR19TQ1NJX01QVDJTQVNf TUFYX1NHRT0xMjgKQ09ORklHX1NDU0lfTVBUM1NBU19NQVhfU0dFPTEyOApDT05GSUdfU0NT SV9NUFQyU0FTPW0KQ09ORklHX1NDU0lfU01BUlRQUUk9bQpDT05GSUdfU0NTSV9VRlNIQ0Q9 bQpDT05GSUdfU0NTSV9VRlNIQ0RfUENJPW0KIyBDT05GSUdfU0NTSV9VRlNfRFdDX1RDX1BD SSBpcyBub3Qgc2V0CkNPTkZJR19TQ1NJX1VGU0hDRF9QTEFURk9STT1tCkNPTkZJR19TQ1NJ X1VGU19DRE5TX1BMQVRGT1JNPW0KIyBDT05GSUdfU0NTSV9VRlNfRFdDX1RDX1BMQVRGT1JN IGlzIG5vdCBzZXQKQ09ORklHX1NDU0lfVUZTX0JTRz15CkNPTkZJR19TQ1NJX1VGU19DUllQ VE89eQpDT05GSUdfU0NTSV9IUFRJT1A9bQpDT05GSUdfU0NTSV9CVVNMT0dJQz1tCkNPTkZJ R19TQ1NJX0ZMQVNIUE9JTlQ9eQpDT05GSUdfU0NTSV9NWVJCPW0KQ09ORklHX1NDU0lfTVlS Uz1tCkNPTkZJR19WTVdBUkVfUFZTQ1NJPW0KQ09ORklHX1hFTl9TQ1NJX0ZST05URU5EPW0K Q09ORklHX0hZUEVSVl9TVE9SQUdFPW0KQ09ORklHX0xJQkZDPW0KQ09ORklHX0xJQkZDT0U9 bQpDT05GSUdfRkNPRT1tCkNPTkZJR19GQ09FX0ZOSUM9bQpDT05GSUdfU0NTSV9TTklDPW0K IyBDT05GSUdfU0NTSV9TTklDX0RFQlVHX0ZTIGlzIG5vdCBzZXQKQ09ORklHX1NDU0lfRE1Y MzE5MUQ9bQpDT05GSUdfU0NTSV9GRE9NQUlOPW0KQ09ORklHX1NDU0lfRkRPTUFJTl9QQ0k9 bQpDT05GSUdfU0NTSV9JU0NJPW0KQ09ORklHX1NDU0lfSVBTPW0KQ09ORklHX1NDU0lfSU5J VElPPW0KQ09ORklHX1NDU0lfSU5JQTEwMD1tCkNPTkZJR19TQ1NJX1BQQT1tCkNPTkZJR19T Q1NJX0lNTT1tCiMgQ09ORklHX1NDU0lfSVpJUF9FUFAxNiBpcyBub3Qgc2V0CiMgQ09ORklH X1NDU0lfSVpJUF9TTE9XX0NUUiBpcyBub3Qgc2V0CkNPTkZJR19TQ1NJX1NURVg9bQpDT05G SUdfU0NTSV9TWU01M0M4WFhfMj1tCkNPTkZJR19TQ1NJX1NZTTUzQzhYWF9ETUFfQUREUkVT U0lOR19NT0RFPTEKQ09ORklHX1NDU0lfU1lNNTNDOFhYX0RFRkFVTFRfVEFHUz0xNgpDT05G SUdfU0NTSV9TWU01M0M4WFhfTUFYX1RBR1M9NjQKQ09ORklHX1NDU0lfU1lNNTNDOFhYX01N SU89eQpDT05GSUdfU0NTSV9JUFI9bQpDT05GSUdfU0NTSV9JUFJfVFJBQ0U9eQpDT05GSUdf U0NTSV9JUFJfRFVNUD15CkNPTkZJR19TQ1NJX1FMT0dJQ18xMjgwPW0KQ09ORklHX1NDU0lf UUxBX0ZDPW0KQ09ORklHX1RDTV9RTEEyWFhYPW0KIyBDT05GSUdfVENNX1FMQTJYWFhfREVC VUcgaXMgbm90IHNldApDT05GSUdfU0NTSV9RTEFfSVNDU0k9bQpDT05GSUdfUUVEST1tCkNP TkZJR19RRURGPW0KQ09ORklHX1NDU0lfTFBGQz1tCiMgQ09ORklHX1NDU0lfTFBGQ19ERUJV R19GUyBpcyBub3Qgc2V0CkNPTkZJR19TQ1NJX0RDMzk1eD1tCkNPTkZJR19TQ1NJX0FNNTND OTc0PW0KQ09ORklHX1NDU0lfV0Q3MTlYPW0KQ09ORklHX1NDU0lfREVCVUc9bQpDT05GSUdf U0NTSV9QTUNSQUlEPW0KQ09ORklHX1NDU0lfUE04MDAxPW0KQ09ORklHX1NDU0lfQkZBX0ZD PW0KQ09ORklHX1NDU0lfVklSVElPPW0KQ09ORklHX1NDU0lfQ0hFTFNJT19GQ09FPW0KQ09O RklHX1NDU0lfTE9XTEVWRUxfUENNQ0lBPXkKQ09ORklHX1BDTUNJQV9BSEExNTJYPW0KQ09O RklHX1BDTUNJQV9GRE9NQUlOPW0KQ09ORklHX1BDTUNJQV9RTE9HSUM9bQpDT05GSUdfUENN Q0lBX1NZTTUzQzUwMD1tCkNPTkZJR19TQ1NJX0RIPXkKQ09ORklHX1NDU0lfREhfUkRBQz1t CkNPTkZJR19TQ1NJX0RIX0hQX1NXPW0KQ09ORklHX1NDU0lfREhfRU1DPW0KQ09ORklHX1ND U0lfREhfQUxVQT1tCiMgZW5kIG9mIFNDU0kgZGV2aWNlIHN1cHBvcnQKCkNPTkZJR19BVEE9 eQpDT05GSUdfU0FUQV9IT1NUPXkKQ09ORklHX1BBVEFfVElNSU5HUz15CkNPTkZJR19BVEFf VkVSQk9TRV9FUlJPUj15CkNPTkZJR19BVEFfRk9SQ0U9eQpDT05GSUdfQVRBX0FDUEk9eQpD T05GSUdfU0FUQV9aUE9ERD15CkNPTkZJR19TQVRBX1BNUD15CgojCiMgQ29udHJvbGxlcnMg d2l0aCBub24tU0ZGIG5hdGl2ZSBpbnRlcmZhY2UKIwpDT05GSUdfU0FUQV9BSENJPXkKQ09O RklHX1NBVEFfTU9CSUxFX0xQTV9QT0xJQ1k9MwpDT05GSUdfU0FUQV9BSENJX1BMQVRGT1JN PW0KQ09ORklHX1NBVEFfSU5JQzE2Mlg9bQpDT05GSUdfU0FUQV9BQ0FSRF9BSENJPW0KQ09O RklHX1NBVEFfU0lMMjQ9bQpDT05GSUdfQVRBX1NGRj15CgojCiMgU0ZGIGNvbnRyb2xsZXJz IHdpdGggY3VzdG9tIERNQSBpbnRlcmZhY2UKIwpDT05GSUdfUERDX0FETUE9bQpDT05GSUdf U0FUQV9RU1RPUj1tCkNPTkZJR19TQVRBX1NYND1tCkNPTkZJR19BVEFfQk1ETUE9eQoKIwoj IFNBVEEgU0ZGIGNvbnRyb2xsZXJzIHdpdGggQk1ETUEKIwpDT05GSUdfQVRBX1BJSVg9bQpD T05GSUdfU0FUQV9EV0M9bQojIENPTkZJR19TQVRBX0RXQ19PTERfRE1BIGlzIG5vdCBzZXQK IyBDT05GSUdfU0FUQV9EV0NfREVCVUcgaXMgbm90IHNldApDT05GSUdfU0FUQV9NVj1tCkNP TkZJR19TQVRBX05WPW0KQ09ORklHX1NBVEFfUFJPTUlTRT1tCkNPTkZJR19TQVRBX1NJTD1t CkNPTkZJR19TQVRBX1NJUz1tCkNPTkZJR19TQVRBX1NWVz1tCkNPTkZJR19TQVRBX1VMST1t CkNPTkZJR19TQVRBX1ZJQT1tCkNPTkZJR19TQVRBX1ZJVEVTU0U9bQoKIwojIFBBVEEgU0ZG IGNvbnRyb2xsZXJzIHdpdGggQk1ETUEKIwpDT05GSUdfUEFUQV9BTEk9bQpDT05GSUdfUEFU QV9BTUQ9bQpDT05GSUdfUEFUQV9BUlRPUD1tCkNPTkZJR19QQVRBX0FUSUlYUD1tCkNPTkZJ R19QQVRBX0FUUDg2N1g9bQpDT05GSUdfUEFUQV9DTUQ2NFg9bQpDT05GSUdfUEFUQV9DWVBS RVNTPW0KQ09ORklHX1BBVEFfRUZBUj1tCkNPTkZJR19QQVRBX0hQVDM2Nj1tCkNPTkZJR19Q QVRBX0hQVDM3WD1tCkNPTkZJR19QQVRBX0hQVDNYMk49bQpDT05GSUdfUEFUQV9IUFQzWDM9 bQpDT05GSUdfUEFUQV9IUFQzWDNfRE1BPXkKQ09ORklHX1BBVEFfSVQ4MjEzPW0KQ09ORklH X1BBVEFfSVQ4MjFYPW0KQ09ORklHX1BBVEFfSk1JQ1JPTj1tCkNPTkZJR19QQVRBX01BUlZF TEw9bQpDT05GSUdfUEFUQV9ORVRDRUxMPW0KQ09ORklHX1BBVEFfTklOSkEzMj1tCkNPTkZJ R19QQVRBX05TODc0MTU9bQpDT05GSUdfUEFUQV9PTERQSUlYPW0KQ09ORklHX1BBVEFfT1BU SURNQT1tCkNPTkZJR19QQVRBX1BEQzIwMjdYPW0KQ09ORklHX1BBVEFfUERDX09MRD1tCkNP TkZJR19QQVRBX1JBRElTWVM9bQpDT05GSUdfUEFUQV9SREM9bQpDT05GSUdfUEFUQV9TQ0g9 bQpDT05GSUdfUEFUQV9TRVJWRVJXT1JLUz1tCkNPTkZJR19QQVRBX1NJTDY4MD1tCkNPTkZJ R19QQVRBX1NJUz1tCkNPTkZJR19QQVRBX1RPU0hJQkE9bQpDT05GSUdfUEFUQV9UUklGTEVY PW0KQ09ORklHX1BBVEFfVklBPW0KQ09ORklHX1BBVEFfV0lOQk9ORD1tCgojCiMgUElPLW9u bHkgU0ZGIGNvbnRyb2xsZXJzCiMKQ09ORklHX1BBVEFfQ01ENjQwX1BDST1tCkNPTkZJR19Q QVRBX01QSUlYPW0KQ09ORklHX1BBVEFfTlM4NzQxMD1tCkNPTkZJR19QQVRBX09QVEk9bQpD T05GSUdfUEFUQV9QQ01DSUE9bQpDT05GSUdfUEFUQV9SWjEwMDA9bQoKIwojIEdlbmVyaWMg ZmFsbGJhY2sgLyBsZWdhY3kgZHJpdmVycwojCkNPTkZJR19QQVRBX0FDUEk9bQpDT05GSUdf QVRBX0dFTkVSSUM9bQpDT05GSUdfUEFUQV9MRUdBQ1k9bQpDT05GSUdfTUQ9eQpDT05GSUdf QkxLX0RFVl9NRD1tCkNPTkZJR19NRF9MSU5FQVI9bQpDT05GSUdfTURfUkFJRDA9bQpDT05G SUdfTURfUkFJRDE9bQpDT05GSUdfTURfUkFJRDEwPW0KQ09ORklHX01EX1JBSUQ0NTY9bQpD T05GSUdfTURfTVVMVElQQVRIPW0KQ09ORklHX01EX0ZBVUxUWT1tCkNPTkZJR19NRF9DTFVT VEVSPW0KQ09ORklHX0JDQUNIRT1tCiMgQ09ORklHX0JDQUNIRV9ERUJVRyBpcyBub3Qgc2V0 CiMgQ09ORklHX0JDQUNIRV9DTE9TVVJFU19ERUJVRyBpcyBub3Qgc2V0CkNPTkZJR19CQ0FD SEVfQVNZTkNfUkVHSVNUUkFUSU9OPXkKQ09ORklHX0JMS19ERVZfRE1fQlVJTFRJTj15CkNP TkZJR19CTEtfREVWX0RNPW0KQ09ORklHX0RNX0RFQlVHPXkKQ09ORklHX0RNX0JVRklPPW0K Q09ORklHX0RNX0RFQlVHX0JMT0NLX01BTkFHRVJfTE9DS0lORz15CiMgQ09ORklHX0RNX0RF QlVHX0JMT0NLX1NUQUNLX1RSQUNJTkcgaXMgbm90IHNldApDT05GSUdfRE1fQklPX1BSSVNP Tj1tCkNPTkZJR19ETV9QRVJTSVNURU5UX0RBVEE9bQpDT05GSUdfRE1fVU5TVFJJUEVEPW0K Q09ORklHX0RNX0NSWVBUPW0KQ09ORklHX0RNX1NOQVBTSE9UPW0KQ09ORklHX0RNX1RISU5f UFJPVklTSU9OSU5HPW0KQ09ORklHX0RNX0NBQ0hFPW0KQ09ORklHX0RNX0NBQ0hFX1NNUT1t CkNPTkZJR19ETV9XUklURUNBQ0hFPW0KQ09ORklHX0RNX0VCUz1tCkNPTkZJR19ETV9FUkE9 bQpDT05GSUdfRE1fQ0xPTkU9bQpDT05GSUdfRE1fTUlSUk9SPW0KQ09ORklHX0RNX0xPR19V U0VSU1BBQ0U9bQpDT05GSUdfRE1fUkFJRD1tCkNPTkZJR19ETV9aRVJPPW0KQ09ORklHX0RN X01VTFRJUEFUSD1tCkNPTkZJR19ETV9NVUxUSVBBVEhfUUw9bQpDT05GSUdfRE1fTVVMVElQ QVRIX1NUPW0KQ09ORklHX0RNX01VTFRJUEFUSF9IU1Q9bQpDT05GSUdfRE1fTVVMVElQQVRI X0lPQT1tCkNPTkZJR19ETV9ERUxBWT1tCkNPTkZJR19ETV9EVVNUPW0KQ09ORklHX0RNX1VF VkVOVD15CkNPTkZJR19ETV9GTEFLRVk9bQpDT05GSUdfRE1fVkVSSVRZPW0KQ09ORklHX0RN X1ZFUklUWV9WRVJJRllfUk9PVEhBU0hfU0lHPXkKIyBDT05GSUdfRE1fVkVSSVRZX1ZFUklG WV9ST09USEFTSF9TSUdfU0VDT05EQVJZX0tFWVJJTkcgaXMgbm90IHNldApDT05GSUdfRE1f VkVSSVRZX0ZFQz15CkNPTkZJR19ETV9TV0lUQ0g9bQpDT05GSUdfRE1fTE9HX1dSSVRFUz1t CkNPTkZJR19ETV9JTlRFR1JJVFk9bQpDT05GSUdfRE1fWk9ORUQ9bQpDT05GSUdfVEFSR0VU X0NPUkU9bQpDT05GSUdfVENNX0lCTE9DSz1tCkNPTkZJR19UQ01fRklMRUlPPW0KQ09ORklH X1RDTV9QU0NTST1tCkNPTkZJR19UQ01fVVNFUjI9bQpDT05GSUdfTE9PUEJBQ0tfVEFSR0VU PW0KQ09ORklHX1RDTV9GQz1tCkNPTkZJR19JU0NTSV9UQVJHRVQ9bQpDT05GSUdfSVNDU0lf VEFSR0VUX0NYR0I0PW0KQ09ORklHX1NCUF9UQVJHRVQ9bQpDT05GSUdfRlVTSU9OPXkKQ09O RklHX0ZVU0lPTl9TUEk9bQpDT05GSUdfRlVTSU9OX0ZDPW0KQ09ORklHX0ZVU0lPTl9TQVM9 bQpDT05GSUdfRlVTSU9OX01BWF9TR0U9MTI4CkNPTkZJR19GVVNJT05fQ1RMPW0KQ09ORklH X0ZVU0lPTl9MQU49bQojIENPTkZJR19GVVNJT05fTE9HR0lORyBpcyBub3Qgc2V0CgojCiMg SUVFRSAxMzk0IChGaXJlV2lyZSkgc3VwcG9ydAojCkNPTkZJR19GSVJFV0lSRT1tCkNPTkZJ R19GSVJFV0lSRV9PSENJPW0KQ09ORklHX0ZJUkVXSVJFX1NCUDI9bQpDT05GSUdfRklSRVdJ UkVfTkVUPW0KQ09ORklHX0ZJUkVXSVJFX05PU1k9bQojIGVuZCBvZiBJRUVFIDEzOTQgKEZp cmVXaXJlKSBzdXBwb3J0CgpDT05GSUdfTUFDSU5UT1NIX0RSSVZFUlM9eQpDT05GSUdfTUFD X0VNVU1PVVNFQlROPW0KQ09ORklHX05FVERFVklDRVM9eQpDT05GSUdfTUlJPW0KQ09ORklH X05FVF9DT1JFPXkKQ09ORklHX0JPTkRJTkc9bQpDT05GSUdfRFVNTVk9bQpDT05GSUdfV0lS RUdVQVJEPW0KIyBDT05GSUdfV0lSRUdVQVJEX0RFQlVHIGlzIG5vdCBzZXQKQ09ORklHX0VR VUFMSVpFUj1tCkNPTkZJR19ORVRfRkM9eQpDT05GSUdfSUZCPW0KQ09ORklHX05FVF9URUFN PW0KQ09ORklHX05FVF9URUFNX01PREVfQlJPQURDQVNUPW0KQ09ORklHX05FVF9URUFNX01P REVfUk9VTkRST0JJTj1tCkNPTkZJR19ORVRfVEVBTV9NT0RFX1JBTkRPTT1tCkNPTkZJR19O RVRfVEVBTV9NT0RFX0FDVElWRUJBQ0tVUD1tCkNPTkZJR19ORVRfVEVBTV9NT0RFX0xPQURC QUxBTkNFPW0KQ09ORklHX01BQ1ZMQU49bQpDT05GSUdfTUFDVlRBUD1tCkNPTkZJR19JUFZM QU5fTDNTPXkKQ09ORklHX0lQVkxBTj1tCkNPTkZJR19JUFZUQVA9bQpDT05GSUdfVlhMQU49 bQpDT05GSUdfR0VORVZFPW0KQ09ORklHX0JBUkVVRFA9bQpDT05GSUdfR1RQPW0KQ09ORklH X01BQ1NFQz1tCkNPTkZJR19ORVRDT05TT0xFPW0KQ09ORklHX05FVENPTlNPTEVfRFlOQU1J Qz15CkNPTkZJR19ORVRQT0xMPXkKQ09ORklHX05FVF9QT0xMX0NPTlRST0xMRVI9eQpDT05G SUdfTlRCX05FVERFVj1tCkNPTkZJR19UVU49bQpDT05GSUdfVEFQPW0KIyBDT05GSUdfVFVO X1ZORVRfQ1JPU1NfTEUgaXMgbm90IHNldApDT05GSUdfVkVUSD1tCkNPTkZJR19WSVJUSU9f TkVUPW0KQ09ORklHX05MTU9OPW0KQ09ORklHX05FVF9WUkY9bQpDT05GSUdfVlNPQ0tNT049 bQpDT05GSUdfTUhJX05FVD1tCkNPTkZJR19TVU5HRU1fUEhZPW0KIyBDT05GSUdfQVJDTkVU IGlzIG5vdCBzZXQKQ09ORklHX0FUTV9EUklWRVJTPXkKIyBDT05GSUdfQVRNX0RVTU1ZIGlz IG5vdCBzZXQKQ09ORklHX0FUTV9UQ1A9bQpDT05GSUdfQVRNX0xBTkFJPW0KQ09ORklHX0FU TV9FTkk9bQojIENPTkZJR19BVE1fRU5JX0RFQlVHIGlzIG5vdCBzZXQKIyBDT05GSUdfQVRN X0VOSV9UVU5FX0JVUlNUIGlzIG5vdCBzZXQKQ09ORklHX0FUTV9GSVJFU1RSRUFNPW0KQ09O RklHX0FUTV9aQVRNPW0KIyBDT05GSUdfQVRNX1pBVE1fREVCVUcgaXMgbm90IHNldApDT05G SUdfQVRNX05JQ1NUQVI9bQojIENPTkZJR19BVE1fTklDU1RBUl9VU0VfU1VOSSBpcyBub3Qg c2V0CiMgQ09ORklHX0FUTV9OSUNTVEFSX1VTRV9JRFQ3NzEwNSBpcyBub3Qgc2V0CkNPTkZJ R19BVE1fSURUNzcyNTI9bQojIENPTkZJR19BVE1fSURUNzcyNTJfREVCVUcgaXMgbm90IHNl dAojIENPTkZJR19BVE1fSURUNzcyNTJfUkNWX0FMTCBpcyBub3Qgc2V0CkNPTkZJR19BVE1f SURUNzcyNTJfVVNFX1NVTkk9eQpDT05GSUdfQVRNX0FNQkFTU0FET1I9bQojIENPTkZJR19B VE1fQU1CQVNTQURPUl9ERUJVRyBpcyBub3Qgc2V0CkNPTkZJR19BVE1fSE9SSVpPTj1tCiMg Q09ORklHX0FUTV9IT1JJWk9OX0RFQlVHIGlzIG5vdCBzZXQKQ09ORklHX0FUTV9JQT1tCiMg Q09ORklHX0FUTV9JQV9ERUJVRyBpcyBub3Qgc2V0CkNPTkZJR19BVE1fRk9SRTIwMEU9bQpD T05GSUdfQVRNX0ZPUkUyMDBFX1VTRV9UQVNLTEVUPXkKQ09ORklHX0FUTV9GT1JFMjAwRV9U WF9SRVRSWT0xNgpDT05GSUdfQVRNX0ZPUkUyMDBFX0RFQlVHPTAKQ09ORklHX0FUTV9IRT1t CkNPTkZJR19BVE1fSEVfVVNFX1NVTkk9eQpDT05GSUdfQVRNX1NPTE9TPW0KCiMKIyBEaXN0 cmlidXRlZCBTd2l0Y2ggQXJjaGl0ZWN0dXJlIGRyaXZlcnMKIwpDT05GSUdfQjUzPW0KQ09O RklHX0I1M19TUElfRFJJVkVSPW0KQ09ORklHX0I1M19NRElPX0RSSVZFUj1tCkNPTkZJR19C NTNfTU1BUF9EUklWRVI9bQpDT05GSUdfQjUzX1NSQUJfRFJJVkVSPW0KQ09ORklHX0I1M19T RVJERVM9bQpDT05GSUdfTkVUX0RTQV9CQ01fU0YyPW0KQ09ORklHX05FVF9EU0FfTE9PUD1t CkNPTkZJR19ORVRfRFNBX0hJUlNDSE1BTk5fSEVMTENSRUVLPW0KIyBDT05GSUdfTkVUX0RT QV9MQU5USVFfR1NXSVAgaXMgbm90IHNldApDT05GSUdfTkVUX0RTQV9NVDc1MzA9bQpDT05G SUdfTkVUX0RTQV9NVjg4RTYwNjA9bQpDT05GSUdfTkVUX0RTQV9NSUNST0NISVBfS1NaX0NP TU1PTj1tCkNPTkZJR19ORVRfRFNBX01JQ1JPQ0hJUF9LU1o5NDc3PW0KQ09ORklHX05FVF9E U0FfTUlDUk9DSElQX0tTWjk0NzdfSTJDPW0KQ09ORklHX05FVF9EU0FfTUlDUk9DSElQX0tT Wjk0NzdfU1BJPW0KQ09ORklHX05FVF9EU0FfTUlDUk9DSElQX0tTWjg3OTU9bQpDT05GSUdf TkVUX0RTQV9NSUNST0NISVBfS1NaODc5NV9TUEk9bQpDT05GSUdfTkVUX0RTQV9NVjg4RTZY WFg9bQpDT05GSUdfTkVUX0RTQV9NVjg4RTZYWFhfUFRQPXkKQ09ORklHX05FVF9EU0FfTVND Q19TRVZJTExFPW0KQ09ORklHX05FVF9EU0FfQVI5MzMxPW0KQ09ORklHX05FVF9EU0FfU0pB MTEwNT1tCkNPTkZJR19ORVRfRFNBX1NKQTExMDVfUFRQPXkKQ09ORklHX05FVF9EU0FfU0pB MTEwNV9UQVM9eQpDT05GSUdfTkVUX0RTQV9TSkExMTA1X1ZMPXkKQ09ORklHX05FVF9EU0Ff WFJTNzAwWD1tCkNPTkZJR19ORVRfRFNBX1hSUzcwMFhfSTJDPW0KQ09ORklHX05FVF9EU0Ff WFJTNzAwWF9NRElPPW0KQ09ORklHX05FVF9EU0FfUUNBOEs9bQpDT05GSUdfTkVUX0RTQV9S RUFMVEVLX1NNST1tCkNPTkZJR19ORVRfRFNBX1NNU0NfTEFOOTMwMz1tCkNPTkZJR19ORVRf RFNBX1NNU0NfTEFOOTMwM19JMkM9bQpDT05GSUdfTkVUX0RTQV9TTVNDX0xBTjkzMDNfTURJ Tz1tCkNPTkZJR19ORVRfRFNBX1ZJVEVTU0VfVlNDNzNYWD1tCkNPTkZJR19ORVRfRFNBX1ZJ VEVTU0VfVlNDNzNYWF9TUEk9bQpDT05GSUdfTkVUX0RTQV9WSVRFU1NFX1ZTQzczWFhfUExB VEZPUk09bQojIGVuZCBvZiBEaXN0cmlidXRlZCBTd2l0Y2ggQXJjaGl0ZWN0dXJlIGRyaXZl cnMKCkNPTkZJR19FVEhFUk5FVD15CkNPTkZJR19NRElPPW0KQ09ORklHX05FVF9WRU5ET1Jf M0NPTT15CkNPTkZJR19QQ01DSUFfM0M1NzQ9bQpDT05GSUdfUENNQ0lBXzNDNTg5PW0KQ09O RklHX1ZPUlRFWD1tCkNPTkZJR19UWVBIT09OPW0KQ09ORklHX05FVF9WRU5ET1JfQURBUFRF Qz15CkNPTkZJR19BREFQVEVDX1NUQVJGSVJFPW0KQ09ORklHX05FVF9WRU5ET1JfQUdFUkU9 eQpDT05GSUdfRVQxMzFYPW0KQ09ORklHX05FVF9WRU5ET1JfQUxBQ1JJVEVDSD15CkNPTkZJ R19TTElDT1NTPW0KQ09ORklHX05FVF9WRU5ET1JfQUxURU9OPXkKQ09ORklHX0FDRU5JQz1t CiMgQ09ORklHX0FDRU5JQ19PTUlUX1RJR09OX0kgaXMgbm90IHNldApDT05GSUdfQUxURVJB X1RTRT1tCkNPTkZJR19ORVRfVkVORE9SX0FNQVpPTj15CkNPTkZJR19FTkFfRVRIRVJORVQ9 bQpDT05GSUdfTkVUX1ZFTkRPUl9BTUQ9eQpDT05GSUdfQU1EODExMV9FVEg9bQpDT05GSUdf UENORVQzMj1tCkNPTkZJR19QQ01DSUFfTk1DTEFOPW0KQ09ORklHX0FNRF9YR0JFPW0KQ09O RklHX0FNRF9YR0JFX0RDQj15CkNPTkZJR19BTURfWEdCRV9IQVZFX0VDQz15CkNPTkZJR19O RVRfVkVORE9SX0FRVUFOVElBPXkKQ09ORklHX0FRVElPTj1tCkNPTkZJR19ORVRfVkVORE9S X0FSQz15CkNPTkZJR19ORVRfVkVORE9SX0FUSEVST1M9eQpDT05GSUdfQVRMMj1tCkNPTkZJ R19BVEwxPW0KQ09ORklHX0FUTDFFPW0KQ09ORklHX0FUTDFDPW0KQ09ORklHX0FMWD1tCkNP TkZJR19ORVRfVkVORE9SX0JST0FEQ09NPXkKQ09ORklHX0I0ND1tCkNPTkZJR19CNDRfUENJ X0FVVE9TRUxFQ1Q9eQpDT05GSUdfQjQ0X1BDSUNPUkVfQVVUT1NFTEVDVD15CkNPTkZJR19C NDRfUENJPXkKQ09ORklHX0JDTUdFTkVUPW0KQ09ORklHX0JOWDI9bQpDT05GSUdfQ05JQz1t CkNPTkZJR19USUdPTjM9bQpDT05GSUdfVElHT04zX0hXTU9OPXkKQ09ORklHX0JOWDJYPW0K Q09ORklHX0JOWDJYX1NSSU9WPXkKQ09ORklHX1NZU1RFTVBPUlQ9bQpDT05GSUdfQk5YVD1t CkNPTkZJR19CTlhUX1NSSU9WPXkKQ09ORklHX0JOWFRfRkxPV0VSX09GRkxPQUQ9eQpDT05G SUdfQk5YVF9EQ0I9eQpDT05GSUdfQk5YVF9IV01PTj15CkNPTkZJR19ORVRfVkVORE9SX0JS T0NBREU9eQpDT05GSUdfQk5BPW0KQ09ORklHX05FVF9WRU5ET1JfQ0FERU5DRT15CkNPTkZJ R19NQUNCPW0KQ09ORklHX01BQ0JfVVNFX0hXU1RBTVA9eQpDT05GSUdfTUFDQl9QQ0k9bQpD T05GSUdfTkVUX1ZFTkRPUl9DQVZJVU09eQpDT05GSUdfVEhVTkRFUl9OSUNfUEY9bQpDT05G SUdfVEhVTkRFUl9OSUNfVkY9bQpDT05GSUdfVEhVTkRFUl9OSUNfQkdYPW0KQ09ORklHX1RI VU5ERVJfTklDX1JHWD1tCkNPTkZJR19DQVZJVU1fUFRQPW0KQ09ORklHX0xJUVVJRElPPW0K Q09ORklHX0xJUVVJRElPX1ZGPW0KQ09ORklHX05FVF9WRU5ET1JfQ0hFTFNJTz15CkNPTkZJ R19DSEVMU0lPX1QxPW0KQ09ORklHX0NIRUxTSU9fVDFfMUc9eQpDT05GSUdfQ0hFTFNJT19U Mz1tCkNPTkZJR19DSEVMU0lPX1Q0PW0KQ09ORklHX0NIRUxTSU9fVDRfRENCPXkKQ09ORklH X0NIRUxTSU9fVDRfRkNPRT15CkNPTkZJR19DSEVMU0lPX1Q0VkY9bQpDT05GSUdfQ0hFTFNJ T19MSUI9bQpDT05GSUdfQ0hFTFNJT19JTkxJTkVfQ1JZUFRPPXkKQ09ORklHX0NIRUxTSU9f SVBTRUNfSU5MSU5FPW0KQ09ORklHX0NIRUxTSU9fVExTX0RFVklDRT1tCkNPTkZJR19ORVRf VkVORE9SX0NJU0NPPXkKQ09ORklHX0VOSUM9bQpDT05GSUdfTkVUX1ZFTkRPUl9DT1JUSU5B PXkKQ09ORklHX0NYX0VDQVQ9bQpDT05GSUdfRE5FVD1tCkNPTkZJR19ORVRfVkVORE9SX0RF Qz15CkNPTkZJR19ORVRfVFVMSVA9eQpDT05GSUdfREUyMTA0WD1tCkNPTkZJR19ERTIxMDRY X0RTTD0wCkNPTkZJR19UVUxJUD1tCkNPTkZJR19UVUxJUF9NV0k9eQpDT05GSUdfVFVMSVBf TU1JTz15CkNPTkZJR19UVUxJUF9OQVBJPXkKQ09ORklHX1RVTElQX05BUElfSFdfTUlUSUdB VElPTj15CkNPTkZJR19ERTRYNT1tCkNPTkZJR19XSU5CT05EXzg0MD1tCkNPTkZJR19ETTkx MDI9bQpDT05GSUdfVUxJNTI2WD1tCkNPTkZJR19QQ01DSUFfWElSQ09NPW0KQ09ORklHX05F VF9WRU5ET1JfRExJTks9eQpDT05GSUdfREwySz1tCkNPTkZJR19TVU5EQU5DRT1tCiMgQ09O RklHX1NVTkRBTkNFX01NSU8gaXMgbm90IHNldApDT05GSUdfTkVUX1ZFTkRPUl9FTVVMRVg9 eQpDT05GSUdfQkUyTkVUPW0KQ09ORklHX0JFMk5FVF9IV01PTj15CkNPTkZJR19CRTJORVRf QkUyPXkKQ09ORklHX0JFMk5FVF9CRTM9eQpDT05GSUdfQkUyTkVUX0xBTkNFUj15CkNPTkZJ R19CRTJORVRfU0tZSEFXSz15CkNPTkZJR19ORVRfVkVORE9SX0VaQ0hJUD15CkNPTkZJR19O RVRfVkVORE9SX0ZVSklUU1U9eQpDT05GSUdfUENNQ0lBX0ZNVkoxOFg9bQpDT05GSUdfTkVU X1ZFTkRPUl9HT09HTEU9eQpDT05GSUdfR1ZFPW0KQ09ORklHX05FVF9WRU5ET1JfSFVBV0VJ PXkKQ09ORklHX0hJTklDPW0KQ09ORklHX05FVF9WRU5ET1JfSTgyNVhYPXkKQ09ORklHX05F VF9WRU5ET1JfSU5URUw9eQpDT05GSUdfRTEwMD1tCkNPTkZJR19FMTAwMD1tCkNPTkZJR19F MTAwMEU9bQpDT05GSUdfRTEwMDBFX0hXVFM9eQpDT05GSUdfSUdCPW0KQ09ORklHX0lHQl9I V01PTj15CkNPTkZJR19JR0JfRENBPXkKQ09ORklHX0lHQlZGPW0KQ09ORklHX0lYR0I9bQpD T05GSUdfSVhHQkU9bQpDT05GSUdfSVhHQkVfSFdNT049eQpDT05GSUdfSVhHQkVfRENBPXkK Q09ORklHX0lYR0JFX0RDQj15CiMgQ09ORklHX0lYR0JFX0lQU0VDIGlzIG5vdCBzZXQKQ09O RklHX0lYR0JFVkY9bQpDT05GSUdfSVhHQkVWRl9JUFNFQz15CkNPTkZJR19JNDBFPW0KQ09O RklHX0k0MEVfRENCPXkKQ09ORklHX0lBVkY9bQpDT05GSUdfSTQwRVZGPW0KQ09ORklHX0lD RT1tCkNPTkZJR19GTTEwSz1tCkNPTkZJR19JR0M9bQpDT05GSUdfSk1FPW0KQ09ORklHX05F VF9WRU5ET1JfTUFSVkVMTD15CkNPTkZJR19NVk1ESU89bQpDT05GSUdfU0tHRT1tCiMgQ09O RklHX1NLR0VfREVCVUcgaXMgbm90IHNldApDT05GSUdfU0tHRV9HRU5FU0lTPXkKQ09ORklH X1NLWTI9bQojIENPTkZJR19TS1kyX0RFQlVHIGlzIG5vdCBzZXQKQ09ORklHX1BSRVNURVJB PW0KQ09ORklHX1BSRVNURVJBX1BDST1tCkNPTkZJR19ORVRfVkVORE9SX01FTExBTk9YPXkK Q09ORklHX01MWDRfRU49bQpDT05GSUdfTUxYNF9FTl9EQ0I9eQpDT05GSUdfTUxYNF9DT1JF PW0KQ09ORklHX01MWDRfREVCVUc9eQpDT05GSUdfTUxYNF9DT1JFX0dFTjI9eQpDT05GSUdf TUxYNV9DT1JFPW0KQ09ORklHX01MWDVfQUNDRUw9eQpDT05GSUdfTUxYNV9GUEdBPXkKQ09O RklHX01MWDVfQ09SRV9FTj15CkNPTkZJR19NTFg1X0VOX0FSRlM9eQpDT05GSUdfTUxYNV9F Tl9SWE5GQz15CkNPTkZJR19NTFg1X01QRlM9eQpDT05GSUdfTUxYNV9FU1dJVENIPXkKQ09O RklHX01MWDVfQ0xTX0FDVD15CkNPTkZJR19NTFg1X1RDX0NUPXkKQ09ORklHX01MWDVfQ09S RV9FTl9EQ0I9eQpDT05GSUdfTUxYNV9DT1JFX0lQT0lCPXkKQ09ORklHX01MWDVfRlBHQV9J UFNFQz15CkNPTkZJR19NTFg1X0lQU0VDPXkKQ09ORklHX01MWDVfRU5fSVBTRUM9eQpDT05G SUdfTUxYNV9GUEdBX1RMUz15CkNPTkZJR19NTFg1X1RMUz15CkNPTkZJR19NTFg1X0VOX1RM Uz15CkNPTkZJR19NTFg1X1NXX1NURUVSSU5HPXkKQ09ORklHX01MWDVfU0Y9eQpDT05GSUdf TUxYNV9TRl9NQU5BR0VSPXkKQ09ORklHX01MWFNXX0NPUkU9bQpDT05GSUdfTUxYU1dfQ09S RV9IV01PTj15CkNPTkZJR19NTFhTV19DT1JFX1RIRVJNQUw9eQpDT05GSUdfTUxYU1dfUENJ PW0KQ09ORklHX01MWFNXX0kyQz1tCkNPTkZJR19NTFhTV19TV0lUQ0hJQj1tCkNPTkZJR19N TFhTV19TV0lUQ0hYMj1tCkNPTkZJR19NTFhTV19TUEVDVFJVTT1tCkNPTkZJR19NTFhTV19T UEVDVFJVTV9EQ0I9eQpDT05GSUdfTUxYU1dfTUlOSU1BTD1tCkNPTkZJR19NTFhGVz1tCkNP TkZJR19ORVRfVkVORE9SX01JQ1JFTD15CkNPTkZJR19LUzg4NDI9bQpDT05GSUdfS1M4ODUx PW0KQ09ORklHX0tTODg1MV9NTEw9bQpDT05GSUdfS1NaODg0WF9QQ0k9bQpDT05GSUdfTkVU X1ZFTkRPUl9NSUNST0NISVA9eQpDT05GSUdfRU5DMjhKNjA9bQojIENPTkZJR19FTkMyOEo2 MF9XUklURVZFUklGWSBpcyBub3Qgc2V0CkNPTkZJR19FTkNYMjRKNjAwPW0KQ09ORklHX0xB Tjc0M1g9bQpDT05GSUdfTkVUX1ZFTkRPUl9NSUNST1NFTUk9eQpDT05GSUdfTVNDQ19PQ0VM T1RfU1dJVENIX0xJQj1tCkNPTkZJR19ORVRfVkVORE9SX01ZUkk9eQpDT05GSUdfTVlSSTEw R0U9bQpDT05GSUdfTVlSSTEwR0VfRENBPXkKQ09ORklHX0ZFQUxOWD1tCkNPTkZJR19ORVRf VkVORE9SX05BVFNFTUk9eQpDT05GSUdfTkFUU0VNST1tCkNPTkZJR19OUzgzODIwPW0KQ09O RklHX05FVF9WRU5ET1JfTkVURVJJT049eQpDT05GSUdfUzJJTz1tCkNPTkZJR19WWEdFPW0K IyBDT05GSUdfVlhHRV9ERUJVR19UUkFDRV9BTEwgaXMgbm90IHNldApDT05GSUdfTkVUX1ZF TkRPUl9ORVRST05PTUU9eQpDT05GSUdfTkZQPW0KQ09ORklHX05GUF9BUFBfRkxPV0VSPXkK Q09ORklHX05GUF9BUFBfQUJNX05JQz15CiMgQ09ORklHX05GUF9ERUJVRyBpcyBub3Qgc2V0 CkNPTkZJR19ORVRfVkVORE9SX05JPXkKQ09ORklHX05JX1hHRV9NQU5BR0VNRU5UX0VORVQ9 bQpDT05GSUdfTkVUX1ZFTkRPUl84MzkwPXkKQ09ORklHX1BDTUNJQV9BWE5FVD1tCkNPTkZJ R19ORTJLX1BDST1tCkNPTkZJR19QQ01DSUFfUENORVQ9bQpDT05GSUdfTkVUX1ZFTkRPUl9O VklESUE9eQpDT05GSUdfRk9SQ0VERVRIPW0KQ09ORklHX05FVF9WRU5ET1JfT0tJPXkKQ09O RklHX0VUSE9DPW0KQ09ORklHX05FVF9WRU5ET1JfUEFDS0VUX0VOR0lORVM9eQpDT05GSUdf SEFNQUNIST1tCkNPTkZJR19ZRUxMT1dGSU49bQpDT05GSUdfTkVUX1ZFTkRPUl9QRU5TQU5E Tz15CkNPTkZJR19JT05JQz1tCkNPTkZJR19ORVRfVkVORE9SX1FMT0dJQz15CkNPTkZJR19R TEEzWFhYPW0KQ09ORklHX1FMQ05JQz1tCkNPTkZJR19RTENOSUNfU1JJT1Y9eQpDT05GSUdf UUxDTklDX0RDQj15CkNPTkZJR19RTENOSUNfSFdNT049eQpDT05GSUdfTkVUWEVOX05JQz1t CkNPTkZJR19RRUQ9bQpDT05GSUdfUUVEX0xMMj15CkNPTkZJR19RRURfU1JJT1Y9eQpDT05G SUdfUUVERT1tCkNPTkZJR19RRURfUkRNQT15CkNPTkZJR19RRURfSVNDU0k9eQpDT05GSUdf UUVEX0ZDT0U9eQpDT05GSUdfUUVEX09PTz15CkNPTkZJR19ORVRfVkVORE9SX1FVQUxDT01N PXkKQ09ORklHX1FDT01fRU1BQz1tCkNPTkZJR19STU5FVD1tCkNPTkZJR19ORVRfVkVORE9S X1JEQz15CkNPTkZJR19SNjA0MD1tCkNPTkZJR19ORVRfVkVORE9SX1JFQUxURUs9eQpDT05G SUdfQVRQPW0KQ09ORklHXzgxMzlDUD1tCkNPTkZJR184MTM5VE9PPW0KIyBDT05GSUdfODEz OVRPT19QSU8gaXMgbm90IHNldApDT05GSUdfODEzOVRPT19UVU5FX1RXSVNURVI9eQpDT05G SUdfODEzOVRPT184MTI5PXkKIyBDT05GSUdfODEzOV9PTERfUlhfUkVTRVQgaXMgbm90IHNl dApDT05GSUdfUjgxNjk9bQpDT05GSUdfTkVUX1ZFTkRPUl9SRU5FU0FTPXkKQ09ORklHX05F VF9WRU5ET1JfUk9DS0VSPXkKQ09ORklHX1JPQ0tFUj1tCkNPTkZJR19ORVRfVkVORE9SX1NB TVNVTkc9eQpDT05GSUdfU1hHQkVfRVRIPW0KQ09ORklHX05FVF9WRU5ET1JfU0VFUT15CkNP TkZJR19ORVRfVkVORE9SX1NPTEFSRkxBUkU9eQpDT05GSUdfU0ZDPW0KQ09ORklHX1NGQ19N VEQ9eQpDT05GSUdfU0ZDX01DRElfTU9OPXkKQ09ORklHX1NGQ19TUklPVj15CkNPTkZJR19T RkNfTUNESV9MT0dHSU5HPXkKQ09ORklHX1NGQ19GQUxDT049bQpDT05GSUdfU0ZDX0ZBTENP Tl9NVEQ9eQpDT05GSUdfTkVUX1ZFTkRPUl9TSUxBTj15CkNPTkZJR19TQzkyMDMxPW0KQ09O RklHX05FVF9WRU5ET1JfU0lTPXkKQ09ORklHX1NJUzkwMD1tCkNPTkZJR19TSVMxOTA9bQpD T05GSUdfTkVUX1ZFTkRPUl9TTVNDPXkKQ09ORklHX1BDTUNJQV9TTUM5MUM5Mj1tCkNPTkZJ R19FUElDMTAwPW0KQ09ORklHX1NNU0M5MTFYPW0KQ09ORklHX1NNU0M5NDIwPW0KQ09ORklH X05FVF9WRU5ET1JfU09DSU9ORVhUPXkKQ09ORklHX05FVF9WRU5ET1JfU1RNSUNSTz15CkNP TkZJR19TVE1NQUNfRVRIPW0KIyBDT05GSUdfU1RNTUFDX1NFTEZURVNUUyBpcyBub3Qgc2V0 CkNPTkZJR19TVE1NQUNfUExBVEZPUk09bQpDT05GSUdfRFdNQUNfR0VORVJJQz1tCkNPTkZJ R19EV01BQ19JTlRFTD1tCkNPTkZJR19TVE1NQUNfUENJPW0KQ09ORklHX05FVF9WRU5ET1Jf U1VOPXkKQ09ORklHX0hBUFBZTUVBTD1tCkNPTkZJR19TVU5HRU09bQpDT05GSUdfQ0FTU0lO ST1tCkNPTkZJR19OSVU9bQpDT05GSUdfTkVUX1ZFTkRPUl9TWU5PUFNZUz15CkNPTkZJR19E V0NfWExHTUFDPW0KQ09ORklHX0RXQ19YTEdNQUNfUENJPW0KQ09ORklHX05FVF9WRU5ET1Jf VEVIVVRJPXkKQ09ORklHX1RFSFVUST1tCkNPTkZJR19ORVRfVkVORE9SX1RJPXkKIyBDT05G SUdfVElfQ1BTV19QSFlfU0VMIGlzIG5vdCBzZXQKQ09ORklHX1RMQU49bQpDT05GSUdfTkVU X1ZFTkRPUl9WSUE9eQpDT05GSUdfVklBX1JISU5FPW0KQ09ORklHX1ZJQV9SSElORV9NTUlP PXkKQ09ORklHX1ZJQV9WRUxPQ0lUWT1tCkNPTkZJR19ORVRfVkVORE9SX1dJWk5FVD15CkNP TkZJR19XSVpORVRfVzUxMDA9bQpDT05GSUdfV0laTkVUX1c1MzAwPW0KIyBDT05GSUdfV0la TkVUX0JVU19ESVJFQ1QgaXMgbm90IHNldAojIENPTkZJR19XSVpORVRfQlVTX0lORElSRUNU IGlzIG5vdCBzZXQKQ09ORklHX1dJWk5FVF9CVVNfQU5ZPXkKQ09ORklHX1dJWk5FVF9XNTEw MF9TUEk9bQpDT05GSUdfTkVUX1ZFTkRPUl9YSUxJTlg9eQpDT05GSUdfWElMSU5YX0VNQUNM SVRFPW0KQ09ORklHX1hJTElOWF9BWElfRU1BQz1tCkNPTkZJR19YSUxJTlhfTExfVEVNQUM9 bQpDT05GSUdfTkVUX1ZFTkRPUl9YSVJDT009eQpDT05GSUdfUENNQ0lBX1hJUkMyUFM9bQpD T05GSUdfRkREST1tCkNPTkZJR19ERUZYWD1tCkNPTkZJR19ERUZYWF9NTUlPPXkKQ09ORklH X1NLRlA9bQojIENPTkZJR19ISVBQSSBpcyBub3Qgc2V0CkNPTkZJR19ORVRfU0IxMDAwPW0K Q09ORklHX1BIWUxJTks9bQpDT05GSUdfUEhZTElCPW0KQ09ORklHX1NXUEhZPXkKQ09ORklH X0xFRF9UUklHR0VSX1BIWT15CkNPTkZJR19GSVhFRF9QSFk9bQpDT05GSUdfU0ZQPW0KCiMK IyBNSUkgUEhZIGRldmljZSBkcml2ZXJzCiMKQ09ORklHX0FNRF9QSFk9bQpDT05GSUdfQURJ Tl9QSFk9bQpDT05GSUdfQVFVQU5USUFfUEhZPW0KQ09ORklHX0FYODg3OTZCX1BIWT1tCkNP TkZJR19CUk9BRENPTV9QSFk9bQpDT05GSUdfQkNNNTQxNDBfUEhZPW0KQ09ORklHX0JDTTdY WFhfUEhZPW0KQ09ORklHX0JDTTg0ODgxX1BIWT1tCkNPTkZJR19CQ004N1hYX1BIWT1tCkNP TkZJR19CQ01fTkVUX1BIWUxJQj1tCkNPTkZJR19DSUNBREFfUEhZPW0KQ09ORklHX0NPUlRJ TkFfUEhZPW0KQ09ORklHX0RBVklDT01fUEhZPW0KQ09ORklHX0lDUExVU19QSFk9bQpDT05G SUdfTFhUX1BIWT1tCkNPTkZJR19JTlRFTF9YV0FZX1BIWT1tCkNPTkZJR19MU0lfRVQxMDEx Q19QSFk9bQpDT05GSUdfTUFSVkVMTF9QSFk9bQpDT05GSUdfTUFSVkVMTF8xMEdfUEhZPW0K Q09ORklHX01JQ1JFTF9QSFk9bQpDT05GSUdfTUlDUk9DSElQX1BIWT1tCkNPTkZJR19NSUNS T0NISVBfVDFfUEhZPW0KQ09ORklHX01JQ1JPU0VNSV9QSFk9bQpDT05GSUdfTkFUSU9OQUxf UEhZPW0KQ09ORklHX05YUF9USkExMVhYX1BIWT1tCkNPTkZJR19BVDgwM1hfUEhZPW0KQ09O RklHX1FTRU1JX1BIWT1tCkNPTkZJR19SRUFMVEVLX1BIWT1tCkNPTkZJR19SRU5FU0FTX1BI WT1tCiMgQ09ORklHX1JPQ0tDSElQX1BIWSBpcyBub3Qgc2V0CkNPTkZJR19TTVNDX1BIWT1t CkNPTkZJR19TVEUxMFhQPW0KQ09ORklHX1RFUkFORVRJQ1NfUEhZPW0KQ09ORklHX0RQODM4 MjJfUEhZPW0KQ09ORklHX0RQODNUQzgxMV9QSFk9bQpDT05GSUdfRFA4Mzg0OF9QSFk9bQpD T05GSUdfRFA4Mzg2N19QSFk9bQpDT05GSUdfRFA4Mzg2OV9QSFk9bQpDT05GSUdfVklURVNT RV9QSFk9bQpDT05GSUdfWElMSU5YX0dNSUkyUkdNSUk9bQpDT05GSUdfTUlDUkVMX0tTODk5 NU1BPW0KQ09ORklHX01ESU9fREVWSUNFPW0KQ09ORklHX01ESU9fQlVTPW0KQ09ORklHX01E SU9fREVWUkVTPW0KQ09ORklHX01ESU9fQklUQkFORz1tCkNPTkZJR19NRElPX0JDTV9VTklN QUM9bQpDT05GSUdfTURJT19DQVZJVU09bQpDT05GSUdfTURJT19HUElPPW0KQ09ORklHX01E SU9fSTJDPW0KQ09ORklHX01ESU9fTVZVU0I9bQpDT05GSUdfTURJT19NU0NDX01JSU09bQpD T05GSUdfTURJT19USFVOREVSPW0KCiMKIyBNRElPIE11bHRpcGxleGVycwojCgojCiMgUENT IGRldmljZSBkcml2ZXJzCiMKQ09ORklHX1BDU19YUENTPW0KQ09ORklHX1BDU19MWU5YPW0K IyBlbmQgb2YgUENTIGRldmljZSBkcml2ZXJzCgpDT05GSUdfUExJUD1tCkNPTkZJR19QUFA9 bQpDT05GSUdfUFBQX0JTRENPTVA9bQpDT05GSUdfUFBQX0RFRkxBVEU9bQpDT05GSUdfUFBQ X0ZJTFRFUj15CkNPTkZJR19QUFBfTVBQRT1tCkNPTkZJR19QUFBfTVVMVElMSU5LPXkKQ09O RklHX1BQUE9BVE09bQpDT05GSUdfUFBQT0U9bQpDT05GSUdfUFBUUD1tCkNPTkZJR19QUFBP TDJUUD1tCkNPTkZJR19QUFBfQVNZTkM9bQpDT05GSUdfUFBQX1NZTkNfVFRZPW0KQ09ORklH X1NMSVA9bQpDT05GSUdfU0xIQz1tCkNPTkZJR19TTElQX0NPTVBSRVNTRUQ9eQpDT05GSUdf U0xJUF9TTUFSVD15CkNPTkZJR19TTElQX01PREVfU0xJUDY9eQpDT05GSUdfVVNCX05FVF9E UklWRVJTPW0KQ09ORklHX1VTQl9DQVRDPW0KQ09ORklHX1VTQl9LQVdFVEg9bQpDT05GSUdf VVNCX1BFR0FTVVM9bQpDT05GSUdfVVNCX1JUTDgxNTA9bQpDT05GSUdfVVNCX1JUTDgxNTI9 bQpDT05GSUdfVVNCX0xBTjc4WFg9bQpDT05GSUdfVVNCX1VTQk5FVD1tCkNPTkZJR19VU0Jf TkVUX0FYODgxN1g9bQpDT05GSUdfVVNCX05FVF9BWDg4MTc5XzE3OEE9bQpDT05GSUdfVVNC X05FVF9DRENFVEhFUj1tCkNPTkZJR19VU0JfTkVUX0NEQ19FRU09bQpDT05GSUdfVVNCX05F VF9DRENfTkNNPW0KQ09ORklHX1VTQl9ORVRfSFVBV0VJX0NEQ19OQ009bQpDT05GSUdfVVNC X05FVF9DRENfTUJJTT1tCkNPTkZJR19VU0JfTkVUX0RNOTYwMT1tCkNPTkZJR19VU0JfTkVU X1NSOTcwMD1tCkNPTkZJR19VU0JfTkVUX1NSOTgwMD1tCkNPTkZJR19VU0JfTkVUX1NNU0M3 NVhYPW0KQ09ORklHX1VTQl9ORVRfU01TQzk1WFg9bQpDT05GSUdfVVNCX05FVF9HTDYyMEE9 bQpDT05GSUdfVVNCX05FVF9ORVQxMDgwPW0KQ09ORklHX1VTQl9ORVRfUExVU0I9bQpDT05G SUdfVVNCX05FVF9NQ1M3ODMwPW0KQ09ORklHX1VTQl9ORVRfUk5ESVNfSE9TVD1tCkNPTkZJ R19VU0JfTkVUX0NEQ19TVUJTRVRfRU5BQkxFPW0KQ09ORklHX1VTQl9ORVRfQ0RDX1NVQlNF VD1tCkNPTkZJR19VU0JfQUxJX001NjMyPXkKQ09ORklHX1VTQl9BTjI3MjA9eQpDT05GSUdf VVNCX0JFTEtJTj15CkNPTkZJR19VU0JfQVJNTElOVVg9eQpDT05GSUdfVVNCX0VQU09OMjg4 OD15CkNPTkZJR19VU0JfS0MyMTkwPXkKQ09ORklHX1VTQl9ORVRfWkFVUlVTPW0KQ09ORklH X1VTQl9ORVRfQ1g4MjMxMF9FVEg9bQpDT05GSUdfVVNCX05FVF9LQUxNSUE9bQpDT05GSUdf VVNCX05FVF9RTUlfV1dBTj1tCkNPTkZJR19VU0JfSFNPPW0KQ09ORklHX1VTQl9ORVRfSU5U NTFYMT1tCkNPTkZJR19VU0JfQ0RDX1BIT05FVD1tCkNPTkZJR19VU0JfSVBIRVRIPW0KQ09O RklHX1VTQl9TSUVSUkFfTkVUPW0KQ09ORklHX1VTQl9WTDYwMD1tCkNPTkZJR19VU0JfTkVU X0NIOTIwMD1tCkNPTkZJR19VU0JfTkVUX0FRQzExMT1tCkNPTkZJR19VU0JfUlRMODE1M19F Q009bQpDT05GSUdfV0xBTj15CkNPTkZJR19XTEFOX1ZFTkRPUl9BRE1URUs9eQpDT05GSUdf QURNODIxMT1tCkNPTkZJR19BVEhfQ09NTU9OPW0KQ09ORklHX1dMQU5fVkVORE9SX0FUSD15 CiMgQ09ORklHX0FUSF9ERUJVRyBpcyBub3Qgc2V0CkNPTkZJR19BVEg1Sz1tCkNPTkZJR19B VEg1S19ERUJVRz15CkNPTkZJR19BVEg1S19UUkFDRVI9eQpDT05GSUdfQVRINUtfUENJPXkK Q09ORklHX0FUSDlLX0hXPW0KQ09ORklHX0FUSDlLX0NPTU1PTj1tCkNPTkZJR19BVEg5S19D T01NT05fREVCVUc9eQpDT05GSUdfQVRIOUtfQlRDT0VYX1NVUFBPUlQ9eQpDT05GSUdfQVRI OUs9bQpDT05GSUdfQVRIOUtfUENJPXkKQ09ORklHX0FUSDlLX0FIQj15CkNPTkZJR19BVEg5 S19ERUJVR0ZTPXkKQ09ORklHX0FUSDlLX1NUQVRJT05fU1RBVElTVElDUz15CkNPTkZJR19B VEg5S19EWU5BQ0s9eQpDT05GSUdfQVRIOUtfV09XPXkKQ09ORklHX0FUSDlLX1JGS0lMTD15 CkNPTkZJR19BVEg5S19DSEFOTkVMX0NPTlRFWFQ9eQpDT05GSUdfQVRIOUtfUENPRU09eQpD T05GSUdfQVRIOUtfUENJX05PX0VFUFJPTT1tCkNPTkZJR19BVEg5S19IVEM9bQpDT05GSUdf QVRIOUtfSFRDX0RFQlVHRlM9eQpDT05GSUdfQVRIOUtfSFdSTkc9eQpDT05GSUdfQVRIOUtf Q09NTU9OX1NQRUNUUkFMPXkKQ09ORklHX0NBUkw5MTcwPW0KQ09ORklHX0NBUkw5MTcwX0xF RFM9eQpDT05GSUdfQ0FSTDkxNzBfREVCVUdGUz15CkNPTkZJR19DQVJMOTE3MF9XUEM9eQoj IENPTkZJR19DQVJMOTE3MF9IV1JORyBpcyBub3Qgc2V0CkNPTkZJR19BVEg2S0w9bQpDT05G SUdfQVRINktMX1NESU89bQpDT05GSUdfQVRINktMX1VTQj1tCkNPTkZJR19BVEg2S0xfREVC VUc9eQpDT05GSUdfQVRINktMX1RSQUNJTkc9eQpDT05GSUdfQVI1NTIzPW0KQ09ORklHX1dJ TDYyMTA9bQpDT05GSUdfV0lMNjIxMF9JU1JfQ09SPXkKQ09ORklHX1dJTDYyMTBfVFJBQ0lO Rz15CkNPTkZJR19XSUw2MjEwX0RFQlVHRlM9eQpDT05GSUdfQVRIMTBLPW0KQ09ORklHX0FU SDEwS19DRT15CkNPTkZJR19BVEgxMEtfUENJPW0KQ09ORklHX0FUSDEwS19TRElPPW0KQ09O RklHX0FUSDEwS19VU0I9bQpDT05GSUdfQVRIMTBLX0RFQlVHPXkKQ09ORklHX0FUSDEwS19E RUJVR0ZTPXkKQ09ORklHX0FUSDEwS19TUEVDVFJBTD15CkNPTkZJR19BVEgxMEtfVFJBQ0lO Rz15CkNPTkZJR19XQ04zNlhYPW0KQ09ORklHX1dDTjM2WFhfREVCVUdGUz15CkNPTkZJR19B VEgxMUs9bQpDT05GSUdfQVRIMTFLX0FIQj1tCkNPTkZJR19BVEgxMUtfUENJPW0KQ09ORklH X0FUSDExS19ERUJVRz15CkNPTkZJR19BVEgxMUtfREVCVUdGUz15CiMgQ09ORklHX0FUSDEx S19UUkFDSU5HIGlzIG5vdCBzZXQKQ09ORklHX0FUSDExS19TUEVDVFJBTD15CkNPTkZJR19X TEFOX1ZFTkRPUl9BVE1FTD15CkNPTkZJR19BVE1FTD1tCkNPTkZJR19QQ0lfQVRNRUw9bQpD T05GSUdfUENNQ0lBX0FUTUVMPW0KQ09ORklHX0FUNzZDNTBYX1VTQj1tCkNPTkZJR19XTEFO X1ZFTkRPUl9CUk9BRENPTT15CkNPTkZJR19CNDM9bQpDT05GSUdfQjQzX0JDTUE9eQpDT05G SUdfQjQzX1NTQj15CkNPTkZJR19CNDNfQlVTRVNfQkNNQV9BTkRfU1NCPXkKIyBDT05GSUdf QjQzX0JVU0VTX0JDTUEgaXMgbm90IHNldAojIENPTkZJR19CNDNfQlVTRVNfU1NCIGlzIG5v dCBzZXQKQ09ORklHX0I0M19QQ0lfQVVUT1NFTEVDVD15CkNPTkZJR19CNDNfUENJQ09SRV9B VVRPU0VMRUNUPXkKQ09ORklHX0I0M19TRElPPXkKQ09ORklHX0I0M19CQ01BX1BJTz15CkNP TkZJR19CNDNfUElPPXkKQ09ORklHX0I0M19QSFlfRz15CkNPTkZJR19CNDNfUEhZX049eQpD T05GSUdfQjQzX1BIWV9MUD15CkNPTkZJR19CNDNfUEhZX0hUPXkKQ09ORklHX0I0M19MRURT PXkKQ09ORklHX0I0M19IV1JORz15CiMgQ09ORklHX0I0M19ERUJVRyBpcyBub3Qgc2V0CkNP TkZJR19CNDNMRUdBQ1k9bQpDT05GSUdfQjQzTEVHQUNZX1BDSV9BVVRPU0VMRUNUPXkKQ09O RklHX0I0M0xFR0FDWV9QQ0lDT1JFX0FVVE9TRUxFQ1Q9eQpDT05GSUdfQjQzTEVHQUNZX0xF RFM9eQpDT05GSUdfQjQzTEVHQUNZX0hXUk5HPXkKQ09ORklHX0I0M0xFR0FDWV9ERUJVRz15 CkNPTkZJR19CNDNMRUdBQ1lfRE1BPXkKQ09ORklHX0I0M0xFR0FDWV9QSU89eQpDT05GSUdf QjQzTEVHQUNZX0RNQV9BTkRfUElPX01PREU9eQojIENPTkZJR19CNDNMRUdBQ1lfRE1BX01P REUgaXMgbm90IHNldAojIENPTkZJR19CNDNMRUdBQ1lfUElPX01PREUgaXMgbm90IHNldApD T05GSUdfQlJDTVVUSUw9bQpDT05GSUdfQlJDTVNNQUM9bQpDT05GSUdfQlJDTUZNQUM9bQpD T05GSUdfQlJDTUZNQUNfUFJPVE9fQkNEQz15CkNPTkZJR19CUkNNRk1BQ19QUk9UT19NU0dC VUY9eQpDT05GSUdfQlJDTUZNQUNfU0RJTz15CkNPTkZJR19CUkNNRk1BQ19VU0I9eQpDT05G SUdfQlJDTUZNQUNfUENJRT15CkNPTkZJR19CUkNNX1RSQUNJTkc9eQpDT05GSUdfQlJDTURC Rz15CkNPTkZJR19XTEFOX1ZFTkRPUl9DSVNDTz15CkNPTkZJR19BSVJPPW0KQ09ORklHX0FJ Uk9fQ1M9bQpDT05GSUdfV0xBTl9WRU5ET1JfSU5URUw9eQpDT05GSUdfSVBXMjEwMD1tCkNP TkZJR19JUFcyMTAwX01PTklUT1I9eQojIENPTkZJR19JUFcyMTAwX0RFQlVHIGlzIG5vdCBz ZXQKQ09ORklHX0lQVzIyMDA9bQpDT05GSUdfSVBXMjIwMF9NT05JVE9SPXkKQ09ORklHX0lQ VzIyMDBfUkFESU9UQVA9eQpDT05GSUdfSVBXMjIwMF9QUk9NSVNDVU9VUz15CkNPTkZJR19J UFcyMjAwX1FPUz15CiMgQ09ORklHX0lQVzIyMDBfREVCVUcgaXMgbm90IHNldApDT05GSUdf TElCSVBXPW0KIyBDT05GSUdfTElCSVBXX0RFQlVHIGlzIG5vdCBzZXQKQ09ORklHX0lXTEVH QUNZPW0KQ09ORklHX0lXTDQ5NjU9bQpDT05GSUdfSVdMMzk0NT1tCgojCiMgaXdsMzk0NSAv IGl3bDQ5NjUgRGVidWdnaW5nIE9wdGlvbnMKIwpDT05GSUdfSVdMRUdBQ1lfREVCVUc9eQpD T05GSUdfSVdMRUdBQ1lfREVCVUdGUz15CiMgZW5kIG9mIGl3bDM5NDUgLyBpd2w0OTY1IERl YnVnZ2luZyBPcHRpb25zCgpDT05GSUdfSVdMV0lGST1tCkNPTkZJR19JV0xXSUZJX0xFRFM9 eQpDT05GSUdfSVdMRFZNPW0KQ09ORklHX0lXTE1WTT1tCkNPTkZJR19JV0xXSUZJX09QTU9E RV9NT0RVTEFSPXkKIyBDT05GSUdfSVdMV0lGSV9CQ0FTVF9GSUxURVJJTkcgaXMgbm90IHNl dAoKIwojIERlYnVnZ2luZyBPcHRpb25zCiMKQ09ORklHX0lXTFdJRklfREVCVUc9eQpDT05G SUdfSVdMV0lGSV9ERUJVR0ZTPXkKQ09ORklHX0lXTFdJRklfREVWSUNFX1RSQUNJTkc9eQoj IGVuZCBvZiBEZWJ1Z2dpbmcgT3B0aW9ucwoKQ09ORklHX1dMQU5fVkVORE9SX0lOVEVSU0lM PXkKQ09ORklHX0hPU1RBUD1tCkNPTkZJR19IT1NUQVBfRklSTVdBUkU9eQpDT05GSUdfSE9T VEFQX0ZJUk1XQVJFX05WUkFNPXkKQ09ORklHX0hPU1RBUF9QTFg9bQpDT05GSUdfSE9TVEFQ X1BDST1tCkNPTkZJR19IT1NUQVBfQ1M9bQpDT05GSUdfSEVSTUVTPW0KQ09ORklHX0hFUk1F U19QUklTTT15CkNPTkZJR19IRVJNRVNfQ0FDSEVfRldfT05fSU5JVD15CkNPTkZJR19QTFhf SEVSTUVTPW0KQ09ORklHX1RNRF9IRVJNRVM9bQpDT05GSUdfTk9SVEVMX0hFUk1FUz1tCkNP TkZJR19QQ0lfSEVSTUVTPW0KQ09ORklHX1BDTUNJQV9IRVJNRVM9bQpDT05GSUdfUENNQ0lB X1NQRUNUUlVNPW0KQ09ORklHX09SSU5PQ09fVVNCPW0KQ09ORklHX1A1NF9DT01NT049bQpD T05GSUdfUDU0X1VTQj1tCkNPTkZJR19QNTRfUENJPW0KQ09ORklHX1A1NF9TUEk9bQojIENP TkZJR19QNTRfU1BJX0RFRkFVTFRfRUVQUk9NIGlzIG5vdCBzZXQKQ09ORklHX1A1NF9MRURT PXkKQ09ORklHX1BSSVNNNTQ9bQpDT05GSUdfV0xBTl9WRU5ET1JfTUFSVkVMTD15CkNPTkZJ R19MSUJFUlRBUz1tCkNPTkZJR19MSUJFUlRBU19VU0I9bQpDT05GSUdfTElCRVJUQVNfQ1M9 bQpDT05GSUdfTElCRVJUQVNfU0RJTz1tCkNPTkZJR19MSUJFUlRBU19TUEk9bQojIENPTkZJ R19MSUJFUlRBU19ERUJVRyBpcyBub3Qgc2V0CkNPTkZJR19MSUJFUlRBU19NRVNIPXkKQ09O RklHX0xJQkVSVEFTX1RISU5GSVJNPW0KIyBDT05GSUdfTElCRVJUQVNfVEhJTkZJUk1fREVC VUcgaXMgbm90IHNldApDT05GSUdfTElCRVJUQVNfVEhJTkZJUk1fVVNCPW0KQ09ORklHX01X SUZJRVg9bQpDT05GSUdfTVdJRklFWF9TRElPPW0KQ09ORklHX01XSUZJRVhfUENJRT1tCkNP TkZJR19NV0lGSUVYX1VTQj1tCkNPTkZJR19NV0w4Sz1tCkNPTkZJR19XTEFOX1ZFTkRPUl9N RURJQVRFSz15CkNPTkZJR19NVDc2MDFVPW0KQ09ORklHX01UNzZfQ09SRT1tCkNPTkZJR19N VDc2X0xFRFM9eQpDT05GSUdfTVQ3Nl9VU0I9bQpDT05GSUdfTVQ3Nl9TRElPPW0KQ09ORklH X01UNzZ4MDJfTElCPW0KQ09ORklHX01UNzZ4MDJfVVNCPW0KQ09ORklHX01UNzZfQ09OTkFD X0xJQj1tCkNPTkZJR19NVDc2eDBfQ09NTU9OPW0KQ09ORklHX01UNzZ4MFU9bQpDT05GSUdf TVQ3NngwRT1tCkNPTkZJR19NVDc2eDJfQ09NTU9OPW0KQ09ORklHX01UNzZ4MkU9bQpDT05G SUdfTVQ3NngyVT1tCkNPTkZJR19NVDc2MDNFPW0KQ09ORklHX01UNzYxNV9DT01NT049bQpD T05GSUdfTVQ3NjE1RT1tCkNPTkZJR19NVDc2NjNfVVNCX1NESU9fQ09NTU9OPW0KQ09ORklH X01UNzY2M1U9bQpDT05GSUdfTVQ3NjYzUz1tCkNPTkZJR19NVDc5MTVFPW0KQ09ORklHX01U NzkyMUU9bQpDT05GSUdfV0xBTl9WRU5ET1JfTUlDUk9DSElQPXkKQ09ORklHX1dJTEMxMDAw PW0KQ09ORklHX1dJTEMxMDAwX1NESU89bQpDT05GSUdfV0lMQzEwMDBfU1BJPW0KIyBDT05G SUdfV0lMQzEwMDBfSFdfT09CX0lOVFIgaXMgbm90IHNldApDT05GSUdfV0xBTl9WRU5ET1Jf UkFMSU5LPXkKQ09ORklHX1JUMlgwMD1tCkNPTkZJR19SVDI0MDBQQ0k9bQpDT05GSUdfUlQy NTAwUENJPW0KQ09ORklHX1JUNjFQQ0k9bQpDT05GSUdfUlQyODAwUENJPW0KQ09ORklHX1JU MjgwMFBDSV9SVDMzWFg9eQpDT05GSUdfUlQyODAwUENJX1JUMzVYWD15CkNPTkZJR19SVDI4 MDBQQ0lfUlQ1M1hYPXkKQ09ORklHX1JUMjgwMFBDSV9SVDMyOTA9eQpDT05GSUdfUlQyNTAw VVNCPW0KQ09ORklHX1JUNzNVU0I9bQpDT05GSUdfUlQyODAwVVNCPW0KQ09ORklHX1JUMjgw MFVTQl9SVDMzWFg9eQpDT05GSUdfUlQyODAwVVNCX1JUMzVYWD15CkNPTkZJR19SVDI4MDBV U0JfUlQzNTczPXkKQ09ORklHX1JUMjgwMFVTQl9SVDUzWFg9eQpDT05GSUdfUlQyODAwVVNC X1JUNTVYWD15CkNPTkZJR19SVDI4MDBVU0JfVU5LTk9XTj15CkNPTkZJR19SVDI4MDBfTElC PW0KQ09ORklHX1JUMjgwMF9MSUJfTU1JTz1tCkNPTkZJR19SVDJYMDBfTElCX01NSU89bQpD T05GSUdfUlQyWDAwX0xJQl9QQ0k9bQpDT05GSUdfUlQyWDAwX0xJQl9VU0I9bQpDT05GSUdf UlQyWDAwX0xJQj1tCkNPTkZJR19SVDJYMDBfTElCX0ZJUk1XQVJFPXkKQ09ORklHX1JUMlgw MF9MSUJfQ1JZUFRPPXkKQ09ORklHX1JUMlgwMF9MSUJfTEVEUz15CkNPTkZJR19SVDJYMDBf TElCX0RFQlVHRlM9eQojIENPTkZJR19SVDJYMDBfREVCVUcgaXMgbm90IHNldApDT05GSUdf V0xBTl9WRU5ET1JfUkVBTFRFSz15CkNPTkZJR19SVEw4MTgwPW0KQ09ORklHX1JUTDgxODc9 bQpDT05GSUdfUlRMODE4N19MRURTPXkKQ09ORklHX1JUTF9DQVJEUz1tCkNPTkZJR19SVEw4 MTkyQ0U9bQpDT05GSUdfUlRMODE5MlNFPW0KQ09ORklHX1JUTDgxOTJERT1tCkNPTkZJR19S VEw4NzIzQUU9bQpDT05GSUdfUlRMODcyM0JFPW0KQ09ORklHX1JUTDgxODhFRT1tCkNPTkZJ R19SVEw4MTkyRUU9bQpDT05GSUdfUlRMODgyMUFFPW0KQ09ORklHX1JUTDgxOTJDVT1tCkNP TkZJR19SVExXSUZJPW0KQ09ORklHX1JUTFdJRklfUENJPW0KQ09ORklHX1JUTFdJRklfVVNC PW0KQ09ORklHX1JUTFdJRklfREVCVUc9eQpDT05GSUdfUlRMODE5MkNfQ09NTU9OPW0KQ09O RklHX1JUTDg3MjNfQ09NTU9OPW0KQ09ORklHX1JUTEJUQ09FWElTVD1tCkNPTkZJR19SVEw4 WFhYVT1tCkNPTkZJR19SVEw4WFhYVV9VTlRFU1RFRD15CkNPTkZJR19SVFc4OD1tCkNPTkZJ R19SVFc4OF9DT1JFPW0KQ09ORklHX1JUVzg4X1BDST1tCkNPTkZJR19SVFc4OF84ODIyQj1t CkNPTkZJR19SVFc4OF84ODIyQz1tCkNPTkZJR19SVFc4OF84NzIzRD1tCkNPTkZJR19SVFc4 OF84ODIxQz1tCkNPTkZJR19SVFc4OF84ODIyQkU9bQpDT05GSUdfUlRXODhfODgyMkNFPW0K Q09ORklHX1JUVzg4Xzg3MjNERT1tCkNPTkZJR19SVFc4OF84ODIxQ0U9bQpDT05GSUdfUlRX ODhfREVCVUc9eQpDT05GSUdfUlRXODhfREVCVUdGUz15CkNPTkZJR19XTEFOX1ZFTkRPUl9S U0k9eQpDT05GSUdfUlNJXzkxWD1tCkNPTkZJR19SU0lfREVCVUdGUz15CkNPTkZJR19SU0lf U0RJTz1tCkNPTkZJR19SU0lfVVNCPW0KQ09ORklHX1JTSV9DT0VYPXkKQ09ORklHX1dMQU5f VkVORE9SX1NUPXkKQ09ORklHX0NXMTIwMD1tCkNPTkZJR19DVzEyMDBfV0xBTl9TRElPPW0K Q09ORklHX0NXMTIwMF9XTEFOX1NQST1tCkNPTkZJR19XTEFOX1ZFTkRPUl9UST15CkNPTkZJ R19XTDEyNTE9bQpDT05GSUdfV0wxMjUxX1NQST1tCkNPTkZJR19XTDEyNTFfU0RJTz1tCkNP TkZJR19XTDEyWFg9bQpDT05GSUdfV0wxOFhYPW0KQ09ORklHX1dMQ09SRT1tCkNPTkZJR19X TENPUkVfU0RJTz1tCkNPTkZJR19XSUxJTktfUExBVEZPUk1fREFUQT15CkNPTkZJR19XTEFO X1ZFTkRPUl9aWURBUz15CkNPTkZJR19VU0JfWkQxMjAxPW0KQ09ORklHX1pEMTIxMVJXPW0K IyBDT05GSUdfWkQxMjExUldfREVCVUcgaXMgbm90IHNldApDT05GSUdfV0xBTl9WRU5ET1Jf UVVBTlRFTk5BPXkKQ09ORklHX1FUTkZNQUM9bQpDT05GSUdfUVRORk1BQ19QQ0lFPW0KQ09O RklHX1BDTUNJQV9SQVlDUz1tCkNPTkZJR19QQ01DSUFfV0wzNTAxPW0KQ09ORklHX01BQzgw MjExX0hXU0lNPW0KQ09ORklHX1VTQl9ORVRfUk5ESVNfV0xBTj1tCkNPTkZJR19WSVJUX1dJ Rkk9bQojIENPTkZJR19XQU4gaXMgbm90IHNldApDT05GSUdfSUVFRTgwMjE1NF9EUklWRVJT PW0KQ09ORklHX0lFRUU4MDIxNTRfRkFLRUxCPW0KQ09ORklHX0lFRUU4MDIxNTRfQVQ4NlJG MjMwPW0KIyBDT05GSUdfSUVFRTgwMjE1NF9BVDg2UkYyMzBfREVCVUdGUyBpcyBub3Qgc2V0 CkNPTkZJR19JRUVFODAyMTU0X01SRjI0SjQwPW0KQ09ORklHX0lFRUU4MDIxNTRfQ0MyNTIw PW0KQ09ORklHX0lFRUU4MDIxNTRfQVRVU0I9bQpDT05GSUdfSUVFRTgwMjE1NF9BREY3MjQy PW0KQ09ORklHX0lFRUU4MDIxNTRfQ0E4MjEwPW0KIyBDT05GSUdfSUVFRTgwMjE1NF9DQTgy MTBfREVCVUdGUyBpcyBub3Qgc2V0CkNPTkZJR19JRUVFODAyMTU0X01DUjIwQT1tCkNPTkZJ R19JRUVFODAyMTU0X0hXU0lNPW0KQ09ORklHX1hFTl9ORVRERVZfRlJPTlRFTkQ9bQpDT05G SUdfWEVOX05FVERFVl9CQUNLRU5EPW0KQ09ORklHX1ZNWE5FVDM9bQpDT05GSUdfRlVKSVRT VV9FUz1tCkNPTkZJR19VU0I0X05FVD1tCkNPTkZJR19IWVBFUlZfTkVUPW0KQ09ORklHX05F VERFVlNJTT1tCkNPTkZJR19ORVRfRkFJTE9WRVI9bQpDT05GSUdfSVNETj15CkNPTkZJR19J U0ROX0NBUEk9eQpDT05GSUdfQ0FQSV9UUkFDRT15CkNPTkZJR19JU0ROX0NBUElfTUlERExF V0FSRT15CkNPTkZJR19NSVNETj1tCkNPTkZJR19NSVNETl9EU1A9bQpDT05GSUdfTUlTRE5f TDFPSVA9bQoKIwojIG1JU0ROIGhhcmR3YXJlIGRyaXZlcnMKIwpDT05GSUdfTUlTRE5fSEZD UENJPW0KQ09ORklHX01JU0ROX0hGQ01VTFRJPW0KQ09ORklHX01JU0ROX0hGQ1VTQj1tCkNP TkZJR19NSVNETl9BVk1GUklUWj1tCkNPTkZJR19NSVNETl9TUEVFREZBWD1tCkNPTkZJR19N SVNETl9JTkZJTkVPTj1tCkNPTkZJR19NSVNETl9XNjY5Mj1tCkNPTkZJR19NSVNETl9ORVRK RVQ9bQpDT05GSUdfTUlTRE5fSERMQz1tCkNPTkZJR19NSVNETl9JUEFDPW0KQ09ORklHX01J U0ROX0lTQVI9bQpDT05GSUdfTlZNPXkKQ09ORklHX05WTV9QQkxLPW0KIyBDT05GSUdfTlZN X1BCTEtfREVCVUcgaXMgbm90IHNldAoKIwojIElucHV0IGRldmljZSBzdXBwb3J0CiMKQ09O RklHX0lOUFVUPXkKQ09ORklHX0lOUFVUX0xFRFM9eQpDT05GSUdfSU5QVVRfRkZfTUVNTEVT Uz1tCkNPTkZJR19JTlBVVF9TUEFSU0VLTUFQPW0KQ09ORklHX0lOUFVUX01BVFJJWEtNQVA9 bQoKIwojIFVzZXJsYW5kIGludGVyZmFjZXMKIwpDT05GSUdfSU5QVVRfTU9VU0VERVY9bQpD T05GSUdfSU5QVVRfTU9VU0VERVZfUFNBVVg9eQpDT05GSUdfSU5QVVRfTU9VU0VERVZfU0NS RUVOX1g9MTAyNApDT05GSUdfSU5QVVRfTU9VU0VERVZfU0NSRUVOX1k9NzY4CkNPTkZJR19J TlBVVF9KT1lERVY9bQpDT05GSUdfSU5QVVRfRVZERVY9eQojIENPTkZJR19JTlBVVF9FVkJV RyBpcyBub3Qgc2V0CgojCiMgSW5wdXQgRGV2aWNlIERyaXZlcnMKIwpDT05GSUdfSU5QVVRf S0VZQk9BUkQ9eQpDT05GSUdfS0VZQk9BUkRfQURDPW0KQ09ORklHX0tFWUJPQVJEX0FEUDU1 MjA9bQpDT05GSUdfS0VZQk9BUkRfQURQNTU4OD1tCkNPTkZJR19LRVlCT0FSRF9BRFA1NTg5 PW0KQ09ORklHX0tFWUJPQVJEX0FQUExFU1BJPW0KQ09ORklHX0tFWUJPQVJEX0FUS0JEPW0K Q09ORklHX0tFWUJPQVJEX1FUMTA1MD1tCkNPTkZJR19LRVlCT0FSRF9RVDEwNzA9bQpDT05G SUdfS0VZQk9BUkRfUVQyMTYwPW0KQ09ORklHX0tFWUJPQVJEX0RMSU5LX0RJUjY4NT1tCkNP TkZJR19LRVlCT0FSRF9MS0tCRD1tCkNPTkZJR19LRVlCT0FSRF9HUElPPW0KQ09ORklHX0tF WUJPQVJEX0dQSU9fUE9MTEVEPW0KQ09ORklHX0tFWUJPQVJEX1RDQTY0MTY9bQpDT05GSUdf S0VZQk9BUkRfVENBODQxOD1tCkNPTkZJR19LRVlCT0FSRF9NQVRSSVg9bQpDT05GSUdfS0VZ Qk9BUkRfTE04MzIzPW0KQ09ORklHX0tFWUJPQVJEX0xNODMzMz1tCkNPTkZJR19LRVlCT0FS RF9NQVg3MzU5PW0KQ09ORklHX0tFWUJPQVJEX01DUz1tCkNPTkZJR19LRVlCT0FSRF9NUFIx MjE9bQpDT05GSUdfS0VZQk9BUkRfTkVXVE9OPW0KQ09ORklHX0tFWUJPQVJEX09QRU5DT1JF Uz1tCkNPTkZJR19LRVlCT0FSRF9TQU1TVU5HPW0KQ09ORklHX0tFWUJPQVJEX1NUT1dBV0FZ PW0KQ09ORklHX0tFWUJPQVJEX1NVTktCRD1tCkNPTkZJR19LRVlCT0FSRF9JUVM2Mlg9bQpD T05GSUdfS0VZQk9BUkRfVE0yX1RPVUNIS0VZPW0KQ09ORklHX0tFWUJPQVJEX1RXTDQwMzA9 bQpDT05GSUdfS0VZQk9BUkRfWFRLQkQ9bQpDT05GSUdfS0VZQk9BUkRfQ1JPU19FQz1tCkNP TkZJR19LRVlCT0FSRF9NVEtfUE1JQz1tCkNPTkZJR19JTlBVVF9NT1VTRT15CkNPTkZJR19N T1VTRV9QUzI9bQpDT05GSUdfTU9VU0VfUFMyX0FMUFM9eQpDT05GSUdfTU9VU0VfUFMyX0JZ RD15CkNPTkZJR19NT1VTRV9QUzJfTE9HSVBTMlBQPXkKQ09ORklHX01PVVNFX1BTMl9TWU5B UFRJQ1M9eQpDT05GSUdfTU9VU0VfUFMyX1NZTkFQVElDU19TTUJVUz15CkNPTkZJR19NT1VT RV9QUzJfQ1lQUkVTUz15CkNPTkZJR19NT1VTRV9QUzJfTElGRUJPT0s9eQpDT05GSUdfTU9V U0VfUFMyX1RSQUNLUE9JTlQ9eQpDT05GSUdfTU9VU0VfUFMyX0VMQU5URUNIPXkKQ09ORklH X01PVVNFX1BTMl9FTEFOVEVDSF9TTUJVUz15CkNPTkZJR19NT1VTRV9QUzJfU0VOVEVMSUM9 eQpDT05GSUdfTU9VU0VfUFMyX1RPVUNIS0lUPXkKQ09ORklHX01PVVNFX1BTMl9GT0NBTFRF Q0g9eQpDT05GSUdfTU9VU0VfUFMyX1ZNTU9VU0U9eQpDT05GSUdfTU9VU0VfUFMyX1NNQlVT PXkKQ09ORklHX01PVVNFX1NFUklBTD1tCkNPTkZJR19NT1VTRV9BUFBMRVRPVUNIPW0KQ09O RklHX01PVVNFX0JDTTU5NzQ9bQpDT05GSUdfTU9VU0VfQ1lBUEE9bQpDT05GSUdfTU9VU0Vf RUxBTl9JMkM9bQpDT05GSUdfTU9VU0VfRUxBTl9JMkNfSTJDPXkKQ09ORklHX01PVVNFX0VM QU5fSTJDX1NNQlVTPXkKQ09ORklHX01PVVNFX1ZTWFhYQUE9bQpDT05GSUdfTU9VU0VfR1BJ Tz1tCkNPTkZJR19NT1VTRV9TWU5BUFRJQ1NfSTJDPW0KQ09ORklHX01PVVNFX1NZTkFQVElD U19VU0I9bQpDT05GSUdfSU5QVVRfSk9ZU1RJQ0s9eQpDT05GSUdfSk9ZU1RJQ0tfQU5BTE9H PW0KQ09ORklHX0pPWVNUSUNLX0EzRD1tCkNPTkZJR19KT1lTVElDS19BREM9bQpDT05GSUdf Sk9ZU1RJQ0tfQURJPW0KQ09ORklHX0pPWVNUSUNLX0NPQlJBPW0KQ09ORklHX0pPWVNUSUNL X0dGMks9bQpDT05GSUdfSk9ZU1RJQ0tfR1JJUD1tCkNPTkZJR19KT1lTVElDS19HUklQX01Q PW0KQ09ORklHX0pPWVNUSUNLX0dVSUxMRU1PVD1tCkNPTkZJR19KT1lTVElDS19JTlRFUkFD VD1tCkNPTkZJR19KT1lTVElDS19TSURFV0lOREVSPW0KQ09ORklHX0pPWVNUSUNLX1RNREM9 bQpDT05GSUdfSk9ZU1RJQ0tfSUZPUkNFPW0KQ09ORklHX0pPWVNUSUNLX0lGT1JDRV9VU0I9 bQpDT05GSUdfSk9ZU1RJQ0tfSUZPUkNFXzIzMj1tCkNPTkZJR19KT1lTVElDS19XQVJSSU9S PW0KQ09ORklHX0pPWVNUSUNLX01BR0VMTEFOPW0KQ09ORklHX0pPWVNUSUNLX1NQQUNFT1JC PW0KQ09ORklHX0pPWVNUSUNLX1NQQUNFQkFMTD1tCkNPTkZJR19KT1lTVElDS19TVElOR0VS PW0KQ09ORklHX0pPWVNUSUNLX1RXSURKT1k9bQpDT05GSUdfSk9ZU1RJQ0tfWkhFTkhVQT1t CkNPTkZJR19KT1lTVElDS19EQjk9bQpDT05GSUdfSk9ZU1RJQ0tfR0FNRUNPTj1tCkNPTkZJ R19KT1lTVElDS19UVVJCT0dSQUZYPW0KQ09ORklHX0pPWVNUSUNLX0FTNTAxMT1tCkNPTkZJ R19KT1lTVElDS19KT1lEVU1QPW0KQ09ORklHX0pPWVNUSUNLX1hQQUQ9bQpDT05GSUdfSk9Z U1RJQ0tfWFBBRF9GRj15CkNPTkZJR19KT1lTVElDS19YUEFEX0xFRFM9eQpDT05GSUdfSk9Z U1RJQ0tfV0FMS0VSQTA3MDE9bQpDT05GSUdfSk9ZU1RJQ0tfUFNYUEFEX1NQST1tCkNPTkZJ R19KT1lTVElDS19QU1hQQURfU1BJX0ZGPXkKQ09ORklHX0pPWVNUSUNLX1BYUkM9bQpDT05G SUdfSk9ZU1RJQ0tfRlNJQTZCPW0KQ09ORklHX0lOUFVUX1RBQkxFVD15CkNPTkZJR19UQUJM RVRfVVNCX0FDRUNBRD1tCkNPTkZJR19UQUJMRVRfVVNCX0FJUFRFSz1tCkNPTkZJR19UQUJM RVRfVVNCX0hBTldBTkc9bQpDT05GSUdfVEFCTEVUX1VTQl9LQlRBQj1tCkNPTkZJR19UQUJM RVRfVVNCX1BFR0FTVVM9bQpDT05GSUdfVEFCTEVUX1NFUklBTF9XQUNPTTQ9bQpDT05GSUdf SU5QVVRfVE9VQ0hTQ1JFRU49eQpDT05GSUdfVE9VQ0hTQ1JFRU5fUFJPUEVSVElFUz15CkNP TkZJR19UT1VDSFNDUkVFTl84OFBNODYwWD1tCkNPTkZJR19UT1VDSFNDUkVFTl9BRFM3ODQ2 PW0KQ09ORklHX1RPVUNIU0NSRUVOX0FENzg3Nz1tCkNPTkZJR19UT1VDSFNDUkVFTl9BRDc4 Nzk9bQpDT05GSUdfVE9VQ0hTQ1JFRU5fQUQ3ODc5X0kyQz1tCkNPTkZJR19UT1VDSFNDUkVF Tl9BRDc4NzlfU1BJPW0KQ09ORklHX1RPVUNIU0NSRUVOX0FEQz1tCkNPTkZJR19UT1VDSFND UkVFTl9BVE1FTF9NWFQ9bQpDT05GSUdfVE9VQ0hTQ1JFRU5fQVRNRUxfTVhUX1QzNz15CkNP TkZJR19UT1VDSFNDUkVFTl9BVU9fUElYQ0lSPW0KQ09ORklHX1RPVUNIU0NSRUVOX0JVMjEw MTM9bQpDT05GSUdfVE9VQ0hTQ1JFRU5fQlUyMTAyOT1tCkNPTkZJR19UT1VDSFNDUkVFTl9D SElQT05FX0lDTjg1MDU9bQpDT05GSUdfVE9VQ0hTQ1JFRU5fQ1k4Q1RNQTE0MD1tCkNPTkZJ R19UT1VDSFNDUkVFTl9DWThDVE1HMTEwPW0KQ09ORklHX1RPVUNIU0NSRUVOX0NZVFRTUF9D T1JFPW0KQ09ORklHX1RPVUNIU0NSRUVOX0NZVFRTUF9JMkM9bQpDT05GSUdfVE9VQ0hTQ1JF RU5fQ1lUVFNQX1NQST1tCkNPTkZJR19UT1VDSFNDUkVFTl9DWVRUU1A0X0NPUkU9bQpDT05G SUdfVE9VQ0hTQ1JFRU5fQ1lUVFNQNF9JMkM9bQpDT05GSUdfVE9VQ0hTQ1JFRU5fQ1lUVFNQ NF9TUEk9bQpDT05GSUdfVE9VQ0hTQ1JFRU5fREE5MDM0PW0KQ09ORklHX1RPVUNIU0NSRUVO X0RBOTA1Mj1tCkNPTkZJR19UT1VDSFNDUkVFTl9EWU5BUFJPPW0KQ09ORklHX1RPVUNIU0NS RUVOX0hBTVBTSElSRT1tCkNPTkZJR19UT1VDSFNDUkVFTl9FRVRJPW0KQ09ORklHX1RPVUNI U0NSRUVOX0VHQUxBWF9TRVJJQUw9bQpDT05GSUdfVE9VQ0hTQ1JFRU5fRVhDMzAwMD1tCkNP TkZJR19UT1VDSFNDUkVFTl9GVUpJVFNVPW0KQ09ORklHX1RPVUNIU0NSRUVOX0dPT0RJWD1t CkNPTkZJR19UT1VDSFNDUkVFTl9ISURFRVA9bQpDT05GSUdfVE9VQ0hTQ1JFRU5fSUxJMjEw WD1tCkNPTkZJR19UT1VDSFNDUkVFTl9TNlNZNzYxPW0KQ09ORklHX1RPVUNIU0NSRUVOX0dV TlpFPW0KQ09ORklHX1RPVUNIU0NSRUVOX0VLVEYyMTI3PW0KQ09ORklHX1RPVUNIU0NSRUVO X0VMQU49bQpDT05GSUdfVE9VQ0hTQ1JFRU5fRUxPPW0KQ09ORklHX1RPVUNIU0NSRUVOX1dB Q09NX1c4MDAxPW0KQ09ORklHX1RPVUNIU0NSRUVOX1dBQ09NX0kyQz1tCkNPTkZJR19UT1VD SFNDUkVFTl9NQVgxMTgwMT1tCkNPTkZJR19UT1VDSFNDUkVFTl9NQ1M1MDAwPW0KQ09ORklH X1RPVUNIU0NSRUVOX01NUzExND1tCkNPTkZJR19UT1VDSFNDUkVFTl9NRUxGQVNfTUlQND1t CkNPTkZJR19UT1VDSFNDUkVFTl9NVE9VQ0g9bQpDT05GSUdfVE9VQ0hTQ1JFRU5fSU5FWElP PW0KQ09ORklHX1RPVUNIU0NSRUVOX01LNzEyPW0KQ09ORklHX1RPVUNIU0NSRUVOX1BFTk1P VU5UPW0KQ09ORklHX1RPVUNIU0NSRUVOX0VEVF9GVDVYMDY9bQpDT05GSUdfVE9VQ0hTQ1JF RU5fVE9VQ0hSSUdIVD1tCkNPTkZJR19UT1VDSFNDUkVFTl9UT1VDSFdJTj1tCkNPTkZJR19U T1VDSFNDUkVFTl9USV9BTTMzNVhfVFNDPW0KQ09ORklHX1RPVUNIU0NSRUVOX1VDQjE0MDA9 bQpDT05GSUdfVE9VQ0hTQ1JFRU5fUElYQ0lSPW0KQ09ORklHX1RPVUNIU0NSRUVOX1dEVDg3 WFhfSTJDPW0KQ09ORklHX1RPVUNIU0NSRUVOX1dNODMxWD1tCkNPTkZJR19UT1VDSFNDUkVF Tl9XTTk3WFg9bQpDT05GSUdfVE9VQ0hTQ1JFRU5fV005NzA1PXkKQ09ORklHX1RPVUNIU0NS RUVOX1dNOTcxMj15CkNPTkZJR19UT1VDSFNDUkVFTl9XTTk3MTM9eQpDT05GSUdfVE9VQ0hT Q1JFRU5fVVNCX0NPTVBPU0lURT1tCkNPTkZJR19UT1VDSFNDUkVFTl9NQzEzNzgzPW0KQ09O RklHX1RPVUNIU0NSRUVOX1VTQl9FR0FMQVg9eQpDT05GSUdfVE9VQ0hTQ1JFRU5fVVNCX1BB TkpJVD15CkNPTkZJR19UT1VDSFNDUkVFTl9VU0JfM009eQpDT05GSUdfVE9VQ0hTQ1JFRU5f VVNCX0lUTT15CkNPTkZJR19UT1VDSFNDUkVFTl9VU0JfRVRVUkJPPXkKQ09ORklHX1RPVUNI U0NSRUVOX1VTQl9HVU5aRT15CkNPTkZJR19UT1VDSFNDUkVFTl9VU0JfRE1DX1RTQzEwPXkK Q09ORklHX1RPVUNIU0NSRUVOX1VTQl9JUlRPVUNIPXkKQ09ORklHX1RPVUNIU0NSRUVOX1VT Ql9JREVBTFRFSz15CkNPTkZJR19UT1VDSFNDUkVFTl9VU0JfR0VORVJBTF9UT1VDSD15CkNP TkZJR19UT1VDSFNDUkVFTl9VU0JfR09UT1A9eQpDT05GSUdfVE9VQ0hTQ1JFRU5fVVNCX0pB U1RFQz15CkNPTkZJR19UT1VDSFNDUkVFTl9VU0JfRUxPPXkKQ09ORklHX1RPVUNIU0NSRUVO X1VTQl9FMkk9eQpDT05GSUdfVE9VQ0hTQ1JFRU5fVVNCX1pZVFJPTklDPXkKQ09ORklHX1RP VUNIU0NSRUVOX1VTQl9FVFRfVEM0NVVTQj15CkNPTkZJR19UT1VDSFNDUkVFTl9VU0JfTkVY SU89eQpDT05GSUdfVE9VQ0hTQ1JFRU5fVVNCX0VBU1lUT1VDSD15CkNPTkZJR19UT1VDSFND UkVFTl9UT1VDSElUMjEzPW0KQ09ORklHX1RPVUNIU0NSRUVOX1RTQ19TRVJJTz1tCkNPTkZJ R19UT1VDSFNDUkVFTl9UU0MyMDBYX0NPUkU9bQpDT05GSUdfVE9VQ0hTQ1JFRU5fVFNDMjAw ND1tCkNPTkZJR19UT1VDSFNDUkVFTl9UU0MyMDA1PW0KQ09ORklHX1RPVUNIU0NSRUVOX1RT QzIwMDc9bQpDT05GSUdfVE9VQ0hTQ1JFRU5fVFNDMjAwN19JSU89eQpDT05GSUdfVE9VQ0hT Q1JFRU5fUENBUD1tCkNPTkZJR19UT1VDSFNDUkVFTl9STV9UUz1tCkNPTkZJR19UT1VDSFND UkVFTl9TSUxFQUQ9bQpDT05GSUdfVE9VQ0hTQ1JFRU5fU0lTX0kyQz1tCkNPTkZJR19UT1VD SFNDUkVFTl9TVDEyMzI9bQpDT05GSUdfVE9VQ0hTQ1JFRU5fU1RNRlRTPW0KQ09ORklHX1RP VUNIU0NSRUVOX1NVUjQwPW0KQ09ORklHX1RPVUNIU0NSRUVOX1NVUkZBQ0UzX1NQST1tCkNP TkZJR19UT1VDSFNDUkVFTl9TWDg2NTQ9bQpDT05GSUdfVE9VQ0hTQ1JFRU5fVFBTNjUwN1g9 bQpDT05GSUdfVE9VQ0hTQ1JFRU5fWkVUNjIyMz1tCkNPTkZJR19UT1VDSFNDUkVFTl9aRk9S Q0U9bQpDT05GSUdfVE9VQ0hTQ1JFRU5fUk9ITV9CVTIxMDIzPW0KQ09ORklHX1RPVUNIU0NS RUVOX0lRUzVYWD1tCkNPTkZJR19UT1VDSFNDUkVFTl9aSU5JVElYPW0KQ09ORklHX0lOUFVU X01JU0M9eQpDT05GSUdfSU5QVVRfODhQTTg2MFhfT05LRVk9bQpDT05GSUdfSU5QVVRfODhQ TTgwWF9PTktFWT1tCkNPTkZJR19JTlBVVF9BRDcxNFg9bQpDT05GSUdfSU5QVVRfQUQ3MTRY X0kyQz1tCkNPTkZJR19JTlBVVF9BRDcxNFhfU1BJPW0KQ09ORklHX0lOUFVUX0FSSVpPTkFf SEFQVElDUz1tCkNPTkZJR19JTlBVVF9CTUExNTA9bQpDT05GSUdfSU5QVVRfRTNYMF9CVVRU T049bQpDT05GSUdfSU5QVVRfUENTUEtSPW0KQ09ORklHX0lOUFVUX01BWDc3NjkzX0hBUFRJ Qz1tCkNPTkZJR19JTlBVVF9NQVg4OTI1X09OS0VZPW0KQ09ORklHX0lOUFVUX01BWDg5OTdf SEFQVElDPW0KQ09ORklHX0lOUFVUX01DMTM3ODNfUFdSQlVUVE9OPW0KQ09ORklHX0lOUFVU X01NQTg0NTA9bQpDT05GSUdfSU5QVVRfQVBBTkVMPW0KQ09ORklHX0lOUFVUX0dQSU9fQkVF UEVSPW0KQ09ORklHX0lOUFVUX0dQSU9fREVDT0RFUj1tCkNPTkZJR19JTlBVVF9HUElPX1ZJ QlJBPW0KQ09ORklHX0lOUFVUX0FUTEFTX0JUTlM9bQpDT05GSUdfSU5QVVRfQVRJX1JFTU9U RTI9bQpDT05GSUdfSU5QVVRfS0VZU1BBTl9SRU1PVEU9bQpDT05GSUdfSU5QVVRfS1hUSjk9 bQpDT05GSUdfSU5QVVRfUE9XRVJNQVRFPW0KQ09ORklHX0lOUFVUX1lFQUxJTks9bQpDT05G SUdfSU5QVVRfQ00xMDk9bQpDT05GSUdfSU5QVVRfUkVHVUxBVE9SX0hBUFRJQz1tCkNPTkZJ R19JTlBVVF9SRVRVX1BXUkJVVFRPTj1tCkNPTkZJR19JTlBVVF9BWFAyMFhfUEVLPW0KQ09O RklHX0lOUFVUX1RXTDQwMzBfUFdSQlVUVE9OPW0KQ09ORklHX0lOUFVUX1RXTDQwMzBfVklC UkE9bQpDT05GSUdfSU5QVVRfVFdMNjA0MF9WSUJSQT1tCkNPTkZJR19JTlBVVF9VSU5QVVQ9 bQpDT05GSUdfSU5QVVRfUEFMTUFTX1BXUkJVVFRPTj1tCkNPTkZJR19JTlBVVF9QQ0Y1MDYz M19QTVU9bQpDT05GSUdfSU5QVVRfUENGODU3ND1tCkNPTkZJR19JTlBVVF9QV01fQkVFUEVS PW0KQ09ORklHX0lOUFVUX1BXTV9WSUJSQT1tCkNPTkZJR19JTlBVVF9HUElPX1JPVEFSWV9F TkNPREVSPW0KQ09ORklHX0lOUFVUX0RBNzI4MF9IQVBUSUNTPW0KQ09ORklHX0lOUFVUX0RB OTA1Ml9PTktFWT1tCkNPTkZJR19JTlBVVF9EQTkwNTVfT05LRVk9bQpDT05GSUdfSU5QVVRf REE5MDYzX09OS0VZPW0KQ09ORklHX0lOUFVUX1dNODMxWF9PTj1tCkNPTkZJR19JTlBVVF9Q Q0FQPW0KQ09ORklHX0lOUFVUX0FEWEwzNFg9bQpDT05GSUdfSU5QVVRfQURYTDM0WF9JMkM9 bQpDT05GSUdfSU5QVVRfQURYTDM0WF9TUEk9bQpDT05GSUdfSU5QVVRfSU1TX1BDVT1tCkNP TkZJR19JTlBVVF9JUVMyNjlBPW0KQ09ORklHX0lOUFVUX0NNQTMwMDA9bQpDT05GSUdfSU5Q VVRfQ01BMzAwMF9JMkM9bQpDT05GSUdfSU5QVVRfWEVOX0tCRERFVl9GUk9OVEVORD1tCkNP TkZJR19JTlBVVF9JREVBUEFEX1NMSURFQkFSPW0KQ09ORklHX0lOUFVUX1NPQ19CVVRUT05f QVJSQVk9bQpDT05GSUdfSU5QVVRfRFJWMjYwWF9IQVBUSUNTPW0KQ09ORklHX0lOUFVUX0RS VjI2NjVfSEFQVElDUz1tCkNPTkZJR19JTlBVVF9EUlYyNjY3X0hBUFRJQ1M9bQpDT05GSUdf SU5QVVRfUkFWRV9TUF9QV1JCVVRUT049bQpDT05GSUdfUk1JNF9DT1JFPW0KQ09ORklHX1JN STRfSTJDPW0KQ09ORklHX1JNSTRfU1BJPW0KQ09ORklHX1JNSTRfU01CPW0KQ09ORklHX1JN STRfRjAzPXkKQ09ORklHX1JNSTRfRjAzX1NFUklPPW0KQ09ORklHX1JNSTRfMkRfU0VOU09S PXkKQ09ORklHX1JNSTRfRjExPXkKQ09ORklHX1JNSTRfRjEyPXkKQ09ORklHX1JNSTRfRjMw PXkKQ09ORklHX1JNSTRfRjM0PXkKQ09ORklHX1JNSTRfRjNBPXkKIyBDT05GSUdfUk1JNF9G NTQgaXMgbm90IHNldApDT05GSUdfUk1JNF9GNTU9eQoKIwojIEhhcmR3YXJlIEkvTyBwb3J0 cwojCkNPTkZJR19TRVJJTz1tCkNPTkZJR19BUkNIX01JR0hUX0hBVkVfUENfU0VSSU89eQpD T05GSUdfU0VSSU9fSTgwNDI9bQpDT05GSUdfU0VSSU9fU0VSUE9SVD1tCkNPTkZJR19TRVJJ T19DVDgyQzcxMD1tCkNPTkZJR19TRVJJT19QQVJLQkQ9bQpDT05GSUdfU0VSSU9fUENJUFMy PW0KQ09ORklHX1NFUklPX0xJQlBTMj1tCkNPTkZJR19TRVJJT19SQVc9bQpDT05GSUdfU0VS SU9fQUxURVJBX1BTMj1tCkNPTkZJR19TRVJJT19QUzJNVUxUPW0KQ09ORklHX1NFUklPX0FS Q19QUzI9bQpDT05GSUdfSFlQRVJWX0tFWUJPQVJEPW0KQ09ORklHX1NFUklPX0dQSU9fUFMy PW0KQ09ORklHX1VTRVJJTz1tCkNPTkZJR19HQU1FUE9SVD1tCkNPTkZJR19HQU1FUE9SVF9O UzU1OD1tCkNPTkZJR19HQU1FUE9SVF9MND1tCkNPTkZJR19HQU1FUE9SVF9FTVUxMEsxPW0K Q09ORklHX0dBTUVQT1JUX0ZNODAxPW0KIyBlbmQgb2YgSGFyZHdhcmUgSS9PIHBvcnRzCiMg ZW5kIG9mIElucHV0IGRldmljZSBzdXBwb3J0CgojCiMgQ2hhcmFjdGVyIGRldmljZXMKIwpD T05GSUdfVFRZPXkKQ09ORklHX1ZUPXkKQ09ORklHX0NPTlNPTEVfVFJBTlNMQVRJT05TPXkK Q09ORklHX1ZUX0NPTlNPTEU9eQpDT05GSUdfVlRfQ09OU09MRV9TTEVFUD15CkNPTkZJR19I V19DT05TT0xFPXkKQ09ORklHX1ZUX0hXX0NPTlNPTEVfQklORElORz15CkNPTkZJR19VTklY OThfUFRZUz15CiMgQ09ORklHX0xFR0FDWV9QVFlTIGlzIG5vdCBzZXQKQ09ORklHX0xESVND X0FVVE9MT0FEPXkKCiMKIyBTZXJpYWwgZHJpdmVycwojCkNPTkZJR19TRVJJQUxfRUFSTFlD T049eQpDT05GSUdfU0VSSUFMXzgyNTA9eQojIENPTkZJR19TRVJJQUxfODI1MF9ERVBSRUNB VEVEX09QVElPTlMgaXMgbm90IHNldApDT05GSUdfU0VSSUFMXzgyNTBfUE5QPXkKIyBDT05G SUdfU0VSSUFMXzgyNTBfMTY1NTBBX1ZBUklBTlRTIGlzIG5vdCBzZXQKQ09ORklHX1NFUklB TF84MjUwX0ZJTlRFSz15CkNPTkZJR19TRVJJQUxfODI1MF9DT05TT0xFPXkKQ09ORklHX1NF UklBTF84MjUwX0RNQT15CkNPTkZJR19TRVJJQUxfODI1MF9QQ0k9eQpDT05GSUdfU0VSSUFM XzgyNTBfRVhBUj1tCkNPTkZJR19TRVJJQUxfODI1MF9DUz1tCkNPTkZJR19TRVJJQUxfODI1 MF9NRU5fTUNCPW0KQ09ORklHX1NFUklBTF84MjUwX05SX1VBUlRTPTMyCkNPTkZJR19TRVJJ QUxfODI1MF9SVU5USU1FX1VBUlRTPTMyCkNPTkZJR19TRVJJQUxfODI1MF9FWFRFTkRFRD15 CkNPTkZJR19TRVJJQUxfODI1MF9NQU5ZX1BPUlRTPXkKQ09ORklHX1NFUklBTF84MjUwX1NI QVJFX0lSUT15CiMgQ09ORklHX1NFUklBTF84MjUwX0RFVEVDVF9JUlEgaXMgbm90IHNldApD T05GSUdfU0VSSUFMXzgyNTBfUlNBPXkKQ09ORklHX1NFUklBTF84MjUwX0RXTElCPXkKQ09O RklHX1NFUklBTF84MjUwX0RXPW0KQ09ORklHX1NFUklBTF84MjUwX1JUMjg4WD15CkNPTkZJ R19TRVJJQUxfODI1MF9MUFNTPXkKQ09ORklHX1NFUklBTF84MjUwX01JRD15CgojCiMgTm9u LTgyNTAgc2VyaWFsIHBvcnQgc3VwcG9ydAojCkNPTkZJR19TRVJJQUxfTUFYMzEwMD1tCkNP TkZJR19TRVJJQUxfTUFYMzEwWD1tCkNPTkZJR19TRVJJQUxfVUFSVExJVEU9bQpDT05GSUdf U0VSSUFMX1VBUlRMSVRFX05SX1VBUlRTPTEKQ09ORklHX1NFUklBTF9DT1JFPXkKQ09ORklH X1NFUklBTF9DT1JFX0NPTlNPTEU9eQpDT05GSUdfU0VSSUFMX0pTTT1tCiMgQ09ORklHX1NF UklBTF9MQU5USVEgaXMgbm90IHNldApDT05GSUdfU0VSSUFMX1NDQ05YUD1tCkNPTkZJR19T RVJJQUxfU0MxNklTN1hYX0NPUkU9bQpDT05GSUdfU0VSSUFMX1NDMTZJUzdYWD1tCkNPTkZJ R19TRVJJQUxfU0MxNklTN1hYX0kyQz15CkNPTkZJR19TRVJJQUxfU0MxNklTN1hYX1NQST15 CiMgQ09ORklHX1NFUklBTF9CQ002M1hYIGlzIG5vdCBzZXQKQ09ORklHX1NFUklBTF9BTFRF UkFfSlRBR1VBUlQ9bQpDT05GSUdfU0VSSUFMX0FMVEVSQV9VQVJUPW0KQ09ORklHX1NFUklB TF9BTFRFUkFfVUFSVF9NQVhQT1JUUz00CkNPTkZJR19TRVJJQUxfQUxURVJBX1VBUlRfQkFV RFJBVEU9MTE1MjAwCkNPTkZJR19TRVJJQUxfQVJDPW0KQ09ORklHX1NFUklBTF9BUkNfTlJf UE9SVFM9MQpDT05GSUdfU0VSSUFMX1JQMj1tCkNPTkZJR19TRVJJQUxfUlAyX05SX1VBUlRT PTMyCkNPTkZJR19TRVJJQUxfRlNMX0xQVUFSVD1tCkNPTkZJR19TRVJJQUxfRlNMX0xJTkZM RVhVQVJUPW0KQ09ORklHX1NFUklBTF9NRU5fWjEzNT1tCkNPTkZJR19TRVJJQUxfU1BSRD1t CiMgZW5kIG9mIFNlcmlhbCBkcml2ZXJzCgpDT05GSUdfU0VSSUFMX01DVFJMX0dQSU89eQpD T05GSUdfU0VSSUFMX05PTlNUQU5EQVJEPXkKQ09ORklHX1JPQ0tFVFBPUlQ9bQpDT05GSUdf Q1lDTEFERVM9bQpDT05GSUdfQ1laX0lOVFI9eQpDT05GSUdfTU9YQV9JTlRFTExJTz1tCkNP TkZJR19NT1hBX1NNQVJUSU89bQpDT05GSUdfU1lOQ0xJTktfR1Q9bQpDT05GSUdfSVNJPW0K Q09ORklHX05fSERMQz1tCkNPTkZJR19OX0dTTT1tCkNPTkZJR19OT1pPTUk9bQpDT05GSUdf TlVMTF9UVFk9bQpDT05GSUdfVFJBQ0VfUk9VVEVSPW0KQ09ORklHX1RSQUNFX1NJTks9bQpD T05GSUdfSFZDX0RSSVZFUj15CkNPTkZJR19IVkNfSVJRPXkKQ09ORklHX0hWQ19YRU49eQpD T05GSUdfSFZDX1hFTl9GUk9OVEVORD15CkNPTkZJR19TRVJJQUxfREVWX0JVUz15CkNPTkZJ R19TRVJJQUxfREVWX0NUUkxfVFRZUE9SVD15CkNPTkZJR19QUklOVEVSPW0KQ09ORklHX0xQ X0NPTlNPTEU9eQpDT05GSUdfUFBERVY9bQpDT05GSUdfVklSVElPX0NPTlNPTEU9bQpDT05G SUdfSVBNSV9IQU5ETEVSPW0KQ09ORklHX0lQTUlfRE1JX0RFQ09ERT15CkNPTkZJR19JUE1J X1BMQVRfREFUQT15CiMgQ09ORklHX0lQTUlfUEFOSUNfRVZFTlQgaXMgbm90IHNldApDT05G SUdfSVBNSV9ERVZJQ0VfSU5URVJGQUNFPW0KQ09ORklHX0lQTUlfU0k9bQpDT05GSUdfSVBN SV9TU0lGPW0KQ09ORklHX0lQTUlfV0FUQ0hET0c9bQpDT05GSUdfSVBNSV9QT1dFUk9GRj1t CkNPTkZJR19JUE1CX0RFVklDRV9JTlRFUkZBQ0U9bQpDT05GSUdfSFdfUkFORE9NPW0KQ09O RklHX0hXX1JBTkRPTV9USU1FUklPTUVNPW0KQ09ORklHX0hXX1JBTkRPTV9JTlRFTD1tCkNP TkZJR19IV19SQU5ET01fQU1EPW0KQ09ORklHX0hXX1JBTkRPTV9CQTQzMT1tCkNPTkZJR19I V19SQU5ET01fVklBPW0KQ09ORklHX0hXX1JBTkRPTV9WSVJUSU89bQpDT05GSUdfSFdfUkFO RE9NX1hJUEhFUkE9bQpDT05GSUdfQVBQTElDT009bQoKIwojIFBDTUNJQSBjaGFyYWN0ZXIg ZGV2aWNlcwojCkNPTkZJR19TWU5DTElOS19DUz1tCkNPTkZJR19DQVJETUFOXzQwMDA9bQpD T05GSUdfQ0FSRE1BTl80MDQwPW0KQ09ORklHX1NDUjI0WD1tCkNPTkZJR19JUFdJUkVMRVNT PW0KIyBlbmQgb2YgUENNQ0lBIGNoYXJhY3RlciBkZXZpY2VzCgpDT05GSUdfTVdBVkU9bQpD T05GSUdfREVWTUVNPXkKIyBDT05GSUdfREVWS01FTSBpcyBub3Qgc2V0CkNPTkZJR19OVlJB TT15CkNPTkZJR19SQVdfRFJJVkVSPW0KQ09ORklHX01BWF9SQVdfREVWUz04MTkyCkNPTkZJ R19ERVZQT1JUPXkKQ09ORklHX0hQRVQ9eQojIENPTkZJR19IUEVUX01NQVAgaXMgbm90IHNl dApDT05GSUdfSEFOR0NIRUNLX1RJTUVSPW0KQ09ORklHX1RDR19UUE09bQpDT05GSUdfSFdf UkFORE9NX1RQTT15CkNPTkZJR19UQ0dfVElTX0NPUkU9bQpDT05GSUdfVENHX1RJUz1tCkNP TkZJR19UQ0dfVElTX1NQST1tCkNPTkZJR19UQ0dfVElTX1NQSV9DUjUwPXkKQ09ORklHX1RD R19USVNfSTJDX0NSNTA9bQpDT05GSUdfVENHX1RJU19JMkNfQVRNRUw9bQpDT05GSUdfVENH X1RJU19JMkNfSU5GSU5FT049bQpDT05GSUdfVENHX1RJU19JMkNfTlVWT1RPTj1tCkNPTkZJ R19UQ0dfTlNDPW0KQ09ORklHX1RDR19BVE1FTD1tCkNPTkZJR19UQ0dfSU5GSU5FT049bQpD T05GSUdfVENHX1hFTj1tCkNPTkZJR19UQ0dfQ1JCPW0KQ09ORklHX1RDR19WVFBNX1BST1hZ PW0KQ09ORklHX1RDR19USVNfU1QzM1pQMjQ9bQpDT05GSUdfVENHX1RJU19TVDMzWlAyNF9J MkM9bQpDT05GSUdfVENHX1RJU19TVDMzWlAyNF9TUEk9bQpDT05GSUdfVEVMQ0xPQ0s9bQpD T05GSUdfWElMTFlCVVM9bQpDT05GSUdfWElMTFlCVVNfUENJRT1tCiMgZW5kIG9mIENoYXJh Y3RlciBkZXZpY2VzCgojIENPTkZJR19SQU5ET01fVFJVU1RfQ1BVIGlzIG5vdCBzZXQKIyBD T05GSUdfUkFORE9NX1RSVVNUX0JPT1RMT0FERVIgaXMgbm90IHNldAoKIwojIEkyQyBzdXBw b3J0CiMKQ09ORklHX0kyQz15CkNPTkZJR19BQ1BJX0kyQ19PUFJFR0lPTj15CkNPTkZJR19J MkNfQk9BUkRJTkZPPXkKQ09ORklHX0kyQ19DT01QQVQ9eQpDT05GSUdfSTJDX0NIQVJERVY9 bQpDT05GSUdfSTJDX01VWD1tCgojCiMgTXVsdGlwbGV4ZXIgSTJDIENoaXAgc3VwcG9ydAoj CkNPTkZJR19JMkNfTVVYX0dQSU89bQpDT05GSUdfSTJDX01VWF9MVEM0MzA2PW0KQ09ORklH X0kyQ19NVVhfUENBOTU0MT1tCkNPTkZJR19JMkNfTVVYX1BDQTk1NHg9bQpDT05GSUdfSTJD X01VWF9SRUc9bQpDT05GSUdfSTJDX01VWF9NTFhDUExEPW0KIyBlbmQgb2YgTXVsdGlwbGV4 ZXIgSTJDIENoaXAgc3VwcG9ydAoKQ09ORklHX0kyQ19IRUxQRVJfQVVUTz15CkNPTkZJR19J MkNfU01CVVM9bQpDT05GSUdfSTJDX0FMR09CSVQ9bQpDT05GSUdfSTJDX0FMR09QQ0E9bQoK IwojIEkyQyBIYXJkd2FyZSBCdXMgc3VwcG9ydAojCgojCiMgUEMgU01CdXMgaG9zdCBjb250 cm9sbGVyIGRyaXZlcnMKIwpDT05GSUdfSTJDX0FMSTE1MzU9bQpDT05GSUdfSTJDX0FMSTE1 NjM9bQpDT05GSUdfSTJDX0FMSTE1WDM9bQpDT05GSUdfSTJDX0FNRDc1Nj1tCkNPTkZJR19J MkNfQU1ENzU2X1M0ODgyPW0KQ09ORklHX0kyQ19BTUQ4MTExPW0KQ09ORklHX0kyQ19BTURf TVAyPW0KQ09ORklHX0kyQ19JODAxPW0KQ09ORklHX0kyQ19JU0NIPW0KQ09ORklHX0kyQ19J U01UPW0KQ09ORklHX0kyQ19QSUlYND1tCkNPTkZJR19JMkNfQ0hUX1dDPW0KQ09ORklHX0ky Q19ORk9SQ0UyPW0KQ09ORklHX0kyQ19ORk9SQ0UyX1M0OTg1PW0KQ09ORklHX0kyQ19OVklE SUFfR1BVPW0KQ09ORklHX0kyQ19TSVM1NTk1PW0KQ09ORklHX0kyQ19TSVM2MzA9bQpDT05G SUdfSTJDX1NJUzk2WD1tCkNPTkZJR19JMkNfVklBPW0KQ09ORklHX0kyQ19WSUFQUk89bQoK IwojIEFDUEkgZHJpdmVycwojCkNPTkZJR19JMkNfU0NNST1tCgojCiMgSTJDIHN5c3RlbSBi dXMgZHJpdmVycyAobW9zdGx5IGVtYmVkZGVkIC8gc3lzdGVtLW9uLWNoaXApCiMKQ09ORklH X0kyQ19DQlVTX0dQSU89bQpDT05GSUdfSTJDX0RFU0lHTldBUkVfQ09SRT15CkNPTkZJR19J MkNfREVTSUdOV0FSRV9TTEFWRT15CkNPTkZJR19JMkNfREVTSUdOV0FSRV9QTEFURk9STT15 CkNPTkZJR19JMkNfREVTSUdOV0FSRV9CQVlUUkFJTD15CkNPTkZJR19JMkNfREVTSUdOV0FS RV9QQ0k9eQpDT05GSUdfSTJDX0VNRVYyPW0KQ09ORklHX0kyQ19HUElPPW0KIyBDT05GSUdf STJDX0dQSU9fRkFVTFRfSU5KRUNUT1IgaXMgbm90IHNldApDT05GSUdfSTJDX0tFTVBMRD1t CkNPTkZJR19JMkNfT0NPUkVTPW0KQ09ORklHX0kyQ19QQ0FfUExBVEZPUk09bQpDT05GSUdf STJDX1NJTVRFQz1tCkNPTkZJR19JMkNfWElMSU5YPW0KCiMKIyBFeHRlcm5hbCBJMkMvU01C dXMgYWRhcHRlciBkcml2ZXJzCiMKQ09ORklHX0kyQ19ESU9MQU5fVTJDPW0KQ09ORklHX0ky Q19ETE4yPW0KQ09ORklHX0kyQ19QQVJQT1JUPW0KQ09ORklHX0kyQ19ST0JPVEZVWlpfT1NJ Rj1tCkNPTkZJR19JMkNfVEFPU19FVk09bQpDT05GSUdfSTJDX1RJTllfVVNCPW0KQ09ORklH X0kyQ19WSVBFUkJPQVJEPW0KCiMKIyBPdGhlciBJMkMvU01CdXMgYnVzIGRyaXZlcnMKIwpD T05GSUdfSTJDX01MWENQTEQ9bQpDT05GSUdfSTJDX0NST1NfRUNfVFVOTkVMPW0KIyBlbmQg b2YgSTJDIEhhcmR3YXJlIEJ1cyBzdXBwb3J0CgpDT05GSUdfSTJDX1NUVUI9bQpDT05GSUdf STJDX1NMQVZFPXkKQ09ORklHX0kyQ19TTEFWRV9FRVBST009bQpDT05GSUdfSTJDX1NMQVZF X1RFU1RVTklUPW0KIyBDT05GSUdfSTJDX0RFQlVHX0NPUkUgaXMgbm90IHNldAojIENPTkZJ R19JMkNfREVCVUdfQUxHTyBpcyBub3Qgc2V0CiMgQ09ORklHX0kyQ19ERUJVR19CVVMgaXMg bm90IHNldAojIGVuZCBvZiBJMkMgc3VwcG9ydAoKIyBDT05GSUdfSTNDIGlzIG5vdCBzZXQK Q09ORklHX1NQST15CiMgQ09ORklHX1NQSV9ERUJVRyBpcyBub3Qgc2V0CkNPTkZJR19TUElf TUFTVEVSPXkKQ09ORklHX1NQSV9NRU09eQoKIwojIFNQSSBNYXN0ZXIgQ29udHJvbGxlciBE cml2ZXJzCiMKQ09ORklHX1NQSV9BTFRFUkE9bQpDT05GSUdfU1BJX0FYSV9TUElfRU5HSU5F PW0KQ09ORklHX1NQSV9CSVRCQU5HPW0KQ09ORklHX1NQSV9CVVRURVJGTFk9bQpDT05GSUdf U1BJX0NBREVOQ0U9bQpDT05GSUdfU1BJX0RFU0lHTldBUkU9bQpDT05GSUdfU1BJX0RXX0RN QT15CkNPTkZJR19TUElfRFdfUENJPW0KQ09ORklHX1NQSV9EV19NTUlPPW0KQ09ORklHX1NQ SV9ETE4yPW0KQ09ORklHX1NQSV9OWFBfRkxFWFNQST1tCkNPTkZJR19TUElfR1BJTz1tCkNP TkZJR19TUElfTE03MF9MTFA9bQojIENPTkZJR19TUElfTEFOVElRX1NTQyBpcyBub3Qgc2V0 CkNPTkZJR19TUElfT0NfVElOWT1tCkNPTkZJR19TUElfUFhBMlhYPW0KQ09ORklHX1NQSV9Q WEEyWFhfUENJPW0KIyBDT05GSUdfU1BJX1JPQ0tDSElQIGlzIG5vdCBzZXQKQ09ORklHX1NQ SV9TQzE4SVM2MDI9bQpDT05GSUdfU1BJX1NJRklWRT1tCkNPTkZJR19TUElfTVhJQz1tCkNP TkZJR19TUElfWENPTU09bQpDT05GSUdfU1BJX1hJTElOWD1tCkNPTkZJR19TUElfWllOUU1Q X0dRU1BJPW0KQ09ORklHX1NQSV9BTUQ9bQoKIwojIFNQSSBNdWx0aXBsZXhlciBzdXBwb3J0 CiMKQ09ORklHX1NQSV9NVVg9bQoKIwojIFNQSSBQcm90b2NvbCBNYXN0ZXJzCiMKQ09ORklH X1NQSV9TUElERVY9bQpDT05GSUdfU1BJX0xPT1BCQUNLX1RFU1Q9bQpDT05GSUdfU1BJX1RM RTYyWDA9bQpDT05GSUdfU1BJX1NMQVZFPXkKQ09ORklHX1NQSV9TTEFWRV9USU1FPW0KQ09O RklHX1NQSV9TTEFWRV9TWVNURU1fQ09OVFJPTD1tCkNPTkZJR19TUElfRFlOQU1JQz15CiMg Q09ORklHX1NQTUkgaXMgbm90IHNldAojIENPTkZJR19IU0kgaXMgbm90IHNldApDT05GSUdf UFBTPXkKIyBDT05GSUdfUFBTX0RFQlVHIGlzIG5vdCBzZXQKCiMKIyBQUFMgY2xpZW50cyBz dXBwb3J0CiMKQ09ORklHX1BQU19DTElFTlRfS1RJTUVSPW0KQ09ORklHX1BQU19DTElFTlRf TERJU0M9bQpDT05GSUdfUFBTX0NMSUVOVF9QQVJQT1JUPW0KQ09ORklHX1BQU19DTElFTlRf R1BJTz1tCgojCiMgUFBTIGdlbmVyYXRvcnMgc3VwcG9ydAojCgojCiMgUFRQIGNsb2NrIHN1 cHBvcnQKIwpDT05GSUdfUFRQXzE1ODhfQ0xPQ0s9eQpDT05GSUdfRFA4MzY0MF9QSFk9bQpD T05GSUdfUFRQXzE1ODhfQ0xPQ0tfSU5FUz1tCkNPTkZJR19QVFBfMTU4OF9DTE9DS19LVk09 bQpDT05GSUdfUFRQXzE1ODhfQ0xPQ0tfSURUODJQMzM9bQpDT05GSUdfUFRQXzE1ODhfQ0xP Q0tfSURUQ009bQpDT05GSUdfUFRQXzE1ODhfQ0xPQ0tfVk1XPW0KQ09ORklHX1BUUF8xNTg4 X0NMT0NLX09DUD1tCiMgZW5kIG9mIFBUUCBjbG9jayBzdXBwb3J0CgpDT05GSUdfUElOQ1RS TD15CkNPTkZJR19QSU5NVVg9eQpDT05GSUdfUElOQ09ORj15CkNPTkZJR19HRU5FUklDX1BJ TkNPTkY9eQojIENPTkZJR19ERUJVR19QSU5DVFJMIGlzIG5vdCBzZXQKQ09ORklHX1BJTkNU UkxfQU1EPW0KQ09ORklHX1BJTkNUUkxfREE5MDYyPW0KQ09ORklHX1BJTkNUUkxfTUNQMjNT MDhfSTJDPW0KQ09ORklHX1BJTkNUUkxfTUNQMjNTMDhfU1BJPW0KQ09ORklHX1BJTkNUUkxf TUNQMjNTMDg9bQpDT05GSUdfUElOQ1RSTF9TWDE1MFg9eQpDT05GSUdfUElOQ1RSTF9CQVlU UkFJTD15CkNPTkZJR19QSU5DVFJMX0NIRVJSWVZJRVc9eQpDT05GSUdfUElOQ1RSTF9MWU5Y UE9JTlQ9eQpDT05GSUdfUElOQ1RSTF9JTlRFTD15CkNPTkZJR19QSU5DVFJMX0FMREVSTEFL RT15CkNPTkZJR19QSU5DVFJMX0JST1hUT049eQpDT05GSUdfUElOQ1RSTF9DQU5OT05MQUtF PXkKQ09ORklHX1BJTkNUUkxfQ0VEQVJGT1JLPXkKQ09ORklHX1BJTkNUUkxfREVOVkVSVE9O PXkKQ09ORklHX1BJTkNUUkxfRUxLSEFSVExBS0U9eQpDT05GSUdfUElOQ1RSTF9FTU1JVFNC VVJHPXkKQ09ORklHX1BJTkNUUkxfR0VNSU5JTEFLRT15CkNPTkZJR19QSU5DVFJMX0lDRUxB S0U9eQpDT05GSUdfUElOQ1RSTF9KQVNQRVJMQUtFPXkKQ09ORklHX1BJTkNUUkxfTEFLRUZJ RUxEPXkKQ09ORklHX1BJTkNUUkxfTEVXSVNCVVJHPXkKQ09ORklHX1BJTkNUUkxfU1VOUklT RVBPSU5UPXkKQ09ORklHX1BJTkNUUkxfVElHRVJMQUtFPXkKCiMKIyBSZW5lc2FzIHBpbmN0 cmwgZHJpdmVycwojCiMgZW5kIG9mIFJlbmVzYXMgcGluY3RybCBkcml2ZXJzCgpDT05GSUdf UElOQ1RSTF9NQURFUkE9bQpDT05GSUdfUElOQ1RSTF9DUzQ3TDE1PXkKQ09ORklHX1BJTkNU UkxfQ1M0N0wzNT15CkNPTkZJR19QSU5DVFJMX0NTNDdMODU9eQpDT05GSUdfUElOQ1RSTF9D UzQ3TDkwPXkKQ09ORklHX1BJTkNUUkxfQ1M0N0w5Mj15CkNPTkZJR19HUElPTElCPXkKQ09O RklHX0dQSU9MSUJfRkFTVFBBVEhfTElNSVQ9NTEyCkNPTkZJR19HUElPX0FDUEk9eQpDT05G SUdfR1BJT0xJQl9JUlFDSElQPXkKIyBDT05GSUdfREVCVUdfR1BJTyBpcyBub3Qgc2V0CkNP TkZJR19HUElPX0NERVY9eQpDT05GSUdfR1BJT19DREVWX1YxPXkKQ09ORklHX0dQSU9fR0VO RVJJQz1tCkNPTkZJR19HUElPX01BWDczMFg9bQoKIwojIE1lbW9yeSBtYXBwZWQgR1BJTyBk cml2ZXJzCiMKQ09ORklHX0dQSU9fQU1EUFQ9bQpDT05GSUdfR1BJT19EV0FQQj1tCkNPTkZJ R19HUElPX0VYQVI9bQpDT05GSUdfR1BJT19HRU5FUklDX1BMQVRGT1JNPW0KQ09ORklHX0dQ SU9fSUNIPW0KQ09ORklHX0dQSU9fTUI4NlM3WD1tCkNPTkZJR19HUElPX01FTloxMjc9bQpD T05GSUdfR1BJT19TSU9YPW0KQ09ORklHX0dQSU9fVlg4NTU9bQpDT05GSUdfR1BJT19BTURf RkNIPW0KIyBlbmQgb2YgTWVtb3J5IG1hcHBlZCBHUElPIGRyaXZlcnMKCiMKIyBQb3J0LW1h cHBlZCBJL08gR1BJTyBkcml2ZXJzCiMKQ09ORklHX0dQSU9fRjcxODhYPW0KQ09ORklHX0dQ SU9fSVQ4Nz1tCkNPTkZJR19HUElPX1NDSD1tCkNPTkZJR19HUElPX1NDSDMxMVg9bQpDT05G SUdfR1BJT19XSU5CT05EPW0KQ09ORklHX0dQSU9fV1MxNkM0OD1tCiMgZW5kIG9mIFBvcnQt bWFwcGVkIEkvTyBHUElPIGRyaXZlcnMKCiMKIyBJMkMgR1BJTyBleHBhbmRlcnMKIwpDT05G SUdfR1BJT19BRFA1NTg4PW0KQ09ORklHX0dQSU9fTUFYNzMwMD1tCkNPTkZJR19HUElPX01B WDczMlg9bQpDT05GSUdfR1BJT19QQ0E5NTNYPW0KQ09ORklHX0dQSU9fUENBOTUzWF9JUlE9 eQpDT05GSUdfR1BJT19QQ0E5NTcwPW0KQ09ORklHX0dQSU9fUENGODU3WD1tCkNPTkZJR19H UElPX1RQSUMyODEwPW0KIyBlbmQgb2YgSTJDIEdQSU8gZXhwYW5kZXJzCgojCiMgTUZEIEdQ SU8gZXhwYW5kZXJzCiMKQ09ORklHX0dQSU9fQURQNTUyMD1tCkNPTkZJR19HUElPX0FSSVpP TkE9bQpDT05GSUdfR1BJT19CRDk1NzFNV1Y9bQpDT05GSUdfR1BJT19DUllTVEFMX0NPVkU9 bQpDT05GSUdfR1BJT19EQTkwNTI9bQpDT05GSUdfR1BJT19EQTkwNTU9bQpDT05GSUdfR1BJ T19ETE4yPW0KQ09ORklHX0dQSU9fSkFOWl9UVEw9bQpDT05GSUdfR1BJT19LRU1QTEQ9bQpD T05GSUdfR1BJT19MUDM5NDM9bQpDT05GSUdfR1BJT19MUDg3M1g9bQpDT05GSUdfR1BJT19N QURFUkE9bQpDT05GSUdfR1BJT19QQUxNQVM9eQpDT05GSUdfR1BJT19SQzVUNTgzPXkKQ09O RklHX0dQSU9fVFBTNjUwODY9bQpDT05GSUdfR1BJT19UUFM2NTg2WD15CkNPTkZJR19HUElP X1RQUzY1OTEwPXkKQ09ORklHX0dQSU9fVFBTNjU5MTI9bQpDT05GSUdfR1BJT19UUFM2ODQ3 MD15CkNPTkZJR19HUElPX1RRTVg4Nj1tCkNPTkZJR19HUElPX1RXTDQwMzA9bQpDT05GSUdf R1BJT19UV0w2MDQwPW0KQ09ORklHX0dQSU9fVUNCMTQwMD1tCkNPTkZJR19HUElPX1dISVNL RVlfQ09WRT1tCkNPTkZJR19HUElPX1dNODMxWD1tCkNPTkZJR19HUElPX1dNODM1MD1tCkNP TkZJR19HUElPX1dNODk5ND1tCiMgZW5kIG9mIE1GRCBHUElPIGV4cGFuZGVycwoKIwojIFBD SSBHUElPIGV4cGFuZGVycwojCkNPTkZJR19HUElPX0FNRDgxMTE9bQpDT05GSUdfR1BJT19N TF9JT0g9bQpDT05GSUdfR1BJT19QQ0lfSURJT18xNj1tCkNPTkZJR19HUElPX1BDSUVfSURJ T18yND1tCkNPTkZJR19HUElPX1JEQzMyMVg9bQojIGVuZCBvZiBQQ0kgR1BJTyBleHBhbmRl cnMKCiMKIyBTUEkgR1BJTyBleHBhbmRlcnMKIwpDT05GSUdfR1BJT19NQVgzMTkxWD1tCkNP TkZJR19HUElPX01BWDczMDE9bQpDT05GSUdfR1BJT19NQzMzODgwPW0KQ09ORklHX0dQSU9f UElTT1NSPW0KQ09ORklHX0dQSU9fWFJBMTQwMz1tCiMgZW5kIG9mIFNQSSBHUElPIGV4cGFu ZGVycwoKIwojIFVTQiBHUElPIGV4cGFuZGVycwojCkNPTkZJR19HUElPX1ZJUEVSQk9BUkQ9 bQojIGVuZCBvZiBVU0IgR1BJTyBleHBhbmRlcnMKCiMKIyBWaXJ0dWFsIEdQSU8gZHJpdmVy cwojCkNPTkZJR19HUElPX0FHR1JFR0FUT1I9bQpDT05GSUdfR1BJT19NT0NLVVA9bQojIGVu ZCBvZiBWaXJ0dWFsIEdQSU8gZHJpdmVycwoKQ09ORklHX1cxPW0KQ09ORklHX1cxX0NPTj15 CgojCiMgMS13aXJlIEJ1cyBNYXN0ZXJzCiMKQ09ORklHX1cxX01BU1RFUl9NQVRST1g9bQpD T05GSUdfVzFfTUFTVEVSX0RTMjQ5MD1tCkNPTkZJR19XMV9NQVNURVJfRFMyNDgyPW0KQ09O RklHX1cxX01BU1RFUl9EUzFXTT1tCkNPTkZJR19XMV9NQVNURVJfR1BJTz1tCkNPTkZJR19X MV9NQVNURVJfU0dJPW0KIyBlbmQgb2YgMS13aXJlIEJ1cyBNYXN0ZXJzCgojCiMgMS13aXJl IFNsYXZlcwojCkNPTkZJR19XMV9TTEFWRV9USEVSTT1tCkNPTkZJR19XMV9TTEFWRV9TTUVN PW0KQ09ORklHX1cxX1NMQVZFX0RTMjQwNT1tCkNPTkZJR19XMV9TTEFWRV9EUzI0MDg9bQoj IENPTkZJR19XMV9TTEFWRV9EUzI0MDhfUkVBREJBQ0sgaXMgbm90IHNldApDT05GSUdfVzFf U0xBVkVfRFMyNDEzPW0KQ09ORklHX1cxX1NMQVZFX0RTMjQwNj1tCkNPTkZJR19XMV9TTEFW RV9EUzI0MjM9bQpDT05GSUdfVzFfU0xBVkVfRFMyODA1PW0KQ09ORklHX1cxX1NMQVZFX0RT MjQzMD1tCkNPTkZJR19XMV9TTEFWRV9EUzI0MzE9bQpDT05GSUdfVzFfU0xBVkVfRFMyNDMz PW0KIyBDT05GSUdfVzFfU0xBVkVfRFMyNDMzX0NSQyBpcyBub3Qgc2V0CkNPTkZJR19XMV9T TEFWRV9EUzI0Mzg9bQpDT05GSUdfVzFfU0xBVkVfRFMyNTBYPW0KQ09ORklHX1cxX1NMQVZF X0RTMjc4MD1tCkNPTkZJR19XMV9TTEFWRV9EUzI3ODE9bQpDT05GSUdfVzFfU0xBVkVfRFMy OEUwND1tCkNPTkZJR19XMV9TTEFWRV9EUzI4RTE3PW0KIyBlbmQgb2YgMS13aXJlIFNsYXZl cwoKQ09ORklHX1BPV0VSX1JFU0VUPXkKQ09ORklHX1BPV0VSX1JFU0VUX01UNjMyMz15CkNP TkZJR19QT1dFUl9SRVNFVF9SRVNUQVJUPXkKQ09ORklHX1BPV0VSX1NVUFBMWT15CiMgQ09O RklHX1BPV0VSX1NVUFBMWV9ERUJVRyBpcyBub3Qgc2V0CkNPTkZJR19QT1dFUl9TVVBQTFlf SFdNT049eQpDT05GSUdfUERBX1BPV0VSPW0KQ09ORklHX0dFTkVSSUNfQURDX0JBVFRFUlk9 bQpDT05GSUdfTUFYODkyNV9QT1dFUj1tCkNPTkZJR19XTTgzMVhfQkFDS1VQPW0KQ09ORklH X1dNODMxWF9QT1dFUj1tCkNPTkZJR19XTTgzNTBfUE9XRVI9bQpDT05GSUdfVEVTVF9QT1dF Uj1tCkNPTkZJR19CQVRURVJZXzg4UE04NjBYPW0KQ09ORklHX0NIQVJHRVJfQURQNTA2MT1t CkNPTkZJR19CQVRURVJZX0NXMjAxNT1tCkNPTkZJR19CQVRURVJZX0RTMjc2MD1tCkNPTkZJ R19CQVRURVJZX0RTMjc4MD1tCkNPTkZJR19CQVRURVJZX0RTMjc4MT1tCkNPTkZJR19CQVRU RVJZX0RTMjc4Mj1tCkNPTkZJR19CQVRURVJZX1NCUz1tCkNPTkZJR19DSEFSR0VSX1NCUz1t CkNPTkZJR19NQU5BR0VSX1NCUz1tCkNPTkZJR19CQVRURVJZX0JRMjdYWFg9bQpDT05GSUdf QkFUVEVSWV9CUTI3WFhYX0kyQz1tCkNPTkZJR19CQVRURVJZX0JRMjdYWFhfSERRPW0KIyBD T05GSUdfQkFUVEVSWV9CUTI3WFhYX0RUX1VQREFURVNfTlZNIGlzIG5vdCBzZXQKQ09ORklH X0JBVFRFUllfREE5MDMwPW0KQ09ORklHX0JBVFRFUllfREE5MDUyPW0KQ09ORklHX0NIQVJH RVJfREE5MTUwPW0KQ09ORklHX0JBVFRFUllfREE5MTUwPW0KQ09ORklHX0NIQVJHRVJfQVhQ MjBYPW0KQ09ORklHX0JBVFRFUllfQVhQMjBYPW0KQ09ORklHX0FYUDIwWF9QT1dFUj1tCkNP TkZJR19BWFAyODhfQ0hBUkdFUj1tCkNPTkZJR19BWFAyODhfRlVFTF9HQVVHRT1tCkNPTkZJ R19CQVRURVJZX01BWDE3MDQwPW0KQ09ORklHX0JBVFRFUllfTUFYMTcwNDI9bQpDT05GSUdf QkFUVEVSWV9NQVgxNzIxWD1tCkNPTkZJR19CQVRURVJZX1RXTDQwMzBfTUFEQz1tCkNPTkZJ R19DSEFSR0VSXzg4UE04NjBYPW0KQ09ORklHX0NIQVJHRVJfUENGNTA2MzM9bQpDT05GSUdf QkFUVEVSWV9SWDUxPW0KQ09ORklHX0NIQVJHRVJfSVNQMTcwND1tCkNPTkZJR19DSEFSR0VS X01BWDg5MDM9bQpDT05GSUdfQ0hBUkdFUl9UV0w0MDMwPW0KQ09ORklHX0NIQVJHRVJfTFA4 NzI3PW0KQ09ORklHX0NIQVJHRVJfTFA4Nzg4PW0KQ09ORklHX0NIQVJHRVJfR1BJTz1tCkNP TkZJR19DSEFSR0VSX01BTkFHRVI9eQpDT05GSUdfQ0hBUkdFUl9MVDM2NTE9bQpDT05GSUdf Q0hBUkdFUl9MVEM0MTYyTD1tCkNPTkZJR19DSEFSR0VSX01BWDE0NTc3PW0KQ09ORklHX0NI QVJHRVJfTUFYNzc2OTM9bQpDT05GSUdfQ0hBUkdFUl9NQVg4OTk3PW0KQ09ORklHX0NIQVJH RVJfTUFYODk5OD1tCkNPTkZJR19DSEFSR0VSX01QMjYyOT1tCkNPTkZJR19DSEFSR0VSX0JR MjQxNVg9bQpDT05GSUdfQ0hBUkdFUl9CUTI0MTkwPW0KQ09ORklHX0NIQVJHRVJfQlEyNDI1 Nz1tCkNPTkZJR19DSEFSR0VSX0JRMjQ3MzU9bQpDT05GSUdfQ0hBUkdFUl9CUTI1MTVYPW0K Q09ORklHX0NIQVJHRVJfQlEyNTg5MD1tCkNPTkZJR19DSEFSR0VSX0JRMjU5ODA9bQpDT05G SUdfQ0hBUkdFUl9CUTI1NlhYPW0KQ09ORklHX0NIQVJHRVJfU01CMzQ3PW0KQ09ORklHX0NI QVJHRVJfVFBTNjUwOTA9bQpDT05GSUdfQkFUVEVSWV9HQVVHRV9MVEMyOTQxPW0KQ09ORklH X0JBVFRFUllfUlQ1MDMzPW0KQ09ORklHX0NIQVJHRVJfUlQ5NDU1PW0KQ09ORklHX0NIQVJH RVJfQ1JPU19VU0JQRD1tCkNPTkZJR19DSEFSR0VSX0JEOTk5NTQ9bQpDT05GSUdfQ0hBUkdF Ul9XSUxDTz1tCkNPTkZJR19IV01PTj15CkNPTkZJR19IV01PTl9WSUQ9bQojIENPTkZJR19I V01PTl9ERUJVR19DSElQIGlzIG5vdCBzZXQKCiMKIyBOYXRpdmUgZHJpdmVycwojCkNPTkZJ R19TRU5TT1JTX0FCSVRVR1VSVT1tCkNPTkZJR19TRU5TT1JTX0FCSVRVR1VSVTM9bQpDT05G SUdfU0VOU09SU19BRDczMTQ9bQpDT05GSUdfU0VOU09SU19BRDc0MTQ9bQpDT05GSUdfU0VO U09SU19BRDc0MTg9bQpDT05GSUdfU0VOU09SU19BRE0xMDIxPW0KQ09ORklHX1NFTlNPUlNf QURNMTAyNT1tCkNPTkZJR19TRU5TT1JTX0FETTEwMjY9bQpDT05GSUdfU0VOU09SU19BRE0x MDI5PW0KQ09ORklHX1NFTlNPUlNfQURNMTAzMT1tCkNPTkZJR19TRU5TT1JTX0FETTExNzc9 bQpDT05GSUdfU0VOU09SU19BRE05MjQwPW0KQ09ORklHX1NFTlNPUlNfQURUN1gxMD1tCkNP TkZJR19TRU5TT1JTX0FEVDczMTA9bQpDT05GSUdfU0VOU09SU19BRFQ3NDEwPW0KQ09ORklH X1NFTlNPUlNfQURUNzQxMT1tCkNPTkZJR19TRU5TT1JTX0FEVDc0NjI9bQpDT05GSUdfU0VO U09SU19BRFQ3NDcwPW0KQ09ORklHX1NFTlNPUlNfQURUNzQ3NT1tCkNPTkZJR19TRU5TT1JT X0FIVDEwPW0KQ09ORklHX1NFTlNPUlNfQVMzNzA9bQpDT05GSUdfU0VOU09SU19BU0M3NjIx PW0KQ09ORklHX1NFTlNPUlNfQVhJX0ZBTl9DT05UUk9MPW0KQ09ORklHX1NFTlNPUlNfSzhU RU1QPW0KQ09ORklHX1NFTlNPUlNfSzEwVEVNUD1tCkNPTkZJR19TRU5TT1JTX0ZBTTE1SF9Q T1dFUj1tCkNPTkZJR19TRU5TT1JTX0FNRF9FTkVSR1k9bQpDT05GSUdfU0VOU09SU19BUFBM RVNNQz1tCkNPTkZJR19TRU5TT1JTX0FTQjEwMD1tCkNPTkZJR19TRU5TT1JTX0FTUEVFRD1t CkNPTkZJR19TRU5TT1JTX0FUWFAxPW0KQ09ORklHX1NFTlNPUlNfQ09SU0FJUl9DUFJPPW0K Q09ORklHX1NFTlNPUlNfQ09SU0FJUl9QU1U9bQpDT05GSUdfU0VOU09SU19EUklWRVRFTVA9 bQpDT05GSUdfU0VOU09SU19EUzYyMD1tCkNPTkZJR19TRU5TT1JTX0RTMTYyMT1tCkNPTkZJ R19TRU5TT1JTX0RFTExfU01NPW0KQ09ORklHX1NFTlNPUlNfREE5MDUyX0FEQz1tCkNPTkZJ R19TRU5TT1JTX0RBOTA1NT1tCkNPTkZJR19TRU5TT1JTX0k1S19BTUI9bQpDT05GSUdfU0VO U09SU19GNzE4MDVGPW0KQ09ORklHX1NFTlNPUlNfRjcxODgyRkc9bQpDT05GSUdfU0VOU09S U19GNzUzNzVTPW0KQ09ORklHX1NFTlNPUlNfTUMxMzc4M19BREM9bQpDT05GSUdfU0VOU09S U19GU0NITUQ9bQpDT05GSUdfU0VOU09SU19GVFNURVVUQVRFUz1tCkNPTkZJR19TRU5TT1JT X0dMNTE4U009bQpDT05GSUdfU0VOU09SU19HTDUyMFNNPW0KQ09ORklHX1NFTlNPUlNfRzc2 MEE9bQpDT05GSUdfU0VOU09SU19HNzYyPW0KQ09ORklHX1NFTlNPUlNfSElINjEzMD1tCkNP TkZJR19TRU5TT1JTX0lCTUFFTT1tCkNPTkZJR19TRU5TT1JTX0lCTVBFWD1tCkNPTkZJR19T RU5TT1JTX0lJT19IV01PTj1tCkNPTkZJR19TRU5TT1JTX0k1NTAwPW0KQ09ORklHX1NFTlNP UlNfQ09SRVRFTVA9bQpDT05GSUdfU0VOU09SU19JVDg3PW0KQ09ORklHX1NFTlNPUlNfSkM0 Mj1tCkNPTkZJR19TRU5TT1JTX1BPV1IxMjIwPW0KQ09ORklHX1NFTlNPUlNfTElORUFHRT1t CkNPTkZJR19TRU5TT1JTX0xUQzI5NDU9bQpDT05GSUdfU0VOU09SU19MVEMyOTQ3PW0KQ09O RklHX1NFTlNPUlNfTFRDMjk0N19JMkM9bQpDT05GSUdfU0VOU09SU19MVEMyOTQ3X1NQST1t CkNPTkZJR19TRU5TT1JTX0xUQzI5OTA9bQpDT05GSUdfU0VOU09SU19MVEMyOTkyPW0KQ09O RklHX1NFTlNPUlNfTFRDNDE1MT1tCkNPTkZJR19TRU5TT1JTX0xUQzQyMTU9bQpDT05GSUdf U0VOU09SU19MVEM0MjIyPW0KQ09ORklHX1NFTlNPUlNfTFRDNDI0NT1tCkNPTkZJR19TRU5T T1JTX0xUQzQyNjA9bQpDT05GSUdfU0VOU09SU19MVEM0MjYxPW0KQ09ORklHX1NFTlNPUlNf TUFYMTExMT1tCkNPTkZJR19TRU5TT1JTX01BWDEyNz1tCkNPTkZJR19TRU5TT1JTX01BWDE2 MDY1PW0KQ09ORklHX1NFTlNPUlNfTUFYMTYxOT1tCkNPTkZJR19TRU5TT1JTX01BWDE2Njg9 bQpDT05GSUdfU0VOU09SU19NQVgxOTc9bQpDT05GSUdfU0VOU09SU19NQVgzMTcyMj1tCkNP TkZJR19TRU5TT1JTX01BWDMxNzMwPW0KQ09ORklHX1NFTlNPUlNfTUFYNjYyMT1tCkNPTkZJ R19TRU5TT1JTX01BWDY2Mzk9bQpDT05GSUdfU0VOU09SU19NQVg2NjQyPW0KQ09ORklHX1NF TlNPUlNfTUFYNjY1MD1tCkNPTkZJR19TRU5TT1JTX01BWDY2OTc9bQpDT05GSUdfU0VOU09S U19NQVgzMTc5MD1tCkNPTkZJR19TRU5TT1JTX01DUDMwMjE9bQpDT05GSUdfU0VOU09SU19N TFhSRUdfRkFOPW0KQ09ORklHX1NFTlNPUlNfVEM2NTQ9bQpDT05GSUdfU0VOU09SU19UUFMy Mzg2MT1tCkNPTkZJR19TRU5TT1JTX01FTkYyMUJNQ19IV01PTj1tCkNPTkZJR19TRU5TT1JT X01SNzUyMDM9bQpDT05GSUdfU0VOU09SU19BRENYWD1tCkNPTkZJR19TRU5TT1JTX0xNNjM9 bQpDT05GSUdfU0VOU09SU19MTTcwPW0KQ09ORklHX1NFTlNPUlNfTE03Mz1tCkNPTkZJR19T RU5TT1JTX0xNNzU9bQpDT05GSUdfU0VOU09SU19MTTc3PW0KQ09ORklHX1NFTlNPUlNfTE03 OD1tCkNPTkZJR19TRU5TT1JTX0xNODA9bQpDT05GSUdfU0VOU09SU19MTTgzPW0KQ09ORklH X1NFTlNPUlNfTE04NT1tCkNPTkZJR19TRU5TT1JTX0xNODc9bQpDT05GSUdfU0VOU09SU19M TTkwPW0KQ09ORklHX1NFTlNPUlNfTE05Mj1tCkNPTkZJR19TRU5TT1JTX0xNOTM9bQpDT05G SUdfU0VOU09SU19MTTk1MjM0PW0KQ09ORklHX1NFTlNPUlNfTE05NTI0MT1tCkNPTkZJR19T RU5TT1JTX0xNOTUyNDU9bQpDT05GSUdfU0VOU09SU19QQzg3MzYwPW0KQ09ORklHX1NFTlNP UlNfUEM4NzQyNz1tCkNPTkZJR19TRU5TT1JTX05UQ19USEVSTUlTVE9SPW0KQ09ORklHX1NF TlNPUlNfTkNUNjY4Mz1tCkNPTkZJR19TRU5TT1JTX05DVDY3NzU9bQpDT05GSUdfU0VOU09S U19OQ1Q3ODAyPW0KQ09ORklHX1NFTlNPUlNfTkNUNzkwND1tCkNPTkZJR19TRU5TT1JTX05Q Q003WFg9bQpDT05GSUdfU0VOU09SU19QQ0Y4NTkxPW0KQ09ORklHX1BNQlVTPW0KQ09ORklH X1NFTlNPUlNfUE1CVVM9bQpDT05GSUdfU0VOU09SU19BRE0xMjY2PW0KQ09ORklHX1NFTlNP UlNfQURNMTI3NT1tCkNPTkZJR19TRU5TT1JTX0JFTF9QRkU9bQpDT05GSUdfU0VOU09SU19J Qk1fQ0ZGUFM9bQpDT05GSUdfU0VOU09SU19JTlNQVVJfSVBTUFM9bQpDT05GSUdfU0VOU09S U19JUjM1MjIxPW0KQ09ORklHX1NFTlNPUlNfSVIzODA2ND1tCkNPTkZJR19TRU5TT1JTX0lS UFM1NDAxPW0KQ09ORklHX1NFTlNPUlNfSVNMNjgxMzc9bQpDT05GSUdfU0VOU09SU19MTTI1 MDY2PW0KQ09ORklHX1NFTlNPUlNfTFRDMjk3OD1tCiMgQ09ORklHX1NFTlNPUlNfTFRDMjk3 OF9SRUdVTEFUT1IgaXMgbm90IHNldApDT05GSUdfU0VOU09SU19MVEMzODE1PW0KQ09ORklH X1NFTlNPUlNfTUFYMTYwNjQ9bQpDT05GSUdfU0VOU09SU19NQVgxNjYwMT1tCkNPTkZJR19T RU5TT1JTX01BWDIwNzMwPW0KQ09ORklHX1NFTlNPUlNfTUFYMjA3NTE9bQpDT05GSUdfU0VO U09SU19NQVgzMTc4NT1tCkNPTkZJR19TRU5TT1JTX01BWDM0NDQwPW0KQ09ORklHX1NFTlNP UlNfTUFYODY4OD1tCkNPTkZJR19TRU5TT1JTX01QMjk3NT1tCkNPTkZJR19TRU5TT1JTX1BN Njc2NFRSPW0KQ09ORklHX1NFTlNPUlNfUFhFMTYxMD1tCkNPTkZJR19TRU5TT1JTX1E1NFNK MTA4QTI9bQpDT05GSUdfU0VOU09SU19UUFM0MDQyMj1tCkNPTkZJR19TRU5TT1JTX1RQUzUz Njc5PW0KQ09ORklHX1NFTlNPUlNfVUNEOTAwMD1tCkNPTkZJR19TRU5TT1JTX1VDRDkyMDA9 bQpDT05GSUdfU0VOU09SU19YRFBFMTIyPW0KQ09ORklHX1NFTlNPUlNfWkw2MTAwPW0KQ09O RklHX1NFTlNPUlNfU0JUU0k9bQpDT05GSUdfU0VOU09SU19TSFQxNT1tCkNPTkZJR19TRU5T T1JTX1NIVDIxPW0KQ09ORklHX1NFTlNPUlNfU0hUM3g9bQpDT05GSUdfU0VOU09SU19TSFRD MT1tCkNPTkZJR19TRU5TT1JTX1NJUzU1OTU9bQpDT05GSUdfU0VOU09SU19ETUUxNzM3PW0K Q09ORklHX1NFTlNPUlNfRU1DMTQwMz1tCkNPTkZJR19TRU5TT1JTX0VNQzIxMDM9bQpDT05G SUdfU0VOU09SU19FTUM2VzIwMT1tCkNPTkZJR19TRU5TT1JTX1NNU0M0N00xPW0KQ09ORklH X1NFTlNPUlNfU01TQzQ3TTE5Mj1tCkNPTkZJR19TRU5TT1JTX1NNU0M0N0IzOTc9bQpDT05G SUdfU0VOU09SU19TQ0g1NlhYX0NPTU1PTj1tCkNPTkZJR19TRU5TT1JTX1NDSDU2Mjc9bQpD T05GSUdfU0VOU09SU19TQ0g1NjM2PW0KQ09ORklHX1NFTlNPUlNfU1RUUzc1MT1tCkNPTkZJ R19TRU5TT1JTX1NNTTY2NT1tCkNPTkZJR19TRU5TT1JTX0FEQzEyOEQ4MTg9bQpDT05GSUdf U0VOU09SU19BRFM3ODI4PW0KQ09ORklHX1NFTlNPUlNfQURTNzg3MT1tCkNPTkZJR19TRU5T T1JTX0FNQzY4MjE9bQpDT05GSUdfU0VOU09SU19JTkEyMDk9bQpDT05GSUdfU0VOU09SU19J TkEyWFg9bQpDT05GSUdfU0VOU09SU19JTkEzMjIxPW0KQ09ORklHX1NFTlNPUlNfVEM3ND1t CkNPTkZJR19TRU5TT1JTX1RITUM1MD1tCkNPTkZJR19TRU5TT1JTX1RNUDEwMj1tCkNPTkZJ R19TRU5TT1JTX1RNUDEwMz1tCkNPTkZJR19TRU5TT1JTX1RNUDEwOD1tCkNPTkZJR19TRU5T T1JTX1RNUDQwMT1tCkNPTkZJR19TRU5TT1JTX1RNUDQyMT1tCkNPTkZJR19TRU5TT1JTX1RN UDUxMz1tCkNPTkZJR19TRU5TT1JTX1ZJQV9DUFVURU1QPW0KQ09ORklHX1NFTlNPUlNfVklB Njg2QT1tCkNPTkZJR19TRU5TT1JTX1ZUMTIxMT1tCkNPTkZJR19TRU5TT1JTX1ZUODIzMT1t CkNPTkZJR19TRU5TT1JTX1c4Mzc3M0c9bQpDT05GSUdfU0VOU09SU19XODM3ODFEPW0KQ09O RklHX1NFTlNPUlNfVzgzNzkxRD1tCkNPTkZJR19TRU5TT1JTX1c4Mzc5MkQ9bQpDT05GSUdf U0VOU09SU19XODM3OTM9bQpDT05GSUdfU0VOU09SU19XODM3OTU9bQojIENPTkZJR19TRU5T T1JTX1c4Mzc5NV9GQU5DVFJMIGlzIG5vdCBzZXQKQ09ORklHX1NFTlNPUlNfVzgzTDc4NVRT PW0KQ09ORklHX1NFTlNPUlNfVzgzTDc4Nk5HPW0KQ09ORklHX1NFTlNPUlNfVzgzNjI3SEY9 bQpDT05GSUdfU0VOU09SU19XODM2MjdFSEY9bQpDT05GSUdfU0VOU09SU19XTTgzMVg9bQpD T05GSUdfU0VOU09SU19XTTgzNTA9bQpDT05GSUdfU0VOU09SU19YR0VORT1tCkNPTkZJR19T RU5TT1JTX0lOVEVMX00xMF9CTUNfSFdNT049bQoKIwojIEFDUEkgZHJpdmVycwojCkNPTkZJ R19TRU5TT1JTX0FDUElfUE9XRVI9bQpDT05GSUdfU0VOU09SU19BVEswMTEwPW0KQ09ORklH X1RIRVJNQUw9eQpDT05GSUdfVEhFUk1BTF9ORVRMSU5LPXkKIyBDT05GSUdfVEhFUk1BTF9T VEFUSVNUSUNTIGlzIG5vdCBzZXQKQ09ORklHX1RIRVJNQUxfRU1FUkdFTkNZX1BPV0VST0ZG X0RFTEFZX01TPTEwMApDT05GSUdfVEhFUk1BTF9IV01PTj15CkNPTkZJR19USEVSTUFMX1dS SVRBQkxFX1RSSVBTPXkKQ09ORklHX1RIRVJNQUxfREVGQVVMVF9HT1ZfU1RFUF9XSVNFPXkK IyBDT05GSUdfVEhFUk1BTF9ERUZBVUxUX0dPVl9GQUlSX1NIQVJFIGlzIG5vdCBzZXQKIyBD T05GSUdfVEhFUk1BTF9ERUZBVUxUX0dPVl9VU0VSX1NQQUNFIGlzIG5vdCBzZXQKIyBDT05G SUdfVEhFUk1BTF9ERUZBVUxUX0dPVl9QT1dFUl9BTExPQ0FUT1IgaXMgbm90IHNldApDT05G SUdfVEhFUk1BTF9HT1ZfRkFJUl9TSEFSRT15CkNPTkZJR19USEVSTUFMX0dPVl9TVEVQX1dJ U0U9eQpDT05GSUdfVEhFUk1BTF9HT1ZfQkFOR19CQU5HPXkKQ09ORklHX1RIRVJNQUxfR09W X1VTRVJfU1BBQ0U9eQpDT05GSUdfVEhFUk1BTF9HT1ZfUE9XRVJfQUxMT0NBVE9SPXkKQ09O RklHX0RFVkZSRVFfVEhFUk1BTD15CiMgQ09ORklHX1RIRVJNQUxfRU1VTEFUSU9OIGlzIG5v dCBzZXQKCiMKIyBJbnRlbCB0aGVybWFsIGRyaXZlcnMKIwpDT05GSUdfSU5URUxfUE9XRVJD TEFNUD1tCkNPTkZJR19YODZfVEhFUk1BTF9WRUNUT1I9eQpDT05GSUdfWDg2X1BLR19URU1Q X1RIRVJNQUw9bQpDT05GSUdfSU5URUxfU09DX0RUU19JT1NGX0NPUkU9bQpDT05GSUdfSU5U RUxfU09DX0RUU19USEVSTUFMPW0KCiMKIyBBQ1BJIElOVDM0MFggdGhlcm1hbCBkcml2ZXJz CiMKQ09ORklHX0lOVDM0MFhfVEhFUk1BTD1tCkNPTkZJR19BQ1BJX1RIRVJNQUxfUkVMPW0K Q09ORklHX0lOVDM0MDZfVEhFUk1BTD1tCkNPTkZJR19QUk9DX1RIRVJNQUxfTU1JT19SQVBM PW0KIyBlbmQgb2YgQUNQSSBJTlQzNDBYIHRoZXJtYWwgZHJpdmVycwoKQ09ORklHX0lOVEVM X0JYVF9QTUlDX1RIRVJNQUw9bQpDT05GSUdfSU5URUxfUENIX1RIRVJNQUw9bQojIGVuZCBv ZiBJbnRlbCB0aGVybWFsIGRyaXZlcnMKCkNPTkZJR19HRU5FUklDX0FEQ19USEVSTUFMPW0K Q09ORklHX1dBVENIRE9HPXkKQ09ORklHX1dBVENIRE9HX0NPUkU9eQojIENPTkZJR19XQVRD SERPR19OT1dBWU9VVCBpcyBub3Qgc2V0CkNPTkZJR19XQVRDSERPR19IQU5ETEVfQk9PVF9F TkFCTEVEPXkKQ09ORklHX1dBVENIRE9HX09QRU5fVElNRU9VVD0wCkNPTkZJR19XQVRDSERP R19TWVNGUz15CgojCiMgV2F0Y2hkb2cgUHJldGltZW91dCBHb3Zlcm5vcnMKIwpDT05GSUdf V0FUQ0hET0dfUFJFVElNRU9VVF9HT1Y9eQpDT05GSUdfV0FUQ0hET0dfUFJFVElNRU9VVF9H T1ZfU0VMPW0KQ09ORklHX1dBVENIRE9HX1BSRVRJTUVPVVRfR09WX05PT1A9bQpDT05GSUdf V0FUQ0hET0dfUFJFVElNRU9VVF9HT1ZfUEFOSUM9eQojIENPTkZJR19XQVRDSERPR19QUkVU SU1FT1VUX0RFRkFVTFRfR09WX05PT1AgaXMgbm90IHNldApDT05GSUdfV0FUQ0hET0dfUFJF VElNRU9VVF9ERUZBVUxUX0dPVl9QQU5JQz15CgojCiMgV2F0Y2hkb2cgRGV2aWNlIERyaXZl cnMKIwpDT05GSUdfU09GVF9XQVRDSERPRz1tCiMgQ09ORklHX1NPRlRfV0FUQ0hET0dfUFJF VElNRU9VVCBpcyBub3Qgc2V0CkNPTkZJR19EQTkwNTJfV0FUQ0hET0c9bQpDT05GSUdfREE5 MDU1X1dBVENIRE9HPW0KQ09ORklHX0RBOTA2M19XQVRDSERPRz1tCkNPTkZJR19EQTkwNjJf V0FUQ0hET0c9bQpDT05GSUdfTUVORjIxQk1DX1dBVENIRE9HPW0KQ09ORklHX01FTlowNjlf V0FUQ0hET0c9bQpDT05GSUdfV0RBVF9XRFQ9bQpDT05GSUdfV004MzFYX1dBVENIRE9HPW0K Q09ORklHX1dNODM1MF9XQVRDSERPRz1tCkNPTkZJR19YSUxJTlhfV0FUQ0hET0c9bQpDT05G SUdfWklJUkFWRV9XQVRDSERPRz1tCkNPTkZJR19SQVZFX1NQX1dBVENIRE9HPW0KQ09ORklH X01MWF9XRFQ9bQpDT05GSUdfQ0FERU5DRV9XQVRDSERPRz1tCkNPTkZJR19EV19XQVRDSERP Rz1tCkNPTkZJR19UV0w0MDMwX1dBVENIRE9HPW0KQ09ORklHX01BWDYzWFhfV0FUQ0hET0c9 bQpDT05GSUdfUkVUVV9XQVRDSERPRz1tCkNPTkZJR19BQ1FVSVJFX1dEVD1tCkNPTkZJR19B RFZBTlRFQ0hfV0RUPW0KQ09ORklHX0FMSU0xNTM1X1dEVD1tCkNPTkZJR19BTElNNzEwMV9X RFQ9bQpDT05GSUdfRUJDX0MzODRfV0RUPW0KQ09ORklHX0Y3MTgwOEVfV0RUPW0KQ09ORklH X1NQNTEwMF9UQ089bQpDT05GSUdfU0JDX0ZJVFBDMl9XQVRDSERPRz1tCkNPTkZJR19FVVJP VEVDSF9XRFQ9bQpDT05GSUdfSUI3MDBfV0RUPW0KQ09ORklHX0lCTUFTUj1tCkNPTkZJR19X QUZFUl9XRFQ9bQpDT05GSUdfSTYzMDBFU0JfV0RUPW0KQ09ORklHX0lFNlhYX1dEVD1tCkNP TkZJR19JVENPX1dEVD1tCkNPTkZJR19JVENPX1ZFTkRPUl9TVVBQT1JUPXkKQ09ORklHX0lU ODcxMkZfV0RUPW0KQ09ORklHX0lUODdfV0RUPW0KQ09ORklHX0hQX1dBVENIRE9HPW0KQ09O RklHX0hQV0RUX05NSV9ERUNPRElORz15CkNPTkZJR19LRU1QTERfV0RUPW0KQ09ORklHX1ND MTIwMF9XRFQ9bQpDT05GSUdfUEM4NzQxM19XRFQ9bQpDT05GSUdfTlZfVENPPW0KQ09ORklH XzYwWFhfV0RUPW0KQ09ORklHX0NQVTVfV0RUPW0KQ09ORklHX1NNU0NfU0NIMzExWF9XRFQ9 bQpDT05GSUdfU01TQzM3Qjc4N19XRFQ9bQpDT05GSUdfVFFNWDg2X1dEVD1tCkNPTkZJR19W SUFfV0RUPW0KQ09ORklHX1c4MzYyN0hGX1dEVD1tCkNPTkZJR19XODM4NzdGX1dEVD1tCkNP TkZJR19XODM5NzdGX1dEVD1tCkNPTkZJR19NQUNIWl9XRFQ9bQpDT05GSUdfU0JDX0VQWF9D M19XQVRDSERPRz1tCkNPTkZJR19JTlRFTF9NRUlfV0RUPW0KQ09ORklHX05JOTAzWF9XRFQ9 bQpDT05GSUdfTklDNzAxOF9XRFQ9bQpDT05GSUdfTUVOX0EyMV9XRFQ9bQpDT05GSUdfWEVO X1dEVD1tCgojCiMgUENJLWJhc2VkIFdhdGNoZG9nIENhcmRzCiMKQ09ORklHX1BDSVBDV0FU Q0hET0c9bQpDT05GSUdfV0RUUENJPW0KCiMKIyBVU0ItYmFzZWQgV2F0Y2hkb2cgQ2FyZHMK IwpDT05GSUdfVVNCUENXQVRDSERPRz1tCkNPTkZJR19TU0JfUE9TU0lCTEU9eQpDT05GSUdf U1NCPW0KQ09ORklHX1NTQl9TUFJPTT15CkNPTkZJR19TU0JfQkxPQ0tJTz15CkNPTkZJR19T U0JfUENJSE9TVF9QT1NTSUJMRT15CkNPTkZJR19TU0JfUENJSE9TVD15CkNPTkZJR19TU0Jf QjQzX1BDSV9CUklER0U9eQpDT05GSUdfU1NCX1BDTUNJQUhPU1RfUE9TU0lCTEU9eQpDT05G SUdfU1NCX1BDTUNJQUhPU1Q9eQpDT05GSUdfU1NCX1NESU9IT1NUX1BPU1NJQkxFPXkKQ09O RklHX1NTQl9TRElPSE9TVD15CkNPTkZJR19TU0JfRFJJVkVSX1BDSUNPUkVfUE9TU0lCTEU9 eQpDT05GSUdfU1NCX0RSSVZFUl9QQ0lDT1JFPXkKQ09ORklHX1NTQl9EUklWRVJfR1BJTz15 CkNPTkZJR19CQ01BX1BPU1NJQkxFPXkKQ09ORklHX0JDTUE9bQpDT05GSUdfQkNNQV9CTE9D S0lPPXkKQ09ORklHX0JDTUFfSE9TVF9QQ0lfUE9TU0lCTEU9eQpDT05GSUdfQkNNQV9IT1NU X1BDST15CiMgQ09ORklHX0JDTUFfSE9TVF9TT0MgaXMgbm90IHNldApDT05GSUdfQkNNQV9E UklWRVJfUENJPXkKQ09ORklHX0JDTUFfRFJJVkVSX0dNQUNfQ01OPXkKQ09ORklHX0JDTUFf RFJJVkVSX0dQSU89eQojIENPTkZJR19CQ01BX0RFQlVHIGlzIG5vdCBzZXQKCiMKIyBNdWx0 aWZ1bmN0aW9uIGRldmljZSBkcml2ZXJzCiMKQ09ORklHX01GRF9DT1JFPXkKQ09ORklHX01G RF9BUzM3MTE9eQpDT05GSUdfUE1JQ19BRFA1NTIwPXkKQ09ORklHX01GRF9BQVQyODcwX0NP UkU9eQpDT05GSUdfTUZEX0JDTTU5MFhYPW0KQ09ORklHX01GRF9CRDk1NzFNV1Y9bQpDT05G SUdfTUZEX0FYUDIwWD1tCkNPTkZJR19NRkRfQVhQMjBYX0kyQz1tCkNPTkZJR19NRkRfQ1JP U19FQ19ERVY9bQpDT05GSUdfTUZEX01BREVSQT1tCkNPTkZJR19NRkRfTUFERVJBX0kyQz1t CkNPTkZJR19NRkRfTUFERVJBX1NQST1tCkNPTkZJR19NRkRfQ1M0N0wxNT15CkNPTkZJR19N RkRfQ1M0N0wzNT15CkNPTkZJR19NRkRfQ1M0N0w4NT15CkNPTkZJR19NRkRfQ1M0N0w5MD15 CkNPTkZJR19NRkRfQ1M0N0w5Mj15CkNPTkZJR19QTUlDX0RBOTAzWD15CkNPTkZJR19QTUlD X0RBOTA1Mj15CkNPTkZJR19NRkRfREE5MDUyX1NQST15CkNPTkZJR19NRkRfREE5MDUyX0ky Qz15CkNPTkZJR19NRkRfREE5MDU1PXkKQ09ORklHX01GRF9EQTkwNjI9bQpDT05GSUdfTUZE X0RBOTA2Mz1tCkNPTkZJR19NRkRfREE5MTUwPW0KQ09ORklHX01GRF9ETE4yPW0KQ09ORklH X01GRF9NQzEzWFhYPW0KQ09ORklHX01GRF9NQzEzWFhYX1NQST1tCkNPTkZJR19NRkRfTUMx M1hYWF9JMkM9bQpDT05GSUdfTUZEX01QMjYyOT1tCkNPTkZJR19IVENfUEFTSUMzPW0KQ09O RklHX0hUQ19JMkNQTEQ9eQpDT05GSUdfTUZEX0lOVEVMX1FVQVJLX0kyQ19HUElPPW0KQ09O RklHX0xQQ19JQ0g9bQpDT05GSUdfTFBDX1NDSD1tCkNPTkZJR19JTlRFTF9TT0NfUE1JQz15 CkNPTkZJR19JTlRFTF9TT0NfUE1JQ19CWFRXQz1tCkNPTkZJR19JTlRFTF9TT0NfUE1JQ19D SFRXQz15CkNPTkZJR19JTlRFTF9TT0NfUE1JQ19DSFREQ19UST1tCkNPTkZJR19JTlRFTF9T T0NfUE1JQ19NUkZMRD1tCkNPTkZJR19NRkRfSU5URUxfTFBTUz1tCkNPTkZJR19NRkRfSU5U RUxfTFBTU19BQ1BJPW0KQ09ORklHX01GRF9JTlRFTF9MUFNTX1BDST1tCkNPTkZJR19NRkRf SU5URUxfUE1DX0JYVD1tCkNPTkZJR19NRkRfSU5URUxfUE1UPW0KQ09ORklHX01GRF9JUVM2 Mlg9bQpDT05GSUdfTUZEX0pBTlpfQ01PRElPPW0KQ09ORklHX01GRF9LRU1QTEQ9bQpDT05G SUdfTUZEXzg4UE04MDA9bQpDT05GSUdfTUZEXzg4UE04MDU9bQpDT05GSUdfTUZEXzg4UE04 NjBYPXkKQ09ORklHX01GRF9NQVgxNDU3Nz1tCkNPTkZJR19NRkRfTUFYNzc2OTM9bQpDT05G SUdfTUZEX01BWDc3ODQzPXkKQ09ORklHX01GRF9NQVg4OTA3PW0KQ09ORklHX01GRF9NQVg4 OTI1PXkKQ09ORklHX01GRF9NQVg4OTk3PXkKQ09ORklHX01GRF9NQVg4OTk4PXkKQ09ORklH X01GRF9NVDYzNjA9bQpDT05GSUdfTUZEX01UNjM5Nz1tCkNPTkZJR19NRkRfTUVORjIxQk1D PW0KQ09ORklHX0VaWF9QQ0FQPXkKQ09ORklHX01GRF9WSVBFUkJPQVJEPW0KQ09ORklHX01G RF9SRVRVPW0KQ09ORklHX01GRF9QQ0Y1MDYzMz1tCkNPTkZJR19QQ0Y1MDYzM19BREM9bQpD T05GSUdfUENGNTA2MzNfR1BJTz1tCkNPTkZJR19VQ0IxNDAwX0NPUkU9bQpDT05GSUdfTUZE X1JEQzMyMVg9bQpDT05GSUdfTUZEX1JUNTAzMz1tCkNPTkZJR19NRkRfUkM1VDU4Mz15CkNP TkZJR19NRkRfU0VDX0NPUkU9eQpDT05GSUdfTUZEX1NJNDc2WF9DT1JFPW0KQ09ORklHX01G RF9TTTUwMT1tCkNPTkZJR19NRkRfU001MDFfR1BJTz15CkNPTkZJR19NRkRfU0tZODE0NTI9 bQpDT05GSUdfQUJYNTAwX0NPUkU9eQpDT05GSUdfQUIzMTAwX0NPUkU9eQpDT05GSUdfQUIz MTAwX09UUD15CkNPTkZJR19NRkRfU1lTQ09OPXkKQ09ORklHX01GRF9USV9BTTMzNVhfVFND QURDPW0KQ09ORklHX01GRF9MUDM5NDM9bQpDT05GSUdfTUZEX0xQODc4OD15CkNPTkZJR19N RkRfVElfTE1VPW0KQ09ORklHX01GRF9QQUxNQVM9eQpDT05GSUdfVFBTNjEwNVg9bQpDT05G SUdfVFBTNjUwMTA9bQpDT05GSUdfVFBTNjUwN1g9bQpDT05GSUdfTUZEX1RQUzY1MDg2PW0K Q09ORklHX01GRF9UUFM2NTA5MD15CkNPTkZJR19NRkRfVFBTNjg0NzA9eQpDT05GSUdfTUZE X1RJX0xQODczWD1tCkNPTkZJR19NRkRfVFBTNjU4Nlg9eQpDT05GSUdfTUZEX1RQUzY1OTEw PXkKQ09ORklHX01GRF9UUFM2NTkxMj1tCkNPTkZJR19NRkRfVFBTNjU5MTJfSTJDPW0KQ09O RklHX01GRF9UUFM2NTkxMl9TUEk9bQpDT05GSUdfTUZEX1RQUzgwMDMxPXkKQ09ORklHX1RX TDQwMzBfQ09SRT15CkNPTkZJR19NRkRfVFdMNDAzMF9BVURJTz15CkNPTkZJR19UV0w2MDQw X0NPUkU9eQpDT05GSUdfTUZEX1dMMTI3M19DT1JFPW0KQ09ORklHX01GRF9MTTM1MzM9bQpD T05GSUdfTUZEX1RRTVg4Nj1tCkNPTkZJR19NRkRfVlg4NTU9bQpDT05GSUdfTUZEX0FSSVpP TkE9eQpDT05GSUdfTUZEX0FSSVpPTkFfSTJDPW0KQ09ORklHX01GRF9BUklaT05BX1NQST1t CkNPTkZJR19NRkRfQ1M0N0wyND15CkNPTkZJR19NRkRfV001MTAyPXkKQ09ORklHX01GRF9X TTUxMTA9eQpDT05GSUdfTUZEX1dNODk5Nz15CkNPTkZJR19NRkRfV004OTk4PXkKQ09ORklH X01GRF9XTTg0MDA9eQpDT05GSUdfTUZEX1dNODMxWD15CkNPTkZJR19NRkRfV004MzFYX0ky Qz15CkNPTkZJR19NRkRfV004MzFYX1NQST15CkNPTkZJR19NRkRfV004MzUwPXkKQ09ORklH X01GRF9XTTgzNTBfSTJDPXkKQ09ORklHX01GRF9XTTg5OTQ9bQpDT05GSUdfTUZEX1dDRDkz NFg9bQpDT05GSUdfUkFWRV9TUF9DT1JFPW0KQ09ORklHX01GRF9JTlRFTF9NMTBfQk1DPW0K IyBlbmQgb2YgTXVsdGlmdW5jdGlvbiBkZXZpY2UgZHJpdmVycwoKQ09ORklHX1JFR1VMQVRP Uj15CiMgQ09ORklHX1JFR1VMQVRPUl9ERUJVRyBpcyBub3Qgc2V0CkNPTkZJR19SRUdVTEFU T1JfRklYRURfVk9MVEFHRT1tCkNPTkZJR19SRUdVTEFUT1JfVklSVFVBTF9DT05TVU1FUj1t CkNPTkZJR19SRUdVTEFUT1JfVVNFUlNQQUNFX0NPTlNVTUVSPW0KQ09ORklHX1JFR1VMQVRP Ul84OFBHODZYPW0KQ09ORklHX1JFR1VMQVRPUl84OFBNODAwPW0KQ09ORklHX1JFR1VMQVRP Ul84OFBNODYwNz1tCkNPTkZJR19SRUdVTEFUT1JfQUNUODg2NT1tCkNPTkZJR19SRUdVTEFU T1JfQUQ1Mzk4PW0KQ09ORklHX1JFR1VMQVRPUl9BQVQyODcwPW0KQ09ORklHX1JFR1VMQVRP Ul9BUklaT05BX0xETzE9bQpDT05GSUdfUkVHVUxBVE9SX0FSSVpPTkFfTUlDU1VQUD1tCkNP TkZJR19SRUdVTEFUT1JfQVMzNzExPW0KQ09ORklHX1JFR1VMQVRPUl9BWFAyMFg9bQpDT05G SUdfUkVHVUxBVE9SX0JDTTU5MFhYPW0KQ09ORklHX1JFR1VMQVRPUl9CRDk1NzFNV1Y9bQpD T05GSUdfUkVHVUxBVE9SX0RBOTAzWD1tCkNPTkZJR19SRUdVTEFUT1JfREE5MDUyPW0KQ09O RklHX1JFR1VMQVRPUl9EQTkwNTU9bQpDT05GSUdfUkVHVUxBVE9SX0RBOTA2Mj1tCkNPTkZJ R19SRUdVTEFUT1JfREE5MjEwPW0KQ09ORklHX1JFR1VMQVRPUl9EQTkyMTE9bQpDT05GSUdf UkVHVUxBVE9SX0ZBTjUzNTU1PW0KQ09ORklHX1JFR1VMQVRPUl9HUElPPW0KQ09ORklHX1JF R1VMQVRPUl9JU0w5MzA1PW0KQ09ORklHX1JFR1VMQVRPUl9JU0w2MjcxQT1tCkNPTkZJR19S RUdVTEFUT1JfTE0zNjNYPW0KQ09ORklHX1JFR1VMQVRPUl9MUDM5NzE9bQpDT05GSUdfUkVH VUxBVE9SX0xQMzk3Mj1tCkNPTkZJR19SRUdVTEFUT1JfTFA4NzJYPW0KQ09ORklHX1JFR1VM QVRPUl9MUDg3NTU9bQpDT05GSUdfUkVHVUxBVE9SX0xQODc4OD1tCkNPTkZJR19SRUdVTEFU T1JfTFRDMzU4OT1tCkNPTkZJR19SRUdVTEFUT1JfTFRDMzY3Nj1tCkNPTkZJR19SRUdVTEFU T1JfTUFYMTQ1Nzc9bQpDT05GSUdfUkVHVUxBVE9SX01BWDE1ODY9bQpDT05GSUdfUkVHVUxB VE9SX01BWDg2NDk9bQpDT05GSUdfUkVHVUxBVE9SX01BWDg2NjA9bQpDT05GSUdfUkVHVUxB VE9SX01BWDg5MDc9bQpDT05GSUdfUkVHVUxBVE9SX01BWDg5MjU9bQpDT05GSUdfUkVHVUxB VE9SX01BWDg5NTI9bQpDT05GSUdfUkVHVUxBVE9SX01BWDg5OTc9bQpDT05GSUdfUkVHVUxB VE9SX01BWDg5OTg9bQpDT05GSUdfUkVHVUxBVE9SX01BWDc3NjkzPW0KQ09ORklHX1JFR1VM QVRPUl9NQVg3NzgyNj1tCkNPTkZJR19SRUdVTEFUT1JfTUMxM1hYWF9DT1JFPW0KQ09ORklH X1JFR1VMQVRPUl9NQzEzNzgzPW0KQ09ORklHX1JFR1VMQVRPUl9NQzEzODkyPW0KQ09ORklH X1JFR1VMQVRPUl9NUDg4NTk9bQpDT05GSUdfUkVHVUxBVE9SX01UNjMxMT1tCkNPTkZJR19S RUdVTEFUT1JfTVQ2MzIzPW0KQ09ORklHX1JFR1VMQVRPUl9NVDYzNTg9bQpDT05GSUdfUkVH VUxBVE9SX01UNjM2MD1tCkNPTkZJR19SRUdVTEFUT1JfTVQ2Mzk3PW0KQ09ORklHX1JFR1VM QVRPUl9QQUxNQVM9bQpDT05GSUdfUkVHVUxBVE9SX1BDQTk0NTA9bQpDT05GSUdfUkVHVUxB VE9SX1BDQVA9bQpDT05GSUdfUkVHVUxBVE9SX1BDRjUwNjMzPW0KQ09ORklHX1JFR1VMQVRP Ul9QVjg4MDYwPW0KQ09ORklHX1JFR1VMQVRPUl9QVjg4MDgwPW0KQ09ORklHX1JFR1VMQVRP Ul9QVjg4MDkwPW0KQ09ORklHX1JFR1VMQVRPUl9QV009bQpDT05GSUdfUkVHVUxBVE9SX1JB U1BCRVJSWVBJX1RPVUNIU0NSRUVOX0FUVElOWT1tCkNPTkZJR19SRUdVTEFUT1JfUkM1VDU4 Mz1tCkNPTkZJR19SRUdVTEFUT1JfUlQ0ODAxPW0KQ09ORklHX1JFR1VMQVRPUl9SVDUwMzM9 bQpDT05GSUdfUkVHVUxBVE9SX1JUTVYyMD1tCkNPTkZJR19SRUdVTEFUT1JfUzJNUEEwMT1t CkNPTkZJR19SRUdVTEFUT1JfUzJNUFMxMT1tCkNPTkZJR19SRUdVTEFUT1JfUzVNODc2Nz1t CkNPTkZJR19SRUdVTEFUT1JfU0tZODE0NTI9bQpDT05GSUdfUkVHVUxBVE9SX1NMRzUxMDAw PW0KQ09ORklHX1JFR1VMQVRPUl9UUFM1MTYzMj1tCkNPTkZJR19SRUdVTEFUT1JfVFBTNjEw NVg9bQpDT05GSUdfUkVHVUxBVE9SX1RQUzYyMzYwPW0KQ09ORklHX1JFR1VMQVRPUl9UUFM2 NTAyMz1tCkNPTkZJR19SRUdVTEFUT1JfVFBTNjUwN1g9bQpDT05GSUdfUkVHVUxBVE9SX1RQ UzY1MDg2PW0KQ09ORklHX1JFR1VMQVRPUl9UUFM2NTA5MD1tCkNPTkZJR19SRUdVTEFUT1Jf VFBTNjUxMzI9bQpDT05GSUdfUkVHVUxBVE9SX1RQUzY1MjRYPW0KQ09ORklHX1JFR1VMQVRP Ul9UUFM2NTg2WD1tCkNPTkZJR19SRUdVTEFUT1JfVFBTNjU5MTA9bQpDT05GSUdfUkVHVUxB VE9SX1RQUzY1OTEyPW0KQ09ORklHX1JFR1VMQVRPUl9UUFM4MDAzMT1tCkNPTkZJR19SRUdV TEFUT1JfVFdMNDAzMD1tCkNPTkZJR19SRUdVTEFUT1JfV004MzFYPW0KQ09ORklHX1JFR1VM QVRPUl9XTTgzNTA9bQpDT05GSUdfUkVHVUxBVE9SX1dNODQwMD1tCkNPTkZJR19SRUdVTEFU T1JfV004OTk0PW0KQ09ORklHX1JDX0NPUkU9eQpDT05GSUdfUkNfTUFQPW0KQ09ORklHX0xJ UkM9eQpDT05GSUdfQlBGX0xJUkNfTU9ERTI9eQpDT05GSUdfUkNfREVDT0RFUlM9eQpDT05G SUdfSVJfTkVDX0RFQ09ERVI9bQpDT05GSUdfSVJfUkM1X0RFQ09ERVI9bQpDT05GSUdfSVJf UkM2X0RFQ09ERVI9bQpDT05GSUdfSVJfSlZDX0RFQ09ERVI9bQpDT05GSUdfSVJfU09OWV9E RUNPREVSPW0KQ09ORklHX0lSX1NBTllPX0RFQ09ERVI9bQpDT05GSUdfSVJfU0hBUlBfREVD T0RFUj1tCkNPTkZJR19JUl9NQ0VfS0JEX0RFQ09ERVI9bQpDT05GSUdfSVJfWE1QX0RFQ09E RVI9bQpDT05GSUdfSVJfSU1PTl9ERUNPREVSPW0KQ09ORklHX0lSX1JDTU1fREVDT0RFUj1t CkNPTkZJR19SQ19ERVZJQ0VTPXkKQ09ORklHX1JDX0FUSV9SRU1PVEU9bQpDT05GSUdfSVJf RU5FPW0KQ09ORklHX0lSX0lNT049bQpDT05GSUdfSVJfSU1PTl9SQVc9bQpDT05GSUdfSVJf TUNFVVNCPW0KQ09ORklHX0lSX0lURV9DSVI9bQpDT05GSUdfSVJfRklOVEVLPW0KQ09ORklH X0lSX05VVk9UT049bQpDT05GSUdfSVJfUkVEUkFUMz1tCkNPTkZJR19JUl9TVFJFQU1aQVA9 bQpDT05GSUdfSVJfV0lOQk9ORF9DSVI9bQpDT05GSUdfSVJfSUdPUlBMVUdVU0I9bQpDT05G SUdfSVJfSUdVQU5BPW0KQ09ORklHX0lSX1RUVVNCSVI9bQpDT05GSUdfUkNfTE9PUEJBQ0s9 bQpDT05GSUdfSVJfU0VSSUFMPW0KQ09ORklHX0lSX1NFUklBTF9UUkFOU01JVFRFUj15CkNP TkZJR19JUl9TSVI9bQpDT05GSUdfUkNfWEJPWF9EVkQ9bQpDT05GSUdfSVJfVE9ZPW0KQ09O RklHX0NFQ19DT1JFPW0KQ09ORklHX0NFQ19OT1RJRklFUj15CkNPTkZJR19DRUNfUElOPXkK Q09ORklHX01FRElBX0NFQ19SQz15CiMgQ09ORklHX0NFQ19QSU5fRVJST1JfSU5KIGlzIG5v dCBzZXQKQ09ORklHX01FRElBX0NFQ19TVVBQT1JUPXkKQ09ORklHX0NFQ19DSDczMjI9bQpD T05GSUdfQ0VDX0NST1NfRUM9bQpDT05GSUdfQ0VDX0dQSU89bQpDT05GSUdfQ0VDX1NFQ089 bQpDT05GSUdfQ0VDX1NFQ09fUkM9eQpDT05GSUdfVVNCX1BVTFNFOF9DRUM9bQpDT05GSUdf VVNCX1JBSU5TSEFET1dfQ0VDPW0KQ09ORklHX01FRElBX1NVUFBPUlQ9bQpDT05GSUdfTUVE SUFfU1VQUE9SVF9GSUxURVI9eQpDT05GSUdfTUVESUFfU1VCRFJWX0FVVE9TRUxFQ1Q9eQoK IwojIE1lZGlhIGRldmljZSB0eXBlcwojCkNPTkZJR19NRURJQV9DQU1FUkFfU1VQUE9SVD15 CkNPTkZJR19NRURJQV9BTkFMT0dfVFZfU1VQUE9SVD15CkNPTkZJR19NRURJQV9ESUdJVEFM X1RWX1NVUFBPUlQ9eQpDT05GSUdfTUVESUFfUkFESU9fU1VQUE9SVD15CiMgQ09ORklHX01F RElBX1NEUl9TVVBQT1JUIGlzIG5vdCBzZXQKQ09ORklHX01FRElBX1BMQVRGT1JNX1NVUFBP UlQ9eQpDT05GSUdfTUVESUFfVEVTVF9TVVBQT1JUPXkKIyBlbmQgb2YgTWVkaWEgZGV2aWNl IHR5cGVzCgpDT05GSUdfVklERU9fREVWPW0KQ09ORklHX01FRElBX0NPTlRST0xMRVI9eQpD T05GSUdfRFZCX0NPUkU9bQoKIwojIFZpZGVvNExpbnV4IG9wdGlvbnMKIwpDT05GSUdfVklE RU9fVjRMMj1tCkNPTkZJR19WSURFT19WNEwyX0kyQz15CkNPTkZJR19WSURFT19WNEwyX1NV QkRFVl9BUEk9eQojIENPTkZJR19WSURFT19BRFZfREVCVUcgaXMgbm90IHNldAojIENPTkZJ R19WSURFT19GSVhFRF9NSU5PUl9SQU5HRVMgaXMgbm90IHNldApDT05GSUdfVklERU9fVFVO RVI9bQpDT05GSUdfVjRMMl9NRU0yTUVNX0RFVj1tCkNPTkZJR19WNEwyX0ZMQVNIX0xFRF9D TEFTUz1tCkNPTkZJR19WNEwyX0ZXTk9ERT1tCkNPTkZJR19WSURFT0JVRl9HRU49bQpDT05G SUdfVklERU9CVUZfRE1BX1NHPW0KQ09ORklHX1ZJREVPQlVGX1ZNQUxMT0M9bQojIGVuZCBv ZiBWaWRlbzRMaW51eCBvcHRpb25zCgojCiMgTWVkaWEgY29udHJvbGxlciBvcHRpb25zCiMK Q09ORklHX01FRElBX0NPTlRST0xMRVJfRFZCPXkKQ09ORklHX01FRElBX0NPTlRST0xMRVJf UkVRVUVTVF9BUEk9eQoKIwojIFBsZWFzZSBub3RpY2UgdGhhdCB0aGUgZW5hYmxlZCBNZWRp YSBjb250cm9sbGVyIFJlcXVlc3QgQVBJIGlzIEVYUEVSSU1FTlRBTAojCiMgZW5kIG9mIE1l ZGlhIGNvbnRyb2xsZXIgb3B0aW9ucwoKIwojIERpZ2l0YWwgVFYgb3B0aW9ucwojCkNPTkZJ R19EVkJfTU1BUD15CkNPTkZJR19EVkJfTkVUPXkKQ09ORklHX0RWQl9NQVhfQURBUFRFUlM9 MTYKQ09ORklHX0RWQl9EWU5BTUlDX01JTk9SUz15CiMgQ09ORklHX0RWQl9ERU1VWF9TRUNU SU9OX0xPU1NfTE9HIGlzIG5vdCBzZXQKIyBDT05GSUdfRFZCX1VMRV9ERUJVRyBpcyBub3Qg c2V0CiMgZW5kIG9mIERpZ2l0YWwgVFYgb3B0aW9ucwoKIwojIE1lZGlhIGRyaXZlcnMKIwoK IwojIERyaXZlcnMgZmlsdGVyZWQgYXMgc2VsZWN0ZWQgYXQgJ0ZpbHRlciBtZWRpYSBkcml2 ZXJzJwojCkNPTkZJR19UVFBDSV9FRVBST009bQpDT05GSUdfTUVESUFfVVNCX1NVUFBPUlQ9 eQoKIwojIFdlYmNhbSBkZXZpY2VzCiMKQ09ORklHX1VTQl9WSURFT19DTEFTUz1tCkNPTkZJ R19VU0JfVklERU9fQ0xBU1NfSU5QVVRfRVZERVY9eQpDT05GSUdfVVNCX0dTUENBPW0KQ09O RklHX1VTQl9NNTYwMj1tCkNPTkZJR19VU0JfU1RWMDZYWD1tCkNPTkZJR19VU0JfR0w4NjA9 bQpDT05GSUdfVVNCX0dTUENBX0JFTlE9bQpDT05GSUdfVVNCX0dTUENBX0NPTkVYPW0KQ09O RklHX1VTQl9HU1BDQV9DUElBMT1tCkNPTkZJR19VU0JfR1NQQ0FfRFRDUzAzMz1tCkNPTkZJ R19VU0JfR1NQQ0FfRVRPTVM9bQpDT05GSUdfVVNCX0dTUENBX0ZJTkVQSVg9bQpDT05GSUdf VVNCX0dTUENBX0pFSUxJTko9bQpDT05GSUdfVVNCX0dTUENBX0pMMjAwNUJDRD1tCkNPTkZJ R19VU0JfR1NQQ0FfS0lORUNUPW0KQ09ORklHX1VTQl9HU1BDQV9LT05JQ0E9bQpDT05GSUdf VVNCX0dTUENBX01BUlM9bQpDT05GSUdfVVNCX0dTUENBX01SOTczMTBBPW0KQ09ORklHX1VT Ql9HU1BDQV9OVzgwWD1tCkNPTkZJR19VU0JfR1NQQ0FfT1Y1MTk9bQpDT05GSUdfVVNCX0dT UENBX09WNTM0PW0KQ09ORklHX1VTQl9HU1BDQV9PVjUzNF85PW0KQ09ORklHX1VTQl9HU1BD QV9QQUMyMDc9bQpDT05GSUdfVVNCX0dTUENBX1BBQzczMDI9bQpDT05GSUdfVVNCX0dTUENB X1BBQzczMTE9bQpDT05GSUdfVVNCX0dTUENBX1NFNDAxPW0KQ09ORklHX1VTQl9HU1BDQV9T TjlDMjAyOD1tCkNPTkZJR19VU0JfR1NQQ0FfU045QzIwWD1tCkNPTkZJR19VU0JfR1NQQ0Ff U09OSVhCPW0KQ09ORklHX1VTQl9HU1BDQV9TT05JWEo9bQpDT05GSUdfVVNCX0dTUENBX1NQ Q0E1MDA9bQpDT05GSUdfVVNCX0dTUENBX1NQQ0E1MDE9bQpDT05GSUdfVVNCX0dTUENBX1NQ Q0E1MDU9bQpDT05GSUdfVVNCX0dTUENBX1NQQ0E1MDY9bQpDT05GSUdfVVNCX0dTUENBX1NQ Q0E1MDg9bQpDT05GSUdfVVNCX0dTUENBX1NQQ0E1NjE9bQpDT05GSUdfVVNCX0dTUENBX1NQ Q0ExNTI4PW0KQ09ORklHX1VTQl9HU1BDQV9TUTkwNT1tCkNPTkZJR19VU0JfR1NQQ0FfU1E5 MDVDPW0KQ09ORklHX1VTQl9HU1BDQV9TUTkzMFg9bQpDT05GSUdfVVNCX0dTUENBX1NUSzAx ND1tCkNPTkZJR19VU0JfR1NQQ0FfU1RLMTEzNT1tCkNPTkZJR19VU0JfR1NQQ0FfU1RWMDY4 MD1tCkNPTkZJR19VU0JfR1NQQ0FfU1VOUExVUz1tCkNPTkZJR19VU0JfR1NQQ0FfVDYxMz1t CkNPTkZJR19VU0JfR1NQQ0FfVE9QUk89bQpDT05GSUdfVVNCX0dTUENBX1RPVVBURUs9bQpD T05GSUdfVVNCX0dTUENBX1RWODUzMj1tCkNPTkZJR19VU0JfR1NQQ0FfVkMwMzJYPW0KQ09O RklHX1VTQl9HU1BDQV9WSUNBTT1tCkNPTkZJR19VU0JfR1NQQ0FfWElSTElOS19DSVQ9bQpD T05GSUdfVVNCX0dTUENBX1pDM1hYPW0KQ09ORklHX1VTQl9QV0M9bQojIENPTkZJR19VU0Jf UFdDX0RFQlVHIGlzIG5vdCBzZXQKQ09ORklHX1VTQl9QV0NfSU5QVVRfRVZERVY9eQpDT05G SUdfVklERU9fQ1BJQTI9bQpDT05GSUdfVVNCX1pSMzY0WFg9bQpDT05GSUdfVVNCX1NUS1dF QkNBTT1tCkNPTkZJR19VU0JfUzIyNTU9bQpDT05GSUdfVklERU9fVVNCVFY9bQoKIwojIEFu YWxvZyBUViBVU0IgZGV2aWNlcwojCkNPTkZJR19WSURFT19QVlJVU0IyPW0KQ09ORklHX1ZJ REVPX1BWUlVTQjJfU1lTRlM9eQpDT05GSUdfVklERU9fUFZSVVNCMl9EVkI9eQojIENPTkZJ R19WSURFT19QVlJVU0IyX0RFQlVHSUZDIGlzIG5vdCBzZXQKQ09ORklHX1ZJREVPX0hEUFZS PW0KQ09ORklHX1ZJREVPX1NUSzExNjBfQ09NTU9OPW0KQ09ORklHX1ZJREVPX1NUSzExNjA9 bQpDT05GSUdfVklERU9fR083MDA3PW0KQ09ORklHX1ZJREVPX0dPNzAwN19VU0I9bQpDT05G SUdfVklERU9fR083MDA3X0xPQURFUj1tCkNPTkZJR19WSURFT19HTzcwMDdfVVNCX1MyMjUw X0JPQVJEPW0KCiMKIyBBbmFsb2cvZGlnaXRhbCBUViBVU0IgZGV2aWNlcwojCkNPTkZJR19W SURFT19BVTA4Mjg9bQpDT05GSUdfVklERU9fQVUwODI4X1Y0TDI9eQpDT05GSUdfVklERU9f QVUwODI4X1JDPXkKQ09ORklHX1ZJREVPX0NYMjMxWFg9bQpDT05GSUdfVklERU9fQ1gyMzFY WF9SQz15CkNPTkZJR19WSURFT19DWDIzMVhYX0FMU0E9bQpDT05GSUdfVklERU9fQ1gyMzFY WF9EVkI9bQpDT05GSUdfVklERU9fVE02MDAwPW0KQ09ORklHX1ZJREVPX1RNNjAwMF9BTFNB PW0KQ09ORklHX1ZJREVPX1RNNjAwMF9EVkI9bQoKIwojIERpZ2l0YWwgVFYgVVNCIGRldmlj ZXMKIwpDT05GSUdfRFZCX1VTQj1tCiMgQ09ORklHX0RWQl9VU0JfREVCVUcgaXMgbm90IHNl dApDT05GSUdfRFZCX1VTQl9ESUIzMDAwTUM9bQpDT05GSUdfRFZCX1VTQl9BODAwPW0KQ09O RklHX0RWQl9VU0JfRElCVVNCX01CPW0KQ09ORklHX0RWQl9VU0JfRElCVVNCX01CX0ZBVUxU WT15CkNPTkZJR19EVkJfVVNCX0RJQlVTQl9NQz1tCkNPTkZJR19EVkJfVVNCX0RJQjA3MDA9 bQpDT05GSUdfRFZCX1VTQl9VTVRfMDEwPW0KQ09ORklHX0RWQl9VU0JfQ1hVU0I9bQpDT05G SUdfRFZCX1VTQl9DWFVTQl9BTkFMT0c9eQpDT05GSUdfRFZCX1VTQl9NOTIwWD1tCkNPTkZJ R19EVkJfVVNCX0RJR0lUVj1tCkNPTkZJR19EVkJfVVNCX1ZQNzA0NT1tCkNPTkZJR19EVkJf VVNCX1ZQNzAyWD1tCkNPTkZJR19EVkJfVVNCX0dQOFBTSz1tCkNPTkZJR19EVkJfVVNCX05P VkFfVF9VU0IyPW0KQ09ORklHX0RWQl9VU0JfVFRVU0IyPW0KQ09ORklHX0RWQl9VU0JfRFRU MjAwVT1tCkNPTkZJR19EVkJfVVNCX09QRVJBMT1tCkNPTkZJR19EVkJfVVNCX0FGOTAwNT1t CkNPTkZJR19EVkJfVVNCX0FGOTAwNV9SRU1PVEU9bQpDT05GSUdfRFZCX1VTQl9QQ1RWNDUy RT1tCkNPTkZJR19EVkJfVVNCX0RXMjEwMj1tCkNPTkZJR19EVkJfVVNCX0NJTkVSR1lfVDI9 bQpDT05GSUdfRFZCX1VTQl9EVFY1MTAwPW0KQ09ORklHX0RWQl9VU0JfQVo2MDI3PW0KQ09O RklHX0RWQl9VU0JfVEVDSE5JU0FUX1VTQjI9bQpDT05GSUdfRFZCX1VTQl9WMj1tCkNPTkZJ R19EVkJfVVNCX0FGOTAxNT1tCkNPTkZJR19EVkJfVVNCX0FGOTAzNT1tCkNPTkZJR19EVkJf VVNCX0FOWVNFRT1tCkNPTkZJR19EVkJfVVNCX0FVNjYxMD1tCkNPTkZJR19EVkJfVVNCX0Fa NjAwNz1tCkNPTkZJR19EVkJfVVNCX0NFNjIzMD1tCkNPTkZJR19EVkJfVVNCX0VDMTY4PW0K Q09ORklHX0RWQl9VU0JfR0w4NjE9bQpDT05GSUdfRFZCX1VTQl9MTUUyNTEwPW0KQ09ORklH X0RWQl9VU0JfTVhMMTExU0Y9bQpDT05GSUdfRFZCX1VTQl9SVEwyOFhYVT1tCkNPTkZJR19E VkJfVVNCX0RWQlNLWT1tCkNPTkZJR19EVkJfVVNCX1pEMTMwMT1tCkNPTkZJR19EVkJfVFRV U0JfQlVER0VUPW0KQ09ORklHX0RWQl9UVFVTQl9ERUM9bQpDT05GSUdfU01TX1VTQl9EUlY9 bQpDT05GSUdfRFZCX0IyQzJfRkxFWENPUF9VU0I9bQojIENPTkZJR19EVkJfQjJDMl9GTEVY Q09QX1VTQl9ERUJVRyBpcyBub3Qgc2V0CkNPTkZJR19EVkJfQVMxMDI9bQoKIwojIFdlYmNh bSwgVFYgKGFuYWxvZy9kaWdpdGFsKSBVU0IgZGV2aWNlcwojCkNPTkZJR19WSURFT19FTTI4 WFg9bQpDT05GSUdfVklERU9fRU0yOFhYX1Y0TDI9bQpDT05GSUdfVklERU9fRU0yOFhYX0FM U0E9bQpDT05GSUdfVklERU9fRU0yOFhYX0RWQj1tCkNPTkZJR19WSURFT19FTTI4WFhfUkM9 bQpDT05GSUdfTUVESUFfUENJX1NVUFBPUlQ9eQoKIwojIE1lZGlhIGNhcHR1cmUgc3VwcG9y dAojCkNPTkZJR19WSURFT19NRVlFPW0KQ09ORklHX1ZJREVPX1NPTE82WDEwPW0KQ09ORklH X1ZJREVPX1RXNTg2ND1tCkNPTkZJR19WSURFT19UVzY4PW0KQ09ORklHX1ZJREVPX1RXNjg2 WD1tCgojCiMgTWVkaWEgY2FwdHVyZS9hbmFsb2cgVFYgc3VwcG9ydAojCkNPTkZJR19WSURF T19JVlRWPW0KIyBDT05GSUdfVklERU9fSVZUVl9ERVBSRUNBVEVEX0lPQ1RMUyBpcyBub3Qg c2V0CkNPTkZJR19WSURFT19JVlRWX0FMU0E9bQpDT05GSUdfVklERU9fRkJfSVZUVj1tCiMg Q09ORklHX1ZJREVPX0ZCX0lWVFZfRk9SQ0VfUEFUIGlzIG5vdCBzZXQKQ09ORklHX1ZJREVP X0hFWElVTV9HRU1JTkk9bQpDT05GSUdfVklERU9fSEVYSVVNX09SSU9OPW0KQ09ORklHX1ZJ REVPX01YQj1tCkNPTkZJR19WSURFT19EVDMxNTU9bQoKIwojIE1lZGlhIGNhcHR1cmUvYW5h bG9nL2h5YnJpZCBUViBzdXBwb3J0CiMKQ09ORklHX1ZJREVPX0NYMTg9bQpDT05GSUdfVklE RU9fQ1gxOF9BTFNBPW0KQ09ORklHX1ZJREVPX0NYMjM4ODU9bQpDT05GSUdfTUVESUFfQUxU RVJBX0NJPW0KQ09ORklHX1ZJREVPX0NYMjU4MjE9bQpDT05GSUdfVklERU9fQ1gyNTgyMV9B TFNBPW0KQ09ORklHX1ZJREVPX0NYODg9bQpDT05GSUdfVklERU9fQ1g4OF9BTFNBPW0KQ09O RklHX1ZJREVPX0NYODhfQkxBQ0tCSVJEPW0KQ09ORklHX1ZJREVPX0NYODhfRFZCPW0KQ09O RklHX1ZJREVPX0NYODhfRU5BQkxFX1ZQMzA1ND15CkNPTkZJR19WSURFT19DWDg4X1ZQMzA1 ND1tCkNPTkZJR19WSURFT19DWDg4X01QRUc9bQpDT05GSUdfVklERU9fQlQ4NDg9bQpDT05G SUdfRFZCX0JUOFhYPW0KQ09ORklHX1ZJREVPX1NBQTcxMzQ9bQpDT05GSUdfVklERU9fU0FB NzEzNF9BTFNBPW0KQ09ORklHX1ZJREVPX1NBQTcxMzRfUkM9eQpDT05GSUdfVklERU9fU0FB NzEzNF9EVkI9bQpDT05GSUdfVklERU9fU0FBNzEzNF9HTzcwMDc9bQpDT05GSUdfVklERU9f U0FBNzE2ND1tCgojCiMgTWVkaWEgZGlnaXRhbCBUViBQQ0kgQWRhcHRlcnMKIwpDT05GSUdf RFZCX0FWNzExMF9JUj15CkNPTkZJR19EVkJfQVY3MTEwPW0KQ09ORklHX0RWQl9BVjcxMTBf T1NEPXkKQ09ORklHX0RWQl9CVURHRVRfQ09SRT1tCkNPTkZJR19EVkJfQlVER0VUPW0KQ09O RklHX0RWQl9CVURHRVRfQ0k9bQpDT05GSUdfRFZCX0JVREdFVF9BVj1tCkNPTkZJR19EVkJf QlVER0VUX1BBVENIPW0KQ09ORklHX0RWQl9CMkMyX0ZMRVhDT1BfUENJPW0KIyBDT05GSUdf RFZCX0IyQzJfRkxFWENPUF9QQ0lfREVCVUcgaXMgbm90IHNldApDT05GSUdfRFZCX1BMVVRP Mj1tCkNPTkZJR19EVkJfRE0xMTA1PW0KQ09ORklHX0RWQl9QVDE9bQpDT05GSUdfRFZCX1BU Mz1tCkNPTkZJR19NQU5USVNfQ09SRT1tCkNPTkZJR19EVkJfTUFOVElTPW0KQ09ORklHX0RW Ql9IT1BQRVI9bQpDT05GSUdfRFZCX05HRU5FPW0KQ09ORklHX0RWQl9EREJSSURHRT1tCiMg Q09ORklHX0RWQl9EREJSSURHRV9NU0lFTkFCTEUgaXMgbm90IHNldApDT05GSUdfRFZCX1NN SVBDSUU9bQpDT05GSUdfRFZCX05FVFVQX1VOSURWQj1tCkNPTkZJR19WSURFT19JUFUzX0NJ TzI9bQpDT05GSUdfQ0lPMl9CUklER0U9eQpDT05GSUdfUkFESU9fQURBUFRFUlM9eQpDT05G SUdfUkFESU9fVEVBNTc1WD1tCkNPTkZJR19SQURJT19TSTQ3MFg9bQpDT05GSUdfVVNCX1NJ NDcwWD1tCkNPTkZJR19JMkNfU0k0NzBYPW0KQ09ORklHX1JBRElPX1NJNDcxMz1tCkNPTkZJ R19VU0JfU0k0NzEzPW0KQ09ORklHX1BMQVRGT1JNX1NJNDcxMz1tCkNPTkZJR19JMkNfU0k0 NzEzPW0KQ09ORklHX1JBRElPX1NJNDc2WD1tCkNPTkZJR19VU0JfTVI4MDA9bQpDT05GSUdf VVNCX0RTQlI9bQpDT05GSUdfUkFESU9fTUFYSVJBRElPPW0KQ09ORklHX1JBRElPX1NIQVJL PW0KQ09ORklHX1JBRElPX1NIQVJLMj1tCkNPTkZJR19VU0JfS0VFTkU9bQpDT05GSUdfVVNC X1JBUkVNT05PPW0KQ09ORklHX1VTQl9NQTkwMT1tCkNPTkZJR19SQURJT19URUE1NzY0PW0K Q09ORklHX1JBRElPX1NBQTc3MDZIPW0KQ09ORklHX1JBRElPX1RFRjY4NjI9bQpDT05GSUdf UkFESU9fV0wxMjczPW0KQ09ORklHX1JBRElPX1dMMTI4WD1tCkNPTkZJR19NRURJQV9DT01N T05fT1BUSU9OUz15CgojCiMgY29tbW9uIGRyaXZlciBvcHRpb25zCiMKQ09ORklHX1ZJREVP X0NYMjM0MVg9bQpDT05GSUdfVklERU9fVFZFRVBST009bQpDT05GSUdfQ1lQUkVTU19GSVJN V0FSRT1tCkNPTkZJR19WSURFT0JVRjJfQ09SRT1tCkNPTkZJR19WSURFT0JVRjJfVjRMMj1t CkNPTkZJR19WSURFT0JVRjJfTUVNT1BTPW0KQ09ORklHX1ZJREVPQlVGMl9ETUFfQ09OVElH PW0KQ09ORklHX1ZJREVPQlVGMl9WTUFMTE9DPW0KQ09ORklHX1ZJREVPQlVGMl9ETUFfU0c9 bQpDT05GSUdfVklERU9CVUYyX0RWQj1tCkNPTkZJR19EVkJfQjJDMl9GTEVYQ09QPW0KQ09O RklHX1ZJREVPX1NBQTcxNDY9bQpDT05GSUdfVklERU9fU0FBNzE0Nl9WVj1tCkNPTkZJR19T TVNfU0lBTk9fTURUVj1tCkNPTkZJR19TTVNfU0lBTk9fUkM9eQojIENPTkZJR19TTVNfU0lB Tk9fREVCVUdGUyBpcyBub3Qgc2V0CkNPTkZJR19WSURFT19WNEwyX1RQRz1tCkNPTkZJR19W NExfUExBVEZPUk1fRFJJVkVSUz15CkNPTkZJR19WSURFT19DQUZFX0NDSUM9bQpDT05GSUdf VklERU9fQ0FERU5DRT15CkNPTkZJR19WSURFT19DQURFTkNFX0NTSTJSWD1tCkNPTkZJR19W SURFT19DQURFTkNFX0NTSTJUWD1tCkNPTkZJR19WSURFT19BU1BFRUQ9bQpDT05GSUdfVjRM X01FTTJNRU1fRFJJVkVSUz15CkNPTkZJR19WSURFT19NRU0yTUVNX0RFSU5URVJMQUNFPW0K Q09ORklHX0RWQl9QTEFURk9STV9EUklWRVJTPXkKCiMKIyBNTUMvU0RJTyBEVkIgYWRhcHRl cnMKIwpDT05GSUdfU01TX1NESU9fRFJWPW0KQ09ORklHX1Y0TF9URVNUX0RSSVZFUlM9eQpD T05GSUdfVklERU9fVklNQz1tCkNPTkZJR19WSURFT19WSVZJRD1tCkNPTkZJR19WSURFT19W SVZJRF9DRUM9eQpDT05GSUdfVklERU9fVklWSURfTUFYX0RFVlM9NjQKQ09ORklHX1ZJREVP X1ZJTTJNPW0KQ09ORklHX1ZJREVPX1ZJQ09ERUM9bQpDT05GSUdfRFZCX1RFU1RfRFJJVkVS Uz15CkNPTkZJR19EVkJfVklEVFY9bQoKIwojIEZpcmVXaXJlIChJRUVFIDEzOTQpIEFkYXB0 ZXJzCiMKQ09ORklHX0RWQl9GSVJFRFRWPW0KQ09ORklHX0RWQl9GSVJFRFRWX0lOUFVUPXkK IyBlbmQgb2YgTWVkaWEgZHJpdmVycwoKQ09ORklHX01FRElBX0hJREVfQU5DSUxMQVJZX1NV QkRSVj15CgojCiMgTWVkaWEgYW5jaWxsYXJ5IGRyaXZlcnMKIwpDT05GSUdfTUVESUFfQVRU QUNIPXkKCiMKIyBJUiBJMkMgZHJpdmVyIGF1dG8tc2VsZWN0ZWQgYnkgJ0F1dG9zZWxlY3Qg YW5jaWxsYXJ5IGRyaXZlcnMnCiMKQ09ORklHX1ZJREVPX0lSX0kyQz1tCgojCiMgYXVkaW8s IHZpZGVvIGFuZCByYWRpbyBJMkMgZHJpdmVycyBhdXRvLXNlbGVjdGVkIGJ5ICdBdXRvc2Vs ZWN0IGFuY2lsbGFyeSBkcml2ZXJzJwojCkNPTkZJR19WSURFT19UVkFVRElPPW0KQ09ORklH X1ZJREVPX1REQTc0MzI9bQpDT05GSUdfVklERU9fVERBOTg0MD1tCkNPTkZJR19WSURFT19U RUE2NDE1Qz1tCkNPTkZJR19WSURFT19URUE2NDIwPW0KQ09ORklHX1ZJREVPX01TUDM0MDA9 bQpDT05GSUdfVklERU9fQ1MzMzA4PW0KQ09ORklHX1ZJREVPX0NTNTM0NT1tCkNPTkZJR19W SURFT19DUzUzTDMyQT1tCkNPTkZJR19WSURFT19VREExMzQyPW0KQ09ORklHX1ZJREVPX1dN ODc3NT1tCkNPTkZJR19WSURFT19XTTg3Mzk9bQpDT05GSUdfVklERU9fVlAyN1NNUFg9bQpD T05GSUdfVklERU9fU09OWV9CVEZfTVBYPW0KQ09ORklHX1ZJREVPX1NBQTY1ODg9bQpDT05G SUdfVklERU9fU0FBNzExWD1tCkNPTkZJR19WSURFT19UVlA1MTUwPW0KQ09ORklHX1ZJREVP X1RXMjgwND1tCkNPTkZJR19WSURFT19UVzk5MDM9bQpDT05GSUdfVklERU9fVFc5OTA2PW0K CiMKIyBWaWRlbyBhbmQgYXVkaW8gZGVjb2RlcnMKIwpDT05GSUdfVklERU9fU0FBNzE3WD1t CkNPTkZJR19WSURFT19DWDI1ODQwPW0KQ09ORklHX1ZJREVPX1NBQTcxMjc9bQpDT05GSUdf VklERU9fVVBENjQwMzFBPW0KQ09ORklHX1ZJREVPX1VQRDY0MDgzPW0KQ09ORklHX1ZJREVP X1NBQTY3NTJIUz1tCkNPTkZJR19WSURFT19NNTI3OTA9bQoKIwojIENhbWVyYSBzZW5zb3Ig ZGV2aWNlcwojCkNPTkZJR19WSURFT19BUFRJTkFfUExMPW0KQ09ORklHX1ZJREVPX0NDU19Q TEw9bQpDT05GSUdfVklERU9fSEk1NTY9bQpDT05GSUdfVklERU9fSU1YMjE0PW0KQ09ORklH X1ZJREVPX0lNWDIxOT1tCkNPTkZJR19WSURFT19JTVgyNTg9bQpDT05GSUdfVklERU9fSU1Y Mjc0PW0KQ09ORklHX1ZJREVPX0lNWDI5MD1tCkNPTkZJR19WSURFT19JTVgzMTk9bQpDT05G SUdfVklERU9fSU1YMzU1PW0KQ09ORklHX1ZJREVPX09WMDJBMTA9bQpDT05GSUdfVklERU9f T1YyNjQwPW0KQ09ORklHX1ZJREVPX09WMjY1OT1tCkNPTkZJR19WSURFT19PVjI2ODA9bQpD T05GSUdfVklERU9fT1YyNjg1PW0KQ09ORklHX1ZJREVPX09WMjc0MD1tCkNPTkZJR19WSURF T19PVjU2NDc9bQpDT05GSUdfVklERU9fT1Y1NjQ4PW0KQ09ORklHX1ZJREVPX09WNjY1MD1t CkNPTkZJR19WSURFT19PVjU2NzA9bQpDT05GSUdfVklERU9fT1Y1Njc1PW0KQ09ORklHX1ZJ REVPX09WNTY5NT1tCkNPTkZJR19WSURFT19PVjcyNTE9bQpDT05GSUdfVklERU9fT1Y3NzJY PW0KQ09ORklHX1ZJREVPX09WNzY0MD1tCkNPTkZJR19WSURFT19PVjc2NzA9bQpDT05GSUdf VklERU9fT1Y3NzQwPW0KQ09ORklHX1ZJREVPX09WODg1Nj1tCkNPTkZJR19WSURFT19PVjg4 NjU9bQpDT05GSUdfVklERU9fT1Y5NjQwPW0KQ09ORklHX1ZJREVPX09WOTY1MD1tCkNPTkZJ R19WSURFT19PVjk3MzQ9bQpDT05GSUdfVklERU9fT1YxMzg1OD1tCkNPTkZJR19WSURFT19W UzY2MjQ9bQpDT05GSUdfVklERU9fTVQ5TTAwMT1tCkNPTkZJR19WSURFT19NVDlNMDMyPW0K Q09ORklHX1ZJREVPX01UOU0xMTE9bQpDT05GSUdfVklERU9fTVQ5UDAzMT1tCkNPTkZJR19W SURFT19NVDlUMDAxPW0KQ09ORklHX1ZJREVPX01UOVQxMTI9bQpDT05GSUdfVklERU9fTVQ5 VjAxMT1tCkNPTkZJR19WSURFT19NVDlWMDMyPW0KQ09ORklHX1ZJREVPX01UOVYxMTE9bQpD T05GSUdfVklERU9fU1IwMzBQQzMwPW0KQ09ORklHX1ZJREVPX05PT04wMTBQQzMwPW0KQ09O RklHX1ZJREVPX001TU9MUz1tCkNPTkZJR19WSURFT19NQVg5MjcxX0xJQj1tCkNPTkZJR19W SURFT19SREFDTTIwPW0KQ09ORklHX1ZJREVPX1JEQUNNMjE9bQpDT05GSUdfVklERU9fUko1 NE4xPW0KQ09ORklHX1ZJREVPX1M1SzZBQT1tCkNPTkZJR19WSURFT19TNUs2QTM9bQpDT05G SUdfVklERU9fUzVLNEVDR1g9bQpDT05GSUdfVklERU9fUzVLNUJBRj1tCkNPTkZJR19WSURF T19DQ1M9bQpDT05GSUdfVklERU9fRVQ4RUs4PW0KQ09ORklHX1ZJREVPX1M1QzczTTM9bQoj IGVuZCBvZiBDYW1lcmEgc2Vuc29yIGRldmljZXMKCiMKIyBMZW5zIGRyaXZlcnMKIwpDT05G SUdfVklERU9fQUQ1ODIwPW0KQ09ORklHX1ZJREVPX0FLNzM3NT1tCkNPTkZJR19WSURFT19E Vzk3MTQ9bQpDT05GSUdfVklERU9fRFc5NzY4PW0KQ09ORklHX1ZJREVPX0RXOTgwN19WQ009 bQojIGVuZCBvZiBMZW5zIGRyaXZlcnMKCiMKIyBGbGFzaCBkZXZpY2VzCiMKQ09ORklHX1ZJ REVPX0FEUDE2NTM9bQpDT05GSUdfVklERU9fTE0zNTYwPW0KQ09ORklHX1ZJREVPX0xNMzY0 Nj1tCiMgZW5kIG9mIEZsYXNoIGRldmljZXMKCiMKIyBTUEkgSTJDIGRyaXZlcnMgYXV0by1z ZWxlY3RlZCBieSAnQXV0b3NlbGVjdCBhbmNpbGxhcnkgZHJpdmVycycKIwoKIwojIE1lZGlh IFNQSSBBZGFwdGVycwojCkNPTkZJR19DWEQyODgwX1NQSV9EUlY9bQojIGVuZCBvZiBNZWRp YSBTUEkgQWRhcHRlcnMKCkNPTkZJR19NRURJQV9UVU5FUj1tCgojCiMgVHVuZXIgZHJpdmVy cyBhdXRvLXNlbGVjdGVkIGJ5ICdBdXRvc2VsZWN0IGFuY2lsbGFyeSBkcml2ZXJzJwojCkNP TkZJR19NRURJQV9UVU5FUl9TSU1QTEU9bQpDT05GSUdfTUVESUFfVFVORVJfVERBMTgyNTA9 bQpDT05GSUdfTUVESUFfVFVORVJfVERBODI5MD1tCkNPTkZJR19NRURJQV9UVU5FUl9UREE4 MjdYPW0KQ09ORklHX01FRElBX1RVTkVSX1REQTE4MjcxPW0KQ09ORklHX01FRElBX1RVTkVS X1REQTk4ODc9bQpDT05GSUdfTUVESUFfVFVORVJfVEVBNTc2MT1tCkNPTkZJR19NRURJQV9U VU5FUl9URUE1NzY3PW0KQ09ORklHX01FRElBX1RVTkVSX01UMjBYWD1tCkNPTkZJR19NRURJ QV9UVU5FUl9NVDIwNjA9bQpDT05GSUdfTUVESUFfVFVORVJfTVQyMDYzPW0KQ09ORklHX01F RElBX1RVTkVSX01UMjI2Nj1tCkNPTkZJR19NRURJQV9UVU5FUl9NVDIxMzE9bQpDT05GSUdf TUVESUFfVFVORVJfUVQxMDEwPW0KQ09ORklHX01FRElBX1RVTkVSX1hDMjAyOD1tCkNPTkZJ R19NRURJQV9UVU5FUl9YQzUwMDA9bQpDT05GSUdfTUVESUFfVFVORVJfWEM0MDAwPW0KQ09O RklHX01FRElBX1RVTkVSX01YTDUwMDVTPW0KQ09ORklHX01FRElBX1RVTkVSX01YTDUwMDdU PW0KQ09ORklHX01FRElBX1RVTkVSX01DNDRTODAzPW0KQ09ORklHX01FRElBX1RVTkVSX01B WDIxNjU9bQpDT05GSUdfTUVESUFfVFVORVJfVERBMTgyMTg9bQpDT05GSUdfTUVESUFfVFVO RVJfRkMwMDExPW0KQ09ORklHX01FRElBX1RVTkVSX0ZDMDAxMj1tCkNPTkZJR19NRURJQV9U VU5FUl9GQzAwMTM9bQpDT05GSUdfTUVESUFfVFVORVJfVERBMTgyMTI9bQpDT05GSUdfTUVE SUFfVFVORVJfRTQwMDA9bQpDT05GSUdfTUVESUFfVFVORVJfRkMyNTgwPW0KQ09ORklHX01F RElBX1RVTkVSX004OFJTNjAwMFQ9bQpDT05GSUdfTUVESUFfVFVORVJfVFVBOTAwMT1tCkNP TkZJR19NRURJQV9UVU5FUl9TSTIxNTc9bQpDT05GSUdfTUVESUFfVFVORVJfSVQ5MTNYPW0K Q09ORklHX01FRElBX1RVTkVSX1I4MjBUPW0KQ09ORklHX01FRElBX1RVTkVSX01YTDMwMVJG PW0KQ09ORklHX01FRElBX1RVTkVSX1FNMUQxQzAwNDI9bQpDT05GSUdfTUVESUFfVFVORVJf UU0xRDFCMDAwND1tCgojCiMgRFZCIEZyb250ZW5kIGRyaXZlcnMgYXV0by1zZWxlY3RlZCBi eSAnQXV0b3NlbGVjdCBhbmNpbGxhcnkgZHJpdmVycycKIwoKIwojIE11bHRpc3RhbmRhcmQg KHNhdGVsbGl0ZSkgZnJvbnRlbmRzCiMKQ09ORklHX0RWQl9TVEIwODk5PW0KQ09ORklHX0RW Ql9TVEI2MTAwPW0KQ09ORklHX0RWQl9TVFYwOTB4PW0KQ09ORklHX0RWQl9TVFYwOTEwPW0K Q09ORklHX0RWQl9TVFY2MTEweD1tCkNPTkZJR19EVkJfU1RWNjExMT1tCkNPTkZJR19EVkJf TVhMNVhYPW0KQ09ORklHX0RWQl9NODhEUzMxMDM9bQoKIwojIE11bHRpc3RhbmRhcmQgKGNh YmxlICsgdGVycmVzdHJpYWwpIGZyb250ZW5kcwojCkNPTkZJR19EVkJfRFJYSz1tCkNPTkZJ R19EVkJfVERBMTgyNzFDMkREPW0KQ09ORklHX0RWQl9TSTIxNjU9bQpDT05GSUdfRFZCX01O ODg0NzI9bQpDT05GSUdfRFZCX01OODg0NzM9bQoKIwojIERWQi1TIChzYXRlbGxpdGUpIGZy b250ZW5kcwojCkNPTkZJR19EVkJfQ1gyNDExMD1tCkNPTkZJR19EVkJfQ1gyNDEyMz1tCkNP TkZJR19EVkJfTVQzMTI9bQpDT05GSUdfRFZCX1pMMTAwMzY9bQpDT05GSUdfRFZCX1pMMTAw Mzk9bQpDT05GSUdfRFZCX1M1SDE0MjA9bQpDT05GSUdfRFZCX1NUVjAyODg9bQpDT05GSUdf RFZCX1NUQjYwMDA9bQpDT05GSUdfRFZCX1NUVjAyOTk9bQpDT05GSUdfRFZCX1NUVjYxMTA9 bQpDT05GSUdfRFZCX1NUVjA5MDA9bQpDT05GSUdfRFZCX1REQTgwODM9bQpDT05GSUdfRFZC X1REQTEwMDg2PW0KQ09ORklHX0RWQl9UREE4MjYxPW0KQ09ORklHX0RWQl9WRVMxWDkzPW0K Q09ORklHX0RWQl9UVU5FUl9JVEQxMDAwPW0KQ09ORklHX0RWQl9UVU5FUl9DWDI0MTEzPW0K Q09ORklHX0RWQl9UREE4MjZYPW0KQ09ORklHX0RWQl9UVUE2MTAwPW0KQ09ORklHX0RWQl9D WDI0MTE2PW0KQ09ORklHX0RWQl9DWDI0MTE3PW0KQ09ORklHX0RWQl9DWDI0MTIwPW0KQ09O RklHX0RWQl9TSTIxWFg9bQpDT05GSUdfRFZCX1RTMjAyMD1tCkNPTkZJR19EVkJfRFMzMDAw PW0KQ09ORklHX0RWQl9NQjg2QTE2PW0KQ09ORklHX0RWQl9UREExMDA3MT1tCgojCiMgRFZC LVQgKHRlcnJlc3RyaWFsKSBmcm9udGVuZHMKIwpDT05GSUdfRFZCX1NQODg3MD1tCkNPTkZJ R19EVkJfU1A4ODdYPW0KQ09ORklHX0RWQl9DWDIyNzAwPW0KQ09ORklHX0RWQl9DWDIyNzAy PW0KQ09ORklHX0RWQl9EUlhEPW0KQ09ORklHX0RWQl9MNjQ3ODE9bQpDT05GSUdfRFZCX1RE QTEwMDRYPW0KQ09ORklHX0RWQl9OWFQ2MDAwPW0KQ09ORklHX0RWQl9NVDM1Mj1tCkNPTkZJ R19EVkJfWkwxMDM1Mz1tCkNPTkZJR19EVkJfRElCMzAwME1CPW0KQ09ORklHX0RWQl9ESUIz MDAwTUM9bQpDT05GSUdfRFZCX0RJQjcwMDBNPW0KQ09ORklHX0RWQl9ESUI3MDAwUD1tCkNP TkZJR19EVkJfVERBMTAwNDg9bQpDT05GSUdfRFZCX0FGOTAxMz1tCkNPTkZJR19EVkJfRUMx MDA9bQpDT05GSUdfRFZCX1NUVjAzNjc9bQpDT05GSUdfRFZCX0NYRDI4MjBSPW0KQ09ORklH X0RWQl9DWEQyODQxRVI9bQpDT05GSUdfRFZCX1JUTDI4MzA9bQpDT05GSUdfRFZCX1JUTDI4 MzI9bQpDT05GSUdfRFZCX1NJMjE2OD1tCkNPTkZJR19EVkJfQVMxMDJfRkU9bQpDT05GSUdf RFZCX1pEMTMwMV9ERU1PRD1tCkNPTkZJR19EVkJfR1A4UFNLX0ZFPW0KCiMKIyBEVkItQyAo Y2FibGUpIGZyb250ZW5kcwojCkNPTkZJR19EVkJfVkVTMTgyMD1tCkNPTkZJR19EVkJfVERB MTAwMjE9bQpDT05GSUdfRFZCX1REQTEwMDIzPW0KQ09ORklHX0RWQl9TVFYwMjk3PW0KCiMK IyBBVFNDIChOb3J0aCBBbWVyaWNhbi9Lb3JlYW4gVGVycmVzdHJpYWwvQ2FibGUgRFRWKSBm cm9udGVuZHMKIwpDT05GSUdfRFZCX05YVDIwMFg9bQpDT05GSUdfRFZCX09SNTEyMTE9bQpD T05GSUdfRFZCX09SNTExMzI9bQpDT05GSUdfRFZCX0JDTTM1MTA9bQpDT05GSUdfRFZCX0xH RFQzMzBYPW0KQ09ORklHX0RWQl9MR0RUMzMwNT1tCkNPTkZJR19EVkJfTEdEVDMzMDZBPW0K Q09ORklHX0RWQl9MRzIxNjA9bQpDT05GSUdfRFZCX1M1SDE0MDk9bQpDT05GSUdfRFZCX0FV ODUyMj1tCkNPTkZJR19EVkJfQVU4NTIyX0RUVj1tCkNPTkZJR19EVkJfQVU4NTIyX1Y0TD1t CkNPTkZJR19EVkJfUzVIMTQxMT1tCkNPTkZJR19EVkJfTVhMNjkyPW0KCiMKIyBJU0RCLVQg KHRlcnJlc3RyaWFsKSBmcm9udGVuZHMKIwpDT05GSUdfRFZCX1M5MjE9bQpDT05GSUdfRFZC X0RJQjgwMDA9bQpDT05GSUdfRFZCX01CODZBMjBTPW0KCiMKIyBJU0RCLVMgKHNhdGVsbGl0 ZSkgJiBJU0RCLVQgKHRlcnJlc3RyaWFsKSBmcm9udGVuZHMKIwpDT05GSUdfRFZCX1RDOTA1 MjI9bQoKIwojIERpZ2l0YWwgdGVycmVzdHJpYWwgb25seSB0dW5lcnMvUExMCiMKQ09ORklH X0RWQl9QTEw9bQpDT05GSUdfRFZCX1RVTkVSX0RJQjAwNzA9bQpDT05GSUdfRFZCX1RVTkVS X0RJQjAwOTA9bQoKIwojIFNFQyBjb250cm9sIGRldmljZXMgZm9yIERWQi1TCiMKQ09ORklH X0RWQl9EUlgzOVhZSj1tCkNPTkZJR19EVkJfTE5CSDI1PW0KQ09ORklHX0RWQl9MTkJQMjE9 bQpDT05GSUdfRFZCX0xOQlAyMj1tCkNPTkZJR19EVkJfSVNMNjQwNT1tCkNPTkZJR19EVkJf SVNMNjQyMT1tCkNPTkZJR19EVkJfSVNMNjQyMz1tCkNPTkZJR19EVkJfQTgyOTM9bQpDT05G SUdfRFZCX0xHUzhHWFg9bQpDT05GSUdfRFZCX0FUQk04ODMwPW0KQ09ORklHX0RWQl9UREE2 NjV4PW0KQ09ORklHX0RWQl9JWDI1MDVWPW0KQ09ORklHX0RWQl9NODhSUzIwMDA9bQpDT05G SUdfRFZCX0FGOTAzMz1tCkNPTkZJR19EVkJfSE9SVVMzQT1tCkNPTkZJR19EVkJfQVNDT1Qy RT1tCkNPTkZJR19EVkJfSEVMRU5FPW0KCiMKIyBDb21tb24gSW50ZXJmYWNlIChFTjUwMjIx KSBjb250cm9sbGVyIGRyaXZlcnMKIwpDT05GSUdfRFZCX0NYRDIwOTk9bQpDT05GSUdfRFZC X1NQMj1tCgojCiMgVG9vbHMgdG8gZGV2ZWxvcCBuZXcgZnJvbnRlbmRzCiMKQ09ORklHX0RW Ql9EVU1NWV9GRT1tCiMgZW5kIG9mIE1lZGlhIGFuY2lsbGFyeSBkcml2ZXJzCgojCiMgR3Jh cGhpY3Mgc3VwcG9ydAojCkNPTkZJR19BR1A9bQpDT05GSUdfQUdQX0FNRDY0PW0KQ09ORklH X0FHUF9JTlRFTD1tCkNPTkZJR19BR1BfU0lTPW0KQ09ORklHX0FHUF9WSUE9bQpDT05GSUdf SU5URUxfR1RUPW0KQ09ORklHX1ZHQV9BUkI9eQpDT05GSUdfVkdBX0FSQl9NQVhfR1BVUz0x MApDT05GSUdfVkdBX1NXSVRDSEVST089eQpDT05GSUdfRFJNPW0KQ09ORklHX0RSTV9NSVBJ X0RCST1tCkNPTkZJR19EUk1fTUlQSV9EU0k9eQpDT05GSUdfRFJNX0RQX0FVWF9DSEFSREVW PXkKIyBDT05GSUdfRFJNX0RFQlVHX1NFTEZURVNUIGlzIG5vdCBzZXQKQ09ORklHX0RSTV9L TVNfSEVMUEVSPW0KQ09ORklHX0RSTV9LTVNfRkJfSEVMUEVSPXkKQ09ORklHX0RSTV9GQkRF Vl9FTVVMQVRJT049eQpDT05GSUdfRFJNX0ZCREVWX09WRVJBTExPQz0xMDAKQ09ORklHX0RS TV9MT0FEX0VESURfRklSTVdBUkU9eQpDT05GSUdfRFJNX0RQX0NFQz15CkNPTkZJR19EUk1f VFRNPW0KQ09ORklHX0RSTV9WUkFNX0hFTFBFUj1tCkNPTkZJR19EUk1fVFRNX0hFTFBFUj1t CkNPTkZJR19EUk1fR0VNX0NNQV9IRUxQRVI9eQpDT05GSUdfRFJNX0tNU19DTUFfSEVMUEVS PXkKQ09ORklHX0RSTV9HRU1fU0hNRU1fSEVMUEVSPXkKQ09ORklHX0RSTV9TQ0hFRD1tCgoj CiMgSTJDIGVuY29kZXIgb3IgaGVscGVyIGNoaXBzCiMKQ09ORklHX0RSTV9JMkNfQ0g3MDA2 PW0KQ09ORklHX0RSTV9JMkNfU0lMMTY0PW0KQ09ORklHX0RSTV9JMkNfTlhQX1REQTk5OFg9 bQpDT05GSUdfRFJNX0kyQ19OWFBfVERBOTk1MD1tCiMgZW5kIG9mIEkyQyBlbmNvZGVyIG9y IGhlbHBlciBjaGlwcwoKIwojIEFSTSBkZXZpY2VzCiMKIyBlbmQgb2YgQVJNIGRldmljZXMK CkNPTkZJR19EUk1fUkFERU9OPW0KQ09ORklHX0RSTV9SQURFT05fVVNFUlBUUj15CkNPTkZJ R19EUk1fQU1ER1BVPW0KQ09ORklHX0RSTV9BTURHUFVfU0k9eQpDT05GSUdfRFJNX0FNREdQ VV9DSUs9eQpDT05GSUdfRFJNX0FNREdQVV9VU0VSUFRSPXkKIyBDT05GSUdfRFJNX0FNREdQ VV9HQVJUX0RFQlVHRlMgaXMgbm90IHNldAoKIwojIEFDUCAoQXVkaW8gQ29Qcm9jZXNzb3Ip IENvbmZpZ3VyYXRpb24KIwpDT05GSUdfRFJNX0FNRF9BQ1A9eQojIGVuZCBvZiBBQ1AgKEF1 ZGlvIENvUHJvY2Vzc29yKSBDb25maWd1cmF0aW9uCgojCiMgRGlzcGxheSBFbmdpbmUgQ29u ZmlndXJhdGlvbgojCkNPTkZJR19EUk1fQU1EX0RDPXkKQ09ORklHX0RSTV9BTURfRENfRENO PXkKQ09ORklHX0RSTV9BTURfRENfSERDUD15CkNPTkZJR19EUk1fQU1EX0RDX1NJPXkKIyBl bmQgb2YgRGlzcGxheSBFbmdpbmUgQ29uZmlndXJhdGlvbgoKQ09ORklHX0hTQV9BTUQ9eQpD T05GSUdfRFJNX05PVVZFQVU9bQojIENPTkZJR19OT1VWRUFVX0xFR0FDWV9DVFhfU1VQUE9S VCBpcyBub3Qgc2V0CkNPTkZJR19OT1VWRUFVX0RFQlVHPTUKQ09ORklHX05PVVZFQVVfREVC VUdfREVGQVVMVD0zCiMgQ09ORklHX05PVVZFQVVfREVCVUdfTU1VIGlzIG5vdCBzZXQKIyBD T05GSUdfTk9VVkVBVV9ERUJVR19QVVNIIGlzIG5vdCBzZXQKQ09ORklHX0RSTV9OT1VWRUFV X0JBQ0tMSUdIVD15CkNPTkZJR19EUk1fTk9VVkVBVV9TVk09eQpDT05GSUdfRFJNX0k5MTU9 bQpDT05GSUdfRFJNX0k5MTVfRk9SQ0VfUFJPQkU9IioiCkNPTkZJR19EUk1fSTkxNV9DQVBU VVJFX0VSUk9SPXkKQ09ORklHX0RSTV9JOTE1X0NPTVBSRVNTX0VSUk9SPXkKQ09ORklHX0RS TV9JOTE1X1VTRVJQVFI9eQpDT05GSUdfRFJNX0k5MTVfR1ZUPXkKQ09ORklHX0RSTV9JOTE1 X0dWVF9LVk1HVD1tCkNPTkZJR19EUk1fSTkxNV9GRU5DRV9USU1FT1VUPTEwMDAwCkNPTkZJ R19EUk1fSTkxNV9VU0VSRkFVTFRfQVVUT1NVU1BFTkQ9MjUwCkNPTkZJR19EUk1fSTkxNV9I RUFSVEJFQVRfSU5URVJWQUw9MjUwMApDT05GSUdfRFJNX0k5MTVfUFJFRU1QVF9USU1FT1VU PTY0MApDT05GSUdfRFJNX0k5MTVfTUFYX1JFUVVFU1RfQlVTWVdBSVQ9ODAwMApDT05GSUdf RFJNX0k5MTVfU1RPUF9USU1FT1VUPTEwMApDT05GSUdfRFJNX0k5MTVfVElNRVNMSUNFX0RV UkFUSU9OPTEKQ09ORklHX0RSTV9WR0VNPW0KQ09ORklHX0RSTV9WS01TPW0KQ09ORklHX0RS TV9WTVdHRlg9bQpDT05GSUdfRFJNX1ZNV0dGWF9GQkNPTj15CkNPTkZJR19EUk1fR01BNTAw PW0KQ09ORklHX0RSTV9HTUE2MDA9eQpDT05GSUdfRFJNX1VETD1tCkNPTkZJR19EUk1fQVNU PW0KQ09ORklHX0RSTV9NR0FHMjAwPW0KQ09ORklHX0RSTV9RWEw9bQpDT05GSUdfRFJNX0JP Q0hTPW0KQ09ORklHX0RSTV9WSVJUSU9fR1BVPW0KQ09ORklHX0RSTV9QQU5FTD15CgojCiMg RGlzcGxheSBQYW5lbHMKIwpDT05GSUdfRFJNX1BBTkVMX1JBU1BCRVJSWVBJX1RPVUNIU0NS RUVOPW0KIyBlbmQgb2YgRGlzcGxheSBQYW5lbHMKCkNPTkZJR19EUk1fQlJJREdFPXkKQ09O RklHX0RSTV9QQU5FTF9CUklER0U9eQoKIwojIERpc3BsYXkgSW50ZXJmYWNlIEJyaWRnZXMK IwpDT05GSUdfRFJNX0FOQUxPR0lYX0FOWDc4WFg9bQpDT05GSUdfRFJNX0FOQUxPR0lYX0RQ PW0KIyBlbmQgb2YgRGlzcGxheSBJbnRlcmZhY2UgQnJpZGdlcwoKIyBDT05GSUdfRFJNX0VU TkFWSVYgaXMgbm90IHNldApDT05GSUdfRFJNX0NJUlJVU19RRU1VPW0KQ09ORklHX0RSTV9H TTEyVTMyMD1tCkNPTkZJR19USU5ZRFJNX0hYODM1N0Q9bQpDT05GSUdfVElOWURSTV9JTEk5 MjI1PW0KQ09ORklHX1RJTllEUk1fSUxJOTM0MT1tCkNPTkZJR19USU5ZRFJNX0lMSTk0ODY9 bQpDT05GSUdfVElOWURSTV9NSTAyODNRVD1tCkNPTkZJR19USU5ZRFJNX1JFUEFQRVI9bQpD T05GSUdfVElOWURSTV9TVDc1ODY9bQpDT05GSUdfVElOWURSTV9TVDc3MzVSPW0KQ09ORklH X0RSTV9YRU49eQpDT05GSUdfRFJNX1hFTl9GUk9OVEVORD1tCkNPTkZJR19EUk1fVkJPWFZJ REVPPW0KIyBDT05GSUdfRFJNX0xFR0FDWSBpcyBub3Qgc2V0CkNPTkZJR19EUk1fUEFORUxf T1JJRU5UQVRJT05fUVVJUktTPXkKCiMKIyBGcmFtZSBidWZmZXIgRGV2aWNlcwojCkNPTkZJ R19GQl9DTURMSU5FPXkKQ09ORklHX0ZCX05PVElGWT15CkNPTkZJR19GQj15CkNPTkZJR19G SVJNV0FSRV9FRElEPXkKQ09ORklHX0ZCX0JPT1RfVkVTQV9TVVBQT1JUPXkKQ09ORklHX0ZC X0NGQl9GSUxMUkVDVD15CkNPTkZJR19GQl9DRkJfQ09QWUFSRUE9eQpDT05GSUdfRkJfQ0ZC X0lNQUdFQkxJVD15CkNPTkZJR19GQl9TWVNfRklMTFJFQ1Q9bQpDT05GSUdfRkJfU1lTX0NP UFlBUkVBPW0KQ09ORklHX0ZCX1NZU19JTUFHRUJMSVQ9bQojIENPTkZJR19GQl9GT1JFSUdO X0VORElBTiBpcyBub3Qgc2V0CkNPTkZJR19GQl9TWVNfRk9QUz1tCkNPTkZJR19GQl9ERUZF UlJFRF9JTz15CkNPTkZJR19GQl9NT0RFX0hFTFBFUlM9eQpDT05GSUdfRkJfVElMRUJMSVRU SU5HPXkKCiMKIyBGcmFtZSBidWZmZXIgaGFyZHdhcmUgZHJpdmVycwojCiMgQ09ORklHX0ZC X0NJUlJVUyBpcyBub3Qgc2V0CiMgQ09ORklHX0ZCX1BNMiBpcyBub3Qgc2V0CiMgQ09ORklH X0ZCX0NZQkVSMjAwMCBpcyBub3Qgc2V0CiMgQ09ORklHX0ZCX0FSQyBpcyBub3Qgc2V0CiMg Q09ORklHX0ZCX0FTSUxJQU5UIGlzIG5vdCBzZXQKIyBDT05GSUdfRkJfSU1TVFQgaXMgbm90 IHNldAojIENPTkZJR19GQl9WR0ExNiBpcyBub3Qgc2V0CkNPTkZJR19GQl9VVkVTQT1tCkNP TkZJR19GQl9WRVNBPXkKQ09ORklHX0ZCX0VGST15CiMgQ09ORklHX0ZCX040MTEgaXMgbm90 IHNldAojIENPTkZJR19GQl9IR0EgaXMgbm90IHNldAojIENPTkZJR19GQl9PUEVOQ09SRVMg aXMgbm90IHNldAojIENPTkZJR19GQl9TMUQxM1hYWCBpcyBub3Qgc2V0CiMgQ09ORklHX0ZC X05WSURJQSBpcyBub3Qgc2V0CiMgQ09ORklHX0ZCX1JJVkEgaXMgbm90IHNldAojIENPTkZJ R19GQl9JNzQwIGlzIG5vdCBzZXQKIyBDT05GSUdfRkJfTEU4MDU3OCBpcyBub3Qgc2V0CiMg Q09ORklHX0ZCX01BVFJPWCBpcyBub3Qgc2V0CiMgQ09ORklHX0ZCX1JBREVPTiBpcyBub3Qg c2V0CiMgQ09ORklHX0ZCX0FUWTEyOCBpcyBub3Qgc2V0CiMgQ09ORklHX0ZCX0FUWSBpcyBu b3Qgc2V0CiMgQ09ORklHX0ZCX1MzIGlzIG5vdCBzZXQKIyBDT05GSUdfRkJfU0FWQUdFIGlz IG5vdCBzZXQKIyBDT05GSUdfRkJfU0lTIGlzIG5vdCBzZXQKIyBDT05GSUdfRkJfVklBIGlz IG5vdCBzZXQKIyBDT05GSUdfRkJfTkVPTUFHSUMgaXMgbm90IHNldAojIENPTkZJR19GQl9L WVJPIGlzIG5vdCBzZXQKIyBDT05GSUdfRkJfM0RGWCBpcyBub3Qgc2V0CiMgQ09ORklHX0ZC X1ZPT0RPTzEgaXMgbm90IHNldAojIENPTkZJR19GQl9WVDg2MjMgaXMgbm90IHNldAojIENP TkZJR19GQl9UUklERU5UIGlzIG5vdCBzZXQKIyBDT05GSUdfRkJfQVJLIGlzIG5vdCBzZXQK IyBDT05GSUdfRkJfUE0zIGlzIG5vdCBzZXQKIyBDT05GSUdfRkJfQ0FSTUlORSBpcyBub3Qg c2V0CiMgQ09ORklHX0ZCX1NNNTAxIGlzIG5vdCBzZXQKIyBDT05GSUdfRkJfU01TQ1VGWCBp cyBub3Qgc2V0CiMgQ09ORklHX0ZCX1VETCBpcyBub3Qgc2V0CiMgQ09ORklHX0ZCX0lCTV9H WFQ0NTAwIGlzIG5vdCBzZXQKIyBDT05GSUdfRkJfVklSVFVBTCBpcyBub3Qgc2V0CkNPTkZJ R19YRU5fRkJERVZfRlJPTlRFTkQ9bQojIENPTkZJR19GQl9NRVRST05PTUUgaXMgbm90IHNl dAojIENPTkZJR19GQl9NQjg2MlhYIGlzIG5vdCBzZXQKQ09ORklHX0ZCX0hZUEVSVj1tCkNP TkZJR19GQl9TSU1QTEU9eQojIENPTkZJR19GQl9TTTcxMiBpcyBub3Qgc2V0CiMgZW5kIG9m IEZyYW1lIGJ1ZmZlciBEZXZpY2VzCgojCiMgQmFja2xpZ2h0ICYgTENEIGRldmljZSBzdXBw b3J0CiMKQ09ORklHX0xDRF9DTEFTU19ERVZJQ0U9bQpDT05GSUdfTENEX0w0RjAwMjQyVDAz PW0KQ09ORklHX0xDRF9MTVMyODNHRjA1PW0KQ09ORklHX0xDRF9MVFYzNTBRVj1tCkNPTkZJ R19MQ0RfSUxJOTIyWD1tCkNPTkZJR19MQ0RfSUxJOTMyMD1tCkNPTkZJR19MQ0RfVERPMjRN PW0KQ09ORklHX0xDRF9WR0cyNDMyQTQ9bQpDT05GSUdfTENEX1BMQVRGT1JNPW0KQ09ORklH X0xDRF9BTVMzNjlGRzA2PW0KQ09ORklHX0xDRF9MTVM1MDFLRjAzPW0KQ09ORklHX0xDRF9I WDgzNTc9bQpDT05GSUdfTENEX09UTTMyMjVBPW0KQ09ORklHX0JBQ0tMSUdIVF9DTEFTU19E RVZJQ0U9eQpDT05GSUdfQkFDS0xJR0hUX0tURDI1Mz1tCkNPTkZJR19CQUNLTElHSFRfTE0z NTMzPW0KQ09ORklHX0JBQ0tMSUdIVF9QV009bQpDT05GSUdfQkFDS0xJR0hUX0RBOTAzWD1t CkNPTkZJR19CQUNLTElHSFRfREE5MDUyPW0KQ09ORklHX0JBQ0tMSUdIVF9NQVg4OTI1PW0K Q09ORklHX0JBQ0tMSUdIVF9BUFBMRT1tCkNPTkZJR19CQUNLTElHSFRfUUNPTV9XTEVEPW0K Q09ORklHX0JBQ0tMSUdIVF9TQUhBUkE9bQpDT05GSUdfQkFDS0xJR0hUX1dNODMxWD1tCkNP TkZJR19CQUNLTElHSFRfQURQNTUyMD1tCkNPTkZJR19CQUNLTElHSFRfQURQODg2MD1tCkNP TkZJR19CQUNLTElHSFRfQURQODg3MD1tCkNPTkZJR19CQUNLTElHSFRfODhQTTg2MFg9bQpD T05GSUdfQkFDS0xJR0hUX1BDRjUwNjMzPW0KQ09ORklHX0JBQ0tMSUdIVF9BQVQyODcwPW0K Q09ORklHX0JBQ0tMSUdIVF9MTTM2MzBBPW0KQ09ORklHX0JBQ0tMSUdIVF9MTTM2Mzk9bQpD T05GSUdfQkFDS0xJR0hUX0xQODU1WD1tCkNPTkZJR19CQUNLTElHSFRfTFA4Nzg4PW0KQ09O RklHX0JBQ0tMSUdIVF9QQU5ET1JBPW0KQ09ORklHX0JBQ0tMSUdIVF9TS1k4MTQ1Mj1tCkNP TkZJR19CQUNLTElHSFRfQVMzNzExPW0KQ09ORklHX0JBQ0tMSUdIVF9HUElPPW0KQ09ORklH X0JBQ0tMSUdIVF9MVjUyMDdMUD1tCkNPTkZJR19CQUNLTElHSFRfQkQ2MTA3PW0KQ09ORklH X0JBQ0tMSUdIVF9BUkNYQ05OPW0KQ09ORklHX0JBQ0tMSUdIVF9SQVZFX1NQPW0KIyBlbmQg b2YgQmFja2xpZ2h0ICYgTENEIGRldmljZSBzdXBwb3J0CgpDT05GSUdfVklERU9NT0RFX0hF TFBFUlM9eQpDT05GSUdfSERNST15CgojCiMgQ29uc29sZSBkaXNwbGF5IGRyaXZlciBzdXBw b3J0CiMKQ09ORklHX1ZHQV9DT05TT0xFPXkKQ09ORklHX0RVTU1ZX0NPTlNPTEU9eQpDT05G SUdfRFVNTVlfQ09OU09MRV9DT0xVTU5TPTgwCkNPTkZJR19EVU1NWV9DT05TT0xFX1JPV1M9 MjUKQ09ORklHX0ZSQU1FQlVGRkVSX0NPTlNPTEU9eQpDT05GSUdfRlJBTUVCVUZGRVJfQ09O U09MRV9ERVRFQ1RfUFJJTUFSWT15CkNPTkZJR19GUkFNRUJVRkZFUl9DT05TT0xFX1JPVEFU SU9OPXkKQ09ORklHX0ZSQU1FQlVGRkVSX0NPTlNPTEVfREVGRVJSRURfVEFLRU9WRVI9eQoj IGVuZCBvZiBDb25zb2xlIGRpc3BsYXkgZHJpdmVyIHN1cHBvcnQKCiMgQ09ORklHX0xPR08g aXMgbm90IHNldAojIGVuZCBvZiBHcmFwaGljcyBzdXBwb3J0CgpDT05GSUdfU09VTkQ9bQpD T05GSUdfU09VTkRfT1NTX0NPUkU9eQojIENPTkZJR19TT1VORF9PU1NfQ09SRV9QUkVDTEFJ TSBpcyBub3Qgc2V0CkNPTkZJR19TTkQ9bQpDT05GSUdfU05EX1RJTUVSPW0KQ09ORklHX1NO RF9QQ009bQpDT05GSUdfU05EX1BDTV9FTEQ9eQpDT05GSUdfU05EX1BDTV9JRUM5NTg9eQpD T05GSUdfU05EX0RNQUVOR0lORV9QQ009bQpDT05GSUdfU05EX0hXREVQPW0KQ09ORklHX1NO RF9TRVFfREVWSUNFPW0KQ09ORklHX1NORF9SQVdNSURJPW0KQ09ORklHX1NORF9DT01QUkVT U19PRkZMT0FEPW0KQ09ORklHX1NORF9KQUNLPXkKQ09ORklHX1NORF9KQUNLX0lOUFVUX0RF Vj15CkNPTkZJR19TTkRfT1NTRU1VTD15CkNPTkZJR19TTkRfTUlYRVJfT1NTPW0KQ09ORklH X1NORF9QQ01fT1NTPW0KQ09ORklHX1NORF9QQ01fT1NTX1BMVUdJTlM9eQpDT05GSUdfU05E X1BDTV9USU1FUj15CkNPTkZJR19TTkRfSFJUSU1FUj1tCkNPTkZJR19TTkRfRFlOQU1JQ19N SU5PUlM9eQpDT05GSUdfU05EX01BWF9DQVJEUz0zMgojIENPTkZJR19TTkRfU1VQUE9SVF9P TERfQVBJIGlzIG5vdCBzZXQKQ09ORklHX1NORF9QUk9DX0ZTPXkKQ09ORklHX1NORF9WRVJC T1NFX1BST0NGUz15CkNPTkZJR19TTkRfVkVSQk9TRV9QUklOVEs9eQpDT05GSUdfU05EX0RF QlVHPXkKIyBDT05GSUdfU05EX0RFQlVHX1ZFUkJPU0UgaXMgbm90IHNldAojIENPTkZJR19T TkRfUENNX1hSVU5fREVCVUcgaXMgbm90IHNldAojIENPTkZJR19TTkRfQ1RMX1ZBTElEQVRJ T04gaXMgbm90IHNldAojIENPTkZJR19TTkRfSkFDS19JTkpFQ1RJT05fREVCVUcgaXMgbm90 IHNldApDT05GSUdfU05EX1ZNQVNURVI9eQpDT05GSUdfU05EX0RNQV9TR0JVRj15CkNPTkZJ R19TTkRfU0VRVUVOQ0VSPW0KQ09ORklHX1NORF9TRVFfRFVNTVk9bQpDT05GSUdfU05EX1NF UVVFTkNFUl9PU1M9bQpDT05GSUdfU05EX1NFUV9IUlRJTUVSX0RFRkFVTFQ9eQpDT05GSUdf U05EX1NFUV9NSURJX0VWRU5UPW0KQ09ORklHX1NORF9TRVFfTUlEST1tCkNPTkZJR19TTkRf U0VRX01JRElfRU1VTD1tCkNPTkZJR19TTkRfU0VRX1ZJUk1JREk9bQpDT05GSUdfU05EX01Q VTQwMV9VQVJUPW0KQ09ORklHX1NORF9PUEwzX0xJQj1tCkNPTkZJR19TTkRfT1BMM19MSUJf U0VRPW0KQ09ORklHX1NORF9WWF9MSUI9bQpDT05GSUdfU05EX0FDOTdfQ09ERUM9bQpDT05G SUdfU05EX0RSSVZFUlM9eQojIENPTkZJR19TTkRfUENTUCBpcyBub3Qgc2V0CkNPTkZJR19T TkRfRFVNTVk9bQpDT05GSUdfU05EX0FMT09QPW0KQ09ORklHX1NORF9WSVJNSURJPW0KQ09O RklHX1NORF9NVFBBVj1tCkNPTkZJR19TTkRfTVRTNjQ9bQpDT05GSUdfU05EX1NFUklBTF9V MTY1NTA9bQpDT05GSUdfU05EX01QVTQwMT1tCkNPTkZJR19TTkRfUE9SVE1BTjJYND1tCkNP TkZJR19TTkRfQUM5N19QT1dFUl9TQVZFPXkKQ09ORklHX1NORF9BQzk3X1BPV0VSX1NBVkVf REVGQVVMVD0wCkNPTkZJR19TTkRfU0JfQ09NTU9OPW0KQ09ORklHX1NORF9QQ0k9eQpDT05G SUdfU05EX0FEMTg4OT1tCkNPTkZJR19TTkRfQUxTMzAwPW0KQ09ORklHX1NORF9BTFM0MDAw PW0KQ09ORklHX1NORF9BTEk1NDUxPW0KQ09ORklHX1NORF9BU0lIUEk9bQpDT05GSUdfU05E X0FUSUlYUD1tCkNPTkZJR19TTkRfQVRJSVhQX01PREVNPW0KQ09ORklHX1NORF9BVTg4MTA9 bQpDT05GSUdfU05EX0FVODgyMD1tCkNPTkZJR19TTkRfQVU4ODMwPW0KQ09ORklHX1NORF9B VzI9bQpDT05GSUdfU05EX0FaVDMzMjg9bQpDT05GSUdfU05EX0JUODdYPW0KIyBDT05GSUdf U05EX0JUODdYX09WRVJDTE9DSyBpcyBub3Qgc2V0CkNPTkZJR19TTkRfQ0EwMTA2PW0KQ09O RklHX1NORF9DTUlQQ0k9bQpDT05GSUdfU05EX09YWUdFTl9MSUI9bQpDT05GSUdfU05EX09Y WUdFTj1tCkNPTkZJR19TTkRfQ1M0MjgxPW0KQ09ORklHX1NORF9DUzQ2WFg9bQpDT05GSUdf U05EX0NTNDZYWF9ORVdfRFNQPXkKQ09ORklHX1NORF9DVFhGST1tCkNPTkZJR19TTkRfREFS TEEyMD1tCkNPTkZJR19TTkRfR0lOQTIwPW0KQ09ORklHX1NORF9MQVlMQTIwPW0KQ09ORklH X1NORF9EQVJMQTI0PW0KQ09ORklHX1NORF9HSU5BMjQ9bQpDT05GSUdfU05EX0xBWUxBMjQ9 bQpDT05GSUdfU05EX01PTkE9bQpDT05GSUdfU05EX01JQT1tCkNPTkZJR19TTkRfRUNITzNH PW0KQ09ORklHX1NORF9JTkRJR089bQpDT05GSUdfU05EX0lORElHT0lPPW0KQ09ORklHX1NO RF9JTkRJR09ESj1tCkNPTkZJR19TTkRfSU5ESUdPSU9YPW0KQ09ORklHX1NORF9JTkRJR09E Slg9bQpDT05GSUdfU05EX0VNVTEwSzE9bQpDT05GSUdfU05EX0VNVTEwSzFfU0VRPW0KQ09O RklHX1NORF9FTVUxMEsxWD1tCkNPTkZJR19TTkRfRU5TMTM3MD1tCkNPTkZJR19TTkRfRU5T MTM3MT1tCkNPTkZJR19TTkRfRVMxOTM4PW0KQ09ORklHX1NORF9FUzE5Njg9bQpDT05GSUdf U05EX0VTMTk2OF9JTlBVVD15CkNPTkZJR19TTkRfRVMxOTY4X1JBRElPPXkKQ09ORklHX1NO RF9GTTgwMT1tCkNPTkZJR19TTkRfRk04MDFfVEVBNTc1WF9CT09MPXkKQ09ORklHX1NORF9I RFNQPW0KQ09ORklHX1NORF9IRFNQTT1tCkNPTkZJR19TTkRfSUNFMTcxMj1tCkNPTkZJR19T TkRfSUNFMTcyND1tCkNPTkZJR19TTkRfSU5URUw4WDA9bQpDT05GSUdfU05EX0lOVEVMOFgw TT1tCkNPTkZJR19TTkRfS09SRzEyMTI9bQpDT05GSUdfU05EX0xPTEE9bQpDT05GSUdfU05E X0xYNjQ2NEVTPW0KQ09ORklHX1NORF9NQUVTVFJPMz1tCkNPTkZJR19TTkRfTUFFU1RSTzNf SU5QVVQ9eQpDT05GSUdfU05EX01JWEFSVD1tCkNPTkZJR19TTkRfTk0yNTY9bQpDT05GSUdf U05EX1BDWEhSPW0KQ09ORklHX1NORF9SSVBUSURFPW0KQ09ORklHX1NORF9STUUzMj1tCkNP TkZJR19TTkRfUk1FOTY9bQpDT05GSUdfU05EX1JNRTk2NTI9bQpDT05GSUdfU05EX1NPTklD VklCRVM9bQpDT05GSUdfU05EX1RSSURFTlQ9bQpDT05GSUdfU05EX1ZJQTgyWFg9bQpDT05G SUdfU05EX1ZJQTgyWFhfTU9ERU09bQpDT05GSUdfU05EX1ZJUlRVT1NPPW0KQ09ORklHX1NO RF9WWDIyMj1tCkNPTkZJR19TTkRfWU1GUENJPW0KCiMKIyBIRC1BdWRpbwojCkNPTkZJR19T TkRfSERBPW0KQ09ORklHX1NORF9IREFfR0VORVJJQ19MRURTPXkKQ09ORklHX1NORF9IREFf SU5URUw9bQpDT05GSUdfU05EX0hEQV9IV0RFUD15CkNPTkZJR19TTkRfSERBX1JFQ09ORklH PXkKQ09ORklHX1NORF9IREFfSU5QVVRfQkVFUD15CkNPTkZJR19TTkRfSERBX0lOUFVUX0JF RVBfTU9ERT0wCkNPTkZJR19TTkRfSERBX1BBVENIX0xPQURFUj15CkNPTkZJR19TTkRfSERB X0NPREVDX1JFQUxURUs9bQpDT05GSUdfU05EX0hEQV9DT0RFQ19BTkFMT0c9bQpDT05GSUdf U05EX0hEQV9DT0RFQ19TSUdNQVRFTD1tCkNPTkZJR19TTkRfSERBX0NPREVDX1ZJQT1tCkNP TkZJR19TTkRfSERBX0NPREVDX0hETUk9bQpDT05GSUdfU05EX0hEQV9DT0RFQ19DSVJSVVM9 bQpDT05GSUdfU05EX0hEQV9DT0RFQ19DT05FWEFOVD1tCkNPTkZJR19TTkRfSERBX0NPREVD X0NBMDExMD1tCkNPTkZJR19TTkRfSERBX0NPREVDX0NBMDEzMj1tCkNPTkZJR19TTkRfSERB X0NPREVDX0NBMDEzMl9EU1A9eQpDT05GSUdfU05EX0hEQV9DT0RFQ19DTUVESUE9bQpDT05G SUdfU05EX0hEQV9DT0RFQ19TSTMwNTQ9bQpDT05GSUdfU05EX0hEQV9HRU5FUklDPW0KQ09O RklHX1NORF9IREFfUE9XRVJfU0FWRV9ERUZBVUxUPTEKQ09ORklHX1NORF9IREFfSU5URUxf SERNSV9TSUxFTlRfU1RSRUFNPXkKIyBlbmQgb2YgSEQtQXVkaW8KCkNPTkZJR19TTkRfSERB X0NPUkU9bQpDT05GSUdfU05EX0hEQV9EU1BfTE9BREVSPXkKQ09ORklHX1NORF9IREFfQ09N UE9ORU5UPXkKQ09ORklHX1NORF9IREFfSTkxNT15CkNPTkZJR19TTkRfSERBX0VYVF9DT1JF PW0KQ09ORklHX1NORF9IREFfUFJFQUxMT0NfU0laRT0wCkNPTkZJR19TTkRfSU5URUxfTkhM VD15CkNPTkZJR19TTkRfSU5URUxfRFNQX0NPTkZJRz1tCkNPTkZJR19TTkRfSU5URUxfU09V TkRXSVJFX0FDUEk9bQpDT05GSUdfU05EX0lOVEVMX0JZVF9QUkVGRVJfU09GPXkKQ09ORklH X1NORF9TUEk9eQpDT05GSUdfU05EX1VTQj15CkNPTkZJR19TTkRfVVNCX0FVRElPPW0KQ09O RklHX1NORF9VU0JfQVVESU9fVVNFX01FRElBX0NPTlRST0xMRVI9eQpDT05GSUdfU05EX1VT Ql9VQTEwMT1tCkNPTkZJR19TTkRfVVNCX1VTWDJZPW0KQ09ORklHX1NORF9VU0JfQ0FJQVE9 bQpDT05GSUdfU05EX1VTQl9DQUlBUV9JTlBVVD15CkNPTkZJR19TTkRfVVNCX1VTMTIyTD1t CkNPTkZJR19TTkRfVVNCXzZGSVJFPW0KQ09ORklHX1NORF9VU0JfSElGQUNFPW0KQ09ORklH X1NORF9CQ0QyMDAwPW0KQ09ORklHX1NORF9VU0JfTElORTY9bQpDT05GSUdfU05EX1VTQl9Q T0Q9bQpDT05GSUdfU05EX1VTQl9QT0RIRD1tCkNPTkZJR19TTkRfVVNCX1RPTkVQT1JUPW0K Q09ORklHX1NORF9VU0JfVkFSSUFYPW0KQ09ORklHX1NORF9GSVJFV0lSRT15CkNPTkZJR19T TkRfRklSRVdJUkVfTElCPW0KQ09ORklHX1NORF9ESUNFPW0KQ09ORklHX1NORF9PWEZXPW0K Q09ORklHX1NORF9JU0lHSFQ9bQpDT05GSUdfU05EX0ZJUkVXT1JLUz1tCkNPTkZJR19TTkRf QkVCT0I9bQpDT05GSUdfU05EX0ZJUkVXSVJFX0RJR0kwMFg9bQpDT05GSUdfU05EX0ZJUkVX SVJFX1RBU0NBTT1tCkNPTkZJR19TTkRfRklSRVdJUkVfTU9UVT1tCkNPTkZJR19TTkRfRklS RUZBQ0U9bQpDT05GSUdfU05EX1BDTUNJQT15CkNPTkZJR19TTkRfVlhQT0NLRVQ9bQpDT05G SUdfU05EX1BEQVVESU9DRj1tCkNPTkZJR19TTkRfU09DPW0KQ09ORklHX1NORF9TT0NfQUM5 N19CVVM9eQpDT05GSUdfU05EX1NPQ19HRU5FUklDX0RNQUVOR0lORV9QQ009eQpDT05GSUdf U05EX1NPQ19DT01QUkVTUz15CkNPTkZJR19TTkRfU09DX1RPUE9MT0dZPXkKQ09ORklHX1NO RF9TT0NfQUNQST1tCkNPTkZJR19TTkRfU09DX0FEST1tCkNPTkZJR19TTkRfU09DX0FESV9B WElfSTJTPW0KQ09ORklHX1NORF9TT0NfQURJX0FYSV9TUERJRj1tCkNPTkZJR19TTkRfU09D X0FNRF9BQ1A9bQpDT05GSUdfU05EX1NPQ19BTURfQ1pfREE3MjE5TVg5ODM1N19NQUNIPW0K Q09ORklHX1NORF9TT0NfQU1EX0NaX1JUNTY0NV9NQUNIPW0KQ09ORklHX1NORF9TT0NfQU1E X0FDUDN4PW0KQ09ORklHX1NORF9TT0NfQU1EX1JWX1JUNTY4Ml9NQUNIPW0KQ09ORklHX1NO RF9TT0NfQU1EX1JFTk9JUj1tCkNPTkZJR19TTkRfU09DX0FNRF9SRU5PSVJfTUFDSD1tCkNP TkZJR19TTkRfQVRNRUxfU09DPW0KIyBDT05GSUdfU05EX0JDTTYzWFhfSTJTX1dISVNUTEVS IGlzIG5vdCBzZXQKQ09ORklHX1NORF9ERVNJR05XQVJFX0kyUz1tCkNPTkZJR19TTkRfREVT SUdOV0FSRV9QQ009eQoKIwojIFNvQyBBdWRpbyBmb3IgRnJlZXNjYWxlIENQVXMKIwoKIwoj IENvbW1vbiBTb0MgQXVkaW8gb3B0aW9ucyBmb3IgRnJlZXNjYWxlIENQVXM6CiMKIyBDT05G SUdfU05EX1NPQ19GU0xfQVNSQyBpcyBub3Qgc2V0CiMgQ09ORklHX1NORF9TT0NfRlNMX1NB SSBpcyBub3Qgc2V0CiMgQ09ORklHX1NORF9TT0NfRlNMX0FVRE1JWCBpcyBub3Qgc2V0CiMg Q09ORklHX1NORF9TT0NfRlNMX1NTSSBpcyBub3Qgc2V0CiMgQ09ORklHX1NORF9TT0NfRlNM X1NQRElGIGlzIG5vdCBzZXQKIyBDT05GSUdfU05EX1NPQ19GU0xfRVNBSSBpcyBub3Qgc2V0 CiMgQ09ORklHX1NORF9TT0NfRlNMX01JQ0ZJTCBpcyBub3Qgc2V0CkNPTkZJR19TTkRfU09D X0ZTTF9YQ1ZSPW0KIyBDT05GSUdfU05EX1NPQ19JTVhfQVVETVVYIGlzIG5vdCBzZXQKIyBl bmQgb2YgU29DIEF1ZGlvIGZvciBGcmVlc2NhbGUgQ1BVcwoKQ09ORklHX1NORF9JMlNfSEk2 MjEwX0kyUz1tCkNPTkZJR19TTkRfU09DX0lNRz15CkNPTkZJR19TTkRfU09DX0lNR19JMlNf SU49bQpDT05GSUdfU05EX1NPQ19JTUdfSTJTX09VVD1tCkNPTkZJR19TTkRfU09DX0lNR19Q QVJBTExFTF9PVVQ9bQpDT05GSUdfU05EX1NPQ19JTUdfU1BESUZfSU49bQpDT05GSUdfU05E X1NPQ19JTUdfU1BESUZfT1VUPW0KQ09ORklHX1NORF9TT0NfSU1HX1BJU1RBQ0hJT19JTlRF Uk5BTF9EQUM9bQpDT05GSUdfU05EX1NPQ19JTlRFTF9TU1RfVE9QTEVWRUw9eQpDT05GSUdf U05EX1NPQ19JTlRFTF9TU1Q9bQpDT05GSUdfU05EX1NPQ19JTlRFTF9DQVRQVD1tCkNPTkZJ R19TTkRfU1NUX0FUT01fSElGSTJfUExBVEZPUk09bQpDT05GSUdfU05EX1NTVF9BVE9NX0hJ RkkyX1BMQVRGT1JNX1BDST1tCkNPTkZJR19TTkRfU1NUX0FUT01fSElGSTJfUExBVEZPUk1f QUNQST1tCkNPTkZJR19TTkRfU09DX0lOVEVMX1NLWUxBS0U9bQpDT05GSUdfU05EX1NPQ19J TlRFTF9TS0w9bQpDT05GSUdfU05EX1NPQ19JTlRFTF9BUEw9bQpDT05GSUdfU05EX1NPQ19J TlRFTF9LQkw9bQpDT05GSUdfU05EX1NPQ19JTlRFTF9HTEs9bQpDT05GSUdfU05EX1NPQ19J TlRFTF9DTkw9bQpDT05GSUdfU05EX1NPQ19JTlRFTF9DRkw9bQpDT05GSUdfU05EX1NPQ19J TlRFTF9DTUxfSD1tCkNPTkZJR19TTkRfU09DX0lOVEVMX0NNTF9MUD1tCkNPTkZJR19TTkRf U09DX0lOVEVMX1NLWUxBS0VfRkFNSUxZPW0KQ09ORklHX1NORF9TT0NfSU5URUxfU0tZTEFL RV9TU1BfQ0xLPW0KQ09ORklHX1NORF9TT0NfSU5URUxfU0tZTEFLRV9IREFVRElPX0NPREVD PXkKQ09ORklHX1NORF9TT0NfSU5URUxfU0tZTEFLRV9DT01NT049bQpDT05GSUdfU05EX1NP Q19BQ1BJX0lOVEVMX01BVENIPW0KQ09ORklHX1NORF9TT0NfSU5URUxfTUFDSD15CkNPTkZJ R19TTkRfU09DX0lOVEVMX1VTRVJfRlJJRU5ETFlfTE9OR19OQU1FUz15CkNPTkZJR19TTkRf U09DX0lOVEVMX0hBU1dFTExfTUFDSD1tCkNPTkZJR19TTkRfU09DX0lOVEVMX0JEV19SVDU2 NTBfTUFDSD1tCkNPTkZJR19TTkRfU09DX0lOVEVMX0JEV19SVDU2NzdfTUFDSD1tCkNPTkZJ R19TTkRfU09DX0lOVEVMX0JST0FEV0VMTF9NQUNIPW0KQ09ORklHX1NORF9TT0NfSU5URUxf QllUQ1JfUlQ1NjQwX01BQ0g9bQpDT05GSUdfU05EX1NPQ19JTlRFTF9CWVRDUl9SVDU2NTFf TUFDSD1tCkNPTkZJR19TTkRfU09DX0lOVEVMX0JZVENSX1dNNTEwMl9NQUNIPW0KQ09ORklH X1NORF9TT0NfSU5URUxfQ0hUX0JTV19SVDU2NzJfTUFDSD1tCkNPTkZJR19TTkRfU09DX0lO VEVMX0NIVF9CU1dfUlQ1NjQ1X01BQ0g9bQpDT05GSUdfU05EX1NPQ19JTlRFTF9DSFRfQlNX X01BWDk4MDkwX1RJX01BQ0g9bQpDT05GSUdfU05EX1NPQ19JTlRFTF9DSFRfQlNXX05BVTg4 MjRfTUFDSD1tCkNPTkZJR19TTkRfU09DX0lOVEVMX0JZVF9DSFRfQ1gyMDcyWF9NQUNIPW0K Q09ORklHX1NORF9TT0NfSU5URUxfQllUX0NIVF9EQTcyMTNfTUFDSD1tCkNPTkZJR19TTkRf U09DX0lOVEVMX0JZVF9DSFRfRVM4MzE2X01BQ0g9bQojIENPTkZJR19TTkRfU09DX0lOVEVM X0JZVF9DSFRfTk9DT0RFQ19NQUNIIGlzIG5vdCBzZXQKQ09ORklHX1NORF9TT0NfSU5URUxf U0tMX1JUMjg2X01BQ0g9bQpDT05GSUdfU05EX1NPQ19JTlRFTF9TS0xfTkFVODhMMjVfU1NN NDU2N19NQUNIPW0KQ09ORklHX1NORF9TT0NfSU5URUxfU0tMX05BVTg4TDI1X01BWDk4MzU3 QV9NQUNIPW0KQ09ORklHX1NORF9TT0NfSU5URUxfREE3MjE5X01BWDk4MzU3QV9HRU5FUklD PW0KQ09ORklHX1NORF9TT0NfSU5URUxfQlhUX0RBNzIxOV9NQVg5ODM1N0FfQ09NTU9OPW0K Q09ORklHX1NORF9TT0NfSU5URUxfQlhUX0RBNzIxOV9NQVg5ODM1N0FfTUFDSD1tCkNPTkZJ R19TTkRfU09DX0lOVEVMX0JYVF9SVDI5OF9NQUNIPW0KQ09ORklHX1NORF9TT0NfSU5URUxf U09GX1dNODgwNF9NQUNIPW0KQ09ORklHX1NORF9TT0NfSU5URUxfS0JMX1JUNTY2M19NQVg5 ODkyN19NQUNIPW0KQ09ORklHX1NORF9TT0NfSU5URUxfS0JMX1JUNTY2M19SVDU1MTRfTUFY OTg5MjdfTUFDSD1tCkNPTkZJR19TTkRfU09DX0lOVEVMX0tCTF9EQTcyMTlfTUFYOTgzNTdB X01BQ0g9bQpDT05GSUdfU05EX1NPQ19JTlRFTF9LQkxfREE3MjE5X01BWDk4OTI3X01BQ0g9 bQpDT05GSUdfU05EX1NPQ19JTlRFTF9LQkxfUlQ1NjYwX01BQ0g9bQpDT05GSUdfU05EX1NP Q19JTlRFTF9HTEtfREE3MjE5X01BWDk4MzU3QV9NQUNIPW0KQ09ORklHX1NORF9TT0NfSU5U RUxfR0xLX1JUNTY4Ml9NQVg5ODM1N0FfTUFDSD1tCkNPTkZJR19TTkRfU09DX0lOVEVMX1NL TF9IREFfRFNQX0dFTkVSSUNfTUFDSD1tCkNPTkZJR19TTkRfU09DX0lOVEVMX1NPRl9SVDU2 ODJfTUFDSD1tCkNPTkZJR19TTkRfU09DX0lOVEVMX1NPRl9QQ001MTJ4X01BQ0g9bQpDT05G SUdfU05EX1NPQ19JTlRFTF9DTUxfTFBfREE3MjE5X01BWDk4MzU3QV9NQUNIPW0KQ09ORklH X1NORF9TT0NfSU5URUxfU09GX0NNTF9SVDEwMTFfUlQ1NjgyX01BQ0g9bQpDT05GSUdfU05E X1NPQ19JTlRFTF9TT0ZfREE3MjE5X01BWDk4MzczX01BQ0g9bQpDT05GSUdfU05EX1NPQ19J TlRFTF9FSExfUlQ1NjYwX01BQ0g9bQpDT05GSUdfU05EX1NPQ19JTlRFTF9TT1VORFdJUkVf U09GX01BQ0g9bQpDT05GSUdfU05EX1NPQ19NVEtfQlRDVlNEPW0KQ09ORklHX1NORF9TT0Nf U09GX1RPUExFVkVMPXkKQ09ORklHX1NORF9TT0NfU09GX1BDSV9ERVY9bQpDT05GSUdfU05E X1NPQ19TT0ZfUENJPW0KQ09ORklHX1NORF9TT0NfU09GX0FDUEk9bQpDT05GSUdfU05EX1NP Q19TT0ZfQUNQSV9ERVY9bQojIENPTkZJR19TTkRfU09DX1NPRl9ERUJVR19QUk9CRVMgaXMg bm90IHNldApDT05GSUdfU05EX1NPQ19TT0Y9bQpDT05GSUdfU05EX1NPQ19TT0ZfUFJPQkVf V09SS19RVUVVRT15CkNPTkZJR19TTkRfU09DX1NPRl9JTlRFTF9UT1BMRVZFTD15CkNPTkZJ R19TTkRfU09DX1NPRl9JTlRFTF9ISUZJX0VQX0lQQz1tCkNPTkZJR19TTkRfU09DX1NPRl9J TlRFTF9BVE9NX0hJRklfRVA9bQpDT05GSUdfU05EX1NPQ19TT0ZfSU5URUxfQ09NTU9OPW0K Q09ORklHX1NORF9TT0NfU09GX0JBWVRSQUlMPW0KIyBDT05GSUdfU05EX1NPQ19TT0ZfQlJP QURXRUxMIGlzIG5vdCBzZXQKQ09ORklHX1NORF9TT0NfU09GX01FUlJJRklFTEQ9bQpDT05G SUdfU05EX1NPQ19TT0ZfSU5URUxfQVBMPW0KQ09ORklHX1NORF9TT0NfU09GX0FQT0xMT0xB S0U9bQpDT05GSUdfU05EX1NPQ19TT0ZfR0VNSU5JTEFLRT1tCkNPTkZJR19TTkRfU09DX1NP Rl9JTlRFTF9DTkw9bQpDT05GSUdfU05EX1NPQ19TT0ZfQ0FOTk9OTEFLRT1tCkNPTkZJR19T TkRfU09DX1NPRl9DT0ZGRUVMQUtFPW0KQ09ORklHX1NORF9TT0NfU09GX0NPTUVUTEFLRT1t CkNPTkZJR19TTkRfU09DX1NPRl9JTlRFTF9JQ0w9bQpDT05GSUdfU05EX1NPQ19TT0ZfSUNF TEFLRT1tCkNPTkZJR19TTkRfU09DX1NPRl9KQVNQRVJMQUtFPW0KQ09ORklHX1NORF9TT0Nf U09GX0lOVEVMX1RHTD1tCkNPTkZJR19TTkRfU09DX1NPRl9USUdFUkxBS0U9bQpDT05GSUdf U05EX1NPQ19TT0ZfRUxLSEFSVExBS0U9bQpDT05GSUdfU05EX1NPQ19TT0ZfQUxERVJMQUtF PW0KQ09ORklHX1NORF9TT0NfU09GX0hEQV9DT01NT049bQpDT05GSUdfU05EX1NPQ19TT0Zf SERBX0xJTks9eQpDT05GSUdfU05EX1NPQ19TT0ZfSERBX0FVRElPX0NPREVDPXkKIyBDT05G SUdfU05EX1NPQ19TT0ZfSERBX0FMV0FZU19FTkFCTEVfRE1JX0wxIGlzIG5vdCBzZXQKQ09O RklHX1NORF9TT0NfU09GX0hEQV9MSU5LX0JBU0VMSU5FPW0KQ09ORklHX1NORF9TT0NfU09G X0hEQT1tCkNPTkZJR19TTkRfU09DX1NPRl9JTlRFTF9TT1VORFdJUkVfTElOS19CQVNFTElO RT1tCkNPTkZJR19TTkRfU09DX1NPRl9JTlRFTF9TT1VORFdJUkU9bQpDT05GSUdfU05EX1NP Q19TT0ZfWFRFTlNBPW0KCiMKIyBTVE1pY3JvZWxlY3Ryb25pY3MgU1RNMzIgU09DIGF1ZGlv IHN1cHBvcnQKIwojIGVuZCBvZiBTVE1pY3JvZWxlY3Ryb25pY3MgU1RNMzIgU09DIGF1ZGlv IHN1cHBvcnQKCkNPTkZJR19TTkRfU09DX1hJTElOWF9JMlM9bQpDT05GSUdfU05EX1NPQ19Y SUxJTlhfQVVESU9fRk9STUFUVEVSPW0KQ09ORklHX1NORF9TT0NfWElMSU5YX1NQRElGPW0K Q09ORklHX1NORF9TT0NfWFRGUEdBX0kyUz1tCkNPTkZJR19TTkRfU09DX0kyQ19BTkRfU1BJ PW0KCiMKIyBDT0RFQyBkcml2ZXJzCiMKQ09ORklHX1NORF9TT0NfQVJJWk9OQT1tCkNPTkZJ R19TTkRfU09DX1dNX0FEU1A9bQpDT05GSUdfU05EX1NPQ19BQzk3X0NPREVDPW0KQ09ORklH X1NORF9TT0NfQURBVV9VVElMUz1tCkNPTkZJR19TTkRfU09DX0FEQVUxMzcyPW0KQ09ORklH X1NORF9TT0NfQURBVTEzNzJfSTJDPW0KQ09ORklHX1NORF9TT0NfQURBVTEzNzJfU1BJPW0K Q09ORklHX1NORF9TT0NfQURBVTE3MDE9bQpDT05GSUdfU05EX1NPQ19BREFVMTdYMT1tCkNP TkZJR19TTkRfU09DX0FEQVUxNzYxPW0KQ09ORklHX1NORF9TT0NfQURBVTE3NjFfSTJDPW0K Q09ORklHX1NORF9TT0NfQURBVTE3NjFfU1BJPW0KQ09ORklHX1NORF9TT0NfQURBVTcwMDI9 bQpDT05GSUdfU05EX1NPQ19BREFVNzExOD1tCkNPTkZJR19TTkRfU09DX0FEQVU3MTE4X0hX PW0KQ09ORklHX1NORF9TT0NfQURBVTcxMThfSTJDPW0KQ09ORklHX1NORF9TT0NfQUs0MTA0 PW0KQ09ORklHX1NORF9TT0NfQUs0MTE4PW0KQ09ORklHX1NORF9TT0NfQUs0NDU4PW0KQ09O RklHX1NORF9TT0NfQUs0NTU0PW0KQ09ORklHX1NORF9TT0NfQUs0NjEzPW0KQ09ORklHX1NO RF9TT0NfQUs0NjQyPW0KQ09ORklHX1NORF9TT0NfQUs1Mzg2PW0KQ09ORklHX1NORF9TT0Nf QUs1NTU4PW0KQ09ORklHX1NORF9TT0NfQUxDNTYyMz1tCkNPTkZJR19TTkRfU09DX0JEMjg2 MjM9bQojIENPTkZJR19TTkRfU09DX0JUX1NDTyBpcyBub3Qgc2V0CkNPTkZJR19TTkRfU09D X0NST1NfRUNfQ09ERUM9bQpDT05GSUdfU05EX1NPQ19DUzM1TDMyPW0KQ09ORklHX1NORF9T T0NfQ1MzNUwzMz1tCkNPTkZJR19TTkRfU09DX0NTMzVMMzQ9bQpDT05GSUdfU05EX1NPQ19D UzM1TDM1PW0KQ09ORklHX1NORF9TT0NfQ1MzNUwzNj1tCkNPTkZJR19TTkRfU09DX0NTNDJM NDI9bQpDT05GSUdfU05EX1NPQ19DUzQyTDUxPW0KQ09ORklHX1NORF9TT0NfQ1M0Mkw1MV9J MkM9bQpDT05GSUdfU05EX1NPQ19DUzQyTDUyPW0KQ09ORklHX1NORF9TT0NfQ1M0Mkw1Nj1t CkNPTkZJR19TTkRfU09DX0NTNDJMNzM9bQpDT05GSUdfU05EX1NPQ19DUzQyMzQ9bQpDT05G SUdfU05EX1NPQ19DUzQyNjU9bQpDT05GSUdfU05EX1NPQ19DUzQyNzA9bQpDT05GSUdfU05E X1NPQ19DUzQyNzE9bQpDT05GSUdfU05EX1NPQ19DUzQyNzFfSTJDPW0KQ09ORklHX1NORF9T T0NfQ1M0MjcxX1NQST1tCkNPTkZJR19TTkRfU09DX0NTNDJYWDg9bQpDT05GSUdfU05EX1NP Q19DUzQyWFg4X0kyQz1tCkNPTkZJR19TTkRfU09DX0NTNDMxMzA9bQpDT05GSUdfU05EX1NP Q19DUzQzNDE9bQpDT05GSUdfU05EX1NPQ19DUzQzNDk9bQpDT05GSUdfU05EX1NPQ19DUzUz TDMwPW0KQ09ORklHX1NORF9TT0NfQ1gyMDcyWD1tCkNPTkZJR19TTkRfU09DX0RBNzIxMz1t CkNPTkZJR19TTkRfU09DX0RBNzIxOT1tCkNPTkZJR19TTkRfU09DX0RNSUM9bQpDT05GSUdf U05EX1NPQ19IRE1JX0NPREVDPW0KQ09ORklHX1NORF9TT0NfRVM3MTM0PW0KQ09ORklHX1NO RF9TT0NfRVM3MjQxPW0KQ09ORklHX1NORF9TT0NfRVM4MzE2PW0KQ09ORklHX1NORF9TT0Nf RVM4MzI4PW0KQ09ORklHX1NORF9TT0NfRVM4MzI4X0kyQz1tCkNPTkZJR19TTkRfU09DX0VT ODMyOF9TUEk9bQpDT05GSUdfU05EX1NPQ19HVE02MDE9bQpDT05GSUdfU05EX1NPQ19IREFD X0hETUk9bQpDT05GSUdfU05EX1NPQ19IREFDX0hEQT1tCkNPTkZJR19TTkRfU09DX0lOTk9f UkszMDM2PW0KQ09ORklHX1NORF9TT0NfTUFYOTgwODg9bQpDT05GSUdfU05EX1NPQ19NQVg5 ODA5MD1tCkNPTkZJR19TTkRfU09DX01BWDk4MzU3QT1tCkNPTkZJR19TTkRfU09DX01BWDk4 NTA0PW0KQ09ORklHX1NORF9TT0NfTUFYOTg2Nz1tCkNPTkZJR19TTkRfU09DX01BWDk4OTI3 PW0KQ09ORklHX1NORF9TT0NfTUFYOTgzNzM9bQpDT05GSUdfU05EX1NPQ19NQVg5ODM3M19J MkM9bQpDT05GSUdfU05EX1NPQ19NQVg5ODM3M19TRFc9bQpDT05GSUdfU05EX1NPQ19NQVg5 ODM5MD1tCkNPTkZJR19TTkRfU09DX01BWDk4NjA9bQpDT05GSUdfU05EX1NPQ19NU004OTE2 X1dDRF9ESUdJVEFMPW0KQ09ORklHX1NORF9TT0NfUENNMTY4MT1tCkNPTkZJR19TTkRfU09D X1BDTTE3ODk9bQpDT05GSUdfU05EX1NPQ19QQ00xNzg5X0kyQz1tCkNPTkZJR19TTkRfU09D X1BDTTE3OVg9bQpDT05GSUdfU05EX1NPQ19QQ00xNzlYX0kyQz1tCkNPTkZJR19TTkRfU09D X1BDTTE3OVhfU1BJPW0KQ09ORklHX1NORF9TT0NfUENNMTg2WD1tCkNPTkZJR19TTkRfU09D X1BDTTE4NlhfSTJDPW0KQ09ORklHX1NORF9TT0NfUENNMTg2WF9TUEk9bQpDT05GSUdfU05E X1NPQ19QQ00zMDYwPW0KQ09ORklHX1NORF9TT0NfUENNMzA2MF9JMkM9bQpDT05GSUdfU05E X1NPQ19QQ00zMDYwX1NQST1tCkNPTkZJR19TTkRfU09DX1BDTTMxNjhBPW0KQ09ORklHX1NO RF9TT0NfUENNMzE2OEFfSTJDPW0KQ09ORklHX1NORF9TT0NfUENNMzE2OEFfU1BJPW0KQ09O RklHX1NORF9TT0NfUENNNTEwMkE9bQpDT05GSUdfU05EX1NPQ19QQ001MTJ4PW0KQ09ORklH X1NORF9TT0NfUENNNTEyeF9JMkM9bQpDT05GSUdfU05EX1NPQ19QQ001MTJ4X1NQST1tCkNP TkZJR19TTkRfU09DX1JLMzMyOD1tCkNPTkZJR19TTkRfU09DX1JMNjIzMT1tCkNPTkZJR19T TkRfU09DX1JMNjM0N0E9bQpDT05GSUdfU05EX1NPQ19SVDI4Nj1tCkNPTkZJR19TTkRfU09D X1JUMjk4PW0KQ09ORklHX1NORF9TT0NfUlQxMDExPW0KQ09ORklHX1NORF9TT0NfUlQxMDE1 PW0KQ09ORklHX1NORF9TT0NfUlQxMzA4PW0KQ09ORklHX1NORF9TT0NfUlQxMzA4X1NEVz1t CkNPTkZJR19TTkRfU09DX1JUNTUxND1tCkNPTkZJR19TTkRfU09DX1JUNTUxNF9TUEk9bQpD T05GSUdfU05EX1NPQ19SVDU2MTY9bQpDT05GSUdfU05EX1NPQ19SVDU2MzE9bQpDT05GSUdf U05EX1NPQ19SVDU2NDA9bQpDT05GSUdfU05EX1NPQ19SVDU2NDU9bQpDT05GSUdfU05EX1NP Q19SVDU2NTE9bQpDT05GSUdfU05EX1NPQ19SVDU2NTk9bQpDT05GSUdfU05EX1NPQ19SVDU2 NjA9bQpDT05GSUdfU05EX1NPQ19SVDU2NjM9bQpDT05GSUdfU05EX1NPQ19SVDU2NzA9bQpD T05GSUdfU05EX1NPQ19SVDU2Nzc9bQpDT05GSUdfU05EX1NPQ19SVDU2NzdfU1BJPW0KQ09O RklHX1NORF9TT0NfUlQ1NjgyPW0KQ09ORklHX1NORF9TT0NfUlQ1NjgyX0kyQz1tCkNPTkZJ R19TTkRfU09DX1JUNTY4Ml9TRFc9bQpDT05GSUdfU05EX1NPQ19SVDcwMD1tCkNPTkZJR19T TkRfU09DX1JUNzAwX1NEVz1tCkNPTkZJR19TTkRfU09DX1JUNzExPW0KQ09ORklHX1NORF9T T0NfUlQ3MTFfU0RXPW0KQ09ORklHX1NORF9TT0NfUlQ3MTU9bQpDT05GSUdfU05EX1NPQ19S VDcxNV9TRFc9bQpDT05GSUdfU05EX1NPQ19TR1RMNTAwMD1tCkNPTkZJR19TTkRfU09DX1NJ NDc2WD1tCkNPTkZJR19TTkRfU09DX1NJR01BRFNQPW0KQ09ORklHX1NORF9TT0NfU0lHTUFE U1BfSTJDPW0KQ09ORklHX1NORF9TT0NfU0lHTUFEU1BfUkVHTUFQPW0KQ09ORklHX1NORF9T T0NfU0lNUExFX0FNUExJRklFUj1tCkNPTkZJR19TTkRfU09DX1NJTVBMRV9NVVg9bQojIENP TkZJR19TTkRfU09DX1NJUkZfQVVESU9fQ09ERUMgaXMgbm90IHNldApDT05GSUdfU05EX1NP Q19TUERJRj1tCkNPTkZJR19TTkRfU09DX1NTTTIzMDU9bQpDT05GSUdfU05EX1NPQ19TU00y NjAyPW0KQ09ORklHX1NORF9TT0NfU1NNMjYwMl9TUEk9bQpDT05GSUdfU05EX1NPQ19TU00y NjAyX0kyQz1tCkNPTkZJR19TTkRfU09DX1NTTTQ1Njc9bQpDT05GSUdfU05EX1NPQ19TVEEz Mlg9bQpDT05GSUdfU05EX1NPQ19TVEEzNTA9bQpDT05GSUdfU05EX1NPQ19TVElfU0FTPW0K Q09ORklHX1NORF9TT0NfVEFTMjU1Mj1tCkNPTkZJR19TTkRfU09DX1RBUzI1NjI9bQpDT05G SUdfU05EX1NPQ19UQVMyNzY0PW0KQ09ORklHX1NORF9TT0NfVEFTMjc3MD1tCkNPTkZJR19T TkRfU09DX1RBUzUwODY9bQpDT05GSUdfU05EX1NPQ19UQVM1NzFYPW0KQ09ORklHX1NORF9T T0NfVEFTNTcyMD1tCkNPTkZJR19TTkRfU09DX1RBUzY0MjQ9bQpDT05GSUdfU05EX1NPQ19U REE3NDE5PW0KQ09ORklHX1NORF9TT0NfVEZBOTg3OT1tCkNPTkZJR19TTkRfU09DX1RMVjMy MEFJQzIzPW0KQ09ORklHX1NORF9TT0NfVExWMzIwQUlDMjNfSTJDPW0KQ09ORklHX1NORF9T T0NfVExWMzIwQUlDMjNfU1BJPW0KQ09ORklHX1NORF9TT0NfVExWMzIwQUlDMzFYWD1tCkNP TkZJR19TTkRfU09DX1RMVjMyMEFJQzMyWDQ9bQpDT05GSUdfU05EX1NPQ19UTFYzMjBBSUMz Mlg0X0kyQz1tCkNPTkZJR19TTkRfU09DX1RMVjMyMEFJQzMyWDRfU1BJPW0KQ09ORklHX1NO RF9TT0NfVExWMzIwQUlDM1g9bQpDT05GSUdfU05EX1NPQ19UTFYzMjBBRENYMTQwPW0KQ09O RklHX1NORF9TT0NfVFMzQTIyN0U9bQpDT05GSUdfU05EX1NPQ19UU0NTNDJYWD1tCkNPTkZJ R19TTkRfU09DX1RTQ1M0NTQ9bQpDT05GSUdfU05EX1NPQ19VREExMzM0PW0KQ09ORklHX1NO RF9TT0NfV0NEOTMzNT1tCkNPTkZJR19TTkRfU09DX1dDRDkzNFg9bQpDT05GSUdfU05EX1NP Q19XTTUxMDI9bQpDT05GSUdfU05EX1NPQ19XTTg1MTA9bQpDT05GSUdfU05EX1NPQ19XTTg1 MjM9bQpDT05GSUdfU05EX1NPQ19XTTg1MjQ9bQpDT05GSUdfU05EX1NPQ19XTTg1ODA9bQpD T05GSUdfU05EX1NPQ19XTTg3MTE9bQpDT05GSUdfU05EX1NPQ19XTTg3Mjg9bQpDT05GSUdf U05EX1NPQ19XTTg3MzE9bQpDT05GSUdfU05EX1NPQ19XTTg3Mzc9bQpDT05GSUdfU05EX1NP Q19XTTg3NDE9bQpDT05GSUdfU05EX1NPQ19XTTg3NTA9bQpDT05GSUdfU05EX1NPQ19XTTg3 NTM9bQpDT05GSUdfU05EX1NPQ19XTTg3NzA9bQpDT05GSUdfU05EX1NPQ19XTTg3NzY9bQpD T05GSUdfU05EX1NPQ19XTTg3ODI9bQpDT05GSUdfU05EX1NPQ19XTTg4MDQ9bQpDT05GSUdf U05EX1NPQ19XTTg4MDRfSTJDPW0KQ09ORklHX1NORF9TT0NfV004ODA0X1NQST1tCkNPTkZJ R19TTkRfU09DX1dNODkwMz1tCkNPTkZJR19TTkRfU09DX1dNODkwND1tCkNPTkZJR19TTkRf U09DX1dNODk2MD1tCkNPTkZJR19TTkRfU09DX1dNODk2Mj1tCkNPTkZJR19TTkRfU09DX1dN ODk3ND1tCkNPTkZJR19TTkRfU09DX1dNODk3OD1tCkNPTkZJR19TTkRfU09DX1dNODk4NT1t CkNPTkZJR19TTkRfU09DX1dTQTg4MVg9bQpDT05GSUdfU05EX1NPQ19aTDM4MDYwPW0KQ09O RklHX1NORF9TT0NfWlhfQVVEOTZQMjI9bQpDT05GSUdfU05EX1NPQ19NQVg5NzU5PW0KQ09O RklHX1NORF9TT0NfTVQ2MzUxPW0KQ09ORklHX1NORF9TT0NfTVQ2MzU4PW0KQ09ORklHX1NO RF9TT0NfTVQ2NjYwPW0KQ09ORklHX1NORF9TT0NfTkFVODMxNT1tCkNPTkZJR19TTkRfU09D X05BVTg1NDA9bQpDT05GSUdfU05EX1NPQ19OQVU4ODEwPW0KQ09ORklHX1NORF9TT0NfTkFV ODgyMj1tCkNPTkZJR19TTkRfU09DX05BVTg4MjQ9bQpDT05GSUdfU05EX1NPQ19OQVU4ODI1 PW0KQ09ORklHX1NORF9TT0NfVFBBNjEzMEEyPW0KQ09ORklHX1NORF9TT0NfTFBBU1NfV1NB X01BQ1JPPW0KQ09ORklHX1NORF9TT0NfTFBBU1NfVkFfTUFDUk89bQpDT05GSUdfU05EX1NP Q19MUEFTU19SWF9NQUNSTz1tCkNPTkZJR19TTkRfU09DX0xQQVNTX1RYX01BQ1JPPW0KIyBl bmQgb2YgQ09ERUMgZHJpdmVycwoKQ09ORklHX1NORF9TSU1QTEVfQ0FSRF9VVElMUz1tCkNP TkZJR19TTkRfU0lNUExFX0NBUkQ9bQpDT05GSUdfU05EX1g4Nj15CkNPTkZJR19IRE1JX0xQ RV9BVURJTz1tCkNPTkZJR19TTkRfU1lOVEhfRU1VWD1tCkNPTkZJR19TTkRfWEVOX0ZST05U RU5EPW0KQ09ORklHX0FDOTdfQlVTPW0KCiMKIyBISUQgc3VwcG9ydAojCkNPTkZJR19ISUQ9 eQpDT05GSUdfSElEX0JBVFRFUllfU1RSRU5HVEg9eQpDT05GSUdfSElEUkFXPXkKQ09ORklH X1VISUQ9bQpDT05GSUdfSElEX0dFTkVSSUM9eQoKIwojIFNwZWNpYWwgSElEIGRyaXZlcnMK IwpDT05GSUdfSElEX0E0VEVDSD1tCkNPTkZJR19ISURfQUNDVVRPVUNIPW0KQ09ORklHX0hJ RF9BQ1JVWD1tCkNPTkZJR19ISURfQUNSVVhfRkY9eQpDT05GSUdfSElEX0FQUExFPW0KQ09O RklHX0hJRF9BUFBMRUlSPW0KQ09ORklHX0hJRF9BU1VTPW0KQ09ORklHX0hJRF9BVVJFQUw9 bQpDT05GSUdfSElEX0JFTEtJTj1tCkNPTkZJR19ISURfQkVUT1BfRkY9bQpDT05GSUdfSElE X0JJR0JFTl9GRj1tCkNPTkZJR19ISURfQ0hFUlJZPW0KQ09ORklHX0hJRF9DSElDT05ZPW0K Q09ORklHX0hJRF9DT1JTQUlSPW0KQ09ORklHX0hJRF9DT1VHQVI9bQpDT05GSUdfSElEX01B Q0FMTFk9bQpDT05GSUdfSElEX1BST0RJS0VZUz1tCkNPTkZJR19ISURfQ01FRElBPW0KQ09O RklHX0hJRF9DUDIxMTI9bQpDT05GSUdfSElEX0NSRUFUSVZFX1NCMDU0MD1tCkNPTkZJR19I SURfQ1lQUkVTUz1tCkNPTkZJR19ISURfRFJBR09OUklTRT1tCkNPTkZJR19EUkFHT05SSVNF X0ZGPXkKQ09ORklHX0hJRF9FTVNfRkY9bQpDT05GSUdfSElEX0VMQU49bQpDT05GSUdfSElE X0VMRUNPTT1tCkNPTkZJR19ISURfRUxPPW0KQ09ORklHX0hJRF9FWktFWT1tCkNPTkZJR19I SURfR0VNQklSRD1tCkNPTkZJR19ISURfR0ZSTT1tCkNPTkZJR19ISURfR0xPUklPVVM9bQpD T05GSUdfSElEX0hPTFRFSz1tCkNPTkZJR19IT0xURUtfRkY9eQpDT05GSUdfSElEX0dPT0dM RV9IQU1NRVI9bQpDT05GSUdfSElEX1ZJVkFMREk9bQpDT05GSUdfSElEX0dUNjgzUj1tCkNP TkZJR19ISURfS0VZVE9VQ0g9bQpDT05GSUdfSElEX0tZRT1tCkNPTkZJR19ISURfVUNMT0dJ Qz1tCkNPTkZJR19ISURfV0FMVE9QPW0KQ09ORklHX0hJRF9WSUVXU09OSUM9bQpDT05GSUdf SElEX0dZUkFUSU9OPW0KQ09ORklHX0hJRF9JQ0FERT1tCkNPTkZJR19ISURfSVRFPW0KQ09O RklHX0hJRF9KQUJSQT1tCkNPTkZJR19ISURfVFdJTkhBTj1tCkNPTkZJR19ISURfS0VOU0lO R1RPTj1tCkNPTkZJR19ISURfTENQT1dFUj1tCkNPTkZJR19ISURfTEVEPW0KQ09ORklHX0hJ RF9MRU5PVk89bQpDT05GSUdfSElEX0xPR0lURUNIPW0KQ09ORklHX0hJRF9MT0dJVEVDSF9E Sj1tCkNPTkZJR19ISURfTE9HSVRFQ0hfSElEUFA9bQpDT05GSUdfTE9HSVRFQ0hfRkY9eQpD T05GSUdfTE9HSVJVTUJMRVBBRDJfRkY9eQpDT05GSUdfTE9HSUc5NDBfRkY9eQpDT05GSUdf TE9HSVdIRUVMU19GRj15CkNPTkZJR19ISURfTUFHSUNNT1VTRT1tCkNPTkZJR19ISURfTUFM VFJPTj1tCkNPTkZJR19ISURfTUFZRkxBU0g9bQpDT05GSUdfSElEX1JFRFJBR09OPW0KQ09O RklHX0hJRF9NSUNST1NPRlQ9bQpDT05GSUdfSElEX01PTlRFUkVZPW0KQ09ORklHX0hJRF9N VUxUSVRPVUNIPW0KQ09ORklHX0hJRF9OVEk9bQpDT05GSUdfSElEX05UUklHPW0KQ09ORklH X0hJRF9PUlRFSz1tCkNPTkZJR19ISURfUEFOVEhFUkxPUkQ9bQpDT05GSUdfUEFOVEhFUkxP UkRfRkY9eQpDT05GSUdfSElEX1BFTk1PVU5UPW0KQ09ORklHX0hJRF9QRVRBTFlOWD1tCkNP TkZJR19ISURfUElDT0xDRD1tCkNPTkZJR19ISURfUElDT0xDRF9GQj15CkNPTkZJR19ISURf UElDT0xDRF9CQUNLTElHSFQ9eQpDT05GSUdfSElEX1BJQ09MQ0RfTENEPXkKQ09ORklHX0hJ RF9QSUNPTENEX0xFRFM9eQpDT05GSUdfSElEX1BJQ09MQ0RfQ0lSPXkKQ09ORklHX0hJRF9Q TEFOVFJPTklDUz1tCkNPTkZJR19ISURfUExBWVNUQVRJT049bQpDT05GSUdfUExBWVNUQVRJ T05fRkY9eQpDT05GSUdfSElEX1BSSU1BWD1tCkNPTkZJR19ISURfUkVUUk9ERT1tCkNPTkZJ R19ISURfUk9DQ0FUPW0KQ09ORklHX0hJRF9TQUlURUs9bQpDT05GSUdfSElEX1NBTVNVTkc9 bQpDT05GSUdfSElEX1NPTlk9bQpDT05GSUdfU09OWV9GRj15CkNPTkZJR19ISURfU1BFRURM SU5LPW0KQ09ORklHX0hJRF9TVEVBTT1tCkNPTkZJR19ISURfU1RFRUxTRVJJRVM9bQpDT05G SUdfSElEX1NVTlBMVVM9bQpDT05GSUdfSElEX1JNST1tCkNPTkZJR19ISURfR1JFRU5BU0lB PW0KQ09ORklHX0dSRUVOQVNJQV9GRj15CkNPTkZJR19ISURfSFlQRVJWX01PVVNFPW0KQ09O RklHX0hJRF9TTUFSVEpPWVBMVVM9bQpDT05GSUdfU01BUlRKT1lQTFVTX0ZGPXkKQ09ORklH X0hJRF9USVZPPW0KQ09ORklHX0hJRF9UT1BTRUVEPW0KQ09ORklHX0hJRF9USElOR009bQpD T05GSUdfSElEX1RIUlVTVE1BU1RFUj1tCkNPTkZJR19USFJVU1RNQVNURVJfRkY9eQpDT05G SUdfSElEX1VEUkFXX1BTMz1tCkNPTkZJR19ISURfVTJGWkVSTz1tCkNPTkZJR19ISURfV0FD T009bQpDT05GSUdfSElEX1dJSU1PVEU9bQpDT05GSUdfSElEX1hJTk1PPW0KQ09ORklHX0hJ RF9aRVJPUExVUz1tCkNPTkZJR19aRVJPUExVU19GRj15CkNPTkZJR19ISURfWllEQUNST049 bQpDT05GSUdfSElEX1NFTlNPUl9IVUI9bQpDT05GSUdfSElEX1NFTlNPUl9DVVNUT01fU0VO U09SPW0KQ09ORklHX0hJRF9BTFBTPW0KQ09ORklHX0hJRF9NQ1AyMjIxPW0KIyBlbmQgb2Yg U3BlY2lhbCBISUQgZHJpdmVycwoKIwojIFVTQiBISUQgc3VwcG9ydAojCkNPTkZJR19VU0Jf SElEPW0KQ09ORklHX0hJRF9QSUQ9eQpDT05GSUdfVVNCX0hJRERFVj15CiMgZW5kIG9mIFVT QiBISUQgc3VwcG9ydAoKIwojIEkyQyBISUQgc3VwcG9ydAojCkNPTkZJR19JMkNfSElEX0FD UEk9bQojIGVuZCBvZiBJMkMgSElEIHN1cHBvcnQKCkNPTkZJR19JMkNfSElEX0NPUkU9bQoK IwojIEludGVsIElTSCBISUQgc3VwcG9ydAojCkNPTkZJR19JTlRFTF9JU0hfSElEPW0KQ09O RklHX0lOVEVMX0lTSF9GSVJNV0FSRV9ET1dOTE9BREVSPW0KIyBlbmQgb2YgSW50ZWwgSVNI IEhJRCBzdXBwb3J0CgojCiMgQU1EIFNGSCBISUQgU3VwcG9ydAojCkNPTkZJR19BTURfU0ZI X0hJRD1tCiMgZW5kIG9mIEFNRCBTRkggSElEIFN1cHBvcnQKIyBlbmQgb2YgSElEIHN1cHBv cnQKCkNPTkZJR19VU0JfT0hDSV9MSVRUTEVfRU5ESUFOPXkKQ09ORklHX1VTQl9TVVBQT1JU PXkKQ09ORklHX1VTQl9DT01NT049eQpDT05GSUdfVVNCX0xFRF9UUklHPXkKQ09ORklHX1VT Ql9VTFBJX0JVUz1tCkNPTkZJR19VU0JfQ09OTl9HUElPPW0KQ09ORklHX1VTQl9BUkNIX0hB U19IQ0Q9eQpDT05GSUdfVVNCPXkKQ09ORklHX1VTQl9QQ0k9eQpDT05GSUdfVVNCX0FOTk9V TkNFX05FV19ERVZJQ0VTPXkKCiMKIyBNaXNjZWxsYW5lb3VzIFVTQiBvcHRpb25zCiMKQ09O RklHX1VTQl9ERUZBVUxUX1BFUlNJU1Q9eQojIENPTkZJR19VU0JfRkVXX0lOSVRfUkVUUklF UyBpcyBub3Qgc2V0CiMgQ09ORklHX1VTQl9EWU5BTUlDX01JTk9SUyBpcyBub3Qgc2V0CiMg Q09ORklHX1VTQl9PVEcgaXMgbm90IHNldAojIENPTkZJR19VU0JfT1RHX1BST0RVQ1RMSVNU IGlzIG5vdCBzZXQKQ09ORklHX1VTQl9MRURTX1RSSUdHRVJfVVNCUE9SVD1tCkNPTkZJR19V U0JfQVVUT1NVU1BFTkRfREVMQVk9MgpDT05GSUdfVVNCX01PTj1tCgojCiMgVVNCIEhvc3Qg Q29udHJvbGxlciBEcml2ZXJzCiMKQ09ORklHX1VTQl9DNjdYMDBfSENEPW0KQ09ORklHX1VT Ql9YSENJX0hDRD15CiMgQ09ORklHX1VTQl9YSENJX0RCR0NBUCBpcyBub3Qgc2V0CkNPTkZJ R19VU0JfWEhDSV9QQ0k9bQpDT05GSUdfVVNCX1hIQ0lfUENJX1JFTkVTQVM9bQpDT05GSUdf VVNCX1hIQ0lfUExBVEZPUk09bQpDT05GSUdfVVNCX0VIQ0lfSENEPXkKQ09ORklHX1VTQl9F SENJX1JPT1RfSFVCX1RUPXkKQ09ORklHX1VTQl9FSENJX1RUX05FV1NDSEVEPXkKQ09ORklH X1VTQl9FSENJX1BDST15CkNPTkZJR19VU0JfRUhDSV9GU0w9bQpDT05GSUdfVVNCX0VIQ0lf SENEX1BMQVRGT1JNPW0KQ09ORklHX1VTQl9PWFUyMTBIUF9IQ0Q9bQpDT05GSUdfVVNCX0lT UDExNlhfSENEPW0KQ09ORklHX1VTQl9GT1RHMjEwX0hDRD1tCkNPTkZJR19VU0JfTUFYMzQy MV9IQ0Q9bQpDT05GSUdfVVNCX09IQ0lfSENEPXkKQ09ORklHX1VTQl9PSENJX0hDRF9QQ0k9 eQpDT05GSUdfVVNCX09IQ0lfSENEX1BMQVRGT1JNPW0KQ09ORklHX1VTQl9VSENJX0hDRD15 CkNPTkZJR19VU0JfVTEzMl9IQ0Q9bQpDT05GSUdfVVNCX1NMODExX0hDRD1tCiMgQ09ORklH X1VTQl9TTDgxMV9IQ0RfSVNPIGlzIG5vdCBzZXQKQ09ORklHX1VTQl9TTDgxMV9DUz1tCkNP TkZJR19VU0JfUjhBNjY1OTdfSENEPW0KQ09ORklHX1VTQl9IQ0RfQkNNQT1tCkNPTkZJR19V U0JfSENEX1NTQj1tCiMgQ09ORklHX1VTQl9IQ0RfVEVTVF9NT0RFIGlzIG5vdCBzZXQKCiMK IyBVU0IgRGV2aWNlIENsYXNzIGRyaXZlcnMKIwpDT05GSUdfVVNCX0FDTT1tCkNPTkZJR19V U0JfUFJJTlRFUj1tCkNPTkZJR19VU0JfV0RNPW0KQ09ORklHX1VTQl9UTUM9bQoKIwojIE5P VEU6IFVTQl9TVE9SQUdFIGRlcGVuZHMgb24gU0NTSSBidXQgQkxLX0RFVl9TRCBtYXkKIwoK IwojIGFsc28gYmUgbmVlZGVkOyBzZWUgVVNCX1NUT1JBR0UgSGVscCBmb3IgbW9yZSBpbmZv CiMKQ09ORklHX1VTQl9TVE9SQUdFPW0KIyBDT05GSUdfVVNCX1NUT1JBR0VfREVCVUcgaXMg bm90IHNldApDT05GSUdfVVNCX1NUT1JBR0VfUkVBTFRFSz1tCkNPTkZJR19SRUFMVEVLX0FV VE9QTT15CkNPTkZJR19VU0JfU1RPUkFHRV9EQVRBRkFCPW0KQ09ORklHX1VTQl9TVE9SQUdF X0ZSRUVDT009bQpDT05GSUdfVVNCX1NUT1JBR0VfSVNEMjAwPW0KQ09ORklHX1VTQl9TVE9S QUdFX1VTQkFUPW0KQ09ORklHX1VTQl9TVE9SQUdFX1NERFIwOT1tCkNPTkZJR19VU0JfU1RP UkFHRV9TRERSNTU9bQpDT05GSUdfVVNCX1NUT1JBR0VfSlVNUFNIT1Q9bQpDT05GSUdfVVNC X1NUT1JBR0VfQUxBVURBPW0KQ09ORklHX1VTQl9TVE9SQUdFX09ORVRPVUNIPW0KQ09ORklH X1VTQl9TVE9SQUdFX0tBUk1BPW0KQ09ORklHX1VTQl9TVE9SQUdFX0NZUFJFU1NfQVRBQ0I9 bQpDT05GSUdfVVNCX1NUT1JBR0VfRU5FX1VCNjI1MD1tCkNPTkZJR19VU0JfVUFTPW0KCiMK IyBVU0IgSW1hZ2luZyBkZXZpY2VzCiMKQ09ORklHX1VTQl9NREM4MDA9bQpDT05GSUdfVVNC X01JQ1JPVEVLPW0KQ09ORklHX1VTQklQX0NPUkU9bQpDT05GSUdfVVNCSVBfVkhDSV9IQ0Q9 bQpDT05GSUdfVVNCSVBfVkhDSV9IQ19QT1JUUz04CkNPTkZJR19VU0JJUF9WSENJX05SX0hD Uz0xCkNPTkZJR19VU0JJUF9IT1NUPW0KQ09ORklHX1VTQklQX1ZVREM9bQojIENPTkZJR19V U0JJUF9ERUJVRyBpcyBub3Qgc2V0CkNPTkZJR19VU0JfQ0ROU19TVVBQT1JUPW0KQ09ORklH X1VTQl9DRE5TX0hPU1Q9eQpDT05GSUdfVVNCX0NETlMzPW0KQ09ORklHX1VTQl9DRE5TM19H QURHRVQ9eQpDT05GSUdfVVNCX0NETlMzX0hPU1Q9eQpDT05GSUdfVVNCX0NETlMzX1BDSV9X UkFQPW0KQ09ORklHX1VTQl9DRE5TUF9QQ0k9bQpDT05GSUdfVVNCX0NETlNQX0dBREdFVD15 CkNPTkZJR19VU0JfQ0ROU1BfSE9TVD15CkNPTkZJR19VU0JfTVVTQl9IRFJDPW0KIyBDT05G SUdfVVNCX01VU0JfSE9TVCBpcyBub3Qgc2V0CiMgQ09ORklHX1VTQl9NVVNCX0dBREdFVCBp cyBub3Qgc2V0CkNPTkZJR19VU0JfTVVTQl9EVUFMX1JPTEU9eQoKIwojIFBsYXRmb3JtIEds dWUgTGF5ZXIKIwoKIwojIE1VU0IgRE1BIG1vZGUKIwojIENPTkZJR19NVVNCX1BJT19PTkxZ IGlzIG5vdCBzZXQKQ09ORklHX1VTQl9EV0MzPW0KQ09ORklHX1VTQl9EV0MzX1VMUEk9eQoj IENPTkZJR19VU0JfRFdDM19IT1NUIGlzIG5vdCBzZXQKIyBDT05GSUdfVVNCX0RXQzNfR0FE R0VUIGlzIG5vdCBzZXQKQ09ORklHX1VTQl9EV0MzX0RVQUxfUk9MRT15CgojCiMgUGxhdGZv cm0gR2x1ZSBEcml2ZXIgU3VwcG9ydAojCkNPTkZJR19VU0JfRFdDM19QQ0k9bQpDT05GSUdf VVNCX0RXQzNfSEFQUz1tCkNPTkZJR19VU0JfRFdDMj1tCiMgQ09ORklHX1VTQl9EV0MyX0hP U1QgaXMgbm90IHNldAoKIwojIEdhZGdldC9EdWFsLXJvbGUgbW9kZSByZXF1aXJlcyBVU0Ig R2FkZ2V0IHN1cHBvcnQgdG8gYmUgZW5hYmxlZAojCiMgQ09ORklHX1VTQl9EV0MyX1BFUklQ SEVSQUwgaXMgbm90IHNldApDT05GSUdfVVNCX0RXQzJfRFVBTF9ST0xFPXkKQ09ORklHX1VT Ql9EV0MyX1BDST1tCiMgQ09ORklHX1VTQl9EV0MyX0RFQlVHIGlzIG5vdCBzZXQKIyBDT05G SUdfVVNCX0RXQzJfVFJBQ0tfTUlTU0VEX1NPRlMgaXMgbm90IHNldApDT05GSUdfVVNCX0NI SVBJREVBPW0KQ09ORklHX1VTQl9DSElQSURFQV9VREM9eQpDT05GSUdfVVNCX0NISVBJREVB X0hPU1Q9eQpDT05GSUdfVVNCX0NISVBJREVBX1BDST1tCkNPTkZJR19VU0JfQ0hJUElERUFf TVNNPW0KQ09ORklHX1VTQl9DSElQSURFQV9HRU5FUklDPW0KQ09ORklHX1VTQl9JU1AxNzYw PW0KQ09ORklHX1VTQl9JU1AxNzYwX0hDRD15CkNPTkZJR19VU0JfSVNQMTc2MV9VREM9eQoj IENPTkZJR19VU0JfSVNQMTc2MF9IT1NUX1JPTEUgaXMgbm90IHNldAojIENPTkZJR19VU0Jf SVNQMTc2MF9HQURHRVRfUk9MRSBpcyBub3Qgc2V0CkNPTkZJR19VU0JfSVNQMTc2MF9EVUFM X1JPTEU9eQoKIwojIFVTQiBwb3J0IGRyaXZlcnMKIwpDT05GSUdfVVNCX1VTUzcyMD1tCkNP TkZJR19VU0JfU0VSSUFMPXkKQ09ORklHX1VTQl9TRVJJQUxfQ09OU09MRT15CkNPTkZJR19V U0JfU0VSSUFMX0dFTkVSSUM9eQpDT05GSUdfVVNCX1NFUklBTF9TSU1QTEU9bQpDT05GSUdf VVNCX1NFUklBTF9BSVJDQUJMRT1tCkNPTkZJR19VU0JfU0VSSUFMX0FSSzMxMTY9bQpDT05G SUdfVVNCX1NFUklBTF9CRUxLSU49bQpDT05GSUdfVVNCX1NFUklBTF9DSDM0MT1tCkNPTkZJ R19VU0JfU0VSSUFMX1dISVRFSEVBVD1tCkNPTkZJR19VU0JfU0VSSUFMX0RJR0lfQUNDRUxF UE9SVD1tCkNPTkZJR19VU0JfU0VSSUFMX0NQMjEwWD1tCkNPTkZJR19VU0JfU0VSSUFMX0NZ UFJFU1NfTTg9bQpDT05GSUdfVVNCX1NFUklBTF9FTVBFRz1tCkNPTkZJR19VU0JfU0VSSUFM X0ZURElfU0lPPW0KQ09ORklHX1VTQl9TRVJJQUxfVklTT1I9bQpDT05GSUdfVVNCX1NFUklB TF9JUEFRPW0KQ09ORklHX1VTQl9TRVJJQUxfSVI9bQpDT05GSUdfVVNCX1NFUklBTF9FREdF UE9SVD1tCkNPTkZJR19VU0JfU0VSSUFMX0VER0VQT1JUX1RJPW0KQ09ORklHX1VTQl9TRVJJ QUxfRjgxMjMyPW0KQ09ORklHX1VTQl9TRVJJQUxfRjgxNTNYPW0KQ09ORklHX1VTQl9TRVJJ QUxfR0FSTUlOPW0KQ09ORklHX1VTQl9TRVJJQUxfSVBXPW0KQ09ORklHX1VTQl9TRVJJQUxf SVVVPW0KQ09ORklHX1VTQl9TRVJJQUxfS0VZU1BBTl9QREE9bQpDT05GSUdfVVNCX1NFUklB TF9LRVlTUEFOPW0KQ09ORklHX1VTQl9TRVJJQUxfS0xTST1tCkNPTkZJR19VU0JfU0VSSUFM X0tPQklMX1NDVD1tCkNPTkZJR19VU0JfU0VSSUFMX01DVF9VMjMyPW0KQ09ORklHX1VTQl9T RVJJQUxfTUVUUk89bQpDT05GSUdfVVNCX1NFUklBTF9NT1M3NzIwPW0KQ09ORklHX1VTQl9T RVJJQUxfTU9TNzcxNV9QQVJQT1JUPXkKQ09ORklHX1VTQl9TRVJJQUxfTU9TNzg0MD1tCkNP TkZJR19VU0JfU0VSSUFMX01YVVBPUlQ9bQpDT05GSUdfVVNCX1NFUklBTF9OQVZNQU49bQpD T05GSUdfVVNCX1NFUklBTF9QTDIzMDM9bQpDT05GSUdfVVNCX1NFUklBTF9PVEk2ODU4PW0K Q09ORklHX1VTQl9TRVJJQUxfUUNBVVg9bQpDT05GSUdfVVNCX1NFUklBTF9RVUFMQ09NTT1t CkNPTkZJR19VU0JfU0VSSUFMX1NQQ1A4WDU9bQpDT05GSUdfVVNCX1NFUklBTF9TQUZFPW0K IyBDT05GSUdfVVNCX1NFUklBTF9TQUZFX1BBRERFRCBpcyBub3Qgc2V0CkNPTkZJR19VU0Jf U0VSSUFMX1NJRVJSQVdJUkVMRVNTPW0KQ09ORklHX1VTQl9TRVJJQUxfU1lNQk9MPW0KQ09O RklHX1VTQl9TRVJJQUxfVEk9bQpDT05GSUdfVVNCX1NFUklBTF9DWUJFUkpBQ0s9bQpDT05G SUdfVVNCX1NFUklBTF9XV0FOPW0KQ09ORklHX1VTQl9TRVJJQUxfT1BUSU9OPW0KQ09ORklH X1VTQl9TRVJJQUxfT01OSU5FVD1tCkNPTkZJR19VU0JfU0VSSUFMX09QVElDT049bQpDT05G SUdfVVNCX1NFUklBTF9YU0VOU19NVD1tCkNPTkZJR19VU0JfU0VSSUFMX1dJU0hCT05FPW0K Q09ORklHX1VTQl9TRVJJQUxfU1NVMTAwPW0KQ09ORklHX1VTQl9TRVJJQUxfUVQyPW0KQ09O RklHX1VTQl9TRVJJQUxfVVBENzhGMDczMD1tCkNPTkZJR19VU0JfU0VSSUFMX1hSPW0KQ09O RklHX1VTQl9TRVJJQUxfREVCVUc9bQoKIwojIFVTQiBNaXNjZWxsYW5lb3VzIGRyaXZlcnMK IwpDT05GSUdfVVNCX0VNSTYyPW0KQ09ORklHX1VTQl9FTUkyNj1tCkNPTkZJR19VU0JfQURV VFVYPW0KQ09ORklHX1VTQl9TRVZTRUc9bQpDT05GSUdfVVNCX0xFR09UT1dFUj1tCkNPTkZJ R19VU0JfTENEPW0KQ09ORklHX1VTQl9DWVBSRVNTX0NZN0M2Mz1tCkNPTkZJR19VU0JfQ1lU SEVSTT1tCkNPTkZJR19VU0JfSURNT1VTRT1tCkNPTkZJR19VU0JfRlRESV9FTEFOPW0KQ09O RklHX1VTQl9BUFBMRURJU1BMQVk9bQpDT05GSUdfQVBQTEVfTUZJX0ZBU1RDSEFSR0U9bQpD T05GSUdfVVNCX1NJU1VTQlZHQT1tCkNPTkZJR19VU0JfTEQ9bQpDT05GSUdfVVNCX1RSQU5D RVZJQlJBVE9SPW0KQ09ORklHX1VTQl9JT1dBUlJJT1I9bQpDT05GSUdfVVNCX1RFU1Q9bQpD T05GSUdfVVNCX0VIU0VUX1RFU1RfRklYVFVSRT1tCkNPTkZJR19VU0JfSVNJR0hURlc9bQpD T05GSUdfVVNCX1lVUkVYPW0KQ09ORklHX1VTQl9FWlVTQl9GWDI9bQpDT05GSUdfVVNCX0hV Ql9VU0IyNTFYQj1tCkNPTkZJR19VU0JfSFNJQ19VU0IzNTAzPW0KQ09ORklHX1VTQl9IU0lD X1VTQjQ2MDQ9bQpDT05GSUdfVVNCX0xJTktfTEFZRVJfVEVTVD1tCkNPTkZJR19VU0JfQ0hB T1NLRVk9bQpDT05GSUdfVVNCX0FUTT1tCkNPTkZJR19VU0JfU1BFRURUT1VDSD1tCkNPTkZJ R19VU0JfQ1hBQ1JVPW0KQ09ORklHX1VTQl9VRUFHTEVBVE09bQpDT05GSUdfVVNCX1hVU0JB VE09bQoKIwojIFVTQiBQaHlzaWNhbCBMYXllciBkcml2ZXJzCiMKQ09ORklHX1VTQl9QSFk9 eQpDT05GSUdfTk9QX1VTQl9YQ0VJVj1tCkNPTkZJR19VU0JfR1BJT19WQlVTPW0KQ09ORklH X1RBSFZPX1VTQj1tCiMgQ09ORklHX1RBSFZPX1VTQl9IT1NUX0JZX0RFRkFVTFQgaXMgbm90 IHNldApDT05GSUdfVVNCX0lTUDEzMDE9bQojIGVuZCBvZiBVU0IgUGh5c2ljYWwgTGF5ZXIg ZHJpdmVycwoKQ09ORklHX1VTQl9HQURHRVQ9bQojIENPTkZJR19VU0JfR0FER0VUX0RFQlVH IGlzIG5vdCBzZXQKIyBDT05GSUdfVVNCX0dBREdFVF9ERUJVR19GSUxFUyBpcyBub3Qgc2V0 CiMgQ09ORklHX1VTQl9HQURHRVRfREVCVUdfRlMgaXMgbm90IHNldApDT05GSUdfVVNCX0dB REdFVF9WQlVTX0RSQVc9MgpDT05GSUdfVVNCX0dBREdFVF9TVE9SQUdFX05VTV9CVUZGRVJT PTIKQ09ORklHX1VfU0VSSUFMX0NPTlNPTEU9eQoKIwojIFVTQiBQZXJpcGhlcmFsIENvbnRy b2xsZXIKIwpDT05GSUdfVVNCX0ZPVEcyMTBfVURDPW0KQ09ORklHX1VTQl9HUl9VREM9bQpD T05GSUdfVVNCX1I4QTY2NTk3PW0KQ09ORklHX1VTQl9QWEEyN1g9bQpDT05GSUdfVVNCX01W X1VEQz1tCkNPTkZJR19VU0JfTVZfVTNEPW0KQ09ORklHX1VTQl9TTlBfQ09SRT1tCkNPTkZJ R19VU0JfTTY2NTkyPW0KQ09ORklHX1VTQl9CRENfVURDPW0KQ09ORklHX1VTQl9BTUQ1NTM2 VURDPW0KQ09ORklHX1VTQl9ORVQyMjcyPW0KIyBDT05GSUdfVVNCX05FVDIyNzJfRE1BIGlz IG5vdCBzZXQKQ09ORklHX1VTQl9ORVQyMjgwPW0KQ09ORklHX1VTQl9HT0tVPW0KQ09ORklH X1VTQl9FRzIwVD1tCkNPTkZJR19VU0JfTUFYMzQyMF9VREM9bQpDT05GSUdfVVNCX0RVTU1Z X0hDRD1tCiMgZW5kIG9mIFVTQiBQZXJpcGhlcmFsIENvbnRyb2xsZXIKCkNPTkZJR19VU0Jf TElCQ09NUE9TSVRFPW0KQ09ORklHX1VTQl9GX0FDTT1tCkNPTkZJR19VU0JfRl9TU19MQj1t CkNPTkZJR19VU0JfVV9TRVJJQUw9bQpDT05GSUdfVVNCX1VfRVRIRVI9bQpDT05GSUdfVVNC X1VfQVVESU89bQpDT05GSUdfVVNCX0ZfU0VSSUFMPW0KQ09ORklHX1VTQl9GX09CRVg9bQpD T05GSUdfVVNCX0ZfTkNNPW0KQ09ORklHX1VTQl9GX0VDTT1tCkNPTkZJR19VU0JfRl9QSE9O RVQ9bQpDT05GSUdfVVNCX0ZfRUVNPW0KQ09ORklHX1VTQl9GX1NVQlNFVD1tCkNPTkZJR19V U0JfRl9STkRJUz1tCkNPTkZJR19VU0JfRl9NQVNTX1NUT1JBR0U9bQpDT05GSUdfVVNCX0Zf RlM9bQpDT05GSUdfVVNCX0ZfVUFDMT1tCkNPTkZJR19VU0JfRl9VQUMxX0xFR0FDWT1tCkNP TkZJR19VU0JfRl9VQUMyPW0KQ09ORklHX1VTQl9GX1VWQz1tCkNPTkZJR19VU0JfRl9NSURJ PW0KQ09ORklHX1VTQl9GX0hJRD1tCkNPTkZJR19VU0JfRl9QUklOVEVSPW0KQ09ORklHX1VT Ql9GX1RDTT1tCkNPTkZJR19VU0JfQ09ORklHRlM9bQpDT05GSUdfVVNCX0NPTkZJR0ZTX1NF UklBTD15CkNPTkZJR19VU0JfQ09ORklHRlNfQUNNPXkKQ09ORklHX1VTQl9DT05GSUdGU19P QkVYPXkKQ09ORklHX1VTQl9DT05GSUdGU19OQ009eQpDT05GSUdfVVNCX0NPTkZJR0ZTX0VD TT15CkNPTkZJR19VU0JfQ09ORklHRlNfRUNNX1NVQlNFVD15CkNPTkZJR19VU0JfQ09ORklH RlNfUk5ESVM9eQpDT05GSUdfVVNCX0NPTkZJR0ZTX0VFTT15CkNPTkZJR19VU0JfQ09ORklH RlNfUEhPTkVUPXkKQ09ORklHX1VTQl9DT05GSUdGU19NQVNTX1NUT1JBR0U9eQpDT05GSUdf VVNCX0NPTkZJR0ZTX0ZfTEJfU1M9eQpDT05GSUdfVVNCX0NPTkZJR0ZTX0ZfRlM9eQpDT05G SUdfVVNCX0NPTkZJR0ZTX0ZfVUFDMT15CkNPTkZJR19VU0JfQ09ORklHRlNfRl9VQUMxX0xF R0FDWT15CkNPTkZJR19VU0JfQ09ORklHRlNfRl9VQUMyPXkKQ09ORklHX1VTQl9DT05GSUdG U19GX01JREk9eQpDT05GSUdfVVNCX0NPTkZJR0ZTX0ZfSElEPXkKQ09ORklHX1VTQl9DT05G SUdGU19GX1VWQz15CkNPTkZJR19VU0JfQ09ORklHRlNfRl9QUklOVEVSPXkKQ09ORklHX1VT Ql9DT05GSUdGU19GX1RDTT15CgojCiMgVVNCIEdhZGdldCBwcmVjb21wb3NlZCBjb25maWd1 cmF0aW9ucwojCkNPTkZJR19VU0JfWkVSTz1tCkNPTkZJR19VU0JfQVVESU89bQojIENPTkZJ R19HQURHRVRfVUFDMSBpcyBub3Qgc2V0CkNPTkZJR19VU0JfRVRIPW0KQ09ORklHX1VTQl9F VEhfUk5ESVM9eQpDT05GSUdfVVNCX0VUSF9FRU09eQpDT05GSUdfVVNCX0dfTkNNPW0KQ09O RklHX1VTQl9HQURHRVRGUz1tCkNPTkZJR19VU0JfRlVOQ1RJT05GUz1tCkNPTkZJR19VU0Jf RlVOQ1RJT05GU19FVEg9eQpDT05GSUdfVVNCX0ZVTkNUSU9ORlNfUk5ESVM9eQpDT05GSUdf VVNCX0ZVTkNUSU9ORlNfR0VORVJJQz15CkNPTkZJR19VU0JfTUFTU19TVE9SQUdFPW0KQ09O RklHX1VTQl9HQURHRVRfVEFSR0VUPW0KQ09ORklHX1VTQl9HX1NFUklBTD1tCkNPTkZJR19V U0JfTUlESV9HQURHRVQ9bQpDT05GSUdfVVNCX0dfUFJJTlRFUj1tCkNPTkZJR19VU0JfQ0RD X0NPTVBPU0lURT1tCkNPTkZJR19VU0JfR19OT0tJQT1tCkNPTkZJR19VU0JfR19BQ01fTVM9 bQpDT05GSUdfVVNCX0dfTVVMVEk9bQpDT05GSUdfVVNCX0dfTVVMVElfUk5ESVM9eQpDT05G SUdfVVNCX0dfTVVMVElfQ0RDPXkKQ09ORklHX1VTQl9HX0hJRD1tCkNPTkZJR19VU0JfR19E QkdQPW0KIyBDT05GSUdfVVNCX0dfREJHUF9QUklOVEsgaXMgbm90IHNldApDT05GSUdfVVNC X0dfREJHUF9TRVJJQUw9eQpDT05GSUdfVVNCX0dfV0VCQ0FNPW0KQ09ORklHX1VTQl9SQVdf R0FER0VUPW0KIyBlbmQgb2YgVVNCIEdhZGdldCBwcmVjb21wb3NlZCBjb25maWd1cmF0aW9u cwoKQ09ORklHX1RZUEVDPW0KQ09ORklHX1RZUEVDX1RDUE09bQpDT05GSUdfVFlQRUNfVENQ Q0k9bQpDT05GSUdfVFlQRUNfUlQxNzExSD1tCkNPTkZJR19UWVBFQ19NVDYzNjA9bQpDT05G SUdfVFlQRUNfVENQQ0lfTUFYSU09bQpDT05GSUdfVFlQRUNfRlVTQjMwMj1tCkNPTkZJR19U WVBFQ19XQ09WRT1tCkNPTkZJR19UWVBFQ19VQ1NJPW0KQ09ORklHX1VDU0lfQ0NHPW0KQ09O RklHX1VDU0lfQUNQST1tCkNPTkZJR19UWVBFQ19IRDNTUzMyMjA9bQpDT05GSUdfVFlQRUNf VFBTNjU5OFg9bQpDT05GSUdfVFlQRUNfU1RVU0IxNjBYPW0KCiMKIyBVU0IgVHlwZS1DIE11 bHRpcGxleGVyL0RlTXVsdGlwbGV4ZXIgU3dpdGNoIHN1cHBvcnQKIwpDT05GSUdfVFlQRUNf TVVYX1BJM1VTQjMwNTMyPW0KQ09ORklHX1RZUEVDX01VWF9JTlRFTF9QTUM9bQojIGVuZCBv ZiBVU0IgVHlwZS1DIE11bHRpcGxleGVyL0RlTXVsdGlwbGV4ZXIgU3dpdGNoIHN1cHBvcnQK CiMKIyBVU0IgVHlwZS1DIEFsdGVybmF0ZSBNb2RlIGRyaXZlcnMKIwpDT05GSUdfVFlQRUNf RFBfQUxUTU9ERT1tCkNPTkZJR19UWVBFQ19OVklESUFfQUxUTU9ERT1tCiMgZW5kIG9mIFVT QiBUeXBlLUMgQWx0ZXJuYXRlIE1vZGUgZHJpdmVycwoKQ09ORklHX1VTQl9ST0xFX1NXSVRD SD1tCkNPTkZJR19VU0JfUk9MRVNfSU5URUxfWEhDST1tCkNPTkZJR19NTUM9bQpDT05GSUdf TU1DX0JMT0NLPW0KQ09ORklHX01NQ19CTE9DS19NSU5PUlM9OApDT05GSUdfU0RJT19VQVJU PW0KQ09ORklHX01NQ19URVNUPW0KQ09ORklHX01NQ19DUllQVE89eQoKIwojIE1NQy9TRC9T RElPIEhvc3QgQ29udHJvbGxlciBEcml2ZXJzCiMKIyBDT05GSUdfTU1DX0RFQlVHIGlzIG5v dCBzZXQKQ09ORklHX01NQ19TREhDST1tCkNPTkZJR19NTUNfU0RIQ0lfSU9fQUNDRVNTT1JT PXkKQ09ORklHX01NQ19TREhDSV9QQ0k9bQpDT05GSUdfTU1DX1JJQ09IX01NQz15CkNPTkZJ R19NTUNfU0RIQ0lfQUNQST1tCkNPTkZJR19NTUNfU0RIQ0lfUExURk09bQpDT05GSUdfTU1D X1NESENJX0ZfU0RIMzA9bQpDT05GSUdfTU1DX1dCU0Q9bQpDT05GSUdfTU1DX0FMQ09SPW0K Q09ORklHX01NQ19USUZNX1NEPW0KQ09ORklHX01NQ19TUEk9bQpDT05GSUdfTU1DX1NEUklD T0hfQ1M9bQpDT05GSUdfTU1DX0NCNzEwPW0KQ09ORklHX01NQ19WSUFfU0RNTUM9bQpDT05G SUdfTU1DX1ZVQjMwMD1tCkNPTkZJR19NTUNfVVNIQz1tCkNPTkZJR19NTUNfVVNESEk2Uk9M MD1tCkNPTkZJR19NTUNfUkVBTFRFS19QQ0k9bQpDT05GSUdfTU1DX1JFQUxURUtfVVNCPW0K Q09ORklHX01NQ19DUUhDST1tCkNPTkZJR19NTUNfSFNRPW0KQ09ORklHX01NQ19UT1NISUJB X1BDST1tCkNPTkZJR19NTUNfTVRLPW0KQ09ORklHX01NQ19TREhDSV9YRU5PTj1tCkNPTkZJ R19NRU1TVElDSz1tCiMgQ09ORklHX01FTVNUSUNLX0RFQlVHIGlzIG5vdCBzZXQKCiMKIyBN ZW1vcnlTdGljayBkcml2ZXJzCiMKIyBDT05GSUdfTUVNU1RJQ0tfVU5TQUZFX1JFU1VNRSBp cyBub3Qgc2V0CkNPTkZJR19NU1BST19CTE9DSz1tCkNPTkZJR19NU19CTE9DSz1tCgojCiMg TWVtb3J5U3RpY2sgSG9zdCBDb250cm9sbGVyIERyaXZlcnMKIwpDT05GSUdfTUVNU1RJQ0tf VElGTV9NUz1tCkNPTkZJR19NRU1TVElDS19KTUlDUk9OXzM4WD1tCkNPTkZJR19NRU1TVElD S19SNTkyPW0KQ09ORklHX01FTVNUSUNLX1JFQUxURUtfUENJPW0KQ09ORklHX01FTVNUSUNL X1JFQUxURUtfVVNCPW0KQ09ORklHX05FV19MRURTPXkKQ09ORklHX0xFRFNfQ0xBU1M9eQpD T05GSUdfTEVEU19DTEFTU19GTEFTSD1tCkNPTkZJR19MRURTX0NMQVNTX01VTFRJQ09MT1I9 bQpDT05GSUdfTEVEU19CUklHSFRORVNTX0hXX0NIQU5HRUQ9eQoKIwojIExFRCBkcml2ZXJz CiMKQ09ORklHX0xFRFNfODhQTTg2MFg9bQpDT05GSUdfTEVEU19BUFU9bQpDT05GSUdfTEVE U19BUzM2NDVBPW0KQ09ORklHX0xFRFNfTE0zNTMwPW0KQ09ORklHX0xFRFNfTE0zNTMyPW0K Q09ORklHX0xFRFNfTE0zNTMzPW0KQ09ORklHX0xFRFNfTE0zNjQyPW0KQ09ORklHX0xFRFNf TE0zNjAxWD1tCkNPTkZJR19MRURTX01UNjMyMz1tCkNPTkZJR19MRURTX1BDQTk1MzI9bQpD T05GSUdfTEVEU19QQ0E5NTMyX0dQSU89eQpDT05GSUdfTEVEU19HUElPPW0KQ09ORklHX0xF RFNfTFAzOTQ0PW0KQ09ORklHX0xFRFNfTFAzOTUyPW0KQ09ORklHX0xFRFNfTFA1MFhYPW0K Q09ORklHX0xFRFNfTFA4Nzg4PW0KQ09ORklHX0xFRFNfQ0xFVk9fTUFJTD1tCkNPTkZJR19M RURTX1BDQTk1NVg9bQpDT05GSUdfTEVEU19QQ0E5NTVYX0dQSU89eQpDT05GSUdfTEVEU19Q Q0E5NjNYPW0KQ09ORklHX0xFRFNfV004MzFYX1NUQVRVUz1tCkNPTkZJR19MRURTX1dNODM1 MD1tCkNPTkZJR19MRURTX0RBOTAzWD1tCkNPTkZJR19MRURTX0RBOTA1Mj1tCkNPTkZJR19M RURTX0RBQzEyNFMwODU9bQpDT05GSUdfTEVEU19QV009bQpDT05GSUdfTEVEU19SRUdVTEFU T1I9bQpDT05GSUdfTEVEU19CRDI4MDI9bQpDT05GSUdfTEVEU19JTlRFTF9TUzQyMDA9bQpD T05GSUdfTEVEU19BRFA1NTIwPW0KQ09ORklHX0xFRFNfTUMxMzc4Mz1tCkNPTkZJR19MRURT X1RDQTY1MDc9bQpDT05GSUdfTEVEU19UTEM1OTFYWD1tCkNPTkZJR19MRURTX01BWDg5OTc9 bQpDT05GSUdfTEVEU19MTTM1NXg9bQpDT05GSUdfTEVEU19NRU5GMjFCTUM9bQoKIwojIExF RCBkcml2ZXIgZm9yIGJsaW5rKDEpIFVTQiBSR0IgTEVEIGlzIHVuZGVyIFNwZWNpYWwgSElE IGRyaXZlcnMgKEhJRF9USElOR00pCiMKQ09ORklHX0xFRFNfQkxJTktNPW0KQ09ORklHX0xF RFNfTUxYQ1BMRD1tCkNPTkZJR19MRURTX01MWFJFRz1tCkNPTkZJR19MRURTX1VTRVI9bQpD T05GSUdfTEVEU19OSUM3OEJYPW0KQ09ORklHX0xFRFNfVElfTE1VX0NPTU1PTj1tCkNPTkZJ R19MRURTX0xNMzYyNzQ9bQpDT05GSUdfTEVEU19UUFM2MTA1WD1tCkNPTkZJR19MRURTX1NH TTMxNDA9bQoKIwojIEZsYXNoIGFuZCBUb3JjaCBMRUQgZHJpdmVycwojCkNPTkZJR19MRURT X1JUODUxNT1tCgojCiMgTEVEIFRyaWdnZXJzCiMKQ09ORklHX0xFRFNfVFJJR0dFUlM9eQpD T05GSUdfTEVEU19UUklHR0VSX1RJTUVSPW0KQ09ORklHX0xFRFNfVFJJR0dFUl9PTkVTSE9U PW0KQ09ORklHX0xFRFNfVFJJR0dFUl9ESVNLPXkKQ09ORklHX0xFRFNfVFJJR0dFUl9NVEQ9 eQpDT05GSUdfTEVEU19UUklHR0VSX0hFQVJUQkVBVD1tCkNPTkZJR19MRURTX1RSSUdHRVJf QkFDS0xJR0hUPW0KQ09ORklHX0xFRFNfVFJJR0dFUl9DUFU9eQpDT05GSUdfTEVEU19UUklH R0VSX0FDVElWSVRZPW0KQ09ORklHX0xFRFNfVFJJR0dFUl9HUElPPW0KQ09ORklHX0xFRFNf VFJJR0dFUl9ERUZBVUxUX09OPW0KCiMKIyBpcHRhYmxlcyB0cmlnZ2VyIGlzIHVuZGVyIE5l dGZpbHRlciBjb25maWcgKExFRCB0YXJnZXQpCiMKQ09ORklHX0xFRFNfVFJJR0dFUl9UUkFO U0lFTlQ9bQpDT05GSUdfTEVEU19UUklHR0VSX0NBTUVSQT1tCkNPTkZJR19MRURTX1RSSUdH RVJfUEFOSUM9eQpDT05GSUdfTEVEU19UUklHR0VSX05FVERFVj1tCkNPTkZJR19MRURTX1RS SUdHRVJfUEFUVEVSTj1tCkNPTkZJR19MRURTX1RSSUdHRVJfQVVESU89bQpDT05GSUdfTEVE U19UUklHR0VSX1RUWT1tCgojCiMgTEVEIEJsaW5rCiMKQ09ORklHX0xFRFNfQkxJTks9eQpD T05GSUdfQUNDRVNTSUJJTElUWT15CkNPTkZJR19BMTFZX0JSQUlMTEVfQ09OU09MRT15Cgoj CiMgU3BlYWt1cCBjb25zb2xlIHNwZWVjaAojCkNPTkZJR19TUEVBS1VQPW0KQ09ORklHX1NQ RUFLVVBfU1lOVEhfQUNOVFNBPW0KQ09ORklHX1NQRUFLVVBfU1lOVEhfQVBPTExPPW0KQ09O RklHX1NQRUFLVVBfU1lOVEhfQVVEUFRSPW0KQ09ORklHX1NQRUFLVVBfU1lOVEhfQk5TPW0K Q09ORklHX1NQRUFLVVBfU1lOVEhfREVDVExLPW0KQ09ORklHX1NQRUFLVVBfU1lOVEhfREVD RVhUPW0KQ09ORklHX1NQRUFLVVBfU1lOVEhfTFRMSz1tCkNPTkZJR19TUEVBS1VQX1NZTlRI X1NPRlQ9bQpDT05GSUdfU1BFQUtVUF9TWU5USF9TUEtPVVQ9bQpDT05GSUdfU1BFQUtVUF9T WU5USF9UWFBSVD1tCkNPTkZJR19TUEVBS1VQX1NZTlRIX0RVTU1ZPW0KIyBlbmQgb2YgU3Bl YWt1cCBjb25zb2xlIHNwZWVjaAoKQ09ORklHX0lORklOSUJBTkQ9bQpDT05GSUdfSU5GSU5J QkFORF9VU0VSX01BRD1tCkNPTkZJR19JTkZJTklCQU5EX1VTRVJfQUNDRVNTPW0KQ09ORklH X0lORklOSUJBTkRfVVNFUl9NRU09eQpDT05GSUdfSU5GSU5JQkFORF9PTl9ERU1BTkRfUEFH SU5HPXkKQ09ORklHX0lORklOSUJBTkRfQUREUl9UUkFOUz15CkNPTkZJR19JTkZJTklCQU5E X0FERFJfVFJBTlNfQ09ORklHRlM9eQpDT05GSUdfSU5GSU5JQkFORF9WSVJUX0RNQT15CkNP TkZJR19JTkZJTklCQU5EX01USENBPW0KQ09ORklHX0lORklOSUJBTkRfTVRIQ0FfREVCVUc9 eQpDT05GSUdfSU5GSU5JQkFORF9RSUI9bQpDT05GSUdfSU5GSU5JQkFORF9RSUJfRENBPXkK Q09ORklHX0lORklOSUJBTkRfQ1hHQjQ9bQpDT05GSUdfSU5GSU5JQkFORF9FRkE9bQpDT05G SUdfSU5GSU5JQkFORF9JNDBJVz1tCkNPTkZJR19NTFg0X0lORklOSUJBTkQ9bQpDT05GSUdf TUxYNV9JTkZJTklCQU5EPW0KQ09ORklHX0lORklOSUJBTkRfT0NSRE1BPW0KQ09ORklHX0lO RklOSUJBTkRfVk1XQVJFX1BWUkRNQT1tCkNPTkZJR19JTkZJTklCQU5EX1VTTklDPW0KQ09O RklHX0lORklOSUJBTkRfQk5YVF9SRT1tCkNPTkZJR19JTkZJTklCQU5EX0hGSTE9bQojIENP TkZJR19IRkkxX0RFQlVHX1NETUFfT1JERVIgaXMgbm90IHNldAojIENPTkZJR19TRE1BX1ZF UkJPU0lUWSBpcyBub3Qgc2V0CkNPTkZJR19JTkZJTklCQU5EX1FFRFI9bQpDT05GSUdfSU5G SU5JQkFORF9SRE1BVlQ9bQpDT05GSUdfUkRNQV9SWEU9bQpDT05GSUdfUkRNQV9TSVc9bQpD T05GSUdfSU5GSU5JQkFORF9JUE9JQj1tCkNPTkZJR19JTkZJTklCQU5EX0lQT0lCX0NNPXkK Q09ORklHX0lORklOSUJBTkRfSVBPSUJfREVCVUc9eQojIENPTkZJR19JTkZJTklCQU5EX0lQ T0lCX0RFQlVHX0RBVEEgaXMgbm90IHNldApDT05GSUdfSU5GSU5JQkFORF9TUlA9bQpDT05G SUdfSU5GSU5JQkFORF9TUlBUPW0KQ09ORklHX0lORklOSUJBTkRfSVNFUj1tCkNPTkZJR19J TkZJTklCQU5EX0lTRVJUPW0KQ09ORklHX0lORklOSUJBTkRfUlRSUz1tCkNPTkZJR19JTkZJ TklCQU5EX1JUUlNfQ0xJRU5UPW0KQ09ORklHX0lORklOSUJBTkRfUlRSU19TRVJWRVI9bQpD T05GSUdfSU5GSU5JQkFORF9PUEFfVk5JQz1tCkNPTkZJR19FREFDX0FUT01JQ19TQ1JVQj15 CkNPTkZJR19FREFDX1NVUFBPUlQ9eQpDT05GSUdfRURBQz15CkNPTkZJR19FREFDX0xFR0FD WV9TWVNGUz15CiMgQ09ORklHX0VEQUNfREVCVUcgaXMgbm90IHNldApDT05GSUdfRURBQ19E RUNPREVfTUNFPW0KQ09ORklHX0VEQUNfR0hFUz15CkNPTkZJR19FREFDX0FNRDY0PW0KQ09O RklHX0VEQUNfRTc1Mlg9bQpDT05GSUdfRURBQ19JODI5NzVYPW0KQ09ORklHX0VEQUNfSTMw MDA9bQpDT05GSUdfRURBQ19JMzIwMD1tCkNPTkZJR19FREFDX0lFMzEyMDA9bQpDT05GSUdf RURBQ19YMzg9bQpDT05GSUdfRURBQ19JNTQwMD1tCkNPTkZJR19FREFDX0k3Q09SRT1tCkNP TkZJR19FREFDX0k1MDAwPW0KQ09ORklHX0VEQUNfSTUxMDA9bQpDT05GSUdfRURBQ19JNzMw MD1tCkNPTkZJR19FREFDX1NCUklER0U9bQpDT05GSUdfRURBQ19TS1g9bQpDT05GSUdfRURB Q19JMTBOTT1tCkNPTkZJR19FREFDX1BORDI9bQpDT05GSUdfRURBQ19JR0VONj1tCkNPTkZJ R19SVENfTElCPXkKQ09ORklHX1JUQ19NQzE0NjgxOF9MSUI9eQpDT05GSUdfUlRDX0NMQVNT PXkKQ09ORklHX1JUQ19IQ1RPU1lTPXkKQ09ORklHX1JUQ19IQ1RPU1lTX0RFVklDRT0icnRj MCIKQ09ORklHX1JUQ19TWVNUT0hDPXkKQ09ORklHX1JUQ19TWVNUT0hDX0RFVklDRT0icnRj MCIKIyBDT05GSUdfUlRDX0RFQlVHIGlzIG5vdCBzZXQKQ09ORklHX1JUQ19OVk1FTT15Cgoj CiMgUlRDIGludGVyZmFjZXMKIwpDT05GSUdfUlRDX0lOVEZfU1lTRlM9eQpDT05GSUdfUlRD X0lOVEZfUFJPQz15CkNPTkZJR19SVENfSU5URl9ERVY9eQpDT05GSUdfUlRDX0lOVEZfREVW X1VJRV9FTVVMPXkKIyBDT05GSUdfUlRDX0RSVl9URVNUIGlzIG5vdCBzZXQKCiMKIyBJMkMg UlRDIGRyaXZlcnMKIwpDT05GSUdfUlRDX0RSVl84OFBNODYwWD1tCkNPTkZJR19SVENfRFJW Xzg4UE04MFg9bQpDT05GSUdfUlRDX0RSVl9BQkI1WkVTMz1tCkNPTkZJR19SVENfRFJWX0FC RU9aOT1tCkNPTkZJR19SVENfRFJWX0FCWDgwWD1tCkNPTkZJR19SVENfRFJWX0RTMTMwNz1t CkNPTkZJR19SVENfRFJWX0RTMTMwN19DRU5UVVJZPXkKQ09ORklHX1JUQ19EUlZfRFMxMzc0 PW0KQ09ORklHX1JUQ19EUlZfRFMxMzc0X1dEVD15CkNPTkZJR19SVENfRFJWX0RTMTY3Mj1t CkNPTkZJR19SVENfRFJWX0xQODc4OD1tCkNPTkZJR19SVENfRFJWX01BWDY5MDA9bQpDT05G SUdfUlRDX0RSVl9NQVg4OTA3PW0KQ09ORklHX1JUQ19EUlZfTUFYODkyNT1tCkNPTkZJR19S VENfRFJWX01BWDg5OTg9bQpDT05GSUdfUlRDX0RSVl9NQVg4OTk3PW0KQ09ORklHX1JUQ19E UlZfUlM1QzM3Mj1tCkNPTkZJR19SVENfRFJWX0lTTDEyMDg9bQpDT05GSUdfUlRDX0RSVl9J U0wxMjAyMj1tCkNPTkZJR19SVENfRFJWX1gxMjA1PW0KQ09ORklHX1JUQ19EUlZfUENGODUy Mz1tCkNPTkZJR19SVENfRFJWX1BDRjg1MDYzPW0KQ09ORklHX1JUQ19EUlZfUENGODUzNjM9 bQpDT05GSUdfUlRDX0RSVl9QQ0Y4NTYzPW0KQ09ORklHX1JUQ19EUlZfUENGODU4Mz1tCkNP TkZJR19SVENfRFJWX000MVQ4MD1tCkNPTkZJR19SVENfRFJWX000MVQ4MF9XRFQ9eQpDT05G SUdfUlRDX0RSVl9CUTMySz1tCkNPTkZJR19SVENfRFJWX1BBTE1BUz1tCkNPTkZJR19SVENf RFJWX1RQUzY1ODZYPW0KQ09ORklHX1JUQ19EUlZfVFBTNjU5MTA9bQpDT05GSUdfUlRDX0RS Vl9UUFM4MDAzMT1tCkNPTkZJR19SVENfRFJWX1JDNVQ1ODM9bQpDT05GSUdfUlRDX0RSVl9T MzUzOTBBPW0KQ09ORklHX1JUQ19EUlZfRk0zMTMwPW0KQ09ORklHX1JUQ19EUlZfUlg4MDEw PW0KQ09ORklHX1JUQ19EUlZfUlg4NTgxPW0KQ09ORklHX1JUQ19EUlZfUlg4MDI1PW0KQ09O RklHX1JUQ19EUlZfRU0zMDI3PW0KQ09ORklHX1JUQ19EUlZfUlYzMDI4PW0KQ09ORklHX1JU Q19EUlZfUlYzMDMyPW0KQ09ORklHX1JUQ19EUlZfUlY4ODAzPW0KQ09ORklHX1JUQ19EUlZf UzVNPW0KQ09ORklHX1JUQ19EUlZfU0QzMDc4PW0KCiMKIyBTUEkgUlRDIGRyaXZlcnMKIwpD T05GSUdfUlRDX0RSVl9NNDFUOTM9bQpDT05GSUdfUlRDX0RSVl9NNDFUOTQ9bQpDT05GSUdf UlRDX0RSVl9EUzEzMDI9bQpDT05GSUdfUlRDX0RSVl9EUzEzMDU9bQpDT05GSUdfUlRDX0RS Vl9EUzEzNDM9bQpDT05GSUdfUlRDX0RSVl9EUzEzNDc9bQpDT05GSUdfUlRDX0RSVl9EUzEz OTA9bQpDT05GSUdfUlRDX0RSVl9NQVg2OTE2PW0KQ09ORklHX1JUQ19EUlZfUjk3MDE9bQpD T05GSUdfUlRDX0RSVl9SWDQ1ODE9bQpDT05GSUdfUlRDX0RSVl9SUzVDMzQ4PW0KQ09ORklH X1JUQ19EUlZfTUFYNjkwMj1tCkNPTkZJR19SVENfRFJWX1BDRjIxMjM9bQpDT05GSUdfUlRD X0RSVl9NQ1A3OTU9bQpDT05GSUdfUlRDX0kyQ19BTkRfU1BJPXkKCiMKIyBTUEkgYW5kIEky QyBSVEMgZHJpdmVycwojCkNPTkZJR19SVENfRFJWX0RTMzIzMj1tCkNPTkZJR19SVENfRFJW X0RTMzIzMl9IV01PTj15CkNPTkZJR19SVENfRFJWX1BDRjIxMjc9bQpDT05GSUdfUlRDX0RS Vl9SVjMwMjlDMj1tCkNPTkZJR19SVENfRFJWX1JWMzAyOV9IV01PTj15CkNPTkZJR19SVENf RFJWX1JYNjExMD1tCgojCiMgUGxhdGZvcm0gUlRDIGRyaXZlcnMKIwpDT05GSUdfUlRDX0RS Vl9DTU9TPXkKQ09ORklHX1JUQ19EUlZfRFMxMjg2PW0KQ09ORklHX1JUQ19EUlZfRFMxNTEx PW0KQ09ORklHX1JUQ19EUlZfRFMxNTUzPW0KQ09ORklHX1JUQ19EUlZfRFMxNjg1X0ZBTUlM WT1tCkNPTkZJR19SVENfRFJWX0RTMTY4NT15CiMgQ09ORklHX1JUQ19EUlZfRFMxNjg5IGlz IG5vdCBzZXQKIyBDT05GSUdfUlRDX0RSVl9EUzE3Mjg1IGlzIG5vdCBzZXQKIyBDT05GSUdf UlRDX0RSVl9EUzE3NDg1IGlzIG5vdCBzZXQKIyBDT05GSUdfUlRDX0RSVl9EUzE3ODg1IGlz IG5vdCBzZXQKQ09ORklHX1JUQ19EUlZfRFMxNzQyPW0KQ09ORklHX1JUQ19EUlZfRFMyNDA0 PW0KQ09ORklHX1JUQ19EUlZfREE5MDUyPW0KQ09ORklHX1JUQ19EUlZfREE5MDU1PW0KQ09O RklHX1JUQ19EUlZfREE5MDYzPW0KQ09ORklHX1JUQ19EUlZfU1RLMTdUQTg9bQpDT05GSUdf UlRDX0RSVl9NNDhUODY9bQpDT05GSUdfUlRDX0RSVl9NNDhUMzU9bQpDT05GSUdfUlRDX0RS Vl9NNDhUNTk9bQpDT05GSUdfUlRDX0RSVl9NU002MjQyPW0KQ09ORklHX1JUQ19EUlZfQlE0 ODAyPW0KQ09ORklHX1JUQ19EUlZfUlA1QzAxPW0KQ09ORklHX1JUQ19EUlZfVjMwMjA9bQpD T05GSUdfUlRDX0RSVl9XTTgzMVg9bQpDT05GSUdfUlRDX0RSVl9XTTgzNTA9bQpDT05GSUdf UlRDX0RSVl9QQ0Y1MDYzMz1tCkNPTkZJR19SVENfRFJWX0NST1NfRUM9bQoKIwojIG9uLUNQ VSBSVEMgZHJpdmVycwojCkNPTkZJR19SVENfRFJWX0ZUUlRDMDEwPW0KQ09ORklHX1JUQ19E UlZfUENBUD1tCkNPTkZJR19SVENfRFJWX01DMTNYWFg9bQpDT05GSUdfUlRDX0RSVl9NVDYz OTc9bQoKIwojIEhJRCBTZW5zb3IgUlRDIGRyaXZlcnMKIwpDT05GSUdfUlRDX0RSVl9ISURf U0VOU09SX1RJTUU9bQpDT05GSUdfUlRDX0RSVl9XSUxDT19FQz1tCkNPTkZJR19ETUFERVZJ Q0VTPXkKIyBDT05GSUdfRE1BREVWSUNFU19ERUJVRyBpcyBub3Qgc2V0CgojCiMgRE1BIERl dmljZXMKIwpDT05GSUdfRE1BX0VOR0lORT15CkNPTkZJR19ETUFfVklSVFVBTF9DSEFOTkVM Uz15CkNPTkZJR19ETUFfQUNQST15CkNPTkZJR19BTFRFUkFfTVNHRE1BPW0KQ09ORklHX0lO VEVMX0lETUE2ND1tCkNPTkZJR19JTlRFTF9JRFhEPW0KQ09ORklHX0lOVEVMX0lEWERfU1ZN PXkKQ09ORklHX0lOVEVMX0lPQVRETUE9bQpDT05GSUdfUExYX0RNQT1tCkNPTkZJR19YSUxJ TlhfWllOUU1QX0RQRE1BPW0KQ09ORklHX1FDT01fSElETUFfTUdNVD1tCkNPTkZJR19RQ09N X0hJRE1BPW0KQ09ORklHX0RXX0RNQUNfQ09SRT15CkNPTkZJR19EV19ETUFDPW0KQ09ORklH X0RXX0RNQUNfUENJPXkKQ09ORklHX0RXX0VETUE9bQpDT05GSUdfRFdfRURNQV9QQ0lFPW0K Q09ORklHX0hTVV9ETUE9eQpDT05GSUdfU0ZfUERNQT1tCkNPTkZJR19JTlRFTF9MRE1BPXkK CiMKIyBETUEgQ2xpZW50cwojCkNPTkZJR19BU1lOQ19UWF9ETUE9eQojIENPTkZJR19ETUFU RVNUIGlzIG5vdCBzZXQKQ09ORklHX0RNQV9FTkdJTkVfUkFJRD15CgojCiMgRE1BQlVGIG9w dGlvbnMKIwpDT05GSUdfU1lOQ19GSUxFPXkKIyBDT05GSUdfU1dfU1lOQyBpcyBub3Qgc2V0 CkNPTkZJR19VRE1BQlVGPXkKIyBDT05GSUdfRE1BQlVGX01PVkVfTk9USUZZIGlzIG5vdCBz ZXQKIyBDT05GSUdfRE1BQlVGX0RFQlVHIGlzIG5vdCBzZXQKIyBDT05GSUdfRE1BQlVGX1NF TEZURVNUUyBpcyBub3Qgc2V0CkNPTkZJR19ETUFCVUZfSEVBUFM9eQpDT05GSUdfRE1BQlVG X0hFQVBTX1NZU1RFTT15CkNPTkZJR19ETUFCVUZfSEVBUFNfQ01BPXkKIyBlbmQgb2YgRE1B QlVGIG9wdGlvbnMKCkNPTkZJR19EQ0E9bQpDT05GSUdfQVVYRElTUExBWT15CkNPTkZJR19D SEFSTENEPW0KQ09ORklHX0hENDQ3ODBfQ09NTU9OPW0KQ09ORklHX0hENDQ3ODA9bQpDT05G SUdfS1MwMTA4PW0KQ09ORklHX0tTMDEwOF9QT1JUPTB4Mzc4CkNPTkZJR19LUzAxMDhfREVM QVk9MgpDT05GSUdfQ0ZBRzEyODY0Qj1tCkNPTkZJR19DRkFHMTI4NjRCX1JBVEU9MjAKQ09O RklHX0lNR19BU0NJSV9MQ0Q9bQpDT05GSUdfTENEMlM9bQpDT05GSUdfUEFSUE9SVF9QQU5F TD1tCkNPTkZJR19QQU5FTF9QQVJQT1JUPTAKQ09ORklHX1BBTkVMX1BST0ZJTEU9NQojIENP TkZJR19QQU5FTF9DSEFOR0VfTUVTU0FHRSBpcyBub3Qgc2V0CiMgQ09ORklHX0NIQVJMQ0Rf QkxfT0ZGIGlzIG5vdCBzZXQKIyBDT05GSUdfQ0hBUkxDRF9CTF9PTiBpcyBub3Qgc2V0CkNP TkZJR19DSEFSTENEX0JMX0ZMQVNIPXkKQ09ORklHX1BBTkVMPW0KQ09ORklHX1VJTz1tCkNP TkZJR19VSU9fQ0lGPW0KQ09ORklHX1VJT19QRFJWX0dFTklSUT1tCkNPTkZJR19VSU9fRE1F TV9HRU5JUlE9bQpDT05GSUdfVUlPX0FFQz1tCkNPTkZJR19VSU9fU0VSQ09TMz1tCkNPTkZJ R19VSU9fUENJX0dFTkVSSUM9bQpDT05GSUdfVUlPX05FVFg9bQpDT05GSUdfVUlPX1BSVVNT PW0KQ09ORklHX1VJT19NRjYyND1tCkNPTkZJR19VSU9fSFZfR0VORVJJQz1tCkNPTkZJR19W RklPX0lPTU1VX1RZUEUxPW0KQ09ORklHX1ZGSU9fVklSUUZEPW0KQ09ORklHX1ZGSU89bQoj IENPTkZJR19WRklPX05PSU9NTVUgaXMgbm90IHNldApDT05GSUdfVkZJT19QQ0k9bQpDT05G SUdfVkZJT19QQ0lfVkdBPXkKQ09ORklHX1ZGSU9fUENJX01NQVA9eQpDT05GSUdfVkZJT19Q Q0lfSU5UWD15CkNPTkZJR19WRklPX1BDSV9JR0Q9eQpDT05GSUdfVkZJT19NREVWPW0KQ09O RklHX1ZGSU9fTURFVl9ERVZJQ0U9bQpDT05GSUdfSVJRX0JZUEFTU19NQU5BR0VSPW0KQ09O RklHX1ZJUlRfRFJJVkVSUz15CkNPTkZJR19WQk9YR1VFU1Q9bQpDT05GSUdfTklUUk9fRU5D TEFWRVM9bQpDT05GSUdfQUNSTl9IU009bQpDT05GSUdfVklSVElPPXkKQ09ORklHX1ZJUlRJ T19QQ0lfTElCPW0KQ09ORklHX1ZJUlRJT19NRU5VPXkKQ09ORklHX1ZJUlRJT19QQ0k9bQpD T05GSUdfVklSVElPX1BDSV9MRUdBQ1k9eQpDT05GSUdfVklSVElPX1ZEUEE9bQpDT05GSUdf VklSVElPX1BNRU09bQpDT05GSUdfVklSVElPX0JBTExPT049bQpDT05GSUdfVklSVElPX01F TT1tCkNPTkZJR19WSVJUSU9fSU5QVVQ9bQpDT05GSUdfVklSVElPX01NSU89bQpDT05GSUdf VklSVElPX01NSU9fQ01ETElORV9ERVZJQ0VTPXkKQ09ORklHX1ZJUlRJT19ETUFfU0hBUkVE X0JVRkZFUj1tCkNPTkZJR19WRFBBPW0KQ09ORklHX1ZEUEFfU0lNPW0KQ09ORklHX1ZEUEFf U0lNX05FVD1tCkNPTkZJR19JRkNWRj1tCkNPTkZJR19NTFg1X1ZEUEE9eQpDT05GSUdfTUxY NV9WRFBBX05FVD1tCkNPTkZJR19WSE9TVF9JT1RMQj1tCkNPTkZJR19WSE9TVF9SSU5HPW0K Q09ORklHX1ZIT1NUPW0KQ09ORklHX1ZIT1NUX01FTlU9eQpDT05GSUdfVkhPU1RfTkVUPW0K Q09ORklHX1ZIT1NUX1NDU0k9bQpDT05GSUdfVkhPU1RfVlNPQ0s9bQpDT05GSUdfVkhPU1Rf VkRQQT1tCiMgQ09ORklHX1ZIT1NUX0NST1NTX0VORElBTl9MRUdBQ1kgaXMgbm90IHNldAoK IwojIE1pY3Jvc29mdCBIeXBlci1WIGd1ZXN0IHN1cHBvcnQKIwpDT05GSUdfSFlQRVJWPW0K Q09ORklHX0hZUEVSVl9USU1FUj15CkNPTkZJR19IWVBFUlZfVVRJTFM9bQpDT05GSUdfSFlQ RVJWX0JBTExPT049bQojIGVuZCBvZiBNaWNyb3NvZnQgSHlwZXItViBndWVzdCBzdXBwb3J0 CgojCiMgWGVuIGRyaXZlciBzdXBwb3J0CiMKQ09ORklHX1hFTl9CQUxMT09OPXkKQ09ORklH X1hFTl9CQUxMT09OX01FTU9SWV9IT1RQTFVHPXkKQ09ORklHX1hFTl9CQUxMT09OX01FTU9S WV9IT1RQTFVHX0xJTUlUPTUxMgpDT05GSUdfWEVOX1NDUlVCX1BBR0VTX0RFRkFVTFQ9eQpD T05GSUdfWEVOX0RFVl9FVlRDSE49bQpDT05GSUdfWEVOX0JBQ0tFTkQ9eQpDT05GSUdfWEVO RlM9bQpDT05GSUdfWEVOX0NPTVBBVF9YRU5GUz15CkNPTkZJR19YRU5fU1lTX0hZUEVSVklT T1I9eQpDT05GSUdfWEVOX1hFTkJVU19GUk9OVEVORD15CkNPTkZJR19YRU5fR05UREVWPW0K Q09ORklHX1hFTl9HTlRERVZfRE1BQlVGPXkKQ09ORklHX1hFTl9HUkFOVF9ERVZfQUxMT0M9 bQpDT05GSUdfWEVOX0dSQU5UX0RNQV9BTExPQz15CkNPTkZJR19TV0lPVExCX1hFTj15CkNP TkZJR19YRU5fUENJREVWX0JBQ0tFTkQ9bQpDT05GSUdfWEVOX1BWQ0FMTFNfRlJPTlRFTkQ9 bQpDT05GSUdfWEVOX1BWQ0FMTFNfQkFDS0VORD15CkNPTkZJR19YRU5fU0NTSV9CQUNLRU5E PW0KQ09ORklHX1hFTl9QUklWQ01EPW0KQ09ORklHX1hFTl9BQ1BJX1BST0NFU1NPUj1tCkNP TkZJR19YRU5fTUNFX0xPRz15CkNPTkZJR19YRU5fSEFWRV9QVk1NVT15CkNPTkZJR19YRU5f RUZJPXkKQ09ORklHX1hFTl9BVVRPX1hMQVRFPXkKQ09ORklHX1hFTl9BQ1BJPXkKQ09ORklH X1hFTl9TWU1TPXkKQ09ORklHX1hFTl9IQVZFX1ZQTVU9eQpDT05GSUdfWEVOX0ZST05UX1BH RElSX1NIQlVGPW0KQ09ORklHX1hFTl9VTlBPUFVMQVRFRF9BTExPQz15CiMgZW5kIG9mIFhl biBkcml2ZXIgc3VwcG9ydAoKIyBDT05GSUdfR1JFWUJVUyBpcyBub3Qgc2V0CkNPTkZJR19T VEFHSU5HPXkKQ09ORklHX1BSSVNNMl9VU0I9bQojIENPTkZJR19DT01FREkgaXMgbm90IHNl dApDT05GSUdfUlRMODE5MlU9bQpDT05GSUdfUlRMTElCPW0KQ09ORklHX1JUTExJQl9DUllQ VE9fQ0NNUD1tCkNPTkZJR19SVExMSUJfQ1JZUFRPX1RLSVA9bQpDT05GSUdfUlRMTElCX0NS WVBUT19XRVA9bQpDT05GSUdfUlRMODE5MkU9bQpDT05GSUdfUlRMODcyM0JTPW0KQ09ORklH X1I4NzEyVT1tCkNPTkZJR19SODE4OEVVPW0KQ09ORklHXzg4RVVfQVBfTU9ERT15CkNPTkZJ R19SVFM1MjA4PW0KQ09ORklHX1ZUNjY1NT1tCkNPTkZJR19WVDY2NTY9bQoKIwojIElJTyBz dGFnaW5nIGRyaXZlcnMKIwoKIwojIEFjY2VsZXJvbWV0ZXJzCiMKQ09ORklHX0FESVMxNjIw Mz1tCkNPTkZJR19BRElTMTYyNDA9bQojIGVuZCBvZiBBY2NlbGVyb21ldGVycwoKIwojIEFu YWxvZyB0byBkaWdpdGFsIGNvbnZlcnRlcnMKIwpDT05GSUdfQUQ3ODE2PW0KQ09ORklHX0FE NzI4MD1tCiMgZW5kIG9mIEFuYWxvZyB0byBkaWdpdGFsIGNvbnZlcnRlcnMKCiMKIyBBbmFs b2cgZGlnaXRhbCBiaS1kaXJlY3Rpb24gY29udmVydGVycwojCkNPTkZJR19BRFQ3MzE2PW0K Q09ORklHX0FEVDczMTZfU1BJPW0KQ09ORklHX0FEVDczMTZfSTJDPW0KIyBlbmQgb2YgQW5h bG9nIGRpZ2l0YWwgYmktZGlyZWN0aW9uIGNvbnZlcnRlcnMKCiMKIyBDYXBhY2l0YW5jZSB0 byBkaWdpdGFsIGNvbnZlcnRlcnMKIwpDT05GSUdfQUQ3MTUwPW0KQ09ORklHX0FENzc0Nj1t CiMgZW5kIG9mIENhcGFjaXRhbmNlIHRvIGRpZ2l0YWwgY29udmVydGVycwoKIwojIERpcmVj dCBEaWdpdGFsIFN5bnRoZXNpcwojCkNPTkZJR19BRDk4MzI9bQpDT05GSUdfQUQ5ODM0PW0K IyBlbmQgb2YgRGlyZWN0IERpZ2l0YWwgU3ludGhlc2lzCgojCiMgTmV0d29yayBBbmFseXpl ciwgSW1wZWRhbmNlIENvbnZlcnRlcnMKIwpDT05GSUdfQUQ1OTMzPW0KIyBlbmQgb2YgTmV0 d29yayBBbmFseXplciwgSW1wZWRhbmNlIENvbnZlcnRlcnMKCiMKIyBBY3RpdmUgZW5lcmd5 IG1ldGVyaW5nIElDCiMKQ09ORklHX0FERTc4NTQ9bQpDT05GSUdfQURFNzg1NF9JMkM9bQpD T05GSUdfQURFNzg1NF9TUEk9bQojIGVuZCBvZiBBY3RpdmUgZW5lcmd5IG1ldGVyaW5nIElD CgojCiMgUmVzb2x2ZXIgdG8gZGlnaXRhbCBjb252ZXJ0ZXJzCiMKQ09ORklHX0FEMlMxMjEw PW0KIyBlbmQgb2YgUmVzb2x2ZXIgdG8gZGlnaXRhbCBjb252ZXJ0ZXJzCiMgZW5kIG9mIElJ TyBzdGFnaW5nIGRyaXZlcnMKCiMgQ09ORklHX0ZCX1NNNzUwIGlzIG5vdCBzZXQKQ09ORklH X1NUQUdJTkdfTUVESUE9eQpDT05GSUdfSU5URUxfQVRPTUlTUD15CkNPTkZJR19WSURFT19B VE9NSVNQPW0KQ09ORklHX1ZJREVPX0FUT01JU1BfSVNQMjQwMT15CkNPTkZJR19WSURFT19B VE9NSVNQX09WMjcyMj1tCkNPTkZJR19WSURFT19BVE9NSVNQX0dDMjIzNT1tCkNPTkZJR19W SURFT19BVE9NSVNQX01TUkxJU1RfSEVMUEVSPW0KQ09ORklHX1ZJREVPX0FUT01JU1BfTVQ5 TTExND1tCkNPTkZJR19WSURFT19BVE9NSVNQX0dDMDMxMD1tCkNPTkZJR19WSURFT19BVE9N SVNQX09WMjY4MD1tCkNPTkZJR19WSURFT19BVE9NSVNQX09WNTY5Mz1tCkNPTkZJR19WSURF T19BVE9NSVNQX0xNMzU1ND1tCiMgQ09ORklHX1ZJREVPX1pPUkFOIGlzIG5vdCBzZXQKQ09O RklHX1ZJREVPX0lQVTNfSU1HVT1tCgojCiMgQW5kcm9pZAojCiMgZW5kIG9mIEFuZHJvaWQK CkNPTkZJR19MVEVfR0RNNzI0WD1tCkNPTkZJR19GSVJFV0lSRV9TRVJJQUw9bQpDT05GSUdf RldUVFlfTUFYX1RPVEFMX1BPUlRTPTY0CkNPTkZJR19GV1RUWV9NQVhfQ0FSRF9QT1JUUz0z MgpDT05GSUdfR1NfRlBHQUJPT1Q9bQpDT05GSUdfVU5JU1lTU1BBUj15CkNPTkZJR19VTklT WVNfVklTT1JOSUM9bQpDT05GSUdfVU5JU1lTX1ZJU09SSU5QVVQ9bQpDT05GSUdfVU5JU1lT X1ZJU09SSEJBPW0KIyBDT05GSUdfRkJfVEZUIGlzIG5vdCBzZXQKQ09ORklHX01PU1RfQ09N UE9ORU5UUz1tCkNPTkZJR19NT1NUX05FVD1tCkNPTkZJR19NT1NUX1NPVU5EPW0KQ09ORklH X01PU1RfVklERU89bQpDT05GSUdfTU9TVF9JMkM9bQpDT05GSUdfS1M3MDEwPW0KQ09ORklH X1BJNDMzPW0KCiMKIyBHYXNrZXQgZGV2aWNlcwojCkNPTkZJR19TVEFHSU5HX0dBU0tFVF9G UkFNRVdPUks9bQpDT05GSUdfU1RBR0lOR19BUEVYX0RSSVZFUj1tCiMgZW5kIG9mIEdhc2tl dCBkZXZpY2VzCgpDT05GSUdfRklFTERCVVNfREVWPW0KQ09ORklHX0tQQzIwMDA9eQpDT05G SUdfS1BDMjAwMF9DT1JFPW0KQ09ORklHX0tQQzIwMDBfU1BJPW0KQ09ORklHX0tQQzIwMDBf STJDPW0KQ09ORklHX0tQQzIwMDBfRE1BPW0KQ09ORklHX1FMR0U9bQpDT05GSUdfV0lNQVg9 bQpDT05GSUdfV0lNQVhfREVCVUdfTEVWRUw9OApDT05GSUdfV0lNQVhfSTI0MDBNPW0KQ09O RklHX1dJTUFYX0kyNDAwTV9VU0I9bQpDT05GSUdfV0lNQVhfSTI0MDBNX0RFQlVHX0xFVkVM PTgKQ09ORklHX1dGWD1tCkNPTkZJR19YODZfUExBVEZPUk1fREVWSUNFUz15CkNPTkZJR19B Q1BJX1dNST1tCkNPTkZJR19XTUlfQk1PRj1tCkNPTkZJR19IVUFXRUlfV01JPW0KQ09ORklH X0lOVEVMX1dNSV9TQkxfRldfVVBEQVRFPW0KQ09ORklHX0lOVEVMX1dNSV9USFVOREVSQk9M VD1tCkNPTkZJR19NWE1fV01JPW0KQ09ORklHX1BFQVFfV01JPW0KQ09ORklHX1hJQU9NSV9X TUk9bQpDT05GSUdfQUNFUkhERj1tCkNPTkZJR19BQ0VSX1dJUkVMRVNTPW0KQ09ORklHX0FD RVJfV01JPW0KQ09ORklHX0FNRF9QTUM9bQpDT05GSUdfQVBQTEVfR01VWD1tCkNPTkZJR19B U1VTX0xBUFRPUD1tCkNPTkZJR19BU1VTX1dJUkVMRVNTPW0KQ09ORklHX0FTVVNfV01JPW0K Q09ORklHX0FTVVNfTkJfV01JPW0KQ09ORklHX0VFRVBDX0xBUFRPUD1tCkNPTkZJR19FRUVQ Q19XTUk9bQpDT05GSUdfWDg2X1BMQVRGT1JNX0RSSVZFUlNfREVMTD15CkNPTkZJR19BTElF TldBUkVfV01JPW0KQ09ORklHX0RDREJBUz1tCkNPTkZJR19ERUxMX0xBUFRPUD1tCiMgQ09O RklHX0RFTExfUkJVIGlzIG5vdCBzZXQKQ09ORklHX0RFTExfUkJUTj1tCkNPTkZJR19ERUxM X1NNQklPUz1tCkNPTkZJR19ERUxMX1NNQklPU19XTUk9eQpDT05GSUdfREVMTF9TTUJJT1Nf U01NPXkKQ09ORklHX0RFTExfU01PODgwMD1tCkNPTkZJR19ERUxMX1dNST1tCkNPTkZJR19E RUxMX1dNSV9BSU89bQpDT05GSUdfREVMTF9XTUlfREVTQ1JJUFRPUj1tCkNPTkZJR19ERUxM X1dNSV9MRUQ9bQpDT05GSUdfREVMTF9XTUlfU1lTTUFOPW0KQ09ORklHX0FNSUxPX1JGS0lM TD1tCkNPTkZJR19GVUpJVFNVX0xBUFRPUD1tCkNPTkZJR19GVUpJVFNVX1RBQkxFVD1tCkNP TkZJR19HUERfUE9DS0VUX0ZBTj1tCkNPTkZJR19IUF9BQ0NFTD1tCkNPTkZJR19IUF9XSVJF TEVTUz1tCkNPTkZJR19IUF9XTUk9bQpDT05GSUdfSUJNX1JUTD1tCkNPTkZJR19JREVBUEFE X0xBUFRPUD1tCkNPTkZJR19TRU5TT1JTX0hEQVBTPW0KQ09ORklHX1RISU5LUEFEX0FDUEk9 bQpDT05GSUdfVEhJTktQQURfQUNQSV9BTFNBX1NVUFBPUlQ9eQojIENPTkZJR19USElOS1BB RF9BQ1BJX0RFQlVHRkFDSUxJVElFUyBpcyBub3Qgc2V0CiMgQ09ORklHX1RISU5LUEFEX0FD UElfREVCVUcgaXMgbm90IHNldAojIENPTkZJR19USElOS1BBRF9BQ1BJX1VOU0FGRV9MRURT IGlzIG5vdCBzZXQKQ09ORklHX1RISU5LUEFEX0FDUElfVklERU89eQpDT05GSUdfVEhJTktQ QURfQUNQSV9IT1RLRVlfUE9MTD15CkNPTkZJR19JTlRFTF9BVE9NSVNQMl9MRUQ9bQpDT05G SUdfSU5URUxfQ0hUX0lOVDMzRkU9bQpDT05GSUdfSU5URUxfSElEX0VWRU5UPW0KQ09ORklH X0lOVEVMX0lOVDAwMDJfVkdQSU89bQpDT05GSUdfSU5URUxfTUVOTE9XPW0KQ09ORklHX0lO VEVMX09BS1RSQUlMPW0KQ09ORklHX0lOVEVMX1ZCVE49bQpDT05GSUdfTVNJX0xBUFRPUD1t CkNPTkZJR19NU0lfV01JPW0KQ09ORklHX1BDRU5HSU5FU19BUFUyPW0KQ09ORklHX1NBTVNV TkdfTEFQVE9QPW0KQ09ORklHX1NBTVNVTkdfUTEwPW0KQ09ORklHX0FDUElfVE9TSElCQT1t CkNPTkZJR19UT1NISUJBX0JUX1JGS0lMTD1tCkNPTkZJR19UT1NISUJBX0hBUFM9bQpDT05G SUdfVE9TSElCQV9XTUk9bQpDT05GSUdfQUNQSV9DTVBDPW0KQ09ORklHX0NPTVBBTF9MQVBU T1A9bQpDT05GSUdfTEdfTEFQVE9QPW0KQ09ORklHX1BBTkFTT05JQ19MQVBUT1A9bQpDT05G SUdfU09OWV9MQVBUT1A9bQpDT05GSUdfU09OWVBJX0NPTVBBVD15CkNPTkZJR19TWVNURU03 Nl9BQ1BJPW0KQ09ORklHX1RPUFNUQVJfTEFQVE9QPW0KQ09ORklHX0kyQ19NVUxUSV9JTlNU QU5USUFURT1tCkNPTkZJR19NTFhfUExBVEZPUk09bQpDT05GSUdfVE9VQ0hTQ1JFRU5fRE1J PXkKQ09ORklHX0lOVEVMX0lQUz1tCkNPTkZJR19JTlRFTF9SU1Q9bQpDT05GSUdfSU5URUxf U01BUlRDT05ORUNUPW0KCiMKIyBJbnRlbCBTcGVlZCBTZWxlY3QgVGVjaG5vbG9neSBpbnRl cmZhY2Ugc3VwcG9ydAojCkNPTkZJR19JTlRFTF9TUEVFRF9TRUxFQ1RfSU5URVJGQUNFPW0K IyBlbmQgb2YgSW50ZWwgU3BlZWQgU2VsZWN0IFRlY2hub2xvZ3kgaW50ZXJmYWNlIHN1cHBv cnQKCkNPTkZJR19JTlRFTF9UVVJCT19NQVhfMz15CkNPTkZJR19JTlRFTF9VTkNPUkVfRlJF UV9DT05UUk9MPW0KQ09ORklHX0lOVEVMX0JYVFdDX1BNSUNfVE1VPW0KQ09ORklHX0lOVEVM X0NIVERDX1RJX1BXUkJUTj1tCkNPTkZJR19JTlRFTF9NUkZMRF9QV1JCVE49bQpDT05GSUdf SU5URUxfUE1DX0NPUkU9eQpDT05GSUdfSU5URUxfUE1UX0NMQVNTPW0KQ09ORklHX0lOVEVM X1BNVF9URUxFTUVUUlk9bQpDT05GSUdfSU5URUxfUE1UX0NSQVNITE9HPW0KQ09ORklHX0lO VEVMX1BVTklUX0lQQz1tCkNPTkZJR19JTlRFTF9TQ1VfSVBDPXkKQ09ORklHX0lOVEVMX1ND VT15CkNPTkZJR19JTlRFTF9TQ1VfUENJPXkKQ09ORklHX0lOVEVMX1NDVV9QTEFURk9STT1t CkNPTkZJR19JTlRFTF9TQ1VfSVBDX1VUSUw9bQpDT05GSUdfSU5URUxfVEVMRU1FVFJZPW0K Q09ORklHX1BNQ19BVE9NPXkKQ09ORklHX0NIUk9NRV9QTEFURk9STVM9eQpDT05GSUdfQ0hS T01FT1NfTEFQVE9QPW0KQ09ORklHX0NIUk9NRU9TX1BTVE9SRT1tCkNPTkZJR19DSFJPTUVP U19UQk1DPW0KQ09ORklHX0NST1NfRUM9bQpDT05GSUdfQ1JPU19FQ19JMkM9bQpDT05GSUdf Q1JPU19FQ19JU0hUUD1tCkNPTkZJR19DUk9TX0VDX1NQST1tCkNPTkZJR19DUk9TX0VDX0xQ Qz1tCkNPTkZJR19DUk9TX0VDX1BST1RPPXkKQ09ORklHX0NST1NfS0JEX0xFRF9CQUNLTElH SFQ9bQpDT05GSUdfQ1JPU19FQ19DSEFSREVWPW0KQ09ORklHX0NST1NfRUNfTElHSFRCQVI9 bQpDT05GSUdfQ1JPU19FQ19ERUJVR0ZTPW0KQ09ORklHX0NST1NfRUNfU0VOU09SSFVCPW0K Q09ORklHX0NST1NfRUNfU1lTRlM9bQpDT05GSUdfQ1JPU19FQ19UWVBFQz1tCkNPTkZJR19D Uk9TX1VTQlBEX0xPR0dFUj1tCkNPTkZJR19DUk9TX1VTQlBEX05PVElGWT1tCkNPTkZJR19X SUxDT19FQz1tCkNPTkZJR19XSUxDT19FQ19ERUJVR0ZTPW0KQ09ORklHX1dJTENPX0VDX0VW RU5UUz1tCkNPTkZJR19XSUxDT19FQ19URUxFTUVUUlk9bQpDT05GSUdfTUVMTEFOT1hfUExB VEZPUk09eQpDT05GSUdfTUxYUkVHX0hPVFBMVUc9bQpDT05GSUdfTUxYUkVHX0lPPW0KQ09O RklHX1NVUkZBQ0VfUExBVEZPUk1TPXkKQ09ORklHX1NVUkZBQ0UzX1dNST1tCkNPTkZJR19T VVJGQUNFXzNfQlVUVE9OPW0KQ09ORklHX1NVUkZBQ0VfM19QT1dFUl9PUFJFR0lPTj1tCkNP TkZJR19TVVJGQUNFX0FDUElfTk9USUZZPW0KQ09ORklHX1NVUkZBQ0VfQUdHUkVHQVRPUl9D REVWPW0KQ09ORklHX1NVUkZBQ0VfR1BFPW0KQ09ORklHX1NVUkZBQ0VfSE9UUExVRz1tCkNP TkZJR19TVVJGQUNFX1BSTzNfQlVUVE9OPW0KQ09ORklHX1NVUkZBQ0VfQUdHUkVHQVRPUj1t CkNPTkZJR19TVVJGQUNFX0FHR1JFR0FUT1JfQlVTPXkKIyBDT05GSUdfU1VSRkFDRV9BR0dS RUdBVE9SX0VSUk9SX0lOSkVDVElPTiBpcyBub3Qgc2V0CkNPTkZJR19IQVZFX0NMSz15CkNP TkZJR19DTEtERVZfTE9PS1VQPXkKQ09ORklHX0hBVkVfQ0xLX1BSRVBBUkU9eQpDT05GSUdf Q09NTU9OX0NMSz15CkNPTkZJR19DT01NT05fQ0xLX1dNODMxWD1tCkNPTkZJR19DT01NT05f Q0xLX01BWDk0ODU9bQpDT05GSUdfQ09NTU9OX0NMS19TSTUzNDE9bQpDT05GSUdfQ09NTU9O X0NMS19TSTUzNTE9bQpDT05GSUdfQ09NTU9OX0NMS19TSTU0ND1tCkNPTkZJR19DT01NT05f Q0xLX0NEQ0U3MDY9bQpDT05GSUdfQ09NTU9OX0NMS19DUzIwMDBfQ1A9bQpDT05GSUdfQ09N TU9OX0NMS19TMk1QUzExPW0KQ09ORklHX0NMS19UV0w2MDQwPW0KQ09ORklHX0NPTU1PTl9D TEtfUEFMTUFTPW0KQ09ORklHX0NPTU1PTl9DTEtfUFdNPW0KQ09ORklHX1hJTElOWF9WQ1U9 bQpDT05GSUdfSFdTUElOTE9DSz15CgojCiMgQ2xvY2sgU291cmNlIGRyaXZlcnMKIwpDT05G SUdfQ0xLRVZUX0k4MjUzPXkKQ09ORklHX0k4MjUzX0xPQ0s9eQpDT05GSUdfQ0xLQkxEX0k4 MjUzPXkKIyBlbmQgb2YgQ2xvY2sgU291cmNlIGRyaXZlcnMKCkNPTkZJR19NQUlMQk9YPXkK Q09ORklHX1BDQz15CkNPTkZJR19BTFRFUkFfTUJPWD1tCkNPTkZJR19JT01NVV9JT1ZBPXkK Q09ORklHX0lPQVNJRD15CkNPTkZJR19JT01NVV9BUEk9eQpDT05GSUdfSU9NTVVfU1VQUE9S VD15CgojCiMgR2VuZXJpYyBJT01NVSBQYWdldGFibGUgU3VwcG9ydAojCkNPTkZJR19JT01N VV9JT19QR1RBQkxFPXkKIyBlbmQgb2YgR2VuZXJpYyBJT01NVSBQYWdldGFibGUgU3VwcG9y dAoKIyBDT05GSUdfSU9NTVVfREVCVUdGUyBpcyBub3Qgc2V0CiMgQ09ORklHX0lPTU1VX0RF RkFVTFRfUEFTU1RIUk9VR0ggaXMgbm90IHNldApDT05GSUdfSU9NTVVfRE1BPXkKQ09ORklH X0FNRF9JT01NVT15CkNPTkZJR19BTURfSU9NTVVfVjI9eQpDT05GSUdfRE1BUl9UQUJMRT15 CkNPTkZJR19JTlRFTF9JT01NVT15CkNPTkZJR19JTlRFTF9JT01NVV9TVk09eQojIENPTkZJ R19JTlRFTF9JT01NVV9ERUZBVUxUX09OIGlzIG5vdCBzZXQKQ09ORklHX0lOVEVMX0lPTU1V X0ZMT1BQWV9XQT15CkNPTkZJR19JTlRFTF9JT01NVV9TQ0FMQUJMRV9NT0RFX0RFRkFVTFRf T049eQpDT05GSUdfSVJRX1JFTUFQPXkKQ09ORklHX0hZUEVSVl9JT01NVT15CgojCiMgUmVt b3RlcHJvYyBkcml2ZXJzCiMKQ09ORklHX1JFTU9URVBST0M9eQpDT05GSUdfUkVNT1RFUFJP Q19DREVWPXkKIyBlbmQgb2YgUmVtb3RlcHJvYyBkcml2ZXJzCgojCiMgUnBtc2cgZHJpdmVy cwojCkNPTkZJR19SUE1TRz1tCkNPTkZJR19SUE1TR19DSEFSPW0KQ09ORklHX1JQTVNHX05T PW0KQ09ORklHX1JQTVNHX1FDT01fR0xJTks9bQpDT05GSUdfUlBNU0dfUUNPTV9HTElOS19S UE09bQpDT05GSUdfUlBNU0dfVklSVElPPW0KIyBlbmQgb2YgUnBtc2cgZHJpdmVycwoKQ09O RklHX1NPVU5EV0lSRT1tCgojCiMgU291bmRXaXJlIERldmljZXMKIwpDT05GSUdfU09VTkRX SVJFX0NBREVOQ0U9bQpDT05GSUdfU09VTkRXSVJFX0lOVEVMPW0KQ09ORklHX1NPVU5EV0lS RV9RQ09NPW0KQ09ORklHX1NPVU5EV0lSRV9HRU5FUklDX0FMTE9DQVRJT049bQoKIwojIFNP QyAoU3lzdGVtIE9uIENoaXApIHNwZWNpZmljIERyaXZlcnMKIwoKIwojIEFtbG9naWMgU29D IGRyaXZlcnMKIwojIGVuZCBvZiBBbWxvZ2ljIFNvQyBkcml2ZXJzCgojCiMgQnJvYWRjb20g U29DIGRyaXZlcnMKIwojIGVuZCBvZiBCcm9hZGNvbSBTb0MgZHJpdmVycwoKIwojIE5YUC9G cmVlc2NhbGUgUW9ySVEgU29DIGRyaXZlcnMKIwojIGVuZCBvZiBOWFAvRnJlZXNjYWxlIFFv cklRIFNvQyBkcml2ZXJzCgojCiMgaS5NWCBTb0MgZHJpdmVycwojCiMgZW5kIG9mIGkuTVgg U29DIGRyaXZlcnMKCiMKIyBFbmFibGUgTGl0ZVggU29DIEJ1aWxkZXIgc3BlY2lmaWMgZHJp dmVycwojCiMgZW5kIG9mIEVuYWJsZSBMaXRlWCBTb0MgQnVpbGRlciBzcGVjaWZpYyBkcml2 ZXJzCgojCiMgUXVhbGNvbW0gU29DIGRyaXZlcnMKIwpDT05GSUdfUUNPTV9RTUlfSEVMUEVS Uz1tCiMgZW5kIG9mIFF1YWxjb21tIFNvQyBkcml2ZXJzCgpDT05GSUdfU09DX1RJPXkKCiMK IyBYaWxpbnggU29DIGRyaXZlcnMKIwojIGVuZCBvZiBYaWxpbnggU29DIGRyaXZlcnMKIyBl bmQgb2YgU09DIChTeXN0ZW0gT24gQ2hpcCkgc3BlY2lmaWMgRHJpdmVycwoKQ09ORklHX1BN X0RFVkZSRVE9eQoKIwojIERFVkZSRVEgR292ZXJub3JzCiMKQ09ORklHX0RFVkZSRVFfR09W X1NJTVBMRV9PTkRFTUFORD1tCkNPTkZJR19ERVZGUkVRX0dPVl9QRVJGT1JNQU5DRT1tCkNP TkZJR19ERVZGUkVRX0dPVl9QT1dFUlNBVkU9bQpDT05GSUdfREVWRlJFUV9HT1ZfVVNFUlNQ QUNFPW0KQ09ORklHX0RFVkZSRVFfR09WX1BBU1NJVkU9bQoKIwojIERFVkZSRVEgRHJpdmVy cwojCkNPTkZJR19QTV9ERVZGUkVRX0VWRU5UPXkKQ09ORklHX0VYVENPTj15CgojCiMgRXh0 Y29uIERldmljZSBEcml2ZXJzCiMKQ09ORklHX0VYVENPTl9BRENfSkFDSz1tCkNPTkZJR19F WFRDT05fQVJJWk9OQT1tCkNPTkZJR19FWFRDT05fQVhQMjg4PW0KQ09ORklHX0VYVENPTl9G U0E5NDgwPW0KQ09ORklHX0VYVENPTl9HUElPPW0KQ09ORklHX0VYVENPTl9JTlRFTF9JTlQz NDk2PW0KQ09ORklHX0VYVENPTl9JTlRFTF9DSFRfV0M9bQpDT05GSUdfRVhUQ09OX0lOVEVM X01SRkxEPW0KQ09ORklHX0VYVENPTl9NQVgxNDU3Nz1tCkNPTkZJR19FWFRDT05fTUFYMzM1 NT1tCkNPTkZJR19FWFRDT05fTUFYNzc2OTM9bQpDT05GSUdfRVhUQ09OX01BWDc3ODQzPW0K Q09ORklHX0VYVENPTl9NQVg4OTk3PW0KQ09ORklHX0VYVENPTl9QQUxNQVM9bQpDT05GSUdf RVhUQ09OX1BUTjUxNTA9bQpDT05GSUdfRVhUQ09OX1JUODk3M0E9bQpDT05GSUdfRVhUQ09O X1NNNTUwMj1tCkNPTkZJR19FWFRDT05fVVNCX0dQSU89bQpDT05GSUdfRVhUQ09OX1VTQkNf Q1JPU19FQz1tCkNPTkZJR19FWFRDT05fVVNCQ19UVVNCMzIwPW0KQ09ORklHX01FTU9SWT15 CkNPTkZJR19GUEdBX0RGTF9FTUlGPW0KQ09ORklHX0lJTz1tCkNPTkZJR19JSU9fQlVGRkVS PXkKQ09ORklHX0lJT19CVUZGRVJfQ0I9bQpDT05GSUdfSUlPX0JVRkZFUl9ETUE9bQpDT05G SUdfSUlPX0JVRkZFUl9ETUFFTkdJTkU9bQpDT05GSUdfSUlPX0JVRkZFUl9IV19DT05TVU1F Uj1tCkNPTkZJR19JSU9fS0ZJRk9fQlVGPW0KQ09ORklHX0lJT19UUklHR0VSRURfQlVGRkVS PW0KQ09ORklHX0lJT19DT05GSUdGUz1tCkNPTkZJR19JSU9fVFJJR0dFUj15CkNPTkZJR19J SU9fQ09OU1VNRVJTX1BFUl9UUklHR0VSPTIKQ09ORklHX0lJT19TV19ERVZJQ0U9bQpDT05G SUdfSUlPX1NXX1RSSUdHRVI9bQpDT05GSUdfSUlPX1RSSUdHRVJFRF9FVkVOVD1tCgojCiMg QWNjZWxlcm9tZXRlcnMKIwpDT05GSUdfQURJUzE2MjAxPW0KQ09ORklHX0FESVMxNjIwOT1t CkNPTkZJR19BRFhMMzcyPW0KQ09ORklHX0FEWEwzNzJfU1BJPW0KQ09ORklHX0FEWEwzNzJf STJDPW0KQ09ORklHX0JNQTIyMD1tCkNPTkZJR19CTUE0MDA9bQpDT05GSUdfQk1BNDAwX0ky Qz1tCkNPTkZJR19CTUE0MDBfU1BJPW0KQ09ORklHX0JNQzE1MF9BQ0NFTD1tCkNPTkZJR19C TUMxNTBfQUNDRUxfSTJDPW0KQ09ORklHX0JNQzE1MF9BQ0NFTF9TUEk9bQpDT05GSUdfREEy ODA9bQpDT05GSUdfREEzMTE9bQpDT05GSUdfRE1BUkQwOT1tCkNPTkZJR19ETUFSRDEwPW0K Q09ORklHX0hJRF9TRU5TT1JfQUNDRUxfM0Q9bQpDT05GSUdfSUlPX0NST1NfRUNfQUNDRUxf TEVHQUNZPW0KQ09ORklHX0lJT19TVF9BQ0NFTF8zQVhJUz1tCkNPTkZJR19JSU9fU1RfQUND RUxfSTJDXzNBWElTPW0KQ09ORklHX0lJT19TVF9BQ0NFTF9TUElfM0FYSVM9bQpDT05GSUdf S1hTRDk9bQpDT05GSUdfS1hTRDlfU1BJPW0KQ09ORklHX0tYU0Q5X0kyQz1tCkNPTkZJR19L WENKSzEwMTM9bQpDT05GSUdfTUMzMjMwPW0KQ09ORklHX01NQTc0NTU9bQpDT05GSUdfTU1B NzQ1NV9JMkM9bQpDT05GSUdfTU1BNzQ1NV9TUEk9bQpDT05GSUdfTU1BNzY2MD1tCkNPTkZJ R19NTUE4NDUyPW0KQ09ORklHX01NQTk1NTFfQ09SRT1tCkNPTkZJR19NTUE5NTUxPW0KQ09O RklHX01NQTk1NTM9bQpDT05GSUdfTVhDNDAwNT1tCkNPTkZJR19NWEM2MjU1PW0KQ09ORklH X1NDQTMwMDA9bQpDT05GSUdfU1RLODMxMj1tCkNPTkZJR19TVEs4QkE1MD1tCiMgZW5kIG9m IEFjY2VsZXJvbWV0ZXJzCgojCiMgQW5hbG9nIHRvIGRpZ2l0YWwgY29udmVydGVycwojCkNP TkZJR19BRF9TSUdNQV9ERUxUQT1tCkNPTkZJR19BRDcwOTFSNT1tCkNPTkZJR19BRDcxMjQ9 bQpDT05GSUdfQUQ3MTkyPW0KQ09ORklHX0FENzI2Nj1tCkNPTkZJR19BRDcyOTE9bQpDT05G SUdfQUQ3MjkyPW0KQ09ORklHX0FENzI5OD1tCkNPTkZJR19BRDc0NzY9bQpDT05GSUdfQUQ3 NjA2PW0KQ09ORklHX0FENzYwNl9JRkFDRV9QQVJBTExFTD1tCkNPTkZJR19BRDc2MDZfSUZB Q0VfU1BJPW0KQ09ORklHX0FENzc2Nj1tCkNPTkZJR19BRDc3NjhfMT1tCkNPTkZJR19BRDc3 ODA9bQpDT05GSUdfQUQ3NzkxPW0KQ09ORklHX0FENzc5Mz1tCkNPTkZJR19BRDc4ODc9bQpD T05GSUdfQUQ3OTIzPW0KQ09ORklHX0FENzk0OT1tCkNPTkZJR19BRDc5OVg9bQojIENPTkZJ R19BRDk0NjcgaXMgbm90IHNldAojIENPTkZJR19BRElfQVhJX0FEQyBpcyBub3Qgc2V0CkNP TkZJR19BWFAyMFhfQURDPW0KQ09ORklHX0FYUDI4OF9BREM9bQpDT05GSUdfQ0MxMDAwMV9B REM9bQpDT05GSUdfREE5MTUwX0dQQURDPW0KQ09ORklHX0RMTjJfQURDPW0KQ09ORklHX0hJ ODQzNT1tCkNPTkZJR19IWDcxMT1tCkNPTkZJR19JTkEyWFhfQURDPW0KQ09ORklHX0lOVEVM X01SRkxEX0FEQz1tCkNPTkZJR19MUDg3ODhfQURDPW0KQ09ORklHX0xUQzI0NzE9bQpDT05G SUdfTFRDMjQ4NT1tCkNPTkZJR19MVEMyNDk2PW0KQ09ORklHX0xUQzI0OTc9bQpDT05GSUdf TUFYMTAyNz1tCkNPTkZJR19NQVgxMTEwMD1tCkNPTkZJR19NQVgxMTE4PW0KQ09ORklHX01B WDEyNDE9bQpDT05GSUdfTUFYMTM2Mz1tCkNPTkZJR19NQVg5NjExPW0KQ09ORklHX01DUDMy MFg9bQpDT05GSUdfTUNQMzQyMj1tCkNPTkZJR19NQ1AzOTExPW0KQ09ORklHX01FRElBVEVL X01UNjM2MF9BREM9bQpDT05GSUdfTUVOX1oxODhfQURDPW0KQ09ORklHX01QMjYyOV9BREM9 bQpDT05GSUdfTkFVNzgwMj1tCkNPTkZJR19QQUxNQVNfR1BBREM9bQpDT05GSUdfVElfQURD MDgxQz1tCkNPTkZJR19USV9BREMwODMyPW0KQ09ORklHX1RJX0FEQzA4NFMwMjE9bQpDT05G SUdfVElfQURDMTIxMzg9bQpDT05GSUdfVElfQURDMTA4UzEwMj1tCkNPTkZJR19USV9BREMx MjhTMDUyPW0KQ09ORklHX1RJX0FEQzE2MVM2MjY9bQpDT05GSUdfVElfQURTMTAxNT1tCkNP TkZJR19USV9BRFM3OTUwPW0KQ09ORklHX1RJX0FNMzM1WF9BREM9bQpDT05GSUdfVElfVExD NDU0MT1tCkNPTkZJR19UV0w0MDMwX01BREM9bQpDT05GSUdfVFdMNjAzMF9HUEFEQz1tCkNP TkZJR19WSVBFUkJPQVJEX0FEQz1tCkNPTkZJR19YSUxJTlhfWEFEQz1tCiMgZW5kIG9mIEFu YWxvZyB0byBkaWdpdGFsIGNvbnZlcnRlcnMKCiMKIyBBbmFsb2cgRnJvbnQgRW5kcwojCiMg ZW5kIG9mIEFuYWxvZyBGcm9udCBFbmRzCgojCiMgQW1wbGlmaWVycwojCkNPTkZJR19BRDgz NjY9bQpDT05GSUdfSE1DNDI1PW0KIyBlbmQgb2YgQW1wbGlmaWVycwoKIwojIENoZW1pY2Fs IFNlbnNvcnMKIwpDT05GSUdfQVRMQVNfUEhfU0VOU09SPW0KQ09ORklHX0FUTEFTX0VaT19T RU5TT1I9bQpDT05GSUdfQk1FNjgwPW0KQ09ORklHX0JNRTY4MF9JMkM9bQpDT05GSUdfQk1F NjgwX1NQST1tCkNPTkZJR19DQ1M4MTE9bQpDT05GSUdfSUFRQ09SRT1tCkNPTkZJR19QTVM3 MDAzPW0KQ09ORklHX1NDRDMwX0NPUkU9bQpDT05GSUdfU0NEMzBfSTJDPW0KQ09ORklHX1ND RDMwX1NFUklBTD1tCkNPTkZJR19TRU5TSVJJT05fU0dQMzA9bQpDT05GSUdfU1BTMzA9bQpD T05GSUdfVlo4OVg9bQojIGVuZCBvZiBDaGVtaWNhbCBTZW5zb3JzCgpDT05GSUdfSUlPX0NS T1NfRUNfU0VOU09SU19DT1JFPW0KQ09ORklHX0lJT19DUk9TX0VDX1NFTlNPUlM9bQpDT05G SUdfSUlPX0NST1NfRUNfU0VOU09SU19MSURfQU5HTEU9bQoKIwojIEhpZCBTZW5zb3IgSUlP IENvbW1vbgojCkNPTkZJR19ISURfU0VOU09SX0lJT19DT01NT049bQpDT05GSUdfSElEX1NF TlNPUl9JSU9fVFJJR0dFUj1tCiMgZW5kIG9mIEhpZCBTZW5zb3IgSUlPIENvbW1vbgoKQ09O RklHX0lJT19NU19TRU5TT1JTX0kyQz1tCgojCiMgU1NQIFNlbnNvciBDb21tb24KIwpDT05G SUdfSUlPX1NTUF9TRU5TT1JTX0NPTU1PTlM9bQpDT05GSUdfSUlPX1NTUF9TRU5TT1JIVUI9 bQojIGVuZCBvZiBTU1AgU2Vuc29yIENvbW1vbgoKQ09ORklHX0lJT19TVF9TRU5TT1JTX0ky Qz1tCkNPTkZJR19JSU9fU1RfU0VOU09SU19TUEk9bQpDT05GSUdfSUlPX1NUX1NFTlNPUlNf Q09SRT1tCgojCiMgRGlnaXRhbCB0byBhbmFsb2cgY29udmVydGVycwojCkNPTkZJR19BRDUw NjQ9bQpDT05GSUdfQUQ1MzYwPW0KQ09ORklHX0FENTM4MD1tCkNPTkZJR19BRDU0MjE9bQpD T05GSUdfQUQ1NDQ2PW0KQ09ORklHX0FENTQ0OT1tCkNPTkZJR19BRDU1OTJSX0JBU0U9bQpD T05GSUdfQUQ1NTkyUj1tCkNPTkZJR19BRDU1OTNSPW0KQ09ORklHX0FENTUwND1tCkNPTkZJ R19BRDU2MjRSX1NQST1tCkNPTkZJR19BRDU2ODY9bQpDT05GSUdfQUQ1Njg2X1NQST1tCkNP TkZJR19BRDU2OTZfSTJDPW0KQ09ORklHX0FENTc1NT1tCkNPTkZJR19BRDU3NTg9bQpDT05G SUdfQUQ1NzYxPW0KQ09ORklHX0FENTc2ND1tCkNPTkZJR19BRDU3NjY9bQpDT05GSUdfQUQ1 NzcwUj1tCkNPTkZJR19BRDU3OTE9bQpDT05GSUdfQUQ3MzAzPW0KQ09ORklHX0FEODgwMT1t CkNPTkZJR19EUzQ0MjQ9bQpDT05GSUdfTFRDMTY2MD1tCkNPTkZJR19MVEMyNjMyPW0KQ09O RklHX002MjMzMj1tCkNPTkZJR19NQVg1MTc9bQpDT05GSUdfTUNQNDcyNT1tCkNPTkZJR19N Q1A0OTIyPW0KQ09ORklHX1RJX0RBQzA4MlMwODU9bQpDT05GSUdfVElfREFDNTU3MT1tCkNP TkZJR19USV9EQUM3MzExPW0KQ09ORklHX1RJX0RBQzc2MTI9bQojIGVuZCBvZiBEaWdpdGFs IHRvIGFuYWxvZyBjb252ZXJ0ZXJzCgojCiMgSUlPIGR1bW15IGRyaXZlcgojCiMgQ09ORklH X0lJT19TSU1QTEVfRFVNTVkgaXMgbm90IHNldAojIGVuZCBvZiBJSU8gZHVtbXkgZHJpdmVy CgojCiMgRnJlcXVlbmN5IFN5bnRoZXNpemVycyBERFMvUExMCiMKCiMKIyBDbG9jayBHZW5l cmF0b3IvRGlzdHJpYnV0aW9uCiMKQ09ORklHX0FEOTUyMz1tCiMgZW5kIG9mIENsb2NrIEdl bmVyYXRvci9EaXN0cmlidXRpb24KCiMKIyBQaGFzZS1Mb2NrZWQgTG9vcCAoUExMKSBmcmVx dWVuY3kgc3ludGhlc2l6ZXJzCiMKQ09ORklHX0FERjQzNTA9bQpDT05GSUdfQURGNDM3MT1t CiMgZW5kIG9mIFBoYXNlLUxvY2tlZCBMb29wIChQTEwpIGZyZXF1ZW5jeSBzeW50aGVzaXpl cnMKIyBlbmQgb2YgRnJlcXVlbmN5IFN5bnRoZXNpemVycyBERFMvUExMCgojCiMgRGlnaXRh bCBneXJvc2NvcGUgc2Vuc29ycwojCkNPTkZJR19BRElTMTYwODA9bQpDT05GSUdfQURJUzE2 MTMwPW0KQ09ORklHX0FESVMxNjEzNj1tCkNPTkZJR19BRElTMTYyNjA9bQpDT05GSUdfQURY UlMyOTA9bQpDT05GSUdfQURYUlM0NTA9bQpDT05GSUdfQk1HMTYwPW0KQ09ORklHX0JNRzE2 MF9JMkM9bQpDT05GSUdfQk1HMTYwX1NQST1tCkNPTkZJR19GWEFTMjEwMDJDPW0KQ09ORklH X0ZYQVMyMTAwMkNfSTJDPW0KQ09ORklHX0ZYQVMyMTAwMkNfU1BJPW0KQ09ORklHX0hJRF9T RU5TT1JfR1lST18zRD1tCkNPTkZJR19NUFUzMDUwPW0KQ09ORklHX01QVTMwNTBfSTJDPW0K Q09ORklHX0lJT19TVF9HWVJPXzNBWElTPW0KQ09ORklHX0lJT19TVF9HWVJPX0kyQ18zQVhJ Uz1tCkNPTkZJR19JSU9fU1RfR1lST19TUElfM0FYSVM9bQpDT05GSUdfSVRHMzIwMD1tCiMg ZW5kIG9mIERpZ2l0YWwgZ3lyb3Njb3BlIHNlbnNvcnMKCiMKIyBIZWFsdGggU2Vuc29ycwoj CgojCiMgSGVhcnQgUmF0ZSBNb25pdG9ycwojCkNPTkZJR19BRkU0NDAzPW0KQ09ORklHX0FG RTQ0MDQ9bQpDT05GSUdfTUFYMzAxMDA9bQpDT05GSUdfTUFYMzAxMDI9bQojIGVuZCBvZiBI ZWFydCBSYXRlIE1vbml0b3JzCiMgZW5kIG9mIEhlYWx0aCBTZW5zb3JzCgojCiMgSHVtaWRp dHkgc2Vuc29ycwojCkNPTkZJR19BTTIzMTU9bQpDT05GSUdfREhUMTE9bQpDT05GSUdfSERD MTAwWD1tCkNPTkZJR19IREMyMDEwPW0KQ09ORklHX0hJRF9TRU5TT1JfSFVNSURJVFk9bQpD T05GSUdfSFRTMjIxPW0KQ09ORklHX0hUUzIyMV9JMkM9bQpDT05GSUdfSFRTMjIxX1NQST1t CkNPTkZJR19IVFUyMT1tCkNPTkZJR19TSTcwMDU9bQpDT05GSUdfU0k3MDIwPW0KIyBlbmQg b2YgSHVtaWRpdHkgc2Vuc29ycwoKIwojIEluZXJ0aWFsIG1lYXN1cmVtZW50IHVuaXRzCiMK Q09ORklHX0FESVMxNjQwMD1tCkNPTkZJR19BRElTMTY0NjA9bQpDT05GSUdfQURJUzE2NDc1 PW0KQ09ORklHX0FESVMxNjQ4MD1tCkNPTkZJR19CTUkxNjA9bQpDT05GSUdfQk1JMTYwX0ky Qz1tCkNPTkZJR19CTUkxNjBfU1BJPW0KQ09ORklHX0ZYT1M4NzAwPW0KQ09ORklHX0ZYT1M4 NzAwX0kyQz1tCkNPTkZJR19GWE9TODcwMF9TUEk9bQpDT05GSUdfS01YNjE9bQpDT05GSUdf SU5WX0lDTTQyNjAwPW0KQ09ORklHX0lOVl9JQ000MjYwMF9JMkM9bQpDT05GSUdfSU5WX0lD TTQyNjAwX1NQST1tCkNPTkZJR19JTlZfTVBVNjA1MF9JSU89bQpDT05GSUdfSU5WX01QVTYw NTBfSTJDPW0KQ09ORklHX0lOVl9NUFU2MDUwX1NQST1tCkNPTkZJR19JSU9fU1RfTFNNNkRT WD1tCkNPTkZJR19JSU9fU1RfTFNNNkRTWF9JMkM9bQpDT05GSUdfSUlPX1NUX0xTTTZEU1hf U1BJPW0KIyBlbmQgb2YgSW5lcnRpYWwgbWVhc3VyZW1lbnQgdW5pdHMKCkNPTkZJR19JSU9f QURJU19MSUI9bQpDT05GSUdfSUlPX0FESVNfTElCX0JVRkZFUj15CgojCiMgTGlnaHQgc2Vu c29ycwojCkNPTkZJR19BQ1BJX0FMUz1tCkNPTkZJR19BREpEX1MzMTE9bQpDT05GSUdfQURV WDEwMjA9bQpDT05GSUdfQUwzMDEwPW0KQ09ORklHX0FMMzMyMEE9bQpDT05GSUdfQVBEUzkz MDA9bQpDT05GSUdfQVBEUzk5NjA9bQpDT05GSUdfQVM3MzIxMT1tCkNPTkZJR19CSDE3NTA9 bQpDT05GSUdfQkgxNzgwPW0KQ09ORklHX0NNMzIxODE9bQpDT05GSUdfQ00zMjMyPW0KQ09O RklHX0NNMzMyMz1tCkNPTkZJR19DTTM2NjUxPW0KQ09ORklHX0lJT19DUk9TX0VDX0xJR0hU X1BST1g9bQpDT05GSUdfR1AyQVAwMDI9bQpDT05GSUdfR1AyQVAwMjBBMDBGPW0KQ09ORklH X0lRUzYyMV9BTFM9bQpDT05GSUdfU0VOU09SU19JU0wyOTAxOD1tCkNPTkZJR19TRU5TT1JT X0lTTDI5MDI4PW0KQ09ORklHX0lTTDI5MTI1PW0KQ09ORklHX0hJRF9TRU5TT1JfQUxTPW0K Q09ORklHX0hJRF9TRU5TT1JfUFJPWD1tCkNPTkZJR19KU0ExMjEyPW0KQ09ORklHX1JQUjA1 MjE9bQpDT05GSUdfU0VOU09SU19MTTM1MzM9bQpDT05GSUdfTFRSNTAxPW0KQ09ORklHX0xW MDEwNENTPW0KQ09ORklHX01BWDQ0MDAwPW0KQ09ORklHX01BWDQ0MDA5PW0KQ09ORklHX05P QTEzMDU9bQpDT05GSUdfT1BUMzAwMT1tCkNPTkZJR19QQTEyMjAzMDAxPW0KQ09ORklHX1NJ MTEzMz1tCkNPTkZJR19TSTExNDU9bQpDT05GSUdfU1RLMzMxMD1tCkNPTkZJR19TVF9VVklT MjU9bQpDT05GSUdfU1RfVVZJUzI1X0kyQz1tCkNPTkZJR19TVF9VVklTMjVfU1BJPW0KQ09O RklHX1RDUzM0MTQ9bQpDT05GSUdfVENTMzQ3Mj1tCkNPTkZJR19TRU5TT1JTX1RTTDI1NjM9 bQpDT05GSUdfVFNMMjU4Mz1tCkNPTkZJR19UU0wyNzcyPW0KQ09ORklHX1RTTDQ1MzE9bQpD T05GSUdfVVM1MTgyRD1tCkNPTkZJR19WQ05MNDAwMD1tCkNPTkZJR19WQ05MNDAzNT1tCkNP TkZJR19WRU1MNjAzMD1tCkNPTkZJR19WRU1MNjA3MD1tCkNPTkZJR19WTDYxODA9bQpDT05G SUdfWk9QVDIyMDE9bQojIGVuZCBvZiBMaWdodCBzZW5zb3JzCgojCiMgTWFnbmV0b21ldGVy IHNlbnNvcnMKIwpDT05GSUdfQUs4OTc1PW0KQ09ORklHX0FLMDk5MTE9bQpDT05GSUdfQk1D MTUwX01BR049bQpDT05GSUdfQk1DMTUwX01BR05fSTJDPW0KQ09ORklHX0JNQzE1MF9NQUdO X1NQST1tCkNPTkZJR19NQUczMTEwPW0KQ09ORklHX0hJRF9TRU5TT1JfTUFHTkVUT01FVEVS XzNEPW0KQ09ORklHX01NQzM1MjQwPW0KQ09ORklHX0lJT19TVF9NQUdOXzNBWElTPW0KQ09O RklHX0lJT19TVF9NQUdOX0kyQ18zQVhJUz1tCkNPTkZJR19JSU9fU1RfTUFHTl9TUElfM0FY SVM9bQpDT05GSUdfU0VOU09SU19ITUM1ODQzPW0KQ09ORklHX1NFTlNPUlNfSE1DNTg0M19J MkM9bQpDT05GSUdfU0VOU09SU19ITUM1ODQzX1NQST1tCkNPTkZJR19TRU5TT1JTX1JNMzEw MD1tCkNPTkZJR19TRU5TT1JTX1JNMzEwMF9JMkM9bQpDT05GSUdfU0VOU09SU19STTMxMDBf U1BJPW0KQ09ORklHX1lBTUFIQV9ZQVM1MzA9bQojIGVuZCBvZiBNYWduZXRvbWV0ZXIgc2Vu c29ycwoKIwojIE11bHRpcGxleGVycwojCiMgZW5kIG9mIE11bHRpcGxleGVycwoKIwojIElu Y2xpbm9tZXRlciBzZW5zb3JzCiMKQ09ORklHX0hJRF9TRU5TT1JfSU5DTElOT01FVEVSXzNE PW0KQ09ORklHX0hJRF9TRU5TT1JfREVWSUNFX1JPVEFUSU9OPW0KIyBlbmQgb2YgSW5jbGlu b21ldGVyIHNlbnNvcnMKCiMKIyBUcmlnZ2VycyAtIHN0YW5kYWxvbmUKIwpDT05GSUdfSUlP X0hSVElNRVJfVFJJR0dFUj1tCkNPTkZJR19JSU9fSU5URVJSVVBUX1RSSUdHRVI9bQpDT05G SUdfSUlPX1RJR0hUTE9PUF9UUklHR0VSPW0KQ09ORklHX0lJT19TWVNGU19UUklHR0VSPW0K IyBlbmQgb2YgVHJpZ2dlcnMgLSBzdGFuZGFsb25lCgojCiMgTGluZWFyIGFuZCBhbmd1bGFy IHBvc2l0aW9uIHNlbnNvcnMKIwpDT05GSUdfSVFTNjI0X1BPUz1tCkNPTkZJR19ISURfU0VO U09SX0NVU1RPTV9JTlRFTF9ISU5HRT1tCiMgZW5kIG9mIExpbmVhciBhbmQgYW5ndWxhciBw b3NpdGlvbiBzZW5zb3JzCgojCiMgRGlnaXRhbCBwb3RlbnRpb21ldGVycwojCkNPTkZJR19B RDUyNzI9bQpDT05GSUdfRFMxODAzPW0KQ09ORklHX01BWDU0MzI9bQpDT05GSUdfTUFYNTQ4 MT1tCkNPTkZJR19NQVg1NDg3PW0KQ09ORklHX01DUDQwMTg9bQpDT05GSUdfTUNQNDEzMT1t CkNPTkZJR19NQ1A0NTMxPW0KQ09ORklHX01DUDQxMDEwPW0KQ09ORklHX1RQTDAxMDI9bQoj IGVuZCBvZiBEaWdpdGFsIHBvdGVudGlvbWV0ZXJzCgojCiMgRGlnaXRhbCBwb3RlbnRpb3N0 YXRzCiMKQ09ORklHX0xNUDkxMDAwPW0KIyBlbmQgb2YgRGlnaXRhbCBwb3RlbnRpb3N0YXRz CgojCiMgUHJlc3N1cmUgc2Vuc29ycwojCkNPTkZJR19BQlAwNjBNRz1tCkNPTkZJR19CTVAy ODA9bQpDT05GSUdfQk1QMjgwX0kyQz1tCkNPTkZJR19CTVAyODBfU1BJPW0KQ09ORklHX0lJ T19DUk9TX0VDX0JBUk89bQpDT05GSUdfRExITDYwRD1tCkNPTkZJR19EUFMzMTA9bQpDT05G SUdfSElEX1NFTlNPUl9QUkVTUz1tCkNPTkZJR19IUDAzPW0KQ09ORklHX0lDUDEwMTAwPW0K Q09ORklHX01QTDExNT1tCkNPTkZJR19NUEwxMTVfSTJDPW0KQ09ORklHX01QTDExNV9TUEk9 bQpDT05GSUdfTVBMMzExNT1tCkNPTkZJR19NUzU2MTE9bQpDT05GSUdfTVM1NjExX0kyQz1t CkNPTkZJR19NUzU2MTFfU1BJPW0KQ09ORklHX01TNTYzNz1tCkNPTkZJR19JSU9fU1RfUFJF U1M9bQpDT05GSUdfSUlPX1NUX1BSRVNTX0kyQz1tCkNPTkZJR19JSU9fU1RfUFJFU1NfU1BJ PW0KQ09ORklHX1Q1NDAzPW0KQ09ORklHX0hQMjA2Qz1tCkNPTkZJR19aUEEyMzI2PW0KQ09O RklHX1pQQTIzMjZfSTJDPW0KQ09ORklHX1pQQTIzMjZfU1BJPW0KIyBlbmQgb2YgUHJlc3N1 cmUgc2Vuc29ycwoKIwojIExpZ2h0bmluZyBzZW5zb3JzCiMKQ09ORklHX0FTMzkzNT1tCiMg ZW5kIG9mIExpZ2h0bmluZyBzZW5zb3JzCgojCiMgUHJveGltaXR5IGFuZCBkaXN0YW5jZSBz ZW5zb3JzCiMKQ09ORklHX0lTTDI5NTAxPW0KQ09ORklHX0xJREFSX0xJVEVfVjI9bQpDT05G SUdfTUIxMjMyPW0KQ09ORklHX1BJTkc9bQpDT05GSUdfUkZENzc0MDI9bQpDT05GSUdfU1JG MDQ9bQpDT05GSUdfU1g5MzEwPW0KQ09ORklHX1NYOTUwMD1tCkNPTkZJR19TUkYwOD1tCkNP TkZJR19WQ05MMzAyMD1tCkNPTkZJR19WTDUzTDBYX0kyQz1tCiMgZW5kIG9mIFByb3hpbWl0 eSBhbmQgZGlzdGFuY2Ugc2Vuc29ycwoKIwojIFJlc29sdmVyIHRvIGRpZ2l0YWwgY29udmVy dGVycwojCkNPTkZJR19BRDJTOTA9bQpDT05GSUdfQUQyUzEyMDA9bQojIGVuZCBvZiBSZXNv bHZlciB0byBkaWdpdGFsIGNvbnZlcnRlcnMKCiMKIyBUZW1wZXJhdHVyZSBzZW5zb3JzCiMK Q09ORklHX0lRUzYyMEFUX1RFTVA9bQpDT05GSUdfTFRDMjk4Mz1tCkNPTkZJR19NQVhJTV9U SEVSTU9DT1VQTEU9bQpDT05GSUdfSElEX1NFTlNPUl9URU1QPW0KQ09ORklHX01MWDkwNjE0 PW0KQ09ORklHX01MWDkwNjMyPW0KQ09ORklHX1RNUDAwNj1tCkNPTkZJR19UTVAwMDc9bQpD T05GSUdfVFNZUzAxPW0KQ09ORklHX1RTWVMwMkQ9bQpDT05GSUdfTUFYMzE4NTY9bQojIGVu ZCBvZiBUZW1wZXJhdHVyZSBzZW5zb3JzCgpDT05GSUdfTlRCPW0KQ09ORklHX05UQl9NU0k9 eQpDT05GSUdfTlRCX0FNRD1tCkNPTkZJR19OVEJfSURUPW0KQ09ORklHX05UQl9JTlRFTD1t CkNPTkZJR19OVEJfRVBGPW0KQ09ORklHX05UQl9TV0lUQ0hURUM9bQojIENPTkZJR19OVEJf UElOR1BPTkcgaXMgbm90IHNldAojIENPTkZJR19OVEJfVE9PTCBpcyBub3Qgc2V0CiMgQ09O RklHX05UQl9QRVJGIGlzIG5vdCBzZXQKIyBDT05GSUdfTlRCX01TSV9URVNUIGlzIG5vdCBz ZXQKQ09ORklHX05UQl9UUkFOU1BPUlQ9bQojIENPTkZJR19WTUVfQlVTIGlzIG5vdCBzZXQK Q09ORklHX1BXTT15CkNPTkZJR19QV01fU1lTRlM9eQojIENPTkZJR19QV01fREVCVUcgaXMg bm90IHNldApDT05GSUdfUFdNX0NSQz15CkNPTkZJR19QV01fQ1JPU19FQz1tCkNPTkZJR19Q V01fRFdDPW0KQ09ORklHX1BXTV9JUVM2MjBBPW0KQ09ORklHX1BXTV9MUDM5NDM9bQpDT05G SUdfUFdNX0xQU1M9bQpDT05GSUdfUFdNX0xQU1NfUENJPW0KQ09ORklHX1BXTV9MUFNTX1BM QVRGT1JNPW0KQ09ORklHX1BXTV9QQ0E5Njg1PW0KQ09ORklHX1BXTV9UV0w9bQpDT05GSUdf UFdNX1RXTF9MRUQ9bQoKIwojIElSUSBjaGlwIHN1cHBvcnQKIwpDT05GSUdfTUFERVJBX0lS UT1tCiMgZW5kIG9mIElSUSBjaGlwIHN1cHBvcnQKCkNPTkZJR19JUEFDS19CVVM9bQpDT05G SUdfQk9BUkRfVFBDSTIwMD1tCkNPTkZJR19TRVJJQUxfSVBPQ1RBTD1tCkNPTkZJR19SRVNF VF9DT05UUk9MTEVSPXkKQ09ORklHX1JFU0VUX0JSQ01TVEJfUkVTQ0FMPXkKQ09ORklHX1JF U0VUX1RJX1NZU0NPTj1tCgojCiMgUEhZIFN1YnN5c3RlbQojCkNPTkZJR19HRU5FUklDX1BI WT15CkNPTkZJR19VU0JfTEdNX1BIWT1tCkNPTkZJR19CQ01fS09OQV9VU0IyX1BIWT1tCkNP TkZJR19QSFlfUFhBXzI4Tk1fSFNJQz1tCkNPTkZJR19QSFlfUFhBXzI4Tk1fVVNCMj1tCkNP TkZJR19QSFlfQ1BDQVBfVVNCPW0KQ09ORklHX1BIWV9RQ09NX1VTQl9IUz1tCkNPTkZJR19Q SFlfUUNPTV9VU0JfSFNJQz1tCkNPTkZJR19QSFlfU0FNU1VOR19VU0IyPW0KQ09ORklHX1BI WV9UVVNCMTIxMD1tCkNPTkZJR19QSFlfSU5URUxfTEdNX0VNTUM9bQojIGVuZCBvZiBQSFkg U3Vic3lzdGVtCgpDT05GSUdfUE9XRVJDQVA9eQpDT05GSUdfSU5URUxfUkFQTF9DT1JFPW0K Q09ORklHX0lOVEVMX1JBUEw9bQpDT05GSUdfSURMRV9JTkpFQ1Q9eQpDT05GSUdfRFRQTT15 CkNPTkZJR19EVFBNX0NQVT15CkNPTkZJR19NQ0I9bQpDT05GSUdfTUNCX1BDST1tCkNPTkZJ R19NQ0JfTFBDPW0KCiMKIyBQZXJmb3JtYW5jZSBtb25pdG9yIHN1cHBvcnQKIwojIGVuZCBv ZiBQZXJmb3JtYW5jZSBtb25pdG9yIHN1cHBvcnQKCkNPTkZJR19SQVM9eQpDT05GSUdfUkFT X0NFQz15CiMgQ09ORklHX1JBU19DRUNfREVCVUcgaXMgbm90IHNldApDT05GSUdfVVNCND1t CiMgQ09ORklHX1VTQjRfREVCVUdGU19XUklURSBpcyBub3Qgc2V0CiMgQ09ORklHX1VTQjRf RE1BX1RFU1QgaXMgbm90IHNldAoKIwojIEFuZHJvaWQKIwojIENPTkZJR19BTkRST0lEIGlz IG5vdCBzZXQKIyBlbmQgb2YgQW5kcm9pZAoKQ09ORklHX0xJQk5WRElNTT15CkNPTkZJR19C TEtfREVWX1BNRU09bQpDT05GSUdfTkRfQkxLPW0KQ09ORklHX05EX0NMQUlNPXkKQ09ORklH X05EX0JUVD1tCkNPTkZJR19CVFQ9eQpDT05GSUdfTkRfUEZOPW0KQ09ORklHX05WRElNTV9Q Rk49eQpDT05GSUdfTlZESU1NX0RBWD15CkNPTkZJR19EQVhfRFJJVkVSPXkKQ09ORklHX0RB WD15CkNPTkZJR19ERVZfREFYPW0KQ09ORklHX0RFVl9EQVhfUE1FTT1tCkNPTkZJR19ERVZf REFYX0hNRU09bQpDT05GSUdfREVWX0RBWF9ITUVNX0RFVklDRVM9eQpDT05GSUdfREVWX0RB WF9LTUVNPW0KQ09ORklHX0RFVl9EQVhfUE1FTV9DT01QQVQ9bQpDT05GSUdfTlZNRU09eQpD T05GSUdfTlZNRU1fU1lTRlM9eQpDT05GSUdfUkFWRV9TUF9FRVBST009bQpDT05GSUdfTlZN RU1fUk1FTT1tCgojCiMgSFcgdHJhY2luZyBzdXBwb3J0CiMKQ09ORklHX1NUTT1tCkNPTkZJ R19TVE1fUFJPVE9fQkFTSUM9bQpDT05GSUdfU1RNX1BST1RPX1NZU19UPW0KIyBDT05GSUdf U1RNX0RVTU1ZIGlzIG5vdCBzZXQKQ09ORklHX1NUTV9TT1VSQ0VfQ09OU09MRT1tCkNPTkZJ R19TVE1fU09VUkNFX0hFQVJUQkVBVD1tCkNPTkZJR19TVE1fU09VUkNFX0ZUUkFDRT1tCkNP TkZJR19JTlRFTF9USD1tCkNPTkZJR19JTlRFTF9USF9QQ0k9bQpDT05GSUdfSU5URUxfVEhf QUNQST1tCkNPTkZJR19JTlRFTF9USF9HVEg9bQpDT05GSUdfSU5URUxfVEhfU1RIPW0KQ09O RklHX0lOVEVMX1RIX01TVT1tCkNPTkZJR19JTlRFTF9USF9QVEk9bQojIENPTkZJR19JTlRF TF9USF9ERUJVRyBpcyBub3Qgc2V0CiMgZW5kIG9mIEhXIHRyYWNpbmcgc3VwcG9ydAoKQ09O RklHX0ZQR0E9bQpDT05GSUdfQUxURVJBX1BSX0lQX0NPUkU9bQpDT05GSUdfRlBHQV9NR1Jf QUxURVJBX1BTX1NQST1tCkNPTkZJR19GUEdBX01HUl9BTFRFUkFfQ1ZQPW0KQ09ORklHX0ZQ R0FfTUdSX1hJTElOWF9TUEk9bQpDT05GSUdfRlBHQV9NR1JfTUFDSFhPMl9TUEk9bQpDT05G SUdfRlBHQV9CUklER0U9bQpDT05GSUdfQUxURVJBX0ZSRUVaRV9CUklER0U9bQpDT05GSUdf WElMSU5YX1BSX0RFQ09VUExFUj1tCkNPTkZJR19GUEdBX1JFR0lPTj1tCkNPTkZJR19GUEdB X0RGTD1tCkNPTkZJR19GUEdBX0RGTF9GTUU9bQpDT05GSUdfRlBHQV9ERkxfRk1FX01HUj1t CkNPTkZJR19GUEdBX0RGTF9GTUVfQlJJREdFPW0KQ09ORklHX0ZQR0FfREZMX0ZNRV9SRUdJ T049bQpDT05GSUdfRlBHQV9ERkxfQUZVPW0KQ09ORklHX0ZQR0FfREZMX05JT1NfSU5URUxf UEFDX04zMDAwPW0KQ09ORklHX0ZQR0FfREZMX1BDST1tCkNPTkZJR19URUU9bQoKIwojIFRF RSBkcml2ZXJzCiMKQ09ORklHX0FNRFRFRT1tCiMgZW5kIG9mIFRFRSBkcml2ZXJzCgpDT05G SUdfTVVMVElQTEVYRVI9bQoKIwojIE11bHRpcGxleGVyIGRyaXZlcnMKIwpDT05GSUdfTVVY X0FERzc5MkE9bQpDT05GSUdfTVVYX0FER1MxNDA4PW0KQ09ORklHX01VWF9HUElPPW0KIyBl bmQgb2YgTXVsdGlwbGV4ZXIgZHJpdmVycwoKQ09ORklHX1BNX09QUD15CkNPTkZJR19VTklT WVNfVklTT1JCVVM9bQpDT05GSUdfU0lPWD1tCkNPTkZJR19TSU9YX0JVU19HUElPPW0KQ09O RklHX1NMSU1CVVM9bQpDT05GSUdfU0xJTV9RQ09NX0NUUkw9bQpDT05GSUdfSU5URVJDT05O RUNUPXkKQ09ORklHX0NPVU5URVI9bQpDT05GSUdfTU9TVD1tCkNPTkZJR19NT1NUX1VTQl9I RE09bQpDT05GSUdfTU9TVF9DREVWPW0KIyBlbmQgb2YgRGV2aWNlIERyaXZlcnMKCiMKIyBG aWxlIHN5c3RlbXMKIwpDT05GSUdfRENBQ0hFX1dPUkRfQUNDRVNTPXkKQ09ORklHX1ZBTElE QVRFX0ZTX1BBUlNFUj15CkNPTkZJR19GU19JT01BUD15CiMgQ09ORklHX0VYVDJfRlMgaXMg bm90IHNldAojIENPTkZJR19FWFQzX0ZTIGlzIG5vdCBzZXQKQ09ORklHX0VYVDRfRlM9bQpD T05GSUdfRVhUNF9VU0VfRk9SX0VYVDI9eQpDT05GSUdfRVhUNF9GU19QT1NJWF9BQ0w9eQpD T05GSUdfRVhUNF9GU19TRUNVUklUWT15CiMgQ09ORklHX0VYVDRfREVCVUcgaXMgbm90IHNl dApDT05GSUdfSkJEMj1tCiMgQ09ORklHX0pCRDJfREVCVUcgaXMgbm90IHNldApDT05GSUdf RlNfTUJDQUNIRT1tCkNPTkZJR19SRUlTRVJGU19GUz1tCiMgQ09ORklHX1JFSVNFUkZTX0NI RUNLIGlzIG5vdCBzZXQKQ09ORklHX1JFSVNFUkZTX1BST0NfSU5GTz15CkNPTkZJR19SRUlT RVJGU19GU19YQVRUUj15CkNPTkZJR19SRUlTRVJGU19GU19QT1NJWF9BQ0w9eQpDT05GSUdf UkVJU0VSRlNfRlNfU0VDVVJJVFk9eQpDT05GSUdfSkZTX0ZTPW0KQ09ORklHX0pGU19QT1NJ WF9BQ0w9eQpDT05GSUdfSkZTX1NFQ1VSSVRZPXkKIyBDT05GSUdfSkZTX0RFQlVHIGlzIG5v dCBzZXQKQ09ORklHX0pGU19TVEFUSVNUSUNTPXkKQ09ORklHX1hGU19GUz1tCkNPTkZJR19Y RlNfU1VQUE9SVF9WND15CkNPTkZJR19YRlNfUVVPVEE9eQpDT05GSUdfWEZTX1BPU0lYX0FD TD15CkNPTkZJR19YRlNfUlQ9eQpDT05GSUdfWEZTX09OTElORV9TQ1JVQj15CkNPTkZJR19Y RlNfT05MSU5FX1JFUEFJUj15CiMgQ09ORklHX1hGU19XQVJOIGlzIG5vdCBzZXQKIyBDT05G SUdfWEZTX0RFQlVHIGlzIG5vdCBzZXQKQ09ORklHX0dGUzJfRlM9bQpDT05GSUdfR0ZTMl9G U19MT0NLSU5HX0RMTT15CkNPTkZJR19PQ0ZTMl9GUz1tCkNPTkZJR19PQ0ZTMl9GU19PMkNC PW0KQ09ORklHX09DRlMyX0ZTX1VTRVJTUEFDRV9DTFVTVEVSPW0KQ09ORklHX09DRlMyX0ZT X1NUQVRTPXkKQ09ORklHX09DRlMyX0RFQlVHX01BU0tMT0c9eQojIENPTkZJR19PQ0ZTMl9E RUJVR19GUyBpcyBub3Qgc2V0CkNPTkZJR19CVFJGU19GUz1tCkNPTkZJR19CVFJGU19GU19Q T1NJWF9BQ0w9eQojIENPTkZJR19CVFJGU19GU19DSEVDS19JTlRFR1JJVFkgaXMgbm90IHNl dAojIENPTkZJR19CVFJGU19GU19SVU5fU0FOSVRZX1RFU1RTIGlzIG5vdCBzZXQKIyBDT05G SUdfQlRSRlNfREVCVUcgaXMgbm90IHNldAojIENPTkZJR19CVFJGU19BU1NFUlQgaXMgbm90 IHNldAojIENPTkZJR19CVFJGU19GU19SRUZfVkVSSUZZIGlzIG5vdCBzZXQKQ09ORklHX05J TEZTMl9GUz1tCkNPTkZJR19GMkZTX0ZTPW0KQ09ORklHX0YyRlNfU1RBVF9GUz15CkNPTkZJ R19GMkZTX0ZTX1hBVFRSPXkKQ09ORklHX0YyRlNfRlNfUE9TSVhfQUNMPXkKQ09ORklHX0Yy RlNfRlNfU0VDVVJJVFk9eQpDT05GSUdfRjJGU19DSEVDS19GUz15CiMgQ09ORklHX0YyRlNf RkFVTFRfSU5KRUNUSU9OIGlzIG5vdCBzZXQKQ09ORklHX0YyRlNfRlNfQ09NUFJFU1NJT049 eQpDT05GSUdfRjJGU19GU19MWk89eQpDT05GSUdfRjJGU19GU19MWjQ9eQpDT05GSUdfRjJG U19GU19MWjRIQz15CkNPTkZJR19GMkZTX0ZTX1pTVEQ9eQpDT05GSUdfRjJGU19GU19MWk9S TEU9eQpDT05GSUdfWk9ORUZTX0ZTPW0KQ09ORklHX0ZTX0RBWD15CkNPTkZJR19GU19EQVhf UE1EPXkKQ09ORklHX0ZTX1BPU0lYX0FDTD15CkNPTkZJR19FWFBPUlRGUz15CkNPTkZJR19F WFBPUlRGU19CTE9DS19PUFM9eQpDT05GSUdfRklMRV9MT0NLSU5HPXkKIyBDT05GSUdfTUFO REFUT1JZX0ZJTEVfTE9DS0lORyBpcyBub3Qgc2V0CkNPTkZJR19GU19FTkNSWVBUSU9OPXkK Q09ORklHX0ZTX0VOQ1JZUFRJT05fQUxHUz1tCkNPTkZJR19GU19FTkNSWVBUSU9OX0lOTElO RV9DUllQVD15CkNPTkZJR19GU19WRVJJVFk9eQojIENPTkZJR19GU19WRVJJVFlfREVCVUcg aXMgbm90IHNldApDT05GSUdfRlNfVkVSSVRZX0JVSUxUSU5fU0lHTkFUVVJFUz15CkNPTkZJ R19GU05PVElGWT15CkNPTkZJR19ETk9USUZZPXkKQ09ORklHX0lOT1RJRllfVVNFUj15CkNP TkZJR19GQU5PVElGWT15CkNPTkZJR19GQU5PVElGWV9BQ0NFU1NfUEVSTUlTU0lPTlM9eQpD T05GSUdfUVVPVEE9eQpDT05GSUdfUVVPVEFfTkVUTElOS19JTlRFUkZBQ0U9eQojIENPTkZJ R19QUklOVF9RVU9UQV9XQVJOSU5HIGlzIG5vdCBzZXQKIyBDT05GSUdfUVVPVEFfREVCVUcg aXMgbm90IHNldApDT05GSUdfUVVPVEFfVFJFRT1tCkNPTkZJR19RRk1UX1YxPW0KQ09ORklH X1FGTVRfVjI9bQpDT05GSUdfUVVPVEFDVEw9eQpDT05GSUdfQVVUT0ZTNF9GUz15CkNPTkZJ R19BVVRPRlNfRlM9eQpDT05GSUdfRlVTRV9GUz1tCkNPTkZJR19DVVNFPW0KQ09ORklHX1ZJ UlRJT19GUz1tCkNPTkZJR19GVVNFX0RBWD15CkNPTkZJR19PVkVSTEFZX0ZTPW0KQ09ORklH X09WRVJMQVlfRlNfUkVESVJFQ1RfRElSPXkKIyBDT05GSUdfT1ZFUkxBWV9GU19SRURJUkVD VF9BTFdBWVNfRk9MTE9XIGlzIG5vdCBzZXQKQ09ORklHX09WRVJMQVlfRlNfSU5ERVg9eQpD T05GSUdfT1ZFUkxBWV9GU19YSU5PX0FVVE89eQpDT05GSUdfT1ZFUkxBWV9GU19NRVRBQ09Q WT15CgojCiMgQ2FjaGVzCiMKQ09ORklHX0ZTQ0FDSEU9bQpDT05GSUdfRlNDQUNIRV9TVEFU Uz15CiMgQ09ORklHX0ZTQ0FDSEVfSElTVE9HUkFNIGlzIG5vdCBzZXQKIyBDT05GSUdfRlND QUNIRV9ERUJVRyBpcyBub3Qgc2V0CkNPTkZJR19GU0NBQ0hFX09CSkVDVF9MSVNUPXkKQ09O RklHX0NBQ0hFRklMRVM9bQojIENPTkZJR19DQUNIRUZJTEVTX0RFQlVHIGlzIG5vdCBzZXQK IyBDT05GSUdfQ0FDSEVGSUxFU19ISVNUT0dSQU0gaXMgbm90IHNldAojIGVuZCBvZiBDYWNo ZXMKCiMKIyBDRC1ST00vRFZEIEZpbGVzeXN0ZW1zCiMKQ09ORklHX0lTTzk2NjBfRlM9bQpD T05GSUdfSk9MSUVUPXkKQ09ORklHX1pJU09GUz15CkNPTkZJR19VREZfRlM9bQojIGVuZCBv ZiBDRC1ST00vRFZEIEZpbGVzeXN0ZW1zCgojCiMgRE9TL0ZBVC9FWEZBVC9OVCBGaWxlc3lz dGVtcwojCkNPTkZJR19GQVRfRlM9bQpDT05GSUdfTVNET1NfRlM9bQpDT05GSUdfVkZBVF9G Uz1tCkNPTkZJR19GQVRfREVGQVVMVF9DT0RFUEFHRT00MzcKQ09ORklHX0ZBVF9ERUZBVUxU X0lPQ0hBUlNFVD0iYXNjaWkiCkNPTkZJR19GQVRfREVGQVVMVF9VVEY4PXkKQ09ORklHX0VY RkFUX0ZTPW0KQ09ORklHX0VYRkFUX0RFRkFVTFRfSU9DSEFSU0VUPSJ1dGY4IgojIENPTkZJ R19OVEZTX0ZTIGlzIG5vdCBzZXQKIyBlbmQgb2YgRE9TL0ZBVC9FWEZBVC9OVCBGaWxlc3lz dGVtcwoKIwojIFBzZXVkbyBmaWxlc3lzdGVtcwojCkNPTkZJR19QUk9DX0ZTPXkKQ09ORklH X1BST0NfS0NPUkU9eQpDT05GSUdfUFJPQ19WTUNPUkU9eQpDT05GSUdfUFJPQ19WTUNPUkVf REVWSUNFX0RVTVA9eQpDT05GSUdfUFJPQ19TWVNDVEw9eQpDT05GSUdfUFJPQ19QQUdFX01P TklUT1I9eQpDT05GSUdfUFJPQ19DSElMRFJFTj15CkNPTkZJR19QUk9DX1BJRF9BUkNIX1NU QVRVUz15CkNPTkZJR19QUk9DX0NQVV9SRVNDVFJMPXkKQ09ORklHX0tFUk5GUz15CkNPTkZJ R19TWVNGUz15CkNPTkZJR19UTVBGUz15CkNPTkZJR19UTVBGU19QT1NJWF9BQ0w9eQpDT05G SUdfVE1QRlNfWEFUVFI9eQpDT05GSUdfVE1QRlNfSU5PREU2ND15CkNPTkZJR19IVUdFVExC RlM9eQpDT05GSUdfSFVHRVRMQl9QQUdFPXkKQ09ORklHX01FTUZEX0NSRUFURT15CkNPTkZJ R19BUkNIX0hBU19HSUdBTlRJQ19QQUdFPXkKQ09ORklHX0NPTkZJR0ZTX0ZTPXkKQ09ORklH X0VGSVZBUl9GUz15CiMgZW5kIG9mIFBzZXVkbyBmaWxlc3lzdGVtcwoKQ09ORklHX01JU0Nf RklMRVNZU1RFTVM9eQpDT05GSUdfT1JBTkdFRlNfRlM9bQojIENPTkZJR19BREZTX0ZTIGlz IG5vdCBzZXQKQ09ORklHX0FGRlNfRlM9bQpDT05GSUdfRUNSWVBUX0ZTPW0KIyBDT05GSUdf RUNSWVBUX0ZTX01FU1NBR0lORyBpcyBub3Qgc2V0CkNPTkZJR19IRlNfRlM9bQpDT05GSUdf SEZTUExVU19GUz1tCkNPTkZJR19CRUZTX0ZTPW0KIyBDT05GSUdfQkVGU19ERUJVRyBpcyBu b3Qgc2V0CiMgQ09ORklHX0JGU19GUyBpcyBub3Qgc2V0CiMgQ09ORklHX0VGU19GUyBpcyBu b3Qgc2V0CkNPTkZJR19KRkZTMl9GUz1tCkNPTkZJR19KRkZTMl9GU19ERUJVRz0wCkNPTkZJ R19KRkZTMl9GU19XUklURUJVRkZFUj15CiMgQ09ORklHX0pGRlMyX0ZTX1dCVUZfVkVSSUZZ IGlzIG5vdCBzZXQKQ09ORklHX0pGRlMyX1NVTU1BUlk9eQpDT05GSUdfSkZGUzJfRlNfWEFU VFI9eQpDT05GSUdfSkZGUzJfRlNfUE9TSVhfQUNMPXkKQ09ORklHX0pGRlMyX0ZTX1NFQ1VS SVRZPXkKIyBDT05GSUdfSkZGUzJfQ09NUFJFU1NJT05fT1BUSU9OUyBpcyBub3Qgc2V0CkNP TkZJR19KRkZTMl9aTElCPXkKQ09ORklHX0pGRlMyX1JUSU1FPXkKQ09ORklHX1VCSUZTX0ZT PW0KIyBDT05GSUdfVUJJRlNfRlNfQURWQU5DRURfQ09NUFIgaXMgbm90IHNldApDT05GSUdf VUJJRlNfRlNfTFpPPXkKQ09ORklHX1VCSUZTX0ZTX1pMSUI9eQpDT05GSUdfVUJJRlNfRlNf WlNURD15CkNPTkZJR19VQklGU19BVElNRV9TVVBQT1JUPXkKQ09ORklHX1VCSUZTX0ZTX1hB VFRSPXkKQ09ORklHX1VCSUZTX0ZTX1NFQ1VSSVRZPXkKQ09ORklHX1VCSUZTX0ZTX0FVVEhF TlRJQ0FUSU9OPXkKQ09ORklHX0NSQU1GUz1tCkNPTkZJR19DUkFNRlNfQkxPQ0tERVY9eQpD T05GSUdfQ1JBTUZTX01URD15CkNPTkZJR19TUVVBU0hGUz1tCiMgQ09ORklHX1NRVUFTSEZT X0ZJTEVfQ0FDSEUgaXMgbm90IHNldApDT05GSUdfU1FVQVNIRlNfRklMRV9ESVJFQ1Q9eQoj IENPTkZJR19TUVVBU0hGU19ERUNPTVBfU0lOR0xFIGlzIG5vdCBzZXQKIyBDT05GSUdfU1FV QVNIRlNfREVDT01QX01VTFRJIGlzIG5vdCBzZXQKQ09ORklHX1NRVUFTSEZTX0RFQ09NUF9N VUxUSV9QRVJDUFU9eQpDT05GSUdfU1FVQVNIRlNfWEFUVFI9eQpDT05GSUdfU1FVQVNIRlNf WkxJQj15CkNPTkZJR19TUVVBU0hGU19MWjQ9eQpDT05GSUdfU1FVQVNIRlNfTFpPPXkKQ09O RklHX1NRVUFTSEZTX1haPXkKQ09ORklHX1NRVUFTSEZTX1pTVEQ9eQojIENPTkZJR19TUVVB U0hGU180S19ERVZCTEtfU0laRSBpcyBub3Qgc2V0CiMgQ09ORklHX1NRVUFTSEZTX0VNQkVE REVEIGlzIG5vdCBzZXQKQ09ORklHX1NRVUFTSEZTX0ZSQUdNRU5UX0NBQ0hFX1NJWkU9Mwoj IENPTkZJR19WWEZTX0ZTIGlzIG5vdCBzZXQKQ09ORklHX01JTklYX0ZTPW0KQ09ORklHX09N RlNfRlM9bQojIENPTkZJR19IUEZTX0ZTIGlzIG5vdCBzZXQKIyBDT05GSUdfUU5YNEZTX0ZT IGlzIG5vdCBzZXQKIyBDT05GSUdfUU5YNkZTX0ZTIGlzIG5vdCBzZXQKQ09ORklHX1JPTUZT X0ZTPW0KQ09ORklHX1JPTUZTX0JBQ0tFRF9CWV9CTE9DSz15CiMgQ09ORklHX1JPTUZTX0JB Q0tFRF9CWV9NVEQgaXMgbm90IHNldAojIENPTkZJR19ST01GU19CQUNLRURfQllfQk9USCBp cyBub3Qgc2V0CkNPTkZJR19ST01GU19PTl9CTE9DSz15CkNPTkZJR19QU1RPUkU9eQpDT05G SUdfUFNUT1JFX0RFRkFVTFRfS01TR19CWVRFUz0xMDI0MApDT05GSUdfUFNUT1JFX0RFRkxB VEVfQ09NUFJFU1M9bQpDT05GSUdfUFNUT1JFX0xaT19DT01QUkVTUz1tCkNPTkZJR19QU1RP UkVfTFo0X0NPTVBSRVNTPW0KQ09ORklHX1BTVE9SRV9MWjRIQ19DT01QUkVTUz1tCiMgQ09O RklHX1BTVE9SRV84NDJfQ09NUFJFU1MgaXMgbm90IHNldApDT05GSUdfUFNUT1JFX1pTVERf Q09NUFJFU1M9eQpDT05GSUdfUFNUT1JFX0NPTVBSRVNTPXkKIyBDT05GSUdfUFNUT1JFX0RF RkxBVEVfQ09NUFJFU1NfREVGQVVMVCBpcyBub3Qgc2V0CiMgQ09ORklHX1BTVE9SRV9MWk9f Q09NUFJFU1NfREVGQVVMVCBpcyBub3Qgc2V0CiMgQ09ORklHX1BTVE9SRV9MWjRfQ09NUFJF U1NfREVGQVVMVCBpcyBub3Qgc2V0CiMgQ09ORklHX1BTVE9SRV9MWjRIQ19DT01QUkVTU19E RUZBVUxUIGlzIG5vdCBzZXQKQ09ORklHX1BTVE9SRV9aU1REX0NPTVBSRVNTX0RFRkFVTFQ9 eQpDT05GSUdfUFNUT1JFX0NPTVBSRVNTX0RFRkFVTFQ9InpzdGQiCiMgQ09ORklHX1BTVE9S RV9DT05TT0xFIGlzIG5vdCBzZXQKIyBDT05GSUdfUFNUT1JFX1BNU0cgaXMgbm90IHNldAoj IENPTkZJR19QU1RPUkVfRlRSQUNFIGlzIG5vdCBzZXQKQ09ORklHX1BTVE9SRV9SQU09bQpD T05GSUdfUFNUT1JFX1pPTkU9bQpDT05GSUdfUFNUT1JFX0JMSz1tCkNPTkZJR19QU1RPUkVf QkxLX0JMS0RFVj0iIgpDT05GSUdfUFNUT1JFX0JMS19LTVNHX1NJWkU9NjQKQ09ORklHX1BT VE9SRV9CTEtfTUFYX1JFQVNPTj0yCiMgQ09ORklHX1NZU1ZfRlMgaXMgbm90IHNldApDT05G SUdfVUZTX0ZTPW0KIyBDT05GSUdfVUZTX0ZTX1dSSVRFIGlzIG5vdCBzZXQKIyBDT05GSUdf VUZTX0RFQlVHIGlzIG5vdCBzZXQKQ09ORklHX0VST0ZTX0ZTPW0KIyBDT05GSUdfRVJPRlNf RlNfREVCVUcgaXMgbm90IHNldApDT05GSUdfRVJPRlNfRlNfWEFUVFI9eQpDT05GSUdfRVJP RlNfRlNfUE9TSVhfQUNMPXkKQ09ORklHX0VST0ZTX0ZTX1NFQ1VSSVRZPXkKQ09ORklHX0VS T0ZTX0ZTX1pJUD15CkNPTkZJR19FUk9GU19GU19DTFVTVEVSX1BBR0VfTElNSVQ9MgpDT05G SUdfVkJPWFNGX0ZTPW0KQ09ORklHX05FVFdPUktfRklMRVNZU1RFTVM9eQpDT05GSUdfTkZT X0ZTPW0KQ09ORklHX05GU19WMj1tCkNPTkZJR19ORlNfVjM9bQpDT05GSUdfTkZTX1YzX0FD TD15CkNPTkZJR19ORlNfVjQ9bQpDT05GSUdfTkZTX1NXQVA9eQpDT05GSUdfTkZTX1Y0XzE9 eQpDT05GSUdfTkZTX1Y0XzI9eQpDT05GSUdfUE5GU19GSUxFX0xBWU9VVD1tCkNPTkZJR19Q TkZTX0JMT0NLPW0KQ09ORklHX1BORlNfRkxFWEZJTEVfTEFZT1VUPW0KQ09ORklHX05GU19W NF8xX0lNUExFTUVOVEFUSU9OX0lEX0RPTUFJTj0ia2VybmVsLm9yZyIKQ09ORklHX05GU19W NF8xX01JR1JBVElPTj15CkNPTkZJR19ORlNfVjRfU0VDVVJJVFlfTEFCRUw9eQpDT05GSUdf TkZTX0ZTQ0FDSEU9eQojIENPTkZJR19ORlNfVVNFX0xFR0FDWV9ETlMgaXMgbm90IHNldApD T05GSUdfTkZTX1VTRV9LRVJORUxfRE5TPXkKQ09ORklHX05GU19ERUJVRz15CiMgQ09ORklH X05GU19ESVNBQkxFX1VEUF9TVVBQT1JUIGlzIG5vdCBzZXQKIyBDT05GSUdfTkZTX1Y0XzJf UkVBRF9QTFVTIGlzIG5vdCBzZXQKQ09ORklHX05GU0Q9bQpDT05GSUdfTkZTRF9WMl9BQ0w9 eQpDT05GSUdfTkZTRF9WMz15CkNPTkZJR19ORlNEX1YzX0FDTD15CkNPTkZJR19ORlNEX1Y0 PXkKQ09ORklHX05GU0RfUE5GUz15CkNPTkZJR19ORlNEX0JMT0NLTEFZT1VUPXkKQ09ORklH X05GU0RfU0NTSUxBWU9VVD15CiMgQ09ORklHX05GU0RfRkxFWEZJTEVMQVlPVVQgaXMgbm90 IHNldApDT05GSUdfTkZTRF9WNF8yX0lOVEVSX1NTQz15CkNPTkZJR19ORlNEX1Y0X1NFQ1VS SVRZX0xBQkVMPXkKQ09ORklHX0dSQUNFX1BFUklPRD1tCkNPTkZJR19MT0NLRD1tCkNPTkZJ R19MT0NLRF9WND15CkNPTkZJR19ORlNfQUNMX1NVUFBPUlQ9bQpDT05GSUdfTkZTX0NPTU1P Tj15CkNPTkZJR19ORlNfVjRfMl9TU0NfSEVMUEVSPW0KQ09ORklHX1NVTlJQQz1tCkNPTkZJ R19TVU5SUENfR1NTPW0KQ09ORklHX1NVTlJQQ19CQUNLQ0hBTk5FTD15CkNPTkZJR19TVU5S UENfU1dBUD15CkNPTkZJR19SUENTRUNfR1NTX0tSQjU9bQpDT05GSUdfU1VOUlBDX0RJU0FC TEVfSU5TRUNVUkVfRU5DVFlQRVM9eQpDT05GSUdfU1VOUlBDX0RFQlVHPXkKQ09ORklHX1NV TlJQQ19YUFJUX1JETUE9bQpDT05GSUdfQ0VQSF9GUz1tCkNPTkZJR19DRVBIX0ZTQ0FDSEU9 eQpDT05GSUdfQ0VQSF9GU19QT1NJWF9BQ0w9eQpDT05GSUdfQ0VQSF9GU19TRUNVUklUWV9M QUJFTD15CkNPTkZJR19DSUZTPW0KIyBDT05GSUdfQ0lGU19TVEFUUzIgaXMgbm90IHNldApD T05GSUdfQ0lGU19BTExPV19JTlNFQ1VSRV9MRUdBQ1k9eQojIENPTkZJR19DSUZTX1dFQUtf UFdfSEFTSCBpcyBub3Qgc2V0CkNPTkZJR19DSUZTX1VQQ0FMTD15CkNPTkZJR19DSUZTX1hB VFRSPXkKQ09ORklHX0NJRlNfUE9TSVg9eQpDT05GSUdfQ0lGU19ERUJVRz15CiMgQ09ORklH X0NJRlNfREVCVUcyIGlzIG5vdCBzZXQKIyBDT05GSUdfQ0lGU19ERUJVR19EVU1QX0tFWVMg aXMgbm90IHNldApDT05GSUdfQ0lGU19ERlNfVVBDQUxMPXkKQ09ORklHX0NJRlNfU1dOX1VQ Q0FMTD15CiMgQ09ORklHX0NJRlNfU01CX0RJUkVDVCBpcyBub3Qgc2V0CkNPTkZJR19DSUZT X0ZTQ0FDSEU9eQpDT05GSUdfQ09EQV9GUz1tCkNPTkZJR19BRlNfRlM9bQojIENPTkZJR19B RlNfREVCVUcgaXMgbm90IHNldApDT05GSUdfQUZTX0ZTQ0FDSEU9eQojIENPTkZJR19BRlNf REVCVUdfQ1VSU09SIGlzIG5vdCBzZXQKQ09ORklHXzlQX0ZTPW0KQ09ORklHXzlQX0ZTQ0FD SEU9eQpDT05GSUdfOVBfRlNfUE9TSVhfQUNMPXkKQ09ORklHXzlQX0ZTX1NFQ1VSSVRZPXkK Q09ORklHX05MUz15CkNPTkZJR19OTFNfREVGQVVMVD0idXRmOCIKQ09ORklHX05MU19DT0RF UEFHRV80Mzc9eQpDT05GSUdfTkxTX0NPREVQQUdFXzczNz1tCkNPTkZJR19OTFNfQ09ERVBB R0VfNzc1PW0KQ09ORklHX05MU19DT0RFUEFHRV84NTA9bQpDT05GSUdfTkxTX0NPREVQQUdF Xzg1Mj1tCkNPTkZJR19OTFNfQ09ERVBBR0VfODU1PW0KQ09ORklHX05MU19DT0RFUEFHRV84 NTc9bQpDT05GSUdfTkxTX0NPREVQQUdFXzg2MD1tCkNPTkZJR19OTFNfQ09ERVBBR0VfODYx PW0KQ09ORklHX05MU19DT0RFUEFHRV84NjI9bQpDT05GSUdfTkxTX0NPREVQQUdFXzg2Mz1t CkNPTkZJR19OTFNfQ09ERVBBR0VfODY0PW0KQ09ORklHX05MU19DT0RFUEFHRV84NjU9bQpD T05GSUdfTkxTX0NPREVQQUdFXzg2Nj1tCkNPTkZJR19OTFNfQ09ERVBBR0VfODY5PW0KQ09O RklHX05MU19DT0RFUEFHRV85MzY9bQpDT05GSUdfTkxTX0NPREVQQUdFXzk1MD1tCkNPTkZJ R19OTFNfQ09ERVBBR0VfOTMyPW0KQ09ORklHX05MU19DT0RFUEFHRV85NDk9bQpDT05GSUdf TkxTX0NPREVQQUdFXzg3ND1tCkNPTkZJR19OTFNfSVNPODg1OV84PW0KQ09ORklHX05MU19D T0RFUEFHRV8xMjUwPW0KQ09ORklHX05MU19DT0RFUEFHRV8xMjUxPW0KQ09ORklHX05MU19B U0NJST15CkNPTkZJR19OTFNfSVNPODg1OV8xPW0KQ09ORklHX05MU19JU084ODU5XzI9bQpD T05GSUdfTkxTX0lTTzg4NTlfMz1tCkNPTkZJR19OTFNfSVNPODg1OV80PW0KQ09ORklHX05M U19JU084ODU5XzU9bQpDT05GSUdfTkxTX0lTTzg4NTlfNj1tCkNPTkZJR19OTFNfSVNPODg1 OV83PW0KQ09ORklHX05MU19JU084ODU5Xzk9bQpDT05GSUdfTkxTX0lTTzg4NTlfMTM9bQpD T05GSUdfTkxTX0lTTzg4NTlfMTQ9bQpDT05GSUdfTkxTX0lTTzg4NTlfMTU9bQpDT05GSUdf TkxTX0tPSThfUj1tCkNPTkZJR19OTFNfS09JOF9VPW0KQ09ORklHX05MU19NQUNfUk9NQU49 bQpDT05GSUdfTkxTX01BQ19DRUxUSUM9bQpDT05GSUdfTkxTX01BQ19DRU5URVVSTz1tCkNP TkZJR19OTFNfTUFDX0NST0FUSUFOPW0KQ09ORklHX05MU19NQUNfQ1lSSUxMSUM9bQpDT05G SUdfTkxTX01BQ19HQUVMSUM9bQpDT05GSUdfTkxTX01BQ19HUkVFSz1tCkNPTkZJR19OTFNf TUFDX0lDRUxBTkQ9bQpDT05GSUdfTkxTX01BQ19JTlVJVD1tCkNPTkZJR19OTFNfTUFDX1JP TUFOSUFOPW0KQ09ORklHX05MU19NQUNfVFVSS0lTSD1tCkNPTkZJR19OTFNfVVRGOD1tCkNP TkZJR19ETE09bQpDT05GSUdfRExNX0RFQlVHPXkKQ09ORklHX1VOSUNPREU9eQojIENPTkZJ R19VTklDT0RFX05PUk1BTElaQVRJT05fU0VMRlRFU1QgaXMgbm90IHNldApDT05GSUdfSU9f V1E9eQojIGVuZCBvZiBGaWxlIHN5c3RlbXMKCiMKIyBTZWN1cml0eSBvcHRpb25zCiMKQ09O RklHX0tFWVM9eQpDT05GSUdfS0VZU19SRVFVRVNUX0NBQ0hFPXkKQ09ORklHX1BFUlNJU1RF TlRfS0VZUklOR1M9eQpDT05GSUdfVFJVU1RFRF9LRVlTPW0KQ09ORklHX0VOQ1JZUFRFRF9L RVlTPW0KQ09ORklHX0tFWV9ESF9PUEVSQVRJT05TPXkKQ09ORklHX0tFWV9OT1RJRklDQVRJ T05TPXkKQ09ORklHX1NFQ1VSSVRZX0RNRVNHX1JFU1RSSUNUPXkKQ09ORklHX1NFQ1VSSVRZ PXkKQ09ORklHX1NFQ1VSSVRZRlM9eQpDT05GSUdfU0VDVVJJVFlfTkVUV09SSz15CkNPTkZJ R19QQUdFX1RBQkxFX0lTT0xBVElPTj15CkNPTkZJR19TRUNVUklUWV9JTkZJTklCQU5EPXkK Q09ORklHX1NFQ1VSSVRZX05FVFdPUktfWEZSTT15CkNPTkZJR19TRUNVUklUWV9QQVRIPXkK IyBDT05GSUdfSU5URUxfVFhUIGlzIG5vdCBzZXQKQ09ORklHX0xTTV9NTUFQX01JTl9BRERS PTY1NTM2CkNPTkZJR19IQVZFX0hBUkRFTkVEX1VTRVJDT1BZX0FMTE9DQVRPUj15CkNPTkZJ R19IQVJERU5FRF9VU0VSQ09QWT15CkNPTkZJR19IQVJERU5FRF9VU0VSQ09QWV9GQUxMQkFD Sz15CkNPTkZJR19GT1JUSUZZX1NPVVJDRT15CiMgQ09ORklHX1NUQVRJQ19VU0VSTU9ERUhF TFBFUiBpcyBub3Qgc2V0CkNPTkZJR19TRUNVUklUWV9TRUxJTlVYPXkKQ09ORklHX1NFQ1VS SVRZX1NFTElOVVhfQk9PVFBBUkFNPXkKIyBDT05GSUdfU0VDVVJJVFlfU0VMSU5VWF9ESVNB QkxFIGlzIG5vdCBzZXQKQ09ORklHX1NFQ1VSSVRZX1NFTElOVVhfREVWRUxPUD15CkNPTkZJ R19TRUNVUklUWV9TRUxJTlVYX0FWQ19TVEFUUz15CkNPTkZJR19TRUNVUklUWV9TRUxJTlVY X0NIRUNLUkVRUFJPVF9WQUxVRT0wCkNPTkZJR19TRUNVUklUWV9TRUxJTlVYX1NJRFRBQl9I QVNIX0JJVFM9OQpDT05GSUdfU0VDVVJJVFlfU0VMSU5VWF9TSUQyU1RSX0NBQ0hFX1NJWkU9 MjU2CkNPTkZJR19TRUNVUklUWV9TTUFDSz15CkNPTkZJR19TRUNVUklUWV9TTUFDS19CUklO R1VQPXkKQ09ORklHX1NFQ1VSSVRZX1NNQUNLX05FVEZJTFRFUj15CkNPTkZJR19TRUNVUklU WV9TTUFDS19BUFBFTkRfU0lHTkFMUz15CkNPTkZJR19TRUNVUklUWV9UT01PWU89eQpDT05G SUdfU0VDVVJJVFlfVE9NT1lPX01BWF9BQ0NFUFRfRU5UUlk9MjA0OApDT05GSUdfU0VDVVJJ VFlfVE9NT1lPX01BWF9BVURJVF9MT0c9MTAyNAojIENPTkZJR19TRUNVUklUWV9UT01PWU9f T01JVF9VU0VSU1BBQ0VfTE9BREVSIGlzIG5vdCBzZXQKQ09ORklHX1NFQ1VSSVRZX1RPTU9Z T19QT0xJQ1lfTE9BREVSPSIvdXNyL2Jpbi90b21veW8taW5pdCIKQ09ORklHX1NFQ1VSSVRZ X1RPTU9ZT19BQ1RJVkFUSU9OX1RSSUdHRVI9Ii91c3IvbGliL3N5c3RlbWQvc3lzdGVtZCIK IyBDT05GSUdfU0VDVVJJVFlfVE9NT1lPX0lOU0VDVVJFX0JVSUxUSU5fU0VUVElORyBpcyBu b3Qgc2V0CkNPTkZJR19TRUNVUklUWV9BUFBBUk1PUj15CkNPTkZJR19TRUNVUklUWV9BUFBB Uk1PUl9IQVNIPXkKQ09ORklHX1NFQ1VSSVRZX0FQUEFSTU9SX0hBU0hfREVGQVVMVD15CiMg Q09ORklHX1NFQ1VSSVRZX0FQUEFSTU9SX0RFQlVHIGlzIG5vdCBzZXQKQ09ORklHX1NFQ1VS SVRZX0xPQURQSU49eQpDT05GSUdfU0VDVVJJVFlfTE9BRFBJTl9FTkZPUkNFPXkKQ09ORklH X1NFQ1VSSVRZX1lBTUE9eQpDT05GSUdfU0VDVVJJVFlfU0FGRVNFVElEPXkKQ09ORklHX1NF Q1VSSVRZX0xPQ0tET1dOX0xTTT15CiMgQ09ORklHX1NFQ1VSSVRZX0xPQ0tET1dOX0xTTV9F QVJMWSBpcyBub3Qgc2V0CkNPTkZJR19MT0NLX0RPV05fS0VSTkVMX0ZPUkNFX05PTkU9eQoj IENPTkZJR19MT0NLX0RPV05fS0VSTkVMX0ZPUkNFX0lOVEVHUklUWSBpcyBub3Qgc2V0CiMg Q09ORklHX0xPQ0tfRE9XTl9LRVJORUxfRk9SQ0VfQ09ORklERU5USUFMSVRZIGlzIG5vdCBz ZXQKIyBDT05GSUdfSU5URUdSSVRZIGlzIG5vdCBzZXQKIyBDT05GSUdfSU1BX1NFQ1VSRV9B TkRfT1JfVFJVU1RFRF9CT09UIGlzIG5vdCBzZXQKIyBDT05GSUdfREVGQVVMVF9TRUNVUklU WV9TRUxJTlVYIGlzIG5vdCBzZXQKIyBDT05GSUdfREVGQVVMVF9TRUNVUklUWV9TTUFDSyBp cyBub3Qgc2V0CiMgQ09ORklHX0RFRkFVTFRfU0VDVVJJVFlfVE9NT1lPIGlzIG5vdCBzZXQK IyBDT05GSUdfREVGQVVMVF9TRUNVUklUWV9BUFBBUk1PUiBpcyBub3Qgc2V0CkNPTkZJR19E RUZBVUxUX1NFQ1VSSVRZX0RBQz15CkNPTkZJR19MU009ImxvY2tkb3duLHlhbWEiCgojCiMg S2VybmVsIGhhcmRlbmluZyBvcHRpb25zCiMKQ09ORklHX0dDQ19QTFVHSU5fU1RSVUNUTEVB Sz15CgojCiMgTWVtb3J5IGluaXRpYWxpemF0aW9uCiMKIyBDT05GSUdfSU5JVF9TVEFDS19O T05FIGlzIG5vdCBzZXQKIyBDT05GSUdfR0NDX1BMVUdJTl9TVFJVQ1RMRUFLX1VTRVIgaXMg bm90IHNldAojIENPTkZJR19HQ0NfUExVR0lOX1NUUlVDVExFQUtfQllSRUYgaXMgbm90IHNl dApDT05GSUdfR0NDX1BMVUdJTl9TVFJVQ1RMRUFLX0JZUkVGX0FMTD15CiMgQ09ORklHX0dD Q19QTFVHSU5fU1RSVUNUTEVBS19WRVJCT1NFIGlzIG5vdCBzZXQKIyBDT05GSUdfR0NDX1BM VUdJTl9TVEFDS0xFQUsgaXMgbm90IHNldApDT05GSUdfSU5JVF9PTl9BTExPQ19ERUZBVUxU X09OPXkKIyBDT05GSUdfSU5JVF9PTl9GUkVFX0RFRkFVTFRfT04gaXMgbm90IHNldAojIGVu ZCBvZiBNZW1vcnkgaW5pdGlhbGl6YXRpb24KIyBlbmQgb2YgS2VybmVsIGhhcmRlbmluZyBv cHRpb25zCiMgZW5kIG9mIFNlY3VyaXR5IG9wdGlvbnMKCkNPTkZJR19YT1JfQkxPQ0tTPW0K Q09ORklHX0FTWU5DX0NPUkU9bQpDT05GSUdfQVNZTkNfTUVNQ1BZPW0KQ09ORklHX0FTWU5D X1hPUj1tCkNPTkZJR19BU1lOQ19QUT1tCkNPTkZJR19BU1lOQ19SQUlENl9SRUNPVj1tCkNP TkZJR19DUllQVE89eQoKIwojIENyeXB0byBjb3JlIG9yIGhlbHBlcgojCkNPTkZJR19DUllQ VE9fQUxHQVBJPXkKQ09ORklHX0NSWVBUT19BTEdBUEkyPXkKQ09ORklHX0NSWVBUT19BRUFE PW0KQ09ORklHX0NSWVBUT19BRUFEMj15CkNPTkZJR19DUllQVE9fU0tDSVBIRVI9eQpDT05G SUdfQ1JZUFRPX1NLQ0lQSEVSMj15CkNPTkZJR19DUllQVE9fSEFTSD15CkNPTkZJR19DUllQ VE9fSEFTSDI9eQpDT05GSUdfQ1JZUFRPX1JORz15CkNPTkZJR19DUllQVE9fUk5HMj15CkNP TkZJR19DUllQVE9fUk5HX0RFRkFVTFQ9bQpDT05GSUdfQ1JZUFRPX0FLQ0lQSEVSMj15CkNP TkZJR19DUllQVE9fQUtDSVBIRVI9eQpDT05GSUdfQ1JZUFRPX0tQUDI9eQpDT05GSUdfQ1JZ UFRPX0tQUD15CkNPTkZJR19DUllQVE9fQUNPTVAyPXkKQ09ORklHX0NSWVBUT19NQU5BR0VS PXkKQ09ORklHX0NSWVBUT19NQU5BR0VSMj15CkNPTkZJR19DUllQVE9fVVNFUj1tCkNPTkZJ R19DUllQVE9fTUFOQUdFUl9ESVNBQkxFX1RFU1RTPXkKQ09ORklHX0NSWVBUT19HRjEyOE1V TD1tCkNPTkZJR19DUllQVE9fTlVMTD1tCkNPTkZJR19DUllQVE9fTlVMTDI9eQpDT05GSUdf Q1JZUFRPX1BDUllQVD1tCkNPTkZJR19DUllQVE9fQ1JZUFREPW0KQ09ORklHX0NSWVBUT19B VVRIRU5DPW0KQ09ORklHX0NSWVBUT19URVNUPW0KQ09ORklHX0NSWVBUT19TSU1EPW0KQ09O RklHX0NSWVBUT19FTkdJTkU9bQoKIwojIFB1YmxpYy1rZXkgY3J5cHRvZ3JhcGh5CiMKQ09O RklHX0NSWVBUT19SU0E9eQpDT05GSUdfQ1JZUFRPX0RIPXkKQ09ORklHX0NSWVBUT19FQ0M9 bQpDT05GSUdfQ1JZUFRPX0VDREg9bQpDT05GSUdfQ1JZUFRPX0VDUkRTQT1tCkNPTkZJR19D UllQVE9fU00yPW0KQ09ORklHX0NSWVBUT19DVVJWRTI1NTE5PW0KQ09ORklHX0NSWVBUT19D VVJWRTI1NTE5X1g4Nj1tCgojCiMgQXV0aGVudGljYXRlZCBFbmNyeXB0aW9uIHdpdGggQXNz b2NpYXRlZCBEYXRhCiMKQ09ORklHX0NSWVBUT19DQ009bQpDT05GSUdfQ1JZUFRPX0dDTT1t CkNPTkZJR19DUllQVE9fQ0hBQ0hBMjBQT0xZMTMwNT1tCkNPTkZJR19DUllQVE9fQUVHSVMx Mjg9bQpDT05GSUdfQ1JZUFRPX0FFR0lTMTI4X0FFU05JX1NTRTI9bQpDT05GSUdfQ1JZUFRP X1NFUUlWPW0KQ09ORklHX0NSWVBUT19FQ0hBSU5JVj1tCgojCiMgQmxvY2sgbW9kZXMKIwpD T05GSUdfQ1JZUFRPX0NCQz1tCkNPTkZJR19DUllQVE9fQ0ZCPW0KQ09ORklHX0NSWVBUT19D VFI9eQpDT05GSUdfQ1JZUFRPX0NUUz1tCkNPTkZJR19DUllQVE9fRUNCPW0KQ09ORklHX0NS WVBUT19MUlc9bQpDT05GSUdfQ1JZUFRPX09GQj1tCkNPTkZJR19DUllQVE9fUENCQz1tCkNP TkZJR19DUllQVE9fWFRTPW0KQ09ORklHX0NSWVBUT19LRVlXUkFQPW0KQ09ORklHX0NSWVBU T19OSFBPTFkxMzA1PW0KQ09ORklHX0NSWVBUT19OSFBPTFkxMzA1X1NTRTI9bQpDT05GSUdf Q1JZUFRPX05IUE9MWTEzMDVfQVZYMj1tCkNPTkZJR19DUllQVE9fQURJQU5UVU09bQpDT05G SUdfQ1JZUFRPX0VTU0lWPW0KCiMKIyBIYXNoIG1vZGVzCiMKQ09ORklHX0NSWVBUT19DTUFD PW0KQ09ORklHX0NSWVBUT19ITUFDPXkKQ09ORklHX0NSWVBUT19YQ0JDPW0KQ09ORklHX0NS WVBUT19WTUFDPW0KCiMKIyBEaWdlc3QKIwpDT05GSUdfQ1JZUFRPX0NSQzMyQz1tCkNPTkZJ R19DUllQVE9fQ1JDMzJDX0lOVEVMPW0KQ09ORklHX0NSWVBUT19DUkMzMj1tCkNPTkZJR19D UllQVE9fQ1JDMzJfUENMTVVMPW0KQ09ORklHX0NSWVBUT19YWEhBU0g9bQpDT05GSUdfQ1JZ UFRPX0JMQUtFMkI9bQpDT05GSUdfQ1JZUFRPX0JMQUtFMlM9bQpDT05GSUdfQ1JZUFRPX0JM QUtFMlNfWDg2PW0KQ09ORklHX0NSWVBUT19DUkNUMTBESUY9eQpDT05GSUdfQ1JZUFRPX0NS Q1QxMERJRl9QQ0xNVUw9bQpDT05GSUdfQ1JZUFRPX0dIQVNIPW0KQ09ORklHX0NSWVBUT19Q T0xZMTMwNT1tCkNPTkZJR19DUllQVE9fUE9MWTEzMDVfWDg2XzY0PW0KQ09ORklHX0NSWVBU T19NRDQ9bQpDT05GSUdfQ1JZUFRPX01ENT15CkNPTkZJR19DUllQVE9fTUlDSEFFTF9NSUM9 bQpDT05GSUdfQ1JZUFRPX1JNRDE2MD1tCkNPTkZJR19DUllQVE9fU0hBMT15CkNPTkZJR19D UllQVE9fU0hBMV9TU1NFMz1tCkNPTkZJR19DUllQVE9fU0hBMjU2X1NTU0UzPW0KQ09ORklH X0NSWVBUT19TSEE1MTJfU1NTRTM9bQpDT05GSUdfQ1JZUFRPX1NIQTI1Nj15CkNPTkZJR19D UllQVE9fU0hBNTEyPXkKQ09ORklHX0NSWVBUT19TSEEzPW0KQ09ORklHX0NSWVBUT19TTTM9 bQpDT05GSUdfQ1JZUFRPX1NUUkVFQk9HPW0KQ09ORklHX0NSWVBUT19XUDUxMj1tCkNPTkZJ R19DUllQVE9fR0hBU0hfQ0xNVUxfTklfSU5URUw9bQoKIwojIENpcGhlcnMKIwpDT05GSUdf Q1JZUFRPX0FFUz15CkNPTkZJR19DUllQVE9fQUVTX1RJPW0KQ09ORklHX0NSWVBUT19BRVNf TklfSU5URUw9bQpDT05GSUdfQ1JZUFRPX0JMT1dGSVNIPW0KQ09ORklHX0NSWVBUT19CTE9X RklTSF9DT01NT049bQpDT05GSUdfQ1JZUFRPX0JMT1dGSVNIX1g4Nl82ND1tCkNPTkZJR19D UllQVE9fQ0FNRUxMSUE9bQpDT05GSUdfQ1JZUFRPX0NBTUVMTElBX1g4Nl82ND1tCkNPTkZJ R19DUllQVE9fQ0FNRUxMSUFfQUVTTklfQVZYX1g4Nl82ND1tCkNPTkZJR19DUllQVE9fQ0FN RUxMSUFfQUVTTklfQVZYMl9YODZfNjQ9bQpDT05GSUdfQ1JZUFRPX0NBU1RfQ09NTU9OPW0K Q09ORklHX0NSWVBUT19DQVNUNT1tCkNPTkZJR19DUllQVE9fQ0FTVDVfQVZYX1g4Nl82ND1t CkNPTkZJR19DUllQVE9fQ0FTVDY9bQpDT05GSUdfQ1JZUFRPX0NBU1Q2X0FWWF9YODZfNjQ9 bQpDT05GSUdfQ1JZUFRPX0RFUz1tCkNPTkZJR19DUllQVE9fREVTM19FREVfWDg2XzY0PW0K Q09ORklHX0NSWVBUT19GQ1JZUFQ9bQpDT05GSUdfQ1JZUFRPX0NIQUNIQTIwPW0KQ09ORklH X0NSWVBUT19DSEFDSEEyMF9YODZfNjQ9bQpDT05GSUdfQ1JZUFRPX1NFUlBFTlQ9bQpDT05G SUdfQ1JZUFRPX1NFUlBFTlRfU1NFMl9YODZfNjQ9bQpDT05GSUdfQ1JZUFRPX1NFUlBFTlRf QVZYX1g4Nl82ND1tCkNPTkZJR19DUllQVE9fU0VSUEVOVF9BVlgyX1g4Nl82ND1tCkNPTkZJ R19DUllQVE9fU000PW0KQ09ORklHX0NSWVBUT19UV09GSVNIPW0KQ09ORklHX0NSWVBUT19U V09GSVNIX0NPTU1PTj1tCkNPTkZJR19DUllQVE9fVFdPRklTSF9YODZfNjQ9bQpDT05GSUdf Q1JZUFRPX1RXT0ZJU0hfWDg2XzY0XzNXQVk9bQpDT05GSUdfQ1JZUFRPX1RXT0ZJU0hfQVZY X1g4Nl82ND1tCgojCiMgQ29tcHJlc3Npb24KIwpDT05GSUdfQ1JZUFRPX0RFRkxBVEU9bQpD T05GSUdfQ1JZUFRPX0xaTz1tCkNPTkZJR19DUllQVE9fODQyPW0KQ09ORklHX0NSWVBUT19M WjQ9eQpDT05GSUdfQ1JZUFRPX0xaNEhDPW0KQ09ORklHX0NSWVBUT19aU1REPXkKCiMKIyBS YW5kb20gTnVtYmVyIEdlbmVyYXRpb24KIwpDT05GSUdfQ1JZUFRPX0FOU0lfQ1BSTkc9bQpD T05GSUdfQ1JZUFRPX0RSQkdfTUVOVT1tCkNPTkZJR19DUllQVE9fRFJCR19ITUFDPXkKQ09O RklHX0NSWVBUT19EUkJHX0hBU0g9eQpDT05GSUdfQ1JZUFRPX0RSQkdfQ1RSPXkKQ09ORklH X0NSWVBUT19EUkJHPW0KQ09ORklHX0NSWVBUT19KSVRURVJFTlRST1BZPXkKQ09ORklHX0NS WVBUT19VU0VSX0FQST1tCkNPTkZJR19DUllQVE9fVVNFUl9BUElfSEFTSD1tCkNPTkZJR19D UllQVE9fVVNFUl9BUElfU0tDSVBIRVI9bQpDT05GSUdfQ1JZUFRPX1VTRVJfQVBJX1JORz1t CiMgQ09ORklHX0NSWVBUT19VU0VSX0FQSV9STkdfQ0FWUCBpcyBub3Qgc2V0CkNPTkZJR19D UllQVE9fVVNFUl9BUElfQUVBRD1tCiMgQ09ORklHX0NSWVBUT19VU0VSX0FQSV9FTkFCTEVf T0JTT0xFVEUgaXMgbm90IHNldApDT05GSUdfQ1JZUFRPX1NUQVRTPXkKQ09ORklHX0NSWVBU T19IQVNIX0lORk89eQoKIwojIENyeXB0byBsaWJyYXJ5IHJvdXRpbmVzCiMKQ09ORklHX0NS WVBUT19MSUJfQUVTPXkKQ09ORklHX0NSWVBUT19MSUJfQVJDND1tCkNPTkZJR19DUllQVE9f QVJDSF9IQVZFX0xJQl9CTEFLRTJTPW0KQ09ORklHX0NSWVBUT19MSUJfQkxBS0UyU19HRU5F UklDPW0KQ09ORklHX0NSWVBUT19MSUJfQkxBS0UyUz1tCkNPTkZJR19DUllQVE9fQVJDSF9I QVZFX0xJQl9DSEFDSEE9bQpDT05GSUdfQ1JZUFRPX0xJQl9DSEFDSEFfR0VORVJJQz1tCkNP TkZJR19DUllQVE9fTElCX0NIQUNIQT1tCkNPTkZJR19DUllQVE9fQVJDSF9IQVZFX0xJQl9D VVJWRTI1NTE5PW0KQ09ORklHX0NSWVBUT19MSUJfQ1VSVkUyNTUxOV9HRU5FUklDPW0KQ09O RklHX0NSWVBUT19MSUJfQ1VSVkUyNTUxOT1tCkNPTkZJR19DUllQVE9fTElCX0RFUz1tCkNP TkZJR19DUllQVE9fTElCX1BPTFkxMzA1X1JTSVpFPTExCkNPTkZJR19DUllQVE9fQVJDSF9I QVZFX0xJQl9QT0xZMTMwNT1tCkNPTkZJR19DUllQVE9fTElCX1BPTFkxMzA1X0dFTkVSSUM9 bQpDT05GSUdfQ1JZUFRPX0xJQl9QT0xZMTMwNT1tCkNPTkZJR19DUllQVE9fTElCX0NIQUNI QTIwUE9MWTEzMDU9bQpDT05GSUdfQ1JZUFRPX0xJQl9TSEEyNTY9eQpDT05GSUdfQ1JZUFRP X0hXPXkKQ09ORklHX0NSWVBUT19ERVZfUEFETE9DSz1tCkNPTkZJR19DUllQVE9fREVWX1BB RExPQ0tfQUVTPW0KQ09ORklHX0NSWVBUT19ERVZfUEFETE9DS19TSEE9bQpDT05GSUdfQ1JZ UFRPX0RFVl9BVE1FTF9JMkM9bQpDT05GSUdfQ1JZUFRPX0RFVl9BVE1FTF9FQ0M9bQpDT05G SUdfQ1JZUFRPX0RFVl9BVE1FTF9TSEEyMDRBPW0KQ09ORklHX0NSWVBUT19ERVZfQ0NQPXkK Q09ORklHX0NSWVBUT19ERVZfQ0NQX0REPW0KQ09ORklHX0NSWVBUT19ERVZfU1BfQ0NQPXkK Q09ORklHX0NSWVBUT19ERVZfQ0NQX0NSWVBUTz1tCkNPTkZJR19DUllQVE9fREVWX1NQX1BT UD15CkNPTkZJR19DUllQVE9fREVWX0NDUF9ERUJVR0ZTPXkKQ09ORklHX0NSWVBUT19ERVZf UUFUPW0KQ09ORklHX0NSWVBUT19ERVZfUUFUX0RIODk1eENDPW0KQ09ORklHX0NSWVBUT19E RVZfUUFUX0MzWFhYPW0KQ09ORklHX0NSWVBUT19ERVZfUUFUX0M2Mlg9bQpDT05GSUdfQ1JZ UFRPX0RFVl9RQVRfNFhYWD1tCkNPTkZJR19DUllQVE9fREVWX1FBVF9ESDg5NXhDQ1ZGPW0K Q09ORklHX0NSWVBUT19ERVZfUUFUX0MzWFhYVkY9bQpDT05GSUdfQ1JZUFRPX0RFVl9RQVRf QzYyWFZGPW0KQ09ORklHX0NSWVBUT19ERVZfTklUUk9YPW0KQ09ORklHX0NSWVBUT19ERVZf TklUUk9YX0NOTjU1WFg9bQpDT05GSUdfQ1JZUFRPX0RFVl9DSEVMU0lPPW0KQ09ORklHX0NS WVBUT19ERVZfVklSVElPPW0KQ09ORklHX0NSWVBUT19ERVZfU0FGRVhDRUw9bQpDT05GSUdf Q1JZUFRPX0RFVl9BTUxPR0lDX0dYTD1tCkNPTkZJR19DUllQVE9fREVWX0FNTE9HSUNfR1hM X0RFQlVHPXkKQ09ORklHX0FTWU1NRVRSSUNfS0VZX1RZUEU9eQpDT05GSUdfQVNZTU1FVFJJ Q19QVUJMSUNfS0VZX1NVQlRZUEU9eQpDT05GSUdfQVNZTU1FVFJJQ19UUE1fS0VZX1NVQlRZ UEU9bQpDT05GSUdfWDUwOV9DRVJUSUZJQ0FURV9QQVJTRVI9eQpDT05GSUdfUEtDUzhfUFJJ VkFURV9LRVlfUEFSU0VSPW0KQ09ORklHX1RQTV9LRVlfUEFSU0VSPW0KQ09ORklHX1BLQ1M3 X01FU1NBR0VfUEFSU0VSPXkKIyBDT05GSUdfUEtDUzdfVEVTVF9LRVkgaXMgbm90IHNldApD T05GSUdfU0lHTkVEX1BFX0ZJTEVfVkVSSUZJQ0FUSU9OPXkKCiMKIyBDZXJ0aWZpY2F0ZXMg Zm9yIHNpZ25hdHVyZSBjaGVja2luZwojCkNPTkZJR19NT0RVTEVfU0lHX0tFWT0iY2VydHMv c2lnbmluZ19rZXkucGVtIgpDT05GSUdfU1lTVEVNX1RSVVNURURfS0VZUklORz15CkNPTkZJ R19TWVNURU1fVFJVU1RFRF9LRVlTPSIiCiMgQ09ORklHX1NZU1RFTV9FWFRSQV9DRVJUSUZJ Q0FURSBpcyBub3Qgc2V0CkNPTkZJR19TRUNPTkRBUllfVFJVU1RFRF9LRVlSSU5HPXkKQ09O RklHX1NZU1RFTV9CTEFDS0xJU1RfS0VZUklORz15CkNPTkZJR19TWVNURU1fQkxBQ0tMSVNU X0hBU0hfTElTVD0iIgojIGVuZCBvZiBDZXJ0aWZpY2F0ZXMgZm9yIHNpZ25hdHVyZSBjaGVj a2luZwoKQ09ORklHX0JJTkFSWV9QUklOVEY9eQoKIwojIExpYnJhcnkgcm91dGluZXMKIwpD T05GSUdfUkFJRDZfUFE9bQojIENPTkZJR19SQUlENl9QUV9CRU5DSE1BUksgaXMgbm90IHNl dApDT05GSUdfTElORUFSX1JBTkdFUz15CkNPTkZJR19QQUNLSU5HPXkKQ09ORklHX0JJVFJF VkVSU0U9eQpDT05GSUdfR0VORVJJQ19TVFJOQ1BZX0ZST01fVVNFUj15CkNPTkZJR19HRU5F UklDX1NUUk5MRU5fVVNFUj15CkNPTkZJR19HRU5FUklDX05FVF9VVElMUz15CkNPTkZJR19H RU5FUklDX0ZJTkRfRklSU1RfQklUPXkKQ09ORklHX0NPUkRJQz1tCiMgQ09ORklHX1BSSU1F X05VTUJFUlMgaXMgbm90IHNldApDT05GSUdfUkFUSU9OQUw9eQpDT05GSUdfR0VORVJJQ19Q Q0lfSU9NQVA9eQpDT05GSUdfR0VORVJJQ19JT01BUD15CkNPTkZJR19BUkNIX1VTRV9DTVBY Q0hHX0xPQ0tSRUY9eQpDT05GSUdfQVJDSF9IQVNfRkFTVF9NVUxUSVBMSUVSPXkKQ09ORklH X0FSQ0hfVVNFX1NZTV9BTk5PVEFUSU9OUz15CkNPTkZJR19DUkNfQ0NJVFQ9eQpDT05GSUdf Q1JDMTY9bQpDT05GSUdfQ1JDX1QxMERJRj15CkNPTkZJR19DUkNfSVRVX1Q9bQpDT05GSUdf Q1JDMzI9eQojIENPTkZJR19DUkMzMl9TRUxGVEVTVCBpcyBub3Qgc2V0CkNPTkZJR19DUkMz Ml9TTElDRUJZOD15CiMgQ09ORklHX0NSQzMyX1NMSUNFQlk0IGlzIG5vdCBzZXQKIyBDT05G SUdfQ1JDMzJfU0FSV0FURSBpcyBub3Qgc2V0CiMgQ09ORklHX0NSQzMyX0JJVCBpcyBub3Qg c2V0CkNPTkZJR19DUkM2ND1tCkNPTkZJR19DUkM0PW0KQ09ORklHX0NSQzc9bQpDT05GSUdf TElCQ1JDMzJDPW0KQ09ORklHX0NSQzg9bQpDT05GSUdfWFhIQVNIPXkKIyBDT05GSUdfUkFO RE9NMzJfU0VMRlRFU1QgaXMgbm90IHNldApDT05GSUdfODQyX0NPTVBSRVNTPW0KQ09ORklH Xzg0Ml9ERUNPTVBSRVNTPW0KQ09ORklHX1pMSUJfSU5GTEFURT15CkNPTkZJR19aTElCX0RF RkxBVEU9eQpDT05GSUdfTFpPX0NPTVBSRVNTPXkKQ09ORklHX0xaT19ERUNPTVBSRVNTPXkK Q09ORklHX0xaNF9DT01QUkVTUz15CkNPTkZJR19MWjRIQ19DT01QUkVTUz15CkNPTkZJR19M WjRfREVDT01QUkVTUz15CkNPTkZJR19aU1REX0NPTVBSRVNTPXkKQ09ORklHX1pTVERfREVD T01QUkVTUz15CkNPTkZJR19YWl9ERUM9eQpDT05GSUdfWFpfREVDX1g4Nj15CkNPTkZJR19Y Wl9ERUNfUE9XRVJQQz15CkNPTkZJR19YWl9ERUNfSUE2ND15CkNPTkZJR19YWl9ERUNfQVJN PXkKQ09ORklHX1haX0RFQ19BUk1USFVNQj15CkNPTkZJR19YWl9ERUNfU1BBUkM9eQpDT05G SUdfWFpfREVDX0JDSj15CiMgQ09ORklHX1haX0RFQ19URVNUIGlzIG5vdCBzZXQKQ09ORklH X0RFQ09NUFJFU1NfR1pJUD15CkNPTkZJR19ERUNPTVBSRVNTX0JaSVAyPXkKQ09ORklHX0RF Q09NUFJFU1NfTFpNQT15CkNPTkZJR19ERUNPTVBSRVNTX1haPXkKQ09ORklHX0RFQ09NUFJF U1NfTFpPPXkKQ09ORklHX0RFQ09NUFJFU1NfTFo0PXkKQ09ORklHX0RFQ09NUFJFU1NfWlNU RD15CkNPTkZJR19HRU5FUklDX0FMTE9DQVRPUj15CkNPTkZJR19SRUVEX1NPTE9NT049bQpD T05GSUdfUkVFRF9TT0xPTU9OX0VOQzg9eQpDT05GSUdfUkVFRF9TT0xPTU9OX0RFQzg9eQpD T05GSUdfQkNIPW0KQ09ORklHX1RFWFRTRUFSQ0g9eQpDT05GSUdfVEVYVFNFQVJDSF9LTVA9 bQpDT05GSUdfVEVYVFNFQVJDSF9CTT1tCkNPTkZJR19URVhUU0VBUkNIX0ZTTT1tCkNPTkZJ R19CVFJFRT15CkNPTkZJR19JTlRFUlZBTF9UUkVFPXkKQ09ORklHX1hBUlJBWV9NVUxUST15 CkNPTkZJR19BU1NPQ0lBVElWRV9BUlJBWT15CkNPTkZJR19IQVNfSU9NRU09eQpDT05GSUdf SEFTX0lPUE9SVF9NQVA9eQpDT05GSUdfSEFTX0RNQT15CkNPTkZJR19ETUFfT1BTPXkKQ09O RklHX05FRURfU0dfRE1BX0xFTkdUSD15CkNPTkZJR19ORUVEX0RNQV9NQVBfU1RBVEU9eQpD T05GSUdfQVJDSF9ETUFfQUREUl9UXzY0QklUPXkKQ09ORklHX0FSQ0hfSEFTX0ZPUkNFX0RN QV9VTkVOQ1JZUFRFRD15CkNPTkZJR19TV0lPVExCPXkKQ09ORklHX0RNQV9DT0hFUkVOVF9Q T09MPXkKQ09ORklHX0RNQV9DTUE9eQojIENPTkZJR19ETUFfUEVSTlVNQV9DTUEgaXMgbm90 IHNldAoKIwojIERlZmF1bHQgY29udGlndW91cyBtZW1vcnkgYXJlYSBzaXplOgojCkNPTkZJ R19DTUFfU0laRV9NQllURVM9MApDT05GSUdfQ01BX1NJWkVfU0VMX01CWVRFUz15CiMgQ09O RklHX0NNQV9TSVpFX1NFTF9QRVJDRU5UQUdFIGlzIG5vdCBzZXQKIyBDT05GSUdfQ01BX1NJ WkVfU0VMX01JTiBpcyBub3Qgc2V0CiMgQ09ORklHX0NNQV9TSVpFX1NFTF9NQVggaXMgbm90 IHNldApDT05GSUdfQ01BX0FMSUdOTUVOVD04CiMgQ09ORklHX0RNQV9BUElfREVCVUcgaXMg bm90IHNldAojIENPTkZJR19ETUFfTUFQX0JFTkNITUFSSyBpcyBub3Qgc2V0CkNPTkZJR19T R0xfQUxMT0M9eQpDT05GSUdfQ0hFQ0tfU0lHTkFUVVJFPXkKQ09ORklHX0NQVV9STUFQPXkK Q09ORklHX0RRTD15CkNPTkZJR19HTE9CPXkKIyBDT05GSUdfR0xPQl9TRUxGVEVTVCBpcyBu b3Qgc2V0CkNPTkZJR19OTEFUVFI9eQpDT05GSUdfTFJVX0NBQ0hFPW0KQ09ORklHX0NMWl9U QUI9eQpDT05GSUdfSVJRX1BPTEw9eQpDT05GSUdfTVBJTElCPXkKQ09ORklHX0RJTUxJQj15 CkNPTkZJR19PSURfUkVHSVNUUlk9eQpDT05GSUdfVUNTMl9TVFJJTkc9eQpDT05GSUdfSEFW RV9HRU5FUklDX1ZEU089eQpDT05GSUdfR0VORVJJQ19HRVRUSU1FT0ZEQVk9eQpDT05GSUdf R0VORVJJQ19WRFNPX1RJTUVfTlM9eQpDT05GSUdfRk9OVF9TVVBQT1JUPXkKQ09ORklHX0ZP TlRTPXkKIyBDT05GSUdfRk9OVF84eDggaXMgbm90IHNldApDT05GSUdfRk9OVF84eDE2PXkK IyBDT05GSUdfRk9OVF82eDExIGlzIG5vdCBzZXQKIyBDT05GSUdfRk9OVF83eDE0IGlzIG5v dCBzZXQKIyBDT05GSUdfRk9OVF9QRUFSTF84eDggaXMgbm90IHNldAojIENPTkZJR19GT05U X0FDT1JOXzh4OCBpcyBub3Qgc2V0CiMgQ09ORklHX0ZPTlRfTUlOSV80eDYgaXMgbm90IHNl dAojIENPTkZJR19GT05UXzZ4MTAgaXMgbm90IHNldAojIENPTkZJR19GT05UXzEweDE4IGlz IG5vdCBzZXQKIyBDT05GSUdfRk9OVF9TVU44eDE2IGlzIG5vdCBzZXQKIyBDT05GSUdfRk9O VF9TVU4xMngyMiBpcyBub3Qgc2V0CkNPTkZJR19GT05UX1RFUjE2eDMyPXkKIyBDT05GSUdf Rk9OVF82eDggaXMgbm90IHNldApDT05GSUdfU0dfUE9PTD15CkNPTkZJR19BUkNIX0hBU19Q TUVNX0FQST15CkNPTkZJR19NRU1SRUdJT049eQpDT05GSUdfQVJDSF9IQVNfVUFDQ0VTU19G TFVTSENBQ0hFPXkKQ09ORklHX0FSQ0hfSEFTX0NPUFlfTUM9eQpDT05GSUdfQVJDSF9TVEFD S1dBTEs9eQpDT05GSUdfU0JJVE1BUD15CkNPTkZJR19QQVJNQU49bQpDT05GSUdfT0JKQUdH PW0KIyBDT05GSUdfU1RSSU5HX1NFTEZURVNUIGlzIG5vdCBzZXQKIyBlbmQgb2YgTGlicmFy eSByb3V0aW5lcwoKQ09ORklHX1BMRE1GVz15CgojCiMgS2VybmVsIGhhY2tpbmcKIwoKIwoj IHByaW50ayBhbmQgZG1lc2cgb3B0aW9ucwojCkNPTkZJR19QUklOVEtfVElNRT15CiMgQ09O RklHX1BSSU5US19DQUxMRVIgaXMgbm90IHNldApDT05GSUdfQ09OU09MRV9MT0dMRVZFTF9E RUZBVUxUPTQKQ09ORklHX0NPTlNPTEVfTE9HTEVWRUxfUVVJRVQ9MQpDT05GSUdfTUVTU0FH RV9MT0dMRVZFTF9ERUZBVUxUPTQKQ09ORklHX0JPT1RfUFJJTlRLX0RFTEFZPXkKQ09ORklH X0RZTkFNSUNfREVCVUc9eQpDT05GSUdfRFlOQU1JQ19ERUJVR19DT1JFPXkKQ09ORklHX1NZ TUJPTElDX0VSUk5BTUU9eQpDT05GSUdfREVCVUdfQlVHVkVSQk9TRT15CiMgZW5kIG9mIHBy aW50ayBhbmQgZG1lc2cgb3B0aW9ucwoKIwojIENvbXBpbGUtdGltZSBjaGVja3MgYW5kIGNv bXBpbGVyIG9wdGlvbnMKIwpDT05GSUdfREVCVUdfSU5GTz15CiMgQ09ORklHX0RFQlVHX0lO Rk9fUkVEVUNFRCBpcyBub3Qgc2V0CiMgQ09ORklHX0RFQlVHX0lORk9fQ09NUFJFU1NFRCBp cyBub3Qgc2V0CiMgQ09ORklHX0RFQlVHX0lORk9fU1BMSVQgaXMgbm90IHNldAojIENPTkZJ R19ERUJVR19JTkZPX0RXQVJGX1RPT0xDSEFJTl9ERUZBVUxUIGlzIG5vdCBzZXQKQ09ORklH X0RFQlVHX0lORk9fRFdBUkY0PXkKQ09ORklHX0RFQlVHX0lORk9fQlRGPXkKIyBDT05GSUdf R0RCX1NDUklQVFMgaXMgbm90IHNldApDT05GSUdfRlJBTUVfV0FSTj0yMDQ4CkNPTkZJR19T VFJJUF9BU01fU1lNUz15CiMgQ09ORklHX1JFQURBQkxFX0FTTSBpcyBub3Qgc2V0CiMgQ09O RklHX0hFQURFUlNfSU5TVEFMTCBpcyBub3Qgc2V0CiMgQ09ORklHX0RFQlVHX1NFQ1RJT05f TUlTTUFUQ0ggaXMgbm90IHNldApDT05GSUdfU0VDVElPTl9NSVNNQVRDSF9XQVJOX09OTFk9 eQpDT05GSUdfU1RBQ0tfVkFMSURBVElPTj15CiMgQ09ORklHX0RFQlVHX0ZPUkNFX1dFQUtf UEVSX0NQVSBpcyBub3Qgc2V0CiMgZW5kIG9mIENvbXBpbGUtdGltZSBjaGVja3MgYW5kIGNv bXBpbGVyIG9wdGlvbnMKCiMKIyBHZW5lcmljIEtlcm5lbCBEZWJ1Z2dpbmcgSW5zdHJ1bWVu dHMKIwpDT05GSUdfTUFHSUNfU1lTUlE9eQpDT05GSUdfTUFHSUNfU1lTUlFfREVGQVVMVF9F TkFCTEU9MHgwCkNPTkZJR19NQUdJQ19TWVNSUV9TRVJJQUw9eQpDT05GSUdfTUFHSUNfU1lT UlFfU0VSSUFMX1NFUVVFTkNFPSIiCkNPTkZJR19ERUJVR19GUz15CkNPTkZJR19ERUJVR19G U19BTExPV19BTEw9eQojIENPTkZJR19ERUJVR19GU19ESVNBTExPV19NT1VOVCBpcyBub3Qg c2V0CiMgQ09ORklHX0RFQlVHX0ZTX0FMTE9XX05PTkUgaXMgbm90IHNldApDT05GSUdfSEFW RV9BUkNIX0tHREI9eQojIENPTkZJR19LR0RCIGlzIG5vdCBzZXQKQ09ORklHX0FSQ0hfSEFT X1VCU0FOX1NBTklUSVpFX0FMTD15CiMgQ09ORklHX1VCU0FOIGlzIG5vdCBzZXQKQ09ORklH X0hBVkVfQVJDSF9LQ1NBTj15CkNPTkZJR19IQVZFX0tDU0FOX0NPTVBJTEVSPXkKIyBDT05G SUdfS0NTQU4gaXMgbm90IHNldAojIGVuZCBvZiBHZW5lcmljIEtlcm5lbCBEZWJ1Z2dpbmcg SW5zdHJ1bWVudHMKCkNPTkZJR19ERUJVR19LRVJORUw9eQojIENPTkZJR19ERUJVR19NSVND IGlzIG5vdCBzZXQKCiMKIyBNZW1vcnkgRGVidWdnaW5nCiMKIyBDT05GSUdfUEFHRV9FWFRF TlNJT04gaXMgbm90IHNldAojIENPTkZJR19ERUJVR19QQUdFQUxMT0MgaXMgbm90IHNldAoj IENPTkZJR19QQUdFX09XTkVSIGlzIG5vdCBzZXQKQ09ORklHX1BBR0VfUE9JU09OSU5HPXkK IyBDT05GSUdfREVCVUdfUEFHRV9SRUYgaXMgbm90IHNldApDT05GSUdfREVCVUdfUk9EQVRB X1RFU1Q9eQpDT05GSUdfQVJDSF9IQVNfREVCVUdfV1g9eQpDT05GSUdfREVCVUdfV1g9eQpD T05GSUdfR0VORVJJQ19QVERVTVA9eQpDT05GSUdfUFREVU1QX0NPUkU9eQojIENPTkZJR19Q VERVTVBfREVCVUdGUyBpcyBub3Qgc2V0CiMgQ09ORklHX0RFQlVHX09CSkVDVFMgaXMgbm90 IHNldAojIENPTkZJR19TTFVCX0RFQlVHX09OIGlzIG5vdCBzZXQKIyBDT05GSUdfU0xVQl9T VEFUUyBpcyBub3Qgc2V0CkNPTkZJR19IQVZFX0RFQlVHX0tNRU1MRUFLPXkKIyBDT05GSUdf REVCVUdfS01FTUxFQUsgaXMgbm90IHNldAojIENPTkZJR19ERUJVR19TVEFDS19VU0FHRSBp cyBub3Qgc2V0CkNPTkZJR19TQ0hFRF9TVEFDS19FTkRfQ0hFQ0s9eQpDT05GSUdfQVJDSF9I QVNfREVCVUdfVk1fUEdUQUJMRT15CiMgQ09ORklHX0RFQlVHX1ZNIGlzIG5vdCBzZXQKIyBD T05GSUdfREVCVUdfVk1fUEdUQUJMRSBpcyBub3Qgc2V0CkNPTkZJR19BUkNIX0hBU19ERUJV R19WSVJUVUFMPXkKIyBDT05GSUdfREVCVUdfVklSVFVBTCBpcyBub3Qgc2V0CkNPTkZJR19E RUJVR19NRU1PUllfSU5JVD15CiMgQ09ORklHX0RFQlVHX1BFUl9DUFVfTUFQUyBpcyBub3Qg c2V0CkNPTkZJR19BUkNIX1NVUFBPUlRTX0tNQVBfTE9DQUxfRk9SQ0VfTUFQPXkKIyBDT05G SUdfREVCVUdfS01BUF9MT0NBTF9GT1JDRV9NQVAgaXMgbm90IHNldApDT05GSUdfSEFWRV9B UkNIX0tBU0FOPXkKQ09ORklHX0hBVkVfQVJDSF9LQVNBTl9WTUFMTE9DPXkKQ09ORklHX0ND X0hBU19LQVNBTl9HRU5FUklDPXkKQ09ORklHX0NDX0hBU19XT1JLSU5HX05PU0FOSVRJWkVf QUREUkVTUz15CiMgQ09ORklHX0tBU0FOIGlzIG5vdCBzZXQKQ09ORklHX0hBVkVfQVJDSF9L RkVOQ0U9eQpDT05GSUdfS0ZFTkNFPXkKQ09ORklHX0tGRU5DRV9TVEFUSUNfS0VZUz15CkNP TkZJR19LRkVOQ0VfU0FNUExFX0lOVEVSVkFMPTAKQ09ORklHX0tGRU5DRV9OVU1fT0JKRUNU Uz0yNTUKQ09ORklHX0tGRU5DRV9TVFJFU1NfVEVTVF9GQVVMVFM9MAojIGVuZCBvZiBNZW1v cnkgRGVidWdnaW5nCgpDT05GSUdfREVCVUdfU0hJUlE9eQoKIwojIERlYnVnIE9vcHMsIExv Y2t1cHMgYW5kIEhhbmdzCiMKIyBDT05GSUdfUEFOSUNfT05fT09QUyBpcyBub3Qgc2V0CkNP TkZJR19QQU5JQ19PTl9PT1BTX1ZBTFVFPTAKQ09ORklHX1BBTklDX1RJTUVPVVQ9MApDT05G SUdfTE9DS1VQX0RFVEVDVE9SPXkKQ09ORklHX1NPRlRMT0NLVVBfREVURUNUT1I9eQojIENP TkZJR19CT09UUEFSQU1fU09GVExPQ0tVUF9QQU5JQyBpcyBub3Qgc2V0CkNPTkZJR19CT09U UEFSQU1fU09GVExPQ0tVUF9QQU5JQ19WQUxVRT0wCkNPTkZJR19IQVJETE9DS1VQX0RFVEVD VE9SX1BFUkY9eQpDT05GSUdfSEFSRExPQ0tVUF9DSEVDS19USU1FU1RBTVA9eQpDT05GSUdf SEFSRExPQ0tVUF9ERVRFQ1RPUj15CiMgQ09ORklHX0JPT1RQQVJBTV9IQVJETE9DS1VQX1BB TklDIGlzIG5vdCBzZXQKQ09ORklHX0JPT1RQQVJBTV9IQVJETE9DS1VQX1BBTklDX1ZBTFVF PTAKQ09ORklHX0RFVEVDVF9IVU5HX1RBU0s9eQpDT05GSUdfREVGQVVMVF9IVU5HX1RBU0tf VElNRU9VVD0xMjAKIyBDT05GSUdfQk9PVFBBUkFNX0hVTkdfVEFTS19QQU5JQyBpcyBub3Qg c2V0CkNPTkZJR19CT09UUEFSQU1fSFVOR19UQVNLX1BBTklDX1ZBTFVFPTAKIyBDT05GSUdf V1FfV0FUQ0hET0cgaXMgbm90IHNldAojIENPTkZJR19URVNUX0xPQ0tVUCBpcyBub3Qgc2V0 CiMgZW5kIG9mIERlYnVnIE9vcHMsIExvY2t1cHMgYW5kIEhhbmdzCgojCiMgU2NoZWR1bGVy IERlYnVnZ2luZwojCkNPTkZJR19TQ0hFRF9ERUJVRz15CkNPTkZJR19TQ0hFRF9JTkZPPXkK Q09ORklHX1NDSEVEU1RBVFM9eQojIGVuZCBvZiBTY2hlZHVsZXIgRGVidWdnaW5nCgojIENP TkZJR19ERUJVR19USU1FS0VFUElORyBpcyBub3Qgc2V0CiMgQ09ORklHX0RFQlVHX1BSRUVN UFQgaXMgbm90IHNldAoKIwojIExvY2sgRGVidWdnaW5nIChzcGlubG9ja3MsIG11dGV4ZXMs IGV0Yy4uLikKIwpDT05GSUdfTE9DS19ERUJVR0dJTkdfU1VQUE9SVD15CiMgQ09ORklHX1BS T1ZFX0xPQ0tJTkcgaXMgbm90IHNldAojIENPTkZJR19MT0NLX1NUQVQgaXMgbm90IHNldAoj IENPTkZJR19ERUJVR19SVF9NVVRFWEVTIGlzIG5vdCBzZXQKIyBDT05GSUdfREVCVUdfU1BJ TkxPQ0sgaXMgbm90IHNldAojIENPTkZJR19ERUJVR19NVVRFWEVTIGlzIG5vdCBzZXQKIyBD T05GSUdfREVCVUdfV1dfTVVURVhfU0xPV1BBVEggaXMgbm90IHNldAojIENPTkZJR19ERUJV R19SV1NFTVMgaXMgbm90IHNldAojIENPTkZJR19ERUJVR19MT0NLX0FMTE9DIGlzIG5vdCBz ZXQKIyBDT05GSUdfREVCVUdfQVRPTUlDX1NMRUVQIGlzIG5vdCBzZXQKIyBDT05GSUdfREVC VUdfTE9DS0lOR19BUElfU0VMRlRFU1RTIGlzIG5vdCBzZXQKIyBDT05GSUdfTE9DS19UT1JU VVJFX1RFU1QgaXMgbm90IHNldAojIENPTkZJR19XV19NVVRFWF9TRUxGVEVTVCBpcyBub3Qg c2V0CiMgQ09ORklHX1NDRl9UT1JUVVJFX1RFU1QgaXMgbm90IHNldAojIENPTkZJR19DU0Rf TE9DS19XQUlUX0RFQlVHIGlzIG5vdCBzZXQKIyBlbmQgb2YgTG9jayBEZWJ1Z2dpbmcgKHNw aW5sb2NrcywgbXV0ZXhlcywgZXRjLi4uKQoKIyBDT05GSUdfREVCVUdfSVJRRkxBR1MgaXMg bm90IHNldApDT05GSUdfU1RBQ0tUUkFDRT15CiMgQ09ORklHX1dBUk5fQUxMX1VOU0VFREVE X1JBTkRPTSBpcyBub3Qgc2V0CiMgQ09ORklHX0RFQlVHX0tPQkpFQ1QgaXMgbm90IHNldAoK IwojIERlYnVnIGtlcm5lbCBkYXRhIHN0cnVjdHVyZXMKIwpDT05GSUdfREVCVUdfTElTVD15 CiMgQ09ORklHX0RFQlVHX1BMSVNUIGlzIG5vdCBzZXQKIyBDT05GSUdfREVCVUdfU0cgaXMg bm90IHNldAojIENPTkZJR19ERUJVR19OT1RJRklFUlMgaXMgbm90IHNldAojIENPTkZJR19C VUdfT05fREFUQV9DT1JSVVBUSU9OIGlzIG5vdCBzZXQKIyBlbmQgb2YgRGVidWcga2VybmVs IGRhdGEgc3RydWN0dXJlcwoKIyBDT05GSUdfREVCVUdfQ1JFREVOVElBTFMgaXMgbm90IHNl dAoKIwojIFJDVSBEZWJ1Z2dpbmcKIwojIENPTkZJR19SQ1VfU0NBTEVfVEVTVCBpcyBub3Qg c2V0CiMgQ09ORklHX1JDVV9UT1JUVVJFX1RFU1QgaXMgbm90IHNldAojIENPTkZJR19SQ1Vf UkVGX1NDQUxFX1RFU1QgaXMgbm90IHNldApDT05GSUdfUkNVX0NQVV9TVEFMTF9USU1FT1VU PTYwCiMgQ09ORklHX1JDVV9UUkFDRSBpcyBub3Qgc2V0CiMgQ09ORklHX1JDVV9FUVNfREVC VUcgaXMgbm90IHNldAojIENPTkZJR19SQ1VfU1RSSUNUX0dSQUNFX1BFUklPRCBpcyBub3Qg c2V0CiMgZW5kIG9mIFJDVSBEZWJ1Z2dpbmcKCiMgQ09ORklHX0RFQlVHX1dRX0ZPUkNFX1JS X0NQVSBpcyBub3Qgc2V0CiMgQ09ORklHX0RFQlVHX0JMT0NLX0VYVF9ERVZUIGlzIG5vdCBz ZXQKIyBDT05GSUdfQ1BVX0hPVFBMVUdfU1RBVEVfQ09OVFJPTCBpcyBub3Qgc2V0CkNPTkZJ R19MQVRFTkNZVE9QPXkKQ09ORklHX1VTRVJfU1RBQ0tUUkFDRV9TVVBQT1JUPXkKQ09ORklH X05PUF9UUkFDRVI9eQpDT05GSUdfSEFWRV9GVU5DVElPTl9UUkFDRVI9eQpDT05GSUdfSEFW RV9GVU5DVElPTl9HUkFQSF9UUkFDRVI9eQpDT05GSUdfSEFWRV9EWU5BTUlDX0ZUUkFDRT15 CkNPTkZJR19IQVZFX0RZTkFNSUNfRlRSQUNFX1dJVEhfUkVHUz15CkNPTkZJR19IQVZFX0RZ TkFNSUNfRlRSQUNFX1dJVEhfRElSRUNUX0NBTExTPXkKQ09ORklHX0hBVkVfRFlOQU1JQ19G VFJBQ0VfV0lUSF9BUkdTPXkKQ09ORklHX0hBVkVfRlRSQUNFX01DT1VOVF9SRUNPUkQ9eQpD T05GSUdfSEFWRV9TWVNDQUxMX1RSQUNFUE9JTlRTPXkKQ09ORklHX0hBVkVfRkVOVFJZPXkK Q09ORklHX0hBVkVfT0JKVE9PTF9NQ09VTlQ9eQpDT05GSUdfSEFWRV9DX1JFQ09SRE1DT1VO VD15CkNPTkZJR19UUkFDRVJfTUFYX1RSQUNFPXkKQ09ORklHX1RSQUNFX0NMT0NLPXkKQ09O RklHX1JJTkdfQlVGRkVSPXkKQ09ORklHX0VWRU5UX1RSQUNJTkc9eQpDT05GSUdfQ09OVEVY VF9TV0lUQ0hfVFJBQ0VSPXkKQ09ORklHX1RSQUNJTkc9eQpDT05GSUdfR0VORVJJQ19UUkFD RVI9eQpDT05GSUdfVFJBQ0lOR19TVVBQT1JUPXkKQ09ORklHX0ZUUkFDRT15CkNPTkZJR19C T09UVElNRV9UUkFDSU5HPXkKQ09ORklHX0ZVTkNUSU9OX1RSQUNFUj15CkNPTkZJR19GVU5D VElPTl9HUkFQSF9UUkFDRVI9eQpDT05GSUdfRFlOQU1JQ19GVFJBQ0U9eQpDT05GSUdfRFlO QU1JQ19GVFJBQ0VfV0lUSF9SRUdTPXkKQ09ORklHX0RZTkFNSUNfRlRSQUNFX1dJVEhfRElS RUNUX0NBTExTPXkKQ09ORklHX0ZVTkNUSU9OX1BST0ZJTEVSPXkKQ09ORklHX1NUQUNLX1RS QUNFUj15CiMgQ09ORklHX0lSUVNPRkZfVFJBQ0VSIGlzIG5vdCBzZXQKIyBDT05GSUdfUFJF RU1QVF9UUkFDRVIgaXMgbm90IHNldApDT05GSUdfU0NIRURfVFJBQ0VSPXkKQ09ORklHX0hX TEFUX1RSQUNFUj15CkNPTkZJR19NTUlPVFJBQ0U9eQpDT05GSUdfRlRSQUNFX1NZU0NBTExT PXkKQ09ORklHX1RSQUNFUl9TTkFQU0hPVD15CiMgQ09ORklHX1RSQUNFUl9TTkFQU0hPVF9Q RVJfQ1BVX1NXQVAgaXMgbm90IHNldApDT05GSUdfQlJBTkNIX1BST0ZJTEVfTk9ORT15CiMg Q09ORklHX1BST0ZJTEVfQU5OT1RBVEVEX0JSQU5DSEVTIGlzIG5vdCBzZXQKQ09ORklHX0JM S19ERVZfSU9fVFJBQ0U9eQpDT05GSUdfS1BST0JFX0VWRU5UUz15CiMgQ09ORklHX0tQUk9C RV9FVkVOVFNfT05fTk9UUkFDRSBpcyBub3Qgc2V0CkNPTkZJR19VUFJPQkVfRVZFTlRTPXkK Q09ORklHX0JQRl9FVkVOVFM9eQpDT05GSUdfRFlOQU1JQ19FVkVOVFM9eQpDT05GSUdfUFJP QkVfRVZFTlRTPXkKQ09ORklHX0JQRl9LUFJPQkVfT1ZFUlJJREU9eQpDT05GSUdfRlRSQUNF X01DT1VOVF9SRUNPUkQ9eQpDT05GSUdfRlRSQUNFX01DT1VOVF9VU0VfQ0M9eQpDT05GSUdf VFJBQ0lOR19NQVA9eQpDT05GSUdfU1lOVEhfRVZFTlRTPXkKQ09ORklHX0hJU1RfVFJJR0dF UlM9eQojIENPTkZJR19UUkFDRV9FVkVOVF9JTkpFQ1QgaXMgbm90IHNldAojIENPTkZJR19U UkFDRVBPSU5UX0JFTkNITUFSSyBpcyBub3Qgc2V0CiMgQ09ORklHX1JJTkdfQlVGRkVSX0JF TkNITUFSSyBpcyBub3Qgc2V0CiMgQ09ORklHX1RSQUNFX0VWQUxfTUFQX0ZJTEUgaXMgbm90 IHNldAojIENPTkZJR19GVFJBQ0VfUkVDT1JEX1JFQ1VSU0lPTiBpcyBub3Qgc2V0CiMgQ09O RklHX0ZUUkFDRV9TVEFSVFVQX1RFU1QgaXMgbm90IHNldAojIENPTkZJR19SSU5HX0JVRkZF Ul9TVEFSVFVQX1RFU1QgaXMgbm90IHNldAojIENPTkZJR19SSU5HX0JVRkZFUl9WQUxJREFU RV9USU1FX0RFTFRBUyBpcyBub3Qgc2V0CiMgQ09ORklHX01NSU9UUkFDRV9URVNUIGlzIG5v dCBzZXQKIyBDT05GSUdfUFJFRU1QVElSUV9ERUxBWV9URVNUIGlzIG5vdCBzZXQKIyBDT05G SUdfU1lOVEhfRVZFTlRfR0VOX1RFU1QgaXMgbm90IHNldAojIENPTkZJR19LUFJPQkVfRVZF TlRfR0VOX1RFU1QgaXMgbm90IHNldAojIENPTkZJR19ISVNUX1RSSUdHRVJTX0RFQlVHIGlz IG5vdCBzZXQKIyBDT05GSUdfUFJPVklERV9PSENJMTM5NF9ETUFfSU5JVCBpcyBub3Qgc2V0 CiMgQ09ORklHX1NBTVBMRVMgaXMgbm90IHNldApDT05GSUdfQVJDSF9IQVNfREVWTUVNX0lT X0FMTE9XRUQ9eQpDT05GSUdfU1RSSUNUX0RFVk1FTT15CkNPTkZJR19JT19TVFJJQ1RfREVW TUVNPXkKCiMKIyB4ODYgRGVidWdnaW5nCiMKQ09ORklHX1RSQUNFX0lSUUZMQUdTX1NVUFBP UlQ9eQpDT05GSUdfVFJBQ0VfSVJRRkxBR1NfTk1JX1NVUFBPUlQ9eQpDT05GSUdfRUFSTFlf UFJJTlRLX1VTQj15CiMgQ09ORklHX1g4Nl9WRVJCT1NFX0JPT1RVUCBpcyBub3Qgc2V0CkNP TkZJR19FQVJMWV9QUklOVEs9eQpDT05GSUdfRUFSTFlfUFJJTlRLX0RCR1A9eQpDT05GSUdf RUFSTFlfUFJJTlRLX1VTQl9YREJDPXkKIyBDT05GSUdfRUZJX1BHVF9EVU1QIGlzIG5vdCBz ZXQKIyBDT05GSUdfREVCVUdfVExCRkxVU0ggaXMgbm90IHNldApDT05GSUdfSEFWRV9NTUlP VFJBQ0VfU1VQUE9SVD15CkNPTkZJR19YODZfREVDT0RFUl9TRUxGVEVTVD15CkNPTkZJR19J T19ERUxBWV8wWDgwPXkKIyBDT05GSUdfSU9fREVMQVlfMFhFRCBpcyBub3Qgc2V0CiMgQ09O RklHX0lPX0RFTEFZX1VERUxBWSBpcyBub3Qgc2V0CiMgQ09ORklHX0lPX0RFTEFZX05PTkUg aXMgbm90IHNldApDT05GSUdfREVCVUdfQk9PVF9QQVJBTVM9eQojIENPTkZJR19DUEFfREVC VUcgaXMgbm90IHNldAojIENPTkZJR19ERUJVR19FTlRSWSBpcyBub3Qgc2V0CiMgQ09ORklH X0RFQlVHX05NSV9TRUxGVEVTVCBpcyBub3Qgc2V0CiMgQ09ORklHX1g4Nl9ERUJVR19GUFUg aXMgbm90IHNldAojIENPTkZJR19QVU5JVF9BVE9NX0RFQlVHIGlzIG5vdCBzZXQKQ09ORklH X1VOV0lOREVSX09SQz15CiMgQ09ORklHX1VOV0lOREVSX0ZSQU1FX1BPSU5URVIgaXMgbm90 IHNldAojIGVuZCBvZiB4ODYgRGVidWdnaW5nCgojCiMgS2VybmVsIFRlc3RpbmcgYW5kIENv dmVyYWdlCiMKIyBDT05GSUdfS1VOSVQgaXMgbm90IHNldAojIENPTkZJR19OT1RJRklFUl9F UlJPUl9JTkpFQ1RJT04gaXMgbm90IHNldApDT05GSUdfRlVOQ1RJT05fRVJST1JfSU5KRUNU SU9OPXkKIyBDT05GSUdfRkFVTFRfSU5KRUNUSU9OIGlzIG5vdCBzZXQKQ09ORklHX0FSQ0hf SEFTX0tDT1Y9eQpDT05GSUdfQ0NfSEFTX1NBTkNPVl9UUkFDRV9QQz15CiMgQ09ORklHX0tD T1YgaXMgbm90IHNldApDT05GSUdfUlVOVElNRV9URVNUSU5HX01FTlU9eQojIENPTkZJR19M S0RUTSBpcyBub3Qgc2V0CiMgQ09ORklHX1RFU1RfTElTVF9TT1JUIGlzIG5vdCBzZXQKIyBD T05GSUdfVEVTVF9NSU5fSEVBUCBpcyBub3Qgc2V0CiMgQ09ORklHX1RFU1RfU09SVCBpcyBu b3Qgc2V0CiMgQ09ORklHX0tQUk9CRVNfU0FOSVRZX1RFU1QgaXMgbm90IHNldAojIENPTkZJ R19CQUNLVFJBQ0VfU0VMRl9URVNUIGlzIG5vdCBzZXQKIyBDT05GSUdfUkJUUkVFX1RFU1Qg aXMgbm90IHNldAojIENPTkZJR19SRUVEX1NPTE9NT05fVEVTVCBpcyBub3Qgc2V0CiMgQ09O RklHX0lOVEVSVkFMX1RSRUVfVEVTVCBpcyBub3Qgc2V0CiMgQ09ORklHX1BFUkNQVV9URVNU IGlzIG5vdCBzZXQKIyBDT05GSUdfQVRPTUlDNjRfU0VMRlRFU1QgaXMgbm90IHNldApDT05G SUdfQVNZTkNfUkFJRDZfVEVTVD1tCiMgQ09ORklHX1RFU1RfSEVYRFVNUCBpcyBub3Qgc2V0 CiMgQ09ORklHX1RFU1RfU1RSSU5HX0hFTFBFUlMgaXMgbm90IHNldAojIENPTkZJR19URVNU X1NUUlNDUFkgaXMgbm90IHNldAojIENPTkZJR19URVNUX0tTVFJUT1ggaXMgbm90IHNldAoj IENPTkZJR19URVNUX1BSSU5URiBpcyBub3Qgc2V0CiMgQ09ORklHX1RFU1RfQklUTUFQIGlz IG5vdCBzZXQKIyBDT05GSUdfVEVTVF9VVUlEIGlzIG5vdCBzZXQKIyBDT05GSUdfVEVTVF9Y QVJSQVkgaXMgbm90IHNldAojIENPTkZJR19URVNUX09WRVJGTE9XIGlzIG5vdCBzZXQKIyBD T05GSUdfVEVTVF9SSEFTSFRBQkxFIGlzIG5vdCBzZXQKIyBDT05GSUdfVEVTVF9IQVNIIGlz IG5vdCBzZXQKIyBDT05GSUdfVEVTVF9JREEgaXMgbm90IHNldAojIENPTkZJR19URVNUX1BB Uk1BTiBpcyBub3Qgc2V0CiMgQ09ORklHX1RFU1RfTEtNIGlzIG5vdCBzZXQKIyBDT05GSUdf VEVTVF9CSVRPUFMgaXMgbm90IHNldAojIENPTkZJR19URVNUX1ZNQUxMT0MgaXMgbm90IHNl dAojIENPTkZJR19URVNUX1VTRVJfQ09QWSBpcyBub3Qgc2V0CiMgQ09ORklHX1RFU1RfQlBG IGlzIG5vdCBzZXQKIyBDT05GSUdfVEVTVF9CTEFDS0hPTEVfREVWIGlzIG5vdCBzZXQKIyBD T05GSUdfRklORF9CSVRfQkVOQ0hNQVJLIGlzIG5vdCBzZXQKIyBDT05GSUdfVEVTVF9GSVJN V0FSRSBpcyBub3Qgc2V0CiMgQ09ORklHX1RFU1RfU1lTQ1RMIGlzIG5vdCBzZXQKIyBDT05G SUdfVEVTVF9VREVMQVkgaXMgbm90IHNldAojIENPTkZJR19URVNUX1NUQVRJQ19LRVlTIGlz IG5vdCBzZXQKIyBDT05GSUdfVEVTVF9LTU9EIGlzIG5vdCBzZXQKIyBDT05GSUdfVEVTVF9N RU1DQVRfUCBpcyBub3Qgc2V0CiMgQ09ORklHX1RFU1RfT0JKQUdHIGlzIG5vdCBzZXQKIyBD T05GSUdfVEVTVF9TVEFDS0lOSVQgaXMgbm90IHNldAojIENPTkZJR19URVNUX01FTUlOSVQg aXMgbm90IHNldAojIENPTkZJR19URVNUX0hNTSBpcyBub3Qgc2V0CiMgQ09ORklHX1RFU1Rf RlJFRV9QQUdFUyBpcyBub3Qgc2V0CiMgQ09ORklHX1RFU1RfRlBVIGlzIG5vdCBzZXQKIyBD T05GSUdfTUVNVEVTVCBpcyBub3Qgc2V0CiMgQ09ORklHX0hZUEVSVl9URVNUSU5HIGlzIG5v dCBzZXQKIyBlbmQgb2YgS2VybmVsIFRlc3RpbmcgYW5kIENvdmVyYWdlCiMgZW5kIG9mIEtl cm5lbCBoYWNraW5nCg== --------------6AC692267CC088E7165122E4-- From xen-devel-bounces@lists.xenproject.org Thu Jul 01 08:20:01 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 08:20:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148296.274060 (Exim 4.92) (envelope-from ) id 1lyrvN-0008G7-7m; Thu, 01 Jul 2021 08:19:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148296.274060; Thu, 01 Jul 2021 08:19:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyrvN-0008G0-4n; Thu, 01 Jul 2021 08:19:53 +0000 Received: by outflank-mailman (input) for mailman id 148296; Thu, 01 Jul 2021 08:19:51 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyrvL-0008Fu-AE for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 08:19:51 +0000 Received: from foss.arm.com (unknown [217.140.110.172]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTP id b867633c-3fc2-499f-8127-b45c4d8b2ed0; Thu, 01 Jul 2021 08:19:50 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BF5E9D6E; Thu, 1 Jul 2021 01:19:49 -0700 (PDT) Received: from [10.57.12.251] (unknown [10.57.12.251]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 566B93F694; Thu, 1 Jul 2021 01:19:47 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b867633c-3fc2-499f-8127-b45c4d8b2ed0 Subject: Re: [PATCH v3 10/10] arm64: Change type of hsr, cpsr, spsr_el1 to uint64_t To: Julien Grall , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Wei Liu , Tamas K Lengyel , Alexandru Isaila , Petre Pircalabu , bertrand.marquis@arm.com, wei.chen@arm.com References: <20210505074308.11016-1-michal.orzel@arm.com> <20210505074308.11016-11-michal.orzel@arm.com> From: Michal Orzel Message-ID: <9bc0a398-8920-3a95-1bb4-f32e8753972b@arm.com> Date: Thu, 1 Jul 2021 10:19:42 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Hi Julien, On 07.06.2021 15:31, Julien Grall wrote: > Hi, > > On 05/05/2021 08:43, Michal Orzel wrote: >> AArch64 registers are 64bit whereas AArch32 registers >> are 32bit or 64bit. MSR/MRS are expecting 64bit values thus >> we should get rid of helpers READ/WRITE_SYSREG32 >> in favour of using READ/WRITE_SYSREG. >> We should also use register_t type when reading sysregs >> which can correspond to uint64_t or uint32_t. >> Even though many AArch64 registers have upper 32bit reserved >> it does not mean that they can't be widen in the future. >> >> Modify type of hsr, cpsr, spsr_el1 to uint64_t. >> Previously we relied on the padding after SPSR_EL1. >> As we removed the padding, modify the union to be 64bit so we don't corrupt SPSR_FIQ. >> No need to modify the assembly code becuase the accesses were based on 64bit > > s/becuase/because/ > Will do. >> registers as there was a 32bit padding after SPSR_EL1. >> >> Remove 32bit padding in cpu_user_regs before spsr_fiq >> as it is no longer needed due to upper union being 64bit now. >> Add 64bit padding in cpu_user_regs before spsr_el1 >> because offset of spsr_el1 must be a multiple of 8. >> >> Change type of cpsr to uint64_t in the public outside interface >> "public/arch-arm.h" to allow ABI compatibility between 32bit and 64bit. >> Increment XEN_DOMCTL_INTERFACE_VERSION. >> >> Change type of cpsr to uint64_t in the public outside interface >> "public/vm_event.h" to allow ABI compatibility between 32bit and 64bit. > [...] > >> diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c >> index e7384381cc..c8f9773566 100644 >> --- a/xen/arch/arm/traps.c >> +++ b/xen/arch/arm/traps.c >> @@ -546,7 +546,7 @@ void inject_undef64_exception(struct cpu_user_regs *regs, int instr_len) >>           PSR_IRQ_MASK | PSR_DBG_MASK; >>       regs->pc = handler; >>   -    WRITE_SYSREG32(esr.bits, ESR_EL1); >> +    WRITE_SYSREG(esr.bits, ESR_EL1); >>   } >>     /* Inject an abort exception into a 64 bit guest */ >> @@ -580,7 +580,7 @@ static void inject_abt64_exception(struct cpu_user_regs *regs, >>       regs->pc = handler; >>         WRITE_SYSREG(addr, FAR_EL1); >> -    WRITE_SYSREG32(esr.bits, ESR_EL1); >> +    WRITE_SYSREG(esr.bits, ESR_EL1); >>   } >>     static void inject_dabt64_exception(struct cpu_user_regs *regs, >> @@ -717,7 +717,7 @@ struct reg_ctxt { >>       uint64_t vttbr_el2; >>   }; >>   -static const char *mode_string(uint32_t cpsr) >> +static const char *mode_string(register_t cpsr) >>   { >>       uint32_t mode; >>       static const char *mode_strings[] = { >> @@ -756,14 +756,16 @@ static void show_registers_32(const struct cpu_user_regs *regs, >>   #ifdef CONFIG_ARM_64 >>       BUG_ON( ! (regs->cpsr & PSR_MODE_BIT) ); >>       printk("PC:     %08"PRIx32"\n", regs->pc32); >> +    printk("CPSR:   %016"PRIx64" MODE:%s\n", regs->cpsr, >> +           mode_string(regs->cpsr)); > Why do you now need to duplicate this line? Can't we use PRIregister you did everywhere else a register is printed? > Indeed we do not need. It was needed at the beginning but I do not remember why. I will fix it. >>   #else >>       printk("PC:     %08"PRIx32, regs->pc); >>       if ( !guest_mode ) >>           printk(" %pS", _p(regs->pc)); >>       printk("\n"); >> -#endif >>       printk("CPSR:   %08"PRIx32" MODE:%s\n", regs->cpsr, >>              mode_string(regs->cpsr)); >> +#endif > > [...] > >> diff --git a/xen/include/asm-arm/arm64/processor.h b/xen/include/asm-arm/arm64/processor.h >> index 81dfc5e615..0e86079cbb 100644 >> --- a/xen/include/asm-arm/arm64/processor.h >> +++ b/xen/include/asm-arm/arm64/processor.h >> @@ -63,18 +63,19 @@ struct cpu_user_regs >>         /* Return address and mode */ >>       __DECL_REG(pc,           pc32);             /* ELR_EL2 */ >> -    uint32_t cpsr;                              /* SPSR_EL2 */ >> -    uint32_t hsr;                               /* ESR_EL2 */ >> +    uint64_t cpsr;                              /* SPSR_EL2 */ >> +    uint64_t hsr;                               /* ESR_EL2 */ >> + >> +    /* Offset of spsr_el1 must be a multiple of 8 */ > > I am guessing you are saying it should be 8-byte aligned, right? If so, the field before is a 64-bit value, therefore the offset should already be a multiple of 8. Did I miss anything? > Well, instead of 8 I should write 16. We have 2 bug_on checks: 1) BUILD_BUG_ON((sizeof (struct cpu_user_regs)) & 0xf); 2) BUILD_BUG_ON((offsetof(struct cpu_user_regs, spsr_el1)) & 0xf); Total size of cpu_user_regs without padding is 344 which does not pass the first check. With the padding it is 352 and it passes the first check. The offset without padding is 280 which does not pass the second check. The offset with padding is 288 which passes the second check. So I should write: "/* Offset of spsr_el1 must be a multiple of 16 bytes */" Is it ok for you? If yes, I will push v3. >> +    uint64_t pad0; >>         /* Outer guest frame only from here on... */ >>         union { >> -        uint32_t spsr_el1;       /* AArch64 */ >> +        uint64_t spsr_el1;       /* AArch64 */ >>           uint32_t spsr_svc;       /* AArch32 */ >>       }; >>   -    uint32_t pad1; /* Doubleword-align the user half of the frame */ >> - >>       /* AArch32 guests only */ >>       uint32_t spsr_fiq, spsr_irq, spsr_und, spsr_abt; >>   diff --git a/xen/include/asm-arm/hsr.h b/xen/include/asm-arm/hsr.h >> index 29d4531f40..9b91b28c48 100644 >> --- a/xen/include/asm-arm/hsr.h >> +++ b/xen/include/asm-arm/hsr.h >> @@ -16,7 +16,7 @@ enum dabt_size { >>   }; >>     union hsr { >> -    uint32_t bits; >> +    register_t bits; >>       struct { >>           unsigned long iss:25;  /* Instruction Specific Syndrome */ >>           unsigned long len:1;   /* Instruction length */ >> diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h >> index 713fd65317..64a2ca30da 100644 >> --- a/xen/include/public/arch-arm.h >> +++ b/xen/include/public/arch-arm.h >> @@ -267,10 +267,10 @@ struct vcpu_guest_core_regs >>         /* Return address and mode */ >>       __DECL_REG(pc64,         pc32);             /* ELR_EL2 */ >> -    uint32_t cpsr;                              /* SPSR_EL2 */ >> +    uint64_t cpsr;                              /* SPSR_EL2 */ >>         union { >> -        uint32_t spsr_el1;       /* AArch64 */ >> +        uint64_t spsr_el1;       /* AArch64 */ >>           uint32_t spsr_svc;       /* AArch32 */ >>       }; >>   diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h >> index 4dbf107785..d576bfabd6 100644 >> --- a/xen/include/public/domctl.h >> +++ b/xen/include/public/domctl.h >> @@ -38,7 +38,7 @@ >>   #include "hvm/save.h" >>   #include "memory.h" >>   -#define XEN_DOMCTL_INTERFACE_VERSION 0x00000013 >> +#define XEN_DOMCTL_INTERFACE_VERSION 0x00000014 >>     /* >>    * NB. xen_domctl.domain is an IN/OUT parameter for this operation. >> diff --git a/xen/include/public/vm_event.h b/xen/include/public/vm_event.h >> index 36135ba4f1..bb003d21d0 100644 >> --- a/xen/include/public/vm_event.h >> +++ b/xen/include/public/vm_event.h >> @@ -266,8 +266,7 @@ struct vm_event_regs_arm { >>       uint64_t ttbr1; >>       uint64_t ttbcr; >>       uint64_t pc; >> -    uint32_t cpsr; >> -    uint32_t _pad; >> +    uint64_t cpsr; >>   }; >>     /* >> > Cheers, Michal From xen-devel-bounces@lists.xenproject.org Thu Jul 01 08:27:12 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 08:27:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148301.274072 (Exim 4.92) (envelope-from ) id 1lys2O-0001E5-0h; Thu, 01 Jul 2021 08:27:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148301.274072; Thu, 01 Jul 2021 08:27:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lys2N-0001Dy-Sp; Thu, 01 Jul 2021 08:27:07 +0000 Received: by outflank-mailman (input) for mailman id 148301; Thu, 01 Jul 2021 08:27:06 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lys2M-0001Ds-HG for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 08:27:06 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 46bb03ec-53d9-4000-9b0d-cabd097af8e1; Thu, 01 Jul 2021 08:27:04 +0000 (UTC) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01lp2051.outbound.protection.outlook.com [104.47.2.51]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-32-NvfE6PnSNJqBlFGOdLjQIA-1; Thu, 01 Jul 2021 10:27:01 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR0401MB2335.eurprd04.prod.outlook.com (2603:10a6:800:2e::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.23; Thu, 1 Jul 2021 08:26:59 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::99d3:99cd:8adf:3eea]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::99d3:99cd:8adf:3eea%5]) with mapi id 15.20.4287.023; Thu, 1 Jul 2021 08:26:59 +0000 Received: from [10.156.60.236] (37.24.206.209) by PR3P189CA0001.EURP189.PROD.OUTLOOK.COM (2603:10a6:102:52::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.22 via Frontend Transport; Thu, 1 Jul 2021 08:26:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 46bb03ec-53d9-4000-9b0d-cabd097af8e1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1625128023; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DnD25fAzwh8fY86OSuBQt1PTJe6MeV91euHHkyaJBhU=; b=Edd1B1J2ZKvoZOdknV0WIqrn+KsJQhByDUzom+oHTlSZ+h7qgxCfkgb+bt8kvyUKu1YeT4 qSxrSPs3RoclQn1X7yyWDwhXBo2OjTcWotNm1OtfCnpiZrEVcskz+MkKZgJysZEQMXgVZu TEkAFhfO2Zba4S5bES2DN7RPYUNpmPk= X-MC-Unique: NvfE6PnSNJqBlFGOdLjQIA-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kHlvt6D4NESpSTphFp0jZEke9TjTAWNZh6TOiESjztlc+BLWg1exP0pRIoIaa4MN1a3fC31JbrwHnGveIZTudVsQnJatEAx5C5bzkDMXDQTiwVPHo/vj2e1UlNm4uoqX07YnvGlNuqkeV5EiUgzJB5lj2ZIJ2cwwCPSxYC0golZCsHIK5/BKGzfmg6uZUtw3zyip0ouwsLiuV6JeYUmoue+sQpe2MYTOYPzIUWnm9scRjv+GStIidMJ0zofb/zpi+snobZ22h1o46bf4w0p5AjFTVoR2fKGiP+QUcF0SZPMVJD0qBj1mkl1krOlFM7SuToG0+DMxQSX3wKjvUwKanQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DnD25fAzwh8fY86OSuBQt1PTJe6MeV91euHHkyaJBhU=; b=DwOdih7sGDrbbhcSwC+qWyGjDe+94UJwMHuysFwT7U3+n8r7bB8c1g2zJRR3qexx0oXGHaXOubJb7+MzONJZvhFX45DYVn71AhSMS+SZlqEBH9BASCidhXqRe+8NkXWmP5YfcPxAKKPLNLCc8nSPL0ptm1Ss45zPH2SFxY2iFp4huEy8YfI9oouuZ2SS4DbJ81nQVnlW/zziR5xccVV+6sLkOz0zl8tfNFmK7sqz6s0DVsq+5F1ZzR8o+pgTtf6HrsLuKHqoIVkPgJV2/h4QIwXI8m0gF2Jk3u4h9Lc99l8yx0n3bFua3m6Q0K6KbITqjkl7rKMKgY3egDcOkC+mqw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=suse.com; Subject: Re: [PATCH 5/9] xen: introduce assign_pages_nr To: Julien Grall Cc: Bertrand.Marquis@arm.com, Wei.Chen@arm.com, xen-devel@lists.xenproject.org, sstabellini@kernel.org, Penny Zheng References: <20210607024318.3988467-1-penny.zheng@arm.com> <20210607024318.3988467-6-penny.zheng@arm.com> <41a7389b-630c-6cf4-fa28-7d80cb79176b@suse.com> From: Jan Beulich Message-ID: Date: Thu, 1 Jul 2021 10:26:57 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [37.24.206.209] X-ClientProxiedBy: PR3P189CA0001.EURP189.PROD.OUTLOOK.COM (2603:10a6:102:52::6) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1f00bab8-97a7-47f5-ba73-08d93c69fe82 X-MS-TrafficTypeDiagnostic: VI1PR0401MB2335: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WfOupHHZe+VofinmFWHwCgwUTzh3XPRv5NiyaHjsbjTudZksD5QJ8kxmKXganpHzImctcXyMJb8F/fOD7dNKP0KxrC+FrV1vcvcWipKzuRd6hYyagChh2jpvXljwiDXMOFjDXLK9D2WPI6KAtReaAyAgvN3Scdu4lc78SLn46pjJ2RDwZwJJNEZb7r4XIP2nTsW1UCMgMkLTL8Wzxh6XAI0GyOb7+gbh3vvUUR32b5wH/EoGduZhvgxVd7oBhMEnqpDBWRDFxAmogLz31jkZ0ltI7FKcYaLmWmqsrqJe1vBF5Rxa4bI9haj8B8T3yF8uCUn4ZTOane2c7lIKptPWHaR71oCwElDJPEsGeTNG9ZuE5ASTVxvO86xsinpua/zeYfi6+8AZ3F4/Njc1sqJWDHH3NwgP565SViA1BN7X87Hw4grQNQCQpYya13oyPwPzQimCqMrZQ8ozDgcEHr/FHCjvIf54Dr5hx2tv42/Iw5x2/5mtb1jOW3b+UuCsdZz+CkYn6Cvkj7PiXDld61yoxgvx/8BXJx7ybou62jZzepXKwsoTmewtlh2edyaPn+q8z+BzoGCZIBJbJHCKLQsFh4QHO2LYeJpyVf4XavsswMsvDHRu4y5IqkS/QLItcj4Bg6epKcqCfdJLOc0a8G3euyK+x06Im1h/+VBzhKiV35jWQ5VkfIWD+HpJRJjXjug8+wI/IICwLcoYwMLrEheAHlSOPnE3XouFbVMGyi3DrOA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(396003)(346002)(39830400003)(136003)(366004)(376002)(2616005)(956004)(83380400001)(26005)(2906002)(4326008)(36756003)(16526019)(186003)(6486002)(8936002)(16576012)(66476007)(31686004)(66946007)(478600001)(66556008)(6916009)(5660300002)(31696002)(86362001)(53546011)(316002)(38100700002)(8676002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bDFkUzlBeHdlY25keUR0YlpsUTFsWUVxeG9oaWVUQjE0dmVXb3V2L29tZWlh?= =?utf-8?B?YU1LcWI3bStYSFMycTlJVXlVWmZUSk81bnoyWXZQRW1CcXA4Nk1zTFpBZmpF?= =?utf-8?B?SG5ETW8zS0pYNndDeitacWN2ODBHMHlBNkhwZ1poY2tmWGI2bmFCREwyRG1B?= =?utf-8?B?eXh0Y0RzcnFYcVYzZDYwUmhLL3d6VTdKNmdZaVlhVVhVN3k4bGlQWDBUM3Vk?= =?utf-8?B?b0E1ekpDWVZvT2p2cm1DWVBQZ3FPRStPbnRNLzd1dURrUU04Q1BoYldhMkpZ?= =?utf-8?B?bkt6NW03M2pEVzkxVkhIS2VsK1BrZ0lJeGs3ZElTZlJYMmYwZTQ4ZldEOGdu?= =?utf-8?B?dU84UTBTOTQrbi8zUDlrLzFPTFRlcUZJUWpBWXY5K2ExdHdQZ2NHRU1BSTBq?= =?utf-8?B?NlVTd21iQ3kzQXhyWndLL1E5aktJcGVTbUN5Z1ltUjV1OUdLME56akhhcGx4?= =?utf-8?B?Ky9FeTZjdnBjZjBqbXNwZEo0WGovSGZOeGxWMWNRTnZBblhyWmRGQU85Z05K?= =?utf-8?B?djN3SmQxZU14UXBjN3ZCem5zM2laV2NMVG1hTFdyRE9BczBmS0t1cjMzbHdO?= =?utf-8?B?K1BvUUJkUVJFajRvb2RPR0VsdUtLaWxkWXhxdzZiSkRKRHJBYzNmTmNBMEpH?= =?utf-8?B?b3lpcWNvSmwxc2FjeHpKRDlnZ0pCWXhHaUUzUnQ5TTI4WTRMdzFzVUtQWHlT?= =?utf-8?B?ZmFjNnVNOWNSQlFqNGRNRnBMZUhoN1p0cXFtSzcySFU5T3I3MzA3U1BDeFFJ?= =?utf-8?B?ZzN4U0JYUWRvMmtnY2tOZzdDRDFlR2xxMXdhUFhnWUt2VDh6cHRCdldHOEx1?= =?utf-8?B?dkFYT2tVeGxweHNySVBQNVlXV1BNNE93WVRJN2NZb25hc0lERDNSZGdwbjFq?= =?utf-8?B?K1BQa3FQWkJDYmZpY08vc05xdmpjU1l6bUtBb2lzY2JCbWUzOW9pQjZLSXV2?= =?utf-8?B?aXJRUGE3ZExMaUIxbDQvVVZxMGlRZ0xJTU5aZkk0SkZRSEg5VzBoR3N1ZnB5?= =?utf-8?B?R2Y4TDMyd05jcklZYU42ZnMydlRPZ0Zta2o3di9vSG9YOS9uc2tIZkRtOVNX?= =?utf-8?B?cmxCSmhnRXVKeGl6aWZhM0dyNVRnMWlrTnBvVHNHNERhNHBwWGtzRGFPeThU?= =?utf-8?B?OGduaGUzNSt1cXlnNlkySXM0cW5QdEhPU3phK2xvK0FYZy9FYXV1bWxpVTdR?= =?utf-8?B?bWR5WVUvMjFibkpMbndlN3lwYjU5dmpobXVKUHBlWUloNzZqRGp0WitoeFVI?= =?utf-8?B?Z000eEE5akQyMnZTenB3cXJ5QWZQTG8rVUY3S1ptbVRtVmw1dElKSlpRSHlh?= =?utf-8?B?ckR5YlFjb3NKWldiYXprdXozZDR3MjIxUHFxSjVDMnV6U0ZNYm9Ka2lyMTdO?= =?utf-8?B?TXkxYmViWURFTzAvcTZxUzBpdHJsR3BONkpmZWl1cVNMbDdkVTFXZjU4Z1pU?= =?utf-8?B?QWRJR1VadXBnOVdvLzRMYVJqYmF4RDVGM1p4a1Z5VGgycUdwUENVcnhqMHJ6?= =?utf-8?B?VVY2eDFMcitqUVg1eDkxYlFDZEZtQllwVEZMUGwrbzFwSEgwOVRIc2lERFZ2?= =?utf-8?B?SDluRmh1N2hGYmNEWVl5SCthem83bGlxUTNzVHNwcytoTnUwbXVZTVRXU2xz?= =?utf-8?B?WHpMajZLOUNENllHTlR6SVlheG5qMEFDakkrcHg2K3NUSE5EVzJtbTJEejhN?= =?utf-8?B?cTRZbmxOTXlNTXdRVXZleHM0aXRWWnMzWDE0TWVNZkRkYTRXSGF1azJFTU9B?= =?utf-8?Q?9Jee3QpDkmnrnFBbXujldNSxzyyvx57CSjuOniA?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1f00bab8-97a7-47f5-ba73-08d93c69fe82 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jul 2021 08:26:58.9598 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: A7FyyUfTp9ZNs0bQl2wVNyVzjmfSGIKjfg+2PHCOPQQDz7pUX6TeefwsnxdALB8KI3B6+aQ0YQLeRQ6FZhLE0Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2335 On 30.06.2021 20:29, Julien Grall wrote: > On 10/06/2021 10:49, Jan Beulich wrote: >> On 07.06.2021 04:43, Penny Zheng wrote: >>> Introduce new interface assign_pages_nr to deal with when page number is >>> not in a power-of-two, which will save the trouble each time user needs >>> to split the size in a power of 2 to use assign_pages. >> >> First of all I still don't see why in this one special case it is a >> meaningful burden to do the count-to-order conversion in the caller you >> mean to add, > > This sort of works for one caller. However, I would expect some more > user in the future (we use it for Live-Update). > >> and hence why we really need this new function (to keep it >> simple, you could even have the caller not break down to arbitrary >> power-of-2 chunks, but simply iterate over all individual [order-0] >> pages). > > The function assign_pages() will always use 1U << order (and sadly 1 << > order). So we would end up to convert the count in multiple order for > then directly converting back to a number. To me, this sounds rather > pointless... > > There are also a slight benefits to call assign_pages() a single time > during boot because it will reduce the number of time we need to > lock/unlock d->page_alloc_lock. Well, all of this is why I did add ... >> The more that I'm not happy with the chosen name, despite it >> having been suggested during v1 review. _If_ we needed two functions, >> imo they ought to be named assign_page() (dealing with a single page of >> the given order) and assign_pages(). Backporting confusion could be >> helped by altering the order of parameters, such that the compiler >> would point out that adjustments at call sites are needed. ... this. Not sure whether you not commenting on it means you agree with the proposal. >>> --- a/xen/common/page_alloc.c >>> +++ b/xen/common/page_alloc.c >>> @@ -2301,14 +2301,14 @@ void init_domheap_pages(paddr_t ps, paddr_t pe) >>> } >>> >>> >>> -int assign_pages( >>> +int assign_pages_nr( >>> struct domain *d, >>> struct page_info *pg, >>> - unsigned int order, >>> + unsigned int nr_pfns, >> >> Even leaving the naming aspect of "pfns" aside, I can't see why this >> can't be simply "nr" (of appropriate type, see next remark). >> >>> unsigned int memflags) >>> { >>> int rc = 0; >>> - unsigned long i; >>> + unsigned int i; >> >> This is not an acceptable type change, at least not as long as it's not >> justified at all in the description. While both Arm and x86 will be >> fine this way, the code here is supposed to be generic, and hence would >> better remain generally correct. > > I would like to point out the code is already not correct as we are > using 1U << order or worse 1 << order :). Indeed there are improvements (towards being consistent) to be made. But this is not an excuse to make things worse here. At least one of the two loops already properly uses 1ul; sadly that's only debugging code. And of course something like domain_tot_pages() (and the underlying field) dealing with "unsigned int" doesn't help consistency either. As it stands we're limiting ourselves to 8Tb VMs, as it seems, and for no good reason. Jan From xen-devel-bounces@lists.xenproject.org Thu Jul 01 08:47:56 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 08:47:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148306.274083 (Exim 4.92) (envelope-from ) id 1lysMI-0003Ya-Ot; Thu, 01 Jul 2021 08:47:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148306.274083; Thu, 01 Jul 2021 08:47:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lysMI-0003YT-La; Thu, 01 Jul 2021 08:47:42 +0000 Received: by outflank-mailman (input) for mailman id 148306; Thu, 01 Jul 2021 08:47:41 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lysMH-0003YJ-O5; Thu, 01 Jul 2021 08:47:41 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lysMH-0000Wv-Ic; Thu, 01 Jul 2021 08:47:41 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lysMH-0007VY-18; Thu, 01 Jul 2021 08:47:41 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lysMH-0007ku-0Z; Thu, 01 Jul 2021 08:47:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=6EbKupzEtwh9+Z75UGVdFYGztqVoirvxDAlIJS46Sfg=; b=4AICSCKoMW+P5K5j/4PAKwWS5s AxEDf2ZNZ7E856+zUHTk8eQKOYDrw6vOUtz4WDV8iCPcWNflOxls06msIBLJ/5SzhTqUOBLPhcyJp QQXG7QmntQj+KoBePuS9HVkF/nFl7iu/OoGRaZVJMafVJ19CyyoZ9jiGKn2h+Pvpag/U=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 163205: regressions - FAIL X-Osstest-Failures: ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:debian-hvm-install:fail:regression ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:debian-hvm-install:fail:regression X-Osstest-Versions-This: ovmf=bb33c27fbed6c1ed39d243bedd407e8e93a2b3a9 X-Osstest-Versions-That: ovmf=c410ad4da4b7785170d3d42a3ba190c2caac6feb From: osstest service owner Date: Thu, 01 Jul 2021 08:47:41 +0000 flight 163205 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/163205/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 162359 test-amd64-amd64-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 162359 version targeted for testing: ovmf bb33c27fbed6c1ed39d243bedd407e8e93a2b3a9 baseline version: ovmf c410ad4da4b7785170d3d42a3ba190c2caac6feb Last test of basis 162359 2021-06-04 03:40:08 Z 27 days Failing since 162368 2021-06-04 15:42:59 Z 26 days 68 attempts Testing same since 163205 2021-07-01 00:10:20 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Abner Chang Agrawal, Sachin Alexandru Elisei Anthony PERARD Ard Biesheuvel Daniel Schaefer Daoxiang Li Dov Murik DunTan gaoliming Guo Dong Hao A Wu Jian J Wang Kaaira Gupta Ken Lautner Kenneth Lautner Kun Qin Laszlo Ersek Leif Lindholm Liming Gao Loo Tung Lun Loo, Tung Lun Manickavasakam Karpagavinayagam Maurice Ma Ni, Ray Patrick Rudolph Pierre Gondois Ray Ni Rebecca Cran Rebecca Cran Sachin Agrawal Sami Mujawar Scottie Kuo Sean Brogan Sean Brogan Sumana Venur Sunil V L xueshengfeng Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-i386-xl-qemuu-ovmf-amd64 fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 3191 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Jul 01 09:02:36 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 09:02:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148312.274096 (Exim 4.92) (envelope-from ) id 1lysad-0005pf-4R; Thu, 01 Jul 2021 09:02:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148312.274096; Thu, 01 Jul 2021 09:02:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lysad-0005pY-1Q; Thu, 01 Jul 2021 09:02:31 +0000 Received: by outflank-mailman (input) for mailman id 148312; Thu, 01 Jul 2021 09:02:29 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lysab-0005pO-G9; Thu, 01 Jul 2021 09:02:29 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lysab-0000nN-8j; Thu, 01 Jul 2021 09:02:29 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lysaa-0008FY-SW; Thu, 01 Jul 2021 09:02:28 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lysaa-0000ZH-S0; Thu, 01 Jul 2021 09:02:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=BsH2SBUye/IZQ30KsaQMaNneKN8RUr72kk5cHNoagpE=; b=hI6FaJGCoGIbHVW7HNx54HDKCr zJpYEIKa624zm68YqRiTV54Duh3ZXDyBuTwMjhyiU1dyPhpcFXhF7nea1UYUpF+0tiGI1eX/kjqKE mTzW03n79bZDIsIEo2oS9+fz138wdafSyI0yrcTW/ksdop7J8vNqVXXCLN3Td7RmXa/c=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 163208: regressions - FAIL X-Osstest-Failures: libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=15073504dbb624d3f6c911e85557019d3620fdb2 X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Thu, 01 Jul 2021 09:02:28 +0000 flight 163208 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/163208/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a version targeted for testing: libvirt 15073504dbb624d3f6c911e85557019d3620fdb2 baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 356 days Failing since 151818 2020-07-11 04:18:52 Z 355 days 347 attempts Testing same since 163208 2021-07-01 04:20:07 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Andika Triwidada Andrea Bolognani Balázs Meskó Barrett Schonefeld Bastian Germann Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Bjoern Walk Boris Fiuczynski Brian Turek Bruno Haible Chris Mayo Christian Ehrhardt Christian Schoenebeck Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Dmytro Linkin Eiichi Tsukata Eric Farman Erik Skultety Fabian Affolter Fabian Freyer Fabiano Fidêncio Fangge Jin Farhan Ali Fedora Weblate Translation gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Hela Basa Helmut Grohne Ian Wienand Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen Jean-Baptiste Holcroft Jianan Gao Jim Fehlig Jin Yan Jiri Denemark John Ferlan Jonathan Watt Jonathon Jongsma Julio Faracco Ján Tomko Kashyap Chamarthy Kevin Locke Kristina Hanicova Laine Stump Laszlo Ersek Lee Yarwood Liao Pingfang Lin Ma Lin Ma Lin Ma Luke Yue Luyao Zhong Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Markus Schade Martin Kletzander Masayoshi Mizuma Matt Coleman Matt Coleman Mauro Matteo Cascella Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Muha Aliss Nathan Neal Gompa Nick Shyrokovskiy Nickys Music Group Nico Pache Nikolay Shirokovskiy Olaf Hering Olesya Gerasimenko Orion Poplawski Pany Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Ricky Tigg Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Shambarger Sebastian Mitterle SeongHyun Jo Shalini Chellathurai Saroja Shaojun Yang Shi Lei simmon Simon Chopin Simon Gaiser Stefan Bader Stefan Berger Stefan Berger Stefan Hajnoczi Szymon Scholz Thomas Huth Tim Wiederhake Tomáš Golembiovský Tomáš Janoušek Tuguoyi Ville Skyttä Wang Xin WangJian Weblate Wei Liu Wei Liu William Douglas Yalei Li <274268859@qq.com> Yalei Li Yang Hang Yanqiu Zhang Yaroslav Kargin Yi Li Yi Wang Yuri Chornoivan Zbigniew Jędrzejewski-Szmek Zheng Chuan zhenwei pi Zhenyu Zheng jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 63631 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Jul 01 09:24:44 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 09:24:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148321.274111 (Exim 4.92) (envelope-from ) id 1lysw2-0008E0-5K; Thu, 01 Jul 2021 09:24:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148321.274111; Thu, 01 Jul 2021 09:24:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lysw2-0008Dt-2K; Thu, 01 Jul 2021 09:24:38 +0000 Received: by outflank-mailman (input) for mailman id 148321; Thu, 01 Jul 2021 09:24:37 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lysw1-0008Dl-1m for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 09:24:37 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lysw0-0001Az-RV; Thu, 01 Jul 2021 09:24:36 +0000 Received: from [54.239.6.188] (helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lysw0-0004A1-LE; Thu, 01 Jul 2021 09:24:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=V9NFK2lNy9CaNbbZHIo9REyjCJIGDMiOwcehHQbUPIU=; b=jFn1yYam50B8QuzUsAepb1skS+ FvcJMKbPvhzP4wFrcqzal3j51OvEnH8fruVbz6eYAVf0TxbVMXJo9cgBt4hAgwOl4tuaYMZDUchM9 gxBqH4IvW8MFH5frsJx6zOXsH5BMEpeAo5lsnT5fWh4CIRXVLUf4FRs3m3sTmEpXGbyQ=; Subject: Re: [PATCH 5/9] xen: introduce assign_pages_nr To: Jan Beulich Cc: Bertrand.Marquis@arm.com, Wei.Chen@arm.com, xen-devel@lists.xenproject.org, sstabellini@kernel.org, Penny Zheng References: <20210607024318.3988467-1-penny.zheng@arm.com> <20210607024318.3988467-6-penny.zheng@arm.com> <41a7389b-630c-6cf4-fa28-7d80cb79176b@suse.com> From: Julien Grall Message-ID: Date: Thu, 1 Jul 2021 10:24:34 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi Jan, On 01/07/2021 09:26, Jan Beulich wrote: > On 30.06.2021 20:29, Julien Grall wrote: >> On 10/06/2021 10:49, Jan Beulich wrote: >>> On 07.06.2021 04:43, Penny Zheng wrote: >>>> Introduce new interface assign_pages_nr to deal with when page number is >>>> not in a power-of-two, which will save the trouble each time user needs >>>> to split the size in a power of 2 to use assign_pages. >>> >>> First of all I still don't see why in this one special case it is a >>> meaningful burden to do the count-to-order conversion in the caller you >>> mean to add, >> >> This sort of works for one caller. However, I would expect some more >> user in the future (we use it for Live-Update). >> >>> and hence why we really need this new function (to keep it >>> simple, you could even have the caller not break down to arbitrary >>> power-of-2 chunks, but simply iterate over all individual [order-0] >>> pages). >> >> The function assign_pages() will always use 1U << order (and sadly 1 << >> order). So we would end up to convert the count in multiple order for >> then directly converting back to a number. To me, this sounds rather >> pointless... >> >> There are also a slight benefits to call assign_pages() a single time >> during boot because it will reduce the number of time we need to >> lock/unlock d->page_alloc_lock. > > Well, all of this is why I did add ... > >>> The more that I'm not happy with the chosen name, despite it >>> having been suggested during v1 review. _If_ we needed two functions, >>> imo they ought to be named assign_page() (dealing with a single page of >>> the given order) and assign_pages(). Backporting confusion could be >>> helped by altering the order of parameters, such that the compiler >>> would point out that adjustments at call sites are needed. > > ... this. Oh, it wasn't entirely clear whether you were objecting of offering the possibility to pass a number of pages rather than an order. > Not sure whether you not commenting on it means you agree > with the proposal. Yes I am happy with your proposal. > >>>> --- a/xen/common/page_alloc.c >>>> +++ b/xen/common/page_alloc.c >>>> @@ -2301,14 +2301,14 @@ void init_domheap_pages(paddr_t ps, paddr_t pe) >>>> } >>>> >>>> >>>> -int assign_pages( >>>> +int assign_pages_nr( >>>> struct domain *d, >>>> struct page_info *pg, >>>> - unsigned int order, >>>> + unsigned int nr_pfns, >>> >>> Even leaving the naming aspect of "pfns" aside, I can't see why this >>> can't be simply "nr" (of appropriate type, see next remark). >>> >>>> unsigned int memflags) >>>> { >>>> int rc = 0; >>>> - unsigned long i; >>>> + unsigned int i; >>> >>> This is not an acceptable type change, at least not as long as it's not >>> justified at all in the description. While both Arm and x86 will be >>> fine this way, the code here is supposed to be generic, and hence would >>> better remain generally correct. >> >> I would like to point out the code is already not correct as we are >> using 1U << order or worse 1 << order :). > > Indeed there are improvements (towards being consistent) to be made. But > this is not an excuse to make things worse here. At least one of the two > loops already properly uses 1ul; sadly that's only debugging code. And > of course something like domain_tot_pages() (and the underlying field) > dealing with "unsigned int" doesn't help consistency either. As it stands > we're limiting ourselves to 8Tb VMs, as it seems, and for no good reason. I actually have a patch in my queue that hardens assign_pages(). I will aim to send it later today. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Jul 01 09:37:10 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 09:37:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148326.274122 (Exim 4.92) (envelope-from ) id 1lyt86-0001H5-CI; Thu, 01 Jul 2021 09:37:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148326.274122; Thu, 01 Jul 2021 09:37:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyt86-0001Gy-6o; Thu, 01 Jul 2021 09:37:06 +0000 Received: by outflank-mailman (input) for mailman id 148326; Thu, 01 Jul 2021 09:37:05 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyt85-0001Gs-4v for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 09:37:05 +0000 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 53b870e0-8784-4b35-93c2-ed344a96744e; Thu, 01 Jul 2021 09:37:02 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 53b870e0-8784-4b35-93c2-ed344a96744e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1625132222; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=aMEQcTsDPgXtR1BmN6Rp3x+v5tEnrdawfN3Wbzs5MIQ=; b=Gk1bK/9RyibTwUPC5Atdsg/GtMcf08F7ouNdWobZWwiMuN/2P1Qma4nn z56HbMj4kdRJY6ot4g0j3nhr6MMNpdlUqW9tVRceHOJ9I4vqHDtLCPyoK 6Fav301b/Hv5iAmLl5cn9icC50meGBrnJX/aABxHx/OZ8Hphh0a+gOjKg U=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: D7sASBiW/pQzogWFFQWPVDciAodScg54xMExaFQMaLFKTfiUAVd5vN8t7M99S4jCzohkvw2Kt3 bHMkP4dM/TFe8F7qUIcJ+RlejgCz/IlbSxbuQZuY3TU+pLnx95CvIamn9/YJLU9Zmhbp+Lf91E lKrq1jMS+JiidRfnaICSipkHYoVz73/RiuTdiu7GRf1sT5GoqILTVLzQ1bQ4I6rmY039O3iErN AvIr34ve66y9IkNUqLxvx+pgCF4nj81u3ikbi+p48Y7Tg05sqzoA0LpxVbhi8qISeQbLSdrEod LF8= X-SBRS: 5.1 X-MesageID: 47361710 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:aV8rXagP0EaouoqsIqvy4nXxn3BQXtgji2hC6mlwRA09TySZ// rOoB0+726StN9xYgBFpTnuAsW9qB/nmqKdpLNhW4tKPzOW3VdATrsSjrcKqgeIc0aVm9K1l5 0QEZSWYOeAdGSS5vyb3ODXKbgd/OU= X-IronPort-AV: E=Sophos;i="5.83,313,1616472000"; d="scan'208";a="47361710" Date: Thu, 1 Jul 2021 10:36:58 +0100 From: Anthony PERARD To: Jan Beulich CC: "xen-devel@lists.xenproject.org" , "Ian Jackson" , Wei Liu , Andrew Cooper Subject: Re: [PATCH] libxl/x86: check return value of SHADOW_OP_SET_ALLOCATION domctl Message-ID: References: <5d2bb2cf-8c0c-7300-c895-75bef0e50817@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <5d2bb2cf-8c0c-7300-c895-75bef0e50817@suse.com> On Mon, Jun 28, 2021 at 01:47:03PM +0200, Jan Beulich wrote: > The hypervisor may not have enough memory to satisfy the request. > > Requested-by: Andrew Cooper > Signed-off-by: Jan Beulich > --- > Especially if the request was mostly fulfilled, guests may have done > fine despite the failure, so there is a risk of perceived regressions > here. But not checking the error at all was certainly wrong. > > --- a/tools/libs/light/libxl_x86.c > +++ b/tools/libs/light/libxl_x86.c > @@ -531,8 +531,18 @@ int libxl__arch_domain_create(libxl__gc > if (d_config->b_info.type != LIBXL_DOMAIN_TYPE_PV) { > unsigned long shadow = DIV_ROUNDUP(d_config->b_info.shadow_memkb, > 1024); > - xc_shadow_control(ctx->xch, domid, XEN_DOMCTL_SHADOW_OP_SET_ALLOCATION, > - NULL, 0, &shadow, 0, NULL); > + int rc = xc_shadow_control(ctx->xch, domid, Could you use 'r' instead of 'rc' ? The later is reserved for libxl error codes while the former is for system and libxc calls. > + XEN_DOMCTL_SHADOW_OP_SET_ALLOCATION, > + NULL, 0, &shadow, 0, NULL); > + > + if (rc) { xc_shadow_control seems to return "domctl.u.shadow_op.pages" in some cases, are all non-zero return value errors? > + LOGED(ERROR, domid, > + "Failed to set %s allocation: %d (errno:%d)\n", LOGED already prints prints the meaning of the "errno" value, so we don't need to log it. > + libxl_defbool_val(d_config->c_info.hap) ? "HAP" : "shadow", > + rc, errno); Is the return value of xc_shadow_control() actually useful when errno is already logged? Thanks, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Thu Jul 01 09:53:38 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 09:53:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148332.274133 (Exim 4.92) (envelope-from ) id 1lytNs-0003cD-M6; Thu, 01 Jul 2021 09:53:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148332.274133; Thu, 01 Jul 2021 09:53:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lytNs-0003c6-HV; Thu, 01 Jul 2021 09:53:24 +0000 Received: by outflank-mailman (input) for mailman id 148332; Thu, 01 Jul 2021 09:53:23 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lytNr-0003c0-Nc for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 09:53:23 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id bd37892f-0c37-4f5e-be58-2abef2c5c548; Thu, 01 Jul 2021 09:53:22 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bd37892f-0c37-4f5e-be58-2abef2c5c548 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1625133202; h=from:to:cc:subject:date:message-id:content-id: content-transfer-encoding:mime-version; bh=8wf6RvJkTbeOhCP6B745KER9GHhknPb8hrfHAWHomBk=; b=C+zOOcJCXky0bBLkmrOGr35WGV1/ozr0V02Yzck4O4V0L/KZjy7hojRY pK04p+DDUs0tN6L9vDJgOivjO0mqxo/5jyd9Xd/4XsK/62WLsVaCGIerP 5mDsMHB4aqaxiJFZUuaiitXSqA0UF18hRt3gzl0o5RgDagX3neLRiTjLv 8=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: u/C5ZsslG05/7yqjD58kdugYC8n7y+Br0abBWktXlDHVxDaU1tPiLfZFDQqWjaOC49Em8zOJ4X +qVcXW/FoVpmCW2V0pP/+PGe1CQcaLOclXlHx4dAF+DOcSstneXWUU7Cf10wRUc1oBsyuLR1DI p44HQ2AdtK1jkeVq2nXsFrtS7SBajPi4lZj/HW5xHz9WersN3mV37NUzoFV2Tx/osQvpCdqHJs 6yl1ta4tIZ1Nl3liIVg24UxOqi2jYKezkSA4PW9TDibgTcruvSy49wio+9qSXMSZvASvq7hce6 Fgc= X-SBRS: 5.1 X-MesageID: 47354412 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:H8ZTYq2o64qVtneerPQc4AqjBTZyeYIsimQD101hICG9Lfb3qy n+ppsmPEHP5Ar5AEtQ4+xpOMG7MBfhHQYc2/heAV7QZniahILOFvAi0WKC+UyuJ8SazI9gPM hbAtBD4bHLfDpHZKXBkUmF+rQbsaK6GcmT7I+0pRoMPGJXgslbnl1E422gYypLrXx9dOME/e 2nl6x6TlSbCBEqR/X+IkNAc/nIptXNmp6jSwUBHQQb5A6Hii7twKLmEjCDty1uEA9n8PMHyy zoggb57qKsv7WQ0RnHzVLe6JxQhZ/I1sZDPsqRkcIYQw+cyDpAJb4RHoFqjgpF591H22xa1u UkZC1QZvib3kmhOl1dZyGdgzUIngxesEMKgmXo/UcL6faJOw7STfAx2L6xOyGpmnYIrZVy1r lG0HmesIcSBRTcnD7l79yNTB1ykFGoyEBS2tL6HxRkIPUjgZJq3MUiFXluYd899ePBmfQaOf grCNuZ6OddcFucYXyctm5zwMa0VnB2GhudWEANtsGczjATxRlCvgYl7d1amm1F+IM2SpFC6e iBOqN0lKtWRstTaa5mHu8OTca+F2SISxPRN2CZJ0jhCcg8SjjwQl7MkcMIDcSRCdA1JbcJ6e b8uWJjxBkPkhjVeL6zNbVwg2XwqUuGLETQ9v0= X-IronPort-AV: E=Sophos;i="5.83,313,1616472000"; d="scan'208";a="47354412" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CnvPwk6hH/JdnMxYA1wt8MhYMQxe7ihTp5c8omXrXOMPpHa9ViWaSXanPoK+zDhKmWCSxeqQkRWhMIsM71IlOwanSlnW4TXPvQr0LudtUuav+2zKXDdOWBUSS0okG5Epm6OskBWRVTr33DGn4EBLYpyYS6T4AsA918zb7EsxQf6NFuWxgE6GMCsJHz9neSKhfL/LXtoZOmEQB8QIpxPePO751JoAmfs0qkExrojcIwPdSKA/9wMF3mnxxh23WI090B1c2hIgOo7/bT/EPX/eINUoq2zKgu+niVAslf1S644nbeOTfrGiNOTAz27FtF+lIc+qtdh+slLyJVtN5phX8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8wf6RvJkTbeOhCP6B745KER9GHhknPb8hrfHAWHomBk=; b=K2OvDO5Y1yq+BRjJ/GypNSA1LPywxShqxW30IeQYmcPQ5v7f6/BvvYukmAvdWuH7mDZbV4c6RsUS6S2PR0Cjc6U2l1Qg6q6pT+PUuP6EO/L4wR2aKDNAomI16jKxo99ALgujs7mOCfBebw+wLY1kSIphFkH3ESMpC/Bq+WmnS7cRsGUm5kFRS3dmoR3HRckSC6GIR2WwMOdu8LisT3xx5RS9caimdKQIWyH/QGEZJZfDfTQZsRUaofIHI+ZBB5hLFSDjyzUZk8budHrOins5O0REfDHSd1g/FtKLkgLtA4Ngyf62rw5UdCP3/ZQs1NjbaeH/xsK5jq8IoWRKieAERQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8wf6RvJkTbeOhCP6B745KER9GHhknPb8hrfHAWHomBk=; b=P9kXoGCtLhdSub4W3+B7Yl9HOkuAkrep8LzC9BGyiVHvRl48F5tzVJ47kbXDbQF5UbK02Sw3zG4D79PS+gP4jgY2c5hKHrMYc/4783/1h26OwN1Kdrg1mHNdmJwJkzU2lEXwl968CGVjNeOIxYI1MnQ1VUhRiMQXMsekKrn7nsg= From: George Dunlap To: xen-devel CC: Ashley Weltz Subject: JULY COMMUNITY CALL POSTPONED AND RESCHEDULED Thread-Topic: JULY COMMUNITY CALL POSTPONED AND RESCHEDULED Thread-Index: AQHXbl7rLw5NXgB2c0+Ak/Tp5fP82g== Date: Thu, 1 Jul 2021 09:53:19 +0000 Message-ID: <3DF8B46A-308E-4992-A975-7F2E1737AD64@citrix.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3654.60.0.2.21) x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 646c6f49-454a-432a-aae9-08d93c760e3b x-ms-traffictypediagnostic: PH0PR03MB6300: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: puG0lVI4rdZ3DRW+89T3Vhxv8QcYhNad3MZ72gC50KOaweiwEHCAsaFLaztLmYsywFioLAfX5L2CRDHJT+dmIzbH5Wnzc5T9G1UUzy3/NYye/sLzVB0eEjZwQ6DX1ko4MIGkfO/bqdJSMS+i/GeMJTab9NngCQkCUXRhqy9FK4Jce9HyI5DdEbtO4vXuOBQp+zwMiLyrY8zMvVtrz1nkKtK1RNeKFpOWLbTpGDa5cDpfdRVjfkKjYo33RIWpjQey3q4PAa1oTnuQG8N5UiE3tEbwbm0Fmy7mjTx5ncZQHHScpRVM02N8pMBpCDHov09mzZbffNrk0UG2eTTCJ2GeDdFcYjTkCm0n1lii/Wnv5PtthMtOPJxP/xmZViS87X6JsH8zY7O+McDjTRDluA4qVPQOFO5fT08RaoOErES9bGk5yXH07eyvghLIBQrKyxJxYvWL2HZgOFMMqRDJ5BIpc6ZaZTp1b3pPDONzz5S2ivY9Gm+vuyw3BmkwWFTAk4eXBqhaGjy4MsrkzfKsWNKKTey1Czcm7AONj4fcUD3zqbbs1cos2lCetHwIYU/acWyruOOTLUBoKo6it4lP7bRJ+HxM3DFN20fcSeac/phQMXwk9KPTa5Tt/W6KcakJihebWLNHGIg41jQrvPLFORO6kkKHXfMnWPI/iuY0Ph7yP+jHfgbcR0igWWvvv01r72yvE3pspzZ1FYWUWtZ+mqEYrg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR03MB5669.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(346002)(376002)(396003)(39860400002)(366004)(64756008)(66946007)(6486002)(6506007)(66556008)(2616005)(2906002)(66446008)(66476007)(36756003)(8676002)(5660300002)(478600001)(26005)(6916009)(91956017)(6512007)(186003)(86362001)(71200400001)(33656002)(8936002)(76116006)(316002)(4326008)(122000001)(38100700002)(83380400001)(4744005)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?NVBFeDRERWNlZHBMR014WTdRSjVUTjkrSnh5cEc5QmlLWXpUa2JCRDN6dW5W?= =?utf-8?B?QjUzMlllZnNub3ZkTTd2dWE3aTlnRHdqdXc4eHlUY1g4YXRra2JZdFZqWkZr?= =?utf-8?B?NEdZOUdPWmFaYms1QkttblhPaFVIV3Vvc2NTRzRiV2wvdWpIVm9NOS9CV28z?= =?utf-8?B?R05Rb3RNa2hDWURGa3BWRUFmQmRtK0l1ZjltRGIzM2FuMlpYZzNSSXY1ckhH?= =?utf-8?B?cWpnWEhPcUE0ZDk1UDhHOWVxK3Z6dDRTbTJ2MXZCNDdIU0FRa3RIWnRUSkdh?= =?utf-8?B?aEJzcTliN0crUG5nMVQrdDVFTkRyNzJNeW5INkdaZXZXc0QvQnVIS2VxUml5?= =?utf-8?B?SWo1WjFpMmZaYXFsWTBqLzNWMjVPaVFBSXo2V3VuUytpa1gzMExiN01YYlJh?= =?utf-8?B?eGsxYUhBeUFXV2drSW8vSEVPbk9kYzVnSjJ4Nm5USjFTWjFwOURFWlRDSFl4?= =?utf-8?B?NHM3U3VJQ1liV3BwdWlaOTJ2dUZHSjdFWjhZWVExdzkxeTB4Y3pSZzk4TlBx?= =?utf-8?B?RTVuUG5jeis2TnErYWtLS29MaFc3bWErbWNxa3JOK2VRZGgvQ3E3TWxEcS9p?= =?utf-8?B?KzlaMEY2NkhFRmltbm9ZZ0ppSTExWU9EeVdDYzI0b3RRVjhQdnlaYitlVkRP?= =?utf-8?B?RHpDalM2ajc0czJuUkpnSnNkVndYRXNZcU5WWDhYL1RrZjBOVW5qTVhDVEhy?= =?utf-8?B?MHBrb3dTQ0VuUkdqZUFQaVNEbjNMQWJTOHhNZkZKNC96cmRjSWxGV1UvSXli?= =?utf-8?B?Wm5qekVrY2RURkRUK2x1SzFMM1JCNVFoRDV3ZDh3NGkxWGZEZnhaM1BPWHBl?= =?utf-8?B?b2FwdmVOa2JCRmI3MFM4a1VnVGd2NkwwdEdILzc1Umt2S2FQS0hHbDExLzcx?= =?utf-8?B?b3hOQXBlMU0yUUtramFQbDhycEN3Vm9aZjJlS2Z1OGJVYkMzZG5waUdPOGp5?= =?utf-8?B?Zm81Uno3S3JRbTgvRjNrWnpieG9uZ051dEZ5eHFSeTQyMDNMMXdId0djU0tC?= =?utf-8?B?UUZxekthRVdqQm1SWWM0RWJMMGo2YkswY25XbURYN3JvZng1WjlkM0ZOUDRo?= =?utf-8?B?ZTUvTWZFK3BEYUxCbExOM20rVUhseVkyckhzY1c1WlNqazJERm1pbkxGRkxy?= =?utf-8?B?ZWswcll6MXdjNVZyTWNwSjhVN3h0R2xKelhxZnZGSkhhN1JJam9WaUdOWVBN?= =?utf-8?B?ZjdQNkR3c0VXMHh3MEphYVk1OEFxYjF2VkZ4K25JU2REVmZ3YkpsRjVYQWcx?= =?utf-8?B?eW1LVkdvNzJ6R1RHUVlTTVZFcm9MZExtU3hZd0o0Q0VVSC9takFIZVYvdkNw?= =?utf-8?B?QThvUnJBYnZLMzU3U09iUkV5VFhqTGsrS0hZTldNNnZIWVlzaUlCQXhqN3p4?= =?utf-8?B?Zll2Ly9uMlhab0M1bXVhK3dieFpOcklBZS82Yk81SHRqMzFLOWFNSXZzZVVj?= =?utf-8?B?U0JSRkhuS3pVTHBHTjhJUHhZdlNzMFhZR1dNb1B2OTJybEJtOExGcUsyL1FM?= =?utf-8?B?TGRySVVkc3pXbGUzVHh3YjlDNWpvN25IQkpudUtqSDFWeE80V29WNXlNUkxq?= =?utf-8?B?Mm8xdUwxbDFzQ2h2anFPT2hhUmNJWDdtS25CQkdDUDBkUUNLSWhIam1tRGZL?= =?utf-8?B?Q1l5N29NOVZENTZxbGVKT1krRkJWOXMrU1IxdHlDUXRqbG1VbWNSMVJzNkpC?= =?utf-8?B?L2REcDlrTmNKT1F4cXF3cGZWc1pIcVo2TGtwL0tpYkFad2liWkF4c0tUVHRP?= =?utf-8?Q?ldWZT+Qjcp5GOrp7+Xx5iHsWyflFQ1luZJvKVoK?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB5669.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 646c6f49-454a-432a-aae9-08d93c760e3b X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Jul 2021 09:53:19.1627 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: nt9IYMluKzasGroa65jAR3O6fiuTECanmEnPOGAEWHB3FTuB7Bxj9yRg1syPxiYoDUlDCtmfYbn0s4D1qZoe6cy2PF5flmD9uDEnGJWU7Zo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB6300 X-OriginatorOrg: citrix.com U29ycnkgZXZlcnlvbmUgZm9yIG5vdCBpbmNsdWRpbmcgeGVuLWRldmVsIGluIHRoaXMgYW5ub3Vu Y2VtZW50IGVhcmxpZXIuDQoNClRIRVJFIFdJTEwgQkUgTk8gQ09NTVVOSVRZIENBTEwgVE9EQVku ICBXZSB3aWxsIGhhdmUgdGhlIGNhbGwgbmV4dCB3ZWVrLCBhdCBhIHRpbWUgdG8gYmUgYW5ub3Vu Y2VkIGxhdGVyIHRvZGF5Lg0KDQpXZSBhcmUgaW4gdGhlIHByb2Nlc3Mgb2YgZmluZGluZyBhIG5l dyB0aW1lIChhIHN1cnZleSB3YXMgYWxyZWFkeSBzZW50IG91dCB0byBwZW9wbGUgb24gdGhlIGNv bW11bml0eSBjYWxsIHNpZ24tdXAgbGlzdCksIHNvIHdlIGRlY2lkZWQgdG8gcHVzaCB0aGUgY2Fs bCBiYWNrIG9uZSB3ZWVrLiAgSSBzZW50IGFuIGVtYWlsIHRvIHRoZSBjb21tdW5pdHkgY2FsbCBz aWduLXVwIGxpc3QgbGFzdCB3ZWVrLCBidXQgZm9yZ290IHRvIGNjIHhlbi1kZXZlbDsgc29ycnkg YWJvdXQgdGhhdC4NCg0KSeKAmWxsIHNlbmQgYW4gYW5ub3VuY2VtZW50IGZvciB0aGUgbmV3IHRp bWUsIGFuZCBhIGxpbmsgdG8gdGhlIGFnZW5kYSwgbGF0ZXIgdG9kYXkuDQoNClBlYWNlLA0KIC1H ZW9yZ2U= From xen-devel-bounces@lists.xenproject.org Thu Jul 01 09:56:44 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 09:56:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148337.274143 (Exim 4.92) (envelope-from ) id 1lytR6-0004Gb-4i; Thu, 01 Jul 2021 09:56:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148337.274143; Thu, 01 Jul 2021 09:56:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lytR6-0004GU-1Z; Thu, 01 Jul 2021 09:56:44 +0000 Received: by outflank-mailman (input) for mailman id 148337; Thu, 01 Jul 2021 09:56:42 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lytR4-0004GK-GV for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 09:56:42 +0000 Received: from mo4-p00-ob.smtp.rzone.de (unknown [81.169.146.216]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id cda51e26-ea01-4063-ae86-dd01630ea630; Thu, 01 Jul 2021 09:56:40 +0000 (UTC) Received: from sender by smtp.strato.de (RZmta 47.28.1 AUTH) with ESMTPSA id 30791cx619ud5Mb (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Thu, 1 Jul 2021 11:56:39 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cda51e26-ea01-4063-ae86-dd01630ea630 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1625133399; s=strato-dkim-0002; d=aepfle.de; h=Message-Id:Date:Subject:Cc:To:From:Cc:Date:From:Subject:Sender; bh=mmOmmVOJVCc+eRhOPZx2VydYF30S3wGYCPZsoZJsYV4=; b=dE6LowpAE0s4/lMlnv5dd2IMkbK1L0V6kqIfDmXjAORSb5CrEGED/BmO+Vq1kSFPtz bsvJiQnPRysqb7szkH5DzQO4aCZjc93Hqi3ck4pwD/cF1MaZTh5BAm20WC7x3nBW4r5c Ybh1hHcRLbBpdwUHg5ZuwY5ba/5irsTf45ygIhtyhk3xwzu3RMdcjEhxbJS1+l2D/tOB rwZTd5Xeh6qj2GAnEv+2z/m0M59U/fVfYUW5FN8kpaCccRhZ4tr1vEQ1ZBMSwJzvdG1a akAvKwpQLWkmo/hg1KKR+FED3ui9hvYLZ7QHO84pTKSkG95W/ipARKJsSbC6C+1Z94i7 bVHg== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QXkBR9MXjAuzpIG0mv9coXAg5lqlz7EsstGyDcxK3Mbajr+SQKopp1Cb0CyyaZQQ==" X-RZG-CLASS-ID: mo00 From: Olaf Hering To: xen-devel@lists.xenproject.org Cc: Olaf Hering Subject: [PATCH v20210701 00/40] leftover from 2020 Date: Thu, 1 Jul 2021 11:55:55 +0200 Message-Id: <20210701095635.15648-1-olaf@aepfle.de> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Various unreviewed changes, rebase to f95b7b37cf. Olaf Hering (40): hotplug/Linux: fix starting of xenstored with restarting systemd tools: add API to work with sevaral bits at once xl: fix description of migrate --debug tools: use integer division in convert-legacy-stream tools: handle libxl__physmap_info.name properly in convert-legacy-stream tools: fix Python3.4 TypeError in format string tools: create libxensaverestore MAINTAINERS: add myself as saverestore maintainer tools: add readv_exact to libxenctrl tools: add xc_is_known_page_type to libxenctrl tools: use sr_is_known_page_type tools: unify type checking for data pfns in migration stream tools: unify type checking for data pfns in migration stream tools: show migration transfer rate in send_dirty_pages tools: prepare to allocate saverestore arrays once tools: save: move mfns array tools: save: move types array tools: save: move errors array tools: save: move iov array tools: save: move rec_pfns array tools: save: move guest_data array tools: save: move local_pages array tools: restore: move types array tools: restore: move mfns array tools: restore: move map_errs array tools: restore: move mfns array in populate_pfns tools: restore: move pfns array in populate_pfns tools: restore: split record processing tools: restore: split handle_page_data tools: restore: write data directly into guest tools: recognize LIBXL_API_VERSION for 4.16 tools: adjust libxl_domain_suspend to receive a struct props tools: change struct precopy_stats to precopy_stats_t tools: add callback to libxl for precopy_policy and precopy_stats_t tools: add --max_iters to libxl_domain_suspend tools: add --min_remaining to libxl_domain_suspend tools: add --abort_if_busy to libxl_domain_suspend tools: add API for expandable bitmaps tools: use xg_sr_bitmap for populated_pfns tools/libxc: use superpages during restore of HVM guest .gitignore | 2 + MAINTAINERS | 6 + docs/man/xl.1.pod.in | 22 +- tools/hotplug/Linux/init.d/xencommons.in | 2 +- tools/hotplug/Linux/launch-xenstore.in | 40 +- .../Linux/systemd/xenstored.service.in | 2 +- tools/include/libxl.h | 32 +- tools/include/xenguest.h | 186 ----- tools/include/xensaverestore.h | 207 ++++++ tools/libs/Makefile | 1 + tools/libs/ctrl/xc_bitops.h | 28 + tools/libs/ctrl/xc_private.c | 57 +- tools/libs/ctrl/xc_private.h | 1 + tools/libs/guest/Makefile | 11 - tools/libs/guest/xg_dom_x86.c | 5 - tools/libs/guest/xg_offline_page.c | 1 - tools/libs/guest/xg_private.h | 5 + tools/libs/guest/xg_sr_restore_x86_hvm.c | 274 -------- tools/libs/light/Makefile | 4 +- tools/libs/light/libxl_dom_save.c | 24 + tools/libs/light/libxl_domain.c | 10 +- tools/libs/light/libxl_internal.h | 7 + tools/libs/light/libxl_save_helper.c | 1 + tools/libs/light/libxl_save_msgs_gen.pl | 5 +- tools/libs/light/libxl_stream_write.c | 9 +- tools/libs/light/libxl_types.idl | 1 + tools/libs/saverestore/Makefile | 38 ++ .../xg_sr_common.c => saverestore/common.c} | 75 +- .../xg_sr_common.h => saverestore/common.h} | 271 +++++++- .../common_x86.c} | 2 +- .../common_x86.h} | 2 +- .../common_x86_pv.c} | 2 +- .../common_x86_pv.h} | 2 +- .../nomigrate.c} | 2 +- .../xg_sr_restore.c => saverestore/restore.c} | 617 +++++++++-------- tools/libs/saverestore/restore_x86_hvm.c | 645 ++++++++++++++++++ .../restore_x86_pv.c} | 70 +- .../xg_sr_save.c => saverestore/save.c} | 165 ++--- .../save_restore.h} | 2 - .../save_x86_hvm.c} | 7 +- .../save_x86_pv.c} | 33 +- .../stream_format.h} | 0 tools/libs/uselibs.mk | 4 +- tools/ocaml/libs/xl/xenlight_stubs.c | 3 +- tools/python/scripts/convert-legacy-stream | 24 +- tools/xl/xl_cmdtable.c | 26 +- tools/xl/xl_migrate.c | 54 +- tools/xl/xl_saverestore.c | 3 +- 48 files changed, 2037 insertions(+), 953 deletions(-) create mode 100644 tools/include/xensaverestore.h delete mode 100644 tools/libs/guest/xg_sr_restore_x86_hvm.c create mode 100644 tools/libs/saverestore/Makefile rename tools/libs/{guest/xg_sr_common.c => saverestore/common.c} (72%) rename tools/libs/{guest/xg_sr_common.h => saverestore/common.h} (67%) rename tools/libs/{guest/xg_sr_common_x86.c => saverestore/common_x86.c} (99%) rename tools/libs/{guest/xg_sr_common_x86.h => saverestore/common_x86.h} (98%) rename tools/libs/{guest/xg_sr_common_x86_pv.c => saverestore/common_x86_pv.c} (99%) rename tools/libs/{guest/xg_sr_common_x86_pv.h => saverestore/common_x86_pv.h} (98%) rename tools/libs/{guest/xg_nomigrate.c => saverestore/nomigrate.c} (98%) rename tools/libs/{guest/xg_sr_restore.c => saverestore/restore.c} (66%) create mode 100644 tools/libs/saverestore/restore_x86_hvm.c rename tools/libs/{guest/xg_sr_restore_x86_pv.c => saverestore/restore_x86_pv.c} (94%) rename tools/libs/{guest/xg_sr_save.c => saverestore/save.c} (88%) rename tools/libs/{guest/xg_save_restore.h => saverestore/save_restore.h} (98%) rename tools/libs/{guest/xg_sr_save_x86_hvm.c => saverestore/save_x86_hvm.c} (96%) rename tools/libs/{guest/xg_sr_save_x86_pv.c => saverestore/save_x86_pv.c} (97%) rename tools/libs/{guest/xg_sr_stream_format.h => saverestore/stream_format.h} (100%) From xen-devel-bounces@lists.xenproject.org Thu Jul 01 09:56:47 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 09:56:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148338.274154 (Exim 4.92) (envelope-from ) id 1lytR9-0004YZ-Gu; Thu, 01 Jul 2021 09:56:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148338.274154; Thu, 01 Jul 2021 09:56:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lytR9-0004YQ-DP; Thu, 01 Jul 2021 09:56:47 +0000 Received: by outflank-mailman (input) for mailman id 148338; Thu, 01 Jul 2021 09:56:45 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lytR7-0004XT-T6 for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 09:56:45 +0000 Received: from mo4-p01-ob.smtp.rzone.de (unknown [85.215.255.50]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 94438a9c-bd82-4226-aad3-be2c35a408c7; Thu, 01 Jul 2021 09:56:45 +0000 (UTC) Received: from sender by smtp.strato.de (RZmta 47.28.1 AUTH) with ESMTPSA id 30791cx619ue5Md (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Thu, 1 Jul 2021 11:56:40 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 94438a9c-bd82-4226-aad3-be2c35a408c7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1625133400; s=strato-dkim-0002; d=aepfle.de; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Cc:Date: From:Subject:Sender; bh=DqV9Bza4xh4lmngXwj1J3LSRM3kpJQsPapKBO4Z/YvI=; b=qRRlDNFKwfDufQp5NUYrSrgtwMMfk6ATaFHjiH2amRD/NqCWF8dxxGWit6C8hcwGvg PY3/9ws3knYQO0b3lWTEK/A+csdqAk7ICvmTYNqADEesAA13Ryhnwo+BmJNb5LIzXrPz EKYRdzSJjdYT8BsvqMfD9JPD3+lLP589pKAvCUuKDpgmSUV/JW2P64aAeLvixE6CYdYi U7sPBkFcM9v9OjhSZXzDnc7W70rQIhHTfBrmSVJtviidhqsSSP6FQOLraTibzvWbejf1 Lib5d04DrwkNqIB50v5EgtPSt8d69WXfc30eQ2ehB57NnrZlLuZxPxnveDllsQDjy2sY NMbg== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QXkBR9MXjAuzpIG0mv9coXAg5lqlz7EsstGyDcxK3Mbajr+SQKopp1Cb0CyyaZQQ==" X-RZG-CLASS-ID: mo00 From: Olaf Hering To: xen-devel@lists.xenproject.org Cc: Olaf Hering , Ian Jackson , Wei Liu , Juergen Gross Subject: [PATCH v20210701 02/40] tools: add API to work with sevaral bits at once Date: Thu, 1 Jul 2021 11:55:57 +0200 Message-Id: <20210701095635.15648-3-olaf@aepfle.de> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210701095635.15648-1-olaf@aepfle.de> References: <20210701095635.15648-1-olaf@aepfle.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Introduce new API to test if a fixed number of bits is clear or set, and clear or set them all at once. The caller has to make sure the input bitnumber is a multiple of BITS_PER_LONG. This API avoids the loop over each bit in a known range just to see if all of them are either clear or set. Signed-off-by: Olaf Hering v02: - change return type from int to bool (jgross) --- tools/libs/ctrl/xc_bitops.h | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+) diff --git a/tools/libs/ctrl/xc_bitops.h b/tools/libs/ctrl/xc_bitops.h index f0bac4a071..8e8c6efb45 100644 --- a/tools/libs/ctrl/xc_bitops.h +++ b/tools/libs/ctrl/xc_bitops.h @@ -3,6 +3,7 @@ /* bitmap operations for single threaded access */ +#include #include #include @@ -77,4 +78,31 @@ static inline void bitmap_or(void *_dst, const void *_other, dst[i] |= other[i]; } +static inline bool test_bit_long_set(unsigned long nr_base, const void *_addr) +{ + const unsigned long *addr = _addr; + unsigned long val = addr[nr_base / BITS_PER_LONG]; + + return val == ~0; +} + +static inline bool test_bit_long_clear(unsigned long nr_base, const void *_addr) +{ + const unsigned long *addr = _addr; + unsigned long val = addr[nr_base / BITS_PER_LONG]; + + return val == 0; +} + +static inline void clear_bit_long(unsigned long nr_base, void *_addr) +{ + unsigned long *addr = _addr; + addr[nr_base / BITS_PER_LONG] = 0; +} + +static inline void set_bit_long(unsigned long nr_base, void *_addr) +{ + unsigned long *addr = _addr; + addr[nr_base / BITS_PER_LONG] = ~0; +} #endif /* XC_BITOPS_H */ From xen-devel-bounces@lists.xenproject.org Thu Jul 01 09:56:50 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 09:56:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148339.274166 (Exim 4.92) (envelope-from ) id 1lytRC-0004sG-Qj; Thu, 01 Jul 2021 09:56:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148339.274166; Thu, 01 Jul 2021 09:56:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lytRC-0004s5-MR; Thu, 01 Jul 2021 09:56:50 +0000 Received: by outflank-mailman (input) for mailman id 148339; Thu, 01 Jul 2021 09:56:49 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lytRB-0004r4-QC for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 09:56:49 +0000 Received: from mo4-p02-ob.smtp.rzone.de (unknown [85.215.255.83]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id d52abfb2-6848-46b5-b4ea-10d4ede7358d; Thu, 01 Jul 2021 09:56:48 +0000 (UTC) Received: from sender by smtp.strato.de (RZmta 47.28.1 AUTH) with ESMTPSA id 30791cx619uh5Mo (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Thu, 1 Jul 2021 11:56:43 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d52abfb2-6848-46b5-b4ea-10d4ede7358d DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1625133403; s=strato-dkim-0002; d=aepfle.de; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Cc:Date: From:Subject:Sender; bh=SltAKnmIMSX68HfayYsjFaeam+P2Dd+kaJUi7g+KP5U=; b=Ac4RxG/KTWjphnMXvXeZe9Akw4GLKnElRV50Qy3tRHtyTCIYoYa4Zj4bN5ByvSjvSy bw21oNTVatYIeDyRIlVEzlXbUChDoKdsc9vk8hSCxguIR/l6q7SgLR9P09GAGOBFo4vI j6nKrYiBc+ORocgKs7brvWg92wxRNwc8TMHrPaFIV5Q3ylbqqfN2oZc/pa3PGhFyOG5X bQTbVug0Qb3oCkcLQPbTqXSkF7EFmkAeKbuP2l4C13yXi5h4zxLBApYT6PCEkflFBs/g RQDw9XHuyoBFp5lu7vhTdIKoqFicS2utbnCiMpvgRaLDJbESEVru0jZYgc1/ajfNzQbB 26dQ== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QXkBR9MXjAuzpIG0mv9coXAg5lqlz7EsstGyDcxK3Mbajr+SQKopp1Cb0CyyaZQQ==" X-RZG-CLASS-ID: mo00 From: Olaf Hering To: xen-devel@lists.xenproject.org Cc: Olaf Hering , Ian Jackson , Wei Liu , Juergen Gross Subject: [PATCH v20210701 09/40] tools: add readv_exact to libxenctrl Date: Thu, 1 Jul 2021 11:56:04 +0200 Message-Id: <20210701095635.15648-10-olaf@aepfle.de> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210701095635.15648-1-olaf@aepfle.de> References: <20210701095635.15648-1-olaf@aepfle.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Read a batch of iovec's. Short reads are the common case, finish the trailing iov with read_exact. Signed-off-by: Olaf Hering v2: - add comment to short-read handling --- tools/libs/ctrl/xc_private.c | 57 +++++++++++++++++++++++++++++++++++- tools/libs/ctrl/xc_private.h | 1 + 2 files changed, 57 insertions(+), 1 deletion(-) diff --git a/tools/libs/ctrl/xc_private.c b/tools/libs/ctrl/xc_private.c index c0422662f0..bab9a31a70 100644 --- a/tools/libs/ctrl/xc_private.c +++ b/tools/libs/ctrl/xc_private.c @@ -698,8 +698,23 @@ int write_exact(int fd, const void *data, size_t size) #if defined(__MINIOS__) /* - * MiniOS's libc doesn't know about writev(). Implement it as multiple write()s. + * MiniOS's libc doesn't know about readv/writev(). + * Implement it as multiple read/write()s. */ +int readv_exact(int fd, const struct iovec *iov, int iovcnt) +{ + int rc, i; + + for ( i = 0; i < iovcnt; ++i ) + { + rc = read_exact(fd, iov[i].iov_base, iov[i].iov_len); + if ( rc ) + return rc; + } + + return 0; +} + int writev_exact(int fd, const struct iovec *iov, int iovcnt) { int rc, i; @@ -714,6 +729,46 @@ int writev_exact(int fd, const struct iovec *iov, int iovcnt) return 0; } #else +int readv_exact(int fd, const struct iovec *iov, int iovcnt) +{ + int rc = 0, idx = 0; + ssize_t len; + + while ( idx < iovcnt ) + { + len = readv(fd, &iov[idx], min(iovcnt - idx, IOV_MAX)); + if ( len == -1 && errno == EINTR ) + continue; + if ( len <= 0 ) + { + rc = -1; + goto out; + } + + /* Finish a potential short read in the last iov */ + while ( len > 0 && idx < iovcnt ) + { + if ( len >= iov[idx].iov_len ) + { + len -= iov[idx].iov_len; + } + else + { + void *p = iov[idx].iov_base + len; + size_t l = iov[idx].iov_len - len; + + rc = read_exact(fd, p, l); + if ( rc ) + goto out; + len = 0; + } + idx++; + } + } +out: + return rc; +} + int writev_exact(int fd, const struct iovec *iov, int iovcnt) { struct iovec *local_iov = NULL; diff --git a/tools/libs/ctrl/xc_private.h b/tools/libs/ctrl/xc_private.h index 3e299b943f..66086ef19f 100644 --- a/tools/libs/ctrl/xc_private.h +++ b/tools/libs/ctrl/xc_private.h @@ -410,6 +410,7 @@ int xc_flush_mmu_updates(xc_interface *xch, struct xc_mmu *mmu); /* Return 0 on success; -1 on error setting errno. */ int read_exact(int fd, void *data, size_t size); /* EOF => -1, errno=0 */ +int readv_exact(int fd, const struct iovec *iov, int iovcnt); int write_exact(int fd, const void *data, size_t size); int writev_exact(int fd, const struct iovec *iov, int iovcnt); From xen-devel-bounces@lists.xenproject.org Thu Jul 01 09:56:52 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 09:56:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148340.274177 (Exim 4.92) (envelope-from ) id 1lytRE-0005A7-3k; Thu, 01 Jul 2021 09:56:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148340.274177; Thu, 01 Jul 2021 09:56:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lytRD-00059G-Vx; Thu, 01 Jul 2021 09:56:51 +0000 Received: by outflank-mailman (input) for mailman id 148340; Thu, 01 Jul 2021 09:56:50 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lytRC-0004XT-RV for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 09:56:50 +0000 Received: from mo4-p00-ob.smtp.rzone.de (unknown [81.169.146.220]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 42f4d1d9-810f-4e51-9cb2-0241aa5f3c98; Thu, 01 Jul 2021 09:56:45 +0000 (UTC) Received: from sender by smtp.strato.de (RZmta 47.28.1 AUTH) with ESMTPSA id 30791cx619ud5Mc (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Thu, 1 Jul 2021 11:56:39 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 42f4d1d9-810f-4e51-9cb2-0241aa5f3c98 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1625133399; s=strato-dkim-0002; d=aepfle.de; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Cc:Date: From:Subject:Sender; bh=fttDAmpegUqwpOBB61SFRLpHBJB9wPmVo+V4iKyUqQw=; b=fdQxUB5TzFIqwLyw1ED69LqOX2s3AglEWwdkPeuOY77rvPZXAxr7oyaDtElA5HaxG/ wS4anPwPRoe21WhiTF4NF0UDQSEKY7xlfvJw7NXq++Z9tsjtnxn9L+wTxPpvsjWyCYY1 gj6tzo/roDRzABQgRJeCYDoQATMedXnZpQP5EKFKV2vFg6HLn4TUmAmG2veH10UyyQf1 q1TuYC6yjJViUCZYU4mLKxw5Pkx9s1D6mmfKWG79qHBTdITAd+/XNTFo1o8mvrJ28bMV MRN/8q40YmRXsYRxxjPbfVO9tfzSzVT3bz6iZDk/z43VEwtGyk5Wi5AUta6onqy0C4DV QNNg== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QXkBR9MXjAuzpIG0mv9coXAg5lqlz7EsstGyDcxK3Mbajr+SQKopp1Cb0CyyaZQQ==" X-RZG-CLASS-ID: mo00 From: Olaf Hering To: xen-devel@lists.xenproject.org Cc: Olaf Hering , Ian Jackson , Wei Liu Subject: [PATCH v20210701 01/40] hotplug/Linux: fix starting of xenstored with restarting systemd Date: Thu, 1 Jul 2021 11:55:56 +0200 Message-Id: <20210701095635.15648-2-olaf@aepfle.de> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210701095635.15648-1-olaf@aepfle.de> References: <20210701095635.15648-1-olaf@aepfle.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit A hard to trigger race with another unrelated systemd service and xenstored.service unveiled a bug in the way how xenstored is launched with systemd. launch-xenstore may start either a daemon or a domain. In case a domain is used, systemd-notify was called. If another service triggered a restart of systemd while xenstored.service was executed, systemd may temporary lose track of services with Type=notify. As a result, xenstored.service would be marked as failed and units that depend on it will not be started. This breaks the enire Xen toolstack. The chain of events is basically: xenstored.service sends the notification to systemd, this is a one-way event. Then systemd may be restarted by the other unit. During this time, xenstored.service is done and exits. Once systemd is done with its restart, it collects the pending notifications and childs. If it does not find the unit which sent the notification it will declare it as failed. A workaround for this scenario is to leave the child processes running for a short time after sending the "READY=1" notification. If systemd happens to restart it will still find the unit it launched. Adjust the callers of launch-xenstore to specifiy the init system: Do not fork xenstored with systemd, preserve pid. This wil also avoid the need for a sleep because the process which sent the "READY=1" (the previously forked child) is still alive. Remove the --pid-file in the systemd case because the pid of the child is known, and the file had probably little effect anyway due to lack of PidFile= and Type=forking in the unit file. Be verbose about xenstored startup only with sysv to avoid interleaved output in systemd journal. Do the same also for domain case, even if is not strictly needed because init-xenstore-domain has no output. The fix for upstream systemd which is supposed to fix it: 575b300b795b6 ("pid1: rework how we dispatch SIGCHLD and other signals") Signed-off-by: Olaf Hering -- v04: - do mkdir unconditionally because init-xenstore-domain writes the domid to xenstored.pid v03: - remove run_xenstored function, follow style of shell built-in test function v02: - preserve Type=notify --- tools/hotplug/Linux/init.d/xencommons.in | 2 +- tools/hotplug/Linux/launch-xenstore.in | 40 ++++++++++++++----- .../Linux/systemd/xenstored.service.in | 2 +- 3 files changed, 31 insertions(+), 13 deletions(-) diff --git a/tools/hotplug/Linux/init.d/xencommons.in b/tools/hotplug/Linux/init.d/xencommons.in index 7fd6903b98..dcb0ce4b73 100644 --- a/tools/hotplug/Linux/init.d/xencommons.in +++ b/tools/hotplug/Linux/init.d/xencommons.in @@ -60,7 +60,7 @@ do_start () { mkdir -m700 -p ${XEN_LOCK_DIR} mkdir -p ${XEN_LOG_DIR} - @XEN_SCRIPT_DIR@/launch-xenstore || exit 1 + @XEN_SCRIPT_DIR@/launch-xenstore 'sysv' || exit 1 echo Setting domain 0 name, domid and JSON config... ${LIBEXEC_BIN}/xen-init-dom0 ${XEN_DOM0_UUID} diff --git a/tools/hotplug/Linux/launch-xenstore.in b/tools/hotplug/Linux/launch-xenstore.in index 019f9d6f4d..d40c66482a 100644 --- a/tools/hotplug/Linux/launch-xenstore.in +++ b/tools/hotplug/Linux/launch-xenstore.in @@ -15,6 +15,17 @@ # License along with this library; If not, see . # +initd=$1 + +case "$initd" in + sysv) nonl='-n' ;; + systemd) nonl= ;; + *) + echo "first argument must be 'sysv' or 'systemd'" + exit 1 + ;; +esac + XENSTORED=@XENSTORED@ . @XEN_SCRIPT_DIR@/hotplugpath.sh @@ -44,14 +55,16 @@ timeout_xenstore () { return 0 } -test_xenstore && exit 0 +mkdir -p @XEN_RUN_DIR@ + +if test "$initd" = 'sysv' ; then + test_xenstore && exit 0 +fi test -f @CONFIG_DIR@/@CONFIG_LEAF_DIR@/xencommons && . @CONFIG_DIR@/@CONFIG_LEAF_DIR@/xencommons [ "$XENSTORETYPE" = "" ] && XENSTORETYPE=daemon -/bin/mkdir -p @XEN_RUN_DIR@ - [ "$XENSTORETYPE" = "daemon" ] && { [ -z "$XENSTORED_TRACE" ] || XENSTORED_ARGS="$XENSTORED_ARGS -T @XEN_LOG_DIR@/xenstored-trace.log" [ -z "$XENSTORED" ] && XENSTORED=@XENSTORED@ @@ -59,13 +72,15 @@ test -f @CONFIG_DIR@/@CONFIG_LEAF_DIR@/xencommons && . @CONFIG_DIR@/@CONFIG_LEAF echo "No xenstored found" exit 1 } + [ "$initd" = 'sysv' ] && { + echo $nonl Starting $XENSTORED... + $XENSTORED --pid-file @XEN_RUN_DIR@/xenstored.pid $XENSTORED_ARGS + timeout_xenstore $XENSTORED || exit 1 + exit 0 + } - echo -n Starting $XENSTORED... - $XENSTORED --pid-file @XEN_RUN_DIR@/xenstored.pid $XENSTORED_ARGS - - systemd-notify --booted 2>/dev/null || timeout_xenstore $XENSTORED || exit 1 - - exit 0 + exec $XENSTORED -N $XENSTORED_ARGS + exit 1 } [ "$XENSTORETYPE" = "domain" ] && { @@ -75,9 +90,12 @@ test -f @CONFIG_DIR@/@CONFIG_LEAF_DIR@/xencommons && . @CONFIG_DIR@/@CONFIG_LEAF XENSTORE_DOMAIN_ARGS="$XENSTORE_DOMAIN_ARGS --memory $XENSTORE_DOMAIN_SIZE" [ -z "$XENSTORE_MAX_DOMAIN_SIZE" ] || XENSTORE_DOMAIN_ARGS="$XENSTORE_DOMAIN_ARGS --maxmem $XENSTORE_MAX_DOMAIN_SIZE" - echo -n Starting $XENSTORE_DOMAIN_KERNEL... + echo $nonl Starting $XENSTORE_DOMAIN_KERNEL... ${LIBEXEC_BIN}/init-xenstore-domain $XENSTORE_DOMAIN_ARGS || exit 1 - systemd-notify --ready 2>/dev/null + [ "$initd" = 'systemd' ] && { + systemd-notify --ready + sleep 9 + } exit 0 } diff --git a/tools/hotplug/Linux/systemd/xenstored.service.in b/tools/hotplug/Linux/systemd/xenstored.service.in index 80c1d408a5..c226eb3635 100644 --- a/tools/hotplug/Linux/systemd/xenstored.service.in +++ b/tools/hotplug/Linux/systemd/xenstored.service.in @@ -11,7 +11,7 @@ Type=notify NotifyAccess=all RemainAfterExit=true ExecStartPre=/bin/grep -q control_d /proc/xen/capabilities -ExecStart=@XEN_SCRIPT_DIR@/launch-xenstore +ExecStart=@XEN_SCRIPT_DIR@/launch-xenstore 'systemd' [Install] WantedBy=multi-user.target From xen-devel-bounces@lists.xenproject.org Thu Jul 01 09:56:54 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 09:56:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148341.274188 (Exim 4.92) (envelope-from ) id 1lytRG-0005VQ-Ex; Thu, 01 Jul 2021 09:56:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148341.274188; Thu, 01 Jul 2021 09:56:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lytRG-0005V9-Am; Thu, 01 Jul 2021 09:56:54 +0000 Received: by outflank-mailman (input) for mailman id 148341; Thu, 01 Jul 2021 09:56:52 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lytRE-0004r4-FY for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 09:56:52 +0000 Received: from mo4-p01-ob.smtp.rzone.de (unknown [85.215.255.51]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id dab754d8-b797-494a-b08a-c551f11e7521; Thu, 01 Jul 2021 09:56:49 +0000 (UTC) Received: from sender by smtp.strato.de (RZmta 47.28.1 AUTH) with ESMTPSA id 30791cx619ue5Mh (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Thu, 1 Jul 2021 11:56:40 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dab754d8-b797-494a-b08a-c551f11e7521 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1625133401; s=strato-dkim-0002; d=aepfle.de; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Cc:Date: From:Subject:Sender; bh=7VCnrhtz6PkcA6hU43Dz4SRyiupndGcq7UxNqTELglw=; b=Qn1iK4PuvrSQRmBbDFH3T3UsDMsI+qEEMBs1jKHvz2iCrUS7YTnMSloI4wNLXg9N8K xynwKO4T4U863Sc2tP5Oluf6xC3SY7p41f1WZFwVEqeKgQbNwCjmJLa1lcvXpDxusejM lHflf7IPDlNibxhWELktw0CVFMUwe794DPg32iF/4E2rdXLUAzBJTl7vYWS4efGoDDY8 ae7qn5EG4Z+SKtc0cw4+d5w/z1vdqx6DdwXRL0N9QgWIW/AWl7WLs0he0k5kZ0jmIMJk qyoNWj82+xBpLqYO4UqvAHveEftafbJUjsuFUEesN2p2VbfNiwHpsAWd7GPOcoG+pT5L D9qw== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QXkBR9MXjAuzpIG0mv9coXAg5lqlz7EsstGyDcxK3Mbajr+SQKopp1Cb0CyyaZQQ==" X-RZG-CLASS-ID: mo00 From: Olaf Hering To: xen-devel@lists.xenproject.org Cc: Olaf Hering , =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Ian Jackson , Wei Liu Subject: [PATCH v20210701 04/40] tools: use integer division in convert-legacy-stream Date: Thu, 1 Jul 2021 11:55:59 +0200 Message-Id: <20210701095635.15648-5-olaf@aepfle.de> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210701095635.15648-1-olaf@aepfle.de> References: <20210701095635.15648-1-olaf@aepfle.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit A single slash gives a float, a double slash gives an int. bitmap = unpack_exact("Q" * ((max_id/64) + 1)) TypeError: can't multiply sequence by non-int of type 'float' Signed-off-by: Olaf Hering v02: - import division to remain compatible with python2.7 (andrew) - white space in max_id chunk (andrew) --- tools/python/scripts/convert-legacy-stream | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/tools/python/scripts/convert-legacy-stream b/tools/python/scripts/convert-legacy-stream index ca93a93848..66ee3d2f5d 100755 --- a/tools/python/scripts/convert-legacy-stream +++ b/tools/python/scripts/convert-legacy-stream @@ -6,6 +6,7 @@ Convert a legacy migration stream to a v2 stream. """ from __future__ import print_function +from __future__ import division import sys import os, os.path @@ -163,7 +164,7 @@ def write_libxc_hvm_params(params): raise RuntimeError("Expected even length list of hvm parameters") write_record(libxc.REC_TYPE_hvm_params, - pack(libxc.HVM_PARAMS_FORMAT, len(params) / 2, 0), + pack(libxc.HVM_PARAMS_FORMAT, len(params) // 2, 0), pack("Q" * len(params), *params)) def write_libxc_static_data_end(): @@ -264,8 +265,8 @@ def read_pv_extended_info(vm): (so_far - total_length, )) def read_pv_p2m_frames(vm): - fpp = 4096 / vm.width - p2m_frame_len = (vm.p2m_size - 1) / fpp + 1 + fpp = 4096 // vm.width + p2m_frame_len = (vm.p2m_size - 1) // fpp + 1 info("P2M frames: fpp %d, p2m_frame_len %d" % (fpp, p2m_frame_len)) write_libxc_pv_p2m_frames(vm, unpack_ulongs(p2m_frame_len)) @@ -405,7 +406,7 @@ def read_chunks(vm): (max_id, legacy.MAX_VCPU_ID)) vm.max_vcpu_id = max_id - bitmap = unpack_exact("Q" * ((max_id/64) + 1)) + bitmap = unpack_exact("Q" * ((max_id // 64) + 1)) for idx, word in enumerate(bitmap): bit_idx = 0 From xen-devel-bounces@lists.xenproject.org Thu Jul 01 09:56:56 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 09:56:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148342.274199 (Exim 4.92) (envelope-from ) id 1lytRI-0005tF-Ra; Thu, 01 Jul 2021 09:56:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148342.274199; Thu, 01 Jul 2021 09:56:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lytRI-0005su-My; Thu, 01 Jul 2021 09:56:56 +0000 Received: by outflank-mailman (input) for mailman id 148342; Thu, 01 Jul 2021 09:56:55 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lytRH-0004XT-RY for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 09:56:55 +0000 Received: from mo4-p02-ob.smtp.rzone.de (unknown [85.215.255.82]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 13d81159-b2fa-4d56-9e43-7e36d5b2af87; Thu, 01 Jul 2021 09:56:49 +0000 (UTC) Received: from sender by smtp.strato.de (RZmta 47.28.1 AUTH) with ESMTPSA id 30791cx619uf5Mk (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Thu, 1 Jul 2021 11:56:41 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 13d81159-b2fa-4d56-9e43-7e36d5b2af87 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1625133402; s=strato-dkim-0002; d=aepfle.de; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Cc:Date: From:Subject:Sender; bh=w7dbe+kbBj9TSW8hk0eL96KxDDaP2dTnYnGMLgLRSqI=; b=SbESxQvE2mOzRcBik9DJArk5eOy7F3cFOwsCKAO0xVAbzKozcTyr7yCt2b8XIKrhvp Xc/2AXKIaE8g2517el7vNKDDYcoSVXWrA3tjowsgWUtH/OngnWswcKSg8PaSrx+fiR5L 4yRhX2EsZQ1zVKqBbgdpB/vBBHHxtibQuWigSmEEQcykJQG574C3X/NXucFLBMVFwsqc YmInlN/HOO7a0dPfKtyunjZqtkBKWBTw4SEzAX7k8mF5vBlYnW2F98RP+6rORfNVMRwt D8vYCLwcc2rQ3GEa+8HjeB+O4HK5k45zu5fGzCi4mWLTli5Qq/O5mSFVKiO2vLcdVaar aggw== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QXkBR9MXjAuzpIG0mv9coXAg5lqlz7EsstGyDcxK3Mbajr+SQKopp1Cb0CyyaZQQ==" X-RZG-CLASS-ID: mo00 From: Olaf Hering To: xen-devel@lists.xenproject.org Cc: Olaf Hering , =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Ian Jackson , Wei Liu Subject: [PATCH v20210701 06/40] tools: fix Python3.4 TypeError in format string Date: Thu, 1 Jul 2021 11:56:01 +0200 Message-Id: <20210701095635.15648-7-olaf@aepfle.de> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210701095635.15648-1-olaf@aepfle.de> References: <20210701095635.15648-1-olaf@aepfle.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Using the first element of a tuple for a format specifier fails with python3.4 as included in SLE12: b = b"string/%x" % (i, ) TypeError: unsupported operand type(s) for %: 'bytes' and 'tuple' It happens to work with python 2.7 and 3.6. Use a syntax that is handled by all three variants. Signed-off-by: Olaf Hering --- tools/python/scripts/convert-legacy-stream | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/python/scripts/convert-legacy-stream b/tools/python/scripts/convert-legacy-stream index 9003ac4f6d..235b922ff5 100755 --- a/tools/python/scripts/convert-legacy-stream +++ b/tools/python/scripts/convert-legacy-stream @@ -347,9 +347,9 @@ def read_libxl_toolstack(vm, data): if nil != 0: raise StreamError("physmap name not NUL terminated") - root = b"physmap/%x" % (phys, ) - kv = [root + b"/start_addr", b"%x" % (start, ), - root + b"/size", b"%x" % (size, ), + root = bytes(("physmap/%x" % phys).encode('utf-8')) + kv = [root + b"/start_addr", bytes(("%x" % start).encode('utf-8')), + root + b"/size", bytes(("%x" % size).encode('utf-8')), root + b"/name", name] for key, val in zip(kv[0::2], kv[1::2]): From xen-devel-bounces@lists.xenproject.org Thu Jul 01 09:57:02 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 09:57:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148346.274210 (Exim 4.92) (envelope-from ) id 1lytRO-0006X7-9B; Thu, 01 Jul 2021 09:57:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148346.274210; Thu, 01 Jul 2021 09:57:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lytRO-0006Wq-4t; Thu, 01 Jul 2021 09:57:02 +0000 Received: by outflank-mailman (input) for mailman id 148346; Thu, 01 Jul 2021 09:57:00 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lytRM-0004XT-Rr for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 09:57:00 +0000 Received: from mo4-p01-ob.smtp.rzone.de (unknown [85.215.255.50]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id ef2dd189-357d-4b4a-8416-ff4c5bf7bfa6; Thu, 01 Jul 2021 09:56:49 +0000 (UTC) Received: from sender by smtp.strato.de (RZmta 47.28.1 AUTH) with ESMTPSA id 30791cx619ue5Mg (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Thu, 1 Jul 2021 11:56:40 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ef2dd189-357d-4b4a-8416-ff4c5bf7bfa6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1625133400; s=strato-dkim-0002; d=aepfle.de; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Cc:Date: From:Subject:Sender; bh=WwrXv/hX+8hePyd4mOYFfrU0MUgrTtUZ8Gjzx55scrs=; b=X40nb9sxbjnVV1nAwDlmHOrl3IpT3EDdb5MM+s5mXJNeggyrJFdvy4UKL79A3twwkP +GgMYKeLI2azO1neoyTzxlVOnk4/L2Gy7xZCGEEfkoeofS2KIvBh4UFk1X9JGrcFjxW2 45NQz5Q3u3KT+4TDeSyj8jS5AHNlDWtvHGbSorrR8r2ziEFd6zVLf0rxEpnDsEjIBAib 9ktCG0zE9JmsWZSW0RCrX4SrSXe9uf3UfgFfkCzRXivSBfRt8vg/CRdyJSzCJmna5Gks j7aivrJk7fEaB7AbSpFZzedvlaKaj1bNHamNVOGR0IiRVI+wY/CfzsFZnFhxU5bmbseQ DpUQ== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QXkBR9MXjAuzpIG0mv9coXAg5lqlz7EsstGyDcxK3Mbajr+SQKopp1Cb0CyyaZQQ==" X-RZG-CLASS-ID: mo00 From: Olaf Hering To: xen-devel@lists.xenproject.org Cc: Olaf Hering , Juergen Gross , Ian Jackson , Wei Liu , Anthony PERARD Subject: [PATCH v20210701 03/40] xl: fix description of migrate --debug Date: Thu, 1 Jul 2021 11:55:58 +0200 Message-Id: <20210701095635.15648-4-olaf@aepfle.de> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210701095635.15648-1-olaf@aepfle.de> References: <20210701095635.15648-1-olaf@aepfle.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit xl migrate --debug used to track every pfn in every batch of pages. But these times are gone. The code in xc_domain_save is the consumer of this knob, but it considers it only for the remus and colo case. Adjust the help text to tell what --debug does today: Nothing. Signed-off-by: Olaf Hering Reviewed-by: Juergen Gross v02: - the option has no effect anymore --- docs/man/xl.1.pod.in | 2 +- tools/xl/xl_cmdtable.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/man/xl.1.pod.in b/docs/man/xl.1.pod.in index e2176bd696..70a6ebf438 100644 --- a/docs/man/xl.1.pod.in +++ b/docs/man/xl.1.pod.in @@ -481,7 +481,7 @@ domain. =item B<--debug> -Display huge (!) amount of debug information during the migration process. +This option has no effect. It is preserved for compatibility reasons. =item B<-p> diff --git a/tools/xl/xl_cmdtable.c b/tools/xl/xl_cmdtable.c index 661323d488..ca1dfa3525 100644 --- a/tools/xl/xl_cmdtable.c +++ b/tools/xl/xl_cmdtable.c @@ -172,7 +172,7 @@ const struct cmd_spec cmd_table[] = { " migrate-receive [-d -e]\n" "-e Do not wait in the background (on ) for the death\n" " of the domain.\n" - "--debug Print huge (!) amount of debug during the migration process.\n" + "--debug Ignored.\n" "-p Do not unpause domain after migrating it.\n" "-D Preserve the domain id" }, From xen-devel-bounces@lists.xenproject.org Thu Jul 01 09:57:05 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 09:57:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148348.274221 (Exim 4.92) (envelope-from ) id 1lytRQ-00072E-U8; Thu, 01 Jul 2021 09:57:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148348.274221; Thu, 01 Jul 2021 09:57:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lytRQ-00071t-LN; Thu, 01 Jul 2021 09:57:04 +0000 Received: by outflank-mailman (input) for mailman id 148348; Thu, 01 Jul 2021 09:57:02 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lytRO-0004r4-Fp for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 09:57:02 +0000 Received: from mo4-p03-ob.smtp.rzone.de (unknown [85.215.255.102]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id c587559b-37c5-434a-b906-25f3b6bdca35; Thu, 01 Jul 2021 09:56:53 +0000 (UTC) Received: from sender by smtp.strato.de (RZmta 47.28.1 AUTH) with ESMTPSA id 30791cx619ul5N8 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Thu, 1 Jul 2021 11:56:47 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c587559b-37c5-434a-b906-25f3b6bdca35 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1625133408; s=strato-dkim-0002; d=aepfle.de; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Cc:Date: From:Subject:Sender; bh=JtFmFI89VrmWr2vsArcScvsm4YNWIztizbLrNUj8v3A=; b=KF+/i2w2jn0OOsptwi4M0yyQC9/LaijzHsOLKpPAEf0C//wVSKbRIk+XVjsQX7aMP5 pqFw6zhfu/4rm4fwzY7XBLDKe5PvzWH4M8FtlsYYGhly0yYXTG18oArFTlndqyD+SzzY 8ZflkpY0K5epQ2Ns/L1DGVkdHLE/nD1yHWF3SN+6aerEc29EbxuJYB8XtQJyQUbNdfqo wdVfiAXgkTDLT3ucJ3KGWEczM0iB0VgTqX1LXMoGKL4zS1o+SkqUFfiy1FY+piUdnnfn UbS0/7qxmjisfu+6SzRoywgIDRYJ3L+ACrbYCrQfWlGvW/j+EnHRwjtNSNIcF2olHkCQ CSPw== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QXkBR9MXjAuzpIG0mv9coXAg5lqlz7EsstGyDcxK3Mbajr+SQKopp1Cb0CyyaZQQ==" X-RZG-CLASS-ID: mo00 From: Olaf Hering To: xen-devel@lists.xenproject.org Cc: Olaf Hering , Juergen Gross , Ian Jackson , Wei Liu Subject: [PATCH v20210701 18/40] tools: save: move errors array Date: Thu, 1 Jul 2021 11:56:13 +0200 Message-Id: <20210701095635.15648-19-olaf@aepfle.de> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210701095635.15648-1-olaf@aepfle.de> References: <20210701095635.15648-1-olaf@aepfle.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Remove allocation from hotpath, move errors array into preallocated space. Signed-off-by: Olaf Hering Reviewed-by: Juergen Gross --- tools/libs/saverestore/common.h | 2 ++ tools/libs/saverestore/save.c | 7 ++----- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/tools/libs/saverestore/common.h b/tools/libs/saverestore/common.h index 5bd2913cb6..25ee8fcb0f 100644 --- a/tools/libs/saverestore/common.h +++ b/tools/libs/saverestore/common.h @@ -229,6 +229,8 @@ struct sr_save_arrays { xen_pfn_t mfns[MAX_BATCH_SIZE]; /* write_batch: Types of the batch pfns. */ xen_pfn_t types[MAX_BATCH_SIZE]; + /* write_batch: Errors from attempting to map the gfns. */ + int errors[MAX_BATCH_SIZE]; }; struct sr_restore_arrays { diff --git a/tools/libs/saverestore/save.c b/tools/libs/saverestore/save.c index 0883c1fac0..9ebbf00ce7 100644 --- a/tools/libs/saverestore/save.c +++ b/tools/libs/saverestore/save.c @@ -92,7 +92,7 @@ static int write_batch(struct xc_sr_context *ctx) void *guest_mapping = NULL; void **guest_data = NULL; void **local_pages = NULL; - int *errors = NULL, rc = -1; + int *errors = ctx->save.m->errors, rc = -1; unsigned int i, p, nr_pages = 0, nr_pages_mapped = 0; unsigned int nr_pfns = ctx->save.nr_batch_pfns; void *page, *orig_page; @@ -105,8 +105,6 @@ static int write_batch(struct xc_sr_context *ctx) assert(nr_pfns != 0); - /* Errors from attempting to map the gfns. */ - errors = malloc(nr_pfns * sizeof(*errors)); /* Pointers to page data to send. Mapped gfns or local allocations. */ guest_data = calloc(nr_pfns, sizeof(*guest_data)); /* Pointers to locally allocated pages. Need freeing. */ @@ -114,7 +112,7 @@ static int write_batch(struct xc_sr_context *ctx) /* iovec[] for writev(). */ iov = malloc((nr_pfns + 4) * sizeof(*iov)); - if ( !errors || !guest_data || !local_pages || !iov ) + if ( !guest_data || !local_pages || !iov ) { ERROR("Unable to allocate arrays for a batch of %u pages", nr_pfns); @@ -271,7 +269,6 @@ static int write_batch(struct xc_sr_context *ctx) free(iov); free(local_pages); free(guest_data); - free(errors); return rc; } From xen-devel-bounces@lists.xenproject.org Thu Jul 01 09:57:07 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 09:57:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148351.274232 (Exim 4.92) (envelope-from ) id 1lytRT-0007Zx-Bs; Thu, 01 Jul 2021 09:57:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148351.274232; Thu, 01 Jul 2021 09:57:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lytRT-0007ZV-4z; Thu, 01 Jul 2021 09:57:07 +0000 Received: by outflank-mailman (input) for mailman id 148351; Thu, 01 Jul 2021 09:57:05 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lytRR-0004XT-S0 for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 09:57:05 +0000 Received: from mo4-p02-ob.smtp.rzone.de (unknown [81.169.146.170]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 0941045a-39ea-4084-bd5e-22ff734b2a6c; Thu, 01 Jul 2021 09:56:49 +0000 (UTC) Received: from sender by smtp.strato.de (RZmta 47.28.1 AUTH) with ESMTPSA id 30791cx619ui5Ms (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Thu, 1 Jul 2021 11:56:44 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0941045a-39ea-4084-bd5e-22ff734b2a6c DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1625133404; s=strato-dkim-0002; d=aepfle.de; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Cc:Date: From:Subject:Sender; bh=ex4r4d11Mg1k2Zn9qFLItgRI9LdfJn43Y1sVEepvWiU=; b=MINrfXc5iyKU6L0b0y1toSzNvOC3EMNFBf2mAqFKmcHh5kEPrAhRw/niCitYKxPoD3 AowdVRraJeFi3mHit3amy7y4SjQAE+dxJG4R3Nq/bPV+R8iXK8btER1ImH6EO9Bqpkkq U1AgaOznJ0o9KcNiU6NNBxp6wu5AcYQoAYCTooDiCKF7U572lWW117vDDYNKpcYQay6h fOVZS8/EYQ1ggUZDguUR8z3Ap0/M80632/OnVF4Jw81Uy6Dh22jVKkh+KhGZjXAEJlZI tTk33dwwugQ4fd9FTNsqK3od7UFonplaU7wAzYOBL9QzoK3RBWRc6z/L8nqKUco8XBCd KzBA== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QXkBR9MXjAuzpIG0mv9coXAg5lqlz7EsstGyDcxK3Mbajr+SQKopp1Cb0CyyaZQQ==" X-RZG-CLASS-ID: mo00 From: Olaf Hering To: xen-devel@lists.xenproject.org Cc: Olaf Hering , Juergen Gross , Ian Jackson , Wei Liu Subject: [PATCH v20210701 11/40] tools: use sr_is_known_page_type Date: Thu, 1 Jul 2021 11:56:06 +0200 Message-Id: <20210701095635.15648-12-olaf@aepfle.de> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210701095635.15648-1-olaf@aepfle.de> References: <20210701095635.15648-1-olaf@aepfle.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Verify pfn type on sending side, also verify incoming batch of pfns. Signed-off-by: Olaf Hering Reviewed-by: Juergen Gross v02: - use sr_is_known_page_type instead of xc_is_known_page_type --- tools/libs/saverestore/restore.c | 3 +-- tools/libs/saverestore/save.c | 6 ++++++ 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/tools/libs/saverestore/restore.c b/tools/libs/saverestore/restore.c index be259a1c6b..324b9050e2 100644 --- a/tools/libs/saverestore/restore.c +++ b/tools/libs/saverestore/restore.c @@ -406,8 +406,7 @@ static int handle_page_data(struct xc_sr_context *ctx, struct xc_sr_record *rec) } type = (pages->pfn[i] & PAGE_DATA_TYPE_MASK) >> 32; - if ( ((type >> XEN_DOMCTL_PFINFO_LTAB_SHIFT) >= 5) && - ((type >> XEN_DOMCTL_PFINFO_LTAB_SHIFT) <= 8) ) + if ( sr_is_known_page_type(type) == false ) { ERROR("Invalid type %#"PRIx32" for pfn %#"PRIpfn" (index %u)", type, pfn, i); diff --git a/tools/libs/saverestore/save.c b/tools/libs/saverestore/save.c index ae3e8797d0..6f820ea432 100644 --- a/tools/libs/saverestore/save.c +++ b/tools/libs/saverestore/save.c @@ -147,6 +147,12 @@ static int write_batch(struct xc_sr_context *ctx) for ( i = 0; i < nr_pfns; ++i ) { + if ( sr_is_known_page_type(types[i]) == false ) + { + ERROR("Wrong type %#"PRIpfn" for pfn %#"PRIpfn, types[i], mfns[i]); + goto err; + } + switch ( types[i] ) { case XEN_DOMCTL_PFINFO_BROKEN: From xen-devel-bounces@lists.xenproject.org Thu Jul 01 09:57:08 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 09:57:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148353.274241 (Exim 4.92) (envelope-from ) id 1lytRU-0007sC-Nc; Thu, 01 Jul 2021 09:57:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148353.274241; Thu, 01 Jul 2021 09:57:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lytRU-0007rS-Gg; Thu, 01 Jul 2021 09:57:08 +0000 Received: by outflank-mailman (input) for mailman id 148353; Thu, 01 Jul 2021 09:57:07 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lytRT-0004r4-Fz for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 09:57:07 +0000 Received: from mo4-p02-ob.smtp.rzone.de (unknown [85.215.255.81]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 05bcbd22-3dea-4a3b-a0ca-18bda5380d99; Thu, 01 Jul 2021 09:56:54 +0000 (UTC) Received: from sender by smtp.strato.de (RZmta 47.28.1 AUTH) with ESMTPSA id 30791cx619uh5Mn (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Thu, 1 Jul 2021 11:56:43 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 05bcbd22-3dea-4a3b-a0ca-18bda5380d99 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1625133403; s=strato-dkim-0002; d=aepfle.de; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Cc:Date: From:Subject:Sender; bh=+KbVruLtdIEtwG93Soc7D+UJBCIYv9cMILQskmOXes4=; b=D7SisCzfa2rafDqJS+Cmj1d+KIdVX6sD5wo/ADBI8YzE11YqWd4yX3vfLjVoUlZz7t D+JpnF79BDH8B8kztS+G+l95eXmYfQTfZF5WjWSLWJmH/Q0gfRaDOKbbOikCdMgX4yDG 46MaGdrgIep0sk9B/gYuRl/tg0ygFUZuzOUnK/X/4Wgp0fZXtDveil6JgzMfdQtQem8P f+k6PAwPyg+ZJlN1kEJsoWTOzHYhaxQ6SmhcXEFSFMmcPPPPiBLgT58+El2Qb0ZtCU83 taMYjCtjJx8tRQQwNAjSvtc/AYJdDlHRikICCtf/mpzPsNc3z5bLy/4Hy0nqF9Bl0+rt kMJQ== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QXkBR9MXjAuzpIG0mv9coXAg5lqlz7EsstGyDcxK3Mbajr+SQKopp1Cb0CyyaZQQ==" X-RZG-CLASS-ID: mo00 From: Olaf Hering To: xen-devel@lists.xenproject.org Cc: Olaf Hering , Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v20210701 08/40] MAINTAINERS: add myself as saverestore maintainer Date: Thu, 1 Jul 2021 11:56:03 +0200 Message-Id: <20210701095635.15648-9-olaf@aepfle.de> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210701095635.15648-1-olaf@aepfle.de> References: <20210701095635.15648-1-olaf@aepfle.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit I touched it last. Signed-off-by: Olaf Hering --- MAINTAINERS | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 8a52a03969..36dc634958 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -381,6 +381,12 @@ R: Juergen Gross S: Supported F: tools/libs/ +LIBSAVERESTORE: +M: Olaf Hering +S: Supported +F: tools/include/xensaverestore.h +F: tools/libs/saverestore/ + LIBXENLIGHT M: Ian Jackson M: Wei Liu From xen-devel-bounces@lists.xenproject.org Thu Jul 01 09:57:13 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 09:57:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148355.274253 (Exim 4.92) (envelope-from ) id 1lytRZ-0000I3-17; Thu, 01 Jul 2021 09:57:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148355.274253; Thu, 01 Jul 2021 09:57:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lytRY-0000Hk-S9; Thu, 01 Jul 2021 09:57:12 +0000 Received: by outflank-mailman (input) for mailman id 148355; Thu, 01 Jul 2021 09:57:10 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lytRW-0004XT-Rt for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 09:57:10 +0000 Received: from mo4-p02-ob.smtp.rzone.de (unknown [85.215.255.83]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id c60b6e97-d7a6-4b2a-a322-8cfde3b17073; Thu, 01 Jul 2021 09:56:49 +0000 (UTC) Received: from sender by smtp.strato.de (RZmta 47.28.1 AUTH) with ESMTPSA id 30791cx619ui5Mq (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Thu, 1 Jul 2021 11:56:44 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c60b6e97-d7a6-4b2a-a322-8cfde3b17073 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1625133404; s=strato-dkim-0002; d=aepfle.de; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Cc:Date: From:Subject:Sender; bh=deA9YRVAOQ9im7B/3eOo3ZnuGujRxb1REyjDaCpxsfY=; b=ArRTIdul3rn/jRUBaAMtWUjGSvhOeN0c6D25JquFZzJlpSlu3P2UqIQYqBDbCGwQAz 4LQUy0Vg4i+wmTHxvFW3F1mxWXSmwNyv4jBz2FdL/n0FQSUrqpwJpGPp0bizAWHIt+vt dMw4APZU8EWIUaL+/xg5WdwEJ1qtIkIMhmqSYLDyBUVBhGziDzlUmEDAwwUsE/cjScCE grgpPzR7B/03fXb8fsN40E+jlWIerDK/UKoGHqjifE64ierjRRJUk3vnT3w/O/yVx9+L 2/46uUjfv/wGpTz9lN4C6WCm9VkWRVKsDTjqgd0C+n0hB/D3mrf56htE97a8wolGbWzs s+gg== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QXkBR9MXjAuzpIG0mv9coXAg5lqlz7EsstGyDcxK3Mbajr+SQKopp1Cb0CyyaZQQ==" X-RZG-CLASS-ID: mo00 From: Olaf Hering To: xen-devel@lists.xenproject.org Cc: Olaf Hering , Ian Jackson , Wei Liu , Juergen Gross Subject: [PATCH v20210701 10/40] tools: add xc_is_known_page_type to libxenctrl Date: Thu, 1 Jul 2021 11:56:05 +0200 Message-Id: <20210701095635.15648-11-olaf@aepfle.de> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210701095635.15648-1-olaf@aepfle.de> References: <20210701095635.15648-1-olaf@aepfle.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Users of xc_get_pfn_type_batch may want to sanity check the data returned by Xen. Add a simple helper for this purpose. Signed-off-by: Olaf Hering v02: - rename xc_is_known_page_type to sr_is_known_page_type - move from ctrl/xc_private.h to saverestore/common.h (jgross) --- tools/libs/saverestore/common.h | 33 +++++++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+) diff --git a/tools/libs/saverestore/common.h b/tools/libs/saverestore/common.h index ca2eb47a4f..07c506360c 100644 --- a/tools/libs/saverestore/common.h +++ b/tools/libs/saverestore/common.h @@ -467,6 +467,39 @@ int populate_pfns(struct xc_sr_context *ctx, unsigned int count, /* Handle a STATIC_DATA_END record. */ int handle_static_data_end(struct xc_sr_context *ctx); +/* Sanitiy check for types returned by Xen */ +static inline bool sr_is_known_page_type(xen_pfn_t type) +{ + bool ret; + + switch (type) + { + case XEN_DOMCTL_PFINFO_NOTAB: + + case XEN_DOMCTL_PFINFO_L1TAB: + case XEN_DOMCTL_PFINFO_L1TAB | XEN_DOMCTL_PFINFO_LPINTAB: + + case XEN_DOMCTL_PFINFO_L2TAB: + case XEN_DOMCTL_PFINFO_L2TAB | XEN_DOMCTL_PFINFO_LPINTAB: + + case XEN_DOMCTL_PFINFO_L3TAB: + case XEN_DOMCTL_PFINFO_L3TAB | XEN_DOMCTL_PFINFO_LPINTAB: + + case XEN_DOMCTL_PFINFO_L4TAB: + case XEN_DOMCTL_PFINFO_L4TAB | XEN_DOMCTL_PFINFO_LPINTAB: + + case XEN_DOMCTL_PFINFO_XTAB: + case XEN_DOMCTL_PFINFO_XALLOC: /* Synthetic type in Xen 4.2 - 4.5 */ + case XEN_DOMCTL_PFINFO_BROKEN: + ret = true; + break; + default: + ret = false; + break; + } + return ret; +} + #endif /* * Local variables: From xen-devel-bounces@lists.xenproject.org Thu Jul 01 09:57:13 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 09:57:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148356.274258 (Exim 4.92) (envelope-from ) id 1lytRZ-0000Ms-GA; Thu, 01 Jul 2021 09:57:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148356.274258; Thu, 01 Jul 2021 09:57:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lytRZ-0000ME-92; Thu, 01 Jul 2021 09:57:13 +0000 Received: by outflank-mailman (input) for mailman id 148356; Thu, 01 Jul 2021 09:57:12 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lytRY-0004r4-GD for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 09:57:12 +0000 Received: from mo4-p02-ob.smtp.rzone.de (unknown [81.169.146.170]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id a52234a9-c9c2-4701-8d14-db772e6547a8; Thu, 01 Jul 2021 09:56:53 +0000 (UTC) Received: from sender by smtp.strato.de (RZmta 47.28.1 AUTH) with ESMTPSA id 30791cx619uk5N2 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Thu, 1 Jul 2021 11:56:46 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a52234a9-c9c2-4701-8d14-db772e6547a8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1625133406; s=strato-dkim-0002; d=aepfle.de; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Cc:Date: From:Subject:Sender; bh=6RnKPQsH20PdbTfVhW2egX9qSzfuCkrvoyMFtE/0GwA=; b=cquN494lrm7ljI6MEKPtT9XjxAa3kyMZOzySwPXws847LMv75F/o/r3Bcv9727yP7h 9I+k2OiyQPa3l0jMlVeudm7hB1ShHv9IygEH4da018Z4/dEr55bbxrEedIQcXpvc3qQX Bvd5Ezbc7s/qvIfQR1dsm9PbM5Z3+0B8zWdcLUR9I5oHUbfffnbfSrLrGkk8W7Wix4cm 3hbzvHBNlHvjHB1M7VWiamhHsXshQi8u7CPBj+2VGjr+OuGj1sTloYnFmhfamf7Hhsxz SLQ0KTybcvu+tan3ojBvYivYKkqJ31UrEhYFXXKB3EslYuxwRJ7GhbWtAZXmKw61HWoV 2a+w== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QXkBR9MXjAuzpIG0mv9coXAg5lqlz7EsstGyDcxK3Mbajr+SQKopp1Cb0CyyaZQQ==" X-RZG-CLASS-ID: mo00 From: Olaf Hering To: xen-devel@lists.xenproject.org Cc: Olaf Hering , Ian Jackson , Wei Liu , Juergen Gross Subject: [PATCH v20210701 15/40] tools: prepare to allocate saverestore arrays once Date: Thu, 1 Jul 2021 11:56:10 +0200 Message-Id: <20210701095635.15648-16-olaf@aepfle.de> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210701095635.15648-1-olaf@aepfle.de> References: <20210701095635.15648-1-olaf@aepfle.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The hotpath 'send_dirty_pages' is supposed to do just one thing: sending. The other end 'handle_page_data' is supposed to do just receiving. But instead both do other costly work like memory allocations and data moving. Do the allocations once, the array sizes are a compiletime constant. Avoid unneeded copying of data by receiving data directly into mapped guest memory. This patch is just prepartion, subsequent changes will populate the arrays. Once all changes are applied, migration of a busy HVM domU changes like that: Without this series, from sr650 to sr950 (xen-4.15.20201027T173911.16a20963b3 xen_testing): 2020-10-29 10:23:10.711+0000: xc: show_transfer_rate: 23663128 bytes + 2879563 pages in 55.324905335 sec, 203 MiB/sec: Internal error 2020-10-29 10:23:35.115+0000: xc: show_transfer_rate: 16829632 bytes + 2097552 pages in 24.401179720 sec, 335 MiB/sec: Internal error 2020-10-29 10:23:59.436+0000: xc: show_transfer_rate: 16829032 bytes + 2097478 pages in 24.319025928 sec, 336 MiB/sec: Internal error 2020-10-29 10:24:23.844+0000: xc: show_transfer_rate: 16829024 bytes + 2097477 pages in 24.406992500 sec, 335 MiB/sec: Internal error 2020-10-29 10:24:48.292+0000: xc: show_transfer_rate: 16828912 bytes + 2097463 pages in 24.446489027 sec, 335 MiB/sec: Internal error 2020-10-29 10:25:01.816+0000: xc: show_transfer_rate: 16836080 bytes + 2098356 pages in 13.447091818 sec, 609 MiB/sec: Internal error With this series, from sr650 to sr950 (xen-4.15.20201027T173911.16a20963b3 xen_unstable): 2020-10-28 21:26:05.074+0000: xc: show_transfer_rate: 23663128 bytes + 2879563 pages in 52.564054368 sec, 213 MiB/sec: Internal error 2020-10-28 21:26:23.527+0000: xc: show_transfer_rate: 16830040 bytes + 2097603 pages in 18.450592015 sec, 444 MiB/sec: Internal error 2020-10-28 21:26:41.926+0000: xc: show_transfer_rate: 16830944 bytes + 2097717 pages in 18.397862306 sec, 445 MiB/sec: Internal error 2020-10-28 21:27:00.339+0000: xc: show_transfer_rate: 16829176 bytes + 2097498 pages in 18.411973339 sec, 445 MiB/sec: Internal error 2020-10-28 21:27:18.643+0000: xc: show_transfer_rate: 16828592 bytes + 2097425 pages in 18.303326695 sec, 447 MiB/sec: Internal error 2020-10-28 21:27:26.289+0000: xc: show_transfer_rate: 16835952 bytes + 2098342 pages in 7.579846749 sec, 1081 MiB/sec: Internal error Note: the performance improvement depends on the used network cards, wirespeed and the host: - No improvement is expected with a 1G link. - Improvement can be seen as shown above on a 10G link. - Just a slight improvment can be seen on a 100G link. This change also populates sr_save_arrays with "batch_pfns", and sr_restore_arrays with "pfns" to make sure malloc is always called with a non-zero value. Signed-off-by: Olaf Hering v02: - rename xc_sr_save_arrays to sr_save_arrays - rename xc_sr_restore_arrays to sr_restore_arrays - merge handling of "batch_pfns" and "pfns" to make sure malloc is called with a non-zero size value (jgross) --- tools/libs/saverestore/common.h | 12 +++++++++++- tools/libs/saverestore/restore.c | 14 ++++++++++---- tools/libs/saverestore/save.c | 27 +++++++++++++-------------- 3 files changed, 34 insertions(+), 19 deletions(-) diff --git a/tools/libs/saverestore/common.h b/tools/libs/saverestore/common.h index 252076cf51..968bb8af13 100644 --- a/tools/libs/saverestore/common.h +++ b/tools/libs/saverestore/common.h @@ -223,6 +223,15 @@ static inline int update_blob(struct xc_sr_blob *blob, return 0; } +struct sr_save_arrays { + xen_pfn_t batch_pfns[MAX_BATCH_SIZE]; +}; + +struct sr_restore_arrays { + /* handle_page_data */ + xen_pfn_t pfns[MAX_BATCH_SIZE]; +}; + struct xc_sr_context { xc_interface *xch; @@ -255,11 +264,11 @@ struct xc_sr_context struct precopy_stats stats; - xen_pfn_t *batch_pfns; unsigned int nr_batch_pfns; unsigned long *deferred_pages; unsigned long nr_deferred_pages; xc_hypercall_buffer_t dirty_bitmap_hbuf; + struct sr_save_arrays *m; } save; struct /* Restore data. */ @@ -311,6 +320,7 @@ struct xc_sr_context /* Sender has invoked verify mode on the stream. */ bool verify; + struct sr_restore_arrays *m; } restore; }; diff --git a/tools/libs/saverestore/restore.c b/tools/libs/saverestore/restore.c index 799170c7a1..c203ce503d 100644 --- a/tools/libs/saverestore/restore.c +++ b/tools/libs/saverestore/restore.c @@ -315,7 +315,7 @@ static int handle_page_data(struct xc_sr_context *ctx, struct xc_sr_record *rec) unsigned int i, pages_of_data = 0; int rc = -1; - xen_pfn_t *pfns = NULL, pfn; + xen_pfn_t *pfns = ctx->restore.m->pfns, pfn; uint32_t *types = NULL, type; /* @@ -363,9 +363,8 @@ static int handle_page_data(struct xc_sr_context *ctx, struct xc_sr_record *rec) goto err; } - pfns = malloc(pages->count * sizeof(*pfns)); types = malloc(pages->count * sizeof(*types)); - if ( !pfns || !types ) + if ( !types ) { ERROR("Unable to allocate enough memory for %u pfns", pages->count); @@ -412,7 +411,6 @@ static int handle_page_data(struct xc_sr_context *ctx, struct xc_sr_record *rec) &pages->pfn[pages->count]); err: free(types); - free(pfns); return rc; } @@ -739,6 +737,13 @@ static int setup(struct xc_sr_context *ctx) } ctx->restore.allocated_rec_num = DEFAULT_BUF_RECORDS; + ctx->restore.m = malloc(sizeof(*ctx->restore.m)); + if ( !ctx->restore.m ) { + ERROR("Unable to allocate memory for arrays"); + rc = -1; + goto err; + } + err: return rc; } @@ -757,6 +762,7 @@ static void cleanup(struct xc_sr_context *ctx) xc_hypercall_buffer_free_pages( xch, dirty_bitmap, NRPAGES(bitmap_size(ctx->restore.p2m_size))); + free(ctx->restore.m); free(ctx->restore.buffered_records); free(ctx->restore.populated_pfns); diff --git a/tools/libs/saverestore/save.c b/tools/libs/saverestore/save.c index f8fbe7a742..e29b6e1d66 100644 --- a/tools/libs/saverestore/save.c +++ b/tools/libs/saverestore/save.c @@ -77,7 +77,7 @@ static int write_checkpoint_record(struct xc_sr_context *ctx) /* * Writes a batch of memory as a PAGE_DATA record into the stream. The batch - * is constructed in ctx->save.batch_pfns. + * is constructed in ctx->save.m->batch_pfns. * * This function: * - gets the types for each pfn in the batch. @@ -128,12 +128,12 @@ static int write_batch(struct xc_sr_context *ctx) for ( i = 0; i < nr_pfns; ++i ) { types[i] = mfns[i] = ctx->save.ops.pfn_to_gfn(ctx, - ctx->save.batch_pfns[i]); + ctx->save.m->batch_pfns[i]); /* Likely a ballooned page. */ if ( mfns[i] == INVALID_MFN ) { - set_bit(ctx->save.batch_pfns[i], ctx->save.deferred_pages); + set_bit(ctx->save.m->batch_pfns[i], ctx->save.deferred_pages); ++ctx->save.nr_deferred_pages; } } @@ -179,7 +179,7 @@ static int write_batch(struct xc_sr_context *ctx) if ( errors[p] ) { ERROR("Mapping of pfn %#"PRIpfn" (mfn %#"PRIpfn") failed %d", - ctx->save.batch_pfns[i], mfns[p], errors[p]); + ctx->save.m->batch_pfns[i], mfns[p], errors[p]); goto err; } @@ -193,7 +193,7 @@ static int write_batch(struct xc_sr_context *ctx) { if ( rc == -1 && errno == EAGAIN ) { - set_bit(ctx->save.batch_pfns[i], ctx->save.deferred_pages); + set_bit(ctx->save.m->batch_pfns[i], ctx->save.deferred_pages); ++ctx->save.nr_deferred_pages; types[i] = XEN_DOMCTL_PFINFO_XTAB; --nr_pages; @@ -224,7 +224,7 @@ static int write_batch(struct xc_sr_context *ctx) rec.length += nr_pages * PAGE_SIZE; for ( i = 0; i < nr_pfns; ++i ) - rec_pfns[i] = ((uint64_t)(types[i]) << 32) | ctx->save.batch_pfns[i]; + rec_pfns[i] = ((uint64_t)(types[i]) << 32) | ctx->save.m->batch_pfns[i]; iov[0].iov_base = &rec.type; iov[0].iov_len = sizeof(rec.type); @@ -296,9 +296,9 @@ static int flush_batch(struct xc_sr_context *ctx) if ( !rc ) { - VALGRIND_MAKE_MEM_UNDEFINED(ctx->save.batch_pfns, + VALGRIND_MAKE_MEM_UNDEFINED(ctx->save.m->batch_pfns, MAX_BATCH_SIZE * - sizeof(*ctx->save.batch_pfns)); + sizeof(*ctx->save.m->batch_pfns)); } return rc; @@ -315,7 +315,7 @@ static int add_to_batch(struct xc_sr_context *ctx, xen_pfn_t pfn) rc = flush_batch(ctx); if ( rc == 0 ) - ctx->save.batch_pfns[ctx->save.nr_batch_pfns++] = pfn; + ctx->save.m->batch_pfns[ctx->save.nr_batch_pfns++] = pfn; return rc; } @@ -849,13 +849,12 @@ static int setup(struct xc_sr_context *ctx) dirty_bitmap = xc_hypercall_buffer_alloc_pages( xch, dirty_bitmap, NRPAGES(bitmap_size(ctx->save.p2m_size))); - ctx->save.batch_pfns = malloc(MAX_BATCH_SIZE * - sizeof(*ctx->save.batch_pfns)); ctx->save.deferred_pages = bitmap_alloc(ctx->save.p2m_size); + ctx->save.m = malloc(sizeof(*ctx->save.m)); - if ( !ctx->save.batch_pfns || !dirty_bitmap || !ctx->save.deferred_pages ) + if ( !ctx->save.m || !dirty_bitmap || !ctx->save.deferred_pages ) { - ERROR("Unable to allocate memory for dirty bitmaps, batch pfns and" + ERROR("Unable to allocate memory for dirty bitmaps and" " deferred pages"); rc = -1; errno = ENOMEM; @@ -884,7 +883,7 @@ static void cleanup(struct xc_sr_context *ctx) xc_hypercall_buffer_free_pages(xch, dirty_bitmap, NRPAGES(bitmap_size(ctx->save.p2m_size))); free(ctx->save.deferred_pages); - free(ctx->save.batch_pfns); + free(ctx->save.m); } /* From xen-devel-bounces@lists.xenproject.org Thu Jul 01 09:57:17 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 09:57:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148357.274276 (Exim 4.92) (envelope-from ) id 1lytRd-0001BI-AD; Thu, 01 Jul 2021 09:57:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148357.274276; Thu, 01 Jul 2021 09:57:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lytRd-0001Az-4G; Thu, 01 Jul 2021 09:57:17 +0000 Received: by outflank-mailman (input) for mailman id 148357; Thu, 01 Jul 2021 09:57:15 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lytRb-0004XT-Rv for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 09:57:15 +0000 Received: from mo4-p02-ob.smtp.rzone.de (unknown [85.215.255.82]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id c2f72f25-cc87-4aca-9cb6-6f6e2dcd9778; Thu, 01 Jul 2021 09:56:49 +0000 (UTC) Received: from sender by smtp.strato.de (RZmta 47.28.1 AUTH) with ESMTPSA id 30791cx619uf5Mi (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Thu, 1 Jul 2021 11:56:41 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c2f72f25-cc87-4aca-9cb6-6f6e2dcd9778 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1625133401; s=strato-dkim-0002; d=aepfle.de; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Cc:Date: From:Subject:Sender; bh=tMf89Ke5Bo6A5Pju27XJS58XTaKNVAzyOo/JUVzZcLo=; b=nWvRnJWLur55V1tgXMbgxhtwgiY/CRv+DqprRK4PbMxuavZgH5yfVh6Ft1q6K0pILK ukoX/5a8uZ1sWLc2Dl59Eo1P8rfuFG5CeX1tkPuaiO1Yp13sffMDQCoXL9BtIc88MGxC xaewNcFmtlO6jV0QGeHsyjupGZkh3fhdXtuAVgjL9vjObeMtg+zcORScKLD9Q3q0aIG8 mWLyRU+I9vvlWbHwTxEK9ZiwmNdPdaf07uDSeTPf1nAr36mF38LC/W0irQXludbzbgZW 6zJkmdBGWIhWfs1EdSfjDEE9mss+4Zk9z3hGYyssgufhn2QBpe2er1jvzpcmJYqZ+/2W oLhw== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QXkBR9MXjAuzpIG0mv9coXAg5lqlz7EsstGyDcxK3Mbajr+SQKopp1Cb0CyyaZQQ==" X-RZG-CLASS-ID: mo00 From: Olaf Hering To: xen-devel@lists.xenproject.org Cc: Olaf Hering , =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Ian Jackson , Wei Liu Subject: [PATCH v20210701 05/40] tools: handle libxl__physmap_info.name properly in convert-legacy-stream Date: Thu, 1 Jul 2021 11:56:00 +0200 Message-Id: <20210701095635.15648-6-olaf@aepfle.de> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210701095635.15648-1-olaf@aepfle.de> References: <20210701095635.15648-1-olaf@aepfle.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The trailing member name[] in libxl__physmap_info is written as a cstring into the stream. The current code does a sanity check if the last byte is zero. This attempt fails with python3.4 because name[-1] returns a type int. As a result the comparison with byte(\00) fails: File "/usr/lib/xen/bin/convert-legacy-stream", line 347, in read_libxl_toolstack raise StreamError("physmap name not NUL terminated") StreamError: physmap name not NUL terminated To handle both python variants the cstring is unpacked into the actual string and the trailing nil. Signed-off-by: Olaf Hering --- tools/python/scripts/convert-legacy-stream | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/tools/python/scripts/convert-legacy-stream b/tools/python/scripts/convert-legacy-stream index 66ee3d2f5d..9003ac4f6d 100755 --- a/tools/python/scripts/convert-legacy-stream +++ b/tools/python/scripts/convert-legacy-stream @@ -336,20 +336,21 @@ def read_libxl_toolstack(vm, data): if len(data) < namelen: raise StreamError("Remaining data too short for physmap name") - name = data[:namelen] + c_string = data[:namelen] data = data[namelen:] # Strip padding off the end of name if twidth == 64: - name = name[:-4] + c_string = c_string[:-4] - if name[-1] != b'\x00': + name, nil = unpack("={0}sB".format(len(c_string) - 1), c_string) + if nil != 0: raise StreamError("physmap name not NUL terminated") root = b"physmap/%x" % (phys, ) kv = [root + b"/start_addr", b"%x" % (start, ), root + b"/size", b"%x" % (size, ), - root + b"/name", name[:-1]] + root + b"/name", name] for key, val in zip(kv[0::2], kv[1::2]): info(" '%s' = '%s'" % (key.decode(), val.decode())) From xen-devel-bounces@lists.xenproject.org Thu Jul 01 09:57:18 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 09:57:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148359.274284 (Exim 4.92) (envelope-from ) id 1lytRe-0001Yz-PG; Thu, 01 Jul 2021 09:57:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148359.274284; Thu, 01 Jul 2021 09:57:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lytRe-0001Xo-JS; Thu, 01 Jul 2021 09:57:18 +0000 Received: by outflank-mailman (input) for mailman id 148359; Thu, 01 Jul 2021 09:57:17 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lytRd-0004r4-Gd for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 09:57:17 +0000 Received: from mo4-p03-ob.smtp.rzone.de (unknown [85.215.255.104]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id d5bf76a4-ed1b-4216-9294-edd5278aaf94; Thu, 01 Jul 2021 09:56:55 +0000 (UTC) Received: from sender by smtp.strato.de (RZmta 47.28.1 AUTH) with ESMTPSA id 30791cx619un5NC (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Thu, 1 Jul 2021 11:56:49 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d5bf76a4-ed1b-4216-9294-edd5278aaf94 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1625133409; s=strato-dkim-0002; d=aepfle.de; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Cc:Date: From:Subject:Sender; bh=0ENk4UcCha2plreo4qu8AQV+ZCOBGywsK+BeOcrXNEw=; b=hvsGNz2aPTyUlje9u2IN1cqOqVzxnm8zakXYxhY4Dh3rUTNsVHK9vn9sEFbKoLqQrO zabF6S0hEqENSsCUFdqV6+pRBRaSAX9Xh7vdUFlHWHowuAvORi+vCclXXQi6Dv7ePMIH 9KjOwKV6v1TpW4hegVz0r4mxxNUBiFBlYaYCLWWrvXFkR7oVqeNz5dMiuE5QCWmphRoc O9UwdBLMExdfaT/LKBbvXao0iIwni+8tyTBpkFELF7ec4Vrjbzsi3DjkizKlFq1eGFBm 3+sAyGbAF6aMjpoUjwe8iovH4XqJGJI4yBA1O89Lrh2uIZgXvJt7OxE82YUzT/Ryhbi7 uV8Q== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QXkBR9MXjAuzpIG0mv9coXAg5lqlz7EsstGyDcxK3Mbajr+SQKopp1Cb0CyyaZQQ==" X-RZG-CLASS-ID: mo00 From: Olaf Hering To: xen-devel@lists.xenproject.org Cc: Olaf Hering , Juergen Gross , Ian Jackson , Wei Liu Subject: [PATCH v20210701 21/40] tools: save: move guest_data array Date: Thu, 1 Jul 2021 11:56:16 +0200 Message-Id: <20210701095635.15648-22-olaf@aepfle.de> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210701095635.15648-1-olaf@aepfle.de> References: <20210701095635.15648-1-olaf@aepfle.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Remove allocation from hotpath, move guest_data array into preallocated space. Because this was allocated with calloc: Adjust the loop to clear unused entries as needed. Signed-off-by: Olaf Hering Reviewed-by: Juergen Gross --- tools/libs/saverestore/common.h | 2 ++ tools/libs/saverestore/save.c | 11 ++++++----- 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/tools/libs/saverestore/common.h b/tools/libs/saverestore/common.h index 3994ab3844..c3570e0c9a 100644 --- a/tools/libs/saverestore/common.h +++ b/tools/libs/saverestore/common.h @@ -235,6 +235,8 @@ struct sr_save_arrays { struct iovec iov[MAX_BATCH_SIZE + 4]; /* write_batch */ uint64_t rec_pfns[MAX_BATCH_SIZE]; + /* write_batch: Pointers to page data to send. Mapped gfns or local allocations. */ + void *guest_data[MAX_BATCH_SIZE]; }; struct sr_restore_arrays { diff --git a/tools/libs/saverestore/save.c b/tools/libs/saverestore/save.c index 0f02988ff9..ea04cb1a74 100644 --- a/tools/libs/saverestore/save.c +++ b/tools/libs/saverestore/save.c @@ -90,7 +90,7 @@ static int write_batch(struct xc_sr_context *ctx) xc_interface *xch = ctx->xch; xen_pfn_t *mfns = ctx->save.m->mfns, *types = ctx->save.m->types; void *guest_mapping = NULL; - void **guest_data = NULL; + void **guest_data = ctx->save.m->guest_data; void **local_pages = NULL; int *errors = ctx->save.m->errors, rc = -1; unsigned int i, p, nr_pages = 0, nr_pages_mapped = 0; @@ -105,12 +105,10 @@ static int write_batch(struct xc_sr_context *ctx) assert(nr_pfns != 0); - /* Pointers to page data to send. Mapped gfns or local allocations. */ - guest_data = calloc(nr_pfns, sizeof(*guest_data)); /* Pointers to locally allocated pages. Need freeing. */ local_pages = calloc(nr_pfns, sizeof(*local_pages)); - if ( !guest_data || !local_pages ) + if ( !local_pages ) { ERROR("Unable to allocate arrays for a batch of %u pages", nr_pfns); @@ -166,7 +164,10 @@ static int write_batch(struct xc_sr_context *ctx) for ( i = 0, p = 0; i < nr_pfns; ++i ) { if ( page_type_has_stream_data(types[i]) == false ) + { + guest_data[i] = NULL; continue; + } if ( errors[p] ) { @@ -183,6 +184,7 @@ static int write_batch(struct xc_sr_context *ctx) if ( rc ) { + guest_data[i] = NULL; if ( rc == -1 && errno == EAGAIN ) { set_bit(ctx->save.m->batch_pfns[i], ctx->save.deferred_pages); @@ -256,7 +258,6 @@ static int write_batch(struct xc_sr_context *ctx) for ( i = 0; local_pages && i < nr_pfns; ++i ) free(local_pages[i]); free(local_pages); - free(guest_data); return rc; } From xen-devel-bounces@lists.xenproject.org Thu Jul 01 09:57:23 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 09:57:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148361.274298 (Exim 4.92) (envelope-from ) id 1lytRj-0002Oa-8u; Thu, 01 Jul 2021 09:57:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148361.274298; Thu, 01 Jul 2021 09:57:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lytRj-0002Nz-0W; Thu, 01 Jul 2021 09:57:23 +0000 Received: by outflank-mailman (input) for mailman id 148361; Thu, 01 Jul 2021 09:57:21 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lytRg-0004XT-SM for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 09:57:20 +0000 Received: from mo4-p02-ob.smtp.rzone.de (unknown [85.215.255.80]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 8a889ee9-8a7f-45e2-9550-29b8986b84eb; Thu, 01 Jul 2021 09:56:50 +0000 (UTC) Received: from sender by smtp.strato.de (RZmta 47.28.1 AUTH) with ESMTPSA id 30791cx619ui5Mt (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Thu, 1 Jul 2021 11:56:44 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8a889ee9-8a7f-45e2-9550-29b8986b84eb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1625133405; s=strato-dkim-0002; d=aepfle.de; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Cc:Date: From:Subject:Sender; bh=ZxRdsP8qr4H2zPhSJi5htgzgprczUQRiHOrKeRY262U=; b=pySoDWwLANK1H+EV2djdxCEct7RE0o92/5MBJbj9uBZ20QaDBrkor4fsJbbwF94Qn9 oF1R0s3ZGgNTnRhVBs2zFr9xUaFrc05L/dLZ9Nzt/Dm8OED46IxiswjcVursv+j1XV33 AoGb2AbwrJHSbv3JRr2z5oLqykleezJJsMFrzc2GynrNFEQuCPjitiAdlsMojAPB7yCD Vm75lhMVX30wiJ8nX34ukRMOo4OMFU9JS0L4jqN62m9qq9MbSqo9C+whOKhmgYkc1nb+ K8s6BcDCbkJD5IEq2RrYG7wuVdlm9mtUdqVg3VuHlqDnCWXxPdwBIkdYWk2BL3NfKV9e 7m2A== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QXkBR9MXjAuzpIG0mv9coXAg5lqlz7EsstGyDcxK3Mbajr+SQKopp1Cb0CyyaZQQ==" X-RZG-CLASS-ID: mo00 From: Olaf Hering To: xen-devel@lists.xenproject.org Cc: Olaf Hering , Ian Jackson , Wei Liu , Juergen Gross Subject: [PATCH v20210701 12/40] tools: unify type checking for data pfns in migration stream Date: Thu, 1 Jul 2021 11:56:07 +0200 Message-Id: <20210701095635.15648-13-olaf@aepfle.de> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210701095635.15648-1-olaf@aepfle.de> References: <20210701095635.15648-1-olaf@aepfle.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Introduce a helper which decides if a given pfn in the migration stream is backed by memory. This specifically deals with type XEN_DOMCTL_PFINFO_XALLOC, which was a synthetic toolstack-only type used in Xen 4.2 to 4.5. It indicated a dirty page on the sending side for which no data will be send in the initial iteration. No change in behavior intended. Signed-off-by: Olaf Hering --- tools/libs/saverestore/common.h | 17 +++++++++++++++++ tools/libs/saverestore/restore.c | 5 ++--- 2 files changed, 19 insertions(+), 3 deletions(-) diff --git a/tools/libs/saverestore/common.h b/tools/libs/saverestore/common.h index 07c506360c..fa242e808d 100644 --- a/tools/libs/saverestore/common.h +++ b/tools/libs/saverestore/common.h @@ -500,6 +500,23 @@ static inline bool sr_is_known_page_type(xen_pfn_t type) return ret; } +static inline bool page_type_to_populate(uint32_t type) +{ + bool ret; + + switch (type) + { + case XEN_DOMCTL_PFINFO_XTAB: + case XEN_DOMCTL_PFINFO_BROKEN: + ret = false; + break; + case XEN_DOMCTL_PFINFO_XALLOC: + default: + ret = true; + break; + } + return ret; +} #endif /* * Local variables: diff --git a/tools/libs/saverestore/restore.c b/tools/libs/saverestore/restore.c index 324b9050e2..477b7527a1 100644 --- a/tools/libs/saverestore/restore.c +++ b/tools/libs/saverestore/restore.c @@ -152,9 +152,8 @@ int populate_pfns(struct xc_sr_context *ctx, unsigned int count, for ( i = 0; i < count; ++i ) { - if ( (!types || (types && - (types[i] != XEN_DOMCTL_PFINFO_XTAB && - types[i] != XEN_DOMCTL_PFINFO_BROKEN))) && + if ( (!types || + (types && page_type_to_populate(types[i]) == true)) && !pfn_is_populated(ctx, original_pfns[i]) ) { rc = pfn_set_populated(ctx, original_pfns[i]); From xen-devel-bounces@lists.xenproject.org Thu Jul 01 09:57:24 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 09:57:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148362.274303 (Exim 4.92) (envelope-from ) id 1lytRk-0002Xs-3G; Thu, 01 Jul 2021 09:57:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148362.274303; Thu, 01 Jul 2021 09:57:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lytRj-0002WF-Ni; Thu, 01 Jul 2021 09:57:23 +0000 Received: by outflank-mailman (input) for mailman id 148362; Thu, 01 Jul 2021 09:57:22 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lytRi-0004r4-Gk for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 09:57:22 +0000 Received: from mo4-p03-ob.smtp.rzone.de (unknown [85.215.255.101]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id b3f38ebc-a56c-4e01-8323-f92017ee84eb; Thu, 01 Jul 2021 09:56:57 +0000 (UTC) Received: from sender by smtp.strato.de (RZmta 47.28.1 AUTH) with ESMTPSA id 30791cx619up5NL (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Thu, 1 Jul 2021 11:56:51 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b3f38ebc-a56c-4e01-8323-f92017ee84eb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1625133411; s=strato-dkim-0002; d=aepfle.de; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Cc:Date: From:Subject:Sender; bh=6ENQhbtthK4eIjkXxFO8V/gNE/sF6qih6TLZLeOb+b0=; b=tXgf/73seA2ReRIm8D/JvX4Ys0pziOMDW4aurCKsesPhuWp5kqvEKayk+88kKUk4FQ a1798geALsJt37Y5/f/RrZn6uJh2462CYxJwdMIfw8h7sXroDhjML12aaxRwKDgRoytd oQ9hwexHpCtTDxA70biVJOi8pSGynJ4nXJWgoxdOYJchetsXIMdXJioL0B9Y5ujMLWRG eZzZ3aTgGqEIWr0XgQvxepGEPbmx5vntjJEPKZDqHe9ZwHuTfwvgN9hxrxVNJZT/0qMF wnYCEkn4Ao6LrXPnvy4cn5BPloAViOynzk9AmdmLAiXfbZW4gkbxiuuJ2cLmWz8vsH6R ROIw== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QXkBR9MXjAuzpIG0mv9coXAg5lqlz7EsstGyDcxK3Mbajr+SQKopp1Cb0CyyaZQQ==" X-RZG-CLASS-ID: mo00 From: Olaf Hering To: xen-devel@lists.xenproject.org Cc: Olaf Hering , Juergen Gross , Ian Jackson , Wei Liu Subject: [PATCH v20210701 26/40] tools: restore: move mfns array in populate_pfns Date: Thu, 1 Jul 2021 11:56:21 +0200 Message-Id: <20210701095635.15648-27-olaf@aepfle.de> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210701095635.15648-1-olaf@aepfle.de> References: <20210701095635.15648-1-olaf@aepfle.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Remove allocation from hotpath, move populate_pfns mfns array into preallocated space. Use some prefix to avoid conflict with an array used in handle_page_data. Signed-off-by: Olaf Hering Reviewed-by: Juergen Gross --- tools/libs/saverestore/common.h | 2 ++ tools/libs/saverestore/restore.c | 5 ++--- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/tools/libs/saverestore/common.h b/tools/libs/saverestore/common.h index 7684c35e22..9d2ea96583 100644 --- a/tools/libs/saverestore/common.h +++ b/tools/libs/saverestore/common.h @@ -242,6 +242,8 @@ struct sr_restore_arrays { /* process_page_data */ xen_pfn_t mfns[MAX_BATCH_SIZE]; int map_errs[MAX_BATCH_SIZE]; + /* populate_pfns */ + xen_pfn_t pp_mfns[MAX_BATCH_SIZE]; }; struct xc_sr_context diff --git a/tools/libs/saverestore/restore.c b/tools/libs/saverestore/restore.c index 578ee1accb..7418abf1c5 100644 --- a/tools/libs/saverestore/restore.c +++ b/tools/libs/saverestore/restore.c @@ -138,12 +138,12 @@ int populate_pfns(struct xc_sr_context *ctx, unsigned int count, const xen_pfn_t *original_pfns, const uint32_t *types) { xc_interface *xch = ctx->xch; - xen_pfn_t *mfns = malloc(count * sizeof(*mfns)), + xen_pfn_t *mfns = ctx->restore.m->pp_mfns, *pfns = malloc(count * sizeof(*pfns)); unsigned int i, nr_pfns = 0; int rc = -1; - if ( !mfns || !pfns ) + if ( !pfns ) { ERROR("Failed to allocate %zu bytes for populating the physmap", 2 * count * sizeof(*mfns)); @@ -191,7 +191,6 @@ int populate_pfns(struct xc_sr_context *ctx, unsigned int count, err: free(pfns); - free(mfns); return rc; } From xen-devel-bounces@lists.xenproject.org Thu Jul 01 09:57:28 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 09:57:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148367.274319 (Exim 4.92) (envelope-from ) id 1lytRo-0003a5-DY; Thu, 01 Jul 2021 09:57:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148367.274319; Thu, 01 Jul 2021 09:57:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lytRo-0003Zp-92; Thu, 01 Jul 2021 09:57:28 +0000 Received: by outflank-mailman (input) for mailman id 148367; Thu, 01 Jul 2021 09:57:26 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lytRl-0004XT-SS for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 09:57:25 +0000 Received: from mo4-p02-ob.smtp.rzone.de (unknown [85.215.255.80]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 844743a8-e2aa-4a5c-ba0d-5227f666b505; Thu, 01 Jul 2021 09:56:51 +0000 (UTC) Received: from sender by smtp.strato.de (RZmta 47.28.1 AUTH) with ESMTPSA id 30791cx619uj5Mz (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Thu, 1 Jul 2021 11:56:45 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 844743a8-e2aa-4a5c-ba0d-5227f666b505 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1625133406; s=strato-dkim-0002; d=aepfle.de; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Cc:Date: From:Subject:Sender; bh=HjAuQTbWmPJqlcbKtv74PXHy29j5qe7IwbSTeBBg19U=; b=SjBOdI0lSSEEBQqOqmxQDxpMY6Z2JwrcX6hsX0vTDg6IX2qrCx8zFagH0CYUx9FDE+ wJr0ifynv8UbIBIIvZjp5jAtunFRKxNBT/NdyMtv6pYFgu6xgXfTxqfGXFokLeH9Wjca hrpAgUMNdhwAK5C+hRl9w+nJE6i4D9qc2Jnw4yMlgPYR7BOl9GnbamSFM9Yol9wyHafY 13efq1OZf5k4nXDcCviHNuk4ZS8R8tn9vflUVzmcWboXv4iBmVyE07bkJyBpQRuAVFIo fqU88xLfamB95nhRkQ3M07BpcGhEjF2dYq0mNcafBhglJO4zNjXWmwu+7rglBUC5N6kQ 9wPA== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QXkBR9MXjAuzpIG0mv9coXAg5lqlz7EsstGyDcxK3Mbajr+SQKopp1Cb0CyyaZQQ==" X-RZG-CLASS-ID: mo00 From: Olaf Hering To: xen-devel@lists.xenproject.org Cc: Olaf Hering , Ian Jackson , Wei Liu , Juergen Gross Subject: [PATCH v20210701 14/40] tools: show migration transfer rate in send_dirty_pages Date: Thu, 1 Jul 2021 11:56:09 +0200 Message-Id: <20210701095635.15648-15-olaf@aepfle.de> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210701095635.15648-1-olaf@aepfle.de> References: <20210701095635.15648-1-olaf@aepfle.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Show how fast domU pages are transferred in each iteration. The relevant data is how fast the pfns travel, not so much how much protocol overhead exists. So the reported MiB/sec is just for pfns. Signed-off-by: Olaf Hering v02: - rearrange MiB_sec calculation (jgross) --- tools/libs/saverestore/common.h | 2 ++ tools/libs/saverestore/save.c | 46 +++++++++++++++++++++++++++++++++ 2 files changed, 48 insertions(+) diff --git a/tools/libs/saverestore/common.h b/tools/libs/saverestore/common.h index 905b4078f6..252076cf51 100644 --- a/tools/libs/saverestore/common.h +++ b/tools/libs/saverestore/common.h @@ -250,6 +250,8 @@ struct xc_sr_context bool debug; unsigned long p2m_size; + size_t pages_sent; + size_t overhead_sent; struct precopy_stats stats; diff --git a/tools/libs/saverestore/save.c b/tools/libs/saverestore/save.c index 12598bd4e2..f8fbe7a742 100644 --- a/tools/libs/saverestore/save.c +++ b/tools/libs/saverestore/save.c @@ -1,5 +1,6 @@ #include #include +#include #include "common.h" @@ -238,6 +239,8 @@ static int write_batch(struct xc_sr_context *ctx) iov[3].iov_len = nr_pfns * sizeof(*rec_pfns); iovcnt = 4; + ctx->save.pages_sent += nr_pages; + ctx->save.overhead_sent += sizeof(rec) + sizeof(hdr) + nr_pfns * sizeof(*rec_pfns); if ( nr_pages ) { @@ -357,6 +360,42 @@ static int suspend_domain(struct xc_sr_context *ctx) return 0; } +static void show_transfer_rate(struct xc_sr_context *ctx, struct timespec *start) +{ + xc_interface *xch = ctx->xch; + struct timespec end = {}, diff = {}; + size_t ms, MiB_sec; + + if (!ctx->save.pages_sent) + return; + + if ( clock_gettime(CLOCK_MONOTONIC, &end) ) + PERROR("clock_gettime"); + + if ( (end.tv_nsec - start->tv_nsec) < 0 ) + { + diff.tv_sec = end.tv_sec - start->tv_sec - 1; + diff.tv_nsec = end.tv_nsec - start->tv_nsec + (1000U*1000U*1000U); + } + else + { + diff.tv_sec = end.tv_sec - start->tv_sec; + diff.tv_nsec = end.tv_nsec - start->tv_nsec; + } + + ms = (diff.tv_nsec / (1000U*1000U)); + ms += (diff.tv_sec * 1000U); + if (!ms) + ms = 1; + + MiB_sec = (ctx->save.pages_sent * PAGE_SIZE * 1000U) / ms / (1024U*1024U); + + errno = 0; + IPRINTF("%s: %zu bytes + %zu pages in %ld.%09ld sec, %zu MiB/sec", __func__, + ctx->save.overhead_sent, ctx->save.pages_sent, + diff.tv_sec, diff.tv_nsec, MiB_sec); +} + /* * Send a subset of pages in the guests p2m, according to the dirty bitmap. * Used for each subsequent iteration of the live migration loop. @@ -370,9 +409,15 @@ static int send_dirty_pages(struct xc_sr_context *ctx, xen_pfn_t p; unsigned long written; int rc; + struct timespec start = {}; DECLARE_HYPERCALL_BUFFER_SHADOW(unsigned long, dirty_bitmap, &ctx->save.dirty_bitmap_hbuf); + ctx->save.pages_sent = 0; + ctx->save.overhead_sent = 0; + if ( clock_gettime(CLOCK_MONOTONIC, &start) ) + PERROR("clock_gettime"); + for ( p = 0, written = 0; p < ctx->save.p2m_size; ++p ) { if ( !test_bit(p, dirty_bitmap) ) @@ -396,6 +441,7 @@ static int send_dirty_pages(struct xc_sr_context *ctx, if ( written > entries ) DPRINTF("Bitmap contained more entries than expected..."); + show_transfer_rate(ctx, &start); xc_report_progress_step(xch, entries, entries); return ctx->save.ops.check_vm_state(ctx); From xen-devel-bounces@lists.xenproject.org Thu Jul 01 09:57:29 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 09:57:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148369.274324 (Exim 4.92) (envelope-from ) id 1lytRp-0003di-2h; Thu, 01 Jul 2021 09:57:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148369.274324; Thu, 01 Jul 2021 09:57:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lytRo-0003cV-NY; Thu, 01 Jul 2021 09:57:28 +0000 Received: by outflank-mailman (input) for mailman id 148369; Thu, 01 Jul 2021 09:57:27 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lytRn-0004r4-H2 for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 09:57:27 +0000 Received: from mo4-p03-ob.smtp.rzone.de (unknown [85.215.255.102]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 7318a437-6aec-4f53-a2a0-10214f3fbcac; Thu, 01 Jul 2021 09:56:57 +0000 (UTC) Received: from sender by smtp.strato.de (RZmta 47.28.1 AUTH) with ESMTPSA id 30791cx619un5NE (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Thu, 1 Jul 2021 11:56:49 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7318a437-6aec-4f53-a2a0-10214f3fbcac DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1625133409; s=strato-dkim-0002; d=aepfle.de; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Cc:Date: From:Subject:Sender; bh=VXXP7tsnRC41xaA88qzwrHhQNrSFmDSbSlav6Il7DHM=; b=nek8SgSXMYp0YyFkVQajq+6uAJthx4pNaB9Z7RNljK3npjfWHTOJMlzeveUeT19Qxh C/fpM2lj2ShtHYL2QqLRL5+Qe7jOSTRRdMFpFspPLIy0nC5Dqcico76IlIqTmOHTTdQ2 xKw2M4fnke3Z4OivG0VsFPM9ddzkhn7LgJhb2K5dcjmMm2ExIl+Ul5F5tG6TyxpS2c0M DIZQu4aL5NWfl2XkGcIukLAwSql3alv6ieqLDsyD87t5zbw9uZv3pZbrZHLI2XqEvire GsMFVQpwxh3d02bJrqCatpgwaFVPsd2R9skFSpklyDUoKVBpx4tonUlnlAM7p/JJZjTs Wsfw== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QXkBR9MXjAuzpIG0mv9coXAg5lqlz7EsstGyDcxK3Mbajr+SQKopp1Cb0CyyaZQQ==" X-RZG-CLASS-ID: mo00 From: Olaf Hering To: xen-devel@lists.xenproject.org Cc: Olaf Hering , Juergen Gross , Ian Jackson , Wei Liu Subject: [PATCH v20210701 22/40] tools: save: move local_pages array Date: Thu, 1 Jul 2021 11:56:17 +0200 Message-Id: <20210701095635.15648-23-olaf@aepfle.de> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210701095635.15648-1-olaf@aepfle.de> References: <20210701095635.15648-1-olaf@aepfle.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Remove allocation from hotpath, move local_pages array into preallocated space. Adjust the code to use the src page as is in case of HVM. In case of PV the page may need to be normalised, use a private memory area for this purpose. Signed-off-by: Olaf Hering Reviewed-by: Juergen Gross --- tools/libs/saverestore/common.h | 22 ++++++++++--------- tools/libs/saverestore/save.c | 25 +++------------------ tools/libs/saverestore/save_x86_hvm.c | 5 +++-- tools/libs/saverestore/save_x86_pv.c | 31 ++++++++++++++++++--------- 4 files changed, 39 insertions(+), 44 deletions(-) diff --git a/tools/libs/saverestore/common.h b/tools/libs/saverestore/common.h index c3570e0c9a..8089449011 100644 --- a/tools/libs/saverestore/common.h +++ b/tools/libs/saverestore/common.h @@ -45,16 +45,12 @@ struct xc_sr_save_ops * Optionally transform the contents of a page from being specific to the * sending environment, to being generic for the stream. * - * The page of data at the end of 'page' may be a read-only mapping of a - * running guest; it must not be modified. If no transformation is - * required, the callee should leave '*pages' untouched. + * The page of data '*src' may be a read-only mapping of a running guest; + * it must not be modified. If no transformation is required, the callee + * should leave '*src' untouched, and return it via '**ptr'. * - * If a transformation is required, the callee should allocate themselves - * a local page using malloc() and return it via '*page'. - * - * The caller shall free() '*page' in all cases. In the case that the - * callee encounters an error, it should *NOT* free() the memory it - * allocated for '*page'. + * If a transformation is required, the callee should provide the + * transformed page in a private buffer and return it via '**ptr'. * * It is valid to fail with EAGAIN if the transformation is not able to be * completed at this point. The page shall be retried later. @@ -62,7 +58,7 @@ struct xc_sr_save_ops * @returns 0 for success, -1 for failure, with errno appropriately set. */ int (*normalise_page)(struct xc_sr_context *ctx, xen_pfn_t type, - void **page); + void *src, unsigned int idx, void **ptr); /** * Set up local environment to save a domain. (Typically querying @@ -385,6 +381,12 @@ struct xc_sr_context union { + struct + { + /* Used by write_batch for modified pages. */ + void *normalised_pages; + } save; + struct { /* State machine for the order of received records. */ diff --git a/tools/libs/saverestore/save.c b/tools/libs/saverestore/save.c index ea04cb1a74..fa83648f9a 100644 --- a/tools/libs/saverestore/save.c +++ b/tools/libs/saverestore/save.c @@ -91,11 +91,10 @@ static int write_batch(struct xc_sr_context *ctx) xen_pfn_t *mfns = ctx->save.m->mfns, *types = ctx->save.m->types; void *guest_mapping = NULL; void **guest_data = ctx->save.m->guest_data; - void **local_pages = NULL; int *errors = ctx->save.m->errors, rc = -1; unsigned int i, p, nr_pages = 0, nr_pages_mapped = 0; unsigned int nr_pfns = ctx->save.nr_batch_pfns; - void *page, *orig_page; + void *src; uint64_t *rec_pfns = ctx->save.m->rec_pfns; struct iovec *iov = ctx->save.m->iov; int iovcnt = 0; struct xc_sr_rec_page_data_header hdr = { 0 }; @@ -105,16 +104,6 @@ static int write_batch(struct xc_sr_context *ctx) assert(nr_pfns != 0); - /* Pointers to locally allocated pages. Need freeing. */ - local_pages = calloc(nr_pfns, sizeof(*local_pages)); - - if ( !local_pages ) - { - ERROR("Unable to allocate arrays for a batch of %u pages", - nr_pfns); - goto err; - } - for ( i = 0; i < nr_pfns; ++i ) { types[i] = mfns[i] = ctx->save.ops.pfn_to_gfn(ctx, @@ -176,11 +165,8 @@ static int write_batch(struct xc_sr_context *ctx) goto err; } - orig_page = page = guest_mapping + (p * PAGE_SIZE); - rc = ctx->save.ops.normalise_page(ctx, types[i], &page); - - if ( orig_page != page ) - local_pages[i] = page; + src = guest_mapping + (p * PAGE_SIZE); + rc = ctx->save.ops.normalise_page(ctx, types[i], src, i, &guest_data[i]); if ( rc ) { @@ -195,8 +181,6 @@ static int write_batch(struct xc_sr_context *ctx) else goto err; } - else - guest_data[i] = page; rc = -1; ++p; @@ -255,9 +239,6 @@ static int write_batch(struct xc_sr_context *ctx) err: if ( guest_mapping ) xenforeignmemory_unmap(xch->fmem, guest_mapping, nr_pages_mapped); - for ( i = 0; local_pages && i < nr_pfns; ++i ) - free(local_pages[i]); - free(local_pages); return rc; } diff --git a/tools/libs/saverestore/save_x86_hvm.c b/tools/libs/saverestore/save_x86_hvm.c index 91c2cb99ab..26f49ee267 100644 --- a/tools/libs/saverestore/save_x86_hvm.c +++ b/tools/libs/saverestore/save_x86_hvm.c @@ -129,9 +129,10 @@ static xen_pfn_t x86_hvm_pfn_to_gfn(const struct xc_sr_context *ctx, return pfn; } -static int x86_hvm_normalise_page(struct xc_sr_context *ctx, - xen_pfn_t type, void **page) +static int x86_hvm_normalise_page(struct xc_sr_context *ctx, xen_pfn_t type, + void *src, unsigned int idx, void **ptr) { + *ptr = src; return 0; } diff --git a/tools/libs/saverestore/save_x86_pv.c b/tools/libs/saverestore/save_x86_pv.c index 92f77fad0f..159ff59480 100644 --- a/tools/libs/saverestore/save_x86_pv.c +++ b/tools/libs/saverestore/save_x86_pv.c @@ -999,29 +999,31 @@ static xen_pfn_t x86_pv_pfn_to_gfn(const struct xc_sr_context *ctx, * save_ops function. Performs pagetable normalisation on appropriate pages. */ static int x86_pv_normalise_page(struct xc_sr_context *ctx, xen_pfn_t type, - void **page) + void *src, unsigned int idx, void **ptr) { xc_interface *xch = ctx->xch; - void *local_page; int rc; + void *dst; type &= XEN_DOMCTL_PFINFO_LTABTYPE_MASK; if ( type < XEN_DOMCTL_PFINFO_L1TAB || type > XEN_DOMCTL_PFINFO_L4TAB ) + { + *ptr = src; return 0; + } - local_page = malloc(PAGE_SIZE); - if ( !local_page ) + if ( idx >= MAX_BATCH_SIZE ) { - ERROR("Unable to allocate scratch page"); - rc = -1; - goto out; + ERROR("idx %u out of range", idx); + errno = ERANGE; + return -1; } - rc = normalise_pagetable(ctx, *page, local_page, type); - *page = local_page; + dst = ctx->x86.pv.save.normalised_pages + idx * PAGE_SIZE; + rc = normalise_pagetable(ctx, src, dst, type); + *ptr = dst; - out: return rc; } @@ -1031,8 +1033,16 @@ static int x86_pv_normalise_page(struct xc_sr_context *ctx, xen_pfn_t type, */ static int x86_pv_setup(struct xc_sr_context *ctx) { + xc_interface *xch = ctx->xch; int rc; + ctx->x86.pv.save.normalised_pages = malloc(MAX_BATCH_SIZE * PAGE_SIZE); + if ( !ctx->x86.pv.save.normalised_pages ) + { + PERROR("Failed to allocate normalised_pages"); + return -1; + } + rc = x86_pv_domain_info(ctx); if ( rc ) return rc; @@ -1118,6 +1128,7 @@ static int x86_pv_check_vm_state(struct xc_sr_context *ctx) static int x86_pv_cleanup(struct xc_sr_context *ctx) { + free(ctx->x86.pv.save.normalised_pages); free(ctx->x86.pv.p2m_pfns); if ( ctx->x86.pv.p2m ) From xen-devel-bounces@lists.xenproject.org Thu Jul 01 09:57:32 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 09:57:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148371.274341 (Exim 4.92) (envelope-from ) id 1lytRs-0004Q7-6I; Thu, 01 Jul 2021 09:57:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148371.274341; Thu, 01 Jul 2021 09:57:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lytRr-0004PF-S8; Thu, 01 Jul 2021 09:57:31 +0000 Received: by outflank-mailman (input) for mailman id 148371; Thu, 01 Jul 2021 09:57:31 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lytRq-0004XT-Sn for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 09:57:30 +0000 Received: from mo4-p02-ob.smtp.rzone.de (unknown [81.169.146.168]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 8e4898ce-ebf0-4c88-89ea-58c01de1f9ad; Thu, 01 Jul 2021 09:56:51 +0000 (UTC) Received: from sender by smtp.strato.de (RZmta 47.28.1 AUTH) with ESMTPSA id 30791cx619uj5Mv (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Thu, 1 Jul 2021 11:56:45 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8e4898ce-ebf0-4c88-89ea-58c01de1f9ad DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1625133405; s=strato-dkim-0002; d=aepfle.de; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Cc:Date: From:Subject:Sender; bh=GgpmM75SuN6FuifeSB8D7d7fIQ+maSMtt/6dbwwV1Ko=; b=fiU5zy87RwXUPFQisX2pONK2at9yvFQtBp4h+9vdYhCJe+SDgRUQXXk+jxeGclFdqd Ev2LkmLKf+hBiwswf4p6m1UocGilzfNq+eBXul8GlnD3tJWgjyH/+kEmDoWYxezduoTK CgAiWo/H73nDfl4vEdBQL/9mwk1YrznITa/wIbO7lEFxg8M4Y2M2MjirFLgVM5KHavnD o6hXDTKFpCQCA1/rR+MXQhWjIDDh4rJFu8I2L2Yj/mnCcTiDu0OVAI+SlScDm0hgsPM1 V0sAhTynfn9HTOUc/kLsT/4Nia9xhWLPZLdRWlwHfM1TNqpUmW8d9jFfjBD7/s7720hk yd6g== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QXkBR9MXjAuzpIG0mv9coXAg5lqlz7EsstGyDcxK3Mbajr+SQKopp1Cb0CyyaZQQ==" X-RZG-CLASS-ID: mo00 From: Olaf Hering To: xen-devel@lists.xenproject.org Cc: Olaf Hering , Ian Jackson , Wei Liu , Juergen Gross Subject: [PATCH v20210701 13/40] tools: unify type checking for data pfns in migration stream Date: Thu, 1 Jul 2021 11:56:08 +0200 Message-Id: <20210701095635.15648-14-olaf@aepfle.de> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210701095635.15648-1-olaf@aepfle.de> References: <20210701095635.15648-1-olaf@aepfle.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Introduce a helper which decides if a given pfn type has data in the migration stream. No change in behavior intended. Signed-off-by: Olaf Hering --- tools/libs/saverestore/common.h | 18 ++++++++++++++++++ tools/libs/saverestore/restore.c | 29 +++-------------------------- tools/libs/saverestore/save.c | 14 ++------------ 3 files changed, 23 insertions(+), 38 deletions(-) diff --git a/tools/libs/saverestore/common.h b/tools/libs/saverestore/common.h index fa242e808d..905b4078f6 100644 --- a/tools/libs/saverestore/common.h +++ b/tools/libs/saverestore/common.h @@ -517,6 +517,24 @@ static inline bool page_type_to_populate(uint32_t type) } return ret; } + +static inline bool page_type_has_stream_data(uint32_t type) +{ + bool ret; + + switch (type) + { + case XEN_DOMCTL_PFINFO_BROKEN: + case XEN_DOMCTL_PFINFO_XALLOC: + case XEN_DOMCTL_PFINFO_XTAB: + ret = false; + break; + default: + ret = true; + break; + } + return ret; +} #endif /* * Local variables: diff --git a/tools/libs/saverestore/restore.c b/tools/libs/saverestore/restore.c index 477b7527a1..799170c7a1 100644 --- a/tools/libs/saverestore/restore.c +++ b/tools/libs/saverestore/restore.c @@ -232,25 +232,8 @@ static int process_page_data(struct xc_sr_context *ctx, unsigned int count, { ctx->restore.ops.set_page_type(ctx, pfns[i], types[i]); - switch ( types[i] ) - { - case XEN_DOMCTL_PFINFO_NOTAB: - - case XEN_DOMCTL_PFINFO_L1TAB: - case XEN_DOMCTL_PFINFO_L1TAB | XEN_DOMCTL_PFINFO_LPINTAB: - - case XEN_DOMCTL_PFINFO_L2TAB: - case XEN_DOMCTL_PFINFO_L2TAB | XEN_DOMCTL_PFINFO_LPINTAB: - - case XEN_DOMCTL_PFINFO_L3TAB: - case XEN_DOMCTL_PFINFO_L3TAB | XEN_DOMCTL_PFINFO_LPINTAB: - - case XEN_DOMCTL_PFINFO_L4TAB: - case XEN_DOMCTL_PFINFO_L4TAB | XEN_DOMCTL_PFINFO_LPINTAB: - + if ( page_type_has_stream_data(types[i]) == true ) mfns[nr_pages++] = ctx->restore.ops.pfn_to_gfn(ctx, pfns[i]); - break; - } } /* Nothing to do? */ @@ -270,14 +253,8 @@ static int process_page_data(struct xc_sr_context *ctx, unsigned int count, for ( i = 0, j = 0; i < count; ++i ) { - switch ( types[i] ) - { - case XEN_DOMCTL_PFINFO_XTAB: - case XEN_DOMCTL_PFINFO_BROKEN: - case XEN_DOMCTL_PFINFO_XALLOC: - /* No page data to deal with. */ + if ( page_type_has_stream_data(types[i]) == false ) continue; - } if ( map_errs[j] ) { @@ -412,7 +389,7 @@ static int handle_page_data(struct xc_sr_context *ctx, struct xc_sr_record *rec) goto err; } - if ( type < XEN_DOMCTL_PFINFO_BROKEN ) + if ( page_type_has_stream_data(type) == true ) /* NOTAB and all L1 through L4 tables (including pinned) should * have a page worth of data in the record. */ pages_of_data++; diff --git a/tools/libs/saverestore/save.c b/tools/libs/saverestore/save.c index 6f820ea432..12598bd4e2 100644 --- a/tools/libs/saverestore/save.c +++ b/tools/libs/saverestore/save.c @@ -153,13 +153,8 @@ static int write_batch(struct xc_sr_context *ctx) goto err; } - switch ( types[i] ) - { - case XEN_DOMCTL_PFINFO_BROKEN: - case XEN_DOMCTL_PFINFO_XALLOC: - case XEN_DOMCTL_PFINFO_XTAB: + if ( page_type_has_stream_data(types[i]) == false ) continue; - } mfns[nr_pages++] = mfns[i]; } @@ -177,13 +172,8 @@ static int write_batch(struct xc_sr_context *ctx) for ( i = 0, p = 0; i < nr_pfns; ++i ) { - switch ( types[i] ) - { - case XEN_DOMCTL_PFINFO_BROKEN: - case XEN_DOMCTL_PFINFO_XALLOC: - case XEN_DOMCTL_PFINFO_XTAB: + if ( page_type_has_stream_data(types[i]) == false ) continue; - } if ( errors[p] ) { From xen-devel-bounces@lists.xenproject.org Thu Jul 01 09:57:34 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 09:57:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148372.274351 (Exim 4.92) (envelope-from ) id 1lytRu-0004xk-8j; Thu, 01 Jul 2021 09:57:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148372.274351; Thu, 01 Jul 2021 09:57:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lytRt-0004vX-Rc; Thu, 01 Jul 2021 09:57:33 +0000 Received: by outflank-mailman (input) for mailman id 148372; Thu, 01 Jul 2021 09:57:32 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lytRs-0004r4-Gv for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 09:57:32 +0000 Received: from mo4-p03-ob.smtp.rzone.de (unknown [81.169.146.174]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 939893d0-0ec4-4a0f-851d-a8ce2ba947db; Thu, 01 Jul 2021 09:56:58 +0000 (UTC) Received: from sender by smtp.strato.de (RZmta 47.28.1 AUTH) with ESMTPSA id 30791cx619ur5NU (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Thu, 1 Jul 2021 11:56:53 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 939893d0-0ec4-4a0f-851d-a8ce2ba947db DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1625133413; s=strato-dkim-0002; d=aepfle.de; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Cc:Date: From:Subject:Sender; bh=0LMXyjqr5dhJU6Kt86LbarPPbfCTtmro+NAOq1cH7Ts=; b=seFXjeMiXQjNm4nJiNtEFRc+qmrE0unG8gUnEIVDqgAeVpEvsTsvGZSg4/4ql9gK8g cdFrWui1BKKNZGYpm40Ag3p60mxyBCejkMlVaK/sVCdOsCK8dMAG2+mHagXV4SI3yqh8 UZsS1DtArQncExBuQWRlMmpBc4oCSmmIDhlT3Fza8Zwpv1GYEXZU7ZuOnyhGYOA3etGI CIg6Y/lHH3UpqRrT45x+1nI6IFWL4RGo4yxOVk0/gvPL+lFDJyOoKwRIK9lUyFiHj9Cn ruKBzH319FojoxPzWwdJxefYUWRPoursepKTRW6/ePrJizBiGdusb6Y7I+DtbZeC45zA 2yNA== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QXkBR9MXjAuzpIG0mv9coXAg5lqlz7EsstGyDcxK3Mbajr+SQKopp1Cb0CyyaZQQ==" X-RZG-CLASS-ID: mo00 From: Olaf Hering To: xen-devel@lists.xenproject.org Cc: Olaf Hering , Ian Jackson , Wei Liu Subject: [PATCH v20210701 31/40] tools: recognize LIBXL_API_VERSION for 4.16 Date: Thu, 1 Jul 2021 11:56:26 +0200 Message-Id: <20210701095635.15648-32-olaf@aepfle.de> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210701095635.15648-1-olaf@aepfle.de> References: <20210701095635.15648-1-olaf@aepfle.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This is required by upcoming API changes. Signed-off-by: Olaf Hering --- tools/include/libxl.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/include/libxl.h b/tools/include/libxl.h index ae7fe27c1f..29931626a2 100644 --- a/tools/include/libxl.h +++ b/tools/include/libxl.h @@ -729,7 +729,8 @@ typedef struct libxl__ctx libxl_ctx; #if LIBXL_API_VERSION != 0x040200 && LIBXL_API_VERSION != 0x040300 && \ LIBXL_API_VERSION != 0x040400 && LIBXL_API_VERSION != 0x040500 && \ LIBXL_API_VERSION != 0x040700 && LIBXL_API_VERSION != 0x040800 && \ - LIBXL_API_VERSION != 0x041300 && LIBXL_API_VERSION != 0x041400 + LIBXL_API_VERSION != 0x041300 && LIBXL_API_VERSION != 0x041400 && \ + LIBXL_API_VERSION != 0x041600 #error Unknown LIBXL_API_VERSION #endif #endif From xen-devel-bounces@lists.xenproject.org Thu Jul 01 10:01:38 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 10:01:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148404.274375 (Exim 4.92) (envelope-from ) id 1lytVp-0000pB-22; Thu, 01 Jul 2021 10:01:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148404.274375; Thu, 01 Jul 2021 10:01:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lytVo-0000p4-Ut; Thu, 01 Jul 2021 10:01:36 +0000 Received: by outflank-mailman (input) for mailman id 148404; Thu, 01 Jul 2021 10:01:35 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lytSP-0004XT-Tc for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 09:58:05 +0000 Received: from mo4-p03-ob.smtp.rzone.de (unknown [85.215.255.100]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id f8574b62-670a-4575-96ac-f040367c0885; Thu, 01 Jul 2021 09:56:56 +0000 (UTC) Received: from sender by smtp.strato.de (RZmta 47.28.1 AUTH) with ESMTPSA id 30791cx619uo5NH (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Thu, 1 Jul 2021 11:56:50 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f8574b62-670a-4575-96ac-f040367c0885 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1625133410; s=strato-dkim-0002; d=aepfle.de; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Cc:Date: From:Subject:Sender; bh=bOrjMbCsuneuqIIJGmLTblCtP85a/JTG2OAkzH1Hjtw=; b=UySDWzQOP77+pL/xjXP2xA3spFqJTyKI8ZU213fh6F8cBA86GlpSiFZxX8QijfCNiw Jfo3XaYQmD3whcWUQshSBLK4zqALkCB4lyYz3Bo1T5nVTNxYygD7FHny+M4MHwX1P8Iy paU6qPJ8lEqBgUoarSRb2cuD4xtDMc5TZdUK99UpSZvbM6gCxi5CXpysGzLtvDFuY60l ogE8q5SN6+rVMh8z4U/iK+rg3FX6AhHwq5kBEYSci+saoI7LuxBgqUFB6YL28x2wKA78 g1FYYIEd8SOTGJW+Q8Zq7QqZy5EjvlO9Katji2gV5+5mRz1AmE+b6g97qYL6rykTniZ2 juEg== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QXkBR9MXjAuzpIG0mv9coXAg5lqlz7EsstGyDcxK3Mbajr+SQKopp1Cb0CyyaZQQ==" X-RZG-CLASS-ID: mo00 From: Olaf Hering To: xen-devel@lists.xenproject.org Cc: Olaf Hering , Juergen Gross , Ian Jackson , Wei Liu Subject: [PATCH v20210701 24/40] tools: restore: move mfns array Date: Thu, 1 Jul 2021 11:56:19 +0200 Message-Id: <20210701095635.15648-25-olaf@aepfle.de> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210701095635.15648-1-olaf@aepfle.de> References: <20210701095635.15648-1-olaf@aepfle.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Remove allocation from hotpath, move mfns array into preallocated space. Signed-off-by: Olaf Hering Reviewed-by: Juergen Gross --- tools/libs/saverestore/common.h | 2 ++ tools/libs/saverestore/restore.c | 5 ++--- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/tools/libs/saverestore/common.h b/tools/libs/saverestore/common.h index d798b79745..9d7efff03d 100644 --- a/tools/libs/saverestore/common.h +++ b/tools/libs/saverestore/common.h @@ -239,6 +239,8 @@ struct sr_restore_arrays { /* handle_page_data */ xen_pfn_t pfns[MAX_BATCH_SIZE]; uint32_t types[MAX_BATCH_SIZE]; + /* process_page_data */ + xen_pfn_t mfns[MAX_BATCH_SIZE]; }; struct xc_sr_context diff --git a/tools/libs/saverestore/restore.c b/tools/libs/saverestore/restore.c index 8ea125cf73..d7ea52b89e 100644 --- a/tools/libs/saverestore/restore.c +++ b/tools/libs/saverestore/restore.c @@ -205,7 +205,7 @@ static int process_page_data(struct xc_sr_context *ctx, unsigned int count, xen_pfn_t *pfns, uint32_t *types, void *page_data) { xc_interface *xch = ctx->xch; - xen_pfn_t *mfns = malloc(count * sizeof(*mfns)); + xen_pfn_t *mfns = ctx->restore.m->mfns; int *map_errs = malloc(count * sizeof(*map_errs)); int rc; void *mapping = NULL, *guest_page = NULL; @@ -213,7 +213,7 @@ static int process_page_data(struct xc_sr_context *ctx, unsigned int count, j, /* j indexes the subset of pfns we decide to map. */ nr_pages = 0; - if ( !mfns || !map_errs ) + if ( !map_errs ) { rc = -1; ERROR("Failed to allocate %zu bytes to process page data", @@ -299,7 +299,6 @@ static int process_page_data(struct xc_sr_context *ctx, unsigned int count, xenforeignmemory_unmap(xch->fmem, mapping, nr_pages); free(map_errs); - free(mfns); return rc; } From xen-devel-bounces@lists.xenproject.org Thu Jul 01 10:01:38 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 10:01:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148400.274364 (Exim 4.92) (envelope-from ) id 1lytVn-0000Yy-QB; Thu, 01 Jul 2021 10:01:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148400.274364; Thu, 01 Jul 2021 10:01:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lytVn-0000Yr-Ml; Thu, 01 Jul 2021 10:01:35 +0000 Received: by outflank-mailman (input) for mailman id 148400; Thu, 01 Jul 2021 10:01:34 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lytSM-0004r4-I9 for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 09:58:02 +0000 Received: from mo4-p04-ob.smtp.rzone.de (unknown [85.215.255.122]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 1484be7f-e3e1-4bc4-ab2f-7a05b66e3d57; Thu, 01 Jul 2021 09:57:03 +0000 (UTC) Received: from sender by smtp.strato.de (RZmta 47.28.1 AUTH) with ESMTPSA id 30791cx619uw5Nl (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Thu, 1 Jul 2021 11:56:58 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1484be7f-e3e1-4bc4-ab2f-7a05b66e3d57 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1625133418; s=strato-dkim-0002; d=aepfle.de; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Cc:Date: From:Subject:Sender; bh=Oumv/ZrrKNwjWjAhsQKBr42sudweonBRtwKbyL8SE78=; b=IydUb5tErdauBPAIJFpbM8CuvoK9RaRo2nZFUhcwRrajNbMwvAvcEtGQBd9vJtZec0 Nl0NJfWLBwXaEA3C5u6S3Eh76OlZW8zwH3kxa46UVDGk2icwpahjTyNBEMGIWr7jTYt0 1coCcLp67mgcr+rLn51crUs05ZxIjRuC76I+JfQ9bOdAgfm2LAyXlNTEWNmc0GhDFALa S+19YftOqIvZ2kgYNVz2V+g8UGObGDigiFdmhyeFbTiiBODeqjAmPs3dm34a3jTRLL1m ajm/TWPsmpOy9YwGv8VKD2BVbAy+Zo1X4vH+EDJMeGB2K2CdDhBfHDR4jEm2wsWc4VW5 h+LA== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QXkBR9MXjAuzpIG0mv9coXAg5lqlz7EsstGyDcxK3Mbajr+SQKopp1Cb0CyyaZQQ==" X-RZG-CLASS-ID: mo00 From: Olaf Hering To: xen-devel@lists.xenproject.org Cc: Olaf Hering , Ian Jackson , Wei Liu , Juergen Gross Subject: [PATCH v20210701 39/40] tools: use xg_sr_bitmap for populated_pfns Date: Thu, 1 Jul 2021 11:56:34 +0200 Message-Id: <20210701095635.15648-40-olaf@aepfle.de> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210701095635.15648-1-olaf@aepfle.de> References: <20210701095635.15648-1-olaf@aepfle.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Signed-off-by: Olaf Hering v02: - remove xg_ prefix from called functions --- tools/libs/saverestore/common.h | 21 +++++++- tools/libs/saverestore/restore.c | 69 ------------------------ tools/libs/saverestore/restore_x86_hvm.c | 9 ++++ tools/libs/saverestore/restore_x86_pv.c | 7 +++ 4 files changed, 35 insertions(+), 71 deletions(-) diff --git a/tools/libs/saverestore/common.h b/tools/libs/saverestore/common.h index e6a269c482..a610483fe7 100644 --- a/tools/libs/saverestore/common.h +++ b/tools/libs/saverestore/common.h @@ -403,8 +403,7 @@ struct xc_sr_context uint32_t xenstore_domid, console_domid; /* Bitmap of currently populated PFNs during restore. */ - unsigned long *populated_pfns; - xen_pfn_t max_populated_pfn; + struct sr_bitmap populated_pfns; /* Sender has invoked verify mode on the stream. */ bool verify; @@ -647,6 +646,24 @@ static inline bool page_type_has_stream_data(uint32_t type) } return ret; } + +static inline bool pfn_is_populated(struct xc_sr_context *ctx, xen_pfn_t pfn) +{ + return sr_test_bit(pfn, &ctx->restore.populated_pfns); +} + +static inline int pfn_set_populated(struct xc_sr_context *ctx, xen_pfn_t pfn) +{ + xc_interface *xch = ctx->xch; + + if ( sr_set_bit(pfn, &ctx->restore.populated_pfns) == false ) + { + PERROR("Failed to realloc populated_pfns bitmap"); + errno = ENOMEM; + return -1; + } + return 0; +} #endif /* * Local variables: diff --git a/tools/libs/saverestore/restore.c b/tools/libs/saverestore/restore.c index 53f05f1b65..baf8ea44e5 100644 --- a/tools/libs/saverestore/restore.c +++ b/tools/libs/saverestore/restore.c @@ -71,64 +71,6 @@ static int read_headers(struct xc_sr_context *ctx) return 0; } -/* - * Is a pfn populated? - */ -static bool pfn_is_populated(const struct xc_sr_context *ctx, xen_pfn_t pfn) -{ - if ( pfn > ctx->restore.max_populated_pfn ) - return false; - return test_bit(pfn, ctx->restore.populated_pfns); -} - -/* - * Set a pfn as populated, expanding the tracking structures if needed. To - * avoid realloc()ing too excessively, the size increased to the nearest power - * of two large enough to contain the required pfn. - */ -static int pfn_set_populated(struct xc_sr_context *ctx, xen_pfn_t pfn) -{ - xc_interface *xch = ctx->xch; - - if ( pfn > ctx->restore.max_populated_pfn ) - { - xen_pfn_t new_max; - size_t old_sz, new_sz; - unsigned long *p; - - /* Round up to the nearest power of two larger than pfn, less 1. */ - new_max = pfn; - new_max |= new_max >> 1; - new_max |= new_max >> 2; - new_max |= new_max >> 4; - new_max |= new_max >> 8; - new_max |= new_max >> 16; -#ifdef __x86_64__ - new_max |= new_max >> 32; -#endif - - old_sz = bitmap_size(ctx->restore.max_populated_pfn + 1); - new_sz = bitmap_size(new_max + 1); - p = realloc(ctx->restore.populated_pfns, new_sz); - if ( !p ) - { - ERROR("Failed to realloc populated bitmap"); - errno = ENOMEM; - return -1; - } - - memset((uint8_t *)p + old_sz, 0x00, new_sz - old_sz); - - ctx->restore.populated_pfns = p; - ctx->restore.max_populated_pfn = new_max; - } - - assert(!test_bit(pfn, ctx->restore.populated_pfns)); - set_bit(pfn, ctx->restore.populated_pfns); - - return 0; -} - /* * Given a set of pfns, obtain memory from Xen to fill the physmap for the * unpopulated subset. If types is NULL, no page type checking is performed @@ -929,16 +871,6 @@ static int setup(struct xc_sr_context *ctx) if ( rc ) goto err; - ctx->restore.max_populated_pfn = (32 * 1024 / 4) - 1; - ctx->restore.populated_pfns = bitmap_alloc( - ctx->restore.max_populated_pfn + 1); - if ( !ctx->restore.populated_pfns ) - { - ERROR("Unable to allocate memory for populated_pfns bitmap"); - rc = -1; - goto err; - } - ctx->restore.buffered_records = malloc( DEFAULT_BUF_RECORDS * sizeof(struct xc_sr_record)); if ( !ctx->restore.buffered_records ) @@ -977,7 +909,6 @@ static void cleanup(struct xc_sr_context *ctx) free(ctx->restore.m); free(ctx->restore.buffered_records); - free(ctx->restore.populated_pfns); if ( ctx->restore.ops.cleanup(ctx) ) PERROR("Failed to clean up"); diff --git a/tools/libs/saverestore/restore_x86_hvm.c b/tools/libs/saverestore/restore_x86_hvm.c index bd63bd2818..97e7e0f48c 100644 --- a/tools/libs/saverestore/restore_x86_hvm.c +++ b/tools/libs/saverestore/restore_x86_hvm.c @@ -136,6 +136,7 @@ static int x86_hvm_localise_page(struct xc_sr_context *ctx, static int x86_hvm_setup(struct xc_sr_context *ctx) { xc_interface *xch = ctx->xch; + unsigned long max_pfn; if ( ctx->restore.guest_type != DHDR_TYPE_X86_HVM ) { @@ -161,6 +162,13 @@ static int x86_hvm_setup(struct xc_sr_context *ctx) } #endif + max_pfn = max(ctx->restore.p2m_size, ctx->dominfo.max_memkb >> (PAGE_SHIFT-10)); + if ( !sr_bitmap_expand(&ctx->restore.populated_pfns, max_pfn) ) + { + PERROR("Unable to allocate memory for populated_pfns bitmap"); + return -1; + } + return 0; } @@ -241,6 +249,7 @@ static int x86_hvm_stream_complete(struct xc_sr_context *ctx) static int x86_hvm_cleanup(struct xc_sr_context *ctx) { + sr_bitmap_free(&ctx->restore.populated_pfns); free(ctx->x86.hvm.restore.context.ptr); free(ctx->x86.restore.cpuid.ptr); diff --git a/tools/libs/saverestore/restore_x86_pv.c b/tools/libs/saverestore/restore_x86_pv.c index 96608e5231..c73a3cd99f 100644 --- a/tools/libs/saverestore/restore_x86_pv.c +++ b/tools/libs/saverestore/restore_x86_pv.c @@ -1060,6 +1060,12 @@ static int x86_pv_setup(struct xc_sr_context *ctx) if ( rc ) return rc; + if ( !sr_bitmap_expand(&ctx->restore.populated_pfns, 32 * 1024 / 4) ) + { + PERROR("Unable to allocate memory for populated_pfns bitmap"); + return -1; + } + ctx->x86.pv.restore.nr_vcpus = ctx->dominfo.max_vcpu_id + 1; ctx->x86.pv.restore.vcpus = calloc(sizeof(struct xc_sr_x86_pv_restore_vcpu), ctx->x86.pv.restore.nr_vcpus); @@ -1153,6 +1159,7 @@ static int x86_pv_stream_complete(struct xc_sr_context *ctx) */ static int x86_pv_cleanup(struct xc_sr_context *ctx) { + sr_bitmap_free(&ctx->restore.populated_pfns); free(ctx->x86.pv.p2m); free(ctx->x86.pv.p2m_pfns); From xen-devel-bounces@lists.xenproject.org Thu Jul 01 10:01:44 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 10:01:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148406.274386 (Exim 4.92) (envelope-from ) id 1lytVw-0001Cn-DO; Thu, 01 Jul 2021 10:01:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148406.274386; Thu, 01 Jul 2021 10:01:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lytVw-0001CU-8P; Thu, 01 Jul 2021 10:01:44 +0000 Received: by outflank-mailman (input) for mailman id 148406; Thu, 01 Jul 2021 10:01:43 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lytS0-0004XT-Su for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 09:57:40 +0000 Received: from mo4-p03-ob.smtp.rzone.de (unknown [85.215.255.100]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 675c9bdf-ecdf-4f97-98b0-3206d03c9de6; Thu, 01 Jul 2021 09:56:53 +0000 (UTC) Received: from sender by smtp.strato.de (RZmta 47.28.1 AUTH) with ESMTPSA id 30791cx619ul5N5 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Thu, 1 Jul 2021 11:56:47 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 675c9bdf-ecdf-4f97-98b0-3206d03c9de6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1625133407; s=strato-dkim-0002; d=aepfle.de; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Cc:Date: From:Subject:Sender; bh=IfTAu6csmKih3Ul30va1DloKz84aTf69Oy5gDcqna/s=; b=XsemlVKcnJEPbQEhuTh/f1/P0zNwYk0GDD5ZFuuNMui6+I/UoY1e6NDIuYcO19mwvm s/eXT+Fh3UD049CqyU/fJmDpnjQzCe+OQpFcvEcaUeFZSf+A0l9zGa4BMziPLBXkIu09 Su8fRSH5+dNneKXI21FBmwHRoZubAnptMo/D6E0GoSJ1iExRZ+kINd8RCJU6m74/I2XF iO76syePZoRLpr71rO453SjEadeizZOC7cpU9DcxFXrhYuYBQVKvbLrgj3OEayRwWCEp 93dHtlIrraIEWffntlkPa6bGCK+AOa3T05EswFZrM8BMVd6j1+c81mWtqOB4TQi63TGb seUw== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QXkBR9MXjAuzpIG0mv9coXAg5lqlz7EsstGyDcxK3Mbajr+SQKopp1Cb0CyyaZQQ==" X-RZG-CLASS-ID: mo00 From: Olaf Hering To: xen-devel@lists.xenproject.org Cc: Olaf Hering , Juergen Gross , Ian Jackson , Wei Liu Subject: [PATCH v20210701 17/40] tools: save: move types array Date: Thu, 1 Jul 2021 11:56:12 +0200 Message-Id: <20210701095635.15648-18-olaf@aepfle.de> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210701095635.15648-1-olaf@aepfle.de> References: <20210701095635.15648-1-olaf@aepfle.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Remove allocation from hotpath, move types array into preallocated space. Signed-off-by: Olaf Hering Reviewed-by: Juergen Gross --- tools/libs/saverestore/common.h | 2 ++ tools/libs/saverestore/save.c | 7 ++----- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/tools/libs/saverestore/common.h b/tools/libs/saverestore/common.h index 1415a182d2..5bd2913cb6 100644 --- a/tools/libs/saverestore/common.h +++ b/tools/libs/saverestore/common.h @@ -227,6 +227,8 @@ struct sr_save_arrays { xen_pfn_t batch_pfns[MAX_BATCH_SIZE]; /* write_batch: Mfns of the batch pfns. */ xen_pfn_t mfns[MAX_BATCH_SIZE]; + /* write_batch: Types of the batch pfns. */ + xen_pfn_t types[MAX_BATCH_SIZE]; }; struct sr_restore_arrays { diff --git a/tools/libs/saverestore/save.c b/tools/libs/saverestore/save.c index 6b09784be8..0883c1fac0 100644 --- a/tools/libs/saverestore/save.c +++ b/tools/libs/saverestore/save.c @@ -88,7 +88,7 @@ static int write_checkpoint_record(struct xc_sr_context *ctx) static int write_batch(struct xc_sr_context *ctx) { xc_interface *xch = ctx->xch; - xen_pfn_t *mfns = ctx->save.m->mfns, *types = NULL; + xen_pfn_t *mfns = ctx->save.m->mfns, *types = ctx->save.m->types; void *guest_mapping = NULL; void **guest_data = NULL; void **local_pages = NULL; @@ -105,8 +105,6 @@ static int write_batch(struct xc_sr_context *ctx) assert(nr_pfns != 0); - /* Types of the batch pfns. */ - types = malloc(nr_pfns * sizeof(*types)); /* Errors from attempting to map the gfns. */ errors = malloc(nr_pfns * sizeof(*errors)); /* Pointers to page data to send. Mapped gfns or local allocations. */ @@ -116,7 +114,7 @@ static int write_batch(struct xc_sr_context *ctx) /* iovec[] for writev(). */ iov = malloc((nr_pfns + 4) * sizeof(*iov)); - if ( !types || !errors || !guest_data || !local_pages || !iov ) + if ( !errors || !guest_data || !local_pages || !iov ) { ERROR("Unable to allocate arrays for a batch of %u pages", nr_pfns); @@ -274,7 +272,6 @@ static int write_batch(struct xc_sr_context *ctx) free(local_pages); free(guest_data); free(errors); - free(types); return rc; } From xen-devel-bounces@lists.xenproject.org Thu Jul 01 10:01:46 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 10:01:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148414.274397 (Exim 4.92) (envelope-from ) id 1lytVx-0001UF-QN; Thu, 01 Jul 2021 10:01:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148414.274397; Thu, 01 Jul 2021 10:01:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lytVx-0001TK-JF; Thu, 01 Jul 2021 10:01:45 +0000 Received: by outflank-mailman (input) for mailman id 148414; Thu, 01 Jul 2021 10:01:44 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lytSl-0004r4-Iq for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 09:58:27 +0000 Received: from mo4-p03-ob.smtp.rzone.de (unknown [81.169.146.174]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 93bd6b54-8972-4d8c-89ba-2a118f2d9f0d; Thu, 01 Jul 2021 09:57:05 +0000 (UTC) Received: from sender by smtp.strato.de (RZmta 47.28.1 AUTH) with ESMTPSA id 30791cx619uv5Nd (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Thu, 1 Jul 2021 11:56:57 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 93bd6b54-8972-4d8c-89ba-2a118f2d9f0d DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1625133417; s=strato-dkim-0002; d=aepfle.de; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Cc:Date: From:Subject:Sender; bh=qkM58ppJmICGaCKigNV7+3gfD18mpe/eRIOurb3atVw=; b=opoJ9CuscHfKh938XdynCg6vYytGey1HlnnFvP5xY6scsH5sGuFIjFHDgyJ0rG5TzJ IMDQr8WmfR9w13tt5VFtKJhRXJjLQaufI43ltCdjZu1xFaZI3pDQ8ZcBvoDXbsQKGMIV E4/yqUbeaoMIXaru42ILvbuIQ27xrRx8IhLpjOB2sfG83qt2tWBLobXwOk183ZHCKtEU YGzlh7HHR5YZhBVNKvC4jKvazGZUF1Ymp2Llc2ToElFqUZa9LJoxHzDbO7VWxecRsH8U 2udlcuogzyR9SpSWDYUvZvr8I2gXlhpoYFSQj2VGC0efQFSrxZ121c3mDnOT5t8ukWul CPKw== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QXkBR9MXjAuzpIG0mv9coXAg5lqlz7EsstGyDcxK3Mbajr+SQKopp1Cb0CyyaZQQ==" X-RZG-CLASS-ID: mo00 From: Olaf Hering To: xen-devel@lists.xenproject.org Cc: Olaf Hering , Ian Jackson , Wei Liu , Anthony PERARD , Juergen Gross Subject: [PATCH v20210701 36/40] tools: add --min_remaining to libxl_domain_suspend Date: Thu, 1 Jul 2021 11:56:31 +0200 Message-Id: <20210701095635.15648-37-olaf@aepfle.de> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210701095635.15648-1-olaf@aepfle.de> References: <20210701095635.15648-1-olaf@aepfle.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The decision to stop+move a domU to the new host must be based on two factors: - the available network bandwidth for the migration stream - the maximum time a workload within a domU can be savely suspended Both values define how many dirty pages a workload may produce prior the final stop+move. The default value of 50 pages is much too low with todays network bandwidths. On an idle 1GiB link these 200K will be transferred within ~2ms. Give the admin a knob to adjust the point when the final stop+move will be done, so he can base this decision on his own needs. This patch adjusts xl(1) and the libxl API. External users check LIBXL_HAVE_DOMAIN_SUSPEND_PROPS for the availibility of the new .min_remaining property. Signed-off-by: Olaf Hering --- docs/man/xl.1.pod.in | 8 ++++++++ tools/include/libxl.h | 1 + tools/libs/light/libxl_dom_save.c | 2 +- tools/libs/light/libxl_domain.c | 1 + tools/libs/light/libxl_internal.h | 1 + tools/xl/xl_cmdtable.c | 23 ++++++++++++----------- tools/xl/xl_migrate.c | 9 ++++++++- 7 files changed, 32 insertions(+), 13 deletions(-) diff --git a/docs/man/xl.1.pod.in b/docs/man/xl.1.pod.in index 594387bcf4..09e866ad87 100644 --- a/docs/man/xl.1.pod.in +++ b/docs/man/xl.1.pod.in @@ -498,6 +498,14 @@ possible to use this option for a 'localhost' migration. Number of copy iterations before final suspend+move (default: 5) +=item B<--min_remaing> I + +Number of remaining dirty pages. If the number of dirty pages drops that +low, the guest is suspended and the domU will finally be moved to I. + +This allows the host admin to control for how long the domU will likely +be suspended during transit. + =back =item B [I] I I diff --git a/tools/include/libxl.h b/tools/include/libxl.h index bf77da0524..28d70b1078 100644 --- a/tools/include/libxl.h +++ b/tools/include/libxl.h @@ -1715,6 +1715,7 @@ static inline int libxl_retrieve_domain_configuration_0x041200( typedef struct { uint32_t flags; /* LIBXL_SUSPEND_* */ uint32_t max_iters; + uint32_t min_remaining; } libxl_domain_suspend_props; #define LIBXL_SUSPEND_DEBUG 1 #define LIBXL_SUSPEND_LIVE 2 diff --git a/tools/libs/light/libxl_dom_save.c b/tools/libs/light/libxl_dom_save.c index 938c0127f3..ad5df89b2c 100644 --- a/tools/libs/light/libxl_dom_save.c +++ b/tools/libs/light/libxl_dom_save.c @@ -381,7 +381,7 @@ static int libxl__domain_save_precopy_policy(precopy_stats_t stats, void *user) LOGD(DEBUG, shs->domid, "iteration %u dirty_count %ld total_written %lu", stats.iteration, stats.dirty_count, stats.total_written); - if (stats.dirty_count >= 0 && stats.dirty_count < LIBXL_XGS_POLICY_TARGET_DIRTY_COUNT) + if (stats.dirty_count >= 0 && stats.dirty_count < dss->min_remaining) goto stop_copy; if (stats.iteration >= dss->max_iters) goto stop_copy; diff --git a/tools/libs/light/libxl_domain.c b/tools/libs/light/libxl_domain.c index 9f98cd7f2b..06ca7a7df6 100644 --- a/tools/libs/light/libxl_domain.c +++ b/tools/libs/light/libxl_domain.c @@ -528,6 +528,7 @@ int libxl_domain_suspend(libxl_ctx *ctx, uint32_t domid, int fd, dss->fd = fd; dss->type = type; dss->max_iters = props->max_iters ?: LIBXL_XGS_POLICY_MAX_ITERATIONS; + dss->min_remaining = props->min_remaining ?: LIBXL_XGS_POLICY_TARGET_DIRTY_COUNT; dss->live = props->flags & LIBXL_SUSPEND_LIVE; dss->debug = props->flags & LIBXL_SUSPEND_DEBUG; dss->checkpointed_stream = LIBXL_CHECKPOINTED_STREAM_NONE; diff --git a/tools/libs/light/libxl_internal.h b/tools/libs/light/libxl_internal.h index 8cbcc5282c..e4bfb34085 100644 --- a/tools/libs/light/libxl_internal.h +++ b/tools/libs/light/libxl_internal.h @@ -3650,6 +3650,7 @@ struct libxl__domain_save_state { int debug; int checkpointed_stream; uint32_t max_iters; + uint32_t min_remaining; const libxl_domain_remus_info *remus; /* private */ int rc; diff --git a/tools/xl/xl_cmdtable.c b/tools/xl/xl_cmdtable.c index 9b6b3c99aa..2cb4980c80 100644 --- a/tools/xl/xl_cmdtable.c +++ b/tools/xl/xl_cmdtable.c @@ -165,17 +165,18 @@ const struct cmd_spec cmd_table[] = { &main_migrate, 0, 1, "Migrate a domain to another host", "[options] ", - "-h Print this help.\n" - "-C Send instead of config file from creation.\n" - "-s Use instead of ssh. String will be passed\n" - " to sh. If empty, run instead of ssh xl\n" - " migrate-receive [-d -e]\n" - "-e Do not wait in the background (on ) for the death\n" - " of the domain.\n" - "--debug Ignored.\n" - "-p Do not unpause domain after migrating it.\n" - "-D Preserve the domain id\n" - "--max_iters N Number of copy iterations before final stop+move" + "-h Print this help.\n" + "-C Send instead of config file from creation.\n" + "-s Use instead of ssh. String will be passed\n" + " to sh. If empty, run instead of ssh xl\n" + " migrate-receive [-d -e]\n" + "-e Do not wait in the background (on ) for the death\n" + " of the domain.\n" + "--debug Ignored.\n" + "-p Do not unpause domain after migrating it.\n" + "-D Preserve the domain id\n" + "--max_iters N Number of copy iterations before final stop+move\n" + "--min_remaining N Number of remaining dirty pages before final stop+move" }, { "restore", &main_restore, 0, 1, diff --git a/tools/xl/xl_migrate.c b/tools/xl/xl_migrate.c index af117d4d56..14feb2b7ec 100644 --- a/tools/xl/xl_migrate.c +++ b/tools/xl/xl_migrate.c @@ -179,6 +179,7 @@ static void migrate_do_preamble(int send_fd, int recv_fd, pid_t child, static void migrate_domain(uint32_t domid, int preserve_domid, const char *rune, int debug, uint32_t max_iters, + uint32_t min_remaining, const char *override_config_file) { pid_t child = -1; @@ -191,6 +192,7 @@ static void migrate_domain(uint32_t domid, int preserve_domid, libxl_domain_suspend_props props = { .flags = LIBXL_SUSPEND_LIVE, .max_iters = max_iters, + .min_remaining = min_remaining, }; save_domain_core_begin(domid, preserve_domid, override_config_file, @@ -545,9 +547,11 @@ int main_migrate(int argc, char **argv) int opt, daemonize = 1, monitor = 1, debug = 0, pause_after_migration = 0; int preserve_domid = 0; uint32_t max_iters = 0; + uint32_t min_remaining = 0; static struct option opts[] = { {"debug", 0, 0, 0x100}, {"max_iters", 1, 0, 0x101}, + {"min_remaining", 1, 0, 0x102}, {"live", 0, 0, 0x200}, COMMON_LONG_OPTS }; @@ -578,6 +582,9 @@ int main_migrate(int argc, char **argv) case 0x101: /* --max_iters */ max_iters = atoi(optarg); break; + case 0x102: /* --min_remaining */ + min_remaining = atoi(optarg); + break; case 0x200: /* --live */ /* ignored for compatibility with xm */ break; @@ -613,7 +620,7 @@ int main_migrate(int argc, char **argv) } migrate_domain(domid, preserve_domid, rune, debug, - max_iters, config_filename); + max_iters, min_remaining, config_filename); return EXIT_SUCCESS; } From xen-devel-bounces@lists.xenproject.org Thu Jul 01 10:01:51 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 10:01:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148421.274408 (Exim 4.92) (envelope-from ) id 1lytW3-0001zk-AG; Thu, 01 Jul 2021 10:01:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148421.274408; Thu, 01 Jul 2021 10:01:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lytW3-0001zX-6q; Thu, 01 Jul 2021 10:01:51 +0000 Received: by outflank-mailman (input) for mailman id 148421; Thu, 01 Jul 2021 10:01:49 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lytTS-0004XT-W1 for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 09:59:11 +0000 Received: from mo4-p04-ob.smtp.rzone.de (unknown [85.215.255.122]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id f973a37b-9f1f-4660-8e4f-726fae1d291d; Thu, 01 Jul 2021 09:57:07 +0000 (UTC) Received: from sender by smtp.strato.de (RZmta 47.28.1 AUTH) with ESMTPSA id 30791cx619uv5Nf (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Thu, 1 Jul 2021 11:56:57 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f973a37b-9f1f-4660-8e4f-726fae1d291d DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1625133417; s=strato-dkim-0002; d=aepfle.de; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Cc:Date: From:Subject:Sender; bh=+vXVfBW28MRAf3KK7IPzTuDzNHY/m8g7e2aJIg9hVrs=; b=mQJXm+gETkM4L9PcGKaP0zQZrcAyvvuvqZfXYqF43MKmkyonGJtqflRsmgEpgSEDQM bCgEy8MGNe6QGTsNoy25Jly2+iKZ47dScLpt+ytN+fqTFx6ad8MXve5I7oiYABck4EG9 YwTWFQJc149KIgNCQOz8xP0cK6P/27jc+gIUn3naWAHKfXPedfTScX3X8qPHz3b6d+di mXdeumlqDMz7Q0cYUKJ8n2zB/c1KVBAJXarUesHdXJ+BuIPuIOPb3SFOgEm48Kf4dH7O GCKWGyqMqaKn3g0gUFzFB4bQERGAEr1kXZFFzDHBHOTJwOwyGAu/5g2DJOe1aslur9Un iRPg== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QXkBR9MXjAuzpIG0mv9coXAg5lqlz7EsstGyDcxK3Mbajr+SQKopp1Cb0CyyaZQQ==" X-RZG-CLASS-ID: mo00 From: Olaf Hering To: xen-devel@lists.xenproject.org Cc: Olaf Hering , Ian Jackson , Wei Liu , Anthony PERARD , Juergen Gross Subject: [PATCH v20210701 37/40] tools: add --abort_if_busy to libxl_domain_suspend Date: Thu, 1 Jul 2021 11:56:32 +0200 Message-Id: <20210701095635.15648-38-olaf@aepfle.de> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210701095635.15648-1-olaf@aepfle.de> References: <20210701095635.15648-1-olaf@aepfle.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Provide a knob to the host admin to abort the live migration of a running domU if the downtime during final transit will be too long for the workload within domU. Adjust error reporting. Add ERROR_MIGRATION_ABORTED to allow callers of libxl_domain_suspend to distinguish between errors and the requested constraint. Adjust precopy_policy to simplify reporting of remaining dirty pages. The loop in send_memory_live populates ->dirty_count in a different place than ->iteration. Let it proceeed one more time to provide the desired information before leaving the loop. This patch adjusts xl(1) and the libxl API. External users check LIBXL_HAVE_DOMAIN_SUSPEND_PROPS for the availibility of the new .abort_if_busy property. Signed-off-by: Olaf Hering --- docs/man/xl.1.pod.in | 8 +++++++ tools/include/libxl.h | 1 + tools/libs/light/libxl_dom_save.c | 7 ++++++- tools/libs/light/libxl_domain.c | 1 + tools/libs/light/libxl_internal.h | 2 ++ tools/libs/light/libxl_stream_write.c | 9 +++++++- tools/libs/light/libxl_types.idl | 1 + tools/xl/xl_cmdtable.c | 6 +++++- tools/xl/xl_migrate.c | 30 ++++++++++++++++++++------- 9 files changed, 55 insertions(+), 10 deletions(-) diff --git a/docs/man/xl.1.pod.in b/docs/man/xl.1.pod.in index 09e866ad87..37267c9171 100644 --- a/docs/man/xl.1.pod.in +++ b/docs/man/xl.1.pod.in @@ -506,6 +506,14 @@ low, the guest is suspended and the domU will finally be moved to I. This allows the host admin to control for how long the domU will likely be suspended during transit. +=item B<--abort_if_busy> + +Abort migration instead of doing final suspend/move/resume if the +guest produced more than I dirty pages during th number +of I iterations. +This avoids long periods of time where the guest is suspended, which +may confuse the workload within domU. + =back =item B [I] I I diff --git a/tools/include/libxl.h b/tools/include/libxl.h index 28d70b1078..cc056ed627 100644 --- a/tools/include/libxl.h +++ b/tools/include/libxl.h @@ -1719,6 +1719,7 @@ typedef struct { } libxl_domain_suspend_props; #define LIBXL_SUSPEND_DEBUG 1 #define LIBXL_SUSPEND_LIVE 2 +#define LIBXL_SUSPEND_ABORT_IF_BUSY 4 int libxl_domain_suspend(libxl_ctx *ctx, uint32_t domid, int fd, libxl_domain_suspend_props *props, diff --git a/tools/libs/light/libxl_dom_save.c b/tools/libs/light/libxl_dom_save.c index ad5df89b2c..1999a8997f 100644 --- a/tools/libs/light/libxl_dom_save.c +++ b/tools/libs/light/libxl_dom_save.c @@ -383,11 +383,16 @@ static int libxl__domain_save_precopy_policy(precopy_stats_t stats, void *user) stats.iteration, stats.dirty_count, stats.total_written); if (stats.dirty_count >= 0 && stats.dirty_count < dss->min_remaining) goto stop_copy; - if (stats.iteration >= dss->max_iters) + if (stats.dirty_count >= 0 && stats.iteration >= dss->max_iters) goto stop_copy; return XGS_POLICY_CONTINUE_PRECOPY; stop_copy: + if (dss->abort_if_busy) + { + dss->remaining_dirty_pages = stats.dirty_count; + return XGS_POLICY_ABORT; + } return XGS_POLICY_STOP_AND_COPY; } diff --git a/tools/libs/light/libxl_domain.c b/tools/libs/light/libxl_domain.c index 06ca7a7df6..e4740b063e 100644 --- a/tools/libs/light/libxl_domain.c +++ b/tools/libs/light/libxl_domain.c @@ -529,6 +529,7 @@ int libxl_domain_suspend(libxl_ctx *ctx, uint32_t domid, int fd, dss->type = type; dss->max_iters = props->max_iters ?: LIBXL_XGS_POLICY_MAX_ITERATIONS; dss->min_remaining = props->min_remaining ?: LIBXL_XGS_POLICY_TARGET_DIRTY_COUNT; + dss->abort_if_busy = props->flags & LIBXL_SUSPEND_ABORT_IF_BUSY; dss->live = props->flags & LIBXL_SUSPEND_LIVE; dss->debug = props->flags & LIBXL_SUSPEND_DEBUG; dss->checkpointed_stream = LIBXL_CHECKPOINTED_STREAM_NONE; diff --git a/tools/libs/light/libxl_internal.h b/tools/libs/light/libxl_internal.h index e4bfb34085..905d5179ba 100644 --- a/tools/libs/light/libxl_internal.h +++ b/tools/libs/light/libxl_internal.h @@ -3648,9 +3648,11 @@ struct libxl__domain_save_state { libxl_domain_type type; int live; int debug; + int abort_if_busy; int checkpointed_stream; uint32_t max_iters; uint32_t min_remaining; + long remaining_dirty_pages; const libxl_domain_remus_info *remus; /* private */ int rc; diff --git a/tools/libs/light/libxl_stream_write.c b/tools/libs/light/libxl_stream_write.c index 634f3240d1..1ab3943f3e 100644 --- a/tools/libs/light/libxl_stream_write.c +++ b/tools/libs/light/libxl_stream_write.c @@ -344,11 +344,18 @@ void libxl__xc_domain_save_done(libxl__egc *egc, void *dss_void, goto err; if (retval) { + if (dss->remaining_dirty_pages) { + LOGD(NOTICE, dss->domid, "saving domain: aborted," + " %ld remaining dirty pages.", dss->remaining_dirty_pages); + } else { LOGEVD(ERROR, errnoval, dss->domid, "saving domain: %s", dss->dsps.guest_responded ? "domain responded to suspend request" : "domain did not respond to suspend request"); - if (!dss->dsps.guest_responded) + } + if (dss->remaining_dirty_pages) + rc = ERROR_MIGRATION_ABORTED; + else if(!dss->dsps.guest_responded) rc = ERROR_GUEST_TIMEDOUT; else if (dss->rc) rc = dss->rc; diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl index f45adddab0..b91769ee10 100644 --- a/tools/libs/light/libxl_types.idl +++ b/tools/libs/light/libxl_types.idl @@ -76,6 +76,7 @@ libxl_error = Enumeration("error", [ (-30, "QMP_DEVICE_NOT_ACTIVE"), # a device has failed to be become active (-31, "QMP_DEVICE_NOT_FOUND"), # the requested device has not been found (-32, "QEMU_API"), # QEMU's replies don't contains expected members + (-33, "MIGRATION_ABORTED"), ], value_namespace = "") libxl_domain_type = Enumeration("domain_type", [ diff --git a/tools/xl/xl_cmdtable.c b/tools/xl/xl_cmdtable.c index 2cb4980c80..322a47c2bc 100644 --- a/tools/xl/xl_cmdtable.c +++ b/tools/xl/xl_cmdtable.c @@ -176,7 +176,11 @@ const struct cmd_spec cmd_table[] = { "-p Do not unpause domain after migrating it.\n" "-D Preserve the domain id\n" "--max_iters N Number of copy iterations before final stop+move\n" - "--min_remaining N Number of remaining dirty pages before final stop+move" + "--min_remaining N Number of remaining dirty pages before final stop+move\n" + "--abort_if_busy Abort migration instead of doing final stop+move,\n" + " if the number of dirty pages is higher than \n" + " after iterations. Otherwise the amount of memory\n" + " to be transfered would exceed maximum allowed domU downtime." }, { "restore", &main_restore, 0, 1, diff --git a/tools/xl/xl_migrate.c b/tools/xl/xl_migrate.c index 14feb2b7ec..f523746e5b 100644 --- a/tools/xl/xl_migrate.c +++ b/tools/xl/xl_migrate.c @@ -177,7 +177,7 @@ static void migrate_do_preamble(int send_fd, int recv_fd, pid_t child, } static void migrate_domain(uint32_t domid, int preserve_domid, - const char *rune, int debug, + const char *rune, int debug, int abort_if_busy, uint32_t max_iters, uint32_t min_remaining, const char *override_config_file) @@ -213,14 +213,20 @@ static void migrate_domain(uint32_t domid, int preserve_domid, if (debug) props.flags |= LIBXL_SUSPEND_DEBUG; + if (abort_if_busy) + props.flags |= LIBXL_SUSPEND_ABORT_IF_BUSY; rc = libxl_domain_suspend(ctx, domid, send_fd, &props, NULL); if (rc) { fprintf(stderr, "migration sender: libxl_domain_suspend failed" " (rc=%d)\n", rc); - if (rc == ERROR_GUEST_TIMEDOUT) - goto failed_suspend; - else - goto failed_resume; + switch (rc) { + case ERROR_GUEST_TIMEDOUT: + goto failed_suspend; + case ERROR_MIGRATION_ABORTED: + goto failed_busy; + default: + goto failed_resume; + } } //fprintf(stderr, "migration sender: Transfer complete.\n"); @@ -302,6 +308,12 @@ static void migrate_domain(uint32_t domid, int preserve_domid, fprintf(stderr, "Migration failed, failed to suspend at sender.\n"); exit(EXIT_FAILURE); + failed_busy: + close(send_fd); + migration_child_report(recv_fd); + fprintf(stderr, "Migration aborted as requested, domain is too busy.\n"); + exit(EXIT_FAILURE); + failed_resume: close(send_fd); migration_child_report(recv_fd); @@ -545,13 +557,14 @@ int main_migrate(int argc, char **argv) char *rune = NULL; char *host; int opt, daemonize = 1, monitor = 1, debug = 0, pause_after_migration = 0; - int preserve_domid = 0; + int preserve_domid = 0, abort_if_busy = 0; uint32_t max_iters = 0; uint32_t min_remaining = 0; static struct option opts[] = { {"debug", 0, 0, 0x100}, {"max_iters", 1, 0, 0x101}, {"min_remaining", 1, 0, 0x102}, + {"abort_if_busy", 0, 0, 0x103}, {"live", 0, 0, 0x200}, COMMON_LONG_OPTS }; @@ -585,6 +598,9 @@ int main_migrate(int argc, char **argv) case 0x102: /* --min_remaining */ min_remaining = atoi(optarg); break; + case 0x103: /* --abort_if_busy */ + abort_if_busy = 1; + break; case 0x200: /* --live */ /* ignored for compatibility with xm */ break; @@ -619,7 +635,7 @@ int main_migrate(int argc, char **argv) pause_after_migration ? " -p" : ""); } - migrate_domain(domid, preserve_domid, rune, debug, + migrate_domain(domid, preserve_domid, rune, debug, abort_if_busy, max_iters, min_remaining, config_filename); return EXIT_SUCCESS; } From xen-devel-bounces@lists.xenproject.org Thu Jul 01 10:01:57 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 10:01:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148427.274419 (Exim 4.92) (envelope-from ) id 1lytW9-0002eA-MT; Thu, 01 Jul 2021 10:01:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148427.274419; Thu, 01 Jul 2021 10:01:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lytW9-0002dt-Ig; Thu, 01 Jul 2021 10:01:57 +0000 Received: by outflank-mailman (input) for mailman id 148427; Thu, 01 Jul 2021 10:01:57 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lytTI-0004XT-VW for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 09:59:01 +0000 Received: from mo4-p03-ob.smtp.rzone.de (unknown [81.169.146.175]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id b57223e9-2c81-48e3-9cc3-386dc2e0c882; Thu, 01 Jul 2021 09:57:05 +0000 (UTC) Received: from sender by smtp.strato.de (RZmta 47.28.1 AUTH) with ESMTPSA id 30791cx619uu5Nc (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Thu, 1 Jul 2021 11:56:56 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b57223e9-2c81-48e3-9cc3-386dc2e0c882 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1625133416; s=strato-dkim-0002; d=aepfle.de; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Cc:Date: From:Subject:Sender; bh=6LebzrvgpkRPMXPrQvQqUEqJ9oCT3tBlpGnE42P4LCk=; b=KT2oEP6NW3z/fhQra9nm6nrr4OkR+aMBAw2WhNwMdqzOjgFtj+nsKLqMH86Gu9OeWF LlSiZsZfYcSSTGdtpJwmH9jhuSYaI4DNAmpNp7nsDwkHmo5V5bQgQ/px8d5dckC+DVyw TAU1oeCtFoEWkjIvFi+7KJK6by5ZsOTEGJcronSu3U38UPGInxxfvw4LZRSDgMJsmJYw 5HuK9FOnwghE93c8NjAhB4WyPgINB0buk62Cs4AiIkddIWHu7t4K7fAHU3jZGNk7ISMg Ui1ph1RrWR9SXkTLHFXGAjGxsQyUGPBDT7d6F31zGVzX8W2oY4CM1KuZ/Me6ZY5rBazA t+/w== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QXkBR9MXjAuzpIG0mv9coXAg5lqlz7EsstGyDcxK3Mbajr+SQKopp1Cb0CyyaZQQ==" X-RZG-CLASS-ID: mo00 From: Olaf Hering To: xen-devel@lists.xenproject.org Cc: Olaf Hering , Ian Jackson , Wei Liu , Anthony PERARD , Juergen Gross Subject: [PATCH v20210701 35/40] tools: add --max_iters to libxl_domain_suspend Date: Thu, 1 Jul 2021 11:56:30 +0200 Message-Id: <20210701095635.15648-36-olaf@aepfle.de> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210701095635.15648-1-olaf@aepfle.de> References: <20210701095635.15648-1-olaf@aepfle.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Migrating a large, and potentially busy, domU will take more time than neccessary due to excessive number of copying iterations. Allow to host admin to control the number of iterations which copy cumulated domU dirty pages to the target host. The default remains 5, which means one initial iteration to copy the entire domU memory, and up to 4 additional iterations to copy dirty memory from the still running domU. After the given number of iterations the domU is suspended, remaining dirty memory is copied and the domU is finally moved to the target host. This patch adjusts xl(1) and the libxl API. External users check LIBXL_HAVE_DOMAIN_SUSPEND_PROPS for the availibility of the new .max_iters property. Signed-off-by: Olaf Hering --- docs/man/xl.1.pod.in | 4 ++++ tools/include/libxl.h | 1 + tools/libs/light/libxl_dom_save.c | 2 +- tools/libs/light/libxl_domain.c | 1 + tools/libs/light/libxl_internal.h | 1 + tools/xl/xl_cmdtable.c | 3 ++- tools/xl/xl_migrate.c | 10 +++++++++- 7 files changed, 19 insertions(+), 3 deletions(-) diff --git a/docs/man/xl.1.pod.in b/docs/man/xl.1.pod.in index 70a6ebf438..594387bcf4 100644 --- a/docs/man/xl.1.pod.in +++ b/docs/man/xl.1.pod.in @@ -494,6 +494,10 @@ such that it will be identical on the destination host, unless that configuration is overridden using the B<-C> option. Note that it is not possible to use this option for a 'localhost' migration. +=item B<--max_iters> I + +Number of copy iterations before final suspend+move (default: 5) + =back =item B [I] I I diff --git a/tools/include/libxl.h b/tools/include/libxl.h index 9a4d7514ed..bf77da0524 100644 --- a/tools/include/libxl.h +++ b/tools/include/libxl.h @@ -1714,6 +1714,7 @@ static inline int libxl_retrieve_domain_configuration_0x041200( typedef struct { uint32_t flags; /* LIBXL_SUSPEND_* */ + uint32_t max_iters; } libxl_domain_suspend_props; #define LIBXL_SUSPEND_DEBUG 1 #define LIBXL_SUSPEND_LIVE 2 diff --git a/tools/libs/light/libxl_dom_save.c b/tools/libs/light/libxl_dom_save.c index 3f3cff0342..938c0127f3 100644 --- a/tools/libs/light/libxl_dom_save.c +++ b/tools/libs/light/libxl_dom_save.c @@ -383,7 +383,7 @@ static int libxl__domain_save_precopy_policy(precopy_stats_t stats, void *user) stats.iteration, stats.dirty_count, stats.total_written); if (stats.dirty_count >= 0 && stats.dirty_count < LIBXL_XGS_POLICY_TARGET_DIRTY_COUNT) goto stop_copy; - if (stats.iteration >= LIBXL_XGS_POLICY_MAX_ITERATIONS) + if (stats.iteration >= dss->max_iters) goto stop_copy; return XGS_POLICY_CONTINUE_PRECOPY; diff --git a/tools/libs/light/libxl_domain.c b/tools/libs/light/libxl_domain.c index 5dbd27900f..9f98cd7f2b 100644 --- a/tools/libs/light/libxl_domain.c +++ b/tools/libs/light/libxl_domain.c @@ -527,6 +527,7 @@ int libxl_domain_suspend(libxl_ctx *ctx, uint32_t domid, int fd, dss->domid = domid; dss->fd = fd; dss->type = type; + dss->max_iters = props->max_iters ?: LIBXL_XGS_POLICY_MAX_ITERATIONS; dss->live = props->flags & LIBXL_SUSPEND_LIVE; dss->debug = props->flags & LIBXL_SUSPEND_DEBUG; dss->checkpointed_stream = LIBXL_CHECKPOINTED_STREAM_NONE; diff --git a/tools/libs/light/libxl_internal.h b/tools/libs/light/libxl_internal.h index 57d7e4b4b8..8cbcc5282c 100644 --- a/tools/libs/light/libxl_internal.h +++ b/tools/libs/light/libxl_internal.h @@ -3649,6 +3649,7 @@ struct libxl__domain_save_state { int live; int debug; int checkpointed_stream; + uint32_t max_iters; const libxl_domain_remus_info *remus; /* private */ int rc; diff --git a/tools/xl/xl_cmdtable.c b/tools/xl/xl_cmdtable.c index ca1dfa3525..9b6b3c99aa 100644 --- a/tools/xl/xl_cmdtable.c +++ b/tools/xl/xl_cmdtable.c @@ -174,7 +174,8 @@ const struct cmd_spec cmd_table[] = { " of the domain.\n" "--debug Ignored.\n" "-p Do not unpause domain after migrating it.\n" - "-D Preserve the domain id" + "-D Preserve the domain id\n" + "--max_iters N Number of copy iterations before final stop+move" }, { "restore", &main_restore, 0, 1, diff --git a/tools/xl/xl_migrate.c b/tools/xl/xl_migrate.c index 144890924f..af117d4d56 100644 --- a/tools/xl/xl_migrate.c +++ b/tools/xl/xl_migrate.c @@ -178,6 +178,7 @@ static void migrate_do_preamble(int send_fd, int recv_fd, pid_t child, static void migrate_domain(uint32_t domid, int preserve_domid, const char *rune, int debug, + uint32_t max_iters, const char *override_config_file) { pid_t child = -1; @@ -189,6 +190,7 @@ static void migrate_domain(uint32_t domid, int preserve_domid, int config_len; libxl_domain_suspend_props props = { .flags = LIBXL_SUSPEND_LIVE, + .max_iters = max_iters, }; save_domain_core_begin(domid, preserve_domid, override_config_file, @@ -542,8 +544,10 @@ int main_migrate(int argc, char **argv) char *host; int opt, daemonize = 1, monitor = 1, debug = 0, pause_after_migration = 0; int preserve_domid = 0; + uint32_t max_iters = 0; static struct option opts[] = { {"debug", 0, 0, 0x100}, + {"max_iters", 1, 0, 0x101}, {"live", 0, 0, 0x200}, COMMON_LONG_OPTS }; @@ -571,6 +575,9 @@ int main_migrate(int argc, char **argv) case 0x100: /* --debug */ debug = 1; break; + case 0x101: /* --max_iters */ + max_iters = atoi(optarg); + break; case 0x200: /* --live */ /* ignored for compatibility with xm */ break; @@ -605,7 +612,8 @@ int main_migrate(int argc, char **argv) pause_after_migration ? " -p" : ""); } - migrate_domain(domid, preserve_domid, rune, debug, config_filename); + migrate_domain(domid, preserve_domid, rune, debug, + max_iters, config_filename); return EXIT_SUCCESS; } From xen-devel-bounces@lists.xenproject.org Thu Jul 01 10:02:05 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 10:02:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148441.274430 (Exim 4.92) (envelope-from ) id 1lytWH-0003LB-4z; Thu, 01 Jul 2021 10:02:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148441.274430; Thu, 01 Jul 2021 10:02:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lytWG-0003Ky-U4; Thu, 01 Jul 2021 10:02:04 +0000 Received: by outflank-mailman (input) for mailman id 148441; Thu, 01 Jul 2021 10:02:03 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lytTN-0004XT-Vj for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 09:59:06 +0000 Received: from mo4-p04-ob.smtp.rzone.de (unknown [85.215.255.122]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id d24312b3-d57c-445e-b1b2-eafe1123a619; Thu, 01 Jul 2021 09:57:05 +0000 (UTC) Received: from sender by smtp.strato.de (RZmta 47.28.1 AUTH) with ESMTPSA id 30791cx619uw5Nm (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Thu, 1 Jul 2021 11:56:58 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d24312b3-d57c-445e-b1b2-eafe1123a619 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1625133419; s=strato-dkim-0002; d=aepfle.de; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Cc:Date: From:Subject:Sender; bh=4BSb6eeDkPifgS8HDSbSVDpKklU68Xf6WI9Hag1dmvM=; b=jBLrRaJpTQvsf6M1Gf2VBUS4pkLKBkyObynQud5Q4/eSVIM/iRSt15fDhO0tHwnAlv 1FKyCbr7cEwRob38K+L9xBwQyGemJtmQDHZW1RGBJFV3r9uh2FchWrUoJmWK/peMHWaY Om7XyUXvaijdTNHWG5kOq0G0K1qv7u2zLFzoAYkDdWIkAbPjXkk9x6WEKk7tzQRtltFK u9snzNkHACAukU58d3VqFGSKIwnXOTNuP7q+2QhWLUBTAS5dUTFQECkZ4GMvuRDQ3KfV zAfJOSNmOWLmxW8r7SHCxOJSGXBfR5kLsYoDK7bb6YOi9NScjR25bpmL09IgfslKHBTl zchA== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QXkBR9MXjAuzpIG0mv9coXAg5lqlz7EsstGyDcxK3Mbajr+SQKopp1Cb0CyyaZQQ==" X-RZG-CLASS-ID: mo00 From: Olaf Hering To: xen-devel@lists.xenproject.org Cc: Olaf Hering , Ian Jackson , Wei Liu , Juergen Gross Subject: [PATCH v20210701 40/40] tools/libxc: use superpages during restore of HVM guest Date: Thu, 1 Jul 2021 11:56:35 +0200 Message-Id: <20210701095635.15648-41-olaf@aepfle.de> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210701095635.15648-1-olaf@aepfle.de> References: <20210701095635.15648-1-olaf@aepfle.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit During creating of a HVM domU meminit_hvm() tries to map superpages. After save/restore or migration this mapping is lost, everything is allocated in single pages. This causes a performance degradation after migration. Add neccessary code to preallocate a superpage for an incoming chunk of pfns. In case a pfn was not populated on the sending side, it must be freed on the receiving side to avoid over-allocation. The existing code for x86_pv is moved unmodified into its own file. Signed-off-by: Olaf Hering v02: - remove xg_ prefix from called functions --- tools/libs/guest/xg_dom_x86.c | 5 - tools/libs/guest/xg_private.h | 5 + tools/libs/saverestore/common.c | 1 - tools/libs/saverestore/common.h | 28 +- tools/libs/saverestore/restore.c | 62 +--- tools/libs/saverestore/restore_x86_hvm.c | 370 ++++++++++++++++++++++- tools/libs/saverestore/restore_x86_pv.c | 61 +++- 7 files changed, 455 insertions(+), 77 deletions(-) diff --git a/tools/libs/guest/xg_dom_x86.c b/tools/libs/guest/xg_dom_x86.c index d2eb89ce01..ec0d18fd60 100644 --- a/tools/libs/guest/xg_dom_x86.c +++ b/tools/libs/guest/xg_dom_x86.c @@ -44,11 +44,6 @@ #define SUPERPAGE_BATCH_SIZE 512 -#define SUPERPAGE_2MB_SHIFT 9 -#define SUPERPAGE_2MB_NR_PFNS (1UL << SUPERPAGE_2MB_SHIFT) -#define SUPERPAGE_1GB_SHIFT 18 -#define SUPERPAGE_1GB_NR_PFNS (1UL << SUPERPAGE_1GB_SHIFT) - #define X86_CR0_PE 0x01 #define X86_CR0_ET 0x10 diff --git a/tools/libs/guest/xg_private.h b/tools/libs/guest/xg_private.h index 28441ee13f..b7372e6bd5 100644 --- a/tools/libs/guest/xg_private.h +++ b/tools/libs/guest/xg_private.h @@ -179,4 +179,9 @@ struct xc_cpu_policy { }; #endif /* x86 */ +#define SUPERPAGE_2MB_SHIFT 9 +#define SUPERPAGE_2MB_NR_PFNS (1UL << SUPERPAGE_2MB_SHIFT) +#define SUPERPAGE_1GB_SHIFT 18 +#define SUPERPAGE_1GB_NR_PFNS (1UL << SUPERPAGE_1GB_SHIFT) + #endif /* XG_PRIVATE_H */ diff --git a/tools/libs/saverestore/common.c b/tools/libs/saverestore/common.c index e96173eea2..8dbd516b1b 100644 --- a/tools/libs/saverestore/common.c +++ b/tools/libs/saverestore/common.c @@ -1,5 +1,4 @@ #include - #include "common.h" #include diff --git a/tools/libs/saverestore/common.h b/tools/libs/saverestore/common.h index a610483fe7..3d392f1ac9 100644 --- a/tools/libs/saverestore/common.h +++ b/tools/libs/saverestore/common.h @@ -219,6 +219,16 @@ struct xc_sr_restore_ops */ int (*setup)(struct xc_sr_context *ctx); + /** + * Populate PFNs + * + * Given a set of pfns, obtain memory from Xen to fill the physmap for the + * unpopulated subset. + */ + int (*populate_pfns)(struct xc_sr_context *ctx, unsigned count, + const xen_pfn_t *original_pfns, const uint32_t *types); + + /** * Process an individual record from the stream. The caller shall take * care of processing common records (e.g. END, PAGE_DATA). @@ -366,6 +376,8 @@ struct xc_sr_context int send_back_fd; unsigned long p2m_size; + unsigned long max_pages; + unsigned long tot_pages; xc_hypercall_buffer_t dirty_bitmap_hbuf; /* From Image Header. */ @@ -503,6 +515,14 @@ struct xc_sr_context { /* HVM context blob. */ struct xc_sr_blob context; + + /* Bitmap of currently allocated PFNs during restore. */ + struct sr_bitmap attempted_1g; + struct sr_bitmap attempted_2m; + struct sr_bitmap allocated_pfns; + xen_pfn_t prev_populated_pfn; + xen_pfn_t iteration_tracker_pfn; + unsigned long iteration; } restore; }; } hvm; @@ -567,14 +587,6 @@ int read_record_header(struct xc_sr_context *ctx, int fd, struct xc_sr_rhdr *rhd int read_record_data(struct xc_sr_context *ctx, int fd, struct xc_sr_rhdr *rhdr, struct xc_sr_record *rec); -/* - * This would ideally be private in restore.c, but is needed by - * x86_pv_localise_page() if we receive pagetables frames ahead of the - * contents of the frames they point at. - */ -int populate_pfns(struct xc_sr_context *ctx, unsigned int count, - const xen_pfn_t *original_pfns, const uint32_t *types); - /* Handle a STATIC_DATA_END record. */ int handle_static_data_end(struct xc_sr_context *ctx); diff --git a/tools/libs/saverestore/restore.c b/tools/libs/saverestore/restore.c index baf8ea44e5..5ad3df49ba 100644 --- a/tools/libs/saverestore/restore.c +++ b/tools/libs/saverestore/restore.c @@ -71,63 +71,6 @@ static int read_headers(struct xc_sr_context *ctx) return 0; } -/* - * Given a set of pfns, obtain memory from Xen to fill the physmap for the - * unpopulated subset. If types is NULL, no page type checking is performed - * and all unpopulated pfns are populated. - */ -int populate_pfns(struct xc_sr_context *ctx, unsigned int count, - const xen_pfn_t *original_pfns, const uint32_t *types) -{ - xc_interface *xch = ctx->xch; - xen_pfn_t *mfns = ctx->restore.m->pp_mfns, - *pfns = ctx->restore.m->pp_pfns; - unsigned int i, nr_pfns = 0; - int rc = -1; - - for ( i = 0; i < count; ++i ) - { - if ( (!types || - (types && page_type_to_populate(types[i]) == true)) && - !pfn_is_populated(ctx, original_pfns[i]) ) - { - rc = pfn_set_populated(ctx, original_pfns[i]); - if ( rc ) - goto err; - pfns[nr_pfns] = mfns[nr_pfns] = original_pfns[i]; - ++nr_pfns; - } - } - - if ( nr_pfns ) - { - rc = xc_domain_populate_physmap_exact( - xch, ctx->domid, nr_pfns, 0, 0, mfns); - if ( rc ) - { - PERROR("Failed to populate physmap"); - goto err; - } - - for ( i = 0; i < nr_pfns; ++i ) - { - if ( mfns[i] == INVALID_MFN ) - { - ERROR("Populate physmap failed for pfn %u", i); - rc = -1; - goto err; - } - - ctx->restore.ops.set_gfn(ctx, pfns[i], mfns[i]); - } - } - - rc = 0; - - err: - return rc; -} - static int handle_static_data_end_v2(struct xc_sr_context *ctx) { int rc = 0; @@ -270,7 +213,7 @@ static int map_guest_pages(struct xc_sr_context *ctx, uint32_t i, p; int rc; - rc = populate_pfns(ctx, pages->count, m->pfns, m->types); + rc = ctx->restore.ops.populate_pfns(ctx, pages->count, m->pfns, m->types); if ( rc ) { ERROR("Failed to populate pfns for batch of %u pages", pages->count); @@ -1077,6 +1020,9 @@ int xc_domain_restore(xc_interface *xch, int io_fd, uint32_t dom, return -1; } + /* See xc_domain_getinfo */ + ctx.restore.max_pages = ctx.dominfo.max_memkb >> (PAGE_SHIFT-10); + ctx.restore.tot_pages = ctx.dominfo.nr_pages; ctx.restore.p2m_size = nr_pfns; ctx.restore.ops = ctx.dominfo.hvm ? restore_ops_x86_hvm : restore_ops_x86_pv; diff --git a/tools/libs/saverestore/restore_x86_hvm.c b/tools/libs/saverestore/restore_x86_hvm.c index 97e7e0f48c..f45635613f 100644 --- a/tools/libs/saverestore/restore_x86_hvm.c +++ b/tools/libs/saverestore/restore_x86_hvm.c @@ -130,6 +130,25 @@ static int x86_hvm_localise_page(struct xc_sr_context *ctx, return 0; } +static bool x86_hvm_expand_sp_bitmaps(struct xc_sr_context *ctx, unsigned long max_pfn) +{ + struct sr_bitmap *bm; + + bm = &ctx->x86.hvm.restore.attempted_1g; + if ( !sr_bitmap_expand(bm, max_pfn >> SUPERPAGE_1GB_SHIFT) ) + return false; + + bm = &ctx->x86.hvm.restore.attempted_2m; + if ( !sr_bitmap_expand(bm, max_pfn >> SUPERPAGE_2MB_SHIFT) ) + return false; + + bm = &ctx->x86.hvm.restore.allocated_pfns; + if ( !sr_bitmap_expand(bm, max_pfn) ) + return false; + + return true; +} + /* * restore_ops function. Confirms the stream matches the domain. */ @@ -164,12 +183,21 @@ static int x86_hvm_setup(struct xc_sr_context *ctx) max_pfn = max(ctx->restore.p2m_size, ctx->dominfo.max_memkb >> (PAGE_SHIFT-10)); if ( !sr_bitmap_expand(&ctx->restore.populated_pfns, max_pfn) ) - { - PERROR("Unable to allocate memory for populated_pfns bitmap"); - return -1; - } + goto out; + + if ( !x86_hvm_expand_sp_bitmaps(ctx, max_pfn) ) + goto out; + + /* FIXME: distinguish between PVH and HVM */ + /* No superpage in 1st 2MB due to VGA hole */ + sr_set_bit(0, &ctx->x86.hvm.restore.attempted_1g); + sr_set_bit(0, &ctx->x86.hvm.restore.attempted_2m); return 0; + +out: + PERROR("Unable to allocate memory for pfn bitmaps"); + return -1; } /* @@ -250,6 +278,9 @@ static int x86_hvm_stream_complete(struct xc_sr_context *ctx) static int x86_hvm_cleanup(struct xc_sr_context *ctx) { sr_bitmap_free(&ctx->restore.populated_pfns); + sr_bitmap_free(&ctx->x86.hvm.restore.attempted_1g); + sr_bitmap_free(&ctx->x86.hvm.restore.attempted_2m); + sr_bitmap_free(&ctx->x86.hvm.restore.allocated_pfns); free(ctx->x86.hvm.restore.context.ptr); free(ctx->x86.restore.cpuid.ptr); @@ -258,6 +289,336 @@ static int x86_hvm_cleanup(struct xc_sr_context *ctx) return 0; } +/* + * Set a range of pfns as allocated + */ +static void pfn_set_long_allocated(struct xc_sr_context *ctx, xen_pfn_t base_pfn) +{ + sr_set_long_bit(base_pfn, &ctx->x86.hvm.restore.allocated_pfns); +} + +static void pfn_set_allocated(struct xc_sr_context *ctx, xen_pfn_t pfn) +{ + sr_set_bit(pfn, &ctx->x86.hvm.restore.allocated_pfns); +} + +struct x86_hvm_sp { + xen_pfn_t pfn; + xen_pfn_t base_pfn; + unsigned long index; + unsigned long count; +}; + +/* + * Try to allocate a 1GB page for this pfn, but avoid Over-allocation. + * If this succeeds, mark the range of 2MB pages as busy. + */ +static bool x86_hvm_alloc_1g(struct xc_sr_context *ctx, struct x86_hvm_sp *sp) +{ + xc_interface *xch = ctx->xch; + unsigned int order; + int i, done; + xen_pfn_t extent; + + /* Only one attempt to avoid overlapping allocation */ + if ( sr_test_and_set_bit(sp->index, &ctx->x86.hvm.restore.attempted_1g) ) + return false; + + order = SUPERPAGE_1GB_SHIFT; + sp->count = SUPERPAGE_1GB_NR_PFNS; + + /* Allocate only if there is room for another superpage */ + if ( ctx->restore.tot_pages + sp->count > ctx->restore.max_pages ) + return false; + + extent = sp->base_pfn = (sp->pfn >> order) << order; + done = xc_domain_populate_physmap(xch, ctx->domid, 1, order, 0, &extent); + if ( done < 0 ) { + PERROR("populate_physmap failed."); + return false; + } + if ( done == 0 ) + return false; + + DPRINTF("1G %" PRI_xen_pfn "\n", sp->base_pfn); + + /* Mark all 2MB pages as done to avoid overlapping allocation */ + for ( i = 0; i < (SUPERPAGE_1GB_NR_PFNS/SUPERPAGE_2MB_NR_PFNS); i++ ) + sr_set_bit((sp->base_pfn >> SUPERPAGE_2MB_SHIFT) + i, &ctx->x86.hvm.restore.attempted_2m); + + return true; +} + +/* Allocate a 2MB page if x86_hvm_alloc_1g failed, avoid Over-allocation. */ +static bool x86_hvm_alloc_2m(struct xc_sr_context *ctx, struct x86_hvm_sp *sp) +{ + xc_interface *xch = ctx->xch; + unsigned int order; + int done; + xen_pfn_t extent; + + /* Only one attempt to avoid overlapping allocation */ + if ( sr_test_and_set_bit(sp->index, &ctx->x86.hvm.restore.attempted_2m) ) + return false; + + order = SUPERPAGE_2MB_SHIFT; + sp->count = SUPERPAGE_2MB_NR_PFNS; + + /* Allocate only if there is room for another superpage */ + if ( ctx->restore.tot_pages + sp->count > ctx->restore.max_pages ) + return false; + + extent = sp->base_pfn = (sp->pfn >> order) << order; + done = xc_domain_populate_physmap(xch, ctx->domid, 1, order, 0, &extent); + if ( done < 0 ) { + PERROR("populate_physmap failed."); + return false; + } + if ( done == 0 ) + return false; + + DPRINTF("2M %" PRI_xen_pfn "\n", sp->base_pfn); + return true; +} + +/* Allocate a single page if x86_hvm_alloc_2m failed. */ +static bool x86_hvm_alloc_4k(struct xc_sr_context *ctx, struct x86_hvm_sp *sp) +{ + xc_interface *xch = ctx->xch; + unsigned int order; + int done; + xen_pfn_t extent; + + order = 0; + sp->count = 1UL; + + /* Allocate only if there is room for another page */ + if ( ctx->restore.tot_pages + sp->count > ctx->restore.max_pages ) { + errno = E2BIG; + return false; + } + + extent = sp->base_pfn = (sp->pfn >> order) << order; + done = xc_domain_populate_physmap(xch, ctx->domid, 1, order, 0, &extent); + if ( done < 0 ) { + PERROR("populate_physmap failed."); + return false; + } + if ( done == 0 ) { + errno = ENOMEM; + return false; + } + + DPRINTF("4K %" PRI_xen_pfn "\n", sp->base_pfn); + return true; +} +/* + * Attempt to allocate a superpage where the pfn resides. + */ +static int x86_hvm_allocate_pfn(struct xc_sr_context *ctx, xen_pfn_t pfn) +{ + bool success; + unsigned long idx_1g, idx_2m; + struct x86_hvm_sp sp = { + .pfn = pfn + }; + + if ( sr_test_bit(pfn, &ctx->x86.hvm.restore.allocated_pfns) ) + return 0; + + idx_1g = pfn >> SUPERPAGE_1GB_SHIFT; + idx_2m = pfn >> SUPERPAGE_2MB_SHIFT; + + sp.index = idx_1g; + success = x86_hvm_alloc_1g(ctx, &sp); + + if ( success == false ) { + sp.index = idx_2m; + success = x86_hvm_alloc_2m(ctx, &sp); + } + + if ( success == false ) { + sp.index = 0; + success = x86_hvm_alloc_4k(ctx, &sp); + } + + if ( success == false ) + return -1; + + do { + if ( sp.count >= BITS_PER_LONG ) { + sp.count -= BITS_PER_LONG; + ctx->restore.tot_pages += BITS_PER_LONG; + pfn_set_long_allocated(ctx, sp.base_pfn + sp.count); + } else { + sp.count--; + ctx->restore.tot_pages++; + pfn_set_allocated(ctx, sp.base_pfn + sp.count); + } + } while ( sp.count ); + + return 0; +} + +/* + * Deallocate memory. + * There was likely an optimistic superpage allocation. + * This means more pages may have been allocated past gap_end. + * This range is not freed now. Incoming higher pfns will release it. + */ +static int x86_hvm_punch_hole(struct xc_sr_context *ctx, + xen_pfn_t gap_start, xen_pfn_t gap_end) +{ + xc_interface *xch = ctx->xch; + xen_pfn_t _pfn, pfn; + uint32_t domid, freed = 0; + int rc; + + pfn = gap_start >> SUPERPAGE_1GB_SHIFT; + do + { + sr_set_bit(pfn, &ctx->x86.hvm.restore.attempted_1g); + } while (++pfn <= gap_end >> SUPERPAGE_1GB_SHIFT); + + pfn = gap_start >> SUPERPAGE_2MB_SHIFT; + do + { + sr_set_bit(pfn, &ctx->x86.hvm.restore.attempted_2m); + } while (++pfn <= gap_end >> SUPERPAGE_2MB_SHIFT); + + pfn = gap_start; + + while ( pfn <= gap_end ) + { + if ( sr_test_and_clear_bit(pfn, &ctx->x86.hvm.restore.allocated_pfns) ) + { + domid = ctx->domid; + _pfn = pfn; + rc = xc_domain_decrease_reservation_exact(xch, domid, 1, 0, &_pfn); + if ( rc ) + { + PERROR("Failed to release pfn %" PRI_xen_pfn, pfn); + return -1; + } + ctx->restore.tot_pages--; + freed++; + } + pfn++; + } + if ( freed ) + DPRINTF("freed %u between %" PRI_xen_pfn " %" PRI_xen_pfn "\n", + freed, gap_start, gap_end); + return 0; +} + +static int x86_hvm_unpopulate_page(struct xc_sr_context *ctx, xen_pfn_t pfn) +{ + sr_clear_bit(pfn, &ctx->restore.populated_pfns); + return x86_hvm_punch_hole(ctx, pfn, pfn); +} + +static int x86_hvm_populate_page(struct xc_sr_context *ctx, xen_pfn_t pfn) +{ + xen_pfn_t gap_start, gap_end; + bool has_gap, first_iteration; + int rc; + + /* + * Check for a gap between the previous populated pfn and this pfn. + * In case a gap exists, it is required to punch a hole to release memory, + * starting after the previous pfn and before this pfn. + * + * But: this can be done only during the first iteration, which is the + * only place there superpage allocations are attempted. All following + * iterations lack the info to properly maintain prev_populated_pfn. + */ + has_gap = ctx->x86.hvm.restore.prev_populated_pfn + 1 < pfn; + first_iteration = ctx->x86.hvm.restore.iteration == 0; + if ( has_gap && first_iteration ) + { + gap_start = ctx->x86.hvm.restore.prev_populated_pfn + 1; + gap_end = pfn - 1; + + rc = x86_hvm_punch_hole(ctx, gap_start, gap_end); + if ( rc ) + goto err; + } + + rc = x86_hvm_allocate_pfn(ctx, pfn); + if ( rc ) + goto err; + pfn_set_populated(ctx, pfn); + ctx->x86.hvm.restore.prev_populated_pfn = pfn; + + rc = 0; +err: + return rc; +} + +/* + * Try to allocate superpages. + * This works without memory map because the pfns arrive in incremental order. + * All pfn numbers and their type are submitted. + * Only pfns with data will have also pfn content transmitted. + */ +static int x86_hvm_populate_pfns(struct xc_sr_context *ctx, unsigned count, + const xen_pfn_t *original_pfns, + const uint32_t *types) +{ + xc_interface *xch = ctx->xch; + xen_pfn_t pfn, min_pfn, max_pfn; + bool to_populate, populated; + unsigned i = count; + int rc = 0; + + min_pfn = count ? original_pfns[0] : 0; + max_pfn = count ? original_pfns[count - 1] : 0; + DPRINTF("batch of %u pfns between %" PRI_xen_pfn " %" PRI_xen_pfn "\n", + count, min_pfn, max_pfn); + + if ( !x86_hvm_expand_sp_bitmaps(ctx, max_pfn) ) + { + ERROR("Unable to allocate memory for pfn bitmaps"); + return -1; + } + + /* + * There is no indicator for a new iteration. + * Simulate it by checking if a lower pfn is coming in. + * In the end it matters only to know if this iteration is the first one. + */ + if ( min_pfn < ctx->x86.hvm.restore.iteration_tracker_pfn ) + ctx->x86.hvm.restore.iteration++; + ctx->x86.hvm.restore.iteration_tracker_pfn = min_pfn; + + for ( i = 0; i < count; ++i ) + { + pfn = original_pfns[i]; + + to_populate = page_type_to_populate(types[i]); + populated = pfn_is_populated(ctx, pfn); + + /* + * page has data, pfn populated: nothing to do + * page has data, pfn not populated: likely never seen before + * page has no data, pfn populated: likely ballooned out during migration + * page has no data, pfn not populated: nothing to do + */ + if ( to_populate && !populated ) + { + rc = x86_hvm_populate_page(ctx, pfn); + } else if ( !to_populate && populated ) + { + rc = x86_hvm_unpopulate_page(ctx, pfn); + } + if ( rc ) + break; + } + + return rc; +} + + struct xc_sr_restore_ops restore_ops_x86_hvm = { .pfn_is_valid = x86_hvm_pfn_is_valid, @@ -266,6 +627,7 @@ struct xc_sr_restore_ops restore_ops_x86_hvm = .set_page_type = x86_hvm_set_page_type, .localise_page = x86_hvm_localise_page, .setup = x86_hvm_setup, + .populate_pfns = x86_hvm_populate_pfns, .process_record = x86_hvm_process_record, .static_data_complete = x86_static_data_complete, .stream_complete = x86_hvm_stream_complete, diff --git a/tools/libs/saverestore/restore_x86_pv.c b/tools/libs/saverestore/restore_x86_pv.c index c73a3cd99f..244f1da218 100644 --- a/tools/libs/saverestore/restore_x86_pv.c +++ b/tools/libs/saverestore/restore_x86_pv.c @@ -959,6 +959,64 @@ static void x86_pv_set_gfn(struct xc_sr_context *ctx, xen_pfn_t pfn, ((uint32_t *)ctx->x86.pv.p2m)[pfn] = mfn; } +/* + * Given a set of pfns, obtain memory from Xen to fill the physmap for the + * unpopulated subset. If types is NULL, no page type checking is performed + * and all unpopulated pfns are populated. + */ +static int x86_pv_populate_pfns(struct xc_sr_context *ctx, unsigned count, + const xen_pfn_t *original_pfns, + const uint32_t *types) +{ + xc_interface *xch = ctx->xch; + xen_pfn_t *mfns = ctx->restore.m->pp_mfns, + *pfns = ctx->restore.m->pp_pfns; + unsigned int i, nr_pfns = 0; + int rc = -1; + + for ( i = 0; i < count; ++i ) + { + if ( (!types || + (types && page_type_has_stream_data(types[i]) == true)) && + !pfn_is_populated(ctx, original_pfns[i]) ) + { + rc = pfn_set_populated(ctx, original_pfns[i]); + if ( rc ) + goto err; + pfns[nr_pfns] = mfns[nr_pfns] = original_pfns[i]; + ++nr_pfns; + } + } + + if ( nr_pfns ) + { + rc = xc_domain_populate_physmap_exact( + xch, ctx->domid, nr_pfns, 0, 0, mfns); + if ( rc ) + { + PERROR("Failed to populate physmap"); + goto err; + } + + for ( i = 0; i < nr_pfns; ++i ) + { + if ( mfns[i] == INVALID_MFN ) + { + ERROR("Populate physmap failed for pfn %u", i); + rc = -1; + goto err; + } + + ctx->restore.ops.set_gfn(ctx, pfns[i], mfns[i]); + } + } + + rc = 0; + + err: + return rc; +} + /* * restore_ops function. Convert pfns back to mfns in pagetables. Possibly * needs to populate new frames if a PTE is found referring to a frame which @@ -1003,7 +1061,7 @@ static int x86_pv_localise_page(struct xc_sr_context *ctx, } } - if ( to_populate && populate_pfns(ctx, to_populate, pfns, NULL) ) + if ( to_populate && x86_pv_populate_pfns(ctx, to_populate, pfns, NULL) ) return -1; for ( i = 0; i < (PAGE_SIZE / sizeof(uint64_t)); ++i ) @@ -1200,6 +1258,7 @@ struct xc_sr_restore_ops restore_ops_x86_pv = .set_gfn = x86_pv_set_gfn, .localise_page = x86_pv_localise_page, .setup = x86_pv_setup, + .populate_pfns = x86_pv_populate_pfns, .process_record = x86_pv_process_record, .static_data_complete = x86_static_data_complete, .stream_complete = x86_pv_stream_complete, From xen-devel-bounces@lists.xenproject.org Thu Jul 01 10:02:05 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 10:02:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148445.274435 (Exim 4.92) (envelope-from ) id 1lytWH-0003Qx-J7; Thu, 01 Jul 2021 10:02:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148445.274435; Thu, 01 Jul 2021 10:02:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lytWH-0003P2-AU; Thu, 01 Jul 2021 10:02:05 +0000 Received: by outflank-mailman (input) for mailman id 148445; Thu, 01 Jul 2021 10:02:04 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lytSR-0004r4-IA for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 09:58:07 +0000 Received: from mo4-p03-ob.smtp.rzone.de (unknown [85.215.255.103]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id c67c5005-9db6-4605-a9a1-894bd03374d3; Thu, 01 Jul 2021 09:57:04 +0000 (UTC) Received: from sender by smtp.strato.de (RZmta 47.28.1 AUTH) with ESMTPSA id 30791cx619ut5NZ (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Thu, 1 Jul 2021 11:56:55 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c67c5005-9db6-4605-a9a1-894bd03374d3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1625133416; s=strato-dkim-0002; d=aepfle.de; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Cc:Date: From:Subject:Sender; bh=am1tugVzg71doIb/LdiNWtayiDvPFoCjZNyMmciOrqY=; b=S31S0Jt1lo62PKxR9+Zf+Yg69D9KtTrkK70UgDAz146NRRLagnFrm5ubU1mi6Qkg/q Q2GmvdaoeUv8qexauJe8nt7STm03F5HQ7NsRv++KlTNGUhXly65XZCvY9WmJ4DblKL01 l2FXO2a1tIKUC0XNjvSZsGBQcye/w0Ec2WQiUQCiDE0VGBu0cm4GjYGlak4zXxa6dV4Z YWNhhVHIhlrsyOBFjkKkSlItkPEeHUs2TLaYO6bZACVXFZv2yZ4nk+DN1wD5ArOT9tVl qwBaTla3EyL/J+ttb+EPxMC840ZGALDGTFqS9LCu32ZjbyWEHwjO5IIlNjijU0BufqPj sxFA== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QXkBR9MXjAuzpIG0mv9coXAg5lqlz7EsstGyDcxK3Mbajr+SQKopp1Cb0CyyaZQQ==" X-RZG-CLASS-ID: mo00 From: Olaf Hering To: xen-devel@lists.xenproject.org Cc: Olaf Hering , Ian Jackson , Wei Liu , Anthony PERARD , Juergen Gross Subject: [PATCH v20210701 34/40] tools: add callback to libxl for precopy_policy and precopy_stats_t Date: Thu, 1 Jul 2021 11:56:29 +0200 Message-Id: <20210701095635.15648-35-olaf@aepfle.de> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210701095635.15648-1-olaf@aepfle.de> References: <20210701095635.15648-1-olaf@aepfle.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This duplicates simple_precopy_policy. To recap its purpose: - do up to 5 iterations of copying dirty domU memory to target, including the initial copying of all domU memory, excluding the final copying while the domU is suspended - do fewer iterations in case the domU dirtied less than 50 pages Take the opportunity to also move xen_pfn_t into qw(). Signed-off-by: Olaf Hering --- tools/libs/light/libxl_dom_save.c | 19 +++++++++++++++++++ tools/libs/light/libxl_internal.h | 2 ++ tools/libs/light/libxl_save_msgs_gen.pl | 3 ++- 3 files changed, 23 insertions(+), 1 deletion(-) diff --git a/tools/libs/light/libxl_dom_save.c b/tools/libs/light/libxl_dom_save.c index 32e3cb5a13..3f3cff0342 100644 --- a/tools/libs/light/libxl_dom_save.c +++ b/tools/libs/light/libxl_dom_save.c @@ -373,6 +373,24 @@ int libxl__save_emulator_xenstore_data(libxl__domain_save_state *dss, return rc; } +static int libxl__domain_save_precopy_policy(precopy_stats_t stats, void *user) +{ + libxl__save_helper_state *shs = user; + libxl__domain_save_state *dss = shs->caller_state; + STATE_AO_GC(dss->ao); + + LOGD(DEBUG, shs->domid, "iteration %u dirty_count %ld total_written %lu", + stats.iteration, stats.dirty_count, stats.total_written); + if (stats.dirty_count >= 0 && stats.dirty_count < LIBXL_XGS_POLICY_TARGET_DIRTY_COUNT) + goto stop_copy; + if (stats.iteration >= LIBXL_XGS_POLICY_MAX_ITERATIONS) + goto stop_copy; + return XGS_POLICY_CONTINUE_PRECOPY; + +stop_copy: + return XGS_POLICY_STOP_AND_COPY; +} + /*----- main code for saving, in order of execution -----*/ void libxl__domain_save(libxl__egc *egc, libxl__domain_save_state *dss) @@ -430,6 +448,7 @@ void libxl__domain_save(libxl__egc *egc, libxl__domain_save_state *dss) callbacks->suspend = libxl__domain_suspend_callback; callbacks->switch_qemu_logdirty = libxl__domain_suspend_common_switch_qemu_logdirty; + callbacks->precopy_policy = libxl__domain_save_precopy_policy; dss->sws.ao = dss->ao; dss->sws.dss = dss; diff --git a/tools/libs/light/libxl_internal.h b/tools/libs/light/libxl_internal.h index 439c654733..57d7e4b4b8 100644 --- a/tools/libs/light/libxl_internal.h +++ b/tools/libs/light/libxl_internal.h @@ -125,6 +125,8 @@ #define DOMID_XS_PATH "domid" #define PVSHIM_BASENAME "xen-shim" #define PVSHIM_CMDLINE "pv-shim console=xen,pv" +#define LIBXL_XGS_POLICY_MAX_ITERATIONS 5 +#define LIBXL_XGS_POLICY_TARGET_DIRTY_COUNT 50 /* Size macros. */ #define __AC(X,Y) (X##Y) diff --git a/tools/libs/light/libxl_save_msgs_gen.pl b/tools/libs/light/libxl_save_msgs_gen.pl index f263ee01bb..ab55c81644 100755 --- a/tools/libs/light/libxl_save_msgs_gen.pl +++ b/tools/libs/light/libxl_save_msgs_gen.pl @@ -23,6 +23,7 @@ our @msgs = ( STRING doing_what), 'unsigned long', 'done', 'unsigned long', 'total'] ], + [ 'scxW', "precopy_policy", ['precopy_stats_t', 'stats'] ], [ 'srcxA', "suspend", [] ], [ 'srcxA', "postcopy", [] ], [ 'srcxA', "checkpoint", [] ], @@ -142,7 +143,7 @@ static void bytes_put(unsigned char *const buf, int *len, END -foreach my $simpletype (qw(int uint16_t uint32_t unsigned), 'unsigned long', 'xen_pfn_t') { +foreach my $simpletype (qw(int uint16_t uint32_t unsigned precopy_stats_t xen_pfn_t), 'unsigned long') { my $typeid = typeid($simpletype); $out_body{'callout'} .= < Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 10:02:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148450.274442 (Exim 4.92) (envelope-from ) id 1lytWI-0003fq-EY; Thu, 01 Jul 2021 10:02:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148450.274442; Thu, 01 Jul 2021 10:02:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lytWI-0003e4-4A; Thu, 01 Jul 2021 10:02:06 +0000 Received: by outflank-mailman (input) for mailman id 148450; Thu, 01 Jul 2021 10:02:04 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lytSF-0004XT-T9 for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 09:57:55 +0000 Received: from mo4-p03-ob.smtp.rzone.de (unknown [81.169.146.172]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 8f5aaa21-467c-4219-8fba-a36d20e9b099; Thu, 01 Jul 2021 09:56:54 +0000 (UTC) Received: from sender by smtp.strato.de (RZmta 47.28.1 AUTH) with ESMTPSA id 30791cx619um5NA (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Thu, 1 Jul 2021 11:56:48 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8f5aaa21-467c-4219-8fba-a36d20e9b099 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1625133408; s=strato-dkim-0002; d=aepfle.de; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Cc:Date: From:Subject:Sender; bh=xJ7EM0+9FDIAYOBy0R8s1Qys8qJMuiw+N5Xy4+8lTRo=; b=ecp23n+S6r+4J3vKtWX10SGOt6Su4h9JFji2tuLPVYzQv5MY7bYqyPFuHG0tK9wydu K+2wARe/QyYDm/49/2uQKd5An2WKG5l5LORbdXBW5WK3FMqSkUb/cIb076s16lRmodRN JrxlWRGRFwju9v/xJgdjLsjsp7vKDolsGue95kwLbMUbtQd8LPIZtEOAeaZslf6aC2pA Sw/ZPth5/AqS4Lz5laaV64HIPImMq3W4Pcexyxa4QPra1O8tQhiKM41ym+zRxs8pNo+/ EdAMzXYxblAPDipzbkUjyYm1f9JyxZDInIfzDsVGatH7e+M/2lcKgIm+p0WHbAQSzFVN AUmA== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QXkBR9MXjAuzpIG0mv9coXAg5lqlz7EsstGyDcxK3Mbajr+SQKopp1Cb0CyyaZQQ==" X-RZG-CLASS-ID: mo00 From: Olaf Hering To: xen-devel@lists.xenproject.org Cc: Olaf Hering , Juergen Gross , Ian Jackson , Wei Liu Subject: [PATCH v20210701 20/40] tools: save: move rec_pfns array Date: Thu, 1 Jul 2021 11:56:15 +0200 Message-Id: <20210701095635.15648-21-olaf@aepfle.de> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210701095635.15648-1-olaf@aepfle.de> References: <20210701095635.15648-1-olaf@aepfle.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Remove allocation from hotpath, move rec_pfns array into preallocated space. Signed-off-by: Olaf Hering Reviewed-by: Juergen Gross --- tools/libs/saverestore/common.h | 2 ++ tools/libs/saverestore/save.c | 11 +---------- 2 files changed, 3 insertions(+), 10 deletions(-) diff --git a/tools/libs/saverestore/common.h b/tools/libs/saverestore/common.h index c8a30acf7b..3994ab3844 100644 --- a/tools/libs/saverestore/common.h +++ b/tools/libs/saverestore/common.h @@ -233,6 +233,8 @@ struct sr_save_arrays { int errors[MAX_BATCH_SIZE]; /* write_batch: iovec[] for writev(). */ struct iovec iov[MAX_BATCH_SIZE + 4]; + /* write_batch */ + uint64_t rec_pfns[MAX_BATCH_SIZE]; }; struct sr_restore_arrays { diff --git a/tools/libs/saverestore/save.c b/tools/libs/saverestore/save.c index 1a5f3d29ea..0f02988ff9 100644 --- a/tools/libs/saverestore/save.c +++ b/tools/libs/saverestore/save.c @@ -96,7 +96,7 @@ static int write_batch(struct xc_sr_context *ctx) unsigned int i, p, nr_pages = 0, nr_pages_mapped = 0; unsigned int nr_pfns = ctx->save.nr_batch_pfns; void *page, *orig_page; - uint64_t *rec_pfns = NULL; + uint64_t *rec_pfns = ctx->save.m->rec_pfns; struct iovec *iov = ctx->save.m->iov; int iovcnt = 0; struct xc_sr_rec_page_data_header hdr = { 0 }; struct xc_sr_record rec = { @@ -201,14 +201,6 @@ static int write_batch(struct xc_sr_context *ctx) } } - rec_pfns = malloc(nr_pfns * sizeof(*rec_pfns)); - if ( !rec_pfns ) - { - ERROR("Unable to allocate %zu bytes of memory for page data pfn list", - nr_pfns * sizeof(*rec_pfns)); - goto err; - } - hdr.count = nr_pfns; rec.length = sizeof(hdr); @@ -259,7 +251,6 @@ static int write_batch(struct xc_sr_context *ctx) rc = ctx->save.nr_batch_pfns = 0; err: - free(rec_pfns); if ( guest_mapping ) xenforeignmemory_unmap(xch->fmem, guest_mapping, nr_pages_mapped); for ( i = 0; local_pages && i < nr_pfns; ++i ) From xen-devel-bounces@lists.xenproject.org Thu Jul 01 10:02:11 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 10:02:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148459.274463 (Exim 4.92) (envelope-from ) id 1lytWN-0004bp-RC; Thu, 01 Jul 2021 10:02:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148459.274463; Thu, 01 Jul 2021 10:02:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lytWN-0004bZ-LD; Thu, 01 Jul 2021 10:02:11 +0000 Received: by outflank-mailman (input) for mailman id 148459; Thu, 01 Jul 2021 10:02:11 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lytT3-0004XT-Uz for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 09:58:45 +0000 Received: from mo4-p03-ob.smtp.rzone.de (unknown [81.169.146.172]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id ce866e23-22a8-4ca0-a2a8-b1be12cba45e; Thu, 01 Jul 2021 09:57:01 +0000 (UTC) Received: from sender by smtp.strato.de (RZmta 47.28.1 AUTH) with ESMTPSA id 30791cx619us5NY (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Thu, 1 Jul 2021 11:56:54 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ce866e23-22a8-4ca0-a2a8-b1be12cba45e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1625133415; s=strato-dkim-0002; d=aepfle.de; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Cc:Date: From:Subject:Sender; bh=yuafVLq2aG35iRtmsU2Mgmytxa4WOaE4NXl9z9jSB2o=; b=Hsg1ND1EL5IMwp88Gl0qTaM2/mCUSaQ17bsPAiq++O+Xz533TUGNCQ3NxadVT/GIIY uLhJnjczyyus/WqAMECiOsPEBr3LTv4pBs/BseMGMUDqadXrkjFsxCRRzD9uNNUSaASc BaxACe1wOrs8ksgFb6aEvc9SA27yse1vqdrBazsAvVDFuHFkeNGRaT7kt/ARBWpVe0KW O7sn9ayndZrsZsEccohssOWkCT5FqkoxS6tPywhCAdfkKxkNKJPalCyHzNrIS3ctgP14 xOVq8qVVtfqTDHqP8ImXwEwTvVFBh0PEm8M/SC7Swoo6zTKFZnypQLhVBPZw0Zno5Lro sq9Q== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QXkBR9MXjAuzpIG0mv9coXAg5lqlz7EsstGyDcxK3Mbajr+SQKopp1Cb0CyyaZQQ==" X-RZG-CLASS-ID: mo00 From: Olaf Hering To: xen-devel@lists.xenproject.org Cc: Olaf Hering , Ian Jackson , Wei Liu , Juergen Gross Subject: [PATCH v20210701 33/40] tools: change struct precopy_stats to precopy_stats_t Date: Thu, 1 Jul 2021 11:56:28 +0200 Message-Id: <20210701095635.15648-34-olaf@aepfle.de> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210701095635.15648-1-olaf@aepfle.de> References: <20210701095635.15648-1-olaf@aepfle.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This will help libxl_save_msgs_gen.pl to copy the struct as a region of memory. No change in behavior intented. Signed-off-by: Olaf Hering --- tools/include/xensaverestore.h | 7 +++---- tools/libs/saverestore/common.h | 2 +- tools/libs/saverestore/save.c | 6 +++--- 3 files changed, 7 insertions(+), 8 deletions(-) diff --git a/tools/include/xensaverestore.h b/tools/include/xensaverestore.h index 0410f0469e..dca0134605 100644 --- a/tools/include/xensaverestore.h +++ b/tools/include/xensaverestore.h @@ -23,18 +23,17 @@ #define XCFLAGS_DEBUG (1 << 1) /* For save's precopy_policy(). */ -struct precopy_stats -{ +typedef struct { unsigned int iteration; unsigned long total_written; long dirty_count; /* -1 if unknown */ -}; +} precopy_stats_t; /* * A precopy_policy callback may not be running in the same address * space as libxc an so precopy_stats is passed by value. */ -typedef int (*precopy_policy_t)(struct precopy_stats, void *); +typedef int (*precopy_policy_t)(precopy_stats_t, void *); /* callbacks provided by xc_domain_save */ struct save_callbacks { diff --git a/tools/libs/saverestore/common.h b/tools/libs/saverestore/common.h index 3adcf2f83f..bb7e437291 100644 --- a/tools/libs/saverestore/common.h +++ b/tools/libs/saverestore/common.h @@ -283,7 +283,7 @@ struct xc_sr_context size_t pages_sent; size_t overhead_sent; - struct precopy_stats stats; + precopy_stats_t stats; unsigned int nr_batch_pfns; unsigned long *deferred_pages; diff --git a/tools/libs/saverestore/save.c b/tools/libs/saverestore/save.c index e486bce96f..537b977ba8 100644 --- a/tools/libs/saverestore/save.c +++ b/tools/libs/saverestore/save.c @@ -488,7 +488,7 @@ static int update_progress_string(struct xc_sr_context *ctx, char **str) #define SPP_MAX_ITERATIONS 5 #define SPP_TARGET_DIRTY_COUNT 50 -static int simple_precopy_policy(struct precopy_stats stats, void *user) +static int simple_precopy_policy(precopy_stats_t stats, void *user) { return ((stats.dirty_count >= 0 && stats.dirty_count < SPP_TARGET_DIRTY_COUNT) || @@ -515,13 +515,13 @@ static int send_memory_live(struct xc_sr_context *ctx) precopy_policy_t precopy_policy = ctx->save.callbacks->precopy_policy; void *data = ctx->save.callbacks->data; - struct precopy_stats *policy_stats; + precopy_stats_t *policy_stats; rc = update_progress_string(ctx, &progress_str); if ( rc ) goto out; - ctx->save.stats = (struct precopy_stats){ + ctx->save.stats = (precopy_stats_t){ .dirty_count = ctx->save.p2m_size, }; policy_stats = &ctx->save.stats; From xen-devel-bounces@lists.xenproject.org Thu Jul 01 10:02:13 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 10:02:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148461.274473 (Exim 4.92) (envelope-from ) id 1lytWP-0004vl-7L; Thu, 01 Jul 2021 10:02:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148461.274473; Thu, 01 Jul 2021 10:02:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lytWP-0004vW-1d; Thu, 01 Jul 2021 10:02:13 +0000 Received: by outflank-mailman (input) for mailman id 148461; Thu, 01 Jul 2021 10:02:11 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lytRx-0004r4-H0 for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 09:57:37 +0000 Received: from mo4-p03-ob.smtp.rzone.de (unknown [85.215.255.100]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 290751bb-7f5b-49db-83ad-786e01024b54; Thu, 01 Jul 2021 09:56:58 +0000 (UTC) Received: from sender by smtp.strato.de (RZmta 47.28.1 AUTH) with ESMTPSA id 30791cx619ur5NT (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Thu, 1 Jul 2021 11:56:53 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 290751bb-7f5b-49db-83ad-786e01024b54 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1625133413; s=strato-dkim-0002; d=aepfle.de; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Cc:Date: From:Subject:Sender; bh=CECljmMn7PUdmmrOXwMW+tlXTDlbFy0SLwiI5WugPX4=; b=p+92q4HQUSPoR2cRBMqVwfDE0UMRi9sa92T7loltuZ6QafgAURxR0r+r8QcTf+NOJ/ vz9CPzssgi19g8KRpxs0qzc6jNV0mY9LmjjCQ1ydnJmZk9gOOC78BpMIhRY4qBf8dBCe y0AJKW4+155VlDHfKBBd3I25YfcE2psg1x/B/lg+mUQfSg4Xh6464NoX1JNvSmrOa7/d 5okyWBC0JN5DtTCc5GJHFqOKzK4alpCbvtfVGIP5nTFJYuIEC7lOad1yf10WrJ5irDLM Ln+hxBX7pnvM7XrIWxm4ZjcXBxjTTPfXXnvWLipxM0E9246GfFhsMoGa+EdIbxW/6qiA aXHw== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QXkBR9MXjAuzpIG0mv9coXAg5lqlz7EsstGyDcxK3Mbajr+SQKopp1Cb0CyyaZQQ==" X-RZG-CLASS-ID: mo00 From: Olaf Hering To: xen-devel@lists.xenproject.org Cc: Olaf Hering , Ian Jackson , Wei Liu , Juergen Gross Subject: [PATCH v20210701 30/40] tools: restore: write data directly into guest Date: Thu, 1 Jul 2021 11:56:25 +0200 Message-Id: <20210701095635.15648-31-olaf@aepfle.de> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210701095635.15648-1-olaf@aepfle.de> References: <20210701095635.15648-1-olaf@aepfle.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Read incoming migration stream directly into the guest memory. This avoids the memory allocation and copying, and the resulting performance penalty. Signed-off-by: Olaf Hering --- tools/libs/saverestore/common.h | 1 + tools/libs/saverestore/restore.c | 132 ++++++++++++++++++++++++++++++- 2 files changed, 129 insertions(+), 4 deletions(-) diff --git a/tools/libs/saverestore/common.h b/tools/libs/saverestore/common.h index 96bd0ab80e..3adcf2f83f 100644 --- a/tools/libs/saverestore/common.h +++ b/tools/libs/saverestore/common.h @@ -243,6 +243,7 @@ struct sr_restore_arrays { xen_pfn_t mfns[MAX_BATCH_SIZE]; int map_errs[MAX_BATCH_SIZE]; void *guest_data[MAX_BATCH_SIZE]; + struct iovec iov[MAX_BATCH_SIZE]; /* populate_pfns */ xen_pfn_t pp_mfns[MAX_BATCH_SIZE]; diff --git a/tools/libs/saverestore/restore.c b/tools/libs/saverestore/restore.c index 7643de58e0..53f05f1b65 100644 --- a/tools/libs/saverestore/restore.c +++ b/tools/libs/saverestore/restore.c @@ -392,6 +392,122 @@ err: return rc; } +/* + * Handle PAGE_DATA record from the stream. + * Given a list of pfns, their types, and a block of page data from the + * stream, populate and record their types, map the relevant subset and copy + * the data into the guest. + */ +static int handle_incoming_page_data(struct xc_sr_context *ctx, + struct xc_sr_rhdr *rhdr) +{ + xc_interface *xch = ctx->xch; + struct sr_restore_arrays *m = ctx->restore.m; + struct xc_sr_rec_page_data_header *pages = &m->pages; + uint64_t *pfn_nums = m->pages.pfn; + uint32_t i; + int rc, iov_idx; + + rc = handle_static_data_end_v2(ctx); + if ( rc ) + goto err; + + /* First read and verify the header */ + rc = read_exact(ctx->fd, pages, sizeof(*pages)); + if ( rc ) + { + PERROR("Could not read rec_pfn header"); + goto err; + } + + if ( verify_rec_page_hdr(ctx, rhdr->length, pages) == false ) + { + rc = -1; + goto err; + } + + /* Then read and verify the incoming pfn numbers */ + rc = read_exact(ctx->fd, pfn_nums, sizeof(*pfn_nums) * pages->count); + if ( rc ) + { + PERROR("Could not read rec_pfn data"); + goto err; + } + + if ( verify_rec_page_pfns(ctx, rhdr->length, pages) == false ) + { + rc = -1; + goto err; + } + + /* Finally read and verify the incoming pfn data */ + rc = map_guest_pages(ctx, pages); + if ( rc ) + goto err; + + /* Prepare read buffers, either guest or throw away memory */ + for ( i = 0, iov_idx = 0; i < pages->count; i++ ) + { + if ( !m->guest_data[i] ) + continue; + + m->iov[iov_idx].iov_len = PAGE_SIZE; + if ( ctx->restore.verify ) + m->iov[iov_idx].iov_base = ctx->restore.verify_buf + i * PAGE_SIZE; + else + m->iov[iov_idx].iov_base = m->guest_data[i]; + iov_idx++; + } + + if ( !iov_idx ) + goto done; + + rc = readv_exact(ctx->fd, m->iov, iov_idx); + if ( rc ) + { + PERROR("read of %d pages failed", iov_idx); + goto err; + } + + /* Post-processing of pfn data */ + for ( i = 0, iov_idx = 0; i < pages->count; i++ ) + { + if ( !m->guest_data[i] ) + continue; + + rc = ctx->restore.ops.localise_page(ctx, m->types[i], m->iov[iov_idx].iov_base); + if ( rc ) + { + ERROR("Failed to localise pfn %#"PRIpfn" (type %#"PRIx32")", + m->pfns[i], m->types[i] >> XEN_DOMCTL_PFINFO_LTAB_SHIFT); + goto err; + + } + + if ( ctx->restore.verify ) + { + if ( memcmp(m->guest_data[i], m->iov[iov_idx].iov_base, PAGE_SIZE) ) + { + ERROR("verify pfn %#"PRIpfn" failed (type %#"PRIx32")", + m->pfns[i], m->types[i] >> XEN_DOMCTL_PFINFO_LTAB_SHIFT); + } + } + + iov_idx++; + } + +done: + rc = 0; + +err: + if ( ctx->restore.guest_mapping ) + { + xenforeignmemory_unmap(xch->fmem, ctx->restore.guest_mapping, ctx->restore.nr_mapped_pages); + ctx->restore.guest_mapping = NULL; + } + return rc; +} + /* * Handle PAGE_DATA record from an existing buffer * Given a list of pfns, their types, and a block of page data from the @@ -773,11 +889,19 @@ static int process_incoming_record_header(struct xc_sr_context *ctx, struct xc_s struct xc_sr_record rec; int rc; - rc = read_record_data(ctx, ctx->fd, rhdr, &rec); - if ( rc ) - return rc; + switch ( rhdr->type ) + { + case REC_TYPE_PAGE_DATA: + rc = handle_incoming_page_data(ctx, rhdr); + break; + default: + rc = read_record_data(ctx, ctx->fd, rhdr, &rec); + if ( rc == 0 ) + rc = process_buffered_record(ctx, &rec);; + break; + } - return process_buffered_record(ctx, &rec); + return rc; } From xen-devel-bounces@lists.xenproject.org Thu Jul 01 10:02:14 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 10:02:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148463.274479 (Exim 4.92) (envelope-from ) id 1lytWP-00051S-R2; Thu, 01 Jul 2021 10:02:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148463.274479; Thu, 01 Jul 2021 10:02:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lytWP-0004zr-Dc; Thu, 01 Jul 2021 10:02:13 +0000 Received: by outflank-mailman (input) for mailman id 148463; Thu, 01 Jul 2021 10:02:11 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lytSW-0004r4-IF for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 09:58:12 +0000 Received: from mo4-p02-ob.smtp.rzone.de (unknown [85.215.255.82]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 323d7809-47e8-408f-a235-91f0414dce21; Thu, 01 Jul 2021 09:57:03 +0000 (UTC) Received: from sender by smtp.strato.de (RZmta 47.28.1 AUTH) with ESMTPSA id 30791cx619ug5Mm (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Thu, 1 Jul 2021 11:56:42 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 323d7809-47e8-408f-a235-91f0414dce21 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1625133402; s=strato-dkim-0002; d=aepfle.de; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Cc:Date: From:Subject:Sender; bh=NHXITGMwQK1fkhH9Z9SjS8KzA+TTnDL8//gJ5t70QPA=; b=oluRZMKVNr1Zr0vhtJJwgqz8JuGf78CLNRObGsF4RqcuV82oxD1XP1eNN8wAw+CV4M dcN1wT3qh1k2ufVHGmHEIx478TqNCH4DJ4f6bng+a8up24s5qVcFd5l6Y1He0c5J3mre KFeeHmun3oOJ7LlzpeqigPFAFU3zmIJTKBPglniKNsG+Wkp25kjh8r5zve0GlqYOcjqf zC11EWYYjCRHRgzuCBs7Oh2L6QCYoCGHrgN5c3VK9dSaktijG5vsnI1q+FgoAxpyd8ya JQ74oXqHoAsYpHM+/Vyl1lg2VJgkh98zybLEqvyKomHyojbKH024tHzCpCLAPxF+Su52 Ob+Q== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QXkBR9MXjAuzpIG0mv9coXAg5lqlz7EsstGyDcxK3Mbajr+SQKopp1Cb0CyyaZQQ==" X-RZG-CLASS-ID: mo00 From: Olaf Hering To: xen-devel@lists.xenproject.org Cc: Olaf Hering , Wei Liu , Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Julien Grall , Stefano Stabellini , Juergen Gross , Anthony PERARD Subject: [PATCH v20210701 07/40] tools: create libxensaverestore Date: Thu, 1 Jul 2021 11:56:02 +0200 Message-Id: <20210701095635.15648-8-olaf@aepfle.de> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210701095635.15648-1-olaf@aepfle.de> References: <20210701095635.15648-1-olaf@aepfle.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Move all save/restore related code from libxenguest.so into a separate library libxensaverestore.so. The only consumer is libxl-save-helper. There is no need to have the moved code mapped all the time in binaries where libxenguest.so is used. According to size(1) the change is: text data bss dec hex filename 187183 4304 48 191535 2ec2f guest/libxenguest.so.4.15.0 124106 3376 48 127530 1f22a guest/libxenguest.so.4.15.0 67841 1872 8 69721 11059 saverestore/libxensaverestore.so.4.15.0 While touching the files anyway, take the opportunity to drop the redundant xg_sr_ filename prefix. Signed-off-by: Olaf Hering Acked-by: Wei Liu v6: - fix build of nomigrate.c v5: - fix spelling in description v4: - drop xg_ prefix from filenames (jgross) - drop sr_ prefix from filenames (jbeulich) v3: - repost in time for 4.16 v2: - copy also license header - move xg_nomigrate.c - add size(1) output to commit msg - remove change from libxl_create.c --- .gitignore | 2 + tools/include/xenguest.h | 186 ---------------- tools/include/xensaverestore.h | 208 ++++++++++++++++++ tools/libs/Makefile | 1 + tools/libs/guest/Makefile | 11 - tools/libs/guest/xg_offline_page.c | 1 - tools/libs/light/Makefile | 4 +- tools/libs/light/libxl_internal.h | 1 + tools/libs/light/libxl_save_helper.c | 1 + tools/libs/light/libxl_save_msgs_gen.pl | 2 +- tools/libs/saverestore/Makefile | 38 ++++ .../xg_sr_common.c => saverestore/common.c} | 2 +- .../xg_sr_common.h => saverestore/common.h} | 16 +- .../common_x86.c} | 2 +- .../common_x86.h} | 2 +- .../common_x86_pv.c} | 2 +- .../common_x86_pv.h} | 2 +- .../nomigrate.c} | 2 +- .../xg_sr_restore.c => saverestore/restore.c} | 2 +- .../restore_x86_hvm.c} | 2 +- .../restore_x86_pv.c} | 2 +- .../xg_sr_save.c => saverestore/save.c} | 2 +- .../save_restore.h} | 2 - .../save_x86_hvm.c} | 2 +- .../save_x86_pv.c} | 2 +- .../stream_format.h} | 0 tools/libs/uselibs.mk | 4 +- 27 files changed, 283 insertions(+), 218 deletions(-) create mode 100644 tools/include/xensaverestore.h create mode 100644 tools/libs/saverestore/Makefile rename tools/libs/{guest/xg_sr_common.c => saverestore/common.c} (99%) rename tools/libs/{guest/xg_sr_common.h => saverestore/common.h} (98%) rename tools/libs/{guest/xg_sr_common_x86.c => saverestore/common_x86.c} (99%) rename tools/libs/{guest/xg_sr_common_x86.h => saverestore/common_x86.h} (98%) rename tools/libs/{guest/xg_sr_common_x86_pv.c => saverestore/common_x86_pv.c} (99%) rename tools/libs/{guest/xg_sr_common_x86_pv.h => saverestore/common_x86_pv.h} (98%) rename tools/libs/{guest/xg_nomigrate.c => saverestore/nomigrate.c} (98%) rename tools/libs/{guest/xg_sr_restore.c => saverestore/restore.c} (99%) rename tools/libs/{guest/xg_sr_restore_x86_hvm.c => saverestore/restore_x86_hvm.c} (99%) rename tools/libs/{guest/xg_sr_restore_x86_pv.c => saverestore/restore_x86_pv.c} (99%) rename tools/libs/{guest/xg_sr_save.c => saverestore/save.c} (99%) rename tools/libs/{guest/xg_save_restore.h => saverestore/save_restore.h} (98%) rename tools/libs/{guest/xg_sr_save_x86_hvm.c => saverestore/save_x86_hvm.c} (99%) rename tools/libs/{guest/xg_sr_save_x86_pv.c => saverestore/save_x86_pv.c} (99%) rename tools/libs/{guest/xg_sr_stream_format.h => saverestore/stream_format.h} (100%) diff --git a/.gitignore b/.gitignore index 38a085e398..08a321e995 100644 --- a/.gitignore +++ b/.gitignore @@ -147,6 +147,8 @@ tools/libs/light/test_timedereg tools/libs/light/test_fdderegrace tools/libs/light/tmp.* tools/libs/light/xenlight.pc +tools/libs/saverestore/libxensaverestore.map +tools/libs/saverestore/xensaverestore.pc tools/libs/stat/_paths.h tools/libs/stat/headers.chk tools/libs/stat/libxenstat.map diff --git a/tools/include/xenguest.h b/tools/include/xenguest.h index 61d0a82f48..7417675b3b 100644 --- a/tools/include/xenguest.h +++ b/tools/include/xenguest.h @@ -24,9 +24,6 @@ #define XC_NUMA_NO_NODE (~0U) -#define XCFLAGS_LIVE (1 << 0) -#define XCFLAGS_DEBUG (1 << 1) - #define X86_64_B_SIZE 64 #define X86_32_B_SIZE 32 @@ -433,189 +430,6 @@ static inline xen_pfn_t xc_dom_p2m(struct xc_dom_image *dom, xen_pfn_t pfn) */ struct xenevtchn_handle; -/* For save's precopy_policy(). */ -struct precopy_stats -{ - unsigned int iteration; - unsigned long total_written; - long dirty_count; /* -1 if unknown */ -}; - -/* - * A precopy_policy callback may not be running in the same address - * space as libxc an so precopy_stats is passed by value. - */ -typedef int (*precopy_policy_t)(struct precopy_stats, void *); - -/* callbacks provided by xc_domain_save */ -struct save_callbacks { - /* - * Called after expiration of checkpoint interval, - * to suspend the guest. - */ - int (*suspend)(void *data); - - /* - * Called before and after every batch of page data sent during - * the precopy phase of a live migration to ask the caller what - * to do next based on the current state of the precopy migration. - * - * Should return one of the values listed below: - */ -#define XGS_POLICY_ABORT (-1) /* Abandon the migration entirely - * and tidy up. */ -#define XGS_POLICY_CONTINUE_PRECOPY 0 /* Remain in the precopy phase. */ -#define XGS_POLICY_STOP_AND_COPY 1 /* Immediately suspend and transmit the - * remaining dirty pages. */ - precopy_policy_t precopy_policy; - - /* - * Called after the guest's dirty pages have been - * copied into an output buffer. - * Callback function resumes the guest & the device model, - * returns to xc_domain_save. - * xc_domain_save then flushes the output buffer, while the - * guest continues to run. - */ - int (*postcopy)(void *data); - - /* - * Called after the memory checkpoint has been flushed - * out into the network. Typical actions performed in this - * callback include: - * (a) send the saved device model state (for HVM guests), - * (b) wait for checkpoint ack - * (c) release the network output buffer pertaining to the acked checkpoint. - * (c) sleep for the checkpoint interval. - * - * returns: - * 0: terminate checkpointing gracefully - * 1: take another checkpoint - */ - int (*checkpoint)(void *data); - - /* - * Called after the checkpoint callback. - * - * returns: - * 0: terminate checkpointing gracefully - * 1: take another checkpoint - */ - int (*wait_checkpoint)(void *data); - - /* Enable qemu-dm logging dirty pages to xen */ - int (*switch_qemu_logdirty)(uint32_t domid, unsigned enable, void *data); /* HVM only */ - - /* to be provided as the last argument to each callback function */ - void *data; -}; - -/* Type of stream. Plain, or using a continuous replication protocol? */ -typedef enum { - XC_STREAM_PLAIN, - XC_STREAM_REMUS, - XC_STREAM_COLO, -} xc_stream_type_t; - -/** - * This function will save a running domain. - * - * @param xch a handle to an open hypervisor interface - * @param io_fd the file descriptor to save a domain to - * @param dom the id of the domain - * @param flags XCFLAGS_xxx - * @param stream_type XC_STREAM_PLAIN if the far end of the stream - * doesn't use checkpointing - * @param recv_fd Only used for XC_STREAM_COLO. Contains backchannel from - * the destination side. - * @return 0 on success, -1 on failure - */ -int xc_domain_save(xc_interface *xch, int io_fd, uint32_t dom, - uint32_t flags, struct save_callbacks *callbacks, - xc_stream_type_t stream_type, int recv_fd); - -/* callbacks provided by xc_domain_restore */ -struct restore_callbacks { - /* - * Called once the STATIC_DATA_END record has been received/inferred. - * - * For compatibility with older streams, provides a list of static data - * expected to be found in the stream, which was missing. A higher level - * toolstack is responsible for providing any necessary compatibiltiy. - */ -#define XGR_SDD_MISSING_CPUID (1 << 0) -#define XGR_SDD_MISSING_MSR (1 << 1) - int (*static_data_done)(unsigned int missing, void *data); - - /* Called after a new checkpoint to suspend the guest. */ - int (*suspend)(void *data); - - /* - * Called after the secondary vm is ready to resume. - * Callback function resumes the guest & the device model, - * returns to xc_domain_restore. - */ - int (*postcopy)(void *data); - - /* - * A checkpoint record has been found in the stream. - * returns: - */ -#define XGR_CHECKPOINT_ERROR 0 /* Terminate processing */ -#define XGR_CHECKPOINT_SUCCESS 1 /* Continue reading more data from the stream */ -#define XGR_CHECKPOINT_FAILOVER 2 /* Failover and resume VM */ - int (*checkpoint)(void *data); - - /* - * Called after the checkpoint callback. - * - * returns: - * 0: terminate checkpointing gracefully - * 1: take another checkpoint - */ - int (*wait_checkpoint)(void *data); - - /* - * callback to send store gfn and console gfn to xl - * if we want to resume vm before xc_domain_save() - * exits. - */ - void (*restore_results)(xen_pfn_t store_gfn, xen_pfn_t console_gfn, - void *data); - - /* to be provided as the last argument to each callback function */ - void *data; -}; - -/** - * This function will restore a saved domain. - * - * Domain is restored in a suspended state ready to be unpaused. - * - * @param xch a handle to an open hypervisor interface - * @param io_fd the file descriptor to restore a domain from - * @param dom the id of the domain - * @param store_evtchn the xenstore event channel for this domain to use - * @param store_mfn filled with the gfn of the store page - * @param store_domid the backend domain for xenstore - * @param console_evtchn the console event channel for this domain to use - * @param console_mfn filled with the gfn of the console page - * @param console_domid the backend domain for xenconsole - * @param stream_type XC_STREAM_PLAIN if the far end of the stream is using - * checkpointing - * @param callbacks non-NULL to receive a callback to restore toolstack - * specific data - * @param send_back_fd Only used for XC_STREAM_COLO. Contains backchannel to - * the source side. - * @return 0 on success, -1 on failure - */ -int xc_domain_restore(xc_interface *xch, int io_fd, uint32_t dom, - unsigned int store_evtchn, unsigned long *store_mfn, - uint32_t store_domid, unsigned int console_evtchn, - unsigned long *console_mfn, uint32_t console_domid, - xc_stream_type_t stream_type, - struct restore_callbacks *callbacks, int send_back_fd); - /** * This function will create a domain for a paravirtualized Linux * using file names pointing to kernel and ramdisk diff --git a/tools/include/xensaverestore.h b/tools/include/xensaverestore.h new file mode 100644 index 0000000000..0410f0469e --- /dev/null +++ b/tools/include/xensaverestore.h @@ -0,0 +1,208 @@ +/****************************************************************************** + * A library for guest domain save/restore/migration in Xen. + * + * Copyright (c) 2003-2004, K A Fraser. + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; + * version 2.1 of the License. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; If not, see . + */ +#ifndef XENSAVERESTORE_H +#define XENSAVERESTORE_H + +#define XCFLAGS_LIVE (1 << 0) +#define XCFLAGS_DEBUG (1 << 1) + +/* For save's precopy_policy(). */ +struct precopy_stats +{ + unsigned int iteration; + unsigned long total_written; + long dirty_count; /* -1 if unknown */ +}; + +/* + * A precopy_policy callback may not be running in the same address + * space as libxc an so precopy_stats is passed by value. + */ +typedef int (*precopy_policy_t)(struct precopy_stats, void *); + +/* callbacks provided by xc_domain_save */ +struct save_callbacks { + /* + * Called after expiration of checkpoint interval, + * to suspend the guest. + */ + int (*suspend)(void *data); + + /* + * Called before and after every batch of page data sent during + * the precopy phase of a live migration to ask the caller what + * to do next based on the current state of the precopy migration. + * + * Should return one of the values listed below: + */ +#define XGS_POLICY_ABORT (-1) /* Abandon the migration entirely + * and tidy up. */ +#define XGS_POLICY_CONTINUE_PRECOPY 0 /* Remain in the precopy phase. */ +#define XGS_POLICY_STOP_AND_COPY 1 /* Immediately suspend and transmit the + * remaining dirty pages. */ + precopy_policy_t precopy_policy; + + /* + * Called after the guest's dirty pages have been + * copied into an output buffer. + * Callback function resumes the guest & the device model, + * returns to xc_domain_save. + * xc_domain_save then flushes the output buffer, while the + * guest continues to run. + */ + int (*postcopy)(void *data); + + /* + * Called after the memory checkpoint has been flushed + * out into the network. Typical actions performed in this + * callback include: + * (a) send the saved device model state (for HVM guests), + * (b) wait for checkpoint ack + * (c) release the network output buffer pertaining to the acked checkpoint. + * (c) sleep for the checkpoint interval. + * + * returns: + * 0: terminate checkpointing gracefully + * 1: take another checkpoint + */ + int (*checkpoint)(void *data); + + /* + * Called after the checkpoint callback. + * + * returns: + * 0: terminate checkpointing gracefully + * 1: take another checkpoint + */ + int (*wait_checkpoint)(void *data); + + /* Enable qemu-dm logging dirty pages to xen */ + int (*switch_qemu_logdirty)(uint32_t domid, unsigned enable, void *data); /* HVM only */ + + /* to be provided as the last argument to each callback function */ + void *data; +}; + +/* Type of stream. Plain, or using a continuous replication protocol? */ +typedef enum { + XC_STREAM_PLAIN, + XC_STREAM_REMUS, + XC_STREAM_COLO, +} xc_stream_type_t; + +/** + * This function will save a running domain. + * + * @param xch a handle to an open hypervisor interface + * @param io_fd the file descriptor to save a domain to + * @param dom the id of the domain + * @param flags XCFLAGS_xxx + * @param stream_type XC_STREAM_PLAIN if the far end of the stream + * doesn't use checkpointing + * @param recv_fd Only used for XC_STREAM_COLO. Contains backchannel from + * the destination side. + * @return 0 on success, -1 on failure + */ +int xc_domain_save(xc_interface *xch, int io_fd, uint32_t dom, + uint32_t flags, struct save_callbacks *callbacks, + xc_stream_type_t stream_type, int recv_fd); + +/* callbacks provided by xc_domain_restore */ +struct restore_callbacks { + /* + * Called once the STATIC_DATA_END record has been received/inferred. + * + * For compatibility with older streams, provides a list of static data + * expected to be found in the stream, which was missing. A higher level + * toolstack is responsible for providing any necessary compatibiltiy. + */ +#define XGR_SDD_MISSING_CPUID (1 << 0) +#define XGR_SDD_MISSING_MSR (1 << 1) + int (*static_data_done)(unsigned int missing, void *data); + + /* Called after a new checkpoint to suspend the guest. */ + int (*suspend)(void *data); + + /* + * Called after the secondary vm is ready to resume. + * Callback function resumes the guest & the device model, + * returns to xc_domain_restore. + */ + int (*postcopy)(void *data); + + /* + * A checkpoint record has been found in the stream. + * returns: + */ +#define XGR_CHECKPOINT_ERROR 0 /* Terminate processing */ +#define XGR_CHECKPOINT_SUCCESS 1 /* Continue reading more data from the stream */ +#define XGR_CHECKPOINT_FAILOVER 2 /* Failover and resume VM */ + int (*checkpoint)(void *data); + + /* + * Called after the checkpoint callback. + * + * returns: + * 0: terminate checkpointing gracefully + * 1: take another checkpoint + */ + int (*wait_checkpoint)(void *data); + + /* + * callback to send store gfn and console gfn to xl + * if we want to resume vm before xc_domain_save() + * exits. + */ + void (*restore_results)(xen_pfn_t store_gfn, xen_pfn_t console_gfn, + void *data); + + /* to be provided as the last argument to each callback function */ + void *data; +}; + +/** + * This function will restore a saved domain. + * + * Domain is restored in a suspended state ready to be unpaused. + * + * @param xch a handle to an open hypervisor interface + * @param io_fd the file descriptor to restore a domain from + * @param dom the id of the domain + * @param store_evtchn the xenstore event channel for this domain to use + * @param store_mfn filled with the gfn of the store page + * @param store_domid the backend domain for xenstore + * @param console_evtchn the console event channel for this domain to use + * @param console_mfn filled with the gfn of the console page + * @param console_domid the backend domain for xenconsole + * @param stream_type XC_STREAM_PLAIN if the far end of the stream is using + * checkpointing + * @param callbacks non-NULL to receive a callback to restore toolstack + * specific data + * @param send_back_fd Only used for XC_STREAM_COLO. Contains backchannel to + * the source side. + * @return 0 on success, -1 on failure + */ +int xc_domain_restore(xc_interface *xch, int io_fd, uint32_t dom, + unsigned int store_evtchn, unsigned long *store_mfn, + uint32_t store_domid, unsigned int console_evtchn, + unsigned long *console_mfn, uint32_t console_domid, + xc_stream_type_t stream_type, + struct restore_callbacks *callbacks, int send_back_fd); + +#endif /* XENSAVERESTORE_H */ diff --git a/tools/libs/Makefile b/tools/libs/Makefile index 1afcd12e2b..ca43c66777 100644 --- a/tools/libs/Makefile +++ b/tools/libs/Makefile @@ -12,6 +12,7 @@ SUBDIRS-y += devicemodel SUBDIRS-y += ctrl SUBDIRS-y += guest SUBDIRS-y += hypfs +SUBDIRS-y += saverestore SUBDIRS-y += store SUBDIRS-y += stat SUBDIRS-$(CONFIG_Linux) += vchan diff --git a/tools/libs/guest/Makefile b/tools/libs/guest/Makefile index 2ce92d247e..4cf5459bb1 100644 --- a/tools/libs/guest/Makefile +++ b/tools/libs/guest/Makefile @@ -11,18 +11,7 @@ SRCS-y += xg_domain.c SRCS-y += xg_suspend.c SRCS-y += xg_resume.c ifeq ($(CONFIG_MIGRATE),y) -SRCS-y += xg_sr_common.c -SRCS-$(CONFIG_X86) += xg_sr_common_x86.c -SRCS-$(CONFIG_X86) += xg_sr_common_x86_pv.c -SRCS-$(CONFIG_X86) += xg_sr_restore_x86_pv.c -SRCS-$(CONFIG_X86) += xg_sr_restore_x86_hvm.c -SRCS-$(CONFIG_X86) += xg_sr_save_x86_pv.c -SRCS-$(CONFIG_X86) += xg_sr_save_x86_hvm.c -SRCS-y += xg_sr_restore.c -SRCS-y += xg_sr_save.c SRCS-y += xg_offline_page.c -else -SRCS-y += xg_nomigrate.c endif SRCS-y += xg_core.c SRCS-$(CONFIG_X86) += xg_core_x86.c diff --git a/tools/libs/guest/xg_offline_page.c b/tools/libs/guest/xg_offline_page.c index cfe0e2d537..92b65243b1 100644 --- a/tools/libs/guest/xg_offline_page.c +++ b/tools/libs/guest/xg_offline_page.c @@ -29,7 +29,6 @@ #include "xc_private.h" #include "xg_private.h" -#include "xg_save_restore.h" struct pte_backup_entry { diff --git a/tools/libs/light/Makefile b/tools/libs/light/Makefile index 7d8c51d492..68e51dd13c 100644 --- a/tools/libs/light/Makefile +++ b/tools/libs/light/Makefile @@ -179,7 +179,7 @@ $(ACPI_OBJS) $(ACPI_PIC_OBJS): CFLAGS += -I. -DLIBACPI_STDUTILS=\"$(CURDIR)/libx $(TEST_PROG_OBJS) _libxl.api-for-check: CFLAGS += $(CFLAGS_libxentoollog) $(CFLAGS_libxentoolcore) libxl_dom.o libxl_dom.opic: CFLAGS += -I$(XEN_ROOT)/tools # include libacpi/x86.h libxl_x86_acpi.o libxl_x86_acpi.opic: CFLAGS += -I$(XEN_ROOT)/tools -$(SAVE_HELPER_OBJS): CFLAGS += $(CFLAGS_libxenctrl) $(CFLAGS_libxenevtchn) $(CFLAGS_libxenguest) +$(SAVE_HELPER_OBJS): CFLAGS += $(CFLAGS_libxenctrl) $(CFLAGS_libxenevtchn) $(CFLAGS_libxensaverestore) testidl.o: CFLAGS += $(CFLAGS_libxenctrl) $(CFLAGS_libxenlight) testidl.c: libxl_types.idl gentest.py $(XEN_INCLUDE)/libxl.h $(AUTOINCS) @@ -241,7 +241,7 @@ test_%: test_%.o test_common.o libxenlight_test.so $(CC) $(LDFLAGS) -o $@ $^ $(filter-out %libxenlight.so, $(LDLIBS_libxenlight)) $(LDLIBS_libxentoollog) $(LDLIBS_libxentoolcore) -lyajl $(APPEND_LDFLAGS) libxl-save-helper: $(SAVE_HELPER_OBJS) libxenlight.so - $(CC) $(LDFLAGS) -o $@ $(SAVE_HELPER_OBJS) $(LDLIBS_libxentoollog) $(LDLIBS_libxenctrl) $(LDLIBS_libxenguest) $(LDLIBS_libxentoolcore) $(APPEND_LDFLAGS) + $(CC) $(LDFLAGS) -o $@ $(SAVE_HELPER_OBJS) $(LDLIBS_libxentoollog) $(LDLIBS_libxenctrl) $(LDLIBS_libxensaverestore) $(LDLIBS_libxentoolcore) $(APPEND_LDFLAGS) testidl: testidl.o libxenlight.so $(CC) $(LDFLAGS) -o $@ testidl.o $(LDLIBS_libxenlight) $(LDLIBS_libxentoollog) $(LDLIBS_libxentoolcore) $(APPEND_LDFLAGS) diff --git a/tools/libs/light/libxl_internal.h b/tools/libs/light/libxl_internal.h index 0b4671318c..439c654733 100644 --- a/tools/libs/light/libxl_internal.h +++ b/tools/libs/light/libxl_internal.h @@ -56,6 +56,7 @@ #define XC_WANT_COMPAT_MAP_FOREIGN_API #include #include +#include #include #include diff --git a/tools/libs/light/libxl_save_helper.c b/tools/libs/light/libxl_save_helper.c index 65dff389bf..896e845a2f 100644 --- a/tools/libs/light/libxl_save_helper.c +++ b/tools/libs/light/libxl_save_helper.c @@ -48,6 +48,7 @@ #include "xenctrl.h" #include "xenguest.h" +#include "xensaverestore.h" #include "_libxl_save_msgs_helper.h" /*----- logger -----*/ diff --git a/tools/libs/light/libxl_save_msgs_gen.pl b/tools/libs/light/libxl_save_msgs_gen.pl index 9d425b1dee..f263ee01bb 100755 --- a/tools/libs/light/libxl_save_msgs_gen.pl +++ b/tools/libs/light/libxl_save_msgs_gen.pl @@ -72,7 +72,7 @@ END_BOTH END_CALLOUT #include -#include +#include #include "_libxl_save_msgs_${ah}.h" END_HELPER diff --git a/tools/libs/saverestore/Makefile b/tools/libs/saverestore/Makefile new file mode 100644 index 0000000000..48728b3be2 --- /dev/null +++ b/tools/libs/saverestore/Makefile @@ -0,0 +1,38 @@ +XEN_ROOT = $(CURDIR)/../../.. +include $(XEN_ROOT)/tools/Rules.mk + +ifeq ($(CONFIG_MIGRATE),y) +SRCS-y += common.c +SRCS-$(CONFIG_X86) += common_x86.c +SRCS-$(CONFIG_X86) += common_x86_pv.c +SRCS-$(CONFIG_X86) += restore_x86_pv.c +SRCS-$(CONFIG_X86) += restore_x86_hvm.c +SRCS-$(CONFIG_X86) += save_x86_pv.c +SRCS-$(CONFIG_X86) += save_x86_hvm.c +SRCS-y += restore.c +SRCS-y += save.c +else +SRCS-y += nomigrate.c +endif + +CFLAGS += -I$(XEN_libxenctrl) +CFLAGS += -I$(XEN_libxenguest) + +-include $(XEN_TARGET_ARCH)/Makefile + +CFLAGS += -Werror -Wmissing-prototypes +CFLAGS += -I. -I./include $(CFLAGS_xeninclude) +CFLAGS += -D__XEN_TOOLS__ +CFLAGS += -include $(XEN_ROOT)/tools/config.h +# Needed for asprintf() +CFLAGS-$(CONFIG_Linux) += -D_GNU_SOURCE + +LIBHEADER := xensaverestore.h + +NO_HEADERS_CHK := y + +include $(XEN_ROOT)/tools/libs/libs.mk + +.PHONY: cleanlocal +cleanlocal: + rm -f libxensaverestore.map diff --git a/tools/libs/guest/xg_sr_common.c b/tools/libs/saverestore/common.c similarity index 99% rename from tools/libs/guest/xg_sr_common.c rename to tools/libs/saverestore/common.c index 17567ab133..77128bc747 100644 --- a/tools/libs/guest/xg_sr_common.c +++ b/tools/libs/saverestore/common.c @@ -1,6 +1,6 @@ #include -#include "xg_sr_common.h" +#include "common.h" #include diff --git a/tools/libs/guest/xg_sr_common.h b/tools/libs/saverestore/common.h similarity index 98% rename from tools/libs/guest/xg_sr_common.h rename to tools/libs/saverestore/common.h index e2994e18ac..ca2eb47a4f 100644 --- a/tools/libs/guest/xg_sr_common.h +++ b/tools/libs/saverestore/common.h @@ -1,13 +1,25 @@ #ifndef __COMMON__H #define __COMMON__H +#include +#include #include +#include +#include +#include +#include +#include +#include + +#include "xc_private.h" +#include "xenguest.h" +#include "xensaverestore.h" #include "xg_private.h" -#include "xg_save_restore.h" +#include "save_restore.h" #include "xc_bitops.h" -#include "xg_sr_stream_format.h" +#include "stream_format.h" /* String representation of Domain Header types. */ const char *dhdr_type_to_str(uint32_t type); diff --git a/tools/libs/guest/xg_sr_common_x86.c b/tools/libs/saverestore/common_x86.c similarity index 99% rename from tools/libs/guest/xg_sr_common_x86.c rename to tools/libs/saverestore/common_x86.c index 563b4f0168..f1beb234ae 100644 --- a/tools/libs/guest/xg_sr_common_x86.c +++ b/tools/libs/saverestore/common_x86.c @@ -1,4 +1,4 @@ -#include "xg_sr_common_x86.h" +#include "common_x86.h" int write_x86_tsc_info(struct xc_sr_context *ctx) { diff --git a/tools/libs/guest/xg_sr_common_x86.h b/tools/libs/saverestore/common_x86.h similarity index 98% rename from tools/libs/guest/xg_sr_common_x86.h rename to tools/libs/saverestore/common_x86.h index b55758c96d..3a2d91dcb8 100644 --- a/tools/libs/guest/xg_sr_common_x86.h +++ b/tools/libs/saverestore/common_x86.h @@ -1,7 +1,7 @@ #ifndef __COMMON_X86__H #define __COMMON_X86__H -#include "xg_sr_common.h" +#include "common.h" /* * Obtains a domains TSC information from Xen and writes a X86_TSC_INFO record diff --git a/tools/libs/guest/xg_sr_common_x86_pv.c b/tools/libs/saverestore/common_x86_pv.c similarity index 99% rename from tools/libs/guest/xg_sr_common_x86_pv.c rename to tools/libs/saverestore/common_x86_pv.c index c0acf00f90..cfe1b24bed 100644 --- a/tools/libs/guest/xg_sr_common_x86_pv.c +++ b/tools/libs/saverestore/common_x86_pv.c @@ -1,6 +1,6 @@ #include -#include "xg_sr_common_x86_pv.h" +#include "common_x86_pv.h" xen_pfn_t mfn_to_pfn(struct xc_sr_context *ctx, xen_pfn_t mfn) { diff --git a/tools/libs/guest/xg_sr_common_x86_pv.h b/tools/libs/saverestore/common_x86_pv.h similarity index 98% rename from tools/libs/guest/xg_sr_common_x86_pv.h rename to tools/libs/saverestore/common_x86_pv.h index 953b5bfb8d..a9f8c970e3 100644 --- a/tools/libs/guest/xg_sr_common_x86_pv.h +++ b/tools/libs/saverestore/common_x86_pv.h @@ -1,7 +1,7 @@ #ifndef __COMMON_X86_PV_H #define __COMMON_X86_PV_H -#include "xg_sr_common_x86.h" +#include "common_x86.h" /* Virtual address ranges reserved for hypervisor. */ #define HYPERVISOR_VIRT_START_X86_64 0xFFFF800000000000ULL diff --git a/tools/libs/guest/xg_nomigrate.c b/tools/libs/saverestore/nomigrate.c similarity index 98% rename from tools/libs/guest/xg_nomigrate.c rename to tools/libs/saverestore/nomigrate.c index 6795c62ddc..67e58d353a 100644 --- a/tools/libs/guest/xg_nomigrate.c +++ b/tools/libs/saverestore/nomigrate.c @@ -18,7 +18,7 @@ #include #include #include -#include +#include int xc_domain_save(xc_interface *xch, int io_fd, uint32_t dom, uint32_t flags, struct save_callbacks *callbacks, diff --git a/tools/libs/guest/xg_sr_restore.c b/tools/libs/saverestore/restore.c similarity index 99% rename from tools/libs/guest/xg_sr_restore.c rename to tools/libs/saverestore/restore.c index b57a787519..be259a1c6b 100644 --- a/tools/libs/guest/xg_sr_restore.c +++ b/tools/libs/saverestore/restore.c @@ -2,7 +2,7 @@ #include -#include "xg_sr_common.h" +#include "common.h" /* * Read and validate the Image and Domain headers. diff --git a/tools/libs/guest/xg_sr_restore_x86_hvm.c b/tools/libs/saverestore/restore_x86_hvm.c similarity index 99% rename from tools/libs/guest/xg_sr_restore_x86_hvm.c rename to tools/libs/saverestore/restore_x86_hvm.c index d6ea6f3012..bd63bd2818 100644 --- a/tools/libs/guest/xg_sr_restore_x86_hvm.c +++ b/tools/libs/saverestore/restore_x86_hvm.c @@ -1,7 +1,7 @@ #include #include -#include "xg_sr_common_x86.h" +#include "common_x86.h" /* * Process an HVM_CONTEXT record from the stream. diff --git a/tools/libs/guest/xg_sr_restore_x86_pv.c b/tools/libs/saverestore/restore_x86_pv.c similarity index 99% rename from tools/libs/guest/xg_sr_restore_x86_pv.c rename to tools/libs/saverestore/restore_x86_pv.c index dc50b0f5a8..96608e5231 100644 --- a/tools/libs/guest/xg_sr_restore_x86_pv.c +++ b/tools/libs/saverestore/restore_x86_pv.c @@ -1,6 +1,6 @@ #include -#include "xg_sr_common_x86_pv.h" +#include "common_x86_pv.h" static xen_pfn_t pfn_to_mfn(const struct xc_sr_context *ctx, xen_pfn_t pfn) { diff --git a/tools/libs/guest/xg_sr_save.c b/tools/libs/saverestore/save.c similarity index 99% rename from tools/libs/guest/xg_sr_save.c rename to tools/libs/saverestore/save.c index 2ba7c3200c..ae3e8797d0 100644 --- a/tools/libs/guest/xg_sr_save.c +++ b/tools/libs/saverestore/save.c @@ -1,7 +1,7 @@ #include #include -#include "xg_sr_common.h" +#include "common.h" /* * Writes an Image header and Domain header into the stream. diff --git a/tools/libs/guest/xg_save_restore.h b/tools/libs/saverestore/save_restore.h similarity index 98% rename from tools/libs/guest/xg_save_restore.h rename to tools/libs/saverestore/save_restore.h index 3dbbc8dcd2..20bd3d30a5 100644 --- a/tools/libs/guest/xg_save_restore.h +++ b/tools/libs/saverestore/save_restore.h @@ -15,8 +15,6 @@ * License along with this library; If not, see . */ -#include "xc_private.h" - #include #include diff --git a/tools/libs/guest/xg_sr_save_x86_hvm.c b/tools/libs/saverestore/save_x86_hvm.c similarity index 99% rename from tools/libs/guest/xg_sr_save_x86_hvm.c rename to tools/libs/saverestore/save_x86_hvm.c index 1634a7bc43..91c2cb99ab 100644 --- a/tools/libs/guest/xg_sr_save_x86_hvm.c +++ b/tools/libs/saverestore/save_x86_hvm.c @@ -1,6 +1,6 @@ #include -#include "xg_sr_common_x86.h" +#include "common_x86.h" #include diff --git a/tools/libs/guest/xg_sr_save_x86_pv.c b/tools/libs/saverestore/save_x86_pv.c similarity index 99% rename from tools/libs/guest/xg_sr_save_x86_pv.c rename to tools/libs/saverestore/save_x86_pv.c index 4964f1f7b8..92f77fad0f 100644 --- a/tools/libs/guest/xg_sr_save_x86_pv.c +++ b/tools/libs/saverestore/save_x86_pv.c @@ -1,7 +1,7 @@ #include #include -#include "xg_sr_common_x86_pv.h" +#include "common_x86_pv.h" /* Check a 64 bit virtual address for being canonical. */ static inline bool is_canonical_address(xen_vaddr_t vaddr) diff --git a/tools/libs/guest/xg_sr_stream_format.h b/tools/libs/saverestore/stream_format.h similarity index 100% rename from tools/libs/guest/xg_sr_stream_format.h rename to tools/libs/saverestore/stream_format.h diff --git a/tools/libs/uselibs.mk b/tools/libs/uselibs.mk index efd7a475ba..62a2990b95 100644 --- a/tools/libs/uselibs.mk +++ b/tools/libs/uselibs.mk @@ -20,6 +20,8 @@ LIBS_LIBS += ctrl USELIBS_ctrl := toollog call evtchn gnttab foreignmemory devicemodel LIBS_LIBS += guest USELIBS_guest := evtchn ctrl +LIBS_LIBS += saverestore +USELIBS_saverestore := guest ctrl LIBS_LIBS += store USELIBS_store := toolcore LIBS_LIBS += vchan @@ -27,7 +29,7 @@ USELIBS_vchan := toollog store gnttab evtchn LIBS_LIBS += stat USELIBS_stat := ctrl store LIBS_LIBS += light -USELIBS_light := toollog evtchn toolcore ctrl store hypfs guest +USELIBS_light := toollog evtchn toolcore ctrl store hypfs guest saverestore LIBS_LIBS += util USELIBS_util := light FILENAME_util := xlutil From xen-devel-bounces@lists.xenproject.org Thu Jul 01 10:02:19 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 10:02:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148469.274496 (Exim 4.92) (envelope-from ) id 1lytWU-0005wF-R4; Thu, 01 Jul 2021 10:02:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148469.274496; Thu, 01 Jul 2021 10:02:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lytWU-0005vl-Jx; Thu, 01 Jul 2021 10:02:18 +0000 Received: by outflank-mailman (input) for mailman id 148469; Thu, 01 Jul 2021 10:02:17 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lytRv-0004XT-Sy for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 09:57:35 +0000 Received: from mo4-p02-ob.smtp.rzone.de (unknown [85.215.255.82]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id a76f642b-8ab8-4845-afd7-b6e202d99543; Thu, 01 Jul 2021 09:56:52 +0000 (UTC) Received: from sender by smtp.strato.de (RZmta 47.28.1 AUTH) with ESMTPSA id 30791cx619uk5N3 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Thu, 1 Jul 2021 11:56:46 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a76f642b-8ab8-4845-afd7-b6e202d99543 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1625133406; s=strato-dkim-0002; d=aepfle.de; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Cc:Date: From:Subject:Sender; bh=KnwsPxLRJB68rPXEArkMW6OSaI/spxXLS3HmgXIKcHw=; b=F9jVJ1N144s3xumrT8kJVbYSY9MfWREIAi4QGQ0tQpX+AHdjKtnEIBCUSYTo8GG9jL RJBHhn5HrnUp5abb3C6hYg4cv2g9tPC6W9JJjWlxGAayaRpmA0+UOC5OvsuTVgjoE+Qg 3UqSMgQq5+gXYGmDjTPoRAf46TSFqrMYWtivGdddA4StQEO5e1HUqD5nSzVE2EvZ79Mx MsiulUUErQpT+YKwx/1BCRmrl9FynwGYNWkxSard0VRpDefefTQMy7e7mNSwOKIJYs70 qQsuXmTYeeN8b0om/Z9fgO7CFd+QHOVUBo47dj4q7AfhkP+Juw8Ci7u5+yiAZpeNjj82 aUuA== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QXkBR9MXjAuzpIG0mv9coXAg5lqlz7EsstGyDcxK3Mbajr+SQKopp1Cb0CyyaZQQ==" X-RZG-CLASS-ID: mo00 From: Olaf Hering To: xen-devel@lists.xenproject.org Cc: Olaf Hering , Juergen Gross , Ian Jackson , Wei Liu Subject: [PATCH v20210701 16/40] tools: save: move mfns array Date: Thu, 1 Jul 2021 11:56:11 +0200 Message-Id: <20210701095635.15648-17-olaf@aepfle.de> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210701095635.15648-1-olaf@aepfle.de> References: <20210701095635.15648-1-olaf@aepfle.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Remove allocation from hotpath, move mfns array into preallocated space. Signed-off-by: Olaf Hering Reviewed-by: Juergen Gross --- tools/libs/saverestore/common.h | 2 ++ tools/libs/saverestore/save.c | 7 ++----- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/tools/libs/saverestore/common.h b/tools/libs/saverestore/common.h index 968bb8af13..1415a182d2 100644 --- a/tools/libs/saverestore/common.h +++ b/tools/libs/saverestore/common.h @@ -225,6 +225,8 @@ static inline int update_blob(struct xc_sr_blob *blob, struct sr_save_arrays { xen_pfn_t batch_pfns[MAX_BATCH_SIZE]; + /* write_batch: Mfns of the batch pfns. */ + xen_pfn_t mfns[MAX_BATCH_SIZE]; }; struct sr_restore_arrays { diff --git a/tools/libs/saverestore/save.c b/tools/libs/saverestore/save.c index e29b6e1d66..6b09784be8 100644 --- a/tools/libs/saverestore/save.c +++ b/tools/libs/saverestore/save.c @@ -88,7 +88,7 @@ static int write_checkpoint_record(struct xc_sr_context *ctx) static int write_batch(struct xc_sr_context *ctx) { xc_interface *xch = ctx->xch; - xen_pfn_t *mfns = NULL, *types = NULL; + xen_pfn_t *mfns = ctx->save.m->mfns, *types = NULL; void *guest_mapping = NULL; void **guest_data = NULL; void **local_pages = NULL; @@ -105,8 +105,6 @@ static int write_batch(struct xc_sr_context *ctx) assert(nr_pfns != 0); - /* Mfns of the batch pfns. */ - mfns = malloc(nr_pfns * sizeof(*mfns)); /* Types of the batch pfns. */ types = malloc(nr_pfns * sizeof(*types)); /* Errors from attempting to map the gfns. */ @@ -118,7 +116,7 @@ static int write_batch(struct xc_sr_context *ctx) /* iovec[] for writev(). */ iov = malloc((nr_pfns + 4) * sizeof(*iov)); - if ( !mfns || !types || !errors || !guest_data || !local_pages || !iov ) + if ( !types || !errors || !guest_data || !local_pages || !iov ) { ERROR("Unable to allocate arrays for a batch of %u pages", nr_pfns); @@ -277,7 +275,6 @@ static int write_batch(struct xc_sr_context *ctx) free(guest_data); free(errors); free(types); - free(mfns); return rc; } From xen-devel-bounces@lists.xenproject.org Thu Jul 01 10:02:19 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 10:02:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148470.274500 (Exim 4.92) (envelope-from ) id 1lytWV-00060W-Af; Thu, 01 Jul 2021 10:02:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148470.274500; Thu, 01 Jul 2021 10:02:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lytWV-0005zS-3L; Thu, 01 Jul 2021 10:02:19 +0000 Received: by outflank-mailman (input) for mailman id 148470; Thu, 01 Jul 2021 10:02:17 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lytSt-0004XT-Ur for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 09:58:35 +0000 Received: from mo4-p03-ob.smtp.rzone.de (unknown [85.215.255.104]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 54087ce2-f123-4ec4-8ca2-5a6be09f5c48; Thu, 01 Jul 2021 09:56:59 +0000 (UTC) Received: from sender by smtp.strato.de (RZmta 47.28.1 AUTH) with ESMTPSA id 30791cx619uq5NO (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Thu, 1 Jul 2021 11:56:52 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 54087ce2-f123-4ec4-8ca2-5a6be09f5c48 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1625133412; s=strato-dkim-0002; d=aepfle.de; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Cc:Date: From:Subject:Sender; bh=VqP0dtxOpIShGdDn4ROCdSzLaQrNr0I+/+0oMjV5WeY=; b=UFGSIIpkg+JgbdLPDmn3OdvsTFfseQqaPhGrvOXbhe/uB5U7dX2bRe6fm82aOAzv6C X0d6/imN+D3oOuuKMXBdKeWkEpIcXH2zsRr0iuK/+RPwVorJRHLCQn/NCfNfwFkmKjIq m//sv8oBnG17YgVmeqv0zoWAipjIk3umKhJF/9feD4DNSmS1UC4n96jFN5hTrC7B7cZj ygPYoz9+fmXWicc9OmC4Bx/uM3xqKXgKPg3C8/5+QFto54nGXpoVs9pA1URADAM2sk9A IbOlPFO0CkBI1lNXrttEXpVjcbBVapWpol4rMcBUOUQwyKpjDxfS1+bq55V9iDPo1DCM M/fQ== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QXkBR9MXjAuzpIG0mv9coXAg5lqlz7EsstGyDcxK3Mbajr+SQKopp1Cb0CyyaZQQ==" X-RZG-CLASS-ID: mo00 From: Olaf Hering To: xen-devel@lists.xenproject.org Cc: Olaf Hering , Juergen Gross , Ian Jackson , Wei Liu Subject: [PATCH v20210701 28/40] tools: restore: split record processing Date: Thu, 1 Jul 2021 11:56:23 +0200 Message-Id: <20210701095635.15648-29-olaf@aepfle.de> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210701095635.15648-1-olaf@aepfle.de> References: <20210701095635.15648-1-olaf@aepfle.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit handle_page_data must be able to read directly into mapped guest memory. This will avoid unneccesary memcpy calls for data which can be consumed verbatim. Rearrange the code to allow decisions based on the incoming record. This change is preparation for future changes in handle_page_data, no change in behavior is intended. Signed-off-by: Olaf Hering Reviewed-by: Juergen Gross --- tools/libs/saverestore/common.c | 33 ++++++++++++--------- tools/libs/saverestore/common.h | 4 ++- tools/libs/saverestore/restore.c | 49 ++++++++++++++++++++++---------- tools/libs/saverestore/save.c | 7 ++++- 4 files changed, 63 insertions(+), 30 deletions(-) diff --git a/tools/libs/saverestore/common.c b/tools/libs/saverestore/common.c index 77128bc747..7da7fa4e2c 100644 --- a/tools/libs/saverestore/common.c +++ b/tools/libs/saverestore/common.c @@ -91,26 +91,33 @@ int write_split_record(struct xc_sr_context *ctx, struct xc_sr_record *rec, return -1; } -int read_record(struct xc_sr_context *ctx, int fd, struct xc_sr_record *rec) +int read_record_header(struct xc_sr_context *ctx, int fd, struct xc_sr_rhdr *rhdr) { xc_interface *xch = ctx->xch; - struct xc_sr_rhdr rhdr; - size_t datasz; - if ( read_exact(fd, &rhdr, sizeof(rhdr)) ) + if ( read_exact(fd, rhdr, sizeof(*rhdr)) ) { PERROR("Failed to read Record Header from stream"); return -1; } - if ( rhdr.length > REC_LENGTH_MAX ) + if ( rhdr->length > REC_LENGTH_MAX ) { - ERROR("Record (0x%08x, %s) length %#x exceeds max (%#x)", rhdr.type, - rec_type_to_str(rhdr.type), rhdr.length, REC_LENGTH_MAX); + ERROR("Record (0x%08x, %s) length %#x exceeds max (%#x)", rhdr->type, + rec_type_to_str(rhdr->type), rhdr->length, REC_LENGTH_MAX); return -1; } - datasz = ROUNDUP(rhdr.length, REC_ALIGN_ORDER); + return 0; +} + +int read_record_data(struct xc_sr_context *ctx, int fd, struct xc_sr_rhdr *rhdr, + struct xc_sr_record *rec) +{ + xc_interface *xch = ctx->xch; + size_t datasz; + + datasz = ROUNDUP(rhdr->length, REC_ALIGN_ORDER); if ( datasz ) { @@ -119,7 +126,7 @@ int read_record(struct xc_sr_context *ctx, int fd, struct xc_sr_record *rec) if ( !rec->data ) { ERROR("Unable to allocate %zu bytes for record data (0x%08x, %s)", - datasz, rhdr.type, rec_type_to_str(rhdr.type)); + datasz, rhdr->type, rec_type_to_str(rhdr->type)); return -1; } @@ -128,18 +135,18 @@ int read_record(struct xc_sr_context *ctx, int fd, struct xc_sr_record *rec) free(rec->data); rec->data = NULL; PERROR("Failed to read %zu bytes of data for record (0x%08x, %s)", - datasz, rhdr.type, rec_type_to_str(rhdr.type)); + datasz, rhdr->type, rec_type_to_str(rhdr->type)); return -1; } } else rec->data = NULL; - rec->type = rhdr.type; - rec->length = rhdr.length; + rec->type = rhdr->type; + rec->length = rhdr->length; return 0; -}; +} static void __attribute__((unused)) build_assertions(void) { diff --git a/tools/libs/saverestore/common.h b/tools/libs/saverestore/common.h index c319148f8f..580eafacc8 100644 --- a/tools/libs/saverestore/common.h +++ b/tools/libs/saverestore/common.h @@ -487,7 +487,9 @@ static inline int write_record(struct xc_sr_context *ctx, * * On failure, the contents of the record structure are undefined. */ -int read_record(struct xc_sr_context *ctx, int fd, struct xc_sr_record *rec); +int read_record_header(struct xc_sr_context *ctx, int fd, struct xc_sr_rhdr *rhdr); +int read_record_data(struct xc_sr_context *ctx, int fd, struct xc_sr_rhdr *rhdr, + struct xc_sr_record *rec); /* * This would ideally be private in restore.c, but is needed by diff --git a/tools/libs/saverestore/restore.c b/tools/libs/saverestore/restore.c index 2a6ccce847..e75380155d 100644 --- a/tools/libs/saverestore/restore.c +++ b/tools/libs/saverestore/restore.c @@ -471,7 +471,7 @@ static int send_checkpoint_dirty_pfn_list(struct xc_sr_context *ctx) return rc; } -static int process_record(struct xc_sr_context *ctx, struct xc_sr_record *rec); +static int process_buffered_record(struct xc_sr_context *ctx, struct xc_sr_record *rec); static int handle_checkpoint(struct xc_sr_context *ctx) { xc_interface *xch = ctx->xch; @@ -510,7 +510,7 @@ static int handle_checkpoint(struct xc_sr_context *ctx) for ( i = 0; i < ctx->restore.buffered_rec_num; i++ ) { - rc = process_record(ctx, &ctx->restore.buffered_records[i]); + rc = process_buffered_record(ctx, &ctx->restore.buffered_records[i]); if ( rc ) goto err; } @@ -571,10 +571,11 @@ static int handle_checkpoint(struct xc_sr_context *ctx) return rc; } -static int buffer_record(struct xc_sr_context *ctx, struct xc_sr_record *rec) +static int buffer_record(struct xc_sr_context *ctx, struct xc_sr_rhdr *rhdr) { xc_interface *xch = ctx->xch; unsigned int new_alloc_num; + struct xc_sr_record rec; struct xc_sr_record *p; if ( ctx->restore.buffered_rec_num >= ctx->restore.allocated_rec_num ) @@ -592,8 +593,13 @@ static int buffer_record(struct xc_sr_context *ctx, struct xc_sr_record *rec) ctx->restore.allocated_rec_num = new_alloc_num; } + if ( read_record_data(ctx, ctx->fd, rhdr, &rec) ) + { + return -1; + } + memcpy(&ctx->restore.buffered_records[ctx->restore.buffered_rec_num++], - rec, sizeof(*rec)); + &rec, sizeof(rec)); return 0; } @@ -624,7 +630,7 @@ int handle_static_data_end(struct xc_sr_context *ctx) return rc; } -static int process_record(struct xc_sr_context *ctx, struct xc_sr_record *rec) +static int process_buffered_record(struct xc_sr_context *ctx, struct xc_sr_record *rec) { xc_interface *xch = ctx->xch; int rc = 0; @@ -662,6 +668,19 @@ static int process_record(struct xc_sr_context *ctx, struct xc_sr_record *rec) return rc; } +static int process_incoming_record_header(struct xc_sr_context *ctx, struct xc_sr_rhdr *rhdr) +{ + struct xc_sr_record rec; + int rc; + + rc = read_record_data(ctx, ctx->fd, rhdr, &rec); + if ( rc ) + return rc; + + return process_buffered_record(ctx, &rec); +} + + static int setup(struct xc_sr_context *ctx) { xc_interface *xch = ctx->xch; @@ -745,7 +764,7 @@ static void cleanup(struct xc_sr_context *ctx) static int restore(struct xc_sr_context *ctx) { xc_interface *xch = ctx->xch; - struct xc_sr_record rec; + struct xc_sr_rhdr rhdr; int rc, saved_rc = 0, saved_errno = 0; IPRINTF("Restoring domain"); @@ -756,7 +775,7 @@ static int restore(struct xc_sr_context *ctx) do { - rc = read_record(ctx, ctx->fd, &rec); + rc = read_record_header(ctx, ctx->fd, &rhdr); if ( rc ) { if ( ctx->restore.buffer_all_records ) @@ -766,25 +785,25 @@ static int restore(struct xc_sr_context *ctx) } if ( ctx->restore.buffer_all_records && - rec.type != REC_TYPE_END && - rec.type != REC_TYPE_CHECKPOINT ) + rhdr.type != REC_TYPE_END && + rhdr.type != REC_TYPE_CHECKPOINT ) { - rc = buffer_record(ctx, &rec); + rc = buffer_record(ctx, &rhdr); if ( rc ) goto err; } else { - rc = process_record(ctx, &rec); + rc = process_incoming_record_header(ctx, &rhdr); if ( rc == RECORD_NOT_PROCESSED ) { - if ( rec.type & REC_TYPE_OPTIONAL ) + if ( rhdr.type & REC_TYPE_OPTIONAL ) DPRINTF("Ignoring optional record %#x (%s)", - rec.type, rec_type_to_str(rec.type)); + rhdr.type, rec_type_to_str(rhdr.type)); else { ERROR("Mandatory record %#x (%s) not handled", - rec.type, rec_type_to_str(rec.type)); + rhdr.type, rec_type_to_str(rhdr.type)); rc = -1; goto err; } @@ -795,7 +814,7 @@ static int restore(struct xc_sr_context *ctx) goto err; } - } while ( rec.type != REC_TYPE_END ); + } while ( rhdr.type != REC_TYPE_END ); remus_failover: if ( ctx->stream_type == XC_STREAM_COLO ) diff --git a/tools/libs/saverestore/save.c b/tools/libs/saverestore/save.c index fa83648f9a..e486bce96f 100644 --- a/tools/libs/saverestore/save.c +++ b/tools/libs/saverestore/save.c @@ -589,6 +589,7 @@ static int send_memory_live(struct xc_sr_context *ctx) static int colo_merge_secondary_dirty_bitmap(struct xc_sr_context *ctx) { xc_interface *xch = ctx->xch; + struct xc_sr_rhdr rhdr; struct xc_sr_record rec; uint64_t *pfns = NULL; uint64_t pfn; @@ -597,7 +598,11 @@ static int colo_merge_secondary_dirty_bitmap(struct xc_sr_context *ctx) DECLARE_HYPERCALL_BUFFER_SHADOW(unsigned long, dirty_bitmap, &ctx->save.dirty_bitmap_hbuf); - rc = read_record(ctx, ctx->save.recv_fd, &rec); + rc = read_record_header(ctx, ctx->save.recv_fd, &rhdr); + if ( rc ) + goto err; + + rc = read_record_data(ctx, ctx->save.recv_fd, &rhdr, &rec); if ( rc ) goto err; From xen-devel-bounces@lists.xenproject.org Thu Jul 01 10:02:32 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 10:02:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148490.274518 (Exim 4.92) (envelope-from ) id 1lytWh-0007lU-TK; Thu, 01 Jul 2021 10:02:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148490.274518; Thu, 01 Jul 2021 10:02:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lytWh-0007lJ-MX; Thu, 01 Jul 2021 10:02:31 +0000 Received: by outflank-mailman (input) for mailman id 148490; Thu, 01 Jul 2021 10:02:30 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lytSU-0004XT-Tu for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 09:58:10 +0000 Received: from mo4-p03-ob.smtp.rzone.de (unknown [85.215.255.104]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 7ba2abb8-8840-41fd-a5d0-ee4432074b69; Thu, 01 Jul 2021 09:56:56 +0000 (UTC) Received: from sender by smtp.strato.de (RZmta 47.28.1 AUTH) with ESMTPSA id 30791cx619un5NF (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Thu, 1 Jul 2021 11:56:49 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7ba2abb8-8840-41fd-a5d0-ee4432074b69 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1625133410; s=strato-dkim-0002; d=aepfle.de; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Cc:Date: From:Subject:Sender; bh=SEmlTCun49Bu0J5Hduo4Ou5xOCzHrO1gLgKtshkEibk=; b=leNKNgImZhFpMAUfRvKFT4UTuw7NNJ/AvWciHuO8ximTBy06TMcEBStzALzWRO3rBe H+ej4+CDkSuH0BtA0Sfuxbw1jSA2WpfBjAI+EgLyb/5ECI9CO3bPmHq5vXC3iGBjpihu Sn994HSbXw2wHckqAlMC5FzL2gMQv7wAaOY1B9I3GHZB8kFAV980UQu30b2xaCPlWHue UYLT52fitrn8J6w7JbF1QpSy03aY1an/h9nveX+G+mL04/Y9I9Skq+c5z5+c3fDLhuVR 55Me5xHBvzm6+2jnIMSDcai8W1SaEc1vRc6+RZfdSWShl7Z3sgHxhHWYwKVIZfvgXYta wsyA== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QXkBR9MXjAuzpIG0mv9coXAg5lqlz7EsstGyDcxK3Mbajr+SQKopp1Cb0CyyaZQQ==" X-RZG-CLASS-ID: mo00 From: Olaf Hering To: xen-devel@lists.xenproject.org Cc: Olaf Hering , Juergen Gross , Ian Jackson , Wei Liu Subject: [PATCH v20210701 23/40] tools: restore: move types array Date: Thu, 1 Jul 2021 11:56:18 +0200 Message-Id: <20210701095635.15648-24-olaf@aepfle.de> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210701095635.15648-1-olaf@aepfle.de> References: <20210701095635.15648-1-olaf@aepfle.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Remove allocation from hotpath, move types array into preallocated space. Signed-off-by: Olaf Hering Reviewed-by: Juergen Gross --- tools/libs/saverestore/common.h | 1 + tools/libs/saverestore/restore.c | 12 +----------- 2 files changed, 2 insertions(+), 11 deletions(-) diff --git a/tools/libs/saverestore/common.h b/tools/libs/saverestore/common.h index 8089449011..d798b79745 100644 --- a/tools/libs/saverestore/common.h +++ b/tools/libs/saverestore/common.h @@ -238,6 +238,7 @@ struct sr_save_arrays { struct sr_restore_arrays { /* handle_page_data */ xen_pfn_t pfns[MAX_BATCH_SIZE]; + uint32_t types[MAX_BATCH_SIZE]; }; struct xc_sr_context diff --git a/tools/libs/saverestore/restore.c b/tools/libs/saverestore/restore.c index c203ce503d..8ea125cf73 100644 --- a/tools/libs/saverestore/restore.c +++ b/tools/libs/saverestore/restore.c @@ -316,7 +316,7 @@ static int handle_page_data(struct xc_sr_context *ctx, struct xc_sr_record *rec) int rc = -1; xen_pfn_t *pfns = ctx->restore.m->pfns, pfn; - uint32_t *types = NULL, type; + uint32_t *types = ctx->restore.m->types, type; /* * v2 compatibility only exists for x86 streams. This is a bit of a @@ -363,14 +363,6 @@ static int handle_page_data(struct xc_sr_context *ctx, struct xc_sr_record *rec) goto err; } - types = malloc(pages->count * sizeof(*types)); - if ( !types ) - { - ERROR("Unable to allocate enough memory for %u pfns", - pages->count); - goto err; - } - for ( i = 0; i < pages->count; ++i ) { pfn = pages->pfn[i] & PAGE_DATA_PFN_MASK; @@ -410,8 +402,6 @@ static int handle_page_data(struct xc_sr_context *ctx, struct xc_sr_record *rec) rc = process_page_data(ctx, pages->count, pfns, types, &pages->pfn[pages->count]); err: - free(types); - return rc; } From xen-devel-bounces@lists.xenproject.org Thu Jul 01 10:02:32 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 10:02:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148491.274524 (Exim 4.92) (envelope-from ) id 1lytWi-0007sH-E3; Thu, 01 Jul 2021 10:02:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148491.274524; Thu, 01 Jul 2021 10:02:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lytWi-0007qw-5p; Thu, 01 Jul 2021 10:02:32 +0000 Received: by outflank-mailman (input) for mailman id 148491; Thu, 01 Jul 2021 10:02:30 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lytSj-0004XT-UH for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 09:58:25 +0000 Received: from mo4-p03-ob.smtp.rzone.de (unknown [81.169.146.172]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 2bf55f4c-8ccb-4310-b27b-a0a9200a22e3; Thu, 01 Jul 2021 09:56:57 +0000 (UTC) Received: from sender by smtp.strato.de (RZmta 47.28.1 AUTH) with ESMTPSA id 30791cx619up5NN (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Thu, 1 Jul 2021 11:56:51 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2bf55f4c-8ccb-4310-b27b-a0a9200a22e3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1625133411; s=strato-dkim-0002; d=aepfle.de; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Cc:Date: From:Subject:Sender; bh=NzRIOkyxxUnksLPgAOMJtNoYSt71bd12f8S/qdAp4ys=; b=E3E63ORgeCjrZTaxjNFk+nyNw7JY0SiH/yHCVGqWhuC+TMeeeO3l/fAfSOgtVCoqjk GQ0o3YUjOVWcNJOMoO/SLpZLuQuE7110MjTbSJ8jSo9wfgkfQvE1z6FBr4+fZT+TK3Wx RNhXmirclaWDaJSgkxd6i/XqP7taUsITGTpjfgqjHXsbD7UxsCLi0o2MkJqQtmiS3pQY GkTWSjv1rNqGPCt1J7CZqv35cj7LRlB8qlC6uBqMkD9Pj1SMoVvEu2GxXwGjj26xvl8O tweDh0TQpuEb86rHI8sma/iiu6EhE03FQLd4yZQLNMr3j079ckgF1POvpg7OjQaU+k7d 2qvg== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QXkBR9MXjAuzpIG0mv9coXAg5lqlz7EsstGyDcxK3Mbajr+SQKopp1Cb0CyyaZQQ==" X-RZG-CLASS-ID: mo00 From: Olaf Hering To: xen-devel@lists.xenproject.org Cc: Olaf Hering , Juergen Gross , Ian Jackson , Wei Liu Subject: [PATCH v20210701 27/40] tools: restore: move pfns array in populate_pfns Date: Thu, 1 Jul 2021 11:56:22 +0200 Message-Id: <20210701095635.15648-28-olaf@aepfle.de> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210701095635.15648-1-olaf@aepfle.de> References: <20210701095635.15648-1-olaf@aepfle.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Remove allocation from hotpath, move populate_pfns' pfns array into preallocated space. Use some prefix to avoid conflict with an array used in handle_page_data. Signed-off-by: Olaf Hering Reviewed-by: Juergen Gross --- tools/libs/saverestore/common.h | 1 + tools/libs/saverestore/restore.c | 11 +---------- 2 files changed, 2 insertions(+), 10 deletions(-) diff --git a/tools/libs/saverestore/common.h b/tools/libs/saverestore/common.h index 9d2ea96583..c319148f8f 100644 --- a/tools/libs/saverestore/common.h +++ b/tools/libs/saverestore/common.h @@ -244,6 +244,7 @@ struct sr_restore_arrays { int map_errs[MAX_BATCH_SIZE]; /* populate_pfns */ xen_pfn_t pp_mfns[MAX_BATCH_SIZE]; + xen_pfn_t pp_pfns[MAX_BATCH_SIZE]; }; struct xc_sr_context diff --git a/tools/libs/saverestore/restore.c b/tools/libs/saverestore/restore.c index 7418abf1c5..2a6ccce847 100644 --- a/tools/libs/saverestore/restore.c +++ b/tools/libs/saverestore/restore.c @@ -139,17 +139,10 @@ int populate_pfns(struct xc_sr_context *ctx, unsigned int count, { xc_interface *xch = ctx->xch; xen_pfn_t *mfns = ctx->restore.m->pp_mfns, - *pfns = malloc(count * sizeof(*pfns)); + *pfns = ctx->restore.m->pp_pfns; unsigned int i, nr_pfns = 0; int rc = -1; - if ( !pfns ) - { - ERROR("Failed to allocate %zu bytes for populating the physmap", - 2 * count * sizeof(*mfns)); - goto err; - } - for ( i = 0; i < count; ++i ) { if ( (!types || @@ -190,8 +183,6 @@ int populate_pfns(struct xc_sr_context *ctx, unsigned int count, rc = 0; err: - free(pfns); - return rc; } From xen-devel-bounces@lists.xenproject.org Thu Jul 01 10:02:35 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 10:02:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148497.274540 (Exim 4.92) (envelope-from ) id 1lytWl-0000ER-LQ; Thu, 01 Jul 2021 10:02:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148497.274540; Thu, 01 Jul 2021 10:02:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lytWl-0000E6-Ga; Thu, 01 Jul 2021 10:02:35 +0000 Received: by outflank-mailman (input) for mailman id 148497; Thu, 01 Jul 2021 10:02:34 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lytSH-0004r4-Ht for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 09:57:57 +0000 Received: from mo4-p04-ob.smtp.rzone.de (unknown [85.215.255.123]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 0fea3b19-9598-4b0d-8e2a-c7057ee0a005; Thu, 01 Jul 2021 09:57:03 +0000 (UTC) Received: from sender by smtp.strato.de (RZmta 47.28.1 AUTH) with ESMTPSA id 30791cx619uv5Nj (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Thu, 1 Jul 2021 11:56:57 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0fea3b19-9598-4b0d-8e2a-c7057ee0a005 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1625133418; s=strato-dkim-0002; d=aepfle.de; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Cc:Date: From:Subject:Sender; bh=i+CtqX1HY7Q0UrDFSipaIMys+n7R0U7HixGDrxWfeJY=; b=hO+V6Ivo6IqbiuUjPoOD4+qcc8FkwAB9Ci1Ygzs+u7DBYKfrbswow5XDZaZiMnqPDM j4EEfMoB/HMaP2JxuESRHJbw5SNvW8fDAy26jNIE73+Lx5sYncXt2/sYF1wNR9d/Urm0 zhq4gle6Hkg946CQEFSV9rt3g7rOukJXm6yTuhRnkLoEajBapO9Qzo0yW8DI45mw8uTu WR5nk4+xYe6xOloLF0VlHUWVhEij2IQrcKhuUApPZ3w/czVD+Wx5J5IbbwD0RRNNn5Uh RTLOSFZowP0fiHcvjCDqKqihtd7EJmo5NeoPgUNim8sP+XpjZM+npzvS3J8LdYWXjEjD Idbw== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QXkBR9MXjAuzpIG0mv9coXAg5lqlz7EsstGyDcxK3Mbajr+SQKopp1Cb0CyyaZQQ==" X-RZG-CLASS-ID: mo00 From: Olaf Hering To: xen-devel@lists.xenproject.org Cc: Olaf Hering , Ian Jackson , Wei Liu , Juergen Gross Subject: [PATCH v20210701 38/40] tools: add API for expandable bitmaps Date: Thu, 1 Jul 2021 11:56:33 +0200 Message-Id: <20210701095635.15648-39-olaf@aepfle.de> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210701095635.15648-1-olaf@aepfle.de> References: <20210701095635.15648-1-olaf@aepfle.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Since the incoming migration stream lacks info about what the highest pfn will be, some data structures can not be allocated upfront. Add an API for expandable bitmaps, loosely based on pfn_set_populated. Signed-off-by: Olaf Hering --- tools/libs/saverestore/common.c | 39 +++++++++++++++++++ tools/libs/saverestore/common.h | 67 +++++++++++++++++++++++++++++++++ 2 files changed, 106 insertions(+) diff --git a/tools/libs/saverestore/common.c b/tools/libs/saverestore/common.c index 7da7fa4e2c..e96173eea2 100644 --- a/tools/libs/saverestore/common.c +++ b/tools/libs/saverestore/common.c @@ -163,6 +163,45 @@ static void __attribute__((unused)) build_assertions(void) BUILD_BUG_ON(sizeof(struct xc_sr_rec_hvm_params) != 8); } +/* + * Expand the tracking structures as needed. + * To avoid realloc()ing too excessively, the size increased to the nearest + * power of two large enough to contain the required number of bits. + */ +bool _sr_bitmap_expand(struct sr_bitmap *bm, unsigned long bits) +{ + size_t new_max; + size_t old_sz, new_sz; + void *p; + + if (bits <= bm->bits) + return true; + + /* Round up to the nearest power of two larger than bit, less 1. */ + new_max = bits; + new_max |= new_max >> 1; + new_max |= new_max >> 2; + new_max |= new_max >> 4; + new_max |= new_max >> 8; + new_max |= new_max >> 16; + new_max |= sizeof(unsigned long) > 4 ? new_max >> 32 : 0; + + /* Allocate units of unsigned long */ + new_max = (new_max + BITS_PER_LONG - 1) & ~(BITS_PER_LONG - 1); + + old_sz = bitmap_size(bm->bits); + new_sz = bitmap_size(new_max); + p = realloc(bm->p, new_sz); + if (!p) + return false; + + memset(p + old_sz, 0, new_sz - old_sz); + bm->p = p; + bm->bits = new_max; + + return true; +} + /* * Local variables: * mode: C diff --git a/tools/libs/saverestore/common.h b/tools/libs/saverestore/common.h index bb7e437291..e6a269c482 100644 --- a/tools/libs/saverestore/common.h +++ b/tools/libs/saverestore/common.h @@ -30,6 +30,73 @@ const char *rec_type_to_str(uint32_t type); struct xc_sr_context; struct xc_sr_record; +struct sr_bitmap +{ + void *p; + unsigned long bits; +}; + +extern bool _sr_bitmap_expand(struct sr_bitmap *bm, unsigned long bits); + +static inline bool sr_bitmap_expand(struct sr_bitmap *bm, unsigned long bits) +{ + if (bits > bm->bits) + return _sr_bitmap_expand(bm, bits); + return true; +} + +static inline void sr_bitmap_free(struct sr_bitmap *bm) +{ + free(bm->p); + bm->p = NULL; +} + +static inline bool sr_set_bit(unsigned long bit, struct sr_bitmap *bm) +{ + if (sr_bitmap_expand(bm, bit) == false) + return false; + + set_bit(bit, bm->p); + return true; +} + +static inline bool sr_test_bit(unsigned long bit, struct sr_bitmap *bm) +{ + if (bit > bm->bits) + return false; + return !!test_bit(bit, bm->p); +} + +static inline void sr_clear_bit(unsigned long bit, struct sr_bitmap *bm) +{ + if (bit <= bm->bits) + clear_bit(bit, bm->p); +} + +static inline bool sr_test_and_clear_bit(unsigned long bit, struct sr_bitmap *bm) +{ + if (bit > bm->bits) + return false; + return !!test_and_clear_bit(bit, bm->p); +} + +/* No way to report potential allocation error, bitmap must be expanded prior usage */ +static inline bool sr_test_and_set_bit(unsigned long bit, struct sr_bitmap *bm) +{ + if (bit > bm->bits) + return false; + return !!test_and_set_bit(bit, bm->p); +} + +static inline bool sr_set_long_bit(unsigned long base_bit, struct sr_bitmap *bm) +{ + if (sr_bitmap_expand(bm, base_bit + BITS_PER_LONG) == false) + return false; + + set_bit_long(base_bit, bm->p); + return true; +} + /** * Save operations. To be implemented for each type of guest, for use by the * common save algorithm. From xen-devel-bounces@lists.xenproject.org Thu Jul 01 10:02:39 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 10:02:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148504.274556 (Exim 4.92) (envelope-from ) id 1lytWp-0000rP-P2; Thu, 01 Jul 2021 10:02:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148504.274556; Thu, 01 Jul 2021 10:02:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lytWp-0000qG-Fp; Thu, 01 Jul 2021 10:02:39 +0000 Received: by outflank-mailman (input) for mailman id 148504; Thu, 01 Jul 2021 10:02:37 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lytSA-0004XT-T4 for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 09:57:50 +0000 Received: from mo4-p03-ob.smtp.rzone.de (unknown [81.169.146.174]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 086b66b3-062c-4f5c-b56c-b9cf69dfab2d; Thu, 01 Jul 2021 09:56:54 +0000 (UTC) Received: from sender by smtp.strato.de (RZmta 47.28.1 AUTH) with ESMTPSA id 30791cx619um5N9 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Thu, 1 Jul 2021 11:56:48 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 086b66b3-062c-4f5c-b56c-b9cf69dfab2d DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1625133408; s=strato-dkim-0002; d=aepfle.de; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Cc:Date: From:Subject:Sender; bh=43SvGtyUka0RJRv5k5wfzNrETGLrxHTj64zykGKQL1Q=; b=Vj7qzvDcXM4w4xzTRvoqwCtgS94+Xdcvmq/iAUm6RQQF+XzTP3l2LkKk8uk2ijxQGR FsglZZU0fiNrVk6j4R2pBm5V6iohYwZo28xkOEdvllPaizwYAOe7OvarbDJiE5K84TPD OPLdIoXnQ8D7j/tPK6b3YCbNHVVFQWSraMoZInJO9lJCT/iIxsZvivkAK4T9aoYiRWyQ kxCXCPt4924Mu89+91b9XLjdMdbTWGxQwYMcm+fMHFmYeLHOOESPpq8kbei2RzNSo9H0 T+FH2EnuUm2v0CHLo7qC4yHN/1vnNU2qr9zT/7+ahbg2XliUJk7Z38SsZwAXgsxErdk3 JqwA== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QXkBR9MXjAuzpIG0mv9coXAg5lqlz7EsstGyDcxK3Mbajr+SQKopp1Cb0CyyaZQQ==" X-RZG-CLASS-ID: mo00 From: Olaf Hering To: xen-devel@lists.xenproject.org Cc: Olaf Hering , Juergen Gross , Ian Jackson , Wei Liu Subject: [PATCH v20210701 19/40] tools: save: move iov array Date: Thu, 1 Jul 2021 11:56:14 +0200 Message-Id: <20210701095635.15648-20-olaf@aepfle.de> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210701095635.15648-1-olaf@aepfle.de> References: <20210701095635.15648-1-olaf@aepfle.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Remove allocation from hotpath, move iov array into preallocated space. Signed-off-by: Olaf Hering Reviewed-by: Juergen Gross --- tools/libs/saverestore/common.h | 2 ++ tools/libs/saverestore/save.c | 7 ++----- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/tools/libs/saverestore/common.h b/tools/libs/saverestore/common.h index 25ee8fcb0f..c8a30acf7b 100644 --- a/tools/libs/saverestore/common.h +++ b/tools/libs/saverestore/common.h @@ -231,6 +231,8 @@ struct sr_save_arrays { xen_pfn_t types[MAX_BATCH_SIZE]; /* write_batch: Errors from attempting to map the gfns. */ int errors[MAX_BATCH_SIZE]; + /* write_batch: iovec[] for writev(). */ + struct iovec iov[MAX_BATCH_SIZE + 4]; }; struct sr_restore_arrays { diff --git a/tools/libs/saverestore/save.c b/tools/libs/saverestore/save.c index 9ebbf00ce7..1a5f3d29ea 100644 --- a/tools/libs/saverestore/save.c +++ b/tools/libs/saverestore/save.c @@ -97,7 +97,7 @@ static int write_batch(struct xc_sr_context *ctx) unsigned int nr_pfns = ctx->save.nr_batch_pfns; void *page, *orig_page; uint64_t *rec_pfns = NULL; - struct iovec *iov = NULL; int iovcnt = 0; + struct iovec *iov = ctx->save.m->iov; int iovcnt = 0; struct xc_sr_rec_page_data_header hdr = { 0 }; struct xc_sr_record rec = { .type = REC_TYPE_PAGE_DATA, @@ -109,10 +109,8 @@ static int write_batch(struct xc_sr_context *ctx) guest_data = calloc(nr_pfns, sizeof(*guest_data)); /* Pointers to locally allocated pages. Need freeing. */ local_pages = calloc(nr_pfns, sizeof(*local_pages)); - /* iovec[] for writev(). */ - iov = malloc((nr_pfns + 4) * sizeof(*iov)); - if ( !guest_data || !local_pages || !iov ) + if ( !guest_data || !local_pages ) { ERROR("Unable to allocate arrays for a batch of %u pages", nr_pfns); @@ -266,7 +264,6 @@ static int write_batch(struct xc_sr_context *ctx) xenforeignmemory_unmap(xch->fmem, guest_mapping, nr_pages_mapped); for ( i = 0; local_pages && i < nr_pfns; ++i ) free(local_pages[i]); - free(iov); free(local_pages); free(guest_data); From xen-devel-bounces@lists.xenproject.org Thu Jul 01 10:02:40 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 10:02:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148501.274551 (Exim 4.92) (envelope-from ) id 1lytWp-0000n1-8S; Thu, 01 Jul 2021 10:02:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148501.274551; Thu, 01 Jul 2021 10:02:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lytWp-0000mW-41; Thu, 01 Jul 2021 10:02:39 +0000 Received: by outflank-mailman (input) for mailman id 148501; Thu, 01 Jul 2021 10:02:37 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lytS7-0004r4-HY for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 09:57:47 +0000 Received: from mo4-p03-ob.smtp.rzone.de (unknown [81.169.146.172]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 8fb93b39-fa31-4fd4-b68b-bf10d2e2264c; Thu, 01 Jul 2021 09:57:00 +0000 (UTC) Received: from sender by smtp.strato.de (RZmta 47.28.1 AUTH) with ESMTPSA id 30791cx619uq5NR (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Thu, 1 Jul 2021 11:56:52 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8fb93b39-fa31-4fd4-b68b-bf10d2e2264c DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1625133412; s=strato-dkim-0002; d=aepfle.de; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Cc:Date: From:Subject:Sender; bh=BF1RLVhIB1BINrph0oGFlHcI4RXAoWr7u8tCO2/nmZw=; b=Cm3516N0bw8SQ/Ki/WWHQi6r4HjWgWgj5xxASFu1AZkoJQIACx2212nqjH5dm0ouAN UvTL56YGB12xLGngtgO7Az7s7a42jOWIGQskDHHUIrFgjpuMeBoaEMSyx1a0VfOGmOMq Z2ub8mBu2XLoZEi8bS6dkMpseRQLeAmSaZMqtUk5T/kPT2foO1GwRkZdXm9yDLcUtva9 x1CEB4cO5XD7bbpMeFKoEfEEjfiq2Sd8jiCdKYPNt68JF7f7/oveqdvlzywL5Y2OcNZu IVRw2HRHEelfUAnd7qpBFvdaJsJVXojGDv3QKlEdlsMXUFEyTEmtGi1kttrzo1ycKubo JbQw== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QXkBR9MXjAuzpIG0mv9coXAg5lqlz7EsstGyDcxK3Mbajr+SQKopp1Cb0CyyaZQQ==" X-RZG-CLASS-ID: mo00 From: Olaf Hering To: xen-devel@lists.xenproject.org Cc: Olaf Hering , Ian Jackson , Wei Liu , Juergen Gross Subject: [PATCH v20210701 29/40] tools: restore: split handle_page_data Date: Thu, 1 Jul 2021 11:56:24 +0200 Message-Id: <20210701095635.15648-30-olaf@aepfle.de> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210701095635.15648-1-olaf@aepfle.de> References: <20210701095635.15648-1-olaf@aepfle.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit handle_page_data must be able to read directly into mapped guest memory. This will avoid unneccesary memcpy calls for data that can be consumed verbatim. Split the various steps of record processing: - move processing to handle_buffered_page_data - adjust xenforeignmemory_map to set errno in case of failure - adjust verify mode to set errno in case of failure This change is preparation for future changes in handle_page_data, no change in behavior is intended. Signed-off-by: Olaf Hering --- tools/libs/saverestore/common.h | 9 + tools/libs/saverestore/restore.c | 343 ++++++++++++++++++++----------- 2 files changed, 231 insertions(+), 121 deletions(-) diff --git a/tools/libs/saverestore/common.h b/tools/libs/saverestore/common.h index 580eafacc8..96bd0ab80e 100644 --- a/tools/libs/saverestore/common.h +++ b/tools/libs/saverestore/common.h @@ -242,9 +242,14 @@ struct sr_restore_arrays { /* process_page_data */ xen_pfn_t mfns[MAX_BATCH_SIZE]; int map_errs[MAX_BATCH_SIZE]; + void *guest_data[MAX_BATCH_SIZE]; + /* populate_pfns */ xen_pfn_t pp_mfns[MAX_BATCH_SIZE]; xen_pfn_t pp_pfns[MAX_BATCH_SIZE]; + + /* Must be the last member */ + struct xc_sr_rec_page_data_header pages; }; struct xc_sr_context @@ -335,7 +340,11 @@ struct xc_sr_context /* Sender has invoked verify mode on the stream. */ bool verify; + void *verify_buf; + struct sr_restore_arrays *m; + void *guest_mapping; + uint32_t nr_mapped_pages; } restore; }; diff --git a/tools/libs/saverestore/restore.c b/tools/libs/saverestore/restore.c index e75380155d..7643de58e0 100644 --- a/tools/libs/saverestore/restore.c +++ b/tools/libs/saverestore/restore.c @@ -186,123 +186,18 @@ int populate_pfns(struct xc_sr_context *ctx, unsigned int count, return rc; } -/* - * Given a list of pfns, their types, and a block of page data from the - * stream, populate and record their types, map the relevant subset and copy - * the data into the guest. - */ -static int process_page_data(struct xc_sr_context *ctx, unsigned int count, - xen_pfn_t *pfns, uint32_t *types, void *page_data) +static int handle_static_data_end_v2(struct xc_sr_context *ctx) { - xc_interface *xch = ctx->xch; - xen_pfn_t *mfns = ctx->restore.m->mfns; - int *map_errs = ctx->restore.m->map_errs; - int rc; - void *mapping = NULL, *guest_page = NULL; - unsigned int i, /* i indexes the pfns from the record. */ - j, /* j indexes the subset of pfns we decide to map. */ - nr_pages = 0; - - rc = populate_pfns(ctx, count, pfns, types); - if ( rc ) - { - ERROR("Failed to populate pfns for batch of %u pages", count); - goto err; - } - - for ( i = 0; i < count; ++i ) - { - ctx->restore.ops.set_page_type(ctx, pfns[i], types[i]); - - if ( page_type_has_stream_data(types[i]) == true ) - mfns[nr_pages++] = ctx->restore.ops.pfn_to_gfn(ctx, pfns[i]); - } - - /* Nothing to do? */ - if ( nr_pages == 0 ) - goto done; - - mapping = guest_page = xenforeignmemory_map( - xch->fmem, ctx->domid, PROT_READ | PROT_WRITE, - nr_pages, mfns, map_errs); - if ( !mapping ) - { - rc = -1; - PERROR("Unable to map %u mfns for %u pages of data", - nr_pages, count); - goto err; - } - - for ( i = 0, j = 0; i < count; ++i ) - { - if ( page_type_has_stream_data(types[i]) == false ) - continue; - - if ( map_errs[j] ) - { - rc = -1; - ERROR("Mapping pfn %#"PRIpfn" (mfn %#"PRIpfn", type %#"PRIx32") failed with %d", - pfns[i], mfns[j], types[i], map_errs[j]); - goto err; - } - - /* Undo page normalisation done by the saver. */ - rc = ctx->restore.ops.localise_page(ctx, types[i], page_data); - if ( rc ) - { - ERROR("Failed to localise pfn %#"PRIpfn" (type %#"PRIx32")", - pfns[i], types[i] >> XEN_DOMCTL_PFINFO_LTAB_SHIFT); - goto err; - } - - if ( ctx->restore.verify ) - { - /* Verify mode - compare incoming data to what we already have. */ - if ( memcmp(guest_page, page_data, PAGE_SIZE) ) - ERROR("verify pfn %#"PRIpfn" failed (type %#"PRIx32")", - pfns[i], types[i] >> XEN_DOMCTL_PFINFO_LTAB_SHIFT); - } - else - { - /* Regular mode - copy incoming data into place. */ - memcpy(guest_page, page_data, PAGE_SIZE); - } - - ++j; - guest_page += PAGE_SIZE; - page_data += PAGE_SIZE; - } - - done: - rc = 0; - - err: - if ( mapping ) - xenforeignmemory_unmap(xch->fmem, mapping, nr_pages); - - return rc; -} + int rc = 0; -/* - * Validate a PAGE_DATA record from the stream, and pass the results to - * process_page_data() to actually perform the legwork. - */ -static int handle_page_data(struct xc_sr_context *ctx, struct xc_sr_record *rec) -{ +#if defined(__i386__) || defined(__x86_64__) xc_interface *xch = ctx->xch; - struct xc_sr_rec_page_data_header *pages = rec->data; - unsigned int i, pages_of_data = 0; - int rc = -1; - - xen_pfn_t *pfns = ctx->restore.m->pfns, pfn; - uint32_t *types = ctx->restore.m->types, type; - /* * v2 compatibility only exists for x86 streams. This is a bit of a * bodge, but it is less bad than duplicating handle_page_data() between * different architectures. */ -#if defined(__i386__) || defined(__x86_64__) + /* v2 compat. Infer the position of STATIC_DATA_END. */ if ( ctx->restore.format_version < 3 && !ctx->restore.seen_static_data_end ) { @@ -320,12 +215,26 @@ static int handle_page_data(struct xc_sr_context *ctx, struct xc_sr_record *rec) ERROR("No STATIC_DATA_END seen"); goto err; } + + rc = 0; +err: #endif - if ( rec->length < sizeof(*pages) ) + return rc; +} + +static bool verify_rec_page_hdr(struct xc_sr_context *ctx, uint32_t rec_length, + struct xc_sr_rec_page_data_header *pages) +{ + xc_interface *xch = ctx->xch; + bool ret = false; + + errno = EINVAL; + + if ( rec_length < sizeof(*pages) ) { ERROR("PAGE_DATA record truncated: length %u, min %zu", - rec->length, sizeof(*pages)); + rec_length, sizeof(*pages)); goto err; } @@ -335,13 +244,35 @@ static int handle_page_data(struct xc_sr_context *ctx, struct xc_sr_record *rec) goto err; } - if ( rec->length < sizeof(*pages) + (pages->count * sizeof(uint64_t)) ) + if ( pages->count > MAX_BATCH_SIZE ) + { + ERROR("pfn count %u in PAGE_DATA record too large", pages->count); + errno = E2BIG; + goto err; + } + + if ( rec_length < sizeof(*pages) + (pages->count * sizeof(uint64_t)) ) { ERROR("PAGE_DATA record (length %u) too short to contain %u" - " pfns worth of information", rec->length, pages->count); + " pfns worth of information", rec_length, pages->count); goto err; } + ret = true; + +err: + return ret; +} + +static bool verify_rec_page_pfns(struct xc_sr_context *ctx, uint32_t rec_length, + struct xc_sr_rec_page_data_header *pages) +{ + xc_interface *xch = ctx->xch; + uint32_t i, pages_of_data = 0; + xen_pfn_t pfn; + uint32_t type; + bool ret = false; + for ( i = 0; i < pages->count; ++i ) { pfn = pages->pfn[i] & PAGE_DATA_PFN_MASK; @@ -364,23 +295,183 @@ static int handle_page_data(struct xc_sr_context *ctx, struct xc_sr_record *rec) * have a page worth of data in the record. */ pages_of_data++; - pfns[i] = pfn; - types[i] = type; + ctx->restore.m->pfns[i] = pfn; + ctx->restore.m->types[i] = type; } - if ( rec->length != (sizeof(*pages) + + if ( rec_length != (sizeof(*pages) + (sizeof(uint64_t) * pages->count) + (PAGE_SIZE * pages_of_data)) ) { ERROR("PAGE_DATA record wrong size: length %u, expected " - "%zu + %zu + %lu", rec->length, sizeof(*pages), + "%zu + %zu + %lu", rec_length, sizeof(*pages), (sizeof(uint64_t) * pages->count), (PAGE_SIZE * pages_of_data)); goto err; } - rc = process_page_data(ctx, pages->count, pfns, types, - &pages->pfn[pages->count]); + ret = true; + +err: + return ret; +} + +/* + * Populate pfns, if required + * Fill m->guest_data with either mapped address or NULL + * The caller must unmap guest_mapping + */ +static int map_guest_pages(struct xc_sr_context *ctx, + struct xc_sr_rec_page_data_header *pages) +{ + xc_interface *xch = ctx->xch; + struct sr_restore_arrays *m = ctx->restore.m; + uint32_t i, p; + int rc; + + rc = populate_pfns(ctx, pages->count, m->pfns, m->types); + if ( rc ) + { + ERROR("Failed to populate pfns for batch of %u pages", pages->count); + goto err; + } + + ctx->restore.nr_mapped_pages = 0; + + for ( i = 0; i < pages->count; i++ ) + { + ctx->restore.ops.set_page_type(ctx, m->pfns[i], m->types[i]); + + if ( page_type_has_stream_data(m->types[i]) == false ) + { + m->guest_data[i] = NULL; + continue; + } + + m->mfns[ctx->restore.nr_mapped_pages++] = ctx->restore.ops.pfn_to_gfn(ctx, m->pfns[i]); + } + + /* Nothing to do? */ + if ( ctx->restore.nr_mapped_pages == 0 ) + goto done; + + ctx->restore.guest_mapping = xenforeignmemory_map(xch->fmem, ctx->domid, + PROT_READ | PROT_WRITE, ctx->restore.nr_mapped_pages, + m->mfns, m->map_errs); + if ( !ctx->restore.guest_mapping ) + { + rc = -1; + PERROR("Unable to map %u mfns for %u pages of data", + ctx->restore.nr_mapped_pages, pages->count); + goto err; + } + + /* Verify mapping, and assign address to pfn data */ + for ( i = 0, p = 0; i < pages->count; i++ ) + { + if ( page_type_has_stream_data(m->types[i]) == false ) + continue; + + if ( m->map_errs[p] == 0 ) + { + m->guest_data[i] = ctx->restore.guest_mapping + (p * PAGE_SIZE); + p++; + continue; + } + + errno = m->map_errs[p]; + rc = -1; + PERROR("Mapping pfn %#"PRIpfn" (mfn %#"PRIpfn", type %#"PRIx32") failed", + m->pfns[i], m->mfns[p], m->types[i]); + goto err; + } + +done: + rc = 0; + +err: + return rc; +} + +/* + * Handle PAGE_DATA record from an existing buffer + * Given a list of pfns, their types, and a block of page data from the + * stream, populate and record their types, map the relevant subset and copy + * the data into the guest. + */ +static int handle_buffered_page_data(struct xc_sr_context *ctx, + struct xc_sr_record *rec) +{ + xc_interface *xch = ctx->xch; + struct xc_sr_rec_page_data_header *pages = rec->data; + struct sr_restore_arrays *m = ctx->restore.m; + void *p; + uint32_t i; + int rc = -1, idx; + + rc = handle_static_data_end_v2(ctx); + if ( rc ) + goto err; + + /* First read and verify the header */ + if ( verify_rec_page_hdr(ctx, rec->length, pages) == false ) + { + rc = -1; + goto err; + } + + /* Then read and verify the pfn numbers */ + if ( verify_rec_page_pfns(ctx, rec->length, pages) == false ) + { + rc = -1; + goto err; + } + + /* Map the target pfn */ + rc = map_guest_pages(ctx, pages); + if ( rc ) + goto err; + + for ( i = 0, idx = 0; i < pages->count; i++ ) + { + if ( !m->guest_data[i] ) + continue; + + p = &pages->pfn[pages->count] + (idx * PAGE_SIZE); + rc = ctx->restore.ops.localise_page(ctx, m->types[i], p); + if ( rc ) + { + ERROR("Failed to localise pfn %#"PRIpfn" (type %#"PRIx32")", + m->pfns[i], m->types[i] >> XEN_DOMCTL_PFINFO_LTAB_SHIFT); + goto err; + + } + + if ( ctx->restore.verify ) + { + if ( memcmp(m->guest_data[i], p, PAGE_SIZE) ) + { + errno = EIO; + ERROR("verify pfn %#"PRIpfn" failed (type %#"PRIx32")", + m->pfns[i], m->types[i] >> XEN_DOMCTL_PFINFO_LTAB_SHIFT); + goto err; + } + } + else + { + memcpy(m->guest_data[i], p, PAGE_SIZE); + } + + idx++; + } + + rc = 0; + err: + if ( ctx->restore.guest_mapping ) + { + xenforeignmemory_unmap(xch->fmem, ctx->restore.guest_mapping, ctx->restore.nr_mapped_pages); + ctx->restore.guest_mapping = NULL; + } return rc; } @@ -641,12 +732,21 @@ static int process_buffered_record(struct xc_sr_context *ctx, struct xc_sr_recor break; case REC_TYPE_PAGE_DATA: - rc = handle_page_data(ctx, rec); + rc = handle_buffered_page_data(ctx, rec); break; case REC_TYPE_VERIFY: DPRINTF("Verify mode enabled"); ctx->restore.verify = true; + if ( !ctx->restore.verify_buf ) + { + ctx->restore.verify_buf = malloc(MAX_BATCH_SIZE * PAGE_SIZE); + if ( !ctx->restore.verify_buf ) + { + rc = -1; + PERROR("Unable to allocate verify_buf"); + } + } break; case REC_TYPE_CHECKPOINT: @@ -725,7 +825,8 @@ static int setup(struct xc_sr_context *ctx) } ctx->restore.allocated_rec_num = DEFAULT_BUF_RECORDS; - ctx->restore.m = malloc(sizeof(*ctx->restore.m)); + ctx->restore.m = malloc(sizeof(*ctx->restore.m) + + (sizeof(*ctx->restore.m->pages.pfn) * MAX_BATCH_SIZE)); if ( !ctx->restore.m ) { ERROR("Unable to allocate memory for arrays"); rc = -1; From xen-devel-bounces@lists.xenproject.org Thu Jul 01 10:02:40 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 10:02:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148507.274561 (Exim 4.92) (envelope-from ) id 1lytWq-0000z8-9n; Thu, 01 Jul 2021 10:02:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148507.274561; Thu, 01 Jul 2021 10:02:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lytWq-0000wq-0h; Thu, 01 Jul 2021 10:02:40 +0000 Received: by outflank-mailman (input) for mailman id 148507; Thu, 01 Jul 2021 10:02:38 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lytSe-0004XT-UD for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 09:58:20 +0000 Received: from mo4-p03-ob.smtp.rzone.de (unknown [81.169.146.172]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 1bd39e47-8d61-453f-8021-3b2516e0ff03; Thu, 01 Jul 2021 09:56:57 +0000 (UTC) Received: from sender by smtp.strato.de (RZmta 47.28.1 AUTH) with ESMTPSA id 30791cx619uo5NK (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Thu, 1 Jul 2021 11:56:50 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1bd39e47-8d61-453f-8021-3b2516e0ff03 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1625133411; s=strato-dkim-0002; d=aepfle.de; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Cc:Date: From:Subject:Sender; bh=fv8u8kOPgs+5gp4rBj+tXUjGXKsfh+8d1IsW+dkfVk4=; b=S+Xl4Z1zszliY0TzkrzXrYIBAHGDew/2RqvBacfbRbmSaLzzwduoKo4x79mMCm/5g/ nDuK2IfnqsEdrhAxeKKyVqZJ2Mhv5EI6ybX2QNeiJypMRtsZUGbvjXJBthCOmhe13XmN lOjt8ppHej1Y/J8H/BBSmEx+9MBpvruf8K7hKVnI2cP0fPOXESbiD/qXoYUNb/+mhW/A xqUUq/CwFuevuGKoDO9vuZsYBvzHrDVFapY3ZH+xnZedCUQQvUK3u97yncGPW5rz7vEJ 8nlvmt+H4eGDZ/ti0AXEwA4ibB7rn7Dg9iiSJ0oJzsLY/y+NoryAToCjPJyYWveR0HPV U7gA== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QXkBR9MXjAuzpIG0mv9coXAg5lqlz7EsstGyDcxK3Mbajr+SQKopp1Cb0CyyaZQQ==" X-RZG-CLASS-ID: mo00 From: Olaf Hering To: xen-devel@lists.xenproject.org Cc: Olaf Hering , Juergen Gross , Ian Jackson , Wei Liu Subject: [PATCH v20210701 25/40] tools: restore: move map_errs array Date: Thu, 1 Jul 2021 11:56:20 +0200 Message-Id: <20210701095635.15648-26-olaf@aepfle.de> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210701095635.15648-1-olaf@aepfle.de> References: <20210701095635.15648-1-olaf@aepfle.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Remove allocation from hotpath, move map_errs array into preallocated space. Signed-off-by: Olaf Hering Reviewed-by: Juergen Gross --- tools/libs/saverestore/common.h | 1 + tools/libs/saverestore/restore.c | 12 +----------- 2 files changed, 2 insertions(+), 11 deletions(-) diff --git a/tools/libs/saverestore/common.h b/tools/libs/saverestore/common.h index 9d7efff03d..7684c35e22 100644 --- a/tools/libs/saverestore/common.h +++ b/tools/libs/saverestore/common.h @@ -241,6 +241,7 @@ struct sr_restore_arrays { uint32_t types[MAX_BATCH_SIZE]; /* process_page_data */ xen_pfn_t mfns[MAX_BATCH_SIZE]; + int map_errs[MAX_BATCH_SIZE]; }; struct xc_sr_context diff --git a/tools/libs/saverestore/restore.c b/tools/libs/saverestore/restore.c index d7ea52b89e..578ee1accb 100644 --- a/tools/libs/saverestore/restore.c +++ b/tools/libs/saverestore/restore.c @@ -206,21 +206,13 @@ static int process_page_data(struct xc_sr_context *ctx, unsigned int count, { xc_interface *xch = ctx->xch; xen_pfn_t *mfns = ctx->restore.m->mfns; - int *map_errs = malloc(count * sizeof(*map_errs)); + int *map_errs = ctx->restore.m->map_errs; int rc; void *mapping = NULL, *guest_page = NULL; unsigned int i, /* i indexes the pfns from the record. */ j, /* j indexes the subset of pfns we decide to map. */ nr_pages = 0; - if ( !map_errs ) - { - rc = -1; - ERROR("Failed to allocate %zu bytes to process page data", - count * (sizeof(*mfns) + sizeof(*map_errs))); - goto err; - } - rc = populate_pfns(ctx, count, pfns, types); if ( rc ) { @@ -298,8 +290,6 @@ static int process_page_data(struct xc_sr_context *ctx, unsigned int count, if ( mapping ) xenforeignmemory_unmap(xch->fmem, mapping, nr_pages); - free(map_errs); - return rc; } From xen-devel-bounces@lists.xenproject.org Thu Jul 01 10:02:43 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 10:02:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148509.274580 (Exim 4.92) (envelope-from ) id 1lytWs-0001kx-Vt; Thu, 01 Jul 2021 10:02:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148509.274580; Thu, 01 Jul 2021 10:02:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lytWs-0001iZ-Gy; Thu, 01 Jul 2021 10:02:42 +0000 Received: by outflank-mailman (input) for mailman id 148509; Thu, 01 Jul 2021 10:02:41 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lytVZ-0004XT-4H for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 10:01:21 +0000 Received: from mo4-p03-ob.smtp.rzone.de (unknown [85.215.255.100]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id ac119f06-72cf-4881-9e7d-d1a78e7b3b1d; Thu, 01 Jul 2021 09:58:18 +0000 (UTC) Received: from sender by smtp.strato.de (RZmta 47.28.1 AUTH) with ESMTPSA id 30791cx619us5NW (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Thu, 1 Jul 2021 11:56:54 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ac119f06-72cf-4881-9e7d-d1a78e7b3b1d DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1625133414; s=strato-dkim-0002; d=aepfle.de; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Cc:Date: From:Subject:Sender; bh=n0d0gwWXlJ/Ban5eVrK506Di/gOt/MD61K+N2RGQBbA=; b=Gl58uIDpytNCd08vTi0ztylENVBl+fRtA6BJJFBS4K+oAMI4fOQRThcxhH9ZUenr1p LSGgV3d0plPdsJmtYrjw8IErqZWLZk05W83mq33yvMopOnlMNIgywtuHWkA1KMwkk5NX yllcZGagVS2KO3XT/EARqFZoC16c753PHIjD3vlr7pMx6I9WtNVCUUs4Ps75yCOTF/uu 34eLqRIzWxCGH4+2EkcF2cXdzxQdEavqUKZQcZeA0L58nQ2CoMu/NVsYg+ZZ+1SJMEGt IM6PcldeVJJGQx+XoRzBf0Ba9VSNxnbc1IGFRQPAHtxPOuzMD83paaMsrKDQzmKlXmg9 KCwA== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QXkBR9MXjAuzpIG0mv9coXAg5lqlz7EsstGyDcxK3Mbajr+SQKopp1Cb0CyyaZQQ==" X-RZG-CLASS-ID: mo00 From: Olaf Hering To: xen-devel@lists.xenproject.org Cc: Olaf Hering , Christian Lindig , Ian Jackson , Wei Liu , Anthony PERARD , Juergen Gross , David Scott Subject: [PATCH v20210701 32/40] tools: adjust libxl_domain_suspend to receive a struct props Date: Thu, 1 Jul 2021 11:56:27 +0200 Message-Id: <20210701095635.15648-33-olaf@aepfle.de> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210701095635.15648-1-olaf@aepfle.de> References: <20210701095635.15648-1-olaf@aepfle.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Upcoming changes will pass more knobs down to xc_domain_save. Adjust the libxl_domain_suspend API to allow easy adding of additional knobs. No change in behavior intented. Signed-off-by: Olaf Hering Acked-by: Christian Lindig --- tools/include/libxl.h | 26 +++++++++++++++++++++++--- tools/libs/light/libxl_domain.c | 7 ++++--- tools/ocaml/libs/xl/xenlight_stubs.c | 3 ++- tools/xl/xl_migrate.c | 9 ++++++--- tools/xl/xl_saverestore.c | 3 ++- 5 files changed, 37 insertions(+), 11 deletions(-) diff --git a/tools/include/libxl.h b/tools/include/libxl.h index 29931626a2..9a4d7514ed 100644 --- a/tools/include/libxl.h +++ b/tools/include/libxl.h @@ -1706,12 +1706,32 @@ static inline int libxl_retrieve_domain_configuration_0x041200( libxl_retrieve_domain_configuration_0x041200 #endif +/* + * LIBXL_HAVE_DOMAIN_SUSPEND_PROPS indicates that the + * libxl_domain_suspend_props() function takes a props struct. + */ +#define LIBXL_HAVE_DOMAIN_SUSPEND_PROPS 1 + +typedef struct { + uint32_t flags; /* LIBXL_SUSPEND_* */ +} libxl_domain_suspend_props; +#define LIBXL_SUSPEND_DEBUG 1 +#define LIBXL_SUSPEND_LIVE 2 + int libxl_domain_suspend(libxl_ctx *ctx, uint32_t domid, int fd, - int flags, /* LIBXL_SUSPEND_* */ + libxl_domain_suspend_props *props, const libxl_asyncop_how *ao_how) LIBXL_EXTERNAL_CALLERS_ONLY; -#define LIBXL_SUSPEND_DEBUG 1 -#define LIBXL_SUSPEND_LIVE 2 +#if defined(LIBXL_API_VERSION) && LIBXL_API_VERSION < 0x041600 +static inline int libxl_domain_suspend_0x041500(libxl_ctx *ctx, uint32_t domid, + int fd, int flags, /* LIBXL_SUSPEND_* */ + const libxl_asyncop_how *ao_how) +{ + libxl_domain_suspend_props props = { .flags = flags, }; + return libxl_domain_suspend(ctx, domid, fd, &props, ao_how); +} +#define libxl_domain_suspend libxl_domain_suspend_0x041500 +#endif /* * Only suspend domain, do not save its state to file, do not destroy it. diff --git a/tools/libs/light/libxl_domain.c b/tools/libs/light/libxl_domain.c index c00c36c928..5dbd27900f 100644 --- a/tools/libs/light/libxl_domain.c +++ b/tools/libs/light/libxl_domain.c @@ -505,7 +505,8 @@ static void domain_suspend_cb(libxl__egc *egc, } -int libxl_domain_suspend(libxl_ctx *ctx, uint32_t domid, int fd, int flags, +int libxl_domain_suspend(libxl_ctx *ctx, uint32_t domid, int fd, + libxl_domain_suspend_props *props, const libxl_asyncop_how *ao_how) { AO_CREATE(ctx, domid, ao_how); @@ -526,8 +527,8 @@ int libxl_domain_suspend(libxl_ctx *ctx, uint32_t domid, int fd, int flags, dss->domid = domid; dss->fd = fd; dss->type = type; - dss->live = flags & LIBXL_SUSPEND_LIVE; - dss->debug = flags & LIBXL_SUSPEND_DEBUG; + dss->live = props->flags & LIBXL_SUSPEND_LIVE; + dss->debug = props->flags & LIBXL_SUSPEND_DEBUG; dss->checkpointed_stream = LIBXL_CHECKPOINTED_STREAM_NONE; rc = libxl__fd_flags_modify_save(gc, dss->fd, diff --git a/tools/ocaml/libs/xl/xenlight_stubs.c b/tools/ocaml/libs/xl/xenlight_stubs.c index 352a00134d..eaf7bce35a 100644 --- a/tools/ocaml/libs/xl/xenlight_stubs.c +++ b/tools/ocaml/libs/xl/xenlight_stubs.c @@ -614,10 +614,11 @@ value stub_libxl_domain_suspend(value ctx, value domid, value fd, value async, v int ret; uint32_t c_domid = Int_val(domid); int c_fd = Int_val(fd); + libxl_domain_suspend_props props = {}; libxl_asyncop_how *ao_how = aohow_val(async); caml_enter_blocking_section(); - ret = libxl_domain_suspend(CTX, c_domid, c_fd, 0, ao_how); + ret = libxl_domain_suspend(CTX, c_domid, c_fd, &props, ao_how); caml_leave_blocking_section(); free(ao_how); diff --git a/tools/xl/xl_migrate.c b/tools/xl/xl_migrate.c index b8594f44a5..144890924f 100644 --- a/tools/xl/xl_migrate.c +++ b/tools/xl/xl_migrate.c @@ -186,7 +186,10 @@ static void migrate_domain(uint32_t domid, int preserve_domid, char *away_domname; char rc_buf; uint8_t *config_data; - int config_len, flags = LIBXL_SUSPEND_LIVE; + int config_len; + libxl_domain_suspend_props props = { + .flags = LIBXL_SUSPEND_LIVE, + }; save_domain_core_begin(domid, preserve_domid, override_config_file, &config_data, &config_len); @@ -205,8 +208,8 @@ static void migrate_domain(uint32_t domid, int preserve_domid, xtl_stdiostream_adjust_flags(logger, XTL_STDIOSTREAM_HIDE_PROGRESS, 0); if (debug) - flags |= LIBXL_SUSPEND_DEBUG; - rc = libxl_domain_suspend(ctx, domid, send_fd, flags, NULL); + props.flags |= LIBXL_SUSPEND_DEBUG; + rc = libxl_domain_suspend(ctx, domid, send_fd, &props, NULL); if (rc) { fprintf(stderr, "migration sender: libxl_domain_suspend failed" " (rc=%d)\n", rc); diff --git a/tools/xl/xl_saverestore.c b/tools/xl/xl_saverestore.c index 953d791d1a..476d4d9a6a 100644 --- a/tools/xl/xl_saverestore.c +++ b/tools/xl/xl_saverestore.c @@ -130,6 +130,7 @@ static int save_domain(uint32_t domid, int preserve_domid, int fd; uint8_t *config_data; int config_len; + libxl_domain_suspend_props props = {}; save_domain_core_begin(domid, preserve_domid, override_config_file, &config_data, &config_len); @@ -146,7 +147,7 @@ static int save_domain(uint32_t domid, int preserve_domid, save_domain_core_writeconfig(fd, filename, config_data, config_len); - int rc = libxl_domain_suspend(ctx, domid, fd, 0, NULL); + int rc = libxl_domain_suspend(ctx, domid, fd, &props, NULL); close(fd); if (rc < 0) { From xen-devel-bounces@lists.xenproject.org Thu Jul 01 10:13:42 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 10:13:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148574.274595 (Exim 4.92) (envelope-from ) id 1lythQ-0006HL-FN; Thu, 01 Jul 2021 10:13:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148574.274595; Thu, 01 Jul 2021 10:13:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lythQ-0006HE-BK; Thu, 01 Jul 2021 10:13:36 +0000 Received: by outflank-mailman (input) for mailman id 148574; Thu, 01 Jul 2021 10:13:35 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lythP-0006H8-6F for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 10:13:35 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 9fcd3858-5b16-4314-9be1-40ca547d3c6d; Thu, 01 Jul 2021 10:13:34 +0000 (UTC) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05lp2110.outbound.protection.outlook.com [104.47.18.110]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-31-F0waoWd6NVW-5zIx2J01vw-1; Thu, 01 Jul 2021 12:13:27 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB4381.eurprd04.prod.outlook.com (2603:10a6:803:6d::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.23; Thu, 1 Jul 2021 10:13:25 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::99d3:99cd:8adf:3eea]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::99d3:99cd:8adf:3eea%5]) with mapi id 15.20.4287.023; Thu, 1 Jul 2021 10:13:25 +0000 Received: from [10.156.60.236] (37.24.206.209) by PR3P191CA0003.EURP191.PROD.OUTLOOK.COM (2603:10a6:102:54::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4264.18 via Frontend Transport; Thu, 1 Jul 2021 10:13:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9fcd3858-5b16-4314-9be1-40ca547d3c6d DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1625134411; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JCunioa4EWZjq32fQIVqtUhOCPm1ECOwtCYNIITpjdM=; b=VzWSA3WLrDLvmvLy3Src2Y+MPH7GlY/Xmb+ESWsHr4W7Ui9OLTOzpwYBDc40Fpx8tuT5er brsMw6ttA+/4Oxrk0clxBJD1BaNqX3crQHiUCGTvKjiTeslNM8O0EOir+qAdeev/VbRv/m FnIRi80Nt5FsP6wV/OSE5gFFuzEUmt0= X-MC-Unique: F0waoWd6NVW-5zIx2J01vw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=h9ytCMHPYpi7BNJt6dukBjOsPTmGUL+qSrRSGOZ4ThlwYz4TjIbazNNEnKYaW+NO8A1qoY4+95gLRkNKgMbhWlLMHxT4RGuKPvZSvUbz1cfQ0yO3+D6CxmIRjtMRlShTayjpgdYFu9utMPobnMgmqda6FcCqV2ypN8fm1neJvHMnQbD1bgdhVR9exrop3zYl3XA8/jS3FaoCkffkIkm0P90qub+n7qPJTa7ejwsEL8vPif7t9+Uzvq344fk7ceRWlLgXudhAopO+Jt9pbxOJDCQjPXgU1yD1dOllXkWctbqx07sZifDDdBLwPfVOkdbUVp0nOnQOWeCXVZ1dlA0mAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JCunioa4EWZjq32fQIVqtUhOCPm1ECOwtCYNIITpjdM=; b=K2TDbsRv91wKJQmTHUEPBTujtMGoDy6Ge+jKHiw5koZfiLTkX409ALE386wOkapLzVNPkh/GI4OV5JReN5csQLANhKNvjWSj+KZH3dmmFdA+QZ4R0YVr1dcEc4AEbYmHbjs+evYR5UHVr/tgAvKD1x71MH+UU2t1WuBXgejIzKEennZs2obG5yvuJOUhx8bWEx/9TXTy/rOclOfj5FhSUsqksb414WBDbnDOOuu8ytxwMXDFOOqVh3wqXyN6kWlFB2OFf8EuLyVk0bq1IKGIIPD1oW4bUqDAHqIRE6yi0SnQ2uIrIUCyu4kQJyaylbuWQZCiUIeauRvSWQZsAjJPjw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=suse.com; Subject: Re: [PATCH 5/9] xen: introduce assign_pages_nr To: Julien Grall Cc: Bertrand.Marquis@arm.com, Wei.Chen@arm.com, xen-devel@lists.xenproject.org, sstabellini@kernel.org, Penny Zheng References: <20210607024318.3988467-1-penny.zheng@arm.com> <20210607024318.3988467-6-penny.zheng@arm.com> <41a7389b-630c-6cf4-fa28-7d80cb79176b@suse.com> From: Jan Beulich Message-ID: Date: Thu, 1 Jul 2021 12:13:24 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [37.24.206.209] X-ClientProxiedBy: PR3P191CA0003.EURP191.PROD.OUTLOOK.COM (2603:10a6:102:54::8) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5a98f9be-f3f5-41ca-fd4a-08d93c78dcec X-MS-TrafficTypeDiagnostic: VI1PR04MB4381: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jjKTi1diZH3eUNBZIioFIzZdsmm2tuv3OXmgAzojGohzv47EmMVLm9kkrWHMaSny7RXnOgpjNd4hxswO71PT/WFY9M0idEC3COAruvi6XPUvmKHtrTp4AP6hMGbrFaAZBsYDP3o5oXel5b86QF5EF4j+oDENjUy3zkROdhl9Fgmqehnqp8Swz8K5nJbOGY834muaTAdfQJwHIEMtFc5KZ8sK0TY9Qv+gUqml0/QCijFpRgWN7eRCC5o9nad5NqvxtdtaO2yvvF9w6IOy3gcOm3/cwRAmYQWMjBlRS1xLSKesP6kHgltTvRvVFQjQQu5fgj4YSYYRhhLrvJAYzZQ4KibMMQ+DJEMiW9xMKZOWEE/zUqFTDRuvNa0dVtIeFblk2aOTEN2qf7OhdoG0ekPMkzW4KuaIJwp0bW10ssAOWANMmjsZ+FEZpoM0Ew9nQG7IoFdbIrXf4GEkzWmMUO6irxB6hIGmtzV4TtDFOh5HYVcHqeAiDKvc7ZeF0PrIjxAdglWqp2ozWL2xTW7jbCQmnqYYDnRBWS3T6iesr4Di+pjLr568zE69BjOmfdJ1uIyu/a6m9MOrVBTDtn5/zuod0cvm4fYMvLjy7wzv7p+yKid/6mZAOeNkhi3f5oNEcCNT6MiY31As8DuwNys/UjZt17zKysq+DK5LTq/XfqY4pJeZXuJLcFhmi8dx9HJm42HF/K2Gl7e0fAfswH5ypI27NTt6UEtQ1uJoX7OJxkzreow= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(136003)(396003)(366004)(39850400004)(346002)(376002)(956004)(5660300002)(86362001)(2616005)(8936002)(6486002)(31696002)(53546011)(6916009)(66946007)(478600001)(83380400001)(38100700002)(26005)(8676002)(66556008)(66476007)(31686004)(186003)(36756003)(316002)(2906002)(16526019)(16576012)(4326008)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QzR5UWE1VzdOd0k1ZDFzbU9vRlh5UEhjdFBpU1NTUUNNNmpSUTlzcjJJeEcz?= =?utf-8?B?K3ZDRElqYzg4RUVnbDFiMnMyS29kR0dEZEV4Zzk4REJWcmVtd0lTaS9nOVA0?= =?utf-8?B?S2tOd2RzN3RmTUtpUWUvWTRFTjhOMmRpTExkeEgzYXY3S21RWGFwOUVlUWdu?= =?utf-8?B?eFZueUF0UnpKVVhaMWE1bHlFMUZLd2lURno0anNtT29NN05iSk5PVktjditP?= =?utf-8?B?dWlSKzR4R01zaEZnL0U2dXMzZ29KZHRJVUlsdmpYU1dHaGwzb1ZZbWpzYkx3?= =?utf-8?B?Ni9CVTFSdDdQSjl6aHArSU02a3lkWUEwaStKQTRFSEVoQVZtUUxMeUlhbStw?= =?utf-8?B?bmVpVDZzSUUyU0JiK0xJekttcHlaYldyZ25scXNERldQZW9HRXFObHJPUVpZ?= =?utf-8?B?bHExN2FoMG5oTVE2enBQbXg3YnpvcFlyZ0UybTJhdS9lTEVOblBsNVVzemps?= =?utf-8?B?eHNUZENtQVdiK3hlYmRFUWd0cWlEcmhwcElhK0JTRjZlWW95b011amE2dUpF?= =?utf-8?B?MDF5ZllteTdGcEJWWjBwZFYxMU5OWXJNNFlpdDNMSG81eWxkNXQxZlg1TU9y?= =?utf-8?B?dXowVmlxQ3daS0dsWXV2bnFMQURodzZaVlhtV3hsUXlxKzNUcmRadW1ncmxP?= =?utf-8?B?NlBxSXY3Z1NSV1JyUTZ4cFphNStDczVYL1FqY2tuanIrWnZOVk5WTHBPM1dO?= =?utf-8?B?Uk8zOHE0SlUxWjVjNXozeStIM09OczJZZERHQmtxa1Q4ckI4QlEzUW1PTTNl?= =?utf-8?B?RWZoZENFS3NPaGNTTFRxOTVjRFNVcXBUTlhIVWRFeEpnTXU4UWcwZ0xVYUpu?= =?utf-8?B?eGNTdzY1STNrK0tHdytqaTZjTDVnNWMvcnhGMzJtUkNCeHlEN2dHcUliWTE0?= =?utf-8?B?bVJ1RmkyUEU5aytzTW5vYTkzMzZpRlp5bzZiVnBiM0dGUEptOFA3dWlzb1VD?= =?utf-8?B?enZYVVlkU0JiOThRWlFONEZQc3BHTkVZa2lwTlhMV2NVYWdZY2xBWENsS2xR?= =?utf-8?B?d0twSFp3bXNrZUVBUjlCMTFTNjZVNjNJZzBXTTBSaW9YemttVFNJaUcwNWts?= =?utf-8?B?SENiblo3d1g0eTVRMXZLYU1oekkwWXpzbDdSTkJabjhjRWJhVU12Zmoza0po?= =?utf-8?B?SlZKZW0rRUovUDRYV2o4YmZpNTRWWmdJeVhvUW1mZS9kZFpYRXJNbFdpZXJX?= =?utf-8?B?cDdJd3IxT0tKRWFOWHZmdEdISEtyM0xpQ2xRWTF6UGZoUDBiWTZ4ZVdZbFFi?= =?utf-8?B?Wk1hVnBaYWpmcG9ZUWp0ZUkvT1ZiOEZUNHd6T25GNE0vL0FHaXQ2RFhvbkQw?= =?utf-8?B?Mkd6RXVwVVd1Q0RJa2tEVkt3Q0Z2Uit6aDJTUHd2eUN4UXlGSDVqNVJjRDRk?= =?utf-8?B?eDJ2OXRDb3l0bWFLYzFDbGJ6MVo4Qk9HSDl5YkNjbkt3aXpwcUpVV0lFVklB?= =?utf-8?B?NFRMWGhCanNGQXdjaUZ6ME5SaWRBVlpqZHBCemtzVjRXc1BwWUJISGpLUnkv?= =?utf-8?B?SlQ4cW9YSEpTMUJCbE55SUhJeHRvcEJJWlF6bFpvWEMwbS9VVFlqQ3g5RHdX?= =?utf-8?B?KzNhd01udXBLSkRpaVh5K3p6ZHVQMkgvK3ZsaDhTMWhoRlVWdWZvbGcybzhH?= =?utf-8?B?ckFwSDhGc1RzZk54dUJxSXlxRHorRWZWOWQ3eG1jRWd4R0xKNFVJcWFsV20r?= =?utf-8?B?VVMxbkh3a1hYZndPcVlINjBJUWRVeGRMN3htT2JCVzFzNnI4L3FFSWp6ZHpE?= =?utf-8?Q?W36ULVnyOGoOnrEhO+Ca4qIht5hCcq+SNVY9HLQ?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5a98f9be-f3f5-41ca-fd4a-08d93c78dcec X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jul 2021 10:13:25.2195 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7mFr0k7tdkUes3HWt21wlYxwNLxXGNbkH0VS3hjvyV7VGzN/kClro73ewJhSZgrETFRX3vE+dzc/xxTLSJL11Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4381 On 01.07.2021 11:24, Julien Grall wrote: > On 01/07/2021 09:26, Jan Beulich wrote: >> On 30.06.2021 20:29, Julien Grall wrote: >>> On 10/06/2021 10:49, Jan Beulich wrote: >>>> On 07.06.2021 04:43, Penny Zheng wrote: >>>>> Introduce new interface assign_pages_nr to deal with when page number is >>>>> not in a power-of-two, which will save the trouble each time user needs >>>>> to split the size in a power of 2 to use assign_pages. >>>> >>>> First of all I still don't see why in this one special case it is a >>>> meaningful burden to do the count-to-order conversion in the caller you >>>> mean to add, >>> >>> This sort of works for one caller. However, I would expect some more >>> user in the future (we use it for Live-Update). >>> >>>> and hence why we really need this new function (to keep it >>>> simple, you could even have the caller not break down to arbitrary >>>> power-of-2 chunks, but simply iterate over all individual [order-0] >>>> pages). >>> >>> The function assign_pages() will always use 1U << order (and sadly 1 << >>> order). So we would end up to convert the count in multiple order for >>> then directly converting back to a number. To me, this sounds rather >>> pointless... >>> >>> There are also a slight benefits to call assign_pages() a single time >>> during boot because it will reduce the number of time we need to >>> lock/unlock d->page_alloc_lock. >> >> Well, all of this is why I did add ... >> >>>> The more that I'm not happy with the chosen name, despite it >>>> having been suggested during v1 review. _If_ we needed two functions, >>>> imo they ought to be named assign_page() (dealing with a single page of >>>> the given order) and assign_pages(). Backporting confusion could be >>>> helped by altering the order of parameters, such that the compiler >>>> would point out that adjustments at call sites are needed. >> >> ... this. > > Oh, it wasn't entirely clear whether you were objecting of offering the > possibility to pass a number of pages rather than an order. Easily understood: I indeed we trying to express my preference to stick to what we have, but trying to suggest a variant that I think I could live with. Jan From xen-devel-bounces@lists.xenproject.org Thu Jul 01 10:31:10 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 10:31:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148603.274606 (Exim 4.92) (envelope-from ) id 1lytyK-0000LR-Uv; Thu, 01 Jul 2021 10:31:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148603.274606; Thu, 01 Jul 2021 10:31:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lytyK-0000LK-RQ; Thu, 01 Jul 2021 10:31:04 +0000 Received: by outflank-mailman (input) for mailman id 148603; Thu, 01 Jul 2021 10:31:03 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lytyJ-0000LE-72 for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 10:31:03 +0000 Received: from mo4-p04-ob.smtp.rzone.de (unknown [85.215.255.120]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 113a42b9-ebec-470d-bd68-3ad1e2e5905c; Thu, 01 Jul 2021 10:31:01 +0000 (UTC) Received: from sender by smtp.strato.de (RZmta 47.28.1 AUTH) with ESMTPSA id 30791cx61AUo5ih (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Thu, 1 Jul 2021 12:30:50 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 113a42b9-ebec-470d-bd68-3ad1e2e5905c DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1625135451; s=strato-dkim-0002; d=aepfle.de; h=Message-Id:Date:Subject:Cc:To:From:Cc:Date:From:Subject:Sender; bh=Y/umBz55iRwFQy474jplT7NWH63BSvriXmAsJ0ambaI=; b=QzRhUIRiFIqv4idpt40UEApO3wutsIy7YRQVAentS+hsL8Q5twDr5JWtMRU9/9NOCV YbPh/E88DAcxEX0dMRu1ZsAIEZ0xWVbINPtXhUw1M8Y48/zU0xWM3gdEUaFHG7LV0JOG Luyr//yX04nTWjvlP/WtaSbVLb9gvRcK4lvWUv2hf1ZHErHAuLpni3atR2AvcoGopnFW +QeUSRrdUElcbHQYv6lDqMxnk+Ekj9JxFETjFbBaDZguLgzb3QRm54QOhzwDIql62x2O Zeq5tI+TcCyCOcgx1bpx7DyHmdzuJ5yF740b3fSFPl3z12GbgrLpOLVw+32LjhXmntvv PkFw== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QXkBR9MXjAuzpIG0mv9coXAg5lqlz7EsstGyDcxK3Mbajr+SQKopp1Cb0CyyaZQQ==" X-RZG-CLASS-ID: mo00 From: Olaf Hering To: xen-devel@lists.xenproject.org Cc: Olaf Hering , Ian Jackson , Wei Liu , Anthony PERARD , Juergen Gross Subject: [PATCH v1] tools: fix comment typo in libxl__cpuid_legacy Date: Thu, 1 Jul 2021 12:30:48 +0200 Message-Id: <20210701103048.971-1-olaf@aepfle.de> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Replace emualted with emulated. Signed-off-by: Olaf Hering --- tools/libs/light/libxl_cpuid.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/libs/light/libxl_cpuid.c b/tools/libs/light/libxl_cpuid.c index eb6feaa96d..b2c673841a 100644 --- a/tools/libs/light/libxl_cpuid.c +++ b/tools/libs/light/libxl_cpuid.c @@ -465,7 +465,7 @@ int libxl__cpuid_legacy(libxl_ctx *ctx, uint32_t domid, bool restore, * isn't going to migrate, then the current hardware is all that matters. * * Alternatively, an internal property of vTSC is that the values read are - * invariant. Advertise ITSC when we know the domain will have emualted + * invariant. Advertise ITSC when we know the domain will have emulated * TSC everywhere it goes. */ itsc = (libxl_defbool_val(info->disable_migrate) || From xen-devel-bounces@lists.xenproject.org Thu Jul 01 10:37:34 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 10:37:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148608.274617 (Exim 4.92) (envelope-from ) id 1lyu4Y-000193-Mi; Thu, 01 Jul 2021 10:37:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148608.274617; Thu, 01 Jul 2021 10:37:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyu4Y-00018w-Ig; Thu, 01 Jul 2021 10:37:30 +0000 Received: by outflank-mailman (input) for mailman id 148608; Thu, 01 Jul 2021 10:37:29 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyu4X-00018q-5w for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 10:37:29 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 822fb6e9-e771-4340-bc09-db7355af4b2c; Thu, 01 Jul 2021 10:37:28 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 822fb6e9-e771-4340-bc09-db7355af4b2c DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1625135847; h=subject:to:cc:references:from:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=WSCKT4OxFnyTL2XKksw+AQ3g+XGkrMfygXLYy+0V/Hg=; b=SWmG7SNpNvnS37iCYCvtfddWrEdlYlg7mXE0IRMdWPL+PpZJ9mvk2WOu KL1IqpxkXzSnabSYgTcNbXJq0VU5U3otmDe6mGifpT2Ax0edbzC5liJQW hZ39+UfNWrLtXDtNLtGJUAmuiJR5RiQTf6JM5jw+6dxhwnlMlbTNt1hN6 0=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: kH4uyMaTgITXJB/Q66akr59F0sAN4W4KT+idpgkEgvZbLUizONMRudOyTSCCp0htWucfSva+gr a8l1XE009Ndffr7A7icfTCE/nj2tEpckrvm4C3bJV/MjqTD8xkJZIJOKJQjORKSpY311u+PDos 2lbiVD7EI4UaPow0aZz3oH178oeCWkZdFn4hMVZP/k0cZ7FG8R6I+7xqv3x5l0Re3AT4i7CAxE /ctWOrroUo1wTTPk0NWLicKzkwAGjv6UCc7Yto6VTdU3epE2WQqJAPg8UkwKo8EU7V7lH5Iat8 Ons= X-SBRS: 5.1 X-MesageID: 47075608 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:DWI9SqpUDqWpGsZbaBHjvE4aV5vJL9V00zEX/kB9WHVpm5Oj+P xGzc526farslsssREb+OxpOMG7MBfhHO1OkPYs1NCZLXXbUQqTXfxfBO7ZrQEIdBeOjtK1uZ 0QFZSWTeeAd2SS7vyKkzVQcexQueVvmZrA7Yy1rwYPPHRXguNbnmBE426gYz1LrWJ9dPgE/f Snl696TnabCA8qhpPRPAh1YwGPnayFqLvWJTo9QzI34giHij2lrJb8Dhijxx8bFxdC260r/2 TpmxHwovzLiYD79jbsk0voq7hGktrozdVOQOSKl8guMz3pziKlfp5oVbGutC085Muv9FEput /RpApIBbU811rhOkWO5Tf90Qjp1zgjr1X4z0WDvHflqcvlABonFston+tiA1nkwntlmOs5/L NA3mqfuZYSJwjHhj7B69/BUAwvvlaooEAljfUYgxVkIMgjgYdq3MgiFX5uYdA99HqQ0vFgLA AuNrCd2B9uSyLeU5iD1VMfmeBFNx8Ib2W7qktrgL3e79EZpgEg86O0rPZv10voz6hNPKWs0d 60eZiApIs+OvP+UpgNctvpYfHHR1AlEii8fF57HzzcZek60iX22uDKCfMOlbqXRKA= X-IronPort-AV: E=Sophos;i="5.83,313,1616472000"; d="scan'208";a="47075608" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=a1QY/Bs03C3Re4fmkQogDI7qvPqug9oNl/aFQ4mXt1QY4HaNnboCyyWIpDYZHEmOn2slsuObchK/aQ8/EcD/vHaqIDKpMs4tc1XEOfVMN5CNVoHVE+iS2U2MTlB9UtqMy98f0WaS+RDr/Ui7MuXD9YsuiJJQQ5gis/AjRXUKI9x4kZ+pFbQS2nBDM95RM5P5S+p6U+tIEGLlVdz/NoORor+cY5kG5vHXjCjgP4G9APy9M3Sw7gb+n5DlneqBZ75DMplv7T69oSfEwAP8/lIS8R0X4l8QjuwnNvjHThGGazu29b3pNTp6IT3/i1kpCOH6jF117BC0f4gL1Hrs0miHug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WSCKT4OxFnyTL2XKksw+AQ3g+XGkrMfygXLYy+0V/Hg=; b=QONwnpLk55o5W/Cxl4KqG3mI16XlPq+cZAqAwy0pq+pg5ev21Pnzl6/jR/2RLRn9YPSFqoozOS5UBmuAqmUIXpzEDYYqBl8nmDPISH77dL7aEr0IKAsMHvHGAGYHLd3ZQFCajrskYH1GnwvfR7m9/vWn2KFvv9w2FPw38QZ4ymHpppzfZ0OMIsixxzL5w+H6fp1QUqQ0Jqb4FSmcImj+AGsX/6yBKG01p6027efz7rlqZygbzgom2WY8BdkNRx3TNsJ530JpuuVF/DDIEvHrqVj3jag4hCX8JqGbjrBkMwd/o+qHRw1qLVzi6PjvRnnOHjRuScMMaThDbBzp54rFtQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WSCKT4OxFnyTL2XKksw+AQ3g+XGkrMfygXLYy+0V/Hg=; b=TbhqcEv/hbP4m3vIMyiOAeTgTJ1QPsYDLPGLvtgB4cc3k0wjxWozXqII1injOJCAFPulIE+7ZpwIJ08VimuNS72RRaCiMLRQrb3EuVvUUxmgFYfOZPO08PRdHa8bOzq2SbHOZ93pBw+nB0r94fTQRSXYygh4IZvu/yxyfMkWSbw= Subject: Re: [PATCH v1] tools: fix comment typo in libxl__cpuid_legacy To: Olaf Hering , CC: Ian Jackson , Wei Liu , Anthony PERARD , Juergen Gross References: <20210701103048.971-1-olaf@aepfle.de> From: Andrew Cooper Message-ID: Date: Thu, 1 Jul 2021 11:37:10 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 In-Reply-To: <20210701103048.971-1-olaf@aepfle.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-GB X-ClientProxiedBy: LO2P265CA0223.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:b::19) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2697696b-9d7f-4cd5-2189-08d93c7c32ab X-MS-TrafficTypeDiagnostic: SJ0PR03MB5648: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:400; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: geMAGgO56xMb+rDh4PbuWwH2VD5//WBGT09ARHFKGmjnlNwEILt56KdY1Zwa2XY+XDL2dWg3/LTPta8wSPLPfI0B7inkn9giNwkQVgG7jH7z9U38yJX5lKYQAimpgr+f7uEb3C9tzTtNjNL1EXXf89DOefERFHfz5kP9kw0iiVO0DwK1RgU47IvfHwNc+itwP0QrDIkNnbs+J5PTUn60lbJNTfNlCY4JutRiSZLTwtagpcAu6ZzFww0w4j50HN+0Qy0vSWRyYUokaZLgO34ZhzVol+gzy9O41/bOL3RtUSmu7obRyy4C2gQQthBJT1NGRpM7vYRbhnT1u1aVTbL1760M6vmXAPhATnngI6upZQ0q1xxH9b7fDETWgr5Ya6rj/lRPshnD7zMDrICUwdicgAbTODJSOLuf6GTIl0/X7uabGZ7p6GxArUwOVBfPjFAuVmRTSw9L/OHFaexgIhsoPJnMquNcrxPgO8RIijIfvdgBPX8WPkYJJiq0dtPwFgq5plpejdQcXMdHBoirJJ1rcXx4P8DUrMFMTbGClNZFqQ6c+lVANWHrSqk94rN6QmgN0JgbNYkxbo1RfIDB5xmEZg5gqWaN5DLwYQxISTnKuez4WmYkDD55Y/jmBjWvvo0xqwInrbxunHYmxOY1eWHIqrf2JGXWp8j3gQIvFDB8LiPJIW5wnS24jb8JTF0Ygss2i4vBFitTkXiIX5sIPBnSmeBQr+faR0q+LUwxcT0mzOPzBIzui642RGhO/ykr9GOMFPSCVLFOBUHTZC3BEjuzkw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(396003)(376002)(366004)(39850400004)(346002)(5660300002)(86362001)(186003)(31686004)(16526019)(53546011)(31696002)(2906002)(8936002)(558084003)(6486002)(8676002)(478600001)(38100700002)(66946007)(2616005)(66476007)(66556008)(956004)(16576012)(26005)(36756003)(4326008)(6666004)(316002)(54906003)(101420200003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q2hXVU0xRjZveVJERUpqeDUySnVnbmZJMDQ2czJ2WjdLVFZid1Y5WUhDUnk2?= =?utf-8?B?QVlPc1VTZi8ya3AxZ1YwdlBDM1pHaWJOM1A3MDVsSkg2eWEvUExWa2E2UVpY?= =?utf-8?B?UG5rMXIzQU1KTHF0N1cwNExkSWNqUU56TmhMK1gvMTZNNnJWN05kaUlxcXYv?= =?utf-8?B?SHpJZ05PN21XRSsxS1BHQ1BSMFIwcUFHekxJZDZja0ZOZUI0ZVcrSXZuOG9B?= =?utf-8?B?N3FTK0FJYys0YUxoQndzcFlGUVJMWFJxSzIvdDRDNllraFlEL2hOVU1PdEZH?= =?utf-8?B?RmI3OHRSQ2s4M3d3a3UyR2tFaFBkNGd6Tk5qVHc0cWF0WlBlM1ZYci9iRkky?= =?utf-8?B?TTEvNXdTdzE2OVgzMHVSYUtHZElCMUlCL3NIbi9zNzNlcnRZV2ZYVDJXbmts?= =?utf-8?B?MG0wQnY2dXBtUlBFVmpRK05ZclU1SFd2UHdjSWZ2SUMzRTdaSDU1NEVIaEUx?= =?utf-8?B?ME9VRWhNdU1JZnh4VTB2QSt5bVhzTzZLMzl3R2MwRFpzN1A1QnlXMTFkUWZB?= =?utf-8?B?U2tZSi9DQS92bTJZQmc2d3ZpcWlySXJIQWlmQ0IvekFxdEJKQW5Gdk9XNnda?= =?utf-8?B?enlwV2p1MGhVRFRwbTNkM2ZGeDg3NVVlZ0o2T0FSM1dJWFp1S3ZGcHFmQ2oy?= =?utf-8?B?K0ZycVlXano3NGlsaXE4dXdRN0E3ZmtXZWp2NTN1eEtQaWFZUUdIUzhxUTVj?= =?utf-8?B?Yk1hdm9XY1YvNmlVV05zMkRQdEpnZ1oxd3R4TWQ5WXFkVDhtakYzckh3WUtG?= =?utf-8?B?VFEzaHNZU0xpQjVtTUVHMTJHMzFiS2xkMHFWZ1E4SURmdkFFRDFNRytmNENw?= =?utf-8?B?Y0kxRXNDS3FxeEJ1UlRuc1lBbGNzSGhnZHUxZW1YWDIvWjhpYUFEMytZSEFh?= =?utf-8?B?eXNDRUZIWjM4bnYxdStybGFwNGoyOUxpYWZrYlBhTXhsdEwraHl2THVCK095?= =?utf-8?B?NDVsOXBmallnYjdMZzRFVklnK2FDTm1ZU1BFK1daWkxBbmpEcmJLREFLN1ds?= =?utf-8?B?c1Q0NllyZHVRcjhqdzA1REJhSjFlWFVSSlFuNVllUFE2MHVUdXEyS3dSZWpK?= =?utf-8?B?UVE0Q3NYTFJaWkVSemlMR1M4ZHMySFovVkZVYUF3OXNFeGpJTGhLVzFLOEhH?= =?utf-8?B?S3M5MjArVERPTEVwaWg5RHN4ejRDUUdndEQ4ZTdEKzhyclVmN1ZnelJZeGw3?= =?utf-8?B?RnRrdjJaNTRXbHYvVEl2MW91K0IydEcvQ2ozekRXd3ZVVVV1N1hlVWxPYXM1?= =?utf-8?B?WlpRMUpWTEsrS3BFNnJoRldvRkl1dEFlSmJlZloyT1FWWjY4alFJTTNXcFUy?= =?utf-8?B?bnowbU1obWhqMGVsbStSQStCdU84QW5ITjdJUnpoS0JxZ3hVaExjMzhLQXRk?= =?utf-8?B?YVU4ZUdHekQ0dkt2U01IMGovZDNnUktJVWVKd0QvZGJOYjJmVUtLMG03Y0xT?= =?utf-8?B?Rks4RDEyZmJLblhPUHg5aFVXdkVtU2hBSW1lMFBqN3lmUTNRTG1VaC9mRG53?= =?utf-8?B?VmhCQmxJUjRWWkl5TlEzeEMwakNRZVoyZjMwZmR4UUFvbStoVmJTV1Nudm5R?= =?utf-8?B?NllDbXFOZEtLOUgwQ0lzUFdIM2UrZFRvS3BIZWNlblJMc1g2OE11R1VOVFEz?= =?utf-8?B?MnVEdjV0V01SS2toMTdpMEVDTlBJYVZaQVV2TFJ0SklWZ21WTmk5ck5RVmtK?= =?utf-8?B?NWFpRVZmUXl2NVAralJpaGQwQjhhd2NMcnlHY044aGhCS1FjVzFOZzV6YlBq?= =?utf-8?Q?Z/yEli98FUlj5rmciuAODS3Byn7A/okgYisGkgI?= X-MS-Exchange-CrossTenant-Network-Message-Id: 2697696b-9d7f-4cd5-2189-08d93c7c32ab X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jul 2021 10:37:17.5192 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vktocXS2LQAYFPcIbcmV/1YvpmYkRO0tJ/P+9X/OOaC8ysVc86WDOg0m5BiQZQxhYdYixXHEwRr0lV6OJOYhhXpnsIkSl0KTNAf1KzRW+Ws= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5648 X-OriginatorOrg: citrix.com On 01/07/2021 11:30, Olaf Hering wrote: > Replace emualted with emulated. > > Signed-off-by: Olaf Hering Acked-by: Andrew Cooper From xen-devel-bounces@lists.xenproject.org Thu Jul 01 10:39:15 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 10:39:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148612.274627 (Exim 4.92) (envelope-from ) id 1lyu6F-0001k9-1h; Thu, 01 Jul 2021 10:39:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148612.274627; Thu, 01 Jul 2021 10:39:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyu6E-0001k2-Un; Thu, 01 Jul 2021 10:39:14 +0000 Received: by outflank-mailman (input) for mailman id 148612; Thu, 01 Jul 2021 10:39:13 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyu6D-0001jw-IL for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 10:39:13 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id a7fa66ee-63d5-46cb-a6c1-0a4362cdce9d; Thu, 01 Jul 2021 10:39:11 +0000 (UTC) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05lp2110.outbound.protection.outlook.com [104.47.17.110]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-23-n8oveD0ROeKPuBcTvYZ7xg-1; Thu, 01 Jul 2021 12:39:09 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB5599.eurprd04.prod.outlook.com (2603:10a6:803:de::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.23; Thu, 1 Jul 2021 10:39:07 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::99d3:99cd:8adf:3eea]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::99d3:99cd:8adf:3eea%5]) with mapi id 15.20.4287.023; Thu, 1 Jul 2021 10:39:07 +0000 Received: from [10.156.60.236] (37.24.206.209) by AM3PR05CA0117.eurprd05.prod.outlook.com (2603:10a6:207:2::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.23 via Frontend Transport; Thu, 1 Jul 2021 10:39:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a7fa66ee-63d5-46cb-a6c1-0a4362cdce9d DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1625135950; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=b0xtOFMSUTTAQEmkk1wxyYJrt+czH7YUmCcT1A65bl0=; b=XtPw6nwZixxZNpDrjNDVIxhboZXNpBwyJCyK7767U3Kb01nr8tnJOPVvmaIm0dzpUK3JRI h+x430LSTCa3AKWzLrTSmQLDrR3PrsTwnb7hTAiKum6Pm1ueSsIfWpFuELNwn88QHJLjj+ nF46Lff2+LI7VkA/WWeTvnFl2k9rAYs= X-MC-Unique: n8oveD0ROeKPuBcTvYZ7xg-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mNZkTjo0MY2ruxaD+3erLgT7+G3Ew0Kor0OjbuqI5SZ7HdkCJ6X+kpqCue+99GOO/11CgVPCiErX9ZE478yJesA+n+LVmP7WRjX1L1gXulvD0dADo9yUAAxSIHXjT08Na3HrfdIBqTBOArSk2S8L3AVZAcBXCKGhw4CF6QDPqPD+MEE60+CfdxPO4SwWuV8az/I05b4GQ2XorWPqGPVMYEwd44DeaoB0i0VjRmNMFd6AFYv+DbAbKjC05udVRV1rFgixPPo4VqF639BHmaHc2vqm571ClxVOeRIAb7aEFyC2jTdI6KjqZj8GIdOsdL30z86Fuy8MTO8212cMTl4pXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=b0xtOFMSUTTAQEmkk1wxyYJrt+czH7YUmCcT1A65bl0=; b=UqbT22COKc+pYZJOP0m6HrZZegXz8ZOJ6+VHdsQdtrNx48BItCpojTy1DP893zCyqRvE0JbHzqshAmuPqy85c9bHkO3bmLuGio9EM9Y2iwu7Era9sb1vnuJG8VyBZWYh9MNKfXzXwT+0QsCru6q70C3iizmPUibuzGEtBRxsIy6CSs1SWWnSPfP0qPK7n1O6t9D8auCsUBI068bP5fYoEiHh2cUsxXVrTSf1fn3JLTOVVMgNMnsMXsGzS19RwbOIjeOWj3gPZCqfDBqzqwwu1XxzZZpaaGuSBnn4OVFwJlHd7qNNUBDs91wOIliq8zNPRwU2RhzKyRXz17WY9mB96w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com; Subject: Re: [PATCH v20210701 08/40] MAINTAINERS: add myself as saverestore maintainer To: Olaf Hering Cc: Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20210701095635.15648-1-olaf@aepfle.de> <20210701095635.15648-9-olaf@aepfle.de> From: Jan Beulich Message-ID: <13a963c1-639f-5135-734b-9cc1c8d9034e@suse.com> Date: Thu, 1 Jul 2021 12:39:06 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 In-Reply-To: <20210701095635.15648-9-olaf@aepfle.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [37.24.206.209] X-ClientProxiedBy: AM3PR05CA0117.eurprd05.prod.outlook.com (2603:10a6:207:2::19) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 981d1cc9-293d-4264-dbd7-08d93c7c7417 X-MS-TrafficTypeDiagnostic: VI1PR04MB5599: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Y+/CU+GgGyuzU5w8K515II4xYotgvSuXGuLGeG52Zu4WPau6QF44c94bfBdZfN8OBZy+0eWyNkoEnA4fKAZmuTBt4x+yw8Edyhc+p9E7eQMEgQZjbZizJBStIpGpcuLcQTuxvc5nIGWSu21LDQrLiny8KjKd/LIU7BUI3V0znzlnRQXL7ceyX5GvMjWsJkWtqpqi7135doWRl9dSQoInv51OSejL/1GLPJMYukZX6IchCSV2lDYtUDOETPbUAcMIAzj7EXKaO4zqKJoglvAsNPMB4ZprTt9qXBVLKQdogrbzoHX4FU8A6AL/Ox/zxppvPEHrivYD3sZMcdwARs8tKLlW4wvCSMm5KcMkCE1eaYRF9CT2c2w9hidKjJHcVoId+sYM6YNpHi0P/ydJMBloHN+juZv8SKDjSvBswId5woTxWRFIRbAZCNaQeXhrgWiJWNbToB5Xo0QAQHFimplSrd0ZxNMgxjre4yshoOmVRTLG2zp8Y7OD6mKcJiREaMdWUUYU+AlAm8HDu6v8fpehRaqquzYQzJN2xITwfFceE0V+tMHjzRH7jQPGFHxxpd7IcFyrCWhu3c/tsYpYqUdD88imrLmBxHFkYCK3mHWnFg6I0rdJmBukdc1qb8iv47iPF1r8cz2CXGfITX+t/0BUA3Hn4Mfy08hydIf/SCo5eMG/vw4yb7JVq+vFCwyoeRmzx/t8k0m5k86lu6CxLesyDF2ezZf2gOYb/O7VO2vrB5u0H+FnTabWUTHm8ZV3kE2x X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(346002)(396003)(366004)(39860400002)(136003)(376002)(53546011)(4326008)(5660300002)(31696002)(36756003)(26005)(16576012)(86362001)(316002)(6916009)(54906003)(8676002)(478600001)(6486002)(8936002)(66476007)(2616005)(956004)(31686004)(83380400001)(186003)(16526019)(2906002)(38100700002)(66946007)(66556008)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dUhHTDFaUTRiMkhLeWZwTVVBdnl4UVlOYzR1ZWpHeDBhTTdsaG5UTGxXc3Zu?= =?utf-8?B?dlVkZFpuRkpreHdHSUxHa0dxS1ZwRm9yRk5GOHR5UTQwYU5jQWN0akNpSmc5?= =?utf-8?B?N05md0pUQ3gxTE5Jd1ZhL2l6RUxDY01OcWphT25pd2pvZTI5dnVGc2NiY09Z?= =?utf-8?B?TE9QVEpoNXpraDVUL3ZBNUxLOWdrNmNTUVd1THNaNS9Ic05WQjg5VklHWmNE?= =?utf-8?B?aEkwanVoWkdIVTgrQStmaGsyd0lRdnVmSGlmVHdxRUdDazBHUnBMUXV0ck1Z?= =?utf-8?B?YmtMYjJFN1ZOM1R5b2JUV1lzc0FNQm5FSzBlT0hHcXBqakpUcTE5Z25mNmVN?= =?utf-8?B?Y0QrMkhESmdBSXB4RnZGTEdvSVlqZ2ROdVpmdU1pSFJob0Mya3VmdXFUU0lX?= =?utf-8?B?a0xHWWt3dkJhZWh3Qk53aVg0WEVrNmFybXQyUmZEbG1obzZrWmdKTkhXcjNK?= =?utf-8?B?Vk9YaWhmNXZOR2xaYU1JVmcrcTRpYnZzeGZlaUJtUjNubC9nN0g4dFYzTnQ5?= =?utf-8?B?MGt0SEFKdWsxYlVDN2xCNUpHNHc2eUFma0lPQTlqZmxCUUtCRFRKRkU4Ylg1?= =?utf-8?B?eEI1SHZPamVTWFA5bWo4M090NFFQQkZEMGI5eEI5WDFMOGFSNnI5RXRnc2Nn?= =?utf-8?B?ZEl3RzlGMnRZcjlsWmcrL1hGT2ZKcnV1eUJ1S011dVBmOFlwTWhlSHBSbGtO?= =?utf-8?B?M01hSWZGTklCbi9iOVhDYzU4eXBIOVdyVXNXOHV6OFVqcVJBRE1vQjE1MFVD?= =?utf-8?B?NWdNZ25ac3krMkdIUmVnVTk3MmFsdFZSZWtuajc0SWoyZ3d1TUY0SmJCcnNB?= =?utf-8?B?SlU2emdmT3lGai8vZm5ZSk5BL1dkdTJ4TytURHFJVVBPWkpoRER3azVQMEpq?= =?utf-8?B?SjhXTWdYOVFzM00zaWpReWNqZzdjRnNjN1VOV2ZGZEdCQ3FFaEpyZVlNL09I?= =?utf-8?B?KzJLTmQ1eDU1VGdGdzM0UEtwUFVXQUtSbE5wanFDSFd2NjVJWXdOMGgzSG1n?= =?utf-8?B?QzVLdUI3N2tVbHpwTTFsMFp5V0syWE9TZXVnLzI1LzlqTVAyRUphT2tzZG05?= =?utf-8?B?MVVENXpPeHJOU3JjaU5DVU1QcXJ1YUIyMXA4bXNBRjZmSFVNN0VhdTdXUDYw?= =?utf-8?B?d3lsSkhGalY4R1psUlYxckxzdjZRSzlEcGREWitidFJzdFdNOU9rSzdqRUVt?= =?utf-8?B?MWJvcnBITkY0NkFpbHlVRE8velNHc0FJRjEzeEQyVWk1WU1teGUxSGJxV21s?= =?utf-8?B?RnBMMDlHRWdURzZrR0FrNTY0STFpNlhpaXdCbGtVVWRucXdNTFMyTmNROUhz?= =?utf-8?B?Y3p5RkNvYWdyNG1BTXlHYWFRUFpESjI2VGtpckFqZllzVXpZNC8wRkloaUFS?= =?utf-8?B?VUN4dUJhMXkvWGdFU09qQnBVY0o2dHp1bUhSR0dweHQ1QUt1SVkxVm14NXh1?= =?utf-8?B?ZXVYRGVKUXBvRks2bzJocVVQeDlzcjA5YUlWVjZzL0FidDdrbDhaUGJnS3VY?= =?utf-8?B?eThIQUJ0eGlJdFJJUU9uaXg1cU5jelF5bHh0K3U5b1FWZ1RtcG5OTVEwcFRC?= =?utf-8?B?S2FGRU9BQmtRVTIvalEyUFZPR2hGVmduSy9wekpYclJaQ2pSdTRkWVhsOWg3?= =?utf-8?B?OUVGVUtSdkNhT3phTVZjRVRqUWd2YUhBVWMvVmcyU01lbE9raGhpd3k3dkZ0?= =?utf-8?B?SEpzS2ZWM1J6K2V3SDN1RFRUbzZsWVBmbi8veTdlSmhGYTdrQlZFU3pkeWVk?= =?utf-8?Q?6yyau3qIOP5vLs1NYt6rS2jqkyGpObDfNgF709o?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 981d1cc9-293d-4264-dbd7-08d93c7c7417 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jul 2021 10:39:07.2207 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: KqMCRx/av09Rv2Z61n9kfvyYoBQw5pGnL7ixf+HRXtJ3pwtwq/eUfZNz9ZZKpBbH6w57KpsgFvAN2UrmU4YAkQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5599 On 01.07.2021 11:56, Olaf Hering wrote: > I touched it last. For my taste, this is too little as a justification. > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -381,6 +381,12 @@ R: Juergen Gross > S: Supported > F: tools/libs/ > > +LIBSAVERESTORE: Nit: DYM LIBXENSAVERESTORE (and hence for the new entry to be below LIBXENLIGHT)? > +M: Olaf Hering > +S: Supported > +F: tools/include/xensaverestore.h > +F: tools/libs/saverestore/ I'm afraid this goes too far: This way you remove all prior (direct) maintainers (see "The meaning of nesting" in ./MAINTAINERS). And I'm sure Andrew, who has written much of this, ought to be considered to become the maintainer of this code then as well. Personally I think you may want to take a smaller step first and insert yourself as reviewer for this library. See e.g. what we had done a while back for "VM EVENT, MEM ACCESS and MONITOR" when new maintainers had been proposed. I may not have a sufficiently good picture of reviews you've done in the past for this part of the tree, so I'm sorry if I'm missing significant work you've done there, but surely my recent series fixing code in this area could have been a good opportunity to actually do a full round of review, when you have the intention expressed here. Jan > LIBXENLIGHT > M: Ian Jackson > M: Wei Liu > From xen-devel-bounces@lists.xenproject.org Thu Jul 01 10:56:53 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 10:56:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148619.274639 (Exim 4.92) (envelope-from ) id 1lyuN1-0004E6-MX; Thu, 01 Jul 2021 10:56:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148619.274639; Thu, 01 Jul 2021 10:56:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyuN1-0004Dz-JZ; Thu, 01 Jul 2021 10:56:35 +0000 Received: by outflank-mailman (input) for mailman id 148619; Thu, 01 Jul 2021 10:56:34 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyuMz-0004Dt-Q9 for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 10:56:34 +0000 Received: from mo4-p00-ob.smtp.rzone.de (unknown [85.215.255.24]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 3e62e775-6d61-48c8-baee-50645f63130d; Thu, 01 Jul 2021 10:56:32 +0000 (UTC) Received: from sender by smtp.strato.de (RZmta 47.28.1 AUTH) with ESMTPSA id 30791cx61AuU5sD (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate) for ; Thu, 1 Jul 2021 12:56:30 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3e62e775-6d61-48c8-baee-50645f63130d DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1625136990; s=strato-dkim-0002; d=aepfle.de; h=Message-ID:Subject:To:From:Date:Cc:Date:From:Subject:Sender; bh=ymHzSP6b77tUdg3MpeJDDfVcEVfHHO864QOF6PwBG1g=; b=Dwb/yeksOmWR9RF2Osz7ByQzel3gLf2HXdzXMWDs+cqt5v6EgN7oe3gxD4XYDX7J40 iy+XLrCCfDRrFxLyhTixVVv2M+ehIqn4EVrLbGaIJ43Ht4zPR3L7IZf3zZXqb5rUi0Pc gfEHf+R9TsS/To50i9gKO+ddvJOTlLA3rMaabrsFOiz3rLQbpXIA6WqbwPs8B7WjtnUe cryYqw4UIlvUJ3a4Zi5hESGmyo6x82TBds2anp8EQRpXuqJiMdpo3Rq4r+HqJV4z5nM1 2KXIkqFrWkqQHqZKmOUpbQH2Wy9km5Wbq+/hSPwMluJepX2uxL8jigL8Xo7zqa00Pfsh ryFg== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QLpd5ylWvMDX3y/OuD5rXVisQsBBSIa03sY9BUY2ao0oygRsMfcqA6zjDLeeWXNg==" X-RZG-CLASS-ID: mo00 Date: Thu, 1 Jul 2021 12:56:23 +0200 From: Olaf Hering To: xen-devel@lists.xenproject.org Subject: XEN_SYSCTL_cpu_policy_hvm_default truncates leaf count Message-ID: <20210701125623.593fe3ae.olaf@aepfle.de> X-Mailer: Claws Mail 2021.05.27 (GTK+ 2.24.32; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/LWVxqIjpQLVhhKfHVDp2z55"; protocol="application/pgp-signature"; micalg=pgp-sha256 --Sig_/LWVxqIjpQLVhhKfHVDp2z55 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable For some reason migration of HVM domUs from pre-4.14 to staging is broken. It seems xc_cpuid_apply_policy gets nr_leaves=3D119 from XEN_SYSCTL_get_cpu= _policy. Later XEN_SYSCTL_cpu_policy_hvm_default truncates this value to 31. As a result x86_cpuid_copy_to_buffer returns -ENOBUFS. It would copy up to = 51 leaves in my testing. I suspect commit 34990446ca91d9e201ff17bd4e3f43bfe3ad308e just revealed a l= ogic error somewhere. What is supposed to happen in libxl__srm_callout_callback_static_data_done = when XGR_SDD_MISSING_CPUID is set? Olaf --Sig_/LWVxqIjpQLVhhKfHVDp2z55 Content-Type: application/pgp-signature Content-Description: Digitale Signatur von OpenPGP -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEE97o7Um30LT3B+5b/86SN7mm1DoAFAmDdn1cACgkQ86SN7mm1 DoCOoQ//cITmXnQdiJkpKKzg8mZhmG8UsxVmRg4uB3npq/hLTHxBFFeDABexv3h3 59A40YTjwTK+iqYfWeayFG00XM+QP8DbgUup2gpSbmRBUH7iEBVe0EY4jvS99avb S6QB9Xn3Qy/dqCDN5CM+I0fnxsivPrdnztL1IGeKdnOHvAqwdvJ4DFBH2OLhy17E rnODuM9B0/D2fEXDjXUdPxdoeNIVbhaKBvmaItG6dqfT1ttnhBgXsCWEzha198vN 7F8QsuBeLMV65TEpKwWhSSoKembh9h7MVgcoX26R4aZSv9RXdERzjNBDFsYWTrlw 0BZHL/TE3awSFh2p5dNUTTPRdshtjW5jKqGf+ynEOz0HZFq9I3m47rbo2fwC7j+S IaRMFLEkeR/VDggM316dFxP2zAc/1nQImqBhgYN0EkXHp+hc/AU3luitzb/6Ir/D nnykhMuMQ7dWLJ69j/n5mflQor6Gid2lLdFp3x8S7UlTLgs2FbfltuSRBRnDMF6X JQ4h8psNqYV7ccXhoeTXFAofPZ/F5mF/AhnIP/cK+kKfAZV/rHE13ISoHrJESXQN TYHwCrVFrVihnOAqObU0xBmcGuDUfI8v23P4TmPXXI4jlN/gTxKspfyLYxsayTDo oVr3wQrq+p7LlZhD3Cm7pF+Lftu65c1Z3n9lmSX/4QsQN7XorSE= =lUM+ -----END PGP SIGNATURE----- --Sig_/LWVxqIjpQLVhhKfHVDp2z55-- From xen-devel-bounces@lists.xenproject.org Thu Jul 01 11:02:00 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 11:02:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148625.274650 (Exim 4.92) (envelope-from ) id 1lyuSC-0005fM-AQ; Thu, 01 Jul 2021 11:01:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148625.274650; Thu, 01 Jul 2021 11:01:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyuSC-0005fF-7D; Thu, 01 Jul 2021 11:01:56 +0000 Received: by outflank-mailman (input) for mailman id 148625; Thu, 01 Jul 2021 11:01:55 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyuSB-0005f9-2J for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 11:01:55 +0000 Received: from mo4-p01-ob.smtp.rzone.de (unknown [85.215.255.53]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id a5879899-d063-4e70-95ec-c059ee4bf8fb; Thu, 01 Jul 2021 11:01:54 +0000 (UTC) Received: from sender by smtp.strato.de (RZmta 47.28.1 AUTH) with ESMTPSA id 30791cx61B1q5uX (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Thu, 1 Jul 2021 13:01:52 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a5879899-d063-4e70-95ec-c059ee4bf8fb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1625137312; s=strato-dkim-0002; d=aepfle.de; h=References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Cc:Date: From:Subject:Sender; bh=1Ft3d4S2jt1ugXiZnrYmhDGS1ySaDt8cXXFb/3BIPAA=; b=ODtG48Ub/xAzJCrdWPRb54gQQ4meZRvv8XJLwtn+vaFX9shs4mT4hHtaKxM/lRz773 fzHH5xIjNzxT7JQrNeS6K6QWDeCz5W0lBX6mmC9SY0cSU9gwuq7fKfHgCKpi5wcLFOzb sbBzA1jF3e/eZuWx2mU7sE+wo2cGCDnU2MuNCIBs8AA83KWmRiRv5rEKwxm9Xnko+9tT BSC13rke64cE9AuByc97Nuk+u3zumFpSesiIvWwN7V0Si7jaYhOc35Q/VnDpZRzV5xg5 nUhPwZnK37s0xTADktkS+0xGe7WV5DWMf3u1fxn9MJ21ocZhiyz2JfDZ3ARdjz1efOzn DAxA== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QLpd5ylWvMDX3y/OuD5rXVisQsBBSIa03sY9BUY2ao0oygRsMfcqA6zjDLeeWXNg==" X-RZG-CLASS-ID: mo00 Date: Thu, 1 Jul 2021 13:01:43 +0200 From: Olaf Hering To: Jan Beulich Cc: Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [PATCH v20210701 08/40] MAINTAINERS: add myself as saverestore maintainer Message-ID: <20210701130143.2b8cfce3.olaf@aepfle.de> In-Reply-To: <13a963c1-639f-5135-734b-9cc1c8d9034e@suse.com> References: <20210701095635.15648-1-olaf@aepfle.de> <20210701095635.15648-9-olaf@aepfle.de> <13a963c1-639f-5135-734b-9cc1c8d9034e@suse.com> X-Mailer: Claws Mail 2021.05.27 (GTK+ 2.24.32; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/hnFDd7g=OsxECGa+S219NuQ"; protocol="application/pgp-signature"; micalg=pgp-sha256 --Sig_/hnFDd7g=OsxECGa+S219NuQ Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Am Thu, 1 Jul 2021 12:39:06 +0200 schrieb Jan Beulich : > I'm afraid this goes too far: This way you remove all prior > (direct) maintainers (see "The meaning of nesting" in > ./MAINTAINERS). And I'm sure Andrew, who has written much of > this, ought to be considered to become the maintainer of this > code then as well. I think this was copy&paste from some other entry, which would still includ= e the tools/ maintainers when using get_maintainer.pl. I do not remember wh= ich one it was. Also I think if Andrew would have a desire to be in there he would have add= ed himself already. Olaf --Sig_/hnFDd7g=OsxECGa+S219NuQ Content-Type: application/pgp-signature Content-Description: Digitale Signatur von OpenPGP -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEE97o7Um30LT3B+5b/86SN7mm1DoAFAmDdoJcACgkQ86SN7mm1 DoAmCQ/8Dcu9wPw+Og2BtFApKoZlKp2HGXc+NttVZ3mUwhPP2Zf+epS70Fp6tY+m SkFWXCd/xHUN0/S9xEMYtq1cDO9+QzhThUZU3w328UJqWd0t5wtYeVWo6eynxZGI lOPV+f7zfKseuP6C5owS2Nakl26XhucE+XOa8f+zb2PAGC4kcK+1GnOOJ0hLDdtq Ip0dTi3z94zZqXzqv1D68Ce/hYxrCeutH8Xt8oD5SgjGWOSX9BAHPnJXSebcmKbN IYBGYWTJDxKlV9kmyPLHuTxXJPy8TuyH+dQc0qDYQG5fjyhZBJc7MGeKrF7xWurt nQHC7WlXHAFbWRJkL1JpZPxIKOAkO6GlKOSrMQAgqlg2BTrJNdPMevZ4HJrtN0di Se7Y7q7LQgUmE82ozwb/yUMdFwFIRtkl//DDV/X4aIWWy5DnddVI8bhp8nCSnpOV b5swpfyvZFll0H5RO8aavuOWZL516F+/voAYQk/EqqMHZ0jPCn1NQ5uVj8yKvOGq qRLwBqAVhFAezqvGyT/CvfHK1KB37ir6qZnJBUgpPzOjQT9unt79NwZyGeGHgrRu Cd//7GRENf1p5ZgCOHw5u54GchNbhIK878TeD1kjsLNTtx6t6Vq89Cot535veKWF JYVCR9BsSsv0cr+OvjHzTg7tK6OA3jwVbh/VOSACCx4812Ojyn8= =G4ey -----END PGP SIGNATURE----- --Sig_/hnFDd7g=OsxECGa+S219NuQ-- From xen-devel-bounces@lists.xenproject.org Thu Jul 01 11:19:44 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 11:19:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148630.274661 (Exim 4.92) (envelope-from ) id 1lyujJ-0007Ee-Q6; Thu, 01 Jul 2021 11:19:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148630.274661; Thu, 01 Jul 2021 11:19:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyujJ-0007EX-N1; Thu, 01 Jul 2021 11:19:37 +0000 Received: by outflank-mailman (input) for mailman id 148630; Thu, 01 Jul 2021 11:19:36 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyujI-0007ER-3R for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 11:19:36 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 4acf82cb-6e15-41ed-b175-bdd9967fd515; Thu, 01 Jul 2021 11:19:35 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4acf82cb-6e15-41ed-b175-bdd9967fd515 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1625138375; h=to:references:from:subject:message-id:date:in-reply-to: content-transfer-encoding:mime-version; bh=QNk+aQRxXzhpWD8DJgJK2eEl3dKt+LtyV24JvxMfyak=; b=J0vFS9WGa17ivU79sY7N0f60OuAh59eh1vrgXZQ2yw3TQUuIOHUQqMdQ wgqkTLmyyhZrHQJJgNjjw/leXaT6vG7yFGY1Vj/wHbhZF/9CbNfXYP2/e gapjQ9fh6tDekApqX2SFqdMbjgZn8bbHV2+TOhtXMGpJccTWHMoT2N++i E=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: PqilrLgr1TMgFGVyEJrz/LHvpEtxIAuTvH7IISt0frdnVyLRolnwk8kW2WL2xIXaFQ9zG5DTCc pfOFX5lDTo1ZFj+BKSw/bIrdjW9UE9ELyZ+rmcnrTk3SZiM7yDlNC5BoLglBhMrXrGUih4O5WG 5YkhZAq2vTYZTlr/YoVZOs/Ve/v3iUZNHgJ0nbLcnnBLwo6rAgbK9mchyvc4R2bu2GUz4h+jpX BPNye/QGX5Hp739xO7IjBmnGCMCScWHO6OnZ4JeYZlWIGgml5vu7VCqgM71qOtzR2/gg+/uDUo mPo= X-SBRS: 5.1 X-MesageID: 47359628 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:Wb35+ansY0b5XNqHBc2tMp76svnpDfPaimdD5ihNYBxZY6Wkfp +V8sjzhCWatN9OYh0dcLC7WJVoMkmsiqKdhrNhQYtKPTOWxVdASbsC0WKM+UyZJ8STzJ876U 4kSdkFNDSSNykIsS+Z2njALz9I+rDum8rE9ISurQYZcegpUdAF0+4QMHfqLqQcfnghOXNWLu v42iMKnUvaRZxBBf7Ld0XtEtKz6+HjpdbDW1orFhQn4A6BgXeB76P7KQGR2lM7XylUybkv3G DZm0ihj5/T/c2T+1v57Sv+/p5WkNzuxp9qA9GNsNEcLnHJhhyzbIpsdrWetHQeof2p6nwtjN 7Qyi1QcPhb2jf0RCWYsBHt0w7v3HIF8Hn502KVhnPlvIjQWC86I9Apv/MbTjLpr24b+P1s2q NC2GyU87BNCwnboSj779/UEzl3i0uPp2Y4m+J7tQ0ebWInUs4VkWUjxjIQLH9ZdxiKr7zPUd MeTf003cwmM29zNBvizy9SKLXGZAVAIv+EKnJy8fB9nQImxUyR9HFos/D3qE1wvK7Ve6M0k9 gsDZ4Y4o2mbvVmJ56VV91xDPdeNAT2MFvx2TWpUCra/ec8Sirwl6I= X-IronPort-AV: E=Sophos;i="5.83,313,1616472000"; d="scan'208";a="47359628" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OLVPvGC/+I4u7z3fPaFbPGIhSxMLIKQBzOeIOryKStZy4xuvQ7/GEgiMg9G4eqcMK/HbPNUMraIJWc+b4IxYfxIrsSXYKrugIujkqCA629M5SSryAesxhzn08QSJ52QHo4WCarrP53zEkQDk7/vS0eh4eUCh9DPkviIN8dOHjrYzXymCLFxXR96SjTphsO8/PA5Mq3R9+r9emG6iCoCN7/ytZEmAelBn6r3iwCKRWac/RtXT4hhNHhMIsfjxHJd6yaSahiOTBVAZ0kmPQyquB7HhmJ2F5538l+fdMlRzH/d1v9MoHu9Bug5JH0jmdWiQDrg3RbpNabrAmT4ww96DUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QNk+aQRxXzhpWD8DJgJK2eEl3dKt+LtyV24JvxMfyak=; b=G6jRGKX2UBwoczsfrYgdjrwb/bsaATk7QFBEKUMhn4gMPlOAFDgNyWk/hFZDNTU2f9LNlFxXfAwXW7FETEt8SsQEpzKE10jden9/UEZk7tGYwymvHdngniUNV9TslZ3i6CpBP7l0C9PNmfPjSYyjcnuXIitFhKGSlqW1YaJoRCc3XNdXn2r0n1iQfi56bZySOZtTdrqFQTVCCqOzoAL/qskrT9wuBso16I8BneB9eu6m6FIderZnF/yC4z92lpDkbrJpGRZCjPqfM6dTYkaJeoiDGrw1h6Vfq0OMUhTQAPV6vX1X8jekifoDfMGqelJZisq/GqB9nfO6Vm0bxv5jGg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QNk+aQRxXzhpWD8DJgJK2eEl3dKt+LtyV24JvxMfyak=; b=r1q7EkHk4cHhXbaanPLT5JZuq/1PqCnjsFpD4ozokQGDO8EAlUC75MjwWQfSrBNfPBB3fAf5O9myCaePgM95TfFrjllP2C9v+wjY7S1zKAroo0TqJH2NyPG5yP+FL6jUM/iQ3r4Z9dtuWO3oo/UnkNpr3GOFEV28iqAMnsHg9ws= To: Olaf Hering , References: <20210701125623.593fe3ae.olaf@aepfle.de> From: Andrew Cooper Subject: Re: XEN_SYSCTL_cpu_policy_hvm_default truncates leaf count Message-ID: <20e828c9-e7dc-4401-9307-a6d72eb618d8@citrix.com> Date: Thu, 1 Jul 2021 12:19:24 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 In-Reply-To: <20210701125623.593fe3ae.olaf@aepfle.de> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Content-Language: en-GB X-ClientProxiedBy: LO4P123CA0461.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1aa::16) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fdae81e4-c57d-4dd2-ba8c-08d93c82185c X-MS-TrafficTypeDiagnostic: BY5PR03MB5078: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HLPSbBFfc5GuCT2D6+ShGQcV65qBligUPvR5dh0nvLa8oEenFzdRU3EKhzmBXPdc9zNiSaZ1lCBWSjvGe+C2nB6zYz3344niWIX4ninMZ6+u5AaWNhni1o+ihQpMCvj1LJflGknis0c6y0wGIG8DH2h8SBKE15PYNGdYbFgWkum6VsMOYO9eDeh3kxE/bwfk5LnPMSv3SbhMneE7EfiV6Cplsz5+Fm0BTAH2MHidH1PMqnrtEWZHjkGbHtxreFjdLL+AxH34kalO4QK+P1lO2k6+CTDWBhUTfyuINHnlM2RvtrvgMWi1jtk9wqQ3kahE9493GrX6ez8SNYl7v8koD+TgvM87s8e0I1VBQkqLcgNEnAJb/WLhg41S624wTS3zhOYcTWBDFbklbQ6C9VSMFSwoa75V3iAj2rhAS00LOOJbOTb/+P+dbIbBLiEekKr9Vo0onaQptFJULVvsi7/QYBqo3rCoe0T1S876ISwabGHt1Ugk3uxUGwJiv9qFiTBPvNzsTxvhDbeGKwTMr2f9z22rzagaCmPHLOfkenPKOeGQeZJfd5OegTnYg47Q093Tz/9NDRZIKF+fwIdc/TRcWJCGmDFucmcVeVqwKYNyd0LkRW8u1JkVYyIdsE7qXsfX33gkSugUmzDuPizV0PPUQtVm4U8dA3XnwKUBpgFBx8oCqnL6CSotOpueZ6nol0TYgrP0HCGllgtYDDR/+FMHfEirx8jPtM0yvZYeSpB6B1NK92NQzy1DivnLa+7CMi4k X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(376002)(346002)(396003)(366004)(39860400002)(8936002)(956004)(6666004)(31696002)(2616005)(186003)(16526019)(16576012)(8676002)(86362001)(316002)(31686004)(66556008)(66476007)(36756003)(5660300002)(66946007)(83380400001)(26005)(478600001)(53546011)(6486002)(38100700002)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?Windows-1252?Q?1mqasmpYFXQjRP17cqCC0DEbipN8BHSjBOtsAvU6xH+3DHY7rDOctxYK?= =?Windows-1252?Q?ijpfHvKhSiHJej2eM3MF10fuAzPOhx8fgcZWlrflTvWyoj4Lrcbgf62N?= =?Windows-1252?Q?v/iMQbjSXreQQqz/OSlq0LQLUz4QMDQvR4pgRLQWlTYqlIsxdVuhMAdB?= =?Windows-1252?Q?fcGnEKD6OGC9DaDyez9NI76YcbGFcNzQGaWO8MYAnugVykGaDlTFn/oK?= =?Windows-1252?Q?FCLz5lmpYo8YL1Lows5GI7Sfd8jD1q2sLjn7z5zpPlXtiM9QpS1GTLDn?= =?Windows-1252?Q?3jcFHD42f9MWlH3FmEHyR7KoJnYxd7VYV8CBuN3fmzCfCWIcO289iT9h?= =?Windows-1252?Q?PQ03rCpa17NrXAyEkRaPnvR6GtkbyCK6ASOwZPvJICOT90QBwr+x9xU+?= =?Windows-1252?Q?LSH/LZRYNLzODTH+RuRv96bXUabDoLRWdnvNdNkZhJtJyoAB2ymHNxb6?= =?Windows-1252?Q?l4KqYUpqHqd+j1RrKET8mWyd6L3PYq5tN5CUBDEpCUgdjN213tKOA5LE?= =?Windows-1252?Q?NqI/3NJF4vzNuD30Rvcu5isHZTu2f5N+xQkSdKYRdNqBRTkO6vv2DTyA?= =?Windows-1252?Q?JZbEEMaLe1n2gamxlUIT6oQwkWB75Y/nKzo+d306B70WNFf2uVGxreXZ?= =?Windows-1252?Q?9oJ/rIB+HSPW2jzh5WKsG7tnAuS9rDXKHS5ddVVpjNNKEMIZxnk6sHsX?= =?Windows-1252?Q?tl7ItK9tEWs5rEdzDRCW+dlUT95Nn4ppAzptiCXXEFGHQjg1clSXaXC5?= =?Windows-1252?Q?RbhMNJm2xHJqQXhtR3oQSJeVMTvmKvVYSxF3AupU0V188HYhEyau35Mu?= =?Windows-1252?Q?Tlv4cjzgNEo92foswatWIMvbCmDAzb0Z1umqEA6P6fSBVbeRnpUw4igC?= =?Windows-1252?Q?aDrznjakEpLVBKQs3AqT7aqR6oToOxiyYF48NYbol+Ko4mf0MZsaYnzE?= =?Windows-1252?Q?OhvtyVETQHC3CzRMTArVT5NS84oCsAkkXeGMtgWXPZyL/JPDgQdtXr09?= =?Windows-1252?Q?4/lwstqVgZ/0n+UrKWJD4HzAs2AjR6r5Q6GHc9vsGCFPByGrQco7fWM2?= =?Windows-1252?Q?v89d6dY9CmCtqEP6uje7REeI8Cz4qdc14dgPd6H5fJT008fOzPd8h/5l?= =?Windows-1252?Q?3AfDRPKXTHvYJK3gDfR1Hz9aZI5QnOjcmdLJpOLyPiRLOqLxHXb8UOXT?= =?Windows-1252?Q?HsPGPBRnwI6Aai+ppto3UWMhOcdpHE0pVKt2A7XLHDJpERoL0nCNN7pN?= =?Windows-1252?Q?TneVZRwHGX9jt/aVsd//VpTCcCbYv8nbJ5E2PigSJ5KrTtneRo8VPUvp?= =?Windows-1252?Q?C9ciwFVyrFxVRm5rCreDHKErfhjTqSFW5mNUsbDkpScHjeaUGK8fodpw?= =?Windows-1252?Q?wKtSSlt1/rYlKkva1oYyxJGsPjmxJ26NBIKEAHdixWljBvl+KZ35QkaP?= X-MS-Exchange-CrossTenant-Network-Message-Id: fdae81e4-c57d-4dd2-ba8c-08d93c82185c X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jul 2021 11:19:30.3600 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ZItATBG/H11RrX+qDqMB3qJZOcqulfQie7JvDUItxnd7V1NIEQiP3ByjHWXglQHBtg7nlMUv5JUAdlZasJV7nuOZY/lciRX852i4lPs9Liw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR03MB5078 X-OriginatorOrg: citrix.com On 01/07/2021 11:56, Olaf Hering wrote: > For some reason migration of HVM domUs from pre-4.14 to staging is broken= . > > It seems xc_cpuid_apply_policy gets nr_leaves=3D119 from XEN_SYSCTL_get_c= pu_policy. > Later XEN_SYSCTL_cpu_policy_hvm_default truncates this value to 31. 119 is the maximum number of leaves to cover sizeof(struct cpuid_policy). But no CPU hits both Intel and AMD max leaf, so we can unambiguously represent the policy with fewer than 119 leaves.=A0 31 is the count of leaves with data in, on this particular system. > As a result x86_cpuid_copy_to_buffer returns -ENOBUFS. It would copy up t= o 51 leaves in my testing. > > I suspect commit 34990446ca91d9e201ff17bd4e3f43bfe3ad308e just revealed a= logic error somewhere. > > What is supposed to happen in libxl__srm_callout_callback_static_data_don= e when XGR_SDD_MISSING_CPUID is set? One of the many totally broken things about Xen migration was that the guests CPUID data never used to be part of the stream.=A0 It was always reinvented from scratch on the destination host. This had fun properties such as the CPU's family/model/stepping changing underfoot (I'm still amazed that VMs didn't complain more about this - windows would happily install a new HAL driver and call itself done), and less fun properties where some features just disappeared totally due to changes in xc_cpuid_apply_policy() logic. Starting in 4.14, after I'd added a "please get the guest's view of CPUID" hypercall, the CPUID settings the VM saw move in the migrate stream with it. XGR_SDD_MISSING_CPUID is the signal of "this is a pre-4.14 VM with no CPUID data", which means "you need to reinvent CPUID as the toolstack in 4.13 would have done". This *ought* to be "grab default, edit a few details, send back to Xen".=A0 Where is the 51 leaves coming in?=A0 Do you have cpuid=3D lines in the xl cfg file? ~Andrew From xen-devel-bounces@lists.xenproject.org Thu Jul 01 11:36:46 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 11:36:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148637.274671 (Exim 4.92) (envelope-from ) id 1lyuzo-00016K-CH; Thu, 01 Jul 2021 11:36:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148637.274671; Thu, 01 Jul 2021 11:36:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyuzo-00016D-9G; Thu, 01 Jul 2021 11:36:40 +0000 Received: by outflank-mailman (input) for mailman id 148637; Thu, 01 Jul 2021 11:36:39 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyuzm-000167-Oy for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 11:36:39 +0000 Received: from mo4-p01-ob.smtp.rzone.de (unknown [85.215.255.50]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id e469171b-012d-4977-9272-025a76b7e0f0; Thu, 01 Jul 2021 11:36:37 +0000 (UTC) Received: from sender by smtp.strato.de (RZmta 47.28.1 AUTH) with ESMTPSA id 30791cx61BaZ6AK (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Thu, 1 Jul 2021 13:36:35 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e469171b-012d-4977-9272-025a76b7e0f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1625139396; s=strato-dkim-0002; d=aepfle.de; h=References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Cc:Date: From:Subject:Sender; bh=EaTkDCsxmG/5LAoOL5R5PfPFMnYdKWar3UPZ1YO5J0w=; b=hKQzMm0H8qKtThJK/InXZzNpNWjZbVuJEX5fsWtiGnp1nsYyTINWEfhaFtawIBOJcp NRmjKF6DMjoY/4XXzTOTLrAAn9MMo6GhW/R5NlyZ5007Qr274aV0ymAg3c7oh8uR2Bjb fE70EB8VfcdSMLkGA81f5JoujOdPUDO8dxC4zXRayQSU7vuOc27fWdhNv9r56J62IlIz VjcRPb+tSsTAqBgL4rbv5i3R3ceVFfjv7AtK7/7cupCrfFgd+RlIp+FGTun/S9gAn55V /IABpN7o1iflBlwalipOOCVQ93VGmcWWZimtWvZmf3DfgWMPz7W9SX9dJQE17zvC9eqx EK/w== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QLpd5ylWvMDX3y/OuD5rXVisQsBBSIa03sY9BUY2ao0oygRsMfcqA6zjDLeeWXNg==" X-RZG-CLASS-ID: mo00 Date: Thu, 1 Jul 2021 13:36:28 +0200 From: Olaf Hering To: Andrew Cooper Cc: Subject: Re: XEN_SYSCTL_cpu_policy_hvm_default truncates leaf count Message-ID: <20210701133628.1667a344.olaf@aepfle.de> In-Reply-To: <20e828c9-e7dc-4401-9307-a6d72eb618d8@citrix.com> References: <20210701125623.593fe3ae.olaf@aepfle.de> <20e828c9-e7dc-4401-9307-a6d72eb618d8@citrix.com> X-Mailer: Claws Mail 2021.05.27 (GTK+ 2.24.32; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/V3f5fxObco4H8QqtSU1IZEa"; protocol="application/pgp-signature"; micalg=pgp-sha256 --Sig_/V3f5fxObco4H8QqtSU1IZEa Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Am Thu, 1 Jul 2021 12:19:24 +0100 schrieb Andrew Cooper : > This *ought* to be "grab default, edit a few details, send back to > Xen".=C2=A0 Where is the 51 leaves coming in?=C2=A0 Do you have cpuid=3D = lines in > the xl cfg file? No cpuid=3D or anything in domU.cfg or Xen cmdline. If I understand x86_cpuid_copy_to_buffer correctly, it copies all of basic+= extd and viridian+xen leaves, which is apparently more than 31. Olaf=20 --Sig_/V3f5fxObco4H8QqtSU1IZEa Content-Type: application/pgp-signature Content-Description: Digitale Signatur von OpenPGP -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEE97o7Um30LT3B+5b/86SN7mm1DoAFAmDdqL0ACgkQ86SN7mm1 DoBpUA//SB0yjRi7AFikeKxfZKvWSpI00sf+1jzVHYGWzQEwH7jT5qtRLpRYwgBS PQm/nyc34yBQDZN7OJWbzrFBOPifrhM3DkQqp3H9tcg5xfogvUOWRV7x/U+i86iP 1ibN4h9rwldj+AYQ0EXKHdt1DWMPQ6KIDpDuXNJscLEECE7B5wy8zOyglVOsivYJ ZnlnOy13xzPmf1V3B7aW4R5pDLkGu3rO8xxB9bsTLDrEdSMzFoPlAaqjBJgo1fLE pj+ycafjcFLXL5W8hrIofJ4cGfJVu8S2DNhuPHRo/D+aO1yESIfUh4sveYItQO2n Ds8Q2NwLgcFmRr7wmNYvKFeRDRIemz/F+eQPbH/L0c/2mZxg3mU3rIsPJzLtwbCI RDeY1JX2ZLL+CIf0NDilePOeytalJlnfJLlPb9HcgDaAia2qzBY1FEM6Qn0tmc4m HeHA6/7Ck0KDTIspfdfrYekH6nBLoAoTOfWQWeI+WVMZna55n17vQFQqFcxQDX0k rsjHTnq90HKDTE2uHSnmqoBCq+w2621Bn4ifL/0PGpnEjMeGWPxx5ZHCdrgTU+Bc Imrh+xrLq6cCnzgY/WwZRIm10yCw78mkCWBp0p+MuV76/AFrSuaXS+hX+DjmXjMM q83aoyRxMggFAYU03oVLUGVj01jB5SVBCof/H2O3NyHOItuhU+I= =FgNt -----END PGP SIGNATURE----- --Sig_/V3f5fxObco4H8QqtSU1IZEa-- From xen-devel-bounces@lists.xenproject.org Thu Jul 01 11:40:14 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 11:40:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148641.274683 (Exim 4.92) (envelope-from ) id 1lyv3F-0002SQ-T4; Thu, 01 Jul 2021 11:40:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148641.274683; Thu, 01 Jul 2021 11:40:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyv3F-0002SJ-PO; Thu, 01 Jul 2021 11:40:13 +0000 Received: by outflank-mailman (input) for mailman id 148641; Thu, 01 Jul 2021 11:40:13 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyv3F-0002SD-52 for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 11:40:13 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyv3D-0003nr-Qg; Thu, 01 Jul 2021 11:40:11 +0000 Received: from [54.239.6.188] (helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lyv3D-0006D6-KH; Thu, 01 Jul 2021 11:40:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=qrHHKDwLGVAwuZ8YDEmJvO1B5Md1+6hA43DjhdVqj5k=; b=cdVZosP6NNW3LlUp4gI+YlaFds A4msxS1TOnxTapS/qF/mqe6pfUwGxn1UZoqn0IFkRrlisJiGQo6CBUwtUmZqWLXltzWWDpribNapr 8+je9hJkcReo0/3T1RSa423bI9mWRcHH3f01t0keDjeFU+4FAUiOk6QTaZ4Tq+h1oAZ0=; Subject: Re: [PATCH v20210701 08/40] MAINTAINERS: add myself as saverestore maintainer To: Olaf Hering , Jan Beulich Cc: Andrew Cooper , George Dunlap , Ian Jackson , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20210701095635.15648-1-olaf@aepfle.de> <20210701095635.15648-9-olaf@aepfle.de> <13a963c1-639f-5135-734b-9cc1c8d9034e@suse.com> <20210701130143.2b8cfce3.olaf@aepfle.de> From: Julien Grall Message-ID: <07174c4e-cf39-66c2-c3cb-27b728dc5819@xen.org> Date: Thu, 1 Jul 2021 12:40:09 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210701130143.2b8cfce3.olaf@aepfle.de> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi Olaf, On 01/07/2021 12:01, Olaf Hering wrote: > Am Thu, 1 Jul 2021 12:39:06 +0200 > schrieb Jan Beulich : > >> I'm afraid this goes too far: This way you remove all prior >> (direct) maintainers (see "The meaning of nesting" in >> ./MAINTAINERS). And I'm sure Andrew, who has written much of >> this, ought to be considered to become the maintainer of this >> code then as well. > > I think this was copy&paste from some other entry, which would still include the tools/ maintainers when using get_maintainer.pl. I do not remember which one it was. You are mixing CCing and actual maintainers. You can be CCed without maintaining a directory. Jan's point is tools/ maintainers would not be directly maintaining the library. You would be the sole maintainer of the directory and Jan was referring the following paragraph: 1. Under normal circumstances, the Ack of the most specific maintainer is both necessary and sufficient to get a change to a given file committed. So a change to xen/arch/x86/mm/shadow/multi.c requires the the Ack of the xen/arch/x86/mm/shadow maintainer for that part of the patch, but would not require the Ack of the xen/arch/x86 maintainer or the xen/arch/x86/mm maintainer. Regarding your proposal to maintain the directory. I don't follow much the tools side and therefore can't judge the merit of the proposal. However... this is not new code per-se and therefore the fact you touch last is not sufficient (otherwise I could claim the same tomorrow if I send a patch to the directory ;)). For the commit message, I would suggest to provide some information about your contribution (including review) to the area. Also, was this discussed with the tools maintainers? Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Jul 01 12:01:00 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 12:01:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148650.274694 (Exim 4.92) (envelope-from ) id 1lyvMy-0004vG-P4; Thu, 01 Jul 2021 12:00:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148650.274694; Thu, 01 Jul 2021 12:00:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyvMy-0004v9-M8; Thu, 01 Jul 2021 12:00:36 +0000 Received: by outflank-mailman (input) for mailman id 148650; Thu, 01 Jul 2021 12:00:35 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyvMx-0004s1-IP for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 12:00:35 +0000 Received: from mo4-p01-ob.smtp.rzone.de (unknown [85.215.255.52]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 9304a282-d197-4ffb-8038-c59ec8c8cf4e; Thu, 01 Jul 2021 12:00:27 +0000 (UTC) Received: from sender by smtp.strato.de (RZmta 47.28.1 AUTH) with ESMTPSA id 30791cx61C0P6Ko (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Thu, 1 Jul 2021 14:00:25 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9304a282-d197-4ffb-8038-c59ec8c8cf4e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1625140825; s=strato-dkim-0002; d=aepfle.de; h=References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Cc:Date: From:Subject:Sender; bh=LA6pzunebxl1hoyt8xGJaWSXCjL5ktBek1fDgycFaFw=; b=MOOqYp4xHn8EqButhLA9ZbhK4Fxew1EiYl4MxKZh/T8maXTkLEwRx880ndy/n8HHGi +9zLexcWfwzsXfFW3J7qeSxOiPlHQN94Xh/ZAJsHAwF/T57MRO2u2xHZu/O202+5NO5Y wcL3KtnaHsRUZzXaaPe5JHJxvX4E7v4uK/JgJ1f6Plt/tai4C7PZ+iSS0WysdjhtWzD7 GbM6IMi75lSIaPXVBrrMW01Xm6MwlD/wDzfpnIJ4s+H9E2scWpsWm52YYD1RbJ6zgp8k d7A5PW0wTf2Mu7qouAr4dm2pAk0PDhtKsYCcYMgpMsVOERYbcQY8PZ+rcb7irQDnvAGv wFMQ== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QLpd5ylWvMDX3y/OuD5rXVisQsBBSIa03sY9BUY2ao0oygRsMfcqA6zjDLeeWXNg==" X-RZG-CLASS-ID: mo00 Date: Thu, 1 Jul 2021 14:00:07 +0200 From: Olaf Hering To: Julien Grall Cc: Jan Beulich , Andrew Cooper , George Dunlap , Ian Jackson , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [PATCH v20210701 08/40] MAINTAINERS: add myself as saverestore maintainer Message-ID: <20210701140007.77132794.olaf@aepfle.de> In-Reply-To: <07174c4e-cf39-66c2-c3cb-27b728dc5819@xen.org> References: <20210701095635.15648-1-olaf@aepfle.de> <20210701095635.15648-9-olaf@aepfle.de> <13a963c1-639f-5135-734b-9cc1c8d9034e@suse.com> <20210701130143.2b8cfce3.olaf@aepfle.de> <07174c4e-cf39-66c2-c3cb-27b728dc5819@xen.org> X-Mailer: Claws Mail 2021.05.27 (GTK+ 2.24.32; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/NoXEhtjrK0YWGGgMN0OHnvu"; protocol="application/pgp-signature"; micalg=pgp-sha256 --Sig_/NoXEhtjrK0YWGGgMN0OHnvu Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Am Thu, 1 Jul 2021 12:40:09 +0100 schrieb Julien Grall : > You would be the sole maintainer of the directory Yes that is the point, it changes the count from zero to one. Olaf --Sig_/NoXEhtjrK0YWGGgMN0OHnvu Content-Type: application/pgp-signature Content-Description: Digitale Signatur von OpenPGP -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEE97o7Um30LT3B+5b/86SN7mm1DoAFAmDdrkcACgkQ86SN7mm1 DoBtPxAAnpoF09PNlYiJu/jqdqRzOs92MOvNjH+VZWZ4gmr46oZ4evOv1OCKIS1y JVEr4Fb5ARXae+8MRU9yNpLVMRZeIeaEh8So4ZARJ2BQUGg4iRnK3qSaOvAYBeG/ Mz87T9+RJRVFWWtfwLv6sTPZL6VpsdSqyDQchSL2CVb7PlsWUCiesdxCgu32mRQu cef4lQUk4JN4aGfq61niTR2Kgne1b0H0qY8bWr82HgzPWqp1Wp5S0IVvPZBMjIHU On6pM6TdiHrooB7LHx+rm0nB3OxGU7o2l5Xo/Xamrxal77RYFNQefMow+2+jl4jR 9DvEH053YX5r6EzgaFI/hnxr3FsLRfQLIOBqAf2iclXI+Ia27uKt5sSyHVDVezGG Ni51Xdm+jG0ErD4ZQaVzI6CdKSaNoQ0T3cmbNGSwjDG/yk4hFCaZLON1q3agnfw1 QxHwUbVV/BrIOUnAv4RIrSNJ7d2w3UUFy918u9EC1Vzg0NhUAogupD3EvsKL1+ZV d8l6lwJzZirFLFSUkHXU7EIDtAeOlgzsMzy3TQNLig7KiG6AcIiMkOi/PZ5exQ/v gfra5XTBg8V2tslvoBAv3/c0c43l61+OJBOnv2P2jbeoCXff7qqx5RP3IUU1Mf5i pt+Vj4Tc3AqiUGzwWb3Hiuf86744VvlpKUmX0ORwhvZI2xCXCbo= =BOyd -----END PGP SIGNATURE----- --Sig_/NoXEhtjrK0YWGGgMN0OHnvu-- From xen-devel-bounces@lists.xenproject.org Thu Jul 01 12:09:19 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 12:09:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148655.274705 (Exim 4.92) (envelope-from ) id 1lyvVL-0005g7-Jh; Thu, 01 Jul 2021 12:09:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148655.274705; Thu, 01 Jul 2021 12:09:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyvVL-0005g0-G0; Thu, 01 Jul 2021 12:09:15 +0000 Received: by outflank-mailman (input) for mailman id 148655; Thu, 01 Jul 2021 12:09:14 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyvVK-0005fu-Eb for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 12:09:14 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyvVJ-0004Js-8L; Thu, 01 Jul 2021 12:09:13 +0000 Received: from [54.239.6.188] (helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lyvVJ-0008Vk-1w; Thu, 01 Jul 2021 12:09:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=KRmNipCF9JIWLcYk1qw3J6A7B0Feg12knd8BAk5qQs0=; b=X9BhITvKIUwFhnilezbc2wA0QG 8Bqs8kFJU95c9T9vcU+VyFGW8R2PprvTaEau33F9g9aPQSEzYxefEum98LeNMUmlVvwlxEBHQy9oI iUPM4om/bvURpA1PAdJltQviM0f81skNaZ72qQT/UrkzoDQB+eJrxBgrez/N7Ytu9veQ=; Subject: Re: [PATCH v20210701 08/40] MAINTAINERS: add myself as saverestore maintainer To: Olaf Hering Cc: Jan Beulich , Andrew Cooper , George Dunlap , Ian Jackson , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20210701095635.15648-1-olaf@aepfle.de> <20210701095635.15648-9-olaf@aepfle.de> <13a963c1-639f-5135-734b-9cc1c8d9034e@suse.com> <20210701130143.2b8cfce3.olaf@aepfle.de> <07174c4e-cf39-66c2-c3cb-27b728dc5819@xen.org> <20210701140007.77132794.olaf@aepfle.de> From: Julien Grall Message-ID: Date: Thu, 1 Jul 2021 13:09:10 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210701140007.77132794.olaf@aepfle.de> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi Olaf, On 01/07/2021 13:00, Olaf Hering wrote: > Am Thu, 1 Jul 2021 12:40:09 +0100 > schrieb Julien Grall : > >> You would be the sole maintainer of the directory > > Yes that is the point, it changes the count from zero to one. The code you are moving is already maintained by the tools maintainers. So I am guessing you are saying they are unresponsive... Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Jul 01 12:35:43 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 12:35:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148660.274716 (Exim 4.92) (envelope-from ) id 1lyvur-0000Nl-OW; Thu, 01 Jul 2021 12:35:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148660.274716; Thu, 01 Jul 2021 12:35:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyvur-0000Ne-L3; Thu, 01 Jul 2021 12:35:37 +0000 Received: by outflank-mailman (input) for mailman id 148660; Thu, 01 Jul 2021 12:35:35 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyvup-0000NY-8u for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 12:35:35 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id d3d48362-da68-11eb-830f-12813bfff9fa; Thu, 01 Jul 2021 12:35:33 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d3d48362-da68-11eb-830f-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1625142933; h=to:cc:references:from:subject:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=IKAGF7D6OKxUEI5hSQIjI5M/65C8tk+mCvXLhbx6tbY=; b=Mtg6VTQlVw+UlzxsZE+YtzQZpxUD7neDwaFbkEQy3XpIs73VqtMwltaC ddZuDydZsPWipPv5DV4eb4qT6JziPVW005p0mIt5wzM8/ry3jC5+RErKP SakPgSWdqn1y9UW52V45UBXyOsQ1kogjv2V2YZH4srtuilqOmUqq0Z+EX k=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: vytxaQ/PTWbXs12TUrr1PT41/o/f2nLoNaPLOZ6OZqBUA59JDsmHiUa10ICiOqubdj8odXZsXM 53jsR686OZTU+cxiwg5TKGKzd9+Ww0So5tSZwWtv2aJM6Xqi7gn5rd2qsSvEYJNHvljMSYFTkI zFhpwBvZf+GvSbelSv749CRF/crcE5yodde/MKSffV9kyBvEAcJP+Mjglgh0jiypa08mnVtrId sqNxg3DOXvjtTfwd+ZEWDMOIZrLnJ2bpqTaQaGiQWNILcS+DD6PgylfdZXMbyQyuLcAB3Teu0B +R8= X-SBRS: 5.1 X-MesageID: 47744962 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:o2uHR68Wgs1wYCNCFjhuk+DcI+orL9Y04lQ7vn2ZOiYlF/Bw9v re+MjzsCWetN9/YgBGpTn+AtjifZqxz/JICPAqTNWftWrd1ldATrsSi7cKqgeIc0fDH4Vmup uIHZISNDQlNzlHZbCW2mmFL+o= X-IronPort-AV: E=Sophos;i="5.83,314,1616472000"; d="scan'208";a="47744962" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Qsj8wdjrnLSeB62sRJPBATB+PmcPbbsIKZxXIKzvMAsYIUX3knIA+qAwP8myydXAsQgbqWuB31zYD4JRE9GPLTIhAUMOcMJJxUDuvgduUUCFTu3vkF02iJxH8je9t7zrPbsdsMbvAf9T5iHmHBSQHiIq8xVjKB0TjsH06iPXjIkJSLp20hIYtVegA+Qax8DSfOTLUooPF9n4Yz/zhDwK33Vl2Mi04MYPE0Z+jNORviYiifl36d9ahbRD/Kt5amfeZ5KovsLbitL3o2bU650ZQJxq2Q0OFBkX4aVxfdwb02RtHiRQcVO31JgwEFTU1fxm9sEk2voiEjZug4it/YQSPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IKAGF7D6OKxUEI5hSQIjI5M/65C8tk+mCvXLhbx6tbY=; b=itXhyXAywnUWEN6nFasFPBC1mHu2kzqWDzqgkKtCjcmCbC15HHnmQV7yV6jgFcsoEp6rvWrqqjUbnuz8sKbQREu8J0dG3K+imDppkXchqmgDodPZgKOwQVu1JIUo+225j3E7iaGxwjEhs0NwKIdQYKMCP5VW/rx1qejuJQjwwL1CzkmslHZbiO3T20fRZ4joKRtigDLOcJ20Ar/o3McVrPq9y3BUBpkIZeYq7U9VqOKlBuhFexXtqBNbJzZy1VEY1u0zC+vPEZAsZ9hjkRjYI5M19lFpMiDZJdu2lnP1dPw8w0JY7RX4yAYNSm7Ve5Gvt4IuAfw/25fdQ5wCfatzQQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IKAGF7D6OKxUEI5hSQIjI5M/65C8tk+mCvXLhbx6tbY=; b=MM7dXUJ3+oAnp0omN7DNpvNWdV1qDKfS3aIW5XNLvy2SKk8QCKA5UZkMk2robbYViTtUoLEOg4COKu2vRCnharGuISOW3vSY0TRmiwpFm+9MpbZaQ1qr1RjTqsoCbOcLOyGTsxs6m1dYkT6ZRZ1s8X5q/IUGhoGNbGbK47A5ATg= To: Olaf Hering CC: References: <20210701125623.593fe3ae.olaf@aepfle.de> <20e828c9-e7dc-4401-9307-a6d72eb618d8@citrix.com> <20210701133628.1667a344.olaf@aepfle.de> From: Andrew Cooper Subject: Re: XEN_SYSCTL_cpu_policy_hvm_default truncates leaf count Message-ID: <67f50c0d-753c-936e-bf1e-11a708150851@citrix.com> Date: Thu, 1 Jul 2021 13:35:20 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 In-Reply-To: <20210701133628.1667a344.olaf@aepfle.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-GB X-ClientProxiedBy: LO4P123CA0026.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:151::13) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fa32f038-ec66-49b6-20d7-08d93c8cb472 X-MS-TrafficTypeDiagnostic: BYAPR03MB3861: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bS1F6UHvmS6Ds3QJm6QgphrcsqALKQis5LlwFRr6ct3gjBRJep7VhfsMub0B59KraqJVlBd36Af2KwsWgTunbC1om77BhHtQ/L47MYCbuoVn4QBbzUAS2mBfKLBX/0CcuZg3PT1DysDu0XGnemHq/HJqvZktBYqixBjFgwCM4VXn4AqZK3bQIy9UfHz2IBqJ0QGkPrXqSByZ9ZQD+ilLFhPbv37crzi5oIPL1HhN2ybcy9DtTraMPfbJZ2+gWQWy06J0XeDJoD7Nos6l6NFt3fJnyo547mFgimmSt7blYhM5AI6CYrzDbV1a6yD1Bdn8nBDUt8WXn4VvegbE/pXRIRFE9SIEo2PUQeCd4N0T/mljaYqKO4tgNMYpW7L9Nsd5PYapEhLa7H5ivKQajt1rXvmtTkVGWzKb5WaUj9fdiwcrAknYMB4duE2J82KlMmIY6PRA6a4HmkeSlmRw4FKpgmSqdX8+511VT+ivAMGSH08e6AjEleTq3rpJf5AlFSAErIYeVEbgH6glJWL1qzeQz+UJDCVkXsI8oD203rvaQEGHGw5Tl4XkgZfgf/boI+V/HqtbqPAuM2knoDVlfqzoj5dkxdLQsDZCiqKmIu5QAi3ZMsrjDJJBPDgnZ56PaK2vfYvJVwRVAv5qv4CrDw4DC76ZVbXhy6kCgI1MR2fUTCYCzkK8DAgGE3UJE9OM70x8WAUJn8LabE0OCW4+F7eUkJMVB/Wc30c1cdHRnwfFod4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(136003)(346002)(366004)(376002)(396003)(6916009)(4326008)(4744005)(2616005)(66476007)(16526019)(26005)(38100700002)(66946007)(53546011)(6486002)(956004)(16576012)(316002)(186003)(6666004)(31696002)(66556008)(2906002)(8936002)(8676002)(5660300002)(86362001)(83380400001)(36756003)(31686004)(478600001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UE9qUEQ0VmFsbmdicDJpOVdOMmdReFhQM1NJR2ppSWVUWjl0S3E4N0xRcFc2?= =?utf-8?B?VGlCMEFHYWJWMnpMQWNLWGdjZDFOUkJ6dkNyV0IwSlRRbXZXUVhqN201MGdJ?= =?utf-8?B?NytjMFhCV3haWG9Dc3k0T1hRazhLdUtUbUVkaC8xbUF1bG8ydzFHb1d3eDRJ?= =?utf-8?B?SzdzRkNGZndNekhQSm1hc2IwSm5zc1Y1NllqWjZWeFFRSnozS0JxdnI5bjRS?= =?utf-8?B?RjM5Q2pUTjZEWVdUeWU3MkdJd1JrcWNVMTdLMFFWNzFGRGxtb0dGbkVTeFpF?= =?utf-8?B?V3Zhc05aei9BNU9UQkNiSngwU0hjb0pGc2ZSSFAwVXcvWmZCRmFBSk0wbTk3?= =?utf-8?B?WkFvcGVRVUxLaGNxci9TV0Z2ZFZDWlBqcHRYMHpwUXZtMUR1MDdoUjduRmpG?= =?utf-8?B?OTFjNVFScWM0SlM3WEcrMTJDVjlURGJQbU1Ga25XTXBja3llVExEZzYzNDhi?= =?utf-8?B?czV0dTYzZVdFd01MS2RmSVBtakF5UFRXR1p5aU1QelF6eWNsTjJvSDBqNjA4?= =?utf-8?B?WlY5bWZWQ3NEK0xwdklHVlp4eUxOa1VXL0RQSWE2cDZwa3dUNWNpN3NsMVho?= =?utf-8?B?NUwwVGtZeUdvT2lieng3RXhReU1uVS9jQ1hTa1BUNDh3SXd0TWxsZTFtQzFB?= =?utf-8?B?b041cy9rL0dVYjhGNndHTnZQWVUyTitONHFRU2I4cDVWalMreTRyRmtlYWJM?= =?utf-8?B?d3RrUzVoNWxtaGZFdlJrVkpvamV0cmV2U3lxYy92enRpTERyc2JFZjZqc0V6?= =?utf-8?B?VE53ekNCRytRSXdZTS9qWW1xemUzN0lYYWJ0aDQ3OUN1OElxQ1ZYMk8xT2ZQ?= =?utf-8?B?UXEyU2FXMWo3SldvdExUalY5b3dDcVhZN0ZHelhBREFZRE1CSjl1QUN2SU5L?= =?utf-8?B?ODl4dm4zT1E1dkNFSnVJOE56RFVxbGppTitNekt4VHFBdVNxTEdjMlR3QXVn?= =?utf-8?B?MkwxYzM0aWhaS3JlSEJtTWNPTVBzRSt1akFSK3l2VFBNMWR5YnpvU2lScmJ6?= =?utf-8?B?YlZaakR5WVozdGFCVTdBU2lDZFRxa1laZVJpTXA3WDFZa09ZT1A5eFozNW1U?= =?utf-8?B?dnVPa2lNWTFWSk5HZ0JqV0JmekVzWXlYL1Yvc1BPb0VJZ014Mk0vcHVzQnd3?= =?utf-8?B?VzNhQ3FpOWJtRWdCL2w5NERHeVBvbVJWRHJDOHNtK2pWYUxObHhldDE2RUMx?= =?utf-8?B?OEpNVndkckJYV1ZHaWM0YURZNWdFdVJqcURwQnJZOHVrUXZPTytYZWZ2Qi9j?= =?utf-8?B?L29PcWQ3ZVlHQ2FhT0pFTFlUd3VVZGVFQnlMRkpFZXNOWmxpNHdBQWJEclpF?= =?utf-8?B?MFl1eGNtbytMWnI3ZnlSdGlQRVd0Wnkvc04xNDBCQzdyQWVVMEovNE1qY25X?= =?utf-8?B?R3JlQ2xQMmtVazBpS1Eva1hHMHYvWHN5Ry92WXFGWW43M052YmlLZVhrV1BI?= =?utf-8?B?ZzVmd0t3QlZFMmZiYk45ZVdtUE5iNmJzandPMWVDMlRza3dJZ1RyeUJvdkZr?= =?utf-8?B?TXZRUDJUSE42TlhFKzFBUmpRWXg5MWZEOW15a1Y2QjlaVFBmZVVrVWlxRGtR?= =?utf-8?B?UHZMR040dGJWMUwwWHlKcjNzbklyN1NidWhlTng1OFBmSEI1YVZXYUNvSmFw?= =?utf-8?B?NklycytuYzlnK0hKUS9jMC9DbUhKMmNsVW1jOXBoeGt0U2FkUWZxeXFNN0pn?= =?utf-8?B?eFZ5bmhkWk01Z2RZakZDWlNLSEQzbHRaL1RCVXpkY0hxUmhrQURCUmM2VUpi?= =?utf-8?Q?jad/msG43e7wxFGYFo3FGUaAZdwimpZa2Q8k1RJ?= X-MS-Exchange-CrossTenant-Network-Message-Id: fa32f038-ec66-49b6-20d7-08d93c8cb472 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jul 2021 12:35:27.3100 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5X6Ab17oDPzRCfQFjtITaRM3X6BoGqqlt4kgBAHID8HRv2U993I/bjgSjQZ57aWkaZ/WgRw17eMXPBa45jrwPCdEJw+v7btHr1xZkQjP+ek= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB3861 X-OriginatorOrg: citrix.com On 01/07/2021 12:36, Olaf Hering wrote: > Am Thu, 1 Jul 2021 12:19:24 +0100 > schrieb Andrew Cooper : > >> This *ought* to be "grab default, edit a few details, send back to >> Xen".=C2=A0 Where is the 51 leaves coming in?=C2=A0 Do you have cpuid=3D= lines in >> the xl cfg file? > No cpuid=3D or anything in domU.cfg or Xen cmdline. > If I understand x86_cpuid_copy_to_buffer correctly, it copies all of basi= c+extd and viridian+xen leaves, which is apparently more than 31. It will copy the subset based on things like max_leaf, etc. Can you grab xen-cpuid -p from this system please? ~Andrew From xen-devel-bounces@lists.xenproject.org Thu Jul 01 13:05:23 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 13:05:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148666.274726 (Exim 4.92) (envelope-from ) id 1lywNJ-0003aB-3h; Thu, 01 Jul 2021 13:05:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148666.274726; Thu, 01 Jul 2021 13:05:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lywNJ-0003a4-0h; Thu, 01 Jul 2021 13:05:01 +0000 Received: by outflank-mailman (input) for mailman id 148666; Thu, 01 Jul 2021 13:04:59 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lywNH-0003Zy-HD for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 13:04:59 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (unknown [40.107.6.77]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id eef0ed59-da6c-11eb-8315-12813bfff9fa; Thu, 01 Jul 2021 13:04:57 +0000 (UTC) Received: from DB3PR08CA0027.eurprd08.prod.outlook.com (2603:10a6:8::40) by VI1PR08MB3550.eurprd08.prod.outlook.com (2603:10a6:803:84::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.22; Thu, 1 Jul 2021 13:04:54 +0000 Received: from DB5EUR03FT052.eop-EUR03.prod.protection.outlook.com (2603:10a6:8:0:cafe::2d) by DB3PR08CA0027.outlook.office365.com (2603:10a6:8::40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.22 via Frontend Transport; Thu, 1 Jul 2021 13:04:54 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT052.mail.protection.outlook.com (10.152.21.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.22 via Frontend Transport; Thu, 1 Jul 2021 13:04:54 +0000 Received: ("Tessian outbound c836dc7aad98:v97"); Thu, 01 Jul 2021 13:04:54 +0000 Received: from 62cba1562938.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id A500274B-1F25-45E9-B540-386AFFCD65D0.1; Thu, 01 Jul 2021 13:04:21 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 62cba1562938.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 01 Jul 2021 13:04:21 +0000 Received: from PAXPR08MB6816.eurprd08.prod.outlook.com (2603:10a6:102:130::10) by PAXPR08MB6414.eurprd08.prod.outlook.com (2603:10a6:102:12e::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4264.18; Thu, 1 Jul 2021 13:04:19 +0000 Received: from PAXPR08MB6816.eurprd08.prod.outlook.com ([fe80::7cfd:a8eb:b25a:f025]) by PAXPR08MB6816.eurprd08.prod.outlook.com ([fe80::7cfd:a8eb:b25a:f025%7]) with mapi id 15.20.4264.026; Thu, 1 Jul 2021 13:04:18 +0000 Received: from smtpclient.apple (82.8.129.65) by LO2P265CA0356.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:d::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.21 via Frontend Transport; Thu, 1 Jul 2021 13:04:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: eef0ed59-da6c-11eb-8315-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qkfW9EFB2q2P7/g6zZD+KOXOcZxry0Qw1WOUthlY+AU=; b=KMmwUSWamm2G93bATLbdtbrwZqRTOeH6Dqjc8FCzczGX2xBQ6jX4VRa9f2xRISVIkOctkNrdbx3g6EaIlhRJMcGRCdxnsX2ybaDSmlB8S+dtoYWsd6thUQLgkUsV8I1uky8bujWLavPkUQ2frLkogJp640134sR8wtDvL+HJMxg= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: 1bce61ad77d499c2 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OAjmqtnOPV3pNsVwMTgnk3FVVW8IGjs4uYdUWFdQRtGgmORC+xALLLdfzo09ZPtBvoB4wQEqMkfSQPyKQTSYI9WbWzlPlcycfzx/w4rP006NobIugnf8R3uJErhXxQZHvuX4cLKOZXTOq2lkb2uT2+ZfdGRJDM0uCp1GiP/nlTvHxtCUPdf3FHbEYBDUmfdXEoAmL8PKHFxbSm0rZX6sW90jh18iw+3Oz4C/YYEMkIc2fhoTaOA5y2UNXVNXG4aJqRCFYRDCMmJHITj4caQkldOdr7cK23q+eoV+sWu+DvQLcME+8lAPexslx1QrAA7F9k4P45Q85Ulm8u5CJ2Qf2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qkfW9EFB2q2P7/g6zZD+KOXOcZxry0Qw1WOUthlY+AU=; b=lctB6daPaK074qTrjWz4FVwUlSaNJUjeCI4Woss0ZTBmIYRWPvfxTCBoBQygI511S44klfmdfyScMY0aM24jSVLfI+10ZPcvOuj54qEW/GTtbAyMaA325F9wbT9VLxwEJi5VwBISTkEzN2N1bTOivtiHWeju+UHN5aqBlB7yyG8VX3eydoaBWfkTv44TYRzC4FWqGLgu+if5X9PReNm6y1F9wzTgsX5MglP4WplkdzMsyz76pqGy7vOEwYHO1pJMPLBmEbW6llv6AURK7fhwRB2g7m99rOdEpOX5cM7wNcqrgnqXQolJrn4qbgrYepqZGJwFl1TjRKITs4YrKWcGJg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qkfW9EFB2q2P7/g6zZD+KOXOcZxry0Qw1WOUthlY+AU=; b=KMmwUSWamm2G93bATLbdtbrwZqRTOeH6Dqjc8FCzczGX2xBQ6jX4VRa9f2xRISVIkOctkNrdbx3g6EaIlhRJMcGRCdxnsX2ybaDSmlB8S+dtoYWsd6thUQLgkUsV8I1uky8bujWLavPkUQ2frLkogJp640134sR8wtDvL+HJMxg= Authentication-Results-Original: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=arm.com; Content-Type: text/plain; charset=utf-8 Subject: Re: [PATCH v6 6/9] docs: add doxygen preprocessor and related files From: Luca Fancellu In-Reply-To: Date: Thu, 1 Jul 2021 14:04:11 +0100 Cc: xen-devel@lists.xenproject.org, Bertrand Marquis , wei.chen@arm.com, Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Julien Grall , Wei Liu Content-Transfer-Encoding: quoted-printable Message-Id: <5D3534B9-30AC-484F-B2CF-02822D3D1226@arm.com> References: <20210510084105.17108-1-luca.fancellu@arm.com> <20210510084105.17108-7-luca.fancellu@arm.com> To: Stefano Stabellini X-Mailer: Apple Mail (2.3654.100.0.2.22) X-Originating-IP: [82.8.129.65] X-ClientProxiedBy: LO2P265CA0356.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:d::32) To PAXPR08MB6816.eurprd08.prod.outlook.com (2603:10a6:102:130::10) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3dba9457-aec9-4f1b-3dff-08d93c90d20f X-MS-TrafficTypeDiagnostic: PAXPR08MB6414:|VI1PR08MB3550: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:6108;OLM:6108; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: XZOS+bvUR2FfY1emeJGouVdbxzw4GOrmwlZ2NqUdoHUGRpzWvbDkk9K3ZA/vzuoLks445PvEdZwangs+5L423wgnIJMOtsD0BiRTaRzrjQULwbgWEQSxT21NbiBzTvIn5Pboz6fYSCbDwM3wvIpN67aVTuM7oCDiLBbM3D75XPRr9gxlE1TCvmQt27i05KzgN/SOxIP/zvA45WC0QRCZgYQpVOu6IaRvZ7lvdU9ap5apq7IJadDlUrXosh8Rox/Qx3dni12iuPG1ufA3d3ZPqYpXp2oJCt//bQgX427NbsOjxW59jNldrGLBsgls845L+HThrdQrlkpFZOddMHfg2MgpVPlgUeaqAEp90c93XLAJmncg8NBdbNFa8qAkyD8bcbTQWrfahpTGibFuYfIcKuZh6xgkIB0OJuYRLYfu6G73TWzKPeFiZ+IjQuTouqWpbkqWT/uZvcl6/TGCf8W7h1aPnpL2XtuQwpsxoLVf+uof6P8Dd/oSTyLa19CnQ1W5tsBQYk65tZ5I/jNZnwEjns6WkJLIIZmUBd8iM4oc7Ei4vQAeSZ+RvRT0XZnsflZwUCWWhkBp0Vf7XGbjJz4BuUBaHsykdAxdT6kyyXfki1tk4HufygD01fiDLRYESWWp+8eg2AFofhnJ+TOpQqLa9FSldXZO4AN7nQBPUVbF72ZO+0p0f/7ZO5BYrEMLOTaaQps+6AS/QAGa7TQMaxiiU2/Q+XjyI90Lt3Q4d6/JDjc= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB6816.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(136003)(366004)(346002)(39850400004)(376002)(478600001)(186003)(316002)(6512007)(6666004)(38350700002)(16526019)(6486002)(4326008)(54906003)(5660300002)(53546011)(38100700002)(83380400001)(66946007)(956004)(33656002)(86362001)(26005)(6506007)(44832011)(8676002)(66556008)(2906002)(66476007)(6916009)(2616005)(36756003)(8936002)(52116002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UnV4QlhDbFliK0hHQTdRWVh6N242RkNKaUNXTUtQUnk5UmIzdktad2loSEN3?= =?utf-8?B?TVlHTHlsa0pWTFpZUGIrbkMxaHhFU2hiZ2pndXgrdkhuUEtLazJnNmZMQTlx?= =?utf-8?B?d0szeXpjdzBkc2tQSzVUWXFUOS9lUHBaRHpvbDZDcmJHR1l4WFNnMmZRUzA4?= =?utf-8?B?cWoyajBlWmNzczdjTmdCM2VhSjZuM21QaDRVT2ZUaDNVMDNRdllrWkdaQ2d4?= =?utf-8?B?dVNveE5lcUJvbnFyUDlYQVVDbExkV0hwam5VOHVTNXdXSG8rU1p5MzdFUmdJ?= =?utf-8?B?c1F6alJWZTJyN0pPVGt3SzhyRWFhcEVMVWhoL3ppTk9kOEU1ZnQ2ZDJIRDZr?= =?utf-8?B?THRyMVVlYUppMUlMRDhjSzY4NXo0dG1KbitvWXk0cW4zUlI5eGF0VTd2cWpD?= =?utf-8?B?NlZwcHowdHJRMzZ4VnkyZE9lVHgvenZDUDBwdWtaU3lJbURCc2xTRmJHR3ZC?= =?utf-8?B?bUpUYm45SUxLZmFRRTdiV0NrVWhESk1HNDVGL2xNMXpzVm1MNS9aVVB3ZnFv?= =?utf-8?B?aG41ck5Ud3RDUXJKVExjVVhabnN1NGIydDByUTNBOVc0bjlva3RraFZtY0cz?= =?utf-8?B?VmJrU2RIZnBFZkwzc2lQOExVWVFZbXhXUWNBL2QxVkVEMm03R3l5RVdCNlp3?= =?utf-8?B?SzVScGViZUdFUlpUVlFUeGk5aVhyZkplMGRvMzJRckQ2OTlBQVF5R3V2b2xh?= =?utf-8?B?WWpwRGd2WFNuZzE4a1oyVEI4cTl1Qk9JTjhlN2JNa1FwdTBrb29icHBuV1hB?= =?utf-8?B?ZmpvdnFOQStEd1BFekMralB2ZjJzN3lMUXFiOEg1NC9VM1lyNkJ0OVBBSURK?= =?utf-8?B?amFQdzhjaVVnOC9JM09tdkRKTS9wSVJMRk1QdndJZ1Z2R3dvSFFhVkZpTXNO?= =?utf-8?B?dmpWcHRnZU9ScldSZS9JcHdRSmpUQVRIUU94WERGdzlPbTNSeWFTcVczZzdv?= =?utf-8?B?WFk0Z25zbHNjWDJpalErTGY5bHdnc1pTbkxLWHNaOVVFU0poWVBKMWI1USsy?= =?utf-8?B?a2V0VVBwODVsclhWakhiVlpOTzJONEYvaWp4R1ZMcGpUYUYxaldoVnhML1RM?= =?utf-8?B?MlRuM0k4WW5PWHZVL1BmTzN5VEMvaTYxQjJvNmx2ekw5Mkd2cTQ5ZUJOSXdJ?= =?utf-8?B?U1VSdVJ5RUQyMTEvRjJFcUlGN3VIaC9UeWdxdGJhb0JOWEdVd1BkTUdnWGNF?= =?utf-8?B?N3daOTlMclRuZTZWQnlIcjUzRUZDenEwZ2YvTU5KVWh5UWpIUmgyWkNIZmlp?= =?utf-8?B?eWlOUEEvZTQ3dCtPeElBSmVMbEIvS2Jpd3kwSzFCS2pNdE0yRWpaMUFyMVJB?= =?utf-8?B?U0gwaDFJbmNjd01DbUx6bjl6dCsxQ0M5d1hvanFlOGRiamJaZGNWVXRsUkNE?= =?utf-8?B?Mk9GS0FpQzhpN0I1UyttZGNWZ25TK0RHRk1MWnAySWJmMGNMSkpITlFucTFH?= =?utf-8?B?MWw4eWVQaktQYVFpZmFDeGhsM2JmS0drSDB1L1pKcEh5Q2xZbWFxRXQ0SWZZ?= =?utf-8?B?Z2FvOFNxV3lOUmp4aTVRZXh1R3pTWFlnanBwc2Z6UXpVY3VHdDdiS2hPaTZl?= =?utf-8?B?Sm9DWjJWaFdqeG5Kc2pvelRFWndYWmZ1NzRHNnovcnF1UUVVZUJCUE0vYmJh?= =?utf-8?B?SjB4TnNGdDAvQkowSGtkOGdDUUdlbWFxQlF4M2NkdGFhSytVT3EwYXliRnRk?= =?utf-8?B?NHRNRnBIUVo1Y3UyZU53SXZyazFWR2R2R0JoSEdHdTQ4NnRCUC9nNUtuMkZZ?= =?utf-8?Q?Ex9Y7BtLj/fEKTTAgI/Oz1lpg4i2XClsEhxkQz2?= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6414 Original-Authentication-Results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT052.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 384fa76a-92bd-442c-65b3-08d93c90bc43 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vwIG/kIHqNdIHIiYmKBAM+Bc23G0H88UqKgK9iOUaUkwleFfD+ybXbDMuHdkcd0yp0TRehz6ezZJTlOtsrFaJgC2cidSOMpQuAnV6l4ffwGTIUVDhtaXd3Qk2paLRlr3rSqcLDHVY+iPpp3WciRPfWhxQL3zqlgLD9CFouSXxBUg+Vh3KGFL8ziQJh9ZOvZDM5Bx61F21Y6QTZpjWHfXPiYqjI6yj6cJOB+uigjwnr85YM6LFkMYES2hET6+Dw3GSwsnwbfBkqZU3aHPM8Icrc3UD0P0ybAm5Fztb+hMXZfSlWclQT1XOIgurimp6qNOHZevN06nDoyA16tGWvEcT3ByAmZeCqJKJHoTmoo8pQJi075/pC/YuKQlbb+oBXu3zfaFcU8c1GUP4sIjU6FfZJ5wnTn/r+7an2DvMmFQVG/LHGX6AfPS0gwtrTSkMrKoQku8BCXp43Kll/Pm7IA2ny2/sJAYwKswY5zjDUWUk+LvdLJypTen07tnWQYT211yCmooxhNU5SjIXZEAgBu/P1pOsiTdfDpTXiTLZ2bPmObSJeudLckUrxHUf5WlPnT80yKCpoSQTAjAp3lvjKyCf/dpTjAgJhENhXdXh8i2Di2zsascoMnCQ+DwXPpVXBICJxzx4RD7dLW5I/Xy6FeT59o1rzAGeUzXSq9lb3K53GBJX1qZzT88HQ8W9LpRLt5c2eXVE/zmbfa9Sj+4snrb5Q== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(39850400004)(376002)(136003)(346002)(396003)(46966006)(36840700001)(4326008)(82310400003)(6512007)(336012)(2906002)(6486002)(956004)(36860700001)(44832011)(47076005)(2616005)(33656002)(54906003)(83380400001)(82740400003)(81166007)(26005)(53546011)(6506007)(70586007)(8936002)(8676002)(86362001)(6666004)(6862004)(36756003)(5660300002)(70206006)(356005)(186003)(478600001)(316002)(16526019);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jul 2021 13:04:54.6737 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3dba9457-aec9-4f1b-3dff-08d93c90d20f X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT052.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3550 > On 23 Jun 2021, at 23:03, Stefano Stabellini wro= te: >=20 > On Mon, 10 May 2021, Luca Fancellu wrote: >> Add preprocessor called by doxygen before parsing headers, >> it will include in every header a doxygen_include.h file >> that provides missing defines and includes that are >> usually passed by the compiler. >>=20 >> Add doxy_input.list that is a text file containing the >> relative path to the source code file to be parsed by >> doxygen. The path sould be relative to the xen folder: >> E.g. xen/include/public/grant_table.h >>=20 >> Signed-off-by: Luca Fancellu >> --- >> docs/xen-doxygen/doxy-preprocessor.py | 110 ++++++++++++++++++++++++++ >> docs/xen-doxygen/doxy_input.list | 0 >> docs/xen-doxygen/doxygen_include.h.in | 32 ++++++++ >> 3 files changed, 142 insertions(+) >> create mode 100755 docs/xen-doxygen/doxy-preprocessor.py >> create mode 100644 docs/xen-doxygen/doxy_input.list >> create mode 100644 docs/xen-doxygen/doxygen_include.h.in >>=20 >> diff --git a/docs/xen-doxygen/doxy-preprocessor.py b/docs/xen-doxygen/do= xy-preprocessor.py >> new file mode 100755 >> index 0000000000..496899d8e6 >> --- /dev/null >> +++ b/docs/xen-doxygen/doxy-preprocessor.py >> @@ -0,0 +1,110 @@ >> +#!/usr/bin/python3 >> +# >> +# Copyright (c) 2021, Arm Limited. >> +# >> +# SPDX-License-Identifier: GPL-2.0 >> +# >> + >> +import os, sys, re >> + >> + >> +# Variables that holds the preprocessed header text >> +output_text =3D "" >> +header_file_name =3D "" >> + >> +# Variables to enumerate the anonymous structs/unions >> +anonymous_struct_count =3D 0 >> +anonymous_union_count =3D 0 >> + >> + >> +def error(text): >> + sys.stderr.write("{}\n".format(text)) >> + sys.exit(1) >> + >> + >> +def write_to_output(text): >> + sys.stdout.write(text) >> + >> + >> +def insert_doxygen_header(text): >> + # Here the strategy is to insert the #include i= n the >> + # first line of the header >> + abspath =3D os.path.dirname(os.path.abspath(__file__)) >> + text +=3D "#include \"{}/doxygen_include.h\"\n".format(abspath) >> + >> + return text >> + >> + >> +def enumerate_anonymous(match): >> + global anonymous_struct_count >> + global anonymous_union_count >> + >> + if "struct" in match.group(1): >> + label =3D "anonymous_struct_%d" % anonymous_struct_count >> + anonymous_struct_count +=3D 1 >> + else: >> + label =3D "anonymous_union_%d" % anonymous_union_count >> + anonymous_union_count +=3D 1 >> + >> + return match.group(1) + " " + label + " {" >> + >> + >> +def manage_anonymous_structs_unions(text): >> + # Match anonymous unions/structs with this pattern: >> + # struct/union { >> + # [...] >> + # >> + # and substitute it in this way: >> + # >> + # struct anonymous_struct_# { >> + # [...] >> + # or >> + # union anonymous_union_# { >> + # [...] >> + # where # is a counter starting from zero, different between struct= s and >> + # unions >> + # >> + # We don't count anonymous union/struct that are part of a typedef = because >> + # they don't create any issue for doxygen >> + text =3D re.sub( >> + "(?> + enumerate_anonymous, >> + text, >> + flags=3Dre.S >> + ) Hi Stefano, >=20 > My python is a bit rusty but I thought this is really clever! >=20 > One question: given that anonymous_struct_count is local per file being > processed, it always starts at 0 for each header. I think that is > actually better from a documentation readability point of view. >=20 > However, is it possible that Doxygen gets confused in a case where we > can multiple "struct anonymous_struct_0", e.g. one for grant_table.h, > one for event_channel.h, etc. ? Yes this is a very good point, I did some experiment and it can happen, how= ever so far we didn=E2=80=99t notice any problem because all the anonymous union/struct were part of other data stru= cture, in that case there is no problem at all because we have upper_data_structure::anonymous_{struct/unio= n}_0/1/2=E2=80=A6 So given the fact that is difficult to have clash, I would say we can handl= e any future case separately. Having a global numbering can solve the issue but because the script is cal= led separately for each header, Implementing it will involve some changes, there should be a file to mainta= in the number across invocation and so on. Let me know what do you think about that and if in your opinion we can proc= eed the way it is now. Cheers, Luca From xen-devel-bounces@lists.xenproject.org Thu Jul 01 13:15:44 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 13:15:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148673.274737 (Exim 4.92) (envelope-from ) id 1lywXb-00056A-8c; Thu, 01 Jul 2021 13:15:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148673.274737; Thu, 01 Jul 2021 13:15:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lywXb-000563-5O; Thu, 01 Jul 2021 13:15:39 +0000 Received: by outflank-mailman (input) for mailman id 148673; Thu, 01 Jul 2021 13:15:38 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lywXa-00055x-6d for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 13:15:38 +0000 Received: from mo4-p00-ob.smtp.rzone.de (unknown [85.215.255.24]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 173f5661-7eed-4ab8-9411-85344c6e75a6; Thu, 01 Jul 2021 13:15:36 +0000 (UTC) Received: from sender by smtp.strato.de (RZmta 47.28.1 AUTH) with ESMTPSA id 30791cx61DFY6p7 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Thu, 1 Jul 2021 15:15:34 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 173f5661-7eed-4ab8-9411-85344c6e75a6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1625145335; s=strato-dkim-0002; d=aepfle.de; h=References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Cc:Date: From:Subject:Sender; bh=VUOe4fD/9EB6E2UIF6q276ktoXEd68aVUwnt106S2n8=; b=XGTlNS8dM8WpPYBxTisbx9wciJxLSBTlGvfdM4LURUjZTVgF2hOIAg6uzp41BnXT+x jTP7yXgnRDycuyLeq4f97oYW7UC2kz1ez+rYRkvug7o7aTH5b9D9vDIMtXdXYpf5yhM8 KynSLBEID477Hp/9c+or/78v6r9QxdNHclWws+vTInVlvrjPK0dK3accYHD1ZmgP8OPA Ny9wZ5Q0pwjQhzeOmtfu175e912BFUPrBY711AHUmX2KPNIpTs5DYBTHPw/aJ2laJvAM POMAI+9CjQpJHPSAqj9yyUuofBvSUIa3CYJssWtL1exxTTS2vQdCirPcGrOZEiJ69cnG bf/Q== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QLpd5ylWvMDX3y/OuD5rXVisQsBBSIa03sY9BUY2ao0oygRsMfcqA6zjDLeeWXNg==" X-RZG-CLASS-ID: mo00 Date: Thu, 1 Jul 2021 15:15:28 +0200 From: Olaf Hering To: Andrew Cooper Cc: Subject: Re: XEN_SYSCTL_cpu_policy_hvm_default truncates leaf count Message-ID: <20210701151528.08d1f503.olaf@aepfle.de> In-Reply-To: <67f50c0d-753c-936e-bf1e-11a708150851@citrix.com> References: <20210701125623.593fe3ae.olaf@aepfle.de> <20e828c9-e7dc-4401-9307-a6d72eb618d8@citrix.com> <20210701133628.1667a344.olaf@aepfle.de> <67f50c0d-753c-936e-bf1e-11a708150851@citrix.com> X-Mailer: Claws Mail 2021.05.27 (GTK+ 2.24.32; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/dPfTf=+Bc/xAS28jgJQu.9b"; protocol="application/pgp-signature"; micalg=pgp-sha256 --Sig_/dPfTf=+Bc/xAS28jgJQu.9b Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Am Thu, 1 Jul 2021 13:35:20 +0100 schrieb Andrew Cooper : > Can you grab xen-cpuid -p from this system please? Two PowerEdge T320 with E5-2430L. Xen reports there are maximum 119 leaves and 2 MSRs Raw policy: 32 leaves, 2 MSRs CPUID: leaf subleaf -> eax ebx ecx edx =20 00000000:ffffffff -> 0000000d:756e6547:6c65746e:49656e69 00000001:ffffffff -> 000306e4:00200800:7fbee3ff:bfebfbff 00000002:ffffffff -> 76036301:00f0b2ff:00000000:00ca0000 00000004:00000000 -> 3c004121:01c0003f:0000003f:00000000 00000004:00000001 -> 3c004122:01c0003f:0000003f:00000000 00000004:00000002 -> 3c004143:01c0003f:000001ff:00000000 00000004:00000003 -> 3c07c163:04c0003f:00002fff:00000006 00000005:ffffffff -> 00000040:00000040:00000003:00001120 00000006:ffffffff -> 00000077:00000002:00000001:00000000 00000007:00000000 -> 00000000:00000281:00000000:9c000400 0000000a:ffffffff -> 07300403:00000000:00000000:00000603 0000000b:00000000 -> 00000001:00000002:00000100:00000000 0000000b:00000001 -> 00000005:0000000c:00000201:00000000 0000000d:00000000 -> 00000007:00000340:00000340:00000000 0000000d:00000001 -> 00000001:00000000:00000000:00000000 0000000d:00000002 -> 00000100:00000240:00000000:00000000 80000000:ffffffff -> 80000008:00000000:00000000:00000000 80000001:ffffffff -> 00000000:00000000:00000001:2c100800 80000002:ffffffff -> 20202020:746e4920:52286c65:65582029 80000003:ffffffff -> 52286e6f:50432029:35452055:3334322d 80000004:ffffffff -> 76204c30:20402032:30342e32:007a4847 80000006:ffffffff -> 00000000:00000000:01006040:00000000 80000007:ffffffff -> 00000000:00000000:00000000:00000100 80000008:ffffffff -> 0000302e:00000000:00000000:00000000 MSRs: index -> value =20 000000ce -> 0000000080000000 0000010a -> 0000000000000000 Host policy: 31 leaves, 2 MSRs CPUID: leaf subleaf -> eax ebx ecx edx =20 00000000:ffffffff -> 0000000d:756e6547:6c65746e:49656e69 00000001:ffffffff -> 000306e4:00200800:77bee3ff:bfebfbff 00000002:ffffffff -> 76036301:00f0b2ff:00000000:00ca0000 00000004:00000000 -> 3c004121:01c0003f:0000003f:00000000 00000004:00000001 -> 3c004122:01c0003f:0000003f:00000000 00000004:00000002 -> 3c004143:01c0003f:000001ff:00000000 00000004:00000003 -> 3c07c163:04c0003f:00002fff:00000006 00000007:00000000 -> 00000000:00000281:00000000:9c000400 0000000d:00000000 -> 00000007:00000000:00000340:00000000 0000000d:00000001 -> 00000001:00000000:00000000:00000000 0000000d:00000002 -> 00000100:00000240:00000000:00000000 80000000:ffffffff -> 80000008:00000000:00000000:00000000 80000001:ffffffff -> 00000000:00000000:00000001:2c100800 80000002:ffffffff -> 20202020:746e4920:52286c65:65582029 80000003:ffffffff -> 52286e6f:50432029:35452055:3334322d 80000004:ffffffff -> 76204c30:20402032:30342e32:007a4847 80000006:ffffffff -> 00000000:00000000:01006040:00000000 80000007:ffffffff -> 00000000:00000000:00000000:00000100 80000008:ffffffff -> 0000302e:00000000:00000000:00000000 MSRs: index -> value =20 000000ce -> 0000000080000000 0000010a -> 0000000000000000 PV Max policy: 31 leaves, 2 MSRs CPUID: leaf subleaf -> eax ebx ecx edx =20 00000000:ffffffff -> 0000000d:756e6547:6c65746e:49656e69 00000001:ffffffff -> 000306e4:00200800:f6b82203:1fc9cbf5 00000002:ffffffff -> 76036301:00f0b2ff:00000000:00ca0000 00000004:00000000 -> 3c004121:01c0003f:0000003f:00000000 00000004:00000001 -> 3c004122:01c0003f:0000003f:00000000 00000004:00000002 -> 3c004143:01c0003f:000001ff:00000000 00000004:00000003 -> 3c07c163:04c0003f:00002fff:00000006 00000007:00000000 -> 00000000:00000201:00000000:8c000400 0000000d:00000000 -> 00000007:00000000:00000340:00000000 0000000d:00000001 -> 00000001:00000000:00000000:00000000 0000000d:00000002 -> 00000100:00000240:00000000:00000000 80000000:ffffffff -> 80000008:00000000:00000000:00000000 80000001:ffffffff -> 00000000:00000000:00000001:28100800 80000002:ffffffff -> 20202020:746e4920:52286c65:65582029 80000003:ffffffff -> 52286e6f:50432029:35452055:3334322d 80000004:ffffffff -> 76204c30:20402032:30342e32:007a4847 80000006:ffffffff -> 00000000:00000000:01006040:00000000 80000007:ffffffff -> 00000000:00000000:00000000:00000100 80000008:ffffffff -> 0000302e:00001000:00000000:00000000 MSRs: index -> value =20 000000ce -> 0000000080000000 0000010a -> 0000000000000000 HVM Max policy: 31 leaves, 2 MSRs CPUID: leaf subleaf -> eax ebx ecx edx =20 00000000:ffffffff -> 0000000d:756e6547:6c65746e:49656e69 00000001:ffffffff -> 000306e4:00200800:f7ba2223:1fcbfbff 00000002:ffffffff -> 76036301:00f0b2ff:00000000:00ca0000 00000004:00000000 -> 3c004121:01c0003f:0000003f:00000000 00000004:00000001 -> 3c004122:01c0003f:0000003f:00000000 00000004:00000002 -> 3c004143:01c0003f:000001ff:00000000 00000004:00000003 -> 3c07c163:04c0003f:00002fff:00000006 00000007:00000000 -> 00000000:00000281:00000000:9c000400 0000000d:00000000 -> 00000007:00000000:00000340:00000000 0000000d:00000001 -> 00000001:00000000:00000000:00000000 0000000d:00000002 -> 00000100:00000240:00000000:00000000 80000000:ffffffff -> 80000008:00000000:00000000:00000000 80000001:ffffffff -> 00000000:00000000:00000001:2c100800 80000002:ffffffff -> 20202020:746e4920:52286c65:65582029 80000003:ffffffff -> 52286e6f:50432029:35452055:3334322d 80000004:ffffffff -> 76204c30:20402032:30342e32:007a4847 80000006:ffffffff -> 00000000:00000000:01006040:00000000 80000007:ffffffff -> 00000000:00000000:00000000:00000100 80000008:ffffffff -> 0000302e:00101000:00000000:00000000 MSRs: index -> value =20 000000ce -> 0000000080000000 0000010a -> 0000000000000000 PV Default policy: 31 leaves, 2 MSRs CPUID: leaf subleaf -> eax ebx ecx edx =20 00000000:ffffffff -> 0000000d:756e6547:6c65746e:49656e69 00000001:ffffffff -> 000306e4:00200800:f6b82203:1fc9cbf5 00000002:ffffffff -> 76036301:00f0b2ff:00000000:00ca0000 00000004:00000000 -> 3c004121:01c0003f:0000003f:00000000 00000004:00000001 -> 3c004122:01c0003f:0000003f:00000000 00000004:00000002 -> 3c004143:01c0003f:000001ff:00000000 00000004:00000003 -> 3c07c163:04c0003f:00002fff:00000006 00000007:00000000 -> 00000000:00000201:00000000:8c000400 0000000d:00000000 -> 00000007:00000000:00000340:00000000 0000000d:00000001 -> 00000001:00000000:00000000:00000000 0000000d:00000002 -> 00000100:00000240:00000000:00000000 80000000:ffffffff -> 80000008:00000000:00000000:00000000 80000001:ffffffff -> 00000000:00000000:00000001:28100800 80000002:ffffffff -> 20202020:746e4920:52286c65:65582029 80000003:ffffffff -> 52286e6f:50432029:35452055:3334322d 80000004:ffffffff -> 76204c30:20402032:30342e32:007a4847 80000006:ffffffff -> 00000000:00000000:01006040:00000000 80000008:ffffffff -> 0000302e:00001000:00000000:00000000 MSRs: index -> value =20 000000ce -> 0000000080000000 0000010a -> 0000000000000000 HVM Default policy: 31 leaves, 2 MSRs CPUID: leaf subleaf -> eax ebx ecx edx =20 00000000:ffffffff -> 0000000d:756e6547:6c65746e:49656e69 00000001:ffffffff -> 000306e4:00200800:f7ba2203:1fcbfbff 00000002:ffffffff -> 76036301:00f0b2ff:00000000:00ca0000 00000004:00000000 -> 3c004121:01c0003f:0000003f:00000000 00000004:00000001 -> 3c004122:01c0003f:0000003f:00000000 00000004:00000002 -> 3c004143:01c0003f:000001ff:00000000 00000004:00000003 -> 3c07c163:04c0003f:00002fff:00000006 00000007:00000000 -> 00000000:00000281:00000000:9c000400 0000000d:00000000 -> 00000007:00000000:00000340:00000000 0000000d:00000001 -> 00000001:00000000:00000000:00000000 0000000d:00000002 -> 00000100:00000240:00000000:00000000 80000000:ffffffff -> 80000008:00000000:00000000:00000000 80000001:ffffffff -> 00000000:00000000:00000001:2c100800 80000002:ffffffff -> 20202020:746e4920:52286c65:65582029 80000003:ffffffff -> 52286e6f:50432029:35452055:3334322d 80000004:ffffffff -> 76204c30:20402032:30342e32:007a4847 80000006:ffffffff -> 00000000:00000000:01006040:00000000 80000008:ffffffff -> 0000302e:00101000:00000000:00000000 MSRs: index -> value =20 000000ce -> 0000000080000000 0000010a -> 0000000000000000 --Sig_/dPfTf=+Bc/xAS28jgJQu.9b Content-Type: application/pgp-signature Content-Description: Digitale Signatur von OpenPGP -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEE97o7Um30LT3B+5b/86SN7mm1DoAFAmDdv/AACgkQ86SN7mm1 DoAn2Q/9HgV8MwFT1qRJIr38MAahDjeqntfhTfmUjZe39MIfb6NHKY520NQg/BM8 XltxWN0jKP8yKcHBtSXQZIhkndgYWVhbvHjRhHaCUyaHPO9ZwQG5Y9pV6K0CNwoT mkifrC0WxSHwxuWBSdQU/zyUJVdvMSbwJ5g0uzALP8zRueiz7Gfqj1h+WJ2RWlM4 fLLX+OSAf/Txzyl6C4eZl/nykSLv1iH5FQ3ebO7G2yCfb1nMSd9wPWj2hiQQVj6j oinGV97fMUtBjDKE/ttyCRgFuW1LGLyvd2wsvTCoD+tX3Jaeoo7VIcwKeSA3um8S YUIniMd5y3D53FwKtyb7NpC6DeIC2/woetqRZ/qIVNPzdC29qIlTgukEp2ortxrX vh2fjEg7cAFlLB6Y1nKzxIbIVz1TEhSRSeoyukU+wHX79X/Ww1N02EgFyIavOjiI kc5v6f0xbcMyCifjk+fwhXXRbc0Ss9MzGf5mY4fH/y6VKKv4BKyonYW9XTRcNxu5 VEdRWhV2cc4sMljFCsr/JCUAE/usb803GIuP3srQY5KZ1lej7LuI+qJFNdsX5lS0 e6zjUEQUj9s0wsjCZCCuBT8EHZ2HjJh4BByoSMd2VNJRaP9+e/JzXlY0kD+ywe83 jGqtJdjtlMzkrSvL1OKKyDUyZTU1ElUshwEl9quzwUhUMldL2/A= =usa2 -----END PGP SIGNATURE----- --Sig_/dPfTf=+Bc/xAS28jgJQu.9b-- From xen-devel-bounces@lists.xenproject.org Thu Jul 01 13:37:59 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 13:37:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148678.274749 (Exim 4.92) (envelope-from ) id 1lywt6-0007P2-T4; Thu, 01 Jul 2021 13:37:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148678.274749; Thu, 01 Jul 2021 13:37:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lywt6-0007Ov-Pb; Thu, 01 Jul 2021 13:37:52 +0000 Received: by outflank-mailman (input) for mailman id 148678; Thu, 01 Jul 2021 13:37:51 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lywt5-0007Op-4P for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 13:37:51 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (unknown [40.107.13.87]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 85c838ae-da71-11eb-831f-12813bfff9fa; Thu, 01 Jul 2021 13:37:48 +0000 (UTC) Received: from DB6PR0202CA0010.eurprd02.prod.outlook.com (2603:10a6:4:29::20) by DBAPR08MB5800.eurprd08.prod.outlook.com (2603:10a6:10:1a9::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4242.21; Thu, 1 Jul 2021 13:37:45 +0000 Received: from DB5EUR03FT011.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:29:cafe::5f) by DB6PR0202CA0010.outlook.office365.com (2603:10a6:4:29::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.21 via Frontend Transport; Thu, 1 Jul 2021 13:37:45 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT011.mail.protection.outlook.com (10.152.20.95) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.22 via Frontend Transport; Thu, 1 Jul 2021 13:37:45 +0000 Received: ("Tessian outbound f29a5a293366:v97"); Thu, 01 Jul 2021 13:37:45 +0000 Received: from 9c5152fe1225.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id BFA2122E-116F-4386-821D-CC30FC2A63B2.1; Thu, 01 Jul 2021 13:37:07 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 9c5152fe1225.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 01 Jul 2021 13:37:07 +0000 Received: from PAXPR08MB6816.eurprd08.prod.outlook.com (2603:10a6:102:130::10) by PAXPR08MB6735.eurprd08.prod.outlook.com (2603:10a6:102:138::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.23; Thu, 1 Jul 2021 13:37:05 +0000 Received: from PAXPR08MB6816.eurprd08.prod.outlook.com ([fe80::7cfd:a8eb:b25a:f025]) by PAXPR08MB6816.eurprd08.prod.outlook.com ([fe80::7cfd:a8eb:b25a:f025%7]) with mapi id 15.20.4264.026; Thu, 1 Jul 2021 13:37:05 +0000 Received: from smtpclient.apple (82.8.129.65) by LO4P123CA0104.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:191::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.22 via Frontend Transport; Thu, 1 Jul 2021 13:37:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 85c838ae-da71-11eb-831f-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZPq7tTnEUcaJiVPkylVzrXBdU6+dNvknwRZOA2iUTws=; b=QntHPWYSKzhDc6QLcsxr7s1sgf5J2I0LBw3TgxiRuDN7IDJqzLuPG8ePn/zF2bHil3+rpzhEcnhBLYTT8x3jl0cGq50wfBv0G2UA40Sfk89uQrOAgcqqQXOwA54fTWfHeR1v3xystXQBuhS1Vf20FaIvcaIB8k45pdvd2HB48pA= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: c784443f5173c14d X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=f9XKCYcweWI0VVELHkjaKCAG7aRohgBNyPvN3XM4CSNREPSgt0MDeTc/HcxoSvCYYI17kBU76kdFVqqgqRMVBtA0KqWtNDNTN5XusQv8nnEB9LNKdQL7F2p4VCzVfS3yRcGzLHARq0zD+rpdTU7odN5b3SEhkeVT5+MKHxH8ex1G9tht6NZ8e0g39FnXBXAxqjtdn7S96GxlanCeqlj2naxUYZ0wiBCJVC+tuMtxxlIt/o4pkZHKjCnS4ZyYg4RKCuqa7j5aQbrTx0vjmCvC5kkaoOYPlVzcLfIN81ANKa93E3KeX8QoKID73E6pu09H+CfS9GfHupfoaVEjE7vxJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZPq7tTnEUcaJiVPkylVzrXBdU6+dNvknwRZOA2iUTws=; b=fPoC+4PfqX6OaRKmlB5GDQOmPoDl/WFVIbZubY0OhlY/FAMoiw6W6sibfo1ZwbCMs8NtAcfabjT1UbZEa1XG7kjhTViJISRxnQ1tj7L9CUpQ3FuODt3XL/ZPdSEp8owy5fMnOFvMUET0zO3PQQExfvMduZmijcRkDZ9tIyK+gdkVQY8aCQf9bHxsjpn8mbWH7xn+C2+mDMZsxP0w9XO/mAQhDWjACi4W453Vcace1syDutoP92/cnx349uIhJ6ek8XTIQ0/g75lcDcoRzAMaBcNbsPMw1NrRbumNLvtdMdPx7uFA+mT26Jxk2Ts6o3GhXdYkOIXF837jk8HRGAaRCA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZPq7tTnEUcaJiVPkylVzrXBdU6+dNvknwRZOA2iUTws=; b=QntHPWYSKzhDc6QLcsxr7s1sgf5J2I0LBw3TgxiRuDN7IDJqzLuPG8ePn/zF2bHil3+rpzhEcnhBLYTT8x3jl0cGq50wfBv0G2UA40Sfk89uQrOAgcqqQXOwA54fTWfHeR1v3xystXQBuhS1Vf20FaIvcaIB8k45pdvd2HB48pA= Authentication-Results-Original: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=arm.com; Content-Type: text/plain; charset=utf-8 Subject: Re: [PATCH v6 7/9] docs: Change Makefile and sphinx configuration for doxygen From: Luca Fancellu In-Reply-To: Date: Thu, 1 Jul 2021 14:36:59 +0100 Cc: xen-devel@lists.xenproject.org, Bertrand Marquis , wei.chen@arm.com, Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Julien Grall , Wei Liu Content-Transfer-Encoding: quoted-printable Message-Id: <1FC1E8DF-8AED-4ABD-BE9A-DBBD9D66EDBB@arm.com> References: <20210510084105.17108-1-luca.fancellu@arm.com> <20210510084105.17108-8-luca.fancellu@arm.com> To: Stefano Stabellini X-Mailer: Apple Mail (2.3654.100.0.2.22) X-Originating-IP: [82.8.129.65] X-ClientProxiedBy: LO4P123CA0104.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:191::19) To PAXPR08MB6816.eurprd08.prod.outlook.com (2603:10a6:102:130::10) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1ae41800-3dd9-4e41-b110-08d93c9568e7 X-MS-TrafficTypeDiagnostic: PAXPR08MB6735:|DBAPR08MB5800: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:4941;OLM:4941; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: qL1dMJwDE7OqZNHXK78em6+jJje9hI7Fn2XX4k1AiM8ehDbbWBElbGIUf0PaGIPg9Zhx/xts/kUxZjIvLsH7vnYkD71s+Wup+XYSQwP5xhYvvKOFM3FNvpZPS1Imlj/NSqAJOyHenSBBEoRKk2mXoEdYbWpqw5p7hdhq3cJO8NZru9RvDYJaVcsChUn7g59rUkkoyzGWF5QumSlM4mBZhCh1kMRRDm9/ViJ+l56Ms8bUcLGqwNQJApswGdrSTOXJ6Zqzm9UR94YcPdSXRYES85QzS7u6hyM0uMGvryIpLFB+24g1PtcqfERqH78zQEuAgZkhEGhkXu04WeVQZsfQVtrLuGynha4k5FxQZCaib4RYzv5AAQ1a8lXH7B1cX8GoWf6ubm58bQAmpjdJyL9Ov3TY70iMb1Jot1knxFFMVUNdwD4GEXZDmO4zP3E0D9SeW21TaOmahePbmjpKLaNzdOiWqL70/PTJujHu8+IqixctO7n0c+OatKv18tJjEsBpxaN9NKzZZ1HUbvdDyx9EZTjTlkmoe2xYdpwdErz5CCIrPzJIBVCYhpZ4StxaLEW/q7JKbJKaKQnRfRoCNyWZLkY/6yUxXIGvxonnm4+KzuTaEMT8Wg+6o8ZiGAROVc+sWfz+DJv2LhoYhzlQF8I46GbpKTP46PEajcI/VblCLEtl2wGuyOmviNlfR9bonyWlMqFo5NPQmcA4F1sIhf9diiS2rvUmpm5jvp7Fw/d5DkkQIzWv4c8WxU5PQ4tEtBNH X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB6816.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(366004)(136003)(346002)(376002)(39850400004)(83380400001)(66476007)(956004)(44832011)(38350700002)(66556008)(66946007)(2616005)(38100700002)(186003)(16526019)(2906002)(6666004)(86362001)(316002)(5660300002)(53546011)(4326008)(6506007)(36756003)(6512007)(8676002)(26005)(8936002)(6486002)(478600001)(52116002)(33656002)(6916009)(54906003)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cFh4L2kwYzdOOER2V2l4azY3cE5PZ2VkV2FQNllSb2tIR21neWxiTnM5TlEv?= =?utf-8?B?ZTNodUl5MGEzcXpkaVcyTUFBNkM1azY1RVZxSG5KRlZ3Y29tRHRRUy9DQjVW?= =?utf-8?B?dTdCanB1WHNOZEowL3hIOXJ0QVVtOWRxUnducktYL1NsVjRZU2VCeWZ5dXhC?= =?utf-8?B?VVhEb1FNa0FTbnRCQVdDbGcyQWwvejMvd2JWZFJsMTNCbko0T2ZtamtYK29q?= =?utf-8?B?eWdaVVZiWDYvbUQ2bG5FUWdEY1htNlNSbi9OOVlyWWVBY3d3RkJGcmRheDZS?= =?utf-8?B?akNhRytyRHlub2lSRHh3R000L1FpMmgzb1c2ZDJVTmRBNUFSQVpSSFZOQ3Fs?= =?utf-8?B?OEIyaHcxS3RwT3pXNklYM2FUcllyOGcxQ2R2S0RLL2Zkd3cxenFVK1JkTnFK?= =?utf-8?B?MDhmVVR3TjVaSU4wNnBwQjF2eFFuK1NHNU9LbnowVUNsaWlBdGo4Z1UxVnJ1?= =?utf-8?B?eGlwa3huVU4yZ0JrYTJ6bkpxa3dYRWtxNm1ZMERvODFIZk9kRXQ5UVJXUDhr?= =?utf-8?B?QmpvTUtINHdlQ3BPQnNncFZveVA0NDlFbTcvQ3VsVkFxU0Y1bkZxZVFsdFl6?= =?utf-8?B?TWRXZEdJdFFqVHJlOEJQNmpPWnFJUHg2ckZXUzFucWlxaS9xbEMxR0dVaElv?= =?utf-8?B?VDRyN1BuWjM3b3hlclJYZXdvWDh6QUp4U3dqLzFEazU5NlR6K3ZXR0tQZWUx?= =?utf-8?B?RGRFZTBVMnVIN1dpV1JVN3I4V0I1VFduL2EyUWRLSGN4WXVJa3EzbmpVSk1K?= =?utf-8?B?cStZVVV1NUJ0TTRjcVZVNVpLK0xFam1YSHg5MWwyNDBha1czWDUxVjBYSVNy?= =?utf-8?B?RVB3THZWWWtld21KWHlOMStTWXVVRCtZYnM5S21pK05lWXBxdWRvTWxVZDhy?= =?utf-8?B?cmN2NEdPaGFkZCtoMHNLMGJicTR6bEZmcUdZS1Y4NEI5UERkd0I2ZzMwNlJU?= =?utf-8?B?NUN2Tm1na0N1RHV3RDRXN0gxMU5pQzNLcGNxem1KTjBYSjRzQThjM3RUbDh4?= =?utf-8?B?TGxiSWFvcnB5YUh3QTg3VzViY0dNdVZlY3dIdlI4M2FJNG9NS2puTWFDWktU?= =?utf-8?B?TWY5RzlrdkxadE5yWWhXZ0pRMjJ6VlRSMytNOTNYZlRTNm5kLzhBWnNPZmR0?= =?utf-8?B?aTFoTHNIOTFiRHV6NmVaYkdtNGN2bUlDZllCU1lUSy8wQ0UvRnhLR2ltRHdQ?= =?utf-8?B?VitsK3MxQVFzMU9qbGJGNVlSazJ2a1l1UzBGc2s0MTVFZldiTC9zNkt4aVBT?= =?utf-8?B?U2RJK0VGb1paV0tvZUo2Vk84Ti9MMDNGWVRlVmlSeWUyK0hKTUNPVzRNcHNY?= =?utf-8?B?R0FiWVpZU21ZVkltdjhCbWYrcTExbGtOUWt3a1dyNlg3RTl5Zkd1WS9jR1Zy?= =?utf-8?B?NnVBYXA1MnZ3dTNjSnVoTXpSWXFSc2kzVitkWlNLUHgvb2owdTBHQnJUc1F6?= =?utf-8?B?SENCNEFwSEJldnRmZ0w5MXFZN3FuYlpuTUsyRldLUlU1YUtFblprZ3EwUy9q?= =?utf-8?B?OVV3YmlQbEtzTHB3Y2wxRVlzbG1FNHhwUzZoU3Jid0c1WlRFdk1OTjYvN3pV?= =?utf-8?B?QjVVT1lNVEcwaG5jTThGU3Z0SXlER3F3R0lYbDZkK055RFZhYWoycVl5aTVF?= =?utf-8?B?ME9QcFdoeEFJbExmZTMxcHcra3R0aHg0VnpMMmJCSWpZeUtRNEZlOHJsQ1Qx?= =?utf-8?B?dDVVbFdjd3JMbHlQRjZDSHBreTJ4M3BsVEUwb1lwaGY0Zytxbkt4MjZ0QTE5?= =?utf-8?Q?rn4LjPy+nWaiDJZN0owIuvO/qBTwJcaYq4HCnKm?= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6735 Original-Authentication-Results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT011.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: a4abdd86-0b3c-4503-5540-08d93c9550c9 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: SAtR1rzYfWTmsdlEGioA7NP9gvmeoiTq+JRTATkVmTJkIWExQiq0OwfDKBUzbUw6sNx5YhYjRB4V5DbgjKB1HufxHtzYs/kVr0OkQtkCsod1LoPUCO/v4dDgoBi4hEDBaF+e3yXXUNPuzniW9d63Wg+5x4P88la7fKdZIVDBuhmc5hLwGHC6I02Rf0ZNNLv8ha3lQUnV6dR7Zvu26/OypIQrwVJlSsoCxxPH0CmOFhacVDkQbQVRBdHKpfDVho/SeXisnxy7rmPBnp+IfcGBw8941nBoTOKU/pFov0M4fl9UySns3mIthUwKEyrGLNG7N1ZbNk/e2SeBrxHcOUDCtjlfc/nswLs7J/ovWm7Eo+9ViOzhj10vmQm++pzkOOOO6uGI+Sydw/tqbbkJCm02FWpmxajXjaB4zXOVEo8rgUt4K1WhPULWfpvkcb08yJDLrPlht3J51GG+gVAqi4gK6/v20vrP+YF6J87mLOLO7+6kCr9UYN05/r6yDeVkC7SF2ZH3WYW/5Ql7y6c7s5zfxkF8Y763PW15CPASm7ujN/qW20nOPBl/BElGwNhQlkjpoUKngPjz6LEJsm18lHI82g0wjwezW1WExAn4tEyMENiA0j/ezsl3iwqg/D+6mXC4JVcLmKd3R0wRN4ApJp3/PbTpOnc+Np+gF06kCHtFPG8TC/zmMhDLP7sZk9YsmNzW1D0H085syAA4/VbIbjbWpw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(136003)(39850400004)(376002)(396003)(346002)(36840700001)(46966006)(6666004)(4326008)(6486002)(5660300002)(16526019)(82740400003)(186003)(36860700001)(8936002)(478600001)(956004)(81166007)(70206006)(6862004)(70586007)(356005)(26005)(6506007)(53546011)(336012)(36756003)(2616005)(316002)(2906002)(6512007)(86362001)(47076005)(54906003)(33656002)(82310400003)(83380400001)(44832011)(8676002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jul 2021 13:37:45.7364 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1ae41800-3dd9-4e41-b110-08d93c9568e7 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT011.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR08MB5800 > On 24 Jun 2021, at 00:33, Stefano Stabellini wro= te: >=20 > On Mon, 10 May 2021, Luca Fancellu wrote: >> Modify docs/Makefile to call doxygen and generate sphinx >> html documentation given the doxygen XML output. >>=20 >> Modify docs/conf.py sphinx configuration file to setup >> the breathe extension that works as bridge between >> sphinx and doxygen. >>=20 >> Add some files to the .gitignore to ignore some >> generated files for doxygen. >>=20 >> Signed-off-by: Luca Fancellu >> --- >> .gitignore | 6 ++++++ >> docs/Makefile | 42 +++++++++++++++++++++++++++++++++++++++--- >> docs/conf.py | 48 +++++++++++++++++++++++++++++++++++++++++++++--- >> 3 files changed, 90 insertions(+), 6 deletions(-) >>=20 >> diff --git a/.gitignore b/.gitignore >> index 1c2fa1530b..d271e0ce6a 100644 >> --- a/.gitignore >> +++ b/.gitignore >> @@ -58,6 +58,12 @@ docs/man7/ >> docs/man8/ >> docs/pdf/ >> docs/txt/ >> +docs/doxygen-output >> +docs/sphinx >> +docs/xen.doxyfile >> +docs/xen.doxyfile.tmp >> +docs/xen-doxygen/doxygen_include.h >> +docs/xen-doxygen/doxygen_include.h.tmp >> extras/mini-os* >> install/* >> stubdom/*-minios-config.mk >> diff --git a/docs/Makefile b/docs/Makefile >> index 8de1efb6f5..2f784c36ce 100644 >> --- a/docs/Makefile >> +++ b/docs/Makefile >> @@ -17,6 +17,18 @@ TXTSRC-y :=3D $(sort $(shell find misc -name '*.txt' = -print)) >>=20 >> PANDOCSRC-y :=3D $(sort $(shell find designs/ features/ misc/ process/ s= pecs/ \( -name '*.pandoc' -o -name '*.md' \) -print)) >>=20 >> +# Directory in which the doxygen documentation is created >> +# This must be kept in sync with breathe_projects value in conf.py >> +DOXYGEN_OUTPUT =3D doxygen-output >> + >> +# Doxygen input headers from xen-doxygen/doxy_input.list file >> +DOXY_LIST_SOURCES !=3D cat "xen-doxygen/doxy_input.list" >> +DOXY_LIST_SOURCES :=3D $(realpath $(addprefix $(XEN_ROOT)/,$(DOXY_LIST_= SOURCES))) Hi Stefano, >=20 > I cannot find exactly who is populating doxy_input.list. I can see it is > empty in patch #6. Does it get populated during the build? doxy_input.list is the only file that should be modified by the developer w= hen he/she wants to add documentation for a new file to be parsed by Doxygen, in my patch about documenting grant= _tables.h you can see I add there the path =E2=80=9Cxen/include/public/grant_table.h" >=20 >=20 >> +DOXY_DEPS :=3D xen.doxyfile \ >> + xen-doxygen/mainpage.md \ >> + xen-doxygen/doxygen_include.h >> + >> # Documentation targets >> $(foreach i,$(MAN_SECTIONS), \ >> $(eval DOC_MAN$(i) :=3D $(patsubst man/%.$(i),man$(i)/%.$(i), \ >> @@ -46,8 +58,28 @@ all: build >> build: html txt pdf man-pages figs >>=20 >> .PHONY: sphinx-html >> -sphinx-html: >> - sphinx-build -b html . sphinx/html >> +sphinx-html: $(DOXY_DEPS) $(DOXY_LIST_SOURCES) >> +ifneq ($(SPHINXBUILD),no) >=20 > This check on SPHINXBUILD is new, it wasn't there before. Why do we need > it now? We are not really changing anything in regards to Sphinx, just > adding Doxygen support. Or was it a mistake that it was missing even > before this patch? Yes this is new, I saw that we didn=E2=80=99t look if sphinx was installed = in the system, so now we did >=20 >=20 >> + $(DOXYGEN) xen.doxyfile >> + XEN_ROOT=3D$(realpath $(XEN_ROOT)) $(SPHINXBUILD) -b html . sphinx/htm= l >> +else >> + @echo "Sphinx is not installed; skipping sphinx-html documentation." >> +endif >> + >> +xen.doxyfile: xen.doxyfile.in xen-doxygen/doxy_input.list >> + @echo "Generating $@" >> + @sed -e "s,@XEN_BASE@,$(realpath $(XEN_ROOT)),g" $< \ >> + | sed -e "s,@DOXY_OUT@,$(DOXYGEN_OUTPUT),g" > $@.tmp >> + @$(foreach inc,\ >> + $(DOXY_LIST_SOURCES),\ >> + echo "INPUT +=3D \"$(inc)\"" >> $@.tmp; \ >> + ) >> + mv $@.tmp $@ >> + >> +xen-doxygen/doxygen_include.h: xen-doxygen/doxygen_include.h.in >> + @echo "Generating $@" >> + @sed -e "s,@XEN_BASE@,$(realpath $(XEN_ROOT)),g" $< > $@.tmp >> + @mv $@.tmp $@ >=20 > Is the absolute path required? If not, we can probably get rid of this > generation step and simply have the relative path in > xen-doxygen/doxygen_include.h. I think this could apply to > xen.doxyfile.in above. Unfortunately yes, the doxygen_include.h is a file that is included in ever= y documented header before=20 starting the doxygen parser, since we don=E2=80=99t have all the headers in= one path, it is impossible to have here a relative path that is good for every header in Xen. >=20 >=20 >> .PHONY: html >> html: $(DOC_HTML) html/index.html >> @@ -71,7 +103,11 @@ clean: clean-man-pages >> $(MAKE) -C figs clean >> rm -rf .word_count *.aux *.dvi *.bbl *.blg *.glo *.idx *~ >> rm -rf *.ilg *.log *.ind *.toc *.bak *.tmp core >> - rm -rf html txt pdf sphinx/html >> + rm -rf html txt pdf sphinx $(DOXYGEN_OUTPUT) >> + rm -f xen.doxyfile >> + rm -f xen.doxyfile.tmp >> + rm -f xen-doxygen/doxygen_include.h >> + rm -f xen-doxygen/doxygen_include.h.tmp >>=20 >> .PHONY: distclean >> distclean: clean >> diff --git a/docs/conf.py b/docs/conf.py >> index 50e41501db..a48de42331 100644 >> --- a/docs/conf.py >> +++ b/docs/conf.py >> @@ -13,13 +13,17 @@ >> # add these directories to sys.path here. If the directory is relative t= o the >> # documentation root, use os.path.abspath to make it absolute, like show= n here. >> # >> -# import os >> -# import sys >> +import os >> +import sys >> # sys.path.insert(0, os.path.abspath('.')) >>=20 >>=20 >> # -- Project information -----------------------------------------------= ------ >>=20 >> +if "XEN_ROOT" not in os.environ: >> + sys.exit("$XEN_ROOT environment variable undefined.") >> +XEN_ROOT =3D os.path.abspath(os.environ["XEN_ROOT"]) >> + >> project =3D u'Xen' >> copyright =3D u'2019, The Xen development community' >> author =3D u'The Xen development community' >> @@ -35,6 +39,7 @@ try: >> xen_subver =3D line.split(u"=3D")[1].strip() >> elif line.startswith(u"export XEN_EXTRAVERSION"): >> xen_extra =3D line.split(u"=3D")[1].split(u"$", 1)[0].strip(= ) >> + >=20 > spurious change? I think I=E2=80=99ve intentionally added a new line to separate the code fr= om the except: below, but if it is a problem I can remove it >=20 >=20 >> except: >> pass >> finally: >> @@ -44,6 +49,15 @@ finally: >> else: >> version =3D release =3D u"unknown version" >>=20 >> +try: >> + xen_doxygen_output =3D None >> + >> + for line in open(u"Makefile"): >> + if line.startswith(u"DOXYGEN_OUTPUT"): >> + xen_doxygen_output =3D line.split(u"=3D")[1].strip() >> +except: >> + sys.exit("DOXYGEN_OUTPUT variable undefined.") >=20 > This is a bit strange: isn't there a better way to get the > DOXYGEN_OUTPUT variable than reading the Makefile? >=20 > At that point I think it would be better to define DOXYGEN_OUTPUT a > second time in conf.py. But maybe it could be passed as an evironmental > variable? Yes we could pass it as an environment variable as we do with XEN_ROOT, I will fix it in a next release. >=20 >=20 >> # -- General configuration ---------------------------------------------= ------ >>=20 >> # If your documentation needs a minimal Sphinx version, state it here. >> @@ -53,7 +67,8 @@ needs_sphinx =3D '1.4' >> # Add any Sphinx extension module names here, as strings. They can be >> # extensions coming with Sphinx (named 'sphinx.ext.*') or your custom >> # ones. >> -extensions =3D [] >> +# breathe -> extension that integrates doxygen xml output with sphinx >> +extensions =3D ['breathe'] >>=20 >> # Add any paths that contain templates here, relative to this directory. >> templates_path =3D ['_templates'] >> @@ -175,6 +190,33 @@ texinfo_documents =3D [ >> 'Miscellaneous'), >> ] >>=20 >> +# -- Options for Breathe extension ------------------------------------= ------- >> + >> +breathe_projects =3D { >> + "Xen": "{}/docs/{}/xml".format(XEN_ROOT, xen_doxygen_output) >> +} >> +breathe_default_project =3D "Xen" >> + >> +breathe_domain_by_extension =3D { >> + "h": "c", >> + "c": "c", >> +} >> +breathe_separate_member_pages =3D True >> +breathe_show_enumvalue_initializer =3D True >> +breathe_show_define_initializer =3D True >> + >> +# Qualifiers to a function are causing Sphihx/Breathe to warn about >> +# Error when parsing function declaration and more. This is a list >> +# of strings that the parser additionally should accept as >> +# attributes. >> +cpp_id_attributes =3D [ >> + '__syscall', '__deprecated', '__may_alias', >> + '__used', '__unused', '__weak', >> + '__DEPRECATED_MACRO', 'FUNC_NORETURN', >> + '__subsystem', >=20 > Should we also have any of following: >=20 > __packed > __init > __attribute__ > __aligned__ >=20 > in the list? In any case, we don't have to add them right now, we could > add them later as we expand Doxygen coverage if they become needed. Sure it is possible, I can add them now since I have to push a fix for this= patch If you want. Cheers, Luca >=20 >=20 >> +] >> +c_id_attributes =3D cpp_id_attributes >> + >>=20 >> # -- Options for Epub output -------------------------------------------= ------ From xen-devel-bounces@lists.xenproject.org Thu Jul 01 13:51:22 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 13:51:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148684.274760 (Exim 4.92) (envelope-from ) id 1lyx66-0001EH-6o; Thu, 01 Jul 2021 13:51:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148684.274760; Thu, 01 Jul 2021 13:51:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyx66-0001EA-3j; Thu, 01 Jul 2021 13:51:18 +0000 Received: by outflank-mailman (input) for mailman id 148684; Thu, 01 Jul 2021 13:51:16 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyx64-0001E0-RT; Thu, 01 Jul 2021 13:51:16 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyx64-0005xy-FX; Thu, 01 Jul 2021 13:51:16 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyx64-00080V-65; Thu, 01 Jul 2021 13:51:16 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lyx64-0002Ul-5b; Thu, 01 Jul 2021 13:51:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=cCsX2d3Uq9ajqqHEqWFqUPjBIMcSs3MLSgYGJ793iw4=; b=YOKr3xD04Dvl/ZA6RHxgl39pnE T7speR6AUYiUP6g0JBY6hotQAfUJAdTizPHOgZHbrotnDRX98JovwoqjX79aVZdLS7D1Tc2/7lX0D FTH0eHBgT6FgjoILF8CZbyflLqJ4tByz6VB43NKasJbjSMDYMxLd4jbl/ecjF+S0Xxxc=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 163204: regressions - FAIL X-Osstest-Failures: qemu-mainline:test-amd64-amd64-qemuu-nested-amd:xen-boot/l1:fail:regression qemu-mainline:test-amd64-amd64-qemuu-nested-intel:xen-boot/l1:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=d940d468e29bff5eb5669c0dd8f3de0c3de17bfb X-Osstest-Versions-That: qemuu=1d806cef0e38b5db8347a8e12f214d543204a314 From: osstest service owner Date: Thu, 01 Jul 2021 13:51:16 +0000 flight 163204 qemu-mainline real [real] flight 163211 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/163204/ http://logs.test-lab.xenproject.org/osstest/logs/163211/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-qemuu-nested-amd 16 xen-boot/l1 fail REGR. vs. 152631 test-amd64-amd64-qemuu-nested-intel 16 xen-boot/l1 fail REGR. vs. 152631 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152631 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 152631 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 152631 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152631 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152631 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 152631 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152631 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass version targeted for testing: qemuu d940d468e29bff5eb5669c0dd8f3de0c3de17bfb baseline version: qemuu 1d806cef0e38b5db8347a8e12f214d543204a314 Last test of basis 152631 2020-08-20 09:07:46 Z 315 days Failing since 152659 2020-08-21 14:07:39 Z 313 days 576 attempts Testing same since 163204 2021-07-01 00:09:43 Z 0 days 1 attempts ------------------------------------------------------------ 552 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 179833 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Jul 01 14:03:19 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 14:03:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148690.274774 (Exim 4.92) (envelope-from ) id 1lyxHe-0002ny-BF; Thu, 01 Jul 2021 14:03:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148690.274774; Thu, 01 Jul 2021 14:03:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyxHe-0002nr-7I; Thu, 01 Jul 2021 14:03:14 +0000 Received: by outflank-mailman (input) for mailman id 148690; Thu, 01 Jul 2021 14:03:13 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyxHd-0002nl-Gs for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 14:03:13 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyxHc-0006Gm-5r; Thu, 01 Jul 2021 14:03:12 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=ufe34d9ed68d054.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lyxHb-0008GN-Sd; Thu, 01 Jul 2021 14:03:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Message-Id:Date:Subject:Cc:To:From; bh=mC+UL4mB6P83vegs7bksrkog22RhQJHUhe6zIy+isK0=; b=YhkOwdPHoTuIAE0LUzHmnBJGbS Z0/Otu0JTPcagSPeuI7vAPr1+4ju6vqMCe6VbRq8Nh7gra46cpv9tLNOO52SddmwFeIR84LiAMtxz BHUKTKl0T8zDMoM9uC08oNDVSRo1hiAnajgdtK1bgbLaEBw2QnZDL1KJZ4v7HYCs+EdQ=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: raphning@amazon.co.uk, doebel@amazon.de, Julien Grall , Ian Jackson , Wei Liu , Juergen Gross , Julien Grall Subject: [PATCH] tools/xenstored: Stash the correct request in lu_status->in Date: Thu, 1 Jul 2021 15:03:07 +0100 Message-Id: <20210701140307.2516-1-julien@xen.org> X-Mailer: git-send-email 2.17.1 From: Julien Grall When Live-Updating with some load, Xenstored may hit the assert req->in == lu_status->in in do_lu_start(). This is happening because the request is stashed when Live-Update begins. This happens in a different request (see call lu_begin() when select the new binary) from the one performing Live-Update. To avoid the problem, stash the request in lu_start(). Fixes: 65f19ed62aa1 ("tools/xenstore: Don't assume conn->in points to the LU request") Reported-by: Michael Kurth Signed-off-by: Julien Grall ---- This was sadly missed because the on my testing the 2 requests were residing at the same place in memory. This was reproduced by creating domain while Live-Updating. Without the patch, Xenstored will crash. --- tools/xenstore/xenstored_control.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/xenstore/xenstored_control.c b/tools/xenstore/xenstored_control.c index a1b1bd5a718d..ff9863c17fa4 100644 --- a/tools/xenstore/xenstored_control.c +++ b/tools/xenstore/xenstored_control.c @@ -103,7 +103,6 @@ static const char *lu_begin(struct connection *conn) if (!lu_status) return "Allocation failure."; lu_status->conn = conn; - lu_status->in = conn->in; talloc_set_destructor(lu_status, lu_destroy); return NULL; @@ -757,6 +756,7 @@ static const char *lu_start(const void *ctx, struct connection *conn, lu_status->force = force; lu_status->timeout = to; lu_status->started_at = time(NULL); + lu_status->in = conn->in; errno = delay_request(conn, conn->in, do_lu_start, conn, false); -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Thu Jul 01 14:06:48 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 14:06:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148695.274784 (Exim 4.92) (envelope-from ) id 1lyxKy-0003Qn-Qo; Thu, 01 Jul 2021 14:06:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148695.274784; Thu, 01 Jul 2021 14:06:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyxKy-0003Qg-Nq; Thu, 01 Jul 2021 14:06:40 +0000 Received: by outflank-mailman (input) for mailman id 148695; Thu, 01 Jul 2021 14:06:40 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyxKx-0003QY-Sb for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 14:06:40 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (unknown [40.107.21.44]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 8be6d3fe-da75-11eb-8327-12813bfff9fa; Thu, 01 Jul 2021 14:06:36 +0000 (UTC) Received: from DU2PR04CA0341.eurprd04.prod.outlook.com (2603:10a6:10:2b4::30) by AM8PR08MB5858.eurprd08.prod.outlook.com (2603:10a6:20b:1dc::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4264.18; Thu, 1 Jul 2021 14:06:27 +0000 Received: from DB5EUR03FT057.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:2b4:cafe::93) by DU2PR04CA0341.outlook.office365.com (2603:10a6:10:2b4::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.21 via Frontend Transport; Thu, 1 Jul 2021 14:06:27 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT057.mail.protection.outlook.com (10.152.20.235) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.22 via Frontend Transport; Thu, 1 Jul 2021 14:06:27 +0000 Received: ("Tessian outbound 80741586f868:v97"); Thu, 01 Jul 2021 14:06:27 +0000 Received: from e3cd01550ddd.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id A076492F-2A74-474E-9194-9D26169C7376.1; Thu, 01 Jul 2021 14:06:18 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e3cd01550ddd.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 01 Jul 2021 14:06:18 +0000 Received: from PAXPR08MB6816.eurprd08.prod.outlook.com (2603:10a6:102:130::10) by PA4PR08MB6045.eurprd08.prod.outlook.com (2603:10a6:102:ef::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.24; Thu, 1 Jul 2021 14:06:13 +0000 Received: from PAXPR08MB6816.eurprd08.prod.outlook.com ([fe80::7cfd:a8eb:b25a:f025]) by PAXPR08MB6816.eurprd08.prod.outlook.com ([fe80::7cfd:a8eb:b25a:f025%7]) with mapi id 15.20.4264.026; Thu, 1 Jul 2021 14:06:13 +0000 Received: from smtpclient.apple (82.8.129.65) by LO4P123CA0147.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:188::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.22 via Frontend Transport; Thu, 1 Jul 2021 14:06:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8be6d3fe-da75-11eb-8327-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IbKTHFU2AlA3cBd5ckibrMKo40WTXMTV53PLkroJV10=; b=BNO//h8TpjYA6+RJFklsa3GppskxxId8MvR9JmJg2HHcoYdCBZqz9dh8miBEU3H2il1RCQ8KGlrT+4e7Ee9W50u3mZARViSzvf7grrYyDKDlKzbObTTGBO2I0kh/3JpX7sfSJjViPW9Q7aXCkrAqsfDPo6SkCpB2gYYFk+j9z14= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: 6ad17504501bd2e0 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MK8solLtVlI4K3xA3usEuwd6uz5J/N/3rb5HGtTuHQQC8nS9ETYfUUn/GwfXe9cxeoVfnKunkMF25SSoxtB3oHNyn5UDi8rKGaLPwnDDUhq6lxSkpSvup0cVQdiV6StwIHgm2ftO+JZ/eIJK8PG5aQ3x+Lo5Exkou7twkkorlklA4fzsvu3VV5VubUREy3gyBpNvm12zyD5MCVgB3BYmO94+AXfuJ8FGPHbR9FEy9Wlaj8ao8Sf6u5MZG/25Ehp/MlcYN80Jxj3inuVcod4FC8RnqzkCjd3l995ywlc35CvxUXC8NbYGCJI7XQx9J3OTHbaS0rTJV8oNhLNeIMeTQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IbKTHFU2AlA3cBd5ckibrMKo40WTXMTV53PLkroJV10=; b=UpWlRr0U/1UWuq4DCd4/mx9hs7eVAYnXELNvLcpzf3PvM9xdsplI+Vs+4E9TdPxMjvWD4JkHlt9MnG8Xodk8V6hMva2s8qTlfVGToXO5oJLkRvbifrJ9sbjH9yuic59u/ZIxnq8BfWig+wNkJU0I+fmMSpFEJXna2kyQRBlLdHSMxnXaz5NetUiybOaJCTntkz6zR9GAeuMW5AHdHbsk8U28bnR3nEKazmhXXp/PTyjD2MTcALJu3zs2ESKDk1qx0rEk9wSC1DuACD53dMWmTmFWWmVsqws7ZBqpyTbFHQFI/gLUwu0WWeL5fQKs74VMZiDe9rTtaF0587bFyjHttw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IbKTHFU2AlA3cBd5ckibrMKo40WTXMTV53PLkroJV10=; b=BNO//h8TpjYA6+RJFklsa3GppskxxId8MvR9JmJg2HHcoYdCBZqz9dh8miBEU3H2il1RCQ8KGlrT+4e7Ee9W50u3mZARViSzvf7grrYyDKDlKzbObTTGBO2I0kh/3JpX7sfSJjViPW9Q7aXCkrAqsfDPo6SkCpB2gYYFk+j9z14= Authentication-Results-Original: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=arm.com; Content-Type: text/plain; charset=us-ascii Subject: Re: [PATCH v6 8/9] docs: hypercalls sphinx skeleton for generated html From: Luca Fancellu In-Reply-To: Date: Thu, 1 Jul 2021 15:06:06 +0100 Cc: xen-devel@lists.xenproject.org, Bertrand Marquis , wei.chen@arm.com, Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Julien Grall , Wei Liu Content-Transfer-Encoding: quoted-printable Message-Id: References: <20210510084105.17108-1-luca.fancellu@arm.com> <20210510084105.17108-9-luca.fancellu@arm.com> To: Stefano Stabellini X-Mailer: Apple Mail (2.3654.100.0.2.22) X-Originating-IP: [82.8.129.65] X-ClientProxiedBy: LO4P123CA0147.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:188::8) To PAXPR08MB6816.eurprd08.prod.outlook.com (2603:10a6:102:130::10) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 03ad84dd-f8e8-43fe-9843-08d93c996afb X-MS-TrafficTypeDiagnostic: PA4PR08MB6045:|AM8PR08MB5858: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:10000;OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: ltVqP6y7aoZV2LZwUfzYaADxENnOwI4o/t/GHpfj61BawkNgSL+915iIsBrn44SEM3td2mFjhWrqEj0D52PD1iCMbxq7ELLtjPVPVHu0yk94cucgdnifa0747mGoresGsJIAiKKS7lc8Wbv3mef1SELLpas5E3bRVTkKl6WGVu7DH3haOXY66QK2kURpSM/vSDeYzd6XqNE60R4fHj/ufqDez2zzJ9tJY+aCwXCjqSFGUst/OJLmDL04513uWOCW2rfWYftlylDz5ovjWTe44oTvNG9O1isQWcsaio63wQwkD6MgI/5oZhhJj4l79lyHgxk8SqBV+UEjnJYGoWO5OrrjUx8Q2aTd8MZEqGRQtY/y8ivRqD8jG3FKjGCt6Mc+xQ0sQFp8xPNbkH09aAexFaAS96vhs5A/PLcTdbjVeD4O1L6QEuDiir5my6WlO7yUqojvUg7cyOHKHcJ5Yk+jN88uJS/HzJVmkbfFM7+zS7VSI8BDTw9l0V5Z9E9TX5HYyVq+icJInQtYgOgn9GwbKhnECbzTkf9u8+eB83pXMQ5ZRIJiLb1PQFfUhbgpC/0hc/nJqQM02gE9dS+c3r+QAdzH9d3AH4FepE5mE2sDwt/9kxIGhRQ5VLJyTfhtNLZCVZlORAejoMGc3NB9ccNGmWIe2512DRR9TMnIF7YCPfBew8BgyPy1uSHg9vtHUdPMSohlhxWlCMu+kjRWBrnqFFP4oy2yDPOiIPfar22QQOQ= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB6816.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(366004)(376002)(39850400004)(346002)(396003)(316002)(44832011)(6486002)(54906003)(38350700002)(38100700002)(186003)(16526019)(26005)(6512007)(6666004)(6506007)(53546011)(66946007)(52116002)(2906002)(33656002)(36756003)(86362001)(4326008)(66556008)(66476007)(956004)(2616005)(6916009)(8676002)(8936002)(5660300002)(478600001)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?JxTDEZ30QfPigQbNDsjMSUam8ezmIS/Kwv9JsffETV8jGKhmd1sM3ezZwUIs?= =?us-ascii?Q?jFJUWZn5XnZx/LqOg/zPhLLf1rpD+rGI46huTzT+ljviKVP0FDfTZOyG7khN?= =?us-ascii?Q?fDZPucmwf+z+guPpMPYRIfDHRjf/VA5UaYfkX7xE+Nm/mx/CD9eezoGKi1FV?= =?us-ascii?Q?MW731QjIOfV5C2UkOzvqHY/aDDW0YZCxqCJbZv4FuC8fs+oYdZNae2EgWHKv?= =?us-ascii?Q?4WbkYZtW0/YBgtxv7pEw85RIIGsyqYGODqJuW6k/xKwGA+lGyPNf5Ni6Q0xL?= =?us-ascii?Q?lx47lKsuLXvOAy8IcBXRrxSNTz4ZPn7BZFinyH45soR9X8lZhDrr18gIRqwK?= =?us-ascii?Q?ZyZ1m5gdN8VfZYC9dXx86pEIfpJ9078IiU1NhJbdsyo6G+gKnb9UcVi4MKHC?= =?us-ascii?Q?NDBam42k5orp9RDyeQ9FTJPyNgTJnFyOyxQJerngE0El5k5Ww8v79+Fg0Yai?= =?us-ascii?Q?i+l0Y2VhMx7weq6+kKKiJsCi8cpv/GbxRFZxzVmiqdyLse6Kr5oG1cQZoGq4?= =?us-ascii?Q?pqfsgAgRQAlw5v/0Fzbu5gqoniJG2z30k88KWJvpnEPXuLYP5fWkoEtqd5lx?= =?us-ascii?Q?V2cqEjBC5Ui2zJSpX1MH4ituu1vndqibQwOc8VLnyTxvLRgVsNgUpgJJYfE9?= =?us-ascii?Q?mAlSx+HMYNdyDWD6jaF4nO5FZaVQ1KF+ukMRgVSO8CwnHV6IA2M7vr+g0Esv?= =?us-ascii?Q?Z5a0FBfrpDHoqSTUXWkC39AsYuo3blYMNlyqwDdqwtN/XAqm+96ecaWxhbx6?= =?us-ascii?Q?ct6Lz+LxL87LcIV+nc0UlRO8EYjH5QJ+h2P1tJe56rhXOdLylE9uJisrL24m?= =?us-ascii?Q?IoJG2nXw+MNfQFt6Y6asKxbPTEZ/ywi/31wbxM8xk1ZVvrWJY8o1t7TgOrqV?= =?us-ascii?Q?roRJ8cc2vVaZrpxxZgxs4Ui3QLItzIpxH6SOe+rsVgswRJM5QHZ5mUrCekzj?= =?us-ascii?Q?sMQ6d1NpIEW5r/iQqAuAoMY6DuzphyDbrnBA37cQhtSZ6jR+Im8zP2l+pYM/?= =?us-ascii?Q?Sl9WLrhaCj+r/LaByaK3PyhAT7wNIZXFQjBn1tx4egHVVpC0Uw2L0dJgE917?= =?us-ascii?Q?/Eced9S6Xn3Ewj6MnurFN5u/3iL2+oF8WlkN5rMY0bQrgu1+x7sC81CeZ3WU?= =?us-ascii?Q?DIa8zbhxCU26KC8udNSkUFv/kqq5qMVWcqmtdeN1a2WaMsipRLGfynRV2wnB?= =?us-ascii?Q?9KCoi1uvQJ+T4REJlx2fMFr3ljae8Xc7M2ocskU4j8bNXiIuoA8mq62siYDs?= =?us-ascii?Q?E8R5DTuOGIZMjY4KGMwagly9Z5YKf0EP2H42GvoA4U0NqPsFF5hWgLbSYeNf?= =?us-ascii?Q?Fnjf9XHPp8pw8o4tjAPkaEAV?= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6045 Original-Authentication-Results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT057.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 4653e4a1-2bea-4081-3ef5-08d93c99626d X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tazJGIVRTSP185RR6UsagtV0/cyihD9ctUekBWN3h7jJlyTzjLFxxEUgcgs8/o63DsITBYpY/T1vjZuVJO9n7KtzYzMl4LDucQkAJxoFgZaLEytCCLc6g5t4W60P3j/1NxyezyZb9TZOXxHJW+BZrS4+zZ26TMQLLqjOWwbBU8TtreaeRCeFYmSA9h7+QmYxi67elV2W2xXJlMveIYYM25QjoqMHVd+AMe8wfUaKKM/SHU9LXonNsij2RjafiCfFTMz+sP5m+5IeY7QBOrhJ6pQ2DlIDec6hJd+aAL9nkagqgHZqaM8U2C7IDm0SY3yd8d7CaCLNvXwzmKw0ef5m/MDH7IfojTJyw23WQ3oxdMLdnV/ykMg9RBhI8AT0YxgwvZt4QjdZreyIyXStZhG6OpRc/3ZJUQFdvwCSTCHfPA4XREBBPFfkOZv1YlRd/aMiH+uicmA5YhTorpSreNDMeM8WQNi1+0Vd6epuNHeAIebk1z3kxboFFSKMOJi3vPuzw14jpnK4dH3XIums0l8oPW+LrMkV6re7Wr+zSh5rkN31ZQWIx4ib8kGSjZWZ8MhEVW/Y7UXF+kHdToArVEv98c+PsKycwPb57AQXZQ1heRe0I/cO/lxrJj/YUxXu3j4tUAWOapYyNBtKkDn02lLfnt8jMJwCdvvzMf+i3zIq//ttTFLIEh5LomJniiepuvt1pU1/wx3SAwcgTFJ4GIVD1Q== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(39850400004)(396003)(136003)(346002)(376002)(36840700001)(46966006)(81166007)(70206006)(82740400003)(8676002)(6862004)(2616005)(356005)(33656002)(2906002)(4326008)(36860700001)(956004)(478600001)(5660300002)(47076005)(336012)(6506007)(70586007)(316002)(6486002)(6666004)(26005)(186003)(16526019)(53546011)(82310400003)(36756003)(8936002)(86362001)(54906003)(6512007)(44832011);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jul 2021 14:06:27.2092 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 03ad84dd-f8e8-43fe-9843-08d93c996afb X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT057.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB5858 > On 24 Jun 2021, at 00:34, Stefano Stabellini wro= te: >=20 > On Mon, 10 May 2021, Luca Fancellu wrote: >> Create a skeleton for the documentation about hypercalls >>=20 >> Signed-off-by: Luca Fancellu >> --- >> v6 changes: >> - Now every platform has the same sections in .rst files >> --- >> .gitignore | 1 + >> docs/Makefile | 4 ++++ >> docs/hypercall-interfaces/arm32.rst | 32 ++++++++++++++++++++++++++ >> docs/hypercall-interfaces/arm64.rst | 32 ++++++++++++++++++++++++++ >> docs/hypercall-interfaces/index.rst.in | 7 ++++++ >> docs/hypercall-interfaces/x86_64.rst | 32 ++++++++++++++++++++++++++ >> docs/index.rst | 8 +++++++ >> 7 files changed, 116 insertions(+) >> create mode 100644 docs/hypercall-interfaces/arm32.rst >> create mode 100644 docs/hypercall-interfaces/arm64.rst >> create mode 100644 docs/hypercall-interfaces/index.rst.in >> create mode 100644 docs/hypercall-interfaces/x86_64.rst >>=20 >> diff --git a/.gitignore b/.gitignore >> index d271e0ce6a..a9aab120ae 100644 >> --- a/.gitignore >> +++ b/.gitignore >> @@ -64,6 +64,7 @@ docs/xen.doxyfile >> docs/xen.doxyfile.tmp >> docs/xen-doxygen/doxygen_include.h >> docs/xen-doxygen/doxygen_include.h.tmp >> +docs/hypercall-interfaces/index.rst >> extras/mini-os* >> install/* >> stubdom/*-minios-config.mk >> diff --git a/docs/Makefile b/docs/Makefile >> index 2f784c36ce..b02c3dfb79 100644 >> --- a/docs/Makefile >> +++ b/docs/Makefile >> @@ -61,6 +61,9 @@ build: html txt pdf man-pages figs >> sphinx-html: $(DOXY_DEPS) $(DOXY_LIST_SOURCES) >> ifneq ($(SPHINXBUILD),no) >> $(DOXYGEN) xen.doxyfile >> + @echo "Generating hypercall-interfaces/index.rst" >> + @sed -e "s,@XEN_TARGET_ARCH@,$(XEN_TARGET_ARCH),g" \ >> + hypercall-interfaces/index.rst.in > hypercall-interfaces/index.rst >=20 Hi Stefano, > I take that this means we are going to generate docs only for the > architecture that we are building? So if we build for x86, then the docs > are for x86 (no arm32 and arm64 docs.) Is that right? >=20 > Is that because Doxygen relies somehow on the compiler to extract data? > I am asking because if Doxygen doesn't rely on the compiler, then it > could probably generate the docs for all architectures in one go? Doxygen rely on the headers generated from the KConfig system to properly s= olve the preprocessor step, for that reason here we need that. It can be improved for sure, but it needs to call a defconfig for each arch= itecture and have separate Doxygen-output folders for each one, then on the rst files yo= u can choose from which arch you want the data. I think this step can be done in a future serie. Cheers, Luca >=20 >=20 >=20 >> XEN_ROOT=3D$(realpath $(XEN_ROOT)) $(SPHINXBUILD) -b html . sphinx/html >> else >> @echo "Sphinx is not installed; skipping sphinx-html documentation." >> @@ -108,6 +111,7 @@ clean: clean-man-pages >> rm -f xen.doxyfile.tmp >> rm -f xen-doxygen/doxygen_include.h >> rm -f xen-doxygen/doxygen_include.h.tmp >> + rm -f hypercall-interfaces/index.rst >>=20 >> .PHONY: distclean >> distclean: clean >> diff --git a/docs/hypercall-interfaces/arm32.rst b/docs/hypercall-interf= aces/arm32.rst >> new file mode 100644 >> index 0000000000..6762d9fc7c >> --- /dev/null >> +++ b/docs/hypercall-interfaces/arm32.rst >> @@ -0,0 +1,32 @@ >> +.. SPDX-License-Identifier: CC-BY-4.0 >> + >> +Hypercall Interfaces - arm32 >> +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D >> + >> +Starting points >> +--------------- >> +.. toctree:: >> + :maxdepth: 2 >> + >> + >> + >> +Functions >> +--------- >> + >> + >> +Structs >> +------- >> + >> + >> +Enums and sets of #defines >> +-------------------------- >> + >> + >> +Typedefs >> +-------- >> + >> + >> +Enum values and individual #defines >> +----------------------------------- >> + >> + >> diff --git a/docs/hypercall-interfaces/arm64.rst b/docs/hypercall-interf= aces/arm64.rst >> new file mode 100644 >> index 0000000000..5e701a2adc >> --- /dev/null >> +++ b/docs/hypercall-interfaces/arm64.rst >> @@ -0,0 +1,32 @@ >> +.. SPDX-License-Identifier: CC-BY-4.0 >> + >> +Hypercall Interfaces - arm64 >> +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D >> + >> +Starting points >> +--------------- >> +.. toctree:: >> + :maxdepth: 2 >> + >> + >> + >> +Functions >> +--------- >> + >> + >> +Structs >> +------- >> + >> + >> +Enums and sets of #defines >> +-------------------------- >> + >> + >> +Typedefs >> +-------- >> + >> + >> +Enum values and individual #defines >> +----------------------------------- >> + >> + >> diff --git a/docs/hypercall-interfaces/index.rst.in b/docs/hypercall-int= erfaces/index.rst.in >> new file mode 100644 >> index 0000000000..e4dcc5db8d >> --- /dev/null >> +++ b/docs/hypercall-interfaces/index.rst.in >> @@ -0,0 +1,7 @@ >> +.. SPDX-License-Identifier: CC-BY-4.0 >> + >> +Hypercall Interfaces >> +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >> + >> +.. toctree:: >> + @XEN_TARGET_ARCH@ >> diff --git a/docs/hypercall-interfaces/x86_64.rst b/docs/hypercall-inter= faces/x86_64.rst >> new file mode 100644 >> index 0000000000..59e948900c >> --- /dev/null >> +++ b/docs/hypercall-interfaces/x86_64.rst >> @@ -0,0 +1,32 @@ >> +.. SPDX-License-Identifier: CC-BY-4.0 >> + >> +Hypercall Interfaces - x86_64 >> +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D >> + >> +Starting points >> +--------------- >> +.. toctree:: >> + :maxdepth: 2 >> + >> + >> + >> +Functions >> +--------- >> + >> + >> +Structs >> +------- >> + >> + >> +Enums and sets of #defines >> +-------------------------- >> + >> + >> +Typedefs >> +-------- >> + >> + >> +Enum values and individual #defines >> +----------------------------------- >> + >> + >> diff --git a/docs/index.rst b/docs/index.rst >> index b75487a05d..52226a42d8 100644 >> --- a/docs/index.rst >> +++ b/docs/index.rst >> @@ -53,6 +53,14 @@ kind of development environment. >> hypervisor-guide/index >>=20 >>=20 >> +Hypercall Interfaces documentation >> +---------------------------------- >> + >> +.. toctree:: >> + :maxdepth: 2 >> + >> + hypercall-interfaces/index >> + >> Miscellanea >> ----------- >>=20 >> --=20 >> 2.17.1 From xen-devel-bounces@lists.xenproject.org Thu Jul 01 14:10:00 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 14:10:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148699.274796 (Exim 4.92) (envelope-from ) id 1lyxO9-00049J-Dv; Thu, 01 Jul 2021 14:09:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148699.274796; Thu, 01 Jul 2021 14:09:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyxO9-00049C-Au; Thu, 01 Jul 2021 14:09:57 +0000 Received: by outflank-mailman (input) for mailman id 148699; Thu, 01 Jul 2021 14:09:55 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyxO7-000494-IF for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 14:09:55 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 01f3054a-da76-11eb-8327-12813bfff9fa; Thu, 01 Jul 2021 14:09:54 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 01f3054a-da76-11eb-8327-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1625148594; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=eon9sNIahDWrgyFAaZIRX9vSn77mUv2BAx0W5C/4uLU=; b=Wx75YNY9LOa5kRcpypnMNepNLrG9gzXckmBvynwelH3WryqptFXs8yip 1FBXFf8Bw3wQPhBd2Jr4S3msgXibRPl+tYZqNdBSeJ9YHtJjBF/xgp7Tm UVxKWuwC2VFyTfzKft2HtSR1+k4xs8BkP5jLY9mFM1eeQAL50XERUpSKe E=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: o9Qqq7SGbEV6l5QW3XrwILTlDeqGYpAUgteR5Vu1gdwLny5S/sMadyZdRaS+9/Cow6ExD2BDkq g+8eH5/P/qdxQ2F7hoO/ijmGhqJ2S8GWaBVEGxMLPIEH8o4ugdeGl8dbAOTdvfb3bUjqc0O8Kp ruKE9CUBNFJvfEjUNacScMFqzmVCtuYvlIsYKWN7fd4GcHK27zDkHluwv7k6YdepgD1PvBXwlr 9BVZskAfqt3K48DtwIfHckZfL9ribz9Tnf96kCjbUBYnX7tp5G+/ACtpjf4QwUrKAVZ9T9Tl51 c6Y= X-SBRS: 5.1 X-MesageID: 47755271 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:Fk5ipako6LEsygqkS23Q05rCX4LpDfLW3DAbv31ZSRFFG/Fw9/ rCoB3U73/JYVcqKRUdcLW7UpVoLkmyyXcY2+cs1NSZLWzbUQmTXeJfBOLZqlWNJ8SXzIVgPM xbAspD4bPLbGSTjazBkXSF+9RL+qj6zEh/792usEuETmtRGt9dBx8SMHf9LqXvLjM2fqbQEv Cnl6x6jgvlQ1s7ROKhCEIIWuDSzue77q4PMXY9dmcaABDlt0LR1ILH X-IronPort-AV: E=Sophos;i="5.83,314,1616472000"; d="scan'208";a="47755271" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Oodp9vd6P11DdzvMGYL9E6521Yrd6TG3yhfgft3MMBkwVdV30EgPuQIglGIQsx/HzBdddttG4jPBLktByEc0aHDkLjZBjMNluMvAuiPQlXCwcK/7PZAjF/VulDBE461JsxBWkhjsGfMWTy1Z/sYYy7cj78INNAa5X/a3qj52HhCUli7hpSxMnws7t99JLiJ/0NHIP+eotT1im731W8qcjwDxL35WhzgfLzaXqsInTCcV2T0xGpyoiPmP+dPnYuytYJyqxjINwrjf837f6KUa34+QWao/T7b7/U7sMfTzGt8p6UErImO41M/SM7DXe1RfGEXan/hvktJxmVhZZKUHKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eon9sNIahDWrgyFAaZIRX9vSn77mUv2BAx0W5C/4uLU=; b=Wv11+SGLNeQVpLEyxKH+VVC/PnLVi4YRqYSDqnseWqKx1vHQzOgSvwMJwZsonxnTGUCmnBzWqdcubQMjIC+V37TJxBpuJ9UJ+atHyQUztN4Y5NfU95Dx5ltuKM/esv8FkGTS+nOHOV5Nh7k6BuYzykT+VFuecV4JI67CsB8zKTQSOUPmleal4RfWR0yGtmAn+oyEafGZG6WFm/r+WOJGkEJuVynYnXpA02SI0gboHzAGVoNIo8Bh4OH0c666NNUzkf5o2jDH3Smrqu191K5VmiVeWrpJuny9D32z5e9+cJ/YQRkWNwx2jnZCahfw1qWkLVopEwB0UId2aNDCA++5Eg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eon9sNIahDWrgyFAaZIRX9vSn77mUv2BAx0W5C/4uLU=; b=EkadcRHnp6mohxfNjOh5cf4duVm8cwi+hTJd0Rz6yNW4eOcmSEMGFEnm2hmBlxq8CD1bSH6AcbhEaupI/PwRhUQcLarekjZnNLekZRR0kAcQfXX9ZhhF5rm1RwhdEJ6bpGRl5vEpvY3JHXeHcTPxU9gekEW+k5aUZi14uXQVOww= From: George Dunlap To: Nick Rosbrook CC: xen-devel , Nick Rosbrook , Ian Jackson , Wei Liu Subject: Re: [RESEND PATCH 03/12] golang/xenlight: fix string conversion in generated toC functions Thread-Topic: [RESEND PATCH 03/12] golang/xenlight: fix string conversion in generated toC functions Thread-Index: AQHXUNysz1ZbuKJBuU+rSVrlC2Thy6sZwI6AgAUN5YCAD5VSgA== Date: Thu, 1 Jul 2021 14:09:47 +0000 Message-ID: <22BCDDFA-0EDB-466D-B644-54A956C0D84C@citrix.com> References: <06763aceff41167d3d3bbd603f729572c1f55c77.1621887506.git.rosbrookn@ainfosec.com> <6BAF6F60-EC63-41AC-A46E-2045E746C7E1@citrix.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3654.60.0.2.21) x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9ab6c070-b370-4bb4-0b04-08d93c99e26f x-ms-traffictypediagnostic: PH0PR03MB5861: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2657; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: LonZVojVwI2lxyM/GygovcG73eGjvI2RwYS4m24HD3uUib3pZgWwv+vCohsXQ8oLfwLpXiqJ746TPwDPYVaJsb6X4y0RA8OGS4VoU4ZhEeIZn8fPWCLwyg55E7Fs7xxvaEWGRhEVF1RHGrS/1IEXwPhRHsBMirqnUu/Psp17mRjAMWsKfDFobyU+P/4Qlgobk2PvZNom5pKDpw4Y/UkZehLheHZ+dlTiyt2FadxWuOWaIjn3nBYBHho9HbXWIFtyDNOjxF12R/tTPN8mvl+6hqStrYGdBBPAt0xU25UaEZQt4Agi2T9Um41i85E4NJG807Vbnd7LZYA5uqcm3DNzZ5q4WWzXgG2ThYFHjGkHhaqjwVuFFg5kBwtKSQSxYZ2DGAPe+HDSWkSySXrGjAkpcQPQgD5RYl8OIoAAPIfgNOK9y1MfqKeGjl/mnAH7ueiDI+71GKQiHrTuw4jjLStfwpVlNjQrs+u3UgXcBukouK7VgyxuRT11TIs/bSHNOJSfSPi9NcRzd8PYi2EeZNt4nbvGIOIIjYql0/TDIQWEOIw5q/WzQqyUVYBSKa+rrfFLgrOGeyhbvA/UHxqzTG7jw7o/dMSzwOBnroxkg/rr58cMlj8L7m5/Uz9avXDWv/IUleOEFgsYbNYdp55rIX2v2ua/Vj7kamP8tfZaDvYdTGZf5JROM5Ht3funN/7+IPlCaFDG22No0gn9VrUmmJ82MA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR03MB5669.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(136003)(346002)(376002)(39850400004)(396003)(478600001)(91956017)(76116006)(316002)(4326008)(2906002)(8936002)(122000001)(38100700002)(66946007)(2616005)(8676002)(71200400001)(83380400001)(186003)(86362001)(6486002)(54906003)(5660300002)(36756003)(53546011)(64756008)(66476007)(66556008)(6512007)(66446008)(26005)(6916009)(33656002)(6506007)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?aFpjb2ZEWW8zTEhoUWtDdWNkRkJYVGpNbkFZSFg2Q2pBWERTbkdWR3FCNUxR?= =?utf-8?B?Ukx1MkFjRFUyT2R5WnQ3eWhheEd4OG13S3F2bnNaNHUvZXFWNkNISDZXVHdO?= =?utf-8?B?Zm1YTThFY0k4ZGpNRmp3QklXcVRwd0VoTTZMdmhyN25BdWtpUWMvK29LSTZn?= =?utf-8?B?cExqOHNKNHp1V082RU1XUnVoT3NUcThKQTR5bGF6VUo3eE9QeHhLSlJWbG41?= =?utf-8?B?alQ1c29COWxoWk5jZ2E2d25QRURheDRKWVZvQjE5QXRzYkNVZ3FwU1plSWIz?= =?utf-8?B?dHdJcmpQWHZrNkI5eHBZZXZkOTNTL1lCZlFKWlE2NThDVmp6M09pNmZwMC8z?= =?utf-8?B?TndjamJUVHQ5ZVJ1cnFGeU1oeWNFZkJtMFBJY1hYcjN1b1d0eFgvQXdkZzhq?= =?utf-8?B?R2VoZW95QTJ0YjJpU2hxWWdCMXN3RkgvYk9MZzhEbmVJZDFIS1RxeG9kRXB2?= =?utf-8?B?S25Td3VhK3lYVnFjaVdFRTNEcmhtSllYUElNNG40Sy9JRWZZWXNxeEdHMFgv?= =?utf-8?B?ckVZT2tMR2hWSVBRNnJVUkpQWjQvSEQ1cHNzYk1RZllqTldrKzFSVEhUZWxS?= =?utf-8?B?em9paEdYNGN2WUlId2REaVRZb2hJZkNNY05UZG42eTBsaU1zQzd3VzVnNGF3?= =?utf-8?B?RTRydzNwSzdKSTlURjlkK21BTGp5bTcydkh6MlNOVEJXTU9Ga2ptSFdXQ0M3?= =?utf-8?B?RkJsazJDbVdUY0ZNMUYyVmpwL3R4RFkxK0JiTml4d1RqbzNtMjYzUlEyYkow?= =?utf-8?B?QXllRkRMTXJYa2dWL0R1NXZOUkIvbXBXK0ZlVWVXUGRSV3VWK01oWVFTWDgz?= =?utf-8?B?b1RFQW00RXduODRMMSthc3daL01tYjlaL1dtVHJvdkZKR1dqZXJwUXZFVDFJ?= =?utf-8?B?T3UwRXMySHhhZGgxeTBDK3p4ZXo0QlM2QWNET2IrUDZBWWJ4UHFXcnN6WFoz?= =?utf-8?B?S25OQkVxcFFnYm12dmNJcXBwZ25lY2gvYXh3WndiU2xrM0RXMTlScWQ4YU0y?= =?utf-8?B?Y3JEQkkvTzZIbDVXZE9JVHFiYkg0MzBZT0Z1K3doT2lZUFh2WU16Z1UrOWp6?= =?utf-8?B?d1I2b1BnczJFYmo3UW1PdEZCUys1VTJHY05udGo5V3MrSjQxSnNHMGNsSDRX?= =?utf-8?B?WmRKMms2cEZrQUhlUlM4WnJYNnVVMkNXQm1ESDd6V29NVWJMcTRoRnRiVWlW?= =?utf-8?B?enprQk5HSUk5R01qbllTYmVjNUJBS1NPVEJrVFhuc1k5cEF2a1NZL3lCTTdR?= =?utf-8?B?UVRCTmxCbHFQamJEcU51Y2FkTDVtL0ZCTnpra2VyTnc2Q1BFNHFBdkI4dWxx?= =?utf-8?B?aFU3ZmVvQm1hNnpDVWU2czdtdVp3MWlQcTgxWTFOUHhMRGlkcGRBWnJoY2V6?= =?utf-8?B?TzNpM0gvdU9DS1V4eU5GK1FYOEx1Um5XRFluSGhtd25qOWFtRENOM1ZXSjMr?= =?utf-8?B?aWx2RVVPVlU5QjRHM3ZwYjlJeTNPbDhtNDk0bTNKNlBvQ2FkQnNYOUJENUlL?= =?utf-8?B?WHhkQUhWdVRaaFZzR0pDcDMySVBKbDBhVE5Yei8vTE1yQUNpWnZrTk84Wjc0?= =?utf-8?B?OU1ZeG8rd0ZJRUxnL3ZCczdEV2VlRlovbFhXR0R4NTVqNHRucU1XUUd4TGhV?= =?utf-8?B?TzB3MXNyL202N0ljZGxnT1gwbStWVFU1aUM1TDh0blIrUmx2TzExTXUyNCtY?= =?utf-8?B?dWxCK1dBYWZIaVdXOGIrc2pYbXM5T3ZVcEJZUEJRUUxXTGxFZktoRWxyNVBl?= =?utf-8?Q?W+yo/j8dHxDU2nyILgkQHA9fM/mKUrzD/6xWqFF?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB5669.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9ab6c070-b370-4bb4-0b04-08d93c99e26f X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Jul 2021 14:09:47.5509 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ZShJsr0mMGx2wRebhN05T8pUr89VxC8alXwKWvozpcPH5UCUSZym+Cb77Z7PGgSVvdRhyVHDx6MHaQclyb7bYP8a6B/J6hcaZnfw/tcb0/E= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB5861 X-OriginatorOrg: citrix.com DQoNCj4gT24gSnVuIDIxLCAyMDIxLCBhdCA1OjExIFBNLCBOaWNrIFJvc2Jyb29rIDxyb3Nicm9v a25AZ21haWwuY29tPiB3cm90ZToNCj4gDQo+IE9uIEZyaSwgSnVuIDE4LCAyMDIxIGF0IDExOjAw OjI2QU0gKzAwMDAsIEdlb3JnZSBEdW5sYXAgd3JvdGU6DQo+PiANCj4+IA0KPj4+IE9uIE1heSAy NCwgMjAyMSwgYXQgOTozNiBQTSwgTmljayBSb3Nicm9vayA8cm9zYnJvb2tuQGdtYWlsLmNvbT4g d3JvdGU6DQo+Pj4gDQo+Pj4gSW4gZ2VuZ290eXBlcy5weSwgdGhlIHRvQyBmdW5jdGlvbnMgb25s eSBzZXQgQyBzdHJpbmcgZmllbGRzIHdoZW4NCj4+PiB0aGUgR28gc3RyaW5ncyBhcmUgbm9uLWVt cHR5LiBIb3dldmVyLCB0byBwcmV2ZW50IHNlZ2ZhdWx0cyBpbiBzb21lDQo+Pj4gY2FzZXMsIHRo ZXNlIGZpZWxkcyBzaG91bGQgYWx3YXlzIGF0IGxlYXN0IGJlIHNldCB0byBuaWwgc28gdGhhdCB0 aGUgQw0KPj4+IG1lbW9yeSBpcyB6ZXJvZWQgb3V0Lg0KPj4+IA0KPj4+IFVwZGF0ZSBnZW5nb3R5 cGVzLnB5IHNvIHRoYXQgdGhlIGdlbmVyYXRlZCBjb2RlIGFsd2F5cyBzZXRzIHRoZXNlIGZpZWxk cw0KPj4+IHRvIG5pbCBmaXJzdCwgYW5kIHRoZW4gcHJvY2VlZHMgdG8gY2hlY2sgaWYgdGhlIEdv IHN0cmluZyBpcyBub24tZW1wdHkuDQo+Pj4gQW5kLCBjb21taXQgdGhlIG5ldyBnZW5lcmF0ZWQg Y29kZS4NCj4+PiANCj4+PiBTaWduZWQtb2ZmLWJ5OiBOaWNrIFJvc2Jyb29rIDxyb3Nicm9va25A YWluZm9zZWMuY29tPg0KPj4gDQo+PiBTbyB3YWl0IOKAlCBpZiB5b3UgZG8NCj4+IA0KPj4gdmFy IGZvbyBDLnR5cGVuYW1lDQo+PiANCj4+IFRoZW4gZ29sYW5nIHdvbuKAmXQgYXV0b21hdGljYWxs eSB6ZXJvIG91dCBgZm9vYD8NCj4+IA0KPj4gVGhhdCBzZWVtcyBsaWtlIGEgYnVnIHJlYWxseTsg YnV0IGFzc3VtaW5nIHRoaXMgZml4ZXMgcmVhbCBiZWhhdmlvciB5b3XigJl2ZSBlbmNvdW50ZXJl ZDoNCj4gDQo+IEkgd291bGQgaGF2ZSB0byBkaWcgaW4gYWdhaW4gdG8gZmlndXJlIG91dCBleGFj dGx5IHdoYXQgR28vY2dvIGlzIGRvaW5nDQo+IGhlcmUsIGFuZCB3aGV0aGVyIG9yIG5vdCB0aGlz IGlzIGEgYnVnLiBCdXQsIHRoZSBiZWhhdmlvciBJIG9ic2VydmVkIHdhcw0KPiB0aGF0IHdpdGhv dXQgdGhlc2UgbmlsIGFzc2lnbm1lbnRzLCBJIHdvdWxkIHNvbWV0aW1lcyBnZXQgc2VnZmF1bHRz IGluDQo+IGxpYnhsX3N0cmluZ19jb3B5LiBUaGlzIHBhdGNoIGVuc3VyZXMgdGhhdCBsaWJ4bF9f c3RyX2R1cCBpcyBub3QgY2FsbGVkDQo+IGluIHRoZSBlbXB0eSBzdHJpbmcgY2FzZSwgdGh1cyBh dm9pZGluZyB0aGUgc2VnZmF1bHQuDQoNCkkgc2tpbW1lZCB0aHJvdWdoIHRoZSBDR28gcGFnZSBh Z2FpbiB3aGVuIEkgd2FzIGxvb2tpbmcgYXQgdGhpcywgYW5kIGRpZG7igJl0IHNlZSBhbnl0aGlu ZyBzcGVjaWZpZWQgYWJvdXQgd2hhdCBoYXBwZW5zIGlmIHNvbWV0aGluZyBpcyBwYXNzZWQgdG8g YSBDIGZ1bmN0aW9uIGJlZm9yZSBiZWluZyB1c2VkIGJ5IGdvbGFuZy4gIElmIHlvdSBnZXQgYSBj aGFuY2UsIEkgdGhpbmsgaXQgd291bGQgYmUgZ29vZCB0byB0cnkgdG8gZmlsZSBhIHRpY2tldCB3 aXRoIHRoZSBnb2xhbmcgcHJvamVjdCwgcG9pbnRpbmcgb3V0IHRoZSBvYnNlcnZlZCBiZWhhdmlv ciwgYW5kIGFza2luZyB0aGVtIHRvIGVpdGhlcjoNCg0KMS4gRG9jdW1lbnQgdGhhdCB0aGUgZ29s YW5nIGNvbXBpbGVyIG1heSBub3QgaW5pdGlhbGl6ZSBhIHN0cnVjdHVyZSBiZWZvcmUgcGFzc2lu ZyBpdCBpbiB0byBhIEMgZnVuY3Rpb24NCg0KMi4gRG9jdW1lbnQgdGhhdCBpdCAqd2lsbCogaW5p dGlhbGl6ZSB2YWx1ZXMgdG8gemVybywgYW5kIGZpeCB0aGUgYnVnLg0KDQogLUdlb3JnZQ== From xen-devel-bounces@lists.xenproject.org Thu Jul 01 14:10:22 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 14:10:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148703.274807 (Exim 4.92) (envelope-from ) id 1lyxOY-0005MA-PT; Thu, 01 Jul 2021 14:10:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148703.274807; Thu, 01 Jul 2021 14:10:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyxOY-0005Lz-KM; Thu, 01 Jul 2021 14:10:22 +0000 Received: by outflank-mailman (input) for mailman id 148703; Thu, 01 Jul 2021 14:10:21 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyxOX-0005KT-06 for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 14:10:21 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id f6d7bec2-fc7c-4841-b48a-662147126978; Thu, 01 Jul 2021 14:10:20 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f6d7bec2-fc7c-4841-b48a-662147126978 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1625148620; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=M6ZtiyzeBF8+xl4b4ReAdiPAiV8nv9ZrRcrwPVwToLw=; b=djwyYSDoGnR6L0cB6cL3Ot8ERH+w5cv68Z4FwVCd36NJVLcFClINhzuj zw6WaNMO9NO0nzDNbPLpTlthkz1ta+Fy6uAAX9IXK/2PZT6Saf67I0jeA /BOKHCb2EN1m+fehpijz0S9wCzU9J7AGB4mfS+kjedfnmxEcggBICTner Q=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: JX4PJpMfXqJB1Jhc9vF/KyT0TFFbWgzenewcihWWkjultgZsxthgoZfN8cTFCjsO6R1XQjOUNI YqP1GKUk8RP6E8GblNXfOkRA0t1D8Qdyuu5BnyqdGQP+1wNcu8dN3PnDHQfNESfq/JMyBSswqB qATb211dJjZxLrrxHwX4kr/u9OclwZPqzLTjpedJSmsAjtFyycNPsSF4CgXNupgYFKaUOOf6ts xRZIWI0yfrkFsxbo9jZRibB7KrQ4mMbTh9UiOzbf9OkVD9CWYVkyTPajS7w1bPzGUJ1m12YX8G BMQ= X-SBRS: 5.1 X-MesageID: 47093296 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:Txlc0KOGQSvGR8BcTvmjsMiBIKoaSvp037Eqv3oedfUzSL3/qy nOpoVi6faaslYssR0b9exofZPwJE80lqQFhrX5X43SPzUO0VHAROoJgLcKgQeQfxEWntQtrJ uIGJIeNDSfNzdHZL7BkWuFL+o= X-IronPort-AV: E=Sophos;i="5.83,314,1616472000"; d="scan'208";a="47093296" From: Anthony PERARD To: CC: Anthony PERARD , Andrew Cooper , George Dunlap , "Ian Jackson" , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [XEN PATCH v6 01/31] build: fix %.s: %.S rule Date: Thu, 1 Jul 2021 15:09:41 +0100 Message-ID: <20210701141011.785641-2-anthony.perard@citrix.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210701141011.785641-1-anthony.perard@citrix.com> References: <20210701141011.785641-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Fixes: e321576f4047 ("xen/build: start using if_changed") Signed-off-by: Anthony PERARD --- Notes: v6: - new patch xen/Rules.mk | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xen/Rules.mk b/xen/Rules.mk index ceb3d204b84f..d65d6a48993b 100644 --- a/xen/Rules.mk +++ b/xen/Rules.mk @@ -227,8 +227,8 @@ cmd_cpp_i_c = $(CPP) $(filter-out -Wa$(comma)%,$(c_flags)) -MQ $@ -o $@ $< quiet_cmd_cc_s_c = CC $@ cmd_cc_s_c = $(CC) $(filter-out -Wa$(comma)%,$(c_flags)) -S $< -o $@ -quiet_cmd_s_S = CPP $@ -cmd_s_S = $(CPP) $(filter-out -Wa$(comma)%,$(a_flags)) -MQ $@ -o $@ $< +quiet_cmd_cpp_s_S = CPP $@ +cmd_cpp_s_S = $(CPP) $(filter-out -Wa$(comma)%,$(a_flags)) -MQ $@ -o $@ $< %.i: %.c FORCE $(call if_changed,cpp_i_c) -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Thu Jul 01 14:10:28 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 14:10:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148705.274818 (Exim 4.92) (envelope-from ) id 1lyxOe-0005gD-1Q; Thu, 01 Jul 2021 14:10:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148705.274818; Thu, 01 Jul 2021 14:10:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyxOd-0005g4-T0; Thu, 01 Jul 2021 14:10:27 +0000 Received: by outflank-mailman (input) for mailman id 148705; Thu, 01 Jul 2021 14:10:27 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyxOd-0005F9-Ie for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 14:10:27 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 115b20d1-da76-11eb-8327-12813bfff9fa; Thu, 01 Jul 2021 14:10:21 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 115b20d1-da76-11eb-8327-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1625148621; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=8wF1OZRVMN+i4dPl8jzrjodmwU9+O8uvhRvJWa7YhLU=; b=Gz3SFPxQKsGE1TkVWplAILoectsooQsY0ULsu7CldwrHwWfZW8V8qwQi c7PNBI5LYPj4YyWObbQ53qgXqG70Bn9ZIcH+6TcHfaMVroBSDz7gNlRHx VApIUhdwcmks6RoAt7I0Bar0J0pblA0EP6cYaI7Mu6LJfFQSYOPLtbe4u A=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: GfoBV98qFKEsx0+8+X25twMo7xYrQOCMiSGiXjJZB00zgSiOH6Lux/lC1O6UFX7cFaijWpt7+Y 6YGank19UXg9Vy2SnUXE/ovuzUQzsCjw+Tp7a+CG+0IPS3imfW82NlbM0UNPi1PZaLzbtq6cL1 XIn4nznTdeF4Urw+kOU4ii9xCz8WKrP9ajKMKRcj5wIDAx4Cv66KR/r6S4zVwIxIQ3zkxgrAtV /+vhiM9a03xW0Sggftt9t1CqRmL2S65JsVekG59dibwnpuVw1Jq3ke7lyH+tt1agKyfLzHYrKp y8k= X-SBRS: 5.1 X-MesageID: 47376076 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:hmFiDqAkgXNXX0vlHemq55DYdb4zR+YMi2TC1yhKJiC9Ffbo8P xG/c5rrCMc5wxxZJhNo7290ey7MBHhHP1OkO0s1NWZPDUO0VHAROoJ0WKh+UyEJ8SXzJ866U 4KScZD4bPLYWSS9fyKgzWFLw== X-IronPort-AV: E=Sophos;i="5.83,314,1616472000"; d="scan'208";a="47376076" From: Anthony PERARD To: CC: Anthony PERARD , Andrew Cooper , George Dunlap , "Ian Jackson" , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Tim Deegan Subject: [XEN PATCH v6 02/31] build: introduce cpp_flags macro Date: Thu, 1 Jul 2021 15:09:42 +0100 Message-ID: <20210701141011.785641-3-anthony.perard@citrix.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210701141011.785641-1-anthony.perard@citrix.com> References: <20210701141011.785641-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Signed-off-by: Anthony PERARD --- Notes: v6: - switch to a macro as suggested which allows to be used with both a_flags and c_flags v5: - new patch xen/Rules.mk | 7 +++++-- xen/arch/x86/mm/Makefile | 2 +- xen/arch/x86/mm/hap/Makefile | 2 +- xen/arch/x86/mm/shadow/Makefile | 2 +- 4 files changed, 8 insertions(+), 5 deletions(-) diff --git a/xen/Rules.mk b/xen/Rules.mk index d65d6a48993b..f778058f80a6 100644 --- a/xen/Rules.mk +++ b/xen/Rules.mk @@ -133,6 +133,9 @@ endif # Always build obj-bin files as binary even if they come from C source. $(obj-bin-y): XEN_CFLAGS := $(filter-out -flto,$(XEN_CFLAGS)) +# To be use with $(a_flags) or $(c_flags) to produce CPP flags +cpp_flags = $(filter-out -Wa$(comma)%,$(1)) + # Calculation of flags, first the generic flags, then the arch specific flags, # and last the flags modified for a target or a directory. @@ -222,13 +225,13 @@ $(filter %.init.o,$(obj-y) $(obj-bin-y) $(extra-y)): %.init.o: %.o FORCE $(call if_changed,obj_init_o) quiet_cmd_cpp_i_c = CPP $@ -cmd_cpp_i_c = $(CPP) $(filter-out -Wa$(comma)%,$(c_flags)) -MQ $@ -o $@ $< +cmd_cpp_i_c = $(CPP) $(call cpp_flags,$(c_flags)) -MQ $@ -o $@ $< quiet_cmd_cc_s_c = CC $@ cmd_cc_s_c = $(CC) $(filter-out -Wa$(comma)%,$(c_flags)) -S $< -o $@ quiet_cmd_cpp_s_S = CPP $@ -cmd_cpp_s_S = $(CPP) $(filter-out -Wa$(comma)%,$(a_flags)) -MQ $@ -o $@ $< +cmd_cpp_s_S = $(CPP) $(call cpp_flags,$(a_flags)) -MQ $@ -o $@ $< %.i: %.c FORCE $(call if_changed,cpp_i_c) diff --git a/xen/arch/x86/mm/Makefile b/xen/arch/x86/mm/Makefile index b31041644fe8..2818c066f76a 100644 --- a/xen/arch/x86/mm/Makefile +++ b/xen/arch/x86/mm/Makefile @@ -15,7 +15,7 @@ guest_walk_%.o: guest_walk.c Makefile $(CC) $(c_flags) -DGUEST_PAGING_LEVELS=$* -c $< -o $@ guest_walk_%.i: guest_walk.c Makefile - $(CPP) $(filter-out -Wa$(comma)%,$(c_flags)) -DGUEST_PAGING_LEVELS=$* -c $< -o $@ + $(CPP) $(call cpp_flags,$(c_flags)) -DGUEST_PAGING_LEVELS=$* -c $< -o $@ guest_walk_%.s: guest_walk.c Makefile $(CC) $(filter-out -Wa$(comma)%,$(c_flags)) -DGUEST_PAGING_LEVELS=$* -S $< -o $@ diff --git a/xen/arch/x86/mm/hap/Makefile b/xen/arch/x86/mm/hap/Makefile index 22e7ad54bd33..c6d296b51720 100644 --- a/xen/arch/x86/mm/hap/Makefile +++ b/xen/arch/x86/mm/hap/Makefile @@ -9,7 +9,7 @@ guest_walk_%level.o: guest_walk.c Makefile $(CC) $(c_flags) -DGUEST_PAGING_LEVELS=$* -c $< -o $@ guest_walk_%level.i: guest_walk.c Makefile - $(CPP) $(filter-out -Wa$(comma)%,$(c_flags)) -DGUEST_PAGING_LEVELS=$* -c $< -o $@ + $(CPP) $(call cpp_flags,$(c_flags)) -DGUEST_PAGING_LEVELS=$* -c $< -o $@ guest_walk_%level.s: guest_walk.c Makefile $(CC) $(filter-out -Wa$(comma)%,$(c_flags)) -DGUEST_PAGING_LEVELS=$* -S $< -o $@ diff --git a/xen/arch/x86/mm/shadow/Makefile b/xen/arch/x86/mm/shadow/Makefile index 770213fe9d84..fd64b4dda925 100644 --- a/xen/arch/x86/mm/shadow/Makefile +++ b/xen/arch/x86/mm/shadow/Makefile @@ -10,7 +10,7 @@ guest_%.o: multi.c Makefile $(CC) $(c_flags) -DGUEST_PAGING_LEVELS=$* -c $< -o $@ guest_%.i: multi.c Makefile - $(CPP) $(filter-out -Wa$(comma)%,$(c_flags)) -DGUEST_PAGING_LEVELS=$* -c $< -o $@ + $(CPP) $(call cpp_flags,$(c_flags)) -DGUEST_PAGING_LEVELS=$* -c $< -o $@ guest_%.s: multi.c Makefile $(CC) $(filter-out -Wa$(comma)%,$(c_flags)) -DGUEST_PAGING_LEVELS=$* -S $< -o $@ -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Thu Jul 01 14:10:30 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 14:10:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148706.274829 (Exim 4.92) (envelope-from ) id 1lyxOg-0005yi-90; Thu, 01 Jul 2021 14:10:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148706.274829; Thu, 01 Jul 2021 14:10:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyxOg-0005yZ-5H; Thu, 01 Jul 2021 14:10:30 +0000 Received: by outflank-mailman (input) for mailman id 148706; Thu, 01 Jul 2021 14:10:28 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyxOe-0005tj-Qs for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 14:10:28 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 4f84f67f-f63d-4cae-b70a-ea7d3a3e3488; Thu, 01 Jul 2021 14:10:27 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4f84f67f-f63d-4cae-b70a-ea7d3a3e3488 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1625148627; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=p6A2leGuQ6JJnCHw9Z1yFaAvywh0FWS/+VLlHmt9w9U=; b=iZiJaWtS487i5ED1ZAtL/56t2zzQWIuZy1hlrXx6D2BibDt74kJajkrw vBJvOUuYDCh6CEbsAM8FC+kgoxMGAVkzhM+2XPH9FoRHRZXJm8NUQt2PS U5BlxW+HiaYzhPYRAlrXcbTOtyyGpyDNJP3O+mZ/z7G9BZAUjbEbfjUkq s=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: lpM6xOx65WR1xO9xPvAF4rH8L42azngx5PsW6pYxbGjjFYhFCC57hXKs7GPPlu4WVaDss+yIfs dZOSG6QaRCMZYkADD6HlldN3PzKiMAYzStupabtHI/mHcA1q1GlyAxtH8wGSFltma4xqLDN11p gDYd9ysXahhsx+DRr5tKSGulFaDV3fgyaOd3iMZR1BNo3qF8Gf3fTkGP6OOieOFJPznu4Oeh4x gFD2NAiiIL/tNb2y+M9OjKfRT1z30/ZCXFJl3x4w6xeoqXff3LmadGAgcmxWBZG4/MI+QVRE3V OJo= X-SBRS: 5.1 X-MesageID: 49007452 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:1jaZlq2nFwHYrwlAs77h1gqjBGEkLtp133Aq2lEZdPWaSL36qy nIpoVh6fYuskdoZJhEo7u90ca7MBThHPJOjrX5eI3OYOCEghrQEGgB1/qG/9SIIUSXygce78 tdmodFebnN5DNB4/oSjjPZLz6oq+PszEgn7d2uskuEkWlRGttdxjY8KAqWC3d7QxQuP/sE/O P23Lsgm9PZQwV0UviG X-IronPort-AV: E=Sophos;i="5.83,314,1616472000"; d="scan'208";a="49007452" From: Anthony PERARD To: CC: Anthony PERARD , Andrew Cooper , George Dunlap , "Ian Jackson" , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Tim Deegan Subject: [XEN PATCH v6 06/31] x86/mm: avoid building multiple .o from a single .c file Date: Thu, 1 Jul 2021 15:09:46 +0100 Message-ID: <20210701141011.785641-7-anthony.perard@citrix.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210701141011.785641-1-anthony.perard@citrix.com> References: <20210701141011.785641-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain This replace the use of a single .c file use for multiple .o file by creating multiple .c file including the first one. There's quite a few issues with trying to build more than one object file from a single source file: there's is a duplication of the make rules to generate those targets; there is an additional ".file" symbol added in order to differentiate between the object files; and the tools/symbols have an heuristic to try to pick up the right ".file". This patch adds new .c source file which avoid the need to add a second ".file" symbol and thus avoid the need to deal with those issues. Also remove __OBJECT_FILE__ from $(CC) command line as it isn't used anywhere anymore. And remove the macro "build-intermediate" since the generic rules for single targets can be used. Signed-off-by: Anthony PERARD --- Notes: v6: - new patch to replace both from v5: xen,symbols: rework file symbols selection build: use if_changed to build mm/*/guest_%.o The changes in the patch for symbols.c was too complicated to explain, and I probably didn't realize one important fact about the tool: it deal with all *.o been concatenated to each other, without a way to figure out which symbol belong to which original file, and certainly no way to figure out if there's more than one ".file" symbol to choose from beside some fragile heuristic. xen/Makefile | 11 ----------- xen/Rules.mk | 2 +- xen/arch/x86/mm/Makefile | 9 --------- xen/arch/x86/mm/guest_walk.c | 3 --- xen/arch/x86/mm/guest_walk_2.c | 2 ++ xen/arch/x86/mm/guest_walk_3.c | 2 ++ xen/arch/x86/mm/guest_walk_4.c | 2 ++ xen/arch/x86/mm/hap/Makefile | 9 --------- xen/arch/x86/mm/hap/guest_walk.c | 3 --- xen/arch/x86/mm/hap/guest_walk_2level.c | 2 ++ xen/arch/x86/mm/hap/guest_walk_3level.c | 2 ++ xen/arch/x86/mm/hap/guest_walk_4level.c | 2 ++ xen/arch/x86/mm/shadow/Makefile | 9 --------- xen/arch/x86/mm/shadow/guest_2.c | 2 ++ xen/arch/x86/mm/shadow/guest_3.c | 2 ++ xen/arch/x86/mm/shadow/guest_4.c | 2 ++ xen/arch/x86/mm/shadow/multi.c | 3 --- xen/tools/symbols.c | 18 ++---------------- 18 files changed, 21 insertions(+), 64 deletions(-) create mode 100644 xen/arch/x86/mm/guest_walk_2.c create mode 100644 xen/arch/x86/mm/guest_walk_3.c create mode 100644 xen/arch/x86/mm/guest_walk_4.c create mode 100644 xen/arch/x86/mm/hap/guest_walk_2level.c create mode 100644 xen/arch/x86/mm/hap/guest_walk_3level.c create mode 100644 xen/arch/x86/mm/hap/guest_walk_4level.c create mode 100644 xen/arch/x86/mm/shadow/guest_2.c create mode 100644 xen/arch/x86/mm/shadow/guest_3.c create mode 100644 xen/arch/x86/mm/shadow/guest_4.c diff --git a/xen/Makefile b/xen/Makefile index 89879fad4cb2..360b4a1d1867 100644 --- a/xen/Makefile +++ b/xen/Makefile @@ -476,17 +476,6 @@ _MAP: %/: FORCE $(MAKE) -f $(BASEDIR)/Rules.mk -C $* built_in.o built_in_bin.o -build-intermediate = $(eval $(call build-intermediate-closure,$(1))) -define build-intermediate-closure -$(1): FORCE - $(MAKE) -f $(BASEDIR)/Rules.mk -C $$(@D) $$(@F) -endef - -$(foreach base,arch/x86/mm/guest_walk_% \ - arch/x86/mm/hap/guest_walk_%level \ - arch/x86/mm/shadow/guest_%, \ - $(foreach ext,o i s,$(call build-intermediate,$(base).$(ext)))) - .PHONY: cloc cloc: $(eval tmpfile := $(shell mktemp)) diff --git a/xen/Rules.mk b/xen/Rules.mk index f05b2d3f0399..ede408efc515 100644 --- a/xen/Rules.mk +++ b/xen/Rules.mk @@ -139,7 +139,7 @@ cpp_flags = $(filter-out -Wa$(comma)%,$(1)) # Calculation of flags, first the generic flags, then the arch specific flags, # and last the flags modified for a target or a directory. -c_flags = -MMD -MP -MF $(@D)/.$(@F).d $(XEN_CFLAGS) '-D__OBJECT_FILE__="$@"' +c_flags = -MMD -MP -MF $(@D)/.$(@F).d $(XEN_CFLAGS) a_flags = -MMD -MP -MF $(@D)/.$(@F).d $(XEN_AFLAGS) include $(BASEDIR)/arch/$(TARGET_ARCH)/Rules.mk diff --git a/xen/arch/x86/mm/Makefile b/xen/arch/x86/mm/Makefile index 2818c066f76a..6b7882d992bb 100644 --- a/xen/arch/x86/mm/Makefile +++ b/xen/arch/x86/mm/Makefile @@ -10,12 +10,3 @@ obj-$(CONFIG_MEM_SHARING) += mem_sharing.o obj-y += p2m.o obj-$(CONFIG_HVM) += p2m-ept.o p2m-pod.o p2m-pt.o obj-y += paging.o - -guest_walk_%.o: guest_walk.c Makefile - $(CC) $(c_flags) -DGUEST_PAGING_LEVELS=$* -c $< -o $@ - -guest_walk_%.i: guest_walk.c Makefile - $(CPP) $(call cpp_flags,$(c_flags)) -DGUEST_PAGING_LEVELS=$* -c $< -o $@ - -guest_walk_%.s: guest_walk.c Makefile - $(CC) $(filter-out -Wa$(comma)%,$(c_flags)) -DGUEST_PAGING_LEVELS=$* -S $< -o $@ diff --git a/xen/arch/x86/mm/guest_walk.c b/xen/arch/x86/mm/guest_walk.c index 30d83cf1e0e6..b9f607272c39 100644 --- a/xen/arch/x86/mm/guest_walk.c +++ b/xen/arch/x86/mm/guest_walk.c @@ -21,9 +21,6 @@ * along with this program; If not, see . */ -/* Allow uniquely identifying static symbols in the 3 generated objects. */ -asm(".file \"" __OBJECT_FILE__ "\""); - #include #include #include diff --git a/xen/arch/x86/mm/guest_walk_2.c b/xen/arch/x86/mm/guest_walk_2.c new file mode 100644 index 000000000000..defcd59bc260 --- /dev/null +++ b/xen/arch/x86/mm/guest_walk_2.c @@ -0,0 +1,2 @@ +#define GUEST_PAGING_LEVELS 2 +#include "guest_walk.c" diff --git a/xen/arch/x86/mm/guest_walk_3.c b/xen/arch/x86/mm/guest_walk_3.c new file mode 100644 index 000000000000..1c9eca37741e --- /dev/null +++ b/xen/arch/x86/mm/guest_walk_3.c @@ -0,0 +1,2 @@ +#define GUEST_PAGING_LEVELS 3 +#include "guest_walk.c" diff --git a/xen/arch/x86/mm/guest_walk_4.c b/xen/arch/x86/mm/guest_walk_4.c new file mode 100644 index 000000000000..aa3900338a2d --- /dev/null +++ b/xen/arch/x86/mm/guest_walk_4.c @@ -0,0 +1,2 @@ +#define GUEST_PAGING_LEVELS 4 +#include "guest_walk.c" diff --git a/xen/arch/x86/mm/hap/Makefile b/xen/arch/x86/mm/hap/Makefile index c6d296b51720..32aef9b4ba26 100644 --- a/xen/arch/x86/mm/hap/Makefile +++ b/xen/arch/x86/mm/hap/Makefile @@ -4,12 +4,3 @@ obj-y += guest_walk_3level.o obj-y += guest_walk_4level.o obj-y += nested_hap.o obj-y += nested_ept.o - -guest_walk_%level.o: guest_walk.c Makefile - $(CC) $(c_flags) -DGUEST_PAGING_LEVELS=$* -c $< -o $@ - -guest_walk_%level.i: guest_walk.c Makefile - $(CPP) $(call cpp_flags,$(c_flags)) -DGUEST_PAGING_LEVELS=$* -c $< -o $@ - -guest_walk_%level.s: guest_walk.c Makefile - $(CC) $(filter-out -Wa$(comma)%,$(c_flags)) -DGUEST_PAGING_LEVELS=$* -S $< -o $@ diff --git a/xen/arch/x86/mm/hap/guest_walk.c b/xen/arch/x86/mm/hap/guest_walk.c index f59ebc84a290..832a8058471e 100644 --- a/xen/arch/x86/mm/hap/guest_walk.c +++ b/xen/arch/x86/mm/hap/guest_walk.c @@ -18,9 +18,6 @@ * this program; If not, see . */ -/* Allow uniquely identifying static symbols in the 3 generated objects. */ -asm(".file \"" __OBJECT_FILE__ "\""); - #include #include #include diff --git a/xen/arch/x86/mm/hap/guest_walk_2level.c b/xen/arch/x86/mm/hap/guest_walk_2level.c new file mode 100644 index 000000000000..defcd59bc260 --- /dev/null +++ b/xen/arch/x86/mm/hap/guest_walk_2level.c @@ -0,0 +1,2 @@ +#define GUEST_PAGING_LEVELS 2 +#include "guest_walk.c" diff --git a/xen/arch/x86/mm/hap/guest_walk_3level.c b/xen/arch/x86/mm/hap/guest_walk_3level.c new file mode 100644 index 000000000000..1c9eca37741e --- /dev/null +++ b/xen/arch/x86/mm/hap/guest_walk_3level.c @@ -0,0 +1,2 @@ +#define GUEST_PAGING_LEVELS 3 +#include "guest_walk.c" diff --git a/xen/arch/x86/mm/hap/guest_walk_4level.c b/xen/arch/x86/mm/hap/guest_walk_4level.c new file mode 100644 index 000000000000..aa3900338a2d --- /dev/null +++ b/xen/arch/x86/mm/hap/guest_walk_4level.c @@ -0,0 +1,2 @@ +#define GUEST_PAGING_LEVELS 4 +#include "guest_walk.c" diff --git a/xen/arch/x86/mm/shadow/Makefile b/xen/arch/x86/mm/shadow/Makefile index fd64b4dda925..b4a1620b6920 100644 --- a/xen/arch/x86/mm/shadow/Makefile +++ b/xen/arch/x86/mm/shadow/Makefile @@ -5,12 +5,3 @@ obj-$(CONFIG_PV) += pv.o guest_4.o else obj-y += none.o endif - -guest_%.o: multi.c Makefile - $(CC) $(c_flags) -DGUEST_PAGING_LEVELS=$* -c $< -o $@ - -guest_%.i: multi.c Makefile - $(CPP) $(call cpp_flags,$(c_flags)) -DGUEST_PAGING_LEVELS=$* -c $< -o $@ - -guest_%.s: multi.c Makefile - $(CC) $(filter-out -Wa$(comma)%,$(c_flags)) -DGUEST_PAGING_LEVELS=$* -S $< -o $@ diff --git a/xen/arch/x86/mm/shadow/guest_2.c b/xen/arch/x86/mm/shadow/guest_2.c new file mode 100644 index 000000000000..288b229982b0 --- /dev/null +++ b/xen/arch/x86/mm/shadow/guest_2.c @@ -0,0 +1,2 @@ +#define GUEST_PAGING_LEVELS 2 +#include "multi.c" diff --git a/xen/arch/x86/mm/shadow/guest_3.c b/xen/arch/x86/mm/shadow/guest_3.c new file mode 100644 index 000000000000..04e17b0b8adc --- /dev/null +++ b/xen/arch/x86/mm/shadow/guest_3.c @@ -0,0 +1,2 @@ +#define GUEST_PAGING_LEVELS 3 +#include "multi.c" diff --git a/xen/arch/x86/mm/shadow/guest_4.c b/xen/arch/x86/mm/shadow/guest_4.c new file mode 100644 index 000000000000..c0c5d3cb11ad --- /dev/null +++ b/xen/arch/x86/mm/shadow/guest_4.c @@ -0,0 +1,2 @@ +#define GUEST_PAGING_LEVELS 4 +#include "multi.c" diff --git a/xen/arch/x86/mm/shadow/multi.c b/xen/arch/x86/mm/shadow/multi.c index 8bb028c2e2fa..7207fcf9e75f 100644 --- a/xen/arch/x86/mm/shadow/multi.c +++ b/xen/arch/x86/mm/shadow/multi.c @@ -20,9 +20,6 @@ * along with this program; If not, see . */ -/* Allow uniquely identifying static symbols in the 3 generated objects. */ -asm(".file \"" __OBJECT_FILE__ "\""); - #include #include #include diff --git a/xen/tools/symbols.c b/xen/tools/symbols.c index 0b124526165d..710e9785d348 100644 --- a/xen/tools/symbols.c +++ b/xen/tools/symbols.c @@ -84,7 +84,6 @@ static int read_symbol(FILE *in, struct sym_entry *s) { char str[500], type[20] = ""; char *sym, stype; - static enum { symbol, single_source, multi_source } last; static char *filename; int rc = -1; @@ -118,24 +117,11 @@ static int read_symbol(FILE *in, struct sym_entry *s) */ input_format == fmt_sysv && !*type && stype == '?' && sym && sym[1] && strchr("cSsoh", sym[1]) && !sym[2])) { - /* - * gas prior to binutils commit fbdf9406b0 (expected to appear - * in 2.27) outputs symbol table entries resulting from .file - * in reverse order. If we get two consecutive file symbols, - * prefer the first one if that names an object file or has a - * directory component (to cover multiply compiled files). - */ - bool multi = strchr(str, '/') || (sym && sym[1] == 'o'); - - if (multi || last != multi_source) { - free(filename); - filename = *str ? strdup(str) : NULL; - } - last = multi ? multi_source : single_source; + free(filename); + filename = *str ? strdup(str) : NULL; goto skip_tail; } - last = symbol; rc = -1; sym = str; -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Thu Jul 01 14:10:32 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 14:10:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148707.274840 (Exim 4.92) (envelope-from ) id 1lyxOi-0006Kh-Ns; Thu, 01 Jul 2021 14:10:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148707.274840; Thu, 01 Jul 2021 14:10:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyxOi-0006KQ-K6; Thu, 01 Jul 2021 14:10:32 +0000 Received: by outflank-mailman (input) for mailman id 148707; Thu, 01 Jul 2021 14:10:31 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyxOg-0005tj-Vv for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 14:10:31 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 55f3a9fb-720c-452f-92ed-fae6b830b800; Thu, 01 Jul 2021 14:10:28 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 55f3a9fb-720c-452f-92ed-fae6b830b800 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1625148628; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=WNQw53D2CBl7IfW7DXoevzSfofTFknY56S4ZzC5yIeA=; b=I088QyBYbmJgARWg3Rl1kWwYGKh6OVysOFfctpmQYsAubBdFIKYgeTnm ZlQdcg2xM0y3FfYb4JNNyqZN5ibFk1BE7nn9S7xc6uV+sROVx3m/pZbiE +SBh5maz81JC7ojjj7EyO7Pl02efi6Of4zPCe12jcxA2Y9W1SyEO2aAWn A=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: R+4i4GvhQ/bsJUtm/f25GRNBFTY3QnEzZIDpOXXFfnM5XPyNmcnKTNMALl1I858HTbrVLZVixL FgY6jes9ShraMHqbhQlMzSz8xTfRFUc9jB7H1cETWgAamV0+K9rrCleR8qbkJ0a0BRdAQ9eYaP nUvRrZOqNNPCZlfHQPUvTRpOcY27WfA4TJ5l//hJnCFFvDQvJ2gox59VU6cgAH4FAwStzGRh0f IvuCpRqKjohQzU3SLVpZMJktlV2zWnSMmKVSs5/fCBnhAyBheMMWULR8HDZNLd5afZ0WMwzF3W Izk= X-SBRS: 5.1 X-MesageID: 47093323 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:fExu1qhU81WMd6RejdhUkxV2BnBQXuIji2hC6mlwRA09TySZ// rBoB19726TtN9xYgBZpTnuAsm9qB/nmaKdpLNhWItKPzOW31dATrsSjrcKqgeIc0aVm9K1l5 0QF5SWYOeAdGSS5vya3ODXKbkdKaG8gcKVuds= X-IronPort-AV: E=Sophos;i="5.83,314,1616472000"; d="scan'208";a="47093323" From: Anthony PERARD To: CC: Anthony PERARD , Jan Beulich , Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu Subject: [XEN PATCH v6 07/31] build,include: rework compat-build-source.py Date: Thu, 1 Jul 2021 15:09:47 +0100 Message-ID: <20210701141011.785641-8-anthony.perard@citrix.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210701141011.785641-1-anthony.perard@citrix.com> References: <20210701141011.785641-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Improvement are: - give the path to xlat.lst as argument - include `grep -v` in compat-build-source.py script, we don't need to write this in several scripted language. Also remove dependency on Makefile as the file generation doesn't depend on it anymore. No changes in final compat/%.h headers. Signed-off-by: Anthony PERARD Acked-by: Jan Beulich --- Notes: v6: - remove dependency on Makefile as it's not needed anymore v5: - removed "have 'xlat.lst' path as a variable" from the patch. v4: - new patch xen/include/Makefile | 5 ++--- xen/tools/compat-build-source.py | 8 +++++++- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/xen/include/Makefile b/xen/include/Makefile index c8ca97eed0fc..be3b81485bdc 100644 --- a/xen/include/Makefile +++ b/xen/include/Makefile @@ -59,10 +59,9 @@ compat/%.h: compat/%.i Makefile $(BASEDIR)/tools/compat-build-header.py compat/%.i: compat/%.c Makefile $(CPP) $(filter-out -Wa$(comma)% -include %/include/xen/config.h,$(XEN_CFLAGS)) $(cppflags-y) -o $@ $< -compat/%.c: public/%.h xlat.lst Makefile $(BASEDIR)/tools/compat-build-source.py +compat/%.c: public/%.h xlat.lst $(BASEDIR)/tools/compat-build-source.py mkdir -p $(@D) - grep -v 'DEFINE_XEN_GUEST_HANDLE(long)' $< | \ - $(PYTHON) $(BASEDIR)/tools/compat-build-source.py >$@.new + $(PYTHON) $(BASEDIR)/tools/compat-build-source.py xlat.lst <$< >$@.new mv -f $@.new $@ compat/.xlat/%.h: compat/%.h compat/.xlat/%.lst $(BASEDIR)/tools/get-fields.sh Makefile diff --git a/xen/tools/compat-build-source.py b/xen/tools/compat-build-source.py index 2bcaf27d05a3..274d6917ab7f 100755 --- a/xen/tools/compat-build-source.py +++ b/xen/tools/compat-build-source.py @@ -13,7 +13,11 @@ pats = [ [ r"XEN_GUEST_HANDLE", r"COMPAT_HANDLE" ], ]; -xlatf = open('xlat.lst', 'r') +try: + xlatf = open(sys.argv[1], 'r') +except IndexError: + print('missing path to xlat.lst argument') + sys.exit(1) for line in xlatf.readlines(): match = re.subn(r"^\s*\?\s+(\w*)\s.*", r"\1", line.rstrip()) if match[1]: @@ -25,6 +29,8 @@ for pat in pats: pat[0] = re.compile(pat[0]) for line in sys.stdin.readlines(): + if 'DEFINE_XEN_GUEST_HANDLE(long)' in line: + continue for pat in pats: line = re.sub(pat[0], pat[1], line) print(line.rstrip()) -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Thu Jul 01 14:10:34 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 14:10:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148708.274851 (Exim 4.92) (envelope-from ) id 1lyxOk-0006ct-3t; Thu, 01 Jul 2021 14:10:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148708.274851; Thu, 01 Jul 2021 14:10:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyxOj-0006bk-Ud; Thu, 01 Jul 2021 14:10:33 +0000 Received: by outflank-mailman (input) for mailman id 148708; Thu, 01 Jul 2021 14:10:32 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyxOi-0005F9-Iq for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 14:10:32 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 1306551c-da76-11eb-8327-12813bfff9fa; Thu, 01 Jul 2021 14:10:22 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1306551c-da76-11eb-8327-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1625148622; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Pns9739RItoS5khKorq30ivslZu4OAvxwnMWwlNaAu0=; b=VRv/d+8Ab4l2j1QVYGgQcCxHaz8rTmAQeQrfE1oKYLgn5HNXE9mUXUjA rJp0lfZIAbEsB2ytZirznyASonnzg279ZlBq26kmCurs935yfhuJGmj1S GYNr2Mrhbnh5kpeKXW7Vc37rpRD5gmklejF83uIMOqVKEbuyZKmwBKd5K E=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: 3rn9hvSyOIjLz1zTcJ0VvqoZ9PirUNBSml1KaMuBm1To5iUDM40jDpjk2yN3b96kmcikzwI4RA Xr1IRL8o9y59sV6bV14kzfBa3mxb3sEvKoOi2sZf63yle3ertoEX4j9QzuRASTeqgJ0Y/UzwCC xPGrTOKhsPmvaF5ZJwAZAnQ5KEPJW3WgLNMQyQQtTn+dnbaShaVYZ+mIlpBlIpWZP6A5uC1BKp YA/AnW17sGoh9nKyvdO5EBUdS37Og6FCULGh/TCTw1GGna1+ymE6WAN54Ez9rGPxPWHlut3gNS fv4= X-SBRS: 5.1 X-MesageID: 47376079 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:FEn/IagvOulIic/Rfb6eLCv9enBQXuIji2hC6mlwRA09TySZ// rBoB19726TtN9xYgBZpTnuAsm9qB/nmaKdpLNhWItKPzOW31dATrsSjrcKqgeIc0aVm9K1l5 0QF5SWYOeAdGSS5vya3ODXKbkdKaG8gcKVuds= X-IronPort-AV: E=Sophos;i="5.83,314,1616472000"; d="scan'208";a="47376079" From: Anthony PERARD To: CC: Anthony PERARD , Jan Beulich , Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu Subject: [XEN PATCH v6 03/31] build: use if_changed on built_in.o Date: Thu, 1 Jul 2021 15:09:43 +0100 Message-ID: <20210701141011.785641-4-anthony.perard@citrix.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210701141011.785641-1-anthony.perard@citrix.com> References: <20210701141011.785641-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain In the case where $(obj-y) is empty, we also replace $(c_flags) by $(XEN_CFLAGS) to avoid generating an .%.d dependency file. This avoid make trying to include %.h file in the ld command if $(obj-y) isn't empty anymore on a second run. Signed-off-by: Anthony PERARD Acked-by: Jan Beulich --- Notes: v6: - use $(if $(strip $(obj-y)),ld_builtin,cc_builtin) as suggested - rebased v4: - Have cmd_ld_builtin depends on CONFIG_LTO, which simplify built_in.o rule. xen/Rules.mk | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/xen/Rules.mk b/xen/Rules.mk index f778058f80a6..6a0cdfde2eed 100644 --- a/xen/Rules.mk +++ b/xen/Rules.mk @@ -147,17 +147,22 @@ include $(BASEDIR)/arch/$(TARGET_ARCH)/Rules.mk c_flags += $(CFLAGS-y) a_flags += $(CFLAGS-y) $(AFLAGS-y) -built_in.o: $(obj-y) $(if $(strip $(lib-y)),lib.a) $(extra-y) -ifeq ($(strip $(obj-y)),) - $(CC) $(c_flags) -c -x c /dev/null -o $@ -else +quiet_cmd_cc_builtin = LD $@ +cmd_cc_builtin = \ + $(CC) $(XEN_CFLAGS) -c -x c /dev/null -o $@ + +quiet_cmd_ld_builtin = LD $@ ifeq ($(CONFIG_LTO),y) - $(LD_LTO) -r -o $@ $(filter $(obj-y),$^) +cmd_ld_builtin = \ + $(LD_LTO) -r -o $@ $(filter $(obj-y),$(real-prereqs)) else - $(LD) $(XEN_LDFLAGS) -r -o $@ $(filter $(obj-y),$^) -endif +cmd_ld_builtin = \ + $(LD) $(XEN_LDFLAGS) -r -o $@ $(filter $(obj-y),$(real-prereqs)) endif +built_in.o: $(obj-y) $(if $(strip $(lib-y)),lib.a) $(extra-y) FORCE + $(call if_changed,$(if $(strip $(obj-y)),ld_builtin,cc_builtin)) + lib.a: $(lib-y) FORCE $(call if_changed,ar) -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Thu Jul 01 14:10:37 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 14:10:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148709.274862 (Exim 4.92) (envelope-from ) id 1lyxOn-00073f-Fi; Thu, 01 Jul 2021 14:10:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148709.274862; Thu, 01 Jul 2021 14:10:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyxOn-00072Q-BJ; Thu, 01 Jul 2021 14:10:37 +0000 Received: by outflank-mailman (input) for mailman id 148709; Thu, 01 Jul 2021 14:10:36 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyxOl-0005tj-Vm for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 14:10:36 +0000 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 09ef554a-cc6f-4393-bec9-018267e96a0b; Thu, 01 Jul 2021 14:10:30 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 09ef554a-cc6f-4393-bec9-018267e96a0b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1625148630; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=P2E0W/gctKSv9qL8/o+vMgXc//AFHVWuP07uAhIiJh4=; b=h5xlRTJERNCZIb4MfXn0paw4thhIvhuz4PWdYI5X/5WeGLwmd0TTHhcj TLco105FdRIfN/THbmt5aCfmuEYBZijGMYw24xYgDsxx7iqSvdrH3t0Z8 SliOPRpgmjl99il0uI1biOQyIm5D0wrpcr0+wlp9tjl74Y4LgZ0iXbhDG c=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: grgSpt4fWT8iOSPspjf8uGICLMQU/Xg+FsFXwSYR71Q1UMQ4NXITI5Ow9zIJmjSDTLUBsLj4jg aJ6z9LmtP+5zzltsferH1oYFnsZq0MwBaMpxYjdmGoShRUxE0zMoVmlsXVzpACaIuNzfcgg7H+ +p0Wd02cOtVzWOGVP+sEpW4lBhuJFxX/VBWwwibFp89aAg5m0EoNZYpAe8oRpObtzuJEKkZp3h 1EGdSuFWbRjkiQVVccDCelGLnUvEJ0hHq/Nx6lc0sKJim81fqlIIb6feaEZv7dS3K2IPpbcQQZ JDw= X-SBRS: 5.1 X-MesageID: 47446790 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:2+1tPq6o+GDVMMmE2APXwM7XdLJyesId70hD6qhwISY7TiX+rb HIoB17726MtN9/YhAdcLy7VZVoBEmsl6KdgrNhWYtKPjOHhILAFugLhuHfKn/bakjDH4ZmpM FdmsNFZuEYY2IXsS+D2njaL+od X-IronPort-AV: E=Sophos;i="5.83,314,1616472000"; d="scan'208";a="47446790" From: Anthony PERARD To: CC: Anthony PERARD , Wei Liu , "Andrew Cooper" , George Dunlap , Ian Jackson , Jan Beulich , "Julien Grall" , Stefano Stabellini Subject: [XEN PATCH v6 08/31] build,include: rework compat-build-header.py Date: Thu, 1 Jul 2021 15:09:48 +0100 Message-ID: <20210701141011.785641-9-anthony.perard@citrix.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210701141011.785641-1-anthony.perard@citrix.com> References: <20210701141011.785641-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Replace a mix of shell script and python script by all python script. Also remove dependency on Makefile as the file generation doesn't depend on it anymore. No change to the final generated headers. Signed-off-by: Anthony PERARD Acked-by: Wei Liu --- Notes: v6: - removed handling of $(prefix-y) and $(suffix-y), they've been removed. - remove dependency on Makefile as it's not needed anymore - rebased v5: - Removed -P from CPP when generating compat/%.i -> keep removing linemarkers and keep de-duplicating empty lines. So that all the blank line that currently exist in the generated headers stays in place. v4: - new patch xen/include/Makefile | 11 ++------ xen/tools/compat-build-header.py | 44 ++++++++++++++++++++++++++++++-- 2 files changed, 44 insertions(+), 11 deletions(-) diff --git a/xen/include/Makefile b/xen/include/Makefile index be3b81485bdc..9feb57545ef1 100644 --- a/xen/include/Makefile +++ b/xen/include/Makefile @@ -45,15 +45,8 @@ public-$(CONFIG_ARM) := $(wildcard public/arch-arm/*.h public/arch-arm/*/*.h) .PHONY: all all: $(headers-y) -compat/%.h: compat/%.i Makefile $(BASEDIR)/tools/compat-build-header.py - set -e; id=_$$(echo $@ | tr '[:lower:]-/.' '[:upper:]___'); \ - echo "#ifndef $$id" >$@.new; \ - echo "#define $$id" >>$@.new; \ - echo "#include " >>$@.new; \ - $(if $(filter-out compat/arch-%.h,$@),echo "#include <$(patsubst compat/%,public/%,$@)>" >>$@.new;) \ - grep -v '^# [0-9]' $< | \ - $(PYTHON) $(BASEDIR)/tools/compat-build-header.py | uniq >>$@.new; \ - echo "#endif /* $$id */" >>$@.new +compat/%.h: compat/%.i $(BASEDIR)/tools/compat-build-header.py + $(PYTHON) $(BASEDIR)/tools/compat-build-header.py <$< $@ >>$@.new; \ mv -f $@.new $@ compat/%.i: compat/%.c Makefile diff --git a/xen/tools/compat-build-header.py b/xen/tools/compat-build-header.py index 065d3b1b6ee8..5f5474fba051 100755 --- a/xen/tools/compat-build-header.py +++ b/xen/tools/compat-build-header.py @@ -2,6 +2,12 @@ import re,sys +try: + maketrans = str.maketrans +except AttributeError: + # For python2 + from string import maketrans + pats = [ [ r"__InClUdE__(.*)", r"#include\1" ], [ r"__IfDeF__ (XEN_HAVE.*)", r"#ifdef \1" ], @@ -23,7 +29,41 @@ pats = [ [ r"(^|[^\w])long([^\w]|$$)", r"\1int\2" ] ]; +output_filename = sys.argv[1] + +# tr '[:lower:]-/.' '[:upper:]___' +header_id = '_' + \ + output_filename.upper().translate(maketrans('-/.','___')) + +header = """#ifndef {0} +#define {0} +#include """.format(header_id) + +print(header) + +if not re.match("compat/arch-.*.h$", output_filename): + x = output_filename.replace("compat/","public/") + print('#include <%s>' % x) + +last_line_empty = False for line in sys.stdin.readlines(): + line = line.rstrip() + + # Remove linemarkers generated by the preprocessor. + if re.match(r"^# \d", line): + continue + + # De-duplicate empty lines. + if len(line) == 0: + if not last_line_empty: + print(line) + last_line_empty = True + continue + else: + last_line_empty = False + for pat in pats: - line = re.subn(pat[0], pat[1], line)[0] - print(line.rstrip()) + line = re.sub(pat[0], pat[1], line) + print(line) + +print("#endif /* %s */" % header_id) -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Thu Jul 01 14:10:39 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 14:10:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148710.274872 (Exim 4.92) (envelope-from ) id 1lyxOp-0007MU-02; Thu, 01 Jul 2021 14:10:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148710.274872; Thu, 01 Jul 2021 14:10:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyxOo-0007ME-Q6; Thu, 01 Jul 2021 14:10:38 +0000 Received: by outflank-mailman (input) for mailman id 148710; Thu, 01 Jul 2021 14:10:37 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyxOn-0005F9-JC for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 14:10:37 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 0fe08080-da76-11eb-8327-12813bfff9fa; Thu, 01 Jul 2021 14:10:19 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0fe08080-da76-11eb-8327-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1625148620; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=QdYelS8NaZ6G8BQPcUzIhJ1B8dc4YjNwoApXWn17CtM=; b=IjrJ5W+pShq2A1x5gJnE9NsjlOh1IQXTmuBLbMhgMrAIXy+PahNZk74w M4yXEZTE8X/uynk0SSlGcnGRIObPKy50kO+OjERC9dQ+TsYUl9UwNkx36 n17FJJBSEOQaKZOSyV+UtoWhyNHQetvLsI8bgLQVYLFsAz20WkxMCqmMG 4=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: 7bgFLSzrs+Zu58NlCL1z+vgNXhDSUuJL27/RRn0GCfNfZokSPc0lqN08hTAvVA36oRoMprbeZL rYfTMQihX5kDoEZBAMfRemW6qg1E1W5v/xOpx/vuXsPrj55ASR97Z/K+qBRTP2vK9mXSrsBYKM 608+w651r8XaXHEaJKQXY4ZnJo/dzSpgDjQRlE3ZbSftRQeRAqFkvQ/Meagabl8tt8+BbFeXj2 c33vHYxWqg6urQ+eyzgCiJzdnEmiDE/hXU/anWyBkH2J6oLyQhwi8aqSYYp9w2EGrt5Lm77V7Q rsw= X-SBRS: 5.1 X-MesageID: 47755309 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:0OyC3ataI8u22IOSFmrXKua67skDjNV00zEX/kB9WHVpm6yj+v xGUs566faUskd0ZJhEo7q90ca7Lk80maQa3WBzB8bGYOCFghrKEGgK1+KLrwEIcxeUygc379 YDT0ERMrzN5VgRt7eG3OG7eexQvOVuJsqT9JjjJ3QGd3AVV0l5hT0JbTpyiidNNXJ77ZxSLu v72uN34wCOVF4wdcqBCnwMT4H41qf2fMKPW29+O/Y/gjP+9Q+V1A== X-IronPort-AV: E=Sophos;i="5.83,314,1616472000"; d="scan'208";a="47755309" From: Anthony PERARD To: CC: Anthony PERARD , Tim Deegan , Konrad Rzeszutek Wilk , Petre Pircalabu , Daniel De Graaf , "Jan Beulich" , George Dunlap , "Ian Jackson" , Kevin Tian , "Ross Lagerwall" , Alexandru Isaila , Wei Liu , Bob Eshleman , Stefano Stabellini , "Jun Nakajima" , Lukasz Hawrylko , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Paul Durrant , Tamas K Lengyel , Julien Grall , Alistair Francis , Connor Davis , "Daniel P. Smith" , Volodymyr Babchuk , Andrew Cooper Subject: [XEN PATCH v6 00/31] xen: Build system improvements Date: Thu, 1 Jul 2021 15:09:40 +0100 Message-ID: <20210701141011.785641-1-anthony.perard@citrix.com> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Patch series available in this git branch: https://xenbits.xen.org/git-http/people/aperard/xen-unstable.git br.build-system-xen-v6 v6: This new version of the series get's us very close to be able to do out-of-tree build, but I've stop at been able to use Linux's `fixdep` and getting rid of those annoying *.d2 files generation. There a few patch left from the previous round within the first 8 patches (mixed with new or replaced patches). All the rest is new. The main patch is probably "build: build everything from the root dir, use obj=$subdir" which has still quite a few changes left. I might be still be able to break it down even more if needed to help with review (and might allow me to better explain some changes in it). v5: https://lore.kernel.org/xen-devel/20200421161208.2429539-1-anthony.perard@citrix.com/ - few changes detailed in patch notes. - 1 new patch Hi, I have work toward building Xen (the hypervisor) with Linux's build system, Kbuild. The main reason for that is to be able to have out-of-tree build. It's annoying when a build fail because of the pvshim. Other benefit is a much faster rebuild, and `make clean` doesn't take ages, and better dependencies to figure out what needs to be rebuild. This new version of the series get's us very close to be able to do out-of-tree build, but I've stop at been able to use Linux's `fixdep` and getting rid of those annoying *.d2 files. Cheers, Anthony PERARD (31): build: fix %.s: %.S rule build: introduce cpp_flags macro build: use if_changed on built_in.o build: use if_changed_rules with %.o:%.c targets build: factorise generation of the linker scripts x86/mm: avoid building multiple .o from a single .c file build,include: rework compat-build-source.py build,include: rework compat-build-header.py build: clean "lib.a" build: use $(kconfig) shortcut in clean rule build: fix clean targets when subdir-y is used build: use subdir-y in test/Makefile build,tools: have default rules depends on symbols build,arm: move LDFLAGS change to arch.mk build: move make option changes check earlier build: avoid building arm/arm/*/head.o twice build: convert binfile use to if_changed xen: move include/asm-* to include/arch-*/asm build: rework .banner generation build: generate "include/xen/compile.h" with filechk build: set XEN_BUILD_EFI earlier build: fix $(TARGET).efi creation in arch/arm build: fix arch/x86/node.o rule build: set ALL_OBJS to main Makefile; move prelink.o to main Makefile build: remove unneeded deps of x86_emulate.o build: clean common temporary files from root makefile build: prepare to always invoke $(MAKE) from xen/, use $(obj) build: rework test/livepatch/Makefile build: build everything from the root dir, use obj=$subdir build: introduce if_changed_deps build,riscv: tell the build system about riscv64/head.S .gitignore | 6 +- MAINTAINERS | 36 +- tools/include/Makefile | 2 +- tools/misc/xen-access.c | 4 +- tools/tests/vhpet/Makefile | 2 +- xen/Makefile | 209 ++++++--- xen/Rules.mk | 222 +++++----- xen/arch/arm/Makefile | 50 +-- xen/arch/arm/README.LinuxPrimitives | 10 +- xen/arch/arm/arch.mk | 13 +- xen/arch/arm/arm32/Makefile | 1 + xen/arch/arm/arm32/head.S | 2 +- xen/arch/arm/arm64/Makefile | 2 + xen/arch/arm/arm64/head.S | 2 +- xen/arch/arm/smpboot.c | 2 +- xen/arch/arm/vpsci.c | 2 +- xen/arch/riscv/arch.mk | 3 +- xen/arch/riscv/riscv64/Makefile | 1 + xen/arch/x86/Makefile | 105 ++--- xen/arch/x86/Rules.mk | 4 +- xen/arch/x86/arch.mk | 16 +- xen/arch/x86/boot/Makefile | 14 +- xen/arch/x86/efi/Makefile | 6 +- xen/arch/x86/mm/Makefile | 9 - xen/arch/x86/mm/guest_walk.c | 3 - xen/arch/x86/mm/guest_walk_2.c | 2 + xen/arch/x86/mm/guest_walk_3.c | 2 + xen/arch/x86/mm/guest_walk_4.c | 2 + xen/arch/x86/mm/hap/Makefile | 9 - xen/arch/x86/mm/hap/guest_walk.c | 3 - xen/arch/x86/mm/hap/guest_walk_2level.c | 2 + xen/arch/x86/mm/hap/guest_walk_3level.c | 2 + xen/arch/x86/mm/hap/guest_walk_4level.c | 2 + xen/arch/x86/mm/shadow/Makefile | 9 - xen/arch/x86/mm/shadow/guest_2.c | 2 + xen/arch/x86/mm/shadow/guest_3.c | 2 + xen/arch/x86/mm/shadow/guest_4.c | 2 + xen/arch/x86/mm/shadow/multi.c | 3 - xen/common/Makefile | 12 +- xen/common/efi/runtime.c | 14 +- xen/common/libelf/Makefile | 4 +- xen/common/libfdt/Makefile | 6 +- xen/common/page_alloc.c | 2 +- xen/include/Makefile | 60 ++- xen/include/{asm-arm => arch-arm/asm}/acpi.h | 0 .../{asm-arm => arch-arm/asm}/alternative.h | 0 .../{asm-arm => arch-arm/asm}/altp2m.h | 0 .../{asm-arm => arch-arm/asm}/arm32/atomic.h | 0 .../{asm-arm => arch-arm/asm}/arm32/bitops.h | 0 .../{asm-arm => arch-arm/asm}/arm32/bug.h | 0 .../{asm-arm => arch-arm/asm}/arm32/cmpxchg.h | 0 .../asm}/arm32/flushtlb.h | 0 .../{asm-arm => arch-arm/asm}/arm32/insn.h | 0 .../{asm-arm => arch-arm/asm}/arm32/io.h | 0 .../{asm-arm => arch-arm/asm}/arm32/macros.h | 0 .../{asm-arm => arch-arm/asm}/arm32/mm.h | 0 .../{asm-arm => arch-arm/asm}/arm32/page.h | 0 .../asm}/arm32/processor.h | 0 .../{asm-arm => arch-arm/asm}/arm32/sysregs.h | 0 .../{asm-arm => arch-arm/asm}/arm32/system.h | 0 .../{asm-arm => arch-arm/asm}/arm32/traps.h | 0 .../{asm-arm => arch-arm/asm}/arm32/vfp.h | 0 .../{asm-arm => arch-arm/asm}/arm64/atomic.h | 0 .../{asm-arm => arch-arm/asm}/arm64/bitops.h | 0 .../{asm-arm => arch-arm/asm}/arm64/brk.h | 0 .../{asm-arm => arch-arm/asm}/arm64/bug.h | 0 .../{asm-arm => arch-arm/asm}/arm64/cmpxchg.h | 0 .../{asm-arm => arch-arm/asm}/arm64/efibind.h | 0 .../asm}/arm64/flushtlb.h | 0 .../{asm-arm => arch-arm/asm}/arm64/hsr.h | 0 .../{asm-arm => arch-arm/asm}/arm64/insn.h | 0 .../{asm-arm => arch-arm/asm}/arm64/io.h | 0 .../{asm-arm => arch-arm/asm}/arm64/macros.h | 0 .../{asm-arm => arch-arm/asm}/arm64/mm.h | 0 .../{asm-arm => arch-arm/asm}/arm64/page.h | 0 .../asm}/arm64/processor.h | 0 .../{asm-arm => arch-arm/asm}/arm64/sysregs.h | 0 .../{asm-arm => arch-arm/asm}/arm64/system.h | 0 .../{asm-arm => arch-arm/asm}/arm64/traps.h | 0 .../{asm-arm => arch-arm/asm}/arm64/vfp.h | 0 .../{asm-arm => arch-arm/asm}/asm_defns.h | 0 .../{asm-arm => arch-arm/asm}/atomic.h | 0 .../{asm-arm => arch-arm/asm}/bitops.h | 0 xen/include/{asm-arm => arch-arm/asm}/bug.h | 0 .../{asm-arm => arch-arm/asm}/byteorder.h | 0 xen/include/{asm-arm => arch-arm/asm}/cache.h | 0 .../{asm-arm => arch-arm/asm}/cadence-uart.h | 0 .../{asm-arm => arch-arm/asm}/config.h | 0 .../{asm-arm => arch-arm/asm}/cpregs.h | 0 .../{asm-arm => arch-arm/asm}/cpuerrata.h | 0 .../{asm-arm => arch-arm/asm}/cpufeature.h | 0 .../{asm-arm => arch-arm/asm}/current.h | 0 .../{asm-arm => arch-arm/asm}/debugger.h | 0 xen/include/{asm-arm => arch-arm/asm}/delay.h | 0 xen/include/{asm-arm => arch-arm/asm}/desc.h | 0 .../{asm-arm => arch-arm/asm}/device.h | 0 xen/include/{asm-arm => arch-arm/asm}/div64.h | 0 .../{asm-arm => arch-arm/asm}/domain.h | 0 .../{asm-arm => arch-arm/asm}/domain_build.h | 0 .../{asm-arm => arch-arm/asm}/early_printk.h | 0 .../{asm-arm => arch-arm/asm}/efibind.h | 0 xen/include/{asm-arm => arch-arm/asm}/elf.h | 0 xen/include/{asm-arm => arch-arm/asm}/event.h | 0 .../asm}/exynos4210-uart.h | 0 .../{asm-arm => arch-arm/asm}/flushtlb.h | 0 xen/include/{asm-arm => arch-arm/asm}/gic.h | 0 .../{asm-arm => arch-arm/asm}/gic_v3_defs.h | 0 .../{asm-arm => arch-arm/asm}/gic_v3_its.h | 0 .../{asm-arm => arch-arm/asm}/grant_table.h | 0 .../{asm-arm => arch-arm/asm}/guest_access.h | 0 .../{asm-arm => arch-arm/asm}/guest_atomics.h | 0 .../{asm-arm => arch-arm/asm}/guest_walk.h | 0 .../{asm-arm => arch-arm/asm}/hardirq.h | 0 xen/include/{asm-arm => arch-arm/asm}/hsr.h | 0 .../{asm-arm => arch-arm/asm}/hypercall.h | 0 xen/include/{asm-arm => arch-arm/asm}/init.h | 0 xen/include/{asm-arm => arch-arm/asm}/insn.h | 0 xen/include/{asm-arm => arch-arm/asm}/io.h | 0 xen/include/{asm-arm => arch-arm/asm}/iocap.h | 0 xen/include/{asm-arm => arch-arm/asm}/iommu.h | 0 .../{asm-arm => arch-arm/asm}/iommu_fwspec.h | 0 xen/include/{asm-arm => arch-arm/asm}/ioreq.h | 0 xen/include/{asm-arm => arch-arm/asm}/irq.h | 0 .../{asm-arm => arch-arm/asm}/kernel.h | 0 .../{asm-arm => arch-arm/asm}/livepatch.h | 0 xen/include/{asm-arm => arch-arm/asm}/lpae.h | 0 .../{asm-arm => arch-arm/asm}/macros.h | 0 .../{asm-arm => arch-arm/asm}/mem_access.h | 0 xen/include/{asm-arm => arch-arm/asm}/mm.h | 0 xen/include/{asm-arm => arch-arm/asm}/mmio.h | 0 .../{asm-arm => arch-arm/asm}/monitor.h | 0 .../{asm-arm => arch-arm/asm}/new_vgic.h | 0 .../{asm-arm => arch-arm/asm}/nospec.h | 0 xen/include/{asm-arm => arch-arm/asm}/numa.h | 0 xen/include/{asm-arm => arch-arm/asm}/p2m.h | 0 .../{asm-arm => arch-arm/asm}/page-bits.h | 0 xen/include/{asm-arm => arch-arm/asm}/page.h | 0 .../{asm-arm => arch-arm/asm}/paging.h | 0 xen/include/{asm-arm => arch-arm/asm}/pci.h | 0 .../{asm-arm => arch-arm/asm}/percpu.h | 0 xen/include/{asm-arm => arch-arm/asm}/perfc.h | 0 .../{asm-arm => arch-arm/asm}/perfc_defn.h | 0 .../{asm-arm => arch-arm/asm}/pl011-uart.h | 0 .../{asm-arm => arch-arm/asm}/platform.h | 0 .../asm}/platforms/exynos5.h | 0 .../asm}/platforms/midway.h | 0 .../asm}/platforms/omap5.h | 0 .../asm}/platforms/vexpress.h | 0 .../asm}/platforms/xilinx-zynqmp-eemi.h | 0 .../{asm-arm => arch-arm/asm}/processor.h | 0 .../{asm-arm => arch-arm/asm}/procinfo.h | 0 xen/include/{asm-arm => arch-arm/asm}/psci.h | 0 .../{asm-arm => arch-arm/asm}/random.h | 0 xen/include/{asm-arm => arch-arm/asm}/regs.h | 0 .../{asm-arm => arch-arm/asm}/scif-uart.h | 0 xen/include/{asm-arm => arch-arm/asm}/setup.h | 0 .../{asm-arm => arch-arm/asm}/short-desc.h | 0 xen/include/{asm-arm => arch-arm/asm}/smccc.h | 0 xen/include/{asm-arm => arch-arm/asm}/smp.h | 0 .../{asm-arm => arch-arm/asm}/softirq.h | 0 .../{asm-arm => arch-arm/asm}/spinlock.h | 0 .../{asm-arm => arch-arm/asm}/string.h | 0 .../{asm-arm => arch-arm/asm}/sysregs.h | 0 .../{asm-arm => arch-arm/asm}/system.h | 0 .../{asm-arm => arch-arm/asm}/tee/optee_msg.h | 0 .../asm}/tee/optee_rpc_cmd.h | 0 .../{asm-arm => arch-arm/asm}/tee/optee_smc.h | 0 .../{asm-arm => arch-arm/asm}/tee/tee.h | 0 xen/include/{asm-arm => arch-arm/asm}/time.h | 0 xen/include/{asm-arm => arch-arm/asm}/trace.h | 0 xen/include/{asm-arm => arch-arm/asm}/traps.h | 0 xen/include/{asm-arm => arch-arm/asm}/types.h | 0 xen/include/{asm-arm => arch-arm/asm}/vfp.h | 0 .../{asm-arm => arch-arm/asm}/vgic-emul.h | 0 xen/include/{asm-arm => arch-arm/asm}/vgic.h | 0 .../{asm-arm => arch-arm/asm}/vm_event.h | 0 .../{asm-arm => arch-arm/asm}/vpl011.h | 0 xen/include/{asm-arm => arch-arm/asm}/vpsci.h | 0 xen/include/{asm-arm => arch-arm/asm}/vreg.h | 0 .../{asm-arm => arch-arm/asm}/vtimer.h | 0 .../{asm-arm => arch-arm/asm}/xenoprof.h | 0 .../{asm-riscv => arch-riscv/asm}/config.h | 0 xen/include/{asm-x86 => arch-x86/asm}/acpi.h | 0 .../asm}/alternative-asm.h | 0 .../{asm-x86 => arch-x86/asm}/alternative.h | 0 .../{asm-x86 => arch-x86/asm}/altp2m.h | 0 xen/include/{asm-x86 => arch-x86/asm}/amd.h | 0 xen/include/{asm-x86 => arch-x86/asm}/apic.h | 0 .../{asm-x86 => arch-x86/asm}/apicdef.h | 0 .../{asm-x86 => arch-x86/asm}/asm-defns.h | 0 .../{asm-x86 => arch-x86/asm}/asm_defns.h | 0 .../{asm-x86 => arch-x86/asm}/atomic.h | 0 .../{asm-x86 => arch-x86/asm}/bitops.h | 0 xen/include/{asm-x86 => arch-x86/asm}/bug.h | 0 .../{asm-x86 => arch-x86/asm}/byteorder.h | 0 .../{asm-x86 => arch-x86/asm}/bzimage.h | 0 xen/include/{asm-x86 => arch-x86/asm}/cache.h | 0 .../{asm-x86 => arch-x86/asm}/compat.h | 0 .../{asm-x86 => arch-x86/asm}/config.h | 0 .../{asm-x86 => arch-x86/asm}/cpufeature.h | 0 .../{asm-x86 => arch-x86/asm}/cpufeatures.h | 0 .../{asm-x86 => arch-x86/asm}/cpufeatureset.h | 0 xen/include/{asm-x86 => arch-x86/asm}/cpuid.h | 0 .../{asm-x86 => arch-x86/asm}/cpuidle.h | 0 .../{asm-x86 => arch-x86/asm}/current.h | 2 +- .../{asm-x86 => arch-x86/asm}/debugger.h | 0 .../{asm-x86 => arch-x86/asm}/debugreg.h | 0 xen/include/{asm-x86 => arch-x86/asm}/delay.h | 0 xen/include/{asm-x86 => arch-x86/asm}/desc.h | 0 .../{asm-x86 => arch-x86/asm}/device.h | 0 xen/include/{asm-x86 => arch-x86/asm}/div64.h | 0 .../{asm-x86 => arch-x86/asm}/dom0_build.h | 0 .../{asm-x86 => arch-x86/asm}/domain.h | 2 +- xen/include/{asm-x86 => arch-x86/asm}/e820.h | 0 xen/include/{asm-x86 => arch-x86/asm}/edd.h | 0 .../{asm-x86 => arch-x86/asm}/efibind.h | 0 xen/include/{asm-x86 => arch-x86/asm}/elf.h | 0 xen/include/{asm-x86 => arch-x86/asm}/event.h | 0 .../{asm-x86 => arch-x86/asm}/fixmap.h | 0 .../{asm-x86 => arch-x86/asm}/flushtlb.h | 0 .../{asm-x86 => arch-x86/asm}/genapic.h | 0 .../{asm-x86 => arch-x86/asm}/grant_table.h | 0 xen/include/{asm-x86 => arch-x86/asm}/guest.h | 0 .../asm}/guest/hyperv-hcall.h | 0 .../asm}/guest/hyperv-tlfs.h | 0 .../{asm-x86 => arch-x86/asm}/guest/hyperv.h | 0 .../asm}/guest/hypervisor.h | 0 .../asm}/guest/pvh-boot.h | 0 .../asm}/guest/xen-hcall.h | 0 .../{asm-x86 => arch-x86/asm}/guest/xen.h | 0 .../{asm-x86 => arch-x86/asm}/guest_access.h | 0 .../{asm-x86 => arch-x86/asm}/guest_atomics.h | 0 .../{asm-x86 => arch-x86/asm}/guest_pt.h | 0 xen/include/{asm-x86 => arch-x86/asm}/hap.h | 0 .../{asm-x86 => arch-x86/asm}/hardirq.h | 0 xen/include/{asm-x86 => arch-x86/asm}/hpet.h | 0 .../{asm-x86 => arch-x86/asm}/hvm/asid.h | 0 .../{asm-x86 => arch-x86/asm}/hvm/cacheattr.h | 0 .../{asm-x86 => arch-x86/asm}/hvm/domain.h | 0 .../{asm-x86 => arch-x86/asm}/hvm/emulate.h | 0 .../asm}/hvm/grant_table.h | 0 .../asm}/hvm/guest_access.h | 0 .../{asm-x86 => arch-x86/asm}/hvm/hvm.h | 0 .../{asm-x86 => arch-x86/asm}/hvm/io.h | 0 .../{asm-x86 => arch-x86/asm}/hvm/ioreq.h | 0 .../{asm-x86 => arch-x86/asm}/hvm/irq.h | 0 .../{asm-x86 => arch-x86/asm}/hvm/monitor.h | 0 .../{asm-x86 => arch-x86/asm}/hvm/nestedhvm.h | 0 .../{asm-x86 => arch-x86/asm}/hvm/save.h | 0 .../{asm-x86 => arch-x86/asm}/hvm/support.h | 0 .../{asm-x86 => arch-x86/asm}/hvm/svm/asid.h | 0 .../asm}/hvm/svm/emulate.h | 0 .../{asm-x86 => arch-x86/asm}/hvm/svm/intr.h | 0 .../asm}/hvm/svm/nestedsvm.h | 0 .../{asm-x86 => arch-x86/asm}/hvm/svm/svm.h | 0 .../asm}/hvm/svm/svmdebug.h | 0 .../{asm-x86 => arch-x86/asm}/hvm/svm/vmcb.h | 0 .../{asm-x86 => arch-x86/asm}/hvm/trace.h | 0 .../{asm-x86 => arch-x86/asm}/hvm/vcpu.h | 0 .../{asm-x86 => arch-x86/asm}/hvm/vioapic.h | 0 .../{asm-x86 => arch-x86/asm}/hvm/viridian.h | 0 .../{asm-x86 => arch-x86/asm}/hvm/vlapic.h | 0 .../{asm-x86 => arch-x86/asm}/hvm/vm_event.h | 0 .../{asm-x86 => arch-x86/asm}/hvm/vmx/vmcs.h | 0 .../{asm-x86 => arch-x86/asm}/hvm/vmx/vmx.h | 0 .../{asm-x86 => arch-x86/asm}/hvm/vmx/vvmx.h | 0 .../{asm-x86 => arch-x86/asm}/hvm/vpic.h | 0 .../{asm-x86 => arch-x86/asm}/hvm/vpt.h | 0 .../{asm-x86 => arch-x86/asm}/hypercall.h | 0 xen/include/{asm-x86 => arch-x86/asm}/i387.h | 0 xen/include/{asm-x86 => arch-x86/asm}/init.h | 0 .../{asm-x86 => arch-x86/asm}/invpcid.h | 0 xen/include/{asm-x86 => arch-x86/asm}/io.h | 0 .../{asm-x86 => arch-x86/asm}/io_apic.h | 0 xen/include/{asm-x86 => arch-x86/asm}/iocap.h | 0 xen/include/{asm-x86 => arch-x86/asm}/iommu.h | 0 xen/include/{asm-x86 => arch-x86/asm}/ioreq.h | 0 xen/include/{asm-x86 => arch-x86/asm}/irq.h | 0 xen/include/{asm-x86 => arch-x86/asm}/ldt.h | 0 .../{asm-x86 => arch-x86/asm}/livepatch.h | 0 .../asm}/mach-default/bios_ebda.h | 0 .../asm}/mach-default/io_ports.h | 0 .../asm}/mach-default/irq_vectors.h | 0 .../asm}/mach-default/mach_mpparse.h | 0 .../asm}/mach-default/mach_mpspec.h | 0 .../asm}/mach-generic/mach_apic.h | 0 .../asm}/mach-generic/mach_mpparse.h | 0 .../{asm-x86 => arch-x86/asm}/machine_kexec.h | 0 .../{asm-x86 => arch-x86/asm}/mc146818rtc.h | 0 xen/include/{asm-x86 => arch-x86/asm}/mce.h | 0 .../{asm-x86 => arch-x86/asm}/mem_access.h | 0 .../{asm-x86 => arch-x86/asm}/mem_paging.h | 0 .../{asm-x86 => arch-x86/asm}/mem_sharing.h | 0 .../{asm-x86 => arch-x86/asm}/microcode.h | 0 xen/include/{asm-x86 => arch-x86/asm}/mm.h | 0 .../{asm-x86 => arch-x86/asm}/monitor.h | 0 .../{asm-x86 => arch-x86/asm}/mpspec.h | 0 .../{asm-x86 => arch-x86/asm}/mpspec_def.h | 0 xen/include/{asm-x86 => arch-x86/asm}/msi.h | 0 .../{asm-x86 => arch-x86/asm}/msr-index.h | 0 xen/include/{asm-x86 => arch-x86/asm}/msr.h | 0 xen/include/{asm-x86 => arch-x86/asm}/mtrr.h | 0 .../{asm-x86 => arch-x86/asm}/multicall.h | 0 xen/include/{asm-x86 => arch-x86/asm}/mwait.h | 0 xen/include/{asm-x86 => arch-x86/asm}/nmi.h | 0 xen/include/{asm-x86 => arch-x86/asm}/nops.h | 0 .../{asm-x86 => arch-x86/asm}/nospec.h | 0 xen/include/{asm-x86 => arch-x86/asm}/numa.h | 0 xen/include/{asm-x86 => arch-x86/asm}/p2m.h | 0 .../{asm-x86 => arch-x86/asm}/page-bits.h | 0 xen/include/{asm-x86 => arch-x86/asm}/page.h | 0 .../{asm-x86 => arch-x86/asm}/paging.h | 0 xen/include/{asm-x86 => arch-x86/asm}/pci.h | 0 .../{asm-x86 => arch-x86/asm}/percpu.h | 0 xen/include/{asm-x86 => arch-x86/asm}/perfc.h | 0 .../{asm-x86 => arch-x86/asm}/perfc_defn.h | 0 .../{asm-x86 => arch-x86/asm}/processor.h | 0 xen/include/{asm-x86 => arch-x86/asm}/psr.h | 0 .../{asm-x86 => arch-x86/asm}/pv/domain.h | 0 .../asm}/pv/grant_table.h | 0 xen/include/{asm-x86 => arch-x86/asm}/pv/mm.h | 0 .../{asm-x86 => arch-x86/asm}/pv/shim.h | 0 .../{asm-x86 => arch-x86/asm}/pv/traps.h | 0 .../{asm-x86 => arch-x86/asm}/random.h | 0 xen/include/{asm-x86 => arch-x86/asm}/regs.h | 0 xen/include/{asm-x86 => arch-x86/asm}/setup.h | 0 .../{asm-x86 => arch-x86/asm}/shadow.h | 0 .../{asm-x86 => arch-x86/asm}/shared.h | 0 xen/include/{asm-x86 => arch-x86/asm}/smp.h | 0 .../{asm-x86 => arch-x86/asm}/softirq.h | 0 .../{asm-x86 => arch-x86/asm}/spec_ctrl.h | 0 .../{asm-x86 => arch-x86/asm}/spec_ctrl_asm.h | 0 .../{asm-x86 => arch-x86/asm}/spinlock.h | 0 .../{asm-x86 => arch-x86/asm}/string.h | 0 .../{asm-x86 => arch-x86/asm}/system.h | 0 xen/include/{asm-x86 => arch-x86/asm}/tboot.h | 0 xen/include/{asm-x86 => arch-x86/asm}/time.h | 0 xen/include/{asm-x86 => arch-x86/asm}/trace.h | 0 xen/include/{asm-x86 => arch-x86/asm}/traps.h | 0 xen/include/{asm-x86 => arch-x86/asm}/types.h | 0 .../{asm-x86 => arch-x86/asm}/uaccess.h | 0 .../{asm-x86 => arch-x86/asm}/unaligned.h | 0 .../{asm-x86 => arch-x86/asm}/vm_event.h | 0 xen/include/{asm-x86 => arch-x86/asm}/vpmu.h | 0 .../{asm-x86 => arch-x86/asm}/x86-defns.h | 0 .../{asm-x86 => arch-x86/asm}/x86-vendors.h | 0 .../asm}/x86_64/efibind.h | 0 .../{asm-x86 => arch-x86/asm}/x86_64/elf.h | 0 .../{asm-x86 => arch-x86/asm}/x86_64/page.h | 0 .../{asm-x86 => arch-x86/asm}/x86_64/regs.h | 0 .../{asm-x86 => arch-x86/asm}/x86_64/system.h | 0 .../asm}/x86_64/uaccess.h | 0 .../{asm-x86 => arch-x86/asm}/x86_emulate.h | 0 .../{asm-x86 => arch-x86/asm}/xenoprof.h | 0 .../{asm-x86 => arch-x86/asm}/xstate.h | 0 xen/include/xen/acpi.h | 4 +- xen/include/xen/bitmap.h | 2 +- xen/scripts/Kbuild.include | 80 +++- xen/scripts/Makefile.clean | 20 +- xen/test/Makefile | 16 +- xen/test/livepatch/Makefile | 215 ++++------ xen/tools/Makefile | 8 +- xen/tools/compat-build-header.py | 44 +- xen/tools/compat-build-source.py | 8 +- xen/tools/fixdep.c | 404 ++++++++++++++++++ xen/tools/symbols.c | 18 +- xen/xsm/flask/Makefile | 40 +- xen/xsm/flask/policy/mkaccess_vector.sh | 7 +- xen/xsm/flask/ss/Makefile | 2 +- 369 files changed, 1122 insertions(+), 616 deletions(-) create mode 100644 xen/arch/riscv/riscv64/Makefile create mode 100644 xen/arch/x86/mm/guest_walk_2.c create mode 100644 xen/arch/x86/mm/guest_walk_3.c create mode 100644 xen/arch/x86/mm/guest_walk_4.c create mode 100644 xen/arch/x86/mm/hap/guest_walk_2level.c create mode 100644 xen/arch/x86/mm/hap/guest_walk_3level.c create mode 100644 xen/arch/x86/mm/hap/guest_walk_4level.c create mode 100644 xen/arch/x86/mm/shadow/guest_2.c create mode 100644 xen/arch/x86/mm/shadow/guest_3.c create mode 100644 xen/arch/x86/mm/shadow/guest_4.c rename xen/include/{asm-arm => arch-arm/asm}/acpi.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/alternative.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/altp2m.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/arm32/atomic.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/arm32/bitops.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/arm32/bug.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/arm32/cmpxchg.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/arm32/flushtlb.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/arm32/insn.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/arm32/io.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/arm32/macros.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/arm32/mm.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/arm32/page.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/arm32/processor.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/arm32/sysregs.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/arm32/system.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/arm32/traps.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/arm32/vfp.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/arm64/atomic.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/arm64/bitops.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/arm64/brk.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/arm64/bug.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/arm64/cmpxchg.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/arm64/efibind.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/arm64/flushtlb.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/arm64/hsr.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/arm64/insn.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/arm64/io.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/arm64/macros.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/arm64/mm.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/arm64/page.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/arm64/processor.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/arm64/sysregs.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/arm64/system.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/arm64/traps.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/arm64/vfp.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/asm_defns.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/atomic.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/bitops.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/bug.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/byteorder.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/cache.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/cadence-uart.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/config.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/cpregs.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/cpuerrata.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/cpufeature.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/current.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/debugger.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/delay.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/desc.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/device.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/div64.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/domain.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/domain_build.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/early_printk.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/efibind.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/elf.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/event.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/exynos4210-uart.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/flushtlb.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/gic.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/gic_v3_defs.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/gic_v3_its.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/grant_table.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/guest_access.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/guest_atomics.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/guest_walk.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/hardirq.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/hsr.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/hypercall.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/init.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/insn.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/io.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/iocap.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/iommu.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/iommu_fwspec.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/ioreq.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/irq.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/kernel.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/livepatch.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/lpae.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/macros.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/mem_access.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/mm.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/mmio.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/monitor.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/new_vgic.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/nospec.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/numa.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/p2m.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/page-bits.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/page.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/paging.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/pci.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/percpu.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/perfc.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/perfc_defn.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/pl011-uart.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/platform.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/platforms/exynos5.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/platforms/midway.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/platforms/omap5.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/platforms/vexpress.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/platforms/xilinx-zynqmp-eemi.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/processor.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/procinfo.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/psci.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/random.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/regs.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/scif-uart.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/setup.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/short-desc.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/smccc.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/smp.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/softirq.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/spinlock.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/string.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/sysregs.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/system.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/tee/optee_msg.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/tee/optee_rpc_cmd.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/tee/optee_smc.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/tee/tee.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/time.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/trace.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/traps.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/types.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/vfp.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/vgic-emul.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/vgic.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/vm_event.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/vpl011.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/vpsci.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/vreg.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/vtimer.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/xenoprof.h (100%) rename xen/include/{asm-riscv => arch-riscv/asm}/config.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/acpi.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/alternative-asm.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/alternative.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/altp2m.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/amd.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/apic.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/apicdef.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/asm-defns.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/asm_defns.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/atomic.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/bitops.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/bug.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/byteorder.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/bzimage.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/cache.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/compat.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/config.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/cpufeature.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/cpufeatures.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/cpufeatureset.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/cpuid.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/cpuidle.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/current.h (99%) rename xen/include/{asm-x86 => arch-x86/asm}/debugger.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/debugreg.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/delay.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/desc.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/device.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/div64.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/dom0_build.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/domain.h (99%) rename xen/include/{asm-x86 => arch-x86/asm}/e820.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/edd.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/efibind.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/elf.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/event.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/fixmap.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/flushtlb.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/genapic.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/grant_table.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/guest.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/guest/hyperv-hcall.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/guest/hyperv-tlfs.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/guest/hyperv.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/guest/hypervisor.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/guest/pvh-boot.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/guest/xen-hcall.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/guest/xen.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/guest_access.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/guest_atomics.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/guest_pt.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/hap.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/hardirq.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/hpet.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/hvm/asid.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/hvm/cacheattr.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/hvm/domain.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/hvm/emulate.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/hvm/grant_table.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/hvm/guest_access.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/hvm/hvm.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/hvm/io.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/hvm/ioreq.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/hvm/irq.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/hvm/monitor.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/hvm/nestedhvm.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/hvm/save.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/hvm/support.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/hvm/svm/asid.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/hvm/svm/emulate.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/hvm/svm/intr.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/hvm/svm/nestedsvm.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/hvm/svm/svm.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/hvm/svm/svmdebug.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/hvm/svm/vmcb.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/hvm/trace.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/hvm/vcpu.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/hvm/vioapic.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/hvm/viridian.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/hvm/vlapic.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/hvm/vm_event.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/hvm/vmx/vmcs.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/hvm/vmx/vmx.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/hvm/vmx/vvmx.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/hvm/vpic.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/hvm/vpt.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/hypercall.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/i387.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/init.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/invpcid.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/io.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/io_apic.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/iocap.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/iommu.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/ioreq.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/irq.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/ldt.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/livepatch.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/mach-default/bios_ebda.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/mach-default/io_ports.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/mach-default/irq_vectors.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/mach-default/mach_mpparse.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/mach-default/mach_mpspec.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/mach-generic/mach_apic.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/mach-generic/mach_mpparse.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/machine_kexec.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/mc146818rtc.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/mce.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/mem_access.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/mem_paging.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/mem_sharing.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/microcode.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/mm.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/monitor.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/mpspec.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/mpspec_def.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/msi.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/msr-index.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/msr.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/mtrr.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/multicall.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/mwait.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/nmi.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/nops.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/nospec.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/numa.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/p2m.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/page-bits.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/page.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/paging.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/pci.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/percpu.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/perfc.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/perfc_defn.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/processor.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/psr.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/pv/domain.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/pv/grant_table.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/pv/mm.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/pv/shim.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/pv/traps.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/random.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/regs.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/setup.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/shadow.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/shared.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/smp.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/softirq.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/spec_ctrl.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/spec_ctrl_asm.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/spinlock.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/string.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/system.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/tboot.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/time.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/trace.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/traps.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/types.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/uaccess.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/unaligned.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/vm_event.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/vpmu.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/x86-defns.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/x86-vendors.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/x86_64/efibind.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/x86_64/elf.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/x86_64/page.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/x86_64/regs.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/x86_64/system.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/x86_64/uaccess.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/x86_emulate.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/xenoprof.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/xstate.h (100%) create mode 100644 xen/tools/fixdep.c -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Thu Jul 01 14:10:43 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 14:10:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148712.274884 (Exim 4.92) (envelope-from ) id 1lyxOt-0007wz-JN; Thu, 01 Jul 2021 14:10:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148712.274884; Thu, 01 Jul 2021 14:10:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyxOt-0007wh-Ea; Thu, 01 Jul 2021 14:10:43 +0000 Received: by outflank-mailman (input) for mailman id 148712; Thu, 01 Jul 2021 14:10:42 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyxOs-0005F9-JC for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 14:10:42 +0000 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 1306551d-da76-11eb-8327-12813bfff9fa; Thu, 01 Jul 2021 14:10:23 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1306551d-da76-11eb-8327-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1625148623; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=W3w4kLLs4D474Vdd8fHK3XAA2OqyxxyERzR7s4cMOP0=; b=aeHrKohN/N6ShuMLamw3YwrNUV+XmzYHaPzfkdTwszQe4z+SVD0Ebspl hCZkKgq6ERoqlvnAdCERLPjbcTe5QVy4W7OsDNL/EJafRcRXpKqf2URTi xJ+22QUI53O40dm+qu7ZglvRXTwVGFSd2NxYBNfLiU+ghYqWh7+AW5Fzp I=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: GJ4PkxF6CblU0SjvcOwQOGT/BmredQqQ0MdquCllOKVewtxBRYzL6QA28aZcNVrL+XEhv6o3ml XdeCsmaWHLpttZeaEIuUaE0YO+gADtL1B/TT93ZIh2UUJErWB08+WCmKpMba7IqB8OvzGtMuCV eE/88p2AKPyUGSPfYlMeyMYlMOqZ+fOG2n9FWHh8vL2W+ps8SAod92gG6fCwot0niJnFFkOW12 83oaxkGGLABKF2auaGR9f5ziN7N+wW2Rf9OROX4sU8lFjs4D5PttLTay6aUhh6gyQpvI4lXfjH maQ= X-SBRS: 5.1 X-MesageID: 47384355 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:Ms3X/qNZ9Q7d5sBcTsejsMiBIKoaSvp037Eqv3ofdfUzSL3+qy nOpoVj6faaslcssR0b9OxofZPwI080lqQFhbX5X43DYOCOggLBR+tfBMnZsljd8kXFh4hgPM xbHZSWZuedMbEDt7eY3DWF X-IronPort-AV: E=Sophos;i="5.83,314,1616472000"; d="scan'208";a="47384355" From: Anthony PERARD To: CC: Anthony PERARD , Jan Beulich , Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu Subject: [XEN PATCH v6 04/31] build: use if_changed_rules with %.o:%.c targets Date: Thu, 1 Jul 2021 15:09:44 +0100 Message-ID: <20210701141011.785641-5-anthony.perard@citrix.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210701141011.785641-1-anthony.perard@citrix.com> References: <20210701141011.785641-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Use $(dot-target) to have the target name prefix with a dot. Now, when the CC command has run, it is recorded in .*.cmd file, then if_changed_rules will compare it on subsequent runs. Signed-off-by: Anthony PERARD Reviewed-by: Jan Beulich --- xen/Rules.mk | 26 +++++++++++++++++--------- 1 file changed, 17 insertions(+), 9 deletions(-) diff --git a/xen/Rules.mk b/xen/Rules.mk index 6a0cdfde2eed..4adc90eec80d 100644 --- a/xen/Rules.mk +++ b/xen/Rules.mk @@ -192,19 +192,27 @@ FORCE: SRCPATH := $(patsubst $(BASEDIR)/%,%,$(CURDIR)) -%.o: %.c Makefile +quiet_cmd_cc_o_c = CC $@ ifeq ($(CONFIG_ENFORCE_UNIQUE_SYMBOLS),y) - $(CC) $(c_flags) -c $< -o $(@D)/.$(@F).tmp -MQ $@ -ifeq ($(CONFIG_CC_IS_CLANG),y) - $(OBJCOPY) --redefine-sym $<=$(SRCPATH)/$< $(@D)/.$(@F).tmp $@ -else - $(OBJCOPY) --redefine-sym $( Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 14:10:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148714.274895 (Exim 4.92) (envelope-from ) id 1lyxOz-0000I6-1K; Thu, 01 Jul 2021 14:10:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148714.274895; Thu, 01 Jul 2021 14:10:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyxOy-0000HI-Rn; Thu, 01 Jul 2021 14:10:48 +0000 Received: by outflank-mailman (input) for mailman id 148714; Thu, 01 Jul 2021 14:10:47 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyxOx-0005F9-JU for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 14:10:47 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 13833227-da76-11eb-8327-12813bfff9fa; Thu, 01 Jul 2021 14:10:25 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 13833227-da76-11eb-8327-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1625148624; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=uuyAZES2mXpdo7RpfZEYfJQS/0KceaGe4Dk4hEnlg9Y=; b=OorIn9AQhSLuRrI7wKdJAjWWVd2dGx264u+hA7yjIbS8MgJL89TB9SW8 vDjmdvlFK2LMcB4rRHns/WgBNJtjNobiUN8r1Akta/SI/9oRADIL6NhGJ MG+GArcMDN3GjYVAJDcGWweOYTkBiz9ByKfIyz56CMp1dPxAdA6YFKVB3 Q=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: UlKbJEVjkqdCitesAqRIdhA8VQWWfhTd7M/0fsiuU0CO2T4g9F0Ctuf7n35sXw7vU/LXF4tKlM B0Ue5Zn3H4PMY98To+f9RmB369r56t7ttJBaYJwh20kxxE51o6BO6jNHd/RG/9czYtKYEjskkq mwLIaNv/SKjHgzFywA4Xmjkg9/UH35ps0I08xVhxpcTlRFnWdtqF0OfD5X73p+ChcH676VTUcP xdinlcsmcByDfuTKArF5Ju2WzVt474neclk7Wedw1gPAWNIomnOOwErYPFr93UJE+LOqT51n+P wVs= X-SBRS: 5.1 X-MesageID: 47755333 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:+QPBhaMw/wec98BcTjujsMiBIKoaSvp037BK7S1MoNJuEvBw9v re+MjzsCWftN9/Yh4dcLy7VpVoIkmskKKdg7NhXotKNTOO0AeVxelZhrcKqAeQeREWmNQ96U 9hGZIOdeEZDzJB/LrHCN/TKade/DGFmprY+9s31x1WPGZXgzkL1XYDNu6ceHcGIjVuNN4CO7 e3wNFInDakcWR/VLXAOpFUN9Kz3uEijfjdEGY7OyI= X-IronPort-AV: E=Sophos;i="5.83,314,1616472000"; d="scan'208";a="47755333" From: Anthony PERARD To: CC: Anthony PERARD , Andrew Cooper , George Dunlap , "Ian Jackson" , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Volodymyr Babchuk , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [XEN PATCH v6 05/31] build: factorise generation of the linker scripts Date: Thu, 1 Jul 2021 15:09:45 +0100 Message-ID: <20210701141011.785641-6-anthony.perard@citrix.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210701141011.785641-1-anthony.perard@citrix.com> References: <20210701141011.785641-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain In Arm and X86 makefile, generating the linker script is the same, so we can simply have both call the same macro. We need to add *.lds files into extra-y so that Rules.mk can find the .*.cmd dependency file and load it. Change made to the command line: - Use cpp_flags macro which simply filter -Wa,% options from $(a_flags). - Added -D__LINKER__ even it is only used by Arm's lds. Signed-off-by: Anthony PERARD --- Notes: v6: - CPP already used instead of CC -E - -Ui386 already removed - cpp_flags is now a macro - rebased v5: - rename cc_lds_S to cpp_lds_S as the binary runned is now CPP - Use new cpp_flags instead of the open-coded filter of a_flags. v4: - fix rebuild by adding FORCE as dependency - Use $(CPP) - remove -Ui386 - avoid using "define" for cmd_cc_lds_S, as adding '; \' on each line is still mandatory for if_changed (or cmd) macro to work. xen/Rules.mk | 4 ++++ xen/arch/arm/Makefile | 6 ++++-- xen/arch/x86/Makefile | 6 ++++-- 3 files changed, 12 insertions(+), 4 deletions(-) diff --git a/xen/Rules.mk b/xen/Rules.mk index 4adc90eec80d..f05b2d3f0399 100644 --- a/xen/Rules.mk +++ b/xen/Rules.mk @@ -255,6 +255,10 @@ cmd_cpp_s_S = $(CPP) $(call cpp_flags,$(a_flags)) -MQ $@ -o $@ $< %.s: %.S FORCE $(call if_changed,cpp_s_S) +# Linker scripts, .lds.S -> .lds +quiet_cmd_cpp_lds_S = LDS $@ +cmd_cpp_lds_S = $(CPP) -P $(call cpp_flags,$(a_flags)) -D__LINKER__ -MQ $@ -o $@ $< + # Add intermediate targets: # When building objects with specific suffix patterns, add intermediate # targets that the final targets are derived from. diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile index 3d3b97b5b440..0edd9dee6f49 100644 --- a/xen/arch/arm/Makefile +++ b/xen/arch/arm/Makefile @@ -66,6 +66,8 @@ obj-y += vpsci.o obj-y += vuart.o extra-y += $(TARGET_SUBARCH)/head.o +extra-y += xen.lds + #obj-bin-y += ....o ifneq ($(CONFIG_DTB_FILE),"") @@ -133,8 +135,8 @@ $(TARGET)-syms: prelink.o xen.lds .PHONY: include include: -xen.lds: xen.lds.S - $(CPP) -P $(a_flags) -D__LINKER__ -MQ $@ -o $@ $< +xen.lds: xen.lds.S FORCE + $(call if_changed,cpp_lds_S) dtb.o: $(patsubst "%",%,$(CONFIG_DTB_FILE)) diff --git a/xen/arch/x86/Makefile b/xen/arch/x86/Makefile index 2ec883456e48..08a4ec1944d3 100644 --- a/xen/arch/x86/Makefile +++ b/xen/arch/x86/Makefile @@ -79,6 +79,7 @@ obj-y += sysctl.o endif extra-y += asm-macros.i +extra-y += xen.lds ifneq ($(CONFIG_HVM),y) x86_emulate.o: CFLAGS-y += -Wno-unused-label @@ -240,6 +241,7 @@ endif note_file_option ?= $(note_file) ifeq ($(XEN_BUILD_PE),y) +extra-y += efi.lds $(TARGET).efi: prelink.o $(note_file) efi.lds efi/relocs-dummy.o efi/mkreloc ifeq ($(CONFIG_DEBUG_INFO),y) $(if $(filter --strip-debug,$(EFI_LDFLAGS)),echo,:) "Will strip debug info from $(@F)" @@ -292,8 +294,8 @@ $(BASEDIR)/include/asm-x86/asm-macros.h: asm-macros.i Makefile $(call move-if-changed,$@.new,$@) efi.lds: AFLAGS-y += -DEFI -xen.lds efi.lds: xen.lds.S - $(CPP) -P $(filter-out -Wa$(comma)%,$(a_flags)) -MQ $@ -o $@ $< +xen.lds efi.lds: xen.lds.S FORCE + $(call if_changed,cpp_lds_S) boot/mkelf32: boot/mkelf32.c $(HOSTCC) $(HOSTCFLAGS) -o $@ $< -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Thu Jul 01 14:10:52 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 14:10:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148715.274906 (Exim 4.92) (envelope-from ) id 1lyxP2-0000mx-Dy; Thu, 01 Jul 2021 14:10:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148715.274906; Thu, 01 Jul 2021 14:10:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyxP2-0000lI-8H; Thu, 01 Jul 2021 14:10:52 +0000 Received: by outflank-mailman (input) for mailman id 148715; Thu, 01 Jul 2021 14:10:51 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyxP1-0005tj-0R for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 14:10:51 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 9750316e-8fc7-49fa-b4c6-65a7a8682684; Thu, 01 Jul 2021 14:10:38 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9750316e-8fc7-49fa-b4c6-65a7a8682684 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1625148637; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=y8SWyJ3p44fQ34F09ahZsCZGxd9yD3VsNGECNl35lHA=; b=BTkP9KZIzGwZ7ZB+cXXI9i1FEA1V0tKRob8pKou46ZcfUpIDC6d4nTL6 ODnG2sGoqvrkwkB4NeS6oVgvJwM6fPCLPYSxFKmc2soMQfep794qGABEG 0JCey909r8rjdmUe4zq3P0rqEqaaPa7TR0ehnc05LL8082A/HItU/bOf5 c=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: WhFgH9js5xlwKlXGtlC/Joz2aE4ybEandDbTUzHIuxQO6BOpDJqr3Dn/Eirb1DIDOWqRv9Eefh 0wH0QuXKhojgvB/yfeaNs0r61VHO24F68ufD9SDGF8ffW+xWBvp0Q5tVnHTOd4N6/1wNjQLEAx aI1BVhHu1lQPbW3POgx8ENbE8TqlmLBlGORSiqRv5yzOCYjWQfFkHDXCA/2bEyPvvNfkpzWHAR sVOTYK9kkBQrPMBQmf0in8M7rahj/jAp79FuNDbtxhtHPokOTN0Xj2J6r0AKj/RLyiAwyeZWIf eew= X-SBRS: 5.1 X-MesageID: 49007486 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:+M8RiK27SzyZ8UGeKRg56wqjBLQkLtp133Aq2lEZdPRUGvb2qy nIpoV96faUskdpZJhOo7G90cW7LE80sKQFg7X5Xo3SODUO2lHJEGgK1+KLqFfd8m/Fh4tgPM 9bAs5D4bbLY2SS4/yX3ODBKadC/OW6 X-IronPort-AV: E=Sophos;i="5.83,314,1616472000"; d="scan'208";a="49007486" From: Anthony PERARD To: CC: Anthony PERARD , Andrew Cooper , George Dunlap , "Ian Jackson" , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [XEN PATCH v6 13/31] build,tools: have default rules depends on symbols Date: Thu, 1 Jul 2021 15:09:53 +0100 Message-ID: <20210701141011.785641-14-anthony.perard@citrix.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210701141011.785641-1-anthony.perard@citrix.com> References: <20210701141011.785641-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain No need to call $(MAKE) again. Signed-off-by: Anthony PERARD --- xen/tools/Makefile | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/xen/tools/Makefile b/xen/tools/Makefile index e940939d61f4..4e42163f981c 100644 --- a/xen/tools/Makefile +++ b/xen/tools/Makefile @@ -2,8 +2,7 @@ include $(XEN_ROOT)/Config.mk .PHONY: default -default: - $(MAKE) symbols +default: symbols .PHONY: clean clean: -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Thu Jul 01 14:10:54 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 14:10:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148716.274916 (Exim 4.92) (envelope-from ) id 1lyxP3-0001A3-R1; Thu, 01 Jul 2021 14:10:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148716.274916; Thu, 01 Jul 2021 14:10:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyxP3-000183-Kq; Thu, 01 Jul 2021 14:10:53 +0000 Received: by outflank-mailman (input) for mailman id 148716; Thu, 01 Jul 2021 14:10:52 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyxP2-0005F9-Jg for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 14:10:52 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 184bf81a-da76-11eb-8327-12813bfff9fa; Thu, 01 Jul 2021 14:10:32 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 184bf81a-da76-11eb-8327-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1625148632; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=2WFDUvnAZmIMKGyUlu8KLXOxi1z1do7+jNPMy5fEh9Q=; b=HHS8m3PJMqEfShbC3br1fxuy3izyozdQk/J38+Hy6N3sd1/jHIfwoVMc yfr9Ow9m8VeSAU/yiBGlp3ZOY0tdQopWz78F/9LNmr28WI0xkz6JQk4ib AY+SS/AZJAdT90Rpr10Kh0s0Cc2S6UMTSbO41g1UXfl+HaJ9Zs53TzLD5 Y=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: Dls+lF5hiBXijky5vM+9nnAjrwEmsB23wra86iApibKZRVfZotBLVIGeJJHEQCC3VHZNUfkrja fSc+3ONCMCyMlkuaqQIuOVu5QsGl1xefaLtUoQAt0Wxg/dj88YZl0Ca8yAbAN+8jBVaClGtoth p0R3omGJRkxD+4qRurT1zmOcBkhfuNaAPi4ITsStNBMAo2T3VX6aHp+QRPZLWTec4Sz0GwBrW9 WSi50YZ5JYuJsOmL4sfCCXgdIYT6lM9l282r2voKg4fBp63/bCFWPsWHTojhS7nZuMv1mJNdq+ Wxs= X-SBRS: 5.1 X-MesageID: 47755348 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:U8zI+6N+cOO1kcBcT1H155DYdb4zR+YMi2TDiHoddfUFSKalfp 6V98jzjSWE8wr4WBkb6LO90dq7MAnhHP9OkMQs1NKZMDUO11HYS72KgbGC/9SkIVyHygc/79 YtT0EdMqyXMbESt6+Tj2eF+pQbsaC6GcuT9IXjJgJWPGVXgtZbnmJE42igcnFedU1jP94UBZ Cc7s1Iq36LYnIMdPm2AXEDQqzqu8DLvIiOW29JOzcXrC21yR+44r/zFBaVmj0EVSlU/Lsk+W /Z1yTk+6SYte2hwBO07R6T030Woqqg9jJwPr3PtiEnEESotu9uXvUkZ1S2hkF3nAho0idsrD CDmWZnAy050QKtQoj8m2qQ5+Cn6kdg15aq8y7mvVLz5cP+Xz40EMxHmMZQdQbY8VMpuJVm3L tMxH/xjesfMfrsplWL2zHzbWAdqqN0mwtRrccDy3hEFYcOYr5YqoISuEtTDZcbBSr/rIQqCv NnAs3Q7OtfNQryVQGTgkB/hNi3GngjFBaPRUYP/sSTzjhNhXh8i08V3tYWkHsM/I80D5NE++ PHOKJ1k6wmdL5fUUu8PpZ0fSKTMB2GffvhChPjHb3XLtBzB5uWke+H3Fwc3pDYRHUn9upNpK j8 X-IronPort-AV: E=Sophos;i="5.83,314,1616472000"; d="scan'208";a="47755348" From: Anthony PERARD To: CC: Anthony PERARD , Andrew Cooper , George Dunlap , "Ian Jackson" , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [XEN PATCH v6 09/31] build: clean "lib.a" Date: Thu, 1 Jul 2021 15:09:49 +0100 Message-ID: <20210701141011.785641-10-anthony.perard@citrix.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210701141011.785641-1-anthony.perard@citrix.com> References: <20210701141011.785641-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Signed-off-by: Anthony PERARD --- xen/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/Makefile b/xen/Makefile index 360b4a1d1867..e4deceab2c9a 100644 --- a/xen/Makefile +++ b/xen/Makefile @@ -343,7 +343,7 @@ _clean: delete-unfresh-files $(MAKE) $(clean) test $(MAKE) -f $(BASEDIR)/tools/kconfig/Makefile.kconfig ARCH=$(ARCH) SRCARCH=$(SRCARCH) clean find . \( -name "*.o" -o -name ".*.d" -o -name ".*.d2" \ - -o -name "*.gcno" -o -name ".*.cmd" \) -exec rm -f {} \; + -o -name "*.gcno" -o -name ".*.cmd" -o -name "lib.a" \) -exec rm -f {} \; rm -f include/asm $(TARGET) $(TARGET).gz $(TARGET).efi $(TARGET).efi.map $(TARGET)-syms $(TARGET)-syms.map *~ core rm -f asm-offsets.s include/asm-*/asm-offsets.h rm -f .banner -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Thu Jul 01 14:10:59 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 14:10:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148718.274928 (Exim 4.92) (envelope-from ) id 1lyxP9-0001xe-CI; Thu, 01 Jul 2021 14:10:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148718.274928; Thu, 01 Jul 2021 14:10:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyxP9-0001xE-7k; Thu, 01 Jul 2021 14:10:59 +0000 Received: by outflank-mailman (input) for mailman id 148718; Thu, 01 Jul 2021 14:10:57 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyxP7-0005F9-Jw for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 14:10:57 +0000 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 1916428c-da76-11eb-8327-12813bfff9fa; Thu, 01 Jul 2021 14:10:33 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1916428c-da76-11eb-8327-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1625148633; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=+mNOgsYjrFmWoNxBPJggXZS7DoTw6+WYH4Z2rQexo4M=; b=BvH0y00sbPb2wB7+eBju3BUjPhtXsz16o6bbZ1Crzt+2rd4ya9512AiR rAkvqhCK3T0A/hNYo2N0rUwhAWVSQ4kSxi6wXg0wftkN61YYQ6cmPxgCn DTIHjbIAsmdpPK3XoyUZ8N1CT2OG6+rCjDQ6nmYYvr5zMxK0s9EGJIhsx 8=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: r1gCmWINHhjbKSKErWNZwtKtXPUGKanRJOUw7HRnVp3h3EFpmQgP8qOxcR/IRhXRfYbYBcJbM7 sqsfpJRbq1Yer9qI3BSlMVATSaXhUbEj+4o63sdDuME7897nsFrWG4Y6wPVVtfGtS1WlcqBMRR wjVhMVZHjYW3SDXlm23C/zm9ryuW17cgmLnas8MyxF0xF1L8DkvoHFZ97Q92cM6FurGnPiBsum rpgKHuonpnXKhUB38Gy2NyrGh05JcVY+cgyZwcN7obuVT1nw4vxNnliaeTolltbMlUsriwMRou J5w= X-SBRS: 5.1 X-MesageID: 47384384 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:pqbNFK2Fb+IAVhT9QkyFfwqjBLQkLtp133Aq2lEZdPRUGvb2qy nIpoV96faUskdpZJhOo7G90cW7LE80sKQFg7X5Xo3SODUO2lHJEGgK1+KLqFfd8m/Fh4tgPM 9bAs5D4bbLY2SS4/yX3ODBKadC/OW6 X-IronPort-AV: E=Sophos;i="5.83,314,1616472000"; d="scan'208";a="47384384" From: Anthony PERARD To: CC: Anthony PERARD , Andrew Cooper , George Dunlap , "Ian Jackson" , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [XEN PATCH v6 10/31] build: use $(kconfig) shortcut in clean rule Date: Thu, 1 Jul 2021 15:09:50 +0100 Message-ID: <20210701141011.785641-11-anthony.perard@citrix.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210701141011.785641-1-anthony.perard@citrix.com> References: <20210701141011.785641-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Signed-off-by: Anthony PERARD --- xen/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/Makefile b/xen/Makefile index e4deceab2c9a..dae0247067ff 100644 --- a/xen/Makefile +++ b/xen/Makefile @@ -341,7 +341,7 @@ _clean: delete-unfresh-files $(MAKE) $(clean) arch/riscv $(MAKE) $(clean) arch/x86 $(MAKE) $(clean) test - $(MAKE) -f $(BASEDIR)/tools/kconfig/Makefile.kconfig ARCH=$(ARCH) SRCARCH=$(SRCARCH) clean + $(MAKE) $(kconfig) clean find . \( -name "*.o" -o -name ".*.d" -o -name ".*.d2" \ -o -name "*.gcno" -o -name ".*.cmd" -o -name "lib.a" \) -exec rm -f {} \; rm -f include/asm $(TARGET) $(TARGET).gz $(TARGET).efi $(TARGET).efi.map $(TARGET)-syms $(TARGET)-syms.map *~ core -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Thu Jul 01 14:11:02 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 14:11:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148719.274939 (Exim 4.92) (envelope-from ) id 1lyxPB-0002OX-Pc; Thu, 01 Jul 2021 14:11:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148719.274939; Thu, 01 Jul 2021 14:11:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyxPB-0002O2-Jm; Thu, 01 Jul 2021 14:11:01 +0000 Received: by outflank-mailman (input) for mailman id 148719; Thu, 01 Jul 2021 14:11:01 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyxPB-0005tj-1K for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 14:11:01 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id dc51d3e3-e9ff-4cf0-8250-e11fa1c9f0c9; Thu, 01 Jul 2021 14:10:38 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dc51d3e3-e9ff-4cf0-8250-e11fa1c9f0c9 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1625148638; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=uLKI3ja1OUbts2SnkXQR8tTgRcFYuztp8ELRrsey8HY=; b=GzMrmv93g75dGvqNHP/ElWe5XWY5IsPA/7go3q8fnKFgzZZaRgbp5Cg2 wIGhO229pBS4nowzeIHkpnnrH1vSpQHK1HnTdu2FFtp27EvL+E0kIjZ4p yFzc92awQV9mjR16peojouoWcKDDWA8653djOcor0Y3qbR+dijDuabRsT s=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: wIO4LSAo1RB0HaT/akOTS3NCz9fKPQLBQUbVveOV7ZDsxOUA6h6frkF1StbkTbFdNID1zjly80 pWCRm8a8pjU4Nrv+jvHD8wTjx+0gqGylMuUCK4JnKgI1f/Yy/YR3KbTu+0E2P3D7o0Xu8TZQ2i C/TDLPzF1zcft4irDJL81YbVQwxjfyVLArodacQF7kUFEh2JlwmD1h32z61mi43PctvgQdaTBQ quhDcHx9v0aM1oQBZC/dAgjzkegd/OZtGjZsb6QUI4l2AD3BCeqk/wCCQ5TFvywtHae1rrkabJ ncQ= X-SBRS: 5.1 X-MesageID: 49007487 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:kwHH2qx3bz8ADejhFK2EKrPwFL1zdoMgy1knxilNoRw8SKKlfq eV7ZImPH7P+U4ssR4b+exoVJPtfZqYz+8R3WBzB8bEYOCFghrKEGgK1+KLqFeMJ8S9zJ846U 4JSdkGNDSaNzlHZKjBjzVQa+xQouW6zA== X-IronPort-AV: E=Sophos;i="5.83,314,1616472000"; d="scan'208";a="49007487" From: Anthony PERARD To: CC: Anthony PERARD , Stefano Stabellini , Julien Grall , Volodymyr Babchuk Subject: [XEN PATCH v6 14/31] build,arm: move LDFLAGS change to arch.mk Date: Thu, 1 Jul 2021 15:09:54 +0100 Message-ID: <20210701141011.785641-15-anthony.perard@citrix.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210701141011.785641-1-anthony.perard@citrix.com> References: <20210701141011.785641-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Signed-off-by: Anthony PERARD --- xen/arch/arm/Makefile | 8 -------- xen/arch/arm/arch.mk | 8 ++++++++ 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile index 0edd9dee6f49..3d0af8ebc93c 100644 --- a/xen/arch/arm/Makefile +++ b/xen/arch/arm/Makefile @@ -104,14 +104,6 @@ prelink.o: $(ALL_OBJS) $(ALL_LIBS) FORCE $(call if_changed,ld) endif -ifeq ($(CONFIG_ARM64_ERRATUM_843419),y) - ifeq ($(call ld-option, --fix-cortex-a53-843419),n) - $(warning ld does not support --fix-cortex-a53-843419; xen may be susceptible to erratum) - else - XEN_LDFLAGS += --fix-cortex-a53-843419 - endif -endif - targets += prelink.o $(TARGET)-syms: prelink.o xen.lds diff --git a/xen/arch/arm/arch.mk b/xen/arch/arm/arch.mk index 11caec86ba14..6a2982059486 100644 --- a/xen/arch/arm/arch.mk +++ b/xen/arch/arm/arch.mk @@ -17,3 +17,11 @@ $(call cc-option-add,CFLAGS-$(CONFIG_ARM_64),CC,-mno-outline-atomics) ifneq ($(filter command line environment,$(origin CONFIG_EARLY_PRINTK)),) $(error You must use 'make menuconfig' to enable/disable early printk now) endif + +ifeq ($(CONFIG_ARM64_ERRATUM_843419),y) + ifeq ($(call ld-option, --fix-cortex-a53-843419),n) + $(warning ld does not support --fix-cortex-a53-843419; xen may be susceptible to erratum) + else + LDFLAGS += --fix-cortex-a53-843419 + endif +endif -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Thu Jul 01 14:11:04 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 14:11:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148720.274950 (Exim 4.92) (envelope-from ) id 1lyxPE-0002x2-44; Thu, 01 Jul 2021 14:11:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148720.274950; Thu, 01 Jul 2021 14:11:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyxPD-0002wk-Vq; Thu, 01 Jul 2021 14:11:03 +0000 Received: by outflank-mailman (input) for mailman id 148720; Thu, 01 Jul 2021 14:11:02 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyxPC-0005F9-K1 for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 14:11:02 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 1a1c1c88-da76-11eb-8328-12813bfff9fa; Thu, 01 Jul 2021 14:10:35 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1a1c1c88-da76-11eb-8328-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1625148635; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=YsKdP5YvQwz72PyZst34Fs58LUxCUW3nm9UPTFm+erc=; b=Q29apw6ypftOH/490vEziVLWVjfQGeauMxZ4Tiydmp6pRzvvAa0Bjtcs ica8vX0JMeGcvEDf1uoUZFYq1DhlgnObzoC+pivXhmxmVEyA617PGZUcR 8apwQ3ippUKZdHew5PH4JzfjKQ/qzybivUxH2hBrMj36aPQI2YJ25Omhc 8=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: Gl7gpFD2pCJm/M7MRaZCSy0jIjUuheQt71gIpKzZRJmorny4R1wgXdIXEWx2kMSa9kQ0I+OU9G NQzZK/HFxxwJXY6u9HXFz2LCU4pyaCe6qhszmQW+uYfpIywGumUK/u5/xhhm8FIpqA2oAZ6nL4 1jwQaOfeYXlEqqJrawW9TZI6LGRJ5Y/FXqD3F6oQYBgh5lf4LEw118uw5/1b/uEN7rLbRZRCjM HxyNweZqtU3IAURTb1tAaEBFSwWE7aD0+m/av9OPsp8qk8OeIiBAmVkw9FC4JeldeCnhz4Z/rb u6E= X-SBRS: 5.1 X-MesageID: 47376107 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:Vun1V6ljqiwuiZcxmBJSZYTwKj/pDfIm3DAbv31ZSRFFG/Fw9/ re/8jztCWE7Ar5N0tMpTntAsW9qBDnlaKdg7N+AV7KZmCP01dAR7sC0WKN+VLd84CUzIRgPS AKSdkaNDUlZmIK7/rH3A== X-IronPort-AV: E=Sophos;i="5.83,314,1616472000"; d="scan'208";a="47376107" From: Anthony PERARD To: CC: Anthony PERARD , Andrew Cooper , George Dunlap , "Ian Jackson" , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [XEN PATCH v6 11/31] build: fix clean targets when subdir-y is used Date: Thu, 1 Jul 2021 15:09:51 +0100 Message-ID: <20210701141011.785641-12-anthony.perard@citrix.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210701141011.785641-1-anthony.perard@citrix.com> References: <20210701141011.785641-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain The make variable $(subdir-y) isn't used yet but will be in a following patch. Anything in $(subdir-y) doesn't to have a '/' as suffix as we already now it's a directory. Rework the rules so that it doesn't matter whether there is a '/' or not. It also mimic more closely to the way Linux's Kbuild descend in subdirectories. FORCE phony target isn't needed anymore running clean, so it can be removed. Signed-off-by: Anthony PERARD --- xen/scripts/Makefile.clean | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/xen/scripts/Makefile.clean b/xen/scripts/Makefile.clean index 53379e6102cc..027c200c0efc 100644 --- a/xen/scripts/Makefile.clean +++ b/xen/scripts/Makefile.clean @@ -12,19 +12,18 @@ include Makefile # Figure out what we need to clean from the various variables # ========================================================================== subdir-all := $(subdir-y) $(subdir-n) $(subdir-) \ - $(filter %/, $(obj-y) $(obj-n) $(obj-)) + $(patsubst %/,%, $(filter %/, $(obj-y) $(obj-n) $(obj-))) DEPS_RM = $(DEPS) $(DEPS_INCLUDE) .PHONY: clean -clean:: $(addprefix _clean_, $(subdir-all)) +clean:: $(subdir-all) rm -f *.o .*.o.tmp *~ core $(DEPS_RM) # Descending # --------------------------------------------------------------------------- -_clean_%/: FORCE - $(MAKE) $(clean) $* +PHONY += $(subdir-all) +$(subdir-all): + $(MAKE) $(clean) $@ -# Force execution of pattern rules (for which PHONY cannot be directly used). -.PHONY: FORCE -FORCE: +.PHONY: $(PHONY) -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Thu Jul 01 14:11:12 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 14:11:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148722.274961 (Exim 4.92) (envelope-from ) id 1lyxPM-00040O-Lz; Thu, 01 Jul 2021 14:11:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148722.274961; Thu, 01 Jul 2021 14:11:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyxPM-000406-Hy; Thu, 01 Jul 2021 14:11:12 +0000 Received: by outflank-mailman (input) for mailman id 148722; Thu, 01 Jul 2021 14:11:11 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyxPL-0005tj-1D for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 14:11:11 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id c3ababa9-cdb4-485b-a491-5eb323d0578c; Thu, 01 Jul 2021 14:10:40 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c3ababa9-cdb4-485b-a491-5eb323d0578c DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1625148640; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=mqaWfEcjARBVnWLFkl8yloMkvtnZhEKKi1UvpQrE8eE=; b=V/QnKzyBSD7idx/X9I+01F7g53WK5ZZqgkGaBOJkxYze6WhJztK+wVT8 4OAfgRSIt1NgODyl3oS435XuEeY/bSC5FyfE0rd9ORpAUPlvzpHO1UkG4 FymPQRCVQKJXVLRl3kOTppKQxtmDLC3eXVTAECcYgiC1WANA9TA1TK87T M=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: QB1JIgJBju7vB+HZgMiwhjOl7rzVaEimuCoCTSoV99oRVVvqXoPWgfEZzlAV0yt9Z/h6VjZ+Xi Kg+yqw86il+GmltT/+2CWPXZsFpY+GYXHVxVuSNVDplj1hCAQYJ/iC4+bvuP8OAhXhCxH1rKGS t6RM0ZoMFNGYdkxwRKHOEw6pTfxcDzVVNJ2ZRFEjm553cpvVqYRvv7MIAm4O8PJW8K967KPYzv D/h/2BlvgGKhRlcNSpw5+d6pM6nqRmrlt+XI4mCRY2Y+SQRTveRw41dd+BlOLBGoaTVWRI7KNj atU= X-SBRS: 5.1 X-MesageID: 47093349 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:GlAQNKqRnYb+k9v+WBdo34saV5oTeYIsimQD101hICG8cqSj+f xG+85rsyMc6QxhIE3I9urhBEDtex/hHNtOkOws1NSZLW7bUQmTXeJfBOLZqlWKcUDDH6xmpM NdmsBFeaTN5DNB7PoSjjPWLz9Z+qjkzJyV X-IronPort-AV: E=Sophos;i="5.83,314,1616472000"; d="scan'208";a="47093349" From: Anthony PERARD To: CC: Anthony PERARD , Andrew Cooper , George Dunlap , "Ian Jackson" , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [XEN PATCH v6 15/31] build: move make option changes check earlier Date: Thu, 1 Jul 2021 15:09:55 +0100 Message-ID: <20210701141011.785641-16-anthony.perard@citrix.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210701141011.785641-1-anthony.perard@citrix.com> References: <20210701141011.785641-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain And thus avoiding checking for those variable over and over again. Signed-off-by: Anthony PERARD --- xen/Makefile | 22 ++++++++++++++++++++++ xen/Rules.mk | 22 ---------------------- 2 files changed, 22 insertions(+), 22 deletions(-) diff --git a/xen/Makefile b/xen/Makefile index dae0247067ff..06d7bfab3e2c 100644 --- a/xen/Makefile +++ b/xen/Makefile @@ -56,6 +56,28 @@ include scripts/Kbuild.include ifneq ($(root-make-done),y) # section to run before calling Rules.mk, but only once. +ifneq ($(origin crash_debug),undefined) +$(error "You must use 'make menuconfig' to enable/disable crash_debug now.") +endif +ifeq ($(origin debug),command line) +$(warning "You must use 'make menuconfig' to enable/disable debug now.") +endif +ifneq ($(origin frame_pointer),undefined) +$(error "You must use 'make menuconfig' to enable/disable frame_pointer now.") +endif +ifneq ($(origin kexec),undefined) +$(error "You must use 'make menuconfig' to enable/disable kexec now.") +endif +ifneq ($(origin lock_profile),undefined) +$(error "You must use 'make menuconfig' to enable/disable lock_profile now.") +endif +ifneq ($(origin perfc),undefined) +$(error "You must use 'make menuconfig' to enable/disable perfc now.") +endif +ifneq ($(origin verbose),undefined) +$(error "You must use 'make menuconfig' to enable/disable verbose now.") +endif + # Beautify output # --------------------------------------------------------------------------- # diff --git a/xen/Rules.mk b/xen/Rules.mk index ede408efc515..894f2b83a04e 100644 --- a/xen/Rules.mk +++ b/xen/Rules.mk @@ -9,28 +9,6 @@ include $(XEN_ROOT)/Config.mk include $(BASEDIR)/scripts/Kbuild.include -ifneq ($(origin crash_debug),undefined) -$(error "You must use 'make menuconfig' to enable/disable crash_debug now.") -endif -ifeq ($(origin debug),command line) -$(warning "You must use 'make menuconfig' to enable/disable debug now.") -endif -ifneq ($(origin frame_pointer),undefined) -$(error "You must use 'make menuconfig' to enable/disable frame_pointer now.") -endif -ifneq ($(origin kexec),undefined) -$(error "You must use 'make menuconfig' to enable/disable kexec now.") -endif -ifneq ($(origin lock_profile),undefined) -$(error "You must use 'make menuconfig' to enable/disable lock_profile now.") -endif -ifneq ($(origin perfc),undefined) -$(error "You must use 'make menuconfig' to enable/disable perfc now.") -endif -ifneq ($(origin verbose),undefined) -$(error "You must use 'make menuconfig' to enable/disable verbose now.") -endif - TARGET := $(BASEDIR)/xen # Note that link order matters! -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Thu Jul 01 14:11:35 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 14:11:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148723.274972 (Exim 4.92) (envelope-from ) id 1lyxPj-0005br-1X; Thu, 01 Jul 2021 14:11:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148723.274972; Thu, 01 Jul 2021 14:11:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyxPi-0005bc-UR; Thu, 01 Jul 2021 14:11:34 +0000 Received: by outflank-mailman (input) for mailman id 148723; Thu, 01 Jul 2021 14:11:34 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyxPQ-0005tj-1B for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 14:11:16 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id b66e1eab-b8ae-48a5-a179-fd2a76fe5be5; Thu, 01 Jul 2021 14:10:42 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b66e1eab-b8ae-48a5-a179-fd2a76fe5be5 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1625148642; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=fDJGU3FkNLcK/b6b+O2MvcAjqOVoHCERsz8l937Wo3Y=; b=RITo4k8GBDsKxs9WtVh7mdRGibRgzUglQn76NioOkl2tPHswO3a4xB67 pxnkSkcAdU/F4LNBFunTSUti8i4P+ookTmXoNIC1O14BhzR54znyrO3bp aMQXTSG1P9nAEcN9wGouZB60jpyjX+BNequ+nQsIFs28xy3R+bMcRL319 o=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: ME0FSXPCr5qneEQ3bqxXA1FhkzMSN+hx4FUkzBNSr/GN+K+AAw0cdUFgmbQSgJbvKeUq1CR7Hk XP6/NlvO0uNNo4KjAZW8lfl8mU9oEXU+ZW2Om8tmobiLYCtgnAQhrC2BQ0HRnGRqJFK08kQaZ0 4illMf3xHfttdTutn/1CgxAw+GUOBvW6EQtVl+EGQSzFZqnEKwF999DP72dm+Hne07AG3uvdF4 76A4We69tsBzDNNoujunXbhWQ3yQyDAt2ZXicuUhZ6MlhZtp1LsbNUne6OJ5CoAjg0XCIgCAHZ 8c8= X-SBRS: 5.1 X-MesageID: 47093352 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:dtpGEa9pNNDiOdvCFWBuk+DgI+orL9Y04lQ7vn2YSXRuHPBw8P re+sjztCWE8Ar5N0tBpTntAsW9qDbnhPtICOoqTNCftWvdyQiVxehZhOOIqVDd8m/Fh4pgPM 9bAtFD4bbLbGSS4/yU3ODBKadD/OW6 X-IronPort-AV: E=Sophos;i="5.83,314,1616472000"; d="scan'208";a="47093352" From: Anthony PERARD To: CC: Anthony PERARD , Stefano Stabellini , Julien Grall , Volodymyr Babchuk Subject: [XEN PATCH v6 16/31] build: avoid building arm/arm/*/head.o twice Date: Thu, 1 Jul 2021 15:09:56 +0100 Message-ID: <20210701141011.785641-17-anthony.perard@citrix.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210701141011.785641-1-anthony.perard@citrix.com> References: <20210701141011.785641-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain head.o is been built twice, once because it is in $(ALL_OBJS) and a second time because it is in $(extra-y) and thus it is rebuilt when building "arch/arm/built_in.o". Fix this by adding a dependency of "head.o" on the directory "arch/arm/". Also, we should avoid building object that are in subdirectories, so move the declaration in there. This doesn't change anything as "arch/arm/built_in.o" depends on "arch/arm/$subarch/built_in.o" which depends on $(extra-y), so we still need to depend on "arch/arm/built_in.o". Signed-off-by: Anthony PERARD --- xen/arch/arm/Makefile | 7 ++++++- xen/arch/arm/arm32/Makefile | 1 + xen/arch/arm/arm64/Makefile | 2 ++ 3 files changed, 9 insertions(+), 1 deletion(-) diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile index 3d0af8ebc93c..cc90d9796e6e 100644 --- a/xen/arch/arm/Makefile +++ b/xen/arch/arm/Makefile @@ -64,7 +64,6 @@ obj-$(CONFIG_SBSA_VUART_CONSOLE) += vpl011.o obj-y += vsmc.o obj-y += vpsci.o obj-y += vuart.o -extra-y += $(TARGET_SUBARCH)/head.o extra-y += xen.lds @@ -76,6 +75,12 @@ endif ALL_OBJS := $(TARGET_SUBARCH)/head.o $(ALL_OBJS) +# head.o is built by descending into the sub-directory, depends on the part of +# $(ALL_OBJS) that will eventually recurse into $(TARGET_SUBARCH)/ and build +# head.o +$(TARGET_SUBARCH)/head.o: $(BASEDIR)/arch/arm/built_in.o +$(TARGET_SUBARCH)/head.o: ; + ifdef CONFIG_LIVEPATCH all_symbols = --all-symbols ifdef CONFIG_FAST_SYMBOL_LOOKUP diff --git a/xen/arch/arm/arm32/Makefile b/xen/arch/arm/arm32/Makefile index 96105d238307..3040eabce3ad 100644 --- a/xen/arch/arm/arm32/Makefile +++ b/xen/arch/arm/arm32/Makefile @@ -11,3 +11,4 @@ obj-y += smpboot.o obj-y += traps.o obj-y += vfp.o +extra-y += head.o diff --git a/xen/arch/arm/arm64/Makefile b/xen/arch/arm/arm64/Makefile index 40642ff57494..0bb284dedab2 100644 --- a/xen/arch/arm/arm64/Makefile +++ b/xen/arch/arm/arm64/Makefile @@ -13,3 +13,5 @@ obj-y += smpboot.o obj-y += traps.o obj-y += vfp.o obj-y += vsysreg.o + +extra-y += head.o -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Thu Jul 01 14:11:37 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 14:11:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148725.274983 (Exim 4.92) (envelope-from ) id 1lyxPl-0005wC-BE; Thu, 01 Jul 2021 14:11:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148725.274983; Thu, 01 Jul 2021 14:11:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyxPl-0005vu-7S; Thu, 01 Jul 2021 14:11:37 +0000 Received: by outflank-mailman (input) for mailman id 148725; Thu, 01 Jul 2021 14:11:35 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyxPH-0005F9-KI for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 14:11:07 +0000 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 1af898a2-da76-11eb-8328-12813bfff9fa; Thu, 01 Jul 2021 14:10:36 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1af898a2-da76-11eb-8328-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1625148635; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=aeF7Kv7O4DhLszrRehfv9wqocK16xFjPyQnD/pOHJvE=; b=WL8qr6MQA+x8RdrBCE95NyrnzLnsiXABHSyLSZcVkr4ZyQVlbnW00MBj mr8GZpa4Y5hEhb3sckHQLmeChjfBdimVPZlqukINYTrlizr+HilQ3uvvH uckt1fprX5Mw8n2Wf9RMOIWBIudUQtCYf3DRyc/535Z+dPo6sKGW8OaEB I=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: T+nZT/JsDbYrezwdPi3ALHuuwvixwOuxi/FNoer4yP4Pnaf60DhTs+1eP/80q+GMRH94ovSYSd c53NoQcvvGgP1cYWY7Gk9ZYtghKWbTT0Bz/w2BTBZHJHTssm5raqpAOmmFSjrZvDgECmdiD7q4 CeooBiqXRxbHMni5y2ATcAQCcsvGo+dVnaEvhSuh4dzFHwZXD4zFQl2xJpnJsOWGNWCYUoOPDy C7UnsoBV5aomfgtaq9lkm53rQOnE7xwIHj4MnXGbKuVuiQq3D3NdY1toOIVbLqAox7BIYXlbWN QKw= X-SBRS: 5.1 X-MesageID: 47384392 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:GxVxraBj3K7mmOjlHemq55DYdb4zR+YMi2TC1yhKJiC9Ffbo8P xG/c5rrCMc5wxxZJhNo7290ey7MBHhHP1OkO0s1NWZPDUO0VHAROoJ0WKh+UyEJ8SXzJ866U 4KScZD4bPLYWSS9fyKgzWFLw== X-IronPort-AV: E=Sophos;i="5.83,314,1616472000"; d="scan'208";a="47384392" From: Anthony PERARD To: CC: Anthony PERARD , Andrew Cooper , George Dunlap , "Ian Jackson" , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [XEN PATCH v6 12/31] build: use subdir-y in test/Makefile Date: Thu, 1 Jul 2021 15:09:52 +0100 Message-ID: <20210701141011.785641-13-anthony.perard@citrix.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210701141011.785641-1-anthony.perard@citrix.com> References: <20210701141011.785641-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain This allows Makefile.clean to recurse into livepatch without help. Signed-off-by: Anthony PERARD --- xen/test/Makefile | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/xen/test/Makefile b/xen/test/Makefile index aaa499664396..41e4d7bdb78b 100644 --- a/xen/test/Makefile +++ b/xen/test/Makefile @@ -4,15 +4,10 @@ tests all: build ifneq ($(XEN_TARGET_ARCH),x86_32) # Xen 32-bit x86 hypervisor no longer supported, so has no test livepatches -SUBDIRS += livepatch +subdir-y += livepatch endif install build subtree-force-update uninstall: %: - set -e; for s in $(SUBDIRS); do \ + set -e; for s in $(subdir-y); do \ $(MAKE) -f $(BASEDIR)/Rules.mk -C $$s $*; \ done - -clean:: - set -e; for s in $(SUBDIRS); do \ - $(MAKE) -f $(BASEDIR)/Rules.mk -C $$s $@; \ - done -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Thu Jul 01 14:11:37 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 14:11:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148726.274988 (Exim 4.92) (envelope-from ) id 1lyxPl-0005zt-PE; Thu, 01 Jul 2021 14:11:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148726.274988; Thu, 01 Jul 2021 14:11:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyxPl-0005ye-HZ; Thu, 01 Jul 2021 14:11:37 +0000 Received: by outflank-mailman (input) for mailman id 148726; Thu, 01 Jul 2021 14:11:35 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyxPb-0005F9-Kl for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 14:11:27 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 24f283d7-da76-11eb-8328-12813bfff9fa; Thu, 01 Jul 2021 14:10:53 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 24f283d7-da76-11eb-8328-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1625148653; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=HKKAaSAElL9br6IexbYT6ScUQSIaudpvDa7uCaCfemU=; b=M4n8wD+ugtQ8U61VBR2T5tZYuntbk2Yggx3x/rh4wKJzmw51/UY3ZMVr DQnag2aARDNisgYDuiXlRqmchYC/qZxCkGLv7xq66MSTbha2vhaAd6Z4o xmRnJMLpbkQt+uC4p44557eWwBEMQfHsX2ttLzm0uJaZ7P+BwVpaxqs3Q U=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: c1g5C7KdNCNvpUtARA66zPxQUkkAdOp4jynR3zRqXL/E2Pj/rbHwP7Iv3z2mgxMIr1fd+laPTd sznJd1GPoWlhW+uCcD6lfdVVF2kc70PCQYoUU+loHcP0Sv3QhN/Jq0t1K+E7vH5B/52DqavoRU n0Y6ZCnNj0K14ZxTcoZV/I9IO/wxfWKWP1+XE21ON5BRcpDhSrbF4FmoSa8AJFOqTLpGuZ/xJL KHQPkjPsQshE0VGdyV0vghnTA2mxqEBTxbjRmGpU7AktCT8b+PbJU+oZACjWuZcM07BJXNCohn bRk= X-SBRS: 5.1 X-MesageID: 47755379 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:a8e4m69QadqLNsZAVJZuk+DgI+orL9Y04lQ7vn2YSXRuHPBw8P re+sjztCWE8Ar5N0tBpTntAsW9qDbnhPtICOoqTNCftWvdyQiVxehZhOOIqVDd8m/Fh4pgPM 9bAtFD4bbLbGSS4/yU3ODBKadD/OW6 X-IronPort-AV: E=Sophos;i="5.83,314,1616472000"; d="scan'208";a="47755379" From: Anthony PERARD To: CC: Anthony PERARD , Andrew Cooper , George Dunlap , "Ian Jackson" , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [XEN PATCH v6 20/31] build: generate "include/xen/compile.h" with filechk Date: Thu, 1 Jul 2021 15:10:00 +0100 Message-ID: <20210701141011.785641-21-anthony.perard@citrix.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210701141011.785641-1-anthony.perard@citrix.com> References: <20210701141011.785641-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain This will always try regenerate the content of compile.h, but if it didn't change the file isn't updated. Also, as it's currently the case, the file isn't regenerated during `sudo make install` if it exist and does belong to a different user. Thus, we can remove the target "delete-unfresh-files". Target $(TARGET) still need a phony dependency, so add FORCE. This patch imports the macro 'filechk' from Linux v5.12. Signed-off-by: Anthony PERARD --- xen/Makefile | 51 +++++++++++++++++++------------------- xen/scripts/Kbuild.include | 31 +++++++++++++++++++++++ 2 files changed, 56 insertions(+), 26 deletions(-) diff --git a/xen/Makefile b/xen/Makefile index 267ae77aef7a..4c4990a753df 100644 --- a/xen/Makefile +++ b/xen/Makefile @@ -351,7 +351,7 @@ _debug: $(OBJDUMP) -D -S $(TARGET)-syms > $(TARGET).s .PHONY: _clean -_clean: delete-unfresh-files +_clean: $(MAKE) -C tools clean $(MAKE) $(clean) include $(MAKE) $(clean) common @@ -368,7 +368,7 @@ _clean: delete-unfresh-files -o -name "*.gcno" -o -name ".*.cmd" -o -name "lib.a" \) -exec rm -f {} \; rm -f include/asm $(TARGET) $(TARGET).gz $(TARGET).efi $(TARGET).efi.map $(TARGET)-syms $(TARGET)-syms.map *~ core rm -f asm-offsets.s include/arch-*/asm/asm-offsets.h - rm -f .banner + rm -f .banner include/xen/compile.h .PHONY: _distclean _distclean: clean @@ -378,7 +378,7 @@ $(TARGET).gz: $(TARGET) gzip -n -f -9 < $< > $@.new mv $@.new $@ -$(TARGET): delete-unfresh-files +$(TARGET): FORCE $(MAKE) -C tools $(MAKE) -f $(BASEDIR)/Rules.mk include/xen/compile.h [ -e arch/$(TARGET_ARCH)/efi ] && for f in $$(cd common/efi; echo *.[ch]); \ @@ -391,14 +391,6 @@ $(TARGET): delete-unfresh-files $(MAKE) -f $(BASEDIR)/Rules.mk include/arch-$(TARGET_ARCH)/asm/asm-offsets.h $(MAKE) -f $(BASEDIR)/Rules.mk -C arch/$(TARGET_ARCH) $@ -# drivers/char/console.o contains static banner/compile info. Blow it away. -# Don't refresh these files during e.g., 'sudo make install' -.PHONY: delete-unfresh-files -delete-unfresh-files: - @if [ ! -r include/xen/compile.h -o -O include/xen/compile.h ]; then \ - rm -f include/xen/compile.h; \ - fi - quiet_cmd_banner = BANNER $@ define cmd_banner if which figlet >/dev/null 2>&1 ; then \ @@ -413,22 +405,29 @@ endef $(call if_changed,banner) targets += .banner -# compile.h contains dynamic build info. Rebuilt on every 'make' invocation. -include/xen/compile.h: include/xen/compile.h.in .banner - @sed -e 's/@@date@@/$(XEN_BUILD_DATE)/g' \ - -e 's/@@time@@/$(XEN_BUILD_TIME)/g' \ - -e 's/@@whoami@@/$(XEN_WHOAMI)/g' \ - -e 's/@@domain@@/$(XEN_DOMAIN)/g' \ - -e 's/@@hostname@@/$(XEN_BUILD_HOST)/g' \ - -e 's!@@compiler@@!$(shell $(CC) $(CFLAGS) --version 2>&1 | head -1)!g' \ - -e 's/@@version@@/$(XEN_VERSION)/g' \ - -e 's/@@subversion@@/$(XEN_SUBVERSION)/g' \ - -e 's/@@extraversion@@/$(XEN_EXTRAVERSION)/g' \ - -e 's!@@changeset@@!$(shell tools/scmversion $(XEN_ROOT) || echo "unavailable")!g' \ - < include/xen/compile.h.in > $@.new +# Don't refresh this files during e.g., 'sudo make install' +define filechk_compile.h + if [ ! -r $@ -o -O $@ ]; then \ + sed -e 's/@@date@@/$(XEN_BUILD_DATE)/g' \ + -e 's/@@time@@/$(XEN_BUILD_TIME)/g' \ + -e 's/@@whoami@@/$(XEN_WHOAMI)/g' \ + -e 's/@@domain@@/$(XEN_DOMAIN)/g' \ + -e 's/@@hostname@@/$(XEN_BUILD_HOST)/g' \ + -e 's!@@compiler@@!$(shell $(CC) $(CFLAGS) --version 2>&1 | head -1)!g' \ + -e 's/@@version@@/$(XEN_VERSION)/g' \ + -e 's/@@subversion@@/$(XEN_SUBVERSION)/g' \ + -e 's/@@extraversion@@/$(XEN_EXTRAVERSION)/g' \ + -e 's!@@changeset@@!$(shell tools/scmversion $(XEN_ROOT) || echo "unavailable")!g' \ + < $<; \ + sed -rf tools/process-banner.sed < .banner; \ + else \ + cat $@; \ + fi +endef + +include/xen/compile.h: include/xen/compile.h.in .banner FORCE @cat .banner - @sed -rf tools/process-banner.sed < .banner >> $@.new - @mv -f $@.new $@ + $(call filechk,compile.h) asm-offsets.s: arch/$(TARGET_ARCH)/$(TARGET_SUBARCH)/asm-offsets.c $(CC) $(filter-out -Wa$(comma)% -flto,$(c_flags)) -S -g0 -o $@.new -MQ $@ $< diff --git a/xen/scripts/Kbuild.include b/xen/scripts/Kbuild.include index 83c7e1457baa..838c9440f35e 100644 --- a/xen/scripts/Kbuild.include +++ b/xen/scripts/Kbuild.include @@ -26,6 +26,37 @@ real-prereqs = $(filter-out $(PHONY), $^) # Escape single quote for use in echo statements escsq = $(subst $(squote),'\$(squote)',$1) +### +# Easy method for doing a status message + kecho := : + quiet_kecho := echo +silent_kecho := : +kecho := $($(quiet)kecho) + +### +# filechk is used to check if the content of a generated file is updated. +# Sample usage: +# +# filechk_sample = echo $(KERNELRELEASE) +# version.h: FORCE +# $(call filechk,sample) +# +# The rule defined shall write to stdout the content of the new file. +# The existing file will be compared with the new one. +# - If no file exist it is created +# - If the content differ the new file is used +# - If they are equal no change, and no timestamp update +define filechk + $(Q)set -e; \ + mkdir -p $(dir $@); \ + trap "rm -f $(dot-target).tmp" EXIT; \ + { $(filechk_$(1)); } > $(dot-target).tmp; \ + if [ ! -r $@ ] || ! cmp -s $@ $(dot-target).tmp; then \ + $(kecho) ' UPD $@'; \ + mv -f $(dot-target).tmp $@; \ + fi +endef + # as-insn: Check whether assembler supports an instruction. # Usage: cflags-y += $(call as-insn,CC FLAGS,"insn",option-yes,option-no) as-insn = $(if $(shell echo 'void _(void) { asm volatile ( $(2) ); }' \ -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Thu Jul 01 14:11:38 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 14:11:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148728.274994 (Exim 4.92) (envelope-from ) id 1lyxPm-00063p-5y; Thu, 01 Jul 2021 14:11:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148728.274994; Thu, 01 Jul 2021 14:11:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyxPl-00061q-So; Thu, 01 Jul 2021 14:11:37 +0000 Received: by outflank-mailman (input) for mailman id 148728; Thu, 01 Jul 2021 14:11:36 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyxPa-0005tj-1k for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 14:11:26 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id f25f2d19-cf1c-4c7d-836e-4235e74b1443; Thu, 01 Jul 2021 14:10:44 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f25f2d19-cf1c-4c7d-836e-4235e74b1443 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1625148644; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=PhrWzllsmLHVtsvEGcbavRIVcyx12iALMT+0SLc+Lhs=; b=QDp7U/jDvk/GYunNHwWNG1Jbmm5eBEkeRjBJx55HcvbRjAJQSHtIBnxA maVvccfueKvfOpapATahyjuSl8Ww9O0K5eM/fBK6aoL1Pn+wObPRooyZe 7TB/O3mNFSuKl/kcFOEtDIhfNn8VvPQXRtSeY488R4Ja+jPIwSyisb4lG 4=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: EXPDeoC24V8gZrB7FKnrI6Hlp/UMZnCQskM3aLrQz5qmeKZoJKWdRMQtbs+qoED/o4hvORc5Zo 1fggobvKcCsk61ozDgD2rc9452v19ekrMDIi988o8VhT6f3a9Sze0DCYqk3BdlK9NjCxECes1Y QsqKjq3yHLFPKBKpETAj+5pu9onZx0h24DDHEbN6vGnIl3BL5e2JUz1URQya6xXaFxUNCxKPR3 WOQCrWldnhbyhv2uvezBX4cfqK/aC++ah8qPIDjBmkcOk4MaH/0EA/xONuiv1FYtjvLqKF1xlv zyg= X-SBRS: 5.1 X-MesageID: 47755362 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:kw4536p8biEpunqYJdebNQgaV5r5eYIsimQD101hICG9E/b4qy nAppwmPHPP4wr5eUtQ+uxoW5PvfZq/z/JICOAqVItKOjONhILBFvAG0WKI+VLd8kPFm9K1rp 0BT0C1YOeAaWSTTq7BkW6F+6xL+qj/zEjy792ut0uECWpRGtxdB8IQMHf8LqWzLDM2fqbQ0/ Knl7B6T87JQwV0UviG X-IronPort-AV: E=Sophos;i="5.83,314,1616472000"; d="scan'208";a="47755362" From: Anthony PERARD To: CC: Anthony PERARD , Andrew Cooper , George Dunlap , "Ian Jackson" , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Daniel De Graaf , "Daniel P. Smith" Subject: [XEN PATCH v6 17/31] build: convert binfile use to if_changed Date: Thu, 1 Jul 2021 15:09:57 +0100 Message-ID: <20210701141011.785641-18-anthony.perard@citrix.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210701141011.785641-1-anthony.perard@citrix.com> References: <20210701141011.785641-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain This will allow to detect command line changes and allow to regenerate the file in that case. Signed-off-by: Anthony PERARD --- xen/common/Makefile | 8 ++++++-- xen/xsm/flask/Makefile | 8 ++++++-- 2 files changed, 12 insertions(+), 4 deletions(-) diff --git a/xen/common/Makefile b/xen/common/Makefile index 54de70d42278..93df3178b71f 100644 --- a/xen/common/Makefile +++ b/xen/common/Makefile @@ -80,8 +80,12 @@ config.gz: $(CONF_FILE) config_data.o: config.gz -config_data.S: $(BASEDIR)/tools/binfile - $(SHELL) $(BASEDIR)/tools/binfile $@ config.gz xen_config_data +quiet_cmd_binfile = BINFILE $@ +cmd_binfile = $(SHELL) $< $@ config.gz xen_config_data + +config_data.S: $(BASEDIR)/tools/binfile FORCE + $(call if_changed,binfile) +targets += config_data.S clean:: rm -f config_data.S config.gz 2>/dev/null diff --git a/xen/xsm/flask/Makefile b/xen/xsm/flask/Makefile index 637159ad8276..0ad15cb16606 100644 --- a/xen/xsm/flask/Makefile +++ b/xen/xsm/flask/Makefile @@ -35,8 +35,12 @@ $(subst include/,%/,$(AV_H_FILES)): $(AV_H_DEPEND) $(mkaccess) FORCE obj-bin-$(CONFIG_XSM_FLASK_POLICY) += flask-policy.o flask-policy.o: policy.bin -flask-policy.S: $(BASEDIR)/tools/binfile - $(SHELL) $(BASEDIR)/tools/binfile -i $@ policy.bin xsm_flask_init_policy +quiet_cmd_binfile = BINFILE $@ +cmd_binfile = $(SHELL) $< -i $@ policy.bin xsm_flask_init_policy + +flask-policy.S: $(BASEDIR)/tools/binfile FORCE + $(call if_changed,binfile) +targets += flask-policy.S FLASK_BUILD_DIR := $(CURDIR) POLICY_SRC := $(FLASK_BUILD_DIR)/xenpolicy-$(XEN_FULLVERSION) -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Thu Jul 01 14:20:14 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 14:20:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148754.275016 (Exim 4.92) (envelope-from ) id 1lyxY0-00012d-Uk; Thu, 01 Jul 2021 14:20:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148754.275016; Thu, 01 Jul 2021 14:20:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyxY0-00012W-RS; Thu, 01 Jul 2021 14:20:08 +0000 Received: by outflank-mailman (input) for mailman id 148754; Thu, 01 Jul 2021 14:20:07 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyxXz-0000yy-PZ for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 14:20:07 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (unknown [2a01:111:f400:7d00::62e]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 38eb7b32-fdc7-40c8-9b92-6a2105e133d0; Thu, 01 Jul 2021 14:20:03 +0000 (UTC) Received: from AS8PR04CA0102.eurprd04.prod.outlook.com (2603:10a6:20b:31e::17) by HE1PR0802MB2572.eurprd08.prod.outlook.com (2603:10a6:3:db::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.23; Thu, 1 Jul 2021 14:19:58 +0000 Received: from VE1EUR03FT062.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:31e:cafe::dd) by AS8PR04CA0102.outlook.office365.com (2603:10a6:20b:31e::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.22 via Frontend Transport; Thu, 1 Jul 2021 14:19:58 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT062.mail.protection.outlook.com (10.152.18.252) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.22 via Frontend Transport; Thu, 1 Jul 2021 14:19:58 +0000 Received: ("Tessian outbound 71a9bd19c2b9:v97"); Thu, 01 Jul 2021 14:19:57 +0000 Received: from 17edf0b672d7.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id D9F1A26D-C978-49D6-8C77-92BDDDF02473.1; Thu, 01 Jul 2021 14:19:36 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 17edf0b672d7.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 01 Jul 2021 14:19:36 +0000 Received: from PAXPR08MB6816.eurprd08.prod.outlook.com (2603:10a6:102:130::10) by PAXPR08MB6575.eurprd08.prod.outlook.com (2603:10a6:102:156::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.22; Thu, 1 Jul 2021 14:19:34 +0000 Received: from PAXPR08MB6816.eurprd08.prod.outlook.com ([fe80::7cfd:a8eb:b25a:f025]) by PAXPR08MB6816.eurprd08.prod.outlook.com ([fe80::7cfd:a8eb:b25a:f025%7]) with mapi id 15.20.4264.026; Thu, 1 Jul 2021 14:19:34 +0000 Received: from smtpclient.apple (82.8.129.65) by LO2P265CA0361.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a3::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.21 via Frontend Transport; Thu, 1 Jul 2021 14:19:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 38eb7b32-fdc7-40c8-9b92-6a2105e133d0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=afscDBvgHhKc1x2AyQTYXc6zkHtTRdwpHFcfhh+V0Ek=; b=P5KAjpJq8xgSYK3l7kIqnfMRT64IvYQDtuoBwoSn4Z64iuRLAmhf9P7hEXhehrFBUGjlSI/rriBToq4oJ6acEu440KoUhcGY+YeZ8CSBD52eYXd5OwaREptPnidbP42fyN2eUtnWlNYhtb2a4CLPFxlTwIsZMfYUpc2vZydu6dQ= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: b6f5b7374b0fbda0 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aa6SXLjh1XpdbylyNhV7WEFW4td9/ACt4/04bjfUBHMQE909iJL7EPV0uM3HxvTwpMs6eJfxkCnX7v6oFNE5nTP942O7amT4vkI59A7wSc8WvVR+f2kkz4P6yZpJZJFN6CBJ8Wr0lnzZ3OK4jQslobE3QTC3AnRXxqimMSzPstyyzXfjzJuLqFvoVIsJ87VJ9XVxpNaOgzUzb1tLtyZLO6Ui4EQoXq3kUXTRCzXmYTf6QA+8NORydRd805+Urkj3I3nN8WAtnCjGuA/XQjaSIJA4iMXnyFPvMFIUUgoAyRiXujyR/i9mqzsL/lrIeXKqEFU962+V4kbk1O15c7etBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=afscDBvgHhKc1x2AyQTYXc6zkHtTRdwpHFcfhh+V0Ek=; b=mKCdumG2JH49HjeT8jN2eaQih/2d4zV8N8FaouJW/S/eizzhZi4nfgkW2mpquewnah7j5SsRNvNhEUrrYC3K3P3fdLor+hxmiBgpEXwAyg3X0BNCnpXjIgpB42H62WQhK4t3dFHanRUFF1gMOMMFHkMw+pUZez2IBqDKHQKV8wsXZzuzvMS5X33QbMH9iEbD5xNUpKbemFFS3FsCFpA8TWyLUaf6+3ES4H05DyO1s1DxqlxxkA6TbHn0trv2UsPWrxFz/AWBtFGBOSaDBpGOy6IZKSNasalwjNCYwon7V81f8qPaLR5yVaQvJQawLL2a2KAcHB0+eTFsEHmWcgID8A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=afscDBvgHhKc1x2AyQTYXc6zkHtTRdwpHFcfhh+V0Ek=; b=P5KAjpJq8xgSYK3l7kIqnfMRT64IvYQDtuoBwoSn4Z64iuRLAmhf9P7hEXhehrFBUGjlSI/rriBToq4oJ6acEu440KoUhcGY+YeZ8CSBD52eYXd5OwaREptPnidbP42fyN2eUtnWlNYhtb2a4CLPFxlTwIsZMfYUpc2vZydu6dQ= Authentication-Results-Original: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=arm.com; Content-Type: text/plain; charset=utf-8 Subject: Re: [PATCH v6 9/9] docs/doxygen: doxygen documentation for grant_table.h From: Luca Fancellu In-Reply-To: Date: Thu, 1 Jul 2021 15:19:28 +0100 Cc: xen-devel@lists.xenproject.org, Bertrand Marquis , wei.chen@arm.com, Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Julien Grall , Wei Liu Content-Transfer-Encoding: quoted-printable Message-Id: <31171081-1007-4B4E-91CC-25EA1041EB58@arm.com> References: <20210510084105.17108-1-luca.fancellu@arm.com> <20210510084105.17108-10-luca.fancellu@arm.com> To: Stefano Stabellini X-Mailer: Apple Mail (2.3654.100.0.2.22) X-Originating-IP: [82.8.129.65] X-ClientProxiedBy: LO2P265CA0361.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a3::13) To PAXPR08MB6816.eurprd08.prod.outlook.com (2603:10a6:102:130::10) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 418a0670-7b2e-4ec5-6ce3-08d93c9b4e64 X-MS-TrafficTypeDiagnostic: PAXPR08MB6575:|HE1PR0802MB2572: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:2803;OLM:2803; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: L6b6686e6d80gydqVVakp+j2V8WkCGO9vFDQaDPQOlKgZgFmNtJDW3pXd0ImOmUZlCtm774kxqYK0yRWLYxHfvOUw1T9P4xekJiHyaxC2hfWrsdu2mpYBECOWg8jU2YCmf6FbRAhY1ilPDqOfM1BKCxw7AZBIYByF/F5dLmYMB12Mkkpg5qt4/rqt06kg3TMcBsVbfqxfsblMpKqroHYm1pdftNIMKrR+wz77dZpOCpQMVarosfuWPdnldgQIHTvi+u0Ee1mCYfVacOmmnRgDmDUg/FP7vzrmtCzpoWp6VBqUErMIMLz3QSHm8+RcMk7n8AH9eP4/rr71kjLXLI3WU462d4kzyS0ueKsqrOg+4jG+tNJjJKMQHgIkYlZjSHGtiC//c51FFx4ck0VLdLNodsmnTpJUX08vTCjY37g6XdK1x1c2cBG8c85bbLi1+Ygt1NfyUO5KbzIhMWeEj3K0hxq62VEaGk1njp2XUo/qXyAdtl7RGeLkHcfOBYkSa8IaQWZ5+KHx3Y5hAF/LDDTzqv9LdSqyJE3jA2gNzeFuX76Z/mDcEzV1o2EvFpQf/isv88x9F7Tl+IgaSaaRxnh1BcUExLmkYhyrSBl+xgKHcK+MWkRnZHADBWHEq6aXs3ENJ84QAJu2c9te//mVFW1PetU4ydThEqeF1tU7AC8UxlO7ogqORGHOrU1durNo04YyDIf1ytxUBeLZ4QSo5tDTWSlN1aom4vma4ben9tvyUKRte/G5k6YoUDqhu80tQdGudEV3Uy9kDU8RNU+TVMkP9w1sIgKADMLOE6ISUPKnNsDpISjWrlpFPCEAYAF+yPfdlsMTWfZx+viCZg0J/4MaOb7q4v6QmD4ppwt/s7E3W0h+enWf3+Y5+dEQYYFIzty X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB6816.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(83380400001)(5660300002)(86362001)(966005)(956004)(6512007)(66476007)(498600001)(2616005)(52116002)(33656002)(6486002)(6506007)(6666004)(66556008)(66946007)(4326008)(44832011)(36756003)(8936002)(30864003)(8676002)(53546011)(6916009)(186003)(38100700002)(2906002)(26005)(38350700002)(16526019)(54906003)(21314003)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Ly9JQTVDa2FlQjM2aHJGOTE4SW96T3VPQ1lvYXpRUm41c3Z2LzJoWWpFZWRW?= =?utf-8?B?Z24veWpMalNlTmFaWDF4d0IrQnFEcG5vck94TUVWakk1b29ocjEyVDFNdmRL?= =?utf-8?B?MW9STlRxamNLelNKMkNlbWxaYS9WaXI5eCtMSjhqK01FSkNCNGR5UUVQK0Jm?= =?utf-8?B?ZFJmOVVtZDUyYmhQcVFHRGhKeDBucGZuYjdhck1GTitYSEFrVUpoZDZ4eGtO?= =?utf-8?B?N3BieXhHNUVjNkl4RmVjWDNOVlVKODhGd2FTT0NJc1lhYytpaUlhWFdBV0Vm?= =?utf-8?B?YmtyNU82ay9HOUc5cmpESlFnbWkxdE9CUTFYQm03TktncTFoZTRtc2luZ1By?= =?utf-8?B?b3A1TmdHcjJJbjVUZkxQZzFOdTcwNVN3VDdXZGM4UTdibWwydmp3aVE4UEZ5?= =?utf-8?B?WmVVMm1LQjlZL1NKOGtNZW5DNUEvVURtemRpU2R6S3lZZnYvZlJJdTViZUMx?= =?utf-8?B?OFlkTEd5YjF3dG1rWFVnUTBjYnQ1b1dRUWZWYUJUR21Uc0l4ZnZpMTkzM2FL?= =?utf-8?B?dW9DTWxFZDEwZTdoc2ZBc1E1RCtVM2dqcmtLNzgwZmdmNERIRWJQWU1PN094?= =?utf-8?B?WlBHeWZDMDJpZE4xNUI0eUcvTko4U1pXdHNINkxwU1hYRXA3b1YzN0QxTk5v?= =?utf-8?B?ak1JU2lFd3YwdWs2TTF6NG9lR1hYZEVUMFljUEg5N3FOZHZQQWhXZXh5T0w5?= =?utf-8?B?WDd2RHdNWUZJNEE0SmcvdnNQT1ZJMVFEaWphSVRFc2dha29SelBhK0lhSjJa?= =?utf-8?B?UjNXTC9ZbWVWZ1NpMnpiYXNiL2dtOHh4SmNnTXhaUXdNRTlwWUg3aHVxTGRz?= =?utf-8?B?Q252TzVFZ1d3SWM5alBtSlA3amhHYUdrWXY4OENycWJQc2JWRlRNNDFydllQ?= =?utf-8?B?VlRuNGRFSUdZZ0d3ck83N1JCR0VtRGxZa1BCRURyMW16VGgwR1M2eWphUUlm?= =?utf-8?B?czRXcXcvYUNmdGpXbnNBejZXdHNLUDc0Nzd1Q3BtcjQ0SWFTa20wbDJwM2Ry?= =?utf-8?B?YUppWDlXZmZ2VnRheDZNaU5HVUMyV1ovUDBaOWJETmJYUzdKUHhxVlRMTFVT?= =?utf-8?B?YU9xcno5a2pEckpjK2VmVmNQckw0MENGUkhQcVIxNGp3R1hUUS9sTWpJZlRl?= =?utf-8?B?eGcwZDFua2ZkT2tHVEV3L2xlNFJYb0NqSEJoMDhTSzNmTWFSZDhaTHhNQ1U4?= =?utf-8?B?NVN1L00ycU9aWjIzcGxhdHB6L1IwVFpnYUp1b3ZUOWFiZDliTFR1dTZRRk9r?= =?utf-8?B?R1RDUTJGbGo0d0hTTkxVRGl1Vjg3b3o0Z2xiVjBZVkd2dUxNOGd6b3lnU1Bq?= =?utf-8?B?SnZuVzJjck1BaG9tTHUvbmo3SFFETjRTRHBaa1l5RndUcTFOb3NLazl0aFo1?= =?utf-8?B?SzhtOHpxWTc2bjYyY01uMngyNE8wcGhNOHZZZC9KNm5UNStoemhoRFVBWFdj?= =?utf-8?B?THNHZ1NoaU5hOCtlKzNXVTArUmZ4MmhCa3RvSW5jOGNQdTdFYTVkWjgzWVZX?= =?utf-8?B?Yy8xWGhwRHhyejRJSlYxUllKUHJGN3dlamVrU0NhTWt4dUdqYmxncDBLNjBz?= =?utf-8?B?aStwOWYwWFI1T2xEbG5lKzEyc0h2NW9nR2pSWTRJTFd3QWYwNEFaa2FpVVZV?= =?utf-8?B?THV6MnQ1U1NCUFp6dEtpTEhoVTN6dE5mbjBnaUd4dFpscmNjWCtlVjFWZVFQ?= =?utf-8?B?M0N0a3NYeGFlQ3k1QVhEcGVpblgrSDNmVWljOFQwNGNId3hwYkpXMThUYkds?= =?utf-8?Q?Vs1RtVXlvJ3AZiLi7kQUq11E7hfvtqztMi+QrdV?= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6575 Original-Authentication-Results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT062.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 5ca3f7c7-25f5-4139-8d9f-08d93c9b4025 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6F4ktY+k2TFmQDQrdc8yh4LmD2GNxT6J6665TYxG572Gk0rxcUAyPnmrVJRfSeKLWo64E8cJFkGeDonbxAiosP1wxwWe2hfZO8g4wusv+VRn6z5E7f1efuoeMCPRP1THP9zFzbCXgBD60YVYA4Y5A3IqHbryJ5LzlDxzOR874+qEWN/oYn/q0GH6dxJq/TwmkCMrwX6wM9D72tYE93Y8DoboLagdP9eP8R6JW8EVPS0Zfh6qcIDdO2Plz5yUXO5kmSsN0RsvGh+2XWY5GDVfdoP3/xFXpB4ohagc1cjzaf66Pi8QGjf7VxBsxqPzXRfGEBwevOXfFMN/X+SlUa37fFJk1sOFlyDCdJBmPtaxGT/BTJRGA+owRp1E6ty3WZNetbvoSxeP42j3/AlC469Tm9vzddLj2i4j0rgMIVY7Mr/vbFaKUN5ns57Bldb/2tLmm/+Tw8c8xqB4b/DjjfVLIDs5j8ReC3W3ChST8t+Z/aQIz4XqQp7tcIbc3CYwDeHRk/CuxHi5OgwqxPk+thDwSViIpV3kZtBLa1cqFr+gGX2CRMjIO3GFDZu738AdF/TZzGnXtxzml6AtrLY/f1T2xzo4xSOSF83Tv2doPNDXprYUrSrJkAypglLWg/l2BodUK/IQfowP6X75BT15rPCSBGJNgFMlmaXduLz3GJssSqrVNeRO7LS6sokeZIpsjqADswSsfZL41LC46vkWksY8IyyFVNcJcCzWIKK/YI6PRQPmsxh79HDsTI7xO7kgf7woS6LTIwDnR62caIjusE/FkX2w8vfFNPRsCpT36Ornji+mT9O97lwzofj3I4uJ7SdfQEdgXKrzKidpwB7U3/S8GYktnU896NPOlvA9TJHQ5l4= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(6512007)(83380400001)(36860700001)(82310400003)(33656002)(36756003)(6486002)(8676002)(336012)(186003)(16526019)(53546011)(6666004)(966005)(6506007)(956004)(2616005)(44832011)(26005)(6862004)(47076005)(70206006)(4326008)(5660300002)(2906002)(8936002)(498600001)(70586007)(86362001)(30864003)(81166007)(356005)(54906003)(21314003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jul 2021 14:19:58.0908 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 418a0670-7b2e-4ec5-6ce3-08d93c9b4e64 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT062.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0802MB2572 Hi Stefano, > On 24 Jun 2021, at 00:34, Stefano Stabellini wro= te: >=20 > On Mon, 10 May 2021, Luca Fancellu wrote: >> Modification to include/public/grant_table.h: >>=20 >> 1) Add doxygen tags to: >> - Create Grant tables section >> - include variables in the generated documentation >> - Used @keepindent/@endkeepindent to enclose comment >> section that are indented using spaces, to keep >> the indentation. >> 2) Add .rst file for grant table for Arm64 >=20 > Why only arm64? This is a mistake, it should be just =E2=80=9CAdd .rst file for grant table= " >=20 >=20 >> Signed-off-by: Luca Fancellu >> --- >> v6 changes: >> - Fix misaligned comment >> - Moved comments to make them display in the docs >> - Included more documentation in the docs >> (see output here: https://luca.fancellu.gitlab.io/xen-docs/hypercall-in= terfaces/common/grant_tables.html) >=20 > It looks much much better. All the info we care about seems to be there. > The only things that I noticed missing and might be good to keep is the > small comment about HYPERVISOR_grant_table_op: >=20 > /* ` enum neg_errnoval > * ` HYPERVISOR_grant_table_op(enum grant_table_op cmd, > * ` void *args, > * ` unsigned int count) > * ` > * > * @args points to an array of a per-command data structure. The array > * has @count members Where do you want me to put this comment in the html page? In the end of th= e description in the top of the page? Cheers, Luca >=20 > All the changes look good to me. >=20 >=20 >=20 >> v5 changes: >> - Move GNTCOPY_* define next to the flags field >> v4 changes: >> - Used @keepindent/@endkeepindent doxygen commands >> to keep text with spaces indentation. >> - drop changes to grant_entry_v1 comment, it will >> be changed and included in the docs in a future patch >> - Move docs .rst to "common" folder >> v3 changes: >> - removed tags to skip anonymous union/struct >> - moved back comment pointed out by Jan >> - moved down defines related to struct gnttab_copy >> as pointed out by Jan >> v2 changes: >> - Revert back to anonymous union/struct >> - add doxygen tags to skip anonymous union/struct >> --- >> docs/hypercall-interfaces/arm64.rst | 1 + >> .../common/grant_tables.rst | 9 + >> docs/xen-doxygen/doxy_input.list | 1 + >> xen/include/public/grant_table.h | 387 +++++++++++------- >> 4 files changed, 245 insertions(+), 153 deletions(-) >> create mode 100644 docs/hypercall-interfaces/common/grant_tables.rst >>=20 >> diff --git a/docs/hypercall-interfaces/arm64.rst b/docs/hypercall-interf= aces/arm64.rst >> index 5e701a2adc..cb4c0d13de 100644 >> --- a/docs/hypercall-interfaces/arm64.rst >> +++ b/docs/hypercall-interfaces/arm64.rst >> @@ -8,6 +8,7 @@ Starting points >> .. toctree:: >> :maxdepth: 2 >>=20 >> + common/grant_tables >>=20 >>=20 >> Functions >> diff --git a/docs/hypercall-interfaces/common/grant_tables.rst b/docs/hy= percall-interfaces/common/grant_tables.rst >> new file mode 100644 >> index 0000000000..b8a1ef8759 >> --- /dev/null >> +++ b/docs/hypercall-interfaces/common/grant_tables.rst >> @@ -0,0 +1,9 @@ >> +.. SPDX-License-Identifier: CC-BY-4.0 >> + >> +Grant Tables >> +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >> + >> +.. doxygengroup:: grant_table >> + :project: Xen >> + :members: >> + :undoc-members: >> diff --git a/docs/xen-doxygen/doxy_input.list b/docs/xen-doxygen/doxy_in= put.list >> index e69de29bb2..233d692fa7 100644 >> --- a/docs/xen-doxygen/doxy_input.list >> +++ b/docs/xen-doxygen/doxy_input.list >> @@ -0,0 +1 @@ >> +xen/include/public/grant_table.h >> diff --git a/xen/include/public/grant_table.h b/xen/include/public/grant= _table.h >> index 84b1d26b36..dfa5155927 100644 >> --- a/xen/include/public/grant_table.h >> +++ b/xen/include/public/grant_table.h >> @@ -25,15 +25,19 @@ >> * Copyright (c) 2004, K A Fraser >> */ >>=20 >> +/** >> + * @file >> + * @brief Interface for granting foreign access to page frames, and rec= eiving >> + * page-ownership transfers. >> + */ >> + >> #ifndef __XEN_PUBLIC_GRANT_TABLE_H__ >> #define __XEN_PUBLIC_GRANT_TABLE_H__ >>=20 >> #include "xen.h" >>=20 >> -/* >> - * `incontents 150 gnttab Grant Tables >> - * >> - * Xen's grant tables provide a generic mechanism to memory sharing >> +/** >> + * @brief Xen's grant tables provide a generic mechanism to memory shar= ing >> * between domains. This shared memory interface underpins the split >> * device drivers for block and network IO. >> * >> @@ -51,13 +55,13 @@ >> * know the real machine address of a page it is sharing. This makes >> * it possible to share memory correctly with domains running in >> * fully virtualised memory. >> - */ >> - >> -/*********************************** >> + * >> * GRANT TABLE REPRESENTATION >> - */ >> - >> -/* Some rough guidelines on accessing and updating grant-table entries >> + * >> + * A grant table comprises a packed array of grant entries in one or mo= re >> + * page frames shared between Xen and a guest. >> + * >> + * Some rough guidelines on accessing and updating grant-table entries >> * in a concurrency-safe manner. For more information, Linux contains a >> * reference implementation for guest OSes (drivers/xen/grant_table.c, s= ee >> * http://git.kernel.org/?p=3Dlinux/kernel/git/torvalds/linux.git;a=3Dbl= ob;f=3Ddrivers/xen/grant-table.c;hb=3DHEAD >> @@ -66,6 +70,7 @@ >> * compiler barrier will still be required. >> * >> * Introducing a valid entry into the grant table: >> + * @keepindent >> * 1. Write ent->domid. >> * 2. Write ent->frame: >> * GTF_permit_access: Frame to which access is permitted. >> @@ -73,20 +78,25 @@ >> * frame, or zero if none. >> * 3. Write memory barrier (WMB). >> * 4. Write ent->flags, inc. valid type. >> + * @endkeepindent >> * >> * Invalidating an unused GTF_permit_access entry: >> + * @keepindent >> * 1. flags =3D ent->flags. >> * 2. Observe that !(flags & (GTF_reading|GTF_writing)). >> * 3. Check result of SMP-safe CMPXCHG(&ent->flags, flags, 0). >> * NB. No need for WMB as reuse of entry is control-dependent on succes= s of >> * step 3, and all architectures guarantee ordering of ctrl-dep wri= tes. >> + * @endkeepindent >> * >> * Invalidating an in-use GTF_permit_access entry: >> + * >> * This cannot be done directly. Request assistance from the domain con= troller >> * which can set a timeout on the use of a grant entry and take necessa= ry >> * action. (NB. This is not yet implemented!). >> * >> * Invalidating an unused GTF_accept_transfer entry: >> + * @keepindent >> * 1. flags =3D ent->flags. >> * 2. Observe that !(flags & GTF_transfer_committed). [*] >> * 3. Check result of SMP-safe CMPXCHG(&ent->flags, flags, 0). >> @@ -97,29 +107,32 @@ >> * transferred frame is written. It is safe for the guest to spin w= aiting >> * for this to occur (detect by observing GTF_transfer_completed in >> * ent->flags). >> + * @endkeepindent >> * >> * Invalidating a committed GTF_accept_transfer entry: >> * 1. Wait for (ent->flags & GTF_transfer_completed). >> * >> * Changing a GTF_permit_access from writable to read-only: >> + * >> * Use SMP-safe CMPXCHG to set GTF_readonly, while checking !GTF_writin= g. >> * >> * Changing a GTF_permit_access from read-only to writable: >> + * >> * Use SMP-safe bit-setting instruction. >> + * >> + * Data structure fields or defines described below have the following = tags: >> + * * [XEN]: This field is written by Xen and read by the sharing guest. >> + * * [GST]: This field is written by the guest and read by Xen. >> + * >> + * @addtogroup grant_table Grant Tables >> + * @{ >> */ >>=20 >> -/* >> +/** >> * Reference to a grant entry in a specified domain's grant table. >> */ >> typedef uint32_t grant_ref_t; >>=20 >> -/* >> - * A grant table comprises a packed array of grant entries in one or mo= re >> - * page frames shared between Xen and a guest. >> - * [XEN]: This field is written by Xen and read by the sharing guest. >> - * [GST]: This field is written by the guest and read by Xen. >> - */ >> - >> /* >> * Version 1 of the grant table entry structure is maintained purely >> * for backwards compatibility. New guests should use version 2. >> @@ -129,15 +142,17 @@ typedef uint32_t grant_ref_t; >> #define grant_entry_v1_t grant_entry_t >> #endif >> struct grant_entry_v1 { >> - /* GTF_xxx: various type and flag information. [XEN,GST] */ >> + /** GTF_xxx: various type and flag information. [XEN,GST] */ >> uint16_t flags; >> - /* The domain being granted foreign privileges. [GST] */ >> + /** The domain being granted foreign privileges. [GST] */ >> domid_t domid; >> - /* >> + /** >> + * @keepindent >> * GTF_permit_access: GFN that @domid is allowed to map and access. = [GST] >> * GTF_accept_transfer: GFN that @domid is allowed to transfer into.= [GST] >> * GTF_transfer_completed: MFN whose ownership transferred by @domid >> * (non-translated guests only). [XEN] >> + * @endkeepindent >> */ >> uint32_t frame; >> }; >> @@ -150,60 +165,99 @@ typedef struct grant_entry_v1 grant_entry_v1_t; >> #define GNTTAB_RESERVED_CONSOLE 0 >> #define GNTTAB_RESERVED_XENSTORE 1 >>=20 >> -/* >> - * Type of grant entry. >> - * GTF_invalid: This grant entry grants no privileges. >> - * GTF_permit_access: Allow @domid to map/access @frame. >> - * GTF_accept_transfer: Allow @domid to transfer ownership of one page= frame >> - * to this guest. Xen writes the page number to @= frame. >> - * GTF_transitive: Allow @domid to transitively access a subrange of >> - * @trans_grant in @trans_domid. No mappings are allo= wed. >> - */ >> +/** This type of grant entry grants no privileges. */ >> #define GTF_invalid (0U<<0) >> + >> +/** This type of grant entry allow \@domid to map/access \@frame. */ >> #define GTF_permit_access (1U<<0) >> + >> +/** >> + * This type of grant entry allow \@domid to transfer ownership of one = pageframe >> + * to this guest. Xen writes the page number to \@frame. >> + */ >> #define GTF_accept_transfer (2U<<0) >> + >> +/** >> + * This type of grant entry allow \@domid to transitively access a subr= ange of >> + * \@trans_grant in \@trans_domid. No mappings are allowed. >> + */ >> #define GTF_transitive (3U<<0) >> + >> #define GTF_type_mask (3U<<0) >>=20 >> -/* >> - * Subflags for GTF_permit_access and GTF_transitive. >> - * GTF_readonly: Restrict @domid to read-only mappings and accesses. [= GST] >> - * GTF_reading: Grant entry is currently mapped for reading by @domid.= [XEN] >> - * GTF_writing: Grant entry is currently mapped for writing by @domid.= [XEN] >> - * Further subflags for GTF_permit_access only. >> - * GTF_PAT, GTF_PWT, GTF_PCD: (x86) cache attribute flags to be used f= or >> - * mappings of the grant [GST] >> - * GTF_sub_page: Grant access to only a subrange of the page. @domid >> - * will only be allowed to copy from the grant, and not >> - * map it. [GST] >> +/** >> + * @def GTF_readonly >> + * Subflag for GTF_permit_access and GTF_transitive: Restrict \@domid t= o >> + * read-only mappings and accesses. [GST] >> */ >> #define _GTF_readonly (2) >> #define GTF_readonly (1U<<_GTF_readonly) >> + >> +/** >> + * @def GTF_reading >> + * Subflag for GTF_permit_access and GTF_transitive: Grant entry is cur= rently >> + * mapped for reading by \@domid. [XEN] >> + */ >> #define _GTF_reading (3) >> #define GTF_reading (1U<<_GTF_reading) >> + >> +/** >> + * @def GTF_writing >> + * Subflag for GTF_permit_access and GTF_transitive: Grant entry is cur= rently >> + * mapped for writing by \@domid. [XEN] >> + */ >> #define _GTF_writing (4) >> #define GTF_writing (1U<<_GTF_writing) >> + >> +/** >> + * @def GTF_PWT >> + * Subflag for GTF_permit_access only: (x86) cache attribute flags to b= e used >> + * for mappings of the grant [GST] >> + */ >> #define _GTF_PWT (5) >> #define GTF_PWT (1U<<_GTF_PWT) >> + >> +/** >> + * @def GTF_PCD >> + * Subflag for GTF_permit_access only: (x86) cache attribute flags to b= e used >> + * for mappings of the grant [GST] >> + */ >> #define _GTF_PCD (6) >> #define GTF_PCD (1U<<_GTF_PCD) >> + >> +/** >> + * @def GTF_PAT >> + * Subflag for GTF_permit_access only: (x86) cache attribute flags to b= e used >> + * for mappings of the grant [GST] >> + */ >> #define _GTF_PAT (7) >> #define GTF_PAT (1U<<_GTF_PAT) >> + >> +/** >> + * @def GTF_sub_page >> + * Subflag for GTF_permit_access only: Grant access to only a subrange = of the >> + * page. \@domid will only be allowed to copy from the grant, and not m= ap it. >> + * [GST] >> + */ >> #define _GTF_sub_page (8) >> #define GTF_sub_page (1U<<_GTF_sub_page) >>=20 >> -/* >> - * Subflags for GTF_accept_transfer: >> - * GTF_transfer_committed: Xen sets this flag to indicate that it is c= ommitted >> - * to transferring ownership of a page frame. When a guest sees th= is flag >> - * it must /not/ modify the grant entry until GTF_transfer_complet= ed is >> - * set by Xen. >> - * GTF_transfer_completed: It is safe for the guest to spin-wait on th= is flag >> - * after reading GTF_transfer_committed. Xen will always write the= frame >> - * address, followed by ORing this flag, in a timely manner. >> +/** >> + * @def GTF_transfer_committed >> + * Subflag for GTF_accept_transfer: Xen sets this flag to indicate that= it is >> + * committed to transferring ownership of a page frame. When a guest se= es this >> + * flag it must /not/ modify the grant entry until GTF_transfer_complet= ed is >> + * set by Xen. >> */ >> #define _GTF_transfer_committed (2) >> #define GTF_transfer_committed (1U<<_GTF_transfer_committed) >> + >> +/** >> + * @def GTF_transfer_completed >> + * Subflag for GTF_accept_transfer: It is safe for the guest to spin-wa= it on >> + * this flag after reading GTF_transfer_committed. Xen will always writ= e the >> + * frame address, followed by ORing this flag, in a timely manner. >> + */ >> #define _GTF_transfer_completed (3) >> #define GTF_transfer_completed (1U<<_GTF_transfer_completed) >>=20 >> @@ -228,17 +282,17 @@ struct grant_entry_header { >> }; >> typedef struct grant_entry_header grant_entry_header_t; >>=20 >> -/* >> +/** >> * Version 2 of the grant entry structure. >> */ >> union grant_entry_v2 { >> grant_entry_header_t hdr; >>=20 >> - /* >> + /** >> * This member is used for V1-style full page grants, where either: >> * >> - * -- hdr.type is GTF_accept_transfer, or >> - * -- hdr.type is GTF_permit_access and GTF_sub_page is not set. >> + * * hdr.type is GTF_accept_transfer, or >> + * * hdr.type is GTF_permit_access and GTF_sub_page is not set. >> * >> * In that case, the frame field has the same semantics as the >> * field of the same name in the V1 entry structure. >> @@ -249,10 +303,10 @@ union grant_entry_v2 { >> uint64_t frame; >> } full_page; >>=20 >> - /* >> + /** >> * If the grant type is GTF_grant_access and GTF_sub_page is set, >> - * @domid is allowed to access bytes [@page_off,@page_off+@length) >> - * in frame @frame. >> + * \@domid is allowed to access bytes [\@page_off,\@page_off+\@leng= th) >> + * in frame \@frame. >> */ >> struct { >> grant_entry_header_t hdr; >> @@ -261,9 +315,9 @@ union grant_entry_v2 { >> uint64_t frame; >> } sub_page; >>=20 >> - /* >> - * If the grant is GTF_transitive, @domid is allowed to use the >> - * grant @gref in domain @trans_domid, as if it was the local >> + /** >> + * If the grant is GTF_transitive, \@domid is allowed to use the >> + * grant \@gref in domain \@trans_domid, as if it was the local >> * domain. Obviously, the transitive access must be compatible >> * with the original grant. >> * >> @@ -277,7 +331,7 @@ union grant_entry_v2 { >> grant_ref_t gref; >> } transitive; >>=20 >> - uint32_t __spacer[4]; /* Pad to a power of two */ >> + uint32_t __spacer[4]; /**< Pad to a power of two */ >> }; >> typedef union grant_entry_v2 grant_entry_v2_t; >>=20 >> @@ -317,24 +371,25 @@ typedef uint16_t grant_status_t; >> #endif /* __XEN_INTERFACE_VERSION__ */ >> /* ` } */ >>=20 >> -/* >> +/** >> * Handle to track a mapping created via a grant reference. >> */ >> typedef uint32_t grant_handle_t; >>=20 >> -/* >> - * GNTTABOP_map_grant_ref: Map the grant entry (,) for access >> - * by devices and/or host CPUs. If successful, is a tracking n= umber >> - * that must be presented later to destroy the mapping(s). On error, >> +/** >> + * GNTTABOP_map_grant_ref: Map the grant entry (\@dom,\@ref) for access >> + * by devices and/or host CPUs. If successful, \@handle is a tracking n= umber >> + * that must be presented later to destroy the mapping(s). On error, \@= status >> * is a negative status code. >> + * >> * NOTES: >> - * 1. If GNTMAP_device_map is specified then is the add= ress >> + * 1. If GNTMAP_device_map is specified then \@dev_bus_addr is the add= ress >> * via which I/O devices may access the granted frame. >> * 2. If GNTMAP_host_map is specified then a mapping will be added at >> * either a host virtual address in the current address space, or at >> * a PTE at the specified machine address. The type of mapping to >> * perform is selected through the GNTMAP_contains_pte flag, and the >> - * address is specified in . >> + * address is specified in \@host_addr. >> * 3. Mappings should only be destroyed via GNTTABOP_unmap_grant_ref. I= f a >> * host mapping is destroyed by other means then it is *NOT* guarant= eed >> * to be accounted to the correct grant reference! >> @@ -342,25 +397,26 @@ typedef uint32_t grant_handle_t; >> struct gnttab_map_grant_ref { >> /* IN parameters. */ >> uint64_t host_addr; >> - uint32_t flags; /* GNTMAP_* */ >> + uint32_t flags; /**< GNTMAP_* */ >> grant_ref_t ref; >> domid_t dom; >> /* OUT parameters. */ >> - int16_t status; /* =3D> enum grant_status */ >> + int16_t status; /**< GNTST_* status code */ >> grant_handle_t handle; >> uint64_t dev_bus_addr; >> }; >> typedef struct gnttab_map_grant_ref gnttab_map_grant_ref_t; >> DEFINE_XEN_GUEST_HANDLE(gnttab_map_grant_ref_t); >>=20 >> -/* >> +/** >> * GNTTABOP_unmap_grant_ref: Destroy one or more grant-reference mapping= s >> - * tracked by . If or is zero, that >> + * tracked by \@handle. If \@host_addr or \@dev_bus_addr is zero, that >> * field is ignored. If non-zero, they must refer to a device/host mappi= ng >> - * that is tracked by >> + * that is tracked by \@handle >> + * >> * NOTES: >> * 1. The call may fail in an undefined manner if either mapping is not >> - * tracked by . >> + * tracked by \@handle. >> * 3. After executing a batch of unmaps, it is guaranteed that no stale >> * mappings will remain in the device or host TLBs. >> */ >> @@ -370,18 +426,19 @@ struct gnttab_unmap_grant_ref { >> uint64_t dev_bus_addr; >> grant_handle_t handle; >> /* OUT parameters. */ >> - int16_t status; /* =3D> enum grant_status */ >> + int16_t status; /**< GNTST_* status code */ >> }; >> typedef struct gnttab_unmap_grant_ref gnttab_unmap_grant_ref_t; >> DEFINE_XEN_GUEST_HANDLE(gnttab_unmap_grant_ref_t); >>=20 >> -/* >> - * GNTTABOP_setup_table: Set up a grant table for comprising at l= east >> - * pages. The frame addresses are written to the . >> - * Only addresses are written, even if the table is larger. >> +/** >> + * GNTTABOP_setup_table: Set up a grant table for \@dom comprising at l= east >> + * \@nr_frames pages. The frame addresses are written to the \@frame_li= st. >> + * Only \@nr_frames addresses are written, even if the table is larger. >> + * >> * NOTES: >> - * 1. may be specified as DOMID_SELF. >> - * 2. Only a sufficiently-privileged domain may specify !=3D DOM= ID_SELF. >> + * 1. \@dom may be specified as DOMID_SELF. >> + * 2. Only a sufficiently-privileged domain may specify \@dom !=3D DOM= ID_SELF. >> * 3. Xen may not support more than a single grant-table page per domai= n. >> */ >> struct gnttab_setup_table { >> @@ -389,7 +446,7 @@ struct gnttab_setup_table { >> domid_t dom; >> uint32_t nr_frames; >> /* OUT parameters. */ >> - int16_t status; /* =3D> enum grant_status */ >> + int16_t status; /**< GNTST_* status code */ >> #if __XEN_INTERFACE_VERSION__ < 0x00040300 >> XEN_GUEST_HANDLE(ulong) frame_list; >> #else >> @@ -399,7 +456,7 @@ struct gnttab_setup_table { >> typedef struct gnttab_setup_table gnttab_setup_table_t; >> DEFINE_XEN_GUEST_HANDLE(gnttab_setup_table_t); >>=20 >> -/* >> +/** >> * GNTTABOP_dump_table: Dump the contents of the grant table to the >> * xen console. Debugging use only. >> */ >> @@ -407,14 +464,14 @@ struct gnttab_dump_table { >> /* IN parameters. */ >> domid_t dom; >> /* OUT parameters. */ >> - int16_t status; /* =3D> enum grant_status */ >> + int16_t status; /**< GNTST_* status code */ >> }; >> typedef struct gnttab_dump_table gnttab_dump_table_t; >> DEFINE_XEN_GUEST_HANDLE(gnttab_dump_table_t); >>=20 >> -/* >> - * GNTTABOP_transfer: Transfer to a foreign domain. The foreign= domain >> - * has previously registered its interest in the transfer via . >> +/** >> + * GNTTABOP_transfer: Transfer \@frame to a foreign domain. The foreign= domain >> + * has previously registered its interest in the transfer via \@domid, = \@ref. >> * >> * Note that, even if the transfer fails, the specified page no longer b= elongs >> * to the calling domain *unless* the error is GNTST_bad_page. >> @@ -427,13 +484,13 @@ struct gnttab_transfer { >> domid_t domid; >> grant_ref_t ref; >> /* OUT parameters. */ >> - int16_t status; >> + int16_t status; /**< GNTST_* status code */ >> }; >> typedef struct gnttab_transfer gnttab_transfer_t; >> DEFINE_XEN_GUEST_HANDLE(gnttab_transfer_t); >>=20 >>=20 >> -/* >> +/** >> * GNTTABOP_copy: Hypervisor based copy >> * source and destinations can be eithers MFNs or, for foreign domains, >> * grant references. the foreign domain has to grant read/write access >> @@ -451,11 +508,6 @@ DEFINE_XEN_GUEST_HANDLE(gnttab_transfer_t); >> * bytes to be copied. >> */ >>=20 >> -#define _GNTCOPY_source_gref (0) >> -#define GNTCOPY_source_gref (1<<_GNTCOPY_source_gref) >> -#define _GNTCOPY_dest_gref (1) >> -#define GNTCOPY_dest_gref (1<<_GNTCOPY_dest_gref) >> - >> struct gnttab_copy { >> /* IN parameters. */ >> struct gnttab_copy_ptr { >> @@ -467,19 +519,24 @@ struct gnttab_copy { >> uint16_t offset; >> } source, dest; >> uint16_t len; >> - uint16_t flags; /* GNTCOPY_* */ >> + uint16_t flags; /**< GNTCOPY_* */ >> +#define _GNTCOPY_source_gref (0) >> +#define GNTCOPY_source_gref (1<<_GNTCOPY_source_gref) >> +#define _GNTCOPY_dest_gref (1) >> +#define GNTCOPY_dest_gref (1<<_GNTCOPY_dest_gref) >> /* OUT parameters. */ >> int16_t status; >> }; >> typedef struct gnttab_copy gnttab_copy_t; >> DEFINE_XEN_GUEST_HANDLE(gnttab_copy_t); >>=20 >> -/* >> +/** >> * GNTTABOP_query_size: Query the current and maximum sizes of the share= d >> * grant table. >> + * >> * NOTES: >> - * 1. may be specified as DOMID_SELF. >> - * 2. Only a sufficiently-privileged domain may specify !=3D DOM= ID_SELF. >> + * 1. \@dom may be specified as DOMID_SELF. >> + * 2. Only a sufficiently-privileged domain may specify \@dom !=3D DOM= ID_SELF. >> */ >> struct gnttab_query_size { >> /* IN parameters. */ >> @@ -487,19 +544,20 @@ struct gnttab_query_size { >> /* OUT parameters. */ >> uint32_t nr_frames; >> uint32_t max_nr_frames; >> - int16_t status; /* =3D> enum grant_status */ >> + int16_t status; /**< GNTST_* status code */ >> }; >> typedef struct gnttab_query_size gnttab_query_size_t; >> DEFINE_XEN_GUEST_HANDLE(gnttab_query_size_t); >>=20 >> -/* >> +/** >> * GNTTABOP_unmap_and_replace: Destroy one or more grant-reference mappi= ngs >> - * tracked by but atomically replace the page table entry with= one >> - * pointing to the machine address under . will b= e >> + * tracked by \@handle but atomically replace the page table entry with= one >> + * pointing to the machine address under \@new_addr. \@new_addr will be >> * redirected to the null entry. >> + * >> * NOTES: >> * 1. The call may fail in an undefined manner if either mapping is not >> - * tracked by . >> + * tracked by \@handle. >> * 2. After executing a batch of unmaps, it is guaranteed that no stale >> * mappings will remain in the device or host TLBs. >> */ >> @@ -509,13 +567,13 @@ struct gnttab_unmap_and_replace { >> uint64_t new_addr; >> grant_handle_t handle; >> /* OUT parameters. */ >> - int16_t status; /* =3D> enum grant_status */ >> + int16_t status; /**< GNTST_* status code */ >> }; >> typedef struct gnttab_unmap_and_replace gnttab_unmap_and_replace_t; >> DEFINE_XEN_GUEST_HANDLE(gnttab_unmap_and_replace_t); >>=20 >> #if __XEN_INTERFACE_VERSION__ >=3D 0x0003020a >> -/* >> +/** >> * GNTTABOP_set_version: Request a particular version of the grant >> * table shared table structure. This operation may be used to toggle >> * between different versions, but must be performed while no grants >> @@ -529,32 +587,33 @@ typedef struct gnttab_set_version gnttab_set_versi= on_t; >> DEFINE_XEN_GUEST_HANDLE(gnttab_set_version_t); >>=20 >>=20 >> -/* >> +/** >> * GNTTABOP_get_status_frames: Get the list of frames used to store gran= t >> - * status for . In grant format version 2, the status is separated >> + * status for \@dom. In grant format version 2, the status is separated >> * from the other shared grant fields to allow more efficient synchroniz= ation >> * using barriers instead of atomic cmpexch operations. >> - * specify the size of vector . >> - * The frame addresses are returned in the . >> - * Only addresses are returned, even if the table is larger= . >> + * \@nr_frames specify the size of vector \@frame_list. >> + * The frame addresses are returned in the \@frame_list. >> + * Only \@nr_frames addresses are returned, even if the table is larger= . >> + * >> * NOTES: >> - * 1. may be specified as DOMID_SELF. >> - * 2. Only a sufficiently-privileged domain may specify !=3D DOM= ID_SELF. >> + * 1. \@dom may be specified as DOMID_SELF. >> + * 2. Only a sufficiently-privileged domain may specify \@dom !=3D DOM= ID_SELF. >> */ >> struct gnttab_get_status_frames { >> /* IN parameters. */ >> uint32_t nr_frames; >> domid_t dom; >> /* OUT parameters. */ >> - int16_t status; /* =3D> enum grant_status */ >> + int16_t status; /**< GNTST_* status code */ >> XEN_GUEST_HANDLE(uint64_t) frame_list; >> }; >> typedef struct gnttab_get_status_frames gnttab_get_status_frames_t; >> DEFINE_XEN_GUEST_HANDLE(gnttab_get_status_frames_t); >>=20 >> -/* >> +/** >> * GNTTABOP_get_version: Get the grant table version which is in >> - * effect for domain . >> + * effect for domain \@dom. >> */ >> struct gnttab_get_version { >> /* IN parameters */ >> @@ -566,7 +625,7 @@ struct gnttab_get_version { >> typedef struct gnttab_get_version gnttab_get_version_t; >> DEFINE_XEN_GUEST_HANDLE(gnttab_get_version_t); >>=20 >> -/* >> +/** >> * GNTTABOP_swap_grant_ref: Swap the contents of two grant entries. >> */ >> struct gnttab_swap_grant_ref { >> @@ -574,12 +633,12 @@ struct gnttab_swap_grant_ref { >> grant_ref_t ref_a; >> grant_ref_t ref_b; >> /* OUT parameters */ >> - int16_t status; /* =3D> enum grant_status */ >> + int16_t status; /**< GNTST_* status code */ >> }; >> typedef struct gnttab_swap_grant_ref gnttab_swap_grant_ref_t; >> DEFINE_XEN_GUEST_HANDLE(gnttab_swap_grant_ref_t); >>=20 >> -/* >> +/** >> * Issue one or more cache maintenance operations on a portion of a >> * page granted to the calling domain by a foreign domain. >> */ >> @@ -588,8 +647,8 @@ struct gnttab_cache_flush { >> uint64_t dev_bus_addr; >> grant_ref_t ref; >> } a; >> - uint16_t offset; /* offset from start of grant */ >> - uint16_t length; /* size within the grant */ >> + uint16_t offset; /**< offset from start of grant */ >> + uint16_t length; /**< size within the grant */ >> #define GNTTAB_CACHE_CLEAN (1u<<0) >> #define GNTTAB_CACHE_INVAL (1u<<1) >> #define GNTTAB_CACHE_SOURCE_GREF (1u<<31) >> @@ -600,40 +659,60 @@ DEFINE_XEN_GUEST_HANDLE(gnttab_cache_flush_t); >>=20 >> #endif /* __XEN_INTERFACE_VERSION__ */ >>=20 >> -/* >> - * Bitfield values for gnttab_map_grant_ref.flags. >> +/** >> + * @def GNTMAP_device_map >> + * Bitfield value for gnttab_map_grant_ref.flags: Map the grant entry f= or >> + * access by I/O devices. >> */ >> - /* Map the grant entry for access by I/O devices. */ >> #define _GNTMAP_device_map (0) >> #define GNTMAP_device_map (1<<_GNTMAP_device_map) >> - /* Map the grant entry for access by host CPUs. */ >> + >> +/** >> + * @def GNTMAP_host_map >> + * Bitfield value for gnttab_map_grant_ref.flags: Map the grant entry f= or >> + * access by host CPUs. >> + */ >> #define _GNTMAP_host_map (1) >> #define GNTMAP_host_map (1<<_GNTMAP_host_map) >> - /* Accesses to the granted frame will be restricted to read-only acces= s. */ >> + >> +/** >> + * @def GNTMAP_readonly >> + * Bitfield value for gnttab_map_grant_ref.flags: Accesses to the grant= ed frame >> + * will be restricted to read-only access. >> + */ >> #define _GNTMAP_readonly (2) >> #define GNTMAP_readonly (1<<_GNTMAP_readonly) >> - /* >> - * GNTMAP_host_map subflag: >> - * 0 =3D> The host mapping is usable only by the guest OS. >> - * 1 =3D> The host mapping is usable by guest OS + current applicatio= n. >> - */ >> + >> +/** >> + * @def GNTMAP_application_map >> + * Bitfield value for gnttab_map_grant_ref.flags. >> + * >> + * GNTMAP_host_map subflag: >> + * * 0 =3D> The host mapping is usable only by the guest OS. >> + * * 1 =3D> The host mapping is usable by guest OS + current applicatio= n. >> + */ >> #define _GNTMAP_application_map (3) >> #define GNTMAP_application_map (1<<_GNTMAP_application_map) >>=20 >> - /* >> - * GNTMAP_contains_pte subflag: >> - * 0 =3D> This map request contains a host virtual address. >> - * 1 =3D> This map request contains the machine addess of the PTE to = update. >> - */ >> +/** >> + * @def GNTMAP_contains_pte >> + * Bitfield value for gnttab_map_grant_ref.flags. >> + * >> + * GNTMAP_contains_pte subflag: >> + * * 0 =3D> This map request contains a host virtual address. >> + * * 1 =3D> This map request contains the machine addess of the PTE to = update. >> + */ >> #define _GNTMAP_contains_pte (4) >> #define GNTMAP_contains_pte (1<<_GNTMAP_contains_pte) >>=20 >> #define _GNTMAP_can_fail (5) >> #define GNTMAP_can_fail (1<<_GNTMAP_can_fail) >>=20 >> -/* >> - * Bits to be placed in guest kernel available PTE bits (architecture >> - * dependent; only supported when XENFEAT_gnttab_map_avail_bits is set)= . >> +/** >> + * @def GNTMAP_guest_avail_mask >> + * Bitfield value for gnttab_map_grant_ref.flags: Bits to be placed in = guest >> + * kernel available PTE bits (architecture dependent; only supported wh= en >> + * XENFEAT_gnttab_map_avail_bits is set). >> */ >> #define _GNTMAP_guest_avail0 (16) >> #define GNTMAP_guest_avail_mask ((uint32_t)~0 << _GNTMAP_guest_avail0) >> @@ -641,21 +720,19 @@ DEFINE_XEN_GUEST_HANDLE(gnttab_cache_flush_t); >> /* >> * Values for error status returns. All errors are -ve. >> */ >> -/* ` enum grant_status { */ >> -#define GNTST_okay (0) /* Normal return. = */ >> -#define GNTST_general_error (-1) /* General undefined error. = */ >> -#define GNTST_bad_domain (-2) /* Unrecognsed domain id. = */ >> -#define GNTST_bad_gntref (-3) /* Unrecognised or inappropriate gn= tref. */ >> -#define GNTST_bad_handle (-4) /* Unrecognised or inappropriate ha= ndle. */ >> -#define GNTST_bad_virt_addr (-5) /* Inappropriate virtual address to= map. */ >> -#define GNTST_bad_dev_addr (-6) /* Inappropriate device address to = unmap.*/ >> -#define GNTST_no_device_space (-7) /* Out of space in I/O MMU. = */ >> -#define GNTST_permission_denied (-8) /* Not enough privilege for operat= ion. */ >> -#define GNTST_bad_page (-9) /* Specified page was invalid for o= p. */ >> -#define GNTST_bad_copy_arg (-10) /* copy arguments cross page bounda= ry. */ >> -#define GNTST_address_too_big (-11) /* transfer page address too large.= */ >> -#define GNTST_eagain (-12) /* Operation not done; try again. = */ >> -/* ` } */ >> +#define GNTST_okay (0) /**< Normal return. = */ >> +#define GNTST_general_error (-1) /**< General undefined error. = */ >> +#define GNTST_bad_domain (-2) /**< Unrecognsed domain id. = */ >> +#define GNTST_bad_gntref (-3) /**< Unrecognised or inappropriate = gntref. */ >> +#define GNTST_bad_handle (-4) /**< Unrecognised or inappropriate = handle. */ >> +#define GNTST_bad_virt_addr (-5) /**< Inappropriate virtual address = to map. */ >> +#define GNTST_bad_dev_addr (-6) /**< Inappropriate device address t= o unmap.*/ >> +#define GNTST_no_device_space (-7) /**< Out of space in I/O MMU. = */ >> +#define GNTST_permission_denied (-8) /**< Not enough privilege for oper= ation. */ >> +#define GNTST_bad_page (-9) /**< Specified page was invalid for= op. */ >> +#define GNTST_bad_copy_arg (-10) /**< copy arguments cross page boun= dary. */ >> +#define GNTST_address_too_big (-11) /**< transfer page address too larg= e. */ >> +#define GNTST_eagain (-12) /**< Operation not done; try again.= */ >>=20 >> #define GNTTABOP_error_msgs { \ >> "okay", \ >> @@ -673,6 +750,10 @@ DEFINE_XEN_GUEST_HANDLE(gnttab_cache_flush_t); >> "operation not done; try again" \ >> } >>=20 >> +/** >> + * @} >> + */ >> + >> #endif /* __XEN_PUBLIC_GRANT_TABLE_H__ */ >>=20 >> /* >> --=20 >> 2.17.1 >>=20 From xen-devel-bounces@lists.xenproject.org Thu Jul 01 14:21:38 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 14:21:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148759.275027 (Exim 4.92) (envelope-from ) id 1lyxZS-0001hQ-FV; Thu, 01 Jul 2021 14:21:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148759.275027; Thu, 01 Jul 2021 14:21:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyxZS-0001hE-As; Thu, 01 Jul 2021 14:21:38 +0000 Received: by outflank-mailman (input) for mailman id 148759; Thu, 01 Jul 2021 14:21:36 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyxRI-0005F9-Nd for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 14:13:12 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 3d926230-da76-11eb-8329-12813bfff9fa; Thu, 01 Jul 2021 14:11:34 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3d926230-da76-11eb-8329-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1625148693; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=/FUmArmLEUIthNAppG6akBLHO3pJX78uJKbRrb4d2EI=; b=P76S3OAdIgeozLRn43x2LzFcy8Ykwb3pT6tREUw+i1f1TRhCXgKi11FT luKAOnUWzXjeZjs2QbBcF45Gxdk/ZSL7b9+Lfw/E6OkUHp8uObbADquIh jx7vDYEbB09TYP9Uu1IyVSWGRHdnwGDDR44OJm47lkvi2ZQvyxW03rukc o=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: D09gFO1M0EXikMGbZhcoxD0O0fKSoGY0TXjcb8GYPlxlc7KacMjEeVYluQbadkrpN2DOgsrbKo kL7I5nHQgmOEPSmDh+o9f87QkmVlDS7u0Q0vLW8ZTpt41vNJI9eMyqhzF5PY63z94yrlb+81/z +WBED6UtQSVx+LZf/CMufdk+sCJSLL6IUdlieCOvKpBKM/UfDhxp8rGaAYCc1ttHDOouiD/33r 6GXm+WARdUc7qI+zzKkwBOiChCl1glM4g44nIXHQ2ppr1+4dASBCq1HcN2Ncz2Bt93f387BIzM 5Oo= X-SBRS: 5.1 X-MesageID: 47755478 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:amjLI675VHwyieoSTwPXwM7XdLJyesId70hD6qhwISY7TiX+rb HIoB17726MtN9/YhAdcLy7VZVoBEmsl6KdgrNhWYtKPjOHhILAFugLhuHfKn/bakjDH4ZmpM FdmsNFZuEYY2IXsS+D2njaL+od X-IronPort-AV: E=Sophos;i="5.83,314,1616472000"; d="scan'208";a="47755478" From: Anthony PERARD To: CC: Anthony PERARD , Andrew Cooper , George Dunlap , "Ian Jackson" , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [XEN PATCH v6 26/31] build: clean common temporary files from root makefile Date: Thu, 1 Jul 2021 15:10:06 +0100 Message-ID: <20210701141011.785641-27-anthony.perard@citrix.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210701141011.785641-1-anthony.perard@citrix.com> References: <20210701141011.785641-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Signed-off-by: Anthony PERARD --- xen/Makefile | 1 + xen/scripts/Makefile.clean | 2 -- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/xen/Makefile b/xen/Makefile index fd002ecd52d0..6aac68750b4d 100644 --- a/xen/Makefile +++ b/xen/Makefile @@ -378,6 +378,7 @@ _clean: $(MAKE) $(clean) test $(MAKE) $(kconfig) clean find . \( -name "*.o" -o -name ".*.d" -o -name ".*.d2" \ + -o -name ".*.o.tmp" -o -name "*~" -o -name "core" \ -o -name "*.gcno" -o -name ".*.cmd" -o -name "lib.a" \) -exec rm -f {} \; rm -f include/asm $(TARGET) $(TARGET).gz $(TARGET).efi $(TARGET).efi.map $(TARGET)-syms $(TARGET)-syms.map *~ core rm -f asm-offsets.s include/arch-*/asm/asm-offsets.h diff --git a/xen/scripts/Makefile.clean b/xen/scripts/Makefile.clean index 027c200c0efc..b6df9e861e6e 100644 --- a/xen/scripts/Makefile.clean +++ b/xen/scripts/Makefile.clean @@ -14,10 +14,8 @@ include Makefile subdir-all := $(subdir-y) $(subdir-n) $(subdir-) \ $(patsubst %/,%, $(filter %/, $(obj-y) $(obj-n) $(obj-))) -DEPS_RM = $(DEPS) $(DEPS_INCLUDE) .PHONY: clean clean:: $(subdir-all) - rm -f *.o .*.o.tmp *~ core $(DEPS_RM) # Descending # --------------------------------------------------------------------------- -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Thu Jul 01 14:21:40 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 14:21:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148771.275037 (Exim 4.92) (envelope-from ) id 1lyxZU-0001zi-NN; Thu, 01 Jul 2021 14:21:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148771.275037; Thu, 01 Jul 2021 14:21:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyxZU-0001zW-Jj; Thu, 01 Jul 2021 14:21:40 +0000 Received: by outflank-mailman (input) for mailman id 148771; Thu, 01 Jul 2021 14:21:38 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyxQU-0005F9-Lo for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 14:12:22 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 2de16752-da76-11eb-8328-12813bfff9fa; Thu, 01 Jul 2021 14:11:08 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2de16752-da76-11eb-8328-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1625148668; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=TiF+907ZnxR32g7xJeKX/Svu6O0iCgKs/yul2z4hMQ4=; b=CBuk5V9VccZamEJRTJymR4scMjHj2aHBEGnBFK1CV3SwhGe0CVVlznaM tMnVBtp6UQQsOx+sDgA9tjRz2JlIbGmQPggyF4+gN02Z0gcZ5eaKE2gEH 4bF2bG3KIZ+OLNmOPk+dTNHF61ZToPFEWpRHpcnLhB+vgslUUaAv5Azgv E=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: u+Xbk3Z39cB6nUXv0SAaMfHYUNdz/kdlSAuw+iemQtkxF3Ev3vKIJ+Vo9jqvmoOcBa2Oc1nFm3 sT/lZFhcqIxiIorpvbR3mvcEpzOB2seiMC8tD0yCU91aLbxCZGxHWBk1H30yQIpD1V4TgYJBuR NF58oOEGPFNOzEMMezFevA2hGyGi0okItpnwQtabOKIkSkKjomxpXK3BTsz/6jvhyC0HEW3qXK Zo3JAsMo6+8Zeb1nSaICus+kpeVysCAdZ+lvpCEFADZQ4ubiI7OfBl497DXr4EYmwY7uTG30Hm y4I= X-SBRS: 5.1 X-MesageID: 47093433 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:DOVDqq1EypBCfQJyd5Ir0AqjBHYkLtp133Aq2lEZdPU0SKGlfq GV7ZEmPHrP4gr5N0tOpTntAse9qBDnhPxICOsqXYtKNTOO0AeVxelZhrcKqAeQeBEWmNQ96U 9hGZIOcuEZDzJB/LvHCN/TKadd/DGFmprY+ts31x1WPGVXgzkL1XYANu6ceHcGIzVuNN4CO7 e3wNFInDakcWR/VLXBOpFUN9KzweEijfjdEGc7OyI= X-IronPort-AV: E=Sophos;i="5.83,314,1616472000"; d="scan'208";a="47093433" From: Anthony PERARD To: CC: Anthony PERARD , Andrew Cooper , George Dunlap , "Ian Jackson" , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Volodymyr Babchuk , Bob Eshleman , Alistair Francis , Connor Davis , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Konrad Rzeszutek Wilk , "Ross Lagerwall" , Daniel De Graaf , "Daniel P. Smith" Subject: [XEN PATCH v6 29/31] build: build everything from the root dir, use obj=$subdir Date: Thu, 1 Jul 2021 15:10:09 +0100 Message-ID: <20210701141011.785641-30-anthony.perard@citrix.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210701141011.785641-1-anthony.perard@citrix.com> References: <20210701141011.785641-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain A subdirectory is now built by setting "$(obj)" instead of changing directory. "$(obj)" should always be set when using "Rules.mk" and thus a shortcut "$(build)" is introduced and should be used. A new variable "$(need-builtin)" is introduce. It is to be used whenever a "built_in.o" is wanted from a subdirectory. "built_in.o" isn't the main target anymore, and thus only needs to depends on the objects that should be part of "built_in.o". Introduce $(srctree) and $(objtree) to replace $(BASEDIR) in cases a relative path is better. DEPS is updated as the existing macro to deal with it doesn't know about $(obj). There's some changes in "Rules.mk" which in addition to deal with "$(obj)" also make it's looks more like "Makefile.build" from Linux v5.12. test/Makefile doesn't need special handling in order to build everything under test/, Rules.mk will visit test/livepatch via $(subdir-y), thus "tests" "all" and "build" target are removed. "subtree-force-update" target isn't useful so it is removed as well. test/livepatch/Makefile doesn't need default target anymore, Rules.mk will build everything in $(extra-y) and thus all *.livepatch. Signed-off-by: Anthony PERARD --- xen/Makefile | 46 ++++++++----- xen/Rules.mk | 131 +++++++++++++++++++++++------------- xen/arch/arm/Makefile | 4 +- xen/arch/arm/arch.mk | 4 +- xen/arch/riscv/arch.mk | 3 +- xen/arch/x86/Makefile | 13 ++-- xen/arch/x86/Rules.mk | 4 +- xen/arch/x86/arch.mk | 10 +-- xen/arch/x86/boot/Makefile | 8 +-- xen/include/Makefile | 6 +- xen/scripts/Kbuild.include | 6 ++ xen/test/Makefile | 7 +- xen/test/livepatch/Makefile | 6 -- xen/xsm/flask/Makefile | 2 +- xen/xsm/flask/ss/Makefile | 2 +- 15 files changed, 151 insertions(+), 101 deletions(-) diff --git a/xen/Makefile b/xen/Makefile index 6aac68750b4d..71f098cd6374 100644 --- a/xen/Makefile +++ b/xen/Makefile @@ -20,6 +20,10 @@ export PYTHON ?= $(PYTHON_INTERPRETER) export BASEDIR := $(CURDIR) export XEN_ROOT := $(BASEDIR)/.. +srctree := . +objtree := . +export srctree objtree + # Do not use make's built-in rules and variables MAKEFLAGS += -rR @@ -234,7 +238,7 @@ endif CFLAGS += -nostdinc -fno-builtin -fno-common CFLAGS += -Werror -Wredundant-decls -Wno-pointer-arith $(call cc-option-add,CFLAGS,CC,-Wvla) -CFLAGS += -pipe -D__XEN__ -include $(BASEDIR)/include/xen/config.h +CFLAGS += -pipe -D__XEN__ -include $(objtree)/include/xen/config.h CFLAGS-$(CONFIG_DEBUG_INFO) += -g ifneq ($(CONFIG_CC_IS_CLANG),y) @@ -295,7 +299,7 @@ endif # need-config .PHONY: build install uninstall clean distclean MAP build install uninstall debug clean distclean MAP:: ifneq ($(XEN_TARGET_ARCH),x86_32) - $(MAKE) -f Rules.mk _$@ + $(MAKE) $(build)=. _$@ else echo "*** Xen x86/32 target no longer supported!" endif @@ -335,10 +339,10 @@ _install: $(TARGET)$(CONFIG_XEN_INSTALL_SUFFIX) .PHONY: tests tests: - $(MAKE) -f $(BASEDIR)/Rules.mk -C test tests + $(MAKE) $(build)=test .PHONY: install-tests install-tests: - $(MAKE) -f $(BASEDIR)/Rules.mk -C test install + $(MAKE) $(build)=test install .PHONY: _uninstall _uninstall: D=$(DESTDIR) @@ -395,23 +399,26 @@ $(TARGET).gz: $(TARGET) PHONY += prepare prepare: $(MAKE) -C tools - $(MAKE) -f $(BASEDIR)/Rules.mk include/xen/compile.h + $(MAKE) $(build)=. include/xen/compile.h [ -e arch/$(TARGET_ARCH)/efi ] && for f in $$(cd common/efi; echo *.[ch]); \ do test -r arch/$(TARGET_ARCH)/efi/$$f || \ ln -nsf ../../../common/efi/$$f arch/$(TARGET_ARCH)/efi/; \ done; \ true - $(MAKE) -f $(BASEDIR)/Rules.mk -C include - $(MAKE) -f $(BASEDIR)/Rules.mk -C arch/$(TARGET_ARCH) include - $(MAKE) -f $(BASEDIR)/Rules.mk include/arch-$(TARGET_ARCH)/asm/asm-offsets.h + $(MAKE) $(build)=include all + $(MAKE) $(build)=arch/$(TARGET_ARCH) include + $(MAKE) $(build)=. include/arch-$(TARGET_ARCH)/asm/asm-offsets.h + +# The actual objects are generated when descending, +# make sure no implicit rule kicks in +$(sort $(ALL_OBJS) $(ALL_LIBS)): descend ; -$(ALL_OBJS) $(ALL_LIBS): prepare +build-dirs := $(patsubst %/built_in.o,%,$(filter %/built_in.o,$(ALL_OBJS) $(ALL_LIBS))) -# head.o is built by descending into arch/arm/$(TARGET_SUBARCH), depends on the -# part of $(ALL_OBJS) that will eventually recurse into $(TARGET_SUBARCH)/ and -# build head.o -arch/arm/$(TARGET_SUBARCH)/head.o: arch/arm/built_in.o -arch/arm/$(TARGET_SUBARCH)/head.o: ; +PHONY += descend $(build-dirs) +descend: $(build-dirs) +$(build-dirs): prepare + $(MAKE) $(build)=$@ need-builtin=1 ifeq ($(CONFIG_LTO),y) # Gather all LTO objects together @@ -429,7 +436,7 @@ endif targets += prelink.o $(TARGET): prelink.o FORCE - $(MAKE) -f $(BASEDIR)/Rules.mk -C arch/$(TARGET_ARCH) $@ + $(MAKE) $(build)=arch/$(TARGET_ARCH) $@ quiet_cmd_banner = BANNER $@ define cmd_banner @@ -533,14 +540,17 @@ cscope: _MAP: $(NM) -n $(TARGET)-syms | grep -v '\(compiled\)\|\(\.o$$\)\|\( [aUw] \)\|\(\.\.ng$$\)\|\(LASH[RL]DI\)' > System.map +# Avoid those single target rules when Makefile is included by Rules.mk +ifndef obj %.o %.i %.s: %.c FORCE - $(MAKE) -f $(BASEDIR)/Rules.mk -C $(*D) $(@F) + $(MAKE) $(build)=$(*D) $(*D)/$(@F) %.o %.s: %.S FORCE - $(MAKE) -f $(BASEDIR)/Rules.mk -C $(*D) $(@F) + $(MAKE) $(build)=$(*D) $(*D)/$(@F) %/: FORCE - $(MAKE) -f $(BASEDIR)/Rules.mk -C $* built_in.o built_in_bin.o + $(MAKE) $(build)=$* need-builtin=1 +endif .PHONY: cloc cloc: diff --git a/xen/Rules.mk b/xen/Rules.mk index 0f8d90844455..4b3abf0ea880 100644 --- a/xen/Rules.mk +++ b/xen/Rules.mk @@ -3,20 +3,27 @@ # Makefile and are consumed by Rules.mk # -obj := . src := $(obj) +PHONY := __build +__build: + -include $(BASEDIR)/include/config/auto.conf include $(XEN_ROOT)/Config.mk include $(BASEDIR)/scripts/Kbuild.include +ifndef obj +$(warning kbuild: Makefile.build is included improperly) +endif -TARGET := $(BASEDIR)/xen +TARGET := xen # Initialise some variables +obj-y := lib-y := targets := +subdir-y := CFLAGS-y := AFLAGS-y := @@ -47,27 +54,52 @@ cmd_ar = rm -f $@; $(AR) cr $@ $(real-prereqs) quiet_cmd_objcopy = OBJCOPY $@ cmd_objcopy = $(OBJCOPY) $(OBJCOPYFLAGS) $< $@ -define gendep - ifneq ($(1),$(subst /,:,$(1))) - DEPS += $(dir $(1)).$(notdir $(1)).d - endif -endef -$(foreach o,$(filter-out %/,$(obj-y) $(obj-bin-y) $(extra-y)),$(eval $(call gendep,$(o)))) +# Figure out what we need to build from the various variables +# =========================================================================== + +# Libraries are always collected in one lib file. +# Filter out objects already built-in +lib-y := $(filter-out $(obj-y), $(sort $(lib-y))) + +# Subdirectories we need to descend into +subdir-y := $(subdir-y) $(patsubst %/,%,$(filter %/, $(obj-y))) # Handle objects in subdirs -# --------------------------------------------------------------------------- -# o if we encounter foo/ in $(obj-y), replace it by foo/built_in.o -# and add the directory to the list of dirs to descend into: $(subdir-y) -subdir-y := $(subdir-y) $(filter %/, $(obj-y)) +# - if we encounter foo/ in $(obj-y), replace it by foo/built_in.o +ifdef need-builtin obj-y := $(patsubst %/, %/built_in.o, $(obj-y)) +else +obj-y := $(filter-out %/, $(obj-y)) +endif -# $(subdir-obj-y) is the list of objects in $(obj-y) which uses dir/ to -# tell kbuild to descend -subdir-obj-y := $(filter %/built_in.o, $(obj-y)) +# Add subdir path -# Libraries are always collected in one lib file. -# Filter out objects already built-in -lib-y := $(filter-out $(obj-y), $(sort $(lib-y))) +extra-y := $(addprefix $(obj)/,$(extra-y)) +targets := $(addprefix $(obj)/,$(targets)) +lib-y := $(addprefix $(obj)/,$(lib-y)) +obj-y := $(addprefix $(obj)/,$(obj-y)) +obj-bin-y := $(addprefix $(obj)/,$(obj-bin-y)) +subdir-y := $(addprefix $(obj)/,$(subdir-y)) + +# subdir-builtin may contain duplications. Use $(sort ...) +subdir-builtin := $(sort $(filter %/built_in.o, $(obj-y))) + +targets-for-builtin := $(extra-y) + +ifneq ($(strip $(lib-y)),) + targets-for-builtin += $(obj)/lib.a +endif + +ifdef need-builtin + targets-for-builtin += $(obj)/built_in.o + ifneq ($(strip $(obj-bin-y)),) + ifeq ($(CONFIG_LTO),y) + targets-for-builtin += $(obj)/built_in_bin.o + endif + endif +endif + +targets += $(targets-for-builtin) $(filter %.init.o,$(obj-y) $(obj-bin-y) $(extra-y)): CFLAGS-y += -DINIT_SECTIONS_ONLY @@ -119,29 +151,28 @@ quiet_cmd_cc_builtin = LD $@ cmd_cc_builtin = \ $(CC) $(XEN_CFLAGS) -c -x c /dev/null -o $@ +# To build objects in subdirs, we need to descend into the directories +$(subdir-builtin): $(obj)/%/built_in.o: $(obj)/% ; + quiet_cmd_ld_builtin = LD $@ ifeq ($(CONFIG_LTO),y) cmd_ld_builtin = \ - $(LD_LTO) -r -o $@ $(filter $(obj-y),$(real-prereqs)) + $(LD_LTO) -r -o $@ $(real-prereqs) else cmd_ld_builtin = \ - $(LD) $(XEN_LDFLAGS) -r -o $@ $(filter $(obj-y),$(real-prereqs)) + $(LD) $(XEN_LDFLAGS) -r -o $@ $(real-prereqs) endif -built_in.o: $(obj-y) $(if $(strip $(lib-y)),lib.a) $(extra-y) FORCE +$(obj)/built_in.o: $(obj-y) FORCE $(call if_changed,$(if $(strip $(obj-y)),ld_builtin,cc_builtin)) -lib.a: $(lib-y) FORCE +$(obj)/lib.a: $(lib-y) FORCE $(call if_changed,ar) -targets += built_in.o -ifneq ($(strip $(lib-y)),) -targets += lib.a -endif -targets += $(filter-out $(subdir-obj-y), $(obj-y) $(lib-y)) $(extra-y) -targets += $(MAKECMDGOALS) +targets += $(filter-out $(subdir-builtin), $(obj-y)) +targets += $(lib-y) $(MAKECMDGOALS) -built_in_bin.o: $(obj-bin-y) $(extra-y) +$(obj)/built_in_bin.o: $(obj-bin-y) ifeq ($(strip $(obj-bin-y)),) $(CC) $(a_flags) -c -x assembler /dev/null -o $@ else @@ -152,21 +183,13 @@ endif PHONY += FORCE FORCE: -%/built_in.o %/lib.a: FORCE - $(MAKE) -f $(BASEDIR)/Rules.mk -C $* built_in.o - -%/built_in_bin.o: FORCE - $(MAKE) -f $(BASEDIR)/Rules.mk -C $* built_in_bin.o - -SRCPATH := $(patsubst $(BASEDIR)/%,%,$(CURDIR)) - quiet_cmd_cc_o_c = CC $@ ifeq ($(CONFIG_ENFORCE_UNIQUE_SYMBOLS),y) cmd_cc_o_c = $(CC) $(c_flags) -c $< -o $(dot-target).tmp -MQ $@ ifeq ($(CONFIG_CC_IS_CLANG),y) - cmd_objcopy_fix_sym = $(OBJCOPY) --redefine-sym $<=$(SRCPATH)/$< $(dot-target).tmp $@ + cmd_objcopy_fix_sym = $(OBJCOPY) --redefine-sym $( .lds quiet_cmd_cpp_lds_S = LDS $@ cmd_cpp_lds_S = $(CPP) -P $(call cpp_flags,$(a_flags)) -D__LINKER__ -MQ $@ -o $@ $< +targets := $(filter-out $(PHONY), $(targets)) + # Add intermediate targets: # When building objects with specific suffix patterns, add intermediate # targets that the final targets are derived from. @@ -236,7 +261,18 @@ intermediate_targets = $(foreach sfx, $(2), \ # %.init.o <- %.o targets += $(call intermediate_targets, .init.o, .o) --include $(DEPS_INCLUDE) +# Build +# --------------------------------------------------------------------------- + +__build: $(targets-for-builtin) $(subdir-y) + @: + +# Descending +# --------------------------------------------------------------------------- + +PHONY += $(subdir-y) +$(subdir-y): + $(Q)$(MAKE) $(build)=$@ need-builtin=$(if $(filter $@/built_in.o, $(subdir-builtin)),1) # Read all saved command lines and dependencies for the $(targets) we # may be building above, using $(if_changed{,_dep}). As an @@ -247,6 +283,9 @@ existing-targets := $(wildcard $(sort $(targets))) -include $(foreach f,$(existing-targets),$(dir $(f)).$(notdir $(f)).cmd) +DEPS:= $(foreach f,$(existing-targets),$(dir $(f)).$(notdir $(f)).d) +-include $(DEPS_INCLUDE) + # Declare the contents of the PHONY variable as phony. We keep that # information in a variable so we can use it in if_changed and friends. .PHONY: $(PHONY) diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile index 9f9c73aa6c5d..a3204d22d17b 100644 --- a/xen/arch/arm/Makefile +++ b/xen/arch/arm/Makefile @@ -93,12 +93,12 @@ $(TARGET)-syms: $(BASEDIR)/prelink.o $(obj)/xen.lds $(BASEDIR)/common/symbols-dummy.o -o $(@D)/.$(@F).0 $(NM) -pa --format=sysv $(@D)/.$(@F).0 \ | $(BASEDIR)/tools/symbols $(all_symbols) --sysv --sort >$(@D)/.$(@F).0.S - $(MAKE) -f $(BASEDIR)/Rules.mk $(@D)/.$(@F).0.o + $(MAKE) $(build)=$(@D) $(@D)/.$(@F).0.o $(LD) $(XEN_LDFLAGS) -T $(obj)/xen.lds -N $< \ $(@D)/.$(@F).0.o -o $(@D)/.$(@F).1 $(NM) -pa --format=sysv $(@D)/.$(@F).1 \ | $(BASEDIR)/tools/symbols $(all_symbols) --sysv --sort >$(@D)/.$(@F).1.S - $(MAKE) -f $(BASEDIR)/Rules.mk $(@D)/.$(@F).1.o + $(MAKE) $(build)=$(@D) $(@D)/.$(@F).1.o $(LD) $(XEN_LDFLAGS) -T $(obj)/xen.lds -N $< $(build_id_linker) \ $(@D)/.$(@F).1.o -o $@ $(NM) -pa --format=sysv $(@D)/$(@F) \ diff --git a/xen/arch/arm/arch.mk b/xen/arch/arm/arch.mk index 8a2b202f698e..0a6ae6c2fe60 100644 --- a/xen/arch/arm/arch.mk +++ b/xen/arch/arm/arch.mk @@ -1,8 +1,8 @@ ######################################## # arm-specific definitions -CFLAGS += -I$(BASEDIR)/include -CFLAGS += -I$(BASEDIR)/include/arch-$(TARGET_ARCH) +CFLAGS += -I$(srctree)/include +CFLAGS += -I$(srctree)/include/arch-$(TARGET_ARCH) $(call cc-options-add,CFLAGS,CC,$(EMBEDDED_EXTRA_CFLAGS)) $(call cc-option-add,CFLAGS,CC,-Wnested-externs) diff --git a/xen/arch/riscv/arch.mk b/xen/arch/riscv/arch.mk index 53dadb897591..8aa2206184fa 100644 --- a/xen/arch/riscv/arch.mk +++ b/xen/arch/riscv/arch.mk @@ -11,4 +11,5 @@ riscv-march-$(CONFIG_RISCV_ISA_C) := $(riscv-march-y)c # -mcmodel=medlow would force Xen into the lower half. CFLAGS += -march=$(riscv-march-y) -mstrict-align -mcmodel=medany -CFLAGS += -I$(BASEDIR)/include +CFLAGS += -I$(srctree)/include +CFLAGS += -I$(srctree)/include/arch-$(TARGET_ARCH) diff --git a/xen/arch/x86/Makefile b/xen/arch/x86/Makefile index 2cc67d6e0e84..c5e87f3db35b 100644 --- a/xen/arch/x86/Makefile +++ b/xen/arch/x86/Makefile @@ -81,6 +81,9 @@ endif extra-y += asm-macros.i extra-y += xen.lds +# Allows usercopy.c to includes itself +$(obj)/usercopy.o: CFLAGS-y += -I. + ifneq ($(CONFIG_HVM),y) $(obj)/x86_emulate.o: CFLAGS-y += -Wno-unused-label endif @@ -166,13 +169,13 @@ $(TARGET)-syms: $(BASEDIR)/prelink.o $(obj)/xen.lds $(NM) -pa --format=sysv $(@D)/.$(@F).0 \ | $(BASEDIR)/tools/symbols $(all_symbols) --sysv --sort \ >$(@D)/.$(@F).0.S - $(MAKE) -f $(BASEDIR)/Rules.mk $(@D)/.$(@F).0.o + $(MAKE) $(build)=$(@D) $(@D)/.$(@F).0.o $(LD) $(XEN_LDFLAGS) -T $(obj)/xen.lds -N $< $(build_id_linker) \ $(@D)/.$(@F).0.o -o $(@D)/.$(@F).1 $(NM) -pa --format=sysv $(@D)/.$(@F).1 \ | $(BASEDIR)/tools/symbols $(all_symbols) --sysv --sort $(syms-warn-dup-y) \ >$(@D)/.$(@F).1.S - $(MAKE) -f $(BASEDIR)/Rules.mk $(@D)/.$(@F).1.o + $(MAKE) $(build)=$(@D) $(@D)/.$(@F).1.o $(LD) $(XEN_LDFLAGS) -T $(obj)/xen.lds -N $< $(build_id_linker) \ $(@D)/.$(@F).1.o -o $@ $(NM) -pa --format=sysv $(@D)/$(@F) \ @@ -234,14 +237,14 @@ endif $(MKRELOC) $(foreach base,$(VIRT_BASE) $(ALT_BASE),$(@D)/.$(@F).$(base).0) >$(@D)/.$(@F).0r.S $(NM) -pa --format=sysv $(@D)/.$(@F).$(VIRT_BASE).0 \ | $(BASEDIR)/tools/symbols $(all_symbols) --sysv --sort >$(@D)/.$(@F).0s.S - $(MAKE) -f $(BASEDIR)/Rules.mk $(@D)/.$(@F).0r.o $(@D)/.$(@F).0s.o + $(MAKE) $(build)=$(@D) .$(@F).0r.o .$(@F).0s.o $(foreach base, $(VIRT_BASE) $(ALT_BASE), \ $(LD) $(call EFI_LDFLAGS,$(base)) -T $(obj)/efi.lds -N $< \ $(@D)/.$(@F).0r.o $(@D)/.$(@F).0s.o $(note_file_option) -o $(@D)/.$(@F).$(base).1 &&) : $(MKRELOC) $(foreach base,$(VIRT_BASE) $(ALT_BASE),$(@D)/.$(@F).$(base).1) >$(@D)/.$(@F).1r.S $(NM) -pa --format=sysv $(@D)/.$(@F).$(VIRT_BASE).1 \ | $(BASEDIR)/tools/symbols $(all_symbols) --sysv --sort >$(@D)/.$(@F).1s.S - $(MAKE) -f $(BASEDIR)/Rules.mk $(@D)/.$(@F).1r.o $(@D)/.$(@F).1s.o + $(MAKE) $(build)=$(@D) .$(@F).1r.o .$(@F).1s.o $(LD) $(call EFI_LDFLAGS,$(VIRT_BASE)) -T $(obj)/efi.lds -N $< \ $(@D)/.$(@F).1r.o $(@D)/.$(@F).1s.o $(note_file_option) -o $@ $(NM) -pa --format=sysv $(@D)/$(@F) \ @@ -253,7 +256,7 @@ $(TARGET).efi: FORCE echo '$(if $(filter y,$(XEN_BUILD_EFI)),xen.efi generation,EFI support) disabled' endif -$(obj)/efi/buildid.o $(obj)/efi/relocs-dummy.o: $(BASEDIR)/arch/x86/efi/built_in.o +$(obj)/efi/buildid.o $(obj)/efi/relocs-dummy.o: arch/x86/efi/built_in.o $(obj)/efi/buildid.o $(obj)/efi/relocs-dummy.o: ; .PHONY: include diff --git a/xen/arch/x86/Rules.mk b/xen/arch/x86/Rules.mk index 56fe22c979ea..2d12c2dca208 100644 --- a/xen/arch/x86/Rules.mk +++ b/xen/arch/x86/Rules.mk @@ -2,9 +2,9 @@ # x86-specific definitions ifneq ($(filter -DHAVE_AS_QUOTED_SYM,$(XEN_CFLAGS)),) -object_label_flags = '-D__OBJECT_LABEL__=$(subst $(BASEDIR)/,,$(CURDIR))/$@' +object_label_flags = '-D__OBJECT_LABEL__=$@' else -object_label_flags = '-D__OBJECT_LABEL__=$(subst /,$$,$(subst -,_,$(subst $(BASEDIR)/,,$(CURDIR))/$@))' +object_label_flags = '-D__OBJECT_LABEL__=$(subst /,$$,$(subst -,_,$@))' endif c_flags += $(object_label_flags) $(CFLAGS-stack-boundary) a_flags += $(object_label_flags) $(CFLAGS-stack-boundary) diff --git a/xen/arch/x86/arch.mk b/xen/arch/x86/arch.mk index c95caa303db8..3f181f616188 100644 --- a/xen/arch/x86/arch.mk +++ b/xen/arch/x86/arch.mk @@ -3,10 +3,10 @@ export XEN_IMG_OFFSET := 0x200000 -CFLAGS += -I$(BASEDIR)/include -CFLAGS += -I$(BASEDIR)/include/arch-$(TARGET_ARCH) -CFLAGS += -I$(BASEDIR)/include/arch-x86/asm/mach-generic -CFLAGS += -I$(BASEDIR)/include/arch-x86/asm/mach-default +CFLAGS += -I$(srctree)/include +CFLAGS += -I$(srctree)/include/arch-$(TARGET_ARCH) +CFLAGS += -I$(srctree)/include/arch-x86/asm/mach-generic +CFLAGS += -I$(srctree)/include/arch-x86/asm/mach-default CFLAGS += -DXEN_IMG_OFFSET=$(XEN_IMG_OFFSET) # Prevent floating-point variables from creeping into Xen. @@ -66,6 +66,6 @@ export XEN_BUILD_EFI := $(call try-run,$(CC) $(CFLAGS) -c arch/x86/efi/check.c - endif # Set up the assembler include path properly for older toolchains. -CFLAGS += -Wa,-I$(BASEDIR)/include +CFLAGS += -Wa,-I$(srctree)/include ALL_OBJS-y := arch/x86/boot/built_in.o arch/x86/efi/built_in.o $(ALL_OBJS-y) diff --git a/xen/arch/x86/boot/Makefile b/xen/arch/x86/boot/Makefile index 53d357489df2..2469ca7c4530 100644 --- a/xen/arch/x86/boot/Makefile +++ b/xen/arch/x86/boot/Makefile @@ -1,8 +1,8 @@ obj-bin-y += head.o -DEFS_H_DEPS = $(src)/defs.h $(BASEDIR)/include/xen/stdbool.h +DEFS_H_DEPS = $(BASEDIR)/$(src)/defs.h $(BASEDIR)/include/xen/stdbool.h -CMDLINE_DEPS = $(DEFS_H_DEPS) $(src)/video.h +CMDLINE_DEPS = $(DEFS_H_DEPS) $(BASEDIR)/$(src)/video.h RELOC_DEPS = $(DEFS_H_DEPS) \ $(BASEDIR)/include/generated/autoconf.h \ @@ -14,7 +14,7 @@ RELOC_DEPS = $(DEFS_H_DEPS) \ $(obj)/head.o: $(obj)/cmdline.S $(obj)/reloc.S $(obj)/cmdline.S: $(src)/cmdline.c $(CMDLINE_DEPS) - $(MAKE) -f build32.mk -C $(obj) $(@F) CMDLINE_DEPS="$(CMDLINE_DEPS)" + $(MAKE) -f $(BASEDIR)/$(src)/build32.mk -C $(obj) $(@F) CMDLINE_DEPS="$(CMDLINE_DEPS)" $(obj)/reloc.S: $(src)/reloc.c $(RELOC_DEPS) - $(MAKE) -f build32.mk -C $(obj) $(@F) RELOC_DEPS="$(RELOC_DEPS)" + $(MAKE) -f $(BASEDIR)/$(src)/build32.mk -C $(obj) $(@F) RELOC_DEPS="$(RELOC_DEPS)" diff --git a/xen/include/Makefile b/xen/include/Makefile index a969e76ddcad..b318bdaab094 100644 --- a/xen/include/Makefile +++ b/xen/include/Makefile @@ -61,7 +61,7 @@ $(obj)/compat/.xlat/%.h: $(obj)/compat/%.h $(obj)/compat/.xlat/%.lst $(BASEDIR)/ export PYTHON=$(PYTHON); \ while read what name; do \ $(SHELL) $(BASEDIR)/tools/get-fields.sh "$$what" compat_$$name $< || exit $$?; \ - done <$(patsubst compat/%,compat/.xlat/%,$(basename $<)).lst >$@.new + done <$(patsubst $(obj)/compat/%,$(obj)/compat/.xlat/%,$(basename $<)).lst >$@.new mv -f $@.new $@ .PRECIOUS: $(obj)/compat/.xlat/%.lst @@ -86,8 +86,8 @@ PUBLIC_HEADERS := $(filter-out $(src)/public/arch-% $(src)/public/dom0_ops.h, $( PUBLIC_C99_HEADERS := $(src)/public/io/9pfs.h $(src)/public/io/pvcalls.h PUBLIC_ANSI_HEADERS := $(filter-out $(src)/public/%ctl.h $(src)/public/xsm/% $(src)/public/%hvm/save.h $(PUBLIC_C99_HEADERS), $(PUBLIC_HEADERS)) -public/io/9pfs.h-prereq := string -public/io/pvcalls.h-prereq := string +$(src)/public/io/9pfs.h-prereq := string +$(src)/public/io/pvcalls.h-prereq := string $(obj)/headers.chk: $(PUBLIC_ANSI_HEADERS) $(src)/Makefile for i in $(filter %.h,$^); do \ diff --git a/xen/scripts/Kbuild.include b/xen/scripts/Kbuild.include index 7cb55b181dcb..788929cdca38 100644 --- a/xen/scripts/Kbuild.include +++ b/xen/scripts/Kbuild.include @@ -107,6 +107,12 @@ ld-option = $(call success,$(LD) -v $(1)) # Usage: EXTRA_CFLAGS += $(call cc-ifversion, -lt, 0402, -O1) cc-ifversion = $(shell [ $(CONFIG_GCC_VERSION)0 $(1) $(2)000 ] && echo $(3) || echo $(4)) +### +# Shorthand for $(Q)$(MAKE) -f scripts/Makefile.build obj= +# Usage: +# $(Q)$(MAKE) $(build)=dir +build := -f $(BASEDIR)/Rules.mk obj + # Shorthand for $(MAKE) clean # Usage: # $(MAKE) $(clean) dir diff --git a/xen/test/Makefile b/xen/test/Makefile index 41e4d7bdb78b..080763c80766 100644 --- a/xen/test/Makefile +++ b/xen/test/Makefile @@ -1,13 +1,10 @@ -tests all: build - - ifneq ($(XEN_TARGET_ARCH),x86_32) # Xen 32-bit x86 hypervisor no longer supported, so has no test livepatches subdir-y += livepatch endif -install build subtree-force-update uninstall: %: +install uninstall: %: set -e; for s in $(subdir-y); do \ - $(MAKE) -f $(BASEDIR)/Rules.mk -C $$s $*; \ + $(MAKE) $(build)=$$s $*; \ done diff --git a/xen/test/livepatch/Makefile b/xen/test/livepatch/Makefile index e59245323e92..52ee58a08c5f 100644 --- a/xen/test/livepatch/Makefile +++ b/xen/test/livepatch/Makefile @@ -11,9 +11,6 @@ endif CODE_ADDR=$(shell nm --defined $(1) | grep $(2) | awk '{print "0x"$$1}') CODE_SZ=$(shell nm --defined -S $(1) | grep $(2) | awk '{ print "0x"$$2}') -.PHONY: default -build default: livepatch - extra-y += xen_hello_world.livepatch xen_hello_world-objs := xen_hello_world_func.o xen_hello_world.o note.o xen_note.o modinfo.o $(obj)/xen_hello_world.o: $(obj)/config.h @@ -156,9 +153,6 @@ LIVEPATCHES := $(filter %.livepatch,$(extra-y)) LIVEPATCH_DEBUG_DIR ?= $(DEBUG_DIR)/xen-livepatch -.PHONY: livepatch -livepatch: $(LIVEPATCHES) - install: $(addprefix $(obj)/,$(LIVEPATCHES)) $(INSTALL_DIR) $(DESTDIR)$(LIVEPATCH_DEBUG_DIR) $(INSTALL_DATA) $(addprefix $(obj)/,$(LIVEPATCHES)) $(DESTDIR)$(LIVEPATCH_DEBUG_DIR) diff --git a/xen/xsm/flask/Makefile b/xen/xsm/flask/Makefile index 3ea726d66f8b..267ca5c47437 100644 --- a/xen/xsm/flask/Makefile +++ b/xen/xsm/flask/Makefile @@ -42,7 +42,7 @@ $(obj)/flask-policy.S: $(BASEDIR)/tools/binfile FORCE $(call if_changed,binfile) targets += flask-policy.S -FLASK_BUILD_DIR := $(CURDIR) +FLASK_BUILD_DIR := $(BASEDIR)/$(obj) POLICY_SRC := $(FLASK_BUILD_DIR)/xenpolicy-$(XEN_FULLVERSION) $(obj)/policy.bin: FORCE diff --git a/xen/xsm/flask/ss/Makefile b/xen/xsm/flask/ss/Makefile index d32b9e07138e..efd21f138df3 100644 --- a/xen/xsm/flask/ss/Makefile +++ b/xen/xsm/flask/ss/Makefile @@ -8,4 +8,4 @@ obj-y += services.o obj-y += conditional.o obj-y += mls.o -CFLAGS-y += -I../include +CFLAGS-y += -Ixsm/flask/include -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Thu Jul 01 14:21:41 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 14:21:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148775.275042 (Exim 4.92) (envelope-from ) id 1lyxZV-00024m-6j; Thu, 01 Jul 2021 14:21:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148775.275042; Thu, 01 Jul 2021 14:21:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyxZV-00023H-1Y; Thu, 01 Jul 2021 14:21:41 +0000 Received: by outflank-mailman (input) for mailman id 148775; Thu, 01 Jul 2021 14:21:39 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyxQZ-0005F9-M3 for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 14:12:27 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 309bf640-da76-11eb-8328-12813bfff9fa; Thu, 01 Jul 2021 14:11:12 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 309bf640-da76-11eb-8328-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1625148672; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=APF1/u5jPnrWo/5Fqte+sYKklT316xDw+oribOSGvg8=; b=Ge6JnMP34vCiOXZ5Txyu4meDPNMNAynK3t9TiXzuMm2lShhXr17ahCV0 EvGodJ6a+OOxrvKi7uBl+5WIxADfht6XdlXfZgo1aw71cUnDL5vTHzlfC 9gyQaO3QWP/cu30I9Oxv/6NemNkZoFjZbN853zlsrBeRALg1TbFFQ3Km9 k=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: DPse08MoYbUEHN87mCBV8I3seFbD0iRz6VH/LPSxzcuPuQZQjOtYLAmTnXANpYULIIjcgv/Px1 Sp8OkTpY2yODr15n27DBnTkPKjJAuOP/poJnHJYFkXpneEmop0a2vGCerd0fNZxzJ5Bpr0/OAx /bnaBSfuzwAbVrgLqW7FtuEKTszwqufSVO4Oab/tDf/0NSuC5rOa8tT/uHSDaHfSQMsB94SMhP 0YHBhgI51ECOkvrmJsOaDm4UH+uUu2VnVFOUd6nz1UJXNGjNJYdjKSrlVdWOtmVuku3Egi8Fay vd8= X-SBRS: 5.1 X-MesageID: 47093441 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:qrnDPqpWRqPpvhTp/nkAj0waV5rveYIsimQD101hICG9Evb0qy nOpoV/6faQslwssR4b9uxoVJPvfZq+z+8W3WByB9eftWDd0QPFEGgL1+DfKlbbak7DH4BmtJ uJc8JFeafN5VoRt7eG3OFveexQvOVu88qT9JjjJ28Gd3APV0n5hT0JcjpyFCdNNW57LKt8Lr WwzOxdqQGtfHwGB/7LfUXsD4D41rv2fIuNW29+OyIa X-IronPort-AV: E=Sophos;i="5.83,314,1616472000"; d="scan'208";a="47093441" From: Anthony PERARD To: CC: Anthony PERARD , Andrew Cooper , George Dunlap , "Ian Jackson" , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [XEN PATCH v6 30/31] build: introduce if_changed_deps Date: Thu, 1 Jul 2021 15:10:10 +0100 Message-ID: <20210701141011.785641-31-anthony.perard@citrix.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210701141011.785641-1-anthony.perard@citrix.com> References: <20210701141011.785641-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain This macro does compare command line like if_changed, but it also rewrite the dependencies generated by $(CC) in order to depend on a CONFIG_* as generated by kconfig instead of depending on autoconf.h. This allow to make a change in kconfig options and only rebuild the object that uses that CONFIG_* option. cmd_and_record isn't needed anymore as it is replace by cmd_and_fixdep. There's only one .*.d dependency file left which is explicitly included as a workound, all the other are been absorb into the .*.cmd dependency files via `fixdep`. So including .*.d can be removed from the makefile. This imports fixdep.c and if_changed_deps macro from Linux v5.12. Signed-off-by: Anthony PERARD --- .gitignore | 1 + xen/Makefile | 16 +- xen/Rules.mk | 17 +- xen/arch/x86/Makefile | 8 +- xen/scripts/Kbuild.include | 17 +- xen/tools/Makefile | 7 +- xen/tools/fixdep.c | 404 +++++++++++++++++++++++++++++++++++++ 7 files changed, 441 insertions(+), 29 deletions(-) create mode 100644 xen/tools/fixdep.c diff --git a/.gitignore b/.gitignore index 91ae22ae9216..1c9c8a47aac6 100644 --- a/.gitignore +++ b/.gitignore @@ -341,6 +341,7 @@ xen/include/xen/lib/x86/cpuid-autogen.h xen/test/livepatch/config.h xen/test/livepatch/expect_config.h xen/test/livepatch/*.livepatch +xen/tools/fixdep xen/tools/kconfig/.tmp_gtkcheck xen/tools/kconfig/.tmp_qtcheck xen/tools/symbols diff --git a/xen/Makefile b/xen/Makefile index 71f098cd6374..d8dedca206a1 100644 --- a/xen/Makefile +++ b/xen/Makefile @@ -185,6 +185,13 @@ endif export root-make-done := y endif # root-make-done +# =========================================================================== +# Rules shared between *config targets and build targets + +PHONY += tools_fixdep +tools_fixdep: + $(MAKE) -C tools fixdep + # Shorthand for kconfig kconfig = -f $(BASEDIR)/tools/kconfig/Makefile.kconfig ARCH=$(ARCH) SRCARCH=$(SRCARCH) HOSTCC="$(HOSTCC)" HOSTCXX="$(HOSTCXX)" @@ -397,7 +404,7 @@ $(TARGET).gz: $(TARGET) mv $@.new $@ PHONY += prepare -prepare: +prepare: tools_fixdep $(MAKE) -C tools $(MAKE) $(build)=. include/xen/compile.h [ -e arch/$(TARGET_ARCH)/efi ] && for f in $$(cd common/efi; echo *.[ch]); \ @@ -476,6 +483,7 @@ include/xen/compile.h: include/xen/compile.h.in .banner FORCE @cat .banner $(call filechk,compile.h) +-include $(wildcard .asm-offsets.s.d) asm-offsets.s: arch/$(TARGET_ARCH)/$(TARGET_SUBARCH)/asm-offsets.c $(CC) $(filter-out -Wa$(comma)% -flto,$(c_flags)) -S -g0 -o $@.new -MQ $@ $< $(call move-if-changed,$@.new,$@) @@ -542,13 +550,13 @@ _MAP: # Avoid those single target rules when Makefile is included by Rules.mk ifndef obj -%.o %.i %.s: %.c FORCE +%.o %.i %.s: %.c tools_fixdep FORCE $(MAKE) $(build)=$(*D) $(*D)/$(@F) -%.o %.s: %.S FORCE +%.o %.s: %.S tools_fixdep FORCE $(MAKE) $(build)=$(*D) $(*D)/$(@F) -%/: FORCE +%/: tools_fixdep FORCE $(MAKE) $(build)=$* need-builtin=1 endif diff --git a/xen/Rules.mk b/xen/Rules.mk index 4b3abf0ea880..f2af4a6e0644 100644 --- a/xen/Rules.mk +++ b/xen/Rules.mk @@ -139,8 +139,8 @@ cpp_flags = $(filter-out -Wa$(comma)%,$(1)) # Calculation of flags, first the generic flags, then the arch specific flags, # and last the flags modified for a target or a directory. -c_flags = -MMD -MP -MF $(@D)/.$(@F).d $(XEN_CFLAGS) -a_flags = -MMD -MP -MF $(@D)/.$(@F).d $(XEN_AFLAGS) +c_flags = -MMD -MP -MF $(depfile) $(XEN_CFLAGS) +a_flags = -MMD -MP -MF $(depfile) $(XEN_AFLAGS) include $(BASEDIR)/arch/$(TARGET_ARCH)/Rules.mk @@ -197,7 +197,7 @@ else endif define rule_cc_o_c - $(call cmd_and_record,cc_o_c) + $(call cmd_and_fixdep,cc_o_c) $(call cmd,objcopy_fix_sym) endef @@ -208,7 +208,7 @@ quiet_cmd_cc_o_S = CC $@ cmd_cc_o_S = $(CC) $(a_flags) -c $< -o $@ $(obj)/%.o: $(src)/%.S FORCE - $(call if_changed,cc_o_S) + $(call if_changed_dep,cc_o_S) quiet_cmd_obj_init_o = INIT_O $@ @@ -238,13 +238,13 @@ quiet_cmd_cpp_s_S = CPP $@ cmd_cpp_s_S = $(CPP) $(call cpp_flags,$(a_flags)) -MQ $@ -o $@ $< $(obj)/%.i: $(src)/%.c FORCE - $(call if_changed,cpp_i_c) + $(call if_changed_dep,cpp_i_c) $(obj)/%.s: $(src)/%.c FORCE - $(call if_changed,cc_s_c) + $(call if_changed_dep,cc_s_c) $(obj)/%.s: $(src)/%.S FORCE - $(call if_changed,cpp_s_S) + $(call if_changed_dep,cpp_s_S) # Linker scripts, .lds.S -> .lds quiet_cmd_cpp_lds_S = LDS $@ @@ -283,9 +283,6 @@ existing-targets := $(wildcard $(sort $(targets))) -include $(foreach f,$(existing-targets),$(dir $(f)).$(notdir $(f)).cmd) -DEPS:= $(foreach f,$(existing-targets),$(dir $(f)).$(notdir $(f)).d) --include $(DEPS_INCLUDE) - # Declare the contents of the PHONY variable as phony. We keep that # information in a variable so we can use it in if_changed and friends. .PHONY: $(PHONY) diff --git a/xen/arch/x86/Makefile b/xen/arch/x86/Makefile index c5e87f3db35b..bcb140756b98 100644 --- a/xen/arch/x86/Makefile +++ b/xen/arch/x86/Makefile @@ -280,7 +280,7 @@ $(BASEDIR)/include/arch-x86/asm/asm-macros.h: $(obj)/asm-macros.i $(src)/Makefil $(obj)/efi.lds: AFLAGS-y += -DEFI $(obj)/xen.lds $(obj)/efi.lds: $(src)/xen.lds.S FORCE - $(call if_changed,cpp_lds_S) + $(call if_changed_dep,cpp_lds_S) $(obj)/boot/mkelf32: $(src)/boot/mkelf32.c $(HOSTCC) $(HOSTCFLAGS) -o $@ $< @@ -296,9 +296,3 @@ clean:: rm -f $(BASEDIR)/.xen.efi.[0-9]* efi/*.efi efi/mkreloc rm -f boot/cmdline.S boot/reloc.S boot/*.lnk boot/*.bin rm -f note.o - -# Suppress loading of DEPS files for internal, temporary target files. This -# then also suppresses re-generation of the respective .*.d2 files. -ifeq ($(filter-out .xen%.o,$(notdir $(MAKECMDGOALS))),) -DEPS_INCLUDE:= -endif diff --git a/xen/scripts/Kbuild.include b/xen/scripts/Kbuild.include index 788929cdca38..b56bbc4300f0 100644 --- a/xen/scripts/Kbuild.include +++ b/xen/scripts/Kbuild.include @@ -15,8 +15,7 @@ dot-target = $(@D)/.$(@F) ### # dependencies -DEPS = .*.d -DEPS_INCLUDE = $(addsuffix .d2, $(basename $(wildcard $(DEPS)))) +depfile = $(dot-target).d ### # real prerequisites without phony targets @@ -129,6 +128,8 @@ cmd = @set -e; $(echo-cmd) $(cmd_$(1)) ### # if_changed - execute command if any prerequisite is newer than # target, or command line has changed +# if_changed_dep - as if_changed, but uses fixdep to reveal dependencies +# including used config symbols # if_changed_rule - as if_changed but execute rule instead ifneq ($(KBUILD_NOCMDDEP),1) @@ -157,15 +158,19 @@ if_changed = $(if $(any-prereq)$(cmd-check), \ $(cmd); \ printf '%s\n' 'cmd_$@ := $(make-cmd)' > $(dot-target).cmd, @:) +# Execute the command and also postprocess generated .d dependencies file. +if_changed_dep = $(if $(any-prereq)$(cmd-check),$(cmd_and_fixdep),@:) + +cmd_and_fixdep = \ + $(cmd); \ + tools/fixdep $(depfile) $@ '$(make-cmd)' > $(dot-target).cmd; \ + rm -f $(depfile) + # Usage: $(call if_changed_rule,foo) # Will check if $(cmd_foo) or any of the prerequisites changed, # and if so will execute $(rule_foo). if_changed_rule = $(if $(any-prereq)$(cmd-check),$(rule_$(1)),@:) -cmd_and_record = \ - $(cmd); \ - printf '%s\n' 'cmd_$@ := $(make-cmd)' > $(dot-target).cmd - ### # why - tell why a target got built # enabled by make V=2 diff --git a/xen/tools/Makefile b/xen/tools/Makefile index 4e42163f981c..722f3664549d 100644 --- a/xen/tools/Makefile +++ b/xen/tools/Makefile @@ -2,11 +2,14 @@ include $(XEN_ROOT)/Config.mk .PHONY: default -default: symbols +default: symbols fixdep .PHONY: clean clean: - rm -f *.o symbols + rm -f *.o symbols fixdep symbols: symbols.c $(HOSTCC) $(HOSTCFLAGS) -o $@ $< + +fixdep: fixdep.c + $(HOSTCC) $(HOSTCFLAGS) -o $@ $< diff --git a/xen/tools/fixdep.c b/xen/tools/fixdep.c new file mode 100644 index 000000000000..d98540552941 --- /dev/null +++ b/xen/tools/fixdep.c @@ -0,0 +1,404 @@ +/* + * "Optimize" a list of dependencies as spit out by gcc -MD + * for the kernel build + * =========================================================================== + * + * Author Kai Germaschewski + * Copyright 2002 by Kai Germaschewski + * + * This software may be used and distributed according to the terms + * of the GNU General Public License, incorporated herein by reference. + * + * + * Introduction: + * + * gcc produces a very nice and correct list of dependencies which + * tells make when to remake a file. + * + * To use this list as-is however has the drawback that virtually + * every file in the kernel includes autoconf.h. + * + * If the user re-runs make *config, autoconf.h will be + * regenerated. make notices that and will rebuild every file which + * includes autoconf.h, i.e. basically all files. This is extremely + * annoying if the user just changed CONFIG_HIS_DRIVER from n to m. + * + * So we play the same trick that "mkdep" played before. We replace + * the dependency on autoconf.h by a dependency on every config + * option which is mentioned in any of the listed prerequisites. + * + * kconfig populates a tree in include/config/ with an empty file + * for each config symbol and when the configuration is updated + * the files representing changed config options are touched + * which then let make pick up the changes and the files that use + * the config symbols are rebuilt. + * + * So if the user changes his CONFIG_HIS_DRIVER option, only the objects + * which depend on "include/config/his/driver.h" will be rebuilt, + * so most likely only his driver ;-) + * + * The idea above dates, by the way, back to Michael E Chastain, AFAIK. + * + * So to get dependencies right, there are two issues: + * o if any of the files the compiler read changed, we need to rebuild + * o if the command line given to the compile the file changed, we + * better rebuild as well. + * + * The former is handled by using the -MD output, the later by saving + * the command line used to compile the old object and comparing it + * to the one we would now use. + * + * Again, also this idea is pretty old and has been discussed on + * kbuild-devel a long time ago. I don't have a sensibly working + * internet connection right now, so I rather don't mention names + * without double checking. + * + * This code here has been based partially based on mkdep.c, which + * says the following about its history: + * + * Copyright abandoned, Michael Chastain, . + * This is a C version of syncdep.pl by Werner Almesberger. + * + * + * It is invoked as + * + * fixdep + * + * and will read the dependency file + * + * The transformed dependency snipped is written to stdout. + * + * It first generates a line + * + * cmd_ = + * + * and then basically copies the ..d file to stdout, in the + * process filtering out the dependency on autoconf.h and adding + * dependencies on include/config/my/option.h for every + * CONFIG_MY_OPTION encountered in any of the prerequisites. + * + * We don't even try to really parse the header files, but + * merely grep, i.e. if CONFIG_FOO is mentioned in a comment, it will + * be picked up as well. It's not a problem with respect to + * correctness, since that can only give too many dependencies, thus + * we cannot miss a rebuild. Since people tend to not mention totally + * unrelated CONFIG_ options all over the place, it's not an + * efficiency problem either. + * + * (Note: it'd be easy to port over the complete mkdep state machine, + * but I don't think the added complexity is worth it) + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include + +static void usage(void) +{ + fprintf(stderr, "Usage: fixdep \n"); + exit(1); +} + +/* + * In the intended usage of this program, the stdout is redirected to .*.cmd + * files. The return value of printf() and putchar() must be checked to catch + * any error, e.g. "No space left on device". + */ +static void xprintf(const char *format, ...) +{ + va_list ap; + int ret; + + va_start(ap, format); + ret = vprintf(format, ap); + if (ret < 0) { + perror("fixdep"); + exit(1); + } + va_end(ap); +} + +static void xputchar(int c) +{ + int ret; + + ret = putchar(c); + if (ret == EOF) { + perror("fixdep"); + exit(1); + } +} + +/* + * Print out a dependency path from a symbol name + */ +static void print_dep(const char *m, int slen, const char *dir) +{ + int c, prev_c = '/', i; + + xprintf(" $(wildcard %s/", dir); + for (i = 0; i < slen; i++) { + c = m[i]; + if (c == '_') + c = '/'; + else + c = tolower(c); + if (c != '/' || prev_c != '/') + xputchar(c); + prev_c = c; + } + xprintf(".h) \\\n"); +} + +struct item { + struct item *next; + unsigned int len; + unsigned int hash; + char name[]; +}; + +#define HASHSZ 256 +static struct item *hashtab[HASHSZ]; + +static unsigned int strhash(const char *str, unsigned int sz) +{ + /* fnv32 hash */ + unsigned int i, hash = 2166136261U; + + for (i = 0; i < sz; i++) + hash = (hash ^ str[i]) * 0x01000193; + return hash; +} + +/* + * Lookup a value in the configuration string. + */ +static int is_defined_config(const char *name, int len, unsigned int hash) +{ + struct item *aux; + + for (aux = hashtab[hash % HASHSZ]; aux; aux = aux->next) { + if (aux->hash == hash && aux->len == len && + memcmp(aux->name, name, len) == 0) + return 1; + } + return 0; +} + +/* + * Add a new value to the configuration string. + */ +static void define_config(const char *name, int len, unsigned int hash) +{ + struct item *aux = malloc(sizeof(*aux) + len); + + if (!aux) { + perror("fixdep:malloc"); + exit(1); + } + memcpy(aux->name, name, len); + aux->len = len; + aux->hash = hash; + aux->next = hashtab[hash % HASHSZ]; + hashtab[hash % HASHSZ] = aux; +} + +/* + * Record the use of a CONFIG_* word. + */ +static void use_config(const char *m, int slen) +{ + unsigned int hash = strhash(m, slen); + + if (is_defined_config(m, slen, hash)) + return; + + define_config(m, slen, hash); + print_dep(m, slen, "include/config"); +} + +/* test if s ends in sub */ +static int str_ends_with(const char *s, int slen, const char *sub) +{ + int sublen = strlen(sub); + + if (sublen > slen) + return 0; + + return !memcmp(s + slen - sublen, sub, sublen); +} + +static void parse_config_file(const char *p) +{ + const char *q, *r; + const char *start = p; + + while ((p = strstr(p, "CONFIG_"))) { + if (p > start && (isalnum(p[-1]) || p[-1] == '_')) { + p += 7; + continue; + } + p += 7; + q = p; + while (isalnum(*q) || *q == '_') + q++; + if (str_ends_with(p, q - p, "_MODULE")) + r = q - 7; + else + r = q; + if (r > p) + use_config(p, r - p); + p = q; + } +} + +static void *read_file(const char *filename) +{ + struct stat st; + int fd; + char *buf; + + fd = open(filename, O_RDONLY); + if (fd < 0) { + fprintf(stderr, "fixdep: error opening file: "); + perror(filename); + exit(2); + } + if (fstat(fd, &st) < 0) { + fprintf(stderr, "fixdep: error fstat'ing file: "); + perror(filename); + exit(2); + } + buf = malloc(st.st_size + 1); + if (!buf) { + perror("fixdep: malloc"); + exit(2); + } + if (read(fd, buf, st.st_size) != st.st_size) { + perror("fixdep: read"); + exit(2); + } + buf[st.st_size] = '\0'; + close(fd); + + return buf; +} + +/* Ignore certain dependencies */ +static int is_ignored_file(const char *s, int len) +{ + return str_ends_with(s, len, "include/generated/autoconf.h") || + str_ends_with(s, len, "include/generated/autoksyms.h"); +} + +/* + * Important: The below generated source_foo.o and deps_foo.o variable + * assignments are parsed not only by make, but also by the rather simple + * parser in scripts/mod/sumversion.c. + */ +static void parse_dep_file(char *m, const char *target) +{ + char *p; + int is_last, is_target; + int saw_any_target = 0; + int is_first_dep = 0; + void *buf; + + while (1) { + /* Skip any "white space" */ + while (*m == ' ' || *m == '\\' || *m == '\n') + m++; + + if (!*m) + break; + + /* Find next "white space" */ + p = m; + while (*p && *p != ' ' && *p != '\\' && *p != '\n') + p++; + is_last = (*p == '\0'); + /* Is the token we found a target name? */ + is_target = (*(p-1) == ':'); + /* Don't write any target names into the dependency file */ + if (is_target) { + /* The /next/ file is the first dependency */ + is_first_dep = 1; + } else if (!is_ignored_file(m, p - m)) { + *p = '\0'; + + /* + * Do not list the source file as dependency, so that + * kbuild is not confused if a .c file is rewritten + * into .S or vice versa. Storing it in source_* is + * needed for modpost to compute srcversions. + */ + if (is_first_dep) { + /* + * If processing the concatenation of multiple + * dependency files, only process the first + * target name, which will be the original + * source name, and ignore any other target + * names, which will be intermediate temporary + * files. + */ + if (!saw_any_target) { + saw_any_target = 1; + xprintf("source_%s := %s\n\n", + target, m); + xprintf("deps_%s := \\\n", target); + } + is_first_dep = 0; + } else { + xprintf(" %s \\\n", m); + } + + buf = read_file(m); + parse_config_file(buf); + free(buf); + } + + if (is_last) + break; + + /* + * Start searching for next token immediately after the first + * "whitespace" character that follows this token. + */ + m = p + 1; + } + + if (!saw_any_target) { + fprintf(stderr, "fixdep: parse error; no targets found\n"); + exit(1); + } + + xprintf("\n%s: $(deps_%s)\n\n", target, target); + xprintf("$(deps_%s):\n", target); +} + +int main(int argc, char *argv[]) +{ + const char *depfile, *target, *cmdline; + void *buf; + + if (argc != 4) + usage(); + + depfile = argv[1]; + target = argv[2]; + cmdline = argv[3]; + + xprintf("cmd_%s := %s\n\n", target, cmdline); + + buf = read_file(depfile); + parse_dep_file(buf, target); + free(buf); + + return 0; +} -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Thu Jul 01 14:21:41 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 14:21:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148778.275049 (Exim 4.92) (envelope-from ) id 1lyxZV-00028B-Q2; Thu, 01 Jul 2021 14:21:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148778.275049; Thu, 01 Jul 2021 14:21:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyxZV-00026g-BJ; Thu, 01 Jul 2021 14:21:41 +0000 Received: by outflank-mailman (input) for mailman id 148778; Thu, 01 Jul 2021 14:21:40 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyxQT-0005tj-33 for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 14:12:21 +0000 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id a4370ab4-7d26-431f-8643-4db42b9cbd9d; Thu, 01 Jul 2021 14:10:59 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a4370ab4-7d26-431f-8643-4db42b9cbd9d DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1625148659; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=FW24mf7gQhBpHHcg9GJm9hyluG+ERn9X5WYN2UmMbPk=; b=cbdYfVzPIy5KNJccFmRaz2ouIUyoBrGCGeHeYbXyzxTttZRmy2wp2iKV I6gRqVwE+5oidon18IaiLTgC5r3QmsI7YS6miijS5RtoDH28XeOujqPFq xM/C3VwEBDTzkpPV74Pt+d3hZYHvFKPeEf3e4CEoFSdtj8rQDVbO/8NwL g=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: X0x55L6E6elZNa5DJCSBz8AQs/xTDbH104JZsGk/ivXRryutvpwmKbBMTXXbLDFK4nPOb5IBzZ 0N5u5mvjxwK5S7vfU9LXCRVSlic9OhDTTNnw/iycBej8XIsnoDmq/Ff9iAU6aEOJ55V+0ymsHi TCbaTwrM+aSUTSccuqsEZUvJ1CHW7CvDDyh1RHwTU3KvT1V4SScRuwj87NJu3HuSjBOK3pQrar Z773hjmZAvEW7Q12YELsTT8HyTYIHhhf0A+2/YncVPuxcjkg8aR7xlQXE74+qETDW2FWTC8vEh YmE= X-SBRS: 5.1 X-MesageID: 47384424 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:RoSt96FZ/cY7VNDdpLqE0MeALOsnbusQ8zAXP0AYc3Jom6uj5q aTdZUgpGfJYVkqOE3I9ertBEDEewK4yXcX2/h3AV7BZniEhILAFugLhuGO/9SjIVybygc079 YYT0EUMrzN5DZB4voSmDPIceod/A== X-IronPort-AV: E=Sophos;i="5.83,314,1616472000"; d="scan'208";a="47384424" From: Anthony PERARD To: CC: Anthony PERARD , Stefano Stabellini , Julien Grall , Volodymyr Babchuk Subject: [XEN PATCH v6 22/31] build: fix $(TARGET).efi creation in arch/arm Date: Thu, 1 Jul 2021 15:10:02 +0100 Message-ID: <20210701141011.785641-23-anthony.perard@citrix.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210701141011.785641-1-anthony.perard@citrix.com> References: <20210701141011.785641-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain There is no need to try to guess a relative path to the "xen.efi" file, we can simply use $@. Also, there's no need to use `notdir`, make already do that work via $(@F). Signed-off-by: Anthony PERARD --- xen/arch/arm/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile index cc90d9796e6e..dc1d09c8b429 100644 --- a/xen/arch/arm/Makefile +++ b/xen/arch/arm/Makefile @@ -93,7 +93,7 @@ endif $(TARGET): $(TARGET)-syms $(OBJCOPY) -O binary -S $< $@ ifeq ($(CONFIG_ARM_64),y) - ln -sf $(notdir $@) ../../$(notdir $@).efi + ln -sf $(@F) $@.efi endif ifeq ($(CONFIG_LTO),y) -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Thu Jul 01 14:21:43 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 14:21:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148782.275064 (Exim 4.92) (envelope-from ) id 1lyxZX-0002cM-4A; Thu, 01 Jul 2021 14:21:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148782.275064; Thu, 01 Jul 2021 14:21:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyxZW-0002aP-Ps; Thu, 01 Jul 2021 14:21:42 +0000 Received: by outflank-mailman (input) for mailman id 148782; Thu, 01 Jul 2021 14:21:40 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyxQ0-0005F9-LG for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 14:11:52 +0000 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 2bdb2267-da76-11eb-8328-12813bfff9fa; Thu, 01 Jul 2021 14:11:04 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2bdb2267-da76-11eb-8328-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1625148664; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=L4z28cvrDDLSI9snpUNcl7132wPxxWZfLbL6aTtX99c=; b=ifqFwcjzosPIACXs41EiqBd9MOlWyHRkIaX06IdoUEehh31yvKh2+58C wEj+XOtP0JgQ/EH5eNf7yVtVlHLoQ79up2CgVX95lgl7eYSMNm39ojmaM y5OCiPOXmhm0hlsHziT+5x5/Xf3XrgtwRaCkKjfVVefpgYSiAeut8p9aj M=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: TtXDA0ONg0zB4imPwD6CLtxyuHHm1I96tSnPRl398FpKbpk7Af2z1y8E2fAHku/RucW6k0kY3P S1rBcaLI/FSNaTMFtuAVQB/EAjHR+qmS1/nA+RJwGPHyYU56m+9Vn7xcbpaUpf2emxv8VRA7Jf tMc4UbIgXOAvigD0AnbxPxP8KDyMAc1IEuq2Yw41MlM1catRC55unN1ikPQXMSlGzB54i1p1a8 rtR/5DL6F9vvHOvTYMG/zBucORtPOF1sMcyyHddy/wdX1QI88ZStPqm1/PJbqVO8DRI+g12lBf A04= X-SBRS: 5.1 X-MesageID: 47446882 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:vO3cIKx73XAkVg1w2ma1KrPxu+skLtp133Aq2lEZdPULSKKlfp GV88jziyWZtN9IYgBcpTiBUJPwJE80hqQFnbX5XI3SEDUO11HYVb2KgbGSoAEIXheOjNK1tp 0QPJSWaueAdWSS5PySiGLTfrdB/DDEytHSuQ639QY1cegAUdAF0+4NMHf8LqQAfnggOXNWLu v/2uN34x6bPVgHZMWyAXcIG8LZocfQqZ7gaRkaQzY69Qinl1qTmfDHOind+i1bfyJEwL8k/2 SAuRf+/L+fv/ayzQKZ/3PP7q5RhMDqxrJ4dY2xY4kuW3XRYzSTFcZcso65zXUISSaUmRIXee z30lQd1gJImjTsly+O0F3QMkLboUkTAjfZuCGlaD3Y0JTErL5RMbsbuWsRSGqp12Mw+N57y6 5FxGSfqt5eCg7Bhj3045zSWwhtjVfcmwtorQc/tQ0XbWIlUs4YkWXfxjIgLL4QWCbhrIw3Gu hnC8/RoP5QbFOBdnjc+m1i2salUHg/FgqPBhFqgL3Z7xFG2HRii0cIzs0WmXkNsJo7Vplf/u zBdqBljqtHQMMaZb90QO0BXcy0AGrQRg+kChPZHb0mLtBwB5vpke+D3FwY3pDYRHU49upEpH 2aaiIpiYcbQTOdNfGz X-IronPort-AV: E=Sophos;i="5.83,314,1616472000"; d="scan'208";a="47446882" From: Anthony PERARD To: CC: Anthony PERARD , Andrew Cooper , George Dunlap , "Ian Jackson" , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Konrad Rzeszutek Wilk , Ross Lagerwall Subject: [XEN PATCH v6 28/31] build: rework test/livepatch/Makefile Date: Thu, 1 Jul 2021 15:10:08 +0100 Message-ID: <20210701141011.785641-29-anthony.perard@citrix.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210701141011.785641-1-anthony.perard@citrix.com> References: <20210701141011.785641-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain This rework the livepatch/Makefile to make it less repetitive and make use of the facilities. All the targets to be built are now listed in $(extra-y) which will allow Rules.mk to build them without the need of a local target in a future patch. There are some changes/fixes in this patch: - when "xen-syms" is used for a target, it is added to the dependency list of the target, which allow to rebuild the target when xen-syms changes. But if "xen-syms" is missing, make simply fails. - modinfo.o wasn't removing it's $@.bin file like the other targets, this is now done. - The command to build *.livepatch targets as been fixed to use $(XEN_LDFLAGS) rather than just $(LDFLAGS) which is a fallout from 2740d96efdd3 ("xen/build: have the root Makefile generates the CFLAGS") make will findout the dependencies of the *.livepatch files and thus what to built by "looking" at the objects listed in the *-objs variables. The actual dependencies is generated by the new "multi_depend" macro. "$(targets)" needs to be updated with the objects listed in the different *-objs variables to allow make to load the .*.cmd dependency files. This patch copies the macro "multi_depend" from Linux 5.12. Signed-off-by: Anthony PERARD --- xen/scripts/Kbuild.include | 9 ++ xen/test/livepatch/Makefile | 213 ++++++++++++++---------------------- 2 files changed, 91 insertions(+), 131 deletions(-) diff --git a/xen/scripts/Kbuild.include b/xen/scripts/Kbuild.include index 5fe13a7c5abd..7cb55b181dcb 100644 --- a/xen/scripts/Kbuild.include +++ b/xen/scripts/Kbuild.include @@ -199,3 +199,12 @@ why = \ echo-why = $(call escsq, $(strip $(why))) endif + +# Useful for describing the dependency of composite objects +# Usage: +# $(call multi_depend, multi_used_targets, suffix_to_remove, suffix_to_add) +define multi_depend +$(foreach m, $(notdir $1), \ + $(eval $(obj)/$m: \ + $(addprefix $(obj)/, $(foreach s, $3, $($(m:%$(strip $2)=%$(s))))))) +endef diff --git a/xen/test/livepatch/Makefile b/xen/test/livepatch/Makefile index 148dddb90473..e59245323e92 100644 --- a/xen/test/livepatch/Makefile +++ b/xen/test/livepatch/Makefile @@ -12,81 +12,29 @@ CODE_ADDR=$(shell nm --defined $(1) | grep $(2) | awk '{print "0x"$$1}') CODE_SZ=$(shell nm --defined -S $(1) | grep $(2) | awk '{ print "0x"$$2}') .PHONY: default - -LIVEPATCH := xen_hello_world.livepatch -LIVEPATCH_BYE := xen_bye_world.livepatch -LIVEPATCH_REPLACE := xen_replace_world.livepatch -LIVEPATCH_NOP := xen_nop.livepatch -LIVEPATCH_NO_XEN_BUILDID := xen_no_xen_buildid.livepatch -LIVEPATCH_PREPOST_HOOKS := xen_prepost_hooks.livepatch -LIVEPATCH_PREPOST_HOOKS_FAIL := xen_prepost_hooks_fail.livepatch -LIVEPATCH_ACTION_HOOKS := xen_action_hooks.livepatch -LIVEPATCH_ACTION_HOOKS_NOFUNC := xen_action_hooks_nofunc.livepatch -LIVEPATCH_ACTION_HOOKS_MARKER:= xen_action_hooks_marker.livepatch -LIVEPATCH_ACTION_HOOKS_NOAPPLY:= xen_action_hooks_noapply.livepatch -LIVEPATCH_ACTION_HOOKS_NOREVERT:= xen_action_hooks_norevert.livepatch -LIVEPATCH_EXPECTATIONS:= xen_expectations.livepatch -LIVEPATCH_EXPECTATIONS_FAIL:= xen_expectations_fail.livepatch - -LIVEPATCHES += $(LIVEPATCH) -LIVEPATCHES += $(LIVEPATCH_BYE) -LIVEPATCHES += $(LIVEPATCH_REPLACE) -LIVEPATCHES += $(LIVEPATCH_NOP) -LIVEPATCHES += $(LIVEPATCH_NO_XEN_BUILDID) -LIVEPATCHES += $(LIVEPATCH_PREPOST_HOOKS) -LIVEPATCHES += $(LIVEPATCH_PREPOST_HOOKS_FAIL) -LIVEPATCHES += $(LIVEPATCH_ACTION_HOOKS) -LIVEPATCHES += $(LIVEPATCH_ACTION_HOOKS_NOFUNC) -LIVEPATCHES += $(LIVEPATCH_ACTION_HOOKS_MARKER) -LIVEPATCHES += $(LIVEPATCH_ACTION_HOOKS_NOAPPLY) -LIVEPATCHES += $(LIVEPATCH_ACTION_HOOKS_NOREVERT) -LIVEPATCHES += $(LIVEPATCH_EXPECTATIONS) -LIVEPATCHES += $(LIVEPATCH_EXPECTATIONS_FAIL) - -LIVEPATCH_DEBUG_DIR ?= $(DEBUG_DIR)/xen-livepatch - build default: livepatch -install: livepatch - $(INSTALL_DIR) $(DESTDIR)$(LIVEPATCH_DEBUG_DIR) - $(INSTALL_DATA) $(LIVEPATCHES) $(DESTDIR)$(LIVEPATCH_DEBUG_DIR) - -uninstall: - cd $(DESTDIR)$(LIVEPATCH_DEBUG_DIR) && rm -f $(LIVEPATCHES) - -.PHONY: clean -clean:: - rm -f *.o .*.o.d *.livepatch config.h expect_config.h +extra-y += xen_hello_world.livepatch +xen_hello_world-objs := xen_hello_world_func.o xen_hello_world.o note.o xen_note.o modinfo.o +$(obj)/xen_hello_world.o: $(obj)/config.h # # To compute these values we need the binary files: xen-syms # and xen_hello_world_func.o to be already compiled. # -.PHONY: config.h -config.h: OLD_CODE_SZ=$(call CODE_SZ,$(BASEDIR)/xen-syms,xen_extra_version) -config.h: NEW_CODE_SZ=$(call CODE_SZ,$<,xen_hello_world) -config.h: MINOR_VERSION_SZ=$(call CODE_SZ,$(BASEDIR)/xen-syms,xen_minor_version) -config.h: MINOR_VERSION_ADDR=$(call CODE_ADDR,$(BASEDIR)/xen-syms,xen_minor_version) -config.h: xen_hello_world_func.o +$(obj)/config.h: $(obj)/xen_hello_world_func.o (set -e; \ - echo "#define NEW_CODE_SZ $(NEW_CODE_SZ)"; \ - echo "#define MINOR_VERSION_SZ $(MINOR_VERSION_SZ)"; \ - echo "#define MINOR_VERSION_ADDR $(MINOR_VERSION_ADDR)"; \ - echo "#define OLD_CODE_SZ $(OLD_CODE_SZ)") > $@ + echo "#define NEW_CODE_SZ $(call CODE_SZ,$<,xen_hello_world)"; \ + echo "#define MINOR_VERSION_SZ $(call CODE_SZ,$(BASEDIR)/xen-syms,xen_minor_version)"; \ + echo "#define MINOR_VERSION_ADDR $(call CODE_ADDR,$(BASEDIR)/xen-syms,xen_minor_version)"; \ + echo "#define OLD_CODE_SZ $(call CODE_SZ,$(BASEDIR)/xen-syms,xen_extra_version)") > $@ -xen_hello_world.o: config.h - -.PHONY: $(LIVEPATCH) -$(LIVEPATCH): xen_hello_world_func.o xen_hello_world.o note.o xen_note.o modinfo.o - $(LD) $(LDFLAGS) $(build_id_linker) -r -o $(LIVEPATCH) $^ - -.PHONY: modinfo.o -modinfo.o: +$(obj)/modinfo.o: (set -e; \ printf "LIVEPATCH_RULEZ\0") > $@.bin $(OBJCOPY) $(OBJCOPY_MAGIC) \ --rename-section=.data=.modinfo,alloc,load,readonly,data,contents -S $@.bin $@ - #rm -f $@.bin + rm -f $@.bin # # This target is only accessible if CONFIG_LIVEPATCH is defined, which @@ -97,9 +45,8 @@ modinfo.o: # not be built (it is for EFI builds), and that we do not have # the note.o.bin to muck with (as it gets deleted) # -.PHONY: note.o -note.o: - $(OBJCOPY) -O binary --only-section=.note.gnu.build-id $(BASEDIR)/xen-syms $@.bin +$(obj)/note.o: $(BASEDIR)/xen-syms + $(OBJCOPY) -O binary --only-section=.note.gnu.build-id $< $@.bin $(OBJCOPY) $(OBJCOPY_MAGIC) \ --rename-section=.data=.livepatch.depends,alloc,load,readonly,data,contents -S $@.bin $@ rm -f $@.bin @@ -108,9 +55,8 @@ note.o: # Append .livepatch.xen_depends section # with Xen build-id derived from xen-syms. # -.PHONY: xen_note.o -xen_note.o: - $(OBJCOPY) -O binary --only-section=.note.gnu.build-id $(BASEDIR)/xen-syms $@.bin +$(obj)/xen_note.o: $(BASEDIR)/xen-syms + $(OBJCOPY) -O binary --only-section=.note.gnu.build-id $< $@.bin $(OBJCOPY) $(OBJCOPY_MAGIC) \ --rename-section=.data=.livepatch.xen_depends,alloc,load,readonly,data,contents -S $@.bin $@ rm -f $@.bin @@ -119,102 +65,107 @@ xen_note.o: # Extract the build-id of the xen_hello_world.livepatch # (which xen_bye_world will depend on). # -.PHONY: hello_world_note.o -hello_world_note.o: $(LIVEPATCH) - $(OBJCOPY) -O binary --only-section=.note.gnu.build-id $(LIVEPATCH) $@.bin +$(obj)/hello_world_note.o: $(obj)/xen_hello_world.livepatch + $(OBJCOPY) -O binary --only-section=.note.gnu.build-id $< $@.bin $(OBJCOPY) $(OBJCOPY_MAGIC) \ --rename-section=.data=.livepatch.depends,alloc,load,readonly,data,contents -S $@.bin $@ rm -f $@.bin -xen_bye_world.o: config.h -.PHONY: $(LIVEPATCH_BYE) -$(LIVEPATCH_BYE): xen_bye_world_func.o xen_bye_world.o hello_world_note.o xen_note.o - $(LD) $(LDFLAGS) $(build_id_linker) -r -o $(LIVEPATCH_BYE) $^ +extra-y += xen_bye_world.livepatch +xen_bye_world-objs := xen_bye_world_func.o xen_bye_world.o hello_world_note.o xen_note.o +$(obj)/xen_bye_world.o: $(obj)/config.h -xen_replace_world.o: config.h -.PHONY: $(LIVEPATCH_REPLACE) -$(LIVEPATCH_REPLACE): xen_replace_world_func.o xen_replace_world.o note.o xen_note.o - $(LD) $(LDFLAGS) $(build_id_linker) -r -o $(LIVEPATCH_REPLACE) $^ +extra-y += xen_replace_world.livepatch +xen_replace_world-objs := xen_replace_world_func.o xen_replace_world.o note.o xen_note.o +$(obj)/xen_replace_world.o: $(obj)/config.h -xen_nop.o: config.h -.PHONY: $(LIVEPATCH_NOP) -$(LIVEPATCH_NOP): xen_nop.o note.o xen_note.o - $(LD) $(LDFLAGS) $(build_id_linker) -r -o $(LIVEPATCH_NOP) $^ +extra-y += xen_nop.livepatch +xen_nop-objs := xen_nop.o note.o xen_note.o +$(obj)/xen_nop.o: $(obj)/config.h # This one always fails upon upload, because it deliberately # does not have a .livepatch.xen_depends (xen_note.o) section. -xen_no_xen_buildid.o: config.h - -.PHONY: $(LIVEPATCH_NO_XEN_BUILDID) -$(LIVEPATCH_NO_XEN_BUILDID): xen_nop.o note.o - $(LD) $(LDFLAGS) $(build_id_linker) -r -o $(LIVEPATCH_NO_XEN_BUILDID) $^ +extra-y += xen_no_xen_buildid.livepatch +xen_no_xen_buildid-objs := xen_nop.o note.o -xen_prepost_hooks.o: config.h +$(obj)/xen_prepost_hooks.o: $(obj)/config.h -.PHONY: $(LIVEPATCH_PREPOST_HOOKS) -$(LIVEPATCH_PREPOST_HOOKS): xen_prepost_hooks.o xen_hello_world_func.o note.o xen_note.o - $(LD) $(LDFLAGS) $(build_id_linker) -r -o $(LIVEPATCH_PREPOST_HOOKS) $^ +extra-y += xen_prepost_hooks.livepatch +xen_prepost_hooks-objs := xen_prepost_hooks.o xen_hello_world_func.o note.o xen_note.o -xen_prepost_hooks_fail.o: config.h +$(obj)/xen_prepost_hooks_fail.o: $(obj)/config.h -.PHONY: $(LIVEPATCH_PREPOST_HOOKS_FAIL) -$(LIVEPATCH_PREPOST_HOOKS_FAIL): xen_prepost_hooks_fail.o xen_hello_world_func.o note.o xen_note.o - $(LD) $(LDFLAGS) $(build_id_linker) -r -o $(LIVEPATCH_PREPOST_HOOKS_FAIL) $^ +extra-y += xen_prepost_hooks_fail.livepatch +xen_prepost_hooks_fail-objs := xen_prepost_hooks_fail.o xen_hello_world_func.o note.o xen_note.o -xen_action_hooks.o: config.h +$(obj)/xen_action_hooks.o: $(obj)/config.h -.PHONY: $(LIVEPATCH_ACTION_HOOKS) -$(LIVEPATCH_ACTION_HOOKS): xen_action_hooks.o xen_hello_world_func.o note.o xen_note.o - $(LD) $(LDFLAGS) $(build_id_linker) -r -o $(LIVEPATCH_ACTION_HOOKS) $^ +extra-y += xen_action_hooks.livepatch +xen_action_hooks-objs := xen_action_hooks.o xen_hello_world_func.o note.o xen_note.o -xen_action_hooks_nofunc.o: config.h +$(obj)/xen_action_hooks_nofunc.o: $(obj)/config.h -.PHONY: $(LIVEPATCH_ACTION_HOOKS_NOFUNC) -$(LIVEPATCH_ACTION_HOOKS_NOFUNC): xen_action_hooks_nofunc.o note.o xen_note.o - $(LD) $(LDFLAGS) $(build_id_linker) -r -o $(LIVEPATCH_ACTION_HOOKS_NOFUNC) $^ +extra-y += xen_action_hooks_nofunc.livepatch +xen_action_hooks_nofunc-objs := xen_action_hooks_nofunc.o note.o xen_note.o -xen_action_hooks_marker.o: config.h +$(obj)/xen_action_hooks_marker.o: $(obj)/config.h -.PHONY: $(LIVEPATCH_ACTION_HOOKS_MARKER) -$(LIVEPATCH_ACTION_HOOKS_MARKER): xen_action_hooks_marker.o xen_hello_world_func.o note.o xen_note.o - $(LD) $(LDFLAGS) $(build_id_linker) -r -o $(LIVEPATCH_ACTION_HOOKS_MARKER) $^ +extra-y += xen_action_hooks_marker.livepatch +xen_action_hooks_marker-objs := xen_action_hooks_marker.o xen_hello_world_func.o note.o xen_note.o -xen_action_hooks_noapply.o: config.h +$(obj)/xen_action_hooks_noapply.o: $(obj)/config.h -.PHONY: $(LIVEPATCH_ACTION_HOOKS_NOAPPLY) -$(LIVEPATCH_ACTION_HOOKS_NOAPPLY): xen_action_hooks_marker.o xen_hello_world_func.o note.o xen_note.o - $(LD) $(LDFLAGS) $(build_id_linker) -r -o $(LIVEPATCH_ACTION_HOOKS_NOAPPLY) $^ +extra-y += xen_action_hooks_noapply.livepatch +xen_action_hooks_noapply-objs := xen_action_hooks_marker.o xen_hello_world_func.o note.o xen_note.o -xen_action_hooks_norevert.o: config.h +$(obj)/xen_action_hooks_norevert.o: $(obj)/config.h -.PHONY: $(LIVEPATCH_ACTION_HOOKS_NOREVERT) -$(LIVEPATCH_ACTION_HOOKS_NOREVERT): xen_action_hooks_marker.o xen_hello_world_func.o note.o xen_note.o - $(LD) $(LDFLAGS) $(build_id_linker) -r -o $(LIVEPATCH_ACTION_HOOKS_NOREVERT) $^ +extra-y += xen_action_hooks_norevert.livepatch +xen_action_hooks_norevert-objs := xen_action_hooks_marker.o xen_hello_world_func.o note.o xen_note.o EXPECT_BYTES_COUNT := 8 CODE_GET_EXPECT=$(shell $(OBJDUMP) -d --insn-width=1 $(1) | sed -n -e '/<'$(2)'>:$$/,/^$$/ p' | tail -n +2 | head -n $(EXPECT_BYTES_COUNT) | awk '{$$0=$$2; printf "%s", substr($$0,length-1)}' | sed 's/.\{2\}/0x&,/g' | sed 's/^/{/;s/,$$/}/g') -.PHONY: expect_config.h -expect_config.h: EXPECT_BYTES=$(call CODE_GET_EXPECT,$(BASEDIR)/xen-syms,xen_extra_version) -expect_config.h: +$(obj)/expect_config.h: $(BASEDIR)/xen-syms (set -e; \ - echo "#define EXPECT_BYTES $(EXPECT_BYTES)"; \ + echo "#define EXPECT_BYTES $(call CODE_GET_EXPECT,$<,xen_extra_version)"; \ echo "#define EXPECT_BYTES_COUNT $(EXPECT_BYTES_COUNT)") > $@ -xen_expectations.o: expect_config.h +$(obj)/xen_expectations.o: $(obj)/expect_config.h -.PHONY: $(LIVEPATCH_EXPECTATIONS) -$(LIVEPATCH_EXPECTATIONS): xen_expectations.o xen_hello_world_func.o note.o xen_note.o - $(LD) $(LDFLAGS) $(build_id_linker) -r -o $(LIVEPATCH_EXPECTATIONS) $^ +extra-y += xen_expectations.livepatch +xen_expectations-objs := xen_expectations.o xen_hello_world_func.o note.o xen_note.o -.PHONY: $(LIVEPATCH_EXPECTATIONS_FAIL) -$(LIVEPATCH_EXPECTATIONS_FAIL): xen_expectations_fail.o xen_hello_world_func.o note.o xen_note.o - $(LD) $(LDFLAGS) $(build_id_linker) -r -o $(LIVEPATCH_EXPECTATIONS_FAIL) $^ +extra-y += xen_expectations_fail.livepatch +xen_expectations_fail-objs := xen_expectations_fail.o xen_hello_world_func.o note.o xen_note.o + + +quiet_cmd_livepatch = LD $@ +cmd_livepatch = $(LD) $(XEN_LDFLAGS) $(build_id_linker) -r -o $@ $(real-prereqs) + +$(obj)/%.livepatch: FORCE + $(call if_changed,livepatch) + +$(call multi_depend, $(filter %.livepatch,$(extra-y)), .livepatch, -objs) +targets += $(sort $(foreach m,$(basename $(notdir $(filter %.livepatch,$(extra-y)))), \ + $($(m)-objs))) + +LIVEPATCHES := $(filter %.livepatch,$(extra-y)) + +LIVEPATCH_DEBUG_DIR ?= $(DEBUG_DIR)/xen-livepatch .PHONY: livepatch -livepatch: $(LIVEPATCH) $(LIVEPATCH_BYE) $(LIVEPATCH_REPLACE) $(LIVEPATCH_NOP) $(LIVEPATCH_NO_XEN_BUILDID) \ - $(LIVEPATCH_PREPOST_HOOKS) $(LIVEPATCH_PREPOST_HOOKS_FAIL) $(LIVEPATCH_ACTION_HOOKS) \ - $(LIVEPATCH_ACTION_HOOKS_NOFUNC) $(LIVEPATCH_ACTION_HOOKS_MARKER) $(LIVEPATCH_ACTION_HOOKS_NOAPPLY) \ - $(LIVEPATCH_ACTION_HOOKS_NOREVERT) $(LIVEPATCH_EXPECTATIONS) $(LIVEPATCH_EXPECTATIONS_FAIL) +livepatch: $(LIVEPATCHES) + +install: $(addprefix $(obj)/,$(LIVEPATCHES)) + $(INSTALL_DIR) $(DESTDIR)$(LIVEPATCH_DEBUG_DIR) + $(INSTALL_DATA) $(addprefix $(obj)/,$(LIVEPATCHES)) $(DESTDIR)$(LIVEPATCH_DEBUG_DIR) + +uninstall: + cd $(DESTDIR)$(LIVEPATCH_DEBUG_DIR) && rm -f $(LIVEPATCHES) + +.PHONY: clean +clean:: + rm -f *.o .*.o.d *.livepatch config.h expect_config.h -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Thu Jul 01 14:21:43 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 14:21:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148784.275072 (Exim 4.92) (envelope-from ) id 1lyxZX-0002jG-OV; Thu, 01 Jul 2021 14:21:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148784.275072; Thu, 01 Jul 2021 14:21:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyxZX-0002gM-8e; Thu, 01 Jul 2021 14:21:43 +0000 Received: by outflank-mailman (input) for mailman id 148784; Thu, 01 Jul 2021 14:21:41 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyxRD-0005F9-Na for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 14:13:07 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 3b5a5f69-da76-11eb-8329-12813bfff9fa; Thu, 01 Jul 2021 14:11:31 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3b5a5f69-da76-11eb-8329-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1625148691; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=CtRalG/rFOQIYxbwoHgfh6QYWVwTFjvwiv9qJRymPB4=; b=BvC/kxtgp+ZZGHJ7RQnkw9TtvgRaLMN/k/BTi9tbkOenesMiE6m3bJFj /FvDOtvKznlFuLgy5UfHw85TWleo3JjVkGp76mEnsuES+ytaNRsfcDpWO WpnaEjj6/6oMTwCboedwv4YC3IdnMBeAC2vHuqzm3bLOhCoHK9DqL4Q2c I=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: hLraOvlV2hORj0lqUItCLBjZMvgB6Np5KQPQmbLQq7tRXZDkSZqLXMNuP5nJX0jwLPLTi+GI8h 2wc2Rx6pQ3QQKSVTCRtnliw8GKo5seGDbzPoA8KRhfOde0K5cK7GRvOMmVihKoYULs7Tvu5m8y +p66ShJfuBdsQ6kzRQn2bMaIhoNd1yXwEkIVhcPSS0vEt/u7Rhk8tWEuWXbtUp1gQYTNBv4j8G Dqc6PmRbcbpZGEAJ0wPj/4YOScR8+96Q947kR0pTcQr13mJbEUF6HMVVEhgjM4ZP2q9V+anktx ZT8= X-SBRS: 5.1 X-MesageID: 47755476 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:/igxba3JE7yzpCgXmBPKpAqjBIokLtp133Aq2lEZdPRUGvb3qy nIpoV86faUskdoZJhOo7C90cW7LU80sKQFhLX5Xo3SOzUO2lHYT72KhLGKq1aLdhEWtNQtsZ uIG5IOceEYZmIasS+V2maF+q4bsbu6zJw= X-IronPort-AV: E=Sophos;i="5.83,314,1616472000"; d="scan'208";a="47755476" From: Anthony PERARD To: CC: Anthony PERARD , Andrew Cooper , George Dunlap , "Ian Jackson" , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Volodymyr Babchuk , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [XEN PATCH v6 24/31] build: set ALL_OBJS to main Makefile; move prelink.o to main Makefile Date: Thu, 1 Jul 2021 15:10:04 +0100 Message-ID: <20210701141011.785641-25-anthony.perard@citrix.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210701141011.785641-1-anthony.perard@citrix.com> References: <20210701141011.785641-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain This is to avoid arch/$arch/Makefile having to recurse into parents directories. This avoid duplication of the logic to build prelink.o between arches. In order to do that, we cut the $(TARGET) target in the main Makefile in two, there is a "prepare" phase/target runned before starting to build "prelink.o" which will prepare "include/" among other things, the all the $(ALL_OBJS) will be generated in order to build "prelink.o" and finally $(TARGET) will be generated by calling into "arch/*/" to make $(TARGET). Now we don't need to prefix $(ALL_OBJS) with $(BASEDIR) as it is now only used from the main Makefile. Other changes is using "$<" instead of spelling "prelink.o" in the target "$(TARGET)" in both arch/*/Makefile. Beside "prelink.o" been at a different location, no other functional change intended. Signed-off-by: Anthony PERARD --- xen/Makefile | 41 ++++++++++++++++++++++++++++++++++++++++- xen/Rules.mk | 13 ------------- xen/arch/arm/Makefile | 31 ++++--------------------------- xen/arch/arm/arch.mk | 2 ++ xen/arch/x86/Makefile | 27 +++++---------------------- xen/arch/x86/arch.mk | 2 ++ 6 files changed, 53 insertions(+), 63 deletions(-) diff --git a/xen/Makefile b/xen/Makefile index 4c4990a753df..fd002ecd52d0 100644 --- a/xen/Makefile +++ b/xen/Makefile @@ -269,8 +269,21 @@ CFLAGS += -flto LDFLAGS-$(CONFIG_CC_IS_CLANG) += -plugin LLVMgold.so endif +# Note that link order matters! +ALL_OBJS-y := common/built_in.o +ALL_OBJS-y += drivers/built_in.o +ALL_OBJS-y += lib/built_in.o +ALL_OBJS-y += xsm/built_in.o +ALL_OBJS-y += arch/$(TARGET_ARCH)/built_in.o +ALL_OBJS-$(CONFIG_CRYPTO) += crypto/built_in.o + +ALL_LIBS-y := lib/lib.a + include $(BASEDIR)/arch/$(TARGET_ARCH)/arch.mk +export ALL_OBJS := $(ALL_OBJS-y) +export ALL_LIBS := $(ALL_LIBS-y) + # define new variables to avoid the ones defined in Config.mk export XEN_CFLAGS := $(CFLAGS) export XEN_AFLAGS := $(AFLAGS) @@ -378,7 +391,8 @@ $(TARGET).gz: $(TARGET) gzip -n -f -9 < $< > $@.new mv $@.new $@ -$(TARGET): FORCE +PHONY += prepare +prepare: $(MAKE) -C tools $(MAKE) -f $(BASEDIR)/Rules.mk include/xen/compile.h [ -e arch/$(TARGET_ARCH)/efi ] && for f in $$(cd common/efi; echo *.[ch]); \ @@ -389,6 +403,31 @@ $(TARGET): FORCE $(MAKE) -f $(BASEDIR)/Rules.mk -C include $(MAKE) -f $(BASEDIR)/Rules.mk -C arch/$(TARGET_ARCH) include $(MAKE) -f $(BASEDIR)/Rules.mk include/arch-$(TARGET_ARCH)/asm/asm-offsets.h + +$(ALL_OBJS) $(ALL_LIBS): prepare + +# head.o is built by descending into arch/arm/$(TARGET_SUBARCH), depends on the +# part of $(ALL_OBJS) that will eventually recurse into $(TARGET_SUBARCH)/ and +# build head.o +arch/arm/$(TARGET_SUBARCH)/head.o: arch/arm/built_in.o +arch/arm/$(TARGET_SUBARCH)/head.o: ; + +ifeq ($(CONFIG_LTO),y) +# Gather all LTO objects together +prelink_lto.o: $(ALL_OBJS) $(ALL_LIBS) + $(LD_LTO) -r -o $@ $(filter-out %.a,$^) --start-group $(filter %.a,$^) --end-group + +# Link it with all the binary objects +prelink.o: $(patsubst %/built_in.o,%/built_in_bin.o,$(ALL_OBJS)) prelink_lto.o FORCE + $(call if_changed,ld) +else +prelink.o: $(ALL_OBJS) $(ALL_LIBS) FORCE + $(call if_changed,ld) +endif + +targets += prelink.o + +$(TARGET): prelink.o FORCE $(MAKE) -f $(BASEDIR)/Rules.mk -C arch/$(TARGET_ARCH) $@ quiet_cmd_banner = BANNER $@ diff --git a/xen/Rules.mk b/xen/Rules.mk index 894f2b83a04e..530aefa43ad9 100644 --- a/xen/Rules.mk +++ b/xen/Rules.mk @@ -11,25 +11,12 @@ include $(BASEDIR)/scripts/Kbuild.include TARGET := $(BASEDIR)/xen -# Note that link order matters! -ALL_OBJS-y += $(BASEDIR)/common/built_in.o -ALL_OBJS-y += $(BASEDIR)/drivers/built_in.o -ALL_OBJS-y += $(BASEDIR)/lib/built_in.o -ALL_OBJS-y += $(BASEDIR)/xsm/built_in.o -ALL_OBJS-y += $(BASEDIR)/arch/$(TARGET_ARCH)/built_in.o -ALL_OBJS-$(CONFIG_CRYPTO) += $(BASEDIR)/crypto/built_in.o - -ALL_LIBS-y := $(BASEDIR)/lib/lib.a - # Initialise some variables lib-y := targets := CFLAGS-y := AFLAGS-y := -ALL_OBJS := $(ALL_OBJS-y) -ALL_LIBS := $(ALL_LIBS-y) - SPECIAL_DATA_SECTIONS := rodata $(foreach a,1 2 4 8 16, \ $(foreach w,1 2 4, \ rodata.str$(w).$(a)) \ diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile index dc1d09c8b429..067c0d9844e4 100644 --- a/xen/arch/arm/Makefile +++ b/xen/arch/arm/Makefile @@ -73,14 +73,6 @@ ifneq ($(CONFIG_DTB_FILE),"") obj-y += dtb.o endif -ALL_OBJS := $(TARGET_SUBARCH)/head.o $(ALL_OBJS) - -# head.o is built by descending into the sub-directory, depends on the part of -# $(ALL_OBJS) that will eventually recurse into $(TARGET_SUBARCH)/ and build -# head.o -$(TARGET_SUBARCH)/head.o: $(BASEDIR)/arch/arm/built_in.o -$(TARGET_SUBARCH)/head.o: ; - ifdef CONFIG_LIVEPATCH all_symbols = --all-symbols ifdef CONFIG_FAST_SYMBOL_LOOKUP @@ -96,33 +88,18 @@ ifeq ($(CONFIG_ARM_64),y) ln -sf $(@F) $@.efi endif -ifeq ($(CONFIG_LTO),y) -# Gather all LTO objects together -prelink_lto.o: $(ALL_OBJS) $(ALL_LIBS) - $(LD_LTO) -r -o $@ $(filter-out %.a,$^) --start-group $(filter %.a,$^) --end-group - -# Link it with all the binary objects -prelink.o: $(patsubst %/built_in.o,%/built_in_bin.o,$(ALL_OBJS)) prelink_lto.o - $(call if_changed,ld) -else -prelink.o: $(ALL_OBJS) $(ALL_LIBS) FORCE - $(call if_changed,ld) -endif - -targets += prelink.o - -$(TARGET)-syms: prelink.o xen.lds - $(LD) $(XEN_LDFLAGS) -T xen.lds -N prelink.o \ +$(TARGET)-syms: $(BASEDIR)/prelink.o xen.lds + $(LD) $(XEN_LDFLAGS) -T xen.lds -N $< \ $(BASEDIR)/common/symbols-dummy.o -o $(@D)/.$(@F).0 $(NM) -pa --format=sysv $(@D)/.$(@F).0 \ | $(BASEDIR)/tools/symbols $(all_symbols) --sysv --sort >$(@D)/.$(@F).0.S $(MAKE) -f $(BASEDIR)/Rules.mk $(@D)/.$(@F).0.o - $(LD) $(XEN_LDFLAGS) -T xen.lds -N prelink.o \ + $(LD) $(XEN_LDFLAGS) -T xen.lds -N $< \ $(@D)/.$(@F).0.o -o $(@D)/.$(@F).1 $(NM) -pa --format=sysv $(@D)/.$(@F).1 \ | $(BASEDIR)/tools/symbols $(all_symbols) --sysv --sort >$(@D)/.$(@F).1.S $(MAKE) -f $(BASEDIR)/Rules.mk $(@D)/.$(@F).1.o - $(LD) $(XEN_LDFLAGS) -T xen.lds -N prelink.o $(build_id_linker) \ + $(LD) $(XEN_LDFLAGS) -T xen.lds -N $< $(build_id_linker) \ $(@D)/.$(@F).1.o -o $@ $(NM) -pa --format=sysv $(@D)/$(@F) \ | $(BASEDIR)/tools/symbols --all-symbols --xensyms --sysv --sort \ diff --git a/xen/arch/arm/arch.mk b/xen/arch/arm/arch.mk index f54e602301be..8a2b202f698e 100644 --- a/xen/arch/arm/arch.mk +++ b/xen/arch/arm/arch.mk @@ -26,3 +26,5 @@ ifeq ($(CONFIG_ARM64_ERRATUM_843419),y) LDFLAGS += --fix-cortex-a53-843419 endif endif + +ALL_OBJS-y := arch/arm/$(TARGET_SUBARCH)/head.o $(ALL_OBJS-y) diff --git a/xen/arch/x86/Makefile b/xen/arch/x86/Makefile index d84062f48dfa..3bd302d28ccf 100644 --- a/xen/arch/x86/Makefile +++ b/xen/arch/x86/Makefile @@ -161,37 +161,20 @@ endif # $(XEN_BUILD_PE) endif # $(efi-y) -ALL_OBJS := $(BASEDIR)/arch/x86/boot/built_in.o $(BASEDIR)/arch/x86/efi/built_in.o $(ALL_OBJS) - -ifeq ($(CONFIG_LTO),y) -# Gather all LTO objects together -prelink_lto.o: $(ALL_OBJS) $(ALL_LIBS) - $(LD_LTO) -r -o $@ $(filter-out %.a,$^) --start-group $(filter %.a,$^) --end-group - -# Link it with all the binary objects -prelink.o: $(patsubst %/built_in.o,%/built_in_bin.o,$(ALL_OBJS)) prelink_lto.o FORCE - $(call if_changed,ld) -else -prelink.o: $(ALL_OBJS) $(ALL_LIBS) FORCE - $(call if_changed,ld) -endif - -targets += prelink.o - -$(TARGET)-syms: prelink.o xen.lds - $(LD) $(XEN_LDFLAGS) -T xen.lds -N prelink.o $(build_id_linker) \ +$(TARGET)-syms: $(BASEDIR)/prelink.o xen.lds + $(LD) $(XEN_LDFLAGS) -T xen.lds -N $< $(build_id_linker) \ $(BASEDIR)/common/symbols-dummy.o -o $(@D)/.$(@F).0 $(NM) -pa --format=sysv $(@D)/.$(@F).0 \ | $(BASEDIR)/tools/symbols $(all_symbols) --sysv --sort \ >$(@D)/.$(@F).0.S $(MAKE) -f $(BASEDIR)/Rules.mk $(@D)/.$(@F).0.o - $(LD) $(XEN_LDFLAGS) -T xen.lds -N prelink.o $(build_id_linker) \ + $(LD) $(XEN_LDFLAGS) -T xen.lds -N $< $(build_id_linker) \ $(@D)/.$(@F).0.o -o $(@D)/.$(@F).1 $(NM) -pa --format=sysv $(@D)/.$(@F).1 \ | $(BASEDIR)/tools/symbols $(all_symbols) --sysv --sort $(syms-warn-dup-y) \ >$(@D)/.$(@F).1.S $(MAKE) -f $(BASEDIR)/Rules.mk $(@D)/.$(@F).1.o - $(LD) $(XEN_LDFLAGS) -T xen.lds -N prelink.o $(build_id_linker) \ + $(LD) $(XEN_LDFLAGS) -T xen.lds -N $< $(build_id_linker) \ $(@D)/.$(@F).1.o -o $@ $(NM) -pa --format=sysv $(@D)/$(@F) \ | $(BASEDIR)/tools/symbols --all-symbols --xensyms --sysv --sort \ @@ -242,7 +225,7 @@ note_file_option ?= $(note_file) ifeq ($(XEN_BUILD_PE),y) extra-y += efi.lds -$(TARGET).efi: prelink.o $(note_file) efi.lds efi/relocs-dummy.o efi/mkreloc +$(TARGET).efi: $(BASEDIR)/prelink.o $(note_file) efi.lds efi/relocs-dummy.o efi/mkreloc ifeq ($(CONFIG_DEBUG_INFO),y) $(if $(filter --strip-debug,$(EFI_LDFLAGS)),echo,:) "Will strip debug info from $(@F)" endif diff --git a/xen/arch/x86/arch.mk b/xen/arch/x86/arch.mk index 5a4a1704636f..c95caa303db8 100644 --- a/xen/arch/x86/arch.mk +++ b/xen/arch/x86/arch.mk @@ -67,3 +67,5 @@ endif # Set up the assembler include path properly for older toolchains. CFLAGS += -Wa,-I$(BASEDIR)/include + +ALL_OBJS-y := arch/x86/boot/built_in.o arch/x86/efi/built_in.o $(ALL_OBJS-y) -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Thu Jul 01 14:21:45 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 14:21:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148785.275080 (Exim 4.92) (envelope-from ) id 1lyxZY-0002uU-P9; Thu, 01 Jul 2021 14:21:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148785.275080; Thu, 01 Jul 2021 14:21:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyxZY-0002rG-21; Thu, 01 Jul 2021 14:21:44 +0000 Received: by outflank-mailman (input) for mailman id 148785; Thu, 01 Jul 2021 14:21:41 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyxRb-0005tj-5G for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 14:13:31 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 5d4dca46-106a-46ea-9165-196c4265a912; Thu, 01 Jul 2021 14:11:54 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5d4dca46-106a-46ea-9165-196c4265a912 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1625148714; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=6rzhumebECyq+XiEsQEAKIp6M61wPTFJkWWEM129pgo=; b=AFGokSHhDEgAP8thXEvGJHRfizIv4LXicz2NLK2MyX95HscgnWKvB1d+ 8xjc4XMjk/c4a+yDhQdaLANMCR8dgs4lQvsVo1ROk+FxV45EtfNyPR7WO 8jwJdsChaSv9HAH0A2vDe7MHgqfr5Q0C1xbskLI/ldec7eN6lUROWSYjI c=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: beZsAYtNPf2SM4Ps0NfM6EpbWKc4iQA7fVx7nNYGwHqBAdQC659W00WQSrlxFzDDBJoY9XD9Ro M8ZCP8a3zIeKsPnDGdPX3Wp6aTYC1+DqClpsg0mJdvUIbi/SfZcPcOIeg+UmpyBKKQY0VNK/NL +iHo3AVMih1F+amcAVNC5ChIVGBYZYZ6fbD7z/2BI3r5s+fSore5mYyyCAm0Sn4jTD/g7C3inT fwZBjnKWlAhcdbp3hs+1h/8JNcAlkbnY6VooLi9CQ31CwnY61U9FppeH1BH/4p+4q96ZAB7Fxc mMQ= X-SBRS: 5.1 X-MesageID: 47376243 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:dtuHaKFnMr5sYYKKpLqE0MeALOsnbusQ8zAXP0AYc3Jom6uj5q aTdZUgpGfJYVkqOE3I9ertBEDEewK4yXcX2/h3AV7BZniEhILAFugLhuGO/9SjIVybygc079 YYT0EUMrzN5DZB4voSmDPIceod/A== X-IronPort-AV: E=Sophos;i="5.83,314,1616472000"; d="scan'208";a="47376243" From: Anthony PERARD To: CC: Anthony PERARD , Bob Eshleman , Alistair Francis , Connor Davis Subject: [XEN PATCH v6 31/31] build,riscv: tell the build system about riscv64/head.S Date: Thu, 1 Jul 2021 15:10:11 +0100 Message-ID: <20210701141011.785641-32-anthony.perard@citrix.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210701141011.785641-1-anthony.perard@citrix.com> References: <20210701141011.785641-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain This allows to `make arch/riscv/riscv64/head.o`. Example of rune on a fresh copy of the repository: make XEN_TARGET_ARCH=riscv64 CROSS_COMPILE=riscv64-linux-gnu- KBUILD_DEFCONFIG=tiny64_defconfig arch/riscv/riscv64/head.o Signed-off-by: Anthony PERARD --- xen/arch/riscv/riscv64/Makefile | 1 + 1 file changed, 1 insertion(+) create mode 100644 xen/arch/riscv/riscv64/Makefile diff --git a/xen/arch/riscv/riscv64/Makefile b/xen/arch/riscv/riscv64/Makefile new file mode 100644 index 000000000000..15a4a65f6615 --- /dev/null +++ b/xen/arch/riscv/riscv64/Makefile @@ -0,0 +1 @@ +extra-y += head.o -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Thu Jul 01 14:21:45 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 14:21:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148786.275086 (Exim 4.92) (envelope-from ) id 1lyxZZ-00036P-DP; Thu, 01 Jul 2021 14:21:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148786.275086; Thu, 01 Jul 2021 14:21:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyxZZ-00033E-0w; Thu, 01 Jul 2021 14:21:45 +0000 Received: by outflank-mailman (input) for mailman id 148786; Thu, 01 Jul 2021 14:21:42 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyxQY-0005tj-3C for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 14:12:26 +0000 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 15a5bb7c-acdc-4168-94ea-f77cf4018776; Thu, 01 Jul 2021 14:11:00 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 15a5bb7c-acdc-4168-94ea-f77cf4018776 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1625148660; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=VYtJdbyxr0lMfwQQB1MSi1pDA6ObAawqWdtJQrYS9po=; b=RZ/AqPFO3RtE2bZM2a+6ZjsbgbADUyMHPIDxzmx6D5qKXQhpI1vjhDId RAUPCyKWq8X3Mugkan2g73J+wRj90HQHgOY3K0TP9T0a0EUu84Q3lfx/T GT+3ZCXDbjxdhjWhOe4heqipxkx69anfEIwsBU1CB+01THxdbpZ9JmznZ k=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: gCca3NaYK5NXXlP8zzfd2Es4Q6xWeJKic81AuQvAcHairi0uqKEAhynP3h64VNELTzpd3ikKwM vEVBgmeZRmBSvAyOtMBkdqIRtxmfnlfe8ZP0vs+dv+3xKahhvusr5uPnPLxK5aAub7l+1/oDfa BKz61EK8oqKIwfan9lo0UbG9P6X/ZIoT/8Os/0uk5ubJm4MfIUSkj7bEuX5Gusb7hwVKCGIHa3 dTrlNQNp5zX7EXEdjmsk4Vqa3e0kpl+/WKUdJaFqvP2j4Syp3PEJqcmQEvlNOqc/MUrwC+xJxw 2L4= X-SBRS: 5.1 X-MesageID: 47384444 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:zoJpmqosS7oNlMtgtLh3LAYaV5rReYIsimQD101hICG9Evb0qy lhppQmPH7P+VIssRQb8+xoV5PufZqxz/BICOoqTNKftWvdyQiVxehZhOOP/9SJIUbDH4VmpM VdmsZFaeEZDTJB/LvHCAvTKadd/DFQmprY+ts3zB1WPH9Xg7kL1XYfNu4CeHcGPzWvA/ACZf yhz/sCnRWMU1INYP+2A3EUNtKz3eEixPrdEGc77wdM0nj3sQ+V X-IronPort-AV: E=Sophos;i="5.83,314,1616472000"; d="scan'208";a="47384444" From: Anthony PERARD To: CC: Anthony PERARD , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [XEN PATCH v6 25/31] build: remove unneeded deps of x86_emulate.o Date: Thu, 1 Jul 2021 15:10:05 +0100 Message-ID: <20210701141011.785641-26-anthony.perard@citrix.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210701141011.785641-1-anthony.perard@citrix.com> References: <20210701141011.785641-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Those two dependencies already exist so make doesn't need to know about them. The dependency will be generated by $(CC). Signed-off-by: Anthony PERARD --- xen/arch/x86/Makefile | 1 - 1 file changed, 1 deletion(-) diff --git a/xen/arch/x86/Makefile b/xen/arch/x86/Makefile index 3bd302d28ccf..fc719247eac9 100644 --- a/xen/arch/x86/Makefile +++ b/xen/arch/x86/Makefile @@ -84,7 +84,6 @@ extra-y += xen.lds ifneq ($(CONFIG_HVM),y) x86_emulate.o: CFLAGS-y += -Wno-unused-label endif -x86_emulate.o: x86_emulate/x86_emulate.c x86_emulate/x86_emulate.h efi-y := $(shell if [ ! -r $(BASEDIR)/include/xen/compile.h -o \ -O $(BASEDIR)/include/xen/compile.h ]; then \ -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Thu Jul 01 14:21:47 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 14:21:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148792.275101 (Exim 4.92) (envelope-from ) id 1lyxZb-0003gP-CC; Thu, 01 Jul 2021 14:21:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148792.275101; Thu, 01 Jul 2021 14:21:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyxZb-0003ed-14; Thu, 01 Jul 2021 14:21:47 +0000 Received: by outflank-mailman (input) for mailman id 148792; Thu, 01 Jul 2021 14:21:45 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyxR8-0005F9-NK for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 14:13:02 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 3b5a5f68-da76-11eb-8329-12813bfff9fa; Thu, 01 Jul 2021 14:11:30 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3b5a5f68-da76-11eb-8329-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1625148690; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=dwFmFNnNGaBSF9VKRHGAEd86YUDOMJh2c843ZdLeZ+U=; b=UaT1H5wWuAlS8O4fXfRyOffTdO5CO12l8DM3eTC0PdaXiCVqRaylTdNa uRp9Cqq75uKmJsVkczMyS2ZNRI6MlcL8qazTZ/YGq64hDGxVQbAVr9Qjt dLY+e5K9ZAq0+8AJzcxh6X6tA9PkMo8xchxsKddHzMKZ4dNsaR2nmkGoY 8=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: j9+odOWZg4WcY/KWgEG94tzUNJeVT2HdKgX+qswkboAx+QonpZd9WL3w2XDUoAzi684TV5EWTb GOREf2oposR+Kt+yYxPmp/+USQMe37X2fPaofRQg72ypwUaIKEcmOl1XGtkfsdf2+37Q/XceCh GquF6WT4xVEVhSC7JWg95l1kleCPLNwV9EFwE4dkWcirzPHucNuUmjjdYqf6hwjoxa2WsQacUW +AszIaVkwXz3HCPSr31vNhycyAEc7xmH6jBIK+ZJVvmoEq0sHCr7cAN+nnGD+wvvzpxA4szQkK jIc= X-SBRS: 5.1 X-MesageID: 47755474 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:/x1tbK+wxuMrCvGmQSZuk+DgI+orL9Y04lQ7vn2YSXRuHPBw8P re+sjztCWE8Ar5N0tBpTntAsW9qDbnhPtICOoqTNCftWvdyQiVxehZhOOIqVDd8m/Fh4pgPM 9bAtFD4bbLbGSS4/yU3ODBKadD/OW6 X-IronPort-AV: E=Sophos;i="5.83,314,1616472000"; d="scan'208";a="47755474" From: Anthony PERARD To: CC: Anthony PERARD , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [XEN PATCH v6 23/31] build: fix arch/x86/node.o rule Date: Thu, 1 Jul 2021 15:10:03 +0100 Message-ID: <20210701141011.785641-24-anthony.perard@citrix.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210701141011.785641-1-anthony.perard@citrix.com> References: <20210701141011.785641-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Avoid different spelling for the location of "xen-syms", and simply use the dependency variable. This avoid the assumption about $(TARGET) value. Signed-off-by: Anthony PERARD --- xen/arch/x86/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/x86/Makefile b/xen/arch/x86/Makefile index d3e38e4e9f02..d84062f48dfa 100644 --- a/xen/arch/x86/Makefile +++ b/xen/arch/x86/Makefile @@ -199,7 +199,7 @@ $(TARGET)-syms: prelink.o xen.lds rm -f $(@D)/.$(@F).[0-9]* $(@D)/..$(@F).[0-9]* note.o: $(TARGET)-syms - $(OBJCOPY) -O binary --only-section=.note.gnu.build-id $(BASEDIR)/xen-syms $@.bin + $(OBJCOPY) -O binary --only-section=.note.gnu.build-id $< $@.bin $(OBJCOPY) -I binary -O elf64-x86-64 -B i386:x86-64 \ --rename-section=.data=.note.gnu.build-id -S $@.bin $@ rm -f $@.bin -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Thu Jul 01 14:21:51 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 14:21:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148800.275125 (Exim 4.92) (envelope-from ) id 1lyxZf-0004c3-GI; Thu, 01 Jul 2021 14:21:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148800.275125; Thu, 01 Jul 2021 14:21:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyxZf-0004aL-4a; Thu, 01 Jul 2021 14:21:51 +0000 Received: by outflank-mailman (input) for mailman id 148800; Thu, 01 Jul 2021 14:21:49 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyxQ9-0005tj-2T for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 14:12:01 +0000 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 14314842-9033-4700-8274-ee518aa90883; Thu, 01 Jul 2021 14:10:50 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 14314842-9033-4700-8274-ee518aa90883 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1625148650; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=wMjlawSRiHWoCe7r05Ixqb8i36LDLWl65IFqglV03NE=; b=do6jNoofOfnXTttEgepaHSGq5kt9anqnWGtjZzxTgkM1ZO2Ww799UQZS U2Jskkcj+nlx6MV6ZDNCC922rAWy78EW4af/Q/BntHTLpNTz4/2nnteGx bwYqmek8Sl4c/REyHmRYheBpy4WxRGE7BqFTHgJPmBZ/pabi4ropw4JZ7 w=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: KgwEwwFdSBHbhudaD0OB5De4OnkPFINgasweJBn6pR6QQ/NUuqOlmp6gehc6fy/LN+yub+3WJp XzCi6DTGhEu2+nsdMT897ZyEx0H4InQTwmoIdV1NSD+tkJuJukgjQAiDSUh6yJ5FJnlNrK6CGE +4XHn1lDokFsEGeECg0IcP3OgBEJzWfrILQYCdTmveOxs51UaT4L+4XEyqfohwOw//jC/U2Y/o MhY+W9uwbqDrplUwc2mHnf3OOczOxMwr2FrI80eYKHZhZOCI56swkvU7KcnBHSyTGtwvDSlDQu sfY= X-SBRS: 5.1 X-MesageID: 47446833 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:8nisKqj4p6cD5EExsIYXmfKnd3BQXgkji2hC6mlwRA09TyVXrb HMoB19726OtN/LYgBZpTnkAsK9qBznhPlICOUqUotKGTOKhILKFvAa0WKB+UyEJ8SWzIc06U 4jScRD4fLLfDxHZK3BjjVQfexB/DEPm5rDuQ9Rp00dMD2Dt8lbnn1EIzfeMEF7XTNLAodRLv uhDrMtnUvHRZ1uVLXYOkU4 X-IronPort-AV: E=Sophos;i="5.83,314,1616472000"; d="scan'208";a="47446833" From: Anthony PERARD To: CC: Anthony PERARD , Andrew Cooper , George Dunlap , "Ian Jackson" , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Tamas K Lengyel , Alexandru Isaila , Petre Pircalabu , Volodymyr Babchuk , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , "Konrad Rzeszutek Wilk" , Ross Lagerwall , Paul Durrant , Jun Nakajima , "Kevin Tian" , Lukasz Hawrylko , Bob Eshleman , Alistair Francis , Connor Davis Subject: [XEN PATCH v6 18/31] xen: move include/asm-* to include/arch-*/asm Date: Thu, 1 Jul 2021 15:09:58 +0100 Message-ID: <20210701141011.785641-19-anthony.perard@citrix.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210701141011.785641-1-anthony.perard@citrix.com> References: <20210701141011.785641-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit This avoid the need to create the symbolic link "include/asm". Signed-off-by: Anthony PERARD --- Other possible locations that I could think of: include/arch/*/asm arch/*/include/asm --- .gitignore | 5 ++- MAINTAINERS | 36 +++++++++---------- tools/include/Makefile | 2 +- tools/misc/xen-access.c | 4 +-- tools/tests/vhpet/Makefile | 2 +- xen/Makefile | 13 ++++--- xen/arch/arm/README.LinuxPrimitives | 10 +++--- xen/arch/arm/arch.mk | 1 + xen/arch/arm/arm32/head.S | 2 +- xen/arch/arm/arm64/head.S | 2 +- xen/arch/arm/smpboot.c | 2 +- xen/arch/arm/vpsci.c | 2 +- xen/arch/x86/Makefile | 6 ++-- xen/arch/x86/arch.mk | 5 +-- xen/common/efi/runtime.c | 14 ++++---- xen/common/page_alloc.c | 2 +- xen/include/{asm-arm => arch-arm/asm}/acpi.h | 0 .../{asm-arm => arch-arm/asm}/alternative.h | 0 .../{asm-arm => arch-arm/asm}/altp2m.h | 0 .../{asm-arm => arch-arm/asm}/arm32/atomic.h | 0 .../{asm-arm => arch-arm/asm}/arm32/bitops.h | 0 .../{asm-arm => arch-arm/asm}/arm32/bug.h | 0 .../{asm-arm => arch-arm/asm}/arm32/cmpxchg.h | 0 .../asm}/arm32/flushtlb.h | 0 .../{asm-arm => arch-arm/asm}/arm32/insn.h | 0 .../{asm-arm => arch-arm/asm}/arm32/io.h | 0 .../{asm-arm => arch-arm/asm}/arm32/macros.h | 0 .../{asm-arm => arch-arm/asm}/arm32/mm.h | 0 .../{asm-arm => arch-arm/asm}/arm32/page.h | 0 .../asm}/arm32/processor.h | 0 .../{asm-arm => arch-arm/asm}/arm32/sysregs.h | 0 .../{asm-arm => arch-arm/asm}/arm32/system.h | 0 .../{asm-arm => arch-arm/asm}/arm32/traps.h | 0 .../{asm-arm => arch-arm/asm}/arm32/vfp.h | 0 .../{asm-arm => arch-arm/asm}/arm64/atomic.h | 0 .../{asm-arm => arch-arm/asm}/arm64/bitops.h | 0 .../{asm-arm => arch-arm/asm}/arm64/brk.h | 0 .../{asm-arm => arch-arm/asm}/arm64/bug.h | 0 .../{asm-arm => arch-arm/asm}/arm64/cmpxchg.h | 0 .../{asm-arm => arch-arm/asm}/arm64/efibind.h | 0 .../asm}/arm64/flushtlb.h | 0 .../{asm-arm => arch-arm/asm}/arm64/hsr.h | 0 .../{asm-arm => arch-arm/asm}/arm64/insn.h | 0 .../{asm-arm => arch-arm/asm}/arm64/io.h | 0 .../{asm-arm => arch-arm/asm}/arm64/macros.h | 0 .../{asm-arm => arch-arm/asm}/arm64/mm.h | 0 .../{asm-arm => arch-arm/asm}/arm64/page.h | 0 .../asm}/arm64/processor.h | 0 .../{asm-arm => arch-arm/asm}/arm64/sysregs.h | 0 .../{asm-arm => arch-arm/asm}/arm64/system.h | 0 .../{asm-arm => arch-arm/asm}/arm64/traps.h | 0 .../{asm-arm => arch-arm/asm}/arm64/vfp.h | 0 .../{asm-arm => arch-arm/asm}/asm_defns.h | 0 .../{asm-arm => arch-arm/asm}/atomic.h | 0 .../{asm-arm => arch-arm/asm}/bitops.h | 0 xen/include/{asm-arm => arch-arm/asm}/bug.h | 0 .../{asm-arm => arch-arm/asm}/byteorder.h | 0 xen/include/{asm-arm => arch-arm/asm}/cache.h | 0 .../{asm-arm => arch-arm/asm}/cadence-uart.h | 0 .../{asm-arm => arch-arm/asm}/config.h | 0 .../{asm-arm => arch-arm/asm}/cpregs.h | 0 .../{asm-arm => arch-arm/asm}/cpuerrata.h | 0 .../{asm-arm => arch-arm/asm}/cpufeature.h | 0 .../{asm-arm => arch-arm/asm}/current.h | 0 .../{asm-arm => arch-arm/asm}/debugger.h | 0 xen/include/{asm-arm => arch-arm/asm}/delay.h | 0 xen/include/{asm-arm => arch-arm/asm}/desc.h | 0 .../{asm-arm => arch-arm/asm}/device.h | 0 xen/include/{asm-arm => arch-arm/asm}/div64.h | 0 .../{asm-arm => arch-arm/asm}/domain.h | 0 .../{asm-arm => arch-arm/asm}/domain_build.h | 0 .../{asm-arm => arch-arm/asm}/early_printk.h | 0 .../{asm-arm => arch-arm/asm}/efibind.h | 0 xen/include/{asm-arm => arch-arm/asm}/elf.h | 0 xen/include/{asm-arm => arch-arm/asm}/event.h | 0 .../asm}/exynos4210-uart.h | 0 .../{asm-arm => arch-arm/asm}/flushtlb.h | 0 xen/include/{asm-arm => arch-arm/asm}/gic.h | 0 .../{asm-arm => arch-arm/asm}/gic_v3_defs.h | 0 .../{asm-arm => arch-arm/asm}/gic_v3_its.h | 0 .../{asm-arm => arch-arm/asm}/grant_table.h | 0 .../{asm-arm => arch-arm/asm}/guest_access.h | 0 .../{asm-arm => arch-arm/asm}/guest_atomics.h | 0 .../{asm-arm => arch-arm/asm}/guest_walk.h | 0 .../{asm-arm => arch-arm/asm}/hardirq.h | 0 xen/include/{asm-arm => arch-arm/asm}/hsr.h | 0 .../{asm-arm => arch-arm/asm}/hypercall.h | 0 xen/include/{asm-arm => arch-arm/asm}/init.h | 0 xen/include/{asm-arm => arch-arm/asm}/insn.h | 0 xen/include/{asm-arm => arch-arm/asm}/io.h | 0 xen/include/{asm-arm => arch-arm/asm}/iocap.h | 0 xen/include/{asm-arm => arch-arm/asm}/iommu.h | 0 .../{asm-arm => arch-arm/asm}/iommu_fwspec.h | 0 xen/include/{asm-arm => arch-arm/asm}/ioreq.h | 0 xen/include/{asm-arm => arch-arm/asm}/irq.h | 0 .../{asm-arm => arch-arm/asm}/kernel.h | 0 .../{asm-arm => arch-arm/asm}/livepatch.h | 0 xen/include/{asm-arm => arch-arm/asm}/lpae.h | 0 .../{asm-arm => arch-arm/asm}/macros.h | 0 .../{asm-arm => arch-arm/asm}/mem_access.h | 0 xen/include/{asm-arm => arch-arm/asm}/mm.h | 0 xen/include/{asm-arm => arch-arm/asm}/mmio.h | 0 .../{asm-arm => arch-arm/asm}/monitor.h | 0 .../{asm-arm => arch-arm/asm}/new_vgic.h | 0 .../{asm-arm => arch-arm/asm}/nospec.h | 0 xen/include/{asm-arm => arch-arm/asm}/numa.h | 0 xen/include/{asm-arm => arch-arm/asm}/p2m.h | 0 .../{asm-arm => arch-arm/asm}/page-bits.h | 0 xen/include/{asm-arm => arch-arm/asm}/page.h | 0 .../{asm-arm => arch-arm/asm}/paging.h | 0 xen/include/{asm-arm => arch-arm/asm}/pci.h | 0 .../{asm-arm => arch-arm/asm}/percpu.h | 0 xen/include/{asm-arm => arch-arm/asm}/perfc.h | 0 .../{asm-arm => arch-arm/asm}/perfc_defn.h | 0 .../{asm-arm => arch-arm/asm}/pl011-uart.h | 0 .../{asm-arm => arch-arm/asm}/platform.h | 0 .../asm}/platforms/exynos5.h | 0 .../asm}/platforms/midway.h | 0 .../asm}/platforms/omap5.h | 0 .../asm}/platforms/vexpress.h | 0 .../asm}/platforms/xilinx-zynqmp-eemi.h | 0 .../{asm-arm => arch-arm/asm}/processor.h | 0 .../{asm-arm => arch-arm/asm}/procinfo.h | 0 xen/include/{asm-arm => arch-arm/asm}/psci.h | 0 .../{asm-arm => arch-arm/asm}/random.h | 0 xen/include/{asm-arm => arch-arm/asm}/regs.h | 0 .../{asm-arm => arch-arm/asm}/scif-uart.h | 0 xen/include/{asm-arm => arch-arm/asm}/setup.h | 0 .../{asm-arm => arch-arm/asm}/short-desc.h | 0 xen/include/{asm-arm => arch-arm/asm}/smccc.h | 0 xen/include/{asm-arm => arch-arm/asm}/smp.h | 0 .../{asm-arm => arch-arm/asm}/softirq.h | 0 .../{asm-arm => arch-arm/asm}/spinlock.h | 0 .../{asm-arm => arch-arm/asm}/string.h | 0 .../{asm-arm => arch-arm/asm}/sysregs.h | 0 .../{asm-arm => arch-arm/asm}/system.h | 0 .../{asm-arm => arch-arm/asm}/tee/optee_msg.h | 0 .../asm}/tee/optee_rpc_cmd.h | 0 .../{asm-arm => arch-arm/asm}/tee/optee_smc.h | 0 .../{asm-arm => arch-arm/asm}/tee/tee.h | 0 xen/include/{asm-arm => arch-arm/asm}/time.h | 0 xen/include/{asm-arm => arch-arm/asm}/trace.h | 0 xen/include/{asm-arm => arch-arm/asm}/traps.h | 0 xen/include/{asm-arm => arch-arm/asm}/types.h | 0 xen/include/{asm-arm => arch-arm/asm}/vfp.h | 0 .../{asm-arm => arch-arm/asm}/vgic-emul.h | 0 xen/include/{asm-arm => arch-arm/asm}/vgic.h | 0 .../{asm-arm => arch-arm/asm}/vm_event.h | 0 .../{asm-arm => arch-arm/asm}/vpl011.h | 0 xen/include/{asm-arm => arch-arm/asm}/vpsci.h | 0 xen/include/{asm-arm => arch-arm/asm}/vreg.h | 0 .../{asm-arm => arch-arm/asm}/vtimer.h | 0 .../{asm-arm => arch-arm/asm}/xenoprof.h | 0 .../{asm-riscv => arch-riscv/asm}/config.h | 0 xen/include/{asm-x86 => arch-x86/asm}/acpi.h | 0 .../asm}/alternative-asm.h | 0 .../{asm-x86 => arch-x86/asm}/alternative.h | 0 .../{asm-x86 => arch-x86/asm}/altp2m.h | 0 xen/include/{asm-x86 => arch-x86/asm}/amd.h | 0 xen/include/{asm-x86 => arch-x86/asm}/apic.h | 0 .../{asm-x86 => arch-x86/asm}/apicdef.h | 0 .../{asm-x86 => arch-x86/asm}/asm-defns.h | 0 .../{asm-x86 => arch-x86/asm}/asm_defns.h | 0 .../{asm-x86 => arch-x86/asm}/atomic.h | 0 .../{asm-x86 => arch-x86/asm}/bitops.h | 0 xen/include/{asm-x86 => arch-x86/asm}/bug.h | 0 .../{asm-x86 => arch-x86/asm}/byteorder.h | 0 .../{asm-x86 => arch-x86/asm}/bzimage.h | 0 xen/include/{asm-x86 => arch-x86/asm}/cache.h | 0 .../{asm-x86 => arch-x86/asm}/compat.h | 0 .../{asm-x86 => arch-x86/asm}/config.h | 0 .../{asm-x86 => arch-x86/asm}/cpufeature.h | 0 .../{asm-x86 => arch-x86/asm}/cpufeatures.h | 0 .../{asm-x86 => arch-x86/asm}/cpufeatureset.h | 0 xen/include/{asm-x86 => arch-x86/asm}/cpuid.h | 0 .../{asm-x86 => arch-x86/asm}/cpuidle.h | 0 .../{asm-x86 => arch-x86/asm}/current.h | 2 +- .../{asm-x86 => arch-x86/asm}/debugger.h | 0 .../{asm-x86 => arch-x86/asm}/debugreg.h | 0 xen/include/{asm-x86 => arch-x86/asm}/delay.h | 0 xen/include/{asm-x86 => arch-x86/asm}/desc.h | 0 .../{asm-x86 => arch-x86/asm}/device.h | 0 xen/include/{asm-x86 => arch-x86/asm}/div64.h | 0 .../{asm-x86 => arch-x86/asm}/dom0_build.h | 0 .../{asm-x86 => arch-x86/asm}/domain.h | 2 +- xen/include/{asm-x86 => arch-x86/asm}/e820.h | 0 xen/include/{asm-x86 => arch-x86/asm}/edd.h | 0 .../{asm-x86 => arch-x86/asm}/efibind.h | 0 xen/include/{asm-x86 => arch-x86/asm}/elf.h | 0 xen/include/{asm-x86 => arch-x86/asm}/event.h | 0 .../{asm-x86 => arch-x86/asm}/fixmap.h | 0 .../{asm-x86 => arch-x86/asm}/flushtlb.h | 0 .../{asm-x86 => arch-x86/asm}/genapic.h | 0 .../{asm-x86 => arch-x86/asm}/grant_table.h | 0 xen/include/{asm-x86 => arch-x86/asm}/guest.h | 0 .../asm}/guest/hyperv-hcall.h | 0 .../asm}/guest/hyperv-tlfs.h | 0 .../{asm-x86 => arch-x86/asm}/guest/hyperv.h | 0 .../asm}/guest/hypervisor.h | 0 .../asm}/guest/pvh-boot.h | 0 .../asm}/guest/xen-hcall.h | 0 .../{asm-x86 => arch-x86/asm}/guest/xen.h | 0 .../{asm-x86 => arch-x86/asm}/guest_access.h | 0 .../{asm-x86 => arch-x86/asm}/guest_atomics.h | 0 .../{asm-x86 => arch-x86/asm}/guest_pt.h | 0 xen/include/{asm-x86 => arch-x86/asm}/hap.h | 0 .../{asm-x86 => arch-x86/asm}/hardirq.h | 0 xen/include/{asm-x86 => arch-x86/asm}/hpet.h | 0 .../{asm-x86 => arch-x86/asm}/hvm/asid.h | 0 .../{asm-x86 => arch-x86/asm}/hvm/cacheattr.h | 0 .../{asm-x86 => arch-x86/asm}/hvm/domain.h | 0 .../{asm-x86 => arch-x86/asm}/hvm/emulate.h | 0 .../asm}/hvm/grant_table.h | 0 .../asm}/hvm/guest_access.h | 0 .../{asm-x86 => arch-x86/asm}/hvm/hvm.h | 0 .../{asm-x86 => arch-x86/asm}/hvm/io.h | 0 .../{asm-x86 => arch-x86/asm}/hvm/ioreq.h | 0 .../{asm-x86 => arch-x86/asm}/hvm/irq.h | 0 .../{asm-x86 => arch-x86/asm}/hvm/monitor.h | 0 .../{asm-x86 => arch-x86/asm}/hvm/nestedhvm.h | 0 .../{asm-x86 => arch-x86/asm}/hvm/save.h | 0 .../{asm-x86 => arch-x86/asm}/hvm/support.h | 0 .../{asm-x86 => arch-x86/asm}/hvm/svm/asid.h | 0 .../asm}/hvm/svm/emulate.h | 0 .../{asm-x86 => arch-x86/asm}/hvm/svm/intr.h | 0 .../asm}/hvm/svm/nestedsvm.h | 0 .../{asm-x86 => arch-x86/asm}/hvm/svm/svm.h | 0 .../asm}/hvm/svm/svmdebug.h | 0 .../{asm-x86 => arch-x86/asm}/hvm/svm/vmcb.h | 0 .../{asm-x86 => arch-x86/asm}/hvm/trace.h | 0 .../{asm-x86 => arch-x86/asm}/hvm/vcpu.h | 0 .../{asm-x86 => arch-x86/asm}/hvm/vioapic.h | 0 .../{asm-x86 => arch-x86/asm}/hvm/viridian.h | 0 .../{asm-x86 => arch-x86/asm}/hvm/vlapic.h | 0 .../{asm-x86 => arch-x86/asm}/hvm/vm_event.h | 0 .../{asm-x86 => arch-x86/asm}/hvm/vmx/vmcs.h | 0 .../{asm-x86 => arch-x86/asm}/hvm/vmx/vmx.h | 0 .../{asm-x86 => arch-x86/asm}/hvm/vmx/vvmx.h | 0 .../{asm-x86 => arch-x86/asm}/hvm/vpic.h | 0 .../{asm-x86 => arch-x86/asm}/hvm/vpt.h | 0 .../{asm-x86 => arch-x86/asm}/hypercall.h | 0 xen/include/{asm-x86 => arch-x86/asm}/i387.h | 0 xen/include/{asm-x86 => arch-x86/asm}/init.h | 0 .../{asm-x86 => arch-x86/asm}/invpcid.h | 0 xen/include/{asm-x86 => arch-x86/asm}/io.h | 0 .../{asm-x86 => arch-x86/asm}/io_apic.h | 0 xen/include/{asm-x86 => arch-x86/asm}/iocap.h | 0 xen/include/{asm-x86 => arch-x86/asm}/iommu.h | 0 xen/include/{asm-x86 => arch-x86/asm}/ioreq.h | 0 xen/include/{asm-x86 => arch-x86/asm}/irq.h | 0 xen/include/{asm-x86 => arch-x86/asm}/ldt.h | 0 .../{asm-x86 => arch-x86/asm}/livepatch.h | 0 .../asm}/mach-default/bios_ebda.h | 0 .../asm}/mach-default/io_ports.h | 0 .../asm}/mach-default/irq_vectors.h | 0 .../asm}/mach-default/mach_mpparse.h | 0 .../asm}/mach-default/mach_mpspec.h | 0 .../asm}/mach-generic/mach_apic.h | 0 .../asm}/mach-generic/mach_mpparse.h | 0 .../{asm-x86 => arch-x86/asm}/machine_kexec.h | 0 .../{asm-x86 => arch-x86/asm}/mc146818rtc.h | 0 xen/include/{asm-x86 => arch-x86/asm}/mce.h | 0 .../{asm-x86 => arch-x86/asm}/mem_access.h | 0 .../{asm-x86 => arch-x86/asm}/mem_paging.h | 0 .../{asm-x86 => arch-x86/asm}/mem_sharing.h | 0 .../{asm-x86 => arch-x86/asm}/microcode.h | 0 xen/include/{asm-x86 => arch-x86/asm}/mm.h | 0 .../{asm-x86 => arch-x86/asm}/monitor.h | 0 .../{asm-x86 => arch-x86/asm}/mpspec.h | 0 .../{asm-x86 => arch-x86/asm}/mpspec_def.h | 0 xen/include/{asm-x86 => arch-x86/asm}/msi.h | 0 .../{asm-x86 => arch-x86/asm}/msr-index.h | 0 xen/include/{asm-x86 => arch-x86/asm}/msr.h | 0 xen/include/{asm-x86 => arch-x86/asm}/mtrr.h | 0 .../{asm-x86 => arch-x86/asm}/multicall.h | 0 xen/include/{asm-x86 => arch-x86/asm}/mwait.h | 0 xen/include/{asm-x86 => arch-x86/asm}/nmi.h | 0 xen/include/{asm-x86 => arch-x86/asm}/nops.h | 0 .../{asm-x86 => arch-x86/asm}/nospec.h | 0 xen/include/{asm-x86 => arch-x86/asm}/numa.h | 0 xen/include/{asm-x86 => arch-x86/asm}/p2m.h | 0 .../{asm-x86 => arch-x86/asm}/page-bits.h | 0 xen/include/{asm-x86 => arch-x86/asm}/page.h | 0 .../{asm-x86 => arch-x86/asm}/paging.h | 0 xen/include/{asm-x86 => arch-x86/asm}/pci.h | 0 .../{asm-x86 => arch-x86/asm}/percpu.h | 0 xen/include/{asm-x86 => arch-x86/asm}/perfc.h | 0 .../{asm-x86 => arch-x86/asm}/perfc_defn.h | 0 .../{asm-x86 => arch-x86/asm}/processor.h | 0 xen/include/{asm-x86 => arch-x86/asm}/psr.h | 0 .../{asm-x86 => arch-x86/asm}/pv/domain.h | 0 .../asm}/pv/grant_table.h | 0 xen/include/{asm-x86 => arch-x86/asm}/pv/mm.h | 0 .../{asm-x86 => arch-x86/asm}/pv/shim.h | 0 .../{asm-x86 => arch-x86/asm}/pv/traps.h | 0 .../{asm-x86 => arch-x86/asm}/random.h | 0 xen/include/{asm-x86 => arch-x86/asm}/regs.h | 0 xen/include/{asm-x86 => arch-x86/asm}/setup.h | 0 .../{asm-x86 => arch-x86/asm}/shadow.h | 0 .../{asm-x86 => arch-x86/asm}/shared.h | 0 xen/include/{asm-x86 => arch-x86/asm}/smp.h | 0 .../{asm-x86 => arch-x86/asm}/softirq.h | 0 .../{asm-x86 => arch-x86/asm}/spec_ctrl.h | 0 .../{asm-x86 => arch-x86/asm}/spec_ctrl_asm.h | 0 .../{asm-x86 => arch-x86/asm}/spinlock.h | 0 .../{asm-x86 => arch-x86/asm}/string.h | 0 .../{asm-x86 => arch-x86/asm}/system.h | 0 xen/include/{asm-x86 => arch-x86/asm}/tboot.h | 0 xen/include/{asm-x86 => arch-x86/asm}/time.h | 0 xen/include/{asm-x86 => arch-x86/asm}/trace.h | 0 xen/include/{asm-x86 => arch-x86/asm}/traps.h | 0 xen/include/{asm-x86 => arch-x86/asm}/types.h | 0 .../{asm-x86 => arch-x86/asm}/uaccess.h | 0 .../{asm-x86 => arch-x86/asm}/unaligned.h | 0 .../{asm-x86 => arch-x86/asm}/vm_event.h | 0 xen/include/{asm-x86 => arch-x86/asm}/vpmu.h | 0 .../{asm-x86 => arch-x86/asm}/x86-defns.h | 0 .../{asm-x86 => arch-x86/asm}/x86-vendors.h | 0 .../asm}/x86_64/efibind.h | 0 .../{asm-x86 => arch-x86/asm}/x86_64/elf.h | 0 .../{asm-x86 => arch-x86/asm}/x86_64/page.h | 0 .../{asm-x86 => arch-x86/asm}/x86_64/regs.h | 0 .../{asm-x86 => arch-x86/asm}/x86_64/system.h | 0 .../asm}/x86_64/uaccess.h | 0 .../{asm-x86 => arch-x86/asm}/x86_emulate.h | 0 .../{asm-x86 => arch-x86/asm}/xenoprof.h | 0 .../{asm-x86 => arch-x86/asm}/xstate.h | 0 xen/include/xen/acpi.h | 4 +-- xen/include/xen/bitmap.h | 2 +- 329 files changed, 59 insertions(+), 59 deletions(-) rename xen/include/{asm-arm => arch-arm/asm}/acpi.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/alternative.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/altp2m.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/arm32/atomic.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/arm32/bitops.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/arm32/bug.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/arm32/cmpxchg.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/arm32/flushtlb.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/arm32/insn.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/arm32/io.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/arm32/macros.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/arm32/mm.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/arm32/page.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/arm32/processor.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/arm32/sysregs.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/arm32/system.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/arm32/traps.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/arm32/vfp.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/arm64/atomic.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/arm64/bitops.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/arm64/brk.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/arm64/bug.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/arm64/cmpxchg.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/arm64/efibind.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/arm64/flushtlb.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/arm64/hsr.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/arm64/insn.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/arm64/io.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/arm64/macros.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/arm64/mm.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/arm64/page.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/arm64/processor.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/arm64/sysregs.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/arm64/system.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/arm64/traps.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/arm64/vfp.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/asm_defns.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/atomic.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/bitops.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/bug.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/byteorder.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/cache.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/cadence-uart.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/config.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/cpregs.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/cpuerrata.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/cpufeature.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/current.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/debugger.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/delay.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/desc.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/device.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/div64.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/domain.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/domain_build.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/early_printk.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/efibind.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/elf.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/event.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/exynos4210-uart.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/flushtlb.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/gic.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/gic_v3_defs.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/gic_v3_its.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/grant_table.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/guest_access.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/guest_atomics.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/guest_walk.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/hardirq.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/hsr.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/hypercall.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/init.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/insn.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/io.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/iocap.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/iommu.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/iommu_fwspec.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/ioreq.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/irq.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/kernel.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/livepatch.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/lpae.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/macros.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/mem_access.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/mm.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/mmio.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/monitor.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/new_vgic.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/nospec.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/numa.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/p2m.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/page-bits.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/page.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/paging.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/pci.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/percpu.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/perfc.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/perfc_defn.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/pl011-uart.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/platform.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/platforms/exynos5.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/platforms/midway.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/platforms/omap5.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/platforms/vexpress.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/platforms/xilinx-zynqmp-eemi.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/processor.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/procinfo.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/psci.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/random.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/regs.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/scif-uart.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/setup.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/short-desc.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/smccc.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/smp.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/softirq.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/spinlock.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/string.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/sysregs.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/system.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/tee/optee_msg.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/tee/optee_rpc_cmd.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/tee/optee_smc.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/tee/tee.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/time.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/trace.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/traps.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/types.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/vfp.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/vgic-emul.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/vgic.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/vm_event.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/vpl011.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/vpsci.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/vreg.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/vtimer.h (100%) rename xen/include/{asm-arm => arch-arm/asm}/xenoprof.h (100%) rename xen/include/{asm-riscv => arch-riscv/asm}/config.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/acpi.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/alternative-asm.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/alternative.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/altp2m.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/amd.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/apic.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/apicdef.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/asm-defns.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/asm_defns.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/atomic.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/bitops.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/bug.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/byteorder.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/bzimage.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/cache.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/compat.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/config.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/cpufeature.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/cpufeatures.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/cpufeatureset.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/cpuid.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/cpuidle.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/current.h (99%) rename xen/include/{asm-x86 => arch-x86/asm}/debugger.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/debugreg.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/delay.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/desc.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/device.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/div64.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/dom0_build.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/domain.h (99%) rename xen/include/{asm-x86 => arch-x86/asm}/e820.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/edd.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/efibind.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/elf.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/event.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/fixmap.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/flushtlb.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/genapic.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/grant_table.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/guest.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/guest/hyperv-hcall.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/guest/hyperv-tlfs.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/guest/hyperv.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/guest/hypervisor.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/guest/pvh-boot.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/guest/xen-hcall.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/guest/xen.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/guest_access.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/guest_atomics.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/guest_pt.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/hap.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/hardirq.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/hpet.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/hvm/asid.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/hvm/cacheattr.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/hvm/domain.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/hvm/emulate.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/hvm/grant_table.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/hvm/guest_access.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/hvm/hvm.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/hvm/io.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/hvm/ioreq.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/hvm/irq.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/hvm/monitor.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/hvm/nestedhvm.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/hvm/save.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/hvm/support.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/hvm/svm/asid.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/hvm/svm/emulate.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/hvm/svm/intr.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/hvm/svm/nestedsvm.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/hvm/svm/svm.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/hvm/svm/svmdebug.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/hvm/svm/vmcb.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/hvm/trace.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/hvm/vcpu.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/hvm/vioapic.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/hvm/viridian.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/hvm/vlapic.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/hvm/vm_event.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/hvm/vmx/vmcs.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/hvm/vmx/vmx.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/hvm/vmx/vvmx.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/hvm/vpic.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/hvm/vpt.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/hypercall.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/i387.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/init.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/invpcid.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/io.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/io_apic.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/iocap.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/iommu.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/ioreq.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/irq.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/ldt.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/livepatch.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/mach-default/bios_ebda.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/mach-default/io_ports.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/mach-default/irq_vectors.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/mach-default/mach_mpparse.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/mach-default/mach_mpspec.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/mach-generic/mach_apic.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/mach-generic/mach_mpparse.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/machine_kexec.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/mc146818rtc.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/mce.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/mem_access.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/mem_paging.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/mem_sharing.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/microcode.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/mm.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/monitor.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/mpspec.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/mpspec_def.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/msi.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/msr-index.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/msr.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/mtrr.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/multicall.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/mwait.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/nmi.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/nops.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/nospec.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/numa.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/p2m.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/page-bits.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/page.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/paging.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/pci.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/percpu.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/perfc.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/perfc_defn.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/processor.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/psr.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/pv/domain.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/pv/grant_table.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/pv/mm.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/pv/shim.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/pv/traps.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/random.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/regs.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/setup.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/shadow.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/shared.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/smp.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/softirq.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/spec_ctrl.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/spec_ctrl_asm.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/spinlock.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/string.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/system.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/tboot.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/time.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/trace.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/traps.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/types.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/uaccess.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/unaligned.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/vm_event.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/vpmu.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/x86-defns.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/x86-vendors.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/x86_64/efibind.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/x86_64/elf.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/x86_64/page.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/x86_64/regs.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/x86_64/system.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/x86_64/uaccess.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/x86_emulate.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/xenoprof.h (100%) rename xen/include/{asm-x86 => arch-x86/asm}/xstate.h (100%) diff --git a/.gitignore b/.gitignore index 38a085e398e3..91ae22ae9216 100644 --- a/.gitignore +++ b/.gitignore @@ -328,9 +328,8 @@ xen/asm-offsets.s xen/common/config_data.S xen/common/config.gz xen/include/headers*.chk -xen/include/asm -xen/include/asm-*/asm-offsets.h -xen/include/asm-x86/asm-macros.h +xen/include/arch-*/asm/asm-offsets.h +xen/include/arch-x86/asm/asm-macros.h xen/include/compat/* xen/include/config/ xen/include/generated/ diff --git a/MAINTAINERS b/MAINTAINERS index 8a52a03969fe..03a5553116a8 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -245,7 +245,7 @@ F: xen/drivers/char/omap-uart.c F: xen/drivers/char/pl011.c F: xen/drivers/char/scif-uart.c F: xen/drivers/passthrough/arm/ -F: xen/include/asm-arm/ +F: xen/include/arch-arm/ F: xen/include/public/arch-arm/ F: xen/include/public/arch-arm.h @@ -293,8 +293,8 @@ S: Supported F: xen/arch/x86/efi/ F: xen/common/efi/ F: xen/include/efi/ -F: xen/include/asm-x86/efi*.h -F: xen/include/asm-x86/x86_*/efi*.h +F: xen/include/arch-x86/asm/efi*.h +F: xen/include/arch-x86/asm/x86_*/efi*.h GDBSX DEBUGGER M: Elena Ufimtseva @@ -321,7 +321,7 @@ INTEL(R) TRUSTED EXECUTION TECHNOLOGY (TXT) R: Lukasz Hawrylko S: Odd Fixes F: xen/arch/x86/tboot.c -F: xen/include/asm-x86/tboot.h +F: xen/include/arch-x86/asm/tboot.h INTEL(R) VT FOR DIRECTED I/O (VT-D) M: Kevin Tian @@ -334,7 +334,7 @@ M: Kevin Tian S: Supported F: xen/arch/x86/hvm/vmx/ F: xen/arch/x86/mm/p2m-ept.c -F: xen/include/asm-x86/hvm/vmx/ +F: xen/include/arch-x86/asm/hvm/vmx/ F: xen/arch/x86/cpu/vpmu_intel.c IOMMU VENDOR INDEPENDENT CODE @@ -399,7 +399,7 @@ F: tools/misc/xen-livepatch.c F: xen/arch/*/livepatch* F: xen/arch/*/*/livepatch* F: xen/common/livepatch* -F: xen/include/asm-*/livepatch.h +F: xen/include/arch-*/asm/livepatch.h F: xen/include/xen/livepatch* F: xen/test/livepatch/* @@ -500,7 +500,7 @@ TEE MEDIATORS M: Volodymyr Babchuk S: Supported F: xen/arch/arm/tee/ -F: xen/include/asm-arm/tee +F: xen/include/arch-arm/asm/tee TOOLSTACK M: Ian Jackson @@ -537,8 +537,8 @@ F: xen/common/vm_event.c F: xen/include/*/mem_access.h F: xen/include/*/monitor.h F: xen/include/*/vm_event.h -F: xen/include/asm-x86/hvm/monitor.h -F: xen/include/asm-x86/hvm/vm_event.h +F: xen/include/arch-x86/asm/hvm/monitor.h +F: xen/include/arch-x86/asm/hvm/vm_event.h VPCI M: Roger Pau Monné @@ -564,7 +564,7 @@ R: Wei Liu S: Supported L: xen-devel@lists.xenproject.org F: xen/arch/x86/ -F: xen/include/asm-x86/ +F: xen/include/arch-x86/ F: xen/include/public/arch-x86/ F: xen/include/xen/lib/x86 F: xen/lib/x86 @@ -584,10 +584,10 @@ F: xen/arch/x86/hvm/emulate.c F: xen/arch/x86/hvm/intercept.c F: xen/arch/x86/hvm/io.c F: xen/arch/x86/hvm/ioreq.c -F: xen/include/asm-x86/hvm/emulate.h -F: xen/include/asm-x86/hvm/io.h -F: xen/include/asm-x86/hvm/ioreq.h -F: xen/include/asm-x86/ioreq.h +F: xen/include/arch-x86/asm/hvm/emulate.h +F: xen/include/arch-x86/asm/hvm/io.h +F: xen/include/arch-x86/asm/hvm/ioreq.h +F: xen/include/arch-x86/asm/ioreq.h X86 MEMORY MANAGEMENT M: Jan Beulich @@ -619,10 +619,10 @@ M: Wei Liu S: Supported F: xen/arch/x86/guest/hyperv/ F: xen/arch/x86/hvm/viridian/ -F: xen/include/asm-x86/guest/hyperv.h -F: xen/include/asm-x86/guest/hyperv-hcall.h -F: xen/include/asm-x86/guest/hyperv-tlfs.h -F: xen/include/asm-x86/hvm/viridian.h +F: xen/include/arch-x86/asm/guest/hyperv.h +F: xen/include/arch-x86/asm/guest/hyperv-hcall.h +F: xen/include/arch-x86/asm/guest/hyperv-tlfs.h +F: xen/include/arch-x86/asm/hvm/viridian.h XENSTORE M: Ian Jackson diff --git a/tools/include/Makefile b/tools/include/Makefile index 42605d46b937..85b105173741 100644 --- a/tools/include/Makefile +++ b/tools/include/Makefile @@ -30,7 +30,7 @@ xen-dir: ln -s $(XEN_ROOT)/xen/include/acpi/platform acpi/ ln -s $(XEN_ROOT)/xen/include/acpi/ac*.h acpi/ ifeq ($(CONFIG_X86),y) - ln -s $(XEN_ROOT)/xen/include/asm-x86 xen/asm + ln -s $(XEN_ROOT)/xen/include/arch-x86/asm xen/asm mkdir -p xen/lib/x86 ln -s $(filter-out %autogen.h,$(wildcard $(XEN_ROOT)/xen/include/xen/lib/x86/*.h)) xen/lib/x86/ ln -s $(XEN_ROOT)/xen/include/xen/lib/x86/Makefile xen/lib/x86/ diff --git a/tools/misc/xen-access.c b/tools/misc/xen-access.c index 4bbef0bd2e10..d87325800c5b 100644 --- a/tools/misc/xen-access.c +++ b/tools/misc/xen-access.c @@ -56,11 +56,11 @@ #define ERROR(a, b...) fprintf(stderr, a "\n", ## b) #define PERROR(a, b...) fprintf(stderr, a ": %s\n", ## b, strerror(errno)) -/* From xen/include/asm-x86/processor.h */ +/* From xen/include/arch-x86/asm/processor.h */ #define X86_TRAP_DEBUG 1 #define X86_TRAP_INT3 3 -/* From xen/include/asm-x86/x86-defns.h */ +/* From xen/include/arch-x86/asm/x86-defns.h */ #define X86_CR4_PGE 0x00000080 /* enable global pages */ typedef struct vm_event { diff --git a/tools/tests/vhpet/Makefile b/tools/tests/vhpet/Makefile index cb88dd01c5f8..72f08dea22d8 100644 --- a/tools/tests/vhpet/Makefile +++ b/tools/tests/vhpet/Makefile @@ -32,7 +32,7 @@ distclean: clean .PHONY: install install: -hpet.h: $(XEN_ROOT)/xen/include/asm-x86/hpet.h +hpet.h: $(XEN_ROOT)/xen/include/arch-x86/asm/hpet.h cp $< $@ hpet.c: $(XEN_ROOT)/xen/arch/x86/hvm/hpet.c diff --git a/xen/Makefile b/xen/Makefile index 06d7bfab3e2c..7e3e4c42d77b 100644 --- a/xen/Makefile +++ b/xen/Makefile @@ -164,7 +164,7 @@ ifeq ($(TARGET_ARCH),x86) t1 = $(call as-insn,$(CC),".L0: .L1: .skip (.L1 - .L0)",,-no-integrated-as) # Check whether clang asm()-s support .include. -t2 = $(call as-insn,$(CC) -I$(BASEDIR)/include,".include \"asm-x86/asm-defns.h\"",,-no-integrated-as) +t2 = $(call as-insn,$(CC) -I$(BASEDIR)/include/arch-x86,".include \"asm/asm-defns.h\"",,-no-integrated-as) # Check whether clang keeps .macro-s between asm()-s: # https://bugs.llvm.org/show_bug.cgi?id=36110 @@ -367,7 +367,7 @@ _clean: delete-unfresh-files find . \( -name "*.o" -o -name ".*.d" -o -name ".*.d2" \ -o -name "*.gcno" -o -name ".*.cmd" -o -name "lib.a" \) -exec rm -f {} \; rm -f include/asm $(TARGET) $(TARGET).gz $(TARGET).efi $(TARGET).efi.map $(TARGET)-syms $(TARGET)-syms.map *~ core - rm -f asm-offsets.s include/asm-*/asm-offsets.h + rm -f asm-offsets.s include/arch-*/asm/asm-offsets.h rm -f .banner .PHONY: _distclean @@ -381,7 +381,6 @@ $(TARGET).gz: $(TARGET) $(TARGET): delete-unfresh-files $(MAKE) -C tools $(MAKE) -f $(BASEDIR)/Rules.mk include/xen/compile.h - [ -e include/asm ] || ln -sf asm-$(TARGET_ARCH) include/asm [ -e arch/$(TARGET_ARCH)/efi ] && for f in $$(cd common/efi; echo *.[ch]); \ do test -r arch/$(TARGET_ARCH)/efi/$$f || \ ln -nsf ../../../common/efi/$$f arch/$(TARGET_ARCH)/efi/; \ @@ -389,7 +388,7 @@ $(TARGET): delete-unfresh-files true $(MAKE) -f $(BASEDIR)/Rules.mk -C include $(MAKE) -f $(BASEDIR)/Rules.mk -C arch/$(TARGET_ARCH) include - $(MAKE) -f $(BASEDIR)/Rules.mk include/asm-$(TARGET_ARCH)/asm-offsets.h + $(MAKE) -f $(BASEDIR)/Rules.mk include/arch-$(TARGET_ARCH)/asm/asm-offsets.h $(MAKE) -f $(BASEDIR)/Rules.mk -C arch/$(TARGET_ARCH) $@ # drivers/char/console.o contains static banner/compile info. Blow it away. @@ -429,7 +428,7 @@ asm-offsets.s: arch/$(TARGET_ARCH)/$(TARGET_SUBARCH)/asm-offsets.c $(CC) $(filter-out -Wa$(comma)% -flto,$(c_flags)) -S -g0 -o $@.new -MQ $@ $< $(call move-if-changed,$@.new,$@) -include/asm-$(TARGET_ARCH)/asm-offsets.h: asm-offsets.s +include/arch-$(TARGET_ARCH)/asm/asm-offsets.h: asm-offsets.s @(set -e; \ echo "/*"; \ echo " * DO NOT MODIFY."; \ @@ -447,8 +446,8 @@ include/asm-$(TARGET_ARCH)/asm-offsets.h: asm-offsets.s SUBDIRS = xsm arch/$(TARGET_ARCH) common drivers lib test define all_sources - ( find include/asm-$(TARGET_ARCH) -name '*.h' -print; \ - find include -name 'asm-*' -prune -o -name '*.h' -print; \ + ( find include/arch-$(TARGET_ARCH) -name '*.h' -print; \ + find include -name 'arch-*' -prune -o -name '*.h' -print; \ find $(SUBDIRS) -name '*.[chS]' -print ) endef diff --git a/xen/arch/arm/README.LinuxPrimitives b/xen/arch/arm/README.LinuxPrimitives index 664a9f89ed27..733cc22c2cd5 100644 --- a/xen/arch/arm/README.LinuxPrimitives +++ b/xen/arch/arm/README.LinuxPrimitives @@ -8,19 +8,19 @@ arm64: bitops: last sync @ v3.16-rc6 (last commit: 8715466b6027) -linux/arch/arm64/include/asm/bitops.h xen/include/asm-arm/arm64/bitops.h +linux/arch/arm64/include/asm/bitops.h xen/include/arch-arm/asm/arm64/bitops.h --------------------------------------------------------------------- cmpxchg: last sync @ v3.16-rc6 (last commit: e1dfda9ced9b) -linux/arch/arm64/include/asm/cmpxchg.h xen/include/asm-arm/arm64/cmpxchg.h +linux/arch/arm64/include/asm/cmpxchg.h xen/include/arch-arm/asm/arm64/cmpxchg.h --------------------------------------------------------------------- atomics: last sync @ v3.16-rc6 (last commit: 8715466b6027) -linux/arch/arm64/include/asm/atomic.h xen/include/asm-arm/arm64/atomic.h +linux/arch/arm64/include/asm/atomic.h xen/include/arch-arm/asm/arm64/atomic.h The following functions were taken from Linux: atomic_add(), atomic_add_return(), atomic_sub(), atomic_sub_return(), @@ -76,13 +76,13 @@ diff -u ../linux/arch/arm/lib/findbit.S xen/arch/arm/arm32/lib/findbit.S cmpxchg: last sync @ v3.16-rc6 (last commit: c32ffce0f66e) -linux/arch/arm/include/asm/cmpxchg.h xen/include/asm-arm/arm32/cmpxchg.h +linux/arch/arm/include/asm/cmpxchg.h xen/include/arch-arm/asm/arm32/cmpxchg.h --------------------------------------------------------------------- atomics: last sync @ v3.16-rc6 (last commit: 030d0178bdbd) -linux/arch/arm/include/asm/atomic.h xen/include/asm-arm/arm32/atomic.h +linux/arch/arm/include/asm/atomic.h xen/include/arch-arm/asm/arm32/atomic.h The following functions were taken from Linux: atomic_add(), atomic_add_return(), atomic_sub(), atomic_sub_return(), diff --git a/xen/arch/arm/arch.mk b/xen/arch/arm/arch.mk index 6a2982059486..f54e602301be 100644 --- a/xen/arch/arm/arch.mk +++ b/xen/arch/arm/arch.mk @@ -2,6 +2,7 @@ # arm-specific definitions CFLAGS += -I$(BASEDIR)/include +CFLAGS += -I$(BASEDIR)/include/arch-$(TARGET_ARCH) $(call cc-options-add,CFLAGS,CC,$(EMBEDDED_EXTRA_CFLAGS)) $(call cc-option-add,CFLAGS,CC,-Wnested-externs) diff --git a/xen/arch/arm/arm32/head.S b/xen/arch/arm/arm32/head.S index 7178865f48c3..5cd4f19aa199 100644 --- a/xen/arch/arm/arm32/head.S +++ b/xen/arch/arm/arm32/head.S @@ -599,7 +599,7 @@ remove_identity_mapping: strd r2, r3, [r0, r1] identity_mapping_removed: - /* See asm-arm/arm32/flushtlb.h for the explanation of the sequence. */ + /* See arch-arm/asm/arm32/flushtlb.h for the explanation of the sequence. */ dsb nshst mcr CP32(r0, TLBIALLH) dsb nsh diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S index aa1f88c76498..135fdccabdf0 100644 --- a/xen/arch/arm/arm64/head.S +++ b/xen/arch/arm/arm64/head.S @@ -737,7 +737,7 @@ remove_identity_mapping: str xzr, [x0, x1, lsl #3] identity_mapping_removed: - /* See asm-arm/arm64/flushtlb.h for the explanation of the sequence. */ + /* See arch-arm/asm/arm64/flushtlb.h for the explanation of the sequence. */ dsb nshst tlbi alle2 dsb nsh diff --git a/xen/arch/arm/smpboot.c b/xen/arch/arm/smpboot.c index a1ee3146efeb..df10c617c8f7 100644 --- a/xen/arch/arm/smpboot.c +++ b/xen/arch/arm/smpboot.c @@ -46,7 +46,7 @@ struct cpuinfo_arm cpu_data[NR_CPUS]; /* CPU logical map: map xen cpuid to an MPIDR */ register_t __cpu_logical_map[NR_CPUS] = { [0 ... NR_CPUS-1] = MPIDR_INVALID }; -/* Fake one node for now. See also include/asm-arm/numa.h */ +/* Fake one node for now. See also include/arch-arm/asm/numa.h */ nodemask_t __read_mostly node_online_map = { { [0] = 1UL } }; /* Xen stack for bringing up the first CPU. */ diff --git a/xen/arch/arm/vpsci.c b/xen/arch/arm/vpsci.c index c1e250be5967..8b93fd2cd5b7 100644 --- a/xen/arch/arm/vpsci.c +++ b/xen/arch/arm/vpsci.c @@ -278,7 +278,7 @@ bool do_vpsci_0_1_call(struct cpu_user_regs *regs, uint32_t fid) bool do_vpsci_0_2_call(struct cpu_user_regs *regs, uint32_t fid) { /* - * /!\ VPSCI_NR_FUNCS (in asm-arm/vpsci.h) should be updated when + * /!\ VPSCI_NR_FUNCS (in arch-arm/asm/vpsci.h) should be updated when * adding/removing a function. SCCC_SMCCC_*_REVISION should be * updated once per release. */ diff --git a/xen/arch/x86/Makefile b/xen/arch/x86/Makefile index 08a4ec1944d3..bb446a1b928d 100644 --- a/xen/arch/x86/Makefile +++ b/xen/arch/x86/Makefile @@ -275,11 +275,11 @@ efi/buildid.o efi/relocs-dummy.o: $(BASEDIR)/arch/x86/efi/built_in.o efi/buildid.o efi/relocs-dummy.o: ; .PHONY: include -include: $(BASEDIR)/include/asm-x86/asm-macros.h +include: $(BASEDIR)/include/arch-x86/asm/asm-macros.h asm-macros.i: CFLAGS-y += -D__ASSEMBLY__ -P -$(BASEDIR)/include/asm-x86/asm-macros.h: asm-macros.i Makefile +$(BASEDIR)/include/arch-x86/asm/asm-macros.h: asm-macros.i Makefile echo '#if 0' >$@.new echo '.if 0' >>$@.new echo '#endif' >>$@.new @@ -306,7 +306,7 @@ efi/mkreloc: efi/mkreloc.c .PHONY: clean clean:: rm -f *.lds *.new boot/*.o boot/*~ boot/core boot/mkelf32 - rm -f asm-macros.i $(BASEDIR)/include/asm-x86/asm-macros.* + rm -f asm-macros.i $(BASEDIR)/include/arch-x86/asm/asm-macros.* rm -f $(BASEDIR)/.xen-syms.[0-9]* boot/.*.d $(BASEDIR)/.xen.elf32 rm -f $(BASEDIR)/.xen.efi.[0-9]* efi/*.efi efi/mkreloc rm -f boot/cmdline.S boot/reloc.S boot/*.lnk boot/*.bin diff --git a/xen/arch/x86/arch.mk b/xen/arch/x86/arch.mk index ce0c1a0e7fb2..9f5fade39e91 100644 --- a/xen/arch/x86/arch.mk +++ b/xen/arch/x86/arch.mk @@ -4,8 +4,9 @@ export XEN_IMG_OFFSET := 0x200000 CFLAGS += -I$(BASEDIR)/include -CFLAGS += -I$(BASEDIR)/include/asm-x86/mach-generic -CFLAGS += -I$(BASEDIR)/include/asm-x86/mach-default +CFLAGS += -I$(BASEDIR)/include/arch-$(TARGET_ARCH) +CFLAGS += -I$(BASEDIR)/include/arch-x86/asm/mach-generic +CFLAGS += -I$(BASEDIR)/include/arch-x86/asm/mach-default CFLAGS += -DXEN_IMG_OFFSET=$(XEN_IMG_OFFSET) # Prevent floating-point variables from creeping into Xen. diff --git a/xen/common/efi/runtime.c b/xen/common/efi/runtime.c index 375b94229e13..d54bae560487 100644 --- a/xen/common/efi/runtime.c +++ b/xen/common/efi/runtime.c @@ -12,13 +12,13 @@ struct efi_rs_state { #ifdef CONFIG_X86 /* * The way stacks get set up leads to them always being on an 8-byte - * boundary not evenly divisible by 16 (see asm-x86/current.h). The EFI ABI, - * just like the CPU one, however requires stacks to be 16-byte aligned - * before every function call. Since the compiler assumes this (unless - * passing it -mpreferred-stack-boundary=3), it wouldn't generate code to - * align the stack to 16 bytes even if putting a 16-byte aligned object - * there. Hence we need to force larger than 16-byte alignment, even if we - * don't strictly need that. + * boundary not evenly divisible by 16 (see arch-x86/asm/current.h). The + * EFI ABI, just like the CPU one, however requires stacks to be 16-byte + * aligned before every function call. Since the compiler assumes this + * (unless passing it -mpreferred-stack-boundary=3), it wouldn't generate + * code to align the stack to 16 bytes even if putting a 16-byte aligned + * object there. Hence we need to force larger than 16-byte alignment, + * even if we don't strictly need that. */ unsigned long __aligned(32) cr3; #endif diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c index 958ba0cd9256..5cf9b3011cdb 100644 --- a/xen/common/page_alloc.c +++ b/xen/common/page_alloc.c @@ -241,7 +241,7 @@ PAGE_LIST_HEAD(page_broken_list); /* * first_valid_mfn is exported because it is use in ARM specific NUMA - * helpers. See comment in asm-arm/numa.h. + * helpers. See comment in arch-arm/asm/numa.h. */ mfn_t first_valid_mfn = INVALID_MFN_INITIALIZER; diff --git a/xen/include/asm-arm/acpi.h b/xen/include/arch-arm/asm/acpi.h similarity index 100% rename from xen/include/asm-arm/acpi.h rename to xen/include/arch-arm/asm/acpi.h diff --git a/xen/include/asm-arm/alternative.h b/xen/include/arch-arm/asm/alternative.h similarity index 100% rename from xen/include/asm-arm/alternative.h rename to xen/include/arch-arm/asm/alternative.h diff --git a/xen/include/asm-arm/altp2m.h b/xen/include/arch-arm/asm/altp2m.h similarity index 100% rename from xen/include/asm-arm/altp2m.h rename to xen/include/arch-arm/asm/altp2m.h diff --git a/xen/include/asm-arm/arm32/atomic.h b/xen/include/arch-arm/asm/arm32/atomic.h similarity index 100% rename from xen/include/asm-arm/arm32/atomic.h rename to xen/include/arch-arm/asm/arm32/atomic.h diff --git a/xen/include/asm-arm/arm32/bitops.h b/xen/include/arch-arm/asm/arm32/bitops.h similarity index 100% rename from xen/include/asm-arm/arm32/bitops.h rename to xen/include/arch-arm/asm/arm32/bitops.h diff --git a/xen/include/asm-arm/arm32/bug.h b/xen/include/arch-arm/asm/arm32/bug.h similarity index 100% rename from xen/include/asm-arm/arm32/bug.h rename to xen/include/arch-arm/asm/arm32/bug.h diff --git a/xen/include/asm-arm/arm32/cmpxchg.h b/xen/include/arch-arm/asm/arm32/cmpxchg.h similarity index 100% rename from xen/include/asm-arm/arm32/cmpxchg.h rename to xen/include/arch-arm/asm/arm32/cmpxchg.h diff --git a/xen/include/asm-arm/arm32/flushtlb.h b/xen/include/arch-arm/asm/arm32/flushtlb.h similarity index 100% rename from xen/include/asm-arm/arm32/flushtlb.h rename to xen/include/arch-arm/asm/arm32/flushtlb.h diff --git a/xen/include/asm-arm/arm32/insn.h b/xen/include/arch-arm/asm/arm32/insn.h similarity index 100% rename from xen/include/asm-arm/arm32/insn.h rename to xen/include/arch-arm/asm/arm32/insn.h diff --git a/xen/include/asm-arm/arm32/io.h b/xen/include/arch-arm/asm/arm32/io.h similarity index 100% rename from xen/include/asm-arm/arm32/io.h rename to xen/include/arch-arm/asm/arm32/io.h diff --git a/xen/include/asm-arm/arm32/macros.h b/xen/include/arch-arm/asm/arm32/macros.h similarity index 100% rename from xen/include/asm-arm/arm32/macros.h rename to xen/include/arch-arm/asm/arm32/macros.h diff --git a/xen/include/asm-arm/arm32/mm.h b/xen/include/arch-arm/asm/arm32/mm.h similarity index 100% rename from xen/include/asm-arm/arm32/mm.h rename to xen/include/arch-arm/asm/arm32/mm.h diff --git a/xen/include/asm-arm/arm32/page.h b/xen/include/arch-arm/asm/arm32/page.h similarity index 100% rename from xen/include/asm-arm/arm32/page.h rename to xen/include/arch-arm/asm/arm32/page.h diff --git a/xen/include/asm-arm/arm32/processor.h b/xen/include/arch-arm/asm/arm32/processor.h similarity index 100% rename from xen/include/asm-arm/arm32/processor.h rename to xen/include/arch-arm/asm/arm32/processor.h diff --git a/xen/include/asm-arm/arm32/sysregs.h b/xen/include/arch-arm/asm/arm32/sysregs.h similarity index 100% rename from xen/include/asm-arm/arm32/sysregs.h rename to xen/include/arch-arm/asm/arm32/sysregs.h diff --git a/xen/include/asm-arm/arm32/system.h b/xen/include/arch-arm/asm/arm32/system.h similarity index 100% rename from xen/include/asm-arm/arm32/system.h rename to xen/include/arch-arm/asm/arm32/system.h diff --git a/xen/include/asm-arm/arm32/traps.h b/xen/include/arch-arm/asm/arm32/traps.h similarity index 100% rename from xen/include/asm-arm/arm32/traps.h rename to xen/include/arch-arm/asm/arm32/traps.h diff --git a/xen/include/asm-arm/arm32/vfp.h b/xen/include/arch-arm/asm/arm32/vfp.h similarity index 100% rename from xen/include/asm-arm/arm32/vfp.h rename to xen/include/arch-arm/asm/arm32/vfp.h diff --git a/xen/include/asm-arm/arm64/atomic.h b/xen/include/arch-arm/asm/arm64/atomic.h similarity index 100% rename from xen/include/asm-arm/arm64/atomic.h rename to xen/include/arch-arm/asm/arm64/atomic.h diff --git a/xen/include/asm-arm/arm64/bitops.h b/xen/include/arch-arm/asm/arm64/bitops.h similarity index 100% rename from xen/include/asm-arm/arm64/bitops.h rename to xen/include/arch-arm/asm/arm64/bitops.h diff --git a/xen/include/asm-arm/arm64/brk.h b/xen/include/arch-arm/asm/arm64/brk.h similarity index 100% rename from xen/include/asm-arm/arm64/brk.h rename to xen/include/arch-arm/asm/arm64/brk.h diff --git a/xen/include/asm-arm/arm64/bug.h b/xen/include/arch-arm/asm/arm64/bug.h similarity index 100% rename from xen/include/asm-arm/arm64/bug.h rename to xen/include/arch-arm/asm/arm64/bug.h diff --git a/xen/include/asm-arm/arm64/cmpxchg.h b/xen/include/arch-arm/asm/arm64/cmpxchg.h similarity index 100% rename from xen/include/asm-arm/arm64/cmpxchg.h rename to xen/include/arch-arm/asm/arm64/cmpxchg.h diff --git a/xen/include/asm-arm/arm64/efibind.h b/xen/include/arch-arm/asm/arm64/efibind.h similarity index 100% rename from xen/include/asm-arm/arm64/efibind.h rename to xen/include/arch-arm/asm/arm64/efibind.h diff --git a/xen/include/asm-arm/arm64/flushtlb.h b/xen/include/arch-arm/asm/arm64/flushtlb.h similarity index 100% rename from xen/include/asm-arm/arm64/flushtlb.h rename to xen/include/arch-arm/asm/arm64/flushtlb.h diff --git a/xen/include/asm-arm/arm64/hsr.h b/xen/include/arch-arm/asm/arm64/hsr.h similarity index 100% rename from xen/include/asm-arm/arm64/hsr.h rename to xen/include/arch-arm/asm/arm64/hsr.h diff --git a/xen/include/asm-arm/arm64/insn.h b/xen/include/arch-arm/asm/arm64/insn.h similarity index 100% rename from xen/include/asm-arm/arm64/insn.h rename to xen/include/arch-arm/asm/arm64/insn.h diff --git a/xen/include/asm-arm/arm64/io.h b/xen/include/arch-arm/asm/arm64/io.h similarity index 100% rename from xen/include/asm-arm/arm64/io.h rename to xen/include/arch-arm/asm/arm64/io.h diff --git a/xen/include/asm-arm/arm64/macros.h b/xen/include/arch-arm/asm/arm64/macros.h similarity index 100% rename from xen/include/asm-arm/arm64/macros.h rename to xen/include/arch-arm/asm/arm64/macros.h diff --git a/xen/include/asm-arm/arm64/mm.h b/xen/include/arch-arm/asm/arm64/mm.h similarity index 100% rename from xen/include/asm-arm/arm64/mm.h rename to xen/include/arch-arm/asm/arm64/mm.h diff --git a/xen/include/asm-arm/arm64/page.h b/xen/include/arch-arm/asm/arm64/page.h similarity index 100% rename from xen/include/asm-arm/arm64/page.h rename to xen/include/arch-arm/asm/arm64/page.h diff --git a/xen/include/asm-arm/arm64/processor.h b/xen/include/arch-arm/asm/arm64/processor.h similarity index 100% rename from xen/include/asm-arm/arm64/processor.h rename to xen/include/arch-arm/asm/arm64/processor.h diff --git a/xen/include/asm-arm/arm64/sysregs.h b/xen/include/arch-arm/asm/arm64/sysregs.h similarity index 100% rename from xen/include/asm-arm/arm64/sysregs.h rename to xen/include/arch-arm/asm/arm64/sysregs.h diff --git a/xen/include/asm-arm/arm64/system.h b/xen/include/arch-arm/asm/arm64/system.h similarity index 100% rename from xen/include/asm-arm/arm64/system.h rename to xen/include/arch-arm/asm/arm64/system.h diff --git a/xen/include/asm-arm/arm64/traps.h b/xen/include/arch-arm/asm/arm64/traps.h similarity index 100% rename from xen/include/asm-arm/arm64/traps.h rename to xen/include/arch-arm/asm/arm64/traps.h diff --git a/xen/include/asm-arm/arm64/vfp.h b/xen/include/arch-arm/asm/arm64/vfp.h similarity index 100% rename from xen/include/asm-arm/arm64/vfp.h rename to xen/include/arch-arm/asm/arm64/vfp.h diff --git a/xen/include/asm-arm/asm_defns.h b/xen/include/arch-arm/asm/asm_defns.h similarity index 100% rename from xen/include/asm-arm/asm_defns.h rename to xen/include/arch-arm/asm/asm_defns.h diff --git a/xen/include/asm-arm/atomic.h b/xen/include/arch-arm/asm/atomic.h similarity index 100% rename from xen/include/asm-arm/atomic.h rename to xen/include/arch-arm/asm/atomic.h diff --git a/xen/include/asm-arm/bitops.h b/xen/include/arch-arm/asm/bitops.h similarity index 100% rename from xen/include/asm-arm/bitops.h rename to xen/include/arch-arm/asm/bitops.h diff --git a/xen/include/asm-arm/bug.h b/xen/include/arch-arm/asm/bug.h similarity index 100% rename from xen/include/asm-arm/bug.h rename to xen/include/arch-arm/asm/bug.h diff --git a/xen/include/asm-arm/byteorder.h b/xen/include/arch-arm/asm/byteorder.h similarity index 100% rename from xen/include/asm-arm/byteorder.h rename to xen/include/arch-arm/asm/byteorder.h diff --git a/xen/include/asm-arm/cache.h b/xen/include/arch-arm/asm/cache.h similarity index 100% rename from xen/include/asm-arm/cache.h rename to xen/include/arch-arm/asm/cache.h diff --git a/xen/include/asm-arm/cadence-uart.h b/xen/include/arch-arm/asm/cadence-uart.h similarity index 100% rename from xen/include/asm-arm/cadence-uart.h rename to xen/include/arch-arm/asm/cadence-uart.h diff --git a/xen/include/asm-arm/config.h b/xen/include/arch-arm/asm/config.h similarity index 100% rename from xen/include/asm-arm/config.h rename to xen/include/arch-arm/asm/config.h diff --git a/xen/include/asm-arm/cpregs.h b/xen/include/arch-arm/asm/cpregs.h similarity index 100% rename from xen/include/asm-arm/cpregs.h rename to xen/include/arch-arm/asm/cpregs.h diff --git a/xen/include/asm-arm/cpuerrata.h b/xen/include/arch-arm/asm/cpuerrata.h similarity index 100% rename from xen/include/asm-arm/cpuerrata.h rename to xen/include/arch-arm/asm/cpuerrata.h diff --git a/xen/include/asm-arm/cpufeature.h b/xen/include/arch-arm/asm/cpufeature.h similarity index 100% rename from xen/include/asm-arm/cpufeature.h rename to xen/include/arch-arm/asm/cpufeature.h diff --git a/xen/include/asm-arm/current.h b/xen/include/arch-arm/asm/current.h similarity index 100% rename from xen/include/asm-arm/current.h rename to xen/include/arch-arm/asm/current.h diff --git a/xen/include/asm-arm/debugger.h b/xen/include/arch-arm/asm/debugger.h similarity index 100% rename from xen/include/asm-arm/debugger.h rename to xen/include/arch-arm/asm/debugger.h diff --git a/xen/include/asm-arm/delay.h b/xen/include/arch-arm/asm/delay.h similarity index 100% rename from xen/include/asm-arm/delay.h rename to xen/include/arch-arm/asm/delay.h diff --git a/xen/include/asm-arm/desc.h b/xen/include/arch-arm/asm/desc.h similarity index 100% rename from xen/include/asm-arm/desc.h rename to xen/include/arch-arm/asm/desc.h diff --git a/xen/include/asm-arm/device.h b/xen/include/arch-arm/asm/device.h similarity index 100% rename from xen/include/asm-arm/device.h rename to xen/include/arch-arm/asm/device.h diff --git a/xen/include/asm-arm/div64.h b/xen/include/arch-arm/asm/div64.h similarity index 100% rename from xen/include/asm-arm/div64.h rename to xen/include/arch-arm/asm/div64.h diff --git a/xen/include/asm-arm/domain.h b/xen/include/arch-arm/asm/domain.h similarity index 100% rename from xen/include/asm-arm/domain.h rename to xen/include/arch-arm/asm/domain.h diff --git a/xen/include/asm-arm/domain_build.h b/xen/include/arch-arm/asm/domain_build.h similarity index 100% rename from xen/include/asm-arm/domain_build.h rename to xen/include/arch-arm/asm/domain_build.h diff --git a/xen/include/asm-arm/early_printk.h b/xen/include/arch-arm/asm/early_printk.h similarity index 100% rename from xen/include/asm-arm/early_printk.h rename to xen/include/arch-arm/asm/early_printk.h diff --git a/xen/include/asm-arm/efibind.h b/xen/include/arch-arm/asm/efibind.h similarity index 100% rename from xen/include/asm-arm/efibind.h rename to xen/include/arch-arm/asm/efibind.h diff --git a/xen/include/asm-arm/elf.h b/xen/include/arch-arm/asm/elf.h similarity index 100% rename from xen/include/asm-arm/elf.h rename to xen/include/arch-arm/asm/elf.h diff --git a/xen/include/asm-arm/event.h b/xen/include/arch-arm/asm/event.h similarity index 100% rename from xen/include/asm-arm/event.h rename to xen/include/arch-arm/asm/event.h diff --git a/xen/include/asm-arm/exynos4210-uart.h b/xen/include/arch-arm/asm/exynos4210-uart.h similarity index 100% rename from xen/include/asm-arm/exynos4210-uart.h rename to xen/include/arch-arm/asm/exynos4210-uart.h diff --git a/xen/include/asm-arm/flushtlb.h b/xen/include/arch-arm/asm/flushtlb.h similarity index 100% rename from xen/include/asm-arm/flushtlb.h rename to xen/include/arch-arm/asm/flushtlb.h diff --git a/xen/include/asm-arm/gic.h b/xen/include/arch-arm/asm/gic.h similarity index 100% rename from xen/include/asm-arm/gic.h rename to xen/include/arch-arm/asm/gic.h diff --git a/xen/include/asm-arm/gic_v3_defs.h b/xen/include/arch-arm/asm/gic_v3_defs.h similarity index 100% rename from xen/include/asm-arm/gic_v3_defs.h rename to xen/include/arch-arm/asm/gic_v3_defs.h diff --git a/xen/include/asm-arm/gic_v3_its.h b/xen/include/arch-arm/asm/gic_v3_its.h similarity index 100% rename from xen/include/asm-arm/gic_v3_its.h rename to xen/include/arch-arm/asm/gic_v3_its.h diff --git a/xen/include/asm-arm/grant_table.h b/xen/include/arch-arm/asm/grant_table.h similarity index 100% rename from xen/include/asm-arm/grant_table.h rename to xen/include/arch-arm/asm/grant_table.h diff --git a/xen/include/asm-arm/guest_access.h b/xen/include/arch-arm/asm/guest_access.h similarity index 100% rename from xen/include/asm-arm/guest_access.h rename to xen/include/arch-arm/asm/guest_access.h diff --git a/xen/include/asm-arm/guest_atomics.h b/xen/include/arch-arm/asm/guest_atomics.h similarity index 100% rename from xen/include/asm-arm/guest_atomics.h rename to xen/include/arch-arm/asm/guest_atomics.h diff --git a/xen/include/asm-arm/guest_walk.h b/xen/include/arch-arm/asm/guest_walk.h similarity index 100% rename from xen/include/asm-arm/guest_walk.h rename to xen/include/arch-arm/asm/guest_walk.h diff --git a/xen/include/asm-arm/hardirq.h b/xen/include/arch-arm/asm/hardirq.h similarity index 100% rename from xen/include/asm-arm/hardirq.h rename to xen/include/arch-arm/asm/hardirq.h diff --git a/xen/include/asm-arm/hsr.h b/xen/include/arch-arm/asm/hsr.h similarity index 100% rename from xen/include/asm-arm/hsr.h rename to xen/include/arch-arm/asm/hsr.h diff --git a/xen/include/asm-arm/hypercall.h b/xen/include/arch-arm/asm/hypercall.h similarity index 100% rename from xen/include/asm-arm/hypercall.h rename to xen/include/arch-arm/asm/hypercall.h diff --git a/xen/include/asm-arm/init.h b/xen/include/arch-arm/asm/init.h similarity index 100% rename from xen/include/asm-arm/init.h rename to xen/include/arch-arm/asm/init.h diff --git a/xen/include/asm-arm/insn.h b/xen/include/arch-arm/asm/insn.h similarity index 100% rename from xen/include/asm-arm/insn.h rename to xen/include/arch-arm/asm/insn.h diff --git a/xen/include/asm-arm/io.h b/xen/include/arch-arm/asm/io.h similarity index 100% rename from xen/include/asm-arm/io.h rename to xen/include/arch-arm/asm/io.h diff --git a/xen/include/asm-arm/iocap.h b/xen/include/arch-arm/asm/iocap.h similarity index 100% rename from xen/include/asm-arm/iocap.h rename to xen/include/arch-arm/asm/iocap.h diff --git a/xen/include/asm-arm/iommu.h b/xen/include/arch-arm/asm/iommu.h similarity index 100% rename from xen/include/asm-arm/iommu.h rename to xen/include/arch-arm/asm/iommu.h diff --git a/xen/include/asm-arm/iommu_fwspec.h b/xen/include/arch-arm/asm/iommu_fwspec.h similarity index 100% rename from xen/include/asm-arm/iommu_fwspec.h rename to xen/include/arch-arm/asm/iommu_fwspec.h diff --git a/xen/include/asm-arm/ioreq.h b/xen/include/arch-arm/asm/ioreq.h similarity index 100% rename from xen/include/asm-arm/ioreq.h rename to xen/include/arch-arm/asm/ioreq.h diff --git a/xen/include/asm-arm/irq.h b/xen/include/arch-arm/asm/irq.h similarity index 100% rename from xen/include/asm-arm/irq.h rename to xen/include/arch-arm/asm/irq.h diff --git a/xen/include/asm-arm/kernel.h b/xen/include/arch-arm/asm/kernel.h similarity index 100% rename from xen/include/asm-arm/kernel.h rename to xen/include/arch-arm/asm/kernel.h diff --git a/xen/include/asm-arm/livepatch.h b/xen/include/arch-arm/asm/livepatch.h similarity index 100% rename from xen/include/asm-arm/livepatch.h rename to xen/include/arch-arm/asm/livepatch.h diff --git a/xen/include/asm-arm/lpae.h b/xen/include/arch-arm/asm/lpae.h similarity index 100% rename from xen/include/asm-arm/lpae.h rename to xen/include/arch-arm/asm/lpae.h diff --git a/xen/include/asm-arm/macros.h b/xen/include/arch-arm/asm/macros.h similarity index 100% rename from xen/include/asm-arm/macros.h rename to xen/include/arch-arm/asm/macros.h diff --git a/xen/include/asm-arm/mem_access.h b/xen/include/arch-arm/asm/mem_access.h similarity index 100% rename from xen/include/asm-arm/mem_access.h rename to xen/include/arch-arm/asm/mem_access.h diff --git a/xen/include/asm-arm/mm.h b/xen/include/arch-arm/asm/mm.h similarity index 100% rename from xen/include/asm-arm/mm.h rename to xen/include/arch-arm/asm/mm.h diff --git a/xen/include/asm-arm/mmio.h b/xen/include/arch-arm/asm/mmio.h similarity index 100% rename from xen/include/asm-arm/mmio.h rename to xen/include/arch-arm/asm/mmio.h diff --git a/xen/include/asm-arm/monitor.h b/xen/include/arch-arm/asm/monitor.h similarity index 100% rename from xen/include/asm-arm/monitor.h rename to xen/include/arch-arm/asm/monitor.h diff --git a/xen/include/asm-arm/new_vgic.h b/xen/include/arch-arm/asm/new_vgic.h similarity index 100% rename from xen/include/asm-arm/new_vgic.h rename to xen/include/arch-arm/asm/new_vgic.h diff --git a/xen/include/asm-arm/nospec.h b/xen/include/arch-arm/asm/nospec.h similarity index 100% rename from xen/include/asm-arm/nospec.h rename to xen/include/arch-arm/asm/nospec.h diff --git a/xen/include/asm-arm/numa.h b/xen/include/arch-arm/asm/numa.h similarity index 100% rename from xen/include/asm-arm/numa.h rename to xen/include/arch-arm/asm/numa.h diff --git a/xen/include/asm-arm/p2m.h b/xen/include/arch-arm/asm/p2m.h similarity index 100% rename from xen/include/asm-arm/p2m.h rename to xen/include/arch-arm/asm/p2m.h diff --git a/xen/include/asm-arm/page-bits.h b/xen/include/arch-arm/asm/page-bits.h similarity index 100% rename from xen/include/asm-arm/page-bits.h rename to xen/include/arch-arm/asm/page-bits.h diff --git a/xen/include/asm-arm/page.h b/xen/include/arch-arm/asm/page.h similarity index 100% rename from xen/include/asm-arm/page.h rename to xen/include/arch-arm/asm/page.h diff --git a/xen/include/asm-arm/paging.h b/xen/include/arch-arm/asm/paging.h similarity index 100% rename from xen/include/asm-arm/paging.h rename to xen/include/arch-arm/asm/paging.h diff --git a/xen/include/asm-arm/pci.h b/xen/include/arch-arm/asm/pci.h similarity index 100% rename from xen/include/asm-arm/pci.h rename to xen/include/arch-arm/asm/pci.h diff --git a/xen/include/asm-arm/percpu.h b/xen/include/arch-arm/asm/percpu.h similarity index 100% rename from xen/include/asm-arm/percpu.h rename to xen/include/arch-arm/asm/percpu.h diff --git a/xen/include/asm-arm/perfc.h b/xen/include/arch-arm/asm/perfc.h similarity index 100% rename from xen/include/asm-arm/perfc.h rename to xen/include/arch-arm/asm/perfc.h diff --git a/xen/include/asm-arm/perfc_defn.h b/xen/include/arch-arm/asm/perfc_defn.h similarity index 100% rename from xen/include/asm-arm/perfc_defn.h rename to xen/include/arch-arm/asm/perfc_defn.h diff --git a/xen/include/asm-arm/pl011-uart.h b/xen/include/arch-arm/asm/pl011-uart.h similarity index 100% rename from xen/include/asm-arm/pl011-uart.h rename to xen/include/arch-arm/asm/pl011-uart.h diff --git a/xen/include/asm-arm/platform.h b/xen/include/arch-arm/asm/platform.h similarity index 100% rename from xen/include/asm-arm/platform.h rename to xen/include/arch-arm/asm/platform.h diff --git a/xen/include/asm-arm/platforms/exynos5.h b/xen/include/arch-arm/asm/platforms/exynos5.h similarity index 100% rename from xen/include/asm-arm/platforms/exynos5.h rename to xen/include/arch-arm/asm/platforms/exynos5.h diff --git a/xen/include/asm-arm/platforms/midway.h b/xen/include/arch-arm/asm/platforms/midway.h similarity index 100% rename from xen/include/asm-arm/platforms/midway.h rename to xen/include/arch-arm/asm/platforms/midway.h diff --git a/xen/include/asm-arm/platforms/omap5.h b/xen/include/arch-arm/asm/platforms/omap5.h similarity index 100% rename from xen/include/asm-arm/platforms/omap5.h rename to xen/include/arch-arm/asm/platforms/omap5.h diff --git a/xen/include/asm-arm/platforms/vexpress.h b/xen/include/arch-arm/asm/platforms/vexpress.h similarity index 100% rename from xen/include/asm-arm/platforms/vexpress.h rename to xen/include/arch-arm/asm/platforms/vexpress.h diff --git a/xen/include/asm-arm/platforms/xilinx-zynqmp-eemi.h b/xen/include/arch-arm/asm/platforms/xilinx-zynqmp-eemi.h similarity index 100% rename from xen/include/asm-arm/platforms/xilinx-zynqmp-eemi.h rename to xen/include/arch-arm/asm/platforms/xilinx-zynqmp-eemi.h diff --git a/xen/include/asm-arm/processor.h b/xen/include/arch-arm/asm/processor.h similarity index 100% rename from xen/include/asm-arm/processor.h rename to xen/include/arch-arm/asm/processor.h diff --git a/xen/include/asm-arm/procinfo.h b/xen/include/arch-arm/asm/procinfo.h similarity index 100% rename from xen/include/asm-arm/procinfo.h rename to xen/include/arch-arm/asm/procinfo.h diff --git a/xen/include/asm-arm/psci.h b/xen/include/arch-arm/asm/psci.h similarity index 100% rename from xen/include/asm-arm/psci.h rename to xen/include/arch-arm/asm/psci.h diff --git a/xen/include/asm-arm/random.h b/xen/include/arch-arm/asm/random.h similarity index 100% rename from xen/include/asm-arm/random.h rename to xen/include/arch-arm/asm/random.h diff --git a/xen/include/asm-arm/regs.h b/xen/include/arch-arm/asm/regs.h similarity index 100% rename from xen/include/asm-arm/regs.h rename to xen/include/arch-arm/asm/regs.h diff --git a/xen/include/asm-arm/scif-uart.h b/xen/include/arch-arm/asm/scif-uart.h similarity index 100% rename from xen/include/asm-arm/scif-uart.h rename to xen/include/arch-arm/asm/scif-uart.h diff --git a/xen/include/asm-arm/setup.h b/xen/include/arch-arm/asm/setup.h similarity index 100% rename from xen/include/asm-arm/setup.h rename to xen/include/arch-arm/asm/setup.h diff --git a/xen/include/asm-arm/short-desc.h b/xen/include/arch-arm/asm/short-desc.h similarity index 100% rename from xen/include/asm-arm/short-desc.h rename to xen/include/arch-arm/asm/short-desc.h diff --git a/xen/include/asm-arm/smccc.h b/xen/include/arch-arm/asm/smccc.h similarity index 100% rename from xen/include/asm-arm/smccc.h rename to xen/include/arch-arm/asm/smccc.h diff --git a/xen/include/asm-arm/smp.h b/xen/include/arch-arm/asm/smp.h similarity index 100% rename from xen/include/asm-arm/smp.h rename to xen/include/arch-arm/asm/smp.h diff --git a/xen/include/asm-arm/softirq.h b/xen/include/arch-arm/asm/softirq.h similarity index 100% rename from xen/include/asm-arm/softirq.h rename to xen/include/arch-arm/asm/softirq.h diff --git a/xen/include/asm-arm/spinlock.h b/xen/include/arch-arm/asm/spinlock.h similarity index 100% rename from xen/include/asm-arm/spinlock.h rename to xen/include/arch-arm/asm/spinlock.h diff --git a/xen/include/asm-arm/string.h b/xen/include/arch-arm/asm/string.h similarity index 100% rename from xen/include/asm-arm/string.h rename to xen/include/arch-arm/asm/string.h diff --git a/xen/include/asm-arm/sysregs.h b/xen/include/arch-arm/asm/sysregs.h similarity index 100% rename from xen/include/asm-arm/sysregs.h rename to xen/include/arch-arm/asm/sysregs.h diff --git a/xen/include/asm-arm/system.h b/xen/include/arch-arm/asm/system.h similarity index 100% rename from xen/include/asm-arm/system.h rename to xen/include/arch-arm/asm/system.h diff --git a/xen/include/asm-arm/tee/optee_msg.h b/xen/include/arch-arm/asm/tee/optee_msg.h similarity index 100% rename from xen/include/asm-arm/tee/optee_msg.h rename to xen/include/arch-arm/asm/tee/optee_msg.h diff --git a/xen/include/asm-arm/tee/optee_rpc_cmd.h b/xen/include/arch-arm/asm/tee/optee_rpc_cmd.h similarity index 100% rename from xen/include/asm-arm/tee/optee_rpc_cmd.h rename to xen/include/arch-arm/asm/tee/optee_rpc_cmd.h diff --git a/xen/include/asm-arm/tee/optee_smc.h b/xen/include/arch-arm/asm/tee/optee_smc.h similarity index 100% rename from xen/include/asm-arm/tee/optee_smc.h rename to xen/include/arch-arm/asm/tee/optee_smc.h diff --git a/xen/include/asm-arm/tee/tee.h b/xen/include/arch-arm/asm/tee/tee.h similarity index 100% rename from xen/include/asm-arm/tee/tee.h rename to xen/include/arch-arm/asm/tee/tee.h diff --git a/xen/include/asm-arm/time.h b/xen/include/arch-arm/asm/time.h similarity index 100% rename from xen/include/asm-arm/time.h rename to xen/include/arch-arm/asm/time.h diff --git a/xen/include/asm-arm/trace.h b/xen/include/arch-arm/asm/trace.h similarity index 100% rename from xen/include/asm-arm/trace.h rename to xen/include/arch-arm/asm/trace.h diff --git a/xen/include/asm-arm/traps.h b/xen/include/arch-arm/asm/traps.h similarity index 100% rename from xen/include/asm-arm/traps.h rename to xen/include/arch-arm/asm/traps.h diff --git a/xen/include/asm-arm/types.h b/xen/include/arch-arm/asm/types.h similarity index 100% rename from xen/include/asm-arm/types.h rename to xen/include/arch-arm/asm/types.h diff --git a/xen/include/asm-arm/vfp.h b/xen/include/arch-arm/asm/vfp.h similarity index 100% rename from xen/include/asm-arm/vfp.h rename to xen/include/arch-arm/asm/vfp.h diff --git a/xen/include/asm-arm/vgic-emul.h b/xen/include/arch-arm/asm/vgic-emul.h similarity index 100% rename from xen/include/asm-arm/vgic-emul.h rename to xen/include/arch-arm/asm/vgic-emul.h diff --git a/xen/include/asm-arm/vgic.h b/xen/include/arch-arm/asm/vgic.h similarity index 100% rename from xen/include/asm-arm/vgic.h rename to xen/include/arch-arm/asm/vgic.h diff --git a/xen/include/asm-arm/vm_event.h b/xen/include/arch-arm/asm/vm_event.h similarity index 100% rename from xen/include/asm-arm/vm_event.h rename to xen/include/arch-arm/asm/vm_event.h diff --git a/xen/include/asm-arm/vpl011.h b/xen/include/arch-arm/asm/vpl011.h similarity index 100% rename from xen/include/asm-arm/vpl011.h rename to xen/include/arch-arm/asm/vpl011.h diff --git a/xen/include/asm-arm/vpsci.h b/xen/include/arch-arm/asm/vpsci.h similarity index 100% rename from xen/include/asm-arm/vpsci.h rename to xen/include/arch-arm/asm/vpsci.h diff --git a/xen/include/asm-arm/vreg.h b/xen/include/arch-arm/asm/vreg.h similarity index 100% rename from xen/include/asm-arm/vreg.h rename to xen/include/arch-arm/asm/vreg.h diff --git a/xen/include/asm-arm/vtimer.h b/xen/include/arch-arm/asm/vtimer.h similarity index 100% rename from xen/include/asm-arm/vtimer.h rename to xen/include/arch-arm/asm/vtimer.h diff --git a/xen/include/asm-arm/xenoprof.h b/xen/include/arch-arm/asm/xenoprof.h similarity index 100% rename from xen/include/asm-arm/xenoprof.h rename to xen/include/arch-arm/asm/xenoprof.h diff --git a/xen/include/asm-riscv/config.h b/xen/include/arch-riscv/asm/config.h similarity index 100% rename from xen/include/asm-riscv/config.h rename to xen/include/arch-riscv/asm/config.h diff --git a/xen/include/asm-x86/acpi.h b/xen/include/arch-x86/asm/acpi.h similarity index 100% rename from xen/include/asm-x86/acpi.h rename to xen/include/arch-x86/asm/acpi.h diff --git a/xen/include/asm-x86/alternative-asm.h b/xen/include/arch-x86/asm/alternative-asm.h similarity index 100% rename from xen/include/asm-x86/alternative-asm.h rename to xen/include/arch-x86/asm/alternative-asm.h diff --git a/xen/include/asm-x86/alternative.h b/xen/include/arch-x86/asm/alternative.h similarity index 100% rename from xen/include/asm-x86/alternative.h rename to xen/include/arch-x86/asm/alternative.h diff --git a/xen/include/asm-x86/altp2m.h b/xen/include/arch-x86/asm/altp2m.h similarity index 100% rename from xen/include/asm-x86/altp2m.h rename to xen/include/arch-x86/asm/altp2m.h diff --git a/xen/include/asm-x86/amd.h b/xen/include/arch-x86/asm/amd.h similarity index 100% rename from xen/include/asm-x86/amd.h rename to xen/include/arch-x86/asm/amd.h diff --git a/xen/include/asm-x86/apic.h b/xen/include/arch-x86/asm/apic.h similarity index 100% rename from xen/include/asm-x86/apic.h rename to xen/include/arch-x86/asm/apic.h diff --git a/xen/include/asm-x86/apicdef.h b/xen/include/arch-x86/asm/apicdef.h similarity index 100% rename from xen/include/asm-x86/apicdef.h rename to xen/include/arch-x86/asm/apicdef.h diff --git a/xen/include/asm-x86/asm-defns.h b/xen/include/arch-x86/asm/asm-defns.h similarity index 100% rename from xen/include/asm-x86/asm-defns.h rename to xen/include/arch-x86/asm/asm-defns.h diff --git a/xen/include/asm-x86/asm_defns.h b/xen/include/arch-x86/asm/asm_defns.h similarity index 100% rename from xen/include/asm-x86/asm_defns.h rename to xen/include/arch-x86/asm/asm_defns.h diff --git a/xen/include/asm-x86/atomic.h b/xen/include/arch-x86/asm/atomic.h similarity index 100% rename from xen/include/asm-x86/atomic.h rename to xen/include/arch-x86/asm/atomic.h diff --git a/xen/include/asm-x86/bitops.h b/xen/include/arch-x86/asm/bitops.h similarity index 100% rename from xen/include/asm-x86/bitops.h rename to xen/include/arch-x86/asm/bitops.h diff --git a/xen/include/asm-x86/bug.h b/xen/include/arch-x86/asm/bug.h similarity index 100% rename from xen/include/asm-x86/bug.h rename to xen/include/arch-x86/asm/bug.h diff --git a/xen/include/asm-x86/byteorder.h b/xen/include/arch-x86/asm/byteorder.h similarity index 100% rename from xen/include/asm-x86/byteorder.h rename to xen/include/arch-x86/asm/byteorder.h diff --git a/xen/include/asm-x86/bzimage.h b/xen/include/arch-x86/asm/bzimage.h similarity index 100% rename from xen/include/asm-x86/bzimage.h rename to xen/include/arch-x86/asm/bzimage.h diff --git a/xen/include/asm-x86/cache.h b/xen/include/arch-x86/asm/cache.h similarity index 100% rename from xen/include/asm-x86/cache.h rename to xen/include/arch-x86/asm/cache.h diff --git a/xen/include/asm-x86/compat.h b/xen/include/arch-x86/asm/compat.h similarity index 100% rename from xen/include/asm-x86/compat.h rename to xen/include/arch-x86/asm/compat.h diff --git a/xen/include/asm-x86/config.h b/xen/include/arch-x86/asm/config.h similarity index 100% rename from xen/include/asm-x86/config.h rename to xen/include/arch-x86/asm/config.h diff --git a/xen/include/asm-x86/cpufeature.h b/xen/include/arch-x86/asm/cpufeature.h similarity index 100% rename from xen/include/asm-x86/cpufeature.h rename to xen/include/arch-x86/asm/cpufeature.h diff --git a/xen/include/asm-x86/cpufeatures.h b/xen/include/arch-x86/asm/cpufeatures.h similarity index 100% rename from xen/include/asm-x86/cpufeatures.h rename to xen/include/arch-x86/asm/cpufeatures.h diff --git a/xen/include/asm-x86/cpufeatureset.h b/xen/include/arch-x86/asm/cpufeatureset.h similarity index 100% rename from xen/include/asm-x86/cpufeatureset.h rename to xen/include/arch-x86/asm/cpufeatureset.h diff --git a/xen/include/asm-x86/cpuid.h b/xen/include/arch-x86/asm/cpuid.h similarity index 100% rename from xen/include/asm-x86/cpuid.h rename to xen/include/arch-x86/asm/cpuid.h diff --git a/xen/include/asm-x86/cpuidle.h b/xen/include/arch-x86/asm/cpuidle.h similarity index 100% rename from xen/include/asm-x86/cpuidle.h rename to xen/include/arch-x86/asm/cpuidle.h diff --git a/xen/include/asm-x86/current.h b/xen/include/arch-x86/asm/current.h similarity index 99% rename from xen/include/asm-x86/current.h rename to xen/include/arch-x86/asm/current.h index a74ad4bc4c44..c0f949eb2a19 100644 --- a/xen/include/asm-x86/current.h +++ b/xen/include/arch-x86/asm/current.h @@ -53,7 +53,7 @@ struct cpu_info { unsigned long xen_cr3; unsigned long pv_cr3; - /* See asm-x86/spec_ctrl_asm.h for usage. */ + /* See arch-x86/asm/spec_ctrl_asm.h for usage. */ unsigned int shadow_spec_ctrl; uint8_t xen_spec_ctrl; uint8_t spec_ctrl_flags; diff --git a/xen/include/asm-x86/debugger.h b/xen/include/arch-x86/asm/debugger.h similarity index 100% rename from xen/include/asm-x86/debugger.h rename to xen/include/arch-x86/asm/debugger.h diff --git a/xen/include/asm-x86/debugreg.h b/xen/include/arch-x86/asm/debugreg.h similarity index 100% rename from xen/include/asm-x86/debugreg.h rename to xen/include/arch-x86/asm/debugreg.h diff --git a/xen/include/asm-x86/delay.h b/xen/include/arch-x86/asm/delay.h similarity index 100% rename from xen/include/asm-x86/delay.h rename to xen/include/arch-x86/asm/delay.h diff --git a/xen/include/asm-x86/desc.h b/xen/include/arch-x86/asm/desc.h similarity index 100% rename from xen/include/asm-x86/desc.h rename to xen/include/arch-x86/asm/desc.h diff --git a/xen/include/asm-x86/device.h b/xen/include/arch-x86/asm/device.h similarity index 100% rename from xen/include/asm-x86/device.h rename to xen/include/arch-x86/asm/device.h diff --git a/xen/include/asm-x86/div64.h b/xen/include/arch-x86/asm/div64.h similarity index 100% rename from xen/include/asm-x86/div64.h rename to xen/include/arch-x86/asm/div64.h diff --git a/xen/include/asm-x86/dom0_build.h b/xen/include/arch-x86/asm/dom0_build.h similarity index 100% rename from xen/include/asm-x86/dom0_build.h rename to xen/include/arch-x86/asm/dom0_build.h diff --git a/xen/include/asm-x86/domain.h b/xen/include/arch-x86/asm/domain.h similarity index 99% rename from xen/include/asm-x86/domain.h rename to xen/include/arch-x86/asm/domain.h index 92d54de0b9a1..85ad302c0e92 100644 --- a/xen/include/asm-x86/domain.h +++ b/xen/include/arch-x86/asm/domain.h @@ -384,7 +384,7 @@ struct arch_domain struct PITState vpit; /* TSC management (emulation, pv, scaling, stats) */ - int tsc_mode; /* see include/asm-x86/time.h */ + int tsc_mode; /* see include/arch-x86/asm/time.h */ bool_t vtsc; /* tsc is emulated (may change after migrate) */ s_time_t vtsc_last; /* previous TSC value (guarantee monotonicity) */ uint64_t vtsc_offset; /* adjustment for save/restore/migrate */ diff --git a/xen/include/asm-x86/e820.h b/xen/include/arch-x86/asm/e820.h similarity index 100% rename from xen/include/asm-x86/e820.h rename to xen/include/arch-x86/asm/e820.h diff --git a/xen/include/asm-x86/edd.h b/xen/include/arch-x86/asm/edd.h similarity index 100% rename from xen/include/asm-x86/edd.h rename to xen/include/arch-x86/asm/edd.h diff --git a/xen/include/asm-x86/efibind.h b/xen/include/arch-x86/asm/efibind.h similarity index 100% rename from xen/include/asm-x86/efibind.h rename to xen/include/arch-x86/asm/efibind.h diff --git a/xen/include/asm-x86/elf.h b/xen/include/arch-x86/asm/elf.h similarity index 100% rename from xen/include/asm-x86/elf.h rename to xen/include/arch-x86/asm/elf.h diff --git a/xen/include/asm-x86/event.h b/xen/include/arch-x86/asm/event.h similarity index 100% rename from xen/include/asm-x86/event.h rename to xen/include/arch-x86/asm/event.h diff --git a/xen/include/asm-x86/fixmap.h b/xen/include/arch-x86/asm/fixmap.h similarity index 100% rename from xen/include/asm-x86/fixmap.h rename to xen/include/arch-x86/asm/fixmap.h diff --git a/xen/include/asm-x86/flushtlb.h b/xen/include/arch-x86/asm/flushtlb.h similarity index 100% rename from xen/include/asm-x86/flushtlb.h rename to xen/include/arch-x86/asm/flushtlb.h diff --git a/xen/include/asm-x86/genapic.h b/xen/include/arch-x86/asm/genapic.h similarity index 100% rename from xen/include/asm-x86/genapic.h rename to xen/include/arch-x86/asm/genapic.h diff --git a/xen/include/asm-x86/grant_table.h b/xen/include/arch-x86/asm/grant_table.h similarity index 100% rename from xen/include/asm-x86/grant_table.h rename to xen/include/arch-x86/asm/grant_table.h diff --git a/xen/include/asm-x86/guest.h b/xen/include/arch-x86/asm/guest.h similarity index 100% rename from xen/include/asm-x86/guest.h rename to xen/include/arch-x86/asm/guest.h diff --git a/xen/include/asm-x86/guest/hyperv-hcall.h b/xen/include/arch-x86/asm/guest/hyperv-hcall.h similarity index 100% rename from xen/include/asm-x86/guest/hyperv-hcall.h rename to xen/include/arch-x86/asm/guest/hyperv-hcall.h diff --git a/xen/include/asm-x86/guest/hyperv-tlfs.h b/xen/include/arch-x86/asm/guest/hyperv-tlfs.h similarity index 100% rename from xen/include/asm-x86/guest/hyperv-tlfs.h rename to xen/include/arch-x86/asm/guest/hyperv-tlfs.h diff --git a/xen/include/asm-x86/guest/hyperv.h b/xen/include/arch-x86/asm/guest/hyperv.h similarity index 100% rename from xen/include/asm-x86/guest/hyperv.h rename to xen/include/arch-x86/asm/guest/hyperv.h diff --git a/xen/include/asm-x86/guest/hypervisor.h b/xen/include/arch-x86/asm/guest/hypervisor.h similarity index 100% rename from xen/include/asm-x86/guest/hypervisor.h rename to xen/include/arch-x86/asm/guest/hypervisor.h diff --git a/xen/include/asm-x86/guest/pvh-boot.h b/xen/include/arch-x86/asm/guest/pvh-boot.h similarity index 100% rename from xen/include/asm-x86/guest/pvh-boot.h rename to xen/include/arch-x86/asm/guest/pvh-boot.h diff --git a/xen/include/asm-x86/guest/xen-hcall.h b/xen/include/arch-x86/asm/guest/xen-hcall.h similarity index 100% rename from xen/include/asm-x86/guest/xen-hcall.h rename to xen/include/arch-x86/asm/guest/xen-hcall.h diff --git a/xen/include/asm-x86/guest/xen.h b/xen/include/arch-x86/asm/guest/xen.h similarity index 100% rename from xen/include/asm-x86/guest/xen.h rename to xen/include/arch-x86/asm/guest/xen.h diff --git a/xen/include/asm-x86/guest_access.h b/xen/include/arch-x86/asm/guest_access.h similarity index 100% rename from xen/include/asm-x86/guest_access.h rename to xen/include/arch-x86/asm/guest_access.h diff --git a/xen/include/asm-x86/guest_atomics.h b/xen/include/arch-x86/asm/guest_atomics.h similarity index 100% rename from xen/include/asm-x86/guest_atomics.h rename to xen/include/arch-x86/asm/guest_atomics.h diff --git a/xen/include/asm-x86/guest_pt.h b/xen/include/arch-x86/asm/guest_pt.h similarity index 100% rename from xen/include/asm-x86/guest_pt.h rename to xen/include/arch-x86/asm/guest_pt.h diff --git a/xen/include/asm-x86/hap.h b/xen/include/arch-x86/asm/hap.h similarity index 100% rename from xen/include/asm-x86/hap.h rename to xen/include/arch-x86/asm/hap.h diff --git a/xen/include/asm-x86/hardirq.h b/xen/include/arch-x86/asm/hardirq.h similarity index 100% rename from xen/include/asm-x86/hardirq.h rename to xen/include/arch-x86/asm/hardirq.h diff --git a/xen/include/asm-x86/hpet.h b/xen/include/arch-x86/asm/hpet.h similarity index 100% rename from xen/include/asm-x86/hpet.h rename to xen/include/arch-x86/asm/hpet.h diff --git a/xen/include/asm-x86/hvm/asid.h b/xen/include/arch-x86/asm/hvm/asid.h similarity index 100% rename from xen/include/asm-x86/hvm/asid.h rename to xen/include/arch-x86/asm/hvm/asid.h diff --git a/xen/include/asm-x86/hvm/cacheattr.h b/xen/include/arch-x86/asm/hvm/cacheattr.h similarity index 100% rename from xen/include/asm-x86/hvm/cacheattr.h rename to xen/include/arch-x86/asm/hvm/cacheattr.h diff --git a/xen/include/asm-x86/hvm/domain.h b/xen/include/arch-x86/asm/hvm/domain.h similarity index 100% rename from xen/include/asm-x86/hvm/domain.h rename to xen/include/arch-x86/asm/hvm/domain.h diff --git a/xen/include/asm-x86/hvm/emulate.h b/xen/include/arch-x86/asm/hvm/emulate.h similarity index 100% rename from xen/include/asm-x86/hvm/emulate.h rename to xen/include/arch-x86/asm/hvm/emulate.h diff --git a/xen/include/asm-x86/hvm/grant_table.h b/xen/include/arch-x86/asm/hvm/grant_table.h similarity index 100% rename from xen/include/asm-x86/hvm/grant_table.h rename to xen/include/arch-x86/asm/hvm/grant_table.h diff --git a/xen/include/asm-x86/hvm/guest_access.h b/xen/include/arch-x86/asm/hvm/guest_access.h similarity index 100% rename from xen/include/asm-x86/hvm/guest_access.h rename to xen/include/arch-x86/asm/hvm/guest_access.h diff --git a/xen/include/asm-x86/hvm/hvm.h b/xen/include/arch-x86/asm/hvm/hvm.h similarity index 100% rename from xen/include/asm-x86/hvm/hvm.h rename to xen/include/arch-x86/asm/hvm/hvm.h diff --git a/xen/include/asm-x86/hvm/io.h b/xen/include/arch-x86/asm/hvm/io.h similarity index 100% rename from xen/include/asm-x86/hvm/io.h rename to xen/include/arch-x86/asm/hvm/io.h diff --git a/xen/include/asm-x86/hvm/ioreq.h b/xen/include/arch-x86/asm/hvm/ioreq.h similarity index 100% rename from xen/include/asm-x86/hvm/ioreq.h rename to xen/include/arch-x86/asm/hvm/ioreq.h diff --git a/xen/include/asm-x86/hvm/irq.h b/xen/include/arch-x86/asm/hvm/irq.h similarity index 100% rename from xen/include/asm-x86/hvm/irq.h rename to xen/include/arch-x86/asm/hvm/irq.h diff --git a/xen/include/asm-x86/hvm/monitor.h b/xen/include/arch-x86/asm/hvm/monitor.h similarity index 100% rename from xen/include/asm-x86/hvm/monitor.h rename to xen/include/arch-x86/asm/hvm/monitor.h diff --git a/xen/include/asm-x86/hvm/nestedhvm.h b/xen/include/arch-x86/asm/hvm/nestedhvm.h similarity index 100% rename from xen/include/asm-x86/hvm/nestedhvm.h rename to xen/include/arch-x86/asm/hvm/nestedhvm.h diff --git a/xen/include/asm-x86/hvm/save.h b/xen/include/arch-x86/asm/hvm/save.h similarity index 100% rename from xen/include/asm-x86/hvm/save.h rename to xen/include/arch-x86/asm/hvm/save.h diff --git a/xen/include/asm-x86/hvm/support.h b/xen/include/arch-x86/asm/hvm/support.h similarity index 100% rename from xen/include/asm-x86/hvm/support.h rename to xen/include/arch-x86/asm/hvm/support.h diff --git a/xen/include/asm-x86/hvm/svm/asid.h b/xen/include/arch-x86/asm/hvm/svm/asid.h similarity index 100% rename from xen/include/asm-x86/hvm/svm/asid.h rename to xen/include/arch-x86/asm/hvm/svm/asid.h diff --git a/xen/include/asm-x86/hvm/svm/emulate.h b/xen/include/arch-x86/asm/hvm/svm/emulate.h similarity index 100% rename from xen/include/asm-x86/hvm/svm/emulate.h rename to xen/include/arch-x86/asm/hvm/svm/emulate.h diff --git a/xen/include/asm-x86/hvm/svm/intr.h b/xen/include/arch-x86/asm/hvm/svm/intr.h similarity index 100% rename from xen/include/asm-x86/hvm/svm/intr.h rename to xen/include/arch-x86/asm/hvm/svm/intr.h diff --git a/xen/include/asm-x86/hvm/svm/nestedsvm.h b/xen/include/arch-x86/asm/hvm/svm/nestedsvm.h similarity index 100% rename from xen/include/asm-x86/hvm/svm/nestedsvm.h rename to xen/include/arch-x86/asm/hvm/svm/nestedsvm.h diff --git a/xen/include/asm-x86/hvm/svm/svm.h b/xen/include/arch-x86/asm/hvm/svm/svm.h similarity index 100% rename from xen/include/asm-x86/hvm/svm/svm.h rename to xen/include/arch-x86/asm/hvm/svm/svm.h diff --git a/xen/include/asm-x86/hvm/svm/svmdebug.h b/xen/include/arch-x86/asm/hvm/svm/svmdebug.h similarity index 100% rename from xen/include/asm-x86/hvm/svm/svmdebug.h rename to xen/include/arch-x86/asm/hvm/svm/svmdebug.h diff --git a/xen/include/asm-x86/hvm/svm/vmcb.h b/xen/include/arch-x86/asm/hvm/svm/vmcb.h similarity index 100% rename from xen/include/asm-x86/hvm/svm/vmcb.h rename to xen/include/arch-x86/asm/hvm/svm/vmcb.h diff --git a/xen/include/asm-x86/hvm/trace.h b/xen/include/arch-x86/asm/hvm/trace.h similarity index 100% rename from xen/include/asm-x86/hvm/trace.h rename to xen/include/arch-x86/asm/hvm/trace.h diff --git a/xen/include/asm-x86/hvm/vcpu.h b/xen/include/arch-x86/asm/hvm/vcpu.h similarity index 100% rename from xen/include/asm-x86/hvm/vcpu.h rename to xen/include/arch-x86/asm/hvm/vcpu.h diff --git a/xen/include/asm-x86/hvm/vioapic.h b/xen/include/arch-x86/asm/hvm/vioapic.h similarity index 100% rename from xen/include/asm-x86/hvm/vioapic.h rename to xen/include/arch-x86/asm/hvm/vioapic.h diff --git a/xen/include/asm-x86/hvm/viridian.h b/xen/include/arch-x86/asm/hvm/viridian.h similarity index 100% rename from xen/include/asm-x86/hvm/viridian.h rename to xen/include/arch-x86/asm/hvm/viridian.h diff --git a/xen/include/asm-x86/hvm/vlapic.h b/xen/include/arch-x86/asm/hvm/vlapic.h similarity index 100% rename from xen/include/asm-x86/hvm/vlapic.h rename to xen/include/arch-x86/asm/hvm/vlapic.h diff --git a/xen/include/asm-x86/hvm/vm_event.h b/xen/include/arch-x86/asm/hvm/vm_event.h similarity index 100% rename from xen/include/asm-x86/hvm/vm_event.h rename to xen/include/arch-x86/asm/hvm/vm_event.h diff --git a/xen/include/asm-x86/hvm/vmx/vmcs.h b/xen/include/arch-x86/asm/hvm/vmx/vmcs.h similarity index 100% rename from xen/include/asm-x86/hvm/vmx/vmcs.h rename to xen/include/arch-x86/asm/hvm/vmx/vmcs.h diff --git a/xen/include/asm-x86/hvm/vmx/vmx.h b/xen/include/arch-x86/asm/hvm/vmx/vmx.h similarity index 100% rename from xen/include/asm-x86/hvm/vmx/vmx.h rename to xen/include/arch-x86/asm/hvm/vmx/vmx.h diff --git a/xen/include/asm-x86/hvm/vmx/vvmx.h b/xen/include/arch-x86/asm/hvm/vmx/vvmx.h similarity index 100% rename from xen/include/asm-x86/hvm/vmx/vvmx.h rename to xen/include/arch-x86/asm/hvm/vmx/vvmx.h diff --git a/xen/include/asm-x86/hvm/vpic.h b/xen/include/arch-x86/asm/hvm/vpic.h similarity index 100% rename from xen/include/asm-x86/hvm/vpic.h rename to xen/include/arch-x86/asm/hvm/vpic.h diff --git a/xen/include/asm-x86/hvm/vpt.h b/xen/include/arch-x86/asm/hvm/vpt.h similarity index 100% rename from xen/include/asm-x86/hvm/vpt.h rename to xen/include/arch-x86/asm/hvm/vpt.h diff --git a/xen/include/asm-x86/hypercall.h b/xen/include/arch-x86/asm/hypercall.h similarity index 100% rename from xen/include/asm-x86/hypercall.h rename to xen/include/arch-x86/asm/hypercall.h diff --git a/xen/include/asm-x86/i387.h b/xen/include/arch-x86/asm/i387.h similarity index 100% rename from xen/include/asm-x86/i387.h rename to xen/include/arch-x86/asm/i387.h diff --git a/xen/include/asm-x86/init.h b/xen/include/arch-x86/asm/init.h similarity index 100% rename from xen/include/asm-x86/init.h rename to xen/include/arch-x86/asm/init.h diff --git a/xen/include/asm-x86/invpcid.h b/xen/include/arch-x86/asm/invpcid.h similarity index 100% rename from xen/include/asm-x86/invpcid.h rename to xen/include/arch-x86/asm/invpcid.h diff --git a/xen/include/asm-x86/io.h b/xen/include/arch-x86/asm/io.h similarity index 100% rename from xen/include/asm-x86/io.h rename to xen/include/arch-x86/asm/io.h diff --git a/xen/include/asm-x86/io_apic.h b/xen/include/arch-x86/asm/io_apic.h similarity index 100% rename from xen/include/asm-x86/io_apic.h rename to xen/include/arch-x86/asm/io_apic.h diff --git a/xen/include/asm-x86/iocap.h b/xen/include/arch-x86/asm/iocap.h similarity index 100% rename from xen/include/asm-x86/iocap.h rename to xen/include/arch-x86/asm/iocap.h diff --git a/xen/include/asm-x86/iommu.h b/xen/include/arch-x86/asm/iommu.h similarity index 100% rename from xen/include/asm-x86/iommu.h rename to xen/include/arch-x86/asm/iommu.h diff --git a/xen/include/asm-x86/ioreq.h b/xen/include/arch-x86/asm/ioreq.h similarity index 100% rename from xen/include/asm-x86/ioreq.h rename to xen/include/arch-x86/asm/ioreq.h diff --git a/xen/include/asm-x86/irq.h b/xen/include/arch-x86/asm/irq.h similarity index 100% rename from xen/include/asm-x86/irq.h rename to xen/include/arch-x86/asm/irq.h diff --git a/xen/include/asm-x86/ldt.h b/xen/include/arch-x86/asm/ldt.h similarity index 100% rename from xen/include/asm-x86/ldt.h rename to xen/include/arch-x86/asm/ldt.h diff --git a/xen/include/asm-x86/livepatch.h b/xen/include/arch-x86/asm/livepatch.h similarity index 100% rename from xen/include/asm-x86/livepatch.h rename to xen/include/arch-x86/asm/livepatch.h diff --git a/xen/include/asm-x86/mach-default/bios_ebda.h b/xen/include/arch-x86/asm/mach-default/bios_ebda.h similarity index 100% rename from xen/include/asm-x86/mach-default/bios_ebda.h rename to xen/include/arch-x86/asm/mach-default/bios_ebda.h diff --git a/xen/include/asm-x86/mach-default/io_ports.h b/xen/include/arch-x86/asm/mach-default/io_ports.h similarity index 100% rename from xen/include/asm-x86/mach-default/io_ports.h rename to xen/include/arch-x86/asm/mach-default/io_ports.h diff --git a/xen/include/asm-x86/mach-default/irq_vectors.h b/xen/include/arch-x86/asm/mach-default/irq_vectors.h similarity index 100% rename from xen/include/asm-x86/mach-default/irq_vectors.h rename to xen/include/arch-x86/asm/mach-default/irq_vectors.h diff --git a/xen/include/asm-x86/mach-default/mach_mpparse.h b/xen/include/arch-x86/asm/mach-default/mach_mpparse.h similarity index 100% rename from xen/include/asm-x86/mach-default/mach_mpparse.h rename to xen/include/arch-x86/asm/mach-default/mach_mpparse.h diff --git a/xen/include/asm-x86/mach-default/mach_mpspec.h b/xen/include/arch-x86/asm/mach-default/mach_mpspec.h similarity index 100% rename from xen/include/asm-x86/mach-default/mach_mpspec.h rename to xen/include/arch-x86/asm/mach-default/mach_mpspec.h diff --git a/xen/include/asm-x86/mach-generic/mach_apic.h b/xen/include/arch-x86/asm/mach-generic/mach_apic.h similarity index 100% rename from xen/include/asm-x86/mach-generic/mach_apic.h rename to xen/include/arch-x86/asm/mach-generic/mach_apic.h diff --git a/xen/include/asm-x86/mach-generic/mach_mpparse.h b/xen/include/arch-x86/asm/mach-generic/mach_mpparse.h similarity index 100% rename from xen/include/asm-x86/mach-generic/mach_mpparse.h rename to xen/include/arch-x86/asm/mach-generic/mach_mpparse.h diff --git a/xen/include/asm-x86/machine_kexec.h b/xen/include/arch-x86/asm/machine_kexec.h similarity index 100% rename from xen/include/asm-x86/machine_kexec.h rename to xen/include/arch-x86/asm/machine_kexec.h diff --git a/xen/include/asm-x86/mc146818rtc.h b/xen/include/arch-x86/asm/mc146818rtc.h similarity index 100% rename from xen/include/asm-x86/mc146818rtc.h rename to xen/include/arch-x86/asm/mc146818rtc.h diff --git a/xen/include/asm-x86/mce.h b/xen/include/arch-x86/asm/mce.h similarity index 100% rename from xen/include/asm-x86/mce.h rename to xen/include/arch-x86/asm/mce.h diff --git a/xen/include/asm-x86/mem_access.h b/xen/include/arch-x86/asm/mem_access.h similarity index 100% rename from xen/include/asm-x86/mem_access.h rename to xen/include/arch-x86/asm/mem_access.h diff --git a/xen/include/asm-x86/mem_paging.h b/xen/include/arch-x86/asm/mem_paging.h similarity index 100% rename from xen/include/asm-x86/mem_paging.h rename to xen/include/arch-x86/asm/mem_paging.h diff --git a/xen/include/asm-x86/mem_sharing.h b/xen/include/arch-x86/asm/mem_sharing.h similarity index 100% rename from xen/include/asm-x86/mem_sharing.h rename to xen/include/arch-x86/asm/mem_sharing.h diff --git a/xen/include/asm-x86/microcode.h b/xen/include/arch-x86/asm/microcode.h similarity index 100% rename from xen/include/asm-x86/microcode.h rename to xen/include/arch-x86/asm/microcode.h diff --git a/xen/include/asm-x86/mm.h b/xen/include/arch-x86/asm/mm.h similarity index 100% rename from xen/include/asm-x86/mm.h rename to xen/include/arch-x86/asm/mm.h diff --git a/xen/include/asm-x86/monitor.h b/xen/include/arch-x86/asm/monitor.h similarity index 100% rename from xen/include/asm-x86/monitor.h rename to xen/include/arch-x86/asm/monitor.h diff --git a/xen/include/asm-x86/mpspec.h b/xen/include/arch-x86/asm/mpspec.h similarity index 100% rename from xen/include/asm-x86/mpspec.h rename to xen/include/arch-x86/asm/mpspec.h diff --git a/xen/include/asm-x86/mpspec_def.h b/xen/include/arch-x86/asm/mpspec_def.h similarity index 100% rename from xen/include/asm-x86/mpspec_def.h rename to xen/include/arch-x86/asm/mpspec_def.h diff --git a/xen/include/asm-x86/msi.h b/xen/include/arch-x86/asm/msi.h similarity index 100% rename from xen/include/asm-x86/msi.h rename to xen/include/arch-x86/asm/msi.h diff --git a/xen/include/asm-x86/msr-index.h b/xen/include/arch-x86/asm/msr-index.h similarity index 100% rename from xen/include/asm-x86/msr-index.h rename to xen/include/arch-x86/asm/msr-index.h diff --git a/xen/include/asm-x86/msr.h b/xen/include/arch-x86/asm/msr.h similarity index 100% rename from xen/include/asm-x86/msr.h rename to xen/include/arch-x86/asm/msr.h diff --git a/xen/include/asm-x86/mtrr.h b/xen/include/arch-x86/asm/mtrr.h similarity index 100% rename from xen/include/asm-x86/mtrr.h rename to xen/include/arch-x86/asm/mtrr.h diff --git a/xen/include/asm-x86/multicall.h b/xen/include/arch-x86/asm/multicall.h similarity index 100% rename from xen/include/asm-x86/multicall.h rename to xen/include/arch-x86/asm/multicall.h diff --git a/xen/include/asm-x86/mwait.h b/xen/include/arch-x86/asm/mwait.h similarity index 100% rename from xen/include/asm-x86/mwait.h rename to xen/include/arch-x86/asm/mwait.h diff --git a/xen/include/asm-x86/nmi.h b/xen/include/arch-x86/asm/nmi.h similarity index 100% rename from xen/include/asm-x86/nmi.h rename to xen/include/arch-x86/asm/nmi.h diff --git a/xen/include/asm-x86/nops.h b/xen/include/arch-x86/asm/nops.h similarity index 100% rename from xen/include/asm-x86/nops.h rename to xen/include/arch-x86/asm/nops.h diff --git a/xen/include/asm-x86/nospec.h b/xen/include/arch-x86/asm/nospec.h similarity index 100% rename from xen/include/asm-x86/nospec.h rename to xen/include/arch-x86/asm/nospec.h diff --git a/xen/include/asm-x86/numa.h b/xen/include/arch-x86/asm/numa.h similarity index 100% rename from xen/include/asm-x86/numa.h rename to xen/include/arch-x86/asm/numa.h diff --git a/xen/include/asm-x86/p2m.h b/xen/include/arch-x86/asm/p2m.h similarity index 100% rename from xen/include/asm-x86/p2m.h rename to xen/include/arch-x86/asm/p2m.h diff --git a/xen/include/asm-x86/page-bits.h b/xen/include/arch-x86/asm/page-bits.h similarity index 100% rename from xen/include/asm-x86/page-bits.h rename to xen/include/arch-x86/asm/page-bits.h diff --git a/xen/include/asm-x86/page.h b/xen/include/arch-x86/asm/page.h similarity index 100% rename from xen/include/asm-x86/page.h rename to xen/include/arch-x86/asm/page.h diff --git a/xen/include/asm-x86/paging.h b/xen/include/arch-x86/asm/paging.h similarity index 100% rename from xen/include/asm-x86/paging.h rename to xen/include/arch-x86/asm/paging.h diff --git a/xen/include/asm-x86/pci.h b/xen/include/arch-x86/asm/pci.h similarity index 100% rename from xen/include/asm-x86/pci.h rename to xen/include/arch-x86/asm/pci.h diff --git a/xen/include/asm-x86/percpu.h b/xen/include/arch-x86/asm/percpu.h similarity index 100% rename from xen/include/asm-x86/percpu.h rename to xen/include/arch-x86/asm/percpu.h diff --git a/xen/include/asm-x86/perfc.h b/xen/include/arch-x86/asm/perfc.h similarity index 100% rename from xen/include/asm-x86/perfc.h rename to xen/include/arch-x86/asm/perfc.h diff --git a/xen/include/asm-x86/perfc_defn.h b/xen/include/arch-x86/asm/perfc_defn.h similarity index 100% rename from xen/include/asm-x86/perfc_defn.h rename to xen/include/arch-x86/asm/perfc_defn.h diff --git a/xen/include/asm-x86/processor.h b/xen/include/arch-x86/asm/processor.h similarity index 100% rename from xen/include/asm-x86/processor.h rename to xen/include/arch-x86/asm/processor.h diff --git a/xen/include/asm-x86/psr.h b/xen/include/arch-x86/asm/psr.h similarity index 100% rename from xen/include/asm-x86/psr.h rename to xen/include/arch-x86/asm/psr.h diff --git a/xen/include/asm-x86/pv/domain.h b/xen/include/arch-x86/asm/pv/domain.h similarity index 100% rename from xen/include/asm-x86/pv/domain.h rename to xen/include/arch-x86/asm/pv/domain.h diff --git a/xen/include/asm-x86/pv/grant_table.h b/xen/include/arch-x86/asm/pv/grant_table.h similarity index 100% rename from xen/include/asm-x86/pv/grant_table.h rename to xen/include/arch-x86/asm/pv/grant_table.h diff --git a/xen/include/asm-x86/pv/mm.h b/xen/include/arch-x86/asm/pv/mm.h similarity index 100% rename from xen/include/asm-x86/pv/mm.h rename to xen/include/arch-x86/asm/pv/mm.h diff --git a/xen/include/asm-x86/pv/shim.h b/xen/include/arch-x86/asm/pv/shim.h similarity index 100% rename from xen/include/asm-x86/pv/shim.h rename to xen/include/arch-x86/asm/pv/shim.h diff --git a/xen/include/asm-x86/pv/traps.h b/xen/include/arch-x86/asm/pv/traps.h similarity index 100% rename from xen/include/asm-x86/pv/traps.h rename to xen/include/arch-x86/asm/pv/traps.h diff --git a/xen/include/asm-x86/random.h b/xen/include/arch-x86/asm/random.h similarity index 100% rename from xen/include/asm-x86/random.h rename to xen/include/arch-x86/asm/random.h diff --git a/xen/include/asm-x86/regs.h b/xen/include/arch-x86/asm/regs.h similarity index 100% rename from xen/include/asm-x86/regs.h rename to xen/include/arch-x86/asm/regs.h diff --git a/xen/include/asm-x86/setup.h b/xen/include/arch-x86/asm/setup.h similarity index 100% rename from xen/include/asm-x86/setup.h rename to xen/include/arch-x86/asm/setup.h diff --git a/xen/include/asm-x86/shadow.h b/xen/include/arch-x86/asm/shadow.h similarity index 100% rename from xen/include/asm-x86/shadow.h rename to xen/include/arch-x86/asm/shadow.h diff --git a/xen/include/asm-x86/shared.h b/xen/include/arch-x86/asm/shared.h similarity index 100% rename from xen/include/asm-x86/shared.h rename to xen/include/arch-x86/asm/shared.h diff --git a/xen/include/asm-x86/smp.h b/xen/include/arch-x86/asm/smp.h similarity index 100% rename from xen/include/asm-x86/smp.h rename to xen/include/arch-x86/asm/smp.h diff --git a/xen/include/asm-x86/softirq.h b/xen/include/arch-x86/asm/softirq.h similarity index 100% rename from xen/include/asm-x86/softirq.h rename to xen/include/arch-x86/asm/softirq.h diff --git a/xen/include/asm-x86/spec_ctrl.h b/xen/include/arch-x86/asm/spec_ctrl.h similarity index 100% rename from xen/include/asm-x86/spec_ctrl.h rename to xen/include/arch-x86/asm/spec_ctrl.h diff --git a/xen/include/asm-x86/spec_ctrl_asm.h b/xen/include/arch-x86/asm/spec_ctrl_asm.h similarity index 100% rename from xen/include/asm-x86/spec_ctrl_asm.h rename to xen/include/arch-x86/asm/spec_ctrl_asm.h diff --git a/xen/include/asm-x86/spinlock.h b/xen/include/arch-x86/asm/spinlock.h similarity index 100% rename from xen/include/asm-x86/spinlock.h rename to xen/include/arch-x86/asm/spinlock.h diff --git a/xen/include/asm-x86/string.h b/xen/include/arch-x86/asm/string.h similarity index 100% rename from xen/include/asm-x86/string.h rename to xen/include/arch-x86/asm/string.h diff --git a/xen/include/asm-x86/system.h b/xen/include/arch-x86/asm/system.h similarity index 100% rename from xen/include/asm-x86/system.h rename to xen/include/arch-x86/asm/system.h diff --git a/xen/include/asm-x86/tboot.h b/xen/include/arch-x86/asm/tboot.h similarity index 100% rename from xen/include/asm-x86/tboot.h rename to xen/include/arch-x86/asm/tboot.h diff --git a/xen/include/asm-x86/time.h b/xen/include/arch-x86/asm/time.h similarity index 100% rename from xen/include/asm-x86/time.h rename to xen/include/arch-x86/asm/time.h diff --git a/xen/include/asm-x86/trace.h b/xen/include/arch-x86/asm/trace.h similarity index 100% rename from xen/include/asm-x86/trace.h rename to xen/include/arch-x86/asm/trace.h diff --git a/xen/include/asm-x86/traps.h b/xen/include/arch-x86/asm/traps.h similarity index 100% rename from xen/include/asm-x86/traps.h rename to xen/include/arch-x86/asm/traps.h diff --git a/xen/include/asm-x86/types.h b/xen/include/arch-x86/asm/types.h similarity index 100% rename from xen/include/asm-x86/types.h rename to xen/include/arch-x86/asm/types.h diff --git a/xen/include/asm-x86/uaccess.h b/xen/include/arch-x86/asm/uaccess.h similarity index 100% rename from xen/include/asm-x86/uaccess.h rename to xen/include/arch-x86/asm/uaccess.h diff --git a/xen/include/asm-x86/unaligned.h b/xen/include/arch-x86/asm/unaligned.h similarity index 100% rename from xen/include/asm-x86/unaligned.h rename to xen/include/arch-x86/asm/unaligned.h diff --git a/xen/include/asm-x86/vm_event.h b/xen/include/arch-x86/asm/vm_event.h similarity index 100% rename from xen/include/asm-x86/vm_event.h rename to xen/include/arch-x86/asm/vm_event.h diff --git a/xen/include/asm-x86/vpmu.h b/xen/include/arch-x86/asm/vpmu.h similarity index 100% rename from xen/include/asm-x86/vpmu.h rename to xen/include/arch-x86/asm/vpmu.h diff --git a/xen/include/asm-x86/x86-defns.h b/xen/include/arch-x86/asm/x86-defns.h similarity index 100% rename from xen/include/asm-x86/x86-defns.h rename to xen/include/arch-x86/asm/x86-defns.h diff --git a/xen/include/asm-x86/x86-vendors.h b/xen/include/arch-x86/asm/x86-vendors.h similarity index 100% rename from xen/include/asm-x86/x86-vendors.h rename to xen/include/arch-x86/asm/x86-vendors.h diff --git a/xen/include/asm-x86/x86_64/efibind.h b/xen/include/arch-x86/asm/x86_64/efibind.h similarity index 100% rename from xen/include/asm-x86/x86_64/efibind.h rename to xen/include/arch-x86/asm/x86_64/efibind.h diff --git a/xen/include/asm-x86/x86_64/elf.h b/xen/include/arch-x86/asm/x86_64/elf.h similarity index 100% rename from xen/include/asm-x86/x86_64/elf.h rename to xen/include/arch-x86/asm/x86_64/elf.h diff --git a/xen/include/asm-x86/x86_64/page.h b/xen/include/arch-x86/asm/x86_64/page.h similarity index 100% rename from xen/include/asm-x86/x86_64/page.h rename to xen/include/arch-x86/asm/x86_64/page.h diff --git a/xen/include/asm-x86/x86_64/regs.h b/xen/include/arch-x86/asm/x86_64/regs.h similarity index 100% rename from xen/include/asm-x86/x86_64/regs.h rename to xen/include/arch-x86/asm/x86_64/regs.h diff --git a/xen/include/asm-x86/x86_64/system.h b/xen/include/arch-x86/asm/x86_64/system.h similarity index 100% rename from xen/include/asm-x86/x86_64/system.h rename to xen/include/arch-x86/asm/x86_64/system.h diff --git a/xen/include/asm-x86/x86_64/uaccess.h b/xen/include/arch-x86/asm/x86_64/uaccess.h similarity index 100% rename from xen/include/asm-x86/x86_64/uaccess.h rename to xen/include/arch-x86/asm/x86_64/uaccess.h diff --git a/xen/include/asm-x86/x86_emulate.h b/xen/include/arch-x86/asm/x86_emulate.h similarity index 100% rename from xen/include/asm-x86/x86_emulate.h rename to xen/include/arch-x86/asm/x86_emulate.h diff --git a/xen/include/asm-x86/xenoprof.h b/xen/include/arch-x86/asm/xenoprof.h similarity index 100% rename from xen/include/asm-x86/xenoprof.h rename to xen/include/arch-x86/asm/xenoprof.h diff --git a/xen/include/asm-x86/xstate.h b/xen/include/arch-x86/asm/xstate.h similarity index 100% rename from xen/include/asm-x86/xstate.h rename to xen/include/arch-x86/asm/xstate.h diff --git a/xen/include/xen/acpi.h b/xen/include/xen/acpi.h index 088c238a504a..e03ae4e74ee3 100644 --- a/xen/include/xen/acpi.h +++ b/xen/include/xen/acpi.h @@ -40,8 +40,8 @@ #define ACPI_MADT_GET_TRIGGER(inti) ACPI_MADT_GET_(TRIGGER, inti) /* - * Fixmap pages to reserve for ACPI boot-time tables (see asm-x86/fixmap.h or - * asm-arm/config.h, 64 pages(256KB) is large enough for most cases.) + * Fixmap pages to reserve for ACPI boot-time tables (see arch-x86/asm/fixmap.h + * or arch-arm/asm/config.h, 64 pages(256KB) is large enough for most cases.) */ #define NUM_FIXMAP_ACPI_PAGES 64 diff --git a/xen/include/xen/bitmap.h b/xen/include/xen/bitmap.h index 634a259645fb..6d69c72c2e03 100644 --- a/xen/include/xen/bitmap.h +++ b/xen/include/xen/bitmap.h @@ -14,7 +14,7 @@ * * Function implementations generic to all architectures are in * lib/bitmap.c. Functions implementations that are architecture - * specific are in various include/asm-/bitops.h headers + * specific are in various include/arch-/asm/bitops.h headers * and other arch/ specific files. * * See lib/bitmap.c for more details. -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Thu Jul 01 14:21:56 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 14:21:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148811.275137 (Exim 4.92) (envelope-from ) id 1lyxZj-0005IG-RI; Thu, 01 Jul 2021 14:21:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148811.275137; Thu, 01 Jul 2021 14:21:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyxZj-0005Gh-Dt; Thu, 01 Jul 2021 14:21:55 +0000 Received: by outflank-mailman (input) for mailman id 148811; Thu, 01 Jul 2021 14:21:54 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyxPv-0005F9-L9 for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 14:11:47 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 2af6936c-da76-11eb-8328-12813bfff9fa; Thu, 01 Jul 2021 14:11:03 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2af6936c-da76-11eb-8328-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1625148663; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=d78ReIC4dkXR+RmdsCXwSdPyXPKAHSLgx1r8az094Oo=; b=eIxBi1MBjmYipGvvmIhPEBPKrG9UCNUsnwW5XXsZC9PgxcdePe5u9w+n 3x11jLRKnJG5OFZbKfcoHCct53ACGks3fCV35UFd7j5wQWJHcPuVdTvPp HVkFdjJ1t8il1sTlP/H7w6Mhh7wDdwFwt3KV8j2OW02nyxv00lF36OLJK g=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: HUVxGlcv97ZQa0q3AG+QVFZyCim0+EctzY0AQqEJU9/a4O2q/VswMmJj2dscPL3gGS5BYDUtXu Ln5LcK0JeLj8SLBWQUwwPZcb+CBR0MgtYDN6Z2eKiGPu3pey4nckyiNJkJgawA9ga4padMIavk MLQeozwN95dAxhRg5I7rV8lpyOE2HMyCqFUVBERAhuVgHVHCUChau1oPTa0m60KwD/pveGDB8u 5nw3wXwQep8VcCvGKUxSGPXDNh4CyEMmxS82mYFkvOVaEVcRxv5+iPxyP+T2lT+PFDjW2aqVKp zdQ= X-SBRS: 5.1 X-MesageID: 49007566 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:qE7bfKiEd9bH3XMDcANDU6kM4HBQXtwji2hC6mlwRA09TySZ// rAoB19726StN9xYgBYpTnuAsi9qB/nmKKdpLNhX4tKPzOW3FdATrsD0WKK+VSJcEfDH6xmpM JdmsBFebvN5DNB4/oSjjPVLz9Z+qjlzJyV X-IronPort-AV: E=Sophos;i="5.83,314,1616472000"; d="scan'208";a="49007566" From: Anthony PERARD To: CC: Anthony PERARD , Andrew Cooper , George Dunlap , "Ian Jackson" , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Volodymyr Babchuk , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Daniel De Graaf , "Daniel P. Smith" Subject: [XEN PATCH v6 27/31] build: prepare to always invoke $(MAKE) from xen/, use $(obj) Date: Thu, 1 Jul 2021 15:10:07 +0100 Message-ID: <20210701141011.785641-28-anthony.perard@citrix.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210701141011.785641-1-anthony.perard@citrix.com> References: <20210701141011.785641-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain In a future patch, when building a subdirectory, we will set "obj=$subdir" rather than change directory. Before that, we add "$(obj)" and "$(src)" in as many places as possible where we will need to know which subdirectory is been built. "$(obj)" is for files been generated during the build, and "$(src)" is for files present in the source tree. For now, we set both to "." in Rules.mk and Makefile.clean. A few places don't tolerate the addition of "./", this is because make remove the leading "./" in targets and dependencies in rules, so these will be change later. Signed-off-by: Anthony PERARD --- xen/Rules.mk | 5 ++- xen/arch/arm/Makefile | 14 +++--- xen/arch/x86/Makefile | 60 ++++++++++++------------- xen/arch/x86/boot/Makefile | 14 +++--- xen/arch/x86/efi/Makefile | 6 +-- xen/common/Makefile | 8 ++-- xen/common/libelf/Makefile | 4 +- xen/common/libfdt/Makefile | 6 +-- xen/include/Makefile | 44 +++++++++--------- xen/scripts/Makefile.clean | 5 ++- xen/xsm/flask/Makefile | 34 +++++++------- xen/xsm/flask/policy/mkaccess_vector.sh | 7 ++- 12 files changed, 108 insertions(+), 99 deletions(-) diff --git a/xen/Rules.mk b/xen/Rules.mk index 530aefa43ad9..0f8d90844455 100644 --- a/xen/Rules.mk +++ b/xen/Rules.mk @@ -3,6 +3,9 @@ # Makefile and are consumed by Rules.mk # +obj := . +src := $(obj) + -include $(BASEDIR)/include/config/auto.conf include $(XEN_ROOT)/Config.mk @@ -23,7 +26,7 @@ SPECIAL_DATA_SECTIONS := rodata $(foreach a,1 2 4 8 16, \ rodata.cst$(a)) \ $(foreach r,rel rel.ro,data.$(r).local) -include Makefile +include $(src)/Makefile # Linking # --------------------------------------------------------------------------- diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile index 067c0d9844e4..9f9c73aa6c5d 100644 --- a/xen/arch/arm/Makefile +++ b/xen/arch/arm/Makefile @@ -88,18 +88,18 @@ ifeq ($(CONFIG_ARM_64),y) ln -sf $(@F) $@.efi endif -$(TARGET)-syms: $(BASEDIR)/prelink.o xen.lds - $(LD) $(XEN_LDFLAGS) -T xen.lds -N $< \ +$(TARGET)-syms: $(BASEDIR)/prelink.o $(obj)/xen.lds + $(LD) $(XEN_LDFLAGS) -T $(obj)/xen.lds -N $< \ $(BASEDIR)/common/symbols-dummy.o -o $(@D)/.$(@F).0 $(NM) -pa --format=sysv $(@D)/.$(@F).0 \ | $(BASEDIR)/tools/symbols $(all_symbols) --sysv --sort >$(@D)/.$(@F).0.S $(MAKE) -f $(BASEDIR)/Rules.mk $(@D)/.$(@F).0.o - $(LD) $(XEN_LDFLAGS) -T xen.lds -N $< \ + $(LD) $(XEN_LDFLAGS) -T $(obj)/xen.lds -N $< \ $(@D)/.$(@F).0.o -o $(@D)/.$(@F).1 $(NM) -pa --format=sysv $(@D)/.$(@F).1 \ | $(BASEDIR)/tools/symbols $(all_symbols) --sysv --sort >$(@D)/.$(@F).1.S $(MAKE) -f $(BASEDIR)/Rules.mk $(@D)/.$(@F).1.o - $(LD) $(XEN_LDFLAGS) -T xen.lds -N $< $(build_id_linker) \ + $(LD) $(XEN_LDFLAGS) -T $(obj)/xen.lds -N $< $(build_id_linker) \ $(@D)/.$(@F).1.o -o $@ $(NM) -pa --format=sysv $(@D)/$(@F) \ | $(BASEDIR)/tools/symbols --all-symbols --xensyms --sysv --sort \ @@ -109,13 +109,13 @@ $(TARGET)-syms: $(BASEDIR)/prelink.o xen.lds .PHONY: include include: -xen.lds: xen.lds.S FORCE +$(obj)/xen.lds: $(src)/xen.lds.S FORCE $(call if_changed,cpp_lds_S) -dtb.o: $(patsubst "%",%,$(CONFIG_DTB_FILE)) +$(obj)/dtb.o: $(patsubst "%",%,$(CONFIG_DTB_FILE)) .PHONY: clean clean:: - rm -f xen.lds + rm -f $(obj)/xen.lds rm -f $(BASEDIR)/.xen-syms.[0-9]* rm -f $(TARGET).efi diff --git a/xen/arch/x86/Makefile b/xen/arch/x86/Makefile index fc719247eac9..2cc67d6e0e84 100644 --- a/xen/arch/x86/Makefile +++ b/xen/arch/x86/Makefile @@ -82,7 +82,7 @@ extra-y += asm-macros.i extra-y += xen.lds ifneq ($(CONFIG_HVM),y) -x86_emulate.o: CFLAGS-y += -Wno-unused-label +$(obj)/x86_emulate.o: CFLAGS-y += -Wno-unused-label endif efi-y := $(shell if [ ! -r $(BASEDIR)/include/xen/compile.h -o \ @@ -113,8 +113,8 @@ syms-warn-dup-$(CONFIG_SUPPRESS_DUPLICATE_SYMBOL_WARNINGS) := syms-warn-dup-$(CONFIG_ENFORCE_UNIQUE_SYMBOLS) := --error-dup $(TARGET): TMP = $(@D)/.$(@F).elf32 -$(TARGET): $(TARGET)-syms $(efi-y) boot/mkelf32 - ./boot/mkelf32 $(notes_phdrs) $(TARGET)-syms $(TMP) $(XEN_IMG_OFFSET) \ +$(TARGET): $(TARGET)-syms $(efi-y) $(obj)/boot/mkelf32 + $(obj)/boot/mkelf32 $(notes_phdrs) $(TARGET)-syms $(TMP) $(XEN_IMG_OFFSET) \ `$(NM) $(TARGET)-syms | sed -ne 's/^\([^ ]*\) . __2M_rwdata_end$$/0x\1/p'` od -t x4 -N 8192 $(TMP) | grep 1badb002 > /dev/null || \ { echo "No Multiboot1 header found" >&2; false; } @@ -125,29 +125,29 @@ $(TARGET): $(TARGET)-syms $(efi-y) boot/mkelf32 ifneq ($(efi-y),) # Check if the compiler supports the MS ABI. -XEN_BUILD_EFI := $(shell $(CC) $(XEN_CFLAGS) -c efi/check.c -o efi/check.o 2>/dev/null && echo y) +XEN_BUILD_EFI := $(shell $(CC) $(XEN_CFLAGS) -c $(src)/efi/check.c -o $(obj)/efi/check.o 2>/dev/null && echo y) CFLAGS-$(XEN_BUILD_EFI) += -DXEN_BUILD_EFI # Check if the linker supports PE. EFI_LDFLAGS = $(patsubst -m%,-mi386pep,$(XEN_LDFLAGS)) --subsystem=10 -XEN_BUILD_PE := $(if $(XEN_BUILD_EFI),$(call ld-option,$(EFI_LDFLAGS) --image-base=0x100000000 -o efi/check.efi efi/check.o)) +XEN_BUILD_PE := $(if $(XEN_BUILD_EFI),$(call ld-option,$(EFI_LDFLAGS) --image-base=0x100000000 -o $(obj)/efi/check.efi $(obj)/efi/check.o)) # If the above failed, it may be merely because of the linker not dealing well # with debug info. Try again with stripping it. ifeq ($(CONFIG_DEBUG_INFO)-$(XEN_BUILD_PE),y-n) EFI_LDFLAGS += --strip-debug -XEN_BUILD_PE := $(call ld-option,$(EFI_LDFLAGS) --image-base=0x100000000 -o efi/check.efi efi/check.o) +XEN_BUILD_PE := $(call ld-option,$(EFI_LDFLAGS) --image-base=0x100000000 -o $(obj)/efi/check.efi $(obj)/efi/check.o) endif ifeq ($(XEN_BUILD_PE),y) # Check if the linker produces fixups in PE by default -nr-fixups := $(shell $(OBJDUMP) -p efi/check.efi | grep '^[[:blank:]]*reloc[[:blank:]]*[0-9][[:blank:]].*DIR64$$' | wc -l) +nr-fixups := $(shell $(OBJDUMP) -p $(obj)/efi/check.efi | grep '^[[:blank:]]*reloc[[:blank:]]*[0-9][[:blank:]].*DIR64$$' | wc -l) ifeq ($(nr-fixups),2) MKRELOC := : relocs-dummy := else -MKRELOC := efi/mkreloc -relocs-dummy := efi/relocs-dummy.o +MKRELOC := $(obj)/efi/mkreloc +relocs-dummy := $(obj)/efi/relocs-dummy.o # If the linker produced fixups but not precisely two of them, we need to # disable it doing so. But if it didn't produce any fixups, it also wouldn't # recognize the option. @@ -160,27 +160,27 @@ endif # $(XEN_BUILD_PE) endif # $(efi-y) -$(TARGET)-syms: $(BASEDIR)/prelink.o xen.lds - $(LD) $(XEN_LDFLAGS) -T xen.lds -N $< $(build_id_linker) \ +$(TARGET)-syms: $(BASEDIR)/prelink.o $(obj)/xen.lds + $(LD) $(XEN_LDFLAGS) -T $(obj)/xen.lds -N $< $(build_id_linker) \ $(BASEDIR)/common/symbols-dummy.o -o $(@D)/.$(@F).0 $(NM) -pa --format=sysv $(@D)/.$(@F).0 \ | $(BASEDIR)/tools/symbols $(all_symbols) --sysv --sort \ >$(@D)/.$(@F).0.S $(MAKE) -f $(BASEDIR)/Rules.mk $(@D)/.$(@F).0.o - $(LD) $(XEN_LDFLAGS) -T xen.lds -N $< $(build_id_linker) \ + $(LD) $(XEN_LDFLAGS) -T $(obj)/xen.lds -N $< $(build_id_linker) \ $(@D)/.$(@F).0.o -o $(@D)/.$(@F).1 $(NM) -pa --format=sysv $(@D)/.$(@F).1 \ | $(BASEDIR)/tools/symbols $(all_symbols) --sysv --sort $(syms-warn-dup-y) \ >$(@D)/.$(@F).1.S $(MAKE) -f $(BASEDIR)/Rules.mk $(@D)/.$(@F).1.o - $(LD) $(XEN_LDFLAGS) -T xen.lds -N $< $(build_id_linker) \ + $(LD) $(XEN_LDFLAGS) -T $(obj)/xen.lds -N $< $(build_id_linker) \ $(@D)/.$(@F).1.o -o $@ $(NM) -pa --format=sysv $(@D)/$(@F) \ | $(BASEDIR)/tools/symbols --all-symbols --xensyms --sysv --sort \ >$(@D)/$(@F).map rm -f $(@D)/.$(@F).[0-9]* $(@D)/..$(@F).[0-9]* -note.o: $(TARGET)-syms +$(obj)/note.o: $(TARGET)-syms $(OBJCOPY) -O binary --only-section=.note.gnu.build-id $< $@.bin $(OBJCOPY) -I binary -O elf64-x86-64 -B i386:x86-64 \ --rename-section=.data=.note.gnu.build-id -S $@.bin $@ @@ -199,23 +199,23 @@ ifdef SOURCE_DATE_EPOCH EFI_LDFLAGS += --no-insert-timestamp endif -$(TARGET).efi: VIRT_BASE = 0x$(shell $(NM) efi/relocs-dummy.o | sed -n 's, A VIRT_START$$,,p') +$(TARGET).efi: VIRT_BASE = 0x$(shell $(NM) $(obj)/efi/relocs-dummy.o | sed -n 's, A VIRT_START$$,,p') ifeq ($(MKRELOC),:) $(TARGET).efi: ALT_BASE := else -$(TARGET).efi: ALT_BASE = 0x$(shell $(NM) efi/relocs-dummy.o | sed -n 's, A ALT_START$$,,p') +$(TARGET).efi: ALT_BASE = 0x$(shell $(NM) $(obj)/efi/relocs-dummy.o | sed -n 's, A ALT_START$$,,p') endif ifneq ($(build_id_linker),) ifeq ($(call ld-ver-build-id,$(LD) $(filter -m%,$(EFI_LDFLAGS))),y) CFLAGS-y += -DBUILD_ID_EFI EFI_LDFLAGS += $(build_id_linker) -note_file := efi/buildid.o +note_file := $(obj)/efi/buildid.o # NB: this must be the last input in the linker call, because inputs following # the -b option will all be treated as being in the specified format. note_file_option := -b pe-x86-64 $(note_file) else -note_file := note.o +note_file := $(obj)/note.o endif else note_file := @@ -224,25 +224,25 @@ note_file_option ?= $(note_file) ifeq ($(XEN_BUILD_PE),y) extra-y += efi.lds -$(TARGET).efi: $(BASEDIR)/prelink.o $(note_file) efi.lds efi/relocs-dummy.o efi/mkreloc +$(TARGET).efi: $(BASEDIR)/prelink.o $(note_file) $(obj)/efi.lds $(obj)/efi/relocs-dummy.o $(obj)/efi/mkreloc ifeq ($(CONFIG_DEBUG_INFO),y) $(if $(filter --strip-debug,$(EFI_LDFLAGS)),echo,:) "Will strip debug info from $(@F)" endif $(foreach base, $(VIRT_BASE) $(ALT_BASE), \ - $(LD) $(call EFI_LDFLAGS,$(base)) -T efi.lds -N $< $(relocs-dummy) \ + $(LD) $(call EFI_LDFLAGS,$(base)) -T $(obj)/efi.lds -N $< $(relocs-dummy) \ $(BASEDIR)/common/symbols-dummy.o $(note_file_option) -o $(@D)/.$(@F).$(base).0 &&) : $(MKRELOC) $(foreach base,$(VIRT_BASE) $(ALT_BASE),$(@D)/.$(@F).$(base).0) >$(@D)/.$(@F).0r.S $(NM) -pa --format=sysv $(@D)/.$(@F).$(VIRT_BASE).0 \ | $(BASEDIR)/tools/symbols $(all_symbols) --sysv --sort >$(@D)/.$(@F).0s.S $(MAKE) -f $(BASEDIR)/Rules.mk $(@D)/.$(@F).0r.o $(@D)/.$(@F).0s.o $(foreach base, $(VIRT_BASE) $(ALT_BASE), \ - $(LD) $(call EFI_LDFLAGS,$(base)) -T efi.lds -N $< \ + $(LD) $(call EFI_LDFLAGS,$(base)) -T $(obj)/efi.lds -N $< \ $(@D)/.$(@F).0r.o $(@D)/.$(@F).0s.o $(note_file_option) -o $(@D)/.$(@F).$(base).1 &&) : $(MKRELOC) $(foreach base,$(VIRT_BASE) $(ALT_BASE),$(@D)/.$(@F).$(base).1) >$(@D)/.$(@F).1r.S $(NM) -pa --format=sysv $(@D)/.$(@F).$(VIRT_BASE).1 \ | $(BASEDIR)/tools/symbols $(all_symbols) --sysv --sort >$(@D)/.$(@F).1s.S $(MAKE) -f $(BASEDIR)/Rules.mk $(@D)/.$(@F).1r.o $(@D)/.$(@F).1s.o - $(LD) $(call EFI_LDFLAGS,$(VIRT_BASE)) -T efi.lds -N $< \ + $(LD) $(call EFI_LDFLAGS,$(VIRT_BASE)) -T $(obj)/efi.lds -N $< \ $(@D)/.$(@F).1r.o $(@D)/.$(@F).1s.o $(note_file_option) -o $@ $(NM) -pa --format=sysv $(@D)/$(@F) \ | $(BASEDIR)/tools/symbols --all-symbols --xensyms --sysv --sort >$(@D)/$(@F).map @@ -253,15 +253,15 @@ $(TARGET).efi: FORCE echo '$(if $(filter y,$(XEN_BUILD_EFI)),xen.efi generation,EFI support) disabled' endif -efi/buildid.o efi/relocs-dummy.o: $(BASEDIR)/arch/x86/efi/built_in.o -efi/buildid.o efi/relocs-dummy.o: ; +$(obj)/efi/buildid.o $(obj)/efi/relocs-dummy.o: $(BASEDIR)/arch/x86/efi/built_in.o +$(obj)/efi/buildid.o $(obj)/efi/relocs-dummy.o: ; .PHONY: include include: $(BASEDIR)/include/arch-x86/asm/asm-macros.h -asm-macros.i: CFLAGS-y += -D__ASSEMBLY__ -P +$(obj)/asm-macros.i: CFLAGS-y += -D__ASSEMBLY__ -P -$(BASEDIR)/include/arch-x86/asm/asm-macros.h: asm-macros.i Makefile +$(BASEDIR)/include/arch-x86/asm/asm-macros.h: $(obj)/asm-macros.i $(src)/Makefile echo '#if 0' >$@.new echo '.if 0' >>$@.new echo '#endif' >>$@.new @@ -275,14 +275,14 @@ $(BASEDIR)/include/arch-x86/asm/asm-macros.h: asm-macros.i Makefile echo '#endif' >>$@.new $(call move-if-changed,$@.new,$@) -efi.lds: AFLAGS-y += -DEFI -xen.lds efi.lds: xen.lds.S FORCE +$(obj)/efi.lds: AFLAGS-y += -DEFI +$(obj)/xen.lds $(obj)/efi.lds: $(src)/xen.lds.S FORCE $(call if_changed,cpp_lds_S) -boot/mkelf32: boot/mkelf32.c +$(obj)/boot/mkelf32: $(src)/boot/mkelf32.c $(HOSTCC) $(HOSTCFLAGS) -o $@ $< -efi/mkreloc: efi/mkreloc.c +$(obj)/efi/mkreloc: $(src)/efi/mkreloc.c $(HOSTCC) $(HOSTCFLAGS) -g -o $@ $< .PHONY: clean diff --git a/xen/arch/x86/boot/Makefile b/xen/arch/x86/boot/Makefile index 9b31bfcbfb8a..53d357489df2 100644 --- a/xen/arch/x86/boot/Makefile +++ b/xen/arch/x86/boot/Makefile @@ -1,8 +1,8 @@ obj-bin-y += head.o -DEFS_H_DEPS = defs.h $(BASEDIR)/include/xen/stdbool.h +DEFS_H_DEPS = $(src)/defs.h $(BASEDIR)/include/xen/stdbool.h -CMDLINE_DEPS = $(DEFS_H_DEPS) video.h +CMDLINE_DEPS = $(DEFS_H_DEPS) $(src)/video.h RELOC_DEPS = $(DEFS_H_DEPS) \ $(BASEDIR)/include/generated/autoconf.h \ @@ -11,10 +11,10 @@ RELOC_DEPS = $(DEFS_H_DEPS) \ $(BASEDIR)/include/xen/multiboot2.h \ $(BASEDIR)/include/public/arch-x86/hvm/start_info.h -head.o: cmdline.S reloc.S +$(obj)/head.o: $(obj)/cmdline.S $(obj)/reloc.S -cmdline.S: cmdline.c $(CMDLINE_DEPS) - $(MAKE) -f build32.mk $@ CMDLINE_DEPS="$(CMDLINE_DEPS)" +$(obj)/cmdline.S: $(src)/cmdline.c $(CMDLINE_DEPS) + $(MAKE) -f build32.mk -C $(obj) $(@F) CMDLINE_DEPS="$(CMDLINE_DEPS)" -reloc.S: reloc.c $(RELOC_DEPS) - $(MAKE) -f build32.mk $@ RELOC_DEPS="$(RELOC_DEPS)" +$(obj)/reloc.S: $(src)/reloc.c $(RELOC_DEPS) + $(MAKE) -f build32.mk -C $(obj) $(@F) RELOC_DEPS="$(RELOC_DEPS)" diff --git a/xen/arch/x86/efi/Makefile b/xen/arch/x86/efi/Makefile index 87b927ed865b..ac815f02cb5e 100644 --- a/xen/arch/x86/efi/Makefile +++ b/xen/arch/x86/efi/Makefile @@ -3,16 +3,16 @@ CFLAGS-y += -fshort-wchar quiet_cmd_objcopy_o_ihex = OBJCOPY $@ cmd_objcopy_o_ihex = $(OBJCOPY) -I ihex -O binary $< $@ -%.o: %.ihex FORCE +$(obj)/%.o: $(src)/%.ihex FORCE $(call if_changed,objcopy_o_ihex) -boot.init.o: buildid.o +$(obj)/boot.init.o: $(obj)/buildid.o EFIOBJ-y := boot.init.o pe.init.o ebmalloc.o runtime.o EFIOBJ-$(CONFIG_COMPAT) += compat.o $(call cc-option-add,cflags-stack-boundary,CC,-mpreferred-stack-boundary=4) -$(EFIOBJ-y): CFLAGS-stack-boundary := $(cflags-stack-boundary) +$(addprefix $(obj)/,$(EFIOBJ-y)): CFLAGS-stack-boundary := $(cflags-stack-boundary) obj-y := stub.o obj-$(XEN_BUILD_EFI) := $(filter-out %.init.o,$(EFIOBJ-y)) diff --git a/xen/common/Makefile b/xen/common/Makefile index 93df3178b71f..0d5509583427 100644 --- a/xen/common/Makefile +++ b/xen/common/Makefile @@ -75,15 +75,15 @@ obj-$(CONFIG_NEEDS_LIBELF) += libelf/ obj-$(CONFIG_HAS_DEVICE_TREE) += libfdt/ CONF_FILE := $(if $(patsubst /%,,$(KCONFIG_CONFIG)),$(BASEDIR)/)$(KCONFIG_CONFIG) -config.gz: $(CONF_FILE) +$(obj)/config.gz: $(CONF_FILE) gzip -n -c $< >$@ -config_data.o: config.gz +$(obj)/config_data.o: $(obj)/config.gz quiet_cmd_binfile = BINFILE $@ -cmd_binfile = $(SHELL) $< $@ config.gz xen_config_data +cmd_binfile = $(SHELL) $< $@ $(obj)/config.gz xen_config_data -config_data.S: $(BASEDIR)/tools/binfile FORCE +$(obj)/config_data.S: $(BASEDIR)/tools/binfile FORCE $(call if_changed,binfile) targets += config_data.S diff --git a/xen/common/libelf/Makefile b/xen/common/libelf/Makefile index a92326c982e9..8a4522e4e141 100644 --- a/xen/common/libelf/Makefile +++ b/xen/common/libelf/Makefile @@ -7,10 +7,10 @@ OBJCOPYFLAGS := $(foreach s,$(SECTIONS),--rename-section .$(s)=.init.$(s)) CFLAGS-y += -Wno-pointer-sign -libelf.o: libelf-temp.o FORCE +$(obj)/libelf.o: $(obj)/libelf-temp.o FORCE $(call if_changed,objcopy) -libelf-temp.o: $(libelf-objs) FORCE +$(obj)/libelf-temp.o: $(addprefix $(obj)/,$(libelf-objs)) FORCE $(call if_changed,ld) extra-y += libelf-temp.o $(libelf-objs) diff --git a/xen/common/libfdt/Makefile b/xen/common/libfdt/Makefile index 6bd207cf8ffa..6708af12e583 100644 --- a/xen/common/libfdt/Makefile +++ b/xen/common/libfdt/Makefile @@ -1,4 +1,4 @@ -include Makefile.libfdt +include $(src)/Makefile.libfdt SECTIONS := text data $(SPECIAL_DATA_SECTIONS) OBJCOPYFLAGS := $(foreach s,$(SECTIONS),--rename-section .$(s)=.init.$(s)) @@ -8,10 +8,10 @@ nocov-y += libfdt.o CFLAGS-y += -I$(BASEDIR)/include/xen/libfdt/ -libfdt.o: libfdt-temp.o FORCE +$(obj)/libfdt.o: $(obj)/libfdt-temp.o FORCE $(call if_changed,objcopy) -libfdt-temp.o: $(LIBFDT_OBJS) FORCE +$(obj)/libfdt-temp.o: $(addprefix $(obj)/,$(LIBFDT_OBJS)) FORCE $(call if_changed,ld) extra-y += libfdt-temp.o $(LIBFDT_OBJS) diff --git a/xen/include/Makefile b/xen/include/Makefile index 9feb57545ef1..a969e76ddcad 100644 --- a/xen/include/Makefile +++ b/xen/include/Makefile @@ -39,57 +39,57 @@ cppflags-$(CONFIG_X86) += -m32 endif -public-$(CONFIG_X86) := $(wildcard public/arch-x86/*.h public/arch-x86/*/*.h) -public-$(CONFIG_ARM) := $(wildcard public/arch-arm/*.h public/arch-arm/*/*.h) +public-$(CONFIG_X86) := $(wildcard $(src)/public/arch-x86/*.h $(src)/public/arch-x86/*/*.h) +public-$(CONFIG_ARM) := $(wildcard $(src)/public/arch-arm/*.h $(src)/public/arch-arm/*/*.h) .PHONY: all -all: $(headers-y) +all: $(addprefix $(obj)/,$(headers-y)) -compat/%.h: compat/%.i $(BASEDIR)/tools/compat-build-header.py - $(PYTHON) $(BASEDIR)/tools/compat-build-header.py <$< $@ >>$@.new; \ +$(obj)/compat/%.h: $(obj)/compat/%.i $(BASEDIR)/tools/compat-build-header.py + $(PYTHON) $(BASEDIR)/tools/compat-build-header.py <$< $(patsubst $(obj)/%,%,$@) >>$@.new; \ mv -f $@.new $@ -compat/%.i: compat/%.c Makefile +$(obj)/compat/%.i: $(obj)/compat/%.c $(src)/Makefile $(CPP) $(filter-out -Wa$(comma)% -include %/include/xen/config.h,$(XEN_CFLAGS)) $(cppflags-y) -o $@ $< -compat/%.c: public/%.h xlat.lst $(BASEDIR)/tools/compat-build-source.py +$(obj)/compat/%.c: $(src)/public/%.h $(src)/xlat.lst $(BASEDIR)/tools/compat-build-source.py mkdir -p $(@D) - $(PYTHON) $(BASEDIR)/tools/compat-build-source.py xlat.lst <$< >$@.new + $(PYTHON) $(BASEDIR)/tools/compat-build-source.py $(src)/xlat.lst <$< >$@.new mv -f $@.new $@ -compat/.xlat/%.h: compat/%.h compat/.xlat/%.lst $(BASEDIR)/tools/get-fields.sh Makefile +$(obj)/compat/.xlat/%.h: $(obj)/compat/%.h $(obj)/compat/.xlat/%.lst $(BASEDIR)/tools/get-fields.sh $(src)/Makefile export PYTHON=$(PYTHON); \ while read what name; do \ $(SHELL) $(BASEDIR)/tools/get-fields.sh "$$what" compat_$$name $< || exit $$?; \ done <$(patsubst compat/%,compat/.xlat/%,$(basename $<)).lst >$@.new mv -f $@.new $@ -.PRECIOUS: compat/.xlat/%.lst -compat/.xlat/%.lst: xlat.lst Makefile +.PRECIOUS: $(obj)/compat/.xlat/%.lst +$(obj)/compat/.xlat/%.lst: $(src)/xlat.lst $(src)/Makefile mkdir -p $(@D) grep -v '^[[:blank:]]*#' $< | sed -ne 's,@arch@,$(compat-arch-y),g' -re 's,[[:blank:]]+$*\.h[[:blank:]]*$$,,p' >$@.new $(call move-if-changed,$@.new,$@) -xlat-y := $(shell sed -ne 's,@arch@,$(compat-arch-y),g' -re 's,^[?!][[:blank:]]+[^[:blank:]]+[[:blank:]]+,,p' xlat.lst | uniq) +xlat-y := $(shell sed -ne 's,@arch@,$(compat-arch-y),g' -re 's,^[?!][[:blank:]]+[^[:blank:]]+[[:blank:]]+,,p' $(src)/xlat.lst | uniq) xlat-y := $(filter $(patsubst compat/%,%,$(headers-y)),$(xlat-y)) -compat/xlat.h: $(addprefix compat/.xlat/,$(xlat-y)) config/auto.conf Makefile +$(obj)/compat/xlat.h: $(addprefix $(obj)/compat/.xlat/,$(xlat-y)) $(obj)/config/auto.conf $(src)/Makefile cat $(filter %.h,$^) >$@.new mv -f $@.new $@ ifeq ($(XEN_TARGET_ARCH),$(XEN_COMPILE_ARCH)) -all: headers.chk headers99.chk headers++.chk +all: $(obj)/headers.chk $(obj)/headers99.chk $(obj)/headers++.chk -PUBLIC_HEADERS := $(filter-out public/arch-% public/dom0_ops.h, $(wildcard public/*.h public/*/*.h) $(public-y)) +PUBLIC_HEADERS := $(filter-out $(src)/public/arch-% $(src)/public/dom0_ops.h, $(wildcard $(src)/public/*.h $(src)/public/*/*.h) $(public-y)) -PUBLIC_C99_HEADERS := public/io/9pfs.h public/io/pvcalls.h -PUBLIC_ANSI_HEADERS := $(filter-out public/%ctl.h public/xsm/% public/%hvm/save.h $(PUBLIC_C99_HEADERS), $(PUBLIC_HEADERS)) +PUBLIC_C99_HEADERS := $(src)/public/io/9pfs.h $(src)/public/io/pvcalls.h +PUBLIC_ANSI_HEADERS := $(filter-out $(src)/public/%ctl.h $(src)/public/xsm/% $(src)/public/%hvm/save.h $(PUBLIC_C99_HEADERS), $(PUBLIC_HEADERS)) public/io/9pfs.h-prereq := string public/io/pvcalls.h-prereq := string -headers.chk: $(PUBLIC_ANSI_HEADERS) Makefile +$(obj)/headers.chk: $(PUBLIC_ANSI_HEADERS) $(src)/Makefile for i in $(filter %.h,$^); do \ $(CC) -x c -ansi -Wall -Werror -include stdint.h \ -S -o /dev/null $$i || exit 1; \ @@ -97,7 +97,7 @@ headers.chk: $(PUBLIC_ANSI_HEADERS) Makefile done >$@.new mv $@.new $@ -headers99.chk: $(PUBLIC_C99_HEADERS) Makefile +$(obj)/headers99.chk: $(PUBLIC_C99_HEADERS) $(src)/Makefile rm -f $@.new $(foreach i, $(filter %.h,$^), \ echo "#include "\"$(i)\" \ @@ -107,7 +107,7 @@ headers99.chk: $(PUBLIC_C99_HEADERS) Makefile || exit $$?; echo $(i) >> $@.new;) mv $@.new $@ -headers++.chk: $(PUBLIC_HEADERS) Makefile +$(obj)/headers++.chk: $(PUBLIC_HEADERS) $(src)/Makefile rm -f $@.new if ! $(CXX) -v >/dev/null 2>&1; then \ touch $@.new; \ @@ -116,7 +116,7 @@ headers++.chk: $(PUBLIC_HEADERS) Makefile $(foreach i, $(filter %.h,$^), \ echo "#include "\"$(i)\" \ | $(CXX) -x c++ -std=gnu++98 -Wall -Werror -D__XEN_TOOLS__ \ - -include stdint.h -include public/xen.h \ + -include stdint.h -include $(src)/public/xen.h \ $(foreach j, $($(i)-prereq), -include c$(j)) -S -o /dev/null - \ || exit $$?; echo $(i) >> $@.new;) mv $@.new $@ @@ -126,7 +126,7 @@ endif ifeq ($(XEN_TARGET_ARCH),x86_64) .PHONY: lib-x86-all lib-x86-all: - $(MAKE) -C xen/lib/x86 all + $(MAKE) -C $(obj)/xen/lib/x86 all all: lib-x86-all endif diff --git a/xen/scripts/Makefile.clean b/xen/scripts/Makefile.clean index b6df9e861e6e..36b7e7e92f93 100644 --- a/xen/scripts/Makefile.clean +++ b/xen/scripts/Makefile.clean @@ -3,11 +3,14 @@ # Cleaning up # ========================================================================== +obj := . +src := $(obj) + clean:: include $(BASEDIR)/scripts/Kbuild.include -include Makefile +include $(src)/Makefile # Figure out what we need to clean from the various variables # ========================================================================== diff --git a/xen/xsm/flask/Makefile b/xen/xsm/flask/Makefile index 0ad15cb16606..3ea726d66f8b 100644 --- a/xen/xsm/flask/Makefile +++ b/xen/xsm/flask/Makefile @@ -4,48 +4,48 @@ obj-y += flask_op.o obj-y += ss/ -CFLAGS-y += -I./include +CFLAGS-y += -I$(obj)/include AWK = awk -FLASK_H_DEPEND = policy/security_classes policy/initial_sids -AV_H_DEPEND = policy/access_vectors +FLASK_H_DEPEND := $(addprefix $(src)/policy/,security_classes initial_sids) +AV_H_DEPEND = $(src)/policy/access_vectors -FLASK_H_FILES = include/flask.h include/class_to_string.h include/initial_sid_to_string.h -AV_H_FILES = include/av_perm_to_string.h include/av_permissions.h -ALL_H_FILES = $(FLASK_H_FILES) $(AV_H_FILES) +FLASK_H_FILES := flask.h class_to_string.h initial_sid_to_string.h +AV_H_FILES := av_perm_to_string.h av_permissions.h +ALL_H_FILES := $(addprefix include/,$(FLASK_H_FILES) $(AV_H_FILES)) -$(obj-y) ss/built_in.o: $(ALL_H_FILES) +$(addprefix $(obj)/,$(obj-y)) $(obj)/ss/built_in.o: $(addprefix $(obj)/,$(ALL_H_FILES)) extra-y += $(ALL_H_FILES) -mkflask := policy/mkflask.sh +mkflask := $(src)/policy/mkflask.sh quiet_cmd_mkflask = MKFLASK $@ -cmd_mkflask = $(SHELL) $(mkflask) $(AWK) include $(FLASK_H_DEPEND) +cmd_mkflask = $(SHELL) $(mkflask) $(AWK) $(obj)/include $(FLASK_H_DEPEND) -$(subst include/,%/,$(FLASK_H_FILES)): $(FLASK_H_DEPEND) $(mkflask) FORCE +$(addprefix $(obj)/%/,$(FLASK_H_FILES)): $(FLASK_H_DEPEND) $(mkflask) FORCE $(call if_changed,mkflask) -mkaccess := policy/mkaccess_vector.sh +mkaccess := $(src)/policy/mkaccess_vector.sh quiet_cmd_mkaccess = MKACCESS VECTOR $@ -cmd_mkaccess = $(SHELL) $(mkaccess) $(AWK) $(AV_H_DEPEND) +cmd_mkaccess = $(SHELL) $(mkaccess) $(AWK) $(obj)/include $(AV_H_DEPEND) -$(subst include/,%/,$(AV_H_FILES)): $(AV_H_DEPEND) $(mkaccess) FORCE +$(addprefix $(obj)/%/,$(AV_H_FILES)): $(AV_H_DEPEND) $(mkaccess) FORCE $(call if_changed,mkaccess) obj-bin-$(CONFIG_XSM_FLASK_POLICY) += flask-policy.o -flask-policy.o: policy.bin +$(obj)/flask-policy.o: $(obj)/policy.bin quiet_cmd_binfile = BINFILE $@ -cmd_binfile = $(SHELL) $< -i $@ policy.bin xsm_flask_init_policy +cmd_binfile = $(SHELL) $< -i $@ $(obj)/policy.bin xsm_flask_init_policy -flask-policy.S: $(BASEDIR)/tools/binfile FORCE +$(obj)/flask-policy.S: $(BASEDIR)/tools/binfile FORCE $(call if_changed,binfile) targets += flask-policy.S FLASK_BUILD_DIR := $(CURDIR) POLICY_SRC := $(FLASK_BUILD_DIR)/xenpolicy-$(XEN_FULLVERSION) -policy.bin: FORCE +$(obj)/policy.bin: FORCE $(MAKE) -f $(XEN_ROOT)/tools/flask/policy/Makefile.common -C $(XEN_ROOT)/tools/flask/policy FLASK_BUILD_DIR=$(FLASK_BUILD_DIR) cmp -s $(POLICY_SRC) $@ || cp $(POLICY_SRC) $@ diff --git a/xen/xsm/flask/policy/mkaccess_vector.sh b/xen/xsm/flask/policy/mkaccess_vector.sh index 942ede4713f1..ad9772193bff 100755 --- a/xen/xsm/flask/policy/mkaccess_vector.sh +++ b/xen/xsm/flask/policy/mkaccess_vector.sh @@ -8,9 +8,12 @@ set -e awk=$1 shift +output_dir=$1 +shift + # output files -av_permissions="include/av_permissions.h" -av_perm_to_string="include/av_perm_to_string.h" +av_permissions="$output_dir/av_permissions.h" +av_perm_to_string="$output_dir/av_perm_to_string.h" cat $* | $awk " BEGIN { -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Thu Jul 01 14:21:58 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 14:21:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148818.275146 (Exim 4.92) (envelope-from ) id 1lyxZl-0005bc-Qk; Thu, 01 Jul 2021 14:21:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148818.275146; Thu, 01 Jul 2021 14:21:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyxZl-0005at-79; Thu, 01 Jul 2021 14:21:57 +0000 Received: by outflank-mailman (input) for mailman id 148818; Thu, 01 Jul 2021 14:21:56 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyxQE-0005tj-2W for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 14:12:06 +0000 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 3e185f9f-3ef5-4d01-9e93-0151a4543101; Thu, 01 Jul 2021 14:10:54 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3e185f9f-3ef5-4d01-9e93-0151a4543101 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1625148653; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=eij+P9eDuvxcdz2BMz8URUEWDz4oxMoXS30U0EZ+aiI=; b=PrzDv+PO8Jqkr8w9iAZHblqYaVAR+qK6k+WRdqr7uLSg2MYSgmX1PmJC /sgUYjMEKwCAW4KZvxyGjJZYheyGFSyU4FEP8oh0GwU6iesrw0Uk6mZ/P uLIbyhbbnYfoxofiv/SD9KQ6DI7Geo+jFt9qnj4frOjW9My+WPe2mPKC3 E=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: 2hiLc/rv5YZvB7xMScsNK+RP/DATlm5u6nfbHqoWNzyv1NQyIIuaanwfVS39WtqpwOYZNQ8+2a RvpZzFe3OTjhWGav6qmSOnFL8xyZ7ScmeY6WWzMYVpkPhGTdeSLk+gk4lFPYrCRotosrCWGXSe 7pBW1G+btqkPQyeCg1XfZfMWD191C4rG1P4D0YVxNcrCL2AoKP54WH/GW7pXVkBSvJjejxXB0i oHhzFYY7X3ocHEc+VfgeJKzVtNt8vm7Qf24tNrFzZSZ7iOg4WgxbFr5nPykBOgvmf/T2ud2paL IqA= X-SBRS: 5.1 X-MesageID: 47384421 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:9LtKtq7leBdzp6fg6APXwDLXdLJyesId70hD6qkQc3FomwKj9/ xG/c5rsSMc7Qx6ZJhOo7+90cW7L080lqQFhLX5X43SPzUO0VHARO1fBOPZqAEIcBeOlNK1u5 0AT0B/YueAcGSTj6zBkXWF+wBL+qj5zEiq792usUuEVWtRGsZdB58SMHfhLqVxLjM2Y6YRJd 6nyedsgSGvQngTZtTTPAh+YwCSz+e77a4PeHQ9dmYa1DU= X-IronPort-AV: E=Sophos;i="5.83,314,1616472000"; d="scan'208";a="47384421" From: Anthony PERARD To: CC: Anthony PERARD , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini Subject: [XEN PATCH v6 21/31] build: set XEN_BUILD_EFI earlier Date: Thu, 1 Jul 2021 15:10:01 +0100 Message-ID: <20210701141011.785641-22-anthony.perard@citrix.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210701141011.785641-1-anthony.perard@citrix.com> References: <20210701141011.785641-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain We are going to need the variable XEN_BUILD_EFI earlier. This early check is using "try-run" to allow to have a temporary output file in case it is needed for $(CC) to build the *.c file. The "efi/check.o" file is still needed in "arch/x86/Makefile" so the check is currently duplicated. This patch imports the macro "try-run" from Linux v5.12. Signed-off-by: Anthony PERARD --- xen/arch/x86/Makefile | 2 +- xen/arch/x86/arch.mk | 5 +++++ xen/scripts/Kbuild.include | 17 +++++++++++++++++ 3 files changed, 23 insertions(+), 1 deletion(-) diff --git a/xen/arch/x86/Makefile b/xen/arch/x86/Makefile index bb446a1b928d..d3e38e4e9f02 100644 --- a/xen/arch/x86/Makefile +++ b/xen/arch/x86/Makefile @@ -126,7 +126,7 @@ $(TARGET): $(TARGET)-syms $(efi-y) boot/mkelf32 ifneq ($(efi-y),) # Check if the compiler supports the MS ABI. -export XEN_BUILD_EFI := $(shell $(CC) $(XEN_CFLAGS) -c efi/check.c -o efi/check.o 2>/dev/null && echo y) +XEN_BUILD_EFI := $(shell $(CC) $(XEN_CFLAGS) -c efi/check.c -o efi/check.o 2>/dev/null && echo y) CFLAGS-$(XEN_BUILD_EFI) += -DXEN_BUILD_EFI # Check if the linker supports PE. diff --git a/xen/arch/x86/arch.mk b/xen/arch/x86/arch.mk index 9f5fade39e91..5a4a1704636f 100644 --- a/xen/arch/x86/arch.mk +++ b/xen/arch/x86/arch.mk @@ -60,5 +60,10 @@ ifeq ($(CONFIG_UBSAN),y) $(call cc-option-add,CFLAGS_UBSAN,CC,-fno-sanitize=alignment) endif +ifneq ($(CONFIG_PV_SHIM_EXCLUSIVE),y) +# Check if the compiler supports the MS ABI. +export XEN_BUILD_EFI := $(call try-run,$(CC) $(CFLAGS) -c arch/x86/efi/check.c -o "$$TMPO",y) +endif + # Set up the assembler include path properly for older toolchains. CFLAGS += -Wa,-I$(BASEDIR)/include diff --git a/xen/scripts/Kbuild.include b/xen/scripts/Kbuild.include index 838c9440f35e..5fe13a7c5abd 100644 --- a/xen/scripts/Kbuild.include +++ b/xen/scripts/Kbuild.include @@ -57,6 +57,23 @@ define filechk fi endef +# output directory for tests below +TMPOUT = .tmp_$$$$ + +# try-run +# Usage: option = $(call try-run, $(CC)...-o "$$TMP",option-ok,otherwise) +# Exit code chooses option. "$$TMP" serves as a temporary file and is +# automatically cleaned up. +try-run = $(shell set -e; \ + TMP=$(TMPOUT)/tmp; \ + TMPO=$(TMPOUT)/tmp.o; \ + mkdir -p $(TMPOUT); \ + trap "rm -rf $(TMPOUT)" EXIT; \ + if ($(1)) >/dev/null 2>&1; \ + then echo "$(2)"; \ + else echo "$(3)"; \ + fi) + # as-insn: Check whether assembler supports an instruction. # Usage: cflags-y += $(call as-insn,CC FLAGS,"insn",option-yes,option-no) as-insn = $(if $(shell echo 'void _(void) { asm volatile ( $(2) ); }' \ -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Thu Jul 01 14:22:01 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 14:22:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148824.275159 (Exim 4.92) (envelope-from ) id 1lyxZp-0006Gf-3o; Thu, 01 Jul 2021 14:22:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148824.275159; Thu, 01 Jul 2021 14:22:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyxZo-0006F0-IP; Thu, 01 Jul 2021 14:22:00 +0000 Received: by outflank-mailman (input) for mailman id 148824; Thu, 01 Jul 2021 14:21:58 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyxR3-0005F9-NI for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 14:12:57 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 3a858c7a-da76-11eb-8328-12813bfff9fa; Thu, 01 Jul 2021 14:11:29 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3a858c7a-da76-11eb-8328-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1625148689; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=OrEgff/HihyncUiqJLBMZO5p+YLhIkvLwk8ijwp7Og0=; b=IUfo/cC9BJbSiM1KYJctmiuzcp9to3pjLOtjRa4ds9PpHv3vFqDyWefd IjctC1G7l8j6oAmARtzjKsdhKfm1V64W+ZW6SN70bhiZ7ryl6zndGM/If U16WeVEpgDuFxwXZqap56dQIclNMKjCb1W+0HqqBTEKaFuZpyuuV9XP5h 8=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: NZ/MaMEfgDUzcZbO6KcGdvFFBkHR6NU6p9DlxJ715VT6RLQFJVjuh+XWDqbgfYwIUafNmoXmMD s5GWIkHuy3tIdJLKyBUd38fMpUhl7cgGEMYmMn1ljii3q4QxU/+6/kllIcIZR9FVnHja/7ft2S XfcCt8A1gjJ8Nr70Y062zL0eqCSZwEGMUzGKj44Pw2bwN9tbGbB6R1QkAwNSNffdD5qSKV8yG1 +TwvxqSndDA8dZvxdN/pxcne3QiUmMutVWbk5vMssasw8CCES/aRV+71vb0L7eGqP7O0AgEOUj ODY= X-SBRS: 5.1 X-MesageID: 47755472 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:CZGT3q1O+8E7RG7SPjPV7gqjBIokLtp133Aq2lEZdPRUGvb3qy nIpoV86faUskdoZJhOo7C90cW7LU80sKQFhLX5Xo3SOzUO2lHYT72KhLGKq1aLdhEWtNQtsZ uIG5IOceEYZmIasS+V2maF+q4bsbu6zJw= X-IronPort-AV: E=Sophos;i="5.83,314,1616472000"; d="scan'208";a="47755472" From: Anthony PERARD To: CC: Anthony PERARD , Andrew Cooper , George Dunlap , "Ian Jackson" , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [XEN PATCH v6 19/31] build: rework .banner generation Date: Thu, 1 Jul 2021 15:09:59 +0100 Message-ID: <20210701141011.785641-20-anthony.perard@citrix.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210701141011.785641-1-anthony.perard@citrix.com> References: <20210701141011.785641-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Avoid depending on Makefile but still allow to rebuild the banner when $(XEN_FULLVERSION) changes. Also add a dependency on tools/xen.flf, even if not expected to change. Signed-off-by: Anthony PERARD --- xen/Makefile | 20 +++++++++++++------- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/xen/Makefile b/xen/Makefile index 7e3e4c42d77b..267ae77aef7a 100644 --- a/xen/Makefile +++ b/xen/Makefile @@ -399,13 +399,19 @@ delete-unfresh-files: rm -f include/xen/compile.h; \ fi -.banner: Makefile - @if which figlet >/dev/null 2>&1 ; then \ - echo " Xen $(XEN_FULLVERSION)" | figlet -f tools/xen.flf > $@.tmp; \ - else \ - echo " Xen $(XEN_FULLVERSION)" > $@.tmp; \ - fi - @mv -f $@.tmp $@ +quiet_cmd_banner = BANNER $@ +define cmd_banner + if which figlet >/dev/null 2>&1 ; then \ + echo " Xen $(XEN_FULLVERSION)" | figlet -f $< > $@.tmp; \ + else \ + echo " Xen $(XEN_FULLVERSION)" > $@.tmp; \ + fi; \ + mv -f $@.tmp $@ +endef + +.banner: tools/xen.flf FORCE + $(call if_changed,banner) +targets += .banner # compile.h contains dynamic build info. Rebuilt on every 'make' invocation. include/xen/compile.h: include/xen/compile.h.in .banner -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Thu Jul 01 14:30:44 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 14:30:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148863.275170 (Exim 4.92) (envelope-from ) id 1lyxiA-0002IQ-MA; Thu, 01 Jul 2021 14:30:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148863.275170; Thu, 01 Jul 2021 14:30:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyxiA-0002IJ-Hv; Thu, 01 Jul 2021 14:30:38 +0000 Received: by outflank-mailman (input) for mailman id 148863; Thu, 01 Jul 2021 14:30:38 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyxiA-0002ID-74 for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 14:30:38 +0000 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 8620c3ba-85d4-4967-a97b-25e717a56970; Thu, 01 Jul 2021 14:30:37 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8620c3ba-85d4-4967-a97b-25e717a56970 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1625149837; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=8P7vlfIkLcqeQmKRDzO/5KvCw9VoEUvvaKYjxrs4Lwg=; b=HqWMkZ4DwZIO3z2jfbbQCGH8zhWO9uBSQDWntAngR08PQpgD+pA2qrFI i/v/5RaomjdQcQ1e9BJpurJbAY75kiemE6S+ndYh+mvrcfPeZEsW33Gc9 ri+a3pk2ohFDQkIv3Zh71VKwKFrfPzvI14DbrJJGtIuRLUG75rWQQ6Q80 k=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: 0U1C1McnJVqImh+3s74LGBKcPf1DBgdVWaCmAN72OFr7ip3r/fvcZatKZRncr3nBw86BL6sK4Z MXEMr9upMFzYfh673TZttU3Rzq8Cx7WIbOcwBU5MlHu9RBWFws3F7hC4tlZBfSifwOKJBbwCz2 J6810PWChACoESqdR7fxf8PUvL5ZyQJZkTOWjCIhHfFKP2wdqu67XumFbzU3nIswprHq5sNxva 7GFqVGyC6ULkLUiD8g1iwFzKrOmSFw9ViPIuEn5+po7BchG13I11D8fgMAF9C4SinVdLhA0nJG Ils= X-SBRS: 5.1 X-MesageID: 47448780 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:ojxwZqP58v8aVsBcTjejsMiBIKoaSvp037BK7S1MoNJuEvBw9v re+sjzsCWftN9/Yh4dcLy7VpVoBEmsl6KdgrNhWotKPjOW21dARbsKheffKn/bakjDH4Zmvp uIGJIObOEYY2IasS77ijPIbOrJwrO8gd6VbTG19QYdceloAZsQnzuQEmygYzRLrJEtP+tFKH KbjPA33waISDAsQemQIGIKZOTHr82jruObXfZXbyRXkzVnlFmTmcTHLyQ= X-IronPort-AV: E=Sophos;i="5.83,314,1616472000"; d="scan'208";a="47448780" Date: Thu, 1 Jul 2021 15:30:33 +0100 From: Anthony PERARD To: Olaf Hering CC: , Juergen Gross , "Ian Jackson" , Wei Liu Subject: Re: [PATCH v20210701 03/40] xl: fix description of migrate --debug Message-ID: References: <20210701095635.15648-1-olaf@aepfle.de> <20210701095635.15648-4-olaf@aepfle.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20210701095635.15648-4-olaf@aepfle.de> On Thu, Jul 01, 2021 at 11:55:58AM +0200, Olaf Hering wrote: > xl migrate --debug used to track every pfn in every batch of pages. > But these times are gone. The code in xc_domain_save is the consumer > of this knob, but it considers it only for the remus and colo case. > > Adjust the help text to tell what --debug does today: Nothing. > > Signed-off-by: Olaf Hering > Reviewed-by: Juergen Gross > > v02: > - the option has no effect anymore Acked-by: Anthony PERARD Thanks, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Thu Jul 01 14:34:00 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 14:34:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148885.275181 (Exim 4.92) (envelope-from ) id 1lyxlQ-0003AF-5P; Thu, 01 Jul 2021 14:34:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148885.275181; Thu, 01 Jul 2021 14:34:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyxlQ-0003A8-2C; Thu, 01 Jul 2021 14:34:00 +0000 Received: by outflank-mailman (input) for mailman id 148885; Thu, 01 Jul 2021 14:33:59 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyxlP-00039z-6z for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 14:33:59 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 5e768744-da79-11eb-832e-12813bfff9fa; Thu, 01 Jul 2021 14:33:58 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5e768744-da79-11eb-832e-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1625150037; h=subject:to:cc:references:from:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=O+qBSKO2+RUDIgebvioIm+C3sLL6oFNRAelxqHCs84k=; b=BybZb352AEPxijSZ8XS9NKNBZM1BdfF1tYuYcb7KnoMPcupm7a+4pqG/ hOFKHXFCVNU0HwHXi/rM8bfOlhnq9lWntlwuM2KOkv2sfMqJYZ6qO7SFy az7wGcAXCx4SaHzGaoDiUup7xMVuaFBuhKrQCkP0EE8c5ZRejPwOtdIrn E=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: a82aOPRQx/nSrCKDlwoAPX+syTSqIQMruZz6N7vZvfjX53EuxnwUx5Y5U00pKK1V5aESPaCPqy LbfG/z/C1aJwhCNpDZprRt1VZZ0A/9s3neohdXPFIi41wi2irekK3ejEYd/uHei3m7/+0P7K86 lQxY7JbO+BP6PqKjxwNWzxqlKNRGdG40JdW+zWDXoNx3OPdJ2C8hI24+iVQPWDH7G/gEtaRp9I ye78RetwUPCClRYJEw1ZSPlcaUR5FqwKp7kSY5jRMyOb+FqM4cDckMKDXTIsPuWAPIb7x92Hta stc= X-SBRS: 5.1 X-MesageID: 47095733 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:RqCfVa/rb8CwgErhkKJuk+E6db1zdoMgy1knxilNoENuHfBwxv rDoB1E73LJYVYqOU3Jmbi7Sc29qADnhOFICO4qTMuftWjdyRaVxeRZg7cKrAeQYxEWmtQts5 uINpIOcuEYbmIK/voSgjPIaurIqePvmMvD5Za8vgJQpENRGsZdBm9Ce3am+yZNNWt77PQCZf +hD4Z81kGdkSN9VLXLOpBJZZmNm/T70LbdJTIWDR8u7weDyRuu9b7BChCdmjMTSSlGz7sO+X XM11WR3NTjj9iLjjvnk0PD5ZVfn9XsjvNFGcy3k8AQbhHhkByhaohNU6CL+Bo1vOaswlA3l8 SkmWZvA+1Dr1fqOk2lqxrk3AftlBw07WX59FOeiXz/5eTkWTMTEaN69MBkWyqcz3BlkMB30a pN0W7cnYFQFwn8kCP04MWNfw12l3CzvWEpnYco/j9iuLMlGftsRLEkjQRo+M9qJlO91GlnKp gvMCjk3ocSTbvABEqp51WGqbeXLwYO9hTveDlJhiXa6UkPoJjVp3FojfD3pU1wg67VfaM0rN gsAp4Y4I2mcfVmG56VJN1xDPdfWVa9DS4lDgqpUBza/fY8SgzwQtjMke4I2N0= X-IronPort-AV: E=Sophos;i="5.83,314,1616472000"; d="scan'208";a="47095733" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ORCvRhTxcMcbFhHVBzx5dBP6q90Dbidu+UgIrbQ95wTnvG88orMYgiQ/L5mMF4CFRghmMChaxzdMHqvGMtJHIX/N9yYHCX6RucQ3dM+p2bkjhG9AX7ilvBzdaHn7LwARAr17q2NVH7H21DILhBvy26ZXNc6fITt7s8oGkkjHfWrHX9jUB4SJTk/Sn3afhNaMJ9II+dmsaXhFH6cZ049fKYf+6E1pP5NsMaGzD29JaCDnzH4lHkN/5nlZfpTkwqrnF35EALVHAPKIoRY6IuL4+yMo1o6xNcckYdftJN+hVXzK4t6sRoH8efEhHibWY1SBVfwhRI1gM6otAbMCtCmgsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=O+qBSKO2+RUDIgebvioIm+C3sLL6oFNRAelxqHCs84k=; b=fcdthvYqjpJT5i/BpEpGoN2l0TMBWqO+Daw4x3+q7uKBkV5xPwHeCiC6pcupYtjMyDKA3dviV/Rv8LidOiPnfyZy+4aIWMisWKeMNQ6aLemVP2xOESSCd0/KmkQbPJZpllJLrCYRg4dtMHcUggp/E7TS3RJcnSgCHqdirCcgFEcQxPiyKce/n5uk+Tx0/mys1t25J22FBiDa70RjZjYkdzTiXth6gC21jlsCrLzLdUO3NEfN7zHFIdFtDrWPJ6HrU+BPMzaWGSOKHFtOYi9KPXVLY5o51Jjf+cLnBV0xknlifwyLmLB2HwnTuBkayNLmd1L6OEzr6Na/wECdeXmOqg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=O+qBSKO2+RUDIgebvioIm+C3sLL6oFNRAelxqHCs84k=; b=eDMaATME1a0urN0y5W1vG+FSPC/YctRhTMz7eJjU6Sat8enGcvw/SH+pOlwe1Gz3MM9YpayiIcTFZ2BHxFeOekD2jTQlhjBcCUtUI916Dimbuy+8Pq+NoQWgAMV26+IxnXRr1Rss4THhCj0Ou/Kxv7U1ehn8QEuNf4xXK9nqx8o= Subject: Re: [PATCH v20210701 03/40] xl: fix description of migrate --debug To: Olaf Hering , CC: Juergen Gross , Ian Jackson , Wei Liu , Anthony PERARD References: <20210701095635.15648-1-olaf@aepfle.de> <20210701095635.15648-4-olaf@aepfle.de> From: Andrew Cooper Message-ID: <038fa686-c7e8-4afc-e84d-216c3a3f6d5b@citrix.com> Date: Thu, 1 Jul 2021 15:33:47 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 In-Reply-To: <20210701095635.15648-4-olaf@aepfle.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-GB X-ClientProxiedBy: LO2P265CA0396.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:f::24) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 67879142-c152-47e9-6bb4-08d93c9d40c0 X-MS-TrafficTypeDiagnostic: BYAPR03MB3991: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0DdLtBlum8CrVPv+HqM8us89Vd3hFwjWFj4S1AIt88pfEy60Hntw0UpR4AzGwBJpqSD4CSotI6ChIhQx0LEY3LykKgR+J9AKT00Hy7xlRA7KZYIN/scuiKMgyKU2ho1CFhuJ1no8Cy9jYqflHRRyfbcY4mPhWu5XylM9ovXERvbyQVJgCT3oXT9aiHRx9C22DkRj8+lNz/B0NECThl08TPSwMyqK5vIOif3FZ+mjZeyLQOA4s/8IknR7/AEPrhoYuEaZBim36Ps4eDO3QB2bUhDMvdQPLdQiOQdllO/c4O39kU1kcpq8n3377KbbUZdSZypwUOUUDKhrI/y/KC+yPNgU1uhdDmKSnPCIxxezF0R9CNZCo/yqjmYed3iP8hdb2ew/yx88QiU+d5AYYa19sS64G0eqKrWXJY8/eJAd4vkvBA4AgCYkLB6ZFOuE2SSJqUbN8NA1LoWiL54RyXXbJn75Kv3akGscUoTDUdHh57Ql1FFunKCUfnnM2euEdQnqGwu9bhTgOZafIls8aER8bvpGHMYt/nTb7LIaz/t6TlNPJvXV6vpEvnT6JsIp9hTsM+SycH129PZltaf2lrKjVTOjE3tCoyEMsvI200fxLKgQ+HX7Y86SK0xSE639qybkNjP2XmMzF+4bliQyTkXDHvZ9asdD8ud0jA82QoHSaEFoZNLHneOpYiaf52faeqmhRpwj73+4dXIfaZtlSy0D8pY/G4UIc/SM/wbnjeB2AEo= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(39850400004)(136003)(396003)(376002)(346002)(2906002)(316002)(31696002)(54906003)(66476007)(5660300002)(6666004)(86362001)(4326008)(16576012)(4744005)(107886003)(26005)(38100700002)(6486002)(186003)(66556008)(16526019)(956004)(36756003)(8676002)(31686004)(2616005)(8936002)(66946007)(53546011)(478600001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bnlWc2lDUDJvb2NvNEViVWRzRWNwRXg4WEp4eDlrcEhMMDYzV3lmbUFrVzYw?= =?utf-8?B?UlV0alNOVTRIZldTY1ZwNW5qb0w3UnNIc1hQd1RWNXlPVlJKS2JyVTN4RENz?= =?utf-8?B?NURYZC9XYTFxYXM0S29lRG85eWtIaDkxS2VPS2llTTkxWHNZclpraUxnUis5?= =?utf-8?B?VmRhWUZ4MkRhQzhjS2Q2cXo2RWtIVEVsdzFBcWRxL001Y1lQVW5oamhtSkZx?= =?utf-8?B?N09XcjVrZXdObzUwcTRCbUI4U3hwYnZIbkZ4NHpHQk5NVExaTFdUMlFmOFhu?= =?utf-8?B?d0x4SlFtOFFURFRFN1B2Y1dxK1VqRTM3eEtrT0REZDZNSkp3MFpFZHF1ZnlU?= =?utf-8?B?MnRSVXRveDhoRkFna0NTN2RNRVVUMFFnd2tGRWVYVFc1OWFnNlJ6OEdYN0ls?= =?utf-8?B?ay8wUjQrekFrMnRXOVMvM1l2RlJ5dmt3N0d2K051QzB6Zm93dEZMaDM1eVZM?= =?utf-8?B?TEJxWDR0b1JhclF3bW9BVTBZNDBVYXlhRXNWR2Y4ZUVTRXB1TXdJZm1NeEk3?= =?utf-8?B?N0tlejhmekp0ei9KL3FSSXdrbXRkM1lrbVJOVzRQanM4TWVEaVdzNENaMzdk?= =?utf-8?B?c0ZVNGZpSVhWRktqZnFxcWdqcHJVM1kvaEowSjVaUkxYYVlzRk8zYThkbDRq?= =?utf-8?B?dnFJbTVQZERjWER5cWt4cUlvd1FEVlBQb0UwWjYva3o5MXlvQ3RrQ1U2OXpN?= =?utf-8?B?WC9jd2RkbXM3OE1NRXVsZ3NTZVUybUx0S3NqQW0vMk1ueFhPeVAyVEtwdUt0?= =?utf-8?B?bFpLcXJmdFBBb0tralNGT1hqTDVxSEpKeVIvNVRpMFpZZHRaNWo3UU9BOVBp?= =?utf-8?B?S1dINmMxdm0xczdUeGVtc2hWWTBLdmpSdlAyV05tb3E2UFVRZ3l1N29Dckp2?= =?utf-8?B?TFNjRVVUb1RvTHUvbWNHMEdhYllxbHN0TW13bWljUTAvQll0cC83Z0dyVHpU?= =?utf-8?B?bVFLTStrdEpSU1BmWkREMVk5Mm9WL0poSFdwMDNmL1FTb3pjRmt4blFFS0pa?= =?utf-8?B?NjE5eXlkTm15Z1NKbkVZdVQrSmJYRkhzeElwaTRCMVE1a3dOSnduWFFISVRB?= =?utf-8?B?NjBpb2Zyc3FzZWhXNytHNzRDZ2xvK1JySGhsYUd0THZUTW5MQXVwODROTktQ?= =?utf-8?B?bDFXVmhmSUs4NWdwcHl4a3plWVQ4U256TVliWWhaWEMwaW9oNkcvSjhtT2lB?= =?utf-8?B?QjNYS1ZRQ0JnbW84WWR5RW5CZkdYWG40cjJFRVhIRWpqSDdEQWdHU1Vtb2VK?= =?utf-8?B?UlVDbFUwL0tDZG0wb2Z3WW84ZVoyclRDclc4cENSbVRmVlJvWGxNKy8xaTI0?= =?utf-8?B?NnlpSGJnbDVLSXRWZVFpOEh2SHR5L3BmUkNXS0lzdzdGSE5iUHJidG1hcU5s?= =?utf-8?B?U0d5RiswVDVaUVQwc2NyMzh3YWtiLzJjRXNnQ1Jnb0NzZ0FFU3BoMEZnZzIw?= =?utf-8?B?K0hRaXJkcEFqakVRQ3F2OWpQVGpIQUNSOVIrQnBtMC94TzVvS0o4L2ZjYXoz?= =?utf-8?B?UWNDUTBvNU1GTEZ2cmxLdUZTbFdLUWFYbTkvRmRkZmRRZm8vOUhRdmZyZ0hR?= =?utf-8?B?MzlIbnJBa2RrMXB0cHliQnlRSDBtdnFNRGFGaGgzQUxEQVFPOXdya0Q1QUJz?= =?utf-8?B?clJrT0ZMbm1uSStkZ3dWLzRQcFIzVVNlWXFvZU0zRFJNazZWTVdEdGRHMzhu?= =?utf-8?B?WmtjaFE2UHNqQnNqMWVkVFpWSm11UXZxSGJRd3YvQ3E1Z2h3WS9oZDJMTW4v?= =?utf-8?Q?7DNzGpO0AgOZsWPRSsRywFS2y2sq/QUC+daWfhi?= X-MS-Exchange-CrossTenant-Network-Message-Id: 67879142-c152-47e9-6bb4-08d93c9d40c0 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jul 2021 14:33:54.5798 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ZDBjX5j/JH1QJABXqGWJCWKX1uowpdwWzAzSqeu+6uR3PMsVdOEAtHd3jF3oPKbEPVTUt0DdnJu3gphzBVvZHb+078M+SAnnxgr7Ih8NgkU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB3991 X-OriginatorOrg: citrix.com On 01/07/2021 10:55, Olaf Hering wrote: > xl migrate --debug used to track every pfn in every batch of pages. > But these times are gone. The code in xc_domain_save is the consumer > of this knob, but it considers it only for the remus and colo case. > > Adjust the help text to tell what --debug does today: Nothing. > > Signed-off-by: Olaf Hering > Reviewed-by: Juergen Gross > > v02: > - the option has no effect anymore Since when?  It was absolutely critical to debugging issues during the development of migration v2. ~Andrew From xen-devel-bounces@lists.xenproject.org Thu Jul 01 14:41:25 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 14:41:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148892.275192 (Exim 4.92) (envelope-from ) id 1lyxsU-0004dI-Uk; Thu, 01 Jul 2021 14:41:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148892.275192; Thu, 01 Jul 2021 14:41:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyxsU-0004dB-Rh; Thu, 01 Jul 2021 14:41:18 +0000 Received: by outflank-mailman (input) for mailman id 148892; Thu, 01 Jul 2021 14:41:17 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyxsT-0004d5-6h for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 14:41:17 +0000 Received: from mo4-p00-ob.smtp.rzone.de (unknown [85.215.255.21]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id fb43a995-f0da-4761-a821-cac8bb61fb1a; Thu, 01 Jul 2021 14:41:16 +0000 (UTC) Received: from sender by smtp.strato.de (RZmta 47.28.1 AUTH) with ESMTPSA id 30791cx61Ef97JZ (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Thu, 1 Jul 2021 16:41:09 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fb43a995-f0da-4761-a821-cac8bb61fb1a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1625150469; s=strato-dkim-0002; d=aepfle.de; h=References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Cc:Date: From:Subject:Sender; bh=5q+N2VBHAtQyFyml4WQuHRm2+lkqKSKOPkDkryAxlx8=; b=oXhof0CeDekuGnHNaHvW1SY2Rx8afQ8QXxwsK44yqadzuXh7Ua4g8bmAlu+89P8Fu5 t9LK++7IOBPa/K8wUlGmcTWNAI2rh9xITHdCcKNBhFTE1O8jGD2MhGSbkciUbSyKpKbo IBTbpr6Jf1i3O/1jQTVGM9qHGW2LnBXg87tUXy9VaTzQX3NcI//tz4VjG7HbAw/KqN5Y 5lT57MTeRzi5HYtzLYOHFP3Gdn3UawkP6jO6+ZlBeAaYj0/+RYaReQP+k4V4pS4/UCeq q0+KbirbjRAobQEJf23KJa7XngdvhDaOu6G69LBeG8tbo+BtVRAx6udw4i3Ygb2mpq7f cU7w== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QLpd5ylWvMDX3y/OuD5rXVisQsBBSIa03sY9BUY2ao0oygRsMfcqA6zjDLeeWXNg==" X-RZG-CLASS-ID: mo00 Date: Thu, 1 Jul 2021 16:40:55 +0200 From: Olaf Hering To: Andrew Cooper Cc: , Juergen Gross , Ian Jackson , Wei Liu , Anthony PERARD Subject: Re: [PATCH v20210701 03/40] xl: fix description of migrate --debug Message-ID: <20210701164055.6f373be1.olaf@aepfle.de> In-Reply-To: <038fa686-c7e8-4afc-e84d-216c3a3f6d5b@citrix.com> References: <20210701095635.15648-1-olaf@aepfle.de> <20210701095635.15648-4-olaf@aepfle.de> <038fa686-c7e8-4afc-e84d-216c3a3f6d5b@citrix.com> X-Mailer: Claws Mail 2021.05.27 (GTK+ 2.24.32; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/TdB8zB_riXzFLIKxwGc9yRx"; protocol="application/pgp-signature"; micalg=pgp-sha256 --Sig_/TdB8zB_riXzFLIKxwGc9yRx Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Am Thu, 1 Jul 2021 15:33:47 +0100 schrieb Andrew Cooper : > Since when?=C2=A0 It was absolutely critical to debugging issues during t= he > development of migration v2. Well, I can find out if needed. What could would it enable today? Last time I looked there was none. Olaf --Sig_/TdB8zB_riXzFLIKxwGc9yRx Content-Type: application/pgp-signature Content-Description: Digitale Signatur von OpenPGP -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEE97o7Um30LT3B+5b/86SN7mm1DoAFAmDd0/cACgkQ86SN7mm1 DoA0pQ//eZ+/5fW3H7knOOLBHA2FOr3+k/hbEzF8pu0KBV7v6SU0WKtxtAqrvtpL c/Yrlo3TSyjoo/svV1hqc3Ojn/kogClZW03tsUPw7rd4G7xoXoxCaFAV0NiiYlYy f9MdwDzMoIfP3NZGzapxorLX2BdsbpDOz1s1EMUJ4eB5NzM9fQfr7r83uVSTADn0 12d98uKMDQEzVzYnLkbehu2tyLsUaXtGTgcNLLolkhFDm8E2R2VVbXpLOHYGXFiy +2iS7+N2iTREMaHiDH22tj1VJ6L1O468fliQuQSwsvIek/HoleujJXHkksOFt8ed puvQrhD7qVhPZP8udj1Wd7dMWvtU4EmeLAq1MfwIG9L9QXIJ45yiAjhv1qo6dBpT /E6fSoiay/L+Gvoy8MJ3xQY/+XoecpRr/xXEwtR8acfyvMyZuqkXRGhiNhhmfudz hh8HsbSnpol5GRFJaB8P9F9i83t3NcJ21fV95Med5Y8GylXQy6fzJz6fdPRwybAt WKebKefFKn7FNUur0RWUDTPzZ7RTgIOeAR7+zviMpD40SKkzqifWjfW1ZCjfrqhP dRB6e6NV6eOPX0aeg5Z90H2Y9HIWkLDM4ISLFXqvwNeutPx80Ug+DA1a9FYRjy0e hc6LzTfWxNMs6XS10Fjzke+O0fvaCru0Fjhhf2bypqOMtEFX2Lk= =Fsp2 -----END PGP SIGNATURE----- --Sig_/TdB8zB_riXzFLIKxwGc9yRx-- From xen-devel-bounces@lists.xenproject.org Thu Jul 01 14:41:45 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 14:41:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148897.275203 (Exim 4.92) (envelope-from ) id 1lyxsv-00056h-8Y; Thu, 01 Jul 2021 14:41:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148897.275203; Thu, 01 Jul 2021 14:41:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyxsv-00056a-4J; Thu, 01 Jul 2021 14:41:45 +0000 Received: by outflank-mailman (input) for mailman id 148897; Thu, 01 Jul 2021 14:41:43 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyxst-00052g-6J for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 14:41:43 +0000 Received: from mo4-p01-ob.smtp.rzone.de (unknown [85.215.255.50]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 73148ac4-da7a-11eb-8330-12813bfff9fa; Thu, 01 Jul 2021 14:41:42 +0000 (UTC) Received: from sender by smtp.strato.de (RZmta 47.28.1 AUTH) with ESMTPSA id 30791cx61Efa7Ji (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Thu, 1 Jul 2021 16:41:36 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 73148ac4-da7a-11eb-8330-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1625150497; s=strato-dkim-0002; d=aepfle.de; h=References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Cc:Date: From:Subject:Sender; bh=JgvL2sC//ao7ppxnTpjo8vPlzd0G6gPifGziXQs2OzA=; b=XHUjnWf/aM4NltKDeHfnyPkt/qYhoW6PWtYJsajWBQ+QJ1eBo15M0UOBwjBGt9crLX T9zb8iBBNH47iQRN3PwesVfxiAWVJqPFpdjbGQi9NkVndMa6rA3yZtvskZ9HxVGmIYXx zFR6fzEDIYL/1YzXnUqRStZOXrFWh1SSgYQfdw6yQyie2jf1E26nMn70i3FYraGwE8hu gpUaD41yV9kqYVJbqt97tvPePxtZ5+019NihxFjE4lyhW+NfUNgGjcMpqonpAg0Z2rQI QVBUH/PwpZbn+g3DN0JtoWEo1Gx4shznntdziFdXnCD16W//4h7a4Ymw2S/L8iMAit4j vWOA== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QLpd5ylWvMDX3y/OuD5rXVisQsBBSIa03sY9BUY2ao0oygRsMfcqA6zjDLeeWXNg==" X-RZG-CLASS-ID: mo00 Date: Thu, 1 Jul 2021 16:41:35 +0200 From: Olaf Hering To: Andrew Cooper Cc: , Juergen Gross , Ian Jackson , Wei Liu , Anthony PERARD Subject: Re: [PATCH v20210701 03/40] xl: fix description of migrate --debug Message-ID: <20210701164135.5ba31381.olaf@aepfle.de> In-Reply-To: <20210701164055.6f373be1.olaf@aepfle.de> References: <20210701095635.15648-1-olaf@aepfle.de> <20210701095635.15648-4-olaf@aepfle.de> <038fa686-c7e8-4afc-e84d-216c3a3f6d5b@citrix.com> <20210701164055.6f373be1.olaf@aepfle.de> X-Mailer: Claws Mail 2021.05.27 (GTK+ 2.24.32; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/sLH2SbXlvagca7zYZblvAT2"; protocol="application/pgp-signature"; micalg=pgp-sha256 --Sig_/sLH2SbXlvagca7zYZblvAT2 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Am Thu, 1 Jul 2021 16:40:55 +0200 schrieb Olaf Hering : > could "code", sorry. Olaf --Sig_/sLH2SbXlvagca7zYZblvAT2 Content-Type: application/pgp-signature Content-Description: Digitale Signatur von OpenPGP -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEE97o7Um30LT3B+5b/86SN7mm1DoAFAmDd1B8ACgkQ86SN7mm1 DoDjGhAApUD5tFAYDpuaLWcvhrvLfaxl0Z6QGPz6A0FBpRntVONciHmApGynJUAN QJPZ7ZKqTWGBe6qMUmPe9RUyNhj512n592tlk9uc0MBzOgLH7zrBAXEWBbNAtzoS lf2elpLn+bWNP5YR2sYGeOk0NYw9+VRz8JjueTzH0Mhee3JLjm/fvaUeJUAXOMWS 9THptflu+j2waLZcXIH+f+HeB/vq6pN5s6eikPPaQpmia6B1JRWGtTz0VbbAA5KN TNEyXwOYau3PCWnm8Ntt0iuqqYvSvdBE9bl/TQwTWttzulVQQZqxgdLSmIDOhieI 7NNmGRj9oKRbE9+el6J2Km2V5UsfCOlnzz02nSTdKcKSQC9nyx1d1n4eC/yrlPYP MLrubbRAtDLu0WItg4NRQhfSY65/NzkGZmoK1RIA0g/D0AEG+T6N5O8OwffyPIMn GPeIYvJbD8kYcJlxy7/og5Dt1VTh0UDfKJr45ocAFaB4CoNpC94d5oBzxg71OUFD b3cCH2uI04d5Vd+E9XX5WMo8kO8apJA9jZTf7hvpTwd/e5G9WUnNwdHFDJXa2BOO uR9vY7KO0nAOLE9V1CI/R9AimvkIROKMwIxVUCreJYmxCmybrGOzxYS8MyCDWhox voEklUxfsue8MOKVaeBQGpu3D/wM6IIe1g6k05lgX76ofcuuGOM= =X+eI -----END PGP SIGNATURE----- --Sig_/sLH2SbXlvagca7zYZblvAT2-- From xen-devel-bounces@lists.xenproject.org Thu Jul 01 14:49:27 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 14:49:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148904.275214 (Exim 4.92) (envelope-from ) id 1lyy0J-00062t-0t; Thu, 01 Jul 2021 14:49:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148904.275214; Thu, 01 Jul 2021 14:49:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyy0I-00062m-Tt; Thu, 01 Jul 2021 14:49:22 +0000 Received: by outflank-mailman (input) for mailman id 148904; Thu, 01 Jul 2021 14:49:20 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyy0G-00062a-Oh for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 14:49:20 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 83d38364-da7b-11eb-8336-12813bfff9fa; Thu, 01 Jul 2021 14:49:19 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 83d38364-da7b-11eb-8336-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1625150959; h=subject:to:cc:references:from:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=ly2MHXC/HzUrKwuKhJfH6agfT2Fbq0RaeOLGcGtYp/4=; b=FIu2beEhp0ziIYAqE+SDrr/6eBH+qKf+mvPoKJ3/BSz9iEV8xWonIDf1 MXr9nZShk6Wl5pazZ1M4i0rIdat0blTBQhukapZDb6nVL1oF1ZXFiXH1p wZmm1139F+o0+96aii182/qo9knvy+zS0F+qja7h2UEbE2DoNE2etTZsq Q=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: YiQg9rQX8RuCbXSbGTf5LxfSIyqEKAWH5aNvcdpkltPWuKQqxyyHHAg3oYGQRe/8rUiKOUGab0 LL5PdnizmSL05cXlbAwL2xHrn3CzpkPnDNj6LmkL1BcTq0ydT9HqIn7/3ikleSBWvCuQ/V+sLW gN8zWfOUq4ZiPy06x1gTiwKXtoAgej/RLRJh7puTWwTcg/U9VXyXq2K9Pf64yloQNDFdCcuk2K O5m2Jc24bv/80GQ7YgvFX2H4HM2OuOrtWTplWqVz1lsRhNlvdwKZGsDpW10PrvsuLN3tLCbEsz zas= X-SBRS: 5.1 X-MesageID: 47097391 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:TWuzlKOVqTZRBsBcTjujsMiBIKoaSvp037BK7S1MoNJuEvBw9v re+MjzsCWftN9/Yh4dcLy7VpVoIkmskKKdg7NhXotKNTOO0AeVxelZhrcKqAeQeREWmNQ96U 9hGZIOdeEZDzJB/LrHCN/TKade/DGFmprY+9s31x1WPGZXgzkL1XYDNu6ceHcGIjVuNN4CO7 e3wNFInDakcWR/VLXAOpFUN9Kz3uEijfjdEGY7OyI= X-IronPort-AV: E=Sophos;i="5.83,314,1616472000"; d="scan'208";a="47097391" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SnlMfewsKxTRXm+Z2aKZMZ2yFqtnlBBElwrZY9FlSzqRvps7gvJ7hpPnc0TgY1tS4Z0HOSiJn1TrqigFLSpp6rrbQOqVAHbLZspuq01PTolVw7KiH4J2FHi/O2JPk1bcs9JOfS078s8ILfjvVdBeYQbr2d38tUQ6ZoMk/fX/atcr1aLtY5Ok3+EMIIM+GvNx4N6T8wIDnMGEVtH9py8KFT6RWNFyQdP1j3n34NlVRMeMhmqhyofHBBqNEh/Z1duC+eVwOtfwneoap3EK0xWUWl32zsfsVW3M09C90xSFRPqY+IlXTBfOA6XCQit0Q4iybgfl+lwGLQmhBqwNs+lj5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ly2MHXC/HzUrKwuKhJfH6agfT2Fbq0RaeOLGcGtYp/4=; b=AVDHm/kR0zUWXM4btI1ILVvIuIfgWR7zVK9/9qx5T1Q5aQlBPHLl8D8Pdm5MzAp+ludy1drpIXBPAKzIubVsgS3qU12HGxJinPC2JGrO83mDpf5GWNaIXQHopemipkqbHqG4xMJNcuzd+FcRvoGAgH0Krd5PkURLlDyrLKxKIRu/iMxXj2Bj0XflEg/C+2+XNTYs2hknrPTuXMPVQ026AWc48fonoy+mCExEbOsSBkxJ9+fR6eGPu0FvCbo3MdgrhKgK3s9jfufB2pnkuTA2E19ACOnMpoboL7CyPF1TsTh/hPOO0+zFskhGUeSdPvdQ1w8hTNEmJphY0BMBiFAJzw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ly2MHXC/HzUrKwuKhJfH6agfT2Fbq0RaeOLGcGtYp/4=; b=mKRbH+kimVgfbiAKVxNBfupg/aeaJsRJ5/oc5IUozv/gLDJDYJlbLQV8TtpmSBzB3pYLEvLH/jWDjl+PQXaT1g/WBlPeg5PviMXEe8AVj69FTSmhhaqEOHT8I9Fw3EslOMmHphqPndRNwf/Bgcs4odzrvgZPAfDUzHuqZta9KGE= Subject: Re: [PATCH v20210701 03/40] xl: fix description of migrate --debug To: Olaf Hering CC: , Juergen Gross , "Ian Jackson" , Wei Liu , Anthony PERARD References: <20210701095635.15648-1-olaf@aepfle.de> <20210701095635.15648-4-olaf@aepfle.de> <038fa686-c7e8-4afc-e84d-216c3a3f6d5b@citrix.com> <20210701164055.6f373be1.olaf@aepfle.de> <20210701164135.5ba31381.olaf@aepfle.de> From: Andrew Cooper Message-ID: Date: Thu, 1 Jul 2021 15:49:08 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 In-Reply-To: <20210701164135.5ba31381.olaf@aepfle.de> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Content-Language: en-GB X-ClientProxiedBy: LO4P123CA0068.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:153::19) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d5495471-4c39-44ca-714a-08d93c9f65e5 X-MS-TrafficTypeDiagnostic: BYAPR03MB3992: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6790; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VgNpODmaIdhW04XW27kBP7F7RHlGuXu5pwQI9jK8tBp0rXD4EvonsuOBrDI+ysnOyAgyyXrEHJ/HKdEShxD/6lrlpGhWrwGdlcFS3VdHWg4ZB9NVeiaLL+5o71Rc/TuB2gJ3MgPcx3zi1uj6sIEiBY+v6LN0N0vPpZ0647u3BW8IHejK4EsYQUACIj4w/J2N9ukno3u5mYc+RSL7huGozhFx/hef0ze1y0LVHqZdMMVb4fEBowPMSU8dLUhCum0zszSIz/KAeM/+/vXDW6GY+57r2zDr4DoefDnJwIhDkmVpAtP69d0HvB/maSzVa8ogZi7YNJxMZN0FKKhI4o5gdR2QzcDsoonmGakYL9rSRNPDK5X68K3+f4CafW4GsSSldCP9cQLierhjn6yw+SVqPWfOn4MO+x0oa4f8qtKm90uaBrm+Lwt82a+NFdX+QVYZH+P4w5dCaSGZ3mwhnYajqzUzNv9CJfRs/g7PVUbnEOm2VCS6it5Gy2PSRedd4Z9l0nwFz52VRHN4lfQSe0IN76NxR2ABYDwR5p3cHmZn1snv86GrJRbcfY6hW5NnuonhkjOIyPg8KJKz+1/xMcDZAWeWRBVL9+xM1nP+6z9RW0Ha6IZUAAigix72NnJHUfdQz1Q8sMHkLcjRvLqRPrreIYMSxNGc72eVc4cXwTFbc7RrfJ8IFMuQfo4P9tJ7hXzX9V+IzJjCEQVksxZAJI3/eLLQhIYGnKQU0udgc19K6Pf/GejPHk84UyuPx9j7PHeA X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(346002)(39850400004)(396003)(136003)(376002)(5660300002)(107886003)(4326008)(16526019)(86362001)(54906003)(8676002)(316002)(31686004)(6916009)(38100700002)(6666004)(31696002)(186003)(6486002)(53546011)(36756003)(956004)(2616005)(478600001)(66556008)(8936002)(66946007)(2906002)(16576012)(4744005)(26005)(66476007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?Windows-1252?Q?lZpeWYWThORshXljfvQQMCg5iSge6fIh1CgQSSeTurnipc8duPuATTVz?= =?Windows-1252?Q?KED8iG25w2rrjwzjl52bHQHA7OlxrclYkAFMs4c4pBixPAvj8KUg7JgG?= =?Windows-1252?Q?wzKri5e5W55Z8Zk1WLNB82vODGE7rUIHrS2egfdM32bjNwTovSof9R7b?= =?Windows-1252?Q?UV4/RcdCzIp4+Y+iU7ntopae1Tx++hL4qwatHPJqckSFPvHdPfP6ZGHi?= =?Windows-1252?Q?bUb3pXrZybxNzkx7arDH1KpitIGA5b5zZFxZAVL7raQi+Tq5m1zpNm81?= =?Windows-1252?Q?YTMfqXkhMSYK8MGY54136ObzEqskN/Who011TP95K+JveE+9DQHjDdmJ?= =?Windows-1252?Q?9hlUJfx8otzyp90UuOY0l9rFZl1BybTh4jWMsIsjvBIg/Cj+eayUkgSa?= =?Windows-1252?Q?lrU0UhIbFtbzqha4uqlWBHtJEisrRyxi3F2KIc773aIL1w77oEmN6VFQ?= =?Windows-1252?Q?br1d6do5wv4vQTC/ZBt9b2+jK/ESHWSaIGDz5T8UdJwvYixAXJgLwk/e?= =?Windows-1252?Q?Xs0omwq5CykksPNsjgn84UeThEDbGFWlIhuJ/fHl5vqxmIKnXlsWO1CJ?= =?Windows-1252?Q?jkJ018vZMkcyb6e/nRvU1ZiwB6dG1LiyHJGha6DJe9gRsRkDidGAp8Cw?= =?Windows-1252?Q?PHwIsG+CHSCJ7gg0uOA29cmJXzGhO5gyGCodkBlDSeq/N+a/nNRBdjuY?= =?Windows-1252?Q?H6i1SWs2qI7vXxloC7AL7EJf+1Mo4ZoIIhQPsY7J20hsN8zp8K1Z9KQ0?= =?Windows-1252?Q?cXQExptj0K8CSUFcDNm5aMp3UZT/ml0nxLqmY5RtysRRQB8p0025xoES?= =?Windows-1252?Q?rptCS+rfTo7X6HQ+LyeioAn4VHqCH34hdKqYF4mzJIRoKNfknMv58GcV?= =?Windows-1252?Q?LDNHS1f17IB1ukKSy7t9t/hwZINkHqmIYKnZENp06rqSqrPUdTtHLw2s?= =?Windows-1252?Q?92Hftn4P7upHuoiTPlUsBSzWHPt2pvWuu3XiEIMIwHiuDYfaNPFyaOK9?= =?Windows-1252?Q?whTxsPrZuIsZ8FwqAXDXgQoWogXpfGNEOMY9kgmumw9UgcrmYlWSU1XA?= =?Windows-1252?Q?I79IBHWfR0No3rui1A67TexYHoncyLmN3hFA/9AmamOJmrnHd/88BlTn?= =?Windows-1252?Q?N4rCzfzHTEgF+FNJS7x3ZKEFmPLcPsTXls//DB2F/iEvgPSJ/XRZ7fiG?= =?Windows-1252?Q?g5fChOPe6JqLyyfhxvPscowi4QlC9Hred16s/Wf0FuhJv9VRZ+L7N7M8?= =?Windows-1252?Q?zPipGk4NXGPmaEYjGz3sYJtsIoTvkrmcLh8t3rIyguu/9aO17QXXHqnI?= =?Windows-1252?Q?pSKMIR0t1TMt05rsf7JMhkbF3bNiVucfodGY5ALijerJaCxQcwWB1FQ0?= =?Windows-1252?Q?kSUkhhJR0bGKqqf8lvnyB+qMK0FEc10orrbmerJHyWWcFSUMiEieQAhM?= X-MS-Exchange-CrossTenant-Network-Message-Id: d5495471-4c39-44ca-714a-08d93c9f65e5 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jul 2021 14:49:15.7917 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WCkSwxn7XiR5CJRDpGbHnI03T56L4dk/E71XKb/AM1gbVuZVlTm+JW+qVq/Nx4iydU6UVMaTHUkqCRmPn7PKREX38OV89SFdm3rBb9braM0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB3992 X-OriginatorOrg: citrix.com On 01/07/2021 15:41, Olaf Hering wrote: > Am Thu, 1 Jul 2021 16:40:55 +0200 > schrieb Olaf Hering : > >> could > "code", sorry. c/s 7449fb36c6c81d2ba10a40b59e61a9f420cd8450 was buggy and inverted the condition while making the code transformation. --debug makes no sense at all in a checkpointed stream. ~Andrew From xen-devel-bounces@lists.xenproject.org Thu Jul 01 15:00:28 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 15:00:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148913.275225 (Exim 4.92) (envelope-from ) id 1lyyAu-0008MI-5b; Thu, 01 Jul 2021 15:00:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148913.275225; Thu, 01 Jul 2021 15:00:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyyAu-0008MB-2Y; Thu, 01 Jul 2021 15:00:20 +0000 Received: by outflank-mailman (input) for mailman id 148913; Thu, 01 Jul 2021 15:00:19 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyyAt-0008M5-1l for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 15:00:19 +0000 Received: from mo4-p01-ob.smtp.rzone.de (unknown [81.169.146.164]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 68fc91ca-6281-4814-93ea-fcf68e3bd5db; Thu, 01 Jul 2021 15:00:18 +0000 (UTC) Received: from sender by smtp.strato.de (RZmta 47.28.1 AUTH) with ESMTPSA id 30791cx61F0G7NZ (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Thu, 1 Jul 2021 17:00:16 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 68fc91ca-6281-4814-93ea-fcf68e3bd5db DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1625151616; s=strato-dkim-0002; d=aepfle.de; h=References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Cc:Date: From:Subject:Sender; bh=1FRUTA3lx1xmpOp1mKwuBsgpUX+KYHxPk64HZkc7MTI=; b=g/z5yD0aJ3oSy0UuR/Wra5UCgZdzo9XYOnqfa10HvSojgcWl5dxTVtKSK3CUFPloeJ upFEiKVN7QwYHNGzv9bi7BofWM6I1o9blVSLWEB1XbMTW5wkiHxRa1JxwQx7Blymj7qx SO1zVjPQ0bBoO/BO6SAL+zTabDIH9fZdp6FJpzh9DDUARMzb0vwHkHUvrV4w5qi1oshC f9B5+/nCk3NRDpzm5rE8gg7toFMnrMZ72pVpqZNljhfT51yqW20SA+pJuDZnN13GXyMd HMTwmSoiTV3FpHRo+56eWLfZ60oPm5OqSpjVnQFXzP41ckIC0JekOYbOhPOdyMe/v1L7 UgWw== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QLpd5ylWvMDX3y/OuD5rXVisQsBBSIa03sY9BUY2ao0oygRsMfcqA6zjDLeeWXNg==" X-RZG-CLASS-ID: mo00 Date: Thu, 1 Jul 2021 17:00:09 +0200 From: Olaf Hering To: Andrew Cooper Cc: Subject: Re: XEN_SYSCTL_cpu_policy_hvm_default truncates leaf count Message-ID: <20210701170009.5a8be33f.olaf@aepfle.de> In-Reply-To: <20e828c9-e7dc-4401-9307-a6d72eb618d8@citrix.com> References: <20210701125623.593fe3ae.olaf@aepfle.de> <20e828c9-e7dc-4401-9307-a6d72eb618d8@citrix.com> X-Mailer: Claws Mail 2021.05.27 (GTK+ 2.24.32; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/_MbKKWyEwa/888gyYOByhSd"; protocol="application/pgp-signature"; micalg=pgp-sha256 --Sig_/_MbKKWyEwa/888gyYOByhSd Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Am Thu, 1 Jul 2021 12:19:24 +0100 schrieb Andrew Cooper : > Where is the 51 leaves coming in? I suspect the bug is this line, and the magic "0x1c" value: p->extd.max_leaf =3D min(p->extd.max_leaf, 0x1cu); In my testing basic remains at 13, while extd is truncated from 0x80000008 = to 28. I think it should be truncated to CPUID_GUEST_NR_EXTD_INTEL? Olaf --Sig_/_MbKKWyEwa/888gyYOByhSd Content-Type: application/pgp-signature Content-Description: Digitale Signatur von OpenPGP -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEE97o7Um30LT3B+5b/86SN7mm1DoAFAmDd2HkACgkQ86SN7mm1 DoAt5RAAi7YY8rPut4dXconVpm/h1wjL1WGHXNCYK5cNxb7vUjo5nzcWyvUWYGyW f50OsYYJTtLUt7pjuvymmPNPMomOAnYu6E3lYJ5zNu0yGW4FmB8ekh5IohMeFEdi RDT725qmdE4vofiR+Apnk6OQ59t0a4u2g2FEPnomsk0Vmj0p9fz3wrbbTNBWPPr+ N61Irs6OtspnBZ/I+qwL5jSCBhE9JvxB+Ni52O0HwTU015zOJQAlqkDpl+bVMrkl ZZgEmbTs5kKZ/0JvqRm+TMNK0fCHm/f6Olt5lNu4wyDaZEmzjDBgOEGO1WlcASXf hCzv0WSL5opHRc8GwdHuOipiVR4s2L4w1TCo7+J16+g+96Ctkx10vTKKUjat+xxj PfZi/+MMeqcKcAmQOoMbcloXBYssW+dDNf9pc3DYxLpMtThC8cn9YX//nEVyLeeg yHQXxg1usZQLqrcx7Jyj3w6oMsrRPG1jE4vkUtfRBXJ4WGLG4+ObHQw8seyA6KIU J3oJY1fV0ZAR1kfbnw4w/CreiyKZ86TpBMNx5r2JZPNX9r0xusG3WCrwZneOcnHT nUoNx8D4+0gnowP8JLSWgAdvl5jrZ/Sd8opSE9muh+6pI0eIsjNFYTJJpUic3sLM iHkuawfChvXN54vWpEAhnQYACTxgEWPuMLdK2MQJP9aVyDKsjqE= =Zc2q -----END PGP SIGNATURE----- --Sig_/_MbKKWyEwa/888gyYOByhSd-- From xen-devel-bounces@lists.xenproject.org Thu Jul 01 15:08:49 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 15:08:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148918.275235 (Exim 4.92) (envelope-from ) id 1lyyIy-0000jk-0F; Thu, 01 Jul 2021 15:08:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148918.275235; Thu, 01 Jul 2021 15:08:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyyIx-0000jd-Tb; Thu, 01 Jul 2021 15:08:39 +0000 Received: by outflank-mailman (input) for mailman id 148918; Thu, 01 Jul 2021 15:08:38 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyyIw-0000jX-7D for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 15:08:38 +0000 Received: from mo4-p01-ob.smtp.rzone.de (unknown [85.215.255.52]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 35a43b2c-da7e-11eb-8338-12813bfff9fa; Thu, 01 Jul 2021 15:08:37 +0000 (UTC) Received: from sender by smtp.strato.de (RZmta 47.28.1 AUTH) with ESMTPSA id 30791cx61F8U7Pv (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Thu, 1 Jul 2021 17:08:30 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 35a43b2c-da7e-11eb-8338-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1625152111; s=strato-dkim-0002; d=aepfle.de; h=References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Cc:Date: From:Subject:Sender; bh=190ANC80fjmodXC6Is3P8V2pQJsWM0E1YXYCwyxcwEY=; b=ZzJGVDtZmXTZ3Ofr3cVbT+YGqtdrDav4z2D6FEYR322AOlY9C8hdZIGlI56RNmzUak oaqfcndKl9O3lfchPsQgecXprNAkGovqMV9nKK3bmdyrjgO87HPXvctUammknrRRSrPp bSIuaqeMaXNaIfOptH1lzws6g/2GP6W8SLzbee1HCksWIHvrud0uAHb0e3j7Fz7Gi0oP y3UV5JOowwXBIdhDwmIjSIgpxmPuXVRFq9j5gt+NhZPn2riIpaDcYEtrOFySU5JrBHZI O5mzAbzeCH1gfwvNsvX5vHYcHAD/9jmIgn7ee0XNin2ptzi8+SY9zRrMaMSmt5j7Yhz3 PBAQ== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QLpd5ylWvMDX3y/OuD5rXVisQsBBSIa03sY9BUY2ao0oygRsMfcqA6zjDLeeWXNg==" X-RZG-CLASS-ID: mo00 Date: Thu, 1 Jul 2021 17:08:21 +0200 From: Olaf Hering To: Andrew Cooper Cc: , Juergen Gross , "Ian Jackson" , Wei Liu , Anthony PERARD Subject: Re: [PATCH v20210701 03/40] xl: fix description of migrate --debug Message-ID: <20210701170821.1f6cdd80.olaf@aepfle.de> In-Reply-To: References: <20210701095635.15648-1-olaf@aepfle.de> <20210701095635.15648-4-olaf@aepfle.de> <038fa686-c7e8-4afc-e84d-216c3a3f6d5b@citrix.com> <20210701164055.6f373be1.olaf@aepfle.de> <20210701164135.5ba31381.olaf@aepfle.de> X-Mailer: Claws Mail 2021.05.27 (GTK+ 2.24.32; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/XR_bpdG+7Xi0.jilAwYy4hu"; protocol="application/pgp-signature"; micalg=pgp-sha256 --Sig_/XR_bpdG+7Xi0.jilAwYy4hu Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Am Thu, 1 Jul 2021 15:49:08 +0100 schrieb Andrew Cooper : > --debug makes no sense at all in a checkpointed stream. This should probably have become "ctx->save.checkpointed =3D=3D MIG_STREAM_= NONE". But this still leaves the question what value this code branch has when ver= ify_frames does not, and most likely can not, work. I think fixing it requires to expose details like which pages are grant pag= es. Olaf --Sig_/XR_bpdG+7Xi0.jilAwYy4hu Content-Type: application/pgp-signature Content-Description: Digitale Signatur von OpenPGP -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEE97o7Um30LT3B+5b/86SN7mm1DoAFAmDd2mUACgkQ86SN7mm1 DoABWw//VFy/dW3EykCZhfeTJWq51gBWbxz8QeOA1yyeg49Tyskjcr7wPpnWrGv3 whafIYj9nGBlfkdbhWerd4Zv645kYvXteGyPMlQ2MilgtJ2qwYyzuuMXRK50sAjc sbiAxc56RGc0IgD8cczZIzw/H+6qQ1UQMY2zJcFsbOkplaYTcfbxAgHZuU5Q79lH s48A8uTf17EVkaU4JNQ92MTzaQ7VeAIZARDWkUol0a1pbCADIw0iTwheATWEodQ3 Ch09e5NHI7wUmb4CMvyaVBeLFKNOjWGZyUszdgscql6YzVT2lc3DeTev2pgqkcAi 1NkUIdi15hB/E/NUcgdCLQhl07JJ3vmCgQRJS09oB4X2aC5Gr/1rwKOuWxOyzGZ4 rtqrRP48dh6xtU3U0+gX+GIGXnK1sEPtGSsVMfSUj51I1jIhp92x1nyeWLJ2m1hQ 5dV6r1fpog080Hg3CJhOeJ6ruqBBF2s4C18gjgVTnPIxB3CiZPegm0Q9piYmGEu9 mfKwd4jo788Vp61Xv5+9cUnXPsf9GV2v/gCURUV75P1DuBJj5jJNlyyWKbw/md8A 1WeEFWZry5p4wuQ+PRp8egsdZZm0n+pGnSvEmDoP0iZIBHj3mo+cyrA34kqzY3t8 /ecZ2MVhLvH5QqgPZcngFi3tkPEIiI7K19QRpb01fi3F1ip9MwQ= =1izF -----END PGP SIGNATURE----- --Sig_/XR_bpdG+7Xi0.jilAwYy4hu-- From xen-devel-bounces@lists.xenproject.org Thu Jul 01 15:13:33 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 15:13:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148923.275246 (Exim 4.92) (envelope-from ) id 1lyyNf-0002BQ-Jq; Thu, 01 Jul 2021 15:13:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148923.275246; Thu, 01 Jul 2021 15:13:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyyNf-0002BJ-GQ; Thu, 01 Jul 2021 15:13:31 +0000 Received: by outflank-mailman (input) for mailman id 148923; Thu, 01 Jul 2021 15:13:29 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyyNd-0002BD-C8 for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 15:13:29 +0000 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 87d385b9-34e5-4e9f-ba2a-d1d4dbe27994; Thu, 01 Jul 2021 15:13:28 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 87d385b9-34e5-4e9f-ba2a-d1d4dbe27994 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1625152408; h=to:cc:references:from:subject:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=ydcrTrLAzfXe3aNjGfjl5WB8cgTZLWAMYtc9G5cGdTo=; b=gnzr3f7e72Qu/Chbm41/FVdUEqzS7KiGHxlHRLuDKoR30x8D1ixHszNr nO9pukMuDJ2OzN+waRzXZzrs5p/ML9b8T4YNsZW+rAfZ7i3CjbZHxsKPi kO6YvxNsW7dYMyCNC4duY8Q56wjqHGpkIIK78Dh4PVIld0mMOdFF0jLU8 8=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: 6zI9ZKMYwdDrFHIvYFY2ic19yUSQSrDwKs6wgxS/4c0ougVrejlwwcN7Nye4PNbrguV7dWMQ0U OrNEfgnX77O03+MpTn13/xladx/CiSN0ut64Q01DrlKzPRtcmNDDzpPE40vibCGN1AsFSMCT1W kVlKCBas7kebf7yirIBh7ERku9+XYdLz/ub55Tc65DrTqSBh2+T+gueSbhyIyQcBrhl3ItPf9p Zhrhjw87tnCmkcP+DQm8AwekuWQwf352s5wqfhIXqWo94oIKiNe9ITPGy9YB+AXkWau5JSNogH fr0= X-SBRS: 5.1 X-MesageID: 47391768 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:viFdeK/7gbOtc9MSIk1uk+AuI+orL9Y04lQ7vn2ZKSY5TiVXra CTdZUgpHnJYVMqMk3I9uruBEDtex3hHNtOkOss1NSZLW7bUQmTXeJfBOLZqlWNJ8S9zJ856U 4JScND4bbLfDxHZKjBgTVRE7wbsaa6GKLDv5ah85+6JzsaGp2J7G1Ce3am+lUdfng+OXKgfq Dsm/auoVCbCAwqR/X+PFYpdc7ZqebGkZr3CCR2eyLOuGG1/EiVAKeRKWnj4isj X-IronPort-AV: E=Sophos;i="5.83,314,1616472000"; d="scan'208";a="47391768" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OxycDaqTSqXA31CRNt4Bg7MVYYSWtPTqRW30unpo0noBzIBEv9HjrZ4CTTmurEAUh0jowPXDYutmyeXGscOTflyMGdbX/AWgGDjTlKYTlF6VrQlvyzWXIqgiOaKWMWsfiXhEEbqTY07/vnYWWoJP+6W9U0w7UKzT/5vbPk71U7bd44spO1FuPuzIjMhcy1kyvMn2xsA2IVZdgUgHSh2Adx1vl90tuuSN4ILLslEJt67xixqXqpLsrpm6X5BCn7tzuiJzZsen/Ru+D1XLpYGFAWE9GGRG2QCWp+pqxKr4l+S2ow8vWFNk1yAcEFjlqeCN+xdeUki1OfWlTD6XOeDF+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OMFB/iP2HOsEBbJCx9O3lVcQ2RR3FXbB/e+5SkWgTGQ=; b=g4Sk1FHeSiA2UfQt0wmG8VUm92Y4VhYW2P+/5Mf0WqsK8TfipaZhpgMWUeC2hLeKqIN1jbd+/DSErdzULT0dgvJBpXBaH57VtitNyqpPUaaGlF0mFjIkXwNh0mAA3yPT3lYaDJ8nyPC//hqow4kO/Q/PGZtTT1EzvjPn+McxyqyCdnPqa1alFDDOMbYvs4uzxhkvBjAyhoYuNNddDG9LtnM1Hml7LypI4vppzovEYOL3BkoPOvXaWW9lJa9PtjfiYq9NcHK06qgIKLexNcR5eed2xE3BvPMepqqE4i58TeuyHT98DpL8YrD5iha8Zzy1J4LlpNvikTmzOLtvHvp9bA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OMFB/iP2HOsEBbJCx9O3lVcQ2RR3FXbB/e+5SkWgTGQ=; b=BJRc4md1llc/1xYAbTE3YwR69FMBQUNikqKpmJyMTjdoYWcyDSa4eCbfWmNOMtVpZPGYkFbRn+owZabppogEkXsi/NylTqFvl5La8FIJ+xG13Rnh2vOoNUUcvvFBR8vJVo6iBwdpnsroDjLuaa0Gv97cmRjCEEL1s4gB/ya6Tf0= To: Olaf Hering CC: References: <20210701125623.593fe3ae.olaf@aepfle.de> <20e828c9-e7dc-4401-9307-a6d72eb618d8@citrix.com> <20210701170009.5a8be33f.olaf@aepfle.de> From: Andrew Cooper Subject: Re: XEN_SYSCTL_cpu_policy_hvm_default truncates leaf count Message-ID: <48cfe27b-70fe-36aa-833a-7d78e205528c@citrix.com> Date: Thu, 1 Jul 2021 16:13:21 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 In-Reply-To: <20210701170009.5a8be33f.olaf@aepfle.de> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Content-Language: en-GB X-ClientProxiedBy: LNXP265CA0095.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:76::35) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a838265e-6ee5-461c-9fbe-08d93ca2c63d X-MS-TrafficTypeDiagnostic: BY5PR03MB4968: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MjFIq2unBIf3KpVRwV/z4e1Yawwb0/n4M8VTSgM8TODPr8Ktn8B6yI6QeoZWAHEN41lYbPXXPSIde/4VdNd5aqm7LkxnVTxtgY7XFj4Xw3Re10KMAEgRvmTs4B6WexrFwqb0kootZLy9FaX7dHF+LYIsoc4knEhDrweld2kYxv1CylGgZHNJzpVV/ZMHT8v9diVBR/dcL8pcKfE2QDBjy1x9GW6RW2vWurVbxQ4dMH8ltkQD2qY4KeB2ZGOBpr6E6jKVoriTcDVa8PWYiEB5/S/PxtiePyMNe+pvnTheML9VoEvIdE8tny5akQ8Go4iWXW2biRJHmI48UhDhYJqaAr9H6ZqXfpfAktmX/YyhTjUPFKe95RhFY2oTNoIjkbwcEjek74CYYgI4bnWJwStLiy9nQQxE7Ag6W/JeBg5Eq0/qJpcE030u/Ac+7h/VyZyNJ5V8bzoS6qFfsMc//X7sJaxqtbfewFkmdBYkHudN6Imc5RmWZPsWQJVN41BiIubE9zRmqFAgXzQ0oRPEnpWnydLlM4+4iYKVGUrmW/TcXpf7qp1s+8zk4n+YOrB/qvePFywKH3cJ+B3x76YV9lxmz3R0DyCBP8N+qoYJJSIO26trzRNlVIi0n04UVMny5qLEa8zL77U6xDq1OV/iKcC43gYRU59SEfMUDKwQ2s9XvcpreH9Iw7WDmqiZIMfF7Xn17FJJFtF4PVnI5Y+Gg9PAN466TQZ7GqDlLeYSEkQiCWxS78knw673+Wx9kSj4Ri4T X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(39860400002)(136003)(376002)(346002)(396003)(66946007)(31696002)(6666004)(6486002)(31686004)(4326008)(186003)(16526019)(86362001)(38100700002)(26005)(36756003)(8936002)(2616005)(16576012)(2906002)(53546011)(4744005)(316002)(8676002)(956004)(478600001)(6916009)(5660300002)(66476007)(66556008)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?Windows-1252?Q?xf0GqOsqzCzKwcDaIH42zAuDY1moxoh/L+uD0HQhqDfwAbT5yI/S8Sv5?= =?Windows-1252?Q?nQF/XW+WPecvzY/Rnd+/90gGJyTEjDiOf96V7Eb0zHAUrNya1U5Ht5AH?= =?Windows-1252?Q?8YdjB/s+MyUsOUOslTtqO2sobSaRjvy85rTiSE2aE2Qd/1srolnwGAkn?= =?Windows-1252?Q?G4UpG39XRssZgtEivRqY1bngXguu3IB9B5LbTY8gyYI75u6Lewm1/LRA?= =?Windows-1252?Q?qioSiUn5GIHHKO0BhHCMk/d7byhpMkZppVM0vEbI9V7kDnNVyAxDuuwm?= =?Windows-1252?Q?jLXj7/i8C7+4EJ+pmTRt1m+NP/acpzJmUYN4BRPmkUII1k8kHTIHETvw?= =?Windows-1252?Q?DK/NEd0THx1cJ7xNp4zp3NI+zGdYYcOX6xNOWXdLfXwoWNkllIW0SKBh?= =?Windows-1252?Q?Wr7bPaP5fGk+9Xaq5poYov8ckuW9dru98jvL+UaFdCY8dmKi25u7d/+8?= =?Windows-1252?Q?SoT5crCps8qWuHVFNAcyWJhTb/fy39LjLNZuAx6Ls3KfhI/3jAqHallU?= =?Windows-1252?Q?LLJIfnmRvyNOUME4AyfJQZRKxdt8BSy99M5CA6hUKNx3vFInAB5ek0p+?= =?Windows-1252?Q?o+8xi8v7QaEes+xZLvsZunpzpSpnvAU97LxkIoHI0sey1NHTHESTvRxe?= =?Windows-1252?Q?p/yGgJC2m8NhqAEst16HsPbtLfNDb5B63dxeiSXElLdwaTmeDWhSfA37?= =?Windows-1252?Q?U7JP9EN2wZknTZYNztKLaldnNT2OFfG6bx7uRNql4mcbJgqb82NlYkav?= =?Windows-1252?Q?VqXzsK0uYreNEbQyXgrjO/zJh7oTwpyI2Bm4gC5EKdCzZXnN3B0KaLLq?= =?Windows-1252?Q?iZoGKW7gSmZ5X0q0UfvLEoJWiBCaW9IVGviQM97Tzcju6ZqYJRZMMesX?= =?Windows-1252?Q?h1k0g+RXn5WEbr2hPxeXn3xY253AQMhlgths1vMAZfV19ImVjP6sfmN/?= =?Windows-1252?Q?BBaujtZWlB3yWwNwSsN+UsjvJ5VOSdgcUM4q/RQKwdN+mtXXEAATvtCy?= =?Windows-1252?Q?t/O7JCPv5SQQPFWcPi5sx54exGRGgJlbHuRhRibl9BL3VpvIWw0+33YB?= =?Windows-1252?Q?ri0qOhtPzo1ZT59ykgERcSHSvdrLAj7A7HBYOYmm6MA2xZePgzYXvecR?= =?Windows-1252?Q?Lqvq6GO6cVsXuvgwV8qbRiTdG4cN0CxzYHCFxUuP27v/iBL3idioSLtJ?= =?Windows-1252?Q?19zVIRqWGheJto3/SKivHPXHxDJb3gCA3IblBsMcTbpQ9//xsWO5J5Im?= =?Windows-1252?Q?a58+yoRSwBRVFDL2k8UepUxT/cV0zDURfi/zfCfcGy6tTdfg0YCm/9ss?= =?Windows-1252?Q?eUsah8NX1gl/jCS5XKrzTjMl7mi6+fB7i5b3/LK+PlotsBzGvP90LI3o?= =?Windows-1252?Q?quAip6lMfp6gUCxt18fUaIQFqSuaZ1M5WV737i3cALm3MvLrYDkvYoBC?= X-MS-Exchange-CrossTenant-Network-Message-Id: a838265e-6ee5-461c-9fbe-08d93ca2c63d X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jul 2021 15:13:25.9360 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: uByN7qHxXAOIyQ18s0Gw1hBRvN7l+rPRqSoqRBvI0xA6SOgrCx3R02gfwBUFwC35ijgWYYyC6G64ua730KXaiFlVigezGjl7t+e+NkTSY0U= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR03MB4968 X-OriginatorOrg: citrix.com On 01/07/2021 16:00, Olaf Hering wrote: > Am Thu, 1 Jul 2021 12:19:24 +0100 > schrieb Andrew Cooper : > >> Where is the 51 leaves coming in? > I suspect the bug is this line, and the magic "0x1c" value: > > p->extd.max_leaf =3D min(p->extd.max_leaf, 0x1cu); > > In my testing basic remains at 13, while extd is truncated from 0x8000000= 8 to 28. > I think it should be truncated to CPUID_GUEST_NR_EXTD_INTEL? That logic is definitely incorrect, but using a different constant isn't right.=A0 I think it has been copied from elsewhere else and incorrectly simplified. I'll see about trying to fix it... ~Andrew From xen-devel-bounces@lists.xenproject.org Thu Jul 01 15:18:29 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 15:18:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148928.275258 (Exim 4.92) (envelope-from ) id 1lyySP-0002qK-6b; Thu, 01 Jul 2021 15:18:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148928.275258; Thu, 01 Jul 2021 15:18:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyySP-0002qD-3L; Thu, 01 Jul 2021 15:18:25 +0000 Received: by outflank-mailman (input) for mailman id 148928; Thu, 01 Jul 2021 15:18:23 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyySN-0002q7-LK for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 15:18:23 +0000 Received: from mo4-p02-ob.smtp.rzone.de (unknown [85.215.255.81]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 916c577d-da7f-11eb-833c-12813bfff9fa; Thu, 01 Jul 2021 15:18:22 +0000 (UTC) Received: from sender by smtp.strato.de (RZmta 47.28.1 AUTH) with ESMTPSA id 30791cx61FIL7Rm (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Thu, 1 Jul 2021 17:18:21 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 916c577d-da7f-11eb-833c-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1625152701; s=strato-dkim-0002; d=aepfle.de; h=References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Cc:Date: From:Subject:Sender; bh=M0ebOvnNW5hhMGkl7OSyZD6UvWcOLfEJiyQEs07Unyk=; b=Nd44gLvNb/EU0v4TzAYlo+ljMN/MkE1qlaaMUNq5FfVALjgVxFelHsVmo9k1GGcWPj dHmnjSGj34Gk5Uu+FaOKIpaczF5EXZ/j5sZngwNx61IUPDd/0NiKkICyxmc9fa5lVl/d SF1CIVHRciAJDQylULsq5wmOYjyABZtt58oZ8nmUbVuNVNIpHXO+twSawxdv6ZTPTttQ KmSc4idpFhvXDFQit+HlTdlhQVQmret8sWoSMBOAVr8V0ga2vlNGiNFKmLu706tbn53Y QdfW/DRBWS6QsLxaLKHhDsvkZxps8Hbd8risvDbKe2KQvNSqtN8VdFr3E0UOxOX/shXi i3CQ== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QLpd5ylWvMDX3y/OuD5rXVisQsBBSIa03sY9BUY2ao0oygRsMfcqA6zjDLeeWXNg==" X-RZG-CLASS-ID: mo00 Date: Thu, 1 Jul 2021 17:18:19 +0200 From: Olaf Hering To: Andrew Cooper Cc: Subject: Re: XEN_SYSCTL_cpu_policy_hvm_default truncates leaf count Message-ID: <20210701171819.67968d4d.olaf@aepfle.de> In-Reply-To: <48cfe27b-70fe-36aa-833a-7d78e205528c@citrix.com> References: <20210701125623.593fe3ae.olaf@aepfle.de> <20e828c9-e7dc-4401-9307-a6d72eb618d8@citrix.com> <20210701170009.5a8be33f.olaf@aepfle.de> <48cfe27b-70fe-36aa-833a-7d78e205528c@citrix.com> X-Mailer: Claws Mail 2021.05.27 (GTK+ 2.24.32; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/m4YsW8EoIBaGu/zB3IzQXN2"; protocol="application/pgp-signature"; micalg=pgp-sha256 --Sig_/m4YsW8EoIBaGu/zB3IzQXN2 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Am Thu, 1 Jul 2021 16:13:21 +0100 schrieb Andrew Cooper : > That logic is definitely incorrect, but using a different constant isn't > right. Yeah, that occurred to me after sending this email. I think in the end the values should probably get closer to 51, not smaller= than the current one. Olaf --Sig_/m4YsW8EoIBaGu/zB3IzQXN2 Content-Type: application/pgp-signature Content-Description: Digitale Signatur von OpenPGP -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEE97o7Um30LT3B+5b/86SN7mm1DoAFAmDd3LsACgkQ86SN7mm1 DoC3mRAAjJLu7G7sMzLBGdG25ssHNsvBfA1ylw9kf7OJ7Mp5Z3A7t9SLRGieSFIV zMrSU0D34FyV7YMqS+UUO8o2tmWR9Tlk3o+aWRL8EYoRhwF+fsHYfsTUok1Kxge7 hE6rPCL0triPJe1iFrRRep5zEMruMDALmsrcu2VFTYz9S74cmpjkhE3fPmHgxhbJ yOtP8R8xSUudPBBP64URngxEko8xtXkTVJNC77kEXYLWe2Z7T+5pYg/SykoXlNRW BGODq2Rd25ZCPdJfmWhv1BQNodnV6mo907xPwe4+PfjMRm5Gu2OhlqrB44LfVzWB UK7VsfXnCuLhIOsHg7E14iOHq64hPzQ9cFdnxdfaexoF+v7PGlEFUUW1jO9I+nfD OfgAWHf7kbArEP357YCK2wBlLjzbs3EukaNmHP4QS9uWq0rlMgHfiaPZpxNP+Q9j ZcBD0vHWv5jZB1mkdo+bl5By8ELsog0AxjvCJrsWrwHfGzOqDCWLVlSf7cgN+Bs8 Koak+qvGlXEIf30spvcAdLvIEwvS2edEm4tZv/M0XVa3Fl/l53EPYnIGegmbxPcY cTXsEfzr9aps78KtmNV1BkFQ2I1AGIB6ohFXwJStnNStw7t7LJiU9Xic32NlwNDf njPFX4SRsVlOED1np3A3vxF5/BwI2SyTn0Y2ZHKZ53YtOmCmr+Y= =dn6K -----END PGP SIGNATURE----- --Sig_/m4YsW8EoIBaGu/zB3IzQXN2-- From xen-devel-bounces@lists.xenproject.org Thu Jul 01 15:25:27 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 15:25:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148936.275269 (Exim 4.92) (envelope-from ) id 1lyyZ8-0004Il-UM; Thu, 01 Jul 2021 15:25:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148936.275269; Thu, 01 Jul 2021 15:25:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyyZ8-0004Ie-RR; Thu, 01 Jul 2021 15:25:22 +0000 Received: by outflank-mailman (input) for mailman id 148936; Thu, 01 Jul 2021 15:25:22 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyyZ8-0004IY-BK for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 15:25:22 +0000 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 8c44fd48-da80-11eb-8340-12813bfff9fa; Thu, 01 Jul 2021 15:25:21 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8c44fd48-da80-11eb-8340-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1625153121; h=subject:to:cc:references:from:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=X/V5ibCYQ5Ltjst3E1u/yOTCJtEyYzUZXQwk3N3+N8A=; b=SuZU4Sq/kFh51r6PDK8rqJPQR9NkpLnUAMySwSCxwiGL9oB38SNUStf5 oHFi3Dxmc/BGFLQiTMTwHNdVcpKXEjrRLytpOZi9LotlZpaZhYuwnthSY qD0KBy/WpL4eUv+801B4rHAsF+Oo+Z9QeOrHkJXAJq0rk/46Cum5aEimG Y=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=hardfail (body hash did not verify [final]) header.i=@citrix.onmicrosoft.com IronPort-SDR: AxWbYp+n8zJn626r/8nVZagjrA9vK/HRgctX5sBjxiDLboBgojMajFNpOTFsSElb5+qVLt7UDm IzAHNGI4G3xjdlzOejouTclhEtTm4PxRXidxT5fL49gcTR8G1yuokBppr/DvDxVU5ReZNNIRfy Cs1kNimiawwRwnjF0rUnVICOeVGeZsf707zZ1UErjLxxpivEDaBHiItlctrdueRbM9sKbVLhSE hULnDmfDd/3GPJlMDBNUVzTR2ox74swBN8G3d4V4mXGnxKoAt8esZG8eqp0IYB38+Ju662EAAR Io8= X-SBRS: 5.1 X-MesageID: 47455352 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:5a/oW6+ZpwXnPhFqhxRuk+E1db1zdoMgy1knxilNoENuHPBwxv rAoB1E73PJYVYqOE3Jmbi7Sc69qADnhOBICO4qTMiftWjdyReVxeRZjLcKrAeQYBEWmtQtrJ uINpIOdeEYbmIK//oSgjPIa+rIqePvmMvD6Ja8vhUdOT2CKZsQiTuRYjzrYXGeLzM2YKbReq Dsgvav6wDQA0j+Oa+Adwk4tqX41pL2vaOjRSRDKw8s6QGIgz/twLnmEyKA1hNbdz9U278t/U XMjgS8v8yYwrCG4y6Z81WWw4VdmdPnxNcGLMuQivINIjGprgqzfoxuV5CLoThwiuCy71QBls XKvn4bTopOwkKUWlvwjQrm2gHm3jprwWTl00WkjXzqptG8bC4mCuJa7LgpMCfx2g4FhpVRwa hL12WWu958FhXbhhnw4NDOSlVDile0m3w/iuQe5kYvErf2UIUh6bD3wXklV6vpREnBmcYa+a hVfYHhDc9tABanhyuzhBg3/DTENU5DaytvQSA5y4aoOnZt7ShEJnAjtboid0E7hdkAoql/lp P525tT5fhzp+8tHO9A7bQ6MIeK4lKke2OFDIvEGyWXKEhAAQOXl6LK X-IronPort-AV: E=Sophos;i="5.83,314,1616472000"; d="scan'208";a="47455352" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=f4mgmGHWxsu3RaQMRFAyOgsPoC7dttGOOkH8Xor5Eqy/jKYgViChM7RywtYpqOhvKwDqMDUO1jiadE07A9MCmmk6Ji87GmY+XyLo7ROQL/qlxMKB36npglfBiCzzLefyv9p50yNHTfkLqhxMWt5vBDscvwXBMc+V/MoQhkojkxhIpaoFPDJkNqkXH9ieY6ewKCXv7qiBEhTYTt9+pvQ7UKZFNYPl0ZXn2FwoxjhyN3SoiDHuIr6QLp6baCQbj3Niu7SP29XJsRoEqG2DfRfsnFOj4quEML5SE0vISguo8cfCgTPXVinTeC9VVtyqx65dagV33vB7TYGz46/GBFNEmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mjwVxX4GgIrAQoSzUjcjTbNJwYYZxd6+6mayAKz3JtU=; b=Dax8dpeRQJNFqEhNGHJhsSYPuF43nWL/aR5pUff6noAFwBWgMQuSzE4BL7ntgqwVQHdncMP+hmZt1MLr4zOBsd4sk0uVwDo7TjB98buc8eqU4mA0FveZyKjIMODq+5zEWLU9OpONzfdgtSxPSa7YNXqW5qT6YdNM98ch2LusgppMsTKj8yod7XOwp5zMWBlTMWlZsAOoZ/itJV4X7aGq9T11+Sm0y169yCNVBdtUho5QPX/IEc6gvU+3l+p3XwpQKisG2ZB/C70cXTQk1Z/Ky55ilfObNmo7oJ19sLp+oC/K3mcaUyl2GgMdmlYatdE2TmVJbHti426GAXd2qpkEBQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mjwVxX4GgIrAQoSzUjcjTbNJwYYZxd6+6mayAKz3JtU=; b=W9Y4S3+IpzqVGGQUm03nPFM/w7U8NHdORGcZjp6gnL1uMZGsbh9DSQIIFWQ4iIJmCJS3LmC4zvwHRzQpYyFP94QUMeg4cc3ClfhnZ7cDHq2WICLed8Xab3/AZNcbrIsiBvwo30Lxj/t891tX6mVgF7GPsoEtY9safsYdcE8CECk= Subject: Re: XEN_SYSCTL_cpu_policy_hvm_default truncates leaf count To: Olaf Hering CC: References: <20210701125623.593fe3ae.olaf@aepfle.de> <20e828c9-e7dc-4401-9307-a6d72eb618d8@citrix.com> <20210701170009.5a8be33f.olaf@aepfle.de> <48cfe27b-70fe-36aa-833a-7d78e205528c@citrix.com> <20210701171819.67968d4d.olaf@aepfle.de> From: Andrew Cooper Message-ID: Date: Thu, 1 Jul 2021 16:25:10 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 In-Reply-To: <20210701171819.67968d4d.olaf@aepfle.de> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Content-Language: en-GB X-ClientProxiedBy: LO4P123CA0256.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:194::9) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0ca967e3-da94-412b-5dfe-08d93ca46e0d X-MS-TrafficTypeDiagnostic: BYAPR03MB4680: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1227; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VBIHtrEeW7g7sgbxbguMX1tdpK/bg6/tlIs1jb1LZ/RGowor7dRaJKOTyvPg620dtx7wuuz4u46nJ8TT41PGvBLdTIxYtAlFojK87xTLZlQzHAR4GKffz27O1HEC3mrxqFCCBcKQx+d6SKqvXyz19q47vx+HLQplYUHk+pYYIHJLYi+LiwuJd605wO4duLlQ+imA21gSUc2SLYSyGo7nNtJDZOIpOhapXO0b1TkdZMZfNeXcRsLOg5AywJP3IBwmd7N++gNeAJx+h0R/PeiZsjr8l185QjAbaQOehWlqrh7nKX7Xya6V9U5Tr2TkKmwCiVDxv1u0tHgAAxJ9RT8n5K5TX6xjCoTbWM/9f16sweANF1FRtkmegmUDf4kSlDnCc5VHsy/xUITjnj8qBXWISIQqo2Of1OVPxafZSCSa2IA+sXTwvxTiDtWMXbe/x4XVt+v0IEEu9emY6fo6qUTsXRvpdXFGR2UhV1HXhTIrLoD3IMYD8adAEOq0eAg6AKK/xCguX/hWg9tsDJ62G4dfV/zmxEAT4w0pe3b+gqwnkUeAPMa60O80gWwrCqgB1e/WEFplE3baR1q+dhYMIEb25KqeCCV3k6gAqBT2Hzlz6IkhY4VMhcxG+UBI9SA6C9SpcEn3mzakvEkim6W5twINKzGZbHiK4pxinl1NcdjBUsTp4/OaI36s7Amm9mZmsyJDXwnuMjGgxO2CkP7FU6p4CDBMEwJ0sn3TmAH0uk0tzZvMSz1U9ZZZHa/amBm1aN21 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(39860400002)(376002)(346002)(396003)(366004)(8676002)(186003)(83380400001)(16526019)(6916009)(53546011)(38100700002)(26005)(6666004)(31686004)(478600001)(5660300002)(36756003)(2906002)(31696002)(86362001)(16576012)(316002)(956004)(4326008)(66946007)(66556008)(8936002)(2616005)(66476007)(6486002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?Windows-1252?Q?GreJc3SMVHfRXYwURNJzmrwnk6axbm1G4rK2Ee2c2V/6kBOeZ4Cna4nP?= =?Windows-1252?Q?Cr+wZuNuIU1ks3woRGFpYp5XWgfKASzLfKStnvgxEpDyjQCexF1KN8FF?= =?Windows-1252?Q?nGEBNiMdgUgPJ54gEjalXwEwJhl2KzA3nsyZzwP54vM03pLOZvG3aw2s?= =?Windows-1252?Q?3lHFPEJiVy+siseGAzaOKBSm4WJNkg4k5gBnwUICD23wIsKWyEZ4o+tI?= =?Windows-1252?Q?Q0cd2ir9Dxx7pkTdrlUhjexQxY6esQYIYfCHprnJF8EaxbAypBCrUvSK?= =?Windows-1252?Q?UA6oX+pV5sF/laCOO5KMwvCqalF8aV3Q+SO4Q3NZKWkpW6H5YqN4JBMl?= =?Windows-1252?Q?s0m5N8axsFDgOj2aJMREfqjuIrNV8BiCB6RTfNToDhtsLLHb0Q2yZ7Si?= =?Windows-1252?Q?Eb+2dm1BcqsB40YwtxzYbi9ymUTnMJnaS//81cv4T5JI29tHSxaK87LG?= =?Windows-1252?Q?o0joUKp4kwL3tC4DeL5J1ckwilY4ESAtkVadS2jegzuVGFp1ChR7KCpV?= =?Windows-1252?Q?Hm8n/uMad7fyPPRZWzj7IoEJu3Y5gq7MNaRAh51/mDavU+JH0EO6nEVb?= =?Windows-1252?Q?V3MPRugXB+MLFd4xQput38semNl4SLGUA8gAMTMakqHBvKd0lou+3cJW?= =?Windows-1252?Q?UarDYrAhcsT7WWUU9HWB3tmCTvtFbmsxRAPOyYLrJi1O+x/QXK2zsMEY?= =?Windows-1252?Q?0l/RNvlM0CfN9YWfwAi0XWrufD9oYTsT97idg8m8ApcbC7hzEuLu5+It?= =?Windows-1252?Q?ay7sJ5e63VC7pT7jsfFiNTsB2SHRI4CH3ORTjRpUGkH4iyfPiKqF3DrX?= =?Windows-1252?Q?zHCQKBAJG1BQKC6SwVlgI05kNhoYfZIN68qecRHVx9dqpMyFwH/16WgN?= =?Windows-1252?Q?Qrl5J3Fh3GZPVGfHQck15LSpnFeJdaJPWywRoyU57cPZWufznQXYny00?= =?Windows-1252?Q?2cSjEJ2++AfJru0Jeyu+GzLgwmTz+Jg4itw8dzcTponruErL2XDCZs0I?= =?Windows-1252?Q?FEKcVOqtoanbxamUgz+/qkKq4MSrkeqD/giwQuzPn1RBILctvwEMbIHV?= =?Windows-1252?Q?UGL+1Nex75p6XxwoNRzTeNRWSF76WOF9xwSKd6hacoH1toL0n91mu3j4?= =?Windows-1252?Q?k3qsTp0CxmdqpHzgPfXUjnOk54MyvCxEK9IS3Qeiuifeo04aq5Uq2+WF?= =?Windows-1252?Q?cdiwJjQeX9z/qhExVeimlxZ0ZSUa1u1uRAcY0gQjG9nQmdvaKt0JDRCG?= =?Windows-1252?Q?QSeBFqGZ1UNbQAG/Ld+IrMapy4B97f4usATSpUtgsowQ+BfL+IMCjD0P?= =?Windows-1252?Q?n65biZQuMgCMHhnHSIdclOe0bqXJ4d6IVFRLJscRb0YBwj5q81Yvue6C?= =?Windows-1252?Q?s3irPoe2ab5e59twv/XFzOwFy6k3PaEMAS6phikJSKoD8t3nswiJlGkk?= X-MS-Exchange-CrossTenant-Network-Message-Id: 0ca967e3-da94-412b-5dfe-08d93ca46e0d X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jul 2021 15:25:16.9757 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xrYH1kp6hYoUOuKDajInr5xtH5jj/A6gCwYLjVWMxXEAKI++nwvSi2stIgeAcgj+kHWTg+LsNnEwgB4G9dRJfFgxBEbcawVFsgJEzL4Erxg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB4680 X-OriginatorOrg: citrix.com On 01/07/2021 16:18, Olaf Hering wrote: > Am Thu, 1 Jul 2021 16:13:21 +0100 > schrieb Andrew Cooper : > >> That logic is definitely incorrect, but using a different constant isn't >> right. > Yeah, that occurred to me after sending this email. > I think in the end the values should probably get closer to 51, not smaller than the current one. Can you give this a spin? (Sorry - I'm busy with another task right now - I'll do a commit message in due course) ~Andrew diff --git a/tools/libs/guest/xg_cpuid_x86.c b/tools/libs/guest/xg_cpuid_x86.c index e01d657e03..e1fa33d708 100644 --- a/tools/libs/guest/xg_cpuid_x86.c +++ b/tools/libs/guest/xg_cpuid_x86.c @@ -513,7 +513,7 @@ int xc_cpuid_apply_policy(xc_interface *xch, uint32_t domid, bool restore, /* Clamp maximum leaves to the ones supported on 4.12. */ p->basic.max_leaf = min(p->basic.max_leaf, 0xdu); p->feat.max_subleaf = 0; - p->extd.max_leaf = min(p->extd.max_leaf, 0x1cu); + p->extd.max_leaf = 0x80000000 | min(p->extd.max_leaf & 0xffff, 0x1cu); } if ( featureset ) From xen-devel-bounces@lists.xenproject.org Thu Jul 01 15:43:36 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 15:43:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148943.275280 (Exim 4.92) (envelope-from ) id 1lyyqg-0006iB-LB; Thu, 01 Jul 2021 15:43:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148943.275280; Thu, 01 Jul 2021 15:43:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyyqg-0006i4-Gz; Thu, 01 Jul 2021 15:43:30 +0000 Received: by outflank-mailman (input) for mailman id 148943; Thu, 01 Jul 2021 15:43:29 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyyqf-0006hu-It; Thu, 01 Jul 2021 15:43:29 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyyqf-0008A0-DI; Thu, 01 Jul 2021 15:43:29 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyyqf-0004FY-43; Thu, 01 Jul 2021 15:43:29 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lyyqf-0000dW-3U; Thu, 01 Jul 2021 15:43:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=8hDzVsvnQdC8oYQ6Ruqk5A0ejVENUULzYfeJB+I0mKE=; b=MeMcp70Nc3dtLEQnWfCus3vz37 BrrsF5u5P7SiO8uMlUnMFsi3fbgqCrTS3Y6oDFYgs07IkNdRzIAEnhCHrCT2Fev3U7NMCoexb/R7n pwVps4ECx7Td2CTo5y21XDHRVect0DsaHaS1UedikOCSFMRq/vjvEUY3rlSSXcH24d1M=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xtf test] 163212: all pass - PUSHED X-Osstest-Versions-This: xtf=cdef9568c1b1f8831f3b8f644073e635d47f0ec4 X-Osstest-Versions-That: xtf=93b29b886e8665e368598c711279d45b7e5d066c From: osstest service owner Date: Thu, 01 Jul 2021 15:43:29 +0000 flight 163212 xtf real [real] http://logs.test-lab.xenproject.org/osstest/logs/163212/ Perfect :-) All tests in this flight passed as required version targeted for testing: xtf cdef9568c1b1f8831f3b8f644073e635d47f0ec4 baseline version: xtf 93b29b886e8665e368598c711279d45b7e5d066c Last test of basis 163016 2021-06-24 11:41:21 Z 7 days Testing same since 163212 2021-07-01 12:40:06 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Pranjal Singh <008pranjalsingh@gmail.com> jobs: build-amd64-xtf pass build-amd64 pass build-amd64-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xtf.git 93b29b8..cdef956 cdef9568c1b1f8831f3b8f644073e635d47f0ec4 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Thu Jul 01 15:53:01 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 15:53:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148949.275294 (Exim 4.92) (envelope-from ) id 1lyyzq-0008Aj-HZ; Thu, 01 Jul 2021 15:52:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148949.275294; Thu, 01 Jul 2021 15:52:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyyzq-0008Ac-Eb; Thu, 01 Jul 2021 15:52:58 +0000 Received: by outflank-mailman (input) for mailman id 148949; Thu, 01 Jul 2021 15:52:56 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyyzo-0008AW-Oa for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 15:52:56 +0000 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id a85c2024-3b38-412d-90ee-51c082d3b1f3; Thu, 01 Jul 2021 15:52:55 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a85c2024-3b38-412d-90ee-51c082d3b1f3 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1625154775; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=y1e/4dsezIMJVg+0zwuh7zOhGcr3k456Pu74dnN3TXA=; b=e+AHZWVh+LwlAwwa4M+pHEYe7PyKqzGqjVMQr04nJC8NRCcTo3Lhb+Zp yp/REsdT2aK/Z2NYMmQwH+vgnvPdN4ZhPiwmJABxqpoSefS2HIBNaOCRW lEGlXqwon7KFoluPjV+pzvTZ+Wl/d4ODbEaHFrrGWhW7dWMqwswXW+8SH Y=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: jX2BKWaZ/WBhxDFAMELTQV8xH2CfNJ9KXSV9dZET0cXK1d+bFtMJeTBJKkuKB/5kjeJ75IhsGo tlPU0JKCOQ7pal0SCRwUrliD3GLvoQrxxrSJE9GAVjN2vIS+1/Wr4nrAlkk5LsS2+7l0h2TQEi K1+JN3P4aIV8NYWn32U9/UiyfGcXjJk206IvAlakO4DRHUOilCRGEwKEL57o8C51B6s4iA1DpT WG5evNjBmDL/sdD1RRaHMZqGJydHOtapEw2fiZ3eapakYK0ayqpYryAdpgIXIuMGI/HAkckYHk C88= X-SBRS: 5.1 X-MesageID: 47458429 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:4aWhxa3v25HBFFW0JFs9yAqjBT5yeYIsimQD101hICG9Lfb3qy n+ppsmPEHP5Ar5AEtQ5OxoS5PwPU80lKQFr7X5WI3CYOCIghrQEGgP1/qB/9SkIVyFygc/79 YgT0EdMqyJMbESt6+Ti2PUc6dC/DDEytHSuQ639QY3cegAUdAF0+4NMHf8LqQAfnggOXNWLu v42uN34x6bPVgHZMWyAXcIG8LZocfQqZ7gaRkaQzY69Qinl1qTmf7HOind+i1bfyJEwL8k/2 SAuRf+/L+fv/ayzQKZ/3PP7q5RhMDqxrJ4dY+xY4kuW3fRYzSTFcBcso65zXcISSaUmRAXee z30lId1gJImirsly+O0EPQMkLboUkTAjfZuCGlaD3Y0JbErXsBerp8bY41SGqp12Mw+N57y6 5FxGSfqt5eCg7Bhj3045zSWwhtjVfcmwtprQc/tQ0WbWIlUs4bkWXfxjIjLL4QWCbhrIw3Gu hnC8/RoP5QbFOBdnjc+m1i2salUHg/FgqPBhFqgL3Y7xFG2HRii0cIzs0WmXkNsJo7Vplf/u zBdqBljqtHQMMaZb90QO0BXcy0AGrQRg+kChPeHb0mLtBPB5vpke+53FwY3pDeRHU49upFpH 2aaiIriYcbQTObNSSh5uw5zizw X-IronPort-AV: E=Sophos;i="5.83,314,1616472000"; d="scan'208";a="47458429" From: Anthony PERARD To: CC: Ian Jackson , Wei Liu , Juergen Gross , Anthony PERARD Subject: [XEN PATCH] MAINTAINERS: Updating after change to tools/include/ Date: Thu, 1 Jul 2021 16:52:32 +0100 Message-ID: <20210701155232.792978-1-anthony.perard@citrix.com> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain The LIBS section doesn't mention the headers associated with the libraries, same for LIBXENLIGHT section. They aren't any ':' in other section names, so remove it. Fixes: 4664034cdc72 ("tools/libs: move official headers to common directory") Fixes: f7079d7ef69f ("MAINTAINERS: add myself as tools/libs reviewer") Signed-off-by: Anthony PERARD --- MAINTAINERS | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 8a52a03969fe..56d16e4328cf 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -374,11 +374,25 @@ F: xen/include/{kexec,kimage}.h F: xen/arch/x86/machine_kexec.c F: xen/arch/x86/x86_64/kexec_reloc.S -LIBS: +LIBS M: Ian Jackson M: Wei Liu R: Juergen Gross S: Supported +F: tools/include/libxenvchan.h +F: tools/include/xencall.h +F: tools/include/xenctrl*.h +F: tools/include/xendevicemodel.h +F: tools/include/xenevtchn.h +F: tools/include/xenforeignmemory.h +F: tools/include/xengnttab.h +F: tools/include/xenguest.h +F: tools/include/xenhypfs.h +F: tools/include/xenstat.h +F: tools/include/xenstore*.h +F: tools/include/xenstore-compat/*.h +F: tools/include/xentoolcore*.h +F: tools/include/xentoollog.h F: tools/libs/ LIBXENLIGHT @@ -386,6 +400,7 @@ M: Ian Jackson M: Wei Liu M: Anthony PERARD S: Supported +F: tools/include/libxl*.h F: tools/libs/light/ F: tools/libs/util/ F: tools/xl/ -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Thu Jul 01 16:23:37 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 16:23:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148954.275305 (Exim 4.92) (envelope-from ) id 1lyzTF-0003Qq-SH; Thu, 01 Jul 2021 16:23:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148954.275305; Thu, 01 Jul 2021 16:23:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyzTF-0003Qj-PL; Thu, 01 Jul 2021 16:23:21 +0000 Received: by outflank-mailman (input) for mailman id 148954; Thu, 01 Jul 2021 16:23:20 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyzTD-0003Qd-S5 for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 16:23:20 +0000 Received: from mo4-p00-ob.smtp.rzone.de (unknown [85.215.255.25]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id deb8d0ca-a45b-4ab6-ac30-1b552949c886; Thu, 01 Jul 2021 16:23:18 +0000 (UTC) Received: from sender by smtp.strato.de (RZmta 47.28.1 AUTH) with ESMTPSA id 30791cx61GNH7g0 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Thu, 1 Jul 2021 18:23:17 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: deb8d0ca-a45b-4ab6-ac30-1b552949c886 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1625156597; s=strato-dkim-0002; d=aepfle.de; h=References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Cc:Date: From:Subject:Sender; bh=Vn+2Cg38JHefu8IRGLFILggWXxBZgWIPgtfWkr3bmLM=; b=IDY0PVhJXUOoCm9WsGq9/yjF/VTVf4T3uOdPDv7BA8XmrL9UNn3jbQARfHPrZeZM+j hYOs2SeTPGpNLdG2p1J+6514KdTXQ8vmnRnroxhzEBLuc31h4Ssw63/8UQKzTXlI9gAC tyCIgTs71fxdHHr0k8odhnGQKkkCUAMifi+S4BtkpSUjRW8B92sWTMPIWMqbQz9fC9aA Asiqjla9ZgLBwBnrao6osi+NmSpLx4OmWFXDwIxA0GjVZWyvd+0ZNlyfKsFICezZjgJW 2oXRxFXtBWAgDaIt8k+K/h4TE/4c9yxfO4Cntn5QAtD0NE81AFIkf2m02CBkmvTGTg8k YbDg== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QLpd5ylWvMDX3y/OuD5rXVisQsBBSIa03sY9BUY2ao0oygRsMfcqA6zjDLeeWXNg==" X-RZG-CLASS-ID: mo00 Date: Thu, 1 Jul 2021 18:23:03 +0200 From: Olaf Hering To: Andrew Cooper Cc: Subject: Re: XEN_SYSCTL_cpu_policy_hvm_default truncates leaf count Message-ID: <20210701182303.53756e1e.olaf@aepfle.de> In-Reply-To: References: <20210701125623.593fe3ae.olaf@aepfle.de> <20e828c9-e7dc-4401-9307-a6d72eb618d8@citrix.com> <20210701170009.5a8be33f.olaf@aepfle.de> <48cfe27b-70fe-36aa-833a-7d78e205528c@citrix.com> <20210701171819.67968d4d.olaf@aepfle.de> X-Mailer: Claws Mail 2021.05.27 (GTK+ 2.24.32; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/ZX8F8fCP.bKboWIEMyMZzaB"; protocol="application/pgp-signature"; micalg=pgp-sha256 --Sig_/ZX8F8fCP.bKboWIEMyMZzaB Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Am Thu, 1 Jul 2021 16:25:10 +0100 schrieb Andrew Cooper : > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 p->extd.max_leaf =3D min(p->e= xtd.max_leaf, 0x1cu); > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 p->extd.max_leaf =3D 0x800000= 00 | min(p->extd.max_leaf & 0xffff, > 0x1cu); Yes, this fixes it for me. Thanks. Olaf --Sig_/ZX8F8fCP.bKboWIEMyMZzaB Content-Type: application/pgp-signature Content-Description: Digitale Signatur von OpenPGP -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEE97o7Um30LT3B+5b/86SN7mm1DoAFAmDd6+cACgkQ86SN7mm1 DoBVgg/8C3Qwwaw/1t1Suul1ZLu8HXZ44bMfBfQjLkLWuo9+Gp/ixpMVrKUxGerL g13cBrMpUiByf4C1TMn4s/SWNBUKcrnF8GlMwQCQXe0eSjxTGYVTMU51x+wTLUXm I6YXzUdEo+yrJDdrFWcd7mWP3o69qfMTnnmMcjHsVStDTXrtjOxutGMPjwi1eu/Z 21mcH7OjMUeZlxr+g/msYwFWPOHROw7Uj/eD0HubGYKx+VGwpzc2poHcz9NKTZ9F 5rPsGhf35oEzhZWMkvN7XxdwG1RrP0ZP+F/WQ2UkGEQ8pVH8KLHykRpw3I8eLjhP X514TVcOu4nJvONmbGVeMvMutGAPygoEuuBkYdO/VzlEe55impmaxXo1RYh18PZ1 Yo9x7X/TFwwG4B1n4axBL7A1twR35OklbIdLpsnhbR+FSWJFTx4PfIX0+qCVHyMg ZxtWbz4o7Li5JO2AeRq0X9B2yY1AiV7Ewul+iO5mpTQlPAHOni4fZxm/WTaTC4VS wnhJ3dwe4K4iOuWaQuRuWlRO/FK0cq/GRJ2ReVzuXrto8+WgFJ2GtaN3BCTdyp5Q hA9vzqnKtIVhJAKkIiBN1HWCrqM5p2rCCM04Zu4jONq8/kPSBZHDHNy0hVrMqh7c oRULMLBTMyeK2eN8YLY1UD2JzbYKlDp+EzJU7BP3rVOIzkPaOD0= =lpa2 -----END PGP SIGNATURE----- --Sig_/ZX8F8fCP.bKboWIEMyMZzaB-- From xen-devel-bounces@lists.xenproject.org Thu Jul 01 16:28:42 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 16:28:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148959.275316 (Exim 4.92) (envelope-from ) id 1lyzYN-00046i-Fb; Thu, 01 Jul 2021 16:28:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148959.275316; Thu, 01 Jul 2021 16:28:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyzYN-00046b-CX; Thu, 01 Jul 2021 16:28:39 +0000 Received: by outflank-mailman (input) for mailman id 148959; Thu, 01 Jul 2021 16:28:38 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyzYM-00046V-FC for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 16:28:38 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 62ce21de-da89-11eb-834a-12813bfff9fa; Thu, 01 Jul 2021 16:28:37 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 62ce21de-da89-11eb-834a-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1625156917; h=subject:to:cc:references:from:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=dO6qQWqwyorMYGU7047AcVjW2mxs/SQxbE8+jVjUZWI=; b=ByXBlmBNYdB9ugbnI9INh6mDIL1OLa/LFpn8mpNx8+Vo/HRjlfGGDoQJ glfKYX4vNFNaQ01ARDK3ELxW9/KW4AJ8HQiKYN85UgmeAb0l1GwXIR6f1 FJTHC1G5dA4odyM++AWdXMFQeQehoBf3CCuuTVtUIHTfIWEgahfRZG8gD c=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: MckqqaUWzpl+kSosY7VrEv+yDz6/amnJt6NQWllmdDNpuc6Qufdef20kgUP/pgXanXQ5Dr9iOC WgFtWMM9PADZkplQBx0tISiwVXezP2XwF8x1mcAwu3remqrwnydUab4hk/8Hsz2eI6DgW061yo d9cJawgrxeZJBqTroxi60bnVkfXHkuWaLmEQ5X07NZu1cbX6kocr+HZ2d1ztswa6n45NpgHE8/ CLyaH31pb/qG6Z3Z6Qig3D5ZoumS+JbMH2xRMBD0/HkKPQy/fkFpuolRHE2OMGkMALgpPZEGWw 6sU= X-SBRS: 5.1 X-MesageID: 49024238 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:2pcpYahlRlYpNpddzo9X7mGYM3BQXh4ji2hC6mlwRA09TyX5ra 2TdZUgpHrJYVMqMk3I9uruBEDtex3hHP1OkOss1NWZPDUO0VHARO1fBOPZqAEIcBeOldK1u5 0AT0B/YueAd2STj6zBkXSF+wBL+qj6zEiq792usEuEVWtRGsVdB58SMHfiLqVxLjM2YqYRJd 6nyedsgSGvQngTZtTTPAh/YwCSz+e78q4PeHQ9dmca1DU= X-IronPort-AV: E=Sophos;i="5.83,314,1616472000"; d="scan'208";a="49024238" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RWYt9vbgBRREqjxjyp+x0YJS4vbOmDFc9i8uaZjaCW8DtGVtgqxREsU4aDQ62X2/ZUPfo99iFViS1v+QwUw+H3TI84PDM2NTAwSIgn+JIJUyc6eFd1Z38BRr8BwsmQksJ2sXQynnlB91zW4CLLDBoRJW/MQvnkGtVdY8+BQcGYj36OlWRCNcfMOx4kvGFQ0TGspRI6EfP6FGztUzKw6APSXQh5VOmQQ2WQLMxzLu/QhsPF2GL3CNOdyYAIGf/9q2fBxKCleoc0tSrZriO4QuONfcuVij8SJjBs0brwlJRsl03ETh0WZ6MqLwjAnZdZfUDhsgCCgunkgAqWNkjjoEGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dO6qQWqwyorMYGU7047AcVjW2mxs/SQxbE8+jVjUZWI=; b=l+kcMhYMgSxzE5imh4hLEOk8L+0dLrhfjnxXV35+sdB9Mtt/HwDaS8RtTdD3W2jtAJ7zzjGjyCULAeDAg8ZE41CNsRMQfDP3jvBSQQrBRvP2NLnsvCA4RnG5DZ3kK1/TleoTpbuLmfMSdbi61XclX2bMv+Xo4OcGZuePVQypZMzOdRJFhkGEegwkars8Kyv/lw9ovzZi3nNLBo301ViqUCYf8166Vt7PtmA2MXAHxKwsxP7z82+va8xLDrhib13BcKahKeIIUydZ+ZwSUhECUDbOJmw0lm7OGBLWeffj5oqOAKKosMhI3Mn73qvRSDgChgZO9iaX9Qky/k6fErJ9GQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dO6qQWqwyorMYGU7047AcVjW2mxs/SQxbE8+jVjUZWI=; b=gWgkisaODfoSLdV4kbIjfj1gT2anbeFdrIFXpnqR4XXqdrLvPmDiKzN7vQK8+TNBJw/qF9yM0HhUfQsY4Jc8QwSqKqOFHrH8DM8lnLlxhno24enU3HVZeo49Re0hXsxN1H0uM8hoq30KEP3qbTaXXcEn/KHOKlmzwzb37EV/WvU= Subject: Re: XEN_SYSCTL_cpu_policy_hvm_default truncates leaf count To: Olaf Hering CC: References: <20210701125623.593fe3ae.olaf@aepfle.de> <20e828c9-e7dc-4401-9307-a6d72eb618d8@citrix.com> <20210701170009.5a8be33f.olaf@aepfle.de> <48cfe27b-70fe-36aa-833a-7d78e205528c@citrix.com> <20210701171819.67968d4d.olaf@aepfle.de> <20210701182303.53756e1e.olaf@aepfle.de> From: Andrew Cooper Message-ID: <967b6463-c1bd-6ced-bec6-bafe02310e09@citrix.com> Date: Thu, 1 Jul 2021 17:28:25 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 In-Reply-To: <20210701182303.53756e1e.olaf@aepfle.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-GB X-ClientProxiedBy: LO2P265CA0003.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:62::15) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 67977f58-f8b5-4ba1-ddf0-08d93cad439f X-MS-TrafficTypeDiagnostic: BYAPR03MB4120: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0/1fXh+xcW1tXou7PzziEIAPwxnucCpJ9HvcQfCu2lg8XFuR5LmUvTHv7LJ45HvW2DcUuP7rYCkTiqxhfCGfsr4Msz8C89TjdDihZEg+pyp1uUdHKDAJXRU8iXYmPXtbcnuj22PFm/u/ORW0Af1GEJZFszzPrl6ibpWmjqAMGUNcOxxIm8/1O/HhJDzMlUjX5AfOPXdzOSy3tv+t3JpNGNFVtCy/N68QA58OvK7nyDDCrsJ0zD0FU58LUIPff9V237Q0PKLxS1VGRN2hnfpbkdQRvagB9adFpPk7GzcIjGMVrlcxTGCRvGY7dwstLcEU2z8ZsbVTQqY2VRfnF6mmLDCxH+SJ925nzzRhFa4gFfsSDjI5Hu2B+Ya5PovWAPsyF/psyikjLM8FT+n8+vIxgARZ909iSywskHqnxztSkEDbM2lRhvLFqGVfKJxROUhLvIJQgRQHEnB6SCnNXQU54I4HkKwKt48frhOjpY1ZyocIUsbtkmipGMh6HQYRu3HzDhBLlIOT07YtIWkXJI9wBqRcS4ZOmjr8uQEOcXcekGaV1pzatEqj+MKiGWRPFKspIhP9z0mIH8lNm9ZPjBlbrkUTiDYWNQhNSh9eFVwq5E6CvJBei40Uhohr4YtFWmHNl7Y4+hZEfqs9iocXbckfjsw1WtHxQO8vWEBFRJAqPLbOM1hPG9XyRgERTaQHEauf0G2ytIeQwAcXW+oGSrTx+RMli+UJAuTJMi1T8VwvGFfivt52ZJIsAn9VZYx9ON12 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(66946007)(66556008)(66476007)(8936002)(2616005)(956004)(6916009)(5660300002)(4744005)(16576012)(86362001)(4326008)(186003)(2906002)(16526019)(53546011)(498600001)(36756003)(38100700002)(6486002)(31686004)(31696002)(6666004)(8676002)(26005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UzIvTXp3L3ZFam5Mc1F4WUVkUHF5RnFtTXRWVFBob0wxTDBqWTNDMHlRK2hO?= =?utf-8?B?T25lOENzcGtMVjg2d3B0QmhKeWRFbktJSEVzOTJHOWNYbnBlZXVpTTJDeXBC?= =?utf-8?B?ZHlNTnVwU0xNNTl2Ni9VMG1yREdIZGJUcTdPMG8rV2FDelJvQWN4Q2x3L0pa?= =?utf-8?B?N2pMRm9VdW9WR1J5aGc2YTJMZEVKRmNmeG5jWDY3VmVrOWNDbEpPeWtMYlZo?= =?utf-8?B?TXc2QTY0ckdSeTVzSjJuRUFtU1RrNGJvaWpKV0czUWRiYkRha1ZzZmtYbmlm?= =?utf-8?B?M0RPb2s4S05tR3MxVnlhV3B3MEUvMWZxeFpUOXA2YnB3NmpkN0RKSnVIbzh2?= =?utf-8?B?RWhyTkVUakNvQWpvaFF4NXFIL1FyQ1M1WVNaaFJZM2lsN290NGwxdmlndmlT?= =?utf-8?B?c0Rya2hsN1JUY21NSXJFb2J3YkdMUE1OY0FRMXA4U0JZK3dCZ1JaUzUrSEUy?= =?utf-8?B?Y3FFQzB5anh5WHJzdm5uY083STgzdHZYbnJ5NUlISVBodlYwdTRTVDl2SGZr?= =?utf-8?B?c0NvRVlmZ3NyTnRBSFp4VTZZYk1ydC9MSkhydGpNR05QdDFxMkdPM1NRS0Y3?= =?utf-8?B?dDRST3RzVjZDUXFDRnhBQVlaQTFsUWZsWFA2S1NQbkxKeU1DM2UxL3ZwSmkz?= =?utf-8?B?OGtFR2l4Q2VCYWZ6cy9paENIdlNjQnQ0UExpSFZmeU4zV2tteXdlT1pVN0d6?= =?utf-8?B?U21TYThUcTBUSXdsRStxVWhNeFZpa09XTm8rSlUrZGpWa0NUczdudlo3TmJQ?= =?utf-8?B?eHQvU01lUjRxOUV2S0FPMEpDdndxTCtjdU5VYWE5bDRzakd5K2tUbHc2MHYr?= =?utf-8?B?R3RnN05OQ0lDM3VJMXNCVVhSZGVLSUNRRUhlRGpRVk9nMWt4MVhqa0lXbWtP?= =?utf-8?B?TVNMZG5kS003TDVDcUJ3WVJDRmt3ckp2K3ZLZlloaGo4YzlHbmVLN29oN091?= =?utf-8?B?dHJwY0FwdlhKamlkM2FlTWFkbTBwSDlRTnFoZTB0RHBVMW5GNGU5WW9HWSta?= =?utf-8?B?Yk80bTMvbmFNaUlQR2ZjS2VLS0hvbEZXUXgvaXhiRjJrbkszWG5YSnhsb3pu?= =?utf-8?B?dVVlNHdUcE15OE9YSzRsZWE4VVpzUG5oWDRQYWtDRmttY2lYODVxVHI2aUU1?= =?utf-8?B?ZzcwcVhWRXZVTmsxUGpaME5oRWxOaVFwZTJlMjNmeHp1d1BjeFRuM2hMOGRX?= =?utf-8?B?U0J3clFoT2tMRFV4SWxQY3BYWUZYeUlYZ201MWpWZFQ0RjArV3Nmc3A2S0Ns?= =?utf-8?B?Q2pnNWpJeVdTVHYvY1VmcVBoTjlDanFHT1V2eHBYdXp6SEVxdWFadmhaMEFD?= =?utf-8?B?VXN4bVRMVTJUb2F1SnZjenphK3ZsaHJ4NVNTdEFsZUwvRGNtdmFjM0JzSkIv?= =?utf-8?B?bDJjU29MeXF2bnM2TzVjQnRaOTd1Mk9ST2lZMUVuS3dvd2JlOFdOMzZSUzNT?= =?utf-8?B?dlUvRUN0UFdaSjVEYmJHZ0ZhWlRRZFpMOWJMZmg0Z0Y2bXJNR0hhKzRZSzdz?= =?utf-8?B?bUFHMmVzblBTMGozbUJYOGZOam4zMnhOVDloRVFZRGpGenplNUdaazB1VFdM?= =?utf-8?B?OE02RUhWWU12bFlyOXN4RmpmSXZwdFJKVmxhODErTkthemFhZTEyZVMweFN3?= =?utf-8?B?YzB4cEZPVUpkTXY2TFJIWjBRVzVMaUwrU25UczJmU2hQU0dTMU84bFcvQjFB?= =?utf-8?B?OFlFV0d2NC9wSC84N0UrZ2FPbFVxdjNaOXZGQi9YSUxNYnhhcStyU1hpOThx?= =?utf-8?Q?P+EbFUf6T4B9TPL3OK+FYihcwPg1Ol8abypPe0f?= X-MS-Exchange-CrossTenant-Network-Message-Id: 67977f58-f8b5-4ba1-ddf0-08d93cad439f X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jul 2021 16:28:31.2554 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: DjmYlwwnhZeREY6qVlXUqKbxtCqh5HqbRKSpAzLwLOs/LyGhIHFn5NiCHX25T1ecjUE45ErMPm6p4as3W8LI7xlV1PfNVESeJllMzHrPhHM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB4120 X-OriginatorOrg: citrix.com On 01/07/2021 17:23, Olaf Hering wrote: > Am Thu, 1 Jul 2021 16:25:10 +0100 > schrieb Andrew Cooper : > >> -        p->extd.max_leaf = min(p->extd.max_leaf, 0x1cu); >> +        p->extd.max_leaf = 0x80000000 | min(p->extd.max_leaf & 0xffff, >> 0x1cu); > Yes, this fixes it for me. Thanks. Fantastic.  I'll try and do a proper patch in due course. On further thought, I think I'm going to go with the slightly simpler p->extd.max_leaf = min(p->extd.max_leaf, 0x8000001c); This is a policy obtained directly from Xen, which means it is running on a 64bit capable system, which means that 0x80000008 is the lowest number which can possibly exist in extd.max_leaf. ~Andrew From xen-devel-bounces@lists.xenproject.org Thu Jul 01 16:32:35 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 16:32:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148964.275327 (Exim 4.92) (envelope-from ) id 1lyzcB-0005TB-0e; Thu, 01 Jul 2021 16:32:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148964.275327; Thu, 01 Jul 2021 16:32:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyzcA-0005T4-Ti; Thu, 01 Jul 2021 16:32:34 +0000 Received: by outflank-mailman (input) for mailman id 148964; Thu, 01 Jul 2021 16:32:34 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyzcA-0005Sy-5W for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 16:32:34 +0000 Received: from mo4-p00-ob.smtp.rzone.de (unknown [85.215.255.20]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id e8da98a7-81f9-4a80-86bd-e6db86daf426; Thu, 01 Jul 2021 16:32:33 +0000 (UTC) Received: from sender by smtp.strato.de (RZmta 47.28.1 AUTH) with ESMTPSA id 30791cx61GWV7iX (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Thu, 1 Jul 2021 18:32:31 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e8da98a7-81f9-4a80-86bd-e6db86daf426 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1625157152; s=strato-dkim-0002; d=aepfle.de; h=References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Cc:Date: From:Subject:Sender; bh=SZ8Fozes6rdvs8EE03cNo6FUdtEDZhZS+j9Mr6fLabc=; b=M3+6Dnu+8a/OcGv7v7viNn4SWJhYeTg3dC6RZk0YWFvR3V+yE41+hjZmivdl3SYuf0 NEExnm2XaMpEhcfuo+/EGLIIRiNJ5U6PZytg05CfCsZx1JpKYENTPxWN1hbYDNs6UBiV zLkZSndErpXicfyH1LmjbB0OpMYy/VzQOcNcp7hIBcSKvXmzrNW0nCDe7ni9bt+MdYDJ PJSxfXR3M6lUfEAjHRjFrE6Gjp/7XKMP4CGHwbD440CBxrPeNNvSmVXvlHFoMF7vAjVV ytqod8O8jqFDJlxl0t9LIlxlShogKY/HVxKvtY1f/04pcyoDfhPAhLdBie90pXfVjvi1 I1/w== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QLpd5ylWvMDX3y/OuD5rXVisQsBBSIa03sY9BUY2ao0oygRsMfcqA6zjDLeeWXNg==" X-RZG-CLASS-ID: mo00 Date: Thu, 1 Jul 2021 18:32:28 +0200 From: Olaf Hering To: Andrew Cooper Cc: Subject: Re: XEN_SYSCTL_cpu_policy_hvm_default truncates leaf count Message-ID: <20210701183228.1f8fce35.olaf@aepfle.de> In-Reply-To: <967b6463-c1bd-6ced-bec6-bafe02310e09@citrix.com> References: <20210701125623.593fe3ae.olaf@aepfle.de> <20e828c9-e7dc-4401-9307-a6d72eb618d8@citrix.com> <20210701170009.5a8be33f.olaf@aepfle.de> <48cfe27b-70fe-36aa-833a-7d78e205528c@citrix.com> <20210701171819.67968d4d.olaf@aepfle.de> <20210701182303.53756e1e.olaf@aepfle.de> <967b6463-c1bd-6ced-bec6-bafe02310e09@citrix.com> X-Mailer: Claws Mail 2021.05.27 (GTK+ 2.24.32; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/Ty1JdHR.1N6X/Iy9fAyrNi2"; protocol="application/pgp-signature"; micalg=pgp-sha256 --Sig_/Ty1JdHR.1N6X/Iy9fAyrNi2 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Am Thu, 1 Jul 2021 17:28:25 +0100 schrieb Andrew Cooper : > 0x8000001c Dues this need to be tagged as unsigned with a trailing U? Olaf --Sig_/Ty1JdHR.1N6X/Iy9fAyrNi2 Content-Type: application/pgp-signature Content-Description: Digitale Signatur von OpenPGP -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEE97o7Um30LT3B+5b/86SN7mm1DoAFAmDd7hwACgkQ86SN7mm1 DoCzXhAAjFSj9QS1/D0i46vC6isNk/+CkpqcQAgOLlmDgdOxF4EFjufGKXNkKixx XN/ErlxqOK0uyrKFVH58QLJAOIDSdy593WELqc9tu3o3oYxAoyBSFFxol3EORJqr e9iA7Tp2a+4dVmQ3iRXw6s5Zapo4r/G/pKoTapWW/lpH1aG02GwBO+p088T88eTp bkaaaaK+8rKO1la1dPgRqIjhhpXS3o3kCVhEM6tAlbw9VREXQP8ubZ0Larigyn5W TdEJwPrJrBsKqgITfUrY831a/4X/ceqimTe/ZSseY/MA2Py5uWpFJ/GSzFAm4aI/ KxEW3fWY2TIk1eki3SqWDy3e+lsaS+k1A0ut0cVr38gy7LBCaZ80PC2Hvcur/vqW Zizsgu/uV3jwwwc0HFhi6Ukn0/7lZPK4NHtDewsDyzsHjEQUqTLIug7ioYG14a66 RuXdWL/NpIrEID2KNlLjY6isvthW9BAzHUSmwA5rW6pquDjj1ULm43k3Z6c684fP UtFeNmR93iAar4Wn2650hCTpuiKAuruZZw1lNoL+51E3YTGzPQORBw/xyhOPLhNc x9p3e0GFcl2yTpwzHvKYyCkSLI5zWTfFbvTrCMjs9TfOTVP4Kb7/sDPsdYkpYM4C 77PXaGR5elYEeFsfS9zlCllITofCNUZLcJvd3SmD0BV1W5sbEdc= =+Aaz -----END PGP SIGNATURE----- --Sig_/Ty1JdHR.1N6X/Iy9fAyrNi2-- From xen-devel-bounces@lists.xenproject.org Thu Jul 01 16:45:31 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 16:45:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148969.275337 (Exim 4.92) (envelope-from ) id 1lyzoa-0006uj-6l; Thu, 01 Jul 2021 16:45:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148969.275337; Thu, 01 Jul 2021 16:45:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyzoa-0006uc-3o; Thu, 01 Jul 2021 16:45:24 +0000 Received: by outflank-mailman (input) for mailman id 148969; Thu, 01 Jul 2021 16:45:22 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyzoY-0006uW-Rl for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 16:45:22 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id b923b309-da8b-11eb-834c-12813bfff9fa; Thu, 01 Jul 2021 16:45:21 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b923b309-da8b-11eb-834c-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1625157921; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=ZwU/kaaaYYYQFi6JKPF0BJjEhDRHt0Zz/RNYp0r6Jw4=; b=YwxXfbr4QKaHgKvWV9a4TuXqesXWmEwPPdSrTIsweFH9oBxbrNWAB8iZ nth7dk2pkLB/VXOvP9+FJphs1EYLJLJDhSYD0pKPJYH7j5m8B6tlHJhA3 XulpaWJpp2AQIBPcqvCcTdGSVa/NJwEUIzbfCnhD3G2XEMQNoU8MEHOnC s=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: x4UbEOTOCt/EN0W4ahuZCEizoyTjrBKdA67OJj+ehW6gThDWBnpdpnhgEZlyEAXZs/emnv/DO3 DRLVm7WxKM/FIJVxmH12g+onW/f6oty6E+fEpPBaTe2om5Xr1b13vbykLIMydZtGSXmCGeFUnS Mba8I6R63TF0qEdQj9A0D1cxV7h8PsxLeGYceIy3uf8K8dtwyqbiDqStVBscctlYQ2T5K0ZZos MJdh4BwKQ8/rAXFj3cSs4n8NOqLnu5fZGbDv8yVo9JRiIaBwiiDOM6vjuMkhMIcr2mwr7wgYH/ TIo= X-SBRS: 5.1 X-MesageID: 47392510 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:c5dWiakvNne2PxP/O1u4kVnY4nDpDfMqiWdD5ihNYBxZY6Wkfp +V8cjzhCWftN9OYhodcIi7SdO9qXO1z+8X3WBjB8beYOCGghrrEGgG1+ffKlLbakvDH4JmtJ uINpIOc+EYbmIKyPoSgjPIaurIqePvmM/HuQ6d9QYUcehEUdAG0+4TMHf4LqQCfngjOXNPLu v42iMonVqdUEVSSv7+KmgOXuDFqdGOvonhewQ6Cxku7xTLpS+06ZbheiLomSs2Yndq+/MP4G LFmwv26uGIqPeg0CLR0GfV8tB/hMbh8N1eH8aB4/JlbAkEyzzYPbiJaYfy5wzdk9vfsmrCV+ O8/ivICv4Ds085uFvF/ScFlTOQjwrGoEWStWNwyUGT3vARAghKT/apzLgpDCfx+g4uuspx37 lM2H/cv51LDQnYlCC4/NTQUQp2/3DE4EYKgKoWgRVkIMIjQa4UqYJa9F5JGJ0AGC789ekcYa JTJdCZ4PgTa1+ccnvI+mJm2tPEZAV6Iv6qeDlMhiWu6UkZoJm59Tpv+OUP2nMbsJ4tQZhN4O rJdqxuibFVV8cTKaZwHv0IT8e7AnHEBUukChPQHX33UKUcf37doZ/+57s4oOmsZZwT1ZM33J DMSklRu2I+c1/nTceOwJpI+BbQR3jVZ0Ws9il0j6IJy4EUhICbfRGrWRQriY+tsv8fCsrUV7 KoOZpMD/LmJWvqEoBZmxb5R4RTLncXXsETp5IjQFSFrtjQJoCCjJ2uTB/3HsubLd8JYBKMPp IzZkm/GCwb1DHZZpbRummlZ5rCQD2OwbtgVLPX5u4J1cwHPpdC9g4IlF+++saHQAcy+JALQA == X-IronPort-AV: E=Sophos;i="5.83,315,1616472000"; d="scan'208";a="47392510" Date: Thu, 1 Jul 2021 17:45:12 +0100 From: Anthony PERARD To: Olaf Hering CC: , Ian Jackson , "Wei Liu" , Juergen Gross Subject: Re: [PATCH v20210701 33/40] tools: change struct precopy_stats to precopy_stats_t Message-ID: References: <20210701095635.15648-1-olaf@aepfle.de> <20210701095635.15648-34-olaf@aepfle.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20210701095635.15648-34-olaf@aepfle.de> On Thu, Jul 01, 2021 at 11:56:28AM +0200, Olaf Hering wrote: > This will help libxl_save_msgs_gen.pl to copy the struct as a region of memory. > > No change in behavior intented. > > Signed-off-by: Olaf Hering > --- > tools/include/xensaverestore.h | 7 +++---- > tools/libs/saverestore/common.h | 2 +- > tools/libs/saverestore/save.c | 6 +++--- > 3 files changed, 7 insertions(+), 8 deletions(-) > > diff --git a/tools/include/xensaverestore.h b/tools/include/xensaverestore.h > index 0410f0469e..dca0134605 100644 > --- a/tools/include/xensaverestore.h > +++ b/tools/include/xensaverestore.h > @@ -23,18 +23,17 @@ > #define XCFLAGS_DEBUG (1 << 1) > > /* For save's precopy_policy(). */ > -struct precopy_stats I don't think changing the existing API is a good idea. It's probably ok to add a typedef. But can't libxl_save_msgs_gen.pl been able to deal with thing like 'struct precopy_stats' ? It seems to be able to deal with 'unsigned long'. > -{ > +typedef struct { > unsigned int iteration; > unsigned long total_written; > long dirty_count; /* -1 if unknown */ > -}; > +} precopy_stats_t; > Thanks, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Thu Jul 01 17:08:57 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 17:08:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148975.275349 (Exim 4.92) (envelope-from ) id 1lz0BE-0000tM-86; Thu, 01 Jul 2021 17:08:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148975.275349; Thu, 01 Jul 2021 17:08:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lz0BE-0000t9-4u; Thu, 01 Jul 2021 17:08:48 +0000 Received: by outflank-mailman (input) for mailman id 148975; Thu, 01 Jul 2021 17:08:46 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lz0BC-0000t1-CU for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 17:08:46 +0000 Received: from mo4-p01-ob.smtp.rzone.de (unknown [81.169.146.167]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id fde8654e-da8e-11eb-8351-12813bfff9fa; Thu, 01 Jul 2021 17:08:45 +0000 (UTC) Received: from sender by smtp.strato.de (RZmta 47.28.1 AUTH) with ESMTPSA id 30791cx61H8c7rD (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Thu, 1 Jul 2021 19:08:38 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fde8654e-da8e-11eb-8351-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1625159318; s=strato-dkim-0002; d=aepfle.de; h=References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Cc:Date: From:Subject:Sender; bh=LIhm0s7MYVUQghllSXbu6oUayBlInZOsy10OIdm7s0I=; b=SBrVmwUHsTuXkXkTY5WYeyyCWBhZ0q2qkZ0N5BDgJU+LyTvI3Vp064+97g2hk8UivV 8/qu/Yx4VPUElj4Gyw54CjjBt3n9d4W+1GRYqedrWDZuDgBpV/SBIVGX57Eq1Svs9TY7 Z0ru3kIjPLgmD23Ua3YsCA7lEZAWcS5msXfbSyGDjKuJOtqoTVCb+z4s5u/EdMyY5xmj gMAa7OUDfl8dn3vur7+rX2CaJBn0Dq5LGOwRVcWDYSM/GN7yvguurUhCN/FKuOZYt7pj 47/e1dCNh6Qq8z4iO9sJarz3uLMYA+slNn40QN0cRjf5QQ+/FIgMozs8CUvuC78sCgX1 78pg== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QLpd5ylWvMDX3y/OuD5rXVisQsBBSIa03sY9BUY2ao0oygRsMfcqA6zjDLeeWXNg==" X-RZG-CLASS-ID: mo00 Date: Thu, 1 Jul 2021 19:08:31 +0200 From: Olaf Hering To: Anthony PERARD Cc: , Ian Jackson , "Wei Liu" , Juergen Gross Subject: Re: [PATCH v20210701 33/40] tools: change struct precopy_stats to precopy_stats_t Message-ID: <20210701190831.4bee9632.olaf@aepfle.de> In-Reply-To: References: <20210701095635.15648-1-olaf@aepfle.de> <20210701095635.15648-34-olaf@aepfle.de> X-Mailer: Claws Mail 2021.05.27 (GTK+ 2.24.32; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/3dctEgGIi/JgQQnvlhc7Xxj"; protocol="application/pgp-signature"; micalg=pgp-sha256 --Sig_/3dctEgGIi/JgQQnvlhc7Xxj Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Am Thu, 1 Jul 2021 17:45:12 +0100 schrieb Anthony PERARD : > But can't libxl_save_msgs_gen.pl been able to deal with > thing like 'struct precopy_stats' ? It seems to be able to deal with > 'unsigned long'. Yes, this is apparently possible. I have to check why I thought it was required to turn this into a typedef. Right now I do not see the reason in the code comments. Olaf --Sig_/3dctEgGIi/JgQQnvlhc7Xxj Content-Type: application/pgp-signature Content-Description: Digitale Signatur von OpenPGP -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEE97o7Um30LT3B+5b/86SN7mm1DoAFAmDd9o8ACgkQ86SN7mm1 DoBmFw/7BEB4hxB/i2Pgr7FCI7N41L0qjTC5QwSjJhbD3xC5GxULbccTqGUlGlqw zrCXcgMLeauNYQ33EUWLU5q7GqlhIvnK0hTpjJAIdw8AWXINTog0CqQIfYTvPGxR y0wqdUkePVmAugyMy7/zPm6lYTKTrgbcVLgS5nhuSwNW46DXjXJV2Ox0d33wygo6 ThV9Gey/IuIB3wtt9dbJoDr1URWaP+pWX9PTQt4/m1bVdEiYWdO9IBbbQXzbZsa4 xwrgjlplR2uW16CLez4+++T698WkK6nr1wcCqIoNF8Tyx+dZbzdBhNh+qyFofBQ3 3YyPwlP0Do0bEVw0Kyy7CH19gi2th/RBUlJ3JGsNGYN9ip4hOQR9vDCG+TEA9rNs 6Z7/NPySd0HPUQZ4SqVxGJAFWeYpxId6rzgUMI++heE6t0Xb9n04Dxa1AD0FoK7B nmTX5/2TlmTJGu9e7viVabvplRfaXRWRg14txM2Mqc8JvFXjyWGH6kJFpCA3ArrE YolOAuoY8cpXbSQpNIkASx2//Am3XXx1RawZUBsJKrlMcRyhLWohmOt+YAwJEZ8e ZcM41hFjabbSZJxFk+87CDjVMP9l/fZa1ITotgIRQ8NhVCpGYEJ1Pt9wVWIH1rOA h/KjyFDxkHT7rtEGTGBNBnx4V1XQvfMMp11mGMggbTTBgo04B2U= =EGPx -----END PGP SIGNATURE----- --Sig_/3dctEgGIi/JgQQnvlhc7Xxj-- From xen-devel-bounces@lists.xenproject.org Thu Jul 01 17:25:02 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 17:25:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148981.275370 (Exim 4.92) (envelope-from ) id 1lz0Qn-0003MJ-Tq; Thu, 01 Jul 2021 17:24:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148981.275370; Thu, 01 Jul 2021 17:24:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lz0Qn-0003MC-QT; Thu, 01 Jul 2021 17:24:53 +0000 Received: by outflank-mailman (input) for mailman id 148981; Thu, 01 Jul 2021 17:24:52 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lz0Qm-00035P-HO for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 17:24:52 +0000 Received: from mail-wm1-x335.google.com (unknown [2a00:1450:4864:20::335]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id f0c10b64-d8a7-4662-9e9f-01bc1a1ab55f; Thu, 01 Jul 2021 17:24:47 +0000 (UTC) Received: by mail-wm1-x335.google.com with SMTP id a5-20020a7bc1c50000b02901e3bbe0939bso4633198wmj.0 for ; Thu, 01 Jul 2021 10:24:47 -0700 (PDT) Received: from ?IPv6:2a00:23c5:5785:9a01:dd08:98e8:6495:64d2? ([2a00:23c5:5785:9a01:dd08:98e8:6495:64d2]) by smtp.gmail.com with ESMTPSA id o3sm613049wrw.56.2021.07.01.10.24.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 01 Jul 2021 10:24:46 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f0c10b64-d8a7-4662-9e9f-01bc1a1ab55f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:reply-to:subject:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=bM636ttOBoWSgPMiqkDWtkSD1pigvPw7drXBJk2dQSo=; b=CoYAhA25qZuZPHQ03Z3conMZVB/j7nIxyTpV8KAfawMUJcGMdM2D6rJgltGNtKQtg3 Nudzew74AD9NWYs5euIQatfkbrD1P4ZdJjFelHclGcN6HD3itT3LzuUtdyI5or17Oo7M WOUnlUWG/ix7ZxEk5RQEhWxPd3PohJpGrM8dCRCE0kRF9k9+3TIRA2GvzpzEvq8VQDPQ T451NjlwgFDG9QX0dEdb8WYHkyX5VCmgKvqvNrT1Rtao2bMxOwJbCCp5I0fdTnhcaPfT kjBvboXlWxoajNEUbdErN9UHqMlPBQkpBPDF6sD4icsJsGehTGjCNkjZM0M3c+XVFMZJ 42MQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:reply-to:subject:to:cc:references :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=bM636ttOBoWSgPMiqkDWtkSD1pigvPw7drXBJk2dQSo=; b=aVL0R1xjxMBrmyytx5EVVaG3msTUmXci+BHL8FMXRp1BpsSyag6I7XJMVPAlzXazF2 9SBIwA8sx2h1qmNX8ooYYW772t4BMvcBGTHGL348xUJOzjdhxfCb8l/sGXoHh5hZT33L D7oksgxvcCyIIn6Zk+VUhxKHxwhudWtyK4jS3eDzEiHDLb5Z7JVrlFx1YHcCnEqhwgrP uYmTNwF5LX7OYiRuW23p1FdD4L0nfhRgtxiSmNsJkxHMwFwjMyahF4I4JWKYDV95aa8Y bHIqEfEBDuTs4+Ex3lC1hbTCirNJjHH2rBIdF1imI/Z0GCibsXMDHFFL/HvggfKlj8tq j1EA== X-Gm-Message-State: AOAM530MF92Lcr8CrX23LbXYcS23FvsTvjs2k6zZTnmkGZqvBy4eI7F3 LYeT5LKceJ/6A2yk18LRPno= X-Google-Smtp-Source: ABdhPJzR73BRmIIfFijATpWTS27jawGoNo9rHaVB8ejaBTxpMp3GuQyBgjKXZ0J3VDzp6rMyNUNe3Q== X-Received: by 2002:a05:600c:5112:: with SMTP id o18mr797431wms.15.1625160287101; Thu, 01 Jul 2021 10:24:47 -0700 (PDT) From: Paul Durrant X-Google-Original-From: Paul Durrant Reply-To: paul@xen.org Subject: Re: [XEN PATCH v6 18/31] xen: move include/asm-* to include/arch-*/asm To: Anthony PERARD , xen-devel@lists.xenproject.org Cc: Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Tamas K Lengyel , Alexandru Isaila , Petre Pircalabu , Volodymyr Babchuk , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Konrad Rzeszutek Wilk , Ross Lagerwall , Jun Nakajima , Kevin Tian , Lukasz Hawrylko , Bob Eshleman , Alistair Francis , Connor Davis References: <20210701141011.785641-1-anthony.perard@citrix.com> <20210701141011.785641-19-anthony.perard@citrix.com> Message-ID: Date: Thu, 1 Jul 2021 18:24:45 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210701141011.785641-19-anthony.perard@citrix.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 01/07/2021 15:09, Anthony PERARD wrote: > This avoid the need to create the symbolic link "include/asm". > > Signed-off-by: Anthony PERARD Acked-by: Paul Durrant From xen-devel-bounces@lists.xenproject.org Thu Jul 01 17:25:02 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 17:25:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148980.275360 (Exim 4.92) (envelope-from ) id 1lz0Qi-00035c-LX; Thu, 01 Jul 2021 17:24:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148980.275360; Thu, 01 Jul 2021 17:24:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lz0Qi-00035V-Hx; Thu, 01 Jul 2021 17:24:48 +0000 Received: by outflank-mailman (input) for mailman id 148980; Thu, 01 Jul 2021 17:24:47 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lz0Qh-00035P-OC for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 17:24:47 +0000 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 37b6940f-3c0c-4c7d-a8fa-60a10fc43cf1; Thu, 01 Jul 2021 17:24:47 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 0107661406; Thu, 1 Jul 2021 17:24:45 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 37b6940f-3c0c-4c7d-a8fa-60a10fc43cf1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1625160286; bh=9C0/uCMUMnP6PwBqwBxTxBmKbrPiPpORig3xR+otpIo=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=IumK+bakb+BzvaRbTIy5m7Pe4tOdjTxdUWEDtnrq1aMz8LD55FX+Dcm4/b5qq/ZhF GxddFJuuRmQIW5u4kGskSa5tfPaiFbeM3MJ8dUtmp1+WTk5PiPiSLNQX7SYr0VdoVW DBCF3/871//LY+dXsvQ94HRNH0iCDCBJx5vIPUKFSBSXez2VIEZRMRwsdxc5vX20AA 0SFrLwatHHhKN0BBeJf+WB/yi8OdYJM6Q/1WegZ20t4tXo835Wyn3I4CRMxL+0Qncs OShgkVl+gklNCRXx7RnryhEIDXPdw4I2qAlDqmAKf66BdIJSXzOcmC44XGIrBk3y8B 0XQC+D99s2LUQ== Date: Thu, 1 Jul 2021 10:24:45 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Luca Fancellu cc: Stefano Stabellini , xen-devel@lists.xenproject.org, Bertrand Marquis , wei.chen@arm.com, Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Julien Grall , Wei Liu Subject: Re: [PATCH v6 8/9] docs: hypercalls sphinx skeleton for generated html In-Reply-To: Message-ID: References: <20210510084105.17108-1-luca.fancellu@arm.com> <20210510084105.17108-9-luca.fancellu@arm.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Thu, 1 Jul 2021, Luca Fancellu wrote: > > On 24 Jun 2021, at 00:34, Stefano Stabellini wrote: > > > > On Mon, 10 May 2021, Luca Fancellu wrote: > >> Create a skeleton for the documentation about hypercalls > >> > >> Signed-off-by: Luca Fancellu > >> --- > >> v6 changes: > >> - Now every platform has the same sections in .rst files > >> --- > >> .gitignore | 1 + > >> docs/Makefile | 4 ++++ > >> docs/hypercall-interfaces/arm32.rst | 32 ++++++++++++++++++++++++++ > >> docs/hypercall-interfaces/arm64.rst | 32 ++++++++++++++++++++++++++ > >> docs/hypercall-interfaces/index.rst.in | 7 ++++++ > >> docs/hypercall-interfaces/x86_64.rst | 32 ++++++++++++++++++++++++++ > >> docs/index.rst | 8 +++++++ > >> 7 files changed, 116 insertions(+) > >> create mode 100644 docs/hypercall-interfaces/arm32.rst > >> create mode 100644 docs/hypercall-interfaces/arm64.rst > >> create mode 100644 docs/hypercall-interfaces/index.rst.in > >> create mode 100644 docs/hypercall-interfaces/x86_64.rst > >> > >> diff --git a/.gitignore b/.gitignore > >> index d271e0ce6a..a9aab120ae 100644 > >> --- a/.gitignore > >> +++ b/.gitignore > >> @@ -64,6 +64,7 @@ docs/xen.doxyfile > >> docs/xen.doxyfile.tmp > >> docs/xen-doxygen/doxygen_include.h > >> docs/xen-doxygen/doxygen_include.h.tmp > >> +docs/hypercall-interfaces/index.rst > >> extras/mini-os* > >> install/* > >> stubdom/*-minios-config.mk > >> diff --git a/docs/Makefile b/docs/Makefile > >> index 2f784c36ce..b02c3dfb79 100644 > >> --- a/docs/Makefile > >> +++ b/docs/Makefile > >> @@ -61,6 +61,9 @@ build: html txt pdf man-pages figs > >> sphinx-html: $(DOXY_DEPS) $(DOXY_LIST_SOURCES) > >> ifneq ($(SPHINXBUILD),no) > >> $(DOXYGEN) xen.doxyfile > >> + @echo "Generating hypercall-interfaces/index.rst" > >> + @sed -e "s,@XEN_TARGET_ARCH@,$(XEN_TARGET_ARCH),g" \ > >> + hypercall-interfaces/index.rst.in > hypercall-interfaces/index.rst > > > > Hi Stefano, > > > I take that this means we are going to generate docs only for the > > architecture that we are building? So if we build for x86, then the docs > > are for x86 (no arm32 and arm64 docs.) Is that right? > > > > Is that because Doxygen relies somehow on the compiler to extract data? > > I am asking because if Doxygen doesn't rely on the compiler, then it > > could probably generate the docs for all architectures in one go? > > Doxygen rely on the headers generated from the KConfig system to properly solve > the preprocessor step, for that reason here we need that. > > It can be improved for sure, but it needs to call a defconfig for each architecture and > have separate Doxygen-output folders for each one, then on the rst files you can choose > from which arch you want the data. > > I think this step can be done in a future serie. OK. Maybe add a note about this to one of the commit messages. > > > > > > > >> XEN_ROOT=$(realpath $(XEN_ROOT)) $(SPHINXBUILD) -b html . sphinx/html > >> else > >> @echo "Sphinx is not installed; skipping sphinx-html documentation." > >> @@ -108,6 +111,7 @@ clean: clean-man-pages > >> rm -f xen.doxyfile.tmp > >> rm -f xen-doxygen/doxygen_include.h > >> rm -f xen-doxygen/doxygen_include.h.tmp > >> + rm -f hypercall-interfaces/index.rst > >> > >> .PHONY: distclean > >> distclean: clean > >> diff --git a/docs/hypercall-interfaces/arm32.rst b/docs/hypercall-interfaces/arm32.rst > >> new file mode 100644 > >> index 0000000000..6762d9fc7c > >> --- /dev/null > >> +++ b/docs/hypercall-interfaces/arm32.rst > >> @@ -0,0 +1,32 @@ > >> +.. SPDX-License-Identifier: CC-BY-4.0 > >> + > >> +Hypercall Interfaces - arm32 > >> +============================ > >> + > >> +Starting points > >> +--------------- > >> +.. toctree:: > >> + :maxdepth: 2 > >> + > >> + > >> + > >> +Functions > >> +--------- > >> + > >> + > >> +Structs > >> +------- > >> + > >> + > >> +Enums and sets of #defines > >> +-------------------------- > >> + > >> + > >> +Typedefs > >> +-------- > >> + > >> + > >> +Enum values and individual #defines > >> +----------------------------------- > >> + > >> + > >> diff --git a/docs/hypercall-interfaces/arm64.rst b/docs/hypercall-interfaces/arm64.rst > >> new file mode 100644 > >> index 0000000000..5e701a2adc > >> --- /dev/null > >> +++ b/docs/hypercall-interfaces/arm64.rst > >> @@ -0,0 +1,32 @@ > >> +.. SPDX-License-Identifier: CC-BY-4.0 > >> + > >> +Hypercall Interfaces - arm64 > >> +============================ > >> + > >> +Starting points > >> +--------------- > >> +.. toctree:: > >> + :maxdepth: 2 > >> + > >> + > >> + > >> +Functions > >> +--------- > >> + > >> + > >> +Structs > >> +------- > >> + > >> + > >> +Enums and sets of #defines > >> +-------------------------- > >> + > >> + > >> +Typedefs > >> +-------- > >> + > >> + > >> +Enum values and individual #defines > >> +----------------------------------- > >> + > >> + > >> diff --git a/docs/hypercall-interfaces/index.rst.in b/docs/hypercall-interfaces/index.rst.in > >> new file mode 100644 > >> index 0000000000..e4dcc5db8d > >> --- /dev/null > >> +++ b/docs/hypercall-interfaces/index.rst.in > >> @@ -0,0 +1,7 @@ > >> +.. SPDX-License-Identifier: CC-BY-4.0 > >> + > >> +Hypercall Interfaces > >> +==================== > >> + > >> +.. toctree:: > >> + @XEN_TARGET_ARCH@ > >> diff --git a/docs/hypercall-interfaces/x86_64.rst b/docs/hypercall-interfaces/x86_64.rst > >> new file mode 100644 > >> index 0000000000..59e948900c > >> --- /dev/null > >> +++ b/docs/hypercall-interfaces/x86_64.rst > >> @@ -0,0 +1,32 @@ > >> +.. SPDX-License-Identifier: CC-BY-4.0 > >> + > >> +Hypercall Interfaces - x86_64 > >> +============================= > >> + > >> +Starting points > >> +--------------- > >> +.. toctree:: > >> + :maxdepth: 2 > >> + > >> + > >> + > >> +Functions > >> +--------- > >> + > >> + > >> +Structs > >> +------- > >> + > >> + > >> +Enums and sets of #defines > >> +-------------------------- > >> + > >> + > >> +Typedefs > >> +-------- > >> + > >> + > >> +Enum values and individual #defines > >> +----------------------------------- > >> + > >> + > >> diff --git a/docs/index.rst b/docs/index.rst > >> index b75487a05d..52226a42d8 100644 > >> --- a/docs/index.rst > >> +++ b/docs/index.rst > >> @@ -53,6 +53,14 @@ kind of development environment. > >> hypervisor-guide/index > >> > >> > >> +Hypercall Interfaces documentation > >> +---------------------------------- > >> + > >> +.. toctree:: > >> + :maxdepth: 2 > >> + > >> + hypercall-interfaces/index > >> + > >> Miscellanea > >> ----------- > >> > >> -- > >> 2.17.1 > From xen-devel-bounces@lists.xenproject.org Thu Jul 01 17:26:29 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 17:26:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148987.275383 (Exim 4.92) (envelope-from ) id 1lz0SK-0004Gf-Ae; Thu, 01 Jul 2021 17:26:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148987.275383; Thu, 01 Jul 2021 17:26:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lz0SK-0004GY-4z; Thu, 01 Jul 2021 17:26:28 +0000 Received: by outflank-mailman (input) for mailman id 148987; Thu, 01 Jul 2021 17:26:27 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lz0SJ-0004GD-8w for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 17:26:27 +0000 Received: from mail-pg1-x536.google.com (unknown [2607:f8b0:4864:20::536]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 5a742286-a903-48e6-a2e0-21818705cd04; Thu, 01 Jul 2021 17:26:26 +0000 (UTC) Received: by mail-pg1-x536.google.com with SMTP id d12so6739044pgd.9 for ; Thu, 01 Jul 2021 10:26:26 -0700 (PDT) Received: from ?IPv6:2602:4b:a45e:ca01::9? ([2602:4b:a45e:ca01::9]) by smtp.gmail.com with ESMTPSA id 195sm582873pfw.133.2021.07.01.10.26.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 01 Jul 2021 10:26:25 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5a742286-a903-48e6-a2e0-21818705cd04 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:organization:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=puxaSWmR8dmzghTaq+DldI0mhH3+zGEkF2xlex2SX4Q=; b=UXU9U2NdEUjg94KzE69NDcWVVpTV8Eyi8ROyPNW2c39AtFlt7eXEQadQeHlu56Lsv+ SUHAzZA9Jnsm7KaGSmGskyNKdyE4dXockf+63snrMghLbFnnXyJ/483cHpsuF2lr/AOz P77YoSQMz2zKICzPoEIe0lmm5w+iu36g+dI1XjKeCHrMnEKzXmPeRJ30aF0nSbyEDpWV Wqo6PPCyJrA63v6emMUxwO+W4HYBiPMUum3q6JZaFEJ6V6XDlMaIYfmJmIpbcVQUZFRy jiiBDM3hlezav5GP7GdgdTVe3Kcz3yecN2xnLHkr5gXDTqh24nfnhFf9U0QMMcmAdpfC txsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=puxaSWmR8dmzghTaq+DldI0mhH3+zGEkF2xlex2SX4Q=; b=PIXsK6oYWZY4Vm5jeXymfGUFZneDDhnk0sBTOsdQscgla7GbwEFO8ISJOp6jfu/6uu r/HUJAxSM6+aR9kMfhmjPw/duy8u7OmcnXDTmTIpziTLLAqeq+QaNZrIMm326656jhhx ViNnH5eWJPwvbqO3PM0NUvK+K2GdaImMW4JzqEZ+x3VlYDVoBy47689S4+blK1OH9CWJ JTpdh/7R3ZlzjL/H47yMFL9lAvDzM3305QgUCwytYv0IIkasE/MwF6Qd8GCOEA8ogd7G iZxuwkcQeEIO2NQgjoEK2DBP9oF7IgKONTnEFOPXZnxSk7lKhi3OAZtdpLKM00G/OwmW 37Rw== X-Gm-Message-State: AOAM533yqQ+Zd8Mnb1sR1THaQy7NLwzjgWc2EZ+ut9LNzfKiWYsHz4ZI K1q2OY8DfH4jTAAWPPjHUp0= X-Google-Smtp-Source: ABdhPJxphjOfc/JZOSY1gk6URvPa4YBCzTNdtVQUy1Bc7b1e9ZtfVks+RUPKNCuJKNkzxbWvDEqEXQ== X-Received: by 2002:aa7:8884:0:b029:307:4e14:14c9 with SMTP id z4-20020aa788840000b02903074e1414c9mr790039pfe.62.1625160385619; Thu, 01 Jul 2021 10:26:25 -0700 (PDT) Subject: Re: [XEN PATCH v6 18/31] xen: move include/asm-* to include/arch-*/asm To: Anthony PERARD , xen-devel@lists.xenproject.org Cc: Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Tamas K Lengyel , Alexandru Isaila , Petre Pircalabu , Volodymyr Babchuk , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Konrad Rzeszutek Wilk , Ross Lagerwall , Paul Durrant , Jun Nakajima , Kevin Tian , Lukasz Hawrylko , Alistair Francis , Connor Davis References: <20210701141011.785641-1-anthony.perard@citrix.com> <20210701141011.785641-19-anthony.perard@citrix.com> From: Bob Eshleman Organization: Vates SAS Message-ID: Date: Thu, 1 Jul 2021 10:26:22 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: <20210701141011.785641-19-anthony.perard@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Hey Anthony, > diff --git a/MAINTAINERS b/MAINTAINERS > index 8a52a03969fe..03a5553116a8 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > -F: xen/include/asm-arm/ > +F: xen/include/arch-arm/ ... snip ... > -F: xen/include/asm-x86/ > +F: xen/include/arch-x86/ It looks like riscv will also need the same in its "xen/include/asm-riscv/" F entry. Thanks -- Bobby Eshleman SE at Vates SAS From xen-devel-bounces@lists.xenproject.org Thu Jul 01 17:34:39 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 17:34:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.148995.275392 (Exim 4.92) (envelope-from ) id 1lz0aA-0005jZ-3I; Thu, 01 Jul 2021 17:34:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148995.275392; Thu, 01 Jul 2021 17:34:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lz0aA-0005jS-0A; Thu, 01 Jul 2021 17:34:34 +0000 Received: by outflank-mailman (input) for mailman id 148995; Thu, 01 Jul 2021 17:34:32 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lz0a8-0005jI-OU; Thu, 01 Jul 2021 17:34:32 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lz0a8-00026y-Jg; Thu, 01 Jul 2021 17:34:32 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lz0a8-0008OT-A9; Thu, 01 Jul 2021 17:34:32 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lz0a8-0007d8-9a; Thu, 01 Jul 2021 17:34:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Cm/Tba5D96BQmgvO4+zA9lHmk99fIp/2NNakT155y+0=; b=LmuMgRw4wGAFPAGaunkCXuk211 fla2YjyBA57LbWHU0vXIElqhC2gogtoBUQNuWDJcjas+VCnG+dgOzOERotd2JXxf+YQnI2vWhUpAd C0roVDKV9MxxN/kx2mRZGSV0Qq/BWyQ6yiJPK/+PDpI7+adEo5sk7aQyANGlyJEy93Hg=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 163210: regressions - FAIL X-Osstest-Failures: ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:debian-hvm-install:fail:regression ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:debian-hvm-install:fail:regression X-Osstest-Versions-This: ovmf=bb33c27fbed6c1ed39d243bedd407e8e93a2b3a9 X-Osstest-Versions-That: ovmf=c410ad4da4b7785170d3d42a3ba190c2caac6feb From: osstest service owner Date: Thu, 01 Jul 2021 17:34:32 +0000 flight 163210 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/163210/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 162359 test-amd64-amd64-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 162359 version targeted for testing: ovmf bb33c27fbed6c1ed39d243bedd407e8e93a2b3a9 baseline version: ovmf c410ad4da4b7785170d3d42a3ba190c2caac6feb Last test of basis 162359 2021-06-04 03:40:08 Z 27 days Failing since 162368 2021-06-04 15:42:59 Z 27 days 69 attempts Testing same since 163205 2021-07-01 00:10:20 Z 0 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Abner Chang Agrawal, Sachin Alexandru Elisei Anthony PERARD Ard Biesheuvel Daniel Schaefer Daoxiang Li Dov Murik DunTan gaoliming Guo Dong Hao A Wu Jian J Wang Kaaira Gupta Ken Lautner Kenneth Lautner Kun Qin Laszlo Ersek Leif Lindholm Liming Gao Loo Tung Lun Loo, Tung Lun Manickavasakam Karpagavinayagam Maurice Ma Ni, Ray Patrick Rudolph Pierre Gondois Ray Ni Rebecca Cran Rebecca Cran Sachin Agrawal Sami Mujawar Scottie Kuo Sean Brogan Sean Brogan Sumana Venur Sunil V L xueshengfeng Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-i386-xl-qemuu-ovmf-amd64 fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 3191 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Jul 01 17:36:45 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 17:36:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149002.275407 (Exim 4.92) (envelope-from ) id 1lz0cG-0006PD-M7; Thu, 01 Jul 2021 17:36:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149002.275407; Thu, 01 Jul 2021 17:36:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lz0cG-0006P6-Iy; Thu, 01 Jul 2021 17:36:44 +0000 Received: by outflank-mailman (input) for mailman id 149002; Thu, 01 Jul 2021 17:36:44 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lz0cG-0006P0-0s for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 17:36:44 +0000 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id e5bd724f-da92-11eb-835a-12813bfff9fa; Thu, 01 Jul 2021 17:36:42 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 348F36138C; Thu, 1 Jul 2021 17:36:41 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e5bd724f-da92-11eb-835a-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1625161001; bh=ifTalwTLDbilj/hbcd+BpJi1t2wEHaUzCH7wDp147tU=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=WP1DaP9iCaHruWwoXcaetrJwzcAxMFS+ilw//fhmsk/NdfiFIypgDX/HuM7NfvviQ 4L8T0WQLhGJJPHOgMZQPzD5wNdocLAsiARnwleKPWQgZx80W5w4G6gMKaXcwdn/S6n zB3/ECvedFJcxr2jay3ZBE7yYwmHr1y7srtEG9v7MiHHX/OFe93x1JbH6/FzoRXFFB irqvOgFb7VcGRIP+/tu8ZeVi/hvWeWe70vfdrz64OuGnypkoxXSNhL2xc3NVbO7PNg o+PFzj9YZdmtMoV+YEwzXzgRZtMiJERzjDtvCEezVCquKr9DZseYcMbDhEoPj/FmEO Wh/ekf5rPQbHA== Date: Thu, 1 Jul 2021 10:36:40 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Luca Fancellu cc: Stefano Stabellini , xen-devel@lists.xenproject.org, Bertrand Marquis , wei.chen@arm.com, Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Julien Grall , Wei Liu Subject: Re: [PATCH v6 6/9] docs: add doxygen preprocessor and related files In-Reply-To: <5D3534B9-30AC-484F-B2CF-02822D3D1226@arm.com> Message-ID: References: <20210510084105.17108-1-luca.fancellu@arm.com> <20210510084105.17108-7-luca.fancellu@arm.com> <5D3534B9-30AC-484F-B2CF-02822D3D1226@arm.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-1068870486-1625161001=:9437" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-1068870486-1625161001=:9437 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Thu, 1 Jul 2021, Luca Fancellu wrote: > > On 23 Jun 2021, at 23:03, Stefano Stabellini wrote: > > > > On Mon, 10 May 2021, Luca Fancellu wrote: > >> Add preprocessor called by doxygen before parsing headers, > >> it will include in every header a doxygen_include.h file > >> that provides missing defines and includes that are > >> usually passed by the compiler. > >> > >> Add doxy_input.list that is a text file containing the > >> relative path to the source code file to be parsed by > >> doxygen. The path sould be relative to the xen folder: > >> E.g. xen/include/public/grant_table.h > >> > >> Signed-off-by: Luca Fancellu > >> --- > >> docs/xen-doxygen/doxy-preprocessor.py | 110 ++++++++++++++++++++++++++ > >> docs/xen-doxygen/doxy_input.list | 0 > >> docs/xen-doxygen/doxygen_include.h.in | 32 ++++++++ > >> 3 files changed, 142 insertions(+) > >> create mode 100755 docs/xen-doxygen/doxy-preprocessor.py > >> create mode 100644 docs/xen-doxygen/doxy_input.list > >> create mode 100644 docs/xen-doxygen/doxygen_include.h.in > >> > >> diff --git a/docs/xen-doxygen/doxy-preprocessor.py b/docs/xen-doxygen/doxy-preprocessor.py > >> new file mode 100755 > >> index 0000000000..496899d8e6 > >> --- /dev/null > >> +++ b/docs/xen-doxygen/doxy-preprocessor.py > >> @@ -0,0 +1,110 @@ > >> +#!/usr/bin/python3 > >> +# > >> +# Copyright (c) 2021, Arm Limited. > >> +# > >> +# SPDX-License-Identifier: GPL-2.0 > >> +# > >> + > >> +import os, sys, re > >> + > >> + > >> +# Variables that holds the preprocessed header text > >> +output_text = "" > >> +header_file_name = "" > >> + > >> +# Variables to enumerate the anonymous structs/unions > >> +anonymous_struct_count = 0 > >> +anonymous_union_count = 0 > >> + > >> + > >> +def error(text): > >> + sys.stderr.write("{}\n".format(text)) > >> + sys.exit(1) > >> + > >> + > >> +def write_to_output(text): > >> + sys.stdout.write(text) > >> + > >> + > >> +def insert_doxygen_header(text): > >> + # Here the strategy is to insert the #include in the > >> + # first line of the header > >> + abspath = os.path.dirname(os.path.abspath(__file__)) > >> + text += "#include \"{}/doxygen_include.h\"\n".format(abspath) > >> + > >> + return text > >> + > >> + > >> +def enumerate_anonymous(match): > >> + global anonymous_struct_count > >> + global anonymous_union_count > >> + > >> + if "struct" in match.group(1): > >> + label = "anonymous_struct_%d" % anonymous_struct_count > >> + anonymous_struct_count += 1 > >> + else: > >> + label = "anonymous_union_%d" % anonymous_union_count > >> + anonymous_union_count += 1 > >> + > >> + return match.group(1) + " " + label + " {" > >> + > >> + > >> +def manage_anonymous_structs_unions(text): > >> + # Match anonymous unions/structs with this pattern: > >> + # struct/union { > >> + # [...] > >> + # > >> + # and substitute it in this way: > >> + # > >> + # struct anonymous_struct_# { > >> + # [...] > >> + # or > >> + # union anonymous_union_# { > >> + # [...] > >> + # where # is a counter starting from zero, different between structs and > >> + # unions > >> + # > >> + # We don't count anonymous union/struct that are part of a typedef because > >> + # they don't create any issue for doxygen > >> + text = re.sub( > >> + "(? >> + enumerate_anonymous, > >> + text, > >> + flags=re.S > >> + ) > > Hi Stefano, > > > > > My python is a bit rusty but I thought this is really clever! > > > > One question: given that anonymous_struct_count is local per file being > > processed, it always starts at 0 for each header. I think that is > > actually better from a documentation readability point of view. > > > > However, is it possible that Doxygen gets confused in a case where we > > can multiple "struct anonymous_struct_0", e.g. one for grant_table.h, > > one for event_channel.h, etc. ? > > Yes this is a very good point, I did some experiment and it can happen, however so far we didn’t notice any > problem because all the anonymous union/struct were part of other data structure, in that case there is no > problem at all because we have upper_data_structure::anonymous_{struct/union}_0/1/2… > > So given the fact that is difficult to have clash, I would say we can handle any future case separately. > > Having a global numbering can solve the issue but because the script is called separately for each header, > Implementing it will involve some changes, there should be a file to maintain the number across invocation > and so on. > > Let me know what do you think about that and if in your opinion we can proceed the way it is now. I think anonymous union/struct are always part of another data struct in our headers, so we shouldn't have a problem. I think we can get away without a global numbering system. Maybe you should add a note about this limitation in the commit message or an in-code comment. --8323329-1068870486-1625161001=:9437-- From xen-devel-bounces@lists.xenproject.org Thu Jul 01 17:43:20 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 17:43:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149008.275417 (Exim 4.92) (envelope-from ) id 1lz0ia-0007pL-DL; Thu, 01 Jul 2021 17:43:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149008.275417; Thu, 01 Jul 2021 17:43:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lz0ia-0007pE-A6; Thu, 01 Jul 2021 17:43:16 +0000 Received: by outflank-mailman (input) for mailman id 149008; Thu, 01 Jul 2021 17:43:14 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lz0iY-0007os-RA for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 17:43:14 +0000 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id ce647b15-da93-11eb-835a-12813bfff9fa; Thu, 01 Jul 2021 17:43:12 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 960E9613CF; Thu, 1 Jul 2021 17:43:11 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ce647b15-da93-11eb-835a-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1625161392; bh=n3cChlAKPWbsfGn3St/MEGP7YDIKX5dMWBEnm3z0uGI=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=ZQVoGOWLkJlm7to26A7enQV1QMXZY4dVC6mwxEd1WOf1hkO5JBQ17zABeMU4T4kqO oHX1C+mIJmu+Wlpv7GiIRfmsWUD5Vx1ceAbx1z5MKykhtjtW8mgPP6I4K5MbiGRV7C fGwSJHIo9euM/qgihWrsClb12IEbKylyPM1h+vh1chABxhZNazTtlr1BftYJbRPJ0s TpgcOPX4aqHsCT8xFmZkbSXQbYoOQTklnUIT5UVGL+wDxKNZFad53XX1Xf3udR20k+ ThnqldElZvrw7HgZhfAqcTozT0Y6Q/V+yxCNIL0QAAu8ZHzkuvWgc+VuoYR10ZGkps Ab121NZ+6hKOQ== Date: Thu, 1 Jul 2021 10:43:11 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Luca Fancellu cc: Stefano Stabellini , xen-devel@lists.xenproject.org, Bertrand Marquis , wei.chen@arm.com, Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Julien Grall , Wei Liu Subject: Re: [PATCH v6 7/9] docs: Change Makefile and sphinx configuration for doxygen In-Reply-To: <1FC1E8DF-8AED-4ABD-BE9A-DBBD9D66EDBB@arm.com> Message-ID: References: <20210510084105.17108-1-luca.fancellu@arm.com> <20210510084105.17108-8-luca.fancellu@arm.com> <1FC1E8DF-8AED-4ABD-BE9A-DBBD9D66EDBB@arm.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-683733543-1625161391=:9437" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-683733543-1625161391=:9437 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Thu, 1 Jul 2021, Luca Fancellu wrote: > > On 24 Jun 2021, at 00:33, Stefano Stabellini wrote: > > > > On Mon, 10 May 2021, Luca Fancellu wrote: > >> Modify docs/Makefile to call doxygen and generate sphinx > >> html documentation given the doxygen XML output. > >> > >> Modify docs/conf.py sphinx configuration file to setup > >> the breathe extension that works as bridge between > >> sphinx and doxygen. > >> > >> Add some files to the .gitignore to ignore some > >> generated files for doxygen. > >> > >> Signed-off-by: Luca Fancellu > >> --- > >> .gitignore | 6 ++++++ > >> docs/Makefile | 42 +++++++++++++++++++++++++++++++++++++++--- > >> docs/conf.py | 48 +++++++++++++++++++++++++++++++++++++++++++++--- > >> 3 files changed, 90 insertions(+), 6 deletions(-) > >> > >> diff --git a/.gitignore b/.gitignore > >> index 1c2fa1530b..d271e0ce6a 100644 > >> --- a/.gitignore > >> +++ b/.gitignore > >> @@ -58,6 +58,12 @@ docs/man7/ > >> docs/man8/ > >> docs/pdf/ > >> docs/txt/ > >> +docs/doxygen-output > >> +docs/sphinx > >> +docs/xen.doxyfile > >> +docs/xen.doxyfile.tmp > >> +docs/xen-doxygen/doxygen_include.h > >> +docs/xen-doxygen/doxygen_include.h.tmp > >> extras/mini-os* > >> install/* > >> stubdom/*-minios-config.mk > >> diff --git a/docs/Makefile b/docs/Makefile > >> index 8de1efb6f5..2f784c36ce 100644 > >> --- a/docs/Makefile > >> +++ b/docs/Makefile > >> @@ -17,6 +17,18 @@ TXTSRC-y := $(sort $(shell find misc -name '*.txt' -print)) > >> > >> PANDOCSRC-y := $(sort $(shell find designs/ features/ misc/ process/ specs/ \( -name '*.pandoc' -o -name '*.md' \) -print)) > >> > >> +# Directory in which the doxygen documentation is created > >> +# This must be kept in sync with breathe_projects value in conf.py > >> +DOXYGEN_OUTPUT = doxygen-output > >> + > >> +# Doxygen input headers from xen-doxygen/doxy_input.list file > >> +DOXY_LIST_SOURCES != cat "xen-doxygen/doxy_input.list" > >> +DOXY_LIST_SOURCES := $(realpath $(addprefix $(XEN_ROOT)/,$(DOXY_LIST_SOURCES))) > > Hi Stefano, > > > > > I cannot find exactly who is populating doxy_input.list. I can see it is > > empty in patch #6. Does it get populated during the build? > > doxy_input.list is the only file that should be modified by the developer when he/she wants to add documentation > for a new file to be parsed by Doxygen, in my patch about documenting grant_tables.h you can see I add > there the path “xen/include/public/grant_table.h" OK, thanks. I missed that addition. > > > >> +DOXY_DEPS := xen.doxyfile \ > >> + xen-doxygen/mainpage.md \ > >> + xen-doxygen/doxygen_include.h > >> + > >> # Documentation targets > >> $(foreach i,$(MAN_SECTIONS), \ > >> $(eval DOC_MAN$(i) := $(patsubst man/%.$(i),man$(i)/%.$(i), \ > >> @@ -46,8 +58,28 @@ all: build > >> build: html txt pdf man-pages figs > >> > >> .PHONY: sphinx-html > >> -sphinx-html: > >> - sphinx-build -b html . sphinx/html > >> +sphinx-html: $(DOXY_DEPS) $(DOXY_LIST_SOURCES) > >> +ifneq ($(SPHINXBUILD),no) > > > > This check on SPHINXBUILD is new, it wasn't there before. Why do we need > > it now? We are not really changing anything in regards to Sphinx, just > > adding Doxygen support. Or was it a mistake that it was missing even > > before this patch? > > Yes this is new, I saw that we didn’t look if sphinx was installed in the system, so now we did In that case, I think anything related to SPHINXBUILD and whether sphinx is installed or not, should be a separate patch at the beginning of the series. It could be committed independently before the rest of the series. When we get to this patch, SPHINXBUILD should be already there. > >> + $(DOXYGEN) xen.doxyfile > >> + XEN_ROOT=$(realpath $(XEN_ROOT)) $(SPHINXBUILD) -b html . sphinx/html > >> +else > >> + @echo "Sphinx is not installed; skipping sphinx-html documentation." > >> +endif > >> + > >> +xen.doxyfile: xen.doxyfile.in xen-doxygen/doxy_input.list > >> + @echo "Generating $@" > >> + @sed -e "s,@XEN_BASE@,$(realpath $(XEN_ROOT)),g" $< \ > >> + | sed -e "s,@DOXY_OUT@,$(DOXYGEN_OUTPUT),g" > $@.tmp > >> + @$(foreach inc,\ > >> + $(DOXY_LIST_SOURCES),\ > >> + echo "INPUT += \"$(inc)\"" >> $@.tmp; \ > >> + ) > >> + mv $@.tmp $@ > >> + > >> +xen-doxygen/doxygen_include.h: xen-doxygen/doxygen_include.h.in > >> + @echo "Generating $@" > >> + @sed -e "s,@XEN_BASE@,$(realpath $(XEN_ROOT)),g" $< > $@.tmp > >> + @mv $@.tmp $@ > > > > Is the absolute path required? If not, we can probably get rid of this > > generation step and simply have the relative path in > > xen-doxygen/doxygen_include.h. I think this could apply to > > xen.doxyfile.in above. > > Unfortunately yes, the doxygen_include.h is a file that is included in every documented header before > starting the doxygen parser, since we don’t have all the headers in one path, it is impossible to have here > a relative path that is good for every header in Xen. OK :-/ > > > > > >> .PHONY: html > >> html: $(DOC_HTML) html/index.html > >> @@ -71,7 +103,11 @@ clean: clean-man-pages > >> $(MAKE) -C figs clean > >> rm -rf .word_count *.aux *.dvi *.bbl *.blg *.glo *.idx *~ > >> rm -rf *.ilg *.log *.ind *.toc *.bak *.tmp core > >> - rm -rf html txt pdf sphinx/html > >> + rm -rf html txt pdf sphinx $(DOXYGEN_OUTPUT) > >> + rm -f xen.doxyfile > >> + rm -f xen.doxyfile.tmp > >> + rm -f xen-doxygen/doxygen_include.h > >> + rm -f xen-doxygen/doxygen_include.h.tmp > >> > >> .PHONY: distclean > >> distclean: clean > >> diff --git a/docs/conf.py b/docs/conf.py > >> index 50e41501db..a48de42331 100644 > >> --- a/docs/conf.py > >> +++ b/docs/conf.py > >> @@ -13,13 +13,17 @@ > >> # add these directories to sys.path here. If the directory is relative to the > >> # documentation root, use os.path.abspath to make it absolute, like shown here. > >> # > >> -# import os > >> -# import sys > >> +import os > >> +import sys > >> # sys.path.insert(0, os.path.abspath('.')) > >> > >> > >> # -- Project information ----------------------------------------------------- > >> > >> +if "XEN_ROOT" not in os.environ: > >> + sys.exit("$XEN_ROOT environment variable undefined.") > >> +XEN_ROOT = os.path.abspath(os.environ["XEN_ROOT"]) > >> + > >> project = u'Xen' > >> copyright = u'2019, The Xen development community' > >> author = u'The Xen development community' > >> @@ -35,6 +39,7 @@ try: > >> xen_subver = line.split(u"=")[1].strip() > >> elif line.startswith(u"export XEN_EXTRAVERSION"): > >> xen_extra = line.split(u"=")[1].split(u"$", 1)[0].strip() > >> + > > > > spurious change? > > I think I’ve intentionally added a new line to separate the code from the except: below, > but if it is a problem I can remove it Better to remove it or to move it to a separate patch > > > >> except: > >> pass > >> finally: > >> @@ -44,6 +49,15 @@ finally: > >> else: > >> version = release = u"unknown version" > >> > >> +try: > >> + xen_doxygen_output = None > >> + > >> + for line in open(u"Makefile"): > >> + if line.startswith(u"DOXYGEN_OUTPUT"): > >> + xen_doxygen_output = line.split(u"=")[1].strip() > >> +except: > >> + sys.exit("DOXYGEN_OUTPUT variable undefined.") > > > > This is a bit strange: isn't there a better way to get the > > DOXYGEN_OUTPUT variable than reading the Makefile? > > > > At that point I think it would be better to define DOXYGEN_OUTPUT a > > second time in conf.py. But maybe it could be passed as an evironmental > > variable? > > Yes we could pass it as an environment variable as we do with XEN_ROOT, > I will fix it in a next release. Great > > > >> # -- General configuration --------------------------------------------------- > >> > >> # If your documentation needs a minimal Sphinx version, state it here. > >> @@ -53,7 +67,8 @@ needs_sphinx = '1.4' > >> # Add any Sphinx extension module names here, as strings. They can be > >> # extensions coming with Sphinx (named 'sphinx.ext.*') or your custom > >> # ones. > >> -extensions = [] > >> +# breathe -> extension that integrates doxygen xml output with sphinx > >> +extensions = ['breathe'] > >> > >> # Add any paths that contain templates here, relative to this directory. > >> templates_path = ['_templates'] > >> @@ -175,6 +190,33 @@ texinfo_documents = [ > >> 'Miscellaneous'), > >> ] > >> > >> +# -- Options for Breathe extension ------------------------------------------- > >> + > >> +breathe_projects = { > >> + "Xen": "{}/docs/{}/xml".format(XEN_ROOT, xen_doxygen_output) > >> +} > >> +breathe_default_project = "Xen" > >> + > >> +breathe_domain_by_extension = { > >> + "h": "c", > >> + "c": "c", > >> +} > >> +breathe_separate_member_pages = True > >> +breathe_show_enumvalue_initializer = True > >> +breathe_show_define_initializer = True > >> + > >> +# Qualifiers to a function are causing Sphihx/Breathe to warn about > >> +# Error when parsing function declaration and more. This is a list > >> +# of strings that the parser additionally should accept as > >> +# attributes. > >> +cpp_id_attributes = [ > >> + '__syscall', '__deprecated', '__may_alias', > >> + '__used', '__unused', '__weak', > >> + '__DEPRECATED_MACRO', 'FUNC_NORETURN', > >> + '__subsystem', > > > > Should we also have any of following: > > > > __packed > > __init > > __attribute__ > > __aligned__ > > > > in the list? In any case, we don't have to add them right now, we could > > add them later as we expand Doxygen coverage if they become needed. > > Sure it is possible, I can add them now since I have to push a fix for this patch > If you want. I would add them now even if they are not strictly required to parse the public headers. But this is the kind of thing where others might have a different opinion. --8323329-683733543-1625161391=:9437-- From xen-devel-bounces@lists.xenproject.org Thu Jul 01 17:44:11 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 17:44:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149012.275429 (Exim 4.92) (envelope-from ) id 1lz0jS-0008Na-O4; Thu, 01 Jul 2021 17:44:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149012.275429; Thu, 01 Jul 2021 17:44:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lz0jS-0008NT-Kn; Thu, 01 Jul 2021 17:44:10 +0000 Received: by outflank-mailman (input) for mailman id 149012; Thu, 01 Jul 2021 17:44:09 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lz0jR-0008NH-GZ for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 17:44:09 +0000 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id efca23bc-da93-11eb-835a-12813bfff9fa; Thu, 01 Jul 2021 17:44:08 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id A8826613CF; Thu, 1 Jul 2021 17:44:07 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: efca23bc-da93-11eb-835a-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1625161448; bh=XauLEPYd/jYs64JpDvfc3TTx0NmqPddBd+EF4qXuebY=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=ftAZdRrGVvCCdWd5M8VuIzp7elLONE46uxBOuj9DIWNsBFgAgVYq8ya9Qn8HfwCRN Sb0fx9YoPUuhyfkECYmDkS4xDZBnmiAxSVCQhVSr8R2OmsrSERhkphlyOeHgVIvRyG dr7rGmmAD9Id4oALVGq0GO7XiSB0sggnNYpREAaF7GtsGWQ6WSmDVFbLMBwLNrWVc3 xQ/aSGXYLRcU2kABPAUkkV73EBtIZ4Nla/iSsW0L3sNgAaWlu0SKygGhDS70FEdFCU yBa4ASUV4J7GNYXfLEANoTaOjR/kiB4M9NywuUjsi7iLLTz5Lnu+nbp29efUJMFon/ 0Y6RUfF2fKEqg== Date: Thu, 1 Jul 2021 10:44:06 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Luca Fancellu cc: Stefano Stabellini , xen-devel@lists.xenproject.org, Bertrand Marquis , wei.chen@arm.com, Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Julien Grall , Wei Liu Subject: Re: [PATCH v6 9/9] docs/doxygen: doxygen documentation for grant_table.h In-Reply-To: <31171081-1007-4B4E-91CC-25EA1041EB58@arm.com> Message-ID: References: <20210510084105.17108-1-luca.fancellu@arm.com> <20210510084105.17108-10-luca.fancellu@arm.com> <31171081-1007-4B4E-91CC-25EA1041EB58@arm.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-1419850380-1625161448=:9437" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-1419850380-1625161448=:9437 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Thu, 1 Jul 2021, Luca Fancellu wrote: > Hi Stefano, > > > On 24 Jun 2021, at 00:34, Stefano Stabellini wrote: > > > > On Mon, 10 May 2021, Luca Fancellu wrote: > >> Modification to include/public/grant_table.h: > >> > >> 1) Add doxygen tags to: > >> - Create Grant tables section > >> - include variables in the generated documentation > >> - Used @keepindent/@endkeepindent to enclose comment > >> section that are indented using spaces, to keep > >> the indentation. > >> 2) Add .rst file for grant table for Arm64 > > > > Why only arm64? > > This is a mistake, it should be just “Add .rst file for grant table" > > > > > > >> Signed-off-by: Luca Fancellu > >> --- > >> v6 changes: > >> - Fix misaligned comment > >> - Moved comments to make them display in the docs > >> - Included more documentation in the docs > >> (see output here: https://luca.fancellu.gitlab.io/xen-docs/hypercall-interfaces/common/grant_tables.html) > > > > It looks much much better. All the info we care about seems to be there. > > The only things that I noticed missing and might be good to keep is the > > small comment about HYPERVISOR_grant_table_op: > > > > /* ` enum neg_errnoval > > * ` HYPERVISOR_grant_table_op(enum grant_table_op cmd, > > * ` void *args, > > * ` unsigned int count) > > * ` > > * > > * @args points to an array of a per-command data structure. The array > > * has @count members > > Where do you want me to put this comment in the html page? In the end of the description in the top of the page? Yeah, that looks like a good place --8323329-1419850380-1625161448=:9437-- From xen-devel-bounces@lists.xenproject.org Thu Jul 01 17:49:42 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 17:49:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149018.275440 (Exim 4.92) (envelope-from ) id 1lz0oj-0000fg-D7; Thu, 01 Jul 2021 17:49:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149018.275440; Thu, 01 Jul 2021 17:49:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lz0oj-0000fZ-8n; Thu, 01 Jul 2021 17:49:37 +0000 Received: by outflank-mailman (input) for mailman id 149018; Thu, 01 Jul 2021 17:49:36 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lz0oh-0000fT-UF for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 17:49:35 +0000 Received: from mail-pf1-x42d.google.com (unknown [2607:f8b0:4864:20::42d]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id e7e92e8e-5db8-4b7d-a5e0-5679b76c1516; Thu, 01 Jul 2021 17:49:34 +0000 (UTC) Received: by mail-pf1-x42d.google.com with SMTP id b12so5453965pfv.6 for ; Thu, 01 Jul 2021 10:49:34 -0700 (PDT) Received: from ?IPv6:2602:4b:a45e:ca01::9? ([2602:4b:a45e:ca01::9]) by smtp.gmail.com with ESMTPSA id m10sm657377pfh.62.2021.07.01.10.49.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 01 Jul 2021 10:49:33 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e7e92e8e-5db8-4b7d-a5e0-5679b76c1516 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:organization:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=U+W37TQ3T1y+C5Q0xHkEVJ/uCWV5n7YOCtXmRIz31uY=; b=jRnDwladYCmFPktuYJ+57+1jrKD8YE06vTGnV7pkX/UMK5G3bcT8TqfrJJJXb2Weqy RBuh2sljZadfP6HBgqhLruw+PmYKuKHhXWsD5BncdcTWQnUmS/K9T5ELezU9Z2JZDk+O 0bLmGYloYifTymMYr/pelIlNJh/pMYQeDBvn7I5ine7GNWDSgjPpJSyLFxppdrs7da2K MrCPfG0nAaYd8Tv6qmn8zWktZr5wZ7irLNfR19HqyU/P32AZ4EMCAl8cPb52Z0qw6aOG d1kqRL9tuuoO6FcQGWMtpZXXKyZ92n/h/AjDFRTbiskmLkt5jnfPMNrA+ORuVPfH/I7+ 6kdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=U+W37TQ3T1y+C5Q0xHkEVJ/uCWV5n7YOCtXmRIz31uY=; b=OyPuHZhwEhXo/xrB45TPjMUUAoacDj16RJOvSE57OMu9Rdny4YW0cg4553Fin4VA6K ZTdh2M4l4U1qjVci2IvF+KMgG1L7OIs/NwNX7I7VvA25eJZGS35ECXJDsDZHzqEJKVKg skDPj16fppkwBcPISHkWGqzDLSa2tx7zJTL9PNFZbJWZo+v6UMRgTNhMRuxpoKyujv9Y z7jAXvrlpidp/2XmvQFCaDa1B4kXiK5GeEpjFyC0VdZtjVcHH1uyTXYmmJbjGu9uP3zV nevVINMd3FDsSXHFRxmlkopzkp1WLOxS+UAqRVJUucwNV8hDKDTSH03DJLhqBJ9/bFrh F93g== X-Gm-Message-State: AOAM530/WkelUiCQw4uNRJmVy5C7GZPSUzfBFMPpf7FBfk5IrHsS2vFA wIeBiGkcbymBv8Lj1nCDoVk= X-Google-Smtp-Source: ABdhPJyORDWdcFyyra64spz9FVC6hyprvWsHXOD0m5Bwuv7ne7Q5OU+IPwzohxffdUCZNpj+bB+WoA== X-Received: by 2002:a63:ef44:: with SMTP id c4mr753464pgk.162.1625161774060; Thu, 01 Jul 2021 10:49:34 -0700 (PDT) Subject: Re: [XEN PATCH v6 29/31] build: build everything from the root dir, use obj=$subdir To: Anthony PERARD , xen-devel@lists.xenproject.org Cc: Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Volodymyr Babchuk , Alistair Francis , Connor Davis , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Konrad Rzeszutek Wilk , Ross Lagerwall , Daniel De Graaf , "Daniel P. Smith" References: <20210701141011.785641-1-anthony.perard@citrix.com> <20210701141011.785641-30-anthony.perard@citrix.com> From: Bob Eshleman Organization: Vates SAS Message-ID: <11c9c305-9053-e492-ecd6-c0ab22c93ed1@gmail.com> Date: Thu, 1 Jul 2021 10:49:26 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: <20210701141011.785641-30-anthony.perard@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 7/1/21 7:10 AM, Anthony PERARD wrote: > A subdirectory is now built by setting "$(obj)" instead of changing > directory. "$(obj)" should always be set when using "Rules.mk" and > thus a shortcut "$(build)" is introduced and should be used. > > A new variable "$(need-builtin)" is introduce. It is to be used > whenever a "built_in.o" is wanted from a subdirectory. "built_in.o" > isn't the main target anymore, and thus only needs to depends on the > objects that should be part of "built_in.o". > > Introduce $(srctree) and $(objtree) to replace $(BASEDIR) in cases a > relative path is better. > > DEPS is updated as the existing macro to deal with it doesn't know > about $(obj). > > There's some changes in "Rules.mk" which in addition to deal with > "$(obj)" also make it's looks more like "Makefile.build" from Linux > v5.12. > > test/Makefile doesn't need special handling in order to build > everything under test/, Rules.mk will visit test/livepatch via > $(subdir-y), thus "tests" "all" and "build" target are removed. > "subtree-force-update" target isn't useful so it is removed as well. > > test/livepatch/Makefile doesn't need default target anymore, Rules.mk > will build everything in $(extra-y) and thus all *.livepatch. > > Signed-off-by: Anthony PERARD Acked-by: Bob Eshleman Thanks, Bobby From xen-devel-bounces@lists.xenproject.org Thu Jul 01 17:52:26 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 17:52:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149023.275450 (Exim 4.92) (envelope-from ) id 1lz0rR-000259-Vr; Thu, 01 Jul 2021 17:52:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149023.275450; Thu, 01 Jul 2021 17:52:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lz0rR-000252-Sl; Thu, 01 Jul 2021 17:52:25 +0000 Received: by outflank-mailman (input) for mailman id 149023; Thu, 01 Jul 2021 17:52:25 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lz0rQ-00024p-WD for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 17:52:25 +0000 Received: from mail-pj1-x1029.google.com (unknown [2607:f8b0:4864:20::1029]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id b30768fb-0fb2-413e-a749-f44269e4bae8; Thu, 01 Jul 2021 17:52:24 +0000 (UTC) Received: by mail-pj1-x1029.google.com with SMTP id l11so4719373pji.5 for ; Thu, 01 Jul 2021 10:52:24 -0700 (PDT) Received: from ?IPv6:2602:4b:a45e:ca01::9? ([2602:4b:a45e:ca01::9]) by smtp.gmail.com with ESMTPSA id c21sm616684pfv.138.2021.07.01.10.52.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 01 Jul 2021 10:52:23 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b30768fb-0fb2-413e-a749-f44269e4bae8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:organization:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=0Vsex3I4g2OE7oG/neSBO+550Ku5bwDkSc1VWgWklJM=; b=On3F/DLFrInmIVnIoyaTcrsbnbqpU3BpzOCQYFEznAuC+3DFHOQ6+JjCPOoSTdGZVA byUJh5p1wd0b0FjyGvzfmFss1+urhZ+mj07fvFoNqlIDhGhOMCjXEFmFFnA9alnJ2ARR XbcVkLAr0O91ygXq1Izd16SulB2/JE1dIwja8atj+lqaQdhhR091/Rh94CKrUuyr0eft jAjobzsj+Y2uJ+jFoCUgNnLQMr3eUXV4/KnIGgdlzZGwnWhPXGRU2fd+5bD/U3xz2b8U wrxCBRsdEMQQQDp2B13jiHzx7nQ/9/yGc/FiFaUuozCpNIE+Pfopku0MOg6S3wJnNvm6 OO5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=0Vsex3I4g2OE7oG/neSBO+550Ku5bwDkSc1VWgWklJM=; b=kzDSrWVyZYCtMuEfZr1gRTRS/pABGLCiKMtBtBUjEnN+qN4ZFwAI8gCr+XTpi0TLs4 4j1N+KMVUWGJTHBBzGSW0XXswkd6RQvE33hoAd5xJzgOfO11SSB/V0X7K4nY+nF+7DAr RHjyMg7JJGb2A/s3Vhct38wWQSvYrmT1TFfKlZDrY5oI84C2XXBeKjctivgpNypRfX3K TxZ64UjAqks2RxTg3rQTXzEiRUdDs1ox8imEc81K0lXmIxbpbzCeM5fgoH/VIHJmLCZb gjnMz8nnhujm8NuxYeBkANvyY9cnTawXSqt11bRRSy+Xl4pLWvJiFX/bJHU6hHUmqbkD R2MA== X-Gm-Message-State: AOAM5333GxMguvf0opSiHghDKMyJ+fha+a06ui9wxV2WXCFzRIrBCYjm QWnCX2o2euXviA6WUWbYNds= X-Google-Smtp-Source: ABdhPJy5IhU4yYYT5O819bfLHWpyYviWFKlRWlUTu4WevT8HGP6l22zduT9xqn3d5FvMIrGyDVNARg== X-Received: by 2002:a17:902:d102:b029:128:e250:ebca with SMTP id w2-20020a170902d102b0290128e250ebcamr678585plw.14.1625161943699; Thu, 01 Jul 2021 10:52:23 -0700 (PDT) Subject: Re: [XEN PATCH v6 31/31] build,riscv: tell the build system about riscv64/head.S To: Anthony PERARD , xen-devel@lists.xenproject.org Cc: Alistair Francis , Connor Davis References: <20210701141011.785641-1-anthony.perard@citrix.com> <20210701141011.785641-32-anthony.perard@citrix.com> From: Bob Eshleman Organization: Vates SAS Message-ID: <40116c39-1437-de8c-23bd-0454e4551478@gmail.com> Date: Thu, 1 Jul 2021 10:52:19 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: <20210701141011.785641-32-anthony.perard@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 7/1/21 7:10 AM, Anthony PERARD wrote: > This allows to `make arch/riscv/riscv64/head.o`. > > Example of rune on a fresh copy of the repository: > make XEN_TARGET_ARCH=riscv64 CROSS_COMPILE=riscv64-linux-gnu- KBUILD_DEFCONFIG=tiny64_defconfig arch/riscv/riscv64/head.o > > Signed-off-by: Anthony PERARD > --- > xen/arch/riscv/riscv64/Makefile | 1 + > 1 file changed, 1 insertion(+) > create mode 100644 xen/arch/riscv/riscv64/Makefile > > diff --git a/xen/arch/riscv/riscv64/Makefile b/xen/arch/riscv/riscv64/Makefile > new file mode 100644 > index 000000000000..15a4a65f6615 > --- /dev/null > +++ b/xen/arch/riscv/riscv64/Makefile > @@ -0,0 +1 @@ > +extra-y += head.o > Acked-by: Bob Eshleman -- Bobby Eshleman SE at Vates SAS From xen-devel-bounces@lists.xenproject.org Thu Jul 01 18:06:13 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 18:06:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149029.275461 (Exim 4.92) (envelope-from ) id 1lz14h-0003d6-3g; Thu, 01 Jul 2021 18:06:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149029.275461; Thu, 01 Jul 2021 18:06:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lz14h-0003cz-0m; Thu, 01 Jul 2021 18:06:07 +0000 Received: by outflank-mailman (input) for mailman id 149029; Thu, 01 Jul 2021 18:06:05 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lz14f-0003cp-Nl; Thu, 01 Jul 2021 18:06:05 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lz14f-0002jS-HF; Thu, 01 Jul 2021 18:06:05 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lz14f-00016D-71; Thu, 01 Jul 2021 18:06:05 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lz14f-0006BZ-6Z; Thu, 01 Jul 2021 18:06:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=tfK3+WTsBZ4TdBWk+Tzr3sj4cN/p6mhzyBfak1rchZQ=; b=uu6F15xvIi0BQwbe4Zwvw9v5Ht rDZhPyJvzStejtlG/YdE5G5u7Xrv/oR+iOtyjspbHUutWHlHeyuMxnY07y8qnvIdtNlAteOYDE1Ev 3EHUVPKxHi4UwwzdE+j9xXyPRbQhYMiVbNF81lEQee2Ck3nzfgxVq/k5bppBS+bxkJOY=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 163206: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug xen-unstable:test-armhf-armhf-libvirt-raw:xen-boot:fail:heisenbug xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=f95b7b37cfc6d4613721df9357090d14712013c0 X-Osstest-Versions-That: xen=f95b7b37cfc6d4613721df9357090d14712013c0 From: osstest service owner Date: Thu, 01 Jul 2021 18:06:05 +0000 flight 163206 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/163206/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail in 163190 pass in 163206 test-armhf-armhf-libvirt-raw 8 xen-boot fail pass in 163190 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail in 163190 blocked in 163206 test-armhf-armhf-libvirt-raw 14 migrate-support-check fail in 163190 never pass test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 163190 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 163190 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 163190 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 163190 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 163190 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 163190 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 163190 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 163190 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 163190 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 163190 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass version targeted for testing: xen f95b7b37cfc6d4613721df9357090d14712013c0 baseline version: xen f95b7b37cfc6d4613721df9357090d14712013c0 Last test of basis 163206 2021-07-01 01:51:36 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw fail test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Thu Jul 01 19:32:06 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 19:32:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149035.275476 (Exim 4.92) (envelope-from ) id 1lz2Ph-0003FG-OD; Thu, 01 Jul 2021 19:31:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149035.275476; Thu, 01 Jul 2021 19:31:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lz2Ph-0003F9-Kh; Thu, 01 Jul 2021 19:31:53 +0000 Received: by outflank-mailman (input) for mailman id 149035; Thu, 01 Jul 2021 19:31:52 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lz2Pg-0003Ez-7z; Thu, 01 Jul 2021 19:31:52 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lz2Pg-00043v-1S; Thu, 01 Jul 2021 19:31:52 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lz2Pf-0004A6-Lk; Thu, 01 Jul 2021 19:31:51 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lz2Pf-0000lT-LF; Thu, 01 Jul 2021 19:31:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=nHoKSs46Gn4WnaN1vOJmjfGDBwLzw66dsPrcx5W69fs=; b=AZfncMenmhTUDT9rA/dA8bH2qr dfpREGWIgEGBT3gtJisrkJXGrqmSFmJiATU4kMRF5JMoIVbUn83WdWHjoWtw0B0uksWBGxysmjzH8 8tqe9W/PMrBmOr8tDy5FDJ+NxLFy6Bc276QQr671ASiQBVj7c1kKAD9QVkN/14hwmbPo=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 163207: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-i386-qemut-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-coresched-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-examine:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-pvshim:xen-install:fail:regression linux-linus:test-amd64-i386-xl-raw:xen-install:fail:regression linux-linus:test-amd64-i386-xl-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-i386:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-xsm:xen-install:fail:regression linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-vhd:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-thunderx:debian-fixup:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-arm64-arm64-xl-xsm:debian-fixup:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:debian-fixup:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-amd64-amd64-amd64-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-i386-pvgrub:guest-stop:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qcow2:guest-start:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:debian-fixup:fail:regression linux-linus:test-arm64-arm64-xl:debian-fixup:fail:regression linux-linus:test-amd64-amd64-examine:memdisk-try-append:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:guest-start:fail:regression linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=dbe69e43372212527abf48609aba7fc39a6daa27 X-Osstest-Versions-That: linux=deacdb3e3979979016fcd0ffd518c320a62ad166 From: osstest service owner Date: Thu, 01 Jul 2021 19:31:51 +0000 flight 163207 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/163207/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-qemut-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-coresched-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-examine 6 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-pvshim 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-raw 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-i386 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-xsm 7 xen-install fail REGR. vs. 152332 test-arm64-arm64-xl-credit1 8 xen-boot fail REGR. vs. 152332 test-amd64-amd64-libvirt-vhd 13 guest-start fail REGR. vs. 152332 test-arm64-arm64-xl-thunderx 13 debian-fixup fail REGR. vs. 152332 test-armhf-armhf-examine 8 reboot fail REGR. vs. 152332 test-arm64-arm64-xl-xsm 13 debian-fixup fail REGR. vs. 152332 test-arm64-arm64-libvirt-xsm 13 debian-fixup fail REGR. vs. 152332 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 152332 test-amd64-amd64-amd64-pvgrub 20 guest-stop fail REGR. vs. 152332 test-amd64-amd64-i386-pvgrub 20 guest-stop fail REGR. vs. 152332 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 152332 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 152332 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 152332 test-amd64-amd64-xl-qcow2 13 guest-start fail REGR. vs. 152332 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 152332 test-arm64-arm64-xl-credit2 13 debian-fixup fail REGR. vs. 152332 test-arm64-arm64-xl 13 debian-fixup fail REGR. vs. 152332 test-amd64-amd64-examine 4 memdisk-try-append fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 152332 test-armhf-armhf-xl-vhd 13 guest-start fail REGR. vs. 152332 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 152332 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 152332 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152332 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152332 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass version targeted for testing: linux dbe69e43372212527abf48609aba7fc39a6daa27 baseline version: linux deacdb3e3979979016fcd0ffd518c320a62ad166 Last test of basis 152332 2020-07-31 19:41:23 Z 334 days Failing since 152366 2020-08-01 20:49:34 Z 333 days 568 attempts Testing same since 163207 2021-07-01 02:12:24 Z 0 days 1 attempts ------------------------------------------------------------ 6412 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-i386-xl fail test-amd64-coresched-i386-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm fail test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm fail test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine fail test-amd64-i386-examine fail test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel fail test-amd64-i386-qemuu-rhel6hvm-intel fail test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-amd64-pvgrub fail test-amd64-amd64-i386-pvgrub fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 fail test-armhf-armhf-libvirt-raw fail test-amd64-i386-xl-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow fail test-arm64-arm64-xl-thunderx fail test-amd64-amd64-libvirt-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1802647 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Jul 01 22:12:17 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Jul 2021 22:12:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149044.275493 (Exim 4.92) (envelope-from ) id 1lz4ug-0000lq-Bo; Thu, 01 Jul 2021 22:12:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149044.275493; Thu, 01 Jul 2021 22:12:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lz4ug-0000lj-8g; Thu, 01 Jul 2021 22:12:02 +0000 Received: by outflank-mailman (input) for mailman id 149044; Thu, 01 Jul 2021 22:12:00 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lz4ue-0000lZ-SY; Thu, 01 Jul 2021 22:12:00 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lz4ue-0006jR-IQ; Thu, 01 Jul 2021 22:12:00 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lz4ue-00047i-8k; Thu, 01 Jul 2021 22:12:00 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lz4ue-0004L5-8J; Thu, 01 Jul 2021 22:12:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=YF8sTuGrs37hcmO1B5NjG/UyDSgLfYwUWERAcDZkJ3U=; b=F/CppXG3yPjSpYP0PAk56TG+SM s5Wp6/5nEJ15B3fW9Sxx0APmL3BQbV6yQ/oxyM30WqUtHLyHz/4w3RZdOjeTlROuQDtaA3DDkiWOl Us9zjQh2FJuq8lWOyeYHoZyqvGsy1XPW9q+DbNWWY81fW6lk+UGT4ywGecJp66gRKdt0=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 163214: regressions - FAIL X-Osstest-Failures: ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:debian-hvm-install:fail:regression ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:debian-hvm-install:fail:regression X-Osstest-Versions-This: ovmf=8697dc60cc28b2673aed4998fb6b21b9bf54a76d X-Osstest-Versions-That: ovmf=c410ad4da4b7785170d3d42a3ba190c2caac6feb From: osstest service owner Date: Thu, 01 Jul 2021 22:12:00 +0000 flight 163214 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/163214/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 162359 test-amd64-amd64-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 162359 version targeted for testing: ovmf 8697dc60cc28b2673aed4998fb6b21b9bf54a76d baseline version: ovmf c410ad4da4b7785170d3d42a3ba190c2caac6feb Last test of basis 162359 2021-06-04 03:40:08 Z 27 days Failing since 162368 2021-06-04 15:42:59 Z 27 days 70 attempts Testing same since 163214 2021-07-01 17:42:29 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Abner Chang Agrawal, Sachin Alexandru Elisei Anthony PERARD Ard Biesheuvel Daniel Schaefer Daoxiang Li Dov Murik DunTan gaoliming Guo Dong Hao A Wu Jian J Wang Kaaira Gupta Ken Lautner Kenneth Lautner Kun Qin Laszlo Ersek Leif Lindholm Liming Gao Loo Tung Lun Loo, Tung Lun Manickavasakam Karpagavinayagam Maurice Ma Ni, Ray Patrick Rudolph Pierre Gondois Ray Ni Rebecca Cran Rebecca Cran Sachin Agrawal Sami Mujawar Scottie Kuo Sean Brogan Sean Brogan Sumana Venur Sunil V L xueshengfeng Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-i386-xl-qemuu-ovmf-amd64 fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 3210 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Jul 02 01:07:25 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Jul 2021 01:07:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149051.275508 (Exim 4.92) (envelope-from ) id 1lz7e9-0002bP-VI; Fri, 02 Jul 2021 01:07:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149051.275508; Fri, 02 Jul 2021 01:07:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lz7e9-0002bH-P7; Fri, 02 Jul 2021 01:07:09 +0000 Received: by outflank-mailman (input) for mailman id 149051; Fri, 02 Jul 2021 01:07:09 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lz7e9-0002b7-4x; Fri, 02 Jul 2021 01:07:09 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lz7e8-0004ao-Tt; Fri, 02 Jul 2021 01:07:08 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lz7e8-0001Il-Kt; Fri, 02 Jul 2021 01:07:08 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lz7e8-00088r-KN; Fri, 02 Jul 2021 01:07:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=/kHQCQtIatzVct0oByhL8yCJaYtoAb4L1/GaW3l6IUw=; b=5V1RxqaL8HW0MpRFo+zhVHDFOE 02wYwNwHNt5172ohR0xA5PRDQahc7vydxZ33pl+vlOwUlAB7+1fKGWaywPFnrCliOQdbZ/Egkia8P M0yzKl8qHV4Jacg0e3BDtKv5gFxtEwS/4x8LPC+tYAPXDjPluUrMS0iZ67/SvPutyE2o=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 163216: regressions - FAIL X-Osstest-Failures: ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:debian-hvm-install:fail:regression ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:debian-hvm-install:fail:regression X-Osstest-Versions-This: ovmf=fea7901dba72eeac526f3ef12a4ad4c539622373 X-Osstest-Versions-That: ovmf=c410ad4da4b7785170d3d42a3ba190c2caac6feb From: osstest service owner Date: Fri, 02 Jul 2021 01:07:08 +0000 flight 163216 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/163216/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 162359 test-amd64-amd64-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 162359 version targeted for testing: ovmf fea7901dba72eeac526f3ef12a4ad4c539622373 baseline version: ovmf c410ad4da4b7785170d3d42a3ba190c2caac6feb Last test of basis 162359 2021-06-04 03:40:08 Z 27 days Failing since 162368 2021-06-04 15:42:59 Z 27 days 71 attempts Testing same since 163216 2021-07-01 22:42:29 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Abner Chang Agrawal, Sachin Alexandru Elisei Anthony PERARD Ard Biesheuvel Daniel Schaefer Daoxiang Li Dov Murik DunTan gaoliming Guo Dong Hao A Wu Jian J Wang Kaaira Gupta Ken Lautner Kenneth Lautner Kun Qin Laszlo Ersek Leif Lindholm Liming Gao Loo Tung Lun Loo, Tung Lun Manickavasakam Karpagavinayagam Maurice Ma Ni, Ray Patrick Rudolph Pierre Gondois Ray Ni Rebecca Cran Rebecca Cran Sachin Agrawal Sami Mujawar Scottie Kuo Sean Brogan Sean Brogan Sumana Venur Sunil V L xueshengfeng Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-i386-xl-qemuu-ovmf-amd64 fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 3224 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Jul 02 02:24:38 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Jul 2021 02:24:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149059.275521 (Exim 4.92) (envelope-from ) id 1lz8qv-0001o4-P7; Fri, 02 Jul 2021 02:24:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149059.275521; Fri, 02 Jul 2021 02:24:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lz8qv-0001nx-Li; Fri, 02 Jul 2021 02:24:25 +0000 Received: by outflank-mailman (input) for mailman id 149059; Fri, 02 Jul 2021 02:24:24 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lz8qu-0001nn-JK; Fri, 02 Jul 2021 02:24:24 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lz8qu-0006GY-CD; Fri, 02 Jul 2021 02:24:24 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lz8qt-0003Oe-Tj; Fri, 02 Jul 2021 02:24:24 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lz8qt-0005Lf-Sz; Fri, 02 Jul 2021 02:24:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=L6gc9hzGIPABbXmTfLYuJidhHWCcVY1YBxwTks4jR2c=; b=qarcLd/QeuOtuNsrt2nXrpQ6L+ FtgWqN+FnuYIHsYtkP6LqfWXYiLAvdHvGleASkqMQoCQqzWWrLvOksuxkUySG0C1ivbFVyeItinVf DJ2EnANMJqV2QUqJnRk5AzWnY7zaLLVQkjI1F8NXAZLaHxz4+aPO7+AUJqORDvEg6zFY=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 163213: regressions - FAIL X-Osstest-Failures: qemu-mainline:test-amd64-amd64-qemuu-nested-amd:xen-boot/l1:fail:regression qemu-mainline:test-amd64-amd64-qemuu-nested-intel:xen-boot/l1:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=1ec2cd0ce2ca94292ce237becc2c21b4eb9edca0 X-Osstest-Versions-That: qemuu=1d806cef0e38b5db8347a8e12f214d543204a314 From: osstest service owner Date: Fri, 02 Jul 2021 02:24:23 +0000 flight 163213 qemu-mainline real [real] flight 163218 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/163213/ http://logs.test-lab.xenproject.org/osstest/logs/163218/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-qemuu-nested-amd 16 xen-boot/l1 fail REGR. vs. 152631 test-amd64-amd64-qemuu-nested-intel 16 xen-boot/l1 fail REGR. vs. 152631 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152631 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 152631 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152631 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152631 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 152631 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152631 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass version targeted for testing: qemuu 1ec2cd0ce2ca94292ce237becc2c21b4eb9edca0 baseline version: qemuu 1d806cef0e38b5db8347a8e12f214d543204a314 Last test of basis 152631 2020-08-20 09:07:46 Z 315 days Failing since 152659 2020-08-21 14:07:39 Z 314 days 577 attempts Testing same since 163213 2021-07-01 13:53:26 Z 0 days 1 attempts ------------------------------------------------------------ 552 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 180246 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Jul 02 02:25:11 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Jul 2021 02:25:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149064.275535 (Exim 4.92) (envelope-from ) id 1lz8rf-0002Nc-84; Fri, 02 Jul 2021 02:25:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149064.275535; Fri, 02 Jul 2021 02:25:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lz8rf-0002NV-4l; Fri, 02 Jul 2021 02:25:11 +0000 Received: by outflank-mailman (input) for mailman id 149064; Fri, 02 Jul 2021 02:25:09 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lz8rd-0002M7-0p; Fri, 02 Jul 2021 02:25:09 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lz8rc-0006HD-Tl; Fri, 02 Jul 2021 02:25:08 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lz8rc-0003Pa-Ms; Fri, 02 Jul 2021 02:25:08 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lz8rc-00060J-MM; Fri, 02 Jul 2021 02:25:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=d3UaKIeA4lHwc6/4H75FWl/cQx1DtVsUDC4KcemtYfE=; b=DyMAfVkQqGnixUbWeH+UhkOETl /FsXqVAsG8pE7bbkA1u0hRhiIlZbfaWKV3qjMdB49jeF+795dE35RU+hVMUDivgvUpcSBNLqkyWMv +WyBMcQQYOv4i+Fxmt/n1DPzMd6o0EF453TOUGSJi9IJAWTxb93Rmf4NSXiWoJoq1TbQ=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 163217: regressions - FAIL X-Osstest-Failures: ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:debian-hvm-install:fail:regression ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:debian-hvm-install:fail:regression X-Osstest-Versions-This: ovmf=fea7901dba72eeac526f3ef12a4ad4c539622373 X-Osstest-Versions-That: ovmf=c410ad4da4b7785170d3d42a3ba190c2caac6feb From: osstest service owner Date: Fri, 02 Jul 2021 02:25:08 +0000 flight 163217 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/163217/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 162359 test-amd64-amd64-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 162359 version targeted for testing: ovmf fea7901dba72eeac526f3ef12a4ad4c539622373 baseline version: ovmf c410ad4da4b7785170d3d42a3ba190c2caac6feb Last test of basis 162359 2021-06-04 03:40:08 Z 27 days Failing since 162368 2021-06-04 15:42:59 Z 27 days 72 attempts Testing same since 163216 2021-07-01 22:42:29 Z 0 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Abner Chang Agrawal, Sachin Alexandru Elisei Anthony PERARD Ard Biesheuvel Daniel Schaefer Daoxiang Li Dov Murik DunTan gaoliming Guo Dong Hao A Wu Jian J Wang Kaaira Gupta Ken Lautner Kenneth Lautner Kun Qin Laszlo Ersek Leif Lindholm Liming Gao Loo Tung Lun Loo, Tung Lun Manickavasakam Karpagavinayagam Maurice Ma Ni, Ray Patrick Rudolph Pierre Gondois Ray Ni Rebecca Cran Rebecca Cran Sachin Agrawal Sami Mujawar Scottie Kuo Sean Brogan Sean Brogan Sumana Venur Sunil V L xueshengfeng Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-i386-xl-qemuu-ovmf-amd64 fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 3224 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Jul 02 03:08:18 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Jul 2021 03:08:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149074.275549 (Exim 4.92) (envelope-from ) id 1lz9XH-0006Tk-Kv; Fri, 02 Jul 2021 03:08:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149074.275549; Fri, 02 Jul 2021 03:08:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lz9XH-0006Td-Ho; Fri, 02 Jul 2021 03:08:11 +0000 Received: by outflank-mailman (input) for mailman id 149074; Fri, 02 Jul 2021 03:08:10 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lz9XG-0006TX-KM for xen-devel@lists.xenproject.org; Fri, 02 Jul 2021 03:08:10 +0000 Received: from mail-oi1-x230.google.com (unknown [2607:f8b0:4864:20::230]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 8e046331-4739-4c0c-92e9-9cdf01347cc6; Fri, 02 Jul 2021 03:08:09 +0000 (UTC) Received: by mail-oi1-x230.google.com with SMTP id t3so9797238oic.5 for ; Thu, 01 Jul 2021 20:08:09 -0700 (PDT) Received: from localhost ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id l2sm374555otl.27.2021.07.01.20.08.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Jul 2021 20:08:08 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: 8e046331-4739-4c0c-92e9-9cdf01347cc6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=vnC0TqPJlyIMqLOncGpr5zl9pmbmcIIyiC4phT6PUIQ=; b=rcatVMwnoboRAVBm6z7P2HYmOyqx+HWthzA0HOg5zSVWMr7WIAx3ZVtmMQBABS3jSs ll3cBrlaV5N4g4Rvy938v3Mka2o7BKSsLAnp0j9BVKtd6G0HRyhUAM117EPetSB6PYk4 aIzksvokAZwg7oj60y4L3zka5GOYTYtCADcKKqh9eOpTeqFos+tdtKUeh13pl/ncaATb z+gsly2qHHMFdyn0yxdy8vih0i6Y3VD1swKheCHmBE++JlII4Ajp+FJ6942Kfxfr0p9t PlSPUBKWfUPw26fCx2/8jDss0gWJ7ZhSbqGnHJzN7Y9CqXNOHLSOGPQ6Z7xfZJI1OXzp hIRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=vnC0TqPJlyIMqLOncGpr5zl9pmbmcIIyiC4phT6PUIQ=; b=jKTSJqkGiP/4D2KKl8/Qr5dFRC3kumAd81fH4dh93nwa4C4eEWChRYZpDYBwq0rsFc bqW8ZZZI0g9u3i4T2vU6d4K2y3JDQV7hX2wzkaWM2cZgjymgtopv+F/CwpicvTecMftF MUBk+pKOmk4P+xe/L/ihO8xYrNCYS5Y3Id+/Vxm5TExDIqGOaYKViFOt7OChEydQTSGN HNDSk8p+aTmrhqYjAZTL+155BwbAk7oejqAF3Vd9qWg+4ClmxVR2i10YbKEKzEs+6KCv UXhT8iVAuQ+trDLRWQrNbfFQCDwTqoo9i71chTlVD/bo76HBaGPmu4Dks9pHizx1Q1Gu 9MvQ== X-Gm-Message-State: AOAM530gcWXJtZNXIpeSYGNeu0U1rnKCPCyVgXxOrii6JfvE5Og+HgTv taSvOMTqq4d+0kLppwymUfE= X-Google-Smtp-Source: ABdhPJxROyx59a65CULGKnIjDKL6LEkceViIozGHO/6JCiILIO/ostWPfjk3TYymGpFPnNGZwku3+w== X-Received: by 2002:a54:4187:: with SMTP id 7mr2101677oiy.127.1625195289117; Thu, 01 Jul 2021 20:08:09 -0700 (PDT) Sender: Guenter Roeck Date: Thu, 1 Jul 2021 20:08:07 -0700 From: Guenter Roeck To: Claire Chang Cc: Rob Herring , mpe@ellerman.id.au, Joerg Roedel , Will Deacon , Frank Rowand , Konrad Rzeszutek Wilk , boris.ostrovsky@oracle.com, jgross@suse.com, Christoph Hellwig , Marek Szyprowski , heikki.krogerus@linux.intel.com, thomas.hellstrom@linux.intel.com, peterz@infradead.org, dri-devel@lists.freedesktop.org, chris@chris-wilson.co.uk, grant.likely@arm.com, paulus@samba.org, mingo@kernel.org, jxgao@google.com, sstabellini@kernel.org, Saravana Kannan , xypron.glpk@gmx.de, "Rafael J . Wysocki" , Bartosz Golaszewski , bskeggs@redhat.com, linux-pci@vger.kernel.org, xen-devel@lists.xenproject.org, Thierry Reding , intel-gfx@lists.freedesktop.org, matthew.auld@intel.com, linux-devicetree , airlied@linux.ie, Robin Murphy , Nicolas Boichat , rodrigo.vivi@intel.com, bhelgaas@google.com, Dan Williams , Andy Shevchenko , Greg KH , Randy Dunlap , quic_qiancai@quicinc.com, lkml , tfiga@chromium.org, "list@263.net:IOMMU DRIVERS" , Jim Quinlan , thomas.lendacky@amd.com, linuxppc-dev@lists.ozlabs.org, bauerman@linux.ibm.com Subject: Re: [PATCH v15 12/12] of: Add plumbing for restricted DMA pool Message-ID: <20210702030807.GA2685166@roeck-us.net> References: <20210624155526.2775863-1-tientzu@chromium.org> <20210624155526.2775863-13-tientzu@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210624155526.2775863-13-tientzu@chromium.org> Hi, On Thu, Jun 24, 2021 at 11:55:26PM +0800, Claire Chang wrote: > If a device is not behind an IOMMU, we look up the device node and set > up the restricted DMA when the restricted-dma-pool is presented. > > Signed-off-by: Claire Chang > Tested-by: Stefano Stabellini > Tested-by: Will Deacon With this patch in place, all sparc and sparc64 qemu emulations fail to boot. Symptom is that the root file system is not found. Reverting this patch fixes the problem. Bisect log is attached. Guenter --- # bad: [fb0ca446157a86b75502c1636b0d81e642fe6bf1] Add linux-next specific files for 20210701 # good: [62fb9874f5da54fdb243003b386128037319b219] Linux 5.13 git bisect start 'HEAD' 'v5.13' # bad: [f63c4fda987a19b1194cc45cb72fd5bf968d9d90] Merge remote-tracking branch 'rdma/for-next' git bisect bad f63c4fda987a19b1194cc45cb72fd5bf968d9d90 # good: [46bb5dd1d2a63e906e374e97dfd4a5e33934b1c4] Merge remote-tracking branch 'ipsec/master' git bisect good 46bb5dd1d2a63e906e374e97dfd4a5e33934b1c4 # good: [43ba6969cfb8185353a7a6fc79070f13b9e3d6d3] Merge remote-tracking branch 'clk/clk-next' git bisect good 43ba6969cfb8185353a7a6fc79070f13b9e3d6d3 # good: [1ca5eddcf8dca1d6345471c6404e7364af0d7019] Merge remote-tracking branch 'fuse/for-next' git bisect good 1ca5eddcf8dca1d6345471c6404e7364af0d7019 # good: [8f6d7b3248705920187263a4e7147b0752ec7dcf] Merge remote-tracking branch 'pci/next' git bisect good 8f6d7b3248705920187263a4e7147b0752ec7dcf # good: [df1885a755784da3ef285f36d9230c1d090ef186] RDMA/rtrs_clt: Alloc less memory with write path fast memory registration git bisect good df1885a755784da3ef285f36d9230c1d090ef186 # good: [93d31efb58c8ad4a66bbedbc2d082df458c04e45] Merge remote-tracking branch 'cpufreq-arm/cpufreq/arm/linux-next' git bisect good 93d31efb58c8ad4a66bbedbc2d082df458c04e45 # good: [46308965ae6fdc7c25deb2e8c048510ae51bbe66] RDMA/irdma: Check contents of user-space irdma_mem_reg_req object git bisect good 46308965ae6fdc7c25deb2e8c048510ae51bbe66 # good: [6de7a1d006ea9db235492b288312838d6878385f] thermal/drivers/int340x/processor_thermal: Split enumeration and processing part git bisect good 6de7a1d006ea9db235492b288312838d6878385f # good: [081bec2577cda3d04f6559c60b6f4e2242853520] dt-bindings: of: Add restricted DMA pool git bisect good 081bec2577cda3d04f6559c60b6f4e2242853520 # good: [bf95ac0bcd69979af146852f6a617a60285ebbc1] Merge remote-tracking branch 'thermal/thermal/linux-next' git bisect good bf95ac0bcd69979af146852f6a617a60285ebbc1 # good: [3d8287544223a3d2f37981c1f9ffd94d0b5e9ffc] RDMA/core: Always release restrack object git bisect good 3d8287544223a3d2f37981c1f9ffd94d0b5e9ffc # bad: [cff1f23fad6e0bd7d671acce0d15285c709f259c] Merge remote-tracking branch 'swiotlb/linux-next' git bisect bad cff1f23fad6e0bd7d671acce0d15285c709f259c # bad: [b655006619b7bccd0dc1e055bd72de5d613e7b5c] of: Add plumbing for restricted DMA pool git bisect bad b655006619b7bccd0dc1e055bd72de5d613e7b5c # first bad commit: [b655006619b7bccd0dc1e055bd72de5d613e7b5c] of: Add plumbing for restricted DMA pool From xen-devel-bounces@lists.xenproject.org Fri Jul 02 03:51:11 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Jul 2021 03:51:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149078.275560 (Exim 4.92) (envelope-from ) id 1lzACf-0002ek-0N; Fri, 02 Jul 2021 03:50:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149078.275560; Fri, 02 Jul 2021 03:50:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzACe-0002ed-Rl; Fri, 02 Jul 2021 03:50:56 +0000 Received: by outflank-mailman (input) for mailman id 149078; Fri, 02 Jul 2021 03:50:55 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzACd-0002eT-1q; Fri, 02 Jul 2021 03:50:55 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzACc-0007fb-Qw; Fri, 02 Jul 2021 03:50:54 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzACc-0006I9-9p; Fri, 02 Jul 2021 03:50:54 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lzACc-0006Iu-9J; Fri, 02 Jul 2021 03:50:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=f4IrwvRjcovpIIV+F7WxvebaqdkwFWTbbDQ1oSCBBLM=; b=IKOrE7RBC9oe7LsLZMsx9sBciI muCdR8M3qro2qchd/neFor+jAKZVCWgqqhhw97jx+x937pM3/IrcsRIqR2PRYHADOFrvlKDCF7uXs kEAtPxtGdI46D5MGjzzpPwNEav7F/actvwd5/KyWmPCZhqcJsksCE7ux3Ta2jSifVQ8E=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 163215: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-i386-qemut-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-coresched-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-examine:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-pvshim:xen-install:fail:regression linux-linus:test-amd64-i386-xl-raw:xen-install:fail:regression linux-linus:test-amd64-i386-xl-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-i386:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-xsm:xen-install:fail:regression linux-linus:test-arm64-arm64-xl-seattle:debian-install:fail:regression linux-linus:test-amd64-amd64-libvirt-vhd:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-credit1:debian-install:fail:regression linux-linus:test-arm64-arm64-xl-credit2:debian-install:fail:regression linux-linus:test-arm64-arm64-xl-thunderx:debian-install:fail:regression linux-linus:test-arm64-arm64-xl-xsm:debian-install:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-arm64-arm64-xl:debian-install:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:debian-install:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-amd64-amd64-amd64-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-i386-pvgrub:guest-stop:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qcow2:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-xsm:guest-start/debian.repeat:fail:regression linux-linus:test-armhf-armhf-xl-cubietruck:debian-install:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:debian-di-install:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:debian-install:fail:regression linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=c288d9cd710433e5991d58a0764c4d08a933b871 X-Osstest-Versions-That: linux=deacdb3e3979979016fcd0ffd518c320a62ad166 From: osstest service owner Date: Fri, 02 Jul 2021 03:50:54 +0000 flight 163215 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/163215/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-qemut-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-coresched-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-examine 6 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-pvshim 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-raw 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-i386 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-xsm 7 xen-install fail REGR. vs. 152332 test-arm64-arm64-xl-seattle 12 debian-install fail REGR. vs. 152332 test-amd64-amd64-libvirt-vhd 13 guest-start fail REGR. vs. 152332 test-arm64-arm64-xl-credit1 12 debian-install fail REGR. vs. 152332 test-arm64-arm64-xl-credit2 12 debian-install fail REGR. vs. 152332 test-arm64-arm64-xl-thunderx 12 debian-install fail REGR. vs. 152332 test-arm64-arm64-xl-xsm 12 debian-install fail REGR. vs. 152332 test-armhf-armhf-examine 8 reboot fail REGR. vs. 152332 test-arm64-arm64-xl 12 debian-install fail REGR. vs. 152332 test-arm64-arm64-libvirt-xsm 12 debian-install fail REGR. vs. 152332 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 152332 test-amd64-amd64-amd64-pvgrub 20 guest-stop fail REGR. vs. 152332 test-amd64-amd64-i386-pvgrub 20 guest-stop fail REGR. vs. 152332 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 152332 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 152332 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 152332 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 152332 test-amd64-amd64-xl-qcow2 13 guest-start fail REGR. vs. 152332 test-amd64-amd64-xl-xsm 22 guest-start/debian.repeat fail REGR. vs. 152332 test-armhf-armhf-xl-cubietruck 12 debian-install fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 152332 test-armhf-armhf-xl-vhd 12 debian-di-install fail REGR. vs. 152332 test-armhf-armhf-xl-multivcpu 12 debian-install fail REGR. vs. 152332 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 152332 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 152332 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152332 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152332 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass version targeted for testing: linux c288d9cd710433e5991d58a0764c4d08a933b871 baseline version: linux deacdb3e3979979016fcd0ffd518c320a62ad166 Last test of basis 152332 2020-07-31 19:41:23 Z 335 days Failing since 152366 2020-08-01 20:49:34 Z 334 days 569 attempts Testing same since 163215 2021-07-01 19:41:07 Z 0 days 1 attempts ------------------------------------------------------------ 6418 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-i386-xl fail test-amd64-coresched-i386-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm fail test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm fail test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck fail test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine fail test-amd64-i386-examine fail test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel fail test-amd64-i386-qemuu-rhel6hvm-intel fail test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-amd64-pvgrub fail test-amd64-amd64-i386-pvgrub fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 fail test-armhf-armhf-libvirt-raw fail test-amd64-i386-xl-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow fail test-arm64-arm64-xl-thunderx fail test-amd64-amd64-libvirt-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1805615 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Jul 02 04:46:02 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Jul 2021 04:46:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149083.275574 (Exim 4.92) (envelope-from ) id 1lzB3r-0007k2-9M; Fri, 02 Jul 2021 04:45:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149083.275574; Fri, 02 Jul 2021 04:45:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzB3r-0007jv-4B; Fri, 02 Jul 2021 04:45:55 +0000 Received: by outflank-mailman (input) for mailman id 149083; Fri, 02 Jul 2021 04:45:54 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzB3q-0007jp-9f for xen-devel@lists.xenproject.org; Fri, 02 Jul 2021 04:45:54 +0000 Received: from mail-io1-xd2f.google.com (unknown [2607:f8b0:4864:20::d2f]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id c84291fa-e516-4e66-99a1-616021f2c5e9; Fri, 02 Jul 2021 04:45:53 +0000 (UTC) Received: by mail-io1-xd2f.google.com with SMTP id f21so10153651ioh.13 for ; Thu, 01 Jul 2021 21:45:53 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c84291fa-e516-4e66-99a1-616021f2c5e9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8R7vzE3sMCLc8J7Cy3dbusGdeTZZo2sinRkBhrCFmms=; b=vTaC25hO73MXSL3xPAej+rc5V6NNcyjA9e2gk6Na2UN5AUZ1b/LvUAbsUFub2TeDcQ SnqMKnU1xekNb5TZe3LTGZsa+H92Mgzidgh8lJs6k8U8cb19GBvj9nvbkj+0R3g73LUQ 1oZXDB9ybhX+tWcSb2W/PZdwfhpndH0+/E0CrN8ZeoihyFsdxRZbVhvRC0qVoBGVbdP/ mfIbtSgVyP2Hg5NFeFxNs2eePudXkESuG3pTsc3XbtaeCXAi3JlVxIohSVbW9UAqOAzX GCzI8CenBjICm6Nkuym/wIxaxHIVoyJt44yKBheMwDSH6GN+zp3Iog5FXgD9E4DSEEsd sUDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8R7vzE3sMCLc8J7Cy3dbusGdeTZZo2sinRkBhrCFmms=; b=fNK6I2z5b74QCm832t8TnQXlnnrO/gs2MvrJn1o5gGnv5kYoIc2U6Kdf3Zdwvro3Li THMDq0cNQhHs79qAthzai0uKzaqLcb8iAQxk2XJt9yeN6xLtN+vCrIYwudym9CNOZSdI fpxTjhZK5Hy1riEK3B8uQwe7R8XhadOgkJ1acBNc0K6sJT1C7mJUHlBauNgAs+M3Jdbz YDoohHfvIm6lGmPuObBvTWqa7BHOFf/0HJv5TBemzNyxlI0bpJcYWx/SVwWOsQdos9MI qLWuCwU3Csbdhs2bxldGtTf72BKrlb0+PrdF88c58Rg7xnWMjaFEldNrbrhAP2Am3D1W RNtw== X-Gm-Message-State: AOAM53250Cke1zojy6IkZsNNjlDMUGMkV73BOO+1chvfj2Kyrury7wFS M/tBDR87tYOEzSXWI7q/793KM981FS5xsWZ1I2Q= X-Google-Smtp-Source: ABdhPJz/iJbO1+nGINTuz8kFu1jMtHs4zerb1uteu5ERhzJm1QbC8Dwd/Dv4EFWPHaHVIu7q2TjJ3GL4VMz7W4JsHG8= X-Received: by 2002:a05:6638:614:: with SMTP id g20mr2722369jar.135.1625201153073; Thu, 01 Jul 2021 21:45:53 -0700 (PDT) MIME-Version: 1.0 References: <20210701141011.785641-1-anthony.perard@citrix.com> <20210701141011.785641-32-anthony.perard@citrix.com> In-Reply-To: <20210701141011.785641-32-anthony.perard@citrix.com> From: Alistair Francis Date: Fri, 2 Jul 2021 14:45:27 +1000 Message-ID: Subject: Re: [XEN PATCH v6 31/31] build,riscv: tell the build system about riscv64/head.S To: Anthony PERARD Cc: "open list:X86" , Bob Eshleman , Alistair Francis , Connor Davis Content-Type: text/plain; charset="UTF-8" On Fri, Jul 2, 2021 at 12:22 AM Anthony PERARD wrote: > > This allows to `make arch/riscv/riscv64/head.o`. > > Example of rune on a fresh copy of the repository: > make XEN_TARGET_ARCH=riscv64 CROSS_COMPILE=riscv64-linux-gnu- KBUILD_DEFCONFIG=tiny64_defconfig arch/riscv/riscv64/head.o > > Signed-off-by: Anthony PERARD Reviewed-by: Alistair Francis Alistair > --- > xen/arch/riscv/riscv64/Makefile | 1 + > 1 file changed, 1 insertion(+) > create mode 100644 xen/arch/riscv/riscv64/Makefile > > diff --git a/xen/arch/riscv/riscv64/Makefile b/xen/arch/riscv/riscv64/Makefile > new file mode 100644 > index 000000000000..15a4a65f6615 > --- /dev/null > +++ b/xen/arch/riscv/riscv64/Makefile > @@ -0,0 +1 @@ > +extra-y += head.o > -- > Anthony PERARD > > From xen-devel-bounces@lists.xenproject.org Fri Jul 02 09:31:55 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Jul 2021 09:31:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149095.275585 (Exim 4.92) (envelope-from ) id 1lzFWI-00086Z-Ky; Fri, 02 Jul 2021 09:31:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149095.275585; Fri, 02 Jul 2021 09:31:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzFWI-00086S-Hk; Fri, 02 Jul 2021 09:31:34 +0000 Received: by outflank-mailman (input) for mailman id 149095; Fri, 02 Jul 2021 09:31:33 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzFWH-00086J-3M for xen-devel@lists.xenproject.org; Fri, 02 Jul 2021 09:31:33 +0000 Received: from EUR03-VE1-obe.outbound.protection.outlook.com (unknown [40.107.5.55]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 18c9b473-f96f-42f0-87e2-392c2b5709c4; Fri, 02 Jul 2021 09:31:30 +0000 (UTC) Received: from AM4PR05CA0022.eurprd05.prod.outlook.com (2603:10a6:205::35) by PAXPR08MB6955.eurprd08.prod.outlook.com (2603:10a6:102:1da::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4264.19; Fri, 2 Jul 2021 09:31:18 +0000 Received: from VE1EUR03FT030.eop-EUR03.prod.protection.outlook.com (2603:10a6:205:0:cafe::38) by AM4PR05CA0022.outlook.office365.com (2603:10a6:205::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.23 via Frontend Transport; Fri, 2 Jul 2021 09:31:18 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT030.mail.protection.outlook.com (10.152.18.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.22 via Frontend Transport; Fri, 2 Jul 2021 09:31:17 +0000 Received: ("Tessian outbound 80741586f868:v97"); Fri, 02 Jul 2021 09:31:17 +0000 Received: from bc0f1798548d.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 68A4D265-0723-4ECC-9A55-98121966B23C.1; Fri, 02 Jul 2021 09:30:39 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id bc0f1798548d.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 02 Jul 2021 09:30:39 +0000 Received: from PAXPR08MB6816.eurprd08.prod.outlook.com (2603:10a6:102:130::10) by PR3PR08MB5866.eurprd08.prod.outlook.com (2603:10a6:102:85::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.23; Fri, 2 Jul 2021 09:30:30 +0000 Received: from PAXPR08MB6816.eurprd08.prod.outlook.com ([fe80::7cfd:a8eb:b25a:f025]) by PAXPR08MB6816.eurprd08.prod.outlook.com ([fe80::7cfd:a8eb:b25a:f025%7]) with mapi id 15.20.4264.026; Fri, 2 Jul 2021 09:30:30 +0000 Received: from smtpclient.apple (82.8.129.65) by LO2P123CA0021.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:a6::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.22 via Frontend Transport; Fri, 2 Jul 2021 09:30:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 18c9b473-f96f-42f0-87e2-392c2b5709c4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=afZC5+m0/GvuAmPp0xHyVWxSco3LvhffrIB4q/FSOh8=; b=K+y8FldURuIGqC3iYIwubf4Om2Du1QiQVNAUYgbqiB2njaykVtrfGA5tqqWMb60nkTo/pQQ9/leJ9N/VT6DtdrIDelSX3gMMJXB5JL8r0nulPvJNyzkGEKpIxXsMuMfskk138yBFyQYqfls+C39O1KXuffmsYoOPmd9H9XdHIeQ= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: c7c573d22bb97714 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Nqr1SwRXFlxau1MXEPGw+/kHHLsKeEZIAhlDzrfHqhrWeUuW+Z4jc1HEPiLnPK0GEOOzbkYWauI5ET153HIXfRl19r4W9gKygPPBgA646n72Xshif56rhaUPDrMtQVu9w78tYNkyQw9pILR6PQtsFGorZqT6fsaEFHd4iM5ebyyggC0PW0YuCVlpOsOH5e68KWkMecQa5JVH4yD+ML9aTNhS6XchXgkKdlb9fzvaIm7T4m/b7tQPXkPN6k87MHiz+s7szj3gznqlTCaihz1i48bU3fXFKwEF/nXbuaSW7ZfF5Di/rED1FFigK7noJKOhYg9pSNxv6v9j1NXUU+Mz2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=afZC5+m0/GvuAmPp0xHyVWxSco3LvhffrIB4q/FSOh8=; b=RNIBMnT4ahWJSgVNSI6QU70oX+bR2X2NKAVPc58svowFUgrySmHllZKjSnaedcAT6JSgriDgxYXqHsBpP/owEKCgdVbMzrFBo+VSvQVgLn10iorh6DUT9QkYsaQ+16kqtcctlrS7hFL7bT1uFx9sr4k763pMCo5KksQCWb2f6TaVD2bFmZTxtRprefSB+22tn7StuqxKWqv+hbdkioNi/vBURysh0vTkmSNjEXdVq9t5smeXTAccMdPeBpbFeNL+zgPNngEb3NH2QfMThNMe+LfVfRk11fPYD2tpdF5zRy84rQUsjesadRIL3vUHiCLnpacdMrf/YElviRyL91P4FQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=afZC5+m0/GvuAmPp0xHyVWxSco3LvhffrIB4q/FSOh8=; b=K+y8FldURuIGqC3iYIwubf4Om2Du1QiQVNAUYgbqiB2njaykVtrfGA5tqqWMb60nkTo/pQQ9/leJ9N/VT6DtdrIDelSX3gMMJXB5JL8r0nulPvJNyzkGEKpIxXsMuMfskk138yBFyQYqfls+C39O1KXuffmsYoOPmd9H9XdHIeQ= Authentication-Results-Original: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=arm.com; Content-Type: text/plain; charset=utf-8 Subject: Re: [PATCH v6 7/9] docs: Change Makefile and sphinx configuration for doxygen From: Luca Fancellu In-Reply-To: Date: Fri, 2 Jul 2021 10:30:23 +0100 Cc: xen-devel@lists.xenproject.org, Bertrand Marquis , wei.chen@arm.com, Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Julien Grall , Wei Liu Content-Transfer-Encoding: quoted-printable Message-Id: <7C3269F1-3C61-4F39-82F9-9DE4C563849B@arm.com> References: <20210510084105.17108-1-luca.fancellu@arm.com> <20210510084105.17108-8-luca.fancellu@arm.com> <1FC1E8DF-8AED-4ABD-BE9A-DBBD9D66EDBB@arm.com> To: Stefano Stabellini X-Mailer: Apple Mail (2.3654.100.0.2.22) X-Originating-IP: [82.8.129.65] X-ClientProxiedBy: LO2P123CA0021.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:a6::33) To PAXPR08MB6816.eurprd08.prod.outlook.com (2603:10a6:102:130::10) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: db3f9d5b-1269-44d7-ce11-08d93d3c250e X-MS-TrafficTypeDiagnostic: PR3PR08MB5866:|PAXPR08MB6955: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:4941;OLM:4941; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: YCRIufPq1sbx7UI19GfoxIjo1SlxgrYbFQ5rfa3oOZw4zBT3Qoh7TEW8xhga1YFq+Rmr/OyoHgyacCe15ZRKSreO9GDOb8nT3wvzLjOTeIiaNLwRZQ4U3d7bM7BqE92zCqnklhecclldsXvAK5fbvQ4WJAnau5geTLopjkUXhs+rfFy9IQb3KGR01V4e+8A9M/e9aCYXCIFjcIPlLaQKuOm6K4WV4znzotgr6iHX2KctUF38ba6VkyjV6ZEXwp5OL3dSHbzOFT/cYBGNc/0kIngy+jFqejc9v2Fd6GriQo12fcVHfn0AYKe6MFlx5rQdhBFMeW2s/+ru0+PoS8BVS5+vpcoB/Jf1JPbslri/3TXl5hvrjUHTC0nZFdXDId5grjjbpIOMONodDMSs0IL9sDWcCd9ROGc/kDPnqW/5qYIW1rRz/LKWrPxkPq2fxZERMC5IjPK0WcYynpE5vqWH3XNdhH/OCu3BM+0g88YCECH6+dg7oOpjz76LWbsXva2mqjbE7GoaWrHLm9NFMmdMovF0u/41VlVcGHEZMjUCfB/JOKo0wACvespH4M3fkSBFIp+RLdrARTnWaKGwGC9IN57xURWmL75YYb/dFdfcp7XQS8xra8s5damxxx3n9vU5ljW2SxlIig8KwcCxyXcC8SMJMwIk/NFd9+tj+fMG+J4IpuiwEumKAiz0VX5psoexxPENfgDECNdEfS8Pt790x+LkUki8iitAY8Pp4GSGl90= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB6816.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(136003)(39850400004)(346002)(366004)(376002)(26005)(2616005)(53546011)(16526019)(83380400001)(6486002)(186003)(38100700002)(2906002)(66476007)(66946007)(8676002)(44832011)(66556008)(52116002)(956004)(6512007)(5660300002)(478600001)(38350700002)(30864003)(6506007)(54906003)(6916009)(86362001)(4326008)(8936002)(36756003)(33656002)(316002)(6666004)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TkpCbzgrUlVYUzJMU1VOOEdWZ0Z2ejF2R0ZYK3JGQ0VkWGpSV3JmUEhrbVdj?= =?utf-8?B?K1lPZW84WXZVMDc1TlBSWGxMVW5QemJSRStRaG14cXhZeUJGWjl4R3pOajU2?= =?utf-8?B?VEtCSjNRYTRKenhpcVFhdUxqOTIzbml1VEZYb2JySHpjb05oWVZwb0hmZTB5?= =?utf-8?B?VFRmeXhMMjJkRWNldUE4SkdhSE5lR05kNGJBQUxmOGZUL3IvWkFWN0ZuVzhX?= =?utf-8?B?SUNJUW1NZm9wcUN2QlZ3bnRjZ1RwSmg1VUZzanNkRkZYQkppTzIySDArZzg5?= =?utf-8?B?eHM4NGRDTUxlMzhCTEZEeksrSnZkMDhTUHZSRnBya2c4d2xwMkUyUC8vYjdU?= =?utf-8?B?cUJIb0RSeTNWY0Y4eWkvTUhhYkQzVEdBbEtRanNRYVhmUTZicmxsU3pySVE5?= =?utf-8?B?OWxhRFFXakk3ZHlETmpSbjNOVWlaQi9WZGdnVy95TG5EMHd0emptdXBuVUVh?= =?utf-8?B?akZZczRURmMxYXFlb3VKazA1aEMrRlNWYi92VU5mb3JVWFVCTWFuY1dhU0NP?= =?utf-8?B?ZmpOYm9HQ0R1K1Z0N3BLbE5jZHBxOFp0KzQyY2NhRVV6Z1BQOUxuM2xZNE9F?= =?utf-8?B?WUJoWkpIZGVMa3o3clBqaTVGbmRSVFBNWTU0N3oxS3RQQTRGN2JhVGo5U295?= =?utf-8?B?Y3E3ZVJuYjZlSUNJR0RlL3FLZmN1UVJzQVZGZEsxMXA2aGVXeDBOM0hDU25r?= =?utf-8?B?bksydWlCYVdzbjd5R085dDJIYWR5TjVBS0xpTEUvRmE5QlNsczh3VnhrVEp1?= =?utf-8?B?VU9WZUJOL0xuNUZZSzVpekd4YUxGUVR4c3JDNXBUK2ZrY1NvaS9CTEx0ZWhQ?= =?utf-8?B?MUFCUTV0REJKTTJPeHNKQ0IyZnV0dFR1LzlTMTRZWXlZQzByZzZIT2RGOFBM?= =?utf-8?B?S0xhSllZbnJwYllkY3pxTHZCQUVpQXNoWDczYkR0a1hhSjRWUFM1ZFNMVXd6?= =?utf-8?B?cEZxUEJCcTBOQlQwU0RuSEtQaEhBdllkNkNicllUY3ZPM08wT0dvNWI3NzVG?= =?utf-8?B?NGRkY3c4a3VlbVg4eFhUc1MxWVcvc2R0MjNWTHRFWDFNa2ovWmxwU1RlclJL?= =?utf-8?B?QU1PNFBVY25FNXAwS21vMWd0UUFmeHltMUg0Zk9mQTJ0Z0txcTQ4dmFCcy9p?= =?utf-8?B?eXF2OTBid2pLWXNTNWVmZUFXVGNZNy9LeDV3ejdHMDM4SCsvaHVoMEJSbjlT?= =?utf-8?B?T1BvUjgyckRkL1JtaTJPWGpGSm1pc1dZRE0vMEtWL2k0aytKTU0xNGwwbXlR?= =?utf-8?B?b1IzdFYzRmhiMEkwWURZVERNcVpTMDN1ZlB6WjNxZENZTkRCSjlMMSswempI?= =?utf-8?B?S1JpSjRwWFdnb0E3a2ZrVkthdTc0b1o5OWRaSzVBTXJuUGJxd3BPNkZIU2R1?= =?utf-8?B?NGdJRjdjVTBZU1FKTThXWXBPLzZEVGhwME9sZGhtc1ByWkxZS3ppN0szaTVE?= =?utf-8?B?WEdQb3FRNFRNMUdkZVJJQm1iVXVPeno1OTM2MzVtajQrTC8xbzBVRHkwenpC?= =?utf-8?B?MHNCc3pKbzFuU0F0VnJsU1ptTFI4MVNDUUorRm5BeTZETnpkNlJieldac0wz?= =?utf-8?B?VDNvNC84NlRaTklUcWlwcDE4RnNiaHhkODJvYWpVT2Z3Mk9UWm5UdnBBbkRC?= =?utf-8?B?eUFLM292bzhXOXVJclZiZEpmbFVjUThHRHhtdHJDcmpEN002ZXd3aitzWFpt?= =?utf-8?B?Ly8vajRGVTJVc29sMThUbXNpV1cxR2I2dkVDcVJGTDVpTTJPdFErR0FHRS9t?= =?utf-8?Q?ypkmD3k751ZJCAQRvdrcIUD7MJkCW/H6vz2lrli?= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR08MB5866 Original-Authentication-Results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT030.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 4f38b49f-1ab9-4441-bc3b-08d93d3c0840 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yO+BJL5dldzcMznlFRlymTfvKTmr3zLujwX+Qv5DsSMgEXJwVQycydtD0YqpcvlJhetbrt27CUzteC8MReStj3c3B/qqyzuknZDGKjUsFWKrOu1fEo1+f79WOT0j7kb4uRC0fQpoQY9tbem2VjfTQuMmQS/p/TKgqm6BPfuSOom95AgLnJ2LsKT/X2a6+SrM/iVjE0Rfbs9nE7jImRQ6qk4HMZy4VFSwekVq/SVWmd1BuuqfEKBnMmJJiN+N5KxqZvjd8KeIthl/r/+Q5XUvKdihGFKOcHInYTAIsGjTX6DC0qY9th/dHsgD9vTqTLDLdBAuqGvHkQC4J45u3+OvU6J+EV86DVdLtBFLV7G/0AYLOepfERgqrRz/pk4SCLAWcqPmIc+Mlpf/hG720lTlPaLkDXn+b+xEXft3C3QBPKVrohUa22n+TpGTlALQfN66mGNKYVcrXbttYotapL64KMzE7w60mzlRxZlH/wQz7XeU9g9ELGwazLAJCrhSQyMs8L7vCbJB7xMDg1HIZ5lpgZZEGQn+h2/JPMt8g7WHYFhKkCYmkxfnB+8LuEx53I9UwVGoQOvi3XUXiJQYeKrmTVpZ8mOQuuIQhdtnMzL3jLzhPq+xWzLykw6h0e5JRJ11h5lH4Wp1H+aT8jvHUONCuwybYqqDyLAu8J6ZhcM1U+e2/gzpjV4R5MhETA7GLmNQDs6zTw3dx6Fz23TbqxeAvw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(346002)(136003)(396003)(39860400002)(376002)(46966006)(36840700001)(478600001)(186003)(70586007)(26005)(956004)(6512007)(33656002)(8676002)(30864003)(70206006)(82310400003)(316002)(36860700001)(16526019)(6862004)(54906003)(6486002)(5660300002)(356005)(4326008)(81166007)(83380400001)(6666004)(47076005)(8936002)(86362001)(336012)(82740400003)(53546011)(44832011)(2616005)(2906002)(36756003)(6506007);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jul 2021 09:31:17.7075 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: db3f9d5b-1269-44d7-ce11-08d93d3c250e X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT030.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6955 Hi Stefano, > On 1 Jul 2021, at 18:43, Stefano Stabellini wrot= e: >=20 > On Thu, 1 Jul 2021, Luca Fancellu wrote: >>> On 24 Jun 2021, at 00:33, Stefano Stabellini w= rote: >>>=20 >>> On Mon, 10 May 2021, Luca Fancellu wrote: >>>> Modify docs/Makefile to call doxygen and generate sphinx >>>> html documentation given the doxygen XML output. >>>>=20 >>>> Modify docs/conf.py sphinx configuration file to setup >>>> the breathe extension that works as bridge between >>>> sphinx and doxygen. >>>>=20 >>>> Add some files to the .gitignore to ignore some >>>> generated files for doxygen. >>>>=20 >>>> Signed-off-by: Luca Fancellu >>>> --- >>>> .gitignore | 6 ++++++ >>>> docs/Makefile | 42 +++++++++++++++++++++++++++++++++++++++--- >>>> docs/conf.py | 48 +++++++++++++++++++++++++++++++++++++++++++++--- >>>> 3 files changed, 90 insertions(+), 6 deletions(-) >>>>=20 >>>> diff --git a/.gitignore b/.gitignore >>>> index 1c2fa1530b..d271e0ce6a 100644 >>>> --- a/.gitignore >>>> +++ b/.gitignore >>>> @@ -58,6 +58,12 @@ docs/man7/ >>>> docs/man8/ >>>> docs/pdf/ >>>> docs/txt/ >>>> +docs/doxygen-output >>>> +docs/sphinx >>>> +docs/xen.doxyfile >>>> +docs/xen.doxyfile.tmp >>>> +docs/xen-doxygen/doxygen_include.h >>>> +docs/xen-doxygen/doxygen_include.h.tmp >>>> extras/mini-os* >>>> install/* >>>> stubdom/*-minios-config.mk >>>> diff --git a/docs/Makefile b/docs/Makefile >>>> index 8de1efb6f5..2f784c36ce 100644 >>>> --- a/docs/Makefile >>>> +++ b/docs/Makefile >>>> @@ -17,6 +17,18 @@ TXTSRC-y :=3D $(sort $(shell find misc -name '*.txt= ' -print)) >>>>=20 >>>> PANDOCSRC-y :=3D $(sort $(shell find designs/ features/ misc/ process/= specs/ \( -name '*.pandoc' -o -name '*.md' \) -print)) >>>>=20 >>>> +# Directory in which the doxygen documentation is created >>>> +# This must be kept in sync with breathe_projects value in conf.py >>>> +DOXYGEN_OUTPUT =3D doxygen-output >>>> + >>>> +# Doxygen input headers from xen-doxygen/doxy_input.list file >>>> +DOXY_LIST_SOURCES !=3D cat "xen-doxygen/doxy_input.list" >>>> +DOXY_LIST_SOURCES :=3D $(realpath $(addprefix $(XEN_ROOT)/,$(DOXY_LIS= T_SOURCES))) >>=20 >> Hi Stefano, >>=20 >>>=20 >>> I cannot find exactly who is populating doxy_input.list. I can see it i= s >>> empty in patch #6. Does it get populated during the build? >>=20 >> doxy_input.list is the only file that should be modified by the develope= r when he/she wants to add documentation >> for a new file to be parsed by Doxygen, in my patch about documenting gr= ant_tables.h you can see I add >> there the path =E2=80=9Cxen/include/public/grant_table.h" >=20 > OK, thanks. I missed that addition. >=20 >=20 >>>=20 >>>> +DOXY_DEPS :=3D xen.doxyfile \ >>>> + xen-doxygen/mainpage.md \ >>>> + xen-doxygen/doxygen_include.h >>>> + >>>> # Documentation targets >>>> $(foreach i,$(MAN_SECTIONS), \ >>>> $(eval DOC_MAN$(i) :=3D $(patsubst man/%.$(i),man$(i)/%.$(i), \ >>>> @@ -46,8 +58,28 @@ all: build >>>> build: html txt pdf man-pages figs >>>>=20 >>>> .PHONY: sphinx-html >>>> -sphinx-html: >>>> - sphinx-build -b html . sphinx/html >>>> +sphinx-html: $(DOXY_DEPS) $(DOXY_LIST_SOURCES) >>>> +ifneq ($(SPHINXBUILD),no) >>>=20 >>> This check on SPHINXBUILD is new, it wasn't there before. Why do we nee= d >>> it now? We are not really changing anything in regards to Sphinx, just >>> adding Doxygen support. Or was it a mistake that it was missing even >>> before this patch? >>=20 >> Yes this is new, I saw that we didn=E2=80=99t look if sphinx was install= ed in the system, so now we did >=20 > In that case, I think anything related to SPHINXBUILD and whether sphinx > is installed or not, should be a separate patch at the beginning of the > series. It could be committed independently before the rest of the > series. When we get to this patch, SPHINXBUILD should be already there. I=E2=80=99ve introduced SPHINXBUILD in this patch: [PATCH v6 5/9] docs: add= checks to configure for sphinx and doxygen, In your commend do you mean that you would like it to be outside this serie= and this serie to be based on top of that one? >=20 >=20 >>>> + $(DOXYGEN) xen.doxyfile >>>> + XEN_ROOT=3D$(realpath $(XEN_ROOT)) $(SPHINXBUILD) -b html . sphinx/h= tml >>>> +else >>>> + @echo "Sphinx is not installed; skipping sphinx-html documentation." >>>> +endif >>>> + >>>> +xen.doxyfile: xen.doxyfile.in xen-doxygen/doxy_input.list >>>> + @echo "Generating $@" >>>> + @sed -e "s,@XEN_BASE@,$(realpath $(XEN_ROOT)),g" $< \ >>>> + | sed -e "s,@DOXY_OUT@,$(DOXYGEN_OUTPUT),g" > $@.tmp >>>> + @$(foreach inc,\ >>>> + $(DOXY_LIST_SOURCES),\ >>>> + echo "INPUT +=3D \"$(inc)\"" >> $@.tmp; \ >>>> + ) >>>> + mv $@.tmp $@ >>>> + >>>> +xen-doxygen/doxygen_include.h: xen-doxygen/doxygen_include.h.in >>>> + @echo "Generating $@" >>>> + @sed -e "s,@XEN_BASE@,$(realpath $(XEN_ROOT)),g" $< > $@.tmp >>>> + @mv $@.tmp $@ >>>=20 >>> Is the absolute path required? If not, we can probably get rid of this >>> generation step and simply have the relative path in >>> xen-doxygen/doxygen_include.h. I think this could apply to >>> xen.doxyfile.in above. >>=20 >> Unfortunately yes, the doxygen_include.h is a file that is included in e= very documented header before=20 >> starting the doxygen parser, since we don=E2=80=99t have all the headers= in one path, it is impossible to have here >> a relative path that is good for every header in Xen. >=20 > OK :-/ >=20 >=20 >>>=20 >>>=20 >>>> .PHONY: html >>>> html: $(DOC_HTML) html/index.html >>>> @@ -71,7 +103,11 @@ clean: clean-man-pages >>>> $(MAKE) -C figs clean >>>> rm -rf .word_count *.aux *.dvi *.bbl *.blg *.glo *.idx *~ >>>> rm -rf *.ilg *.log *.ind *.toc *.bak *.tmp core >>>> - rm -rf html txt pdf sphinx/html >>>> + rm -rf html txt pdf sphinx $(DOXYGEN_OUTPUT) >>>> + rm -f xen.doxyfile >>>> + rm -f xen.doxyfile.tmp >>>> + rm -f xen-doxygen/doxygen_include.h >>>> + rm -f xen-doxygen/doxygen_include.h.tmp >>>>=20 >>>> .PHONY: distclean >>>> distclean: clean >>>> diff --git a/docs/conf.py b/docs/conf.py >>>> index 50e41501db..a48de42331 100644 >>>> --- a/docs/conf.py >>>> +++ b/docs/conf.py >>>> @@ -13,13 +13,17 @@ >>>> # add these directories to sys.path here. If the directory is relative= to the >>>> # documentation root, use os.path.abspath to make it absolute, like sh= own here. >>>> # >>>> -# import os >>>> -# import sys >>>> +import os >>>> +import sys >>>> # sys.path.insert(0, os.path.abspath('.')) >>>>=20 >>>>=20 >>>> # -- Project information ---------------------------------------------= -------- >>>>=20 >>>> +if "XEN_ROOT" not in os.environ: >>>> + sys.exit("$XEN_ROOT environment variable undefined.") >>>> +XEN_ROOT =3D os.path.abspath(os.environ["XEN_ROOT"]) >>>> + >>>> project =3D u'Xen' >>>> copyright =3D u'2019, The Xen development community' >>>> author =3D u'The Xen development community' >>>> @@ -35,6 +39,7 @@ try: >>>> xen_subver =3D line.split(u"=3D")[1].strip() >>>> elif line.startswith(u"export XEN_EXTRAVERSION"): >>>> xen_extra =3D line.split(u"=3D")[1].split(u"$", 1)[0].strip= () >>>> + >>>=20 >>> spurious change? >>=20 >> I think I=E2=80=99ve intentionally added a new line to separate the code= from the except: below, >> but if it is a problem I can remove it >=20 > Better to remove it or to move it to a separate patch Sure I=E2=80=99ll fix it >=20 >=20 >>>=20 >>>> except: >>>> pass >>>> finally: >>>> @@ -44,6 +49,15 @@ finally: >>>> else: >>>> version =3D release =3D u"unknown version" >>>>=20 >>>> +try: >>>> + xen_doxygen_output =3D None >>>> + >>>> + for line in open(u"Makefile"): >>>> + if line.startswith(u"DOXYGEN_OUTPUT"): >>>> + xen_doxygen_output =3D line.split(u"=3D")[1].strip() >>>> +except: >>>> + sys.exit("DOXYGEN_OUTPUT variable undefined.") >>>=20 >>> This is a bit strange: isn't there a better way to get the >>> DOXYGEN_OUTPUT variable than reading the Makefile? >>>=20 >>> At that point I think it would be better to define DOXYGEN_OUTPUT a >>> second time in conf.py. But maybe it could be passed as an evironmental >>> variable? >>=20 >> Yes we could pass it as an environment variable as we do with XEN_ROOT, >> I will fix it in a next release. >=20 > Great >=20 >=20 >=20 >>>=20 >>>> # -- General configuration -------------------------------------------= -------- >>>>=20 >>>> # If your documentation needs a minimal Sphinx version, state it here. >>>> @@ -53,7 +67,8 @@ needs_sphinx =3D '1.4' >>>> # Add any Sphinx extension module names here, as strings. They can be >>>> # extensions coming with Sphinx (named 'sphinx.ext.*') or your custom >>>> # ones. >>>> -extensions =3D [] >>>> +# breathe -> extension that integrates doxygen xml output with sphinx >>>> +extensions =3D ['breathe'] >>>>=20 >>>> # Add any paths that contain templates here, relative to this director= y. >>>> templates_path =3D ['_templates'] >>>> @@ -175,6 +190,33 @@ texinfo_documents =3D [ >>>> 'Miscellaneous'), >>>> ] >>>>=20 >>>> +# -- Options for Breathe extension ----------------------------------= --------- >>>> + >>>> +breathe_projects =3D { >>>> + "Xen": "{}/docs/{}/xml".format(XEN_ROOT, xen_doxygen_output) >>>> +} >>>> +breathe_default_project =3D "Xen" >>>> + >>>> +breathe_domain_by_extension =3D { >>>> + "h": "c", >>>> + "c": "c", >>>> +} >>>> +breathe_separate_member_pages =3D True >>>> +breathe_show_enumvalue_initializer =3D True >>>> +breathe_show_define_initializer =3D True >>>> + >>>> +# Qualifiers to a function are causing Sphihx/Breathe to warn about >>>> +# Error when parsing function declaration and more. This is a list >>>> +# of strings that the parser additionally should accept as >>>> +# attributes. >>>> +cpp_id_attributes =3D [ >>>> + '__syscall', '__deprecated', '__may_alias', >>>> + '__used', '__unused', '__weak', >>>> + '__DEPRECATED_MACRO', 'FUNC_NORETURN', >>>> + '__subsystem', >>>=20 >>> Should we also have any of following: >>>=20 >>> __packed >>> __init >>> __attribute__ >>> __aligned__ >>>=20 >>> in the list? In any case, we don't have to add them right now, we could >>> add them later as we expand Doxygen coverage if they become needed. >>=20 >> Sure it is possible, I can add them now since I have to push a fix for t= his patch >> If you want. >=20 > I would add them now even if they are not strictly required to parse the > public headers. But this is the kind of thing where others might have a > different opinion. Ok I will add them now if no one object to that. Cheers, Luca From xen-devel-bounces@lists.xenproject.org Fri Jul 02 09:55:41 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Jul 2021 09:55:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149100.275595 (Exim 4.92) (envelope-from ) id 1lzFtX-000201-Dm; Fri, 02 Jul 2021 09:55:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149100.275595; Fri, 02 Jul 2021 09:55:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzFtX-0001zu-AQ; Fri, 02 Jul 2021 09:55:35 +0000 Received: by outflank-mailman (input) for mailman id 149100; Fri, 02 Jul 2021 09:55:33 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzFtV-0001zo-EB for xen-devel@lists.xenproject.org; Fri, 02 Jul 2021 09:55:33 +0000 Received: from EUR03-DB5-obe.outbound.protection.outlook.com (unknown [40.107.4.67]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 8fbf92dc-1a8b-4f12-99ea-c3a9077968d1; Fri, 02 Jul 2021 09:55:31 +0000 (UTC) Received: from AM5PR0402CA0019.eurprd04.prod.outlook.com (2603:10a6:203:90::29) by VE1PR08MB4912.eurprd08.prod.outlook.com (2603:10a6:802:a9::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.23; Fri, 2 Jul 2021 09:55:29 +0000 Received: from VE1EUR03FT023.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:90:cafe::26) by AM5PR0402CA0019.outlook.office365.com (2603:10a6:203:90::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.22 via Frontend Transport; Fri, 2 Jul 2021 09:55:28 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT023.mail.protection.outlook.com (10.152.18.133) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.22 via Frontend Transport; Fri, 2 Jul 2021 09:55:28 +0000 Received: ("Tessian outbound 1763b1d84bc3:v97"); Fri, 02 Jul 2021 09:55:28 +0000 Received: from aa0dd6780e09.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id B04FDB58-CCF6-4D29-92AB-2AE20734A897.1; Fri, 02 Jul 2021 09:54:44 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id aa0dd6780e09.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 02 Jul 2021 09:54:44 +0000 Received: from AS8PR08MB6919.eurprd08.prod.outlook.com (2603:10a6:20b:39e::10) by AM6PR08MB3880.eurprd08.prod.outlook.com (2603:10a6:20b:86::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.26; Fri, 2 Jul 2021 09:54:42 +0000 Received: from AS8PR08MB6919.eurprd08.prod.outlook.com ([fe80::2de3:452a:87cf:3ff5]) by AS8PR08MB6919.eurprd08.prod.outlook.com ([fe80::2de3:452a:87cf:3ff5%9]) with mapi id 15.20.4264.026; Fri, 2 Jul 2021 09:54:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8fbf92dc-1a8b-4f12-99ea-c3a9077968d1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MAeN4g9hFqVqKa89MWTgNV1qnWJrfTy96z5kl5qbVYA=; b=MNXREkDXf83qR398MUpiuQJLdvHrPl3X9Qz5gZAAWYOtNt75pd9BitsZpVK02DW9fztpmkMMoZRTF7sZOqf86uep+OpQhveni7byob6+rKnO4mbDpqFFPZo3fCErnHDZeoeW6mkxcegkfuUBWYlMMb8nqmsDCBatiC0XMQx/a/I= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: ebc7a716a0c72ea9 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cbFLS3PzWzUmJyoa9Or9fsW3CJC5o6FOGVqf26D2iERwhuaOsKuq5gzrUt0yRFxR1R1f8Wexjx/ZZJhHl2idazLC89VXSRAnpVZwFO/NKB/IklB+pN3dmBHjLbrbaObvDycj2TaFZVdG6kYbAmv6ZbafRWoslStY2W7MKd3TPm3/Hqg3LeeKEY47vuoLRUsGdQzjOOmRX/Xy1fu5UikeE8Oomld+w5AkKhRRxpOz0qdukJgF7nfF4Dys76qHdPNFEJu2JIPnMGzn/JNSunED+jzbyv38sOKhxAWH8dBd+GL4ByzFKtn6R77w0U5LbqSbnO+duewW6zqj0SOFTqK8hQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MAeN4g9hFqVqKa89MWTgNV1qnWJrfTy96z5kl5qbVYA=; b=HG+Gk7zB3fHUKzDVDLTTV1BHXkmia1NrPsbIn0C2hkY4U6ZZvCzzZ4X+6W/8JrK78zexZOqdmPYXxieKvz862ItYtEyZnXXQ+81pB4CmEZ/CbVNs/+hprJXWRkah66IRs8h1sqC06h5WTnvHZBwPNaP6rzbyVltz53POGfP8kMSIunfelu+0CkqYVbiHgcNgW+KxTmEISv4pg9fUZ0Ylv2YgE5nHnI20vEjIRC3N6Atz4U7kLqXlQlmLcRiOHwI9Izho0gesjNkfvzo/jisoHd3/g+Cfuv1M9GiuOO3V7hMp8uOP4g2V4aA1Fj6RyGCeN2eYRFjCSlxU3L8l22k5+Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MAeN4g9hFqVqKa89MWTgNV1qnWJrfTy96z5kl5qbVYA=; b=MNXREkDXf83qR398MUpiuQJLdvHrPl3X9Qz5gZAAWYOtNt75pd9BitsZpVK02DW9fztpmkMMoZRTF7sZOqf86uep+OpQhveni7byob6+rKnO4mbDpqFFPZo3fCErnHDZeoeW6mkxcegkfuUBWYlMMb8nqmsDCBatiC0XMQx/a/I= From: Rahul Singh To: Julien Grall CC: xen-devel , Bertrand Marquis , Stefano Stabellini , Volodymyr Babchuk Subject: Re: [PATCH] xen/arm: smmuv1: Fixed stream matching register allocation Thread-Topic: [PATCH] xen/arm: smmuv1: Fixed stream matching register allocation Thread-Index: AQHXaeBuO8lC15Rvy0GU2dq6zulC56ssS6GAgACREoCAAAMWgIACnQOA Date: Fri, 2 Jul 2021 09:54:41 +0000 Message-ID: <8BD37A47-7F82-4710-A37C-9C9C933913A9@arm.com> References: <612e7f61c19e60019bb7829888342fda95fd36be.1624546532.git.rahul.singh@arm.com> <11df0a34-724a-63ad-1822-4bd8aa364ab0@xen.org> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com; x-originating-ip: [80.1.41.211] x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: 0834fae0-2706-47c4-69a6-08d93d3f85bd x-ms-traffictypediagnostic: AM6PR08MB3880:|VE1PR08MB4912: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: qHGMzuIxcPRy0HgoUcHUwKbf/XpCK5P07x5yS8GU4kV/jyuIl0X/943gsNQuXSHtWxLmBTjiE+rbq0qUl3SS82zeXJURjz3ACuxzuAP8bRrkd/6KjhqI7HE7YXdBYJ5D1xPBY5EgGi8B4f1YxQHIacvfqf7DVZxX7zZyWb8Y8s44v2tsYocTngySrByPvzGNOp0X6KIrDB4lhDVOPZ97qYMCuuVDvB3vpB+18mgCz4kCeEdO5NheSqX0C4zAIFuDYpV44tVRWNtf0JX1zzVhFZwBnKwnj5i+ndG04GtFPga8cPcIaKeVNBRprWaKhk7rX2Y0ShXXPxXAyU2e59BA5MXy4/LwY1FbpKv1K0ppfBwkngF62ntN0fB2GvAPk45R6jJNAWT1F1Dwdv4g7Y3m4SdzrVlfxv3xUEnaovdkD5p0BciX4w1eRBGVjZa3YXoKwmBzIHivz+d85dqrMxW8on8C/pqKn1TBkAFloM7OMxc35JtnmlLhEDVoTdLuCveHvIbtd64J0T2Yh2H23I4TOkoELvAFKHbLdlb3cath6dl9gvotbuF4dh6VoWFTR4ai8X0sl1Bkl4T191TWga0IpAiP3+2f6CV2W9VYATrebK12S4uEBtqFQcG25jp8gFO/u4iqHj1eSy5qvKB5/5xxoUOntmDuLph0FViFFhQzITu+5gN6NBCqPcNkHWnc81IhyDHqnaDYg2+89xyoJMTz6A== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6919.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(136003)(376002)(366004)(39850400004)(396003)(8936002)(26005)(6506007)(53546011)(86362001)(4326008)(2616005)(36756003)(186003)(83380400001)(8676002)(64756008)(66476007)(33656002)(6512007)(122000001)(71200400001)(38100700002)(2906002)(6916009)(76116006)(91956017)(54906003)(66446008)(5660300002)(478600001)(66946007)(316002)(6486002)(66556008)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Il2Mn1fX1U/ECRXTvI1RMcLDkRebICnJ/bpMENTQgx0gGbmjEzaZErG+BFJn?= =?us-ascii?Q?GuqI1Dzfny8E6ZPncDagFaRVj4FAIrnMPM11gzCmS6Rlgx4T+gbxI+U/XRXU?= =?us-ascii?Q?cKNwqkAZ4LR0leSit0lnkJ5W0r8KREV4igr4xfyadXrCOVPQVipdAbpRcv3z?= =?us-ascii?Q?6BBLlEe5LV0/SHRaYE0wwZLIVcVTYofVw3QGzNm+q4y1ymz6YFE17TeZpFvB?= =?us-ascii?Q?76yHgn0KEZ7HjGLG+hl5tg0A6XokC1557HFDod5QNh6P1sQk1v4Uevf0j9z7?= =?us-ascii?Q?uhf+c4tLQaH4gQKrItM8pMkmVhvhrYa+NUxFP2uQZe1sc3ctKB8LJ9wG6gCU?= =?us-ascii?Q?260jlSp3hxL77L77wBDtmQV6Y9SqX/a0m9DwZVX0uDb62pe+W5qfioB+SLPG?= =?us-ascii?Q?scl3UC4M/8Nvaw16gSvJ8bTSnLXxiVLijRmZJoxrygNNnRX+ds09EDvJDadB?= =?us-ascii?Q?WlFQzYYvhQS1CRWXVvUpHcgYnhLXCRgOnRqyTLxpIUgxZ4l9xshbjdBFv4ZI?= =?us-ascii?Q?Yu8Tc8kPonHVFps7MNxG/uT5d73Lz5evD8rtho1KJJbvSVNbojmqdZVLPOuD?= =?us-ascii?Q?bOJpXbs1R3N0CfLTlwuxcXunrCsFRmehMyAMWpumJQ5WyGMaLmBsoEP3jPt9?= =?us-ascii?Q?VrpUy8cy/n4fuCMQcdV3sYWT79eAchvYQAuGAjL1F8AzEYbjV11Jgb2R7tmm?= =?us-ascii?Q?urlV0dpcU9Wpj/eXbbxUDBv+KFruUhiWMxw8s0EOr52NoDr+/WPeJVahE3Jy?= =?us-ascii?Q?IIQqgz0bekK6oGhObRCVsTbFLhNed7fvBQTzYp2dUnjVwdvgZxTL72oI0Scy?= =?us-ascii?Q?4ikxC9CqxmJtcpxEl358jI1orQ8YKcA2uXA89zcgh9uR0UryHZNxa7JQFkHg?= =?us-ascii?Q?wNVxl4hxPJKreVZ9/lBgmI/+sl4p2t/dYIsY13u0i17YoSr++FlJ5FbKE8GR?= =?us-ascii?Q?BWIAuOanQoQwaTAGw25faGkE4D4DIJ3ffRghAB/BavGvTWyFJa0FRt7ojtjw?= =?us-ascii?Q?9IptX//eIEMJhvEn3D8Y+R6VSk8s4eg/luYb/pl/iI8I/LC7fEr6/mtLRyKr?= =?us-ascii?Q?Q1cTis8aIq7VxMruUXAh2FCYDfRoiim2Y30oCtTToXmhVZWXNL2497/D05gH?= =?us-ascii?Q?hc3mUe1zZJqMXkaCA16lD9dXOayEBN5XiuxVxUB5j2JW4hld5T+vTO0pZD2U?= =?us-ascii?Q?yhJUITw6+zhzpscznxb4dEiNniWMqGbnE1AwatAvWX8aFx6jQu0rXyv5v8Lf?= =?us-ascii?Q?wxbhss7TvQQfykj3pSeHWAD74RyTEffE0a9y3MsGq905xA8dvFqM0Kwr0Zjg?= =?us-ascii?Q?OTao+ipjHweig/CZfGJA03uu?= Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3880 Original-Authentication-Results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT023.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: ba9d5ff7-9b82-436a-972b-08d93d3f6a12 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: G6Lqg5eGLpcQdNM3ZgZtvHg5lmtmy+uJ7pPjZ+3/ZJo3SuSzNxq2W59F/TQ5AzFrn9n1Kb4jo3AeMeWBfiPriZdWYTEA9l7++CehywaLFkFLPR5vYk7HG0oscSRPbgbVW14ybDmuH61youdxXr+k0x+NUIdbruRW1i2R+E8O+lhbfvWLk9V8VVbiCye5N0g2PjQk4Mk/caBS0JBQsZopWjl4OVNBiBpH63wqXJcMfTV89FAZTUSTNAiNQHtYSe2SJ0o7rrE/6NiE14gkrG6VndMKDPIDkKPhd3Z/Jy1cb9fUqomenauGkRYvHqrfgj3EZDR/bsGZfTYf/XxAJj5e+2KZWXCq6kmQv98LE9ACJ6F6DHpiCiWNX4DMyI7pYisM+WoXbXEtiyAdXYKMIQRHp2f5TQWyoOVXhnVj8J3K/J+JdxttfynkaDii14rV3kPBHh2RKNw1ztPoDOMoZHGE4VWy6hilgGWcimfl3rHI5IFe2XeOD0+XrnlaojRuv+CZqT/Ldgz1ONuiCnDGG+Z2Plh+70O28W18lnnEI0yQRRY9vKq67SIOu+PzCVzKvS5NmekrTSrParD7H3E2EY2EVqg9IeJi2SvWhqakHZaiLLX4FtmmqiC0xJdJwA5Z2qB0gKtJ5sGm7XjoQowpugm2km/Hz3alh9SLo04r91D2GrEgaWTwN45bcr2qO3IrGmxcZ6y1tOkhZShF43SwgOwGaA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(346002)(376002)(136003)(39850400004)(396003)(36840700001)(46966006)(478600001)(54906003)(6486002)(316002)(336012)(2616005)(6862004)(2906002)(81166007)(47076005)(8936002)(4326008)(33656002)(8676002)(82740400003)(107886003)(83380400001)(356005)(82310400003)(36860700001)(86362001)(70206006)(70586007)(6506007)(53546011)(6512007)(36756003)(5660300002)(26005)(186003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jul 2021 09:55:28.4453 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0834fae0-2706-47c4-69a6-08d93d3f85bd X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT023.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB4912 Hi Julien, > On 30 Jun 2021, at 7:00 pm, Julien Grall wrote: >=20 >=20 >=20 > On 30/06/2021 18:49, Rahul Singh wrote: >> Hi Julien, >=20 > Hi, >=20 >>> On 30 Jun 2021, at 10:09 am, Julien Grall wrote: >>>=20 >>> Hi Rahul, >>>=20 >>> On 25/06/2021 17:37, Rahul Singh wrote: >>>> SMR allocation should be based on the number of supported stream >>>> matching register for each SMMU device. >>>> Issue introduced by commit 5e08586afbb90b2e2d56c175c07db77a4afa873c >>>> when backported the patches from Linux to XEN to fix the stream match >>>> conflict issue when two devices have the same stream-id. >>>> Acked-by: Stefano Stabellini >>>> Tested-by: Stefano Stabellini >>>> Signed-off-by: Rahul Singh >>>> --- >>>> xen/drivers/passthrough/arm/smmu.c | 3 ++- >>>> 1 file changed, 2 insertions(+), 1 deletion(-) >>>> diff --git a/xen/drivers/passthrough/arm/smmu.c b/xen/drivers/passthro= ugh/arm/smmu.c >>>> index d9a3a0cbf6..da2cd457d7 100644 >>>> --- a/xen/drivers/passthrough/arm/smmu.c >>>> +++ b/xen/drivers/passthrough/arm/smmu.c >>>> @@ -149,6 +149,7 @@ typedef enum irqreturn irqreturn_t; >>>> #define kzalloc(size, flags) _xzalloc(size, sizeof(void *)) >>>> #define devm_kzalloc(dev, size, flags) _xzalloc(size, sizeof(void *)) >>>> #define kmalloc_array(size, n, flags) _xmalloc_array(size, sizeof(voi= d *), n) >>>> +#define kzalloc_array(size, n, flags) _xzalloc_array(size, sizeof(voi= d *), n) >>>> static void __iomem *devm_ioremap_resource(struct device *dev, >>>> struct resource *res) >>>> @@ -2221,7 +2222,7 @@ static int arm_smmu_device_cfg_probe(struct arm_= smmu_device *smmu) >>>> smmu->smr_mask_mask =3D smr >> SMR_MASK_SHIFT; >>>> /* Zero-initialised to mark as invalid */ >>>> - smmu->smrs =3D devm_kzalloc(smmu->dev, sizeof(*smmu->smrs), GFP_KER= NEL); >>>> + smmu->smrs =3D kzalloc_array(sizeof(*smmu->smrs), size, GFP_KERNEL)= ; >>>=20 >>> I noticed this is already in... However, I am a bit puzzled into why th= is was switched devm_kzalloc() to kzalloc_array(). This doesn't matter for = Xen as they are just wrappers to x*alloc() but a mention in the commit mess= age would have been useful. >> Yes we can use the devm_kzalloc(..) but then we have to pass (sizeof(*sm= mu->smrs) * size ) as size argument to devm_kzalloc(..) >> I thought for better code readability I will use kzalloc_array() as the = function name suggests we are allocating memory for an array. >=20 > My point is devm_k*alloc() and k*alloc() are quite different on the paper= . One will allocate memory for a given device while the other is unknown me= mory. >=20 > It would have been better to call the function devm_kzalloc_array() to ke= ep to keep the code coherent. Can you please send a patch to make the switc= h? Ok. I will modify the code as per your request as below . I will use devm_k= calloc(..) as this will be more coherent. diff --git a/xen/drivers/passthrough/arm/smmu.c b/xen/drivers/passthrough/a= rm/smmu.c index da2cd457d7..658c40433c 100644 --- a/xen/drivers/passthrough/arm/smmu.c +++ b/xen/drivers/passthrough/arm/smmu.c @@ -149,7 +149,8 @@ typedef enum irqreturn irqreturn_t; #define kzalloc(size, flags) _xzalloc(size, sizeof(void *)) #define devm_kzalloc(dev, size, flags) _xzalloc(size, sizeof(void *)) #define kmalloc_array(size, n, flags) _xmalloc_array(size, sizeof(void *)= , n) -#define kzalloc_array(size, n, flags) _xzalloc_array(size, sizeof(void *)= , n) +#define devm_kcalloc(dev, n, size, flags) \ + _xzalloc_array(size, sizeof(void *), n) =20 static void __iomem *devm_ioremap_resource(struct device *dev, struct resource *res) @@ -2222,7 +2223,8 @@ static int arm_smmu_device_cfg_probe(struct arm_smmu_= device *smmu) smmu->smr_mask_mask =3D smr >> SMR_MASK_SHIFT; =20 /* Zero-initialised to mark as invalid */ - smmu->smrs =3D kzalloc_array(sizeof(*smmu->smrs), size, GFP= _KERNEL); + smmu->smrs =3D devm_kcalloc(smmu->dev, size, sizeof(*smmu->= smrs), + GFP_KERNEL)= ; if (!smmu->smrs) return -ENOMEM; Regards, Rahul >=20 > Cheers, >=20 > --=20 > Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Jul 02 10:34:05 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Jul 2021 10:34:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149104.275607 (Exim 4.92) (envelope-from ) id 1lzGUa-00069T-Hb; Fri, 02 Jul 2021 10:33:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149104.275607; Fri, 02 Jul 2021 10:33:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzGUa-00069M-ED; Fri, 02 Jul 2021 10:33:52 +0000 Received: by outflank-mailman (input) for mailman id 149104; Fri, 02 Jul 2021 10:33:51 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzGUZ-00069C-4F; Fri, 02 Jul 2021 10:33:51 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzGUY-00071c-SR; Fri, 02 Jul 2021 10:33:50 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzGUY-0001Bv-JO; Fri, 02 Jul 2021 10:33:50 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lzGUY-0005Ms-It; Fri, 02 Jul 2021 10:33:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=M0w3TDJUzps+F3T3E+IEEnxvCx6FbJfmonQk2/Q/WSo=; b=nJ8GnylnVZaqIc8ZumyRTx0wYI w7zRqKgXPhn33/Iy5H7tp+TuDqc/0tMH/Qn5zEFIustJQIdiX9Wm4XTelsYQ3tyZp/Lb3rwoHltjT uEjpaA83TyaVjGXBdxC0FS0/xj8v1gJqCGdepGjsJJ3eI2xhcMj6GqozYIn2WpWDrgCA=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 163223: regressions - FAIL X-Osstest-Failures: libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=dfa1e9b3eb438866c122e4b8d0b4f99679f47cd2 X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Fri, 02 Jul 2021 10:33:50 +0000 flight 163223 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/163223/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a version targeted for testing: libvirt dfa1e9b3eb438866c122e4b8d0b4f99679f47cd2 baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 357 days Failing since 151818 2020-07-11 04:18:52 Z 356 days 348 attempts Testing same since 163223 2021-07-02 04:20:05 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Andika Triwidada Andrea Bolognani Balázs Meskó Barrett Schonefeld Bastian Germann Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Bjoern Walk Boris Fiuczynski Brian Turek Bruno Haible Chris Mayo Christian Ehrhardt Christian Schoenebeck Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Dmytro Linkin Eiichi Tsukata Eric Farman Erik Skultety Fabian Affolter Fabian Freyer Fabiano Fidêncio Fangge Jin Farhan Ali Fedora Weblate Translation gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Hela Basa Helmut Grohne Ian Wienand Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen Jean-Baptiste Holcroft Jianan Gao Jim Fehlig Jin Yan Jiri Denemark John Ferlan Jonathan Watt Jonathon Jongsma Julio Faracco Ján Tomko Kashyap Chamarthy Kevin Locke Kristina Hanicova Laine Stump Laszlo Ersek Lee Yarwood Liao Pingfang Lin Ma Lin Ma Lin Ma Liu Yiding Luke Yue Luyao Zhong Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Markus Schade Martin Kletzander Masayoshi Mizuma Matt Coleman Matt Coleman Mauro Matteo Cascella Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Muha Aliss Nathan Neal Gompa Nick Shyrokovskiy Nickys Music Group Nico Pache Nikolay Shirokovskiy Olaf Hering Olesya Gerasimenko Orion Poplawski Pany Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Ricky Tigg Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Shambarger Sebastian Mitterle SeongHyun Jo Shalini Chellathurai Saroja Shaojun Yang Shi Lei simmon Simon Chopin Simon Gaiser Stefan Bader Stefan Berger Stefan Berger Stefan Hajnoczi Szymon Scholz Thomas Huth Tim Wiederhake Tomáš Golembiovský Tomáš Janoušek Tuguoyi Ville Skyttä Wang Xin WangJian Weblate Wei Liu Wei Liu William Douglas Yalei Li <274268859@qq.com> Yalei Li Yang Hang Yanqiu Zhang Yaroslav Kargin Yi Li Yi Wang Yuri Chornoivan Zbigniew Jędrzejewski-Szmek Zheng Chuan zhenwei pi Zhenyu Zheng jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 63918 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Jul 02 11:02:05 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Jul 2021 11:02:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149110.275621 (Exim 4.92) (envelope-from ) id 1lzGvn-0000mE-TK; Fri, 02 Jul 2021 11:01:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149110.275621; Fri, 02 Jul 2021 11:01:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzGvn-0000m7-PR; Fri, 02 Jul 2021 11:01:59 +0000 Received: by outflank-mailman (input) for mailman id 149110; Fri, 02 Jul 2021 11:01:58 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzGvm-0000m1-KT for xen-devel@lists.xenproject.org; Fri, 02 Jul 2021 11:01:58 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (unknown [40.107.8.71]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id ea23cef5-db24-11eb-839e-12813bfff9fa; Fri, 02 Jul 2021 11:01:56 +0000 (UTC) Received: from PR0P264CA0106.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:19::22) by AS8PR08MB6760.eurprd08.prod.outlook.com (2603:10a6:20b:393::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4242.21; Fri, 2 Jul 2021 11:01:54 +0000 Received: from VE1EUR03FT035.eop-EUR03.prod.protection.outlook.com (2603:10a6:100:19:cafe::b7) by PR0P264CA0106.outlook.office365.com (2603:10a6:100:19::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.22 via Frontend Transport; Fri, 2 Jul 2021 11:01:54 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT035.mail.protection.outlook.com (10.152.18.110) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.22 via Frontend Transport; Fri, 2 Jul 2021 11:01:53 +0000 Received: ("Tessian outbound 71a9bd19c2b9:v97"); Fri, 02 Jul 2021 11:01:53 +0000 Received: from 003c9c2ec04b.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 311EB26B-1CE6-47B0-B5D5-46A8F6316B03.1; Fri, 02 Jul 2021 11:01:15 +0000 Received: from EUR03-AM5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 003c9c2ec04b.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 02 Jul 2021 11:01:15 +0000 Received: from PAXPR08MB6816.eurprd08.prod.outlook.com (2603:10a6:102:130::10) by PR3PR08MB5723.eurprd08.prod.outlook.com (2603:10a6:102:89::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.27; Fri, 2 Jul 2021 11:01:13 +0000 Received: from PAXPR08MB6816.eurprd08.prod.outlook.com ([fe80::7cfd:a8eb:b25a:f025]) by PAXPR08MB6816.eurprd08.prod.outlook.com ([fe80::7cfd:a8eb:b25a:f025%7]) with mapi id 15.20.4264.026; Fri, 2 Jul 2021 11:01:13 +0000 Received: from smtpclient.apple (82.8.129.65) by LO4P123CA0103.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:191::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.22 via Frontend Transport; Fri, 2 Jul 2021 11:01:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ea23cef5-db24-11eb-839e-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+uRhU4AslYb7IzQtRiQCkU8K6Wvpoh3wjruFiJ715nI=; b=EqjdiY7NLR8H/RhTL2HrQbqn/JKFUS0LjBpYBOrKPEML/Tg7KTjNDHah3WUwy4GqGacEU0IIGE8aOdFLOQ93/fRMrZQ+pwIY8n9tsX5DBC6HHkZhbOKLo+8wKNYtJ/uRL1Gr47BjwjoNxVRDEcI+AH0og57U3VInduB64tNbSN0= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: 53e80b0f3dae74a7 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=E7hgOx7q9j482y+72cuLBiTRM6XghXxYeCUw4oT0TAQL7GExmYJAX9w/E6KTbsOyVNopeAk1L/z4dW2P6T6unX+qnafOsyxAh7yrkcreEDmd7YLXlXpBDCeZwj9DfpDCnNTnJyO7591BWuUaC96K6iLj7V/xEY1V5tvomeNaa0Ss8WMMGUp0m4j49r/UMiylQR+U6tOldx28bi/a78/xjqeppZomR15ukShnrdQGma2Xmv02/cNJiFlzmub2qKiJvtT4SVCDA1x0khDn0KUCV2vaBqBKuDP99zy5DjjC0LoliutG7jSCfLpYz1YTS8TzLIXaoS8j8VWLeixgsxB4uQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+uRhU4AslYb7IzQtRiQCkU8K6Wvpoh3wjruFiJ715nI=; b=jihwjj7qwUpTBDtb8m9/iR3RG/YbFzd/45kMgbBa9aM72Tnd7cWpdZGmmnLH/2JMWlyEKampQ2y6zuRM42BGr3w3kkG+Gw4prY1prO4WvQK/YW1lYvOq9MkvIvX/PSlGSv9cBnPPcfv9Ot1jrrgpXhhkGdTnqlN1mj90IPjjlEGWSa+mUw4riKwykm2DXbALLPvYY4LZ8O6YOCN6Z87mZk857cYPardFewXqKjHEWn/ByBI1UjC5G/6dHV36NBfA50hQ9VP1puUf7vqIcQ2RvBH28W0HoR8j648ZJ9FRzJTaYs2uVN7u5CZ6UyBz1OHMnx1a0HgKmBBzdnZk1ho/7A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+uRhU4AslYb7IzQtRiQCkU8K6Wvpoh3wjruFiJ715nI=; b=EqjdiY7NLR8H/RhTL2HrQbqn/JKFUS0LjBpYBOrKPEML/Tg7KTjNDHah3WUwy4GqGacEU0IIGE8aOdFLOQ93/fRMrZQ+pwIY8n9tsX5DBC6HHkZhbOKLo+8wKNYtJ/uRL1Gr47BjwjoNxVRDEcI+AH0og57U3VInduB64tNbSN0= Authentication-Results-Original: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=arm.com; Content-Type: text/plain; charset=utf-8 Subject: Re: [PATCH v6 9/9] docs/doxygen: doxygen documentation for grant_table.h From: Luca Fancellu In-Reply-To: Date: Fri, 2 Jul 2021 12:01:06 +0100 Cc: xen-devel@lists.xenproject.org, Bertrand Marquis , wei.chen@arm.com, Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Julien Grall , Wei Liu Content-Transfer-Encoding: quoted-printable Message-Id: <4E85233D-5371-4862-A0A5-2B653C677D54@arm.com> References: <20210510084105.17108-1-luca.fancellu@arm.com> <20210510084105.17108-10-luca.fancellu@arm.com> <31171081-1007-4B4E-91CC-25EA1041EB58@arm.com> To: Stefano Stabellini X-Mailer: Apple Mail (2.3654.100.0.2.22) X-Originating-IP: [82.8.129.65] X-ClientProxiedBy: LO4P123CA0103.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:191::18) To PAXPR08MB6816.eurprd08.prod.outlook.com (2603:10a6:102:130::10) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5ec88e60-a8d7-468f-1b97-08d93d48cd2e X-MS-TrafficTypeDiagnostic: PR3PR08MB5723:|AS8PR08MB6760: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:8882;OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: iQmreDM5gfMKXoW47LtiF5fKBLuCy0tD3g0xtiroG/R5L94cbj+xR//6BDc62bdmRYoDqg5nC9FDVPTAaaXMiKtQN7atKsSlBomzpDtjwCbVG9ksWjErIWJrKWC46Gbt3zVmwHHWz1V5fozpYvTr5ehmNcduugM5PCYXILqm+HMRNFjTuQLjy0KkotujVCD57r4wwF8fLucA8Lyfh203bMmIcJ1SBjKN4D1oVM/KD4JBz1yXcyOMiQ/Z4QiN0ZeriJwRKwi2j1F4cSQIVg6fllKWBl8LGqgljBCerC72xhNvwpIUn/MXx+tXdDCQgPSc2+plUBkm2D5JxDyiSiYbhjz/YvB2njVCAKyjHgAmvENy0o7iDzf9yK5QbDGecTfbgjPWAWb2lciNTMEyOwFlKr13Z8gN5DHEavOYe1t7jgkK1pV3N/eKUZ8LjvU1/9jtcK9ZnxbEvr/ZowxsSfDOE4ZmDdcwT1CFvbSbxovAUCmU/MVIoLKJSIqn3xbP10bwCotAo8s2nTN4ynqOhz9NMMrAW4UYPbvyMbFS7wOO4bfMMqnNlrpxH4R5brbXO3ED9iiHjW8fm80SeY3dur7NOuQq5VCd2KjKYWT3fkJfapHafedACX/NH2qmAgVgmdV40YwnGKUzy4tmTX+cGbudEPIyAYXt/vb9FiEI1ST7i+XwEaFCuwuDagPAuUpCMirZ8AsFxQKP8VNGafxjsckHWH3CSc3JctmL6vGrEGJvLAck4A5z4CazONATcn63vUdrEoaUvENWK80rx2GxKojnRw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB6816.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39850400004)(366004)(376002)(396003)(136003)(346002)(478600001)(5660300002)(66556008)(6916009)(956004)(2616005)(2906002)(66476007)(6486002)(6512007)(4326008)(316002)(44832011)(966005)(6666004)(66946007)(54906003)(26005)(53546011)(6506007)(52116002)(186003)(83380400001)(86362001)(33656002)(8936002)(36756003)(8676002)(16526019)(38350700002)(38100700002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cDVlczZPMHF3QmUzSk5FNU9yN0ZYdGxyVFRmcVZObnRHdWVnSTVnUVdKekpQ?= =?utf-8?B?OFNRelY1dFhQUURmblhvOWlyN2tKaUxwNm94Y2dwWW9hUUE2dnFCNzFIRmpt?= =?utf-8?B?eTJGa0NseCt5SUhRdGoyMzJnd0RDMlhLTU1jbXNZaFYrM0lYbFJyMVc0NXhp?= =?utf-8?B?eXlxTGl5eHZZQXNVekRtaEFmd1BVUkM5aG9GMGFMSkFpeFdjRVlOQ2s1WHRl?= =?utf-8?B?T2JWcDdOMUYweWlpQk11UWtVNFdIMld6WE0vaEFVY0xxSWwrcE1VK2hHOExw?= =?utf-8?B?eEIzeStVTWVRYjY3akxleU9nWUpYeHlnR3Bjdk5lMU55VWh3emwzeXl2Z1kx?= =?utf-8?B?VHJhdEVrbTYraUp0Ni9jUmsrRGtLcmtWZy9GcTFQVGo1YjdJc3FVL3JCVVEz?= =?utf-8?B?QTV4UlkyMUw3aUZtTjU0c09FeElHckx6bGI2WmIxNmxQa0M4QkphcmNNMXV4?= =?utf-8?B?K3RPcHlZb2V0MU54V0U5T05jU2QvQW4zT3hseVQ3ejM2QTN4VWFLUG00Qnd4?= =?utf-8?B?cjM2aFlJeEpUeVRpRVRINzdjcHZTdTh3TXNLaVc5bDZyMmlhUXI5SzlZeWV0?= =?utf-8?B?dldmV3U4QXc5RVVxZE92RG1xb040WVZtTm1LaDM0R1M1S2E2QW91czFIWGMv?= =?utf-8?B?aWdJR1l0MFR0M1VNbHhqMVNKTHFqcWVFNG9zZGZ6cFQ1YTdoa0tNSjByb0Ir?= =?utf-8?B?UjUyUjAwNTlaaHVTZDN3ejVudCtPT08xVUxkbXBSekZkcnoxd2tmL1JXdlMv?= =?utf-8?B?TldWYTRDQTFuQWI5eUFmMUFKc2dDOE9RU2xzMGlSNWRxd25rZjhYeXNuak1m?= =?utf-8?B?SmdNV09vSWdYY2NTYzRVRFBTM2lKSkNQMXBqdUdqT0Z4ZVhDNTNNazVVRE1u?= =?utf-8?B?OG9nSDFRQXFGbDVHS3FZbjJjZDRGNUhQcXRId2tsYVgvNW9kdkFWejkzWmx4?= =?utf-8?B?ZjRRaE4zR05jMG9jWWMrbEpmYUhIKzBadWlPK1pZZW04d3NSc1ZzUWVMZzNU?= =?utf-8?B?bzdyMnBYaFlMcEJXczRzTDNmQ3J0RE1TbmhNb3JqUm04bkdkT3EvMDRKaFYr?= =?utf-8?B?aG44c09vY3NDd0JQa1pSMW9NL0FKSk5DWC9ybCtydktVVzNiYnF0dGJaRTBt?= =?utf-8?B?KzlhZ1ZBQWg5OERHUTRBd2prYVhiayt0ZjlDQjJjbXd2NHh4Yk9YVy9ma05N?= =?utf-8?B?UFkyamZtczd1UUloMnZPc1h5L3NIaDhhd0tRSWxlMzZrVVFJMk90eWxMK1No?= =?utf-8?B?R1QxYVNNbTFtMVh1MDY2OUJtMHljR3VSeXdxaVRxejF6aTJLT0JoQUlTMDBK?= =?utf-8?B?YzM5eUpaRk1ybW5FWmhCTVI2MjZqc3NMY3B5U0Z2SFlGQnJxZDA4cDB4bmlU?= =?utf-8?B?bHREamFjQ0hhMURYZVB3ZEt5bi8rNWtjRnYwSThIZlVxaEZkOFcwd3ZWbHhi?= =?utf-8?B?djNjMjRabDdhWEVXKzRYd2Uwby9zUWxmakk5aTdnWlZQMzR4TERsa3B5T1pP?= =?utf-8?B?a3dnVDVIazJBcTVNT1A5SU1qNzNZcjNiMjc1QjhjTmhIb2JDYWtQRVpldFRC?= =?utf-8?B?NnViKzhTYlk4SkdIT2xIS3d0MTZsL0NkbGRGMnRhTHJlRFpTUk83WDRjSjF5?= =?utf-8?B?NnVCUGZ3L21mMXFrYTV4UnZQV3R6RVBQdkNobGVrcm53NjRhVVh4Um5FQ2pT?= =?utf-8?B?b1dWSmxFZWtoMVhWSWY5eWJDZUF1dGJKN2FuczkyM1ZxbFhvQTV5a3pEMUNS?= =?utf-8?Q?PnrFtRltLWXY+ETvSFQm6B1jHrMgqe4s10DBu5k?= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR08MB5723 Original-Authentication-Results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT035.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: dd3599ae-0382-43c9-a46f-08d93d48b518 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: IJa7sfTYtyS9rZ8pTTW8r4Z7miadTkfdfZJZw82uDkONR/5xhRdZOHTmRoWuNoW1wPyDLT8swnRC19X+0jWhN2XLXsh0Cmk3thif6KhVzndP48wMMRw3WQAzYvXd8niJnk5vg/DL/jWSOc01ZioBcjgLpHMlK+bPh3Bbt48UANmBtBjHBMVvdLv6dFSiCPQe6HreIAbrpCh4STBQlHzLB31lohfodbngEmAsQctWXk9HpRsh/0K44Yl2u3IleSCb2dFMuaHZ4sGTyXxbp0Cpu5rDpOXupfnrf5zStaWF9/GJJAbxr47yJage+Tu21Kyqn9AdISFZ5uZ4XCuRObBylanV0RgR/Ocg2xZxeSgFcG4keyijzbHIu3+m8OqQsmYVBibiC0WraoxDpyriOMzj0Nw2agUfl/pxM+uAL80nErIYBNq+EukqIGkepJ5KjqkGWTJfy5Fh/ctrJ9IbU/rn1hKU7K1cRUHIi7/qtIr4mUDLj9pirSe16Tqii1CvGEHJ6riOI+It34YInuxXuo0Yq0lvWH7oeKIJSQwoeG0SzgZJRy9Kv1uB6UHIzOWmjJT9DdPMBCU6mMlJNg+ZgUiRLZUrMmO3sFJ2bL9VcHTpgmrHMmM/Pa44HwsHbylkLxahs9nUE5a1MZorcVtFW5pEQFZgIl1lERP/BcGux5uZTode27ckZT/ZEbeeaGM5wpXXqaYhSogng2FZQ76q1nNgx47xxfMdDTonppQRYSCTzZlZN0NkC+2Vi4TB5B/cuIOO X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(376002)(346002)(136003)(396003)(39850400004)(46966006)(36840700001)(2616005)(53546011)(6506007)(36756003)(956004)(186003)(33656002)(44832011)(16526019)(478600001)(8676002)(2906002)(26005)(336012)(47076005)(6486002)(86362001)(8936002)(36860700001)(6512007)(966005)(70586007)(82740400003)(6862004)(4326008)(5660300002)(70206006)(356005)(316002)(83380400001)(54906003)(82310400003)(6666004)(81166007);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jul 2021 11:01:53.7767 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5ec88e60-a8d7-468f-1b97-08d93d48cd2e X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT035.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6760 > On 1 Jul 2021, at 18:44, Stefano Stabellini wrot= e: >=20 > On Thu, 1 Jul 2021, Luca Fancellu wrote: >> Hi Stefano, >>=20 >>> On 24 Jun 2021, at 00:34, Stefano Stabellini w= rote: >>>=20 >>> On Mon, 10 May 2021, Luca Fancellu wrote: >>>> Modification to include/public/grant_table.h: >>>>=20 >>>> 1) Add doxygen tags to: >>>> - Create Grant tables section >>>> - include variables in the generated documentation >>>> - Used @keepindent/@endkeepindent to enclose comment >>>> section that are indented using spaces, to keep >>>> the indentation. >>>> 2) Add .rst file for grant table for Arm64 >>>=20 >>> Why only arm64? >>=20 >> This is a mistake, it should be just =E2=80=9CAdd .rst file for grant ta= ble" >>=20 >>>=20 >>>=20 >>>> Signed-off-by: Luca Fancellu >>>> --- >>>> v6 changes: >>>> - Fix misaligned comment >>>> - Moved comments to make them display in the docs >>>> - Included more documentation in the docs >>>> (see output here: https://luca.fancellu.gitlab.io/xen-docs/hypercall-i= nterfaces/common/grant_tables.html) >>>=20 >>> It looks much much better. All the info we care about seems to be there= . >>> The only things that I noticed missing and might be good to keep is the >>> small comment about HYPERVISOR_grant_table_op: >>>=20 >>> /* ` enum neg_errnoval >>> * ` HYPERVISOR_grant_table_op(enum grant_table_op cmd, >>> * ` void *args, >>> * ` unsigned int count) >>> * ` >>> * >>> * @args points to an array of a per-command data structure. The array >>> * has @count members >>=20 >> Where do you want me to put this comment in the html page? In the end of= the description in the top of the page? >=20 > Yeah, that looks like a good place Great, for a preview, have a look on this: https://luca.fancellu.gitlab.io/= xen-docs/hypercall-interfaces/common/grant_tables.html From xen-devel-bounces@lists.xenproject.org Fri Jul 02 11:15:02 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Jul 2021 11:15:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149116.275632 (Exim 4.92) (envelope-from ) id 1lzH8N-0002KH-4U; Fri, 02 Jul 2021 11:14:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149116.275632; Fri, 02 Jul 2021 11:14:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzH8N-0002KA-1N; Fri, 02 Jul 2021 11:14:59 +0000 Received: by outflank-mailman (input) for mailman id 149116; Fri, 02 Jul 2021 11:14:57 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzH8L-0002K0-CS; Fri, 02 Jul 2021 11:14:57 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzH8L-0007h5-5I; Fri, 02 Jul 2021 11:14:57 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzH8K-0003ew-Rx; Fri, 02 Jul 2021 11:14:56 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lzH8K-0002aW-RT; Fri, 02 Jul 2021 11:14:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=xNepEykTUdR1+8m4UdxuBL02+UAFLM2p/TH5Mmkw9GM=; b=SP57u/iGzKpk0YuNLqpoGASeUS vfwBB+96emEwPmmobLJz/qCLThR6t0pBOEUeqU7gMai7ZWTgNRzH3f1LQQSYbnTcPb0gHYd6BZ1Ma e6lspqfG/q7vHXe0jgD4uuaXXl5vpp1hi8iX4Ta23eaEJEalT7GVGtorJHisLHhhaEHE=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 163221: regressions - FAIL X-Osstest-Failures: ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:debian-hvm-install:fail:regression ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:debian-hvm-install:fail:regression X-Osstest-Versions-This: ovmf=fea7901dba72eeac526f3ef12a4ad4c539622373 X-Osstest-Versions-That: ovmf=c410ad4da4b7785170d3d42a3ba190c2caac6feb From: osstest service owner Date: Fri, 02 Jul 2021 11:14:56 +0000 flight 163221 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/163221/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 162359 test-amd64-amd64-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 162359 version targeted for testing: ovmf fea7901dba72eeac526f3ef12a4ad4c539622373 baseline version: ovmf c410ad4da4b7785170d3d42a3ba190c2caac6feb Last test of basis 162359 2021-06-04 03:40:08 Z 28 days Failing since 162368 2021-06-04 15:42:59 Z 27 days 73 attempts Testing same since 163216 2021-07-01 22:42:29 Z 0 days 3 attempts ------------------------------------------------------------ People who touched revisions under test: Abner Chang Agrawal, Sachin Alexandru Elisei Anthony PERARD Ard Biesheuvel Daniel Schaefer Daoxiang Li Dov Murik DunTan gaoliming Guo Dong Hao A Wu Jian J Wang Kaaira Gupta Ken Lautner Kenneth Lautner Kun Qin Laszlo Ersek Leif Lindholm Liming Gao Loo Tung Lun Loo, Tung Lun Manickavasakam Karpagavinayagam Maurice Ma Ni, Ray Patrick Rudolph Pierre Gondois Ray Ni Rebecca Cran Rebecca Cran Sachin Agrawal Sami Mujawar Scottie Kuo Sean Brogan Sean Brogan Sumana Venur Sunil V L xueshengfeng Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-i386-xl-qemuu-ovmf-amd64 fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 3224 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Jul 02 11:22:56 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Jul 2021 11:22:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149121.275645 (Exim 4.92) (envelope-from ) id 1lzHFy-0003jg-UJ; Fri, 02 Jul 2021 11:22:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149121.275645; Fri, 02 Jul 2021 11:22:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzHFy-0003jZ-R9; Fri, 02 Jul 2021 11:22:50 +0000 Received: by outflank-mailman (input) for mailman id 149121; Fri, 02 Jul 2021 11:22:50 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzHFx-0003jT-Jr for xen-devel@lists.xenproject.org; Fri, 02 Jul 2021 11:22:50 +0000 Received: from desiato.infradead.org (unknown [2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 8bbc85ee-dc99-4ae4-9610-1b3e840d2519; Fri, 02 Jul 2021 11:22:45 +0000 (UTC) Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1lzHFD-00DqNT-HJ; Fri, 02 Jul 2021 11:22:03 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 43862300091; Fri, 2 Jul 2021 13:22:00 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id D797A20244CE2; Fri, 2 Jul 2021 13:22:00 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8bbc85ee-dc99-4ae4-9610-1b3e840d2519 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=O5Uqso+ww5amQ01DKigcD3vJJ7N3bwtD7LxAeQZ8NGo=; b=JYJbKRCaTtVjDzb/7N8Vg5ALJK Z9z+lgf5/nby+DFt32t6/4uiGrBJeKjTLVqqlBekOg4CgVhfQqk4bd+I/0DRjmpHrmNI77IlDRhYn JTJlDJI2+gb1fvdiaPk1sAjttTyO6N8hHeBFR/6wiUzGir5xO+zjr18vT2GDa7ueMv3jA0DvapxgS sORLkZ7+5aVcnyqMrOOh2sxuewdQjUzEt/H8Pa02qexOzNdz5irUkHr2OVQIQ7TUGNBbfjA6/qU55 KLYzKy4dbIvNoL9okqBh6IPngAIxJ8W8lD+1vYchcUWAbhBempd1bUMgvDJN85yD8fulHZbpEdfXJ Z5/MAk+w==; Date: Fri, 2 Jul 2021 13:22:00 +0200 From: Peter Zijlstra To: Zhu Lingshan Cc: pbonzini@redhat.com, bp@alien8.de, seanjc@google.com, vkuznets@redhat.com, wanpengli@tencent.com, jmattson@google.com, joro@8bytes.org, weijiang.yang@intel.com, kan.liang@linux.intel.com, ak@linux.intel.com, wei.w.wang@intel.com, eranian@google.com, liuxiangdong5@huawei.com, linux-kernel@vger.kernel.org, x86@kernel.org, kvm@vger.kernel.org, like.xu.linux@gmail.com, Like Xu , Will Deacon , Marc Zyngier , Guo Ren , Nick Hu , Paul Walmsley , Boris Ostrovsky , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-csky@vger.kernel.org, linux-riscv@lists.infradead.org, xen-devel@lists.xenproject.org Subject: Re: [PATCH V7 01/18] perf/core: Use static_call to optimize perf_guest_info_callbacks Message-ID: References: <20210622094306.8336-1-lingshan.zhu@intel.com> <20210622094306.8336-2-lingshan.zhu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210622094306.8336-2-lingshan.zhu@intel.com> On Tue, Jun 22, 2021 at 05:42:49PM +0800, Zhu Lingshan wrote: > diff --git a/arch/x86/events/core.c b/arch/x86/events/core.c > index 8f71dd72ef95..c71af4cfba9b 100644 > --- a/arch/x86/events/core.c > +++ b/arch/x86/events/core.c > @@ -90,6 +90,27 @@ DEFINE_STATIC_CALL_NULL(x86_pmu_pebs_aliases, *x86_pmu.pebs_aliases); > */ > DEFINE_STATIC_CALL_RET0(x86_pmu_guest_get_msrs, *x86_pmu.guest_get_msrs); > > +DEFINE_STATIC_CALL_RET0(x86_guest_state, *(perf_guest_cbs->state)); > +DEFINE_STATIC_CALL_RET0(x86_guest_get_ip, *(perf_guest_cbs->get_ip)); > +DEFINE_STATIC_CALL_RET0(x86_guest_handle_intel_pt_intr, *(perf_guest_cbs->handle_intel_pt_intr)); > + > +void arch_perf_update_guest_cbs(void) > +{ > + static_call_update(x86_guest_state, (void *)&__static_call_return0); > + static_call_update(x86_guest_get_ip, (void *)&__static_call_return0); > + static_call_update(x86_guest_handle_intel_pt_intr, (void *)&__static_call_return0); > + > + if (perf_guest_cbs && perf_guest_cbs->state) > + static_call_update(x86_guest_state, perf_guest_cbs->state); > + > + if (perf_guest_cbs && perf_guest_cbs->get_ip) > + static_call_update(x86_guest_get_ip, perf_guest_cbs->get_ip); > + > + if (perf_guest_cbs && perf_guest_cbs->handle_intel_pt_intr) > + static_call_update(x86_guest_handle_intel_pt_intr, > + perf_guest_cbs->handle_intel_pt_intr); > +} Coding style wants { } on that last if(). From xen-devel-bounces@lists.xenproject.org Fri Jul 02 11:33:33 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Jul 2021 11:33:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149125.275657 (Exim 4.92) (envelope-from ) id 1lzHQG-0005AQ-Vt; Fri, 02 Jul 2021 11:33:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149125.275657; Fri, 02 Jul 2021 11:33:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzHQG-0005AJ-S1; Fri, 02 Jul 2021 11:33:28 +0000 Received: by outflank-mailman (input) for mailman id 149125; Fri, 02 Jul 2021 11:33:27 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzHQF-00059t-Jv; Fri, 02 Jul 2021 11:33:27 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzHQF-000810-9v; Fri, 02 Jul 2021 11:33:27 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzHQE-0004N3-6E; Fri, 02 Jul 2021 11:33:26 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lzHQE-0001dl-5j; Fri, 02 Jul 2021 11:33:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=pjKkfDJ92AvRweYX4G4aIbQEq8Zdil9QSca9w0f35KM=; b=HLeLvRcusHYCnW/SPxdmo1i8ks p+6AMMNBm6ygshEjzB6ToFO/dIvjwGPqpWpNwlUv6lAtLiXCIc0wiPTh7BBJOz250D9xQDmI3MNGA oW8Rv7qh9ZoscGFN7xK/thZp9FdpkSAsxiHPkD0psFBJWpZ5m3nEe1lwCROwYuqHupb0=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 163219: tolerable FAIL X-Osstest-Failures: xen-unstable:test-armhf-armhf-libvirt-raw:xen-boot:fail:heisenbug xen-unstable:test-amd64-i386-libvirt:xen-boot:fail:heisenbug xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=f95b7b37cfc6d4613721df9357090d14712013c0 X-Osstest-Versions-That: xen=f95b7b37cfc6d4613721df9357090d14712013c0 From: osstest service owner Date: Fri, 02 Jul 2021 11:33:26 +0000 flight 163219 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/163219/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-armhf-armhf-libvirt-raw 8 xen-boot fail in 163206 pass in 163219 test-amd64-i386-libvirt 8 xen-boot fail pass in 163206 Tests which did not succeed, but are not blocking: test-amd64-i386-libvirt 15 migrate-support-check fail in 163206 never pass test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 163190 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 163206 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 163206 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 163206 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 163206 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 163206 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 163206 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 163206 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 163206 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 163206 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 163206 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen f95b7b37cfc6d4613721df9357090d14712013c0 baseline version: xen f95b7b37cfc6d4613721df9357090d14712013c0 Last test of basis 163219 2021-07-02 01:52:38 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt fail test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Fri Jul 02 11:40:04 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Jul 2021 11:40:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149130.275671 (Exim 4.92) (envelope-from ) id 1lzHWU-0005uL-St; Fri, 02 Jul 2021 11:39:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149130.275671; Fri, 02 Jul 2021 11:39:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzHWU-0005uE-Ps; Fri, 02 Jul 2021 11:39:54 +0000 Received: by outflank-mailman (input) for mailman id 149130; Fri, 02 Jul 2021 11:39:53 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzHWT-0005u7-70 for xen-devel@lists.xenproject.org; Fri, 02 Jul 2021 11:39:53 +0000 Received: from foss.arm.com (unknown [217.140.110.172]) by us1-rack-iad1.inumbo.com (Halon) with ESMTP id 796f2f0c-04b6-407f-a078-4c6ad2d07b3c; Fri, 02 Jul 2021 11:39:51 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 773371FB; Fri, 2 Jul 2021 04:39:51 -0700 (PDT) Received: from [10.57.40.45] (unknown [10.57.40.45]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A5E473F718; Fri, 2 Jul 2021 04:39:44 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 796f2f0c-04b6-407f-a078-4c6ad2d07b3c Subject: Re: [PATCH v15 12/12] of: Add plumbing for restricted DMA pool To: Guenter Roeck , Claire Chang Cc: Rob Herring , mpe@ellerman.id.au, Joerg Roedel , Will Deacon , Frank Rowand , Konrad Rzeszutek Wilk , boris.ostrovsky@oracle.com, jgross@suse.com, Christoph Hellwig , Marek Szyprowski , heikki.krogerus@linux.intel.com, thomas.hellstrom@linux.intel.com, peterz@infradead.org, dri-devel@lists.freedesktop.org, chris@chris-wilson.co.uk, grant.likely@arm.com, paulus@samba.org, mingo@kernel.org, jxgao@google.com, sstabellini@kernel.org, Saravana Kannan , xypron.glpk@gmx.de, "Rafael J . Wysocki" , Bartosz Golaszewski , bskeggs@redhat.com, linux-pci@vger.kernel.org, xen-devel@lists.xenproject.org, Thierry Reding , intel-gfx@lists.freedesktop.org, matthew.auld@intel.com, linux-devicetree , airlied@linux.ie, Nicolas Boichat , rodrigo.vivi@intel.com, bhelgaas@google.com, Dan Williams , Andy Shevchenko , Greg KH , Randy Dunlap , quic_qiancai@quicinc.com, lkml , tfiga@chromium.org, "list@263.net:IOMMU DRIVERS" , Jim Quinlan , thomas.lendacky@amd.com, linuxppc-dev@lists.ozlabs.org, bauerman@linux.ibm.com References: <20210624155526.2775863-1-tientzu@chromium.org> <20210624155526.2775863-13-tientzu@chromium.org> <20210702030807.GA2685166@roeck-us.net> From: Robin Murphy Message-ID: <87ca3ada-22ed-f40c-0089-ca6fffc04f24@arm.com> Date: Fri, 2 Jul 2021 12:39:41 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210702030807.GA2685166@roeck-us.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit On 2021-07-02 04:08, Guenter Roeck wrote: > Hi, > > On Thu, Jun 24, 2021 at 11:55:26PM +0800, Claire Chang wrote: >> If a device is not behind an IOMMU, we look up the device node and set >> up the restricted DMA when the restricted-dma-pool is presented. >> >> Signed-off-by: Claire Chang >> Tested-by: Stefano Stabellini >> Tested-by: Will Deacon > > With this patch in place, all sparc and sparc64 qemu emulations > fail to boot. Symptom is that the root file system is not found. > Reverting this patch fixes the problem. Bisect log is attached. Ah, OF_ADDRESS depends on !SPARC, so of_dma_configure_id() is presumably returning an unexpected -ENODEV from the of_dma_set_restricted_buffer() stub. That should probably be returning 0 instead, since either way it's not an error condition for it to simply do nothing. Robin. > > Guenter > > --- > # bad: [fb0ca446157a86b75502c1636b0d81e642fe6bf1] Add linux-next specific files for 20210701 > # good: [62fb9874f5da54fdb243003b386128037319b219] Linux 5.13 > git bisect start 'HEAD' 'v5.13' > # bad: [f63c4fda987a19b1194cc45cb72fd5bf968d9d90] Merge remote-tracking branch 'rdma/for-next' > git bisect bad f63c4fda987a19b1194cc45cb72fd5bf968d9d90 > # good: [46bb5dd1d2a63e906e374e97dfd4a5e33934b1c4] Merge remote-tracking branch 'ipsec/master' > git bisect good 46bb5dd1d2a63e906e374e97dfd4a5e33934b1c4 > # good: [43ba6969cfb8185353a7a6fc79070f13b9e3d6d3] Merge remote-tracking branch 'clk/clk-next' > git bisect good 43ba6969cfb8185353a7a6fc79070f13b9e3d6d3 > # good: [1ca5eddcf8dca1d6345471c6404e7364af0d7019] Merge remote-tracking branch 'fuse/for-next' > git bisect good 1ca5eddcf8dca1d6345471c6404e7364af0d7019 > # good: [8f6d7b3248705920187263a4e7147b0752ec7dcf] Merge remote-tracking branch 'pci/next' > git bisect good 8f6d7b3248705920187263a4e7147b0752ec7dcf > # good: [df1885a755784da3ef285f36d9230c1d090ef186] RDMA/rtrs_clt: Alloc less memory with write path fast memory registration > git bisect good df1885a755784da3ef285f36d9230c1d090ef186 > # good: [93d31efb58c8ad4a66bbedbc2d082df458c04e45] Merge remote-tracking branch 'cpufreq-arm/cpufreq/arm/linux-next' > git bisect good 93d31efb58c8ad4a66bbedbc2d082df458c04e45 > # good: [46308965ae6fdc7c25deb2e8c048510ae51bbe66] RDMA/irdma: Check contents of user-space irdma_mem_reg_req object > git bisect good 46308965ae6fdc7c25deb2e8c048510ae51bbe66 > # good: [6de7a1d006ea9db235492b288312838d6878385f] thermal/drivers/int340x/processor_thermal: Split enumeration and processing part > git bisect good 6de7a1d006ea9db235492b288312838d6878385f > # good: [081bec2577cda3d04f6559c60b6f4e2242853520] dt-bindings: of: Add restricted DMA pool > git bisect good 081bec2577cda3d04f6559c60b6f4e2242853520 > # good: [bf95ac0bcd69979af146852f6a617a60285ebbc1] Merge remote-tracking branch 'thermal/thermal/linux-next' > git bisect good bf95ac0bcd69979af146852f6a617a60285ebbc1 > # good: [3d8287544223a3d2f37981c1f9ffd94d0b5e9ffc] RDMA/core: Always release restrack object > git bisect good 3d8287544223a3d2f37981c1f9ffd94d0b5e9ffc > # bad: [cff1f23fad6e0bd7d671acce0d15285c709f259c] Merge remote-tracking branch 'swiotlb/linux-next' > git bisect bad cff1f23fad6e0bd7d671acce0d15285c709f259c > # bad: [b655006619b7bccd0dc1e055bd72de5d613e7b5c] of: Add plumbing for restricted DMA pool > git bisect bad b655006619b7bccd0dc1e055bd72de5d613e7b5c > # first bad commit: [b655006619b7bccd0dc1e055bd72de5d613e7b5c] of: Add plumbing for restricted DMA pool > From xen-devel-bounces@lists.xenproject.org Fri Jul 02 12:29:47 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Jul 2021 12:29:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149135.275681 (Exim 4.92) (envelope-from ) id 1lzIIe-0002KW-Pv; Fri, 02 Jul 2021 12:29:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149135.275681; Fri, 02 Jul 2021 12:29:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzIIe-0002KP-Mm; Fri, 02 Jul 2021 12:29:40 +0000 Received: by outflank-mailman (input) for mailman id 149135; Fri, 02 Jul 2021 12:29:39 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzIId-0002KJ-Bm for xen-devel@lists.xenproject.org; Fri, 02 Jul 2021 12:29:39 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 29b1941e-db31-11eb-83ab-12813bfff9fa; Fri, 02 Jul 2021 12:29:37 +0000 (UTC) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04lp2050.outbound.protection.outlook.com [104.47.13.50]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-30-vftSAFXgONertm_4dqtRnA-1; Fri, 02 Jul 2021 14:29:35 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR0402MB3934.eurprd04.prod.outlook.com (2603:10a6:803:1b::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4264.20; Fri, 2 Jul 2021 12:29:32 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::99d3:99cd:8adf:3eea]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::99d3:99cd:8adf:3eea%5]) with mapi id 15.20.4287.023; Fri, 2 Jul 2021 12:29:32 +0000 Received: from [10.156.60.236] (37.24.206.209) by FR3P281CA0012.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1d::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4308.8 via Frontend Transport; Fri, 2 Jul 2021 12:29:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 29b1941e-db31-11eb-83ab-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1625228976; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OXCXkoq7qZBEYwgC4hG+ro2jpvJk8JLQN6Z4zTZq0hQ=; b=nwZR5yMPlkSU5sDEzmSpPiWKQAQ7wDxVFXs3oX2WUxi4ViZPbPOaCpNM2C9oUsmf6XoS0q PvWGbg1Jd9rC+19cWEWi7XKQE9koaV74dCPOJ3816LzzOQ2q3bhzSfrocVuynndcaHp7Pn XAuzrMj+MY/7dd37OnRVoyGlZ0vAv9Q= X-MC-Unique: vftSAFXgONertm_4dqtRnA-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P8bN8gQjkon8mrsXNk5pu8YrATEWXhKBB7d79E4HJOXut9fJeZzyhXI1/wXiz+4CNQGMAkXiv8x1svRVx644n2K80k7hVojrpwAPrphXqjxW9TzRicvKLbrEudlaamrbQ0b9YCkpicjgow5JaA+nbFl6v1rmjJBUfdWkbUOUCV2yCSJHAy8XZCMKmxjMkgSs+PSVPz4BWy6ewHwvCqORN3u1eqpBZhRyClHQrZB3oqDz6PhWDvZ8k4F+Fb4yZ3aiM3AoXK5xDf1vtuhEqv+kHLRuEohCLIsG/jU128lO7AL+lsbrASzF00dkVz1ouGB5QOGIN97OZ4FHAHzpaXew9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OXCXkoq7qZBEYwgC4hG+ro2jpvJk8JLQN6Z4zTZq0hQ=; b=VOHuIxbCpg5GR8qL0gR41u7D2F1Cg4TwWivihmQV4vQsdtsxBlZ5yDgNmsba33qgXpjCG/5Xo2L4cE+LyoE/wFA/shuM3R7Rl+P4w7k5e7qRXn5lMgYB08XB3bwK50t5bpX5Uwz4NEZ8miL0Gc2iFO0nD96NnqSSwGEIeXkKKz/K3XsiEu2Eo+jE1Dm1ph0BROlKEF0OsSBJyF9JtP5tFex8C4bYhRHblEb7BsdohngBAjzXREkJrrmaQzjNv0BbDhqccqpf0J6RRSCB8UsMLTUJ52VRCfwibcU/0JkXhrpK9RFUjL4j3EpFvwXYj0Wlj2CizK86vD37ri/Tjhpr6Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: citrix.com; dkim=none (message not signed) header.d=none;citrix.com; dmarc=none action=none header.from=suse.com; Subject: Re: [PATCH] libxl/x86: check return value of SHADOW_OP_SET_ALLOCATION domctl To: Anthony PERARD Cc: "xen-devel@lists.xenproject.org" , Ian Jackson , Wei Liu , Andrew Cooper References: <5d2bb2cf-8c0c-7300-c895-75bef0e50817@suse.com> From: Jan Beulich Message-ID: <4913d3f6-cd16-1865-9c19-99f7db615ded@suse.com> Date: Fri, 2 Jul 2021 14:29:31 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [37.24.206.209] X-ClientProxiedBy: FR3P281CA0012.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1d::15) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7e9c49c5-a595-4117-6b45-08d93d550b69 X-MS-TrafficTypeDiagnostic: VI1PR0402MB3934: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +mxBPYuRUJI13yJgLB/a88r9N90OUyhTD411Pq4Pug0avOvFH7cX1R69BoBePIyFg3HyZKBLFzWZUkgc+Zp1kPHHOmvsPwf0Ewb1AjOF+TJf1lTQ9aQj9SVc5KfK5wKk33whkmkFauIevkLS85Q4hj6HFODqveLkhptozecxVzZQYNzkIcU/r2WM5nchu0E+rIo0DyBrn0DD5Orhlawz98naWvbJlBaL0xlObSbSr/A63ZYowpNp/3DtIjgYU5tPKHIvaM/2Rsf6/MXeg6Aw0HfrTzmmWOuuLNS8VlGZ/Ea2SIdnVTKA5J1znwjJQonQJT7WTp5cJ8df5DyEZ3vQVPHY+C2cH3ZdVB0FB0Gvul7LPt+cFtuqVdeGRkgT39TsdYB9/42bfNDKdxw1i97u+IvANnE2S3GoI1Jq1H7GNQJ7/NyRioG9fb/btaytbJ9aLpzSSDEMXyupxU1rBe38tMy5YyHDL9BQf3lsnUdkjQwdHPa/juuitkN2GWhOiUtj9q4e2ikvUT561+cXJE3Ql8Dxl5NM34NXeFUXQdRPtTIdq7CjFYPTkDxF8gs28enx//1ckTrPvTc4hqqx2EozHqAgkmcr7D7TthjEo7btgmFSuUIXM4wh+yfv1+YPfI4brq/IbE8H9hTy0xcWNtM28JcPsZLFXWj2+qa74IC9zYZ8BteAZJeDgO6oEuohHNg2jsmSY9TVygvwcp95QtvGHvbiLMNkZoMMGW+7iCXg+Ik= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(39850400004)(396003)(366004)(136003)(346002)(376002)(26005)(36756003)(478600001)(8676002)(8936002)(16526019)(186003)(66946007)(66556008)(66476007)(6916009)(16576012)(86362001)(316002)(6486002)(38100700002)(53546011)(31686004)(54906003)(2616005)(956004)(2906002)(4326008)(5660300002)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VlpNOUxqb0llR2dsd3R6ZDZtVEgxWlRIWHIxUkNncU5Rc2xTRmlvOGNnMVV6?= =?utf-8?B?VW5sREpVV2lLQ1B4QmlkOE54NEd6bFdkK2g2RWpzbU1IZHRPM25TL1NwTitl?= =?utf-8?B?bzdFOGZUUXpCOStrbzVEMXhrSXhXZkZXVVVvM2ovMEp2VUpUK2VJMHIwS0Jp?= =?utf-8?B?NUZHUEFvdjR1dFdzOEdNdUdkRUVMM2ZMTEdiTVVJVTJ2a2thL1RIcy9aaFM1?= =?utf-8?B?aGh1VlhzV3ZQMk1RT3FLalF3YktIQitkM25scUFKM2d6TmlsZmE3YTFyVjMz?= =?utf-8?B?dGxyTDBiazgvTndRM09zc2hteitJOXgxam5SQ3VFcEgvejgxdDZMeENqSDR5?= =?utf-8?B?b2dLWDNiZTJuUklpbEluSGF0N1loS05oaW5UWXU3dmlZR05qL2ExTmIvNmRx?= =?utf-8?B?YXY2Tk90eGJlTFV3Z2lSeXZHSjhacHVDVzFSTUE0UGxLU3hlaE0zSXdjZTNh?= =?utf-8?B?SVc2V3lYdmFpZzFyci9lTm96SHlOWWVXUmdTWldaQ2pWeU5IMkt3TXZBU05P?= =?utf-8?B?WDVqeXBHNHo1VXVJcDdvYkwwK3NvdkhNRU52Wm5QSTV2ZjBtcFVBa0FkSTQ1?= =?utf-8?B?YU11SE1rbm5haGpMNjBEa3B3TkFSZ25oeStGanNsZ3ExUFJGSE9uZ1NkS3lk?= =?utf-8?B?ZHE5TUVhdHd0MytuN1RYaHpNa2h0R2lQWS9HNXFYaFFHS2Vpemh5bk1ZU3RY?= =?utf-8?B?cVV4cjdyQ1JkcUZvbmVuSFR1cmtUY0dDNURNL1MrWWg3YWVxLzRPYm1lZExK?= =?utf-8?B?N2k1dGovMyt3U2p2NUJMeEZUa0tKSjIyWjZZN0lmajU1eDd0b3RGRkV6UlQw?= =?utf-8?B?ZHl4NDdrYXd3eWVYR2R3RlV1Y1JJdHdjRGlSaGtpTGt2M2dteUFsOWlGcCtC?= =?utf-8?B?VWdxZ0pZR0ZOQ29RbzdGQmFxMGhDbDVRWk1OazQzS05JTGRMMWYyd25NUzNB?= =?utf-8?B?UnovRlgxSDAwaFZHUi9EWElNcklKS1BhTVJBV0NHUFdNSEtIb0Q3eWFvNEZH?= =?utf-8?B?Rm5KZldHMUFZcFpNU0FKZkZGWnlsT1FXYjNvcXlPN3BySVoxaHJJVUljOE1O?= =?utf-8?B?Q000eFpZYS8wV3ZieGVGS2RQZDF5RmlXbEhyS0RmTGpVQklOdzcxWEZxMEFT?= =?utf-8?B?NHlMZG4ybzJSQ2NVa0JKeDBjbVUzRHlIZHVVRkpSWGxRdHI0SnRMcTVBSDNM?= =?utf-8?B?ZTE1eUNQUkV3VUZkaHc0eHlMZXE4VDFEeVlWdG1vVnBTdllOb0hxOXFGRFVQ?= =?utf-8?B?OGJYU0hZeUt6Ly90NCtPbURDbHFSd0U0eVRSZnppWkNXN0ZQT2VsQWZjMkpH?= =?utf-8?B?Qjloc2NaUHowb2RZWTVGM1pWZDIrRkdrWnhzNmlkYy9ZY2wrRmxLck1rcTBq?= =?utf-8?B?eFNlT2VKSkFHdTZlZEI5eEJNNzZpazZJV2REUldEUjRLdGtLVGxsdGNaSVQ4?= =?utf-8?B?WjFrUlNnbEpyLzRDNE16UkJVVXBxZWFBY2YvY1gwckVZQWYybzE0aFFMbE81?= =?utf-8?B?T2premtDUVVacWgzbDB6QnpxdXlGSFVJSlNhai90RStRWVJyLzNIS2F1cGtP?= =?utf-8?B?R0wvRlNFcE13WmJiWWUxRm5MK3FkOUprRjhROTV3WkhKUE9wMjZ3aHpqemxK?= =?utf-8?B?MjRtSmF3NWF4cmxOK0JzWTlCNmxKcmVJcFVjZjZwNnBCVjhlREpwR0VRdTJ6?= =?utf-8?B?WWtyVU5LTlhzdXlpRWxqSm1nbTdlMk1URkIzSUtQOTJUMHFITXNHQ2VCWS95?= =?utf-8?Q?0Gv42Y8GOzmyPvMPxNzxaCgylZ+x7d3d2ClSTeF?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7e9c49c5-a595-4117-6b45-08d93d550b69 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jul 2021 12:29:32.5067 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: yJQisQjKkzqC0Cbcz2WDT+xDX+9oS7v8RE64d1nfEKtDm66iHAbMe9QH8RCy0Ag9x6YDLTSfS4jEn/s24U0vgg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3934 On 01.07.2021 11:36, Anthony PERARD wrote: > On Mon, Jun 28, 2021 at 01:47:03PM +0200, Jan Beulich wrote: >> --- a/tools/libs/light/libxl_x86.c >> +++ b/tools/libs/light/libxl_x86.c >> @@ -531,8 +531,18 @@ int libxl__arch_domain_create(libxl__gc >> if (d_config->b_info.type != LIBXL_DOMAIN_TYPE_PV) { >> unsigned long shadow = DIV_ROUNDUP(d_config->b_info.shadow_memkb, >> 1024); >> - xc_shadow_control(ctx->xch, domid, XEN_DOMCTL_SHADOW_OP_SET_ALLOCATION, >> - NULL, 0, &shadow, 0, NULL); >> + int rc = xc_shadow_control(ctx->xch, domid, > > Could you use 'r' instead of 'rc' ? The later is reserved for libxl > error codes while the former is for system and libxc calls. Of course I can, but I did look at the rest of the function and found that it uses "ret" for the purpose of what you now say "rc" ought to be used for. Seeing "ret", I decided to avoid it (knowing you use different names for different kinds of return values). While I've switched to "r" for now, I'd be rather inclined to re-use "ret" instead. (Or actually, as per the remark further down, I can get away without any local variable then.) >> + XEN_DOMCTL_SHADOW_OP_SET_ALLOCATION, >> + NULL, 0, &shadow, 0, NULL); >> + >> + if (rc) { > > xc_shadow_control seems to return "domctl.u.shadow_op.pages" in some > cases, are all non-zero return value errors? Indeed it does, but (a) we pass in zero here and (b) this operation doesn't alter (nor even care about) the value. So I'd prefer to stick to what I have, but if you tell me to switch to "... < 0", I will. >> + LOGED(ERROR, domid, >> + "Failed to set %s allocation: %d (errno:%d)\n", > > LOGED already prints prints the meaning of the "errno" value, so we > don't need to log it. I see. Please note that again I took neighboring code (a few lines down) for reference. Judging from other call sites (not the one right below here) I infer I also shouldn't have \n in the format string? >> + libxl_defbool_val(d_config->c_info.hap) ? "HAP" : "shadow", >> + rc, errno); > > Is the return value of xc_shadow_control() actually useful when errno is > already logged? I don't know. Again what I had matches what can be found a few lines down in the same function. But looking at other uses (in other files) I'm getting the impression that it's useless - dropped. Jan From xen-devel-bounces@lists.xenproject.org Fri Jul 02 13:18:57 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Jul 2021 13:18:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149140.275692 (Exim 4.92) (envelope-from ) id 1lzJ48-00074w-Kw; Fri, 02 Jul 2021 13:18:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149140.275692; Fri, 02 Jul 2021 13:18:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzJ48-00074p-I2; Fri, 02 Jul 2021 13:18:44 +0000 Received: by outflank-mailman (input) for mailman id 149140; Fri, 02 Jul 2021 13:18:43 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzJ47-00074j-AX for xen-devel@lists.xenproject.org; Fri, 02 Jul 2021 13:18:43 +0000 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 04cb8054-db38-11eb-83ac-12813bfff9fa; Fri, 02 Jul 2021 13:18:41 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 4D3B36109D; Fri, 2 Jul 2021 13:18:33 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 04cb8054-db38-11eb-83ac-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1625231920; bh=GDNc99vWU2EKYVywroGm/MONGRMfJ1bw5GtcP1Kxyew=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UpJXnxcF4r+u8N9In3Ngt/3KsBiIssEtR46hbKVGD4imJoDwZps2CiNu9/tX6XODL RkRPeCMJzkowmvGyx+vBIS2hY1z4ccknZBrbZdUt3JmjE2xh4ItTea2grkiScPUhIn HLmoRTEOJQbfW+p5GY0xQ0VKUewGU1RsIqEJOhMbpuv3pp74w18YlrSAOnrKBIP55s v+J/uIyo0HZY5XHsn1OOtuplTl/3fBAHP0aXr8wAQJjJJZ7gIcW+IXijJkOA5vhe1e A78+z8Z0KIiDl7b4jtkq2bGKSaVHIDksVIMFkEDwiE3IncWj68Vxm0ezE9lm9A76mg Qcdpn8Gt/MWYA== Date: Fri, 2 Jul 2021 14:18:29 +0100 From: Will Deacon To: Robin Murphy Cc: Guenter Roeck , Claire Chang , Rob Herring , mpe@ellerman.id.au, Joerg Roedel , Frank Rowand , Konrad Rzeszutek Wilk , boris.ostrovsky@oracle.com, jgross@suse.com, Christoph Hellwig , Marek Szyprowski , heikki.krogerus@linux.intel.com, thomas.hellstrom@linux.intel.com, peterz@infradead.org, dri-devel@lists.freedesktop.org, chris@chris-wilson.co.uk, grant.likely@arm.com, paulus@samba.org, mingo@kernel.org, jxgao@google.com, sstabellini@kernel.org, Saravana Kannan , xypron.glpk@gmx.de, "Rafael J . Wysocki" , Bartosz Golaszewski , bskeggs@redhat.com, linux-pci@vger.kernel.org, xen-devel@lists.xenproject.org, Thierry Reding , intel-gfx@lists.freedesktop.org, matthew.auld@intel.com, linux-devicetree , airlied@linux.ie, Nicolas Boichat , rodrigo.vivi@intel.com, bhelgaas@google.com, Dan Williams , Andy Shevchenko , Greg KH , Randy Dunlap , quic_qiancai@quicinc.com, lkml , tfiga@chromium.org, "list@263.net:IOMMU DRIVERS" , Jim Quinlan , thomas.lendacky@amd.com, linuxppc-dev@lists.ozlabs.org, bauerman@linux.ibm.com Subject: Re: [PATCH v15 12/12] of: Add plumbing for restricted DMA pool Message-ID: <20210702131829.GA11132@willie-the-truck> References: <20210624155526.2775863-1-tientzu@chromium.org> <20210624155526.2775863-13-tientzu@chromium.org> <20210702030807.GA2685166@roeck-us.net> <87ca3ada-22ed-f40c-0089-ca6fffc04f24@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87ca3ada-22ed-f40c-0089-ca6fffc04f24@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) On Fri, Jul 02, 2021 at 12:39:41PM +0100, Robin Murphy wrote: > On 2021-07-02 04:08, Guenter Roeck wrote: > > On Thu, Jun 24, 2021 at 11:55:26PM +0800, Claire Chang wrote: > > > If a device is not behind an IOMMU, we look up the device node and set > > > up the restricted DMA when the restricted-dma-pool is presented. > > > > > > Signed-off-by: Claire Chang > > > Tested-by: Stefano Stabellini > > > Tested-by: Will Deacon > > > > With this patch in place, all sparc and sparc64 qemu emulations > > fail to boot. Symptom is that the root file system is not found. > > Reverting this patch fixes the problem. Bisect log is attached. > > Ah, OF_ADDRESS depends on !SPARC, so of_dma_configure_id() is presumably > returning an unexpected -ENODEV from the of_dma_set_restricted_buffer() > stub. That should probably be returning 0 instead, since either way it's not > an error condition for it to simply do nothing. Something like below? Will --->8 >From 4d9dcb9210c1f37435b6088284e04b6b36ee8c4d Mon Sep 17 00:00:00 2001 From: Will Deacon Date: Fri, 2 Jul 2021 14:13:28 +0100 Subject: [PATCH] of: Return success from of_dma_set_restricted_buffer() when !OF_ADDRESS When CONFIG_OF_ADDRESS=n, of_dma_set_restricted_buffer() returns -ENODEV and breaks the boot for sparc[64] machines. Return 0 instead, since the function is essentially a glorified NOP in this configuration. Cc: Claire Chang Cc: Konrad Rzeszutek Wilk Reported-by: Guenter Roeck Suggested-by: Robin Murphy Link: https://lore.kernel.org/r/20210702030807.GA2685166@roeck-us.net Signed-off-by: Will Deacon --- drivers/of/of_private.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/of/of_private.h b/drivers/of/of_private.h index 8fde97565d11..34dd548c5eac 100644 --- a/drivers/of/of_private.h +++ b/drivers/of/of_private.h @@ -173,7 +173,8 @@ static inline int of_dma_get_range(struct device_node *np, static inline int of_dma_set_restricted_buffer(struct device *dev, struct device_node *np) { - return -ENODEV; + /* Do nothing, successfully. */ + return 0; } #endif -- 2.32.0.93.g670b81a890-goog From xen-devel-bounces@lists.xenproject.org Fri Jul 02 13:49:10 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Jul 2021 13:49:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149145.275703 (Exim 4.92) (envelope-from ) id 1lzJXT-0001iC-W7; Fri, 02 Jul 2021 13:49:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149145.275703; Fri, 02 Jul 2021 13:49:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzJXT-0001i5-SI; Fri, 02 Jul 2021 13:49:03 +0000 Received: by outflank-mailman (input) for mailman id 149145; Fri, 02 Jul 2021 13:49:02 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzJXS-0001hz-1h for xen-devel@lists.xenproject.org; Fri, 02 Jul 2021 13:49:02 +0000 Received: from mail-ot1-x333.google.com (unknown [2607:f8b0:4864:20::333]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 2da892b3-a654-4c8e-8c23-2ccfa732e28c; Fri, 02 Jul 2021 13:49:01 +0000 (UTC) Received: by mail-ot1-x333.google.com with SMTP id i12-20020a05683033ecb02903346fa0f74dso10074494otu.10 for ; Fri, 02 Jul 2021 06:49:01 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id n26sm599488oos.14.2021.07.02.06.48.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 02 Jul 2021 06:48:59 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: 2da892b3-a654-4c8e-8c23-2ccfa732e28c DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=9x+juvDeOlaCtKmozneQfrCt9yo0Whbh1MNkOy7JJZU=; b=UEjOTwG3dEw4BMs9zskTAlB/qyEqwJyHyp2F3uc3IEyjANLR6uP1/H9KR/MbGUoN+q uXXp5fn/iI8ZGaLxshXE1VQxeK5/3UWORkO2pNxSV6JX6TB55C98dgtqR+ifQCzwR/+E tWXw5g4HJNLzPOLmN5ZESxRdKK1SlSI9vIjSxu/oxrzoNqDVDJAp6devlE/I9vjje1jl UriRs+KKNlto9yhu5Cc6j3zBlDtCEQbiH6DoyRIcLxwtvRuZjbkzbi0yal/mv3qJLt2a 3fiDvGnsl5Hudqdx9BEktUwL9MS3wAY6jCzLNb0Q5Ly1c+F45rGX3brSqu3cPed6aviv JOqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=9x+juvDeOlaCtKmozneQfrCt9yo0Whbh1MNkOy7JJZU=; b=ZCTGP4CyT+8Z9LyRsplfQinqlw+A048EpprqlN0KfKpgs9CzGHx0FQYQRfCfTeNOIc 0j3s3OYrbDVqyJomjoaDrEOvhMxpQp/M82NUu2qIBH/jv9TccfQfTsO8dnRLNe4iGg/6 cjuyDohMLfbrX+nRQ6rotVEnFgtPl0bd2KL9a56CV4rCPNKCBYY2Lvc1q+TKvn/cG/Kw t2giVmLbl8kANcdLKvhgedbs2lMKZAxrIlZp5hP+g4Gjwr5MbDklW56cTBl22XjnPIoK GDWqy9dSZrhMbePFdwqipvT47zxwXpG6nllaTYYNj5syFbwrUQWNQJy1/cPm5ygUaY6W ZKOQ== X-Gm-Message-State: AOAM530LKbpqS8LMRXTV0010TE8god9sjpeSwifWmuPE2MefWqKVAA6W D6kXX987wcf8VXbSeqn3KQo= X-Google-Smtp-Source: ABdhPJzlnGPxxKYZSXkVHHmfsdkLH9E7ecEfVsvBHCQZR82klKUBGGO/PYD4fEoEphoBmS1gKABKng== X-Received: by 2002:a05:6830:823:: with SMTP id t3mr4518459ots.334.1625233740480; Fri, 02 Jul 2021 06:49:00 -0700 (PDT) Sender: Guenter Roeck Subject: Re: [PATCH v15 12/12] of: Add plumbing for restricted DMA pool To: Will Deacon , Robin Murphy Cc: Claire Chang , Rob Herring , mpe@ellerman.id.au, Joerg Roedel , Frank Rowand , Konrad Rzeszutek Wilk , boris.ostrovsky@oracle.com, jgross@suse.com, Christoph Hellwig , Marek Szyprowski , heikki.krogerus@linux.intel.com, thomas.hellstrom@linux.intel.com, peterz@infradead.org, dri-devel@lists.freedesktop.org, chris@chris-wilson.co.uk, grant.likely@arm.com, paulus@samba.org, mingo@kernel.org, jxgao@google.com, sstabellini@kernel.org, Saravana Kannan , xypron.glpk@gmx.de, "Rafael J . Wysocki" , Bartosz Golaszewski , bskeggs@redhat.com, linux-pci@vger.kernel.org, xen-devel@lists.xenproject.org, Thierry Reding , intel-gfx@lists.freedesktop.org, matthew.auld@intel.com, linux-devicetree , airlied@linux.ie, Nicolas Boichat , rodrigo.vivi@intel.com, bhelgaas@google.com, Dan Williams , Andy Shevchenko , Greg KH , Randy Dunlap , quic_qiancai@quicinc.com, lkml , tfiga@chromium.org, "list@263.net:IOMMU DRIVERS" , Jim Quinlan , thomas.lendacky@amd.com, linuxppc-dev@lists.ozlabs.org, bauerman@linux.ibm.com References: <20210624155526.2775863-1-tientzu@chromium.org> <20210624155526.2775863-13-tientzu@chromium.org> <20210702030807.GA2685166@roeck-us.net> <87ca3ada-22ed-f40c-0089-ca6fffc04f24@arm.com> <20210702131829.GA11132@willie-the-truck> From: Guenter Roeck Message-ID: <2f2d6633-2457-f7eb-81c1-355f56dc34ce@roeck-us.net> Date: Fri, 2 Jul 2021 06:48:54 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210702131829.GA11132@willie-the-truck> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 7/2/21 6:18 AM, Will Deacon wrote: > On Fri, Jul 02, 2021 at 12:39:41PM +0100, Robin Murphy wrote: >> On 2021-07-02 04:08, Guenter Roeck wrote: >>> On Thu, Jun 24, 2021 at 11:55:26PM +0800, Claire Chang wrote: >>>> If a device is not behind an IOMMU, we look up the device node and set >>>> up the restricted DMA when the restricted-dma-pool is presented. >>>> >>>> Signed-off-by: Claire Chang >>>> Tested-by: Stefano Stabellini >>>> Tested-by: Will Deacon >>> >>> With this patch in place, all sparc and sparc64 qemu emulations >>> fail to boot. Symptom is that the root file system is not found. >>> Reverting this patch fixes the problem. Bisect log is attached. >> >> Ah, OF_ADDRESS depends on !SPARC, so of_dma_configure_id() is presumably >> returning an unexpected -ENODEV from the of_dma_set_restricted_buffer() >> stub. That should probably be returning 0 instead, since either way it's not >> an error condition for it to simply do nothing. > > Something like below? > Yes, that does the trick. > Will > > --->8 > >>From 4d9dcb9210c1f37435b6088284e04b6b36ee8c4d Mon Sep 17 00:00:00 2001 > From: Will Deacon > Date: Fri, 2 Jul 2021 14:13:28 +0100 > Subject: [PATCH] of: Return success from of_dma_set_restricted_buffer() when > !OF_ADDRESS > > When CONFIG_OF_ADDRESS=n, of_dma_set_restricted_buffer() returns -ENODEV > and breaks the boot for sparc[64] machines. Return 0 instead, since the > function is essentially a glorified NOP in this configuration. > > Cc: Claire Chang > Cc: Konrad Rzeszutek Wilk > Reported-by: Guenter Roeck > Suggested-by: Robin Murphy > Link: https://lore.kernel.org/r/20210702030807.GA2685166@roeck-us.net > Signed-off-by: Will Deacon Tested-by: Guenter Roeck > --- > drivers/of/of_private.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/of/of_private.h b/drivers/of/of_private.h > index 8fde97565d11..34dd548c5eac 100644 > --- a/drivers/of/of_private.h > +++ b/drivers/of/of_private.h > @@ -173,7 +173,8 @@ static inline int of_dma_get_range(struct device_node *np, > static inline int of_dma_set_restricted_buffer(struct device *dev, > struct device_node *np) > { > - return -ENODEV; > + /* Do nothing, successfully. */ > + return 0; > } > #endif > > From xen-devel-bounces@lists.xenproject.org Fri Jul 02 13:59:16 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Jul 2021 13:59:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149150.275714 (Exim 4.92) (envelope-from ) id 1lzJhH-00039E-SX; Fri, 02 Jul 2021 13:59:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149150.275714; Fri, 02 Jul 2021 13:59:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzJhH-000397-PU; Fri, 02 Jul 2021 13:59:11 +0000 Received: by outflank-mailman (input) for mailman id 149150; Fri, 02 Jul 2021 13:59:10 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzJhG-000391-FL for xen-devel@lists.xenproject.org; Fri, 02 Jul 2021 13:59:10 +0000 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id fef40f88-8c4d-448c-8a71-2bca51ebaed8; Fri, 02 Jul 2021 13:59:09 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id E67B26142B; Fri, 2 Jul 2021 13:59:00 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fef40f88-8c4d-448c-8a71-2bca51ebaed8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1625234348; bh=GAzz+9Wi5F3smddcMqAPXL+yX+g6y+b7+ZdyCyCYk6o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DRFf+Wzi4/1+CXjK9WTjhUw5flwP67NTwGefIxgOECtBfi65Tj3m3RZAnGmMeaHWN 2nB6ydioSV2HMouSGryEIIBRdSlehAFMTcH+PJ43Fzncx1dyolaRkF7sppvivPuZf7 cPX4Boe7jQMJiyFe3ZHKT4MFIZG39Q+YJQliaRWFbkh7/vzRbU7bxJi79Z1ru+gtBo ad1ubKsTeSBiWjEpbwdaLM3RhLgyMoL6khfdtq+W/6U3noQUe78qA62SPzsLgc5K4n HLEZtG+/PJtTdlqtEwnI8LIwqrv30Hz5pVN+cgBES579vlL24El76ac3B9gttOgNJw +e4R0HS7ObwsQ== Date: Fri, 2 Jul 2021 14:58:57 +0100 From: Will Deacon To: Nathan Chancellor Cc: Claire Chang , Rob Herring , mpe@ellerman.id.au, Joerg Roedel , Frank Rowand , Konrad Rzeszutek Wilk , boris.ostrovsky@oracle.com, jgross@suse.com, Christoph Hellwig , Marek Szyprowski , benh@kernel.crashing.org, paulus@samba.org, "list@263.net:IOMMU DRIVERS" , Stefano Stabellini , Robin Murphy , grant.likely@arm.com, xypron.glpk@gmx.de, Thierry Reding , mingo@kernel.org, bauerman@linux.ibm.com, peterz@infradead.org, Greg KH , Saravana Kannan , "Rafael J . Wysocki" , heikki.krogerus@linux.intel.com, Andy Shevchenko , Randy Dunlap , Dan Williams , Bartosz Golaszewski , linux-devicetree , lkml , linuxppc-dev@lists.ozlabs.org, xen-devel@lists.xenproject.org, Nicolas Boichat , Jim Quinlan , Tomasz Figa , bskeggs@redhat.com, Bjorn Helgaas , chris@chris-wilson.co.uk, Daniel Vetter , airlied@linux.ie, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, jani.nikula@linux.intel.com, Jianxiong Gao , joonas.lahtinen@linux.intel.com, linux-pci@vger.kernel.org, maarten.lankhorst@linux.intel.com, matthew.auld@intel.com, rodrigo.vivi@intel.com, thomas.hellstrom@linux.intel.com, Tom Lendacky , Qian Cai Subject: Re: [PATCH v15 06/12] swiotlb: Use is_swiotlb_force_bounce for swiotlb data bouncing Message-ID: <20210702135856.GB11132@willie-the-truck> References: <20210624155526.2775863-1-tientzu@chromium.org> <20210624155526.2775863-7-tientzu@chromium.org> <20210630114348.GA8383@willie-the-truck> <20210701074045.GA9436@willie-the-truck> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Hi Nathan, On Thu, Jul 01, 2021 at 12:52:20AM -0700, Nathan Chancellor wrote: > On 7/1/2021 12:40 AM, Will Deacon wrote: > > On Wed, Jun 30, 2021 at 08:56:51AM -0700, Nathan Chancellor wrote: > > > On Wed, Jun 30, 2021 at 12:43:48PM +0100, Will Deacon wrote: > > > > On Wed, Jun 30, 2021 at 05:17:27PM +0800, Claire Chang wrote: > > > > > `BUG: unable to handle page fault for address: 00000000003a8290` and > > > > > the fact it crashed at `_raw_spin_lock_irqsave` look like the memory > > > > > (maybe dev->dma_io_tlb_mem) was corrupted? > > > > > The dev->dma_io_tlb_mem should be set here > > > > > (https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/pci/probe.c#n2528) > > > > > through device_initialize. > > > > > > > > I'm less sure about this. 'dma_io_tlb_mem' should be pointing at > > > > 'io_tlb_default_mem', which is a page-aligned allocation from memblock. > > > > The spinlock is at offset 0x24 in that structure, and looking at the > > > > register dump from the crash: > > > > > > > > Jun 29 18:28:42 hp-4300G kernel: RSP: 0018:ffffadb4013db9e8 EFLAGS: 00010006 > > > > Jun 29 18:28:42 hp-4300G kernel: RAX: 00000000003a8290 RBX: 0000000000000000 RCX: ffff8900572ad580 > > > > Jun 29 18:28:42 hp-4300G kernel: RDX: ffff89005653f024 RSI: 00000000000c0000 RDI: 0000000000001d17 > > > > Jun 29 18:28:42 hp-4300G kernel: RBP: 000000000a20d000 R08: 00000000000c0000 R09: 0000000000000000 > > > > Jun 29 18:28:42 hp-4300G kernel: R10: 000000000a20d000 R11: ffff89005653f000 R12: 0000000000000212 > > > > Jun 29 18:28:42 hp-4300G kernel: R13: 0000000000001000 R14: 0000000000000002 R15: 0000000000200000 > > > > Jun 29 18:28:42 hp-4300G kernel: FS: 00007f1f8898ea40(0000) GS:ffff890057280000(0000) knlGS:0000000000000000 > > > > Jun 29 18:28:42 hp-4300G kernel: CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > > > > Jun 29 18:28:42 hp-4300G kernel: CR2: 00000000003a8290 CR3: 00000001020d0000 CR4: 0000000000350ee0 > > > > Jun 29 18:28:42 hp-4300G kernel: Call Trace: > > > > Jun 29 18:28:42 hp-4300G kernel: _raw_spin_lock_irqsave+0x39/0x50 > > > > Jun 29 18:28:42 hp-4300G kernel: swiotlb_tbl_map_single+0x12b/0x4c0 > > > > > > > > Then that correlates with R11 holding the 'dma_io_tlb_mem' pointer and > > > > RDX pointing at the spinlock. Yet RAX is holding junk :/ > > > > > > > > I agree that enabling KASAN would be a good idea, but I also think we > > > > probably need to get some more information out of swiotlb_tbl_map_single() > > > > to see see what exactly is going wrong in there. > > > > > > I can certainly enable KASAN and if there is any debug print I can add > > > or dump anything, let me know! > > > > I bit the bullet and took v5.13 with swiotlb/for-linus-5.14 merged in, built > > x86 defconfig and ran it on my laptop. However, it seems to work fine! > > > > Please can you share your .config? > > Sure thing, it is attached. It is just Arch Linux's config run through > olddefconfig. The original is below in case you need to diff it. > > https://raw.githubusercontent.com/archlinux/svntogit-packages/9045405dc835527164f3034b3ceb9a67c7a53cd4/trunk/config > > If there is anything more that I can provide, please let me know. I eventually got this booting (for some reason it was causing LD to SEGV trying to link it for a while...) and sadly it works fine on my laptop. Hmm. Did you manage to try again with KASAN? It might also be worth taking the IOMMU out of the equation, since that interfaces differently with SWIOTLB and I couldn't figure out the code path from the log you provided. What happens if you boot with "amd_iommu=off swiotlb=force"? (although word of warning here: i915 dies horribly on my laptop if I pass swiotlb=force, even with the distro 5.10 kernel) Will From xen-devel-bounces@lists.xenproject.org Fri Jul 02 14:04:47 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Jul 2021 14:04:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149154.275725 (Exim 4.92) (envelope-from ) id 1lzJmb-0004fI-Ku; Fri, 02 Jul 2021 14:04:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149154.275725; Fri, 02 Jul 2021 14:04:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzJmb-0004fB-I0; Fri, 02 Jul 2021 14:04:41 +0000 Received: by outflank-mailman (input) for mailman id 149154; Fri, 02 Jul 2021 14:04:41 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzJmb-0004f5-4I for xen-devel@lists.xenproject.org; Fri, 02 Jul 2021 14:04:41 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzJmZ-000282-1D; Fri, 02 Jul 2021 14:04:39 +0000 Received: from [54.239.6.178] (helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lzJmY-0008EW-RB; Fri, 02 Jul 2021 14:04:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=6EtD5SqbRZJNvHvLZGtuLrFhx1G/nd/OrXMKhDJ1chI=; b=qkbpf3/7L3zxazPEqvUwNJEF3h me/qnG0UXHl2hv8SZx97S0v+791Kl2O0JMxlK6MzKLqwDUF6UqrIkmUW2bF0JjsBaSYIVPB0QCh+S 6WV71OiNu+yA/svhIKwqy4lgVs3lrvLlMnkJTDtNdTHR5bESOZuPCzwjGeAfzHoAgYFc=; Subject: Re: [XEN PATCH] Config.mk: re-pin OVMF changeset and unpin qemu-xen To: Ian Jackson , Anthony PERARD Cc: xen-devel@lists.xenproject.org, Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu References: <20210628134217.47622-1-anthony.perard@citrix.com> <24793.54037.159770.159505@mariner.uk.xensource.com> From: Julien Grall Message-ID: Date: Fri, 2 Jul 2021 15:04:36 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <24793.54037.159770.159505@mariner.uk.xensource.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi, On 28/06/2021 14:48, Ian Jackson wrote: > Anthony PERARD writes ("[XEN PATCH] Config.mk: re-pin OVMF changeset and unpin qemu-xen"): >> qemu-xen tree have a osstest gate and doesn't need to be pinned. >> >> On the other hand, OVMF's xen repository doesn't have a gate and needs >> to be pinned. The "master" branch correspond now to the tag >> "edk2-stable202105", so pin to that commit. >> >> Fixes: a04509d34d72 ("Branching: Update version files etc. for newly unstable") >> Signed-off-by: Anthony PERARD > > Acked-by: Ian Jackson > > Looks like I adjusted the wrong line in a04509d34d72. Sorry. I have committed it. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Jul 02 14:07:56 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Jul 2021 14:07:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149157.275736 (Exim 4.92) (envelope-from ) id 1lzJpk-0005J6-4S; Fri, 02 Jul 2021 14:07:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149157.275736; Fri, 02 Jul 2021 14:07:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzJpk-0005Iz-1S; Fri, 02 Jul 2021 14:07:56 +0000 Received: by outflank-mailman (input) for mailman id 149157; Fri, 02 Jul 2021 14:07:54 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzJpi-0005Ir-TV for xen-devel@lists.xenproject.org; Fri, 02 Jul 2021 14:07:54 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzJpi-0002AY-Lb; Fri, 02 Jul 2021 14:07:54 +0000 Received: from [54.239.6.178] (helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lzJpi-0008Vt-G8; Fri, 02 Jul 2021 14:07:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:Cc:References:To:Subject; bh=Nk9KjwhaCTd13rM719XKrXuTMUVVzXZ5x4wfekoB+lE=; b=ndiOxL6/JJ1LTocE7hP+QUJ7y4 mOF/z4vlYVVUkwDlbZjPrbdIrnJ5iJPmrFTXLvLHYYrrqM54vMBQYYHkC4qwVJg11fb3QxcPWH8Zr GECscAVKpTeh39zlkZBiKXbUzq3CvHo+Br8iALKAmIlS4NSr5ZLbi3CIG2Akxmr64axU=; Subject: Re: Some more QEMU 6.0 fixes To: Anthony PERARD , xen-devel@lists.xenproject.org References: <20210628100157.5010-1-anthony.perard@citrix.com> Cc: Ian Jackson From: Julien Grall Message-ID: <0a4325fd-97f4-7301-1402-27ee7ee2fe8c@xen.org> Date: Fri, 2 Jul 2021 15:07:53 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210628100157.5010-1-anthony.perard@citrix.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi, On 28/06/2021 11:01, Anthony PERARD wrote: > Follow-up of > [XEN PATCH v2 0/8] Fix libxl with QEMU 6.0 + remove some more deprecated usages > to fix few missing bits. I have committed the series. > > To be backported to Xen 4.15 as well. @Ian can you queue it for backport? Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Jul 02 14:30:03 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Jul 2021 14:30:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149168.275760 (Exim 4.92) (envelope-from ) id 1lzKAy-0007ko-4l; Fri, 02 Jul 2021 14:29:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149168.275760; Fri, 02 Jul 2021 14:29:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzKAy-0007kh-00; Fri, 02 Jul 2021 14:29:52 +0000 Received: by outflank-mailman (input) for mailman id 149168; Fri, 02 Jul 2021 14:29:50 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzKAv-0007kb-VF for xen-devel@lists.xenproject.org; Fri, 02 Jul 2021 14:29:50 +0000 Received: from smtp-out1.suse.de (unknown [195.135.220.28]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id f3c3f818-db41-11eb-83b0-12813bfff9fa; Fri, 02 Jul 2021 14:29:48 +0000 (UTC) Received: from imap.suse.de (imap-alt.suse-dmz.suse.de [192.168.254.47]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 0805C2260D; Fri, 2 Jul 2021 14:29:47 +0000 (UTC) Received: from imap3-int (imap-alt.suse-dmz.suse.de [192.168.254.47]) by imap.suse.de (Postfix) with ESMTP id CA8FD11C84; Fri, 2 Jul 2021 14:29:46 +0000 (UTC) Received: from director2.suse.de ([192.168.254.72]) by imap3-int with ESMTPSA id TJVoL9oi32A9YwAALh3uQQ (envelope-from ); Fri, 02 Jul 2021 14:29:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f3c3f818-db41-11eb-83b0-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1625236187; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=CvTtdyfy/5mwGsdpXhBqLdVczADRr3EuF8hDT43aDaE=; b=oEh9QJ6D5NNXMiS096947GW9oZsES4Y0+fGyrn3rhZKA2hP0eCVwo6zBWBCp8S7lgEFTWV bgZEG2Dbo47R8uQqlZ7s9KO63XnkvlEZJAncltlWWtFY8T6Vk9fLaTYrWPtqtqhG5oVptW Wh5G97aGtwOAvwXl9ZXIhiPXXNCtvgY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1625236187; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=CvTtdyfy/5mwGsdpXhBqLdVczADRr3EuF8hDT43aDaE=; b=oEh9QJ6D5NNXMiS096947GW9oZsES4Y0+fGyrn3rhZKA2hP0eCVwo6zBWBCp8S7lgEFTWV bgZEG2Dbo47R8uQqlZ7s9KO63XnkvlEZJAncltlWWtFY8T6Vk9fLaTYrWPtqtqhG5oVptW Wh5G97aGtwOAvwXl9ZXIhiPXXNCtvgY= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Ian Jackson , Wei Liu Subject: [PATCH-4.15] tools/libs/ctrl: fix xc_core_arch_map_p2m() to support linear p2m table Date: Fri, 2 Jul 2021 16:29:44 +0200 Message-Id: <20210702142944.1698-1-jgross@suse.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The core of a pv linux guest produced via "xl dump-core" is not usable as since kernel 4.14 only the linear p2m table is kept if Xen indicates it is supporting that. Unfortunately xc_core_arch_map_p2m() is still supporting the 3-level p2m tree only. Fix that by copying the functionality of map_p2m() from libxenguest to libxenctrl. Additionally the mapped p2m isn't of a fixed length now, so the interface to the mapping functions needs to be adapted. In order not to add even more parameters, expand struct domain_info_context and use a pointer to that as a parameter. This is a backport of upstream commit bd7a29c3d0b937ab542a. As the original patch includes a modification of a data structure passed via pointer to a library function, the related function in the library is renamed in order to be able to spot any external users of that function. Note that it is extremely unlikely any such users outside the Xen git tree are existing, so the risk to break any existing programs is very unlikely. In case such a user is existing, changing the name of xc_map_domain_meminfo() will at least avoid silent breakage. Fixes: dc6d60937121 ("libxc: set flag for support of linear p2m list in domain builder") Signed-off-by: Juergen Gross --- tools/include/xenguest.h | 2 + tools/libs/ctrl/xc_core.c | 5 +- tools/libs/ctrl/xc_core.h | 8 +- tools/libs/ctrl/xc_core_arm.c | 23 +-- tools/libs/ctrl/xc_core_x86.c | 256 ++++++++++++++++++++++++++++------ tools/libs/ctrl/xc_private.h | 1 + tools/libs/guest/xg_domain.c | 17 +-- 7 files changed, 234 insertions(+), 78 deletions(-) diff --git a/tools/include/xenguest.h b/tools/include/xenguest.h index 217022b6e7..36a26deba4 100644 --- a/tools/include/xenguest.h +++ b/tools/include/xenguest.h @@ -700,8 +700,10 @@ struct xc_domain_meminfo { xen_pfn_t *pfn_type; xen_pfn_t *p2m_table; unsigned long p2m_size; + unsigned int p2m_frames; }; +#define xc_map_domain_meminfo xc_map_domain_meminfo_mod int xc_map_domain_meminfo(xc_interface *xch, uint32_t domid, struct xc_domain_meminfo *minfo); diff --git a/tools/libs/ctrl/xc_core.c b/tools/libs/ctrl/xc_core.c index b47ab2f6d8..9576bec5a3 100644 --- a/tools/libs/ctrl/xc_core.c +++ b/tools/libs/ctrl/xc_core.c @@ -574,8 +574,7 @@ xc_domain_dumpcore_via_callback(xc_interface *xch, goto out; } - sts = xc_core_arch_map_p2m(xch, dinfo->guest_width, &info, live_shinfo, - &p2m, &dinfo->p2m_size); + sts = xc_core_arch_map_p2m(xch, dinfo, &info, live_shinfo, &p2m); if ( sts != 0 ) goto out; @@ -945,7 +944,7 @@ out: if ( memory_map != NULL ) free(memory_map); if ( p2m != NULL ) - munmap(p2m, PAGE_SIZE * P2M_FL_ENTRIES); + munmap(p2m, PAGE_SIZE * dinfo->p2m_frames); if ( p2m_array != NULL ) free(p2m_array); if ( pfn_array != NULL ) diff --git a/tools/libs/ctrl/xc_core.h b/tools/libs/ctrl/xc_core.h index 36fb755da2..8ea1f93a10 100644 --- a/tools/libs/ctrl/xc_core.h +++ b/tools/libs/ctrl/xc_core.h @@ -138,14 +138,14 @@ int xc_core_arch_memory_map_get(xc_interface *xch, xc_dominfo_t *info, shared_info_any_t *live_shinfo, xc_core_memory_map_t **mapp, unsigned int *nr_entries); -int xc_core_arch_map_p2m(xc_interface *xch, unsigned int guest_width, +int xc_core_arch_map_p2m(xc_interface *xch, struct domain_info_context *dinfo, xc_dominfo_t *info, shared_info_any_t *live_shinfo, - xen_pfn_t **live_p2m, unsigned long *pfnp); + xen_pfn_t **live_p2m); -int xc_core_arch_map_p2m_writable(xc_interface *xch, unsigned int guest_width, +int xc_core_arch_map_p2m_writable(xc_interface *xch, struct domain_info_context *dinfo, xc_dominfo_t *info, shared_info_any_t *live_shinfo, - xen_pfn_t **live_p2m, unsigned long *pfnp); + xen_pfn_t **live_p2m); int xc_core_arch_get_scratch_gpfn(xc_interface *xch, uint32_t domid, xen_pfn_t *gpfn); diff --git a/tools/libs/ctrl/xc_core_arm.c b/tools/libs/ctrl/xc_core_arm.c index 7b587b4cc5..93765a565f 100644 --- a/tools/libs/ctrl/xc_core_arm.c +++ b/tools/libs/ctrl/xc_core_arm.c @@ -66,33 +66,24 @@ xc_core_arch_memory_map_get(xc_interface *xch, struct xc_core_arch_context *unus static int xc_core_arch_map_p2m_rw(xc_interface *xch, struct domain_info_context *dinfo, xc_dominfo_t *info, - shared_info_any_t *live_shinfo, xen_pfn_t **live_p2m, - unsigned long *pfnp, int rw) + shared_info_any_t *live_shinfo, xen_pfn_t **live_p2m, int rw) { errno = ENOSYS; return -1; } int -xc_core_arch_map_p2m(xc_interface *xch, unsigned int guest_width, xc_dominfo_t *info, - shared_info_any_t *live_shinfo, xen_pfn_t **live_p2m, - unsigned long *pfnp) +xc_core_arch_map_p2m(xc_interface *xch, struct domain_info_context *dinfo, xc_dominfo_t *info, + shared_info_any_t *live_shinfo, xen_pfn_t **live_p2m) { - struct domain_info_context _dinfo = { .guest_width = guest_width }; - struct domain_info_context *dinfo = &_dinfo; - return xc_core_arch_map_p2m_rw(xch, dinfo, info, - live_shinfo, live_p2m, pfnp, 0); + return xc_core_arch_map_p2m_rw(xch, dinfo, info, live_shinfo, live_p2m, 0); } int -xc_core_arch_map_p2m_writable(xc_interface *xch, unsigned int guest_width, xc_dominfo_t *info, - shared_info_any_t *live_shinfo, xen_pfn_t **live_p2m, - unsigned long *pfnp) +xc_core_arch_map_p2m_writable(xc_interface *xch, struct domain_info_context *dinfo, xc_dominfo_t *info, + shared_info_any_t *live_shinfo, xen_pfn_t **live_p2m) { - struct domain_info_context _dinfo = { .guest_width = guest_width }; - struct domain_info_context *dinfo = &_dinfo; - return xc_core_arch_map_p2m_rw(xch, dinfo, info, - live_shinfo, live_p2m, pfnp, 1); + return xc_core_arch_map_p2m_rw(xch, dinfo, info, live_shinfo, live_p2m, 1); } int diff --git a/tools/libs/ctrl/xc_core_x86.c b/tools/libs/ctrl/xc_core_x86.c index cb76e6207b..c8f71d4b75 100644 --- a/tools/libs/ctrl/xc_core_x86.c +++ b/tools/libs/ctrl/xc_core_x86.c @@ -17,6 +17,7 @@ * */ +#include #include "xc_private.h" #include "xc_core.h" #include @@ -65,34 +66,169 @@ xc_core_arch_memory_map_get(xc_interface *xch, struct xc_core_arch_context *unus return 0; } -static int -xc_core_arch_map_p2m_rw(xc_interface *xch, struct domain_info_context *dinfo, xc_dominfo_t *info, - shared_info_any_t *live_shinfo, xen_pfn_t **live_p2m, - unsigned long *pfnp, int rw) +static inline bool is_canonical_address(uint64_t vaddr) { - /* Double and single indirect references to the live P2M table */ - xen_pfn_t *live_p2m_frame_list_list = NULL; - xen_pfn_t *live_p2m_frame_list = NULL; - /* Copies of the above. */ - xen_pfn_t *p2m_frame_list_list = NULL; - xen_pfn_t *p2m_frame_list = NULL; + return ((int64_t)vaddr >> 47) == ((int64_t)vaddr >> 63); +} - uint32_t dom = info->domid; - int ret = -1; - int err; - int i; +/* Virtual address ranges reserved for hypervisor. */ +#define HYPERVISOR_VIRT_START_X86_64 0xFFFF800000000000ULL +#define HYPERVISOR_VIRT_END_X86_64 0xFFFF87FFFFFFFFFFULL - if ( xc_domain_nr_gpfns(xch, info->domid, &dinfo->p2m_size) < 0 ) +#define HYPERVISOR_VIRT_START_X86_32 0x00000000F5800000ULL +#define HYPERVISOR_VIRT_END_X86_32 0x00000000FFFFFFFFULL + +static xen_pfn_t * +xc_core_arch_map_p2m_list_rw(xc_interface *xch, struct domain_info_context *dinfo, + uint32_t dom, shared_info_any_t *live_shinfo, + uint64_t p2m_cr3) +{ + uint64_t p2m_vaddr, p2m_end, mask, off; + xen_pfn_t p2m_mfn, mfn, saved_mfn, max_pfn; + uint64_t *ptes = NULL; + xen_pfn_t *mfns = NULL; + unsigned int fpp, n_pages, level, n_levels, shift, + idx_start, idx_end, idx, saved_idx; + + p2m_vaddr = GET_FIELD(live_shinfo, arch.p2m_vaddr, dinfo->guest_width); + fpp = PAGE_SIZE / dinfo->guest_width; + dinfo->p2m_frames = (dinfo->p2m_size - 1) / fpp + 1; + p2m_end = p2m_vaddr + dinfo->p2m_frames * PAGE_SIZE - 1; + + if ( dinfo->guest_width == 8 ) { - ERROR("Could not get maximum GPFN!"); - goto out; + mask = 0x0000ffffffffffffULL; + n_levels = 4; + p2m_mfn = p2m_cr3 >> 12; + if ( !is_canonical_address(p2m_vaddr) || + !is_canonical_address(p2m_end) || + p2m_end < p2m_vaddr || + (p2m_vaddr <= HYPERVISOR_VIRT_END_X86_64 && + p2m_end > HYPERVISOR_VIRT_START_X86_64) ) + { + ERROR("Bad virtual p2m address range %#" PRIx64 "-%#" PRIx64, + p2m_vaddr, p2m_end); + errno = ERANGE; + goto out; + } + } + else + { + mask = 0x00000000ffffffffULL; + n_levels = 3; + if ( p2m_cr3 & ~mask ) + p2m_mfn = ~0UL; + else + p2m_mfn = (uint32_t)((p2m_cr3 >> 12) | (p2m_cr3 << 20)); + if ( p2m_vaddr > mask || p2m_end > mask || p2m_end < p2m_vaddr || + (p2m_vaddr <= HYPERVISOR_VIRT_END_X86_32 && + p2m_end > HYPERVISOR_VIRT_START_X86_32) ) + { + ERROR("Bad virtual p2m address range %#" PRIx64 "-%#" PRIx64, + p2m_vaddr, p2m_end); + errno = ERANGE; + goto out; + } } - if ( dinfo->p2m_size < info->nr_pages ) + mfns = malloc(sizeof(*mfns)); + if ( !mfns ) { - ERROR("p2m_size < nr_pages -1 (%lx < %lx", dinfo->p2m_size, info->nr_pages - 1); + ERROR("Cannot allocate memory for array of %u mfns", 1); goto out; } + mfns[0] = p2m_mfn; + off = 0; + saved_mfn = 0; + idx_start = idx_end = saved_idx = 0; + + for ( level = n_levels; level > 0; level-- ) + { + n_pages = idx_end - idx_start + 1; + ptes = xc_map_foreign_pages(xch, dom, PROT_READ, mfns, n_pages); + if ( !ptes ) + { + PERROR("Failed to map %u page table pages for p2m list", n_pages); + goto out; + } + free(mfns); + + shift = level * 9 + 3; + idx_start = ((p2m_vaddr - off) & mask) >> shift; + idx_end = ((p2m_end - off) & mask) >> shift; + idx = idx_end - idx_start + 1; + mfns = malloc(sizeof(*mfns) * idx); + if ( !mfns ) + { + ERROR("Cannot allocate memory for array of %u mfns", idx); + goto out; + } + + for ( idx = idx_start; idx <= idx_end; idx++ ) + { + mfn = (ptes[idx] & 0x000ffffffffff000ULL) >> PAGE_SHIFT; + if ( mfn == 0 ) + { + ERROR("Bad mfn %#lx during page table walk for vaddr %#" PRIx64 " at level %d of p2m list", + mfn, off + ((uint64_t)idx << shift), level); + errno = ERANGE; + goto out; + } + mfns[idx - idx_start] = mfn; + + /* Maximum pfn check at level 2. Same reasoning as for p2m tree. */ + if ( level == 2 ) + { + if ( mfn != saved_mfn ) + { + saved_mfn = mfn; + saved_idx = idx - idx_start; + } + } + } + + if ( level == 2 ) + { + if ( saved_idx == idx_end ) + saved_idx++; + max_pfn = ((xen_pfn_t)saved_idx << 9) * fpp; + if ( max_pfn < dinfo->p2m_size ) + { + dinfo->p2m_size = max_pfn; + dinfo->p2m_frames = (dinfo->p2m_size + fpp - 1) / fpp; + p2m_end = p2m_vaddr + dinfo->p2m_frames * PAGE_SIZE - 1; + idx_end = idx_start + saved_idx; + } + } + + munmap(ptes, n_pages * PAGE_SIZE); + ptes = NULL; + off = p2m_vaddr & ((mask >> shift) << shift); + } + + return mfns; + + out: + free(mfns); + if ( ptes ) + munmap(ptes, n_pages * PAGE_SIZE); + + return NULL; +} + +static xen_pfn_t * +xc_core_arch_map_p2m_tree_rw(xc_interface *xch, struct domain_info_context *dinfo, + uint32_t dom, shared_info_any_t *live_shinfo) +{ + /* Double and single indirect references to the live P2M table */ + xen_pfn_t *live_p2m_frame_list_list; + xen_pfn_t *live_p2m_frame_list = NULL; + /* Copies of the above. */ + xen_pfn_t *p2m_frame_list_list = NULL; + xen_pfn_t *p2m_frame_list; + + int err; + int i; live_p2m_frame_list_list = xc_map_foreign_range(xch, dom, PAGE_SIZE, PROT_READ, @@ -151,10 +287,60 @@ xc_core_arch_map_p2m_rw(xc_interface *xch, struct domain_info_context *dinfo, xc for ( i = P2M_FL_ENTRIES - 1; i >= 0; i-- ) p2m_frame_list[i] = ((uint32_t *)p2m_frame_list)[i]; + dinfo->p2m_frames = P2M_FL_ENTRIES; + + return p2m_frame_list; + + out: + err = errno; + + if ( live_p2m_frame_list_list ) + munmap(live_p2m_frame_list_list, PAGE_SIZE); + + if ( live_p2m_frame_list ) + munmap(live_p2m_frame_list, P2M_FLL_ENTRIES * PAGE_SIZE); + + free(p2m_frame_list_list); + + errno = err; + + return NULL; +} + +static int +xc_core_arch_map_p2m_rw(xc_interface *xch, struct domain_info_context *dinfo, xc_dominfo_t *info, + shared_info_any_t *live_shinfo, xen_pfn_t **live_p2m, int rw) +{ + xen_pfn_t *p2m_frame_list = NULL; + uint64_t p2m_cr3; + uint32_t dom = info->domid; + int ret = -1; + int err; + + if ( xc_domain_nr_gpfns(xch, info->domid, &dinfo->p2m_size) < 0 ) + { + ERROR("Could not get maximum GPFN!"); + goto out; + } + + if ( dinfo->p2m_size < info->nr_pages ) + { + ERROR("p2m_size < nr_pages -1 (%lx < %lx", dinfo->p2m_size, info->nr_pages - 1); + goto out; + } + + p2m_cr3 = GET_FIELD(live_shinfo, arch.p2m_cr3, dinfo->guest_width); + + p2m_frame_list = p2m_cr3 ? xc_core_arch_map_p2m_list_rw(xch, dinfo, dom, live_shinfo, p2m_cr3) + : xc_core_arch_map_p2m_tree_rw(xch, dinfo, dom, live_shinfo); + + if ( !p2m_frame_list ) + goto out; + *live_p2m = xc_map_foreign_pages(xch, dom, rw ? (PROT_READ | PROT_WRITE) : PROT_READ, p2m_frame_list, - P2M_FL_ENTRIES); + dinfo->p2m_frames); if ( !*live_p2m ) { @@ -162,21 +348,11 @@ xc_core_arch_map_p2m_rw(xc_interface *xch, struct domain_info_context *dinfo, xc goto out; } - *pfnp = dinfo->p2m_size; - ret = 0; out: err = errno; - if ( live_p2m_frame_list_list ) - munmap(live_p2m_frame_list_list, PAGE_SIZE); - - if ( live_p2m_frame_list ) - munmap(live_p2m_frame_list, P2M_FLL_ENTRIES * PAGE_SIZE); - - free(p2m_frame_list_list); - free(p2m_frame_list); errno = err; @@ -184,25 +360,17 @@ out: } int -xc_core_arch_map_p2m(xc_interface *xch, unsigned int guest_width, xc_dominfo_t *info, - shared_info_any_t *live_shinfo, xen_pfn_t **live_p2m, - unsigned long *pfnp) +xc_core_arch_map_p2m(xc_interface *xch, struct domain_info_context *dinfo, xc_dominfo_t *info, + shared_info_any_t *live_shinfo, xen_pfn_t **live_p2m) { - struct domain_info_context _dinfo = { .guest_width = guest_width }; - struct domain_info_context *dinfo = &_dinfo; - return xc_core_arch_map_p2m_rw(xch, dinfo, info, - live_shinfo, live_p2m, pfnp, 0); + return xc_core_arch_map_p2m_rw(xch, dinfo, info, live_shinfo, live_p2m, 0); } int -xc_core_arch_map_p2m_writable(xc_interface *xch, unsigned int guest_width, xc_dominfo_t *info, - shared_info_any_t *live_shinfo, xen_pfn_t **live_p2m, - unsigned long *pfnp) +xc_core_arch_map_p2m_writable(xc_interface *xch, struct domain_info_context *dinfo, xc_dominfo_t *info, + shared_info_any_t *live_shinfo, xen_pfn_t **live_p2m) { - struct domain_info_context _dinfo = { .guest_width = guest_width }; - struct domain_info_context *dinfo = &_dinfo; - return xc_core_arch_map_p2m_rw(xch, dinfo, info, - live_shinfo, live_p2m, pfnp, 1); + return xc_core_arch_map_p2m_rw(xch, dinfo, info, live_shinfo, live_p2m, 1); } int diff --git a/tools/libs/ctrl/xc_private.h b/tools/libs/ctrl/xc_private.h index f0b5f83ac8..8ebc0b59da 100644 --- a/tools/libs/ctrl/xc_private.h +++ b/tools/libs/ctrl/xc_private.h @@ -79,6 +79,7 @@ struct iovec { struct domain_info_context { unsigned int guest_width; + unsigned int p2m_frames; unsigned long p2m_size; }; diff --git a/tools/libs/guest/xg_domain.c b/tools/libs/guest/xg_domain.c index 5019c84e0e..dd7db2cbd8 100644 --- a/tools/libs/guest/xg_domain.c +++ b/tools/libs/guest/xg_domain.c @@ -24,13 +24,9 @@ int xc_unmap_domain_meminfo(xc_interface *xch, struct xc_domain_meminfo *minfo) { - struct domain_info_context _di = { .guest_width = minfo->guest_width, - .p2m_size = minfo->p2m_size}; - struct domain_info_context *dinfo = &_di; - free(minfo->pfn_type); if ( minfo->p2m_table ) - munmap(minfo->p2m_table, P2M_FL_ENTRIES * PAGE_SIZE); + munmap(minfo->p2m_table, minfo->p2m_frames * PAGE_SIZE); minfo->p2m_table = NULL; return 0; @@ -40,7 +36,6 @@ int xc_map_domain_meminfo(xc_interface *xch, uint32_t domid, struct xc_domain_meminfo *minfo) { struct domain_info_context _di; - struct domain_info_context *dinfo = &_di; xc_dominfo_t info; shared_info_any_t *live_shinfo; @@ -96,16 +91,16 @@ int xc_map_domain_meminfo(xc_interface *xch, uint32_t domid, return -1; } - if ( xc_core_arch_map_p2m_writable(xch, minfo->guest_width, &info, - live_shinfo, &minfo->p2m_table, - &minfo->p2m_size) ) + if ( xc_core_arch_map_p2m_writable(xch, &_di, &info, + live_shinfo, &minfo->p2m_table) ) { PERROR("Could not map the P2M table"); munmap(live_shinfo, PAGE_SIZE); return -1; } munmap(live_shinfo, PAGE_SIZE); - _di.p2m_size = minfo->p2m_size; + minfo->p2m_size = _di.p2m_size; + minfo->p2m_frames = _di.p2m_frames; /* Make space and prepare for getting the PFN types */ minfo->pfn_type = calloc(sizeof(*minfo->pfn_type), minfo->p2m_size); @@ -141,7 +136,7 @@ failed: } if ( minfo->p2m_table ) { - munmap(minfo->p2m_table, P2M_FL_ENTRIES * PAGE_SIZE); + munmap(minfo->p2m_table, minfo->p2m_frames * PAGE_SIZE); minfo->p2m_table = NULL; } -- 2.26.2 From xen-devel-bounces@lists.xenproject.org Fri Jul 02 14:47:14 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Jul 2021 14:47:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149173.275771 (Exim 4.92) (envelope-from ) id 1lzKRb-0001Z7-Ey; Fri, 02 Jul 2021 14:47:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149173.275771; Fri, 02 Jul 2021 14:47:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzKRb-0001Z0-BP; Fri, 02 Jul 2021 14:47:03 +0000 Received: by outflank-mailman (input) for mailman id 149173; Fri, 02 Jul 2021 14:47:01 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzKRZ-0001Yu-HE for xen-devel@lists.xenproject.org; Fri, 02 Jul 2021 14:47:01 +0000 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 9a14a27a-5f20-40ac-8431-b9b52b3e89bd; Fri, 02 Jul 2021 14:46:59 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9a14a27a-5f20-40ac-8431-b9b52b3e89bd DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1625237219; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=0Qi9xaAYZUBrgWX3jmYBGQmATiOhIRK7rRkjsrCzGo4=; b=SvIL6fV09b6n7Ctz1FqheMjLToffbl+bsIgOg/YNh1nhgE9MjhoaxYJZ 51w5Drc8KtzeMTkN3FY/GHyra9fyoF2zJpEQtElA3y2Mq/9Vzzuj8hiuw ZVPZ3pRaWBuEDkJCHDFsVa7oZUmTHEbKWzZVC7u6RpOW84sUQXoAwmG7h M=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: 9rj2FTI6x1eMY5mXLo4ddIeOtwqaK6NYq8KmE2VXdmIBpKYlFef4xb72oSnibNNPysbBJHKgFz +IGyU9lNkYW+6Gtk/+TpkbdcUmQ3JIBxD/YRJEGAXNNwqCjBZocTrq5VtW8OGeX8jwTnCW9Jpq 8caGMW8Gl7wbR6cpFMLlZg0UeHFuFSve28mDXw2R8e9yb3MPdjM6O2BaAc8/KDAZ27QsZ6mwzQ FovJouoaH7XlFCxRT30xyxej2vbC3rrkK2b59z6oI6FOfhIlEQXYeGBGDxFdcUsExZmrzAwBI3 Rhk= X-SBRS: 5.1 X-MesageID: 47536243 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:YSlH9anXw4fUlBhX+wIxnB4EFaLpDfLW3DAbv31ZSRFFG/Fw9/ rCoB3U73/JYVcqKRUdcLW7UpVoLkmyyXcY2+cs1NSZLWzbUQmTXeJfBOLZqlWNJ8SXzIVgPM xbAspD4bPLbGSTjazBkXSF+9RL+qj6zEh/792usEuETmtRGt9dBx8SMHf9LqXvLjM2fqbQEv Cnl6x6jgvlQ1s7ROKhCEIIWuDSzue77q4PMXY9dmcaABDlt0LR1ILH X-IronPort-AV: E=Sophos;i="5.83,317,1616472000"; d="scan'208";a="47536243" Date: Fri, 2 Jul 2021 15:46:56 +0100 From: Anthony PERARD To: Jan Beulich CC: "xen-devel@lists.xenproject.org" , "Ian Jackson" , Wei Liu , Andrew Cooper Subject: Re: [PATCH] libxl/x86: check return value of SHADOW_OP_SET_ALLOCATION domctl Message-ID: References: <5d2bb2cf-8c0c-7300-c895-75bef0e50817@suse.com> <4913d3f6-cd16-1865-9c19-99f7db615ded@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <4913d3f6-cd16-1865-9c19-99f7db615ded@suse.com> On Fri, Jul 02, 2021 at 02:29:31PM +0200, Jan Beulich wrote: > On 01.07.2021 11:36, Anthony PERARD wrote: > > On Mon, Jun 28, 2021 at 01:47:03PM +0200, Jan Beulich wrote: > >> --- a/tools/libs/light/libxl_x86.c > >> +++ b/tools/libs/light/libxl_x86.c > >> @@ -531,8 +531,18 @@ int libxl__arch_domain_create(libxl__gc > >> if (d_config->b_info.type != LIBXL_DOMAIN_TYPE_PV) { > >> unsigned long shadow = DIV_ROUNDUP(d_config->b_info.shadow_memkb, > >> 1024); > >> - xc_shadow_control(ctx->xch, domid, XEN_DOMCTL_SHADOW_OP_SET_ALLOCATION, > >> - NULL, 0, &shadow, 0, NULL); > >> + int rc = xc_shadow_control(ctx->xch, domid, > > > > Could you use 'r' instead of 'rc' ? The later is reserved for libxl > > error codes while the former is for system and libxc calls. > > Of course I can, but I did look at the rest of the function and > found that it uses "ret" for the purpose of what you now say > "rc" ought to be used for. Seeing "ret", I decided to avoid it > (knowing you use different names for different kinds of return > values). While I've switched to "r" for now, I'd be rather > inclined to re-use "ret" instead. (Or actually, as per the > remark further down, I can get away without any local variable > then.) I know there's quite a few (many?) coding style issue in libxl. I'm trying to prevent new issue without asking to fix the existing one. The use of "ret" is an already existing issue, so I'm fine with it been use in this patch for libxl error code in the function. BTW, you still need to store the return value of xc_shadow_control() into a "r" variable before checking it for error. > > >> + XEN_DOMCTL_SHADOW_OP_SET_ALLOCATION, > >> + NULL, 0, &shadow, 0, NULL); > >> + > >> + if (rc) { > > > > xc_shadow_control seems to return "domctl.u.shadow_op.pages" in some > > cases, are all non-zero return value errors? > > Indeed it does, but (a) we pass in zero here and (b) this > operation doesn't alter (nor even care about) the value. So I'd > prefer to stick to what I have, but if you tell me to switch to > "... < 0", I will. That's fine, no need to change. > > >> + LOGED(ERROR, domid, > >> + "Failed to set %s allocation: %d (errno:%d)\n", > > > > LOGED already prints prints the meaning of the "errno" value, so we > > don't need to log it. > > I see. Please note that again I took neighboring code (a few lines > down) for reference. Judging from other call sites (not the one > right below here) I infer I also shouldn't have \n in the format > string? Ah, indeed, the '\n' isn't needed. > >> + libxl_defbool_val(d_config->c_info.hap) ? "HAP" : "shadow", > >> + rc, errno); > > > > Is the return value of xc_shadow_control() actually useful when errno is > > already logged? > > I don't know. Again what I had matches what can be found a few > lines down in the same function. But looking at other uses (in > other files) I'm getting the impression that it's useless - > dropped. Whether or not the return value is useful to be logged depends only on xc_shadow_control(). But thanks. Thanks, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Fri Jul 02 15:11:39 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Jul 2021 15:11:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149178.275782 (Exim 4.92) (envelope-from ) id 1lzKpI-0004rd-Dv; Fri, 02 Jul 2021 15:11:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149178.275782; Fri, 02 Jul 2021 15:11:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzKpI-0004rW-Ay; Fri, 02 Jul 2021 15:11:32 +0000 Received: by outflank-mailman (input) for mailman id 149178; Fri, 02 Jul 2021 15:11:30 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzKpG-0004rA-87 for xen-devel@lists.xenproject.org; Fri, 02 Jul 2021 15:11:30 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id c64f449a-db47-11eb-83b6-12813bfff9fa; Fri, 02 Jul 2021 15:11:28 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c64f449a-db47-11eb-83b6-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1625238689; h=subject:to:cc:references:from:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=JI+dDqQPttl8nzl/yOMoLNzy4H96SN8XpCcjUNK2YwM=; b=RySVpkIf6bfxpGj0Koa4Z/y321q7H6TI8wGRMLVce22Yr75LF7A05wLq vTV4BNz3T77ly+My8gMGC2qDeIDiX029CsZqitwMSN/ZY0RbC6h2Bskr1 eBeAPjkb8nq/qI0OpKt7oKoSCdiIfWKc4iqbduWzMfzTK/QZ5VCaSZrRa A=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: 7/nf6TXk7FrQch/Gw677QhGLfCPjL7mDCrOnJtasPrGpclEp2TAuvuJPe7OHw4OtaiXzM0ObuO 4QXB+M1hc7QZJ+RMtV7VzBWitP1ne2CFHRRFN7RW7hEOsH+CLbH2yxbbmtcVknU8azrkXzL1As upGF02rXXDMey4k2U8nmekaBwEA5eU3H0d6yzuGLBLVex80NAr9gN42itnqPWuQCRadw1yCKBv vowcNkhvgWXb4gB1lWEls6CAHHcydP2MmgjOnm4YWKecW376wtJiIgavg6IKSp9+ADaljkQz8w CHw= X-SBRS: 5.1 X-MesageID: 47465486 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:IlFjX62MGfcf3nVHnik3BQqjBA4kLtp133Aq2lEZdPU1SL3nqy nKppomPHDP+VUssR0b6K290Yi7MBbhHNtOkPIs1NSZLXbbUQmTXfhfBOLZqlWLexEWtNQtrZ uIGJIOauEYeGIK6/oSjjPIb+rJsLO8m5xBq43lvhNQpdwGUc5dBzMSMHftLqUJLjM2dKbQMv enl7l6T0nLQxkqR/X+LXEfRODIu9DC0KnMRFo6HAI89QWCyRyv86DzCBWVxX4lPw+mtt0ZgB z4e32S3NTSjxnIoCWspVP73tB4nt39xsArPq2xY7AuW0/RY32TFeNcsmK5zUUInN0= X-IronPort-AV: E=Sophos;i="5.83,317,1616472000"; d="scan'208";a="47465486" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fhx6vNeM4jkOXXPw7dkciqz6Ot6hen26hr5zASHvgaz+oNV1cUB75FcJviSpYDuLRUK8rp83H6RDDhLKP2KTHWoo1WOBbIvtRWLlbfhWMtNhV2ZJnsK0+Z4haD1Z15gsob3//Af9qiofUhkV4DGKu+SBRQ7Vdtj5b3Pxbx6GjpaVph+ZqaH++BCAh1jMokb18yrbSkN6Pe6U9Ye4iFOioeZZnfL6bi+DybxZo1F11r01zG4oTWDz8syqjV3sNbElA1UIlIVbxBE97cDE4WSS8rxoW2H5kzznfH2+CWcRalRNrb/WVAuhBAq5UqwUtmxNQGKTpXPL5NlsCiPbx3aQ4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wp9CG1bfiQgdmUIW+LcgwupYphZ5zCiU5UJbXg//STM=; b=IimciG5FkO+18HUQe/WG6ssRs5/lO1AEUEXC/bEYU1GkLdDMo2oW0hQ/4GG9vYlyYzHvhwwQoiC5dZlejcQ87YjEdTDGSQ4OqvXkBALeYbizVdsfExLuXL2Y8q68IyGQ5aYu9GH2KsgH8kAfXwucCD7X8PqbXuHosDoy4uiOWX35KSOhaFsRMr8I+EyMaYAHUkfitv2C+0M6dBTiCPsR9D4lKGlouLm6ytt6Y8Puzqk8Gm8m9Zjal5vBWK1DHZFutX7vT0bFZreL28e/bj3WsJ5X5IFMT7HCvyZt5zdaztPg9hxrtTu5n6sOPwOQJIfI0dZSq3YiXkv2CyfPmdxhKA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wp9CG1bfiQgdmUIW+LcgwupYphZ5zCiU5UJbXg//STM=; b=fqs5gS4dK7WaREEA0sXhi29dMGJYaxAAh3VAeekT25x5KAW/h78gicDUhZQzr6C99EEEhkkgA9zCr/mpzwHbLR9KeMFFK6/ivTVsfyT5lCMnJ8nanBvuO6CocoNf2k0VCl2dBgYod89QVGA2Ic0EI5H8lCB1JG36h8dXHY0pJSA= Subject: Re: [PATCH v20210701 04/40] tools: use integer division in convert-legacy-stream To: Olaf Hering , CC: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , Ian Jackson , Wei Liu References: <20210701095635.15648-1-olaf@aepfle.de> <20210701095635.15648-5-olaf@aepfle.de> From: Andrew Cooper Message-ID: <4db50fa9-638f-97e1-1b1c-e044cf4714d7@citrix.com> Date: Fri, 2 Jul 2021 16:10:53 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 In-Reply-To: <20210701095635.15648-5-olaf@aepfle.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-GB X-ClientProxiedBy: LO2P265CA0069.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:60::33) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e4ee487f-3d75-4cc0-a2f8-08d93d6b9a4d X-MS-TrafficTypeDiagnostic: SJ0PR03MB6224: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:196; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3UHYVmzWYpq75pAXO68zFgujrEweUH/lM/Pkpk4Q/4GbmJ8dorcJjzmgQk00ow/pVemdwF46pmhp58nt3k3PxybXPBXKiknmW1XNHy/Hvwk0sMBxUUyDFkI4AJA3sOBvwC4xDRCY8geqBcB+magweORg3fqtnlC7dtFzuR4IYgczGc0ETtr1JKjg7ikkKhwMEl9FwrHZ2Epv6e9FlBWTFNLpL/9Hurs4ejeLrdVTGGAV/jx2rM9bofv3Uq5P4Y5XX3nTFq/dMCvCzA34VrtgW/CAR2jF56FQzQNGDwR0/aXvC2sO7pBApFqlu5aaaZle4JLvpUk5OTklxjNjBSrIFT4WZs5Q4Z8NTXL5BldxUcz6ypiYkK2En6ehT4hab4F2vA6sCrtcu7FvN1PFoYYMTq/NH4eZ0/poexNnWuOfxInf+mAfOHU+oD3hapB05iCZq0Glhc4TqzSPeMTAHY7sKnUE7v6yND3jwBIy6zh2zJGzUsZWpw7M6l1uwuNxQnGNrMKuZ3W9PRs7hsxuM15acfVpe4rc1FYFNYhH05IXKFSTkNwlbLLpvfYJHybmA8haeoacM88p8LzPr8P9Q+Z52PbyTdgfxb51FH+KMSpVAAoFSoXFWhrBJ0aWkid93w6XPQ9/XmjarM2tQ7LI5itveBemn0szxrwCJZx9HXXYaTqa1ciUhGSBcypQ+Rth8sZrMhVHezzMI63QfEtBrrhnQq2N/iDk2w0bNO1A8RBI5Ydt5ihbKfuFF12k8MH8r3FN X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(366004)(136003)(396003)(39860400002)(346002)(16526019)(5660300002)(53546011)(186003)(86362001)(31686004)(2906002)(6486002)(4744005)(31696002)(66476007)(54906003)(478600001)(26005)(16576012)(956004)(2616005)(66946007)(6666004)(36756003)(66556008)(8936002)(38100700002)(316002)(8676002)(4326008)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bUFYYlZhVVFPS1hxdjdWM3BHL2dYTGx6NnJSYXJka3hDbFlNZWZ4WkRUb0lJ?= =?utf-8?B?bEpjR3hTbEJTdjVlQjFWQlEzZEQ5Vm5lQzR0Uk5XdzFTQjg0dUdncmo1M0lU?= =?utf-8?B?NFEzczd0RmxqUlNaQjhseHFKd0RxT1l4SVBaSTAzdEtXdFNFRTV1TkZnQ1Zv?= =?utf-8?B?bHh6MWdQdnRoVy90YkFGbDZFSGpFK3VqTzBBSVBjODVSajAwdms0bnExTDUz?= =?utf-8?B?UGd4emNtY0NteE9zQW9JeGRLZ0dvSU9lS3owWjUyUnpqQnpFSlpUYWxyQ1pG?= =?utf-8?B?cnBiMjVMb2dEeGJXWldidldPQVhlRTFpSTgxVE5GMUVuY3hYdk9zTzlVb21h?= =?utf-8?B?ZWtrR2pYcVc5SnM0cm1mWmhrdXpYK0JLclRMcTNJNmRacVArTGdidXBvczlr?= =?utf-8?B?NVBHRno5Wm9vSmVCT3gyeW5qQjZXcXhGS1M4OHpwK3JmQ0pRSUc0K1dMUkMz?= =?utf-8?B?SEJMd1FHWmFHRWFFQTF4bzFMamxFOEM0c2U0THJWMElXVFdrYUNJK1AyWnhs?= =?utf-8?B?WFdtajNhdXhkR0Z2ZVQ4ZzF5cG44TUVmRDR0MXVwTFhST1J0UXl0TkZpQ2hJ?= =?utf-8?B?VzNvSnZDb2ZZaElyRk9kRURjQjlaem0zaXVGSGlRQjRlelNxc0lXK1dCdXNW?= =?utf-8?B?eG9PenRjTittOGlPd3diSkFwZksrYXBEeVJmOXd5cWR5ZkcwalNUMFhsSGxq?= =?utf-8?B?d3NUaVRzb2NCclF0TmNzaW51dzBBZDNqSmFoK1o0R1MrdCtSOGJTamY2U3F5?= =?utf-8?B?V2RXa2FHNHpHODFGWGVKMlo1dXYrUEV6cnpVcnArTzJOL0tJZTNoZVQ1Znpo?= =?utf-8?B?eTByRFNWNUJOVHI3cTJpK1ZrODBETDZWU2RraWd6T1g4aktxV2xBRlhaU2pz?= =?utf-8?B?LzQ0Vy8yUzhtYWtjYTA4R0VYblBvQTl6TFI5aFF0djI5WGJmOTgwMXM2RmxT?= =?utf-8?B?c2VEaVVsQ3Uvbnl0MUMxRzhvNFM5NkpuYnk5YWlaZlRJWkswc0JITFJJcjVB?= =?utf-8?B?U0d1dWVlNlp4SFV4VDh3MkllWUZGVFRGSG4zMjhJZ244S0p4S3NlUVhqb0pR?= =?utf-8?B?QUhQOHBDR0hBTW10Snc0dnlmd3RPN2tLU0p2OW5ZTFphQjdhNjZVdXkwanVH?= =?utf-8?B?MUlYbERpT1g5dzlVdEV3T3JSV0RhSHVFUi9xSmlIWklGWkJPdDNnb3VaNWJh?= =?utf-8?B?b0syNzZERnBKNFBmZVZwK0JLZDhhT2ViT1BMK0FmM1AzWXloSjJuVit4M3pG?= =?utf-8?B?UWFXTENHRXgrakdXNUZ6WkdPWHcwN3hROWM4MTF6anFwdXQvZjNUOWR3bmtr?= =?utf-8?B?TWppVHNMdUNQblZoL0RXbmVGdDdIb1ZiK2hKaGtDMDU3REMrRmY3Vk5YNnNk?= =?utf-8?B?SDFlVWVoSWY2VTg1MloyUW9vaTVURHg5d28zM25QYmZDQ1FVSmk3Z3krL3VQ?= =?utf-8?B?SWhyajAyMDFMMlRYWkxHc1pQcGxjY0t1WW1hTVpsS1pOTjhpMklxRzlyUE5N?= =?utf-8?B?L2wyeHpnalJYOVhEclVWODE2WlpPOGJ5bnBOeDk5MElLR2htSGU2bEhkeWkx?= =?utf-8?B?VzlMS3NrQ2FCdTFtTHNrU1M5b0txRUVXMVRsckJDaWFDb0JBTExlUStMc0NY?= =?utf-8?B?WjJVTzJKcExGbVM5QXNvS1JTTmZKVWJuMTZONFhmY3FGOUZWNFQ3Z0tSMW9x?= =?utf-8?B?cUtMZGZjNXNyWjh3WnpmN1lSTVBrSFIzZWd0UzkweHdFUlJXWFU3NURXQjVF?= =?utf-8?Q?LaoCvaM/we8G9kCG4utSVujkJI7FIcTSvUt1Wop?= X-MS-Exchange-CrossTenant-Network-Message-Id: e4ee487f-3d75-4cc0-a2f8-08d93d6b9a4d X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jul 2021 15:11:01.5116 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: XZ/DKHpqeGYQAf5Q/sOGFelI3QKBQ9+hGJLsM9QqRk7NyHQ0tN76fdZYQR5EFYeBZIXp/l313O4AD5GD9iG/HvnpwZk2iUh4Pj37kcKTSm4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6224 X-OriginatorOrg: citrix.com On 01/07/2021 10:55, Olaf Hering wrote: > A single slash gives a float, a double slash gives an int. > > bitmap = unpack_exact("Q" * ((max_id/64) + 1)) > TypeError: can't multiply sequence by non-int of type 'float' > > Signed-off-by: Olaf Hering Reviewed-by: Andrew Cooper From xen-devel-bounces@lists.xenproject.org Fri Jul 02 15:12:29 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Jul 2021 15:12:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149181.275792 (Exim 4.92) (envelope-from ) id 1lzKqD-0005RR-PM; Fri, 02 Jul 2021 15:12:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149181.275792; Fri, 02 Jul 2021 15:12:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzKqD-0005RK-M4; Fri, 02 Jul 2021 15:12:29 +0000 Received: by outflank-mailman (input) for mailman id 149181; Fri, 02 Jul 2021 15:12:29 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzKqD-0005RE-48 for xen-devel@lists.xenproject.org; Fri, 02 Jul 2021 15:12:29 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 5d71f225-76bf-482a-b128-9d567b530083; Fri, 02 Jul 2021 15:12:28 +0000 (UTC) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05lp2176.outbound.protection.outlook.com [104.47.17.176]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-23-PKfjgzwWPQGkgLnazFl3Sw-1; Fri, 02 Jul 2021 17:12:26 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR0402MB2704.eurprd04.prod.outlook.com (2603:10a6:800:b5::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4264.23; Fri, 2 Jul 2021 15:12:25 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::99d3:99cd:8adf:3eea]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::99d3:99cd:8adf:3eea%5]) with mapi id 15.20.4287.023; Fri, 2 Jul 2021 15:12:25 +0000 Received: from [10.156.60.236] (37.24.206.209) by PR3P191CA0031.EURP191.PROD.OUTLOOK.COM (2603:10a6:102:55::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.23 via Frontend Transport; Fri, 2 Jul 2021 15:12:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5d71f225-76bf-482a-b128-9d567b530083 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1625238747; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wbvhHxlLO1642pXBaDEfWehMsyn88DfKcSTKtOiE1n0=; b=PKgEP4eYnCZlwujdIQ/HmWozQors7iNk9r5tJ4WDLQyfROe91wwFfUjYqwBP/pz2ITS5Fc 1oLxz3IpKeuXbNLnE/6ijSCli84l54vqSH1vGcrXN0UKgABUfyOkUL+mJR1rAOUlA/aLR7 SzwAY97q7bEh5dO8OVozOp/ixLQUkdA= X-MC-Unique: PKfjgzwWPQGkgLnazFl3Sw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QegQI+5Yx1cT9Qu0lJdAJAZ2/YsRmf9BXjHfHnvllBQ+LszI8kBGhDAfN/tCZ7T2EeDU5w8GVoKwVdsFcfOeQeLE4t3hznM9/ouvKQxZM8Fn0imUt0M5qFxa3hso4xzG+XcX8xMseEIU5Xc8bOuX+PvMZa/obs9AtvLrdCz5alwDRWGaWEL0MmXLKnH3ym3f0mJ+e7FvvMs2LThkvJC4QQkYCWt+t56mxajmsA5f57g/G8ZbOiIaC2DD0kip92jFkHEWo21UIVdF3wkMh7K5rcf5m3XJfvkuyPaJMiPbLCARLJHE6lba6rQQ41X2szOtBulPYhwevHdLN0UW4/Flxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wbvhHxlLO1642pXBaDEfWehMsyn88DfKcSTKtOiE1n0=; b=D9Pryn99mQ679F8yuBBI5Rn70ZJlUYAw+7iO11dPz1w3oM3L7cAQBNazFkHaTe8EP8JaWd7X7P/JR0ON0aJYN287/KOQrsrNXjakMFBPZfMduXLvsd3imoqODhu1Ix3g7323hemNfSbzDrDopbsiQszmCNeHJwuZqKmD9N+7BXMXOwIOk7YmBkkS8ODOGN+MW92APWndYS3hUo1tguuNRLXomsYK+XHlILIUgTnxnY/SKOCJ0q86ha5uB1ueIyogK0dL4GBaePwi4ETQE5vILIsXTYmuSl8DPr9kzKAnli9XZ15dO+kRKnhWWTBRuKGvW1jfSUf/i+fcG0+k7xZiSg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: citrix.com; dkim=none (message not signed) header.d=none;citrix.com; dmarc=none action=none header.from=suse.com; Subject: Re: [PATCH] libxl/x86: check return value of SHADOW_OP_SET_ALLOCATION domctl To: Anthony PERARD Cc: "xen-devel@lists.xenproject.org" , Ian Jackson , Wei Liu , Andrew Cooper References: <5d2bb2cf-8c0c-7300-c895-75bef0e50817@suse.com> <4913d3f6-cd16-1865-9c19-99f7db615ded@suse.com> From: Jan Beulich Message-ID: <89ccd8b7-42e1-0e86-5929-2a33fa1b9c4b@suse.com> Date: Fri, 2 Jul 2021 17:12:23 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [37.24.206.209] X-ClientProxiedBy: PR3P191CA0031.EURP191.PROD.OUTLOOK.COM (2603:10a6:102:55::6) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6bfbefd7-6d54-4f40-54ed-08d93d6bcc84 X-MS-TrafficTypeDiagnostic: VI1PR0402MB2704: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9svFSW+O7ePAVbnfzlUHtlKF+85Z8OxN+n3dODLhgBouEv0xCtvymuq3AmNxVu9QNkC+TM1mU8yk788bcHGI5OKwo2Vzu9zqxCEvGPXP5xlxBrdosFfGhCHYe4HlZCUrGiuXXY/NxT7XntEo5Nrwn5kA957Xl5KqkfjCP+S3TD+eybvv4GXMkVAtQbVG8cektXJq+VwoqGyXVDHuFuRXRNAU7yuzaxjl8K8l2sxsHoGdiFRy80EKvy4whyECfukW/6wB3otpw72HRNiMpRe71mt/zZo194p/GRsHUZL/7plsWeqZEeSuJ4RtxxzQ9XmI3sbIPJAXPcR2i/9LEkMpSmfa/eWBnNGb8J7tdg/cds5rCdRLyfT1vpZvPI23ON5jWvXaH/nGMqmhnvGUFcXNNIgeRj//pYN/sevDo2/tRMCgaobK26RZLqezhzwQ+5lGtV+YlfcrAcdhMIjo6QgOU9MVl2yrCG0YOMkJ65uxM6aIabXoEquwIB0rLIT6XsaiTtjuJMp78dZjlS+oCQ7IPrBQaYJWi+AUpG+TqignFEdh4uHNh/rlWvBINzEHjw6ONOuRuHYdZhB8PH5SgcZRFNxHk8Y9sLjXwsf+6aBCBchij3qV1KhlTbEMILcx1R6cVdiq0rafgCeKWvchDMVy6JGkIJM/8g5fSGHGNXgNpQBuTExBr7NaFVMjxihsPudPf5s3V6sMRbyOc98h8Je6wgZ8nFi46DhrMjhr4mRj4ZnYfNigCffCcAAQP9lQVl16 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(376002)(136003)(346002)(396003)(366004)(39860400002)(478600001)(956004)(31696002)(6486002)(66556008)(83380400001)(26005)(4326008)(2616005)(16576012)(186003)(36756003)(6916009)(8936002)(86362001)(316002)(66946007)(8676002)(54906003)(66476007)(2906002)(38100700002)(53546011)(16526019)(5660300002)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bFc1VGV4VkJvNWsrMW0yOXEzTUZjeVhtNloySGdpMmRiSWRnd1EzM1NRQTJH?= =?utf-8?B?T1FTaVFsV0g5WS9PNWtwalJaNkdsZDJxUjEwbHUrbWI5Q1VJMUZpS0h6SzFI?= =?utf-8?B?N3dPemhpcmx0czVpUjJqRkdGNUJBdm5oZGVuUXU5SXBscjY4LzEyeHJUM3c0?= =?utf-8?B?WkRMS0dMazZiRzU4U1JpcGVJMEoxcndEMUtiWWk3VjNVNWZJczVlRXdRTTRI?= =?utf-8?B?V0ZTOUFucGc4RkRYc3I1V055MDg2TUVwYWM5OURpYmJrSHZQZmpPL0hqYnhr?= =?utf-8?B?SmYweUx1ZEc1RlpLNnpaeHRNZTRpT2pMTG82MzlJWEdPOHRkVjRyb2FWcVlM?= =?utf-8?B?S0pXZ1VHWENiN2xsTm5adUlXVXJ2VHJTYzVwaWFHRm92eGxYd0JWcHkrblJs?= =?utf-8?B?MC9kRzlhYVhaMkVjVno4K1VuMHQ3RWRkN3dSdXhBNmppLy9qWW4yS0U4bURW?= =?utf-8?B?NS96NkJnUDJyTmkrZ0ZPbmlQTGsrV3U5bGdFTVoyNit2b3ljM2swMmgraWZz?= =?utf-8?B?SnNoeWFNOVg0N3JTTkRvUTRzWDZYUTR4RnpwT2xxTjlYNklMa3hYdWtwbkVW?= =?utf-8?B?U3hUMHZSSiswNldSRE4wWFhSdEJPVHkySTk5MmIxelprajdCamg0RjNlOHk2?= =?utf-8?B?WDNTTXk1bnhxS1VMVDdUZ2NUaU5BL0pBdVQ4NTVSWEUzcjV2dThYR2FWTTNI?= =?utf-8?B?L2dvWSs2M20xci80ZlZISWcwL0R0VVNFUUl6cmJBWFY1TDZWc094U0txR3RD?= =?utf-8?B?YndRc3h1RmxaVXdOVGFCQndMa0NONU8zVlJUWTN6Y3lOK3lhMldkTmE5WHVH?= =?utf-8?B?T0lEQzU3VUhxV3Z2OWlVVHU2VGVPU1dyVEhIMy9EcHkwNi9lcTlMSnFCdDUv?= =?utf-8?B?NXQ0Rkc3YXk3MUs0bW5hOERtVmxjN0dMZ1U5TzNRYzJjVGM1b3Jnc29IN1Bs?= =?utf-8?B?ODNxQVVFK0pNNFFBOXFScW1tZ0lpaCtFT3dsT09wczdoVTFRelFXK1dkbHpC?= =?utf-8?B?UkliNE02TXNBVkFnK0RhSzRhdkt5cHpnOU5zL010OHg1Z1oyZWdqZzV6bUpm?= =?utf-8?B?VDlLdG1WWEk0UjNleFlURlk1azJBUWZVZkVJUDBBVUEvZHRHTk1yTEc2UTFF?= =?utf-8?B?ZENhVGw2blQ1bVdSelV4LzhQMWNhdVVNeFZ2M3d1NWc5ZTE3QXcySVZxRFox?= =?utf-8?B?b2xTdkthblNQYjZobFdDeEZ0Wi82OFI2VWV3NHV0NVZSVDU4RHBJVjdZTDBt?= =?utf-8?B?S3hqMVdsa1pTeStBTjMrUjJkMnBZODJJenNuTllxcnE1Q3BXc25EVlZocU5M?= =?utf-8?B?SjExSjBKamxxNDVwd0RGSXczSmNhNzRKWnZDQ3lHTWZRdE94NENGb1hVNzBm?= =?utf-8?B?MFhXdW1PT21VdWVUczdlT00zVFAySyttNytMSXdndWFDenllMFB6NkFFTDlU?= =?utf-8?B?YnNZMlIwcWE1SUVZWmZJbkdIV3F1cDZ4SFFvVG1qSE4rQjBudzRVSVBDWDN0?= =?utf-8?B?N0hXb3AwUEJDdVhDaEtQRUpDckE1TGg5RTh4QlBUWWtNTm5DOC9XVFdlTGNM?= =?utf-8?B?dlFqblZndWc2eGdlZ2QxaFduY2lMNXhaaDFBUzAxMFhLU3dmdUx2T2ZEYjNo?= =?utf-8?B?VElmYVlFbjRmY21nbFNTRWRmZkg4TlRJaDlmcndsckxmaDFNd042REpPMWVI?= =?utf-8?B?RjcwSU40dHNOVHI0MnVqZzZTTU1KdHNBSlZ2QjV0aU5PMVRia0k5TVNETW9S?= =?utf-8?Q?vEk7corV+XXqUdAkiVBRqHnA4+tn390DKG5irVV?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6bfbefd7-6d54-4f40-54ed-08d93d6bcc84 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jul 2021 15:12:25.2434 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: r2OvLFuJCcrhp5WlaJhvBXd+Iq7sidep7Uowq47mDlKzyrj5vn5HQxV9myuqtCfAPhurULwjEje6iHSpkKeo+w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB2704 On 02.07.2021 16:46, Anthony PERARD wrote: > On Fri, Jul 02, 2021 at 02:29:31PM +0200, Jan Beulich wrote: >> On 01.07.2021 11:36, Anthony PERARD wrote: >>> On Mon, Jun 28, 2021 at 01:47:03PM +0200, Jan Beulich wrote: >>>> --- a/tools/libs/light/libxl_x86.c >>>> +++ b/tools/libs/light/libxl_x86.c >>>> @@ -531,8 +531,18 @@ int libxl__arch_domain_create(libxl__gc >>>> if (d_config->b_info.type != LIBXL_DOMAIN_TYPE_PV) { >>>> unsigned long shadow = DIV_ROUNDUP(d_config->b_info.shadow_memkb, >>>> 1024); >>>> - xc_shadow_control(ctx->xch, domid, XEN_DOMCTL_SHADOW_OP_SET_ALLOCATION, >>>> - NULL, 0, &shadow, 0, NULL); >>>> + int rc = xc_shadow_control(ctx->xch, domid, >>> >>> Could you use 'r' instead of 'rc' ? The later is reserved for libxl >>> error codes while the former is for system and libxc calls. >> >> Of course I can, but I did look at the rest of the function and >> found that it uses "ret" for the purpose of what you now say >> "rc" ought to be used for. Seeing "ret", I decided to avoid it >> (knowing you use different names for different kinds of return >> values). While I've switched to "r" for now, I'd be rather >> inclined to re-use "ret" instead. (Or actually, as per the >> remark further down, I can get away without any local variable >> then.) > > I know there's quite a few (many?) coding style issue in libxl. I'm > trying to prevent new issue without asking to fix the existing one. > The use of "ret" is an already existing issue, so I'm fine with it been > use in this patch for libxl error code in the function. > > BTW, you still need to store the return value of xc_shadow_control() > into a "r" variable before checking it for error. Are you saying that if (xc_shadow_control(ctx->xch, domid, XEN_DOMCTL_SHADOW_OP_SET_ALLOCATION, NULL, 0, &shadow_mb, 0, NULL)) { is not acceptable, style-wise? If indeed you are, please disambiguate your statement above regarding the use of "ret": May I or may I not use it? IOW do I need to introduce "r", or can I get away with the existing local variables. Jan From xen-devel-bounces@lists.xenproject.org Fri Jul 02 15:14:07 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Jul 2021 15:14:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149185.275804 (Exim 4.92) (envelope-from ) id 1lzKrm-00064w-5R; Fri, 02 Jul 2021 15:14:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149185.275804; Fri, 02 Jul 2021 15:14:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzKrm-00064p-1Q; Fri, 02 Jul 2021 15:14:06 +0000 Received: by outflank-mailman (input) for mailman id 149185; Fri, 02 Jul 2021 15:14:04 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzKrk-00064e-IR for xen-devel@lists.xenproject.org; Fri, 02 Jul 2021 15:14:04 +0000 Received: from foss.arm.com (unknown [217.140.110.172]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTP id 22640be4-db48-11eb-83b6-12813bfff9fa; Fri, 02 Jul 2021 15:14:02 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 26FB4D6E; Fri, 2 Jul 2021 08:14:02 -0700 (PDT) Received: from [10.57.40.45] (unknown [10.57.40.45]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A13EA3F5A1; Fri, 2 Jul 2021 08:13:54 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 22640be4-db48-11eb-83b6-12813bfff9fa Subject: Re: [PATCH v15 06/12] swiotlb: Use is_swiotlb_force_bounce for swiotlb data bouncing To: Will Deacon , Nathan Chancellor Cc: Claire Chang , Rob Herring , mpe@ellerman.id.au, Joerg Roedel , Frank Rowand , Konrad Rzeszutek Wilk , boris.ostrovsky@oracle.com, jgross@suse.com, Christoph Hellwig , Marek Szyprowski , benh@kernel.crashing.org, paulus@samba.org, "list@263.net:IOMMU DRIVERS" , Stefano Stabellini , grant.likely@arm.com, xypron.glpk@gmx.de, Thierry Reding , mingo@kernel.org, bauerman@linux.ibm.com, peterz@infradead.org, Greg KH , Saravana Kannan , "Rafael J . Wysocki" , heikki.krogerus@linux.intel.com, Andy Shevchenko , Randy Dunlap , Dan Williams , Bartosz Golaszewski , linux-devicetree , lkml , linuxppc-dev@lists.ozlabs.org, xen-devel@lists.xenproject.org, Nicolas Boichat , Jim Quinlan , Tomasz Figa , bskeggs@redhat.com, Bjorn Helgaas , chris@chris-wilson.co.uk, Daniel Vetter , airlied@linux.ie, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, jani.nikula@linux.intel.com, Jianxiong Gao , joonas.lahtinen@linux.intel.com, linux-pci@vger.kernel.org, maarten.lankhorst@linux.intel.com, matthew.auld@intel.com, rodrigo.vivi@intel.com, thomas.hellstrom@linux.intel.com, Tom Lendacky , Qian Cai References: <20210624155526.2775863-1-tientzu@chromium.org> <20210624155526.2775863-7-tientzu@chromium.org> <20210630114348.GA8383@willie-the-truck> <20210701074045.GA9436@willie-the-truck> <20210702135856.GB11132@willie-the-truck> From: Robin Murphy Message-ID: <0f7bd903-e309-94a0-21d7-f0e8e9546018@arm.com> Date: Fri, 2 Jul 2021 16:13:50 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210702135856.GB11132@willie-the-truck> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit On 2021-07-02 14:58, Will Deacon wrote: > Hi Nathan, > > On Thu, Jul 01, 2021 at 12:52:20AM -0700, Nathan Chancellor wrote: >> On 7/1/2021 12:40 AM, Will Deacon wrote: >>> On Wed, Jun 30, 2021 at 08:56:51AM -0700, Nathan Chancellor wrote: >>>> On Wed, Jun 30, 2021 at 12:43:48PM +0100, Will Deacon wrote: >>>>> On Wed, Jun 30, 2021 at 05:17:27PM +0800, Claire Chang wrote: >>>>>> `BUG: unable to handle page fault for address: 00000000003a8290` and >>>>>> the fact it crashed at `_raw_spin_lock_irqsave` look like the memory >>>>>> (maybe dev->dma_io_tlb_mem) was corrupted? >>>>>> The dev->dma_io_tlb_mem should be set here >>>>>> (https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/pci/probe.c#n2528) >>>>>> through device_initialize. >>>>> >>>>> I'm less sure about this. 'dma_io_tlb_mem' should be pointing at >>>>> 'io_tlb_default_mem', which is a page-aligned allocation from memblock. >>>>> The spinlock is at offset 0x24 in that structure, and looking at the >>>>> register dump from the crash: >>>>> >>>>> Jun 29 18:28:42 hp-4300G kernel: RSP: 0018:ffffadb4013db9e8 EFLAGS: 00010006 >>>>> Jun 29 18:28:42 hp-4300G kernel: RAX: 00000000003a8290 RBX: 0000000000000000 RCX: ffff8900572ad580 >>>>> Jun 29 18:28:42 hp-4300G kernel: RDX: ffff89005653f024 RSI: 00000000000c0000 RDI: 0000000000001d17 >>>>> Jun 29 18:28:42 hp-4300G kernel: RBP: 000000000a20d000 R08: 00000000000c0000 R09: 0000000000000000 >>>>> Jun 29 18:28:42 hp-4300G kernel: R10: 000000000a20d000 R11: ffff89005653f000 R12: 0000000000000212 >>>>> Jun 29 18:28:42 hp-4300G kernel: R13: 0000000000001000 R14: 0000000000000002 R15: 0000000000200000 >>>>> Jun 29 18:28:42 hp-4300G kernel: FS: 00007f1f8898ea40(0000) GS:ffff890057280000(0000) knlGS:0000000000000000 >>>>> Jun 29 18:28:42 hp-4300G kernel: CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 >>>>> Jun 29 18:28:42 hp-4300G kernel: CR2: 00000000003a8290 CR3: 00000001020d0000 CR4: 0000000000350ee0 >>>>> Jun 29 18:28:42 hp-4300G kernel: Call Trace: >>>>> Jun 29 18:28:42 hp-4300G kernel: _raw_spin_lock_irqsave+0x39/0x50 >>>>> Jun 29 18:28:42 hp-4300G kernel: swiotlb_tbl_map_single+0x12b/0x4c0 >>>>> >>>>> Then that correlates with R11 holding the 'dma_io_tlb_mem' pointer and >>>>> RDX pointing at the spinlock. Yet RAX is holding junk :/ >>>>> >>>>> I agree that enabling KASAN would be a good idea, but I also think we >>>>> probably need to get some more information out of swiotlb_tbl_map_single() >>>>> to see see what exactly is going wrong in there. >>>> >>>> I can certainly enable KASAN and if there is any debug print I can add >>>> or dump anything, let me know! >>> >>> I bit the bullet and took v5.13 with swiotlb/for-linus-5.14 merged in, built >>> x86 defconfig and ran it on my laptop. However, it seems to work fine! >>> >>> Please can you share your .config? >> >> Sure thing, it is attached. It is just Arch Linux's config run through >> olddefconfig. The original is below in case you need to diff it. >> >> https://raw.githubusercontent.com/archlinux/svntogit-packages/9045405dc835527164f3034b3ceb9a67c7a53cd4/trunk/config >> >> If there is anything more that I can provide, please let me know. > > I eventually got this booting (for some reason it was causing LD to SEGV > trying to link it for a while...) and sadly it works fine on my laptop. Hmm. > > Did you manage to try again with KASAN? > > It might also be worth taking the IOMMU out of the equation, since that > interfaces differently with SWIOTLB and I couldn't figure out the code path > from the log you provided. What happens if you boot with "amd_iommu=off > swiotlb=force"? Oh, now there's a thing... the chat from the IOMMU API in the boot log implies that the IOMMU *should* be in the picture - we see that default domains are IOMMU_DOMAIN_DMA default and the GPU 0000:0c:00.0 was added to a group. That means dev->dma_ops should be set and DMA API calls should be going through iommu-dma, yet the callstack in the crash says we've gone straight from dma_map_page_attrs() to swiotlb_map(), implying the inline dma_direct_map_page() path. If dev->dma_ops didn't look right in the first place, it's perhaps less surprising that dev->dma_io_tlb_mem might be wild as well. It doesn't seem plausible that we should have a race between initialising the device and probing its driver, so maybe the whole dev pointer is getting trampled earlier in the callchain (or is fundamentally wrong to begin with, but from a quick skim of the amdgpu code it did look like adev->dev and adev->pdev are appropriately set early on by amdgpu_pci_probe()). > (although word of warning here: i915 dies horribly on my laptop if I pass > swiotlb=force, even with the distro 5.10 kernel) FWIW I'd imagine you probably need to massively increase the SWIOTLB buffer size to have hope of that working. Robin. From xen-devel-bounces@lists.xenproject.org Fri Jul 02 15:14:46 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Jul 2021 15:14:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149188.275815 (Exim 4.92) (envelope-from ) id 1lzKsQ-0006iq-Ib; Fri, 02 Jul 2021 15:14:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149188.275815; Fri, 02 Jul 2021 15:14:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzKsQ-0006ij-FM; Fri, 02 Jul 2021 15:14:46 +0000 Received: by outflank-mailman (input) for mailman id 149188; Fri, 02 Jul 2021 15:14:45 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzKsP-0006iX-D2 for xen-devel@lists.xenproject.org; Fri, 02 Jul 2021 15:14:45 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 3aec3538-db48-11eb-83b6-12813bfff9fa; Fri, 02 Jul 2021 15:14:44 +0000 (UTC) Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-am5eur03lp2058.outbound.protection.outlook.com [104.47.8.58]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-5-nrIufyHbMh2YzeEsGJwyaw-1; Fri, 02 Jul 2021 17:14:42 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB7040.eurprd04.prod.outlook.com (2603:10a6:800:121::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.26; Fri, 2 Jul 2021 15:14:41 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::99d3:99cd:8adf:3eea]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::99d3:99cd:8adf:3eea%5]) with mapi id 15.20.4287.023; Fri, 2 Jul 2021 15:14:41 +0000 Received: from [10.156.60.236] (37.24.206.209) by FR2P281CA0021.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:14::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4308.7 via Frontend Transport; Fri, 2 Jul 2021 15:14:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3aec3538-db48-11eb-83b6-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1625238883; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hC94+a97j6kslkLN67tYNOJce5dy4+/q6ruAJmaPGJE=; b=BebwIASDqahviqLcMIIDG1PSe2kcbMSPk0NbzlVRSud/B8WiQu8rnhUpJTrG/lqXvrVHT/ edAHOimGP+QsFT+e7nUaUTfYH67G4V/+RSjdLXxj/yF2M2eyP+XlZXGINeEVliZvq3ucNq XUxwMGucVMomaGAc+UHuFGd8hgIJIno= X-MC-Unique: nrIufyHbMh2YzeEsGJwyaw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=a8QTSxu/aRY6ivBtt2kvuaxGpn7UYZx8BwtrJpUSeCT0JCU9JoEli8F6gboIrlfP+AM9sADEhRTTSWql9bU9xcTwWC0rSdsn2UTgmzR39F4IAFqnZWEEcJZLFT5J86HJwnQ7iAY7/qXUi50NFrMPHxjqCpB/4Emd6fprTbFIsXSAoZ2gWn66pS3PHOyCU10S4XRKXGpj0T2eRGbTzFfqz64oF+/hKXF7yEU7G2pI0yxwb7CcRnr0E43ZVvDx7tmmbvuJ5cGHnpkfzu8lZWk+qiYzMGAkZlyyji0F3dyus38TzN1PJ4WqhjzviAy+s4gsGDnw328CQfdm1llZ2jtF0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hC94+a97j6kslkLN67tYNOJce5dy4+/q6ruAJmaPGJE=; b=EiiCxLKvOiPViHbuCAVonkDNUu5gXIP/bu9v/tA0nSdD+adpKO3Gnkj0E6713kI0MlO9gzy+mxMkna7MZYjb9dMAZtRqPhEURMn+vXwq+TBLz1pviHGj7CpR3hlW31fFqrU0p8VZVFNQDjPoWrDoecV4A1jh2G/cTtJOkZ/xStFYONhYmQ6W98oxsUyw1avX+LooSemVM7PxoD2GV6ot8hLqGhLvfQp3B25iZORiAX/CmTl+0b1jUDzyRjFVKcZ6G2cVN24HoVHfHwC0J9T6U7gvXDhfPG28aAnwkwH4oUOBmmHOjnLa8/uIMtT9xuRkzjogKpV+G+uNXfnH9v6g1A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: citrix.com; dkim=none (message not signed) header.d=none;citrix.com; dmarc=none action=none header.from=suse.com; Subject: Re: [PATCH] libxl/x86: check return value of SHADOW_OP_SET_ALLOCATION domctl From: Jan Beulich To: Anthony PERARD Cc: "xen-devel@lists.xenproject.org" , Ian Jackson , Wei Liu , Andrew Cooper References: <5d2bb2cf-8c0c-7300-c895-75bef0e50817@suse.com> <4913d3f6-cd16-1865-9c19-99f7db615ded@suse.com> <89ccd8b7-42e1-0e86-5929-2a33fa1b9c4b@suse.com> Message-ID: <61f96b68-cd29-84c2-33ca-e114a6fc7714@suse.com> Date: Fri, 2 Jul 2021 17:14:40 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 In-Reply-To: <89ccd8b7-42e1-0e86-5929-2a33fa1b9c4b@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [37.24.206.209] X-ClientProxiedBy: FR2P281CA0021.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:14::8) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3efd04ac-4729-4db5-35ab-08d93d6c1df4 X-MS-TrafficTypeDiagnostic: VI1PR04MB7040: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HzT5jq46pR/Yt11R6iQAR9p1zs/+7HZJDIxroBSwJxBzu6ltfHEgWiVKh8ISqTzB7Fl4CGiNQpBc4Ee4nUSQPvdwj3Eaf6/Km/K4DRMNOd/C9zaZgPWA11ZK/ZbIFG7FArDIcxhz8ZfF2I/36sYfLHp5CUmW4CwzVIc3+Aru+G19m8f6FRkkppRhozF8mvRtT/NdUwYvLtLaA/K+EGbgGuvIMAuZHrf1jFlIQgi+EMoEDPD2eA/a2Jdy9H9qspaNAkx8Q0VG/GE+JD3lXI9hYLncBy3vNcC3m9QJ+AZAkYNZ1gS8jD56tmVqp4vicIBX4Rjp4YOabPdgYlq91MKYzQB2G9cHD611qKMXOII+PZ6+vLTz97KJ4BqNSTxuYitDQLj3o0I+Z18afu0Zgb6JBKSHC1OacSeAjOksl3DLcEaVayXKuw6Wp5wW8HJwu2GNh2ZENBpECBoe0tPJkySh7/koonpBd3AKpBbH2GgFu6XwQGpyHd5XP2xKsPEf843doLhCGUHy88fG9HGr9mh6qiANbhv+VW7pjowIA6gtX0LC00jkS/TIFZjshfP2lJHKWzpMsAQ+nWt2I6GtvtrM7P+Ik6kKzz91NpSQEsbx0S1Ovct4s3yGsmOkYkaMigmUdCM67t65CG/RER25bY4zRtk7ZRrrMu5PMr0LsHM3wCi7cdMezo1CePRg7ecJDZJWbzvKQP0voTD/+WACk3SjpGv7dptfXwO1EdrbwGsWpdmpF6cCbEDYijZBiSYrU3Kc X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(376002)(136003)(366004)(346002)(396003)(39860400002)(16526019)(86362001)(6486002)(8936002)(54906003)(36756003)(5660300002)(186003)(53546011)(316002)(83380400001)(26005)(2906002)(66476007)(66946007)(38100700002)(66556008)(31686004)(8676002)(478600001)(16576012)(31696002)(6916009)(956004)(4326008)(2616005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dEVuZ2NDWmtROFZ3Q3hiSVhtbHVtY0x4ZEVsd294d1Rld2dNMC9Tem1TNGo2?= =?utf-8?B?SjNmL1F2QWVRVVVvK1czOEFMem9CRTc2ZUZ5R3ZDdU5CLzhJRkpzYVpIdjNH?= =?utf-8?B?L2RWZ2tXcmRiUG5IZ0doTnZtVjNMSEVyTGlwZXRyZDBYREN5Q2tuNW05SjdL?= =?utf-8?B?R0N0anFyQklick5MQ0NrRVh4dWJ3SWR2RkM2aWsxaGlPUlpkYUFPaGhqSlVP?= =?utf-8?B?WVUyY21mVlF0NzNCSGxjamVnd0dyZFk4dm41Rzl0Tk9HYW9nUUNFWHdLT2VD?= =?utf-8?B?bkxTMUJpeEJ3MkZXL09nbzBxcyt2Ti9BaHpWSkMrc3l6YlFYalA4Z2cxcE1W?= =?utf-8?B?OHMxSk5UY0J2VmRCaEIvNnpFZHlXODF3YVlucDZpVWpLSmxpSUpaNG1EaHNw?= =?utf-8?B?anRJUGlHcCtVa2UrVUprQ1NuUVJhaFNkV0FEbmw5WkthRUdYRmZXMzNDZld3?= =?utf-8?B?S2lqaVVjQ0cyTjJxUGVMYkFZc1laNFo5QmthbFJFeDhrc0NwOGVwRHNNRmI4?= =?utf-8?B?RElyZDVMa1JhSlltQlB2T05JV0ttSmRjOUcyQkZUL01YU0kyaWdtQkNKOHc3?= =?utf-8?B?bUtpeFZZaDVIenZEblAxRDhJQlptd1V0YU9LTkg1dE9QTHZQSUJ1MVgrb2x3?= =?utf-8?B?NU5aV0pBM0FHdlF6TStpaHBEWExVV1hXa0VDdGkxRnFCZ0FLb0Z3ejZOLytq?= =?utf-8?B?ZjdWZTFiYzhxY0dRVGo1VUVuR2xOQjJsbW9zbDEyUUNSZ29LT2FZL1FBTzlE?= =?utf-8?B?dzVkTy96K1diMmZFRVhieDVzaDhqTTBZZWxoSW9SMDhnVnY1UkkreGN1cHRq?= =?utf-8?B?T3NUYUpMcmZpb0tSZDFKd0h3UlRoSlo1eGdYd0FVaUpIOUMySDBYRm9UTVZB?= =?utf-8?B?WTFDRllPV2Z0NW1HVHZBNXlRUjhXUUJ3MmV3U3Avb3QwcmVNVWlmMmhrSTQz?= =?utf-8?B?YTZ5cnkvZW83Z2lNMmNKVXRzb0w5U0pFZnQxbnZqd1A1bjE0eGlhdUZ3VTRU?= =?utf-8?B?U2xUTGpIYjVvcGxnd2JYOHp3Z3VHYUVHV3h6bVRZY2l1K0czNW0vZUw2a0xY?= =?utf-8?B?Ukx5WmowbGZjeXFiNktwMU5La1hmeWZXb0tMMFpORU5JRkVKRkt2SWlaVUxJ?= =?utf-8?B?UVhEYVJLTlkyVWY4SlhsSzNCSFMrL3drNHlCb3dCZmx2RUpuWWJYMVBVY0Er?= =?utf-8?B?aXVBOHNSU0w1VWF2alZrRDlmRlV1Q0pGQnZ0bFZUbjQxOXlyNXFSdVRVRDFx?= =?utf-8?B?K3JsREoxTkRhZjBtMEpRYlhpZk1MaXN3Wmdsb1pSMFZMOHZHeTBma1pieTBz?= =?utf-8?B?WHcyWlBHR2FmSXhTR0xSMDQyckpha2YvanRMSHU4djU2N09qR0tVZnNmMjBG?= =?utf-8?B?bVczQmdacGFzcVh5RE9sNHZEMHBDNjZUQnhVNjYwR0R5VlZtMi9mOGFsTHJ0?= =?utf-8?B?ajVsVW1jYkI0czFTNWszckpvUDYzcC9WK1hRdE0zMTNUT1R1UXJOZC9lYkFE?= =?utf-8?B?UWJWbFl0MEsrM3dpMWtiaXB5b3dadTR0Z1Bna01tdGFNUGlLc3Y1ZG1jVHZV?= =?utf-8?B?R0gwS01SNk5JaHFKTlFCeFlNajN5QVp2Y05oWEpxVzJoU0tGNHRXbnU1aGNF?= =?utf-8?B?YjJBVDZoZVVXUi9ycHBEeVk5ZEVWYWxFN2hNM01ZVlE3WE1WS05IaEtJMU02?= =?utf-8?B?dUJNQ3lOalVtRzhDcEJlcWtHY1hCdVp3STVqOUIyZ05xY1BmR1ZLWllkOC8x?= =?utf-8?Q?0yITrBQ26sHhqyH/k00XOHsOm9BNWvrF9N4pfbV?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3efd04ac-4729-4db5-35ab-08d93d6c1df4 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jul 2021 15:14:41.8591 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: F0W+yx/I2k52wG8mkb1oTpD3crdx+gNkEC4aD3HsvXmVAIHIykMK+YS9FSpTalg2anvuXf39Amv4cwnDkFuKpQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7040 On 02.07.2021 17:12, Jan Beulich wrote: > On 02.07.2021 16:46, Anthony PERARD wrote: >> On Fri, Jul 02, 2021 at 02:29:31PM +0200, Jan Beulich wrote: >>> On 01.07.2021 11:36, Anthony PERARD wrote: >>>> On Mon, Jun 28, 2021 at 01:47:03PM +0200, Jan Beulich wrote: >>>>> --- a/tools/libs/light/libxl_x86.c >>>>> +++ b/tools/libs/light/libxl_x86.c >>>>> @@ -531,8 +531,18 @@ int libxl__arch_domain_create(libxl__gc >>>>> if (d_config->b_info.type != LIBXL_DOMAIN_TYPE_PV) { >>>>> unsigned long shadow = DIV_ROUNDUP(d_config->b_info.shadow_memkb, >>>>> 1024); >>>>> - xc_shadow_control(ctx->xch, domid, XEN_DOMCTL_SHADOW_OP_SET_ALLOCATION, >>>>> - NULL, 0, &shadow, 0, NULL); >>>>> + int rc = xc_shadow_control(ctx->xch, domid, >>>> >>>> Could you use 'r' instead of 'rc' ? The later is reserved for libxl >>>> error codes while the former is for system and libxc calls. >>> >>> Of course I can, but I did look at the rest of the function and >>> found that it uses "ret" for the purpose of what you now say >>> "rc" ought to be used for. Seeing "ret", I decided to avoid it >>> (knowing you use different names for different kinds of return >>> values). While I've switched to "r" for now, I'd be rather >>> inclined to re-use "ret" instead. (Or actually, as per the >>> remark further down, I can get away without any local variable >>> then.) >> >> I know there's quite a few (many?) coding style issue in libxl. I'm >> trying to prevent new issue without asking to fix the existing one. >> The use of "ret" is an already existing issue, so I'm fine with it been >> use in this patch for libxl error code in the function. >> >> BTW, you still need to store the return value of xc_shadow_control() >> into a "r" variable before checking it for error. > > Are you saying that > > if (xc_shadow_control(ctx->xch, domid, > XEN_DOMCTL_SHADOW_OP_SET_ALLOCATION, > NULL, 0, &shadow_mb, 0, NULL)) { > > is not acceptable, style-wise? Oh, there is indeed such a rule under "ERROR HANDLING". Which means ... > If indeed you are, please disambiguate > your statement above regarding the use of "ret": May I or may I not > use it? IOW do I need to introduce "r", or can I get away with the > existing local variables. ... I need this to be clarified. Jan From xen-devel-bounces@lists.xenproject.org Fri Jul 02 15:33:13 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Jul 2021 15:33:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149197.275825 (Exim 4.92) (envelope-from ) id 1lzLA2-0000aT-4T; Fri, 02 Jul 2021 15:32:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149197.275825; Fri, 02 Jul 2021 15:32:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzLA2-0000aM-1O; Fri, 02 Jul 2021 15:32:58 +0000 Received: by outflank-mailman (input) for mailman id 149197; Fri, 02 Jul 2021 15:32:55 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzL9z-0000aC-T8; Fri, 02 Jul 2021 15:32:55 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzL9z-0003Zd-OD; Fri, 02 Jul 2021 15:32:55 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzL9z-00055J-88; Fri, 02 Jul 2021 15:32:55 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lzL9z-0003dp-7f; Fri, 02 Jul 2021 15:32:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=3brfxfD38pg/aiw/Xf9DGQdUqKyB26eO1It5iUHHGX4=; b=d+6wTVUwcN2hNsBy0+TREMOKRK 6+wNMH1V5xe/9YzbrHa+i7aefn99XTLc1/QKfzT3mrJDxYli7aPCDGd01aNHYMxpEFtbnvDMsfcIt 5JWNPktz3atm5kON8JbMta+MrS586o57JJEMX+9s4UrFK8oZ9wUSdxgPeEJFatOYBZKU=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 163224: regressions - FAIL X-Osstest-Failures: ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:debian-hvm-install:fail:regression ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:debian-hvm-install:fail:regression X-Osstest-Versions-This: ovmf=fea7901dba72eeac526f3ef12a4ad4c539622373 X-Osstest-Versions-That: ovmf=c410ad4da4b7785170d3d42a3ba190c2caac6feb From: osstest service owner Date: Fri, 02 Jul 2021 15:32:55 +0000 flight 163224 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/163224/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 162359 test-amd64-amd64-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 162359 version targeted for testing: ovmf fea7901dba72eeac526f3ef12a4ad4c539622373 baseline version: ovmf c410ad4da4b7785170d3d42a3ba190c2caac6feb Last test of basis 162359 2021-06-04 03:40:08 Z 28 days Failing since 162368 2021-06-04 15:42:59 Z 27 days 74 attempts Testing same since 163216 2021-07-01 22:42:29 Z 0 days 4 attempts ------------------------------------------------------------ People who touched revisions under test: Abner Chang Agrawal, Sachin Alexandru Elisei Anthony PERARD Ard Biesheuvel Daniel Schaefer Daoxiang Li Dov Murik DunTan gaoliming Guo Dong Hao A Wu Jian J Wang Kaaira Gupta Ken Lautner Kenneth Lautner Kun Qin Laszlo Ersek Leif Lindholm Liming Gao Loo Tung Lun Loo, Tung Lun Manickavasakam Karpagavinayagam Maurice Ma Ni, Ray Patrick Rudolph Pierre Gondois Ray Ni Rebecca Cran Rebecca Cran Sachin Agrawal Sami Mujawar Scottie Kuo Sean Brogan Sean Brogan Sumana Venur Sunil V L xueshengfeng Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-i386-xl-qemuu-ovmf-amd64 fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 3224 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Jul 02 15:35:38 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Jul 2021 15:35:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149202.275840 (Exim 4.92) (envelope-from ) id 1lzLCb-0001Cb-JC; Fri, 02 Jul 2021 15:35:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149202.275840; Fri, 02 Jul 2021 15:35:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzLCb-0001CU-Fu; Fri, 02 Jul 2021 15:35:37 +0000 Received: by outflank-mailman (input) for mailman id 149202; Fri, 02 Jul 2021 15:35:36 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzLCa-0001CM-5b for xen-devel@lists.xenproject.org; Fri, 02 Jul 2021 15:35:36 +0000 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id d895ea47-b7af-43a3-9b5e-ec75117c23c0; Fri, 02 Jul 2021 15:35:34 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d895ea47-b7af-43a3-9b5e-ec75117c23c0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1625240134; h=subject:to:cc:references:from:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=Xdt+eIuEGaCpuykJfuYIIg+7Kj59yE98PXgv392ZAJ4=; b=MMM+nvbCw1QUlqwLL7AZVSO47YoTB7aWGrFo1QWuBXnx9Wy007CBa08f Zk+nk+Iutq7Fp4DrIfr2+ZPQY2HFRhzUDIZ43HRWNFI9FODwnla1V/f2S m99Zev3R4vhbD8qUFwqgdRFjEP/VuHTbeDxyMkYjowY5tEEEfh9oUE6CR Q=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: 1/29cVpA2oXfCqfhtd/WEHdvrfxhXutm1y+HlRoIXACK/EO2+3KcUcNdpPAms/wzbk2ug9d/J/ n4yFqdpU3WPS/Oxyd9fi0yjPntSwQP5tSifzZfMyBX5qgg5GAdSt9GutOJ1U/9MLZWbHP6+Wfi Gq4i8cLgqHr8fHZht86ON5hmVzZreB+zUUBdqGv9uv6DTtRUPK/eMvtSMJY8r8LNGQS/L2BLfY WP7wQZMNAElKazjjBmTPqZyexYpCOwFO/abyAl0OA62YsCRD5J3b+E0n0NXm32y/ZQBdeR0ER/ vtY= X-SBRS: 5.1 X-MesageID: 47540000 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:Z4Ksh6Ajwsk9XYDlHemF55DYdb4zR+YMi2TDgXoBMSC9Ffbo8/ xG/c5rsCMd6l4qMk3I/OrsBEDuex/hHPJOjrX5Xo3SPjUO2lHJEGg41/qa/9SIIUSXndK1s5 0PT0EUMqySMbEVt6fHCKbTKada/DEqmprY4ts3bh1WPGdXV50= X-IronPort-AV: E=Sophos;i="5.83,317,1616472000"; d="scan'208";a="47540000" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fO1w+OdEBMESOjluxe2el3EnkiK/tK7r+REyQiaMPDQMZGnRLn8C4fmTGlP8MGuZe2iQSEDBLidJgBuJCgivIYvY261rfaXoCXbBb2a4yh8uY2hzzwCq9LW5U4kI+FUz//PSqmq98ZUFTojAzfW4XEPm0H72QonXcMcsvU+u3I1qctiIbBvIvPoY9iQCt67IFRLTvaVaX1jw/TRu3heCtipt77qenW4z6xd85TTCGH+NY8iddmVT2AwgB4/MG/alX42UX1jpE28BNL2nZD/rz4Mi01q4edAoow6foL+egxzgYGcVIzlnMqgYBFQUn//3f5mr/YX06GqsocxobB0zjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Tpf0x1XJffsQgLTaKqZ/nNiSJRvmEJFmmAdpmrR+uYQ=; b=L5XeoRmSfYxio5XBrtX4aWFBnazWWcphZVtdtc7kSLsyghQZZoD5oCpjRoEDDCnsn0BaHNOxmSQ5/5KH9kHu66W9ro/TVMNtZxjtiGSKJvrJb2QxsfUXJyXay3mE6i8xR8habWStaL9S/egqepV8qMF9ZPlAaqCOzlGc9jW1Z+7K/ro1PWDDj5ByPvSqR4RYonML8JZuJpQ5nlhvl6ppEEuvZOPJ3CLVjgxL3wamtH21UnOEswxVXb7qGoK0Hsyd0OkK5gZy1tsULV3n/hcyOnFVcV5jJWc7VrxDLwC2WsDISQnjiDVQijSHYZoD7wmeib+ZdVLoiB05je1ioIes8g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Tpf0x1XJffsQgLTaKqZ/nNiSJRvmEJFmmAdpmrR+uYQ=; b=BXjP2bjCbLgUaGqjfIheUjLWLiTuoOFRyKLmH4glYmYco+GxjIOu4D+fWJuxIRwqB1gsVYz2J8iP+xej15t+8DPn89hp9u/DoL2pAMstGlRd9rQ5YoGFvt2Ye96OWp9O1YAXZYmkr2Pwpvs4R4aQ0vqnldghEH1jxsVBpNDH+LI= Subject: Re: [PATCH v20210701 05/40] tools: handle libxl__physmap_info.name properly in convert-legacy-stream To: Olaf Hering , CC: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , Ian Jackson , Wei Liu References: <20210701095635.15648-1-olaf@aepfle.de> <20210701095635.15648-6-olaf@aepfle.de> From: Andrew Cooper Message-ID: Date: Fri, 2 Jul 2021 16:35:24 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 In-Reply-To: <20210701095635.15648-6-olaf@aepfle.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-GB X-ClientProxiedBy: LO4P123CA0319.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:197::18) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f41efe5a-6d21-4e95-7b55-08d93d6f06a6 X-MS-TrafficTypeDiagnostic: BY5PR03MB4998: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4941; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Z71qIZGWFFJupdhXFnQrbT+gf5F4xmmck7OHjzPdLZBU2Yb8GR0jOBk39TKuTA+WtAhbwJhC0oSZnVM6duP76mpydoWSAKsk5GfxUMdy7+n3dU+/h1j14ifMMe1yRlQ6bvR2A8de/JLnp7z0w8nWLPR9/WSQaDsNahyPFwrRVvumWdA3accvuVg/Rts0fQ/OlCmEh8KLlX4CLZ/TkzG9zg9lBvM0hipGjeiO5iurmw+XXNCvjTFrcXVxSZpqUPq6aXhVfqJdQ/B/EDdpQass8HWmXaHZxWUMas2abdkgnFThPuEcxMbFkbbNsSZF4zUsfBdL7R+VvbJA0eVN1VphW3+r/GTc10IPzupvsFlaQZ1Y3k59rbdK+PUdLtCF2G8DwRH2GN+zEC+WaqojOxgKgGoJlFNhpfv3wc8S7WF5dbuGjJweQct0nM3M+VOn91hNqNhbPoHvYppB9sg2G30liP2pDe34RE2Z7FSd9qlxqfZX1Je5UWLu4FtyfHm0qeUn1gCKPXiTTf6C9VWmrjexYIb/jBpmtT2vVHv+k3qT82/eHokaR8OsH/Ux/eFi9UmUTN8HSJLCBg8lvI6yZhe6pGLAUpnJNyWY0q9Ot2wR7Um6d5qj798EjIz5YjE5sqpp2kcY+EH/4a+xtSCNzdxMK/uyyVTPaYH9NT0FaWfL82tchTzNUrt3jhJQFE+5aI93zzsQLp650uosqHZGwnJCDQGaRbwx+k1isc2Vc4MuIEx0lAJCsITeB1dfF72eojFaOdVC1BTz+PBV2+bI9jK2+w== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(376002)(396003)(346002)(39860400002)(366004)(8676002)(26005)(186003)(6486002)(16526019)(5660300002)(86362001)(53546011)(31686004)(36756003)(66556008)(956004)(31696002)(4326008)(2906002)(54906003)(66946007)(8936002)(2616005)(316002)(16576012)(478600001)(38100700002)(6666004)(66476007)(101420200003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bUhPdUVqMnNySzdsMkpPYWFELy9rMXZjMzVpZk1SS1puK3Y2bkp2a3Z5SWNr?= =?utf-8?B?NXRJbFBwaGJoWlRwb3ZJY3lIRG1KY09taTQxcUsyZHkxekMwalVyeGQwTnU0?= =?utf-8?B?MWd6c2ZGejBOUnpTT1l2aEttdHB4d2RFVDY1WUxOOVF1SngxWjBTZkkvTStL?= =?utf-8?B?V3Flak16K1ZrNUhWdmthS1VDRW11MEd3K1VMM1JJTUQxRklQVXg0ZW1HQ1BY?= =?utf-8?B?S1owSUd2QzRYU1hIV1ZEWUxTYXVOdGFiTEZ3eldCWVhMZ1JnVnBkMjBQYjNP?= =?utf-8?B?MjFRZ2VRUHQ3RE1wQ3grQ250WVMrVExqdGloZ3pMV1RoR0ZSVEMrOWN0N1BC?= =?utf-8?B?N2ZwNjZSN0REY283NkFMU01zdGNzWHBpSktRcVBSWWlFNEp3SVoxNWNOSmt6?= =?utf-8?B?dk5Ra0Z4QnNxT3lETEl0WUM3KzZrUFl5cGd3S09mYk1kYTFVc0VrT0dvTWY4?= =?utf-8?B?OHR6bE5ESzJzbmxJY2JadHFpMnFRVEVFd1pZTjd6cVB2RFhXOUVUV2NtdEVM?= =?utf-8?B?enhYcTRHNFVQSVkwRG91NkpYU2EvNUsyNlA0amd2THBGdkJIUHAwVktPVDlT?= =?utf-8?B?eC93dWl4cHZqYzdQMW5Dd0E3amZWVXBtT01kbHBmU01INjZhaEQzQmk0a0Nl?= =?utf-8?B?SmFQR1RWdWVjcEFFOWFpZGxNOUtvbXRCWVZNcXNQeVZOUVhsZ1lPbnFOdG1Q?= =?utf-8?B?WUVvMG9NLzBtZkFDZjl0aEVQam83QmlLblNLcDl2RUphQW02TjVwdXJwWnls?= =?utf-8?B?bmFPYUxYb0RDZzhuYWI1TCs4UEE5SW9ZVXlhK3BJZWxBNS9QVGtBcWt1cU1x?= =?utf-8?B?d3pISGF6SjMzWnl3TlVGZk9ON1lVTm9yalR0dUJCS1Nxd0VMaEE2TEFQNWtl?= =?utf-8?B?Wjd5Qm4yMVRYeU1rNW9sMzNUS0FLR2ROMU5YZCtpMWREdSs1eHlNSFJTNzVQ?= =?utf-8?B?Q1lFY0lOR0Q4SkNVNDVVTTVRbk5sOFk2M2NMMjBHRnY3OVI4UkVDRlBtYTVl?= =?utf-8?B?YVRnUXlkTzAvQjQya0JjQVNnLzNNd2daL2E0SUVvSGZodHk2bWs1a3FySG1a?= =?utf-8?B?MGhsNXhWd0FUNWYzeEpHV1ppcUMvV2JOMUFvREVna3ZEa0ZLdng1SnkwWVBR?= =?utf-8?B?a25ySlFNeFhkRW5USDJENURyQ21NZTNLSXhFWEFCNlN5cXFGcXY4OVFzTnVI?= =?utf-8?B?YzU3VTlrVnJxaGdjU0JOZWNFOSt3YUV5dXd5a1QvVytPZVYyTmhMQWllYkor?= =?utf-8?B?MmR6SjY2NCtXTmkrY1Vra0pacUtjb2J2blNsSnE2eGNMUHRGdlRMeC9xYU9u?= =?utf-8?B?b3IwOFlZY0VDeVF0My9PdlRjYUYrV0JCaUhaSzY4ZnppdXpuSytYZkQ2VDY5?= =?utf-8?B?dFJOVVlkeFdoS00wMVVNNkdqOVZMcFM5d054WlVPVGRQZkFOdUZTVVcycGRR?= =?utf-8?B?TWRWckRJdmRhUzg2L2l2MTFUNXM5MzFaNVdmUE5zWWpneCtwYUcyMnNNNGVS?= =?utf-8?B?RDhvNXFaSGpYQWZkZ3pMRFc1VWhseWJGdUliSFNCNkxFUWx4VGhDUE03MEJO?= =?utf-8?B?Nko0UlBXMG16L2wrYVpydW5JRzdZNU1hbHdnRU8vQ1AzbVNBOExjNmxkdnBz?= =?utf-8?B?aW1sR0JZZlBQOGpob3I1QVBpdXgxN0VPUG1lNTl5SGNKWVlvUXVzUm9CYzg2?= =?utf-8?B?T3p6cXBoVjN3b1YzNEVFektRNFNTNDB6MWh5RmtZbXI3VXo1Vm5xVkF1S3lL?= =?utf-8?Q?ZKWyJApmnRCrHqi0KfiNIGLXk7EP1Tr3gpZK2O9?= X-MS-Exchange-CrossTenant-Network-Message-Id: f41efe5a-6d21-4e95-7b55-08d93d6f06a6 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jul 2021 15:35:31.4092 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: cn7BI7VlOyQ5YyUgCnDGlN6zSsjgMXRQ5WNmQ832ZjXvB3DCllUDT2KFoZqERwELST5hxCEpU2zVPDAZ8pCihD3uexyUZwfmjzR5ZgZc9Ok= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR03MB4998 X-OriginatorOrg: citrix.com On 01/07/2021 10:56, Olaf Hering wrote: > diff --git a/tools/python/scripts/convert-legacy-stream b/tools/python/scripts/convert-legacy-stream > index 66ee3d2f5d..9003ac4f6d 100755 > --- a/tools/python/scripts/convert-legacy-stream > +++ b/tools/python/scripts/convert-legacy-stream > @@ -336,20 +336,21 @@ def read_libxl_toolstack(vm, data): > if len(data) < namelen: > raise StreamError("Remaining data too short for physmap name") > > - name = data[:namelen] > + c_string = data[:namelen] > data = data[namelen:] > > # Strip padding off the end of name > if twidth == 64: > - name = name[:-4] > + c_string = c_string[:-4] > > - if name[-1] != b'\x00': > + name, nil = unpack("={0}sB".format(len(c_string) - 1), c_string) This is rather invasive.  How about simply: diff --git a/tools/python/scripts/convert-legacy-stream b/tools/python/scripts/convert-legacy-stream index ca93a93848ec..d4ae94c02f21 100755 --- a/tools/python/scripts/convert-legacy-stream +++ b/tools/python/scripts/convert-legacy-stream @@ -342,7 +342,7 @@ def read_libxl_toolstack(vm, data):          if twidth == 64:              name = name[:-4]   -        if name[-1] != b'\x00': +        if bytearray(name)[-1] != 0:              raise StreamError("physmap name not NUL terminated")            root = b"physmap/%x" % (phys, ) which is rather more contained, and looks to work from Py2.6 and later? ~Andrew From xen-devel-bounces@lists.xenproject.org Fri Jul 02 15:51:50 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Jul 2021 15:51:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149208.275851 (Exim 4.92) (envelope-from ) id 1lzLSD-0003QK-0i; Fri, 02 Jul 2021 15:51:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149208.275851; Fri, 02 Jul 2021 15:51:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzLSC-0003QD-T4; Fri, 02 Jul 2021 15:51:44 +0000 Received: by outflank-mailman (input) for mailman id 149208; Fri, 02 Jul 2021 15:51:43 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzLSB-0003Q3-ED for xen-devel@lists.xenproject.org; Fri, 02 Jul 2021 15:51:43 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id c74e55fe-1ce7-4883-84a5-2eb606b27198; Fri, 02 Jul 2021 15:51:42 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c74e55fe-1ce7-4883-84a5-2eb606b27198 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1625241102; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=BjTqGy4abhKp1gc8m9BKzlsOJmsOYRUY/uoo8dZsolQ=; b=EQqDyzzQPjL0k+7ZjWEExH0mNVwd4haNuq07kAD01UMQQUrEMhAajjug IKyZdJRHgZqCFSWrqc57Qg1F5gdGKKy3qzLzJFDbXY64Dj+OsvX51mUD+ VCGzp6gxp2cXs88nSa5JTsgUfjtGMcKvERurc5jFtqvik39+3U/Ngejql I=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: 5FoqbxpJvQGHXpeWq5UWrpKAmtCthWJJNpCeswrd1d7pWx0OOKa/ZXTwLhcwOGYxOAQ+gSgXs6 8ux9AbSoaLOnQNXjAUTfpYGka1zRj1uNydN8tUF/CRJUxaUya8W4ebsI57CaAlUcQqhpuER9O0 t3lJBz851hpY/cRinxO/dy0kyeLyg/dwoVggGwozafZ3HkrhxZoGynJqNcCY9n7IMDbvTiftAG DZi1TYerS3BMJEnTsVcB2xpL/6SLsWl643LwV92jQ5ypxZNEjr3bNnW190dmRYmnRZQYg+2kpZ 3Ak= X-SBRS: 5.1 X-MesageID: 49104571 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:PmKBF6iKTgOr8h62UT8Hcq/G4nBQXtgji2hC6mlwRA09TySZ// rOoB0+726StN9xYgBFpTnuAsW9qB/nmqKdpLNhW4tKPzOW3VdATrsSjrcKqgeIc0aVm9K1l5 0QEZSWYOeAdGSS5vyb3ODXKbgd/OU= X-IronPort-AV: E=Sophos;i="5.83,317,1616472000"; d="scan'208";a="49104571" Date: Fri, 2 Jul 2021 16:51:38 +0100 From: Anthony PERARD To: Jan Beulich CC: "xen-devel@lists.xenproject.org" , "Ian Jackson" , Wei Liu , Andrew Cooper Subject: Re: [PATCH] libxl/x86: check return value of SHADOW_OP_SET_ALLOCATION domctl Message-ID: References: <5d2bb2cf-8c0c-7300-c895-75bef0e50817@suse.com> <4913d3f6-cd16-1865-9c19-99f7db615ded@suse.com> <89ccd8b7-42e1-0e86-5929-2a33fa1b9c4b@suse.com> <61f96b68-cd29-84c2-33ca-e114a6fc7714@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <61f96b68-cd29-84c2-33ca-e114a6fc7714@suse.com> On Fri, Jul 02, 2021 at 05:14:40PM +0200, Jan Beulich wrote: > On 02.07.2021 17:12, Jan Beulich wrote: > > On 02.07.2021 16:46, Anthony PERARD wrote: > >> On Fri, Jul 02, 2021 at 02:29:31PM +0200, Jan Beulich wrote: > >>> On 01.07.2021 11:36, Anthony PERARD wrote: > >>>> On Mon, Jun 28, 2021 at 01:47:03PM +0200, Jan Beulich wrote: > >>>>> --- a/tools/libs/light/libxl_x86.c > >>>>> +++ b/tools/libs/light/libxl_x86.c > >>>>> @@ -531,8 +531,18 @@ int libxl__arch_domain_create(libxl__gc > >>>>> if (d_config->b_info.type != LIBXL_DOMAIN_TYPE_PV) { > >>>>> unsigned long shadow = DIV_ROUNDUP(d_config->b_info.shadow_memkb, > >>>>> 1024); > >>>>> - xc_shadow_control(ctx->xch, domid, XEN_DOMCTL_SHADOW_OP_SET_ALLOCATION, > >>>>> - NULL, 0, &shadow, 0, NULL); > >>>>> + int rc = xc_shadow_control(ctx->xch, domid, > >>>> > >>>> Could you use 'r' instead of 'rc' ? The later is reserved for libxl > >>>> error codes while the former is for system and libxc calls. > >>> > >>> Of course I can, but I did look at the rest of the function and > >>> found that it uses "ret" for the purpose of what you now say > >>> "rc" ought to be used for. Seeing "ret", I decided to avoid it > >>> (knowing you use different names for different kinds of return > >>> values). While I've switched to "r" for now, I'd be rather > >>> inclined to re-use "ret" instead. (Or actually, as per the > >>> remark further down, I can get away without any local variable > >>> then.) > >> > >> I know there's quite a few (many?) coding style issue in libxl. I'm > >> trying to prevent new issue without asking to fix the existing one. > >> The use of "ret" is an already existing issue, so I'm fine with it been > >> use in this patch for libxl error code in the function. > >> > >> BTW, you still need to store the return value of xc_shadow_control() > >> into a "r" variable before checking it for error. > > > > Are you saying that > > > > if (xc_shadow_control(ctx->xch, domid, > > XEN_DOMCTL_SHADOW_OP_SET_ALLOCATION, > > NULL, 0, &shadow_mb, 0, NULL)) { > > > > is not acceptable, style-wise? > > Oh, there is indeed such a rule under "ERROR HANDLING". Which means ... > > > If indeed you are, please disambiguate > > your statement above regarding the use of "ret": May I or may I not > > use it? IOW do I need to introduce "r", or can I get away with the > > existing local variables. > > ... I need this to be clarified. You need to introduce the "r" local variable, to store xc_shadow_control return value. Then, set "ret" to ERROR_FAIL before "goto out;". Hope that's clearer. Cheers, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Fri Jul 02 16:00:39 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Jul 2021 16:00:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149215.275862 (Exim 4.92) (envelope-from ) id 1lzLam-0005SF-1N; Fri, 02 Jul 2021 16:00:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149215.275862; Fri, 02 Jul 2021 16:00:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzLal-0005S8-UJ; Fri, 02 Jul 2021 16:00:35 +0000 Received: by outflank-mailman (input) for mailman id 149215; Fri, 02 Jul 2021 16:00:34 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzLak-0005S2-Qz for xen-devel@lists.xenproject.org; Fri, 02 Jul 2021 16:00:34 +0000 Received: from smtprelay.hostedemail.com (unknown [216.40.44.36]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id a21a0c34-db4e-11eb-83b7-12813bfff9fa; Fri, 02 Jul 2021 16:00:34 +0000 (UTC) Received: from omf08.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay07.hostedemail.com (Postfix) with ESMTP id 5E8CE181D207E; Fri, 2 Jul 2021 16:00:33 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: joe@perches.com) by omf08.hostedemail.com (Postfix) with ESMTPA id 850751A29F9; Fri, 2 Jul 2021 16:00:25 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a21a0c34-db4e-11eb-83b7-12813bfff9fa Message-ID: <7379289718c6826dd1affec5824b749be2aee0a4.camel@perches.com> Subject: Re: [PATCH V7 01/18] perf/core: Use static_call to optimize perf_guest_info_callbacks From: Joe Perches To: Peter Zijlstra , Zhu Lingshan Cc: pbonzini@redhat.com, bp@alien8.de, seanjc@google.com, vkuznets@redhat.com, wanpengli@tencent.com, jmattson@google.com, joro@8bytes.org, weijiang.yang@intel.com, kan.liang@linux.intel.com, ak@linux.intel.com, wei.w.wang@intel.com, eranian@google.com, liuxiangdong5@huawei.com, linux-kernel@vger.kernel.org, x86@kernel.org, kvm@vger.kernel.org, like.xu.linux@gmail.com, Like Xu , Will Deacon , Marc Zyngier , Guo Ren , Nick Hu , Paul Walmsley , Boris Ostrovsky , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-csky@vger.kernel.org, linux-riscv@lists.infradead.org, xen-devel@lists.xenproject.org Date: Fri, 02 Jul 2021 09:00:22 -0700 In-Reply-To: References: <20210622094306.8336-1-lingshan.zhu@intel.com> <20210622094306.8336-2-lingshan.zhu@intel.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.40.0-1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 850751A29F9 X-Spam-Status: No, score=-1.40 X-Stat-Signature: shha9bwa3wcuy6qog6sh3abeec4qbbut X-Rspamd-Server: rspamout03 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Session-ID: U2FsdGVkX18c3UUJH2LcjAG65GSZ68xha895S86OjZI= X-HE-Tag: 1625241625-20610 On Fri, 2021-07-02 at 13:22 +0200, Peter Zijlstra wrote: > On Tue, Jun 22, 2021 at 05:42:49PM +0800, Zhu Lingshan wrote: > > diff --git a/arch/x86/events/core.c b/arch/x86/events/core.c [] > > @@ -90,6 +90,27 @@ DEFINE_STATIC_CALL_NULL(x86_pmu_pebs_aliases, *x86_pmu.pebs_aliases); > > */ > > DEFINE_STATIC_CALL_RET0(x86_pmu_guest_get_msrs, *x86_pmu.guest_get_msrs); > > > > > > +DEFINE_STATIC_CALL_RET0(x86_guest_state, *(perf_guest_cbs->state)); > > +DEFINE_STATIC_CALL_RET0(x86_guest_get_ip, *(perf_guest_cbs->get_ip)); > > +DEFINE_STATIC_CALL_RET0(x86_guest_handle_intel_pt_intr, *(perf_guest_cbs->handle_intel_pt_intr)); > > + > > +void arch_perf_update_guest_cbs(void) > > +{ > > + static_call_update(x86_guest_state, (void *)&__static_call_return0); > > + static_call_update(x86_guest_get_ip, (void *)&__static_call_return0); > > + static_call_update(x86_guest_handle_intel_pt_intr, (void *)&__static_call_return0); > > + > > + if (perf_guest_cbs && perf_guest_cbs->state) > > + static_call_update(x86_guest_state, perf_guest_cbs->state); > > + > > + if (perf_guest_cbs && perf_guest_cbs->get_ip) > > + static_call_update(x86_guest_get_ip, perf_guest_cbs->get_ip); > > + > > + if (perf_guest_cbs && perf_guest_cbs->handle_intel_pt_intr) > > + static_call_update(x86_guest_handle_intel_pt_intr, > > + perf_guest_cbs->handle_intel_pt_intr); > > +} > > Coding style wants { } on that last if(). That's just your personal preference. The coding-style document doesn't require that. It just says single statement. It's not the number of vertical lines or characters required for the statement. ---------------------------------- Do not unnecessarily use braces where a single statement will do. .. code-block:: c if (condition) action(); and .. code-block:: none if (condition) do_this(); else do_that(); This does not apply if only one branch of a conditional statement is a single statement; in the latter case use braces in both branches: From xen-devel-bounces@lists.xenproject.org Fri Jul 02 16:19:56 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Jul 2021 16:19:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149219.275873 (Exim 4.92) (envelope-from ) id 1lzLtN-00070M-K3; Fri, 02 Jul 2021 16:19:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149219.275873; Fri, 02 Jul 2021 16:19:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzLtN-00070F-H1; Fri, 02 Jul 2021 16:19:49 +0000 Received: by outflank-mailman (input) for mailman id 149219; Fri, 02 Jul 2021 16:19:47 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzLtL-000709-6A for xen-devel@lists.xenproject.org; Fri, 02 Jul 2021 16:19:47 +0000 Received: from wout4-smtp.messagingengine.com (unknown [64.147.123.20]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 50603c45-db51-11eb-83bb-12813bfff9fa; Fri, 02 Jul 2021 16:19:45 +0000 (UTC) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 4F51A3200939; Fri, 2 Jul 2021 12:19:44 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Fri, 02 Jul 2021 12:19:44 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 2 Jul 2021 12:19:42 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 50603c45-db51-11eb-83bb-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=YBZ4tJ Ng0hQZ1NvEYHvKXLF8rlfuU8r7NDnfsiqj9Ro=; b=iy34pu1U4GN3CfPS7M38hT VW9wqV5xo42lUIyjebAdcxpIZU0DX5U1v/4vQEVg0g7T+evI6CGmLJHNvsAbhPDM 6HJhgjvrd42MwgjGgUascf2L5j4FEWJhGGrYjP1IoBm7hXOtE4nxY13xd/mzQMyR oLJwRkONmkll9Txi13eqEDsd0S0HavUv8UCYrYPb8+/9iyD0RGp8nlN8JBx5y9DM la85lJZUivZMAOT0EKCSz8ZckQvVyzVCGyw2ozg1NRODOFGqyLb2sU1sc9/C1loG c/+pLFThAzbsPLhVm7u9MVccQVKkduw3bPOGRuMXI+tcqmUENfRZnFZrF1/7n3cg == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrfeeikedgleekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpeforghrvghk ucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesihhnvh hishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeetveff iefghfekhffggeeffffhgeevieektedthfehveeiheeiiedtudegfeetffenucevlhhush htvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgvkhes ihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Date: Fri, 2 Jul 2021 18:19:39 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Olaf Hering Cc: xen-devel@lists.xenproject.org, Ian Jackson , Wei Liu Subject: Re: [PATCH v20210701 06/40] tools: fix Python3.4 TypeError in format string Message-ID: References: <20210701095635.15648-1-olaf@aepfle.de> <20210701095635.15648-7-olaf@aepfle.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="0PxFz+rlyW/ZVH6j" Content-Disposition: inline In-Reply-To: <20210701095635.15648-7-olaf@aepfle.de> --0PxFz+rlyW/ZVH6j Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Fri, 2 Jul 2021 18:19:39 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Olaf Hering Cc: xen-devel@lists.xenproject.org, Ian Jackson , Wei Liu Subject: Re: [PATCH v20210701 06/40] tools: fix Python3.4 TypeError in format string On Thu, Jul 01, 2021 at 11:56:01AM +0200, Olaf Hering wrote: > Using the first element of a tuple for a format specifier fails with > python3.4 as included in SLE12: > b =3D b"string/%x" % (i, ) > TypeError: unsupported operand type(s) for %: 'bytes' and 'tuple' >=20 > It happens to work with python 2.7 and 3.6. > Use a syntax that is handled by all three variants. >=20 > Signed-off-by: Olaf Hering > --- > tools/python/scripts/convert-legacy-stream | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/tools/python/scripts/convert-legacy-stream b/tools/python/sc= ripts/convert-legacy-stream > index 9003ac4f6d..235b922ff5 100755 > --- a/tools/python/scripts/convert-legacy-stream > +++ b/tools/python/scripts/convert-legacy-stream > @@ -347,9 +347,9 @@ def read_libxl_toolstack(vm, data): > if nil !=3D 0: > raise StreamError("physmap name not NUL terminated") > =20 > - root =3D b"physmap/%x" % (phys, ) > - kv =3D [root + b"/start_addr", b"%x" % (start, ), > - root + b"/size", b"%x" % (size, ), > + root =3D bytes(("physmap/%x" % phys).encode('utf-8')) > + kv =3D [root + b"/start_addr", bytes(("%x" % start).encode('utf-= 8')), > + root + b"/size", bytes(("%x" % size).encode('utf-8')= ), Why bytes()? Encode does already return bytes type. > root + b"/name", name] > =20 > for key, val in zip(kv[0::2], kv[1::2]): --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --0PxFz+rlyW/ZVH6j Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmDfPJsACgkQ24/THMrX 1yxGhggAhvkfFO/jUgXBIVvtXKv0oCbmo0tJGq/QRQz7KkyXy+ZfwaSzLD1EdOgE hiJcUUfA1+o+vKXfYrQIuoIhQ7o8Unt8Y/qW1eJVweRMB9oHJ2JvCuwzZnFu7gyk m1mU5xByavGhHLC+z9OYTmWTgTh/MvUF10UZDzXsJwciWSLUYKZPqI64C1cUlgBm sCdccuaWPCrwAu3SLrlF2xMvFIPo8hKZ80YGnzpqjJfMUOkWqMo2vGWkzpX6d3Nk urNH86r/RDs3x2kB9KRd8XxTKz28JuHS2Jt8FhFBK7HrLxTdprCfbrr9AyZMNZHh yCdfKlpPfqXkb/mwzA/7Our3VJ8g+w== =Vc5l -----END PGP SIGNATURE----- --0PxFz+rlyW/ZVH6j-- From xen-devel-bounces@lists.xenproject.org Fri Jul 02 16:21:18 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Jul 2021 16:21:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149223.275884 (Exim 4.92) (envelope-from ) id 1lzLuo-0008Hn-06; Fri, 02 Jul 2021 16:21:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149223.275884; Fri, 02 Jul 2021 16:21:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzLun-0008Hg-Ra; Fri, 02 Jul 2021 16:21:17 +0000 Received: by outflank-mailman (input) for mailman id 149223; Fri, 02 Jul 2021 16:21:17 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzLum-0008HW-II for xen-devel@lists.xenproject.org; Fri, 02 Jul 2021 16:21:17 +0000 Received: from casper.infradead.org (unknown [2001:8b0:10b:1236::1]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 5675a5e2-f293-45b3-8fc4-d5e4a817d9cc; Fri, 02 Jul 2021 16:21:13 +0000 (UTC) Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1lzLtX-007r9Y-4l; Fri, 02 Jul 2021 16:20:02 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 65FA830007E; Fri, 2 Jul 2021 18:19:56 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 484942B759E47; Fri, 2 Jul 2021 18:19:56 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5675a5e2-f293-45b3-8fc4-d5e4a817d9cc DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=1zeioteA+jdIxWL/dgp30Yr4n/h54VyVtqBx1y8dmpw=; b=fYXRPL+pdyd6pWTWgyqUpSCon6 hVRsaqHU4sbIFMylpPESw6s1ds+Ne9pVmfvWssHCPh1tDhQ9NkyStK+h+EbWgWCnW12z5BtIVCdGe f+zT2Z6CPo0EeWU9hw197UGVVVwpfo/M/LWBBZmP19BuXpyZ9vOQSoLzX4yYf8flnCnzPjudhIe5I nAPW1UA4YFmGzh9Tr8facSLDTW5eGOBQNDmEGJQ9f2Ue8KDsvmGSbeYOcfg67qbyPcb5an5v85HpA uIFMkJLiWxHwoIg2+vPo84aLIc+3qyJICFoRdiDRt5ZJq1EXAve92cC7Nu/lybkzevKBEV34ZCENu mIazXrTg==; Date: Fri, 2 Jul 2021 18:19:56 +0200 From: Peter Zijlstra To: Joe Perches Cc: Zhu Lingshan , pbonzini@redhat.com, bp@alien8.de, seanjc@google.com, vkuznets@redhat.com, wanpengli@tencent.com, jmattson@google.com, joro@8bytes.org, weijiang.yang@intel.com, kan.liang@linux.intel.com, ak@linux.intel.com, wei.w.wang@intel.com, eranian@google.com, liuxiangdong5@huawei.com, linux-kernel@vger.kernel.org, x86@kernel.org, kvm@vger.kernel.org, like.xu.linux@gmail.com, Like Xu , Will Deacon , Marc Zyngier , Guo Ren , Nick Hu , Paul Walmsley , Boris Ostrovsky , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-csky@vger.kernel.org, linux-riscv@lists.infradead.org, xen-devel@lists.xenproject.org Subject: Re: [PATCH V7 01/18] perf/core: Use static_call to optimize perf_guest_info_callbacks Message-ID: References: <20210622094306.8336-1-lingshan.zhu@intel.com> <20210622094306.8336-2-lingshan.zhu@intel.com> <7379289718c6826dd1affec5824b749be2aee0a4.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <7379289718c6826dd1affec5824b749be2aee0a4.camel@perches.com> On Fri, Jul 02, 2021 at 09:00:22AM -0700, Joe Perches wrote: > On Fri, 2021-07-02 at 13:22 +0200, Peter Zijlstra wrote: > > On Tue, Jun 22, 2021 at 05:42:49PM +0800, Zhu Lingshan wrote: > > > diff --git a/arch/x86/events/core.c b/arch/x86/events/core.c > [] > > > @@ -90,6 +90,27 @@ DEFINE_STATIC_CALL_NULL(x86_pmu_pebs_aliases, *x86_pmu.pebs_aliases); > > > */ > > > DEFINE_STATIC_CALL_RET0(x86_pmu_guest_get_msrs, *x86_pmu.guest_get_msrs); > > > > > > > > > +DEFINE_STATIC_CALL_RET0(x86_guest_state, *(perf_guest_cbs->state)); > > > +DEFINE_STATIC_CALL_RET0(x86_guest_get_ip, *(perf_guest_cbs->get_ip)); > > > +DEFINE_STATIC_CALL_RET0(x86_guest_handle_intel_pt_intr, *(perf_guest_cbs->handle_intel_pt_intr)); > > > + > > > +void arch_perf_update_guest_cbs(void) > > > +{ > > > + static_call_update(x86_guest_state, (void *)&__static_call_return0); > > > + static_call_update(x86_guest_get_ip, (void *)&__static_call_return0); > > > + static_call_update(x86_guest_handle_intel_pt_intr, (void *)&__static_call_return0); > > > + > > > + if (perf_guest_cbs && perf_guest_cbs->state) > > > + static_call_update(x86_guest_state, perf_guest_cbs->state); > > > + > > > + if (perf_guest_cbs && perf_guest_cbs->get_ip) > > > + static_call_update(x86_guest_get_ip, perf_guest_cbs->get_ip); > > > + > > > + if (perf_guest_cbs && perf_guest_cbs->handle_intel_pt_intr) > > > + static_call_update(x86_guest_handle_intel_pt_intr, > > > + perf_guest_cbs->handle_intel_pt_intr); > > > +} > > > > Coding style wants { } on that last if(). > > That's just your personal preference. As a maintainer, those carry weight, also that's tip rules: https://lore.kernel.org/lkml/20181107171149.165693799@linutronix.de/ From xen-devel-bounces@lists.xenproject.org Fri Jul 02 16:39:11 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Jul 2021 16:39:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149229.275895 (Exim 4.92) (envelope-from ) id 1lzMBi-0001QH-DK; Fri, 02 Jul 2021 16:38:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149229.275895; Fri, 02 Jul 2021 16:38:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzMBi-0001QA-9j; Fri, 02 Jul 2021 16:38:46 +0000 Received: by outflank-mailman (input) for mailman id 149229; Fri, 02 Jul 2021 16:38:45 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzMBh-0001Q4-EN for xen-devel@lists.xenproject.org; Fri, 02 Jul 2021 16:38:45 +0000 Received: from foss.arm.com (unknown [217.140.110.172]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTP id f6edbfb2-db53-11eb-83bc-12813bfff9fa; Fri, 02 Jul 2021 16:38:43 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 45060147A; Fri, 2 Jul 2021 09:38:43 -0700 (PDT) Received: from C02TD0UTHF1T.local (unknown [10.57.15.239]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 94E3C3F5A1; Fri, 2 Jul 2021 09:38:38 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f6edbfb2-db53-11eb-83bc-12813bfff9fa Date: Fri, 2 Jul 2021 17:38:36 +0100 From: Mark Rutland To: Joe Perches Cc: Peter Zijlstra , Zhu Lingshan , wanpengli@tencent.com, Like Xu , eranian@google.com, weijiang.yang@intel.com, Guo Ren , linux-riscv@lists.infradead.org, Will Deacon , kvmarm@lists.cs.columbia.edu, kan.liang@linux.intel.com, ak@linux.intel.com, kvm@vger.kernel.org, Marc Zyngier , joro@8bytes.org, x86@kernel.org, linux-csky@vger.kernel.org, wei.w.wang@intel.com, xen-devel@lists.xenproject.org, liuxiangdong5@huawei.com, bp@alien8.de, Paul Walmsley , Boris Ostrovsky , linux-arm-kernel@lists.infradead.org, jmattson@google.com, like.xu.linux@gmail.com, Nick Hu , seanjc@google.com, linux-kernel@vger.kernel.org, pbonzini@redhat.com, vkuznets@redhat.com Subject: Re: [PATCH V7 01/18] perf/core: Use static_call to optimize perf_guest_info_callbacks Message-ID: <20210702163836.GB94260@C02TD0UTHF1T.local> References: <20210622094306.8336-1-lingshan.zhu@intel.com> <20210622094306.8336-2-lingshan.zhu@intel.com> <7379289718c6826dd1affec5824b749be2aee0a4.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <7379289718c6826dd1affec5824b749be2aee0a4.camel@perches.com> On Fri, Jul 02, 2021 at 09:00:22AM -0700, Joe Perches wrote: > On Fri, 2021-07-02 at 13:22 +0200, Peter Zijlstra wrote: > > On Tue, Jun 22, 2021 at 05:42:49PM +0800, Zhu Lingshan wrote: > > > diff --git a/arch/x86/events/core.c b/arch/x86/events/core.c > [] > > > @@ -90,6 +90,27 @@ DEFINE_STATIC_CALL_NULL(x86_pmu_pebs_aliases, *x86_pmu.pebs_aliases); > > >   */ > > >  DEFINE_STATIC_CALL_RET0(x86_pmu_guest_get_msrs, *x86_pmu.guest_get_msrs); > > >   > > > > > > +DEFINE_STATIC_CALL_RET0(x86_guest_state, *(perf_guest_cbs->state)); > > > +DEFINE_STATIC_CALL_RET0(x86_guest_get_ip, *(perf_guest_cbs->get_ip)); > > > +DEFINE_STATIC_CALL_RET0(x86_guest_handle_intel_pt_intr, *(perf_guest_cbs->handle_intel_pt_intr)); > > > + > > > +void arch_perf_update_guest_cbs(void) > > > +{ > > > + static_call_update(x86_guest_state, (void *)&__static_call_return0); > > > + static_call_update(x86_guest_get_ip, (void *)&__static_call_return0); > > > + static_call_update(x86_guest_handle_intel_pt_intr, (void *)&__static_call_return0); > > > + > > > + if (perf_guest_cbs && perf_guest_cbs->state) > > > + static_call_update(x86_guest_state, perf_guest_cbs->state); > > > + > > > + if (perf_guest_cbs && perf_guest_cbs->get_ip) > > > + static_call_update(x86_guest_get_ip, perf_guest_cbs->get_ip); > > > + > > > + if (perf_guest_cbs && perf_guest_cbs->handle_intel_pt_intr) > > > + static_call_update(x86_guest_handle_intel_pt_intr, > > > + perf_guest_cbs->handle_intel_pt_intr); > > > +} > > > > Coding style wants { } on that last if(). > > That's just your personal preference. > > The coding-style document doesn't require that. > > It just says single statement. It's not the number of > vertical lines or characters required for the statement. > > ---------------------------------- > > Do not unnecessarily use braces where a single statement will do. > > .. code-block:: c > > if (condition) > action(); > > and > > .. code-block:: none > > if (condition) > do_this(); > else > do_that(); > > This does not apply if only one branch of a conditional statement is a single > statement; in the latter case use braces in both branches: Immediately after this, we say: | Also, use braces when a loop contains more than a single simple statement: | | .. code-block:: c | | while (condition) { | if (test) | do_something(); | } | ... and while that says "a loop", the principle is obviously supposed to apply to conditionals too; structurally they're no different. We should just fix the documentation to say "a loop or conditional", or something to that effect. Mark. From xen-devel-bounces@lists.xenproject.org Fri Jul 02 16:40:08 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Jul 2021 16:40:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149232.275906 (Exim 4.92) (envelope-from ) id 1lzMD1-0002hR-NR; Fri, 02 Jul 2021 16:40:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149232.275906; Fri, 02 Jul 2021 16:40:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzMD1-0002hK-KD; Fri, 02 Jul 2021 16:40:07 +0000 Received: by outflank-mailman (input) for mailman id 149232; Fri, 02 Jul 2021 16:40:06 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzMD0-0002h8-D2 for xen-devel@lists.xenproject.org; Fri, 02 Jul 2021 16:40:06 +0000 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 2739fb90-db54-11eb-83bc-12813bfff9fa; Fri, 02 Jul 2021 16:40:05 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2739fb90-db54-11eb-83bc-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1625244005; h=subject:to:cc:references:from:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=QNDiYe7qVvD77weSt/RSAqaII0v+IS7MsePnmosmZoc=; b=aZ+B1dvSV/EP5yq6ShYqffUn7bQnn4FxG2SmQuf1tIrtNQvZOXobi8cL gK8prKz4M9vAcLo++ROrH5hEFP2wTUouq8TzgAtYwKfM7VKkivXeaArtB JEs+OWO6afiZCXZCJojVdnz50cpCJ9MJ9Y/xgBzEa4NZhFjNyeqxRWz8+ Y=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: AKWCZRCYTFADERGXdBnNoVgL8cG1cUINEViI9ewxcS1f3XMCLff/dXSyBI4O4fn7qtQiorhgEP ozMKJS4GPp7LRG9FIBFThXbZ/kOiAUT/ZlxjtyW/V2XUiyhApogGG+4s7L90Tu/DAb0T/8OBae nhPTMCeN2cw0T1kkeHeWf1494R2xktTLTgQBNSWrUBXKjXidY5xE9ZU3JHdnxD6WTZcuxhT2r9 8eDjvT0gBYDd7epne/8sLGMqpTn4lY/wIXE2Sh8GT1g2k+x3W1m/RJfs6hN+04BI/v+kPLj+Dt qFo= X-SBRS: 5.1 X-MesageID: 47544408 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:cgiyBqPF8dnZYsBcTyr155DYdb4zR+YMi2TDiHofdfUFSKClfp 6V8cjztSWUtN4QMEtQ/exoS5PwPk80kqQFnbX5XI3SITUO3VHHEGgM1/qb/9SNIVyZygcZ79 YbT0EcMqyCMbEZt7eC3ODQKb9Jq7PmgcPY8Ns2jU0dKj2CA5sQnzuRYTzrcHGeKjM2YKbRWK Dsnfau8FGbCAUqh4mAdzU4dtmGg+eOuIPtYBYACRJiwA6SjQmw4Lq/NxSDxB8RXx5G3L9nqA H+4kLEz5Tml8v+5g7X1mfV4ZgTsNz9yuFbDMjJrsQOMD3jhiuheYwkcbyfuzIepv2p9T8R4Z bxiiZlG/42x2Laf2mzrxeo8RLnyiwS53jrzkLdqWf/oOTiLQhKSPZptMZ8SF/0+kAgtNZz3O ZgxGSCradaChvGgWDU+8XIbRd3jUC5yEBS0dL7t0YvFLf2VYUh6bD2pChuYdA99WPBmcEa+d BVfYPhDK08SyLdU5ix1VMfsuBFXRwIb1y7qwY5y5WoOgNt7QdEJn0jtYQid0c7heYAoqZ/lp L524RT5ftzp5wtHO9A7Nloe7r/NoWbe2OzDIvVGyW+KJ06 X-IronPort-AV: E=Sophos;i="5.83,317,1616472000"; d="scan'208";a="47544408" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dGFbQr0/jn0AE2GyCa/iadBmTp0FVWMg0cx3KANoN1L9/ELG8Lo22P0IXgjRQJo8S2SSfOibPy5moFL0m4yvtGk5hz++whJ9dmR8piBdSi6QetT/t3O0Gawvt4+xZdcdiJ7JmXh8x5XtEXx8+NEiEvzvHZsd6XRndywV68t3vHzN14mxoPCLF+whPymWyKvb7EwxgFoUOEBz4OzSEEi7ZNMBksOtukxJdGPNWB5+3QBV8AD+O0Du2OAI43FJBXyH88virPlLR9pq7X3QbZfTN25iTih1RIFu5BJkdKD6IP9XiH+vPuQC2utBbflbCbMpgZq0q1v7KbdNwQ5mCK7N2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PxkcVonICac42Pbf/BOtB1iAtPYZZwEMizz0Pojn5Xs=; b=dqB7GuavQ5hltphivSfSED2D6wA2NOisMq29uLOcl9grBKpIJnH955ZYO3f0o6z7pqT/RqZOYnZvytdoMpSUA3gAuU8kwGfsA3+5vgoTtqxZUavn/vtW1875i2HujBg4XO4AGlMNCFkxQOsTuS2ZaXQDJW+GSScWFxk4lVq+mefa1s9pzMndtsH3K+PC5diKEbYc512KAHmz6zLfJCUUXAITb8stcKHFeqDmGIogkuN904AWygI3nNCrVDX0JhOij6YFJQVfLNQIzS68nGch6MVYNHCN6/QMMbF5AVeNNTjNIx2itTP9nsscLNseaT3LJ/YnmPqJ3dd7LG/yWWbSsw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PxkcVonICac42Pbf/BOtB1iAtPYZZwEMizz0Pojn5Xs=; b=uuJnD5Y1w2TG3pBfKH5+bYzVjqLWtHiYb5WiBu2vJvmD7oQQxzwJEOP7gfNBUQZkoH4gDmgEYrdFirPWpiK193Xqn0rU46FKUZHXSpiIpdPDYsL2mxkEDypAHEKhrinFbYo3WlCKzSmbUbT/mSHiLoP2nEbD5lXD/WygQBcF3zQ= Subject: Re: [PATCH v20210701 06/40] tools: fix Python3.4 TypeError in format string To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , Olaf Hering CC: , Ian Jackson , Wei Liu References: <20210701095635.15648-1-olaf@aepfle.de> <20210701095635.15648-7-olaf@aepfle.de> From: Andrew Cooper Message-ID: Date: Fri, 2 Jul 2021 17:39:54 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-GB X-ClientProxiedBy: LO4P123CA0423.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18b::14) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 68badc1b-971b-4609-547f-08d93d7808e6 X-MS-TrafficTypeDiagnostic: BYAPR03MB4166: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3044; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: V93+PyxjLhMoQ7hmRua8HwSUDtVlpPzWWyItnsP3kA9UYM7DY34uHjqvBIHlr035D8cFKRpVpxByyJR+5ut3uMLFqxX2lbw5P6uq9DAlAADh6p1vck4jqaJnw/hrqmunH79RFc7UCIF0bczq5Tb1kCDGskcXfOIGmKqhNTwF6HQoeIuWkHkgeUYktuLigf2BIf62p6fvEAUDmaXkqUaTy+/PcyVJpU3jQEJdeJ2CY3QUknY6x0QwWn/sWtrZGQgINQ8s2BzHUzZjPfWVBBrXjz6TDX1WvH+Y3MYuUofqRUrMKFhuZX+5nEb1nCEI2KJg4q5C7rWJZz5xQoYRj1n0PlhsPh4duqaZwbZ/KQia8GGLVVT4V7L3/dLgLROnQc3f7tKIlTSl27cSc+vy5DjwUA20oNFunqVGS1tM7pmNHNXCTCzcfoPng2iggkpMTvEWGPEw50P/4POvkTB/v+17VjpWMUGbTsX7glbeRF1phjDsjoQeMsugMmorxxqDvJ50rRZGG9iwsiJouCkIDeh6DAgTf8LIVHmBjgNJDP5LUP84c1JY0ZW+FA+8YKXGeh9lIWTUYONRA6ti6hpW2kpjW++I+VBbTHUWsanP74XNkNgKMOmoSD9szXgGEJY7X7229PFV/gPOotc0BCW0R1YK1FKuZA8t/btQPGk/kUomLoHexnfFDB2TJT1YvK5xPItRUFcMlCL97YozaxhW3j30dPPmW2g5xeb56Ipw9OyTnQ61eCHKqwigkBV92q+ojNqO8FlIwWPj3rAebRVT5vL2ojV2XtIc5J9ONO6TKveX0A5TFgEzFwkTI1a20OPPIC5h X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(376002)(396003)(346002)(39860400002)(136003)(316002)(6666004)(16576012)(8676002)(16526019)(31686004)(110136005)(31696002)(6486002)(2906002)(86362001)(8936002)(5660300002)(38100700002)(54906003)(956004)(2616005)(83380400001)(966005)(36756003)(66476007)(478600001)(66946007)(186003)(26005)(66556008)(4326008)(53546011)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VmhmYzJEMHQ1N0VHV2xBOThrcVlGZUM1Qy9yMmp4THJYcjJmclR0QWdSdDM3?= =?utf-8?B?WWZ2U1ltaW9NMUtHa0JUaVkxTHdIemt3azQrNDhGWHdxWTRxdkRVM3ZPTmFt?= =?utf-8?B?Z053NlExS0VxYlBvdXI5QXBzdXB1dVNCMDkzZmRmK1ZwaG83QzFsbmZHYk1P?= =?utf-8?B?UmFlRzFRVDZwekpwNGJWNWxxTm9YK2p4eFpKWTJIK0N4SURXb1JNc1FrMlV2?= =?utf-8?B?YmRrQzUzeTgzYXppVnN2bkRUcVIrc05yNFB1M2h1OXBPRTl4TDlEL2I1YzN4?= =?utf-8?B?bS80TnAzTjQ0WHN6cThXdndJb1U1eWpJMUpIdC8reU9RNzltU3hoQXRKelhh?= =?utf-8?B?RkhpeHlSVWZoeEM5TXZCQ1d3b2RJQTVtTHVqME1iYXN6MHVETkgvb3JRMnRS?= =?utf-8?B?Z3pad3gyMThqdS80SDRvYzdKU0RHelFOSlJNMUFtbVNvUlg3UHp0by9FWFU1?= =?utf-8?B?ZjRPL1RrL3RzcTRmTzhHdnJTa3M5SnQvZGRUb1hxM2FCWlRwNktKbVd1Q3Bk?= =?utf-8?B?dDdLNzk2NjB2WmljeTEwTTAzeFZMNElBU2srcVB4ak1oa0szMlAvOG4xeUpJ?= =?utf-8?B?Ly9RemVMeFhkSUQrcExPVE9IWmhRd3FCRUhVSVdHVHI3QUtXYjdDc1FjSHJR?= =?utf-8?B?OXpMZmQ4SU92YmE0ZllabU1qVDIvL2NDc2tTVzRCVW4xUkg3NWRsYXR3TDRl?= =?utf-8?B?WTdhSjI4TUgyNllHL21YSWZhOUVVM1FNU2Rub1ZkREowUnVwVWpJK0pJQlFT?= =?utf-8?B?K01Cc1QyQ0NIK01TVHJSTHZyWXhVUGZZR2Nqek5QNzhSTUpsK2g0aEFSSG9l?= =?utf-8?B?ZGZsM2Znd3NoYzFjL3Zwd3ZFZmUyVFlIbHFkTjlqTFM4VW9jL3J3OEk2QWVk?= =?utf-8?B?a0VjZk5Ba3N1ODR6dnc3U3RqMnFEUE1iL0lrNGNGem51Sm9RMjNEODNNb2Qv?= =?utf-8?B?RkhjTmZrT2hSUTZZWENiRGMwTVJ4V3kzZGZUWHgyeVpsUEZ3eThQL2c3cVNQ?= =?utf-8?B?Q0ZzcjNqcGJUY2VIYjl5NmNmSm1pcStaNUVOWGQ5RVNRbDhCd1ZheFZhVTNx?= =?utf-8?B?QmtmYTBqTlNjcTNERUhUeGVpVFZEaVVIYnM4ekRZSFNTN3VwN1MzT2JHdGh4?= =?utf-8?B?SWFNTlhxQ1ZVUDJnQ0d4RytraTBQNnJVZzloZGJmNThIYWFjSHpxc3Z2R2ph?= =?utf-8?B?VTFzanpacEVZYnhKZGJ5Q3VRVTJxV3kvMUhWbEZ3UUlBNFA1Q3FINm5pUERU?= =?utf-8?B?SWpqN2tGK0FWWEREcWREcERlVTJuUWxZMFlkVWp0dVFYNkhwZU9MNVlJbnp1?= =?utf-8?B?WU9EclJKR0FIaHI2NHpsbkpGKzVLbnlCSG5EQW9IY1k5NXg5QnZiVExqRGtO?= =?utf-8?B?K3dMYUFRcS80MFJQbkNra1NYZnoyVnREdCtPNHVZOGNwUnlMYmU0WHMram91?= =?utf-8?B?ZCtwcXBrZkZjTi9BTDlIUldUcW9sdVMwZFBkYUNXMWZTM0IvVDJXbmNWcVM0?= =?utf-8?B?SFo0Y2Jwa0s2WjIrb2RlY29lLzFEaHJUUEd6R05sK2JlNkxWbGxSZ1RHcGpS?= =?utf-8?B?bGFkd3RUMGpueUgxckRab1ErcGxqY3d4OEhXb2IxeVFFT25MaFpCZUFPcmMv?= =?utf-8?B?eFV5OVhwVGNscTVKZjhFeU0yYUt4ekljS1VzcHV3NVFXVlRlb2dTS1BRaFdI?= =?utf-8?B?ZW14cUhneGFvOXFERjM0MDRZZG95YVJrbUJLOVNYcnJxRlc5dTRyZ2MyMEpT?= =?utf-8?Q?2zEpd+gePenZtoiStoVknIEZfo4URMbtLiVL4E1?= X-MS-Exchange-CrossTenant-Network-Message-Id: 68badc1b-971b-4609-547f-08d93d7808e6 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jul 2021 16:40:00.6097 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: iNBr8bs/awouGz0XcaFq4mCvg+q/GUUN+mPTf2Fg9cAzeoSnR7o1jniXjzi2MvmvQfofQtwWMFQ8HFhpxaUQnjKIfWFpY6RbOL/e10+1ze0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB4166 X-OriginatorOrg: citrix.com On 02/07/2021 17:19, Marek Marczykowski-Górecki wrote: > On Thu, Jul 01, 2021 at 11:56:01AM +0200, Olaf Hering wrote: >> Using the first element of a tuple for a format specifier fails with >> python3.4 as included in SLE12: >> b = b"string/%x" % (i, ) >> TypeError: unsupported operand type(s) for %: 'bytes' and 'tuple' >> >> It happens to work with python 2.7 and 3.6. >> Use a syntax that is handled by all three variants. >> >> Signed-off-by: Olaf Hering >> --- >> tools/python/scripts/convert-legacy-stream | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/tools/python/scripts/convert-legacy-stream b/tools/python/scripts/convert-legacy-stream >> index 9003ac4f6d..235b922ff5 100755 >> --- a/tools/python/scripts/convert-legacy-stream >> +++ b/tools/python/scripts/convert-legacy-stream >> @@ -347,9 +347,9 @@ def read_libxl_toolstack(vm, data): >> if nil != 0: >> raise StreamError("physmap name not NUL terminated") >> >> - root = b"physmap/%x" % (phys, ) >> - kv = [root + b"/start_addr", b"%x" % (start, ), >> - root + b"/size", b"%x" % (size, ), >> + root = bytes(("physmap/%x" % phys).encode('utf-8')) >> + kv = [root + b"/start_addr", bytes(("%x" % start).encode('utf-8')), >> + root + b"/size", bytes(("%x" % size).encode('utf-8')), > Why bytes()? Encode does already return bytes type. Yes - I've just tried this out on various version of python (including https://www.onlinegdb.com/online_python_interpreter which is the only place I can find Python 3.4 easily available) .encode() does return bytes (Py3) or str (Py2) so doesn't need the surrounding bytes(). However, the % (phys, ) with the trailing comma is deliberate to work around a common python error, so wants to remain if you're keeping the %-formatting. ~Andrew From xen-devel-bounces@lists.xenproject.org Fri Jul 02 16:42:38 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Jul 2021 16:42:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149237.275917 (Exim 4.92) (envelope-from ) id 1lzMFR-0003SL-BZ; Fri, 02 Jul 2021 16:42:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149237.275917; Fri, 02 Jul 2021 16:42:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzMFR-0003SE-7m; Fri, 02 Jul 2021 16:42:37 +0000 Received: by outflank-mailman (input) for mailman id 149237; Fri, 02 Jul 2021 16:42:36 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzMFQ-0003S8-2m for xen-devel@lists.xenproject.org; Fri, 02 Jul 2021 16:42:36 +0000 Received: from smtprelay.hostedemail.com (unknown [216.40.44.201]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id ce75d36e-57c0-44ea-883c-acb8a663e0c1; Fri, 02 Jul 2021 16:42:35 +0000 (UTC) Received: from omf19.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay04.hostedemail.com (Postfix) with ESMTP id C507B180A9C91; Fri, 2 Jul 2021 16:42:34 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: joe@perches.com) by omf19.hostedemail.com (Postfix) with ESMTPA id 10EBB20D764; Fri, 2 Jul 2021 16:42:26 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ce75d36e-57c0-44ea-883c-acb8a663e0c1 Message-ID: <34a668a0606092990326207d2acc5441592756d6.camel@perches.com> Subject: Re: [PATCH V7 01/18] perf/core: Use static_call to optimize perf_guest_info_callbacks From: Joe Perches To: Peter Zijlstra Cc: Zhu Lingshan , pbonzini@redhat.com, bp@alien8.de, seanjc@google.com, vkuznets@redhat.com, wanpengli@tencent.com, jmattson@google.com, joro@8bytes.org, weijiang.yang@intel.com, kan.liang@linux.intel.com, ak@linux.intel.com, wei.w.wang@intel.com, eranian@google.com, liuxiangdong5@huawei.com, linux-kernel@vger.kernel.org, x86@kernel.org, kvm@vger.kernel.org, like.xu.linux@gmail.com, Like Xu , Will Deacon , Marc Zyngier , Guo Ren , Nick Hu , Paul Walmsley , Boris Ostrovsky , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-csky@vger.kernel.org, linux-riscv@lists.infradead.org, xen-devel@lists.xenproject.org Date: Fri, 02 Jul 2021 09:42:25 -0700 In-Reply-To: References: <20210622094306.8336-1-lingshan.zhu@intel.com> <20210622094306.8336-2-lingshan.zhu@intel.com> <7379289718c6826dd1affec5824b749be2aee0a4.camel@perches.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.40.0-1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.40 X-Stat-Signature: ycuw4tc4dkddxofnskkdygh116nc5379 X-Rspamd-Server: rspamout04 X-Rspamd-Queue-Id: 10EBB20D764 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Session-ID: U2FsdGVkX18HOccKXnefKVhqRarv+ICfPC7oSScH3Ls= X-HE-Tag: 1625244146-824246 On Fri, 2021-07-02 at 18:19 +0200, Peter Zijlstra wrote: > On Fri, Jul 02, 2021 at 09:00:22AM -0700, Joe Perches wrote: > > On Fri, 2021-07-02 at 13:22 +0200, Peter Zijlstra wrote: > > > On Tue, Jun 22, 2021 at 05:42:49PM +0800, Zhu Lingshan wrote: > > > > diff --git a/arch/x86/events/core.c b/arch/x86/events/core.c > > [] > > > > + if (perf_guest_cbs && perf_guest_cbs->handle_intel_pt_intr) > > > > + static_call_update(x86_guest_handle_intel_pt_intr, > > > > + perf_guest_cbs->handle_intel_pt_intr); > > > > +} > > > > > > Coding style wants { } on that last if(). > > > > That's just your personal preference. > > As a maintainer, those carry weight, also that's tip rules: > > https://lore.kernel.org/lkml/20181107171149.165693799@linutronix.de/ Right, definitely so. But merely referencing 'coding style' is ambiguous at best. btw: ASCII commonly refers to '{' and '}', the curly brackets, to be braces and '[' and ']', the square brackets, to be brackets. It might be clearer to use that terminology. belts and braces, etc... cheers, Joe ---------------- +Bracket rules +^^^^^^^^^^^^^ + +Brackets should be omitted only if the statement which follows 'if', 'for', +'while' etc. is truly a single line:: + + if (foo) + do_something(); + +The following is not considered to be a single line statement even +though C does not require brackets:: + + for (i = 0; i < end; i++) + if (foo[i]) + do_something(foo[i]); + +Adding brackets around the outer loop enhances the reading flow:: + + for (i = 0; i < end; i++) { + if (foo[i]) + do_something(foo[i]); + } From xen-devel-bounces@lists.xenproject.org Fri Jul 02 16:49:05 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Jul 2021 16:49:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149243.275928 (Exim 4.92) (envelope-from ) id 1lzMLe-000481-2L; Fri, 02 Jul 2021 16:49:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149243.275928; Fri, 02 Jul 2021 16:49:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzMLd-00047u-VI; Fri, 02 Jul 2021 16:49:01 +0000 Received: by outflank-mailman (input) for mailman id 149243; Fri, 02 Jul 2021 16:49:01 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzMLd-00047k-Da; Fri, 02 Jul 2021 16:49:01 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzMLd-0005Mp-77; Fri, 02 Jul 2021 16:49:01 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzMLc-0007DX-SJ; Fri, 02 Jul 2021 16:49:00 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lzMLc-0004lk-Rq; Fri, 02 Jul 2021 16:49:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=tlIp1cihvGVnO5SMtNwoPZsubtnbIaZyb7hkURA6icg=; b=05LJW/St6EhmfrYpBhjo1CPyiz v2LC+nWfaXdF5G8nuOzfPZ8grqCMfkHMyVZ7oLqyufbebWDnqD7yAypQY9o8Nc0ThOeWFpnfomqLu xPX3osu1cbCMm3MwZ83g9m78XP3hVKjQ7jGfkdDWdCnJLYzPWbEzDp25wex4YI24VcIY=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 163220: regressions - FAIL X-Osstest-Failures: qemu-mainline:test-amd64-amd64-qemuu-nested-amd:xen-boot/l1:fail:regression qemu-mainline:test-amd64-amd64-qemuu-nested-intel:xen-boot/l1:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=dd62bf14b756821fa293e3465955a41e9d460deb X-Osstest-Versions-That: qemuu=1d806cef0e38b5db8347a8e12f214d543204a314 From: osstest service owner Date: Fri, 02 Jul 2021 16:49:00 +0000 flight 163220 qemu-mainline real [real] flight 163226 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/163220/ http://logs.test-lab.xenproject.org/osstest/logs/163226/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-qemuu-nested-amd 16 xen-boot/l1 fail REGR. vs. 152631 test-amd64-amd64-qemuu-nested-intel 16 xen-boot/l1 fail REGR. vs. 152631 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152631 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 152631 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152631 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152631 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 152631 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152631 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass version targeted for testing: qemuu dd62bf14b756821fa293e3465955a41e9d460deb baseline version: qemuu 1d806cef0e38b5db8347a8e12f214d543204a314 Last test of basis 152631 2020-08-20 09:07:46 Z 316 days Failing since 152659 2020-08-21 14:07:39 Z 315 days 578 attempts Testing same since 163220 2021-07-02 02:27:48 Z 0 days 1 attempts ------------------------------------------------------------ 552 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 180596 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Jul 02 16:57:09 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Jul 2021 16:57:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149252.275950 (Exim 4.92) (envelope-from ) id 1lzMTR-0005ck-03; Fri, 02 Jul 2021 16:57:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149252.275950; Fri, 02 Jul 2021 16:57:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzMTQ-0005cd-TD; Fri, 02 Jul 2021 16:57:04 +0000 Received: by outflank-mailman (input) for mailman id 149252; Fri, 02 Jul 2021 16:57:03 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzMTP-0005cX-7b for xen-devel@lists.xenproject.org; Fri, 02 Jul 2021 16:57:03 +0000 Received: from smtprelay.hostedemail.com (unknown [216.40.44.146]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 859efe72-db56-11eb-83be-12813bfff9fa; Fri, 02 Jul 2021 16:57:02 +0000 (UTC) Received: from omf04.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay03.hostedemail.com (Postfix) with ESMTP id 1BBDF837F27E; Fri, 2 Jul 2021 16:57:01 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: joe@perches.com) by omf04.hostedemail.com (Postfix) with ESMTPA id D6515D1517; Fri, 2 Jul 2021 16:56:52 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 859efe72-db56-11eb-83be-12813bfff9fa Message-ID: <7a2ef915bd08a1c0277b9633e20905c0ca62c568.camel@perches.com> Subject: Re: [PATCH V7 01/18] perf/core: Use static_call to optimize perf_guest_info_callbacks From: Joe Perches To: Mark Rutland Cc: Peter Zijlstra , Zhu Lingshan , wanpengli@tencent.com, Like Xu , eranian@google.com, weijiang.yang@intel.com, Guo Ren , linux-riscv@lists.infradead.org, Will Deacon , kvmarm@lists.cs.columbia.edu, kan.liang@linux.intel.com, ak@linux.intel.com, kvm@vger.kernel.org, Marc Zyngier , joro@8bytes.org, x86@kernel.org, linux-csky@vger.kernel.org, wei.w.wang@intel.com, xen-devel@lists.xenproject.org, liuxiangdong5@huawei.com, bp@alien8.de, Paul Walmsley , Boris Ostrovsky , linux-arm-kernel@lists.infradead.org, jmattson@google.com, like.xu.linux@gmail.com, Nick Hu , seanjc@google.com, linux-kernel@vger.kernel.org, pbonzini@redhat.com, vkuznets@redhat.com Date: Fri, 02 Jul 2021 09:56:51 -0700 In-Reply-To: <20210702163836.GB94260@C02TD0UTHF1T.local> References: <20210622094306.8336-1-lingshan.zhu@intel.com> <20210622094306.8336-2-lingshan.zhu@intel.com> <7379289718c6826dd1affec5824b749be2aee0a4.camel@perches.com> <20210702163836.GB94260@C02TD0UTHF1T.local> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.40.0-1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.40 X-Rspamd-Server: rspamout01 X-Rspamd-Queue-Id: D6515D1517 X-Stat-Signature: yfcchsbgyrrjqd9annscud3jta5gtkxi X-Session-Marker: 6A6F6540706572636865732E636F6D X-Session-ID: U2FsdGVkX1/FrPSf3Ewjv8gI9yMKoa9Lq2JHlpGAS2Q= X-HE-Tag: 1625245012-826405 On Fri, 2021-07-02 at 17:38 +0100, Mark Rutland wrote: > On Fri, Jul 02, 2021 at 09:00:22AM -0700, Joe Perches wrote: > > On Fri, 2021-07-02 at 13:22 +0200, Peter Zijlstra wrote: > > > On Tue, Jun 22, 2021 at 05:42:49PM +0800, Zhu Lingshan wrote: [] > > > > + if (perf_guest_cbs && perf_guest_cbs->handle_intel_pt_intr) > > > > + static_call_update(x86_guest_handle_intel_pt_intr, > > > > + perf_guest_cbs->handle_intel_pt_intr); > > > > +} > > > > > > Coding style wants { } on that last if(). > > > > That's just your personal preference. > > > > The coding-style document doesn't require that. > > > > It just says single statement. It's not the number of > > vertical lines or characters required for the statement. > > > > ---------------------------------- > > > > Do not unnecessarily use braces where a single statement will do. > > > > .. code-block:: c > > > > if (condition) > > action(); > > > > and > > > > .. code-block:: none > > > > if (condition) > > do_this(); > > else > > do_that(); > > > > This does not apply if only one branch of a conditional statement is a single > > statement; in the latter case use braces in both branches: > > Immediately after this, we say: > > > Also, use braces when a loop contains more than a single simple statement: > > > > .. code-block:: c > > > > while (condition) { > > if (test) > > do_something(); > > } > > > > ... and while that says "a loop", the principle is obviously supposed to > apply to conditionals too; structurally they're no different. We should > just fix the documentation to say "a loop or conditional", or something > to that effect. Maybe. I think there are _way_ too many existing obvious uses where the statement that follows a conditional is multi-line. if (foo) printk(fmt, args...); where the braces wouldn't add anything other than more vertical space. I don't much care one way or another other than Peter's somewhat ambiguous use of the phrase "coding style". checkpatch doesn't emit a message either way. ----------------------------------------- $ cat t_multiline.c // SPDX-License-Identifier: GPL-2.0-only void foo(void) { if (foo) { pr_info(fmt, args); } if (foo) pr_info(fmt, args); if (foo) pr_info(fmt, args); } $ ./scripts/checkpatch.pl -f --strict t_multiline.c total: 0 errors, 0 warnings, 0 checks, 16 lines checked t_multiline.c has no obvious style problems and is ready for submission. ----------------------------------------- cheers, Joe From xen-devel-bounces@lists.xenproject.org Fri Jul 02 17:17:19 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Jul 2021 17:17:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149259.275961 (Exim 4.92) (envelope-from ) id 1lzMmv-0007uD-KA; Fri, 02 Jul 2021 17:17:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149259.275961; Fri, 02 Jul 2021 17:17:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzMmv-0007u6-HI; Fri, 02 Jul 2021 17:17:13 +0000 Received: by outflank-mailman (input) for mailman id 149259; Fri, 02 Jul 2021 17:17:12 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzMmu-0007tw-BT; Fri, 02 Jul 2021 17:17:12 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzMmu-0005re-3x; Fri, 02 Jul 2021 17:17:12 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzMmt-0007sA-Sf; Fri, 02 Jul 2021 17:17:11 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lzMmt-0003YK-SD; Fri, 02 Jul 2021 17:17:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=rD9bOTF/TefSSw/VO4rgXAsRt7RJgVaCE5CB+OeIYMg=; b=tUXEpVRxlqoD0m9+PfRjHgxLPI D6DJiLuH2qARjrOsNfDvwyV4qI1ZuXhEOyIJ2+hUXyrcnijJZ+DT68Whm0yr/dIEn62hmc+ObV5x9 pBeuk2BGxykBVpkREwkX2kKWZaOEohglzDSqwGijHrW8tS2qum7zZT+N7pkEMjUtwef4=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 163227: regressions - FAIL X-Osstest-Failures: ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:debian-hvm-install:fail:regression ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:debian-hvm-install:fail:regression X-Osstest-Versions-This: ovmf=fea7901dba72eeac526f3ef12a4ad4c539622373 X-Osstest-Versions-That: ovmf=c410ad4da4b7785170d3d42a3ba190c2caac6feb From: osstest service owner Date: Fri, 02 Jul 2021 17:17:11 +0000 flight 163227 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/163227/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 162359 test-amd64-amd64-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 162359 version targeted for testing: ovmf fea7901dba72eeac526f3ef12a4ad4c539622373 baseline version: ovmf c410ad4da4b7785170d3d42a3ba190c2caac6feb Last test of basis 162359 2021-06-04 03:40:08 Z 28 days Failing since 162368 2021-06-04 15:42:59 Z 28 days 75 attempts Testing same since 163216 2021-07-01 22:42:29 Z 0 days 5 attempts ------------------------------------------------------------ People who touched revisions under test: Abner Chang Agrawal, Sachin Alexandru Elisei Anthony PERARD Ard Biesheuvel Daniel Schaefer Daoxiang Li Dov Murik DunTan gaoliming Guo Dong Hao A Wu Jian J Wang Kaaira Gupta Ken Lautner Kenneth Lautner Kun Qin Laszlo Ersek Leif Lindholm Liming Gao Loo Tung Lun Loo, Tung Lun Manickavasakam Karpagavinayagam Maurice Ma Ni, Ray Patrick Rudolph Pierre Gondois Ray Ni Rebecca Cran Rebecca Cran Sachin Agrawal Sami Mujawar Scottie Kuo Sean Brogan Sean Brogan Sumana Venur Sunil V L xueshengfeng Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-i386-xl-qemuu-ovmf-amd64 fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 3224 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Jul 02 17:30:47 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Jul 2021 17:30:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149257.275975 (Exim 4.92) (envelope-from ) id 1lzN00-0001kV-2x; Fri, 02 Jul 2021 17:30:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149257.275975; Fri, 02 Jul 2021 17:30:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzMzz-0001kO-W5; Fri, 02 Jul 2021 17:30:43 +0000 Received: by outflank-mailman (input) for mailman id 149257; Fri, 02 Jul 2021 17:06:07 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzMcB-000741-5K for xen-devel@lists.xenproject.org; Fri, 02 Jul 2021 17:06:07 +0000 Received: from mail-wm1-x330.google.com (unknown [2a00:1450:4864:20::330]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 3db709d6-a894-4da3-bbc2-bb6d1936be93; Fri, 02 Jul 2021 17:06:06 +0000 (UTC) Received: by mail-wm1-x330.google.com with SMTP id m9-20020a05600c3b09b02901f246b43bbeso6828395wms.3 for ; Fri, 02 Jul 2021 10:06:06 -0700 (PDT) Received: from kali.home (lfbn-ren-1-1383-171.w86-229.abo.wanadoo.fr. [86.229.230.171]) by smtp.gmail.com with ESMTPSA id n12sm4370181wmq.5.2021.07.02.10.06.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Jul 2021 10:06:04 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3db709d6-a894-4da3-bbc2-bb6d1936be93 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=+y3LpJdUbFsVjWi7bT1uPxcUXlW8ZvzJtS1CGiUFEoo=; b=ilQbxJZxwKMQGTpGuzdy2jZotnl+hTG1GP4+nZqcxx6Wu3HRxX+IFGgRK1DGLxQGgd h3gdASG5noFqMPPnMiB6852ttDLWp7ZMoStdBXAV1idqIbRF5ykv47ft1QkqsEL8Fjxl rTTIv5Cm+c355oUdyh98s+oOjMZPVYVKVvhKAN/UvqbBnvzAQaVRmYPfODi/RYIOwgz7 AH0QFd1iTK7+dK3hRoALQls6lUIQcdscDMVnimOCq5pg5DKqQRdTPA+ICoC264k45SAQ +l3rhIpC2jEJLZqpfrtA7X2c2ITr93N71nPhV4Eq07wD0AZnEunxS1V9Q3TixbrVqhlS BKow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=+y3LpJdUbFsVjWi7bT1uPxcUXlW8ZvzJtS1CGiUFEoo=; b=s0//jmCdVudbrhdmAuw4WML5x45IB+eKjLbqLmCZ+0Cpm9iUlIV10a5tZ4kPfgfOtr brnj6upOYSMYEVxzV6eMKX6wETO1/QHlh/lJwyzuz+V0nwA6HSWROvFOx3sUA+FkBqhJ Mw4nFzQtotJknNGz6QKBoxRouLaez6BCTtFTWoDYugXvEagWLnV6hVQYhOpcTSAUCS+4 tzGs56X50tXwWd/MW8mmbwCgIc6ZsL8MllFFb4CvJAQffIhxVOtw+XNb9oQDKdNnx5qO N/RYndAaI6hdFPGwniB+9yggakdJwEUElrZvApPuvzkLM7p5xGtFggsyAe6UvuzsT26H PGYQ== X-Gm-Message-State: AOAM5311i9obDgj4r9DVpVuBju8jBuX1fwZy/Oy64eEzaR03DcuNVGGV kC+b/tqSYmv3bliUiEKxYUq6XylQLsh+pQ== X-Google-Smtp-Source: ABdhPJxbi5ZQiX8O7rrXK+xP2VIa2tUOiIAMTkTa6+eQgtwqaghu4H4YtFcpyXK3OcgJc0/nmrubSg== X-Received: by 2002:a1c:2cc3:: with SMTP id s186mr849419wms.150.1625245565163; Fri, 02 Jul 2021 10:06:05 -0700 (PDT) From: Fabrice Fontaine To: xen-devel@lists.xenproject.org Cc: Fabrice Fontaine Subject: [PATCH] xen/Makefile: drop -Werror Date: Fri, 2 Jul 2021 19:06:02 +0200 Message-Id: <20210702170602.890817-1-fontaine.fabrice@gmail.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Drop -Werror to avoid the following build failure with -DNDEBUG: In file included from :0:0: /usr/lfs/hdd_v1/rc-buildroot-test/scripts/instance-0/output-1/build/xen-4.14.2/xen/include/xen/config.h:94:0: error: "NDEBUG" redefined [-Werror] #define NDEBUG :0:0: note: this is the location of the previous definition Fixes: - http://autobuild.buildroot.org/results/66573ad0abc4244c0dfeac8b684a7bfcc31c0d4d Signed-off-by: Fabrice Fontaine --- xen/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/Makefile b/xen/Makefile index 89879fad4c..cf9f83b1fb 100644 --- a/xen/Makefile +++ b/xen/Makefile @@ -210,7 +210,7 @@ CFLAGS += -fomit-frame-pointer endif CFLAGS += -nostdinc -fno-builtin -fno-common -CFLAGS += -Werror -Wredundant-decls -Wno-pointer-arith +CFLAGS += -Wredundant-decls -Wno-pointer-arith $(call cc-option-add,CFLAGS,CC,-Wvla) CFLAGS += -pipe -D__XEN__ -include $(BASEDIR)/include/xen/config.h CFLAGS-$(CONFIG_DEBUG_INFO) += -g -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Fri Jul 02 17:34:34 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Jul 2021 17:34:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149272.275985 (Exim 4.92) (envelope-from ) id 1lzN3g-0002PL-JJ; Fri, 02 Jul 2021 17:34:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149272.275985; Fri, 02 Jul 2021 17:34:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzN3g-0002PE-GI; Fri, 02 Jul 2021 17:34:32 +0000 Received: by outflank-mailman (input) for mailman id 149272; Fri, 02 Jul 2021 17:34:31 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzN3f-0002Op-FW for xen-devel@lists.xenproject.org; Fri, 02 Jul 2021 17:34:31 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 21030f05-1198-4c84-b98a-983ba5d6a80f; Fri, 02 Jul 2021 17:34:30 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 21030f05-1198-4c84-b98a-983ba5d6a80f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1625247270; h=subject:to:references:from:message-id:date:in-reply-to: content-transfer-encoding:mime-version; bh=oKIxEfPmbuVRb1uO8qr3dJruNe1XRbrn7LXjL9ztNYk=; b=cqJKPk7UcNtPAtOVJkYtStRChHIsyjGKVEK+Kcf0dcAUXY9O1LndINYx JEuCjXCo7kBp5EArlfGSzppDk79y58hm9c21XuH/1V9L7qW03jksOHtVE 5v/1zZ9WDs60Qacizofo7aytv9lXwdAIyM65aY0ggA4pG7sNGyN8Qgvwu 8=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: lvLqR0Xt8Hcv7hJcDkOC6Idfk8jMj1X4SDYxuoBcRpETUo4IVNCAXBIPn+s3WW0sBW6hDtBT+i yzIKQiYHvUFJRwoYq0QobDvuZbEj5sRdGalSVxhPTFibO20vqrgwr2KHiy6RpNH6pU4PDmqwYM 6X96ZrK23J9MXHCr237pN9wmoKM40zj8jso7ryukTC+WeHIpOb44oNOPziP4GUUwpOtx5DeH1V AnDAHOBDr+ZaFiYp9pwykDTgvVh9v36k5+TvFN7p+woxAxEycwwKmJxVVJ3NzoaF5NW6t5u2UP Y9Y= X-SBRS: 5.1 X-MesageID: 47858398 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:kF/XpKgFMhyVawMVP3gCZrJ7s3BQXzl13DAbv31ZSRFFG/FwyP rCoB1L73XJYWgqM03IwerwQJVoMkmsjqKdgLNhdotKOTOLhILGFvAH0WKP+Vzd8mjFh5dgPM RbAuJD4b/LfD9HZK/BiWHWferIguP3lpxA7t2urEuFODsaDp2ImD0JaDpzfHcXeCB2Qb4CUL aM7MtOoDStPV4NaN6gO3UDV+/f4/XWiZPPe3c9dlIawTjLqQntxK/xEhCe0BtbeShI260e/W /MlBG8zrm/ssu81gTX2wbonttrcZrau5V+7f63+4gowwbX+0WVjUNaKv+/VQUO0aCSAZAR4Z zxSlkbToBOAjjqDxuISFPWqnTdOXAVmjLfIBaj8AfeiN28SzQgB8Vbg4VFNhPf9ko7pdl5lL lGxmSDqvNsfGX9dQnGlqz1vitR5z2JSLsZ4J0upm0aVZFbZK5arIQZ8k8QGJAcHDji4IRiFO V1FsnT6PtfbFvfNhnizyFS6c3pWm52EgaNQ0AEtMDQ2z9KnGphx09dwMAEhH8P+J80VpEB7e XZNaZjkq1IU6YtHOtA7Sc6ML6K40n2MGLx2U6pUCra/ZA8SgDwQsTMkcoIDcmRCe018Kc= X-IronPort-AV: E=Sophos;i="5.83,319,1616472000"; d="scan'208";a="47858398" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MBTr9ko5XPMPiY67MCrTYkdglpF4NPKVMZvW6TulUwZ9RvVW96W3Ws2jjoALr6VXqk+46Y9F8MMObqUCZTQnQJ8wthvXYgk49Mx2YIPFVtwBn8hBAOsL5UrO0iVdZeZVuK6Z+zSbzzZgP5NJJwPIrmFRS1oK7gKjIuiLGO2zNFaiZJXEaod2FlpyK5+8j66A4Uq9RJoRDT1wzdMM2ZBSkCsikhvSq3dLrERxTK004RVUg0x04+7wexAGvircOrv3NrrSY5Lx5YQo58xSciNpLO2fy7NDELE9vhL8ybQcjcmR3nzS2nvnaSphiskxeEbzyvlPzZBMmIls4ErK6fgsBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bROnHpnTR/M8aKMS4PXc+XiJb4a9Hhm+XOczIWCLeyE=; b=R6Xnme82RYiYm4K3ty+nPoBRtYZDxGopbK4zv5Hf4iUA+oCaoQWiCVlhzxA+sjOJbMZv23D+xADdKB85qBwdojbEVDxjqdulYqdG9WnmeVaqqsFMKSY0gl7TkCyuU+uoLMLI3rGMna5IieGhPlzbdKbF05c+Fn5kT9CU/N7qwFkTtvljxc+KsofDO8gik1C9tsKzY5bzoe5YnFpa4x2TmnwaSDSiRBVjnZp5nKKlUM6k37O7C8iVT2NBvGmIEfMqS9OMtl2AydSznjCTE2cplvwpPnK8Ls7k5W2889lX7wrwY1Bk5J7YGUgPGWurwFd6OK1cnSv1OzkNAbFQkUC42A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bROnHpnTR/M8aKMS4PXc+XiJb4a9Hhm+XOczIWCLeyE=; b=Y6CE3L2zo86eB+Y7ZIkcWS6UQCg9a87psgaeT7JqjlVt4RKDVqjb2MebzeQtXes5jLNFhKNUTuU2+0R332/+oFr0p/r/Z/y0FBKWIcGMnQt9imVSzwwvlC11so8IZ0wU/q/G567NiWAvJDvd3EN02BfeD/epO4zs3Nh0LGwgfwo= Subject: Re: [PATCH] xen/Makefile: drop -Werror To: Fabrice Fontaine , References: <20210702170602.890817-1-fontaine.fabrice@gmail.com> From: Andrew Cooper Message-ID: Date: Fri, 2 Jul 2021 18:34:11 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 In-Reply-To: <20210702170602.890817-1-fontaine.fabrice@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-GB X-ClientProxiedBy: LO4P123CA0396.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18f::23) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a3800f9e-5a6a-4a2e-14c2-08d93d7fa278 X-MS-TrafficTypeDiagnostic: SJ0PR03MB5775: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:5797; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yGJNu/cugMsqhTJ+M05GhZDVvxZVmFgzr2d8Rn13wgtg2jDom3c3x9pNWrmkrPzp/byTe7t8Vpu1Qz9Nfs+OkloY3RMqpcMhiV2BEg1pFfuxlQTy/pegfEa/q5WRxu1652/EgFT4glP0q3cVZ5RkKKcCsny0a6Z59aftMhei9h4XpnPmVBLB/9zSB8pm6ZUnK0M4ckfN73EN4mFedRR9DuihlWlNK8g6fRmLlBRF1fOvZ4NkRtW5q3Hx72KGcuiTbVxCUEde+QOAzHTIVgXdZMxZlIwhNndkYYNbX7OHUjgLuDl+xJsrewzO+nH2+3Xy6e5rTD1EoScYzcTTluNdQ38FaTisQs2LHFZgTLx1HU8fbFDcrNvcQaAAq7vr0KDpcl10aeYwMCrgWml5zjqLEg4Xvff4YxeNNSLl+s/hbnsxZ2Kl8Cgm9A1Pp1K1oKLVj4wN+yQWrahTjcOlNARWofWh9AqmuwFzzf6TqZGXU/Au/TuTMs4e8F4TF1tAjcb9GfnBTbZzvdRK/DdMh3w5GwyD5F434XTTtLik5h8Xdb7cvMnyaSr14rurLrJYGi1HjpX6qdetwXcW68or9QWDD1UNfk9VeBy8rj/bRr94MdXE3iILSZorSPxzX8IH7JOH3hGJT5SgRc6l17R9A4Hvsmlu6dL1S2W54U10C/Q+IdBPxtZeQxVULt6HXWlzRrQcEhT8ftiD3yiqelfTB9tjWAKOFqsaAIOFQRvE8tx8dbLKg9dux2AxbKhZGURWg6q9TH3lkCH4jM5L8M5UHwOcXsj1BuWV4MZB48c/quX90Y9Ec203tMMCUESRqhoJubNF X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(346002)(366004)(376002)(396003)(136003)(4744005)(2616005)(66556008)(66946007)(16526019)(478600001)(66476007)(38100700002)(26005)(956004)(36756003)(6666004)(8676002)(6486002)(8936002)(31696002)(186003)(966005)(5660300002)(316002)(16576012)(53546011)(86362001)(2906002)(31686004)(83380400001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bENjU2I3dlZ3NkpNeFpSMjZqZlZKNXY1U0NLUVhvU01QQjR2bWFmQVNyVk9S?= =?utf-8?B?R0RKNGl4YzM4enpqYXRyK0NJZGFPanpsTktIa3Fya3hRenBtRWVtcTVzZk1V?= =?utf-8?B?TDhLOS9sYy9haklBMUZ3aytrVEdoU2xyOWx1elZ6eXVaZExMMmVvWVAwWnFt?= =?utf-8?B?MWxrUW1Da0M0cEIzL093U3czQklzaEhYdjlXKytxK0E0WUVYdGhPcVRhV0xH?= =?utf-8?B?VFlvd2RnTXhwR0ZobG1hZmlEODRnU0xkY3RXK3RSRXp1VDFJbmRYS2NjTnQ4?= =?utf-8?B?VGYrdU9zblhMOXlTc1Nqekp2TU1CN1NvMDNaV3JkTGswc3NmTVFlazJMekR5?= =?utf-8?B?K1hTV2lXNWg3QXRFeWxmRjZtL0xES29wc05ONXBUd2FQTFVoSGUwNFVqV1p4?= =?utf-8?B?aGl3N3kwMzdmUVRmcTN1N2JLeEtEYjFaM1M3bVJsOGlubUZHVGw4OUl3RGhH?= =?utf-8?B?bVJjTjg3U1hRSzU0V3BHZExGRDlwL01Mdm9YY0hmUW91eWxValdRb3VmM0Nt?= =?utf-8?B?RDRxV3BVNTJCUmVNMTNMK3VMRThDOTNJTHl3Rnk5U0JWY2wwQzZWazBVV1lx?= =?utf-8?B?cFFabUtyR3B5WVZtb2Q5OGVIcksvK29FaE03cUwvcUNBbnd4dmphMFJQY1E2?= =?utf-8?B?N2lmWHVYT0VodkpiT0tBaUV0TnVLZWNtSm53djZOYm5tOFpLdGpqeDNOaVFH?= =?utf-8?B?c0xzUHJIR0paQ1dHWXJPckVESHRvOSt6RFVLamgrSGowNWR4VW1PRThaZGkv?= =?utf-8?B?YWxxb2ZUNDRCQS80amhaalBkaGxjOFZrY0EwUnU0MlhvZUI3SitXUkIwOTJJ?= =?utf-8?B?d1ZzcDlkVmlOTTZaaDl4STk2RzlMUXQ2dmI1amZ2eVlHMnhEdXFrbGwzNHhD?= =?utf-8?B?RHBCSUtHbU14YVVIcXRNbjhpQnErR2hXQ0svK2xGY2Q2VG90Tkx5VDFTSmhn?= =?utf-8?B?RXZpOGJVbGpTSXBKS2FMTTZueVV2eStINVlkcEQ4eHdaUUpjd3NSSXk0M3Qv?= =?utf-8?B?SzJMSFNWV1V2YnlISEJyUFBhRVNrSUxRRTRYVEpFMmk5L2wvZWFNSHRrMS9G?= =?utf-8?B?Q2xjQldYV21TbGZDWStjSXNnZTFhdXh5SzVUOXJna1hwTHRUOHk1d1FKSkZM?= =?utf-8?B?dTNqVXF0RkxaUTkrYjRZaC9iTU1YUS9wc0dHUWNCTFNqOUszeWtKN2V0Z3g1?= =?utf-8?B?cWtjR1U5MlkrVUJPOTh5dGFWT1BSc0lUYnJXR3p2ZTNXNkxFaDFyNVVNeTdz?= =?utf-8?B?dHAvZ2pHWUJHMDdJQitlamMyZWNzSXVvWXptUHNiTnZiei9qemM0N0hkYkRq?= =?utf-8?B?WTFucDc4Qy8wQ3dkVm5sVU1SdGhsSFBlN3RUM0E0dFQzT3BCZDk3Y3dIaGN1?= =?utf-8?B?RGpaZEVCZG14OTkxeEtKMWRGVndScnBuUk1kVmd5UTBZemh5NExUZ0pZOEVo?= =?utf-8?B?VVJXR2J6bGJxbk84djh4M1hDRnNpazF4N05HSGdZTm52Q0NvRndxaW1XMy95?= =?utf-8?B?VzdaSmZHUWoybzRIVEFIS3BxUFhWVGVtMzZQWmtuUXl1Z1NGZXo5a09CbEpN?= =?utf-8?B?OGY2S3lBL1A5cDFPYkVYUWJicDJrQjhyZ0hnaXl2cG5GWkE5RzBXc21oTUgv?= =?utf-8?B?dGtKZlRhcTY2bEJMMVZiYXdidHpIOEpSQUY4b0Q4WkxOVXZYdHJSNTVFbUdy?= =?utf-8?B?OG11ZzlOVVEvTVk4M0FUMlkxdWpVMkRDNmFFSHRvS0h0SnB6ZGdTS2V6OWRV?= =?utf-8?Q?TFVty/GOoYUB9TgzvAIVkXPBLZrEdmcehG19qj8?= X-MS-Exchange-CrossTenant-Network-Message-Id: a3800f9e-5a6a-4a2e-14c2-08d93d7fa278 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jul 2021 17:34:24.7774 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ZlWLryENd9iZ5rvbw8MK2Gh+dALsGLPzwyEVcekx08hx0KQhLGW5jPQMefBXQojqvOJme9Ic6TIfyNFIwJmixt3qCKFxtaXQ1NVmEh/py+E= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5775 X-OriginatorOrg: citrix.com On 02/07/2021 18:06, Fabrice Fontaine wrote: > Drop -Werror to avoid the following build failure with -DNDEBUG: > > In file included from :0:0: > /usr/lfs/hdd_v1/rc-buildroot-test/scripts/instance-0/output-1/build/xen-4.14.2/xen/include/xen/config.h:94:0: error: "NDEBUG" redefined [-Werror] > #define NDEBUG > > :0:0: note: this is the location of the previous definition > > Fixes: > - http://autobuild.buildroot.org/results/66573ad0abc4244c0dfeac8b684a7bfcc31c0d4d > > Signed-off-by: Fabrice Fontaine For better or worse, It is Xen's policy that -Werror will remain.  95% of the time, it is the right thing.  We will however build failures whenever they crop up. This one is weird though.  How is NDEBUG getting in twice?  What does the rest of this build environment look like? ~Andrew From xen-devel-bounces@lists.xenproject.org Fri Jul 02 17:52:32 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Jul 2021 17:52:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149276.275997 (Exim 4.92) (envelope-from ) id 1lzNKl-0004dV-3T; Fri, 02 Jul 2021 17:52:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149276.275997; Fri, 02 Jul 2021 17:52:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzNKl-0004dO-0e; Fri, 02 Jul 2021 17:52:11 +0000 Received: by outflank-mailman (input) for mailman id 149276; Fri, 02 Jul 2021 17:52:09 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzNKj-0004dI-5y for xen-devel@lists.xenproject.org; Fri, 02 Jul 2021 17:52:09 +0000 Received: from mail-lj1-x229.google.com (unknown [2a00:1450:4864:20::229]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 15aaf7df-18c3-4cf0-912f-c7bf1e1679f1; Fri, 02 Jul 2021 17:52:08 +0000 (UTC) Received: by mail-lj1-x229.google.com with SMTP id d25so14364479lji.7 for ; Fri, 02 Jul 2021 10:52:07 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 15aaf7df-18c3-4cf0-912f-c7bf1e1679f1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=G2DWgRozu9su2algE9H6/nQBT1eyOu01WcxyUE3AsBE=; b=mkMCV75SY8+wfIzunLgxIV5LXUF2CB5nOsK2zV4hdpp0m8XgvifkpIL+0iykiRL1BQ wYBndNe1f9mTDwnR7fjXWBF8stpg/t6PS2p+81Gz0vO/kgoVDPNHyX292uy+nPte/j/3 N+HXt3RoaDwJXTy1TFQ3b/j6gy9th8pmX7sx5OQfyCHniSxYt79e956lQUOw51T6tCKO eJSLjd+xNCgzE988kA3X5CmQk2R9qnqr0S8Ijet//OvYD8mBTBbgTSh6WOZ/MiqQ/aLk RC13BxEX7FfT8rwW/AYhvkHyJcUMfNMdvZD4hn+mNl6UB5kybZF7xi5hG2GggH8/ITT+ c05w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=G2DWgRozu9su2algE9H6/nQBT1eyOu01WcxyUE3AsBE=; b=krnoGug4ZVRRv0Y9Cdhs3x5Fa0VWLdG4RJO/lZyWsWC2kWvTk6D4EtkBQruB7G8SBo Z7Za6ZXDOmBptWx965gMZO1Zs0n0mMANqk+Gc7+vSp+bx5oEtHUiUoOYnhLK8SLr4r2a UjItmV5bcmIi9/Z7VFj1/kd9xSc+q5iRlsOn3oQaUKdaK4MjMvxF+0FustV8t3l6F6Qg lZWibOA9bR6L6Q2eNc8xk2i/SMe7AmQZEOlJk3L0D/Lqgr3KdxV4YXS2C6nph4OdO9WS C7/C2cajK4S4mcUjBXJaZ9Wus7HKzWCFP+otEUGmWc2PrLJof1tIUK0lN0X2fPV+/dZY FLgQ== X-Gm-Message-State: AOAM5311qwZusUVD1Nzu6BKw/tJC0SyE+vpYuRyDrnkwV3lf2z7AT6lT TxoMVvjfP23aUv24CJZAqMKbcsEoym9hOtAlxdQ= X-Google-Smtp-Source: ABdhPJzVpDWXuKaemUBNBmQ/eQiF1wV5SuMI0cEswVjNX2AgvVfmgRZZgPYnNu4xANi3guT/pupNAUBsjS100xr5InU= X-Received: by 2002:a2e:6e09:: with SMTP id j9mr470491ljc.319.1625248326760; Fri, 02 Jul 2021 10:52:06 -0700 (PDT) MIME-Version: 1.0 References: <20210702170602.890817-1-fontaine.fabrice@gmail.com> In-Reply-To: From: Fabrice Fontaine Date: Fri, 2 Jul 2021 19:51:55 +0200 Message-ID: Subject: Re: [PATCH] xen/Makefile: drop -Werror To: Andrew Cooper Cc: xen-devel@lists.xenproject.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Le ven. 2 juil. 2021 =C3=A0 19:34, Andrew Cooper a =C3=A9crit : > > On 02/07/2021 18:06, Fabrice Fontaine wrote: > > Drop -Werror to avoid the following build failure with -DNDEBUG: > > > > In file included from :0:0: > > /usr/lfs/hdd_v1/rc-buildroot-test/scripts/instance-0/output-1/build/xen= -4.14.2/xen/include/xen/config.h:94:0: error: "NDEBUG" redefined [-Werror] > > #define NDEBUG > > > > :0:0: note: this is the location of the previous definiti= on > > > > Fixes: > > - http://autobuild.buildroot.org/results/66573ad0abc4244c0dfeac8b684a7= bfcc31c0d4d > > > > Signed-off-by: Fabrice Fontaine > > For better or worse, It is Xen's policy that -Werror will remain. 95% > of the time, it is the right thing. We will however build failures > whenever they crop up. > > This one is weird though. How is NDEBUG getting in twice? What does > the rest of this build environment look like? NDEBUG is added by buildroot in the command line if the user sets BR2_ENABLE_RUNTIME_DEBUG to false since https://git.buildroot.net/buildroot/commit/?id=3D5a8c50fe05afacc3cbe8e7347e= 238da9f242fab0 I do agree that setting -Werror is generally perfectly valid for upstream. However, for downstream packager, it is generally seen as an issue as it will always raise unexepected build failures with older, newer, or exotic toolchains, see https://embeddedartistry.com/blog/2017/05/22/werror-is-not-your-friend. It would be good to, at least, have an option to disable -Werror for example through a XEN_DISABLE_WERROR. > > ~Andrew Best Regards, Fabrice From xen-devel-bounces@lists.xenproject.org Fri Jul 02 17:56:09 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Jul 2021 17:56:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149281.276008 (Exim 4.92) (envelope-from ) id 1lzNOa-0005IF-Kq; Fri, 02 Jul 2021 17:56:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149281.276008; Fri, 02 Jul 2021 17:56:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzNOa-0005I8-Hr; Fri, 02 Jul 2021 17:56:08 +0000 Received: by outflank-mailman (input) for mailman id 149281; Fri, 02 Jul 2021 17:56:07 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzNOZ-0005Hx-1e; Fri, 02 Jul 2021 17:56:07 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzNOY-0006Vb-Si; Fri, 02 Jul 2021 17:56:06 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzNOY-0000ON-GG; Fri, 02 Jul 2021 17:56:06 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lzNOY-0000ph-Fk; Fri, 02 Jul 2021 17:56:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=dEB21GecrvnwaKoxNxqsrYehj5BhE3Nh22Xi2rFa/90=; b=mh7KdqEKc2s1aYAtR65XneSD14 jQlEoZaiI5lmSO/H7rijQRplwgFCP7mr6vma7rlxhkhRdAlBpfdr/rB7m7NXhAB9VZczQK7r7v04/ wP7ETSNnGAwTCPTWLsYDAcOG7+sDSUSORB33v4ak47zLGfP5gMo+m37bRTkdfb2BqrCo=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 163225: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=3bc3be978fd61f8099797864136c5f447c0e4aae X-Osstest-Versions-That: xen=f95b7b37cfc6d4613721df9357090d14712013c0 From: osstest service owner Date: Fri, 02 Jul 2021 17:56:06 +0000 flight 163225 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/163225/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 3bc3be978fd61f8099797864136c5f447c0e4aae baseline version: xen f95b7b37cfc6d4613721df9357090d14712013c0 Last test of basis 163183 2021-06-29 13:01:32 Z 3 days Testing same since 163225 2021-07-02 15:01:35 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD Ian Jackson jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git f95b7b37cf..3bc3be978f 3bc3be978fd61f8099797864136c5f447c0e4aae -> smoke From xen-devel-bounces@lists.xenproject.org Fri Jul 02 18:17:07 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Jul 2021 18:17:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149290.276021 (Exim 4.92) (envelope-from ) id 1lzNio-0007d1-2d; Fri, 02 Jul 2021 18:17:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149290.276021; Fri, 02 Jul 2021 18:17:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzNin-0007cu-VX; Fri, 02 Jul 2021 18:17:01 +0000 Received: by outflank-mailman (input) for mailman id 149290; Fri, 02 Jul 2021 18:17:01 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzNim-0007ck-Vj; Fri, 02 Jul 2021 18:17:00 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzNim-0006w4-EM; Fri, 02 Jul 2021 18:17:00 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzNim-0001K2-4f; Fri, 02 Jul 2021 18:17:00 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lzNim-00010L-4D; Fri, 02 Jul 2021 18:17:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=/5MpkBBk0swxaI9bAqSxgRMi8d5AYsiwdiK2RghOxaA=; b=qE8HRgQm178nXmwC3CSvA5W//D tr6+L1PKRHfwYsl4zCfHBiSIuex5ZUChNoDgXAuferMf2hd+syWKkxC+mtsIoo0qbK6donX7jyeH1 s/cujL8aE3ptPWaUP81/hU32+wnfN7LAoFy1xt0LPIuUjt7qJDtJzckh4LQ9+sC6aKTM=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 163222: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-i386-xl-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-coresched-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-examine:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-pvshim:xen-install:fail:regression linux-linus:test-amd64-i386-xl-raw:xen-install:fail:regression linux-linus:test-amd64-i386-xl-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-i386:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-xsm:xen-install:fail:regression linux-linus:test-arm64-arm64-xl-seattle:debian-install:fail:regression linux-linus:test-amd64-amd64-libvirt-vhd:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-credit1:debian-install:fail:regression linux-linus:test-arm64-arm64-xl-credit2:debian-install:fail:regression linux-linus:test-arm64-arm64-xl-thunderx:debian-install:fail:regression linux-linus:test-arm64-arm64-xl-xsm:debian-install:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-arm64-arm64-xl:debian-install:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:debian-install:fail:regression linux-linus:test-amd64-amd64-amd64-pvgrub:guest-stop:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-amd64-amd64-i386-pvgrub:guest-stop:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qcow2:guest-start:fail:regression linux-linus:test-armhf-armhf-xl-cubietruck:debian-install:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:debian-di-install:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:debian-install:fail:regression linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=3dbdb38e286903ec220aaf1fb29a8d94297da246 X-Osstest-Versions-That: linux=deacdb3e3979979016fcd0ffd518c320a62ad166 From: osstest service owner Date: Fri, 02 Jul 2021 18:17:00 +0000 flight 163222 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/163222/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-coresched-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-examine 6 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-pvshim 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-raw 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-i386 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-xsm 7 xen-install fail REGR. vs. 152332 test-arm64-arm64-xl-seattle 12 debian-install fail REGR. vs. 152332 test-amd64-amd64-libvirt-vhd 13 guest-start fail REGR. vs. 152332 test-arm64-arm64-xl-credit1 12 debian-install fail REGR. vs. 152332 test-arm64-arm64-xl-credit2 12 debian-install fail REGR. vs. 152332 test-arm64-arm64-xl-thunderx 12 debian-install fail REGR. vs. 152332 test-arm64-arm64-xl-xsm 12 debian-install fail REGR. vs. 152332 test-armhf-armhf-examine 8 reboot fail REGR. vs. 152332 test-arm64-arm64-xl 12 debian-install fail REGR. vs. 152332 test-arm64-arm64-libvirt-xsm 12 debian-install fail REGR. vs. 152332 test-amd64-amd64-amd64-pvgrub 20 guest-stop fail REGR. vs. 152332 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 152332 test-amd64-amd64-i386-pvgrub 20 guest-stop fail REGR. vs. 152332 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 152332 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 152332 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 152332 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 152332 test-amd64-amd64-xl-qcow2 13 guest-start fail REGR. vs. 152332 test-armhf-armhf-xl-cubietruck 12 debian-install fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 152332 test-armhf-armhf-xl-vhd 12 debian-di-install fail REGR. vs. 152332 test-armhf-armhf-xl-multivcpu 12 debian-install fail REGR. vs. 152332 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 152332 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 152332 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152332 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152332 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass version targeted for testing: linux 3dbdb38e286903ec220aaf1fb29a8d94297da246 baseline version: linux deacdb3e3979979016fcd0ffd518c320a62ad166 Last test of basis 152332 2020-07-31 19:41:23 Z 335 days Failing since 152366 2020-08-01 20:49:34 Z 334 days 570 attempts Testing same since 163222 2021-07-02 03:54:04 Z 0 days 1 attempts ------------------------------------------------------------ 6483 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-i386-xl fail test-amd64-coresched-i386-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm fail test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm fail test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck fail test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine fail test-amd64-i386-examine fail test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel fail test-amd64-i386-qemuu-rhel6hvm-intel fail test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-amd64-pvgrub fail test-amd64-amd64-i386-pvgrub fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 fail test-armhf-armhf-libvirt-raw fail test-amd64-i386-xl-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow fail test-arm64-arm64-xl-thunderx fail test-amd64-amd64-libvirt-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1844969 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Jul 02 18:53:20 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Jul 2021 18:53:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149297.276035 (Exim 4.92) (envelope-from ) id 1lzOHg-00038f-VX; Fri, 02 Jul 2021 18:53:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149297.276035; Fri, 02 Jul 2021 18:53:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzOHg-00038Y-SW; Fri, 02 Jul 2021 18:53:04 +0000 Received: by outflank-mailman (input) for mailman id 149297; Fri, 02 Jul 2021 18:53:03 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzOHf-00038S-1E for xen-devel@lists.xenproject.org; Fri, 02 Jul 2021 18:53:03 +0000 Received: from mailhost.m5p.com (unknown [74.104.188.4]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id b9a71bfe-db66-11eb-83c4-12813bfff9fa; Fri, 02 Jul 2021 18:53:01 +0000 (UTC) Received: from m5p.com (mailhost.m5p.com [IPv6:2001:470:1f07:15ff:0:0:0:f7]) by mailhost.m5p.com (8.16.1/8.15.2) with ESMTPS id 162IqlBN003070 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Fri, 2 Jul 2021 14:52:53 -0400 (EDT) (envelope-from ehem@m5p.com) Received: (from ehem@localhost) by m5p.com (8.16.1/8.15.2/Submit) id 162Iqlv7003069; Fri, 2 Jul 2021 11:52:47 -0700 (PDT) (envelope-from ehem) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b9a71bfe-db66-11eb-83c4-12813bfff9fa Date: Fri, 2 Jul 2021 11:52:47 -0700 From: Elliott Mitchell To: Fabrice Fontaine Cc: Andrew Cooper , xen-devel@lists.xenproject.org Subject: Re: [PATCH] xen/Makefile: drop -Werror Message-ID: References: <20210702170602.890817-1-fontaine.fabrice@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=0.4 required=10.0 tests=KHOP_HELO_FCRDNS autolearn=no autolearn_force=no version=3.4.5 X-Spam-Checker-Version: SpamAssassin 3.4.5 (2021-03-20) on mattapan.m5p.com On Fri, Jul 02, 2021 at 07:51:55PM +0200, Fabrice Fontaine wrote: > > I do agree that setting -Werror is generally perfectly valid for upstream. > However, for downstream packager, it is generally seen as an issue as > it will always raise unexepected build failures with older, newer, or > exotic toolchains, see > https://embeddedartistry.com/blog/2017/05/22/werror-is-not-your-friend. > It would be good to, at least, have an option to disable -Werror for > example through a XEN_DISABLE_WERROR. Two people don't make it a majority opinion, but if this was a meeting this opinion would get a second. I don't know where everyone is on the spectrum, but I also strongly dislike -Werror yet do like -Wall and tend to get rid of warnings. -Werror is good for continuous integration systems, not so great for releases or active development. -Werror kind of seems like Stack Ranking, good for use during brief periods, but poor for long term continuous use. -- (\___(\___(\______ --=> 8-) EHM <=-- ______/)___/)___/) \BS ( | ehem+sigmsg@m5p.com PGP 87145445 | ) / \_CS\ | _____ -O #include O- _____ | / _/ 8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/5445 From xen-devel-bounces@lists.xenproject.org Fri Jul 02 19:03:53 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Jul 2021 19:03:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149302.276046 (Exim 4.92) (envelope-from ) id 1lzOS4-0004bM-Vq; Fri, 02 Jul 2021 19:03:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149302.276046; Fri, 02 Jul 2021 19:03:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzOS4-0004bF-Sm; Fri, 02 Jul 2021 19:03:48 +0000 Received: by outflank-mailman (input) for mailman id 149302; Fri, 02 Jul 2021 19:03:48 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzOS4-0004b9-9L for xen-devel@lists.xenproject.org; Fri, 02 Jul 2021 19:03:48 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id c6e9edb3-9766-4be2-bc1d-fa69b044b748; Fri, 02 Jul 2021 19:03:47 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c6e9edb3-9766-4be2-bc1d-fa69b044b748 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1625252627; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=9SOX91f3hRKaTPe6o7t7fdvabRZeV3+jzwC4q2f8vfM=; b=bn69MBVXlWBsAm+FCU7jyg8GCjykMDEfQihg/+C26zyHbZcSmVB8tIq3 lAAHfeXfiAkMveYiW2ZDU54qQM0ubs82BsFf9xXFLZsHZHSor6/ZjeuTO /NkaO05AZyIebkEiDONwdno/GE1kLJqAPkcC8lZsrqSagbLztFEcOjwjn E=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: kZ7R2aNXK7xosx3lmuMrbGttPgNSIrQL4vk030p8lm94pJ0XiFcPJ5cnbqHXIgiYpJ1fRRzs1d Jn8CVj4R/RVg1LutiETFu30iA8dulbNCkvsRwxEMRBT0FG0/rUENVek2trmRLlyuPhaX+RPfKV sxau0udUq26yzxUNkVtKZhkrNLMuO4zDz+t4T2b13vRztdqxK6Oa3UUja4c1j6uU8cbBYT68rN IjX2CMRY5ovRksE//znyjRH3qVcfsLYatG7TLaKJREabVFFUFxwZSRd+HxRQzkfO3k8f8q5w2x 7A4= X-SBRS: 5.1 X-MesageID: 47863081 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:vmWBBK2BjUq/ipG/pBjcaQqjBLwkLtp133Aq2lEZdPRUGvb4qy nIpoV86faUskd3ZJhOo6HiBEDtexzhHP1OkO0s1NWZLWvbUQKTRekIh+aP/9SJIVyGygc378 ddmsZFZuEYdWIK6PrH3A== X-IronPort-AV: E=Sophos;i="5.83,319,1616472000"; d="scan'208";a="47863081" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Ian Jackson , Olaf Hering Subject: [PATCH] tools/libxenguest: Fix max_extd_leaf calculation for legacy restore Date: Fri, 2 Jul 2021 20:03:34 +0100 Message-ID: <20210702190334.31271-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit 0x1c is lower than any value which will actually be observed in p->extd.max_leaf, but higher than the logical 9 leaves worth of extended data on Intel systems, causing x86_cpuid_copy_to_buffer() to fail with -ENOBUFS. Correct the calculation. The problem was first noticed in c/s 34990446ca9 "libxl: don't ignore the return value from xc_cpuid_apply_policy" but introduced earlier. Fixes: 34990446ca91 ("libxl: don't ignore the return value from xc_cpuid_apply_policy") Reported-by: Olaf Hering Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu CC: Ian Jackson CC: Olaf Hering Olaf - as I've changed the fix, I haven't included your T-by tag, but I'm confident that this will suitably address the issue. --- tools/libs/guest/xg_cpuid_x86.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/libs/guest/xg_cpuid_x86.c b/tools/libs/guest/xg_cpuid_x86.c index e01d657e0394..0c9c4fefc1ef 100644 --- a/tools/libs/guest/xg_cpuid_x86.c +++ b/tools/libs/guest/xg_cpuid_x86.c @@ -513,7 +513,7 @@ int xc_cpuid_apply_policy(xc_interface *xch, uint32_t domid, bool restore, /* Clamp maximum leaves to the ones supported on 4.12. */ p->basic.max_leaf = min(p->basic.max_leaf, 0xdu); p->feat.max_subleaf = 0; - p->extd.max_leaf = min(p->extd.max_leaf, 0x1cu); + p->extd.max_leaf = min(p->extd.max_leaf, 0x8000001c); } if ( featureset ) -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Fri Jul 02 19:03:54 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Jul 2021 19:03:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149303.276058 (Exim 4.92) (envelope-from ) id 1lzOSA-0004t2-6n; Fri, 02 Jul 2021 19:03:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149303.276058; Fri, 02 Jul 2021 19:03:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzOSA-0004sv-3n; Fri, 02 Jul 2021 19:03:54 +0000 Received: by outflank-mailman (input) for mailman id 149303; Fri, 02 Jul 2021 19:03:53 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzOS9-0004b9-01 for xen-devel@lists.xenproject.org; Fri, 02 Jul 2021 19:03:53 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id ee2ce74b-9f90-4eab-b1ff-80532c0c4121; Fri, 02 Jul 2021 19:03:51 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ee2ce74b-9f90-4eab-b1ff-80532c0c4121 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1625252631; h=from:to:cc:subject:date:message-id:mime-version; bh=gfmANs3MCnxiFwWReGm72wEovDSLU4AH2fTV/7XxIgU=; b=Lq1K3KAox0l97aU1NuuBVTcFZhdMiX+Ak0kCTntpFADV8kc0+XY1yYA2 eejJQejnnxgIdonn/Yc8ABKN6FKS+Ip2a7weU4NoRzxRjXaEs7bXaEp8D pWx7uBPPr7JkjahfXHm6AcT7ibaSYcTBlU3XIkKUKC+Msfy6O9BbDt6sX w=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: Y3L9KClQ1ZJnN9B06enohAJUu2Ta2Qkokk56xo83VZvvCU8ypoUZxh3VQZeCVgmIM1GFuuLzV/ EWgF2qO8KKmygTzDozzfUR51wsBm+eu6fqwWtSlqaQ3+FkjM3+1izAwHB7ioYUvitAJkULp6G8 JOr5OrOh7DaHg47dmDdzyxsQSrGxItvwXNJt6VnW0xz6/kWcdBeojyrl6Di2jil2CN8souhyWr Xt14Q8QwAmTLPErsnxwktX+InRZOCcCUCjm1t7LTIdEQ2ieqBQfqx6a6BzHvyJ93Dzr0JksZ+N Ki4= X-SBRS: 5.1 X-MesageID: 47863089 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:CAGIEql2HENup4MFrxNEeSw2tFXpDfIk3DAbv31ZSRFFG/Fxl6 iV/cjztCWE7gr5N0tQ+uxoVJPufZq+z+8T3WByB8bBYOCOggLBR+sOgbcKqweQfxEWndQ86U 4PScZD4aXLfD1Hsfo= X-IronPort-AV: E=Sophos;i="5.83,319,1616472000"; d="scan'208";a="47863089" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Ian Jackson , Wei Liu , Olaf Hering Subject: [PATCH] tools/libxenguest: Fix migration's debug option Date: Fri, 2 Jul 2021 20:03:42 +0100 Message-ID: <20210702190342.31319-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain The code has gone through many refactors, but the first refactor was the one which broke it by inverting the check with respect to checkpointed streams. Fixes: 7449fb36c6c8 ("migration/save: pass checkpointed_stream from libxl to libxc") Reported-by: Olaf Hering Signed-off-by: Andrew Cooper --- CC: Ian Jackson CC: Wei Liu CC: Olaf Hering `xl migrate --debug` might not be perfect, but this at least brings it back to mostly working. I don't think dropping it is a sensible move. In particular, it is invaluable for testing the logdirty infrastructure when migrating a memtest VM. If anyone has a clever idea to fix the grant problem, then we can. It is after all a debug option, without any specific prescribed behaviour. --- tools/libs/guest/xg_sr_save.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/libs/guest/xg_sr_save.c b/tools/libs/guest/xg_sr_save.c index 2ba7c3200cd5..f0e2bd048d37 100644 --- a/tools/libs/guest/xg_sr_save.c +++ b/tools/libs/guest/xg_sr_save.c @@ -752,7 +752,7 @@ static int send_domain_memory_live(struct xc_sr_context *ctx) if ( rc ) goto out; - if ( ctx->save.debug && ctx->stream_type != XC_STREAM_PLAIN ) + if ( ctx->save.debug && ctx->stream_type == XC_STREAM_PLAIN ) { rc = verify_frames(ctx); if ( rc ) -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Fri Jul 02 19:20:30 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Jul 2021 19:20:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149312.276069 (Exim 4.92) (envelope-from ) id 1lzOi7-0007P6-Kd; Fri, 02 Jul 2021 19:20:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149312.276069; Fri, 02 Jul 2021 19:20:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzOi7-0007Oz-Gn; Fri, 02 Jul 2021 19:20:23 +0000 Received: by outflank-mailman (input) for mailman id 149312; Fri, 02 Jul 2021 19:20:21 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzOi5-0007Ot-Pl for xen-devel@lists.xenproject.org; Fri, 02 Jul 2021 19:20:21 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 839e4e15-2028-4f20-acd0-a4a6cfecbec9; Fri, 02 Jul 2021 19:20:20 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 839e4e15-2028-4f20-acd0-a4a6cfecbec9 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1625253620; h=subject:to:cc:references:from:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=8gPoalEr9Re1SNhKgmmyuCgslTud+udKlbclHPxuTBE=; b=N/FSOkVQ5vLd8p25MRY77hy3rw6rbT43qYsco6GUrUSZzChS+aTYJJgp UJRQ9tzsssQzLv62+0S5vTCmWtB+lnb1BpF53BTDuQYacLWEi/nbI0ab9 2No6YMLPJik/65B2FYxH8zP+ECeVnDjle7D4WkIddTpEWL1TTsZMYnYM8 Y=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: 22pzsmOhQAFc27y794eckw6i84WlBRb0t1PSNfqbPJk3s3VlGLLKvBIgFmSFAQDr6tN4ODiuoG qo/HLqw4GlEkzK8RjwHLEjXP06CpV5DO8wnv7xyUCplaYBZHRSPawKqHzNgRnBrtL2z32pKunn a+2IdQZtyhmwcg1M3yFhfEVW9mRmoMCIsaZQJW+XGN7Wds1oUL1/S+MUhYdBJu/YGc73oHvNip 9wXgZtJO3UgRRTMss8dYhJTA9JW1xQRsk2Lm6sox6HZ11ZYhh609dTsAVg7TboVQ9y+gNcs+TZ mY0= X-SBRS: 5.1 X-MesageID: 47864053 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:ERxzZKNDbhuMxMBcTyz155DYdb4zR+YMi2TDiHoedfUFSKOlfp 6V8MjztSWVtN4QMEtQ/uxoS5PwP080kqQFnrX5XI3SIDUO3VHIEGgM1/qY/9SNIVyGygcZ79 YcT0EcMqyDMbEZt7eD3ODQKb9Jq7PrgcPY55ar854ud3ANV0gJ1XYLNu/xKDwSeOApP+tcKH PR3Ls8m9L2Ek5nHvhTS0N1ENTrlpnurtbLcBQGDxko5E2nii6p0qfzF1y90g0FWz1C7L8++S yd+jaJp5mLgrWe8FvxxmXT55NZlJ/IzcZCPtWFjowwJi/3ggilSYx9U/mpvSwzosuo9FE2+e O87SsIDoBW0Tf8b2u1qRzi103LyzA18ULvzleenD/KvdH5bChSMbsCuatpNj/ir2YwttB116 xGm0iDsYBMMB/GlCPho/DVShBRkFauq3ZKq59Rs5Vma/pbVFZtl/1ZwKsMe61wWh4SqbpXUN WGNfusocq/KjihHinkVgAF+q3YYpwxdi32CHTq9PbliwS+p0oJuXfw8vZv1UvoxKhNPKWs2N 60e5iAtIs+A/P+PpgNSNvof6OMeyTwqEX3QROvyBLcZfo6B04= X-IronPort-AV: E=Sophos;i="5.83,319,1616472000"; d="scan'208";a="47864053" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FWmXMFlUsYPYaa0J63xGwXHvwW+zF3VEDFAwkLAgVGUov2CRhLrSNcVW/MvN3cRygJoOCxI/p1wUSpjSoeU9yUG+eYg3+zusGcDFyhrxiqSmHeYrfcOiqOg6hmeAGmXy0h+5c3Qc+B5+/i0SNSSKPLkv7Pw3JYxi09Z5uSYv7ympHd5Jg3TZfINUFY/oGUhb9cMiKt02zqVnsCoLgJLQtu/83urnMbuaKoBF7RDDQKe9bfqyXDWDUMVZjJyKS5mOjVrDE3fCJ2u52Yqr2zkvtovYuLi2VfcmtVzglv4foC4vjoy/Oi/tToO84DwrZ+NtdyrCmF5KXFLljXtU30zG+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8ZyIw04UjhrPa5KiX5OOX2k6ZBfrmL8RM/sb7+4MSIE=; b=TMDQgzPIxdCoTC9sjbjDm24DnCGj4OrbmxrJJjLhYDzX4Ms0rtPLcXZsREPCKlVCypioIhxPp54Q+Qf4+yWd+VxQasXFKC0ctMRcDabw30Sp/p62TZpol6zzI1QQBuOBtFDIBpMlqPWz+xwGwl7m3dJjVruPEgIzqphAtYdPGn4iRA03J3CGQRkyBk4JtfnRT/0cfcMkLDgXZtoYzBVSqwxJEfBSswit5BVotZP9Z5Xx8+HnQRH4d4V/XxJ/y0LCE/90o6bEKulLhGjxeMnEGMzewlZB+A+jM9keYEGYSF/Yx4q3seU6mnea6k72unhabuoo9BW9QahzjcdzgVf7Xw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8ZyIw04UjhrPa5KiX5OOX2k6ZBfrmL8RM/sb7+4MSIE=; b=lf4haiG22LiV7Nu3DJZIcBD8fbGSKU+vpKa7nQW+3HyLg5pMdnhYu1muQ0xc4Q8IBNfZQghqMyTDGiZfN7/uXcb4kUyMDnnH3G4PXQl1iiQAgFYXSCc2T7As/Xt8lsUWQOud2/XPDdqWzagNksWsaX68wxiz/zBT9W47TKCXQXE= Subject: Re: [PATCH v20210701 10/40] tools: add xc_is_known_page_type to libxenctrl To: Olaf Hering , CC: Ian Jackson , Wei Liu , Juergen Gross References: <20210701095635.15648-1-olaf@aepfle.de> <20210701095635.15648-11-olaf@aepfle.de> From: Andrew Cooper Message-ID: <3c0efa9b-aaff-b4b7-0fd5-9eed32b20e01@citrix.com> Date: Fri, 2 Jul 2021 20:20:08 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 In-Reply-To: <20210701095635.15648-11-olaf@aepfle.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-GB X-ClientProxiedBy: LO2P265CA0441.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:e::21) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9492f2bb-36ff-474b-8095-08d93d8e6bc6 X-MS-TrafficTypeDiagnostic: SJ0PR03MB6392: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:843; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: u5ySoHgNeKv60/5SxJ04wuYdgId3IgVF/BMq1F7eILVRxPF6iv4Ta34Bc4sgBSXrsO+EubnFMVTbp9iEGnxuKfIoLeLP9NmypTqwCbsY8LJbZSytPXtRCxdjHBFk9ssdUk57fPVB2HXYIXITL2c3W6RcsQwDe/Am68oN2bI287Mc7Y+x2jlq4F7/gFQWsWqMgy7XXgamDO6bqSr22/1f6EnS7Qsg7+gWtO9rHJyLl0ZxCOZg5bK7EjYDu9OsE/Hfd5tzYB39OXuEesSuHUX8KJHW34nZ5mp+fSi1l/276/M9RFNcNN39WYFoZ4Vz9jpTdN/FecKv44lg+x+YzHhjr2I97SV9lZKsUGmm1QYEZZryGMr9sTcvEXirgG/uNAdU+TpwoH8A+bwbWFFgJPlU2VULT+2HBRGYDSbebMPv4pDwKkFhjf9M7J+gmAKKbJ1+GFSFvyeroNjkIfJya1HIn9aQJGNAAd6Wo8COKdL+QpL5i8jJjNHOfn/zqxPh8JRbS1A///kvgNXCTEkWfixAAUT4H6AKynlyNqpH8fg8+/hKKZkRzjCDENpe/tLYt0xgkaBgGm5jgdOQlcXQK8tQaqctHBsL2ak7JIjkRbnFueXZSTmPZJR0R4MbkzYQw0GIg9HTXJLQJgQ4sqmHu03RexSaa5lsCj4mqkrbgL8f1yzAZXWaPUNKoYNvBI7CF3Luem0jk/QWvoDucEoYfsQ/YnKAZJwS+FQCjwAfh0KYt4XeQFpww1yT4UrGjdWyl+LV X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(376002)(366004)(396003)(136003)(39860400002)(16576012)(83380400001)(2616005)(316002)(478600001)(6666004)(86362001)(956004)(54906003)(4326008)(36756003)(2906002)(8676002)(31686004)(31696002)(66946007)(186003)(16526019)(66556008)(26005)(8936002)(5660300002)(6486002)(38100700002)(66476007)(53546011)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YmlRVlJIRTdlTDNOVE9DMmZmOTZHR0RiRUM1Y3RQSVU4cnFaS0pSMmk1OTdL?= =?utf-8?B?bERZTUx5UHpOOUZFeWZSYkpjMmk1dTNtam9kcCtITHEwZkE1ejd1Z0wrUFlV?= =?utf-8?B?WHdyMlNKUUpVbHVSNkx5ZkRaVnY5RHRseVo3UXc3U3N0anhuNkZyN1VVMjVD?= =?utf-8?B?TFlUUTd2ZkRMU2Vadkt2Qi81TGliT2hZYUgrMVgrQTJaQTFaOW9aemJUVVJE?= =?utf-8?B?RzIxM3lqeEFRaWZ5MldUenNWM2lSeTJuZkhudS9sd0ZydzFXWmNhQ2srNDM5?= =?utf-8?B?aEJCdENsdlkvbnlXdHFDUzVsdnExYldtZ1dtWHc0YnVkK0dQL0R3eE5tRU1G?= =?utf-8?B?Vmxid0cwVXZXamlvdVZxbG5zVW5JdExtK3NoVUlienRzV0dacUQzT3drWFNp?= =?utf-8?B?YWY0VG9lcTVOcmVqWVpHV2VyalNjK3lEc25kT095RkRpaFowbDNWdS9UdmZs?= =?utf-8?B?Uk14b2pXbnhyamJuRHY4bFByTnZiWFAyS1lSVzhGQlNybjFLQTUxZkFSVTV2?= =?utf-8?B?SFN1ZzdUYVFHeVQ0SmdLNm13bHdsUXprdHVaTHBIQ2todTRYNU9OWWlSZ0lt?= =?utf-8?B?alFYNUFObnVnKys0WFg2eEF5QUlkR3R0dk9RcW5JUG5kNk52QlN3OG5BcWcx?= =?utf-8?B?UXJYWFpWWlZYa3FMRnBWcUtZemEvRHZuZnJiT0drdWlSM2ZiMmV5UnZFMGp3?= =?utf-8?B?RzVSakVNVDAycXZsYVZBZ2JPd1lVbHYxVUtvODFueE90cWNvWGVTK3BOTDFa?= =?utf-8?B?cm13VVU3Z29ubFdiTG5RTGcyMEZvaUhkRzduVm1URTBMSUJDVHVhandxUHZ6?= =?utf-8?B?UFB6T0dETDVCeUlwSGJuSFpwaS9SNlZkK3daT21MQU5URnVCc1hGVUFvaU1Y?= =?utf-8?B?WU9RdkpOZCtIVG9HQXJWT2FhTHI4aEJwRmRucVh2OVFOWnhIMUcvYngxL0Mv?= =?utf-8?B?R3RaOGRucGNCVkgrK2dWaGZIa05mK1g0Z0VUSXN0VmNHQ1U2dWh3SUEwVXhW?= =?utf-8?B?U20zOGpjcldPRjlwdjBaWTV4WW5scjJ6cGJMdVJkb3FHNjRCSTBkK2M2aCtr?= =?utf-8?B?R2o1Wkw2M21UVSt6K2lzQ1QxSHlzbkhwRG9YdE9OYXE0aUM1Zk9KUlRGemVR?= =?utf-8?B?SE91aDhPVWFoTURKWlhiVlQvb1JtWXZqM2JpclRkVnFRR2VpMEJHYUZ5Mlhu?= =?utf-8?B?YWMwWHlOR2dHOVdVLzVYQ3hlazFGSTdVWjdscjIwd2luTkhSY0xvSTVydTI0?= =?utf-8?B?NThJc1k0WXJsWjh6TFExK0Rqbkc3b013QjYrNzI1cUZFcllMdmFldFBiWnNE?= =?utf-8?B?SHFUbGorODAvQUhDanhoOTFUNHlNR1VaOERDaFhIQWFOR3ZPTEx4SlYyRlI2?= =?utf-8?B?NWl3eDFibTZvT3pMRjJERVRaelhjem5jcUs3RFhDYnAzdnRqa0VzbTJmWS80?= =?utf-8?B?QnZkekEwb25EL3VDUnZqN2VDbmFOdW9XSkRmYk9XMGlYT2NKYjFsTHlHSU5M?= =?utf-8?B?ZURoVzgwMWxGamtkQ3dkaHByTUNIcFRCYXMyQktxZk8vRnVJdDNJSDBrc21L?= =?utf-8?B?N1h3NGR0R3BKYVQrQzhmMksxbVBvZldDbUEzbU9NRVEvZ2xNZEZkUnkwTVlT?= =?utf-8?B?TThSQ2ovTXlMNnpmV0pYNy9UbnhITnhPOGp0RW1OYnlSc3dYUFptdjRYcll2?= =?utf-8?B?VEhENUxyNFBlSXNSOGdEM01MdXY2bUg0cHhjbkRrUENvWlZOaXNGbDV0Z2Fn?= =?utf-8?Q?05cFtfoUZhPhGBDHGisUk6mBGwdb8AxSi9pIbEd?= X-MS-Exchange-CrossTenant-Network-Message-Id: 9492f2bb-36ff-474b-8095-08d93d8e6bc6 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jul 2021 19:20:15.5825 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: AO7QSuJNpKVkkIJlRZog8Kov/+d3RONxx0Bnp/adVGyL5cJNeoU/oXN+2y/ikfDV5ZF26BY8/Xz05i+nlZc7t9E1Z3rwaToeXHy50xL5G64= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6392 X-OriginatorOrg: citrix.com On 01/07/2021 10:56, Olaf Hering wrote: > Users of xc_get_pfn_type_batch may want to sanity check the data > returned by Xen. Add a simple helper for this purpose. > > Signed-off-by: Olaf Hering Subject needs correcting after v2. However, given that this is in the save/restore common header, does it really need a prefix?  Simply is_known_page_type() seems good enough. > > v02: > - rename xc_is_known_page_type to sr_is_known_page_type > - move from ctrl/xc_private.h to saverestore/common.h (jgross) > --- > tools/libs/saverestore/common.h | 33 +++++++++++++++++++++++++++++++++ > 1 file changed, 33 insertions(+) > > diff --git a/tools/libs/saverestore/common.h b/tools/libs/saverestore/common.h > index ca2eb47a4f..07c506360c 100644 > --- a/tools/libs/saverestore/common.h > +++ b/tools/libs/saverestore/common.h > @@ -467,6 +467,39 @@ int populate_pfns(struct xc_sr_context *ctx, unsigned int count, > /* Handle a STATIC_DATA_END record. */ > int handle_static_data_end(struct xc_sr_context *ctx); > > +/* Sanitiy check for types returned by Xen */ > +static inline bool sr_is_known_page_type(xen_pfn_t type) uint32_t > +{ > + bool ret; The logic will be rather shorter and cleaner to read by dropping ret and using return directly out of the switch. > + > + switch (type) Spaces. I can fix up everything on commit if you're happy with the suggestions. ~Andrew From xen-devel-bounces@lists.xenproject.org Fri Jul 02 19:27:38 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Jul 2021 19:27:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149317.276080 (Exim 4.92) (envelope-from ) id 1lzOp5-00086t-CH; Fri, 02 Jul 2021 19:27:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149317.276080; Fri, 02 Jul 2021 19:27:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzOp5-00086m-8Y; Fri, 02 Jul 2021 19:27:35 +0000 Received: by outflank-mailman (input) for mailman id 149317; Fri, 02 Jul 2021 19:27:34 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzOp4-00086g-0h for xen-devel@lists.xenproject.org; Fri, 02 Jul 2021 19:27:34 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 8c2e29e2-db6b-11eb-83c4-12813bfff9fa; Fri, 02 Jul 2021 19:27:33 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8c2e29e2-db6b-11eb-83c4-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1625254052; h=to:cc:references:from:subject:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=GJMO5191+CEUfBDPyW4CErq1LZvZxrTzZ4s7qNnQgnc=; b=fmKjq6q8da+8RH19x8hXGOOhv+UqeiQyVs2bjGIuGKImsU2eyt0d6uAw MxuGUdto2aCfGyap2ZCN7LUpNio5Y9DNuHvC6s5fbtsu1Y3S2CGWI1+Tt EBG3lClI1FPj4fr3euaupM+uBkh3dWr1b7+p7tw/evCW7rvobiAsIxAPz 0=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: cnogoSSIE4oS8gDmKv9t9zMdRiq3AhzJb2wkvLQ1BUT3N6p7TmXNTub01jxdJh0vteV4LJMaLu cCkEjjt0vsxK8rM9MfJoTG7EJ+nKRP/smE+CQasZtDZqUz2fOfFa94f9E5UVZwNQp+GMtxEFQc +iVKBk2XIhgfvTJOrguQXyDTAszsy3vbWaAQqqOpzVQqSL73c0dE/1CINOF6byBTi2qWfm4ick mSgUDrWg3Dhs9+HGYDFXAtceSUInjSFROGLmIUC89u1J/opKz4vy+j7gybOdiUH5V3yWvEiW7s Qnc= X-SBRS: 5.1 X-MesageID: 47864395 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:5MTxEqrI+gQyl9ZdqT3U/A4aV5vGL9V00zEX/kB9WHVpm5Oj+f xGzc516farslossREb+expOMG7MBfhHO1OkPcs1NCZLXbbUQqTXf1fBO7ZogEIdBeOjdK1uZ 0QFZSWTeeAcGSS7vyKkjVQcexQuOVvmZrA7Yy1ogYPPGMaH52IrT0JbTpzencGNzWubqBJba Z0iPA3wgZINU5nFPhSURI+Lpj+TpDw5d3bSC9DIyRixBiFjDuu5rK/Ox+E3i0GWzcK5bs562 DKnyHw+63m6piAu17h/l6Wy64TtMrqy9NFCsDJos8JKg/0ggLtQIh6QbWNsB08venqwlc3l9 vnpQsmIq1Imj3sV1DwhSGo9xjr0T4o5XOn40Sfm2HfrcvwQy9/I9ZdhKpCGyGpqXYIjZVZ6u ZmzmiZv51YAVfrhyLm/eXFUBlsiw6dvWciq+gOlHZSOLFuK4O5lbZvuH+9La1wWx4TsOscYa 9T5YDnlbZrmGqhHjXkVjIF+q30YpxbdS32N3TruaSuonJrdT5CvhMlLfck7wE9HaQGOtJ5Dt T/Q9NVfY51P4YrhIJGdao8qJiMeyDwqSylChPbHb2xLtB3B5uKke+t3IkI X-IronPort-AV: E=Sophos;i="5.83,319,1616472000"; d="scan'208";a="47864395" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CFREmW0qSW+js5FCssGjV33+CmubV88SX+z0J6S9d8qeMovrLFm6Mqy5ivRig2L1OQuJVRgm/baruWRDK3l5QoXsYh1HUE4ovJSBCTVstlSOMc4cWwgB2E6nXHPcMWqq8m6yPHsTFF+kAp4+BlgABMsA1NZw+CbKSgBd9/4MvXSrcPqlWvrno6fG8A2xEXhhnw5jlGFK9cQLqeVUzuc2r9Ho50psoXymE3t5cBQyG3VjbZN663B4TSyOiXU5OmN400aF5YZEi8C1zmadxBW8MNdqGfEl2lGUJAjrjbY5O93XlXDJ6gdCSLSlwepfjyT6Ph4D3VM8NIuITF6LjqyaRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PdVih0xujv8YQmEXpMnahM4rVK+2iTrv8F5oQBUTJx0=; b=J1m54eCE956lJbm/Ne36GRfMdwB9Vf8Pv25+7e6SKrYCzq2F7b2hPxeBOfrO3dHHod+shmlFHbJWh5pYt7L1/XsqBhSzzJl778/VwoyuC6ogykJxH4jmisGrXCgPxm7uqOOt8MRH6j7xUYtnNceDD7pfn3EEjCGzKR8eWMApbJLeqm9GuCjgJr8Pjcd8RVEOHJTzLNYCf4Xkdj5UBSETUjTT1OJtWOVVWk61xaaCdbHUoqQoy7xUgTfR9dGQOcHbIIcB+XNiZnkzRyEWeN9PkcET1GvwhJZivSsHFW+7b8wy8XcKBnBGFfl41Lbm2iAGW1ntqhnPPRHxsVUHHlskQw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PdVih0xujv8YQmEXpMnahM4rVK+2iTrv8F5oQBUTJx0=; b=ht4Z116AcTCBMAwmEFtTE0647+IQ+NyhnIod+EbHYHD1AXiUgVUVad+yTkW9Hinu5HEFXXGzEAp9enNR1xptulV1+V8TakRJ/6JFwug3tVReWHCaEbHrVDIJ+awL+jiGhyuwKj1bbsZb2qYXm0RyNw+F53obEUYcs2I21yYJ4sA= To: Olaf Hering , CC: Juergen Gross , Ian Jackson , Wei Liu References: <20210701095635.15648-1-olaf@aepfle.de> <20210701095635.15648-12-olaf@aepfle.de> From: Andrew Cooper Subject: Re: [PATCH v20210701 11/40] tools: use sr_is_known_page_type Message-ID: Date: Fri, 2 Jul 2021 20:27:21 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 In-Reply-To: <20210701095635.15648-12-olaf@aepfle.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-GB X-ClientProxiedBy: LO2P123CA0001.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:a6::13) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6e5a2f8d-4304-4e45-ac05-08d93d8f6e5e X-MS-TrafficTypeDiagnostic: SJ0PR03MB5837: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2657; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Hc2ZoRZ/HdrdkR6YeHUs4ExgYyWzVqbJfhsaoTZt1V0E/RC1O7eGdCtjo2bsKzByEB2975NrnMNYvL8TtwEmhNd4yWdzj8TPq1obIB44k5DApWVkJ3mWW0LYXx8EO4RN2mcCeNCVyy0yijy+fXhCaRxc/IXSUIwE2dhnhgug3XKPT1ex6IphfoDZY0dEqa2jfMHDGCdsW5wVBFk/mOgPYuyLe4y+gm0daQeqDjNFi+GIwq3GQVkfyUDJRBhklIdBwoMb1yeaCd/Ll2TNGOle8K/Bct0Mzl2j7Nm4u+NpT70GKQ0jyFlkczcFmZwt7mskuLQaJM8CRXBOxoL2lkoHtjxqUwRnqMrs+WdyTDwDL/HW0ZXN/BmkBpQpT0ddTiVDoAfd1Y+Aulsm8YxTRLu4Wlu508nTKMSZ/d+uah6bCi7IEr9kgtulSw/1UQbCl0UihR9MZgdNZZLByQz1hXVZOP0KKVPA7j8rG5ZwkwL0L0z57+ccYTUf5e5T8R3zs37rFZgclMR/gSbKtLj2WmKhjVUXTFmpIfPiY+0EfwGl4Inv3dXSn+LVvM3VH+ifdnWxaxJQWEJiZfh5YYqLHa43vy3Z78IVILi561ruOt1mgeO5uNyhsdAv4gZucepex2dxxT0t14WXA+ZQoP3mj8uisJphjuQUvQ2qvVG4Y1ibgssNnQ4aQh5Tdo/qaPloWERyXbtS5wsTbFvudY63FuSvVB8QcuGVEREvGz06BoQOwSYiJxG4NVQxVWllFXisIGuF X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(366004)(136003)(396003)(346002)(39860400002)(36756003)(956004)(31696002)(86362001)(186003)(83380400001)(8676002)(8936002)(2616005)(26005)(31686004)(16526019)(6486002)(54906003)(66946007)(5660300002)(66476007)(316002)(4326008)(16576012)(38100700002)(66556008)(6666004)(4744005)(2906002)(478600001)(53546011)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dDh5ejlSdmVUc0VqVnhMWEZsN2ExVUJiU2RTMlJvRUM2NzhHcjQyTFZRRDdR?= =?utf-8?B?M0V2V2c3Vi9hR0xYNmNheHpOczNpVER4V0tFa0pXRk91d3hoQkdHeGJrZFB0?= =?utf-8?B?UFVsamJFQzFobE5lTDNDdEVhWTEzYVl2Z1Q3QlRvcm5WUE9td2k2andmS2Mw?= =?utf-8?B?R3h0bTl4T0RiU3h5RWNMRTV1dFMzQmJCQXBtaFUvNWJZaHN4UzVkK3VHYlRl?= =?utf-8?B?a1JlVzFYV2QxajZ2Z25GbHlIVjhuQTZ1Z3lkZFlqbWxvQmx6WURCaVVmMGFP?= =?utf-8?B?Y0g4TG9iZngrUzEwZVR0NXNwR3B3RmlKN1FzNEIzUG9xVlNOUHQxK3UvTU5o?= =?utf-8?B?ZnBzRTZZMGhxMkpCK0U5L0J5enVDRmpxVmIzNEdZNktFb1h2bURIT1kvM2F4?= =?utf-8?B?dVJXQ1BzU1dmZU9ydDNDUnVpUDJxZi9tYk9hSkhqQjlvbWRNaEJJbzRiMGRP?= =?utf-8?B?d1FDaEpVeVMveUR6cHEvdStGM1lwbmZCVzVRMEdzNGR0TmRieG5SSHhlS0Ru?= =?utf-8?B?MlVtbDBQdkwzVUpybWUxTE1oZk9xTlJ3aTVuU3FXSnpkSFBmcXJmNUlZQnlY?= =?utf-8?B?MFhidlhEQkF2ejBlNEJud3BKVUhyTG1uS3NlSkx1ZVF2ejc3OGNIRDkrMTlq?= =?utf-8?B?ZnZ5eW8zZzRsMFFwT0NHWDVWNzRhV2RCZEgwcGVtampwa3oxVHc4cUxac0Y1?= =?utf-8?B?UlBhSmo3SnlockZ1cVdDWlc4bFhzQXBBV2ZmREhNQUlhckdIeHR1eGYzY0V3?= =?utf-8?B?TU5ZZXdsT2NxQldiM2FBaFIvWW40OVBzREZsZEpKVXlBWXJYSmdFWDVGYUhC?= =?utf-8?B?aVUrYnlVKzR0SGFVRXN6VFVTKzA4QlRBQkhiMXd6RHBnMEpFTTlxVHMrY2wz?= =?utf-8?B?YU9NUG8xVWdjTHhUd1FNekdrWHVFVEcrTlBNZ1VsbkZpRTRyVVliejcvWjdG?= =?utf-8?B?L3h6dENqK0JiVk5vaFN6ZFZOTllGNnJXKzU1K1pMeGUyRXpTeFpodUpQQnZr?= =?utf-8?B?SVdZVGR5SVR3MGJ0QVBpZHJscGdwRHZENE9NM3RoQVpPTTMvUWIxYXB3QW9U?= =?utf-8?B?dlBPS1VibzZvM0hGT0VOOU1VSzN2OU5JN1JiZlYzRHp1ZUE1VHhoNUxHV1g2?= =?utf-8?B?eTNXUlBPbjlyVXF2T0RDVFYrYnBLb0Fiay9VdG9IZGdkSGtDYTkxdlg3QVdp?= =?utf-8?B?Y0kwQkdjT3dma3FwTkpLWlh5VlFwZmhJdnhib1F5amVxa1lYYWVJNHk4Mmpq?= =?utf-8?B?U0VoaXdxSk9EU29DOWlSenJEdjFVVms0WGlIN01tZ0RvQjc2bndON1d0Mlpl?= =?utf-8?B?RHJUcHkxM3EyS3pzSDdoSWppNVFPMFlKY09TeXdCbWFDaG1HUnlLTDJxTE14?= =?utf-8?B?bUJpMTJtczQ0K1JHQ2tWZ1gvRVpNWjFIci9leEZZLzNzRXUrN2NkRzMvNElt?= =?utf-8?B?VzNUV1VYYS9KY2lCWlhHNDEyN2xFTHgrR1YzZzAyRCtVSS9icUI4RnFwcjZu?= =?utf-8?B?OCs4ZlpKS25BbHJjcG5HbVJsaERBanU3cVZOQk5sQytLSmh3VGwrUnh1WFJO?= =?utf-8?B?cDFkMWwwT21XZU1uOC9yeElsbHhERG83eERTN0lKZEpEZ3pGWStkUFEyN2hJ?= =?utf-8?B?SVBvMjRmSG1lYkFuUWtPV0RDNDhPUkpSTm9zOXMwakJvcysyckdzbHpGYm5h?= =?utf-8?B?MnZJLzNWSWhiK3pnVHVjVWlsakVBU3NXU0dha2YvN0ZvT1BiQ09obmVYZ0N5?= =?utf-8?Q?LQyJUpkIgpemWGb8FiQ4eQ+2brHlUoXdoZIELfj?= X-MS-Exchange-CrossTenant-Network-Message-Id: 6e5a2f8d-4304-4e45-ac05-08d93d8f6e5e X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jul 2021 19:27:29.2860 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kohGHpSfhKy6OGhT3r23R2jExywl1DVkvH/q7OLRq96rygVc7dG+XzC0UWtSH6itzZzjTvinYSBnMVHEhR/+ttg2p9WEazqNmilrgnhRXKA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5837 X-OriginatorOrg: citrix.com On 01/07/2021 10:56, Olaf Hering wrote: > Verify pfn type on sending side, also verify incoming batch of pfns. > > Signed-off-by: Olaf Hering > Reviewed-by: Juergen Gross Any reason this isn't folded into the previous patch, like your subsequent two page type helper patches are? > diff --git a/tools/libs/saverestore/save.c b/tools/libs/saverestore/save.= c > index ae3e8797d0..6f820ea432 100644 > --- a/tools/libs/saverestore/save.c > +++ b/tools/libs/saverestore/save.c > @@ -147,6 +147,12 @@ static int write_batch(struct xc_sr_context *ctx) > =20 > for ( i =3D 0; i < nr_pfns; ++i ) > { > + if ( sr_is_known_page_type(types[i]) =3D=3D false ) > + { > + ERROR("Wrong type %#"PRIpfn" for pfn %#"PRIpfn, types[i], mf= ns[i]); "Unknown type" would be more accurate. ~Andrew From xen-devel-bounces@lists.xenproject.org Fri Jul 02 19:43:32 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Jul 2021 19:43:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149322.276090 (Exim 4.92) (envelope-from ) id 1lzP4Q-0001wk-QJ; Fri, 02 Jul 2021 19:43:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149322.276090; Fri, 02 Jul 2021 19:43:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzP4Q-0001wd-NR; Fri, 02 Jul 2021 19:43:26 +0000 Received: by outflank-mailman (input) for mailman id 149322; Fri, 02 Jul 2021 19:43:24 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzP4O-0001wX-HU for xen-devel@lists.xenproject.org; Fri, 02 Jul 2021 19:43:24 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 1f750bb6-9dc6-43da-9a2a-418389247bea; Fri, 02 Jul 2021 19:43:23 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1f750bb6-9dc6-43da-9a2a-418389247bea DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1625255002; h=to:cc:references:from:subject:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=HY/2zx7JsDsDRDIO7jca5fPF13HZXmGu/pYGKlWarDk=; b=OTM0LFid8mms3YinhnnGu+K9Yy7vDmI88b4injOPrr6Q5g35i3K6bB1b wGFVRCY3wDgiWX9I2/1vqgAQRc4BpSbfOwJP610Ed7skQAihiLNOMH8Wy KuDXUeJLEM2lHwZK6CjhtAIveBl8YCzUK63LgfcbbTVBy5l3eqdtJw5SL w=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: /uMgw+MXHXzfAZzVVxrrweiVstwx+G33gy7ZY9viQjp5y9Nhp4y55Srmzn5Ku0WGN84qA4xvEa GkbGjBL45GUmKEqvfQzKE1Jv2Y44Rfd9asVnlbHNNpKVG7Z435+zyY4w3HZXOLtc63fPc3NxX5 adEhQ2fEkjIdk04OlCtSyk0VsZw+jnrGE3JNouneXs4aeETeX6IadtOzZW65KG35tbZvaqbU7U juDmMCxPtDsuiS3LA2yp4hrNDmJ5C+4bYI2KDhXtLlOrVF38Him1joKQfOoHeT+c8hc+RPOown Nl8= X-SBRS: 5.1 X-MesageID: 47198654 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:JSp1Hah2mG4jYPZ6R3kLjb2ZwXBQXzF13DAbv31ZSRFFG/FwyP rAoB1L73PJYWgqNU3I+ergBEGBKUmskKKdkrNhQotKOzOWxFdATbsSkLcKpgePJ8SQzJ8k6U 4NSdkYNDS0NykBsS+Y2njKLz9D+qj/zEnAv463pB0MPGIaHp2IrT0JbjpzencGNDWubqBJcq Z0iPA3xQZINU5nFfhSURI+Lpn+TpDw5d7bSC9DIyRixBiFjDuu5rK/Ox+E3i0GWzcK5bs562 DKnyHw+63m6piAu1Hh/l6Wy64TtMrqy9NFCsDJos8JKg/0ggLtQIh6QbWNsB08venqwlc3l9 vnpQsmIq1ImjzsV1DwhSGo9xjr0T4o5XOn40Sfm2HfrcvwQy9/I9ZdhKpCGyGpqHYIjZVZ6u ZmzmiZv51YAVfrhyLm/eXFUBlsiw6dvWciq+gOlHZSOLFuKIO5lbZvuX+9La1wWB4TsOscYa 5T5YDnlbdrmGqhHjLkVjIF+q3rYpxbdS32MHTruaSuonNrdT5CvhIlLfck7wA9HaQGOtF5Dt T/Q9BVfY51P7krhIJGda08qJiMeyHwqSylChPaHb2xLtB4B5uKke+u3IkI X-IronPort-AV: E=Sophos;i="5.83,319,1616472000"; d="scan'208";a="47198654" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=W00Z/toL/YgW0tAhVjwDX+ObOdXSiqzHfGIIzUPo6JFYSncPw8znVQPMlBtDpiL1lUhhS4Ipm3P6i1LYiArskxpKMCwCI34ukUEUGevcxjg5hROyyCs3T5BrzDjDKiuk6Z6mLUshbaJewd4wLLuSXDUmx6tCoBc36+GxqTHerbeKXAeiE9Xef5yW83XHV6pLGuUOpVLbIhlWWy7mBJXT17OrU5jTgY6dXdabDw9owIJL8XJZHWZXyjIbrNRSmklL6l7FxNa2NNlYaNpyi5hvugnGkXQNibESRCPiJgTB2YscLdAtL9ReMhhqrC2DexftxMstpH0sUhp9UXWg+u196Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WQm8/LM5DZNPep69o2xTgCMxTO2rUFu6G+DGUi9imyU=; b=ZnnIDGJidU8W4yLPGT9cYTIQMi32QAQUQ5M5S1Ej2jT6v/EHwO7S7LMEGcJfW1d/S5ZXXqEZXpWRgF9rqs/xdOleae0cHICI7HYcW2wd1RA/+nImaVSf/0mT86bw3fb7owIF1QUBsYck9DnRRjFu5icGadJfpGmjruqeQSMacYYTNUv9NN2qFFsK1imLA8BCSEssDPSrjPJlMFNXKKzxKkJy3zkTIbkjlGvRIf7aOW+4bm/tPITo9JmRUgazTH6ovxC+2nWw/xbJ5f0h4X8EsbQlpb/9EkeP0rWTrb27awZqNLqDm9Hfw7g7l6DTCMqlwVQ8t56v2Ekw4S5/dPGdog== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WQm8/LM5DZNPep69o2xTgCMxTO2rUFu6G+DGUi9imyU=; b=ruW8BmgGsRvEBH/BDqZpS0dfqShZZQQuZ8jHw4INtRvaJ52dA6ywyYURMOO8Rv8bue4rRwzCKRqMtG0skI1ue10+gJKcUf0FWxgb2KpcP7gU0QYa3K1rWCYDd1oW0Vg2L2nzKeCE6wEabgznPXPPIIITwLkqXXi9WC7FPXqvCyw= To: Olaf Hering , CC: Ian Jackson , Wei Liu , Juergen Gross References: <20210701095635.15648-1-olaf@aepfle.de> <20210701095635.15648-13-olaf@aepfle.de> From: Andrew Cooper Subject: Re: [PATCH v20210701 12/40] tools: unify type checking for data pfns in migration stream Message-ID: <9db50e05-233b-e279-307d-548fc23d0115@citrix.com> Date: Fri, 2 Jul 2021 20:43:13 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 In-Reply-To: <20210701095635.15648-13-olaf@aepfle.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-GB X-ClientProxiedBy: LO4P123CA0098.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:191::13) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e18f3e4b-8cc5-4cfc-4a88-08d93d91a4ad X-MS-TrafficTypeDiagnostic: BYAPR03MB3942: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8W7sJJuSfv6ny0N+g2nd4Zdaig2Fsk2WfD5IigFQ2ZWBYi613rpbCib150suxs1C4CTQ4ngvMqgHSca71W9e5X6bKJSSiUwTVOOtXPIjRcF8/HTBkM8kTaC3hHZVe4JGoZ2d0EHKl4UfEacJbaad7jF6C5in/DeznZJSrJAfnRzcPnuhDeI5bGcH6bIZbxAU3GTJ86k4nYCAbOdlmCrFUSTNlKbn8uuoJnoPvENSKlBnDSg6B0QaLA/KQef9K20yyzs9AwkisyvCvR8WysIZTdrH65cxVlXP2HPaVis9/p7sDjziDMLrXZm2JGKymji39jKqG1/JdYULPdiYYVYXkIk7s3l7ZX3QO6fRV17CDB04pBlbs8L9xuGs7ym+hyTDR9BFMWdcaXqQU2cQv+waidschGSndYytDWmfEvcuG4vk3ekrft6rAo7VJT7yGW5geuNJM+F196+9E1eQroNEGNuVLoWdV8ws2eLr8aJ75I6Favx0JjCN1OzXSVTww15ZwUlcG7XhgMgZNHF4dbKXC3rURpvNzc+f6EdZ1+AWZTtZ9ieZ/cOSb1icBG2AkdRVN3YdM3x++hwqYFe4hCOYYTuiT2RJTTlffrUeVOP2lgYxM2BEkUOyuVpQsSHvOBE6pQ2Qj48Oc9Nm2S2C2p4qkb+artD/KRcftSJ4t+K4slhy/RNrF7Zvcm2IO0dvwXQ+oLwnedUMTlAw7qYcP5GtRVjUvltc5dhA3Bt70i2UYdtPPKcjI/5dlylxr5qgXO1L X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(376002)(136003)(366004)(39860400002)(396003)(26005)(36756003)(6666004)(5660300002)(478600001)(66946007)(66476007)(66556008)(16576012)(54906003)(316002)(16526019)(2906002)(186003)(8676002)(6486002)(53546011)(86362001)(83380400001)(38100700002)(8936002)(31696002)(31686004)(4326008)(956004)(2616005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UFFFTG1CcW9lL0tQdFVvalVWYVh0Q3doZFBjNmdRcldQQzZzR2U3dSs4Yzgx?= =?utf-8?B?NDdwajNTZ3lDUVNFck9FWUZ5NC91L2ZWTFg2NVA2VklHZzRpOEV1ZnF5d1Zy?= =?utf-8?B?cHdzTzlGSmlrWndsQmNDdWFpVmJZOC94RnBtWlJ6OHJ2a2QvdVFON0dEVkZM?= =?utf-8?B?emp2bll0K2IyMVp2V2x5bmNHYVowclNyT21qUUFJZk12RzdMcnZIVVBpeVVJ?= =?utf-8?B?ZjFjenZIVlZ3NkFqWGdYNzdxMTAyK2VHelJQMWxlWTJISnpWR0NUZ3AwUTF1?= =?utf-8?B?bjRkMEpoTzI3RHZzdGNPeElPeDJrdHJhZkhoTDk0VUMwRm1tRWZINit3RTlY?= =?utf-8?B?WEZoN2tNM2dkQ2xYakV6YXM1UWxxMG8vNzkyaFVZcXNSYk5qdUdsY0pCUnl3?= =?utf-8?B?ZDRWMmZZd0hSNTF6MWFVaXBPVlR6S2J0b3oyRlhmSUtuTk03eXRKSnM4aUxX?= =?utf-8?B?dUEwa21iV0dMTGRxUGZzcXMrNGdxalNWYW5aM2JHYklOdFd6WlB1MUlZSWVQ?= =?utf-8?B?NSs3U1I5TnFNNit1b2ZDcDNucVpjbCtIdU1YTHA2MnNnaXF3eHF3WWlmemRB?= =?utf-8?B?dkZZek5SemNwR1BwdXVwQnRLZkJPc2JwcnNTRlcyRlJCUFovMml3K1B6SGND?= =?utf-8?B?MjdheU5xQkFMTTB0Yi9OTFBMbEVvM0piSUVqRHBLNEI1bk9PaytQNUpUTC96?= =?utf-8?B?U2pPeXFTWWZhSW5VNEl1ZGpSZXErZkxvL0dvdkNxYVhhS3RUYlVZUWdQUnBq?= =?utf-8?B?VExncktaVUxvSnFWZ0tHWkZiMGFKNzVaWElNczc2OUdRMEdwRmR1Q0hxbXZ3?= =?utf-8?B?Mm4zOWcyOGVaVVRqNXAvVlRDbytPVTcrTEVZeVRibUcvTUpSajVhQUxWSEhF?= =?utf-8?B?UW9xVXpaZk91WmhKWHZOV1ZuNk1Ub0lSRVExUnJlUzdrWjZYVTdEcjFLSi8y?= =?utf-8?B?V2V5d1FOcXdCeVIreUx2aVBxSHNWK2RFK0NWNXRycXJsR1VBbVoyeTVNUjJz?= =?utf-8?B?dU9rUFFBOGp4WjN0T0VYMjdyY3VHSTJpWjgwaDArTGU2MG1jS2xDUDhQQzRV?= =?utf-8?B?T2grcTVSdXdjYU9TOUJSZzhiRnNWUXcyTVp3bGgydStYL2wrM0hVQmErS3N3?= =?utf-8?B?emFKQVZoTHhCTlBLbUMxaFAxWkdWRHB1QzZmdDk3T1I5S0haRkF4a0owMlQ0?= =?utf-8?B?YWlxb1hpb1VmcTJFcTJlTHM5c2F0dUV2THZqc3ZzMkZORGJFYkV1T0JMcDcv?= =?utf-8?B?UlJHempQTmJNR0wxUTdEZVl2NU9QRDBxOCtXY0ttTk5wOHZsdWRaRnFOM2Q4?= =?utf-8?B?Q2NkdmQ1YWw2a2x1V3NmSWN5V3NRRVFHb0dFQVRMWXJCbWV6Ymlvdlk4ZWEw?= =?utf-8?B?NmJGUmtER3EyUG8zOHZ3Z0dRK2RTSDBPWTlzY1ZBV2hFSXYzWGpwSlhaZUhZ?= =?utf-8?B?TzlZVHVxNnY3L2lhOU4vWmNHTXgwU1FPRm1SMnpJSVM2enB1UkZ4SGVXR2Nz?= =?utf-8?B?SWtSZG54enZjTkRZSFlrSG5HL2lyMDdxLzRTRGJGbS9uenI4U3VnRmI5bDhC?= =?utf-8?B?cVFUeEhEY1VMK1Vqbm1xd3RiZ1NwcDRCNG8wL3Zwd1FCR1lGTzJVLzlSMFFK?= =?utf-8?B?U3I3dmNZT09ralJvbSttaXVMZTdtbjFIT1NidVdiTjd5R0Y4blVGckJmU1Nl?= =?utf-8?B?QWlPMkpacVB3VTYwN1gzbk5IMGtDbnJsd09FVmRValhLbG9TWmlrQ0ZGL0pL?= =?utf-8?Q?RHywifRPnwiczIedknN5OimZaI5RDMF4ndUJb9U?= X-MS-Exchange-CrossTenant-Network-Message-Id: e18f3e4b-8cc5-4cfc-4a88-08d93d91a4ad X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jul 2021 19:43:19.5956 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: RteaGOXmWeExst11eY0mwr9zVBfnM1xyXsolp9ore1yqFP6CRr3HX5cSQQl+oHEbeBoVgIdSaq2RYLAs+Co1z2LQdEVhgbxdvqtAioO+P/I= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB3942 X-OriginatorOrg: citrix.com On 01/07/2021 10:56, Olaf Hering wrote: > Introduce a helper which decides if a given pfn in the migration > stream is backed by memory. > > This specifically deals with type XEN_DOMCTL_PFINFO_XALLOC, which was > a synthetic toolstack-only type used in Xen 4.2 to 4.5. It indicated a > dirty page on the sending side for which no data will be send in the > initial iteration. > > No change in behavior intended. > > Signed-off-by: Olaf Hering > --- > tools/libs/saverestore/common.h | 17 +++++++++++++++++ > tools/libs/saverestore/restore.c | 5 ++--- > 2 files changed, 19 insertions(+), 3 deletions(-) > > diff --git a/tools/libs/saverestore/common.h b/tools/libs/saverestore/com= mon.h > index 07c506360c..fa242e808d 100644 > --- a/tools/libs/saverestore/common.h > +++ b/tools/libs/saverestore/common.h > @@ -500,6 +500,23 @@ static inline bool sr_is_known_page_type(xen_pfn_t t= ype) > return ret; > } > =20 > +static inline bool page_type_to_populate(uint32_t type) > +{ > + bool ret; > + > + switch (type) > + { Same style comments as before. > + case XEN_DOMCTL_PFINFO_XTAB: > + case XEN_DOMCTL_PFINFO_BROKEN: > + ret =3D false; > + break; > + case XEN_DOMCTL_PFINFO_XALLOC: > + default: > + ret =3D true; > + break; I know you're replacing the logic as-was, but in hindsight, I'm not sure it was great to begin with.=C2=A0 It defaults the unallocated types to bein= g considered populated, which isn't a clever idea. Anyone adding a new page type is going to have to audit/edit each of these helpers.=C2=A0 I think it would be better to write all the true cases explicitly. > + } > + return ret; > +} > #endif > /* > * Local variables: > diff --git a/tools/libs/saverestore/restore.c b/tools/libs/saverestore/re= store.c > index 324b9050e2..477b7527a1 100644 > --- a/tools/libs/saverestore/restore.c > +++ b/tools/libs/saverestore/restore.c > @@ -152,9 +152,8 @@ int populate_pfns(struct xc_sr_context *ctx, unsigned= int count, > =20 > for ( i =3D 0; i < count; ++i ) > { > - if ( (!types || (types && > - (types[i] !=3D XEN_DOMCTL_PFINFO_XTAB && > - types[i] !=3D XEN_DOMCTL_PFINFO_BROKEN))) && > + if ( (!types || > + (types && page_type_to_populate(types[i]) =3D=3D true)) && I'm surprised not to have seen a compiler or static analysis complaint about this. !A || (A && B) is redundant, and simplifies to !A || B. Clearly need to blame whichever numpty wrote this code to begin with. ~Andrew From xen-devel-bounces@lists.xenproject.org Fri Jul 02 19:49:25 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Jul 2021 19:49:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149327.276102 (Exim 4.92) (envelope-from ) id 1lzPAA-0002c8-H9; Fri, 02 Jul 2021 19:49:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149327.276102; Fri, 02 Jul 2021 19:49:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzPAA-0002c1-Ci; Fri, 02 Jul 2021 19:49:22 +0000 Received: by outflank-mailman (input) for mailman id 149327; Fri, 02 Jul 2021 19:49:21 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzPA9-0002bp-1u for xen-devel@lists.xenproject.org; Fri, 02 Jul 2021 19:49:21 +0000 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id f6bfad3a-4bfc-4041-ba76-585be361874c; Fri, 02 Jul 2021 19:49:20 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f6bfad3a-4bfc-4041-ba76-585be361874c DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1625255360; h=to:cc:references:from:subject:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=rgW8C+eifQjwPHLKw03S1HEEEfQoGZN/ty46eG1nTFs=; b=fSQQlGrdRtuBJfpnmnpSCn8a6t8nqbl8mBHf2Q8OZPAe1v9A5Sgd0ZIV tatc7hZijhFKBzEbXKfZjal+/2+slG0Y8LpAWeWoGZeBBfRT8XZKGQYa/ fKWeJZHOmLzUUByJ5cs1yDjuahzB2fQDWyRifh6LXFzLi3Ex+Otx0cB6f A=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: Pu2RNO5O3GfQ+IKxB5dpfof/CEFUGnAJlX8ZsnBjyIkelvLKbbS3odC2nBqAYL43kADqnBWBxj Ph4E/YmoX1cuLUOEAz/GqQSiiq/wyyZsNTnKIXKq2uMDOq/G/ewxxeybk3Nl6Z3U4orW+xs7u4 LXFcEwPZm4uoBV6DE91OnqIwIxf2OZdSZuqrEyQMHbzRaVsUnCdOoHDgyvHkVmgPI66MO+08Dl fPseAJDASZ7eRjiXv9FaP86F9BVQ2r/pdICEQvHlQDqqgaLo/FFGVL04rbZDhasIVYplDBKGhs jik= X-SBRS: 5.1 X-MesageID: 47554560 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:T4Cwj63a8bWsp/GYzP8Y7QqjBV9yeYIsimQD101hICG9Lfb3qy n+ppsmPEHP5Ar5OEtBpTiBUJPwJU80hqQFn7X5Wo3SIzUO2VHYUL2KiLGC/9SOIVyEygcw79 YHT0E6MqyMMbEYt7eJ3ODbKadZ/DDvysnB7o2yvhQdL3AfV0gj1XYfNu/yKDwEeOAsP+tBKH Pz3Lsjm9PtQwVsUiztbUN1L9Qr6ue7267OUFojPVoK+QOOhTSn5PrTFAWZ5A4XV3dqza05+W bIvgTl7uH72svLiyP05iv21dB7idHhwtxMCIiljdUUECzljkKNaJ56U7OPkTgpqKWE6Uoskv PLvxA8Vv4DpU/5TyWQm1/AygPg2DEh5zvJ0lmDm0bupsT/WXYTF9dBrZgxSGqa12MQ+PVHlI 5b1WOQsJRaSTnamj7m2tTOXxZ20mKpvHsZl/IJhXA3a/pcVFZol/1awKppKuZGIMqjg7pXVt WGTfuspMq+SGnqKkww5QJUsYWRth1ZJGbyfqAA0vblmQS+0koJl3fw//Zv6EvowqhNAKWs19 60RZiAq4s+B/P+TZgNSdvpEvHHRlAkf3r3QSqvyAPcZdA60jT22sXK3Ik= X-IronPort-AV: E=Sophos;i="5.83,319,1616472000"; d="scan'208";a="47554560" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=g1TJij7fKF6HiWndX2m0nt5bcF+Vh3JnQlduLBdB1oz9bC1dghIcCUKYvGosUv3OkjZ5ddtfcZQsk0FJUmO8a1BDYx9sBmBTCGOCx+B/sCRB43OFnyHVh2BDi+PwbpfgDesg+l04LxRYvfZS52FMGiI2H783kmVrAYXom3Ym8clh+D3E/wyDr3Kp22fi1bmnipY3pzCcPx2BZ2wKFJ30y/cMVbKhjPTqxfeDSf6HZJcrR7loa/MbfxoEqV19C6EEEuX5R8pS6XBTNij/X54UPhntgpGonz0sELF171+UY+LW6OzNBl3zHp6u6yx6QWc8KOWQr8ZzYKa6Zbb+PMjUhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=i7N68Ya0uhCMnAoSNn5iCyw/Z8cNK+0b8HcO4R8m5OY=; b=PlrTqP6A8mpZ240ZHFAhu9HRJ1pPQzlJ9g8MPebYgP+4FqEXARHq+mXWRux0YXc6PDEEVh+eu5XwD7qtDsff3BnaSXgzpTc4xeZsg1Ha2YcOaXyozHu5bzAIiaUQLRq2ca46itDnWqgIGAdtUiuxfGl7p6Yp7gL515k2NZxqf4vyXa3hyCsaCZl8ZiodS84CNG5ZuxqiY07UhDXtOvwCtOFD879Mmshz29GLbCG+k1E1CJ2XRRBXfIuvy70yCeP5QUkd0VGBMRlXXjDtXT6K32pfw7pkXjzOnSxZKsttF1EO2LshdJ+hc99mdbGzvqXjvnAu2LFYcOZx2AD/HUg8Ag== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=i7N68Ya0uhCMnAoSNn5iCyw/Z8cNK+0b8HcO4R8m5OY=; b=sMQb0CSSObXLe570VqDhfq+/+KMcQZW4qrXu7KcgL4rWtoM3e2J3BguryJElvqExx5ThgpBj69AqT5uux9Y7EUNts/fK6V6lzuUBmFtUn6kyfIi7eBV6ffLA8Ybl2pVCQIanCmGZ1+5JBOxJ2ToNIPTsS9CNQrRFq4HNghCMVo0= To: Olaf Hering , CC: Ian Jackson , Wei Liu , Juergen Gross References: <20210701095635.15648-1-olaf@aepfle.de> <20210701095635.15648-14-olaf@aepfle.de> From: Andrew Cooper Subject: Re: [PATCH v20210701 13/40] tools: unify type checking for data pfns in migration stream Message-ID: Date: Fri, 2 Jul 2021 20:49:09 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 In-Reply-To: <20210701095635.15648-14-olaf@aepfle.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-GB X-ClientProxiedBy: LO2P123CA0054.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1::18) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 861b2a03-5e29-4148-5e8d-08d93d9279c1 X-MS-TrafficTypeDiagnostic: BYAPR03MB3942: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:644; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YJLadaferQiwVYamK8BYiLInt0yRxrv+D+jF5tnjZpjORTM/SV4nqxdmftajLzYDzCvi3P0wDXPWm+V0I730+0zWztBnEarbhMXOJftE2Q25up2oFLLj1LGsqSIX2T73hecnGNiztrfFSNdQy5atrhZg3y20yANfMivBAW1+YAeWZb1fjhyDatX4dQvYuP6VhPTOX4aidXeiEFzTrrWxPstogoAGVUi5+z43wZG9uhsEu8EFTNcoEC7nLbLnHpJDmJPx6iGwA469iuSxWiZcYrrEicP6e10wvvLTgQ25zCWooMYNAyZzUyo/hGCj43N3IxpGhjckM86OPk8Twtbc+h7d1u/NpOzDI+N9jRKWahI8AtkGWHVRlHM+EjZJrens6hBXLOxfz6LQk4ayZQnmMnOHw66qox9z0skN7Mb+aNXlD8GrCaqU1EeRGGmBeQzY7V8yP4yxLtFLwucBPrn/zS3Mh5mkuStlujRxo+rO502FQLBZDs9DcpWteWK4xv/MmP6+tfXAUNbWh8e9BKM+fTwB89h7E/LLtcUmVLZH/Kb5qoSEr842X3a8GeMdVElwzuHKodfCubZ1BTjgYCd3PWTS4zLQys+Q1Cm8WF5UKNpWCRQcOjBv+VgpwvaxrVKzAql2KD4zo/t0ZBXg8Au2FzR8nBXp+PmCI8bq3nvlzSQehGbwajrG5tLRIqfh0ab+1Md5ufIY4SjEZRAMlhnJche5Hopq6KHodk0jSvePGmtX7DF34zV5k8fR2HqnAhFW X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(39860400002)(366004)(136003)(376002)(346002)(31686004)(86362001)(83380400001)(38100700002)(31696002)(8936002)(4326008)(2616005)(956004)(66946007)(66476007)(66556008)(16576012)(26005)(36756003)(478600001)(5660300002)(6666004)(53546011)(4744005)(316002)(54906003)(8676002)(6486002)(16526019)(2906002)(186003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QWs5OGhUNEhtNlMxZDVnZnV2VStnZ2xDOVpBejZHKys2Nzhtd0ZLZTdCMzcv?= =?utf-8?B?WXVoY2hJUW4zN0l1TVBjUlBhZzlkTzlxL01JdEd3cWx3Z3A3TkFjbUxNbmda?= =?utf-8?B?dmczWkE1RHo5djRLb2ZzWEZLd0VZRG9veWlhN0Y0TWtjVjJHYUJhYnlycWpF?= =?utf-8?B?ZEZvQXRPZExmSXd6LzhqRUZlR2k1ajdBRTR3VGdxZ2VKc3pnVzI5czlhSTg5?= =?utf-8?B?N0F4T0JhSnl0RXQwN2tVeXFUN0tOdFlmalVuWUJQZjgwUC8ydjdKR1hxR2xm?= =?utf-8?B?KzI5dFBFaEhlRTBibTF6NjB1SVpLR3NHdkpQSmJwWnAzWU1na1lTK2RSdkY5?= =?utf-8?B?dTZ5bFEzYmY4aDZSVEVyODZIeHZxNG1sQ0Z2VnVINVpjQ3VDTHhtUEFJK0lZ?= =?utf-8?B?OHJsWDdOcW4yNTlnako3WjdMNUZPQkNNbFpDWkxxMk5qUWZmVUhhYWJOTlBI?= =?utf-8?B?ZFNoWEkrTlNod0s5YjdHSUgvWks1NzVxWDA0RndlaU83QWZnTFJSd2dMWi9w?= =?utf-8?B?dElFaVZ0NFJiaVY5VEEzYTBqRFRmWkRPNnVYL2ZKcER0MnU4bk1oK0lCc2w4?= =?utf-8?B?S1gySnZvckVhbUcwU0hvRnJuanlHNlNGM0pDY0hUdWN4bmQ2ZURNSlRqSjlk?= =?utf-8?B?NS9mcGIwMkJ3K3V3YVRKelpDRDROM3dNMC9ZOVhJMjJwYXh0ODJkS0Z2Zmhm?= =?utf-8?B?UnY1MkR4ZmdyaTMrZlRtSUZDR1k1bVpRWVhkUmE4a3lDa0FtbkJHOWNQUEV3?= =?utf-8?B?SWpLSDZyYWd0SnlwMFUyRG9NMzBGVmRweEg1YzBSYyttR0l6WDZqNUJ3WkhZ?= =?utf-8?B?Y3llRnA1cXl5YU1oMFRlSVozYXFJbVI0bzZNWEVwU2Fqem9IRGxhUEI4VVl5?= =?utf-8?B?TnRGTXhUUGVRakVQcHpTalpOSUgxZTJmV2xvWSt6cHE1NTQxUytDRnAzT3NO?= =?utf-8?B?ZWpFZzNEUGo0SG9DbnZXNnJPMUtraGl3TWtqU2Rta1phOE03dk9KN0c0QUM4?= =?utf-8?B?cEViU1NGWHdNeVF3NW9BSEhtVkNmN3BybmowQWgxT0VsWEpsY0RnLytESzZR?= =?utf-8?B?eTAwM3dCT0hhRlFBZDVGY2ExOExjN3pVd3hOMFRmZzBxWDdKc1U1Ym5MdldY?= =?utf-8?B?KyttWVBVSDN2MEhTa1hVeXhGM0ZCSklBYThVTGJMOXpVYVFKdG1mT2tSREg1?= =?utf-8?B?bU54U2daYlcvQnJUaTdPbFVDZnlaTkl3WUFTRmxVN2dmSkRKWW5IdUJ6dGRK?= =?utf-8?B?V0R2U05rNzJ0T3hnQlpsejl5M1kyVENGcTc1ZUdpTWxKTGZOemN1ZmN4bUlh?= =?utf-8?B?Y28zNFpUMXFkOE5IdHNCU29jSkttUjlnaSsyVUt3VFFQcm1YYzNJbnllSU9Q?= =?utf-8?B?aDZSSFFVYjdFNjlhTHhKS0Fsa2l4S2pCSitRWW1MQkZWUXhuUklNUWZ6VitF?= =?utf-8?B?bXVjTzZIVVF6d1ZNZDdvSUhrTjN6VDJZZ2lUVVlDd28vMDI3OENXSGl0SCtF?= =?utf-8?B?WVRuWTFveURuT1Y1dk5YUU1Oc09mSHBkTWU2YzM4eHVGc0RCZGU4dWFxMVlS?= =?utf-8?B?c3dYYTVMRmRBWnVwa1Y3cmpPYWFJODhsOGt4UjFzQkpITE40Ni9DYW5jT3pj?= =?utf-8?B?aTVzY2JhZW5NMGowMlplM2ZjcW1OV0dPSEtjQkluYSthcDJ4Q2VIT2Y2ZjhK?= =?utf-8?B?QmhIQ0ZnK1hEaFU3SlhHN2p0WkpUTkxkNzl0aVFuKzN1a3h4NERTUXdIK1h2?= =?utf-8?Q?ggQDs8wrE7pwBtsYHPSyV2yEQOnV5Av65WMqcHf?= X-MS-Exchange-CrossTenant-Network-Message-Id: 861b2a03-5e29-4148-5e8d-08d93d9279c1 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jul 2021 19:49:16.8780 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jnJyu0vtBs0Fvx5040oIxy18gABPryTzteri4YjULepcZnqSlXtgJIHI+KBdyZfpxoJdyoPMoeyqyJbE6DEIhwqDpqTken1xxW+jUJeIORo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB3942 X-OriginatorOrg: citrix.com On 01/07/2021 10:56, Olaf Hering wrote: > diff --git a/tools/libs/saverestore/common.h b/tools/libs/saverestore/com= mon.h > index fa242e808d..905b4078f6 100644 > --- a/tools/libs/saverestore/common.h > +++ b/tools/libs/saverestore/common.h > @@ -517,6 +517,24 @@ static inline bool page_type_to_populate(uint32_t ty= pe) > } > return ret; > } > + > +static inline bool page_type_has_stream_data(uint32_t type) > +{ > + bool ret; > + > + switch (type) > + { > + case XEN_DOMCTL_PFINFO_BROKEN: > + case XEN_DOMCTL_PFINFO_XALLOC: > + case XEN_DOMCTL_PFINFO_XTAB: > + ret =3D false; > + break; > + default: > + ret =3D true; > + break; As with page_type_to_populate(), we shouldn't really default the unallocated types to having stream data. Subject to this and the other style concerned, Reviewed-by: Andrew Cooper I'm happy to fix up all the issue for the page type helpers on commit, if you're happy. ~Andrew From xen-devel-bounces@lists.xenproject.org Fri Jul 02 20:22:11 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Jul 2021 20:22:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149332.276112 (Exim 4.92) (envelope-from ) id 1lzPff-0006Ta-33; Fri, 02 Jul 2021 20:21:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149332.276112; Fri, 02 Jul 2021 20:21:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzPff-0006TT-01; Fri, 02 Jul 2021 20:21:55 +0000 Received: by outflank-mailman (input) for mailman id 149332; Fri, 02 Jul 2021 20:21:53 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzPfd-0006TN-B2 for xen-devel@lists.xenproject.org; Fri, 02 Jul 2021 20:21:53 +0000 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 85a8db1a-5c85-477b-8308-ad06038d411d; Fri, 02 Jul 2021 20:21:52 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id C20356135C; Fri, 2 Jul 2021 20:21:51 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 85a8db1a-5c85-477b-8308-ad06038d411d DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1625257312; bh=3+1YcGhflKHl8OpcsTPtGA8KDvz83imejjTVs+ylYh0=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=Y0Kch2H7zr5Ri4/kM40qBxllmmjbe6wpcRRiVUXYPDIk3pjErcYgP/RdLXvbPSlOe IyC753h8MhHdNVEVIeJeZP7PugY+SQMb+wEiCD8WY8Fal/ACu81aCFwk+3XaKV2hLt ZDPXqH3hf7nJWIrK5oVudVB9P/BME/iPoOPJq6w7IJScej9DUqWHPworbjH1T5PBsd tR/201Fs7xBu6Cl4Cun795ZVhZDMXonsOh2RVBp09nKTz7hj0+DHVTo63wePSCGSDk jN19uhXKfizBui+Oo8L1Bt+TxuRTqAksb+/4xYepZT8SOgacJEKcNOGow98XBVxsNX 8skinA0SbvqYg== Date: Fri, 2 Jul 2021 13:21:51 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Luca Fancellu cc: Stefano Stabellini , xen-devel@lists.xenproject.org, Bertrand Marquis , wei.chen@arm.com, Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Julien Grall , Wei Liu Subject: Re: [PATCH v6 9/9] docs/doxygen: doxygen documentation for grant_table.h In-Reply-To: <4E85233D-5371-4862-A0A5-2B653C677D54@arm.com> Message-ID: References: <20210510084105.17108-1-luca.fancellu@arm.com> <20210510084105.17108-10-luca.fancellu@arm.com> <31171081-1007-4B4E-91CC-25EA1041EB58@arm.com> <4E85233D-5371-4862-A0A5-2B653C677D54@arm.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-961216169-1625257312=:9437" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-961216169-1625257312=:9437 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Fri, 2 Jul 2021, Luca Fancellu wrote: > > On 1 Jul 2021, at 18:44, Stefano Stabellini wrote: > > > > On Thu, 1 Jul 2021, Luca Fancellu wrote: > >> Hi Stefano, > >> > >>> On 24 Jun 2021, at 00:34, Stefano Stabellini wrote: > >>> > >>> On Mon, 10 May 2021, Luca Fancellu wrote: > >>>> Modification to include/public/grant_table.h: > >>>> > >>>> 1) Add doxygen tags to: > >>>> - Create Grant tables section > >>>> - include variables in the generated documentation > >>>> - Used @keepindent/@endkeepindent to enclose comment > >>>> section that are indented using spaces, to keep > >>>> the indentation. > >>>> 2) Add .rst file for grant table for Arm64 > >>> > >>> Why only arm64? > >> > >> This is a mistake, it should be just “Add .rst file for grant table" > >> > >>> > >>> > >>>> Signed-off-by: Luca Fancellu > >>>> --- > >>>> v6 changes: > >>>> - Fix misaligned comment > >>>> - Moved comments to make them display in the docs > >>>> - Included more documentation in the docs > >>>> (see output here: https://luca.fancellu.gitlab.io/xen-docs/hypercall-interfaces/common/grant_tables.html) > >>> > >>> It looks much much better. All the info we care about seems to be there. > >>> The only things that I noticed missing and might be good to keep is the > >>> small comment about HYPERVISOR_grant_table_op: > >>> > >>> /* ` enum neg_errnoval > >>> * ` HYPERVISOR_grant_table_op(enum grant_table_op cmd, > >>> * ` void *args, > >>> * ` unsigned int count) > >>> * ` > >>> * > >>> * @args points to an array of a per-command data structure. The array > >>> * has @count members > >> > >> Where do you want me to put this comment in the html page? In the end of the description in the top of the page? > > > > Yeah, that looks like a good place > > Great, for a preview, have a look on this: https://luca.fancellu.gitlab.io/xen-docs/hypercall-interfaces/common/grant_tables.html Looks good! --8323329-961216169-1625257312=:9437-- From xen-devel-bounces@lists.xenproject.org Fri Jul 02 20:56:08 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Jul 2021 20:56:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149338.276123 (Exim 4.92) (envelope-from ) id 1lzQCd-00019y-QK; Fri, 02 Jul 2021 20:55:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149338.276123; Fri, 02 Jul 2021 20:55:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzQCd-00019r-NB; Fri, 02 Jul 2021 20:55:59 +0000 Received: by outflank-mailman (input) for mailman id 149338; Fri, 02 Jul 2021 20:55:58 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzQCc-00019h-LY; Fri, 02 Jul 2021 20:55:58 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzQCc-0001Ew-DT; Fri, 02 Jul 2021 20:55:58 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzQCc-0000Eb-4Z; Fri, 02 Jul 2021 20:55:58 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lzQCc-0005pG-45; Fri, 02 Jul 2021 20:55:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=c59bnYu/bzOBS0V0n6q3LIARBQUeUknpTp+nOsjO+lE=; b=1FdWPl0TVxNHHKnoqJ4wsHxkXA 4iicJ1MPWMUbaM5p6/gi6L8VM4E6EuP+NRzL4PGkD/m1ZWdRIES3h+J3BrVrtEqBTzwcNUVRIaIGa +ClazDdUvVNmjCaHQReGbwGuS8x2MUqnbV9ez87+dvFZ8HJJ5aIQFQtCBZeWnq4sN1aE=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 163230: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=74d044d51b19bb697eac5c3deafa140f6afafec8 X-Osstest-Versions-That: xen=3bc3be978fd61f8099797864136c5f447c0e4aae From: osstest service owner Date: Fri, 02 Jul 2021 20:55:58 +0000 flight 163230 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/163230/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 74d044d51b19bb697eac5c3deafa140f6afafec8 baseline version: xen 3bc3be978fd61f8099797864136c5f447c0e4aae Last test of basis 163225 2021-07-02 15:01:35 Z 0 days Testing same since 163230 2021-07-02 18:01:38 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Olaf Hering jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 3bc3be978f..74d044d51b 74d044d51b19bb697eac5c3deafa140f6afafec8 -> smoke From xen-devel-bounces@lists.xenproject.org Fri Jul 02 22:23:08 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Jul 2021 22:23:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149351.276149 (Exim 4.92) (envelope-from ) id 1lzRYr-00017g-Ng; Fri, 02 Jul 2021 22:23:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149351.276149; Fri, 02 Jul 2021 22:23:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzRYr-00017X-KC; Fri, 02 Jul 2021 22:23:01 +0000 Received: by outflank-mailman (input) for mailman id 149351; Fri, 02 Jul 2021 22:22:59 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzRYp-00016l-RJ for xen-devel@lists.xenproject.org; Fri, 02 Jul 2021 22:22:59 +0000 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 0e08e4da-db84-11eb-83c9-12813bfff9fa; Fri, 02 Jul 2021 22:22:58 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id CDEB2613D8; Fri, 2 Jul 2021 22:22:57 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0e08e4da-db84-11eb-83c9-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1625264578; bh=Fy+lh0gdDpIUJ31/KI+4mZyM1dnS4gMtNFLuAyMxMmw=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=Kh1lN74M1X59uKKPgGFrOx3YV4nt3Bdy9y9MFmMdAhJ7xYJoBVwh+NkbOq0ruAaaA XuNQ+W2G1VwTObfay7JKaPkaKL4b7YlJXVoNISLIJp3O5zVvuhPrwmk2YgGsX7XIf4 y3F5TiFodCHV5DwUg3M2waV6Gln4RXBCjncpRJMeRc4kiivcAUq5PVi6l/qxUTAs7A HTrLXuZGJ8UCi9ZfzJHMSvUnvW4Trn9Il68cXhx2B07TqZrFUAM6iPqVIt9K7jjjm+ CBD0uO7DAKBZjyb5fs1jOhyoiMKZjFFKk31fPY7L1lnC1prsixQILhkqOz/wfX+m3c ynGvPBNpp7kTg== Date: Fri, 2 Jul 2021 15:22:57 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Luca Fancellu cc: xen-devel@lists.xenproject.org, bertrand.marquis@arm.com, wei.chen@arm.com, Ian Jackson , Wei Liu Subject: Re: [PATCH v6 4/9] m4/python: add function to docs_tool.m4 and new m4 module In-Reply-To: <20210510084105.17108-5-luca.fancellu@arm.com> Message-ID: References: <20210510084105.17108-1-luca.fancellu@arm.com> <20210510084105.17108-5-luca.fancellu@arm.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Mon, 10 May 2021, Luca Fancellu wrote: > Add ax_python_module.m4 to have a way to check if > a python module is installed in the system. > > Add a function to docs_tool.m4 to throw an error if the > required docs tool is missing. > > Signed-off-by: Luca Fancellu Acked-by: Stefano Stabellini > --- > m4/ax_python_module.m4 | 56 ++++++++++++++++++++++++++++++++++++++++++ > m4/docs_tool.m4 | 9 +++++++ > 2 files changed, 65 insertions(+) > create mode 100644 m4/ax_python_module.m4 > > diff --git a/m4/ax_python_module.m4 b/m4/ax_python_module.m4 > new file mode 100644 > index 0000000000..107d88264a > --- /dev/null > +++ b/m4/ax_python_module.m4 > @@ -0,0 +1,56 @@ > +# =========================================================================== > +# https://www.gnu.org/software/autoconf-archive/ax_python_module.html > +# =========================================================================== > +# > +# SYNOPSIS > +# > +# AX_PYTHON_MODULE(modname[, fatal, python]) > +# > +# DESCRIPTION > +# > +# Checks for Python module. > +# > +# If fatal is non-empty then absence of a module will trigger an error. > +# The third parameter can either be "python" for Python 2 or "python3" for > +# Python 3; defaults to Python 3. > +# > +# LICENSE > +# > +# Copyright (c) 2008 Andrew Collier > +# > +# Copying and distribution of this file, with or without modification, are > +# permitted in any medium without royalty provided the copyright notice > +# and this notice are preserved. This file is offered as-is, without any > +# warranty. > + > +#serial 9 > + > +AU_ALIAS([AC_PYTHON_MODULE], [AX_PYTHON_MODULE]) > +AC_DEFUN([AX_PYTHON_MODULE],[ > + if test -z $PYTHON; > + then > + if test -z "$3"; > + then > + PYTHON="python3" > + else > + PYTHON="$3" > + fi > + fi > + PYTHON_NAME=`basename $PYTHON` > + AC_MSG_CHECKING($PYTHON_NAME module: $1) > + $PYTHON -c "import $1" 2>/dev/null > + if test $? -eq 0; > + then > + AC_MSG_RESULT(yes) > + eval AS_TR_CPP(HAVE_PYMOD_$1)=yes > + else > + AC_MSG_RESULT(no) > + eval AS_TR_CPP(HAVE_PYMOD_$1)=no > + # > + if test -n "$2" > + then > + AC_MSG_ERROR(failed to find required module $1) > + exit 1 > + fi > + fi > +]) > \ No newline at end of file > diff --git a/m4/docs_tool.m4 b/m4/docs_tool.m4 > index 3e8814ac8d..39aa348026 100644 > --- a/m4/docs_tool.m4 > +++ b/m4/docs_tool.m4 > @@ -15,3 +15,12 @@ dnl > AC_MSG_WARN([$2 is not available so some documentation won't be built]) > ]) > ]) > + > +AC_DEFUN([AX_DOCS_TOOL_REQ_PROG], [ > +dnl > + AC_ARG_VAR([$1], [Path to $2 tool]) > + AC_PATH_PROG([$1], [$2]) > + AS_IF([! test -x "$ac_cv_path_$1"], [ > + AC_MSG_ERROR([$2 is needed]) > + ]) > +]) > \ No newline at end of file > -- > 2.17.1 > > From xen-devel-bounces@lists.xenproject.org Fri Jul 02 22:23:08 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Jul 2021 22:23:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149350.276138 (Exim 4.92) (envelope-from ) id 1lzRYl-0000qP-Fg; Fri, 02 Jul 2021 22:22:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149350.276138; Fri, 02 Jul 2021 22:22:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzRYl-0000qI-CV; Fri, 02 Jul 2021 22:22:55 +0000 Received: by outflank-mailman (input) for mailman id 149350; Fri, 02 Jul 2021 22:22:54 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzRYk-0000q8-Ah for xen-devel@lists.xenproject.org; Fri, 02 Jul 2021 22:22:54 +0000 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 80df7d79-ec09-4269-aa45-50be355b2d5a; Fri, 02 Jul 2021 22:22:53 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 5B51D61405; Fri, 2 Jul 2021 22:22:52 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 80df7d79-ec09-4269-aa45-50be355b2d5a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1625264572; bh=Iqikf0GglF2rjBlBCK0w5hpWr/YpU8lp+Uws8c+boYk=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=HJm0//bOy6goiu9XQ7lonVgUlGlRzOWGpffun0TVuoG2xI/XSIbtiZsyKQ+Xa4d0B 5+QM6JkxnaVt0+I2CKIRhdK7r9HL1I7QjFUcVSE/1GTKm0LlAED08iKpYGwpSk6pnC vH8/N3PQndhw2mXJpb2hJVFyizG3EyEWcqNS0Txx72D4vbZhlIwOhNkdA3nig7QXtV n9jJUWLwcnBXHncNCFtLpE7zRsRnzag5I0tDuYB6kyg8TLuvoyKQ9l7ROpJf3RQO28 1perlfYzM7rn68V3KpBcVEs3uT5SRL7orG0ZG7H6MJYXmsrq8251hhsU7pIJ2jLb5o tOc+skz85q0+w== Date: Fri, 2 Jul 2021 15:22:51 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Luca Fancellu cc: xen-devel@lists.xenproject.org, bertrand.marquis@arm.com, wei.chen@arm.com, Ian Jackson , Wei Liu Subject: Re: [PATCH v6 5/9] docs: add checks to configure for sphinx and doxygen In-Reply-To: <20210510084105.17108-6-luca.fancellu@arm.com> Message-ID: References: <20210510084105.17108-1-luca.fancellu@arm.com> <20210510084105.17108-6-luca.fancellu@arm.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Mon, 10 May 2021, Luca Fancellu wrote: > Add checks in the configure files to see if the system > is capable of generate the sphinx html docs using ^ of generating > doxygen and sphinx-breathe tools. I take you updated the configure script but running autoconf again, right? Assuming that is the case: Acked-by: Stefano Stabellini > Signed-off-by: Luca Fancellu > --- > config/Docs.mk.in | 2 + > docs/configure | 258 ++++++++++++++++++++++++++++++++++++++++++++++ > docs/configure.ac | 15 +++ > 3 files changed, 275 insertions(+) > > diff --git a/config/Docs.mk.in b/config/Docs.mk.in > index e76e5cd5ff..dfd4a02838 100644 > --- a/config/Docs.mk.in > +++ b/config/Docs.mk.in > @@ -7,3 +7,5 @@ POD2HTML := @POD2HTML@ > POD2TEXT := @POD2TEXT@ > PANDOC := @PANDOC@ > PERL := @PERL@ > +SPHINXBUILD := @SPHINXBUILD@ > +DOXYGEN := @DOXYGEN@ > diff --git a/docs/configure b/docs/configure > index 569bd4c2ff..0ebf046a79 100755 > --- a/docs/configure > +++ b/docs/configure > @@ -588,6 +588,8 @@ ac_unique_file="misc/xen-command-line.pandoc" > ac_subst_vars='LTLIBOBJS > LIBOBJS > PERL > +DOXYGEN > +SPHINXBUILD > PANDOC > POD2TEXT > POD2HTML > @@ -673,6 +675,7 @@ POD2MAN > POD2HTML > POD2TEXT > PANDOC > +DOXYGEN > PERL' > > > @@ -1318,6 +1321,7 @@ Some influential environment variables: > POD2HTML Path to pod2html tool > POD2TEXT Path to pod2text tool > PANDOC Path to pandoc tool > + DOXYGEN Path to doxygen tool > PERL Path to Perl parser > > Use these variables to override the choices made by `configure' or to help > @@ -1800,6 +1804,7 @@ ac_configure="$SHELL $ac_aux_dir/configure" # Please don't use this var. > > > > + > case "$host_os" in > *freebsd*) XENSTORED_KVA=/dev/xen/xenstored ;; > *) XENSTORED_KVA=/proc/xen/xsd_kva ;; > @@ -1812,6 +1817,53 @@ case "$host_os" in > esac > > > +# =========================================================================== > +# https://www.gnu.org/software/autoconf-archive/ax_python_module.html > +# =========================================================================== > +# > +# SYNOPSIS > +# > +# AX_PYTHON_MODULE(modname[, fatal, python]) > +# > +# DESCRIPTION > +# > +# Checks for Python module. > +# > +# If fatal is non-empty then absence of a module will trigger an error. > +# The third parameter can either be "python" for Python 2 or "python3" for > +# Python 3; defaults to Python 3. > +# > +# LICENSE > +# > +# Copyright (c) 2008 Andrew Collier > +# > +# Copying and distribution of this file, with or without modification, are > +# permitted in any medium without royalty provided the copyright notice > +# and this notice are preserved. This file is offered as-is, without any > +# warranty. > + > +#serial 9 > + > +# This is what autoupdate's m4 run will expand. It fires > +# the warning (with _au_warn_XXX), outputs it into the > +# updated configure.ac (with AC_DIAGNOSE), and then outputs > +# the replacement expansion. > + > + > +# This is an auxiliary macro that is also run when > +# autoupdate runs m4. It simply calls m4_warning, but > +# we need a wrapper so that each warning is emitted only > +# once. We break the quoting in m4_warning's argument in > +# order to expand this macro's arguments, not AU_DEFUN's. > + > + > +# Finally, this is the expansion that is picked up by > +# autoconf. It tells the user to run autoupdate, and > +# then outputs the replacement expansion. We do not care > +# about autoupdate's warning because that contains > +# information on what to do *after* running autoupdate. > > > test "x$prefix" = "xNONE" && prefix=$ac_default_prefix > @@ -2232,6 +2284,212 @@ $as_echo "$as_me: WARNING: pandoc is not available so some documentation won't b > fi > > > +# If sphinx is installed, make sure to have also the dependencies to build > +# Sphinx documentation. > +for ac_prog in sphinx-build > +do > + # Extract the first word of "$ac_prog", so it can be a program name with args. > +set dummy $ac_prog; ac_word=$2 > +{ $as_echo "$as_me:${as_lineno-$LINENO}: checking for $ac_word" >&5 > +$as_echo_n "checking for $ac_word... " >&6; } > +if ${ac_cv_prog_SPHINXBUILD+:} false; then : > + $as_echo_n "(cached) " >&6 > +else > + if test -n "$SPHINXBUILD"; then > + ac_cv_prog_SPHINXBUILD="$SPHINXBUILD" # Let the user override the test. > +else > +as_save_IFS=$IFS; IFS=$PATH_SEPARATOR > +for as_dir in $PATH > +do > + IFS=$as_save_IFS > + test -z "$as_dir" && as_dir=. > + for ac_exec_ext in '' $ac_executable_extensions; do > + if as_fn_executable_p "$as_dir/$ac_word$ac_exec_ext"; then > + ac_cv_prog_SPHINXBUILD="$ac_prog" > + $as_echo "$as_me:${as_lineno-$LINENO}: found $as_dir/$ac_word$ac_exec_ext" >&5 > + break 2 > + fi > +done > + done > +IFS=$as_save_IFS > + > +fi > +fi > +SPHINXBUILD=$ac_cv_prog_SPHINXBUILD > +if test -n "$SPHINXBUILD"; then > + { $as_echo "$as_me:${as_lineno-$LINENO}: result: $SPHINXBUILD" >&5 > +$as_echo "$SPHINXBUILD" >&6; } > +else > + { $as_echo "$as_me:${as_lineno-$LINENO}: result: no" >&5 > +$as_echo "no" >&6; } > +fi > + > + > + test -n "$SPHINXBUILD" && break > +done > +test -n "$SPHINXBUILD" || SPHINXBUILD="no" > + > + if test "x$SPHINXBUILD" = xno; then : > + { $as_echo "$as_me:${as_lineno-$LINENO}: WARNING: sphinx-build is not available so sphinx documentation \ > +won't be built" >&5 > +$as_echo "$as_me: WARNING: sphinx-build is not available so sphinx documentation \ > +won't be built" >&2;} > +else > + > + # Extract the first word of "sphinx-build", so it can be a program name with args. > +set dummy sphinx-build; ac_word=$2 > +{ $as_echo "$as_me:${as_lineno-$LINENO}: checking for $ac_word" >&5 > +$as_echo_n "checking for $ac_word... " >&6; } > +if ${ac_cv_path_SPHINXBUILD+:} false; then : > + $as_echo_n "(cached) " >&6 > +else > + case $SPHINXBUILD in > + [\\/]* | ?:[\\/]*) > + ac_cv_path_SPHINXBUILD="$SPHINXBUILD" # Let the user override the test with a path. > + ;; > + *) > + as_save_IFS=$IFS; IFS=$PATH_SEPARATOR > +for as_dir in $PATH > +do > + IFS=$as_save_IFS > + test -z "$as_dir" && as_dir=. > + for ac_exec_ext in '' $ac_executable_extensions; do > + if as_fn_executable_p "$as_dir/$ac_word$ac_exec_ext"; then > + ac_cv_path_SPHINXBUILD="$as_dir/$ac_word$ac_exec_ext" > + $as_echo "$as_me:${as_lineno-$LINENO}: found $as_dir/$ac_word$ac_exec_ext" >&5 > + break 2 > + fi > +done > + done > +IFS=$as_save_IFS > + > + ;; > +esac > +fi > +SPHINXBUILD=$ac_cv_path_SPHINXBUILD > +if test -n "$SPHINXBUILD"; then > + { $as_echo "$as_me:${as_lineno-$LINENO}: result: $SPHINXBUILD" >&5 > +$as_echo "$SPHINXBUILD" >&6; } > +else > + { $as_echo "$as_me:${as_lineno-$LINENO}: result: no" >&5 > +$as_echo "no" >&6; } > +fi > + > + > + > + > + # Extract the first word of "doxygen", so it can be a program name with args. > +set dummy doxygen; ac_word=$2 > +{ $as_echo "$as_me:${as_lineno-$LINENO}: checking for $ac_word" >&5 > +$as_echo_n "checking for $ac_word... " >&6; } > +if ${ac_cv_path_DOXYGEN+:} false; then : > + $as_echo_n "(cached) " >&6 > +else > + case $DOXYGEN in > + [\\/]* | ?:[\\/]*) > + ac_cv_path_DOXYGEN="$DOXYGEN" # Let the user override the test with a path. > + ;; > + *) > + as_save_IFS=$IFS; IFS=$PATH_SEPARATOR > +for as_dir in $PATH > +do > + IFS=$as_save_IFS > + test -z "$as_dir" && as_dir=. > + for ac_exec_ext in '' $ac_executable_extensions; do > + if as_fn_executable_p "$as_dir/$ac_word$ac_exec_ext"; then > + ac_cv_path_DOXYGEN="$as_dir/$ac_word$ac_exec_ext" > + $as_echo "$as_me:${as_lineno-$LINENO}: found $as_dir/$ac_word$ac_exec_ext" >&5 > + break 2 > + fi > +done > + done > +IFS=$as_save_IFS > + > + ;; > +esac > +fi > +DOXYGEN=$ac_cv_path_DOXYGEN > +if test -n "$DOXYGEN"; then > + { $as_echo "$as_me:${as_lineno-$LINENO}: result: $DOXYGEN" >&5 > +$as_echo "$DOXYGEN" >&6; } > +else > + { $as_echo "$as_me:${as_lineno-$LINENO}: result: no" >&5 > +$as_echo "no" >&6; } > +fi > + > + > + if ! test -x "$ac_cv_path_DOXYGEN"; then : > + > + as_fn_error $? "doxygen is needed" "$LINENO" 5 > + > +fi > + > + > + if test -z $PYTHON; > + then > + if test -z ""; > + then > + PYTHON="python3" > + else > + PYTHON="" > + fi > + fi > + PYTHON_NAME=`basename $PYTHON` > + { $as_echo "$as_me:${as_lineno-$LINENO}: checking $PYTHON_NAME module: breathe" >&5 > +$as_echo_n "checking $PYTHON_NAME module: breathe... " >&6; } > + $PYTHON -c "import breathe" 2>/dev/null > + if test $? -eq 0; > + then > + { $as_echo "$as_me:${as_lineno-$LINENO}: result: yes" >&5 > +$as_echo "yes" >&6; } > + eval HAVE_PYMOD_BREATHE=yes > + else > + { $as_echo "$as_me:${as_lineno-$LINENO}: result: no" >&5 > +$as_echo "no" >&6; } > + eval HAVE_PYMOD_BREATHE=no > + # > + if test -n "yes" > + then > + as_fn_error $? "failed to find required module breathe" "$LINENO" 5 > + exit 1 > + fi > + fi > + > + > + if test -z $PYTHON; > + then > + if test -z ""; > + then > + PYTHON="python3" > + else > + PYTHON="" > + fi > + fi > + PYTHON_NAME=`basename $PYTHON` > + { $as_echo "$as_me:${as_lineno-$LINENO}: checking $PYTHON_NAME module: sphinx_rtd_theme" >&5 > +$as_echo_n "checking $PYTHON_NAME module: sphinx_rtd_theme... " >&6; } > + $PYTHON -c "import sphinx_rtd_theme" 2>/dev/null > + if test $? -eq 0; > + then > + { $as_echo "$as_me:${as_lineno-$LINENO}: result: yes" >&5 > +$as_echo "yes" >&6; } > + eval HAVE_PYMOD_SPHINX_RTD_THEME=yes > + else > + { $as_echo "$as_me:${as_lineno-$LINENO}: result: no" >&5 > +$as_echo "no" >&6; } > + eval HAVE_PYMOD_SPHINX_RTD_THEME=no > + # > + if test -n "yes" > + then > + as_fn_error $? "failed to find required module sphinx_rtd_theme" "$LINENO" 5 > + exit 1 > + fi > + fi > + > + > + > +fi > + > > # Extract the first word of "perl", so it can be a program name with args. > set dummy perl; ac_word=$2 > diff --git a/docs/configure.ac b/docs/configure.ac > index c2e5edd3b3..a2ff55f30a 100644 > --- a/docs/configure.ac > +++ b/docs/configure.ac > @@ -20,6 +20,7 @@ m4_include([../m4/docs_tool.m4]) > m4_include([../m4/path_or_fail.m4]) > m4_include([../m4/features.m4]) > m4_include([../m4/paths.m4]) > +m4_include([../m4/ax_python_module.m4]) > > AX_XEN_EXPAND_CONFIG() > > @@ -29,6 +30,20 @@ AX_DOCS_TOOL_PROG([POD2HTML], [pod2html]) > AX_DOCS_TOOL_PROG([POD2TEXT], [pod2text]) > AX_DOCS_TOOL_PROG([PANDOC], [pandoc]) > > +# If sphinx is installed, make sure to have also the dependencies to build > +# Sphinx documentation. > +AC_CHECK_PROGS([SPHINXBUILD], [sphinx-build], [no]) > + AS_IF([test "x$SPHINXBUILD" = xno], > + [AC_MSG_WARN(sphinx-build is not available so sphinx documentation \ > +won't be built)], > + [ > + AC_PATH_PROG([SPHINXBUILD], [sphinx-build]) > + AX_DOCS_TOOL_REQ_PROG([DOXYGEN], [doxygen]) > + AX_PYTHON_MODULE([breathe],[yes]) > + AX_PYTHON_MODULE([sphinx_rtd_theme], [yes]) > + ] > + ) > + > AC_ARG_VAR([PERL], [Path to Perl parser]) > AX_PATH_PROG_OR_FAIL([PERL], [perl]) From xen-devel-bounces@lists.xenproject.org Fri Jul 02 22:23:12 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Jul 2021 22:23:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149354.276160 (Exim 4.92) (envelope-from ) id 1lzRZ2-0001XW-02; Fri, 02 Jul 2021 22:23:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149354.276160; Fri, 02 Jul 2021 22:23:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzRZ1-0001XN-So; Fri, 02 Jul 2021 22:23:11 +0000 Received: by outflank-mailman (input) for mailman id 149354; Fri, 02 Jul 2021 22:23:10 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzRYz-0001TB-UK for xen-devel@lists.xenproject.org; Fri, 02 Jul 2021 22:23:09 +0000 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 142bdc0a-db84-11eb-83c9-12813bfff9fa; Fri, 02 Jul 2021 22:23:08 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id F1AD5613D8; Fri, 2 Jul 2021 22:23:07 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 142bdc0a-db84-11eb-83c9-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1625264588; bh=zQNj7JPmp8LSW80+gBSqlEodeUICaVTJJkxXZfv6L2I=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=BirKJ1REFub07HLbB102mTrRvf8LWj3y34qKXKdfeNv4zLO3NJtweDeDVYvBVWlRV fpoOzRlon/BvfeSwbTKQu3v9Ko5/uajP43/awOp4pMtVDkhRettlJqudcCSkrOaZmY rMCDfY2enO3AkhqoKi66jH61G+PfkLZrtfvSAvmAXvxNGiu7ioCwvNlMnxY7L/YIIN jimb94yZV4k75ZjwtsrbYm6C5BdPrltfCp4yHQNAzz14gps9wLOrPHCtl3DGQQLyE/ KV2iXxdhujkkaJ7V4UJYqRnA4ZvoyQLvoLgraiIA3XH1bPm93Ddccx8LhCP5c0CBbq XYjoY9WHI21iQ== Date: Fri, 2 Jul 2021 15:23:07 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Luca Fancellu cc: Stefano Stabellini , xen-devel@lists.xenproject.org, Bertrand Marquis , wei.chen@arm.com, Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Julien Grall , Wei Liu Subject: Re: [PATCH v6 7/9] docs: Change Makefile and sphinx configuration for doxygen In-Reply-To: <7C3269F1-3C61-4F39-82F9-9DE4C563849B@arm.com> Message-ID: References: <20210510084105.17108-1-luca.fancellu@arm.com> <20210510084105.17108-8-luca.fancellu@arm.com> <1FC1E8DF-8AED-4ABD-BE9A-DBBD9D66EDBB@arm.com> <7C3269F1-3C61-4F39-82F9-9DE4C563849B@arm.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="8323329-766106159-1625257521=:9437" Content-ID: This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-766106159-1625257521=:9437 Content-Type: text/plain; CHARSET=UTF-8 Content-Transfer-Encoding: 8BIT Content-ID: On Fri, 2 Jul 2021, Luca Fancellu wrote: > > On 1 Jul 2021, at 18:43, Stefano Stabellini wrote: > > > > On Thu, 1 Jul 2021, Luca Fancellu wrote: > >>> On 24 Jun 2021, at 00:33, Stefano Stabellini wrote: > >>> > >>> On Mon, 10 May 2021, Luca Fancellu wrote: > >>>> Modify docs/Makefile to call doxygen and generate sphinx > >>>> html documentation given the doxygen XML output. > >>>> > >>>> Modify docs/conf.py sphinx configuration file to setup > >>>> the breathe extension that works as bridge between > >>>> sphinx and doxygen. > >>>> > >>>> Add some files to the .gitignore to ignore some > >>>> generated files for doxygen. > >>>> > >>>> Signed-off-by: Luca Fancellu > >>>> --- > >>>> .gitignore | 6 ++++++ > >>>> docs/Makefile | 42 +++++++++++++++++++++++++++++++++++++++--- > >>>> docs/conf.py | 48 +++++++++++++++++++++++++++++++++++++++++++++--- > >>>> 3 files changed, 90 insertions(+), 6 deletions(-) > >>>> > >>>> diff --git a/.gitignore b/.gitignore > >>>> index 1c2fa1530b..d271e0ce6a 100644 > >>>> --- a/.gitignore > >>>> +++ b/.gitignore > >>>> @@ -58,6 +58,12 @@ docs/man7/ > >>>> docs/man8/ > >>>> docs/pdf/ > >>>> docs/txt/ > >>>> +docs/doxygen-output > >>>> +docs/sphinx > >>>> +docs/xen.doxyfile > >>>> +docs/xen.doxyfile.tmp > >>>> +docs/xen-doxygen/doxygen_include.h > >>>> +docs/xen-doxygen/doxygen_include.h.tmp > >>>> extras/mini-os* > >>>> install/* > >>>> stubdom/*-minios-config.mk > >>>> diff --git a/docs/Makefile b/docs/Makefile > >>>> index 8de1efb6f5..2f784c36ce 100644 > >>>> --- a/docs/Makefile > >>>> +++ b/docs/Makefile > >>>> @@ -17,6 +17,18 @@ TXTSRC-y := $(sort $(shell find misc -name '*.txt' -print)) > >>>> > >>>> PANDOCSRC-y := $(sort $(shell find designs/ features/ misc/ process/ specs/ \( -name '*.pandoc' -o -name '*.md' \) -print)) > >>>> > >>>> +# Directory in which the doxygen documentation is created > >>>> +# This must be kept in sync with breathe_projects value in conf.py > >>>> +DOXYGEN_OUTPUT = doxygen-output > >>>> + > >>>> +# Doxygen input headers from xen-doxygen/doxy_input.list file > >>>> +DOXY_LIST_SOURCES != cat "xen-doxygen/doxy_input.list" > >>>> +DOXY_LIST_SOURCES := $(realpath $(addprefix $(XEN_ROOT)/,$(DOXY_LIST_SOURCES))) > >> > >> Hi Stefano, > >> > >>> > >>> I cannot find exactly who is populating doxy_input.list. I can see it is > >>> empty in patch #6. Does it get populated during the build? > >> > >> doxy_input.list is the only file that should be modified by the developer when he/she wants to add documentation > >> for a new file to be parsed by Doxygen, in my patch about documenting grant_tables.h you can see I add > >> there the path “xen/include/public/grant_table.h" > > > > OK, thanks. I missed that addition. > > > > > >>> > >>>> +DOXY_DEPS := xen.doxyfile \ > >>>> + xen-doxygen/mainpage.md \ > >>>> + xen-doxygen/doxygen_include.h > >>>> + > >>>> # Documentation targets > >>>> $(foreach i,$(MAN_SECTIONS), \ > >>>> $(eval DOC_MAN$(i) := $(patsubst man/%.$(i),man$(i)/%.$(i), \ > >>>> @@ -46,8 +58,28 @@ all: build > >>>> build: html txt pdf man-pages figs > >>>> > >>>> .PHONY: sphinx-html > >>>> -sphinx-html: > >>>> - sphinx-build -b html . sphinx/html > >>>> +sphinx-html: $(DOXY_DEPS) $(DOXY_LIST_SOURCES) > >>>> +ifneq ($(SPHINXBUILD),no) > >>> > >>> This check on SPHINXBUILD is new, it wasn't there before. Why do we need > >>> it now? We are not really changing anything in regards to Sphinx, just > >>> adding Doxygen support. Or was it a mistake that it was missing even > >>> before this patch? > >> > >> Yes this is new, I saw that we didn’t look if sphinx was installed in the system, so now we did > > > > In that case, I think anything related to SPHINXBUILD and whether sphinx > > is installed or not, should be a separate patch at the beginning of the > > series. It could be committed independently before the rest of the > > series. When we get to this patch, SPHINXBUILD should be already there. > > I’ve introduced SPHINXBUILD in this patch: [PATCH v6 5/9] docs: add checks to configure for sphinx and doxygen, > In your commend do you mean that you would like it to be outside this serie and this serie to be based on top of that one? I totally missed patches 4 and 5. Can you please CC me to the whole series next time? I meant as a separate patch, like you have done in patch #5. It doesn't necessarily need to be at the beginning of the series so what you have already done is OK. --8323329-766106159-1625257521=:9437-- From xen-devel-bounces@lists.xenproject.org Fri Jul 02 22:30:39 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Jul 2021 22:30:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149364.276171 (Exim 4.92) (envelope-from ) id 1lzRgB-0003Rr-PZ; Fri, 02 Jul 2021 22:30:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149364.276171; Fri, 02 Jul 2021 22:30:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzRgB-0003Rk-Lk; Fri, 02 Jul 2021 22:30:35 +0000 Received: by outflank-mailman (input) for mailman id 149364; Fri, 02 Jul 2021 22:30:34 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzRgA-0003RH-Af; Fri, 02 Jul 2021 22:30:34 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzRgA-0002pS-3K; Fri, 02 Jul 2021 22:30:34 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzRg9-0003mY-RQ; Fri, 02 Jul 2021 22:30:33 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lzRg9-0006Uh-Qs; Fri, 02 Jul 2021 22:30:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=NojLvlH1NVB8CmWm4l0BaNToK+GO9YRY7D2DplensKA=; b=IpePY04y/AQwTiciFSkBvOwZzC llXcN4u/qodbvK/rtAnBX5i2xewQ6+G/sT8oPnlqhgmPpsp0C1awHxbIxJkFJ04+Uj6gUWf58Py7z lEqSbUm8uqzaAru5f5Hx7YHEBevyuYAWdl6Ha4fmn/LKcwfvnuX4Iv7hwTaXUPaUHhRw=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 163229: regressions - FAIL X-Osstest-Failures: ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:debian-hvm-install:fail:regression ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:debian-hvm-install:fail:regression X-Osstest-Versions-This: ovmf=fea7901dba72eeac526f3ef12a4ad4c539622373 X-Osstest-Versions-That: ovmf=c410ad4da4b7785170d3d42a3ba190c2caac6feb From: osstest service owner Date: Fri, 02 Jul 2021 22:30:33 +0000 flight 163229 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/163229/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 162359 test-amd64-amd64-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 162359 version targeted for testing: ovmf fea7901dba72eeac526f3ef12a4ad4c539622373 baseline version: ovmf c410ad4da4b7785170d3d42a3ba190c2caac6feb Last test of basis 162359 2021-06-04 03:40:08 Z 28 days Failing since 162368 2021-06-04 15:42:59 Z 28 days 76 attempts Testing same since 163216 2021-07-01 22:42:29 Z 0 days 6 attempts ------------------------------------------------------------ People who touched revisions under test: Abner Chang Agrawal, Sachin Alexandru Elisei Anthony PERARD Ard Biesheuvel Daniel Schaefer Daoxiang Li Dov Murik DunTan gaoliming Guo Dong Hao A Wu Jian J Wang Kaaira Gupta Ken Lautner Kenneth Lautner Kun Qin Laszlo Ersek Leif Lindholm Liming Gao Loo Tung Lun Loo, Tung Lun Manickavasakam Karpagavinayagam Maurice Ma Ni, Ray Patrick Rudolph Pierre Gondois Ray Ni Rebecca Cran Rebecca Cran Sachin Agrawal Sami Mujawar Scottie Kuo Sean Brogan Sean Brogan Sumana Venur Sunil V L xueshengfeng Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-i386-xl-qemuu-ovmf-amd64 fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 3224 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Jul 03 03:25:09 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 03 Jul 2021 03:25:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149379.276185 (Exim 4.92) (envelope-from ) id 1lzWH0-0004wa-Mp; Sat, 03 Jul 2021 03:24:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149379.276185; Sat, 03 Jul 2021 03:24:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzWH0-0004wT-Im; Sat, 03 Jul 2021 03:24:54 +0000 Received: by outflank-mailman (input) for mailman id 149379; Sat, 03 Jul 2021 03:24:52 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzWGy-0004wJ-Lf; Sat, 03 Jul 2021 03:24:52 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzWGy-0000xF-Dc; Sat, 03 Jul 2021 03:24:52 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzWGy-00040Z-3c; Sat, 03 Jul 2021 03:24:52 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lzWGy-0007AV-38; Sat, 03 Jul 2021 03:24:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=IdE53JjzXI2sRcR+kZUW30o7yRiGX69hnKFgJZVFbtY=; b=y4tIWkFlB6TFBiw/MImDo7mJkN mDtIO/0W4eJWJbHV4bZ1li3mL8usyQXyYcmQKHRehVVbhPH/n9kfb8Up9nI1yDfP1jqMDo175UjJJ l5y4Cv1jeb4poOnlio1zf1Cteyb5AE4SnR1fWqj32356o7v09yHIiBDZ6S2bJHt/AhlU=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 163228: regressions - FAIL X-Osstest-Failures: qemu-mainline:test-amd64-amd64-qemuu-nested-amd:xen-boot/l1:fail:regression qemu-mainline:test-amd64-amd64-qemuu-nested-intel:xen-boot/l1:fail:regression qemu-mainline:test-amd64-i386-xl-xsm:guest-localmigrate/x10:fail:heisenbug qemu-mainline:test-armhf-armhf-xl-rtds:guest-start.2:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=9c2647f75004c4f7d64c9c0ec55f8c6f0739a8b1 X-Osstest-Versions-That: qemuu=1d806cef0e38b5db8347a8e12f214d543204a314 From: osstest service owner Date: Sat, 03 Jul 2021 03:24:52 +0000 flight 163228 qemu-mainline real [real] flight 163234 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/163228/ http://logs.test-lab.xenproject.org/osstest/logs/163234/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-qemuu-nested-amd 16 xen-boot/l1 fail REGR. vs. 152631 test-amd64-amd64-qemuu-nested-intel 16 xen-boot/l1 fail REGR. vs. 152631 Tests which are failing intermittently (not blocking): test-amd64-i386-xl-xsm 20 guest-localmigrate/x10 fail pass in 163234-retest Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-rtds 19 guest-start.2 fail blocked in 152631 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152631 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 152631 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152631 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152631 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 152631 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152631 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass version targeted for testing: qemuu 9c2647f75004c4f7d64c9c0ec55f8c6f0739a8b1 baseline version: qemuu 1d806cef0e38b5db8347a8e12f214d543204a314 Last test of basis 152631 2020-08-20 09:07:46 Z 316 days Failing since 152659 2020-08-21 14:07:39 Z 315 days 579 attempts Testing same since 163228 2021-07-02 17:08:27 Z 0 days 1 attempts ------------------------------------------------------------ 554 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 182071 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Jul 03 05:55:52 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 03 Jul 2021 05:55:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149388.276199 (Exim 4.92) (envelope-from ) id 1lzYcq-0001Z9-3C; Sat, 03 Jul 2021 05:55:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149388.276199; Sat, 03 Jul 2021 05:55:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzYcp-0001Z2-TW; Sat, 03 Jul 2021 05:55:35 +0000 Received: by outflank-mailman (input) for mailman id 149388; Sat, 03 Jul 2021 05:55:34 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzYco-0001Yw-9z for xen-devel@lists.xenproject.org; Sat, 03 Jul 2021 05:55:34 +0000 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 431d9276-dbc3-11eb-83d5-12813bfff9fa; Sat, 03 Jul 2021 05:55:26 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 74FC461424; Sat, 3 Jul 2021 05:55:20 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 431d9276-dbc3-11eb-83d5-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1625291725; bh=HbboShhJw0f/xTnUHQfXIFinz/CiXs1HWoUcY3xQXJE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=I0O6LGfdCvtS7x+XbgKrTkXDiWa9+ydNpeJ+Hpd6thPwMt/pojOE7wFc9EaMa5s/7 fzphfhgg11VE20oFX64ca0R8nMN+8vPQbIU1BgmW4rl6XbnuFKZDhNjV8cRQqP0aY/ FYsbmLfYPBUSfZ61FOTt8DbsSGB4+VMnlmpSxUQAttiKVwK+o8pXqyAD2ddyoHmIgj 0e7EjrXmY1/a7Nazd1WwuwVUez38Y6EoEwEcX6CsBiVsyBW0zgITA8LugP+eVTC2Bd ov/kHYh9GLPWR8A0vxWjZQwwD5frujwFh8tpknLuguSreNmEDXPVqcNA1c0N8kxgBn Wddj3pL7y93qw== Date: Fri, 2 Jul 2021 22:55:17 -0700 From: Nathan Chancellor To: Robin Murphy Cc: Will Deacon , Claire Chang , Rob Herring , mpe@ellerman.id.au, Joerg Roedel , Frank Rowand , Konrad Rzeszutek Wilk , boris.ostrovsky@oracle.com, jgross@suse.com, Christoph Hellwig , Marek Szyprowski , benh@kernel.crashing.org, paulus@samba.org, "list@263.net:IOMMU DRIVERS" , Stefano Stabellini , grant.likely@arm.com, xypron.glpk@gmx.de, Thierry Reding , mingo@kernel.org, bauerman@linux.ibm.com, peterz@infradead.org, Greg KH , Saravana Kannan , "Rafael J . Wysocki" , heikki.krogerus@linux.intel.com, Andy Shevchenko , Randy Dunlap , Dan Williams , Bartosz Golaszewski , linux-devicetree , lkml , linuxppc-dev@lists.ozlabs.org, xen-devel@lists.xenproject.org, Nicolas Boichat , Jim Quinlan , Tomasz Figa , bskeggs@redhat.com, Bjorn Helgaas , chris@chris-wilson.co.uk, Daniel Vetter , airlied@linux.ie, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, jani.nikula@linux.intel.com, Jianxiong Gao , joonas.lahtinen@linux.intel.com, linux-pci@vger.kernel.org, maarten.lankhorst@linux.intel.com, matthew.auld@intel.com, rodrigo.vivi@intel.com, thomas.hellstrom@linux.intel.com, Tom Lendacky , Qian Cai Subject: Re: [PATCH v15 06/12] swiotlb: Use is_swiotlb_force_bounce for swiotlb data bouncing Message-ID: References: <20210624155526.2775863-1-tientzu@chromium.org> <20210624155526.2775863-7-tientzu@chromium.org> <20210630114348.GA8383@willie-the-truck> <20210701074045.GA9436@willie-the-truck> <20210702135856.GB11132@willie-the-truck> <0f7bd903-e309-94a0-21d7-f0e8e9546018@arm.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="IzhtKCoR/XhZJq5z" Content-Disposition: inline In-Reply-To: <0f7bd903-e309-94a0-21d7-f0e8e9546018@arm.com> --IzhtKCoR/XhZJq5z Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Will and Robin, On Fri, Jul 02, 2021 at 04:13:50PM +0100, Robin Murphy wrote: > On 2021-07-02 14:58, Will Deacon wrote: > > Hi Nathan, > > > > On Thu, Jul 01, 2021 at 12:52:20AM -0700, Nathan Chancellor wrote: > > > On 7/1/2021 12:40 AM, Will Deacon wrote: > > > > On Wed, Jun 30, 2021 at 08:56:51AM -0700, Nathan Chancellor wrote: > > > > > On Wed, Jun 30, 2021 at 12:43:48PM +0100, Will Deacon wrote: > > > > > > On Wed, Jun 30, 2021 at 05:17:27PM +0800, Claire Chang wrote: > > > > > > > `BUG: unable to handle page fault for address: 00000000003a8290` and > > > > > > > the fact it crashed at `_raw_spin_lock_irqsave` look like the memory > > > > > > > (maybe dev->dma_io_tlb_mem) was corrupted? > > > > > > > The dev->dma_io_tlb_mem should be set here > > > > > > > (https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/pci/probe.c#n2528) > > > > > > > through device_initialize. > > > > > > > > > > > > I'm less sure about this. 'dma_io_tlb_mem' should be pointing at > > > > > > 'io_tlb_default_mem', which is a page-aligned allocation from memblock. > > > > > > The spinlock is at offset 0x24 in that structure, and looking at the > > > > > > register dump from the crash: > > > > > > > > > > > > Jun 29 18:28:42 hp-4300G kernel: RSP: 0018:ffffadb4013db9e8 EFLAGS: 00010006 > > > > > > Jun 29 18:28:42 hp-4300G kernel: RAX: 00000000003a8290 RBX: 0000000000000000 RCX: ffff8900572ad580 > > > > > > Jun 29 18:28:42 hp-4300G kernel: RDX: ffff89005653f024 RSI: 00000000000c0000 RDI: 0000000000001d17 > > > > > > Jun 29 18:28:42 hp-4300G kernel: RBP: 000000000a20d000 R08: 00000000000c0000 R09: 0000000000000000 > > > > > > Jun 29 18:28:42 hp-4300G kernel: R10: 000000000a20d000 R11: ffff89005653f000 R12: 0000000000000212 > > > > > > Jun 29 18:28:42 hp-4300G kernel: R13: 0000000000001000 R14: 0000000000000002 R15: 0000000000200000 > > > > > > Jun 29 18:28:42 hp-4300G kernel: FS: 00007f1f8898ea40(0000) GS:ffff890057280000(0000) knlGS:0000000000000000 > > > > > > Jun 29 18:28:42 hp-4300G kernel: CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > > > > > > Jun 29 18:28:42 hp-4300G kernel: CR2: 00000000003a8290 CR3: 00000001020d0000 CR4: 0000000000350ee0 > > > > > > Jun 29 18:28:42 hp-4300G kernel: Call Trace: > > > > > > Jun 29 18:28:42 hp-4300G kernel: _raw_spin_lock_irqsave+0x39/0x50 > > > > > > Jun 29 18:28:42 hp-4300G kernel: swiotlb_tbl_map_single+0x12b/0x4c0 > > > > > > > > > > > > Then that correlates with R11 holding the 'dma_io_tlb_mem' pointer and > > > > > > RDX pointing at the spinlock. Yet RAX is holding junk :/ > > > > > > > > > > > > I agree that enabling KASAN would be a good idea, but I also think we > > > > > > probably need to get some more information out of swiotlb_tbl_map_single() > > > > > > to see see what exactly is going wrong in there. > > > > > > > > > > I can certainly enable KASAN and if there is any debug print I can add > > > > > or dump anything, let me know! > > > > > > > > I bit the bullet and took v5.13 with swiotlb/for-linus-5.14 merged in, built > > > > x86 defconfig and ran it on my laptop. However, it seems to work fine! > > > > > > > > Please can you share your .config? > > > > > > Sure thing, it is attached. It is just Arch Linux's config run through > > > olddefconfig. The original is below in case you need to diff it. > > > > > > https://raw.githubusercontent.com/archlinux/svntogit-packages/9045405dc835527164f3034b3ceb9a67c7a53cd4/trunk/config > > > > > > If there is anything more that I can provide, please let me know. > > > > I eventually got this booting (for some reason it was causing LD to SEGV > > trying to link it for a while...) and sadly it works fine on my laptop. Hmm. Seems like it might be something specific to the amdgpu module? > > Did you manage to try again with KASAN? Yes, it took a few times to reproduce the issue but I did manage to get a dmesg, please find it attached. I build from commit 7d31f1c65cc9 ("swiotlb: fix implicit debugfs declarations") in Konrad's tree. > > It might also be worth taking the IOMMU out of the equation, since that > > interfaces differently with SWIOTLB and I couldn't figure out the code path > > from the log you provided. What happens if you boot with "amd_iommu=off > > swiotlb=force"? > > Oh, now there's a thing... the chat from the IOMMU API in the boot log > implies that the IOMMU *should* be in the picture - we see that default > domains are IOMMU_DOMAIN_DMA default and the GPU 0000:0c:00.0 was added to a > group. That means dev->dma_ops should be set and DMA API calls should be > going through iommu-dma, yet the callstack in the crash says we've gone > straight from dma_map_page_attrs() to swiotlb_map(), implying the inline > dma_direct_map_page() path. > > If dev->dma_ops didn't look right in the first place, it's perhaps less > surprising that dev->dma_io_tlb_mem might be wild as well. It doesn't seem > plausible that we should have a race between initialising the device and > probing its driver, so maybe the whole dev pointer is getting trampled > earlier in the callchain (or is fundamentally wrong to begin with, but from > a quick skim of the amdgpu code it did look like adev->dev and adev->pdev > are appropriately set early on by amdgpu_pci_probe()). > > > (although word of warning here: i915 dies horribly on my laptop if I pass > > swiotlb=force, even with the distro 5.10 kernel) > > FWIW I'd imagine you probably need to massively increase the SWIOTLB buffer > size to have hope of that working. Is it worth trying this still then? Cheers, Nathan --IzhtKCoR/XhZJq5z Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="7d31f1c65cc9-kasan.log" [ 0.000000] Linux version 5.12.0-rc3-debug (nathan@archlinux-ax161) (gcc (GCC) 11.1.0, GNU ld (GNU Binutils) 2.36.1) #1 SMP PREEMPT Fri Jul 2 22:22:23 MST 2021 [ 0.000000] Command line: initrd=\amd-ucode.img initrd=\initramfs-linux-mainline-llvm.img root=PARTUUID=8680aa0c-cf09-4a69-8cf3-970478040ee7 rw intel_pstate=no_hwp debug ignore_loglevel earlyprintk=efi,keep log_buf_len=16M [ 0.000000] x86/fpu: Supporting XSAVE feature 0x001: 'x87 floating point registers' [ 0.000000] x86/fpu: Supporting XSAVE feature 0x002: 'SSE registers' [ 0.000000] x86/fpu: Supporting XSAVE feature 0x004: 'AVX registers' [ 0.000000] x86/fpu: xstate_offset[2]: 576, xstate_sizes[2]: 256 [ 0.000000] x86/fpu: Enabled xstate features 0x7, context size is 832 bytes, using 'compacted' format. [ 0.000000] BIOS-provided physical RAM map: [ 0.000000] BIOS-e820: [mem 0x0000000000000000-0x000000000009ffff] usable [ 0.000000] BIOS-e820: [mem 0x00000000000a0000-0x00000000000fffff] reserved [ 0.000000] BIOS-e820: [mem 0x0000000000100000-0x0000000009c0ffff] usable [ 0.000000] BIOS-e820: [mem 0x0000000009c10000-0x0000000009ffffff] reserved [ 0.000000] BIOS-e820: [mem 0x000000000a000000-0x000000000a1fffff] usable [ 0.000000] BIOS-e820: [mem 0x000000000a200000-0x000000000a20cfff] ACPI NVS [ 0.000000] BIOS-e820: [mem 0x000000000a20d000-0x000000000affffff] usable [ 0.000000] BIOS-e820: [mem 0x000000000b000000-0x000000000b01ffff] reserved [ 0.000000] BIOS-e820: [mem 0x000000000b020000-0x00000000b838ffff] usable [ 0.000000] BIOS-e820: [mem 0x00000000b8390000-0x00000000b86c5fff] reserved [ 0.000000] BIOS-e820: [mem 0x00000000b86c6000-0x00000000b8721fff] ACPI data [ 0.000000] BIOS-e820: [mem 0x00000000b8722000-0x00000000b8a14fff] ACPI NVS [ 0.000000] BIOS-e820: [mem 0x00000000b8a15000-0x00000000badfefff] reserved [ 0.000000] BIOS-e820: [mem 0x00000000badff000-0x00000000bbffffff] usable [ 0.000000] BIOS-e820: [mem 0x00000000bc000000-0x00000000bdffffff] reserved [ 0.000000] BIOS-e820: [mem 0x00000000bf000000-0x00000000bfffffff] reserved [ 0.000000] BIOS-e820: [mem 0x00000000f0000000-0x00000000f7ffffff] reserved [ 0.000000] BIOS-e820: [mem 0x00000000fd200000-0x00000000fd2fffff] reserved [ 0.000000] BIOS-e820: [mem 0x00000000fd600000-0x00000000fd6fffff] reserved [ 0.000000] BIOS-e820: [mem 0x00000000fea00000-0x00000000fea0ffff] reserved [ 0.000000] BIOS-e820: [mem 0x00000000feb80000-0x00000000fec01fff] reserved [ 0.000000] BIOS-e820: [mem 0x00000000fec10000-0x00000000fec10fff] reserved [ 0.000000] BIOS-e820: [mem 0x00000000fec30000-0x00000000fec30fff] reserved [ 0.000000] BIOS-e820: [mem 0x00000000fed00000-0x00000000fed00fff] reserved [ 0.000000] BIOS-e820: [mem 0x00000000fed40000-0x00000000fed44fff] reserved [ 0.000000] BIOS-e820: [mem 0x00000000fed80000-0x00000000fed8ffff] reserved [ 0.000000] BIOS-e820: [mem 0x00000000fedc2000-0x00000000fedcffff] reserved [ 0.000000] BIOS-e820: [mem 0x00000000fedd4000-0x00000000fedd5fff] reserved [ 0.000000] BIOS-e820: [mem 0x00000000ff000000-0x00000000ffffffff] reserved [ 0.000000] BIOS-e820: [mem 0x0000000100000000-0x000000021f37ffff] usable [ 0.000000] BIOS-e820: [mem 0x000000021f380000-0x000000023fffffff] reserved [ 0.000000] intel_pstate: HWP disabled [ 0.000000] printk: debug: ignoring loglevel setting. [ 0.000000] NX (Execute Disable) protection: active [ 0.000000] e820: update [mem 0xb4c66018-0xb4c73457] usable ==> usable [ 0.000000] e820: update [mem 0xb4c66018-0xb4c73457] usable ==> usable [ 0.000000] extended physical RAM map: [ 0.000000] reserve setup_data: [mem 0x0000000000000000-0x000000000009ffff] usable [ 0.000000] reserve setup_data: [mem 0x00000000000a0000-0x00000000000fffff] reserved [ 0.000000] reserve setup_data: [mem 0x0000000000100000-0x0000000009c0ffff] usable [ 0.000000] reserve setup_data: [mem 0x0000000009c10000-0x0000000009ffffff] reserved [ 0.000000] reserve setup_data: [mem 0x000000000a000000-0x000000000a1fffff] usable [ 0.000000] reserve setup_data: [mem 0x000000000a200000-0x000000000a20cfff] ACPI NVS [ 0.000000] reserve setup_data: [mem 0x000000000a20d000-0x000000000affffff] usable [ 0.000000] reserve setup_data: [mem 0x000000000b000000-0x000000000b01ffff] reserved [ 0.000000] reserve setup_data: [mem 0x000000000b020000-0x00000000b4c66017] usable [ 0.000000] reserve setup_data: [mem 0x00000000b4c66018-0x00000000b4c73457] usable [ 0.000000] reserve setup_data: [mem 0x00000000b4c73458-0x00000000b838ffff] usable [ 0.000000] reserve setup_data: [mem 0x00000000b8390000-0x00000000b86c5fff] reserved [ 0.000000] reserve setup_data: [mem 0x00000000b86c6000-0x00000000b8721fff] ACPI data [ 0.000000] reserve setup_data: [mem 0x00000000b8722000-0x00000000b8a14fff] ACPI NVS [ 0.000000] reserve setup_data: [mem 0x00000000b8a15000-0x00000000badfefff] reserved [ 0.000000] reserve setup_data: [mem 0x00000000badff000-0x00000000bbffffff] usable [ 0.000000] reserve setup_data: [mem 0x00000000bc000000-0x00000000bdffffff] reserved [ 0.000000] reserve setup_data: [mem 0x00000000bf000000-0x00000000bfffffff] reserved [ 0.000000] reserve setup_data: [mem 0x00000000f0000000-0x00000000f7ffffff] reserved [ 0.000000] reserve setup_data: [mem 0x00000000fd200000-0x00000000fd2fffff] reserved [ 0.000000] reserve setup_data: [mem 0x00000000fd600000-0x00000000fd6fffff] reserved [ 0.000000] reserve setup_data: [mem 0x00000000fea00000-0x00000000fea0ffff] reserved [ 0.000000] reserve setup_data: [mem 0x00000000feb80000-0x00000000fec01fff] reserved [ 0.000000] reserve setup_data: [mem 0x00000000fec10000-0x00000000fec10fff] reserved [ 0.000000] reserve setup_data: [mem 0x00000000fec30000-0x00000000fec30fff] reserved [ 0.000000] reserve setup_data: [mem 0x00000000fed00000-0x00000000fed00fff] reserved [ 0.000000] reserve setup_data: [mem 0x00000000fed40000-0x00000000fed44fff] reserved [ 0.000000] reserve setup_data: [mem 0x00000000fed80000-0x00000000fed8ffff] reserved [ 0.000000] reserve setup_data: [mem 0x00000000fedc2000-0x00000000fedcffff] reserved [ 0.000000] reserve setup_data: [mem 0x00000000fedd4000-0x00000000fedd5fff] reserved [ 0.000000] reserve setup_data: [mem 0x00000000ff000000-0x00000000ffffffff] reserved [ 0.000000] reserve setup_data: [mem 0x0000000100000000-0x000000021f37ffff] usable [ 0.000000] reserve setup_data: [mem 0x000000021f380000-0x000000023fffffff] reserved [ 0.000000] efi: EFI v2.70 by American Megatrends [ 0.000000] efi: ACPI=0xb8721000 ACPI 2.0=0xb8721014 TPMFinalLog=0xb89c8000 SMBIOS=0xbac0f000 SMBIOS 3.0=0xbac0e000 MEMATTR=0xb5184018 ESRT=0xb6dde918 RNG=0xbac3e998 TPMEventLog=0xb5185018 [ 0.000000] efi: seeding entropy pool [ 0.000000] SMBIOS 3.3.0 present. [ 0.000000] DMI: HP HP Desktop M01-F1xxx/87D6, BIOS F.12 12/17/2020 [ 0.000000] tsc: Fast TSC calibration using PIT [ 0.000000] tsc: Detected 3793.113 MHz processor [ 0.000282] e820: update [mem 0x00000000-0x00000fff] usable ==> reserved [ 0.000289] e820: remove [mem 0x000a0000-0x000fffff] usable [ 0.000312] last_pfn = 0x21f380 max_arch_pfn = 0x400000000 [ 0.000759] x86/PAT: Configuration [0-7]: WB WC UC- UC WB WP UC- WT [ 0.001796] e820: update [mem 0xc0000000-0xffffffff] usable ==> reserved [ 0.001811] last_pfn = 0xbc000 max_arch_pfn = 0x400000000 [ 0.006400] esrt: Reserving ESRT space from 0x00000000b6dde918 to 0x00000000b6dde950. [ 0.006423] e820: update [mem 0xb6dde000-0xb6ddefff] usable ==> reserved [ 0.006833] check: Scanning 1 areas for low memory corruption [ 0.006842] Using GB pages for direct mapping [ 0.028975] printk: log_buf_len: 16777216 bytes [ 0.028982] printk: early log buf free: 123936(94%) [ 0.028986] Secure boot disabled [ 0.028988] RAMDISK: [mem 0x7f7c7000-0x7fff5fff] [ 0.029012] ACPI: Early table checksum verification disabled [ 0.029022] ACPI: RSDP 0x00000000B8721014 000024 (v02 HPQOEM) [ 0.029032] ACPI: XSDT 0x00000000B8720728 0000EC (v01 HPQOEM SLIC-CPC 01072009 AMI 01000013) [ 0.029045] ACPI: FACP 0x00000000B870F000 000114 (v06 HPQOEM SLIC-CPC 01072009 AMI 00010013) [ 0.029059] ACPI: DSDT 0x00000000B86FE000 01050C (v02 HPQOEM SLIC-CPC 01072009 INTL 20120913) [ 0.029068] ACPI: FACS 0x00000000B89F8000 000040 [ 0.029076] ACPI: MSDM 0x00000000B871F000 000055 (v03 HPQOEM SLIC-CPC 01072009 AMI 01000013) [ 0.029085] ACPI: SSDT 0x00000000B871E000 000050 (v01 HPQOEM SLIC-CPC 00000001 INTL 20120913) [ 0.029093] ACPI: IVRS 0x00000000B871D000 0000D0 (v02 HPQOEM SLIC-CPC 00000001 AMD 00000000) [ 0.029102] ACPI: SSDT 0x00000000B8715000 007229 (v02 HPQOEM SLIC-CPC 00000002 MSFT 04000000) [ 0.029110] ACPI: SSDT 0x00000000B8711000 003BA1 (v01 HPQOEM SLIC-CPC 00000001 INTL 20120913) [ 0.029119] ACPI: SSDT 0x00000000B8710000 000094 (v02 HPQOEM SLIC-CPC 01072009 AMI 01072009) [ 0.029128] ACPI: FIDT 0x00000000B86FD000 00009C (v01 HPQOEM SLIC-CPC 01072009 AMI 00010013) [ 0.029136] ACPI: MCFG 0x00000000B86FC000 00003C (v01 HPQOEM SLIC-CPC 01072009 MSFT 00010013) [ 0.029145] ACPI: HPET 0x00000000B86FB000 000038 (v01 HPQOEM SLIC-CPC 01072009 AMI 00000005) [ 0.029154] ACPI: VFCT 0x00000000B86ED000 00D484 (v01 HPQOEM SLIC-CPC 00000001 AMD 31504F47) [ 0.029162] ACPI: BGRT 0x00000000B86EC000 000038 (v01 HPQOEM SLIC-CPC 01072009 AMI 00010013) [ 0.029171] ACPI: TPM2 0x00000000B86EB000 00004C (v04 HPQOEM SLIC-CPC 00000001 AMI 00000000) [ 0.029179] ACPI: SSDT 0x00000000B86E9000 001CE4 (v02 HPQOEM SLIC-CPC 00000001 AMD 00000001) [ 0.029188] ACPI: CRAT 0x00000000B86E8000 0007E8 (v01 HPQOEM SLIC-CPC 00000001 AMD 00000001) [ 0.029197] ACPI: CDIT 0x00000000B86E7000 000029 (v01 HPQOEM SLIC-CPC 00000001 AMD 00000001) [ 0.029205] ACPI: SSDT 0x00000000B86E6000 000D37 (v01 HPQOEM SLIC-CPC 00000001 INTL 20120913) [ 0.029214] ACPI: SSDT 0x00000000B86E4000 0010A5 (v01 HPQOEM SLIC-CPC 00000001 INTL 20120913) [ 0.029222] ACPI: SSDT 0x00000000B86E0000 00333E (v01 HPQOEM SLIC-CPC 00000001 INTL 20120913) [ 0.029231] ACPI: SSDT 0x00000000B86DF000 0000BF (v01 HPQOEM SLIC-CPC 00001000 INTL 20120913) [ 0.029240] ACPI: WSMT 0x00000000B86DE000 000028 (v01 HPQOEM SLIC-CPC 01072009 AMI 00010013) [ 0.029248] ACPI: APIC 0x00000000B86DD000 00015E (v03 HPQOEM SLIC-CPC 01072009 AMI 00010013) [ 0.029257] ACPI: SSDT 0x00000000B86DC000 000517 (v01 HPQOEM SLIC-CPC 00000001 INTL 20120913) [ 0.029266] ACPI: SSDT 0x00000000B86DA000 0010AF (v01 HPQOEM SLIC-CPC 00000001 INTL 20120913) [ 0.029274] ACPI: FPDT 0x00000000B86D9000 000044 (v01 HPQOEM SLIC-CPC 01072009 AMI 01000013) [ 0.029288] ACPI: Local APIC address 0xfee00000 [ 0.029611] No NUMA configuration found [ 0.029614] Faking a node at [mem 0x0000000000000000-0x000000021f37ffff] [ 0.029626] NODE_DATA(0) allocated [mem 0x21ab7c000-0x21ab7ffff] [ 0.029690] Zone ranges: [ 0.029693] DMA [mem 0x0000000000001000-0x0000000000ffffff] [ 0.029698] DMA32 [mem 0x0000000001000000-0x00000000ffffffff] [ 0.029702] Normal [mem 0x0000000100000000-0x000000021f37ffff] [ 0.029707] Device empty [ 0.029710] Movable zone start for each node [ 0.029713] Early memory node ranges [ 0.029715] node 0: [mem 0x0000000000001000-0x000000000009ffff] [ 0.029718] node 0: [mem 0x0000000000100000-0x0000000009c0ffff] [ 0.029722] node 0: [mem 0x000000000a000000-0x000000000a1fffff] [ 0.029725] node 0: [mem 0x000000000a20d000-0x000000000affffff] [ 0.029728] node 0: [mem 0x000000000b020000-0x00000000b838ffff] [ 0.029732] node 0: [mem 0x00000000badff000-0x00000000bbffffff] [ 0.029735] node 0: [mem 0x0000000100000000-0x000000021f37ffff] [ 0.029740] Initmem setup node 0 [mem 0x0000000000001000-0x000000021f37ffff] [ 0.029744] On node 0 totalpages: 1934483 [ 0.029748] DMA zone: 64 pages used for memmap [ 0.029751] DMA zone: 26 pages reserved [ 0.029754] DMA zone: 3999 pages, LIFO batch:0 [ 0.032133] DMA zone: 28769 pages in unavailable ranges [ 0.032137] DMA32 zone: 11782 pages used for memmap [ 0.032140] DMA32 zone: 754036 pages, LIFO batch:63 [ 0.076694] DMA32 zone: 28300 pages in unavailable ranges [ 0.076706] Normal zone: 18382 pages used for memmap [ 0.076709] Normal zone: 1176448 pages, LIFO batch:63 [ 0.143245] Normal zone: 3200 pages in unavailable ranges [ 0.274167] kasan: KernelAddressSanitizer initialized [ 0.274679] ACPI: PM-Timer IO Port: 0x808 [ 0.274683] ACPI: Local APIC address 0xfee00000 [ 0.274697] ACPI: LAPIC_NMI (acpi_id[0xff] high edge lint[0x1]) [ 0.274714] IOAPIC[0]: apic_id 9, version 33, address 0xfec00000, GSI 0-23 [ 0.274723] IOAPIC[1]: apic_id 10, version 33, address 0xfec01000, GSI 24-55 [ 0.274729] ACPI: INT_SRC_OVR (bus 0 bus_irq 0 global_irq 2 dfl dfl) [ 0.274733] ACPI: INT_SRC_OVR (bus 0 bus_irq 9 global_irq 9 low level) [ 0.274738] ACPI: IRQ0 used by override. [ 0.274742] ACPI: IRQ9 used by override. [ 0.274747] Using ACPI (MADT) for SMP configuration information [ 0.274751] ACPI: HPET id: 0x10228201 base: 0xfed00000 [ 0.274779] e820: update [mem 0xb5158000-0xb517ffff] usable ==> reserved [ 0.274812] smpboot: Allowing 32 CPUs, 24 hotplug CPUs [ 0.274935] PM: hibernation: Registered nosave memory: [mem 0x00000000-0x00000fff] [ 0.274943] PM: hibernation: Registered nosave memory: [mem 0x000a0000-0x000fffff] [ 0.274951] PM: hibernation: Registered nosave memory: [mem 0x09c10000-0x09ffffff] [ 0.274959] PM: hibernation: Registered nosave memory: [mem 0x0a200000-0x0a20cfff] [ 0.274967] PM: hibernation: Registered nosave memory: [mem 0x0b000000-0x0b01ffff] [ 0.274975] PM: hibernation: Registered nosave memory: [mem 0xb4c66000-0xb4c66fff] [ 0.274983] PM: hibernation: Registered nosave memory: [mem 0xb4c73000-0xb4c73fff] [ 0.274991] PM: hibernation: Registered nosave memory: [mem 0xb5158000-0xb517ffff] [ 0.274999] PM: hibernation: Registered nosave memory: [mem 0xb6dde000-0xb6ddefff] [ 0.275007] PM: hibernation: Registered nosave memory: [mem 0xb8390000-0xb86c5fff] [ 0.275010] PM: hibernation: Registered nosave memory: [mem 0xb86c6000-0xb8721fff] [ 0.275013] PM: hibernation: Registered nosave memory: [mem 0xb8722000-0xb8a14fff] [ 0.275016] PM: hibernation: Registered nosave memory: [mem 0xb8a15000-0xbadfefff] [ 0.275024] PM: hibernation: Registered nosave memory: [mem 0xbc000000-0xbdffffff] [ 0.275028] PM: hibernation: Registered nosave memory: [mem 0xbe000000-0xbeffffff] [ 0.275031] PM: hibernation: Registered nosave memory: [mem 0xbf000000-0xbfffffff] [ 0.275034] PM: hibernation: Registered nosave memory: [mem 0xc0000000-0xefffffff] [ 0.275037] PM: hibernation: Registered nosave memory: [mem 0xf0000000-0xf7ffffff] [ 0.275040] PM: hibernation: Registered nosave memory: [mem 0xf8000000-0xfd1fffff] [ 0.275043] PM: hibernation: Registered nosave memory: [mem 0xfd200000-0xfd2fffff] [ 0.275046] PM: hibernation: Registered nosave memory: [mem 0xfd300000-0xfd5fffff] [ 0.275049] PM: hibernation: Registered nosave memory: [mem 0xfd600000-0xfd6fffff] [ 0.275052] PM: hibernation: Registered nosave memory: [mem 0xfd700000-0xfe9fffff] [ 0.275055] PM: hibernation: Registered nosave memory: [mem 0xfea00000-0xfea0ffff] [ 0.275058] PM: hibernation: Registered nosave memory: [mem 0xfea10000-0xfeb7ffff] [ 0.275061] PM: hibernation: Registered nosave memory: [mem 0xfeb80000-0xfec01fff] [ 0.275064] PM: hibernation: Registered nosave memory: [mem 0xfec02000-0xfec0ffff] [ 0.275067] PM: hibernation: Registered nosave memory: [mem 0xfec10000-0xfec10fff] [ 0.275070] PM: hibernation: Registered nosave memory: [mem 0xfec11000-0xfec2ffff] [ 0.275073] PM: hibernation: Registered nosave memory: [mem 0xfec30000-0xfec30fff] [ 0.275076] PM: hibernation: Registered nosave memory: [mem 0xfec31000-0xfecfffff] [ 0.275079] PM: hibernation: Registered nosave memory: [mem 0xfed00000-0xfed00fff] [ 0.275082] PM: hibernation: Registered nosave memory: [mem 0xfed01000-0xfed3ffff] [ 0.275085] PM: hibernation: Registered nosave memory: [mem 0xfed40000-0xfed44fff] [ 0.275088] PM: hibernation: Registered nosave memory: [mem 0xfed45000-0xfed7ffff] [ 0.275091] PM: hibernation: Registered nosave memory: [mem 0xfed80000-0xfed8ffff] [ 0.275095] PM: hibernation: Registered nosave memory: [mem 0xfed90000-0xfedc1fff] [ 0.275098] PM: hibernation: Registered nosave memory: [mem 0xfedc2000-0xfedcffff] [ 0.275101] PM: hibernation: Registered nosave memory: [mem 0xfedd0000-0xfedd3fff] [ 0.275104] PM: hibernation: Registered nosave memory: [mem 0xfedd4000-0xfedd5fff] [ 0.275107] PM: hibernation: Registered nosave memory: [mem 0xfedd6000-0xfeffffff] [ 0.275110] PM: hibernation: Registered nosave memory: [mem 0xff000000-0xffffffff] [ 0.275116] [mem 0xc0000000-0xefffffff] available for PCI devices [ 0.275120] Booting paravirtualized kernel on bare hardware [ 0.275125] clocksource: refined-jiffies: mask: 0xffffffff max_cycles: 0xffffffff, max_idle_ns: 6370452778343963 ns [ 0.283746] setup_percpu: NR_CPUS:320 nr_cpumask_bits:320 nr_cpu_ids:32 nr_node_ids:1 [ 0.285877] percpu: Embedded 64 pages/cpu s225280 r8192 d28672 u262144 [ 0.285919] pcpu-alloc: s225280 r8192 d28672 u262144 alloc=1*2097152 [ 0.285926] pcpu-alloc: [0] 00 01 02 03 04 05 06 07 [0] 08 09 10 11 12 13 14 15 [ 0.285954] pcpu-alloc: [0] 16 17 18 19 20 21 22 23 [0] 24 25 26 27 28 29 30 31 [ 0.286068] Built 1 zonelists, mobility grouping on. Total pages: 1904229 [ 0.286072] Policy zone: Normal [ 0.286075] Kernel command line: initrd=\amd-ucode.img initrd=\initramfs-linux-mainline-llvm.img root=PARTUUID=8680aa0c-cf09-4a69-8cf3-970478040ee7 rw intel_pstate=no_hwp debug ignore_loglevel earlyprintk=efi,keep log_buf_len=16M [ 0.287383] Dentry cache hash table entries: 1048576 (order: 11, 8388608 bytes, linear) [ 0.288005] Inode-cache hash table entries: 524288 (order: 10, 4194304 bytes, linear) [ 0.288283] mem auto-init: stack:off, heap alloc:on, heap free:off [ 0.487941] Memory: 6325388K/7737932K available (20488K kernel code, 7278K rwdata, 8472K rodata, 2012K init, 5244K bss, 1412288K reserved, 0K cma-reserved) [ 0.487959] random: get_random_u64 called from __kmem_cache_create+0x2a/0x540 with crng_init=0 [ 0.488611] SLUB: HWalign=64, Order=0-3, MinObjects=0, CPUs=32, Nodes=1 [ 0.488656] ftrace: allocating 41984 entries in 165 pages [ 0.513537] ftrace: allocated 164 pages with 3 groups [ 0.514222] rcu: Preemptible hierarchical RCU implementation. [ 0.514225] rcu: RCU dyntick-idle grace-period acceleration is enabled. [ 0.514228] rcu: RCU restricting CPUs from NR_CPUS=320 to nr_cpu_ids=32. [ 0.514230] rcu: RCU priority boosting: priority 1 delay 500 ms. [ 0.514234] Trampoline variant of Tasks RCU enabled. [ 0.514236] Rude variant of Tasks RCU enabled. [ 0.514238] Tracing variant of Tasks RCU enabled. [ 0.514240] rcu: RCU calculated value of scheduler-enlistment delay is 30 jiffies. [ 0.514243] rcu: Adjusting geometry for rcu_fanout_leaf=16, nr_cpu_ids=32 [ 0.530610] NR_IRQS: 20736, nr_irqs: 1224, preallocated irqs: 16 [ 0.531305] Console: colour dummy device 80x25 [ 0.532581] printk: console [tty0] enabled [ 0.532672] ACPI: Core revision 20210105 [ 0.534075] clocksource: hpet: mask: 0xffffffff max_cycles: 0xffffffff, max_idle_ns: 133484873504 ns [ 0.534108] APIC: Switch to symmetric I/O mode setup [ 0.536014] Switched APIC routing to physical flat. [ 0.536980] ..TIMER: vector=0x30 apic1=0 pin1=2 apic2=-1 pin2=-1 [ 0.550788] clocksource: tsc-early: mask: 0xffffffffffffffff max_cycles: 0x6d59da3440c, max_idle_ns: 881590460744 ns [ 0.550813] Calibrating delay loop (skipped), value calculated using timer frequency.. 7589.31 BogoMIPS (lpj=12643710) [ 0.550826] pid_max: default: 32768 minimum: 301 [ 0.560533] LSM: Security Framework initializing [ 0.560572] Yama: becoming mindful. [ 0.560704] Mount-cache hash table entries: 16384 (order: 5, 131072 bytes, linear) [ 0.560737] Mountpoint-cache hash table entries: 16384 (order: 5, 131072 bytes, linear) [ 0.561938] x86/cpu: User Mode Instruction Prevention (UMIP) activated [ 0.562014] LVT offset 1 assigned for vector 0xf9 [ 0.562063] LVT offset 2 assigned for vector 0xf4 [ 0.562083] Last level iTLB entries: 4KB 1024, 2MB 1024, 4MB 512 [ 0.562090] Last level dTLB entries: 4KB 2048, 2MB 2048, 4MB 1024, 1GB 0 [ 0.562103] Spectre V1 : Mitigation: usercopy/swapgs barriers and __user pointer sanitization [ 0.562113] Spectre V2 : Mitigation: Full AMD retpoline [ 0.562119] Spectre V2 : Spectre v2 / SpectreRSB mitigation: Filling RSB on context switch [ 0.562127] Spectre V2 : Enabling Restricted Speculation for firmware calls [ 0.562134] Spectre V2 : mitigation: Enabling conditional Indirect Branch Prediction Barrier [ 0.562143] Spectre V2 : User space: Mitigation: STIBP via seccomp and prctl [ 0.562151] Speculative Store Bypass: Mitigation: Speculative Store Bypass disabled via prctl and seccomp [ 0.562517] Freeing SMP alternatives memory: 32K [ 0.670524] smpboot: CPU0: AMD Ryzen 3 4300G with Radeon Graphics (family: 0x17, model: 0x60, stepping: 0x1) [ 0.670806] Performance Events: Fam17h+ core perfctr, AMD PMU driver. [ 0.670806] ... version: 0 [ 0.670806] ... bit width: 48 [ 0.670806] ... generic registers: 6 [ 0.670806] ... value mask: 0000ffffffffffff [ 0.670806] ... max period: 00007fffffffffff [ 0.670806] ... fixed-purpose events: 0 [ 0.670806] ... event mask: 000000000000003f [ 0.670806] rcu: Hierarchical SRCU implementation. [ 0.670898] NMI watchdog: Enabled. Permanently consumes one hw-PMU counter. [ 0.672692] smp: Bringing up secondary CPUs ... [ 0.673345] x86: Booting SMP configuration: [ 0.673351] .... node #0, CPUs: #1 #2 #3 #4 #5 #6 #7 [ 0.693536] smp: Brought up 1 node, 8 CPUs [ 0.693536] smpboot: Max logical packages: 4 [ 0.693536] smpboot: Total of 8 processors activated (60714.55 BogoMIPS) [ 0.695830] devtmpfs: initialized [ 0.695830] x86/mm: Memory block size: 128MB [ 0.705546] PM: Registering ACPI NVS region [mem 0x0a200000-0x0a20cfff] (53248 bytes) [ 0.705546] PM: Registering ACPI NVS region [mem 0xb8722000-0xb8a14fff] (3092480 bytes) [ 0.707584] clocksource: jiffies: mask: 0xffffffff max_cycles: 0xffffffff, max_idle_ns: 6370867519511994 ns [ 0.707638] futex hash table entries: 8192 (order: 7, 524288 bytes, linear) [ 0.708029] pinctrl core: initialized pinctrl subsystem [ 0.708720] PM: RTC time: 05:52:33, date: 2021-07-03 [ 0.709499] NET: Registered protocol family 16 [ 0.710265] DMA: preallocated 1024 KiB GFP_KERNEL pool for atomic allocations [ 0.710411] DMA: preallocated 1024 KiB GFP_KERNEL|GFP_DMA pool for atomic allocations [ 0.710565] DMA: preallocated 1024 KiB GFP_KERNEL|GFP_DMA32 pool for atomic allocations [ 0.710649] audit: initializing netlink subsys (disabled) [ 0.710823] audit: type=2000 audit(1625291553.176:1): state=initialized audit_enabled=0 res=1 [ 0.711826] thermal_sys: Registered thermal governor 'fair_share' [ 0.711829] thermal_sys: Registered thermal governor 'bang_bang' [ 0.711837] thermal_sys: Registered thermal governor 'step_wise' [ 0.711842] thermal_sys: Registered thermal governor 'user_space' [ 0.711848] thermal_sys: Registered thermal governor 'power_allocator' [ 0.711909] cpuidle: using governor ladder [ 0.711909] cpuidle: using governor menu [ 0.711909] ACPI: bus type PCI registered [ 0.711909] acpiphp: ACPI Hot Plug PCI Controller Driver version: 0.5 [ 0.711909] PCI: MMCONFIG for domain 0000 [bus 00-7f] at [mem 0xf0000000-0xf7ffffff] (base 0xf0000000) [ 0.711909] PCI: MMCONFIG at [mem 0xf0000000-0xf7ffffff] reserved in E820 [ 0.719382] PCI: Using configuration type 1 for base access [ 0.734924] Kprobes globally optimized [ 0.734949] HugeTLB registered 1.00 GiB page size, pre-allocated 0 pages [ 0.734949] HugeTLB registered 2.00 MiB page size, pre-allocated 0 pages [ 0.738422] fbcon: Taking over console [ 0.738518] ACPI: Added _OSI(Module Device) [ 0.738524] ACPI: Added _OSI(Processor Device) [ 0.738529] ACPI: Added _OSI(3.0 _SCP Extensions) [ 0.738534] ACPI: Added _OSI(Processor Aggregator Device) [ 0.738545] ACPI: Added _OSI(Linux-Dell-Video) [ 0.738555] ACPI: Added _OSI(Linux-Lenovo-NV-HDMI-Audio) [ 0.738565] ACPI: Added _OSI(Linux-HPI-Hybrid-Graphics) [ 1.267709] ACPI: 12 ACPI AML tables successfully acquired and loaded [ 1.300337] ACPI: [Firmware Bug]: BIOS _OSI(Linux) query ignored [ 1.393616] ACPI: EC: EC started [ 1.393628] ACPI: EC: interrupt blocked [ 1.393658] ACPI: EC: EC_CMD/EC_SC=0x66, EC_DATA=0x62 [ 1.393669] ACPI: \_SB_.PCI0.SBRG.EC0_: Boot DSDT EC used to handle transactions [ 1.393680] ACPI: Interpreter enabled [ 1.393805] ACPI: (supports S0 S3 S4 S5) [ 1.393811] ACPI: Using IOAPIC for interrupt routing [ 1.397606] PCI: Using host bridge windows from ACPI; if necessary, use "pci=nocrs" and report a bug [ 1.407707] ACPI: Enabled 4 GPEs in block 00 to 1F [ 1.658446] ACPI: PCI Root Bridge [PCI0] (domain 0000 [bus 00-ff]) [ 1.658486] acpi PNP0A08:00: _OSC: OS supports [ExtendedConfig ASPM ClockPM Segments MSI EDR HPX-Type3] [ 1.664502] acpi PNP0A08:00: _OSC: platform does not support [SHPCHotplug AER LTR DPC] [ 1.670343] acpi PNP0A08:00: _OSC: OS now controls [PCIeHotplug PME PCIeCapability] [ 1.670482] acpi PNP0A08:00: [Firmware Info]: MMCONFIG for domain 0000 [bus 00-7f] only partially covers this bridge [ 1.680552] PCI host bridge to bus 0000:00 [ 1.680564] pci_bus 0000:00: root bus resource [io 0x0000-0x03af window] [ 1.680577] pci_bus 0000:00: root bus resource [io 0x03e0-0x0cf7 window] [ 1.680588] pci_bus 0000:00: root bus resource [io 0x03b0-0x03df window] [ 1.680599] pci_bus 0000:00: root bus resource [io 0x0d00-0xffff window] [ 1.680610] pci_bus 0000:00: root bus resource [mem 0x000a0000-0x000bffff window] [ 1.680623] pci_bus 0000:00: root bus resource [mem 0x000c0000-0x000dffff window] [ 1.680635] pci_bus 0000:00: root bus resource [mem 0xc0000000-0xfec2ffff window] [ 1.680647] pci_bus 0000:00: root bus resource [mem 0xfee00000-0xffffffff window] [ 1.680660] pci_bus 0000:00: root bus resource [bus 00-ff] [ 1.680766] pci 0000:00:00.0: [1022:1630] type 00 class 0x060000 [ 1.682372] pci 0000:00:00.2: [1022:1631] type 00 class 0x080600 [ 1.683965] pci 0000:00:01.0: [1022:1632] type 00 class 0x060000 [ 1.685111] pci 0000:00:02.0: [1022:1632] type 00 class 0x060000 [ 1.686247] pci 0000:00:02.1: [1022:1634] type 01 class 0x060400 [ 1.686276] pci 0000:00:02.1: enabling Extended Tags [ 1.686363] pci 0000:00:02.1: PME# supported from D0 D3hot D3cold [ 1.689305] pci 0000:00:02.2: [1022:1634] type 01 class 0x060400 [ 1.689335] pci 0000:00:02.2: enabling Extended Tags [ 1.689421] pci 0000:00:02.2: PME# supported from D0 D3hot D3cold [ 1.691208] pci 0000:00:08.0: [1022:1632] type 00 class 0x060000 [ 1.692342] pci 0000:00:08.1: [1022:1635] type 01 class 0x060400 [ 1.692370] pci 0000:00:08.1: enabling Extended Tags [ 1.692452] pci 0000:00:08.1: PME# supported from D0 D3hot D3cold [ 1.694225] pci 0000:00:08.2: [1022:1635] type 01 class 0x060400 [ 1.694252] pci 0000:00:08.2: enabling Extended Tags [ 1.694335] pci 0000:00:08.2: PME# supported from D0 D3hot D3cold [ 1.696116] pci 0000:00:14.0: [1022:790b] type 00 class 0x0c0500 [ 1.697735] pci 0000:00:14.3: [1022:790e] type 00 class 0x060100 [ 1.699364] pci 0000:00:18.0: [1022:1448] type 00 class 0x060000 [ 1.700480] pci 0000:00:18.1: [1022:1449] type 00 class 0x060000 [ 1.701595] pci 0000:00:18.2: [1022:144a] type 00 class 0x060000 [ 1.702711] pci 0000:00:18.3: [1022:144b] type 00 class 0x060000 [ 1.703821] pci 0000:00:18.4: [1022:144c] type 00 class 0x060000 [ 1.704933] pci 0000:00:18.5: [1022:144d] type 00 class 0x060000 [ 1.706045] pci 0000:00:18.6: [1022:144e] type 00 class 0x060000 [ 1.707156] pci 0000:00:18.7: [1022:144f] type 00 class 0x060000 [ 1.708924] pci 0000:01:00.0: [1022:43d1] type 00 class 0x0c0330 [ 1.708949] pci 0000:01:00.0: reg 0x10: [mem 0xfcda0000-0xfcda7fff 64bit] [ 1.708994] pci 0000:01:00.0: enabling Extended Tags [ 1.709154] pci 0000:01:00.0: PME# supported from D3hot D3cold [ 1.710181] pci 0000:01:00.1: [1022:43c8] type 00 class 0x010601 [ 1.710222] pci 0000:01:00.1: reg 0x24: [mem 0xfcd80000-0xfcd9ffff] [ 1.710234] pci 0000:01:00.1: reg 0x30: [mem 0xfcd00000-0xfcd7ffff pref] [ 1.710247] pci 0000:01:00.1: enabling Extended Tags [ 1.710386] pci 0000:01:00.1: PME# supported from D3hot D3cold [ 1.716376] pci 0000:01:00.2: [1022:43c6] type 01 class 0x060400 [ 1.716425] pci 0000:01:00.2: enabling Extended Tags [ 1.716567] pci 0000:01:00.2: PME# supported from D3hot D3cold [ 1.717573] pci 0000:00:02.1: PCI bridge to [bus 01-0a] [ 1.717584] pci 0000:00:02.1: bridge window [io 0xd000-0xefff] [ 1.717592] pci 0000:00:02.1: bridge window [mem 0xfcb00000-0xfcdfffff] [ 1.719436] pci 0000:02:00.0: [1022:43c7] type 01 class 0x060400 [ 1.719487] pci 0000:02:00.0: enabling Extended Tags [ 1.719697] pci 0000:02:00.0: PME# supported from D3hot D3cold [ 1.720977] pci 0000:02:01.0: [1022:43c7] type 01 class 0x060400 [ 1.721029] pci 0000:02:01.0: enabling Extended Tags [ 1.721242] pci 0000:02:01.0: PME# supported from D3hot D3cold [ 1.722508] pci 0000:02:02.0: [1022:43c7] type 01 class 0x060400 [ 1.722559] pci 0000:02:02.0: enabling Extended Tags [ 1.722767] pci 0000:02:02.0: PME# supported from D3hot D3cold [ 1.724053] pci 0000:02:03.0: [1022:43c7] type 01 class 0x060400 [ 1.724105] pci 0000:02:03.0: enabling Extended Tags [ 1.724316] pci 0000:02:03.0: PME# supported from D3hot D3cold [ 1.725577] pci 0000:02:04.0: [1022:43c7] type 01 class 0x060400 [ 1.725628] pci 0000:02:04.0: enabling Extended Tags [ 1.725836] pci 0000:02:04.0: PME# supported from D3hot D3cold [ 1.727111] pci 0000:02:05.0: [1022:43c7] type 01 class 0x060400 [ 1.727162] pci 0000:02:05.0: enabling Extended Tags [ 1.727370] pci 0000:02:05.0: PME# supported from D3hot D3cold [ 1.728654] pci 0000:02:06.0: [1022:43c7] type 01 class 0x060400 [ 1.728706] pci 0000:02:06.0: enabling Extended Tags [ 1.728914] pci 0000:02:06.0: PME# supported from D3hot D3cold [ 1.730188] pci 0000:02:07.0: [1022:43c7] type 01 class 0x060400 [ 1.730239] pci 0000:02:07.0: enabling Extended Tags [ 1.730448] pci 0000:02:07.0: PME# supported from D3hot D3cold [ 1.731709] pci 0000:01:00.2: PCI bridge to [bus 02-0a] [ 1.731721] pci 0000:01:00.2: bridge window [io 0xd000-0xefff] [ 1.731730] pci 0000:01:00.2: bridge window [mem 0xfcb00000-0xfccfffff] [ 1.732133] pci 0000:02:00.0: PCI bridge to [bus 03] [ 1.732535] pci 0000:02:01.0: PCI bridge to [bus 04] [ 1.732932] pci 0000:02:02.0: PCI bridge to [bus 05] [ 1.733334] pci 0000:02:03.0: PCI bridge to [bus 06] [ 1.733741] pci 0000:02:04.0: PCI bridge to [bus 07] [ 1.733934] pci 0000:02:05.0: PCI bridge to [bus 08] [ 1.734170] pci 0000:09:00.0: [10ec:c821] type 00 class 0x028000 [ 1.734203] pci 0000:09:00.0: reg 0x10: [io 0xe000-0xe0ff] [ 1.734242] pci 0000:09:00.0: reg 0x18: [mem 0xfcc00000-0xfcc0ffff 64bit] [ 1.734638] pci 0000:09:00.0: supports D1 D2 [ 1.734644] pci 0000:09:00.0: PME# supported from D0 D1 D2 D3hot D3cold [ 1.735243] pci 0000:02:06.0: PCI bridge to [bus 09] [ 1.735254] pci 0000:02:06.0: bridge window [io 0xe000-0xefff] [ 1.735263] pci 0000:02:06.0: bridge window [mem 0xfcc00000-0xfccfffff] [ 1.735488] pci 0000:0a:00.0: [10ec:8168] type 00 class 0x020000 [ 1.735521] pci 0000:0a:00.0: reg 0x10: [io 0xd000-0xd0ff] [ 1.735564] pci 0000:0a:00.0: reg 0x18: [mem 0xfcb04000-0xfcb04fff 64bit] [ 1.735593] pci 0000:0a:00.0: reg 0x20: [mem 0xfcb00000-0xfcb03fff 64bit] [ 1.735965] pci 0000:0a:00.0: supports D1 D2 [ 1.735971] pci 0000:0a:00.0: PME# supported from D0 D1 D2 D3hot D3cold [ 1.736571] pci 0000:02:07.0: PCI bridge to [bus 0a] [ 1.736582] pci 0000:02:07.0: bridge window [io 0xd000-0xdfff] [ 1.736590] pci 0000:02:07.0: bridge window [mem 0xfcb00000-0xfcbfffff] [ 1.737022] pci 0000:0b:00.0: [1c5c:1339] type 00 class 0x010802 [ 1.737046] pci 0000:0b:00.0: reg 0x10: [mem 0xfcf00000-0xfcf03fff 64bit] [ 1.737248] pci 0000:0b:00.0: supports D1 [ 1.737254] pci 0000:0b:00.0: PME# supported from D0 D1 D3hot [ 1.737325] pci 0000:0b:00.0: 15.752 Gb/s available PCIe bandwidth, limited by 8.0 GT/s PCIe x2 link at 0000:00:02.2 (capable of 31.504 Gb/s with 8.0 GT/s PCIe x4 link) [ 1.737750] pci 0000:00:02.2: PCI bridge to [bus 0b] [ 1.737760] pci 0000:00:02.2: bridge window [mem 0xfcf00000-0xfcffffff] [ 1.739105] pci 0000:0c:00.0: [1002:1636] type 00 class 0x030000 [ 1.739123] pci 0000:0c:00.0: reg 0x10: [mem 0xd0000000-0xdfffffff 64bit pref] [ 1.739138] pci 0000:0c:00.0: reg 0x18: [mem 0xe0000000-0xe01fffff 64bit pref] [ 1.739150] pci 0000:0c:00.0: reg 0x20: [io 0xf000-0xf0ff] [ 1.739161] pci 0000:0c:00.0: reg 0x24: [mem 0xfca00000-0xfca7ffff] [ 1.739176] pci 0000:0c:00.0: enabling Extended Tags [ 1.739281] pci 0000:0c:00.0: BAR 0: assigned to efifb [ 1.739327] pci 0000:0c:00.0: PME# supported from D1 D2 D3hot D3cold [ 1.739367] pci 0000:0c:00.0: 126.016 Gb/s available PCIe bandwidth, limited by 8.0 GT/s PCIe x16 link at 0000:00:08.1 (capable of 252.048 Gb/s with 16.0 GT/s PCIe x16 link) [ 1.740514] pci 0000:0c:00.1: [1002:1637] type 00 class 0x040300 [ 1.740528] pci 0000:0c:00.1: reg 0x10: [mem 0xfca88000-0xfca8bfff] [ 1.740555] pci 0000:0c:00.1: enabling Extended Tags [ 1.740684] pci 0000:0c:00.1: PME# supported from D1 D2 D3hot D3cold [ 1.741827] pci 0000:0c:00.2: [1022:15df] type 00 class 0x108000 [ 1.741847] pci 0000:0c:00.2: reg 0x18: [mem 0xfc900000-0xfc9fffff] [ 1.741863] pci 0000:0c:00.2: reg 0x24: [mem 0xfca8c000-0xfca8dfff] [ 1.741876] pci 0000:0c:00.2: enabling Extended Tags [ 1.743084] pci 0000:0c:00.3: [1022:1639] type 00 class 0x0c0330 [ 1.743102] pci 0000:0c:00.3: reg 0x10: [mem 0xfc800000-0xfc8fffff 64bit] [ 1.743131] pci 0000:0c:00.3: enabling Extended Tags [ 1.743261] pci 0000:0c:00.3: PME# supported from D0 D3hot D3cold [ 1.744407] pci 0000:0c:00.4: [1022:1639] type 00 class 0x0c0330 [ 1.744425] pci 0000:0c:00.4: reg 0x10: [mem 0xfc700000-0xfc7fffff 64bit] [ 1.744455] pci 0000:0c:00.4: enabling Extended Tags [ 1.744583] pci 0000:0c:00.4: PME# supported from D0 D3hot D3cold [ 1.745722] pci 0000:0c:00.6: [1022:15e3] type 00 class 0x040300 [ 1.745737] pci 0000:0c:00.6: reg 0x10: [mem 0xfca80000-0xfca87fff] [ 1.745764] pci 0000:0c:00.6: enabling Extended Tags [ 1.745892] pci 0000:0c:00.6: PME# supported from D0 D3hot D3cold [ 1.747111] pci 0000:00:08.1: PCI bridge to [bus 0c] [ 1.747120] pci 0000:00:08.1: bridge window [io 0xf000-0xffff] [ 1.747128] pci 0000:00:08.1: bridge window [mem 0xfc700000-0xfcafffff] [ 1.747137] pci 0000:00:08.1: bridge window [mem 0xd0000000-0xe01fffff 64bit pref] [ 1.747640] pci 0000:0d:00.0: [1022:7901] type 00 class 0x010601 [ 1.747668] pci 0000:0d:00.0: reg 0x24: [mem 0xfce01000-0xfce017ff] [ 1.747681] pci 0000:0d:00.0: enabling Extended Tags [ 1.747842] pci 0000:0d:00.0: 126.016 Gb/s available PCIe bandwidth, limited by 8.0 GT/s PCIe x16 link at 0000:00:08.2 (capable of 252.048 Gb/s with 16.0 GT/s PCIe x16 link) [ 1.748684] pci 0000:0d:00.1: [1022:7901] type 00 class 0x010601 [ 1.748712] pci 0000:0d:00.1: reg 0x24: [mem 0xfce00000-0xfce007ff] [ 1.748725] pci 0000:0d:00.1: enabling Extended Tags [ 1.749708] pci 0000:00:08.2: PCI bridge to [bus 0d] [ 1.749718] pci 0000:00:08.2: bridge window [mem 0xfce00000-0xfcefffff] [ 1.758356] ACPI: PCI Interrupt Link [LNKA] (IRQs 4 5 7 10 11 14 15) *0 [ 1.759656] ACPI: PCI Interrupt Link [LNKB] (IRQs 4 5 7 10 11 14 15) *0 [ 1.760873] ACPI: PCI Interrupt Link [LNKC] (IRQs 4 5 7 10 11 14 15) *0 [ 1.762239] ACPI: PCI Interrupt Link [LNKD] (IRQs 4 5 7 10 11 14 15) *0 [ 1.763530] ACPI: PCI Interrupt Link [LNKE] (IRQs 4 5 7 10 11 14 15) *0 [ 1.764630] ACPI: PCI Interrupt Link [LNKF] (IRQs 4 5 7 10 11 14 15) *0 [ 1.765726] ACPI: PCI Interrupt Link [LNKG] (IRQs 4 5 7 10 11 14 15) *0 [ 1.766833] ACPI: PCI Interrupt Link [LNKH] (IRQs 4 5 7 10 11 14 15) *0 [ 1.779473] ACPI: EC: interrupt unblocked [ 1.779480] ACPI: EC: event unblocked [ 1.779489] ACPI: EC: EC_CMD/EC_SC=0x66, EC_DATA=0x62 [ 1.779495] ACPI: EC: GPE=0x3 [ 1.779505] ACPI: \_SB_.PCI0.SBRG.EC0_: Boot DSDT EC initialization complete [ 1.779523] ACPI: \_SB_.PCI0.SBRG.EC0_: EC: Used to handle transactions and events [ 1.779871] iommu: Default domain type: Translated [ 1.779965] pci 0000:0c:00.0: vgaarb: VGA device added: decodes=io+mem,owns=none,locks=none [ 1.779965] pci 0000:0c:00.0: vgaarb: bridge control possible [ 1.779965] pci 0000:0c:00.0: vgaarb: setting as boot device [ 1.779965] vgaarb: loaded [ 1.781850] SCSI subsystem initialized [ 1.781893] libata version 3.00 loaded. [ 1.781893] ACPI: bus type USB registered [ 1.781893] usbcore: registered new interface driver usbfs [ 1.781893] usbcore: registered new interface driver hub [ 1.781893] usbcore: registered new device driver usb [ 1.781893] pps_core: LinuxPPS API ver. 1 registered [ 1.781893] pps_core: Software ver. 5.3.6 - Copyright 2005-2007 Rodolfo Giometti [ 1.781893] PTP clock support registered [ 1.781893] EDAC MC: Ver: 3.0.0 [ 1.781893] Registered efivars operations [ 1.785136] NetLabel: Initializing [ 1.785143] NetLabel: domain hash size = 128 [ 1.785148] NetLabel: protocols = UNLABELED CIPSOv4 CALIPSO [ 1.785246] NetLabel: unlabeled traffic allowed by default [ 1.785269] PCI: Using ACPI for IRQ routing [ 1.789174] PCI: pci_cache_line_size set to 64 bytes [ 1.789273] e820: reserve RAM buffer [mem 0x09c10000-0x0bffffff] [ 1.789288] e820: reserve RAM buffer [mem 0x0a200000-0x0bffffff] [ 1.789300] e820: reserve RAM buffer [mem 0x0b000000-0x0bffffff] [ 1.789312] e820: reserve RAM buffer [mem 0xb4c66018-0xb7ffffff] [ 1.789324] e820: reserve RAM buffer [mem 0xb5158000-0xb7ffffff] [ 1.789336] e820: reserve RAM buffer [mem 0xb6dde000-0xb7ffffff] [ 1.789347] e820: reserve RAM buffer [mem 0xb8390000-0xbbffffff] [ 1.789360] e820: reserve RAM buffer [mem 0x21f380000-0x21fffffff] [ 1.789385] hpet0: at MMIO 0xfed00000, IRQs 2, 8, 0 [ 1.789385] hpet0: 3 comparators, 32-bit 14.318180 MHz counter [ 1.791525] clocksource: Switched to clocksource tsc-early [ 1.886355] VFS: Disk quotas dquot_6.6.0 [ 1.886463] VFS: Dquot-cache hash table entries: 512 (order 0, 4096 bytes) [ 1.887380] pnp: PnP ACPI init [ 1.888708] system 00:00: [mem 0xf0000000-0xf7ffffff] has been reserved [ 1.888751] system 00:00: Plug and Play ACPI device, IDs PNP0c01 (active) [ 1.889901] system 00:01: [mem 0x220000000-0x23fffffff window] has been reserved [ 1.889932] system 00:01: Plug and Play ACPI device, IDs PNP0c02 (active) [ 1.892039] pnp 00:02: Plug and Play ACPI device, IDs PNP0b00 (active) [ 1.904512] system 00:03: [io 0x0a00-0x0a0f] has been reserved [ 1.904531] system 00:03: [io 0x0a10-0x0a1f] has been reserved [ 1.904547] system 00:03: [io 0x0a20-0x0a2f] has been reserved [ 1.904564] system 00:03: [io 0x0a30-0x0a3f] has been reserved [ 1.904580] system 00:03: [io 0x0a40-0x0a4f] has been reserved [ 1.904596] system 00:03: [io 0x0a50-0x0a5f] has been reserved [ 1.904614] system 00:03: [io 0x0a60-0x0a6f] has been reserved [ 1.904630] system 00:03: [io 0x0a70-0x0a7f] has been reserved [ 1.904646] system 00:03: [io 0x0a80-0x0a8f] has been reserved [ 1.904662] system 00:03: [io 0x0a90-0x0b8e] has been reserved [ 1.904678] system 00:03: [io 0x0aa0-0x0aaf] has been reserved [ 1.904694] system 00:03: [io 0x0ab0-0x0abf] has been reserved [ 1.904711] system 00:03: [io 0x0ac0-0x0acf] has been reserved [ 1.904727] system 00:03: [io 0x0ad0-0x0adf] has been reserved [ 1.904755] system 00:03: Plug and Play ACPI device, IDs PNP0c02 (active) [ 1.909811] system 00:04: [io 0x04d0-0x04d1] has been reserved [ 1.909829] system 00:04: [io 0x040b] has been reserved [ 1.909845] system 00:04: [io 0x04d6] has been reserved [ 1.909861] system 00:04: [io 0x0c00-0x0c01] has been reserved [ 1.909877] system 00:04: [io 0x0c14] has been reserved [ 1.909893] system 00:04: [io 0x0c50-0x0c51] has been reserved [ 1.909909] system 00:04: [io 0x0c52] has been reserved [ 1.909925] system 00:04: [io 0x0c6c] has been reserved [ 1.909941] system 00:04: [io 0x0c6f] has been reserved [ 1.909957] system 00:04: [io 0x0cd0-0x0cd1] has been reserved [ 1.909973] system 00:04: [io 0x0cd2-0x0cd3] has been reserved [ 1.909990] system 00:04: [io 0x0cd4-0x0cd5] has been reserved [ 1.910006] system 00:04: [io 0x0cd6-0x0cd7] has been reserved [ 1.910022] system 00:04: [io 0x0cd8-0x0cdf] has been reserved [ 1.910038] system 00:04: [io 0x0800-0x089f] has been reserved [ 1.910055] system 00:04: [io 0x0b00-0x0b0f] has been reserved [ 1.910071] system 00:04: [io 0x0b20-0x0b3f] has been reserved [ 1.910088] system 00:04: [io 0x0900-0x090f] has been reserved [ 1.910104] system 00:04: [io 0x0910-0x091f] has been reserved [ 1.910132] system 00:04: [mem 0xfec00000-0xfec00fff] could not be reserved [ 1.910159] system 00:04: [mem 0xfec01000-0xfec01fff] could not be reserved [ 1.910179] system 00:04: [mem 0xfedc0000-0xfedc0fff] has been reserved [ 1.910202] system 00:04: [mem 0xfee00000-0xfee00fff] has been reserved [ 1.910229] system 00:04: [mem 0xfed80000-0xfed8ffff] could not be reserved [ 1.910248] system 00:04: [mem 0xfec10000-0xfec10fff] has been reserved [ 1.910266] system 00:04: [mem 0xff000000-0xffffffff] has been reserved [ 1.910296] system 00:04: Plug and Play ACPI device, IDs PNP0c02 (active) [ 1.920974] pnp: PnP ACPI: found 5 devices [ 1.934928] clocksource: acpi_pm: mask: 0xffffff max_cycles: 0xffffff, max_idle_ns: 2085701024 ns [ 1.935177] NET: Registered protocol family 2 [ 1.936737] tcp_listen_portaddr_hash hash table entries: 4096 (order: 4, 65536 bytes, linear) [ 1.936894] TCP established hash table entries: 65536 (order: 7, 524288 bytes, linear) [ 1.937457] TCP bind hash table entries: 65536 (order: 8, 1048576 bytes, linear) [ 1.937992] TCP: Hash tables configured (established 65536 bind 65536) [ 1.938701] MPTCP token hash table entries: 8192 (order: 5, 196608 bytes, linear) [ 1.938849] UDP hash table entries: 4096 (order: 5, 131072 bytes, linear) [ 1.938946] UDP-Lite hash table entries: 4096 (order: 5, 131072 bytes, linear) [ 1.939477] NET: Registered protocol family 1 [ 1.939502] NET: Registered protocol family 44 [ 1.939541] pci 0000:02:00.0: PCI bridge to [bus 03] [ 1.939565] pci 0000:02:01.0: PCI bridge to [bus 04] [ 1.939580] pci 0000:02:02.0: PCI bridge to [bus 05] [ 1.939595] pci 0000:02:03.0: PCI bridge to [bus 06] [ 1.939610] pci 0000:02:04.0: PCI bridge to [bus 07] [ 1.939625] pci 0000:02:05.0: PCI bridge to [bus 08] [ 1.939640] pci 0000:02:06.0: PCI bridge to [bus 09] [ 1.939647] pci 0000:02:06.0: bridge window [io 0xe000-0xefff] [ 1.939657] pci 0000:02:06.0: bridge window [mem 0xfcc00000-0xfccfffff] [ 1.939671] pci 0000:02:07.0: PCI bridge to [bus 0a] [ 1.939678] pci 0000:02:07.0: bridge window [io 0xd000-0xdfff] [ 1.939687] pci 0000:02:07.0: bridge window [mem 0xfcb00000-0xfcbfffff] [ 1.939700] pci 0000:01:00.2: PCI bridge to [bus 02-0a] [ 1.939707] pci 0000:01:00.2: bridge window [io 0xd000-0xefff] [ 1.939717] pci 0000:01:00.2: bridge window [mem 0xfcb00000-0xfccfffff] [ 1.939730] pci 0000:00:02.1: PCI bridge to [bus 01-0a] [ 1.939736] pci 0000:00:02.1: bridge window [io 0xd000-0xefff] [ 1.939744] pci 0000:00:02.1: bridge window [mem 0xfcb00000-0xfcdfffff] [ 1.939755] pci 0000:00:02.2: PCI bridge to [bus 0b] [ 1.939762] pci 0000:00:02.2: bridge window [mem 0xfcf00000-0xfcffffff] [ 1.939775] pci 0000:00:08.1: PCI bridge to [bus 0c] [ 1.939782] pci 0000:00:08.1: bridge window [io 0xf000-0xffff] [ 1.939790] pci 0000:00:08.1: bridge window [mem 0xfc700000-0xfcafffff] [ 1.939798] pci 0000:00:08.1: bridge window [mem 0xd0000000-0xe01fffff 64bit pref] [ 1.939809] pci 0000:00:08.2: PCI bridge to [bus 0d] [ 1.939816] pci 0000:00:08.2: bridge window [mem 0xfce00000-0xfcefffff] [ 1.939830] pci_bus 0000:00: resource 4 [io 0x0000-0x03af window] [ 1.939838] pci_bus 0000:00: resource 5 [io 0x03e0-0x0cf7 window] [ 1.939845] pci_bus 0000:00: resource 6 [io 0x03b0-0x03df window] [ 1.939852] pci_bus 0000:00: resource 7 [io 0x0d00-0xffff window] [ 1.939859] pci_bus 0000:00: resource 8 [mem 0x000a0000-0x000bffff window] [ 1.939866] pci_bus 0000:00: resource 9 [mem 0x000c0000-0x000dffff window] [ 1.939873] pci_bus 0000:00: resource 10 [mem 0xc0000000-0xfec2ffff window] [ 1.939881] pci_bus 0000:00: resource 11 [mem 0xfee00000-0xffffffff window] [ 1.939889] pci_bus 0000:01: resource 0 [io 0xd000-0xefff] [ 1.939895] pci_bus 0000:01: resource 1 [mem 0xfcb00000-0xfcdfffff] [ 1.939902] pci_bus 0000:02: resource 0 [io 0xd000-0xefff] [ 1.939909] pci_bus 0000:02: resource 1 [mem 0xfcb00000-0xfccfffff] [ 1.939916] pci_bus 0000:09: resource 0 [io 0xe000-0xefff] [ 1.939923] pci_bus 0000:09: resource 1 [mem 0xfcc00000-0xfccfffff] [ 1.939930] pci_bus 0000:0a: resource 0 [io 0xd000-0xdfff] [ 1.939937] pci_bus 0000:0a: resource 1 [mem 0xfcb00000-0xfcbfffff] [ 1.939944] pci_bus 0000:0b: resource 1 [mem 0xfcf00000-0xfcffffff] [ 1.939952] pci_bus 0000:0c: resource 0 [io 0xf000-0xffff] [ 1.939958] pci_bus 0000:0c: resource 1 [mem 0xfc700000-0xfcafffff] [ 1.939965] pci_bus 0000:0c: resource 2 [mem 0xd0000000-0xe01fffff 64bit pref] [ 1.939974] pci_bus 0000:0d: resource 1 [mem 0xfce00000-0xfcefffff] [ 1.942791] pci 0000:0c:00.1: D0 power state depends on 0000:0c:00.0 [ 1.945901] PCI: CLS 64 bytes, default 64 [ 1.946192] Trying to unpack rootfs image as initramfs... [ 2.206923] Freeing initrd memory: 8380K [ 2.337507] pci 0000:00:00.2: AMD-Vi: Unable to read/write to IOMMU perf counter. [ 2.338662] pci 0000:00:00.2: can't derive routing for PCI INT A [ 2.338673] pci 0000:00:00.2: PCI INT A: not connected [ 2.338859] pci 0000:00:01.0: Adding to iommu group 0 [ 2.338992] pci 0000:00:02.0: Adding to iommu group 1 [ 2.339096] pci 0000:00:02.1: Adding to iommu group 2 [ 2.339204] pci 0000:00:02.2: Adding to iommu group 3 [ 2.339341] pci 0000:00:08.0: Adding to iommu group 4 [ 2.339407] pci 0000:00:08.1: Adding to iommu group 4 [ 2.339475] pci 0000:00:08.2: Adding to iommu group 4 [ 2.339588] pci 0000:00:14.0: Adding to iommu group 5 [ 2.339638] pci 0000:00:14.3: Adding to iommu group 5 [ 2.339789] pci 0000:00:18.0: Adding to iommu group 6 [ 2.339839] pci 0000:00:18.1: Adding to iommu group 6 [ 2.339895] pci 0000:00:18.2: Adding to iommu group 6 [ 2.339951] pci 0000:00:18.3: Adding to iommu group 6 [ 2.340000] pci 0000:00:18.4: Adding to iommu group 6 [ 2.340050] pci 0000:00:18.5: Adding to iommu group 6 [ 2.340101] pci 0000:00:18.6: Adding to iommu group 6 [ 2.340151] pci 0000:00:18.7: Adding to iommu group 6 [ 2.340254] pci 0000:01:00.0: Adding to iommu group 7 [ 2.340308] pci 0000:01:00.1: Adding to iommu group 7 [ 2.340362] pci 0000:01:00.2: Adding to iommu group 7 [ 2.340402] pci 0000:02:00.0: Adding to iommu group 7 [ 2.340441] pci 0000:02:01.0: Adding to iommu group 7 [ 2.340481] pci 0000:02:02.0: Adding to iommu group 7 [ 2.340524] pci 0000:02:03.0: Adding to iommu group 7 [ 2.340566] pci 0000:02:04.0: Adding to iommu group 7 [ 2.340606] pci 0000:02:05.0: Adding to iommu group 7 [ 2.340651] pci 0000:02:06.0: Adding to iommu group 7 [ 2.340690] pci 0000:02:07.0: Adding to iommu group 7 [ 2.340731] pci 0000:09:00.0: Adding to iommu group 7 [ 2.340774] pci 0000:0a:00.0: Adding to iommu group 7 [ 2.340865] pci 0000:0b:00.0: Adding to iommu group 8 [ 2.340917] pci 0000:0c:00.0: Adding to iommu group 4 [ 2.340956] pci 0000:0c:00.1: Adding to iommu group 4 [ 2.340996] pci 0000:0c:00.2: Adding to iommu group 4 [ 2.341038] pci 0000:0c:00.3: Adding to iommu group 4 [ 2.341078] pci 0000:0c:00.4: Adding to iommu group 4 [ 2.341122] pci 0000:0c:00.6: Adding to iommu group 4 [ 2.341163] pci 0000:0d:00.0: Adding to iommu group 4 [ 2.341203] pci 0000:0d:00.1: Adding to iommu group 4 [ 2.361821] pci 0000:00:00.2: AMD-Vi: Found IOMMU cap 0x40 [ 2.361839] pci 0000:00:00.2: AMD-Vi: Extended features (0x206d73ef22254ade): [ 2.361846] PPR X2APIC NX GT IA GA PC GA_vAPIC [ 2.361861] AMD-Vi: Interrupt remapping enabled [ 2.361865] AMD-Vi: Virtual APIC enabled [ 2.361870] AMD-Vi: X2APIC enabled [ 2.362272] AMD-Vi: Lazy IO/TLB flushing enabled [ 2.362422] amd_uncore: 4 amd_df counters detected [ 2.362449] amd_uncore: 6 amd_l3 counters detected [ 2.363111] LVT offset 0 assigned for vector 0x400 [ 2.363391] perf: AMD IBS detected (0x000003ff) [ 2.366963] check: Scanning for low memory corruption every 60 seconds [ 2.370830] Initialise system trusted keyrings [ 2.370874] Key type blacklist registered [ 2.371070] workingset: timestamp_bits=41 max_order=21 bucket_order=0 [ 2.387358] zbud: loaded [ 2.392535] Key type asymmetric registered [ 2.392543] Asymmetric key parser 'x509' registered [ 2.392593] Block layer SCSI generic (bsg) driver version 0.4 loaded (major 243) [ 2.392758] io scheduler mq-deadline registered [ 2.392767] io scheduler kyber registered [ 2.393069] io scheduler bfq registered [ 2.395473] pcieport 0000:00:02.1: PME: Signaling with IRQ 26 [ 2.396128] pcieport 0000:00:02.2: PME: Signaling with IRQ 27 [ 2.396753] pcieport 0000:00:08.1: PME: Signaling with IRQ 28 [ 2.398314] pcieport 0000:00:08.2: PME: Signaling with IRQ 29 [ 2.408158] shpchp: Standard Hot Plug PCI Controller Driver version: 0.4 [ 2.408334] efifb: probing for efifb [ 2.408723] efifb: framebuffer at 0xd0000000, using 3072k, total 3072k [ 2.408731] efifb: mode is 1024x768x32, linelength=4096, pages=1 [ 2.408737] efifb: scrolling: redraw [ 2.408741] efifb: Truecolor: size=8:8:8:8, shift=24:16:8:0 [ 2.409539] Console: switching to colour frame buffer device 128x48 [ 2.414601] fb0: EFI VGA frame buffer device [ 2.415135] input: Power Button as /devices/LNXSYSTM:00/LNXSYBUS:00/PNP0C0C:00/input/input0 [ 2.415443] ACPI: button: Power Button [PWRB] [ 2.415762] input: Power Button as /devices/LNXSYSTM:00/LNXPWRBN:00/input/input1 [ 2.417681] ACPI: button: Power Button [PWRF] [ 2.418097] Monitor-Mwait will be used to enter C-1 state [ 2.418214] ACPI: \_PR_.C000: Found 3 idle states [ 2.419216] ACPI: \_PR_.C002: Found 3 idle states [ 2.420364] ACPI: \_PR_.C004: Found 3 idle states [ 2.421422] ACPI: \_PR_.C006: Found 3 idle states [ 2.422445] ACPI: \_PR_.C001: Found 3 idle states [ 2.423446] ACPI: \_PR_.C003: Found 3 idle states [ 2.424566] ACPI: \_PR_.C005: Found 3 idle states [ 2.426058] ACPI: \_PR_.C007: Found 3 idle states [ 2.438042] thermal LNXTHERM:00: registered as thermal_zone0 [ 2.438115] ACPI: thermal: Thermal Zone [HPTZ] (30 C) [ 2.439130] Serial: 8250/16550 driver, 32 ports, IRQ sharing enabled [ 2.452629] Non-volatile memory driver v1.3 [ 2.452687] AMD-Vi: AMD IOMMUv2 driver by Joerg Roedel [ 2.459169] nvme nvme0: pci function 0000:0b:00.0 [ 2.459441] ahci 0000:01:00.1: version 3.0 [ 2.459494] ahci 0000:01:00.1: enabling device (0100 -> 0102) [ 2.460857] ahci 0000:01:00.1: SSS flag set, parallel bus scan disabled [ 2.462739] ahci 0000:01:00.1: AHCI 0001.0301 32 slots 8 ports 6 Gbps 0xff impl SATA mode [ 2.464583] ahci 0000:01:00.1: flags: 64bit ncq sntf stag pm led clo only pmp pio slum part sxs deso sadm sds apst [ 2.464969] ================================================================== [ 2.468288] BUG: KASAN: use-after-free in __iommu_dma_unmap_swiotlb+0x64/0xb0 [ 2.468288] Read of size 8 at addr ffff8881d7830000 by task swapper/0/0 [ 2.468288] CPU: 0 PID: 0 Comm: swapper/0 Not tainted 5.12.0-rc3-debug #1 [ 2.468288] Hardware name: HP HP Desktop M01-F1xxx/87D6, BIOS F.12 12/17/2020 [ 2.468288] Call Trace: [ 2.468288] [ 2.479433] dump_stack+0x9c/0xcf [ 2.479433] print_address_description.constprop.0+0x18/0x130 [ 2.479433] ? __iommu_dma_unmap_swiotlb+0x64/0xb0 [ 2.479433] kasan_report.cold+0x7f/0x111 [ 2.479433] ? __iommu_dma_unmap_swiotlb+0x64/0xb0 [ 2.479433] __iommu_dma_unmap_swiotlb+0x64/0xb0 [ 2.479433] nvme_pci_complete_rq+0x73/0x130 [ 2.479433] blk_complete_reqs+0x6f/0x80 [ 2.479433] __do_softirq+0xfc/0x3be [ 2.479433] irq_exit_rcu+0xce/0x120 [ 2.479433] common_interrupt+0x80/0xa0 [ 2.479433] [ 2.479433] asm_common_interrupt+0x1e/0x40 [ 2.479433] RIP: 0010:cpuidle_enter_state+0xf9/0x590 [ 2.479433] Code: 3d 24 0f 37 6d e8 67 ac 49 ff 49 89 c5 0f 1f 44 00 00 31 ff e8 28 c1 49 ff 80 3c 24 00 0f 85 aa 02 00 00 fb 66 0f 1f 44 00 00 <45> 85 f6 0f 88 39 02 00 00 49 63 ee 48 8d 44 6d 00 48 8d 44 85 00 [ 2.479433] RSP: 0018:ffffffff94007df0 EFLAGS: 00000246 [ 2.479433] RAX: 0000000000000000 RBX: ffff8881075a8000 RCX: ffffffff92144885 [ 2.479433] RDX: dffffc0000000000 RSI: 0000000000000008 RDI: ffff8881d6a35648 [ 2.479433] RBP: 0000000000000003 R08: 0000000000000001 R09: ffff8881d6a356d7 [ 2.479433] R10: ffffed103ad46ada R11: 0000000000000001 R12: ffffffff9445ba80 [ 2.479433] R13: 0000000092ec3156 R14: 0000000000000003 R15: ffffffff9445bc10 [ 2.479433] ? sched_idle_set_state+0x25/0x30 [ 2.479433] ? ladder_select_state+0x350/0x370 [ 2.479433] cpuidle_enter+0x3c/0x60 [ 2.525920] do_idle+0x2fa/0x3c0 [ 2.525920] ? arch_cpu_idle_exit+0x40/0x40 [ 2.525920] cpu_startup_entry+0x19/0x20 [ 2.525920] start_kernel+0x3a9/0x3c7 [ 2.525920] secondary_startup_64_no_verify+0xc2/0xcb [ 2.525920] The buggy address belongs to the page: [ 2.525920] page:0000000016c8183d refcount:0 mapcount:0 mapping:0000000000000000 index:0x0 pfn:0x1d7830 [ 2.525920] flags: 0x2ffff0000000000() [ 2.525920] raw: 02ffff0000000000 dead000000000100 dead000000000122 0000000000000000 [ 2.525920] raw: 0000000000000000 0000000000000000 00000000ffffffff 0000000000000000 [ 2.525920] page dumped because: kasan: bad access detected [ 2.525920] Memory state around the buggy address: [ 2.525920] ffff8881d782ff00: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff [ 2.525920] ffff8881d782ff80: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff [ 2.525920] >ffff8881d7830000: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff [ 2.525920] ^ [ 2.525920] ffff8881d7830080: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff [ 2.525920] ffff8881d7830100: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff [ 2.525920] ================================================================== [ 2.525920] Disabling lock debugging due to kernel taint [ 2.566191] nvme nvme0: missing or invalid SUBNQN field. [ 2.566573] scsi host0: ahci [ 2.571284] scsi host1: ahci [ 2.573925] scsi host2: ahci [ 2.575531] nvme nvme0: 16/0/0 default/read/poll queues [ 2.576652] scsi host3: ahci [ 2.580305] scsi host4: ahci [ 2.582369] nvme0n1: p1 p2 [ 2.583114] scsi host5: ahci [ 2.586918] scsi host6: ahci [ 2.589693] scsi host7: ahci [ 2.591895] ata1: SATA max UDMA/133 abar m131072@0xfcd80000 port 0xfcd80100 irq 44 [ 2.593562] ata2: SATA max UDMA/133 abar m131072@0xfcd80000 port 0xfcd80180 irq 44 [ 2.595213] ata3: SATA max UDMA/133 abar m131072@0xfcd80000 port 0xfcd80200 irq 44 [ 2.596830] ata4: SATA max UDMA/133 abar m131072@0xfcd80000 port 0xfcd80280 irq 44 [ 2.598384] ata5: SATA max UDMA/133 abar m131072@0xfcd80000 port 0xfcd80300 irq 44 [ 2.599856] ata6: SATA max UDMA/133 abar m131072@0xfcd80000 port 0xfcd80380 irq 44 [ 2.601282] ata7: SATA max UDMA/133 abar m131072@0xfcd80000 port 0xfcd80400 irq 44 [ 2.602663] ata8: SATA max UDMA/133 abar m131072@0xfcd80000 port 0xfcd80480 irq 44 [ 2.604233] ahci 0000:0d:00.0: enabling device (0100 -> 0102) [ 2.624072] ahci 0000:0d:00.0: AHCI 0001.0301 32 slots 1 ports 6 Gbps 0x1 impl SATA mode [ 2.626047] ahci 0000:0d:00.0: flags: 64bit ncq sntf ilck pm led clo only pmp fbs pio slum part [ 2.629115] scsi host8: ahci [ 2.631134] ata9: SATA max UDMA/133 abar m2048@0xfce01000 port 0xfce01100 irq 62 [ 2.632725] ahci 0000:0d:00.1: enabling device (0100 -> 0102) [ 2.645647] ahci 0000:0d:00.1: AHCI 0001.0301 32 slots 1 ports 6 Gbps 0x1 impl SATA mode [ 2.647377] ahci 0000:0d:00.1: flags: 64bit ncq sntf ilck pm led clo only pmp fbs pio slum part [ 2.650684] scsi host9: ahci [ 2.652987] ata10: SATA max UDMA/133 abar m2048@0xfce00000 port 0xfce00100 irq 64 [ 2.654771] ehci_hcd: USB 2.0 'Enhanced' Host Controller (EHCI) Driver [ 2.656479] ehci-pci: EHCI PCI platform driver [ 2.658223] ohci_hcd: USB 1.1 'Open' Host Controller (OHCI) Driver [ 2.659922] ohci-pci: OHCI PCI platform driver [ 2.661613] uhci_hcd: USB Universal Host Controller Interface driver [ 2.663598] usbcore: registered new interface driver usbserial_generic [ 2.665273] usbserial: USB Serial support registered for generic [ 2.667509] rtc_cmos 00:02: RTC can wake from S4 [ 2.670325] rtc_cmos 00:02: registered as rtc0 [ 2.672456] rtc_cmos 00:02: setting system clock to 2021-07-03T05:52:35 UTC (1625291555) [ 2.674292] rtc_cmos 00:02: alarms up to one month, y3k, 114 bytes nvram, hpet irqs [ 2.676648] ledtrig-cpu: registered to indicate activity on CPUs [ 2.680761] hid: raw HID events driver (C) Jiri Kosina [ 2.682838] drop_monitor: Initializing network drop monitor service [ 2.684723] Initializing XFRM netlink socket [ 2.687522] NET: Registered protocol family 10 [ 2.706529] Segment Routing with IPv6 [ 2.708311] RPL Segment Routing with IPv6 [ 2.710080] NET: Registered protocol family 17 [ 2.717145] microcode: CPU0: patch_level=0x08600106 [ 2.719302] microcode: CPU1: patch_level=0x08600106 [ 2.721700] microcode: CPU2: patch_level=0x08600106 [ 2.723611] microcode: CPU3: patch_level=0x08600106 [ 2.725354] microcode: CPU4: patch_level=0x08600106 [ 2.727673] microcode: CPU5: patch_level=0x08600106 [ 2.729894] microcode: CPU6: patch_level=0x08600106 [ 2.732003] microcode: CPU7: patch_level=0x08600106 [ 2.733779] microcode: Microcode Update Driver: v2.2. [ 2.734648] resctrl: L3 allocation detected [ 2.738008] resctrl: L3DATA allocation detected [ 2.739649] resctrl: L3CODE allocation detected [ 2.741298] resctrl: MB allocation detected [ 2.742960] resctrl: L3 monitoring detected [ 2.744639] IPI shorthand broadcast: enabled [ 2.746420] sched_clock: Marking stable (2741486890, 3147034)->(2749935265, -5301341) [ 2.748947] registered taskstats version 1 [ 2.750823] Loading compiled-in X.509 certificates [ 2.762366] Loaded X.509 cert 'Build time autogenerated kernel key: 2e7560f4a0c00f3b7155a946e3c119b89f094b3b' [ 2.768372] zswap: loaded using pool lz4/z3fold [ 2.771903] Key type ._fscrypt registered [ 2.773785] Key type .fscrypt registered [ 2.775622] Key type fscrypt-provisioning registered [ 2.784028] PM: Magic number: 13:98:870 [ 2.787045] RAS: Correctable Errors collector initialized. [ 2.917218] ata1: SATA link down (SStatus 0 SControl 300) [ 2.943732] ata9: SATA link down (SStatus 0 SControl 300) [ 2.966342] ata10: SATA link down (SStatus 0 SControl 300) [ 3.233062] ata2: SATA link down (SStatus 0 SControl 300) [ 3.384422] tsc: Refined TSC clocksource calibration: 3819.247 MHz [ 3.386233] clocksource: tsc: mask: 0xffffffffffffffff max_cycles: 0x6e1abb3f6be, max_idle_ns: 881590761792 ns [ 3.388357] clocksource: Switched to clocksource tsc [ 3.546862] ata3: SATA link down (SStatus 0 SControl 300) [ 3.859988] ata4: SATA link down (SStatus 0 SControl 300) [ 4.173723] ata5: SATA link down (SStatus 0 SControl 300) [ 4.485990] ata6: SATA link down (SStatus 0 SControl 300) [ 4.800108] ata7: SATA link down (SStatus 0 SControl 300) [ 5.113290] ata8: SATA link down (SStatus 0 SControl 300) [ 5.124842] Freeing unused decrypted memory: 2036K [ 5.127293] Freeing unused kernel image (initmem) memory: 2012K [ 5.128839] Write protecting the kernel read-only data: 32768k [ 5.131774] Freeing unused kernel image (text/rodata gap) memory: 2036K [ 5.134151] Freeing unused kernel image (rodata/data gap) memory: 1768K [ 5.193177] x86/mm: Checked W+X mappings: passed, no W+X pages found. [ 5.194740] rodata_test: all tests were successful [ 5.196302] Run /init as init process [ 5.197816] with arguments: [ 5.199318] /init [ 5.200791] with environment: [ 5.202284] HOME=/ [ 5.203786] TERM=linux [ 5.672103] xhci_hcd 0000:01:00.0: xHCI Host Controller [ 5.674778] xhci_hcd 0000:01:00.0: new USB bus registered, assigned bus number 1 [ 5.731851] xhci_hcd 0000:01:00.0: hcc params 0x0200ef81 hci version 0x110 quirks 0x0000000000000410 [ 5.736868] usb usb1: New USB device found, idVendor=1d6b, idProduct=0002, bcdDevice= 5.12 [ 5.738700] usb usb1: New USB device strings: Mfr=3, Product=2, SerialNumber=1 [ 5.740524] usb usb1: Product: xHCI Host Controller [ 5.742360] usb usb1: Manufacturer: Linux 5.12.0-rc3-debug xhci-hcd [ 5.744342] usb usb1: SerialNumber: 0000:01:00.0 [ 5.747557] hub 1-0:1.0: USB hub found [ 5.749393] hub 1-0:1.0: 14 ports detected [ 5.758482] xhci_hcd 0000:01:00.0: xHCI Host Controller [ 5.760257] xhci_hcd 0000:01:00.0: new USB bus registered, assigned bus number 2 [ 5.761988] xhci_hcd 0000:01:00.0: Host supports USB 3.1 Enhanced SuperSpeed [ 5.763890] usb usb2: We don't know the algorithms for LPM for this host, disabling LPM. [ 5.766015] usb usb2: New USB device found, idVendor=1d6b, idProduct=0003, bcdDevice= 5.12 [ 5.767821] usb usb2: New USB device strings: Mfr=3, Product=2, SerialNumber=1 [ 5.769624] usb usb2: Product: xHCI Host Controller [ 5.771537] usb usb2: Manufacturer: Linux 5.12.0-rc3-debug xhci-hcd [ 5.773341] usb usb2: SerialNumber: 0000:01:00.0 [ 5.776368] hub 2-0:1.0: USB hub found [ 5.778218] hub 2-0:1.0: 8 ports detected [ 5.786159] xhci_hcd 0000:0c:00.3: xHCI Host Controller [ 5.788013] xhci_hcd 0000:0c:00.3: new USB bus registered, assigned bus number 3 [ 5.790016] xhci_hcd 0000:0c:00.3: hcc params 0x0268ffe5 hci version 0x110 quirks 0x0000000000000410 [ 5.794538] usb usb3: New USB device found, idVendor=1d6b, idProduct=0002, bcdDevice= 5.12 [ 5.796327] usb usb3: New USB device strings: Mfr=3, Product=2, SerialNumber=1 [ 5.798153] usb usb3: Product: xHCI Host Controller [ 5.799989] usb usb3: Manufacturer: Linux 5.12.0-rc3-debug xhci-hcd [ 5.801878] usb usb3: SerialNumber: 0000:0c:00.3 [ 5.804989] hub 3-0:1.0: USB hub found [ 5.806943] hub 3-0:1.0: 4 ports detected [ 5.810968] xhci_hcd 0000:0c:00.3: xHCI Host Controller [ 5.812911] xhci_hcd 0000:0c:00.3: new USB bus registered, assigned bus number 4 [ 5.814852] xhci_hcd 0000:0c:00.3: Host supports USB 3.1 Enhanced SuperSpeed [ 5.816914] usb usb4: We don't know the algorithms for LPM for this host, disabling LPM. [ 5.819226] usb usb4: New USB device found, idVendor=1d6b, idProduct=0003, bcdDevice= 5.12 [ 5.821220] usb usb4: New USB device strings: Mfr=3, Product=2, SerialNumber=1 [ 5.823188] usb usb4: Product: xHCI Host Controller [ 5.825148] usb usb4: Manufacturer: Linux 5.12.0-rc3-debug xhci-hcd [ 5.827132] usb usb4: SerialNumber: 0000:0c:00.3 [ 5.830304] hub 4-0:1.0: USB hub found [ 5.832356] hub 4-0:1.0: 2 ports detected [ 5.836607] xhci_hcd 0000:0c:00.4: xHCI Host Controller [ 5.838724] xhci_hcd 0000:0c:00.4: new USB bus registered, assigned bus number 5 [ 5.841046] xhci_hcd 0000:0c:00.4: hcc params 0x0268ffe5 hci version 0x110 quirks 0x0000000000000410 [ 5.845927] usb usb5: New USB device found, idVendor=1d6b, idProduct=0002, bcdDevice= 5.12 [ 5.848104] usb usb5: New USB device strings: Mfr=3, Product=2, SerialNumber=1 [ 5.850279] usb usb5: Product: xHCI Host Controller [ 5.852448] usb usb5: Manufacturer: Linux 5.12.0-rc3-debug xhci-hcd [ 5.854628] usb usb5: SerialNumber: 0000:0c:00.4 [ 5.857964] hub 5-0:1.0: USB hub found [ 5.860097] hub 5-0:1.0: 4 ports detected [ 5.864318] xhci_hcd 0000:0c:00.4: xHCI Host Controller [ 5.866417] xhci_hcd 0000:0c:00.4: new USB bus registered, assigned bus number 6 [ 5.868521] xhci_hcd 0000:0c:00.4: Host supports USB 3.1 Enhanced SuperSpeed [ 5.870764] usb usb6: We don't know the algorithms for LPM for this host, disabling LPM. [ 5.873234] usb usb6: New USB device found, idVendor=1d6b, idProduct=0003, bcdDevice= 5.12 [ 5.875410] usb usb6: New USB device strings: Mfr=3, Product=2, SerialNumber=1 [ 5.877581] usb usb6: Product: xHCI Host Controller [ 5.879736] usb usb6: Manufacturer: Linux 5.12.0-rc3-debug xhci-hcd [ 5.881917] usb usb6: SerialNumber: 0000:0c:00.4 [ 5.885175] hub 6-0:1.0: USB hub found [ 5.887373] hub 6-0:1.0: 2 ports detected [ 5.972196] random: fast init done [ 6.087608] usb 1-11: new full-speed USB device number 2 using xhci_hcd [ 6.273180] SGI XFS with ACLs, security attributes, realtime, scrub, repair, quota, no debug enabled [ 6.283881] XFS (nvme0n1p2): Mounting V5 Filesystem [ 6.301438] XFS (nvme0n1p2): Ending clean mount [ 6.307594] xfs filesystem being mounted at /new_root supports timestamps until 2038 (0x7fffffff) [ 6.423979] usb 1-11: New USB device found, idVendor=046d, idProduct=c534, bcdDevice=29.01 [ 6.426964] usb 1-11: New USB device strings: Mfr=1, Product=2, SerialNumber=0 [ 6.429116] usb 1-11: Product: USB Receiver [ 6.431270] usb 1-11: Manufacturer: Logitech [ 6.512460] random: crng init done [ 6.514601] systemd[1]: Successfully credited entropy passed from boot loader. [ 6.519182] systemd[1]: systemd 248.3-2-arch running in system mode. (+PAM +AUDIT -SELINUX -APPARMOR -IMA +SMACK +SECCOMP +GCRYPT +GNUTLS +OPENSSL +ACL +BLKID +CURL +ELFUTILS +FIDO2 +IDN2 -IDN +IPTC +KMOD +LIBCRYPTSETUP +LIBFDISK +PCRE2 -PWQUALITY +P11KIT -QRENCODE +BZIP2 +LZ4 +XZ +ZLIB +ZSTD +XKBCOMMON +UTMP -SYSVINIT default-hierarchy=unified) [ 6.526303] systemd[1]: No virtualization found in DMI [ 6.544505] systemd[1]: UML virtualization not found in /proc/cpuinfo. [ 6.547123] systemd[1]: No virtualization found in CPUID [ 6.549421] systemd[1]: Virtualization XEN not found, /proc/xen does not exist [ 6.551947] systemd[1]: This platform does not support /proc/device-tree [ 6.554174] systemd[1]: This platform does not support /proc/sysinfo [ 6.556362] systemd[1]: Found VM virtualization none [ 6.558608] systemd[1]: Detected architecture x86-64. [ 6.561488] systemd[1]: Detected initialized system, this is not the first boot. [ 6.572027] systemd[1]: Hostname set to . [ 6.575932] systemd[1]: Successfully added address 127.0.0.1 to loopback interface [ 6.578272] systemd[1]: Successfully added address ::1 to loopback interface [ 6.580513] systemd[1]: Successfully brought loopback interface up [ 6.583278] systemd[1]: Setting 'fs/file-max' to '9223372036854775807'. [ 6.585597] systemd[1]: Setting 'fs/nr_open' to '2147483640'. [ 6.587895] systemd[1]: Couldn't write fs.nr_open as 2147483640, halving it. [ 6.590142] systemd[1]: Setting 'fs/nr_open' to '1073741816'. [ 6.592386] systemd[1]: Successfully bumped fs.nr_open to 1073741816 [ 6.596797] systemd[1]: Found cgroup2 on /sys/fs/cgroup/, full unified hierarchy [ 6.599105] systemd[1]: Unified cgroup hierarchy is located at /sys/fs/cgroup. [ 6.612552] systemd[1]: Got EBADF when using BPF_F_ALLOW_MULTI, which indicates it is supported. Yay! [ 6.615700] systemd[1]: Controller 'cpu' supported: yes [ 6.618063] systemd[1]: Controller 'cpuacct' supported: no [ 6.620391] systemd[1]: Controller 'cpuset' supported: yes [ 6.622710] systemd[1]: Controller 'io' supported: yes [ 6.624999] systemd[1]: Controller 'blkio' supported: no [ 6.627232] systemd[1]: Controller 'memory' supported: yes [ 6.629416] systemd[1]: Controller 'devices' supported: no [ 6.631609] systemd[1]: Controller 'pids' supported: yes [ 6.633741] systemd[1]: Controller 'bpf-firewall' supported: yes [ 6.635832] systemd[1]: Controller 'bpf-devices' supported: yes [ 6.637483] usb 1-12: new full-speed USB device number 3 using xhci_hcd [ 6.638244] systemd[1]: Set up TFD_TIMER_CANCEL_ON_SET timerfd. [ 6.643315] systemd[1]: Enabling (yes) showing of status (commandline). [ 6.646012] systemd[1]: Serializing system-environment-generators to memfd. [ 6.649222] systemd[1]: Successfully forked off '(sd-executor)' as PID 242. [ 6.650166] systemd[242]: Serializing 10-arch to memfd. [ 6.654825] systemd[242]: Successfully forked off '(direxec)' as PID 243. [ 6.676007] systemd[242]: /usr/lib/systemd/system-environment-generators/10-arch succeeded. [ 6.680054] systemd[1]: (sd-executor) succeeded. [ 6.683877] systemd[1]: Successfully forked off '(sd-executor)' as PID 244. [ 6.687068] systemd[244]: Successfully forked off '(direxec)' as PID 245. [ 6.690471] systemd[244]: Successfully forked off '(direxec)' as PID 246. [ 6.693787] systemd[244]: Successfully forked off '(direxec)' as PID 247. [ 6.694955] systemd-bless-boot-generator[245]: Skipping generator, not booted with boot counting in effect. [ 6.697112] systemd[244]: Successfully forked off '(direxec)' as PID 248. [ 6.703122] systemd[244]: Successfully forked off '(direxec)' as PID 249. [ 6.707898] systemd[244]: Successfully forked off '(direxec)' as PID 250. [ 6.708383] systemd-fstab-generator[248]: Parsing /etc/fstab... [ 6.712179] systemd[244]: Successfully forked off '(direxec)' as PID 251. [ 6.713256] systemd-fstab-generator[248]: Found entry what=tmpfs where=/tmp type=tmpfs makefs=no growfs=no noauto=no nofail=no [ 6.715761] systemd-gpt-auto-generator[250]: Disabling root partition auto-detection, root= is defined. [ 6.717146] systemd[244]: Successfully forked off '(direxec)' as PID 252. [ 6.719246] systemd[244]: Successfully forked off '(direxec)' as PID 253. [ 6.719689] systemd-hibernate-resume-generator[251]: Not running in an initrd, quitting. [ 6.721290] systemd[244]: Successfully forked off '(direxec)' as PID 254. [ 6.721414] systemd[244]: /usr/lib/systemd/system-generators/systemd-bless-boot-generator succeeded. [ 6.721802] systemd-fstab-generator[248]: Found entry what=/dev/disk/by-uuid/5457d04f-1fb0-4138-8f28-be95c401b449 where=/ type=xfs makefs=no growfs=no noauto=no nofail=no [ 6.725160] systemd-gpt-auto-generator[250]: Failed to chase block device '/', ignoring: No such file or directory [ 6.728250] systemd-fstab-generator[248]: Found entry what= [ 6.730487] systemd[244]: /usr/lib/systemd/system-generators/systemd-veritysetup-generator succeeded. [ 6.731508] systemd-gpt-auto-generator[250]: nvme0n1p2: Root device /dev/nvme0n1. [ 6.732467] systemd-fstab-generator[248]: where= type= makefs=no growfs=no noauto=no nofail=no [ 6.735097] systemd[244]: /usr/lib/systemd/system-generators/systemd-debug-generator succeeded. [ 6.737246] systemd-fstab-generator[248]: Mount point is not a valid path, ignoring. [ 6.759523] systemd-fstab-generator[248]: Found entry what=/dev/disk/by-uuid/BABE-8F35 where=/boot type=vfat makefs=no growfs=no noauto=no nofail=no [ 6.759864] systemd-fstab-generator[248]: Checking was requested for /dev/disk/by-uuid/BABE-8F35, but fsck.vfat does not exist. [ 6.767403] systemd[244]: /usr/lib/systemd/system-generators/systemd-getty-generator succeeded. [ 6.770973] systemd-fstab-generator[248]: Found entry what= [ 6.772029] systemd-gpt-auto-generator[250]: /boot specified in fstab, ignoring. [ 6.773734] systemd[244]: /usr/lib/systemd/system-generators/systemd-gpt-auto-generator succeeded. [ 6.776211] systemd-fstab-generator[248]: where= type= makefs=no growfs=no noauto=no nofail=no [ 6.778971] systemd[244]: /usr/lib/systemd/system-generators/systemd-cryptsetup-generator succeeded. [ 6.781788] systemd-fstab-generator[248]: Mount point is not a valid path, ignoring. [ 6.784696] systemd[244]: /usr/lib/systemd/system-generators/systemd-run-generator succeeded. [ 6.793437] systemd[244]: /usr/lib/systemd/system-generators/systemd-fstab-generator succeeded. [ 6.796378] systemd[244]: /usr/lib/systemd/system-generators/systemd-system-update-generator succeeded. [ 6.799363] systemd[244]: /usr/lib/systemd/system-generators/systemd-hibernate-resume-generator succeeded. [ 6.803548] systemd[1]: (sd-executor) succeeded. [ 6.806739] systemd[1]: Looking for unit files in (higher priority first): [ 6.809609] systemd[1]: /etc/systemd/system.control [ 6.812462] systemd[1]: /run/systemd/system.control [ 6.815276] systemd[1]: /run/systemd/transient [ 6.818037] systemd[1]: /run/systemd/generator.early [ 6.820789] systemd[1]: /etc/systemd/system [ 6.823485] systemd[1]: /etc/systemd/system.attached [ 6.826236] systemd[1]: /run/systemd/system [ 6.828956] systemd[1]: /run/systemd/system.attached [ 6.831666] systemd[1]: /run/systemd/generator [ 6.834269] systemd[1]: /usr/local/lib/systemd/system [ 6.836896] systemd[1]: /usr/lib/systemd/system [ 6.839528] systemd[1]: /run/systemd/generator.late [ 6.845675] systemd[1]: Modification times have changed, need to update cache. [ 6.850304] systemd[1]: unit_file_build_name_map: alias: /etc/systemd/system/dbus-org.freedesktop.network1.service \xe2\x86\x92 systemd-networkd.service [ 6.856480] systemd[1]: unit_file_build_name_map: alias: /etc/systemd/system/dbus-org.freedesktop.resolve1.service \xe2\x86\x92 systemd-resolved.service [ 6.863257] systemd[1]: unit_file_build_name_map: alias: /etc/systemd/system/display-manager.service \xe2\x86\x92 lightdm.service [ 6.866353] systemd[1]: unit_file_build_name_map: normal unit file: /run/systemd/generator/boot.mount [ 6.869294] systemd[1]: unit_file_build_name_map: normal unit file: /run/systemd/generator/-.mount [ 6.872181] systemd[1]: unit_file_build_name_map: normal unit file: /run/systemd/generator/tmp.mount [ 6.875369] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/nscd.service [ 6.878183] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/e2scrub@.service [ 6.880963] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/e2scrub_all.service [ 6.883569] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/e2scrub_all.timer [ 6.886114] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/e2scrub_fail@.service [ 6.888620] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/e2scrub_reap.service [ 6.891050] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/krb5-kadmind.service [ 6.893434] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/krb5-kdc.service [ 6.895760] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/krb5-kpropd.service [ 6.898037] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/krb5-kpropd.socket [ 6.900256] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/krb5-kpropd@.service [ 6.902397] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/auditd.service [ 6.904446] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/pam_namespace.service [ 6.906420] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/shadow.service [ 6.908333] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/shadow.timer [ 6.910192] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/fstrim.service [ 6.912016] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/fstrim.timer [ 6.913777] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/rfkill-block@.service [ 6.915500] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/rfkill-unblock@.service [ 6.917175] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/uuidd.service [ 6.918800] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/uuidd.socket [ 6.920355] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/dm-event.service [ 6.921915] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/dm-event.socket [ 6.923449] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/dbus.service [ 6.924964] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/dbus.socket [ 6.926407] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/ip6tables.service [ 6.927831] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/iptables.service [ 6.930110] systemd[1]: unit_file_build_name_map: alias: /usr/lib/systemd/system/autovt@.service \xe2\x86\x92 getty@.service [ 6.931600] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/basic.target [ 6.933085] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/blockdev@.target [ 6.934657] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/bluetooth.target [ 6.936130] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/boot-complete.target [ 6.937632] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/console-getty.service [ 6.939126] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/container-getty@.service [ 6.940631] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/cryptsetup-pre.target [ 6.942179] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/cryptsetup.target [ 6.944347] systemd[1]: unit_file_build_name_map: alias: /usr/lib/systemd/system/ctrl-alt-del.target \xe2\x86\x92 reboot.target [ 6.946586] systemd[1]: unit_file_build_name_map: alias: /usr/lib/systemd/system/dbus-org.freedesktop.hostname1.service \xe2\x86\x92 systemd-hostnamed.service [ 6.948141] usb 1-12: New USB device found, idVendor=0bda, idProduct=b00a, bcdDevice= 1.10 [ 6.949923] systemd[1]: unit_file_build_name_map: alias: /usr/lib/systemd/system/dbus-org.freedesktop.import1.service \xe2\x86\x92 systemd-importd.service [ 6.951214] usb 1-12: New USB device strings: Mfr=1, Product=2, SerialNumber=3 [ 6.951218] usb 1-12: Product: Bluetooth Radio [ 6.951221] usb 1-12: Manufacturer: Realtek [ 6.951224] usb 1-12: SerialNumber: 00e04c000001 [ 6.960240] systemd[1]: unit_file_build_name_map: alias: /usr/lib/systemd/system/dbus-org.freedesktop.locale1.service \xe2\x86\x92 systemd-localed.service [ 6.963512] systemd[1]: unit_file_build_name_map: alias: /usr/lib/systemd/system/dbus-org.freedesktop.login1.service \xe2\x86\x92 systemd-logind.service [ 6.967129] systemd[1]: unit_file_build_name_map: alias: /usr/lib/systemd/system/dbus-org.freedesktop.machine1.service \xe2\x86\x92 systemd-machined.service [ 6.971105] systemd[1]: unit_file_build_name_map: alias: /usr/lib/systemd/system/dbus-org.freedesktop.oom1.service \xe2\x86\x92 systemd-oomd.service [ 6.975430] systemd[1]: unit_file_build_name_map: alias: /usr/lib/systemd/system/dbus-org.freedesktop.portable1.service \xe2\x86\x92 systemd-portabled.service [ 6.980097] systemd[1]: unit_file_build_name_map: alias: /usr/lib/systemd/system/dbus-org.freedesktop.timedate1.service \xe2\x86\x92 systemd-timedated.service [ 6.984954] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/debug-shell.service [ 6.987737] systemd[1]: unit_file_build_name_map: alias: /usr/lib/systemd/system/default.target \xe2\x86\x92 graphical.target [ 6.990354] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/dev-hugepages.mount [ 6.993004] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/dev-mqueue.mount [ 6.995660] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/emergency.service [ 6.998322] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/emergency.target [ 7.000974] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/exit.target [ 7.003615] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/final.target [ 7.006254] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/first-boot-complete.target [ 7.008911] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/getty-pre.target [ 7.011574] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/getty.target [ 7.014226] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/getty@.service [ 7.016876] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/graphical.target [ 7.019531] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/halt.target [ 7.022186] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/hibernate.target [ 7.024847] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/hybrid-sleep.target [ 7.027513] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/initrd-cleanup.service [ 7.030139] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/initrd-fs.target [ 7.032744] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/initrd-parse-etc.service [ 7.035352] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/initrd-root-device.target [ 7.037972] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/initrd-root-fs.target [ 7.040576] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/initrd-switch-root.service [ 7.043185] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/initrd-switch-root.target [ 7.045788] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/initrd-udevadm-cleanup-db.service [ 7.048385] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/initrd.target [ 7.050982] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/kexec.target [ 7.053539] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/kmod-static-nodes.service [ 7.056091] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/ldconfig.service [ 7.058560] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/local-fs-pre.target [ 7.061013] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/local-fs.target [ 7.063340] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/machine.slice [ 7.065635] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/machines.target [ 7.067821] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/modprobe@.service [ 7.069984] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/multi-user.target [ 7.072149] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/network-online.target [ 7.074314] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/network-pre.target [ 7.076390] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/network.target [ 7.078380] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/nss-lookup.target [ 7.080285] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/nss-user-lookup.target [ 7.082114] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/paths.target [ 7.083838] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/poweroff.target [ 7.085486] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/printer.target [ 7.087037] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/proc-sys-fs-binfmt_misc.automount [ 7.088535] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/proc-sys-fs-binfmt_misc.mount [ 7.089934] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/quotaon.service [ 7.091252] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/reboot.target [ 7.092494] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/remote-cryptsetup.target [ 7.093651] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/remote-fs-pre.target [ 7.094730] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/remote-fs.target [ 7.095759] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/remote-veritysetup.target [ 7.096760] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/rescue.service [ 7.097755] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/rescue.target [ 7.098738] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/rpcbind.target [ 7.099729] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/serial-getty@.service [ 7.100725] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/shutdown.target [ 7.101726] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/sigpwr.target [ 7.102714] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/sleep.target [ 7.103691] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/slices.target [ 7.104668] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/smartcard.target [ 7.105647] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/sockets.target [ 7.106628] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/sound.target [ 7.107608] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/suspend-then-hibernate.target [ 7.108608] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/suspend.target [ 7.109596] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/swap.target [ 7.110574] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/sys-fs-fuse-connections.mount [ 7.111581] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/sys-kernel-config.mount [ 7.112589] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/sys-kernel-debug.mount [ 7.113585] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/sys-kernel-tracing.mount [ 7.114596] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/sysinit.target [ 7.115592] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/syslog.socket [ 7.116586] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/system-systemd\x2dcryptsetup.slice [ 7.118571] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/system-update-cleanup.service [ 7.119742] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/system-update-pre.target [ 7.120901] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/system-update.target [ 7.122044] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/systemd-ask-password-console.path [ 7.123206] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/systemd-ask-password-console.service [ 7.125488] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/systemd-ask-password-wall.path [ 7.126811] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/systemd-ask-password-wall.service [ 7.128135] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/systemd-backlight@.service [ 7.129455] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/systemd-binfmt.service [ 7.130771] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/systemd-bless-boot.service [ 7.132096] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/systemd-boot-check-no-failures.service [ 7.134745] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/systemd-boot-system-token.service [ 7.136252] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/systemd-coredump.socket [ 7.137755] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/systemd-coredump@.service [ 7.139256] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/systemd-exit.service [ 7.140757] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/systemd-firstboot.service [ 7.142252] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/systemd-fsck-root.service [ 7.143740] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/systemd-fsck@.service [ 7.145216] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/systemd-halt.service [ 7.146691] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/systemd-hibernate-resume@.service [ 7.148178] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/systemd-hibernate.service [ 7.149658] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/systemd-homed-activate.service [ 7.151143] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/systemd-homed.service [ 7.152627] systemd[1]: unit_file_build_name_map: normal unit file: /usr/lib/systemd/system/systemd-hostnamed.service [ 7.324732] Linux agpgart interface v0.103 [ 7.339568] fuse: init (API version 7.33) [ 7.355563] systemd-journald[265]: Auditing in kernel turned on. [ 7.359014] systemd-journald[265]: Journal effective settings seal=no keyed_hash=yes compress=yes compress_threshold_bytes=512B [ 7.359112] systemd-journald[265]: Fixed min_use=16.0M max_use=313.3M max_size=39.1M min_size=512.0K keep_free=156.6M n_max_files=100 [ 7.367696] XFS: attr2 mount option is deprecated. [ 7.368118] systemd-journald[265]: Reserving 333 entries in field hash table. [ 7.372374] xfs filesystem being remounted at / supports timestamps until 2038 (0x7fffffff) [ 7.374992] Asymmetric key parser 'pkcs8' registered [ 7.377914] systemd-journald[265]: Reserving 71310 entries in data hash table. [ 7.381564] systemd-journald[265]: Vacuuming... [ 7.381627] systemd-journald[265]: Vacuuming done, freed 0B of archived journals from /run/log/journal/983425690c9a4432866996cdc56b7fd4. [ 7.381665] systemd-journald[265]: Flushing /dev/kmsg... [ 7.404037] audit: type=1130 audit(1625291560.226:2): pid=1 uid=0 auid=4294967295 ses=4294967295 msg='unit=kmod-static-nodes comm="systemd" exe="/usr/lib/systemd/systemd" hostname=? addr=? terminal=? res=success' [ 7.412624] audit: type=1130 audit(1625291560.236:3): pid=1 uid=0 auid=4294967295 ses=4294967295 msg='unit=modprobe@configfs comm="systemd" exe="/usr/lib/systemd/systemd" hostname=? addr=? terminal=? res=success' [ 7.419004] audit: type=1131 audit(1625291560.236:4): pid=1 uid=0 auid=4294967295 ses=4294967295 msg='unit=modprobe@configfs comm="systemd" exe="/usr/lib/systemd/systemd" hostname=? addr=? terminal=? res=success' [ 7.427185] audit: type=1130 audit(1625291560.249:5): pid=1 uid=0 auid=4294967295 ses=4294967295 msg='unit=modprobe@drm comm="systemd" exe="/usr/lib/systemd/systemd" hostname=? addr=? terminal=? res=success' [ 7.434060] audit: type=1131 audit(1625291560.249:6): pid=1 uid=0 auid=4294967295 ses=4294967295 msg='unit=modprobe@drm comm="systemd" exe="/usr/lib/systemd/systemd" hostname=? addr=? terminal=? res=success' [ 7.444751] audit: type=1130 audit(1625291560.266:7): pid=1 uid=0 auid=4294967295 ses=4294967295 msg='unit=modprobe@fuse comm="systemd" exe="/usr/lib/systemd/systemd" hostname=? addr=? terminal=? res=success' [ 7.451199] audit: type=1131 audit(1625291560.266:8): pid=1 uid=0 auid=4294967295 ses=4294967295 msg='unit=modprobe@fuse comm="systemd" exe="/usr/lib/systemd/systemd" hostname=? addr=? terminal=? res=success' [ 7.462023] audit: type=1130 audit(1625291560.286:9): pid=1 uid=0 auid=4294967295 ses=4294967295 msg='unit=systemd-modules-load comm="systemd" exe="/usr/lib/systemd/systemd" hostname=? addr=? terminal=? res=success' [ 7.472536] audit: type=1130 audit(1625291560.296:10): pid=1 uid=0 auid=4294967295 ses=4294967295 msg='unit=systemd-remount-fs comm="systemd" exe="/usr/lib/systemd/systemd" hostname=? addr=? terminal=? res=success' [ 7.554217] audit: type=1130 audit(1625291560.376:11): pid=1 uid=0 auid=4294967295 ses=4294967295 msg='unit=systemd-binfmt comm="systemd" exe="/usr/lib/systemd/systemd" hostname=? addr=? terminal=? res=success' [ 7.619871] systemd-journald[265]: systemd-journald running as PID 265 for the system. [ 7.620170] systemd-journald[265]: Sent READY=1 notification. [ 7.620230] systemd-journald[265]: Sent WATCHDOG=1 notification. [ 7.622326] systemd-journald[265]: Successfully sent stream file descriptor to service manager. [ 7.636767] systemd-journald[265]: Successfully sent stream file descriptor to service manager. [ 7.640546] systemd-journald[265]: Successfully sent stream file descriptor to service manager. [ 7.645323] systemd-journald[265]: Successfully sent stream file descriptor to service manager. [ 7.649119] systemd-journald[265]: Successfully sent stream file descriptor to service manager. [ 7.649502] systemd-journald[265]: Successfully sent stream file descriptor to service manager. [ 7.649868] systemd-journald[265]: Successfully sent stream file descriptor to service manager. [ 7.650251] systemd-journald[265]: Successfully sent stream file descriptor to service manager. [ 7.650623] systemd-journald[265]: Successfully sent stream file descriptor to service manager. [ 7.651251] systemd-journald[265]: Successfully sent stream file descriptor to service manager. [ 7.651514] systemd-journald[265]: Successfully sent stream file descriptor to service manager. [ 7.652468] systemd-journald[265]: Successfully sent stream file descriptor to service manager. [ 7.677672] systemd-journald[265]: Successfully sent stream file descriptor to service manager. [ 7.680654] systemd-journald[265]: Successfully sent stream file descriptor to service manager. [ 7.681201] systemd-journald[265]: Successfully sent stream file descriptor to service manager. [ 7.681611] systemd-journald[265]: Successfully sent stream file descriptor to service manager. [ 7.682019] systemd-journald[265]: Successfully sent stream file descriptor to service manager. [ 7.682430] systemd-journald[265]: Successfully sent stream file descriptor to service manager. [ 7.683685] systemd-journald[265]: Successfully sent stream file descriptor to service manager. [ 7.698929] systemd-journald[265]: Successfully sent stream file descriptor to service manager. [ 7.702646] systemd-journald[265]: Successfully sent stream file descriptor to service manager. [ 7.711638] systemd-journald[265]: Successfully sent stream file descriptor to service manager. [ 7.721958] systemd-journald[265]: n/a: New incoming connection. [ 7.723759] systemd-journald[265]: varlink-20: varlink: setting state idle-server [ 7.726435] systemd-journald[265]: varlink-20: New incoming message: {"method":"io.systemd.Journal.FlushToVar","parameters":{}} [ 7.730145] systemd-journald[265]: varlink-20: varlink: changing state idle-server \xe2\x86\x92 processing-method [ 7.732073] systemd-journald[265]: Received client request to flush runtime journal. [ 7.734994] systemd-journald[265]: Journal effective settings seal=yes keyed_hash=yes compress=yes compress_threshold_bytes=512B [ 7.741586] systemd-journald[265]: Fixed min_use=16.0M max_use=4.0G max_size=128.0M min_size=512.0K keep_free=4.0G n_max_files=100 [ 7.758328] systemd-journald[265]: Flushing to /var/log/journal/983425690c9a4432866996cdc56b7fd4... [ 7.760632] systemd-journald[265]: Considering root directory '/run/log/journal'. [ 7.762999] systemd-journald[265]: Root directory /run/log/journal added. [ 7.765265] systemd-journald[265]: Considering directory '/run/log/journal/983425690c9a4432866996cdc56b7fd4'. [ 7.767501] systemd-journald[265]: Directory /run/log/journal/983425690c9a4432866996cdc56b7fd4 added. [ 7.769900] systemd-journald[265]: Journal effective settings seal=no keyed_hash=yes compress=no compress_threshold_bytes=8B [ 7.772279] systemd-journald[265]: File /run/log/journal/983425690c9a4432866996cdc56b7fd4/system.journal added. [ 7.774603] systemd-journald[265]: Considering root directory '/var/log/journal'. [ 7.776898] systemd-journald[265]: Considering root directory '/var/log/journal/remote'. [ 8.150185] systemd-journald[265]: Root directory /run/log/journal removed. [ 8.152553] systemd-journald[265]: Directory /run/log/journal/983425690c9a4432866996cdc56b7fd4 removed. [ 8.154907] systemd-journald[265]: mmap cache statistics: 109427 context cache hit, 3 window list hit, 1 miss [ 8.157320] systemd-journald[265]: Journal effective settings seal=no keyed_hash=yes compress=yes compress_threshold_bytes=512B [ 8.162642] systemd-journald[265]: Vacuuming... [ 8.221524] systemd-journald[265]: Vacuuming done, freed 0B of archived journals from /var/log/journal/983425690c9a4432866996cdc56b7fd4. [ 8.232172] systemd-journald[265]: varlink-20: Sending message: {"parameters":{}} [ 8.234888] systemd-journald[265]: varlink-20: varlink: changing state processing-method \xe2\x86\x92 processed-method [ 8.237737] systemd-journald[265]: varlink-20: varlink: changing state processed-method \xe2\x86\x92 idle-server [ 8.243581] systemd-journald[265]: varlink-20: Got POLLHUP from socket. [ 8.246412] systemd-journald[265]: varlink-20: varlink: changing state idle-server \xe2\x86\x92 pending-disconnect [ 8.249306] systemd-journald[265]: varlink-20: varlink: changing state pending-disconnect \xe2\x86\x92 processing-disconnect [ 8.252261] systemd-journald[265]: varlink-20: varlink: changing state processing-disconnect \xe2\x86\x92 disconnected [ 8.308619] systemd-journald[265]: Successfully sent stream file descriptor to service manager. [ 8.517310] acpi_cpufreq: overriding BIOS provided _PSD data [ 8.540118] acpi-tad ACPI000E:00: Missing _PRW [ 8.607758] ACPI: video: Video Device [VGA1] (multi-head: yes rom: no post: no) [ 8.618373] acpi device:1e: registered as cooling_device8 [ 8.626848] input: Video Bus as /devices/LNXSYSTM:00/LNXSYBUS:00/PNP0A08:00/device:1d/LNXVIDEO:01/input/input2 [ 8.825614] acpi PNP0C14:01: duplicate WMI GUID 05901221-D566-11D1-B2F0-00A0C9062910 (first instance was on PNP0C14:00) [ 8.902194] input: Logitech USB Receiver as /devices/pci0000:00/0000:00:02.1/0000:01:00.0/usb1/1-11/1-11:1.0/0003:046D:C534.0001/input/input3 [ 8.939361] ccp 0000:0c:00.2: enabling device (0100 -> 0102) [ 8.955972] ccp 0000:0c:00.2: ccp: unable to access the device: you might be running a broken BIOS. [ 8.963592] systemd-journald[265]: Successfully sent stream file descriptor to service manager. [ 8.970655] hid-generic 0003:046D:C534.0001: input,hidraw0: USB HID v1.11 Keyboard [Logitech USB Receiver] on usb-0000:01:00.0-11/input0 [ 8.971435] ccp 0000:0c:00.2: tee enabled [ 8.983107] ccp 0000:0c:00.2: psp enabled [ 8.993491] piix4_smbus 0000:00:14.0: SMBus Host Controller at 0xb00, revision 0 [ 8.997884] piix4_smbus 0000:00:14.0: Using register 0x02 for SMBus port selection [ 9.001767] piix4_smbus 0000:00:14.0: Auxiliary SMBus Host Controller at 0xb20 [ 9.007282] input: Logitech USB Receiver Mouse as /devices/pci0000:00/0000:00:02.1/0000:01:00.0/usb1/1-11/1-11:1.1/0003:046D:C534.0002/input/input4 [ 9.019415] input: Logitech USB Receiver Consumer Control as /devices/pci0000:00/0000:00:02.1/0000:01:00.0/usb1/1-11/1-11:1.1/0003:046D:C534.0002/input/input5 [ 9.034973] input: PC Speaker as /devices/platform/pcspkr/input/input9 [ 9.046118] FAT-fs (nvme0n1p1): Volume was not properly unmounted. Some data may be corrupt. Please run fsck. [ 9.054500] sp5100_tco: SP5100/SB800 TCO WatchDog Timer Driver [ 9.057035] sp5100-tco sp5100-tco: Using 0xfeb00000 for watchdog MMIO address [ 9.059986] sp5100-tco sp5100-tco: initialized. heartbeat=60 sec (nowayout=0) [ 9.081027] libphy: r8169: probed [ 9.082100] input: Logitech USB Receiver System Control as /devices/pci0000:00/0000:00:02.1/0000:01:00.0/usb1/1-11/1-11:1.1/0003:046D:C534.0002/input/input6 [ 9.087214] r8169 0000:0a:00.0 eth0: RTL8168h/8111h, 00:68:eb:ad:98:43, XID 541, IRQ 91 [ 9.094618] hid-generic 0003:046D:C534.0002: input,hiddev96,hidraw1: USB HID v1.11 Mouse [Logitech USB Receiver] on usb-0000:01:00.0-11/input1 [ 9.097120] r8169 0000:0a:00.0 eth0: jumbo features [frames: 9194 bytes, tx checksumming: ko] [ 9.104420] usbcore: registered new interface driver usbhid [ 9.112544] usbhid: USB HID core driver [ 9.124878] Bluetooth: Core ver 2.22 [ 9.130875] systemd-journald[265]: Successfully sent stream file descriptor to service manager. [ 9.144288] NET: Registered protocol family 31 [ 9.149041] Bluetooth: HCI device and connection manager initialized [ 9.153017] Bluetooth: HCI socket layer initialized [ 9.156925] Bluetooth: L2CAP socket layer initialized [ 9.160735] Bluetooth: SCO socket layer initialized [ 9.209776] cfg80211: Loading compiled-in X.509 certificates for regulatory database [ 9.215973] RAPL PMU: API unit is 2^-32 Joules, 1 fixed counters, 163840 ms ovfl timer [ 9.237135] cfg80211: Loaded X.509 cert 'sforshee: 00b28ddf47aef9cea7' [ 9.242388] RAPL PMU: hw unit of domain package 2^-16 Joules [ 9.243515] platform regulatory.0: Direct firmware load for regulatory.db failed with error -2 [ 9.251002] cfg80211: failed to load regulatory.db [ 9.258468] usbcore: registered new interface driver btusb [ 9.263470] Bluetooth: hci0: RTL: examining hci_ver=08 hci_rev=000c lmp_ver=08 lmp_subver=8821 [ 9.271407] Bluetooth: hci0: RTL: rom_version status=0 version=1 [ 9.276096] Bluetooth: hci0: RTL: loading rtl_bt/rtl8821c_fw.bin [ 9.282586] Bluetooth: hci0: RTL: loading rtl_bt/rtl8821c_config.bin [ 9.286578] cryptd: max_cpu_qlen set to 1000 [ 9.290204] Bluetooth: hci0: RTL: cfg_sz 10, total sz 31990 [ 9.304981] irq 7: nobody cared (try booting with the "irqpoll" option) [ 9.308994] CPU: 4 PID: 308 Comm: systemd-udevd Tainted: G B 5.12.0-rc3-debug #1 [ 9.313266] Hardware name: HP HP Desktop M01-F1xxx/87D6, BIOS F.12 12/17/2020 [ 9.317902] Call Trace: [ 9.322386] [ 9.326452] dump_stack+0x9c/0xcf [ 9.330599] __report_bad_irq+0x43/0xde [ 9.334691] note_interrupt.cold+0x28/0x8b [ 9.339026] ? add_interrupt_randomness+0x152/0x270 [ 9.343255] handle_irq_event+0x14e/0x160 [ 9.347069] ? handle_irq_event_percpu+0xf0/0xf0 [ 9.350865] ? _raw_spin_lock+0x81/0xe0 [ 9.354551] ? _raw_spin_lock_bh+0xe0/0xe0 [ 9.358106] handle_fasteoi_irq+0xfa/0x370 [ 9.361574] __common_interrupt+0x4f/0xc0 [ 9.365067] common_interrupt+0x7b/0xa0 [ 9.368562] [ 9.371968] asm_common_interrupt+0x1e/0x40 [ 9.375328] RIP: 0010:mpihelp_submul_1+0x4a/0x100 [ 9.378586] Code: 48 83 ec 20 48 89 5c 24 08 31 db 48 89 7c 24 10 48 89 74 24 18 48 89 04 24 eb 03 49 63 c5 48 2b 04 24 4c 8d 34 c5 00 00 00 00 <48> 8b 44 24 18 4e 8d 24 30 4c 89 e7 e8 55 85 c4 ff 49 8b 34 24 48 [ 9.385354] RSP: 0018:ffffc90001dc7360 EFLAGS: 00000202 [ 9.388625] RAX: 000000000000003d RBX: 58b15c7a1664d4fd RCX: ffffffff92809c85 [ 9.391896] RDX: dffffc0000000000 RSI: 95a5834bb0a7f6e5 RDI: ffff8881035301e8 [ 9.395056] RBP: 00000000901b3ef1 R08: 6ee397ce901b3ef1 R09: 000000003f8f75f4 [ 9.398127] R10: fffffbfff298d729 R11: 0000000000000001 R12: 7c892be55ef82e4f [ 9.401275] R13: 00000000fffffffd R14: 00000000000001e8 R15: 58b15c7972392b28 [ 9.404440] ? mpihelp_submul_1+0xd5/0x100 [ 9.407665] mpihelp_divrem+0x167/0x9e0 [ 9.410828] mpi_powm+0x86e/0xe00 [ 9.413898] ? mpihelp_mul_karatsuba_case+0x5b0/0x5b0 [ 9.416845] ? asm_common_interrupt+0x1e/0x40 [ 9.419918] ? __sg_page_iter_next+0xa7/0x100 [ 9.422804] ? mpihelp_cmp+0x4f/0x80 [ 9.425790] rsa_enc+0x140/0x1f0 [ 9.428676] ? rsa_dec+0x1f0/0x1f0 [ 9.431576] pkcs1pad_verify+0x296/0x320 [ 9.434458] public_key_verify_signature+0x548/0x6f0 [ 9.437358] ? software_key_eds_op+0x620/0x620 [ 9.440180] ? keyring_search+0x136/0x190 [ 9.442934] ? common_interrupt+0x1c/0xa0 [ 9.445676] ? asm_common_interrupt+0x1e/0x40 [ 9.448371] ? pkcs7_validate_trust+0x2f7/0x330 [ 9.451023] pkcs7_validate_trust+0x303/0x330 [ 9.453667] verify_pkcs7_message_sig+0xe2/0x190 [ 9.456285] ? restrict_link_by_builtin_trusted+0x20/0x20 [ 9.458959] ? kfree+0xc3/0x480 [ 9.461558] verify_pkcs7_signature+0x4c/0x80 [ 9.464115] mod_verify_sig+0xe6/0x130 [ 9.466542] ? is_module_text_address+0x30/0x30 [ 9.469037] ? common_interrupt+0x1c/0xa0 [ 9.471471] load_module+0x48f/0x41a0 [ 9.473945] ? __kernel_read+0x338/0x4f0 [ 9.476449] ? __kernel_read+0x340/0x4f0 [ 9.478938] ? __x64_sys_sendfile64+0x140/0x140 [ 9.481427] ? module_frob_arch_sections+0x20/0x20 [ 9.481442] ? kernel_read+0x46/0xb0 [ 9.481450] ? kernel_read_file+0x1d2/0x3e0 [ 9.481458] ? __x64_sys_fspick+0x230/0x230 [ 9.481464] ? kasan_check_range+0x185/0x1d0 [ 9.481470] ? _raw_write_unlock+0x30/0x30 [ 9.481478] ? __do_sys_finit_module+0x110/0x1a0 [ 9.481484] __do_sys_finit_module+0x110/0x1a0 [ 9.481491] ? __ia32_sys_init_module+0x40/0x40 [ 9.481496] ? get_nth_filter.part.0+0x170/0x170 [ 9.481503] ? rcu_momentary_dyntick_idle+0x50/0x50 [ 9.481512] ? __do_softirq+0x209/0x3be [ 9.481517] ? __audit_syscall_entry+0x193/0x1f0 [ 9.481522] ? ktime_get_coarse_real_ts64+0x4a/0x70 [ 9.516734] do_syscall_64+0x33/0x40 [ 9.516747] entry_SYSCALL_64_after_hwframe+0x44/0xae [ 9.516754] RIP: 0033:0x7f079a72618d [ 9.516759] Code: b4 0c 00 0f 05 eb a9 66 0f 1f 44 00 00 f3 0f 1e fa 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d b3 6c 0c 00 f7 d8 64 89 01 48 [ 9.516763] RSP: 002b:00007ffdde055848 EFLAGS: 00000246 ORIG_RAX: 0000000000000139 [ 9.516768] RAX: ffffffffffffffda RBX: 0000559b1868c870 RCX: 00007f079a72618d [ 9.516772] RDX: 0000000000000000 RSI: 00007f079a883a9d RDI: 0000000000000015 [ 9.516774] RBP: 0000000000020000 R08: 0000000000000000 R09: 0000559b1868c870 [ 9.516777] R10: 0000000000000015 R11: 0000000000000246 R12: 00007f079a883a9d [ 9.516779] R13: 0000000000000000 R14: 0000559b1869b820 R15: 0000559b1868c870 [ 9.516785] handlers: [ 9.516786] [<00000000619962db>] amd_gpio_irq_handler [pinctrl_amd] [ 9.516796] Disabling IRQ #7 [ 9.518500] AVX2 version of gcm_enc/dec engaged. [ 9.518550] AES CTR mode by8 optimization enabled [ 9.518794] snd_hda_intel 0000:0c:00.1: enabling device (0100 -> 0102) [ 9.519962] snd_hda_intel 0000:0c:00.1: Handle vga_switcheroo audio client [ 9.570729] snd_hda_intel 0000:0c:00.6: enabling device (0100 -> 0102) [ 9.614031] input: HD-Audio Generic HDMI/DP,pcm=3 as /devices/pci0000:00/0000:00:08.1/0000:0c:00.1/sound/card0/input10 [ 9.705675] snd_hda_codec_realtek hdaudioC1D0: autoconfig for ALC671: line_outs=1 (0x14/0x0/0x0/0x0/0x0) type:line [ 9.708420] systemd-journald[265]: Successfully sent stream file descriptor to service manager. [ 9.708761] snd_hda_codec_realtek hdaudioC1D0: speaker_outs=0 (0x0/0x0/0x0/0x0/0x0) [ 9.714896] snd_hda_codec_realtek hdaudioC1D0: hp_outs=1 (0x21/0x0/0x0/0x0/0x0) [ 9.718876] snd_hda_codec_realtek hdaudioC1D0: mono: mono_out=0x0 [ 9.718897] snd_hda_codec_realtek hdaudioC1D0: inputs: [ 9.718904] snd_hda_codec_realtek hdaudioC1D0: Mic=0x19 [ 9.718915] snd_hda_codec_realtek hdaudioC1D0: Line=0x1b [ 9.749261] systemd-journald[265]: Successfully sent stream file descriptor to service manager. [ 9.770716] input: HD-Audio Generic Mic as /devices/pci0000:00/0000:00:08.1/0000:0c:00.6/sound/card1/input11 [ 9.771375] input: HD-Audio Generic Line as /devices/pci0000:00/0000:00:08.1/0000:0c:00.6/sound/card1/input12 [ 9.771987] input: HD-Audio Generic Line Out as /devices/pci0000:00/0000:00:08.1/0000:0c:00.6/sound/card1/input13 [ 9.772603] input: HD-Audio Generic Front Headphone as /devices/pci0000:00/0000:00:08.1/0000:0c:00.6/sound/card1/input14 [ 9.797844] rtw_8821ce 0000:09:00.0: enabling device (0100 -> 0103) [ 9.798837] rtw_8821ce 0000:09:00.0: Firmware version 24.8.0, H2C version 12 [ 9.861369] systemd-journald[265]: Successfully sent stream file descriptor to service manager. [ 9.920626] systemd-journald[265]: Successfully sent stream file descriptor to service manager. [ 9.968295] kvm: Nested Virtualization enabled [ 9.970665] [drm] amdgpu kernel modesetting enabled. [ 9.971787] SVM: kvm: Nested Paging enabled [ 9.975655] Virtual CRAT table created for CPU [ 9.977941] SVM: Virtual VMLOAD VMSAVE supported [ 9.977945] SVM: Virtual GIF supported [ 9.989227] amdgpu: Topology: Add CPU node [ 9.993923] checking generic (d0000000 300000) vs hw (d0000000 10000000) [ 9.998240] fb0: switching to amdgpudrmfb from EFI VGA [ 10.002978] Console: switching to colour dummy device 80x25 [ 10.003328] amdgpu 0000:0c:00.0: vgaarb: deactivate vga console [ 10.004163] amdgpu 0000:0c:00.0: enabling device (0106 -> 0107) [ 10.005925] [drm] initializing kernel modesetting (RENOIR 0x1002:0x1636 0x103C:0x87D6 0xCA). [ 10.005985] amdgpu 0000:0c:00.0: amdgpu: Trusted Memory Zone (TMZ) feature disabled as experimental (default) [ 10.006259] [drm] register mmio base: 0xFCA00000 [ 10.006288] [drm] register mmio size: 524288 [ 10.006317] [drm] PCIE atomic ops is not supported [ 10.007372] [drm] add ip block number 0 [ 10.007411] [drm] add ip block number 1 [ 10.007474] [drm] add ip block number 2 [ 10.007492] [drm] add ip block number 3 [ 10.007498] [drm] add ip block number 4 [ 10.007505] [drm] add ip block number 5 [ 10.007512] [drm] add ip block number 6 [ 10.007520] [drm] add ip block number 7 [ 10.007527] [drm] add ip block number 8 [ 10.007562] [drm] add ip block number 9 [ 10.007700] amdgpu 0000:0c:00.0: amdgpu: Fetched VBIOS from VFCT [ 10.007815] amdgpu: ATOM BIOS: 113-RENOIR-026 [ 10.010428] [drm] VCN decode is enabled in VM mode [ 10.010443] [drm] VCN encode is enabled in VM mode [ 10.010448] [drm] JPEG decode is enabled in VM mode [ 10.011043] [drm] vm size is 262144 GB, 4 levels, block size is 9-bit, fragment size is 9-bit [ 10.011118] amdgpu 0000:0c:00.0: amdgpu: VRAM: 512M 0x000000F400000000 - 0x000000F41FFFFFFF (512M used) [ 10.011133] amdgpu 0000:0c:00.0: amdgpu: GART: 1024M 0x0000000000000000 - 0x000000003FFFFFFF [ 10.011146] amdgpu 0000:0c:00.0: amdgpu: AGP: 267419648M 0x000000F800000000 - 0x0000FFFFFFFFFFFF [ 10.011192] [drm] Detected VRAM RAM=512M, BAR=512M [ 10.011201] [drm] RAM width 64bits DDR4 [ 10.011685] [TTM] Zone kernel: Available graphics memory: 3208866 KiB [ 10.011699] [TTM] Zone dma32: Available graphics memory: 2097152 KiB [ 10.046111] MCE: In-kernel MCE decoding enabled. [ 10.050870] [drm] amdgpu: 512M of VRAM memory ready [ 10.050941] [drm] amdgpu: 3072M of GTT memory ready. [ 10.051000] general protection fault, probably for non-canonical address 0xff2439eaff279143: 0000 [#1] PREEMPT SMP KASAN NOPTI [ 10.051018] CPU: 1 PID: 294 Comm: systemd-udevd Tainted: G B 5.12.0-rc3-debug #1 [ 10.051033] Hardware name: HP HP Desktop M01-F1xxx/87D6, BIOS F.12 12/17/2020 [ 10.051043] RIP: 0010:native_queued_spin_lock_slowpath+0x317/0x490 [ 10.051064] Code: 3c d5 00 d9 db 93 48 89 14 24 49 81 c7 40 57 03 00 e8 9d f2 2c 00 48 8b 14 24 4c 03 3c d5 00 d9 db 93 4c 89 ff e8 29 f3 2c 00 <49> 89 2f eb 02 f3 90 4c 89 f7 e8 3a f1 2c 00 8b 45 08 85 c0 74 ef [ 10.051087] RSP: 0018:ffffc9000089f050 EFLAGS: 00010086 [ 10.051099] RAX: 0000000000000000 RBX: ffff8881d7830024 RCX: ffffffff92182ed7 [ 10.051110] RDX: 0000000000000001 RSI: 0000000000000008 RDI: ff2439eaff279143 [ 10.051121] RBP: ffff8881d6a75740 R08: 0000000000000001 R09: ffff8881d7830027 [ 10.051132] R10: ffffed103af06004 R11: 0000000000000001 R12: 0000000000080000 [ 10.051143] R13: 1ffff92000113e0b R14: ffff8881d6a75748 R15: ff2439eaff279143 [ 10.051155] FS: 00007f0799df6a40(0000) GS:ffff8881d6a40000(0000) knlGS:0000000000000000 [ 10.051168] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 10.051179] CR2: 00007f14f6fa9f10 CR3: 000000010a888000 CR4: 0000000000350ee0 [ 10.051190] Call Trace: [ 10.051197] ? .slowpath+0xe/0xe [ 10.051207] ? kasan_save_stack+0x32/0x40 [ 10.051223] ? __kasan_kmalloc+0x99/0xc0 [ 10.051235] ? amdgpu_ttm_init.cold+0x153/0x16f [amdgpu] [ 10.052171] ? gmc_v9_0_sw_init+0x64c/0x980 [amdgpu] [ 10.053184] ? amdgpu_device_init.cold+0x1483/0x2400 [amdgpu] [ 10.054225] ? amdgpu_driver_load_kms+0xb1/0x3f0 [amdgpu] [ 10.055217] ? amdgpu_pci_probe+0x172/0x200 [amdgpu] [ 10.056218] ? local_pci_probe+0x74/0xc0 [ 10.056234] _raw_spin_lock_irqsave+0xe0/0xf0 [ 10.056247] ? _raw_write_unlock_bh+0x30/0x30 [ 10.056257] ? __do_sys_finit_module+0x110/0x1a0 [ 10.056271] ? entry_SYSCALL_64_after_hwframe+0x44/0xae [ 10.056285] swiotlb_tbl_map_single+0x1de/0x6f0 [ 10.056298] ? irq_work_queue+0xb/0x40 [ 10.056314] ? add_hole+0x294/0x310 [drm] [ 10.056457] swiotlb_map+0xc1/0x3f0 [ 10.056467] ? drm_mm_init+0x126/0x140 [drm] [ 10.056607] ? swiotlb_sync_single_for_cpu+0x20/0x20 [ 10.056620] ? ttm_range_man_init+0xdd/0x100 [ttm] [ 10.056650] ? amdgpu_ttm_init.cold+0x153/0x16f [amdgpu] [ 10.057586] dma_map_page_attrs+0x299/0x390 [ 10.057599] ? dmam_free_coherent+0xe0/0xe0 [ 10.057611] amdgpu_gart_init+0x77/0xf0 [amdgpu] [ 10.058480] gmc_v9_0_sw_init+0x910/0x980 [amdgpu] [ 10.059373] ? gmc_v9_0_late_init+0xe0/0xe0 [amdgpu] [ 10.060260] ? __drmm_add_action+0xf0/0x140 [drm] [ 10.060386] ? drm_mode_config_cleanup+0x480/0x480 [drm] [ 10.060513] ? drm_mode_config_cleanup+0x480/0x480 [drm] [ 10.060641] amdgpu_device_init.cold+0x1483/0x2400 [amdgpu] [ 10.061600] ? amdgpu_device_cache_pci_state+0x90/0x90 [amdgpu] [ 10.062639] ? pci_find_saved_ext_cap+0x80/0x80 [ 10.062654] ? pci_enable_device_flags+0xcb/0x250 [ 10.062667] ? pci_enable_device_flags+0x19c/0x250 [ 10.062679] ? pci_enable_bridge+0xe0/0xe0 [ 10.062690] amdgpu_driver_load_kms+0xb1/0x3f0 [amdgpu] [ 10.063709] amdgpu_pci_probe+0x172/0x200 [amdgpu] [ 10.064737] ? amdgpu_pci_remove+0x80/0x80 [amdgpu] [ 10.065697] local_pci_probe+0x74/0xc0 [ 10.065710] pci_device_probe+0x1ee/0x300 [ 10.065721] ? pci_device_remove+0x100/0x100 [ 10.065732] ? kernfs_put+0x18/0x30 [ 10.065741] ? sysfs_do_create_link_sd+0x76/0xd0 [ 10.065754] really_probe+0x185/0x6c0 [ 10.065764] driver_probe_device+0x13f/0x1d0 [ 10.065774] device_driver_attach+0x110/0x120 [ 10.065784] ? device_driver_attach+0x120/0x120 [ 10.065793] __driver_attach+0xae/0x1a0 [ 10.065803] ? device_driver_attach+0x120/0x120 [ 10.065812] bus_for_each_dev+0xe6/0x140 [ 10.065823] ? subsys_dev_iter_exit+0x10/0x10 [ 10.065833] ? __list_add_valid+0x2b/0xa0 [ 10.065844] bus_add_driver+0x1f8/0x2e0 [ 10.065857] driver_register+0x10f/0x190 [ 10.065866] ? 0xffffffffc133b000 [ 10.065875] do_one_initcall+0x89/0x2a0 [ 10.065886] ? perf_trace_initcall_level+0x230/0x230 [ 10.065897] ? kfree+0xc3/0x480 [ 10.065907] ? kasan_set_track+0x1c/0x30 [ 10.065917] ? kasan_unpoison+0x3a/0x60 [ 10.065927] ? kasan_unpoison+0x3a/0x60 [ 10.065938] do_init_module+0xfd/0x3c0 [ 10.065950] load_module+0x3f44/0x41a0 [ 10.065961] ? xfs_file_buffered_read+0x82/0x130 [xfs] [ 10.066346] ? module_frob_arch_sections+0x20/0x20 [ 10.066358] ? kernel_read+0x46/0xb0 [ 10.066369] ? kernel_read_file+0x1d2/0x3e0 [ 10.066384] ? __do_sys_finit_module+0x110/0x1a0 [ 10.066394] __do_sys_finit_module+0x110/0x1a0 [ 10.066404] ? __ia32_sys_init_module+0x40/0x40 [ 10.066414] ? get_nth_filter.part.0+0x170/0x170 [ 10.066426] ? randomize_stack_top+0x80/0x80 [ 10.066436] ? __ia32_compat_sys_newlstat+0x30/0x30 [ 10.066450] ? __audit_syscall_entry+0x193/0x1f0 [ 10.066459] ? ktime_get_coarse_real_ts64+0x4a/0x70 [ 10.066471] do_syscall_64+0x33/0x40 [ 10.066482] entry_SYSCALL_64_after_hwframe+0x44/0xae [ 10.066494] RIP: 0033:0x7f079a72618d [ 10.066502] Code: b4 0c 00 0f 05 eb a9 66 0f 1f 44 00 00 f3 0f 1e fa 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d b3 6c 0c 00 f7 d8 64 89 01 48 [ 10.066522] RSP: 002b:00007ffdde055848 EFLAGS: 00000246 ORIG_RAX: 0000000000000139 [ 10.066535] RAX: ffffffffffffffda RBX: 0000559b1868c810 RCX: 00007f079a72618d [ 10.066545] RDX: 0000000000000000 RSI: 00007f079a883a9d RDI: 0000000000000018 [ 10.066554] RBP: 0000000000020000 R08: 0000000000000000 R09: 00007f079aab65ea [ 10.066564] R10: 0000000000000018 R11: 0000000000000246 R12: 00007f079a883a9d [ 10.066573] R13: 0000000000000000 R14: 0000559b18690b60 R15: 0000559b1868c810 [ 10.066585] Modules linked in: edac_mce_amd fjes(-) kvm_amd rtw88_8821ce kvm rtw88_8821c rtw88_pci amdgpu(+) rtw88_core irqbypass snd_hda_codec_realtek crct10dif_pclmul crc32_pclmul ghash_clmulni_intel snd_hda_codec_generic ledtrig_audio snd_hda_codec_hdmi mac80211 aesni_intel snd_hda_intel snd_intel_dspcfg crypto_simd cryptd gpu_sched snd_intel_sdw_acpi btusb i2c_algo_bit snd_hda_codec btrtl drm_ttm_helper btbcm btintel rapl ttm snd_hda_core drm_kms_helper cfg80211 snd_hwdep bluetooth sp5100_tco vfat pcspkr snd_pcm ecdh_generic k10temp fat r8169 i2c_piix4 cec snd_timer syscopyarea realtek sysfillrect snd mdio_devres sysimgblt rfkill ccp fb_sys_fops soundcore libphy libarc4 ecc usbhid crc16 wmi tpm_crb tpm_tis tpm_tis_core video tpm gpio_amdpt gpio_generic rng_core pinctrl_amd mac_hid acpi_tad acpi_cpufreq pkcs8_key_parser drm fuse agpgart bpf_preload ip_tables x_tables xfs libcrc32c crc32c_generic crc32c_intel xhci_pci xhci_pci_renesas [ 10.066824] ---[ end trace f566d89392370240 ]--- [ 10.066831] RIP: 0010:native_queued_spin_lock_slowpath+0x317/0x490 [ 10.066844] Code: 3c d5 00 d9 db 93 48 89 14 24 49 81 c7 40 57 03 00 e8 9d f2 2c 00 48 8b 14 24 4c 03 3c d5 00 d9 db 93 4c 89 ff e8 29 f3 2c 00 <49> 89 2f eb 02 f3 90 4c 89 f7 e8 3a f1 2c 00 8b 45 08 85 c0 74 ef [ 10.066863] RSP: 0018:ffffc9000089f050 EFLAGS: 00010086 [ 10.066873] RAX: 0000000000000000 RBX: ffff8881d7830024 RCX: ffffffff92182ed7 [ 10.066882] RDX: 0000000000000001 RSI: 0000000000000008 RDI: ff2439eaff279143 [ 10.066892] RBP: ffff8881d6a75740 R08: 0000000000000001 R09: ffff8881d7830027 [ 10.066903] R10: ffffed103af06004 R11: 0000000000000001 R12: 0000000000080000 [ 10.066913] R13: 1ffff92000113e0b R14: ffff8881d6a75748 R15: ff2439eaff279143 [ 10.066924] FS: 00007f0799df6a40(0000) GS:ffff8881d6a40000(0000) knlGS:0000000000000000 [ 10.066936] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 10.066944] CR2: 00007f14f6fa9f10 CR3: 000000010a888000 CR4: 0000000000350ee0 [ 10.066955] note: systemd-udevd[294] exited with preempt_count 1 [ 10.074564] systemd-journald[265]: Compressed data object 946 -> 537 using ZSTD [ 10.076050] systemd-journald[265]: Successfully sent stream file descriptor to service manager. [ 10.089990] systemd-journald[265]: Successfully sent stream file descriptor to service manager. [ 10.114635] systemd-journald[265]: Successfully sent stream file descriptor to service manager. [ 10.226512] systemd-journald[265]: Successfully sent stream file descriptor to service manager. [ 10.234727] systemd-journald[265]: Successfully sent stream file descriptor to service manager. [ 10.249690] systemd-journald[265]: Successfully sent stream file descriptor to service manager. [ 10.292469] r8169 0000:0a:00.0 enp10s0: renamed from eth0 [ 10.321331] input: HP WMI hotkeys as /devices/virtual/input/input15 [ 10.356875] logitech-djreceiver 0003:046D:C534.0001: hidraw0: USB HID v1.11 Keyboard [Logitech USB Receiver] on usb-0000:01:00.0-11/input0 [ 10.478801] intel_rapl_common: Found RAPL domain package [ 10.478843] intel_rapl_common: Found RAPL domain core [ 10.561785] logitech-djreceiver 0003:046D:C534.0002: hiddev96,hidraw1: USB HID v1.11 Mouse [Logitech USB Receiver] on usb-0000:01:00.0-11/input1 [ 10.601569] Bluetooth: hci0: RTL: fw version 0x829a7644 [ 10.633053] logitech-djreceiver 0003:046D:C534.0002: device of type eQUAD nano Lite (0x0a) connected on slot 1 [ 10.635027] logitech-djreceiver 0003:046D:C534.0002: device of type eQUAD nano Lite (0x0a) connected on slot 2 [ 10.635611] input: Logitech Wireless Keyboard PID:4075 Keyboard as /devices/pci0000:00/0000:00:02.1/0000:01:00.0/usb1/1-11/1-11:1.1/0003:046D:C534.0002/0003:046D:4075.0003/input/input16 [ 10.638901] hid-generic 0003:046D:4075.0003: input,hidraw2: USB HID v1.11 Keyboard [Logitech Wireless Keyboard PID:4075] on usb-0000:01:00.0-11/input1:1 [ 10.640688] input: Logitech Wireless Mouse PID:4054 Mouse as /devices/pci0000:00/0000:00:02.1/0000:01:00.0/usb1/1-11/1-11:1.1/0003:046D:C534.0002/0003:046D:4054.0004/input/input21 [ 10.641990] hid-generic 0003:046D:4054.0004: input,hidraw3: USB HID v1.11 Mouse [Logitech Wireless Mouse PID:4054] on usb-0000:01:00.0-11/input1:2 [ 10.688794] mousedev: PS/2 mouse device common for all mice [ 10.918080] input: Logitech Wireless Keyboard PID:4075 as /devices/pci0000:00/0000:00:02.1/0000:01:00.0/usb1/1-11/1-11:1.1/0003:046D:C534.0002/0003:046D:4075.0003/input/input25 [ 10.923263] logitech-hidpp-device 0003:046D:4075.0003: input,hidraw2: USB HID v1.11 Keyboard [Logitech Wireless Keyboard PID:4075] on usb-0000:01:00.0-11/input1:1 [ 10.933008] rtw_8821ce 0000:09:00.0: start vif 74:12:b3:a0:4a:cb on port 0 [ 10.981496] input: Logitech Wireless Mouse as /devices/pci0000:00/0000:00:02.1/0000:01:00.0/usb1/1-11/1-11:1.1/0003:046D:C534.0002/0003:046D:4054.0004/input/input26 [ 10.983168] logitech-hidpp-device 0003:046D:4054.0004: input,hidraw3: USB HID v1.11 Mouse [Logitech Wireless Mouse] on usb-0000:01:00.0-11/input1:2 [ 11.004242] Generic FE-GE Realtek PHY r8169-a00:00: attached PHY driver (mii_bus:phy_addr=r8169-a00:00, irq=MAC) [ 11.174788] r8169 0000:0a:00.0 enp10s0: Link is Down [ 14.177070] r8169 0000:0a:00.0 enp10s0: Link is Up - 1Gbps/Full - flow control rx/tx [ 14.177144] IPv6: ADDRCONF(NETDEV_CHANGE): enp10s0: link becomes ready [ 15.422075] kauditd_printk_skb: 28 callbacks suppressed [ 15.422088] audit: type=1131 audit(1625291568.246:40): pid=1 uid=0 auid=4294967295 ses=4294967295 msg='unit=systemd-rfkill comm="systemd" exe="/usr/lib/systemd/systemd" hostname=? addr=? terminal=? res=success' [ 21.356047] audit: type=1101 audit(1625291574.179:41): pid=416 uid=0 auid=4294967295 ses=4294967295 msg='op=PAM:accounting grantors=pam_access,pam_unix,pam_permit,pam_time acct="nathan" exe="/usr/bin/sshd" hostname=192.168.4.54 addr=192.168.4.54 terminal=ssh res=success' [ 21.363309] audit: type=1103 audit(1625291574.186:42): pid=416 uid=0 auid=4294967295 ses=4294967295 msg='op=PAM:setcred grantors=pam_shells,pam_faillock,pam_permit,pam_env,pam_faillock acct="nathan" exe="/usr/bin/sshd" hostname=192.168.4.54 addr=192.168.4.54 terminal=ssh res=success' [ 21.363633] audit: type=1006 audit(1625291574.186:43): pid=416 uid=0 old-auid=4294967295 auid=1000 tty=(none) old-ses=4294967295 ses=1 res=1 [ 21.363684] audit: type=1300 audit(1625291574.186:43): arch=c000003e syscall=1 success=yes exit=4 a0=3 a1=7ffc39581740 a2=4 a3=3e8 items=0 ppid=373 pid=416 auid=1000 uid=0 gid=0 euid=0 suid=0 fsuid=0 egid=0 sgid=0 fsgid=0 tty=(none) ses=1 comm="sshd" exe="/usr/bin/sshd" key=(null) [ 21.363717] audit: type=1327 audit(1625291574.186:43): proctitle=737368643A206E617468616E205B707269765D [ 21.395973] systemd-journald[265]: Successfully sent stream file descriptor to service manager. [ 21.432227] audit: type=1130 audit(1625291574.256:44): pid=1 uid=0 auid=4294967295 ses=4294967295 msg='unit=user-runtime-dir@1000 comm="systemd" exe="/usr/lib/systemd/systemd" hostname=? addr=? terminal=? res=success' [ 21.440727] systemd-journald[265]: Successfully sent stream file descriptor to service manager. [ 21.454764] audit: type=1101 audit(1625291574.279:45): pid=419 uid=0 auid=4294967295 ses=4294967295 msg='op=PAM:accounting grantors=pam_access,pam_unix,pam_permit,pam_time acct="nathan" exe="/usr/lib/systemd/systemd" hostname=? addr=? terminal=? res=success' [ 21.454837] audit: type=1103 audit(1625291574.279:46): pid=419 uid=0 auid=4294967295 ses=4294967295 msg='op=PAM:setcred grantors=? acct="nathan" exe="/usr/lib/systemd/systemd" hostname=? addr=? terminal=? res=failed' [ 21.455123] audit: type=1006 audit(1625291574.279:47): pid=419 uid=0 old-auid=4294967295 auid=1000 tty=(none) old-ses=4294967295 ses=2 res=1 [ 21.455183] audit: type=1300 audit(1625291574.279:47): arch=c000003e syscall=1 success=yes exit=4 a0=9 a1=7ffe190ef1b0 a2=4 a3=3e8 items=0 ppid=1 pid=419 auid=1000 uid=0 gid=0 euid=0 suid=0 fsuid=0 egid=0 sgid=0 fsgid=0 tty=(none) ses=2 comm="(systemd)" exe="/usr/lib/systemd/systemd" key=(null) [ 21.465054] systemd-journald[265]: Journal effective settings seal=yes keyed_hash=yes compress=yes compress_threshold_bytes=512B [ 21.466322] systemd-journald[265]: Fixed min_use=848.1M max_use=4.0G max_size=128.0M min_size=512.0K keep_free=4.0G n_max_files=100 [ 21.493502] systemd-journald[265]: Journal effective settings seal=no keyed_hash=yes compress=yes compress_threshold_bytes=512B [ 21.629644] systemd-journald[265]: Successfully sent stream file descriptor to service manager. [ 21.681781] systemd-journald[265]: Data hash table of /var/log/journal/983425690c9a4432866996cdc56b7fd4/system.journal has a fill level at 75.0 (174763 of 233016 items, 109051904 file size, 623 bytes per hash table item), suggesting rotation. [ 21.681842] systemd-journald[265]: /var/log/journal/983425690c9a4432866996cdc56b7fd4/system.journal: Journal header limits reached or header out-of-date, rotating. [ 21.681883] systemd-journald[265]: Rotating... [ 21.684864] systemd-journald[265]: Journal effective settings seal=yes keyed_hash=yes compress=yes compress_threshold_bytes=512B [ 21.692779] systemd-journald[265]: Reserving 333 entries in field hash table. [ 21.693953] systemd-journald[265]: Reserving 233016 entries in data hash table. [ 21.728897] systemd-journald[265]: Reserving 333 entries in field hash table. [ 21.730060] systemd-journald[265]: Reserving 233016 entries in data hash table. [ 21.742082] systemd-journald[265]: Failed to parse UID from file name 'user-1000@a73e8f336cda47d99c78d917f661fa32-00000000000005cf-0005c5f19f949d34.journal', ignoring: Invalid argument [ 21.742154] systemd-journald[265]: Failed to parse UID from file name 'user-1000@2d53deb7d71c4bdb85af714a4c578449-000000000003a0f5-0005c630924d4800.journal', ignoring: Invalid argument [ 21.742209] systemd-journald[265]: Failed to parse UID from file name 'user-1000@2d53deb7d71c4bdb85af714a4c578449-000000000004b76d-0005c630bea3393f.journal', ignoring: Invalid argument [ 21.742267] systemd-journald[265]: Failed to parse UID from file name 'user-1000@2d53deb7d71c4bdb85af714a4c578449-0000000000081997-0005c6314a613b2b.journal', ignoring: Invalid argument [ 21.742342] systemd-journald[265]: Vacuuming... [ 21.752710] systemd-journald[265]: Vacuuming done, freed 0B of archived journals from /var/log/journal/983425690c9a4432866996cdc56b7fd4. [ 21.752772] systemd-journald[265]: Journal effective settings seal=no keyed_hash=yes compress=yes compress_threshold_bytes=512B [ 24.053852] systemd-journald[265]: Compressed data object 628 -> 263 using ZSTD [ 27.567518] kauditd_printk_skb: 11 callbacks suppressed [ 27.567531] audit: type=1100 audit(1625291580.389:56): pid=582 uid=1000 auid=1000 ses=1 msg='op=PAM:authentication grantors=pam_faillock,pam_permit,pam_faillock acct="nathan" exe="/usr/bin/doas" hostname=hp-4300G addr=? terminal=pts/0 res=success' [ 27.571597] audit: type=1101 audit(1625291580.396:57): pid=582 uid=1000 auid=1000 ses=1 msg='op=PAM:accounting grantors=pam_unix,pam_permit,pam_time acct="nathan" exe="/usr/bin/doas" hostname=hp-4300G addr=? terminal=pts/0 res=success' [ 27.572223] audit: type=1110 audit(1625291580.396:58): pid=582 uid=1000 auid=1000 ses=1 msg='op=PAM:setcred grantors=pam_faillock,pam_permit,pam_faillock acct="root" exe="/usr/bin/doas" hostname=hp-4300G addr=? terminal=pts/0 res=success' [ 27.573162] audit: type=1105 audit(1625291580.396:59): pid=582 uid=1000 auid=1000 ses=1 msg='op=PAM:session_open grantors=pam_limits,pam_unix,pam_permit acct="root" exe="/usr/bin/doas" hostname=hp-4300G addr=? terminal=pts/0 res=success' --IzhtKCoR/XhZJq5z-- From xen-devel-bounces@lists.xenproject.org Sat Jul 03 06:44:01 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 03 Jul 2021 06:44:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149394.276210 (Exim 4.92) (envelope-from ) id 1lzZNb-0006QS-U3; Sat, 03 Jul 2021 06:43:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149394.276210; Sat, 03 Jul 2021 06:43:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzZNb-0006QL-Qt; Sat, 03 Jul 2021 06:43:55 +0000 Received: by outflank-mailman (input) for mailman id 149394; Sat, 03 Jul 2021 06:43:54 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzZNa-0006QB-GT; Sat, 03 Jul 2021 06:43:54 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzZNa-0004gk-8t; Sat, 03 Jul 2021 06:43:54 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzZNZ-0003HT-VK; Sat, 03 Jul 2021 06:43:54 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lzZNZ-0003nV-Up; Sat, 03 Jul 2021 06:43:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=XcbsxQ3W5DOfYs9eCcnO9Ko1m3sQ4RcsDruS9WrS+ew=; b=2ZS7xDzBHajrh1cCR8huW66qhK GdkmxcQrMtoprW3pAmRQDw0cstXPA5JHJySuJlrJ3OI9qLZpTYz5+Lpcrsg5Pt7NWJNuxNZiGbrca /Sbap2uU9um6RfFATVZNJsaZyWPl6kHw0Qd/Wjvm4ORtde7/aWym3hc4Qw9rR8zzLEXE=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 163233: regressions - FAIL X-Osstest-Failures: ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:debian-hvm-install:fail:regression ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:debian-hvm-install:fail:regression X-Osstest-Versions-This: ovmf=fea7901dba72eeac526f3ef12a4ad4c539622373 X-Osstest-Versions-That: ovmf=c410ad4da4b7785170d3d42a3ba190c2caac6feb From: osstest service owner Date: Sat, 03 Jul 2021 06:43:53 +0000 flight 163233 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/163233/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 162359 test-amd64-amd64-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 162359 version targeted for testing: ovmf fea7901dba72eeac526f3ef12a4ad4c539622373 baseline version: ovmf c410ad4da4b7785170d3d42a3ba190c2caac6feb Last test of basis 162359 2021-06-04 03:40:08 Z 29 days Failing since 162368 2021-06-04 15:42:59 Z 28 days 77 attempts Testing same since 163216 2021-07-01 22:42:29 Z 1 days 7 attempts ------------------------------------------------------------ People who touched revisions under test: Abner Chang Agrawal, Sachin Alexandru Elisei Anthony PERARD Ard Biesheuvel Daniel Schaefer Daoxiang Li Dov Murik DunTan gaoliming Guo Dong Hao A Wu Jian J Wang Kaaira Gupta Ken Lautner Kenneth Lautner Kun Qin Laszlo Ersek Leif Lindholm Liming Gao Loo Tung Lun Loo, Tung Lun Manickavasakam Karpagavinayagam Maurice Ma Ni, Ray Patrick Rudolph Pierre Gondois Ray Ni Rebecca Cran Rebecca Cran Sachin Agrawal Sami Mujawar Scottie Kuo Sean Brogan Sean Brogan Sumana Venur Sunil V L xueshengfeng Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-i386-xl-qemuu-ovmf-amd64 fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 3224 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Jul 03 06:46:52 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 03 Jul 2021 06:46:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149399.276223 (Exim 4.92) (envelope-from ) id 1lzZQR-00072n-Dz; Sat, 03 Jul 2021 06:46:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149399.276223; Sat, 03 Jul 2021 06:46:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzZQR-00072g-B5; Sat, 03 Jul 2021 06:46:51 +0000 Received: by outflank-mailman (input) for mailman id 149399; Sat, 03 Jul 2021 06:46:50 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzZQQ-00072U-1A; Sat, 03 Jul 2021 06:46:50 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzZQP-0004j9-TE; Sat, 03 Jul 2021 06:46:49 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzZQP-0003NB-M3; Sat, 03 Jul 2021 06:46:49 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lzZQP-0005HN-LY; Sat, 03 Jul 2021 06:46:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=/i9FYedQppDQ8FbEtC2gQtue7dDKnxutrh3s50gqqhI=; b=kh7nFGeNx+EMuiz3Dk+LGYUlBe ZTEI+au0rPpcc8zJJhNIu8BD0Z22vVXg47VhvnhxF75yKOdbRsD5+wXB0dZw8wjuvDwhEDJMExQxQ du7WMNeMol5ZX3g4DkAZsxSHc3g9/l5//V5eOPuGrR6F9XeENuWIgKQlR2PSN5dabFaI=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 163231: regressions - FAIL X-Osstest-Failures: xen-unstable:test-amd64-amd64-examine:memdisk-try-append:fail:regression xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=3bc3be978fd61f8099797864136c5f447c0e4aae X-Osstest-Versions-That: xen=f95b7b37cfc6d4613721df9357090d14712013c0 From: osstest service owner Date: Sat, 03 Jul 2021 06:46:49 +0000 flight 163231 xen-unstable real [real] flight 163237 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/163231/ http://logs.test-lab.xenproject.org/osstest/logs/163237/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-examine 4 memdisk-try-append fail REGR. vs. 163219 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail REGR. vs. 163219 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 163219 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 163219 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 163219 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 163219 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 163219 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 163219 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 163219 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 163219 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 163219 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 163219 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 163219 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 3bc3be978fd61f8099797864136c5f447c0e4aae baseline version: xen f95b7b37cfc6d4613721df9357090d14712013c0 Last test of basis 163219 2021-07-02 01:52:38 Z 1 days Testing same since 163231 2021-07-02 18:06:46 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD Ian Jackson jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit 3bc3be978fd61f8099797864136c5f447c0e4aae Author: Anthony PERARD Date: Mon Jun 28 11:01:57 2021 +0100 libxl: Fix QEMU cmdline for scsi device Usage of 'scsi-disk' device is deprecated and removed from QEMU, instead we need to use 'scsi-hd' for hard drives. See QEMU 879be3af49 (hw/scsi: remove 'scsi-disk' device) Signed-off-by: Anthony PERARD Reviewed-by: Jason Andryuk commit 217eef30f7b9b85ba6e27c81a791dae8f6fcdbe7 Author: Anthony PERARD Date: Mon Jun 28 11:01:56 2021 +0100 libxl: Replace short-form boolean for QEMU's -vnc f3f778c81769 forgot one boolean parameter. Fixes: f3f778c81769 ("libxl: Replace QEMU's command line short-form boolean option") Signed-off-by: Anthony PERARD Reviewed-by: Jason Andryuk commit 07d6dd51a5c508cc0f3c93a876f8b4e3102ecf60 Author: Anthony PERARD Date: Mon Jun 28 14:42:17 2021 +0100 Config.mk: re-pin OVMF changeset and unpin qemu-xen qemu-xen tree have a osstest gate and doesn't need to be pinned. On the other hand, OVMF's xen repository doesn't have a gate and needs to be pinned. The "master" branch correspond now to the tag "edk2-stable202105", so pin to that commit. Fixes: a04509d34d72 ("Branching: Update version files etc. for newly unstable") Signed-off-by: Anthony PERARD Acked-by: Ian Jackson (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Sat Jul 03 08:13:40 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 03 Jul 2021 08:13:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149419.276265 (Exim 4.92) (envelope-from ) id 1lzamD-0007K6-LS; Sat, 03 Jul 2021 08:13:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149419.276265; Sat, 03 Jul 2021 08:13:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzamD-0007Jz-IQ; Sat, 03 Jul 2021 08:13:25 +0000 Received: by outflank-mailman (input) for mailman id 149419; Sat, 03 Jul 2021 08:13:24 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzamC-0007Jp-O2; Sat, 03 Jul 2021 08:13:24 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzamC-0006fT-EM; Sat, 03 Jul 2021 08:13:24 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzamC-0006TI-2w; Sat, 03 Jul 2021 08:13:24 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lzamC-0003fC-2R; Sat, 03 Jul 2021 08:13:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Zb0VWkvqAapk1WpKpOQ3BvazcGHFAXQ0x9MBgAYawSQ=; b=P9dmWhRfhPYVWgkG+x1bdJ17dZ 6mQAj+Q5+kTwxeampWazkOU52wmIm84mFO1iPsTyCFoWYKqLMi3M3IF9Zzr05v8Nt2S6FK6JRi5qJ CgZhx9t84WsWFPVYYRSXLhb6f28jMxnQqRa1B4U5/uQQSa89xDs8r58OZLke6wwF4PD4=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 163236: regressions - FAIL X-Osstest-Failures: libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=45f94690d2a89fc03c1a4eaea5c1ee398447a4b8 X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Sat, 03 Jul 2021 08:13:24 +0000 flight 163236 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/163236/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a version targeted for testing: libvirt 45f94690d2a89fc03c1a4eaea5c1ee398447a4b8 baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 358 days Failing since 151818 2020-07-11 04:18:52 Z 357 days 349 attempts Testing same since 163236 2021-07-03 04:20:01 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Andika Triwidada Andrea Bolognani Balázs Meskó Barrett Schonefeld Bastian Germann Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Bjoern Walk Boris Fiuczynski Brian Turek Bruno Haible Chris Mayo Christian Ehrhardt Christian Schoenebeck Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Dmytro Linkin Eiichi Tsukata Eric Farman Erik Skultety Fabian Affolter Fabian Freyer Fabiano Fidêncio Fangge Jin Farhan Ali Fedora Weblate Translation gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Hela Basa Helmut Grohne Ian Wienand Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen Jean-Baptiste Holcroft Jianan Gao Jim Fehlig Jin Yan Jiri Denemark John Ferlan Jonathan Watt Jonathon Jongsma Julio Faracco Ján Tomko Kashyap Chamarthy Kevin Locke Kristina Hanicova Laine Stump Laszlo Ersek Lee Yarwood Liao Pingfang Lin Ma Lin Ma Lin Ma Liu Yiding Luke Yue Luyao Zhong Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Markus Schade Martin Kletzander Masayoshi Mizuma Matt Coleman Matt Coleman Mauro Matteo Cascella Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Muha Aliss Nathan Neal Gompa Nick Shyrokovskiy Nickys Music Group Nico Pache Nikolay Shirokovskiy Olaf Hering Olesya Gerasimenko Orion Poplawski Pany Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Ricky Tigg Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Shambarger Sebastian Mitterle SeongHyun Jo Shalini Chellathurai Saroja Shaojun Yang Shi Lei simmon Simon Chopin Simon Gaiser Stefan Bader Stefan Berger Stefan Berger Stefan Hajnoczi Szymon Scholz Thomas Huth Tim Wiederhake Tomáš Golembiovský Tomáš Janoušek Tuguoyi Ville Skyttä Wang Xin WangJian Weblate Wei Liu Wei Liu William Douglas Yalei Li <274268859@qq.com> Yalei Li Yang Hang Yanqiu Zhang Yaroslav Kargin Yi Li Yi Wang Yuri Chornoivan Zbigniew Jędrzejewski-Szmek Zheng Chuan zhenwei pi Zhenyu Zheng jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 63952 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Jul 03 08:32:03 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 03 Jul 2021 08:32:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149427.276287 (Exim 4.92) (envelope-from ) id 1lzb49-0001Cv-Qy; Sat, 03 Jul 2021 08:31:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149427.276287; Sat, 03 Jul 2021 08:31:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzb49-0001Co-Nn; Sat, 03 Jul 2021 08:31:57 +0000 Received: by outflank-mailman (input) for mailman id 149427; Sat, 03 Jul 2021 08:31:56 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzb48-0001Ce-AP; Sat, 03 Jul 2021 08:31:56 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzb48-0006wh-6D; Sat, 03 Jul 2021 08:31:56 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzb47-0007Pd-Rn; Sat, 03 Jul 2021 08:31:55 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lzb47-0007KR-RK; Sat, 03 Jul 2021 08:31:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=XJzaSN/obYPiUmqi+AEXPVfXhO7ZYKR7cP+rDZI/W34=; b=vdhjYKpAtA0cofdKtrVR/tBTjl os5ZdXU8TAVRu55z6nhFPZUNbrv/RmFnjLKLZ2PcsbVXytjzvf1jpl9DxoSjiXhpIiTTeTnzqKBGI dzgHYreqTmuMxxyZmHcHD9QXzJbx8ESBexFkomDy9BRhNd5ongtAXChmrDuL53/Okpf0=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 163232: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-i386-xl-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-coresched-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-examine:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-pvshim:xen-install:fail:regression linux-linus:test-amd64-i386-xl-raw:xen-install:fail:regression linux-linus:test-amd64-i386-xl-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-i386:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-xsm:xen-install:fail:regression linux-linus:test-arm64-arm64-xl-seattle:debian-install:fail:regression linux-linus:test-amd64-amd64-libvirt-vhd:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-credit1:debian-install:fail:regression linux-linus:test-arm64-arm64-xl-credit2:debian-install:fail:regression linux-linus:test-arm64-arm64-xl-thunderx:debian-install:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-arm64-arm64-xl-xsm:debian-install:fail:regression linux-linus:test-arm64-arm64-xl:debian-install:fail:regression linux-linus:test-amd64-amd64-amd64-pvgrub:guest-stop:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:debian-install:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-amd64-amd64-i386-pvgrub:guest-stop:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qcow2:guest-start:fail:regression linux-linus:test-armhf-armhf-xl-cubietruck:debian-install:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:debian-di-install:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:debian-install:fail:regression linux-linus:test-amd64-amd64-examine:memdisk-try-append:fail:heisenbug linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=3dbdb38e286903ec220aaf1fb29a8d94297da246 X-Osstest-Versions-That: linux=deacdb3e3979979016fcd0ffd518c320a62ad166 From: osstest service owner Date: Sat, 03 Jul 2021 08:31:55 +0000 flight 163232 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/163232/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-coresched-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-examine 6 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-pvshim 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-raw 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-i386 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-xsm 7 xen-install fail REGR. vs. 152332 test-arm64-arm64-xl-seattle 12 debian-install fail REGR. vs. 152332 test-amd64-amd64-libvirt-vhd 13 guest-start fail REGR. vs. 152332 test-arm64-arm64-xl-credit1 12 debian-install fail REGR. vs. 152332 test-arm64-arm64-xl-credit2 12 debian-install fail REGR. vs. 152332 test-arm64-arm64-xl-thunderx 12 debian-install fail REGR. vs. 152332 test-armhf-armhf-examine 8 reboot fail REGR. vs. 152332 test-arm64-arm64-xl-xsm 12 debian-install fail REGR. vs. 152332 test-arm64-arm64-xl 12 debian-install fail REGR. vs. 152332 test-amd64-amd64-amd64-pvgrub 20 guest-stop fail REGR. vs. 152332 test-arm64-arm64-libvirt-xsm 12 debian-install fail REGR. vs. 152332 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 152332 test-amd64-amd64-i386-pvgrub 20 guest-stop fail REGR. vs. 152332 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 152332 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 152332 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 152332 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 152332 test-amd64-amd64-xl-qcow2 13 guest-start fail REGR. vs. 152332 test-armhf-armhf-xl-cubietruck 12 debian-install fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 152332 test-armhf-armhf-xl-vhd 12 debian-di-install fail REGR. vs. 152332 test-armhf-armhf-xl-multivcpu 12 debian-install fail REGR. vs. 152332 Tests which are failing intermittently (not blocking): test-amd64-amd64-examine 4 memdisk-try-append fail pass in 163222 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 163222 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 152332 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 152332 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152332 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152332 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass version targeted for testing: linux 3dbdb38e286903ec220aaf1fb29a8d94297da246 baseline version: linux deacdb3e3979979016fcd0ffd518c320a62ad166 Last test of basis 152332 2020-07-31 19:41:23 Z 336 days Failing since 152366 2020-08-01 20:49:34 Z 335 days 571 attempts Testing same since 163222 2021-07-02 03:54:04 Z 1 days 2 attempts ------------------------------------------------------------ 6483 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-i386-xl fail test-amd64-coresched-i386-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm fail test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm fail test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck fail test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine fail test-amd64-i386-examine fail test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel fail test-amd64-i386-qemuu-rhel6hvm-intel fail test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-amd64-pvgrub fail test-amd64-amd64-i386-pvgrub fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 fail test-armhf-armhf-libvirt-raw fail test-amd64-i386-xl-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow fail test-arm64-arm64-xl-thunderx fail test-amd64-amd64-libvirt-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1844969 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Jul 03 09:21:35 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 03 Jul 2021 09:21:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149440.276326 (Exim 4.92) (envelope-from ) id 1lzbpy-00062g-9F; Sat, 03 Jul 2021 09:21:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149440.276326; Sat, 03 Jul 2021 09:21:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzbpy-00062Z-5y; Sat, 03 Jul 2021 09:21:22 +0000 Received: by outflank-mailman (input) for mailman id 149440; Sat, 03 Jul 2021 09:21:21 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzbpx-00062T-1e for xen-devel@lists.xenproject.org; Sat, 03 Jul 2021 09:21:21 +0000 Received: from deinos.phlegethon.org (unknown [5.39.92.215]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 526fe32f-c4a4-4a83-9879-c8026fb4986f; Sat, 03 Jul 2021 09:21:18 +0000 (UTC) Received: from tjd by deinos.phlegethon.org with local (Exim 4.94.2 (FreeBSD)) (envelope-from ) id 1lzbPW-000Hw7-CP; Sat, 03 Jul 2021 08:54:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 526fe32f-c4a4-4a83-9879-c8026fb4986f Date: Sat, 3 Jul 2021 09:54:02 +0100 From: Tim Deegan To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , George Dunlap , Roberto Bagnara Subject: Re: [PATCH] x86/shadow: drop callback_mask pseudo-variables Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: X-SA-Known-Good: Yes X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: tim@xen.org X-SA-Exim-Scanned: No (on deinos.phlegethon.org); SAEximRunCond expanded to false At 08:42 +0200 on 30 Jun (1625042541), Jan Beulich wrote: > In commit 90629587e16e ("x86/shadow: replace stale literal numbers in > hash_{vcpu,domain}_foreach()") I had to work around a clang shortcoming > (if you like), leveraging that gcc tolerates static const variables in > otherwise integer constant expressions. Roberto suggests that we'd > better not rely on such behavior. Drop the involved static const-s, > using their "expansions" in both of the prior use sites each. This then > allows dropping the short-circuiting of the check for clang. > > Requested-by: Roberto Bagnara > Signed-off-by: Jan Beulich Acked-by: Tim Deegan From xen-devel-bounces@lists.xenproject.org Sat Jul 03 10:58:22 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 03 Jul 2021 10:58:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149460.276376 (Exim 4.92) (envelope-from ) id 1lzdLT-00061F-Vf; Sat, 03 Jul 2021 10:57:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149460.276376; Sat, 03 Jul 2021 10:57:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzdLT-000618-S1; Sat, 03 Jul 2021 10:57:59 +0000 Received: by outflank-mailman (input) for mailman id 149460; Sat, 03 Jul 2021 10:57:58 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzdLS-00060y-S9; Sat, 03 Jul 2021 10:57:58 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzdLS-0000wl-K0; Sat, 03 Jul 2021 10:57:58 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzdLS-00062S-Ai; Sat, 03 Jul 2021 10:57:58 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lzdLS-0002h5-AJ; Sat, 03 Jul 2021 10:57:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=irzwUJPmp5vHU+ysbGQryHQQLaVALTW+OxiJS6wV+zE=; b=pNP+pbcexEKpby4GZ6IkqbjCDW 459n3pqxCU2c3PZSlTx+R2YpGpet8AqR5pE/TqLkXSGoiDf65Gc2n8jLeaHuMsLY814ZzTV/esOG7 ejrxyHWVuTEQqCJ8XyHDZkhJ347gkxBmLuy4ZI0boEEDaGSN2FzkN/UgxAfKyCgdfUSk=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 163238: regressions - FAIL X-Osstest-Failures: ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:debian-hvm-install:fail:regression ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:debian-hvm-install:fail:regression X-Osstest-Versions-This: ovmf=fea7901dba72eeac526f3ef12a4ad4c539622373 X-Osstest-Versions-That: ovmf=c410ad4da4b7785170d3d42a3ba190c2caac6feb From: osstest service owner Date: Sat, 03 Jul 2021 10:57:58 +0000 flight 163238 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/163238/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 162359 test-amd64-amd64-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 162359 version targeted for testing: ovmf fea7901dba72eeac526f3ef12a4ad4c539622373 baseline version: ovmf c410ad4da4b7785170d3d42a3ba190c2caac6feb Last test of basis 162359 2021-06-04 03:40:08 Z 29 days Failing since 162368 2021-06-04 15:42:59 Z 28 days 78 attempts Testing same since 163216 2021-07-01 22:42:29 Z 1 days 8 attempts ------------------------------------------------------------ People who touched revisions under test: Abner Chang Agrawal, Sachin Alexandru Elisei Anthony PERARD Ard Biesheuvel Daniel Schaefer Daoxiang Li Dov Murik DunTan gaoliming Guo Dong Hao A Wu Jian J Wang Kaaira Gupta Ken Lautner Kenneth Lautner Kun Qin Laszlo Ersek Leif Lindholm Liming Gao Loo Tung Lun Loo, Tung Lun Manickavasakam Karpagavinayagam Maurice Ma Ni, Ray Patrick Rudolph Pierre Gondois Ray Ni Rebecca Cran Rebecca Cran Sachin Agrawal Sami Mujawar Scottie Kuo Sean Brogan Sean Brogan Sumana Venur Sunil V L xueshengfeng Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-i386-xl-qemuu-ovmf-amd64 fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 3224 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Jul 03 12:28:32 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 03 Jul 2021 12:28:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149480.276426 (Exim 4.92) (envelope-from ) id 1lzekv-00063G-5i; Sat, 03 Jul 2021 12:28:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149480.276426; Sat, 03 Jul 2021 12:28:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzekv-000639-1i; Sat, 03 Jul 2021 12:28:21 +0000 Received: by outflank-mailman (input) for mailman id 149480; Sat, 03 Jul 2021 12:28:19 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzekt-000633-5E for xen-devel@lists.xenproject.org; Sat, 03 Jul 2021 12:28:19 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzeks-0002Nz-6L; Sat, 03 Jul 2021 12:28:18 +0000 Received: from [54.239.6.185] (helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lzeks-0003uY-00; Sat, 03 Jul 2021 12:28:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=0zUiP+P98Sc6vMw+tiPFrjzxhhszNT4g9boL1IJzXeY=; b=j48VZlFNb7WH9PI4sHXqRDOLEX XCbYx9btQmzrCL5/LkW9q7wacmX2ZnsGijJZmvGosKBHIdNTUX2DUSeuXJEc3t1+CU3UZeFp2n3Cc LbMbMA/YRzbVpoXzCjAeEiX0prtBcvI4CX93KJrVI0kWOgprhAFboaUtO0OLlQ8DnpMo=; Subject: Re: [PATCH] xen/arm: smmuv1: Fixed stream matching register allocation To: Rahul Singh Cc: xen-devel , Bertrand Marquis , Stefano Stabellini , Volodymyr Babchuk References: <612e7f61c19e60019bb7829888342fda95fd36be.1624546532.git.rahul.singh@arm.com> <11df0a34-724a-63ad-1822-4bd8aa364ab0@xen.org> <8BD37A47-7F82-4710-A37C-9C9C933913A9@arm.com> From: Julien Grall Message-ID: Date: Sat, 3 Jul 2021 13:28:16 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <8BD37A47-7F82-4710-A37C-9C9C933913A9@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit On 02/07/2021 10:54, Rahul Singh wrote: > Hi Julien, Hi Rahul, >> On 30 Jun 2021, at 7:00 pm, Julien Grall wrote: >> >> >> >> On 30/06/2021 18:49, Rahul Singh wrote: >>> Hi Julien, >> >> Hi, >> >>>> On 30 Jun 2021, at 10:09 am, Julien Grall wrote: >>>> >>>> Hi Rahul, >>>> >>>> On 25/06/2021 17:37, Rahul Singh wrote: >>>>> SMR allocation should be based on the number of supported stream >>>>> matching register for each SMMU device. >>>>> Issue introduced by commit 5e08586afbb90b2e2d56c175c07db77a4afa873c >>>>> when backported the patches from Linux to XEN to fix the stream match >>>>> conflict issue when two devices have the same stream-id. >>>>> Acked-by: Stefano Stabellini >>>>> Tested-by: Stefano Stabellini >>>>> Signed-off-by: Rahul Singh >>>>> --- >>>>> xen/drivers/passthrough/arm/smmu.c | 3 ++- >>>>> 1 file changed, 2 insertions(+), 1 deletion(-) >>>>> diff --git a/xen/drivers/passthrough/arm/smmu.c b/xen/drivers/passthrough/arm/smmu.c >>>>> index d9a3a0cbf6..da2cd457d7 100644 >>>>> --- a/xen/drivers/passthrough/arm/smmu.c >>>>> +++ b/xen/drivers/passthrough/arm/smmu.c >>>>> @@ -149,6 +149,7 @@ typedef enum irqreturn irqreturn_t; >>>>> #define kzalloc(size, flags) _xzalloc(size, sizeof(void *)) >>>>> #define devm_kzalloc(dev, size, flags) _xzalloc(size, sizeof(void *)) >>>>> #define kmalloc_array(size, n, flags) _xmalloc_array(size, sizeof(void *), n) >>>>> +#define kzalloc_array(size, n, flags) _xzalloc_array(size, sizeof(void *), n) >>>>> static void __iomem *devm_ioremap_resource(struct device *dev, >>>>> struct resource *res) >>>>> @@ -2221,7 +2222,7 @@ static int arm_smmu_device_cfg_probe(struct arm_smmu_device *smmu) >>>>> smmu->smr_mask_mask = smr >> SMR_MASK_SHIFT; >>>>> /* Zero-initialised to mark as invalid */ >>>>> - smmu->smrs = devm_kzalloc(smmu->dev, sizeof(*smmu->smrs), GFP_KERNEL); >>>>> + smmu->smrs = kzalloc_array(sizeof(*smmu->smrs), size, GFP_KERNEL); >>>> >>>> I noticed this is already in... However, I am a bit puzzled into why this was switched devm_kzalloc() to kzalloc_array(). This doesn't matter for Xen as they are just wrappers to x*alloc() but a mention in the commit message would have been useful. >>> Yes we can use the devm_kzalloc(..) but then we have to pass (sizeof(*smmu->smrs) * size ) as size argument to devm_kzalloc(..) >>> I thought for better code readability I will use kzalloc_array() as the function name suggests we are allocating memory for an array. >> >> My point is devm_k*alloc() and k*alloc() are quite different on the paper. One will allocate memory for a given device while the other is unknown memory. >> >> It would have been better to call the function devm_kzalloc_array() to keep to keep the code coherent. Can you please send a patch to make the switch? > > Ok. I will modify the code as per your request as below . I will use devm_kcalloc(..) as this will be more coherent. > > diff --git a/xen/drivers/passthrough/arm/smmu.c b/xen/drivers/passthrough/arm/smmu.c > index da2cd457d7..658c40433c 100644 > --- a/xen/drivers/passthrough/arm/smmu.c > +++ b/xen/drivers/passthrough/arm/smmu.c > @@ -149,7 +149,8 @@ typedef enum irqreturn irqreturn_t; > #define kzalloc(size, flags) _xzalloc(size, sizeof(void *)) > #define devm_kzalloc(dev, size, flags) _xzalloc(size, sizeof(void *)) > #define kmalloc_array(size, n, flags) _xmalloc_array(size, sizeof(void *), n) > -#define kzalloc_array(size, n, flags) _xzalloc_array(size, sizeof(void *), n) > +#define devm_kcalloc(dev, n, size, flags) \ > + _xzalloc_array(size, sizeof(void *), n) > > static void __iomem *devm_ioremap_resource(struct device *dev, > struct resource *res) > @@ -2222,7 +2223,8 @@ static int arm_smmu_device_cfg_probe(struct arm_smmu_device *smmu) > smmu->smr_mask_mask = smr >> SMR_MASK_SHIFT; > > /* Zero-initialised to mark as invalid */ > - smmu->smrs = kzalloc_array(sizeof(*smmu->smrs), size, GFP_KERNEL); > + smmu->smrs = devm_kcalloc(smmu->dev, size, sizeof(*smmu->smrs), > + GFP_KERNEL); > if (!smmu->smrs) > return -ENOMEM; This sounds good to me. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sat Jul 03 13:26:13 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 03 Jul 2021 13:26:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149492.276458 (Exim 4.92) (envelope-from ) id 1lzfeo-0003QN-B0; Sat, 03 Jul 2021 13:26:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149492.276458; Sat, 03 Jul 2021 13:26:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzfeo-0003QG-6t; Sat, 03 Jul 2021 13:26:06 +0000 Received: by outflank-mailman (input) for mailman id 149492; Sat, 03 Jul 2021 13:26:05 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzfen-0003Q8-1E for xen-devel@lists.xenproject.org; Sat, 03 Jul 2021 13:26:05 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzfem-0003Ii-05; Sat, 03 Jul 2021 13:26:04 +0000 Received: from [54.239.6.185] (helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lzfel-0008Jb-QL; Sat, 03 Jul 2021 13:26:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=XvOslK9tGoMg5XCnqq1G7RAZ5HOjX1mCqIZCMegLo/o=; b=ZejDebksHYUqdBzcK0Ke96f5Ur YV6L7sYc2QTM+fh5w2BYL64VBm++kc0NiQDkRLoFQ6NMiaNbzHb2SDhDKKk3/nVAm78p64jXepciA A4tLQlZlWfCXcv8WXuKqll1XAg1cH7LGzZVpky9IJtXT1x4+w9ZmvaV0Yew0LNKeBfYc=; Subject: Re: [PATCH 8/9] xen/arm: check `xen,static-mem` property during domain construction To: Penny Zheng , xen-devel@lists.xenproject.org, sstabellini@kernel.org, jbeulich@suse.com Cc: Bertrand.Marquis@arm.com, Wei.Chen@arm.com References: <20210607024318.3988467-1-penny.zheng@arm.com> <20210607024318.3988467-9-penny.zheng@arm.com> From: Julien Grall Message-ID: Date: Sat, 3 Jul 2021 14:26:01 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210607024318.3988467-9-penny.zheng@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi Penny, On 07/06/2021 03:43, Penny Zheng wrote: > This commit checks `xen,static-mem` device tree property in /domUx node, > to determine whether domain is on Static Allocation, when constructing > domain during boot-up. > > Right now, the implementation of allocate_static_memory is missing, and > will be introduced later. It just BUG() out at the moment. > > And if the `memory` property and `xen,static-mem` are both set, it shall > be verified that if the memory size defined in both is consistent. > > Signed-off-by: Penny Zheng > --- > changes v2: > - remove parsing procedure here > - check the consistency when `xen,static-mem` and `memory` are both defined > --- > xen/arch/arm/domain_build.c | 37 +++++++++++++++++++++++++++++++------ > 1 file changed, 31 insertions(+), 6 deletions(-) > > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > index 282416e74d..4166d7993c 100644 > --- a/xen/arch/arm/domain_build.c > +++ b/xen/arch/arm/domain_build.c > @@ -2424,23 +2424,47 @@ static int __init construct_domU(struct domain *d, > { > struct kernel_info kinfo = {}; > int rc; > - u64 mem; > + u64 mem, static_mem_size = 0; > + const struct dt_property *prop; > + bool static_mem = false; > + > + d->max_pages = ~0U; > + /* > + * Guest RAM could be of static memory from static allocation, > + * which will be specified through "xen,static-mem" phandle. > + */ > + prop = dt_find_property(node, "xen,static-mem", NULL); > + if ( prop ) > + { > + static_mem = true; > + /* static_mem_size = allocate_static_memory(...); */ > + BUG(); > + } I would prefer if the static memory is allocated close to allocate_memory() below. AFAICT, the reason you allocate here is because you want to have the property "memory" optional. However, I am not entirely convinced this is a good idea to make optional. It would be easier for a reader to figure out from the device-tree how much memory we give to the guest. > > rc = dt_property_read_u64(node, "memory", &mem); > - if ( !rc ) > + if ( !static_mem && !rc ) > { > printk("Error building DomU: cannot read \"memory\" property\n"); > return -EINVAL; > + } else if ( rc && static_mem ) > + { > + if ( static_mem_size != mem * SZ_1K ) > + { > + printk("Memory size in \"memory\" property isn't consistent with" > + "the ones defined in \"xen,static-mem\".\n"); > + return -EINVAL; > + } > } > - kinfo.unassigned_mem = (paddr_t)mem * SZ_1K; > + kinfo.unassigned_mem = static_mem ? 0 : (paddr_t)mem * SZ_1K; > > - printk("*** LOADING DOMU cpus=%u memory=%"PRIx64"KB ***\n", d->max_vcpus, mem); > + printk("*** LOADING DOMU cpus=%u memory=%"PRIx64"KB ***\n", > + d->max_vcpus, > + static_mem ? static_mem_size : (kinfo.unassigned_mem) >> 10); If we mandate the property "memory", then kinfo.unassigned_mem doesn't need to be touched. Instead, you could simply check the kinfo.unassigned_mem is equivalent to static_mem_size. > > kinfo.vpl011 = dt_property_read_bool(node, "vpl011"); > > if ( vcpu_create(d, 0) == NULL ) > return -ENOMEM; > - d->max_pages = ~0U; > > kinfo.d = d; > > @@ -2452,7 +2476,8 @@ static int __init construct_domU(struct domain *d, > /* type must be set before allocate memory */ > d->arch.type = kinfo.type; > #endif > - allocate_memory(d, &kinfo); > + if ( !static_mem ) > + allocate_memory(d, &kinfo); > > rc = prepare_dtb_domU(d, &kinfo); > if ( rc < 0 ) > Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sat Jul 03 14:18:42 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 03 Jul 2021 14:18:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149506.276493 (Exim 4.92) (envelope-from ) id 1lzgTV-0008QY-6v; Sat, 03 Jul 2021 14:18:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149506.276493; Sat, 03 Jul 2021 14:18:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzgTV-0008QR-3d; Sat, 03 Jul 2021 14:18:29 +0000 Received: by outflank-mailman (input) for mailman id 149506; Sat, 03 Jul 2021 14:18:27 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzgTT-0008QL-SQ for xen-devel@lists.xenproject.org; Sat, 03 Jul 2021 14:18:27 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzgTS-0004DU-S8; Sat, 03 Jul 2021 14:18:26 +0000 Received: from [54.239.6.185] (helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lzgTS-00047J-M3; Sat, 03 Jul 2021 14:18:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=bRemhQ55eR5N+qtxTTz/MFJuQxVe1NVLs8GT4w9nAH0=; b=fztnM04/UR1wONB2/4DJOpiDXA e2zfSGzXpiOyzUjjT4vwAic0Z20NhaF43aYqwiizKHRa1ctlthZp2GRbioiEcqYWviuEe9Ob51jCE Ie59YwIaLjWw2CH2rb/czF2UigJofq6NY5hzZ0q6eU1cl0AtgOsUKROTNkQHkGtXfB7I=; Subject: Re: [PATCH 9/9] xen/arm: introduce allocate_static_memory To: Penny Zheng , xen-devel@lists.xenproject.org, sstabellini@kernel.org, jbeulich@suse.com Cc: Bertrand.Marquis@arm.com, Wei.Chen@arm.com References: <20210607024318.3988467-1-penny.zheng@arm.com> <20210607024318.3988467-10-penny.zheng@arm.com> From: Julien Grall Message-ID: <2dc9387c-1c6c-70af-5bf5-8b606b62cc79@xen.org> Date: Sat, 3 Jul 2021 15:18:24 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210607024318.3988467-10-penny.zheng@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi Penny, On 07/06/2021 03:43, Penny Zheng wrote: > This commit introduces allocate_static_memory to allocate static memory as > guest RAM for Domain on Static Allocation. > > It uses alloc_domstatic_pages to allocate pre-configured static memory banks > for this domain, and uses guest_physmap_add_page to set up P2M table. > These pre-defiend static memory ranges shall be firstly mapped to the > fixed guest RAM address `GUEST_RAM0_BASE`. And until it exhausts the > `GUEST_RAM0_SIZE`, it will seek to `GUEST_RAM1_BASE`. > `GUEST_RAM0` may take up several pre-defined physical RAM regions. > > Signed-off-by: Penny Zheng > --- > changes v2: > - rename the values, like prefix it g/p > - fix the scalability issue > - allocate when parse > --- > xen/arch/arm/domain_build.c | 155 +++++++++++++++++++++++++++++++++++- > 1 file changed, 153 insertions(+), 2 deletions(-) > > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > index 4166d7993c..63b6a97b2c 100644 > --- a/xen/arch/arm/domain_build.c > +++ b/xen/arch/arm/domain_build.c > @@ -437,6 +437,48 @@ static bool __init allocate_bank_memory(struct domain *d, > return true; > } > > +/* > + * Static memory bank at #smfn of #gsize shall be mapped to #sgfn of #gsize, > + * and #sgfn will be next guest address to map when returning. > + */ > +static bool __init allocate_static_bank_memory(struct domain *d, > + struct kernel_info *kinfo, > + int gbank, Please use unsigned int for index. > + gfn_t* sgfn, > + mfn_t smfn, > + paddr_t gsize) This function doesn't allocate memory and neither a "bank" per-se. So would suggest to rename to (or something similar): append_static_memory_to_bank() Also, I don't think you need all those parameters. You can infer the next GFN to use from the bank information. So how about something like: static bool __init append_static_memory_to_bank(struct domain *d, struct membank *bank, mfn_t smfn, paddr_t size) { gfn_t sgfn = gaddr_to_gfn(bank->start + bank->size); [....] } > +{ > + int res; > + paddr_t tot_size = gsize; > + const uint64_t rambase[] = GUEST_RAM_BANK_BASES; I don't like the idea of introducing rambase here. Can't the bank be initialized in the caller? > + > + while ( tot_size > 0 ) > + { > + unsigned int order = get_allocation_size(tot_size); > + > + res = guest_physmap_add_page(d, *sgfn, smfn, order); > + if ( res ) > + { > + dprintk(XENLOG_ERR, "Failed map pages to DOMU: %d", res); > + return false; > + } > + > + *sgfn = gfn_add(*sgfn, 1UL << order); > + smfn = mfn_add(smfn, 1UL << order); > + tot_size -= (1ULL << (PAGE_SHIFT + order)); > + } > + > + /* Guest RAM bank in kinfo hasn't been initialized. */ > + if ( gbank == kinfo->mem.nr_banks ) > + { > + kinfo->mem.bank[gbank].start = rambase[gbank]; > + kinfo->mem.nr_banks++; > + } > + kinfo->mem.bank[gbank].size += gsize; > + > + return true; > +} > + > static void __init allocate_memory(struct domain *d, struct kernel_info *kinfo) It feels a bit odd that the two functions you introduced are not together. Can they be moved together? > { > unsigned int i; > @@ -480,6 +522,116 @@ fail: > (unsigned long)kinfo->unassigned_mem >> 10); > } > > +/* Allocate memory from static memory as RAM for one specific domain d. */ > +static u64 __init allocate_static_memory(struct domain *d, > + struct kernel_info *kinfo, > + const struct dt_device_node *node) > +{ > + int nr_banks, bank = 0, gbank = 0; > + const uint64_t rambase[] = GUEST_RAM_BANK_BASES; > + const uint64_t ramsize[] = GUEST_RAM_BANK_SIZES; > + const __be32 *cell; > + const struct dt_property *prop; > + struct dt_device_node *static_mem_node; > + const struct dt_device_node *parent = dt_find_node_by_path("/reserved-memory"); > + u32 addr_cells = 2, size_cells = 2, reg_cells; > + u64 tot_size; > + > + paddr_t pbase, psize, gsize; > + gfn_t sgfn; > + mfn_t smfn; > + > + kinfo->mem.nr_banks = 0; > + /* Start with GUEST_RAM0. */ > + gsize = ramsize[gbank]; > + sgfn = gaddr_to_gfn(rambase[gbank]); > + > + /* Parse phandle in `xen,static-mem`. */ > + static_mem_node = dt_parse_phandle(node, "xen,static-mem", 0); > + if ( !static_mem_node ) > + goto fail; > + > + /* > + * #address-cells and #size-cells must be consistent with the parent node, > + * "reserved-memory". > + */ > + dt_property_read_u32(parent, "#address-cells", &addr_cells); > + dt_property_read_u32(parent, "#size-cells", &size_cells); The return for dt_property_read_u32() should be checked. > + BUG_ON(size_cells > 2 || addr_cells > 2); > + reg_cells = addr_cells + size_cells; > + > + prop = dt_find_property(static_mem_node, "reg", NULL); > + if ( !prop ) > + goto fail; > + cell = (const __be32 *)prop->value; > + nr_banks = (prop->length) / (reg_cells * sizeof (u32)); > + BUG_ON(nr_banks > NR_MEM_BANKS); > + > + while ( bank < nr_banks ) > + { > + device_tree_get_reg(&cell, addr_cells, size_cells, &pbase, &psize); We seem to have quite a few functions now that will iterate over "regs". It would be worth considering to introduce a helper to iterate it. > + tot_size += (u64)psize; This cast seems unnecessary. > + smfn = maddr_to_mfn(pbase); > + > + if ( !alloc_domstatic_pages(d, psize >> PAGE_SHIFT, smfn, 0) ) > + { > + printk(XENLOG_ERR > + "%pd: cannot allocate static memory" > + "(0x%"PRIpaddr" - 0x%"PRIpaddr")", > + d, pbase, pbase + psize); > + goto fail; > + } > + > + printk(XENLOG_INFO "%pd STATIC BANK[%d] %#"PRIpaddr"-%#"PRIpaddr"\n", > + d, bank, pbase, pbase + psize); > + > + /* > + * It shall be mapped to the fixed guest RAM address rambase[i], > + * And until it exhausts the ramsize[i], it will seek to the next > + * rambase[i+1]. > + */ > + while ( 1 ) > + { > + if ( gsize >= psize ) > + { > + if ( !allocate_static_bank_memory(d, kinfo, gbank, > + &sgfn, smfn, psize) ) > + goto fail; > + > + gsize = gsize - psize; > + bank++; > + break; > + } > + else > + { > + if ( !allocate_static_bank_memory(d, kinfo, gbank, > + &sgfn, smfn, gsize) ) > + goto fail; > + > + /* > + * Physical bank hasn't been totally mapped, > + * seeking to the next guest RAM i+1, if exist. > + */ > + if ( ++gbank < GUEST_RAM_BANKS ) > + { > + psize = psize - gsize; > + smfn = mfn_add(smfn, gsize >> PAGE_SHIFT); > + gsize = ramsize[gbank]; > + sgfn = gaddr_to_gfn(rambase[gbank]); > + } > + else > + goto fail; > + } The double loop is not nice but I can't think of a better way. However, I think the code in the loop can be simplified. You could write something like: /* Map as much as possible the static range to the guest bank */ if ( !allocate_static_bank(..., min(psize, gsize) ) goto fail; /* The physical bank is fully mapped. Handle the next bank. */ if ( gsize >= psize ) { gsize = gsize - psize; bank++; break; } /* We still have memory to map. Check if we have another guest bank available */ else if ( ++gbank > GUEST_RAM_BANKS ) { printk("Exhausted the number of guest bank\n"); goto fail; } [Update to the next guest bank] > + } > + } > + return tot_size; > + > +fail: > + panic("Failed to allocate requested static memory for domain %pd." > + "Fix the VMs configurations.\n", > + d); > +} > + > static int __init write_properties(struct domain *d, struct kernel_info *kinfo, > const struct dt_device_node *node) > { > @@ -2437,8 +2589,7 @@ static int __init construct_domU(struct domain *d, > if ( prop ) > { > static_mem = true; > - /* static_mem_size = allocate_static_memory(...); */ > - BUG(); > + static_mem_size = allocate_static_memory(d, &kinfo, node); > } > > rc = dt_property_read_u64(node, "memory", &mem); > Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sat Jul 03 14:42:34 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 03 Jul 2021 14:42:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149514.276513 (Exim 4.92) (envelope-from ) id 1lzgqi-00032I-Gk; Sat, 03 Jul 2021 14:42:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149514.276513; Sat, 03 Jul 2021 14:42:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzgqi-00032B-DM; Sat, 03 Jul 2021 14:42:28 +0000 Received: by outflank-mailman (input) for mailman id 149514; Sat, 03 Jul 2021 14:42:27 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzgqh-000325-JD for xen-devel@lists.xenproject.org; Sat, 03 Jul 2021 14:42:27 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzgqZ-0004aN-49; Sat, 03 Jul 2021 14:42:19 +0000 Received: from [54.239.6.185] (helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lzgqY-0006IK-Sp; Sat, 03 Jul 2021 14:42:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=GmGfj4CP4QhiHxEv9OGxje+2tXPZSSTOYjEoiJtqazA=; b=QQHcl4/apn4T/UBYefJVqgACSS lEz+3Zwrs7wA6fxFbJWMDvDW+9QBV7R0/kWZXVi8JKtSmoZ0T48WwWSMUkyLJwQbklYbPYZAIYYcu sY1H4IU3pGOEUgiEssRUfpk0RLd6KztJLh8qZoW6PKoXmAD2idPVZfCeqXhUfkstbRLY=; Subject: Re: [PATCH v3 10/10] arm64: Change type of hsr, cpsr, spsr_el1 to uint64_t To: Michal Orzel , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Wei Liu , Tamas K Lengyel , Alexandru Isaila , Petre Pircalabu , bertrand.marquis@arm.com, wei.chen@arm.com References: <20210505074308.11016-1-michal.orzel@arm.com> <20210505074308.11016-11-michal.orzel@arm.com> <9bc0a398-8920-3a95-1bb4-f32e8753972b@arm.com> From: Julien Grall Message-ID: Date: Sat, 3 Jul 2021 15:42:15 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <9bc0a398-8920-3a95-1bb4-f32e8753972b@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit On 01/07/2021 09:19, Michal Orzel wrote: > Hi Julien, Hi Michal, > On 07.06.2021 15:31, Julien Grall wrote: >> Hi, >> >> On 05/05/2021 08:43, Michal Orzel wrote: >>> AArch64 registers are 64bit whereas AArch32 registers >>> are 32bit or 64bit. MSR/MRS are expecting 64bit values thus >>> we should get rid of helpers READ/WRITE_SYSREG32 >>> in favour of using READ/WRITE_SYSREG. >>> We should also use register_t type when reading sysregs >>> which can correspond to uint64_t or uint32_t. >>> Even though many AArch64 registers have upper 32bit reserved >>> it does not mean that they can't be widen in the future. >>> >>> Modify type of hsr, cpsr, spsr_el1 to uint64_t. >>> Previously we relied on the padding after SPSR_EL1. >>> As we removed the padding, modify the union to be 64bit so we don't corrupt SPSR_FIQ. >>> No need to modify the assembly code becuase the accesses were based on 64bit >> >> s/becuase/because/ >> > Will do. >>> registers as there was a 32bit padding after SPSR_EL1. >>> >>> Remove 32bit padding in cpu_user_regs before spsr_fiq >>> as it is no longer needed due to upper union being 64bit now. >>> Add 64bit padding in cpu_user_regs before spsr_el1 >>> because offset of spsr_el1 must be a multiple of 8. >>> >>> Change type of cpsr to uint64_t in the public outside interface >>> "public/arch-arm.h" to allow ABI compatibility between 32bit and 64bit. >>> Increment XEN_DOMCTL_INTERFACE_VERSION. >>> >>> Change type of cpsr to uint64_t in the public outside interface >>> "public/vm_event.h" to allow ABI compatibility between 32bit and 64bit. >> [...] >> >>> diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c >>> index e7384381cc..c8f9773566 100644 >>> --- a/xen/arch/arm/traps.c >>> +++ b/xen/arch/arm/traps.c >>> @@ -546,7 +546,7 @@ void inject_undef64_exception(struct cpu_user_regs *regs, int instr_len) >>>           PSR_IRQ_MASK | PSR_DBG_MASK; >>>       regs->pc = handler; >>>   -    WRITE_SYSREG32(esr.bits, ESR_EL1); >>> +    WRITE_SYSREG(esr.bits, ESR_EL1); >>>   } >>>     /* Inject an abort exception into a 64 bit guest */ >>> @@ -580,7 +580,7 @@ static void inject_abt64_exception(struct cpu_user_regs *regs, >>>       regs->pc = handler; >>>         WRITE_SYSREG(addr, FAR_EL1); >>> -    WRITE_SYSREG32(esr.bits, ESR_EL1); >>> +    WRITE_SYSREG(esr.bits, ESR_EL1); >>>   } >>>     static void inject_dabt64_exception(struct cpu_user_regs *regs, >>> @@ -717,7 +717,7 @@ struct reg_ctxt { >>>       uint64_t vttbr_el2; >>>   }; >>>   -static const char *mode_string(uint32_t cpsr) >>> +static const char *mode_string(register_t cpsr) >>>   { >>>       uint32_t mode; >>>       static const char *mode_strings[] = { >>> @@ -756,14 +756,16 @@ static void show_registers_32(const struct cpu_user_regs *regs, >>>   #ifdef CONFIG_ARM_64 >>>       BUG_ON( ! (regs->cpsr & PSR_MODE_BIT) ); >>>       printk("PC:     %08"PRIx32"\n", regs->pc32); >>> +    printk("CPSR:   %016"PRIx64" MODE:%s\n", regs->cpsr, >>> +           mode_string(regs->cpsr)); >> Why do you now need to duplicate this line? Can't we use PRIregister you did everywhere else a register is printed? >> > Indeed we do not need. It was needed at the beginning but I do not remember why. I will fix it. >>>   #else >>>       printk("PC:     %08"PRIx32, regs->pc); >>>       if ( !guest_mode ) >>>           printk(" %pS", _p(regs->pc)); >>>       printk("\n"); >>> -#endif >>>       printk("CPSR:   %08"PRIx32" MODE:%s\n", regs->cpsr, >>>              mode_string(regs->cpsr)); >>> +#endif >> >> [...] >> >>> diff --git a/xen/include/asm-arm/arm64/processor.h b/xen/include/asm-arm/arm64/processor.h >>> index 81dfc5e615..0e86079cbb 100644 >>> --- a/xen/include/asm-arm/arm64/processor.h >>> +++ b/xen/include/asm-arm/arm64/processor.h >>> @@ -63,18 +63,19 @@ struct cpu_user_regs >>>         /* Return address and mode */ >>>       __DECL_REG(pc,           pc32);             /* ELR_EL2 */ >>> -    uint32_t cpsr;                              /* SPSR_EL2 */ >>> -    uint32_t hsr;                               /* ESR_EL2 */ >>> +    uint64_t cpsr;                              /* SPSR_EL2 */ >>> +    uint64_t hsr;                               /* ESR_EL2 */ >>> + >>> +    /* Offset of spsr_el1 must be a multiple of 8 */ >> >> I am guessing you are saying it should be 8-byte aligned, right? If so, the field before is a 64-bit value, therefore the offset should already be a multiple of 8. Did I miss anything? >> > Well, instead of 8 I should write 16. > We have 2 bug_on checks: > 1) BUILD_BUG_ON((sizeof (struct cpu_user_regs)) & 0xf); > 2) BUILD_BUG_ON((offsetof(struct cpu_user_regs, spsr_el1)) & 0xf); > > Total size of cpu_user_regs without padding is 344 which does not pass the first check. > With the padding it is 352 and it passes the first check. > > The offset without padding is 280 which does not pass the second check. > The offset with padding is 288 which passes the second check. Ah yes, I forgot that the stack should always be 16-byte aligned. > > So I should write: > "/* Offset of spsr_el1 must be a multiple of 16 bytes */" I would suggest the following comment: /* The kernel frame should be 16-byte aligned. */ So this would make clear that the 16-byte requirement is for the frame itself. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sat Jul 03 14:58:31 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 03 Jul 2021 14:58:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149522.276530 (Exim 4.92) (envelope-from ) id 1lzh6B-0004cZ-6n; Sat, 03 Jul 2021 14:58:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149522.276530; Sat, 03 Jul 2021 14:58:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzh6B-0004cS-3H; Sat, 03 Jul 2021 14:58:27 +0000 Received: by outflank-mailman (input) for mailman id 149522; Sat, 03 Jul 2021 14:58:25 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzh69-0004cI-Fb; Sat, 03 Jul 2021 14:58:25 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzh69-0004s5-8j; Sat, 03 Jul 2021 14:58:25 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzh68-0000mz-Ve; Sat, 03 Jul 2021 14:58:25 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lzh68-0002Xo-V7; Sat, 03 Jul 2021 14:58:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=MA0fhymsYjcx/1c/QGxNY81YbqHBRc5bPNLPLGbwntE=; b=iujC3O102jjwf87ZgbWEtIeYl0 ptLOclOwCOhuFwEFi/gu+68SD9ib4UgDjGTAXi693jLzRA8HPCK6Qh766PYNOC6Km231Xm0LOr59U kX8Yiwopnc2YIQTipRUjFu9MLtKSxyk46NSae22kmltnr2uLaCppNkkvpK5wAPU/DQGo=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 163235: regressions - FAIL X-Osstest-Failures: qemu-mainline:test-amd64-amd64-qemuu-nested-amd:xen-boot/l1:fail:regression qemu-mainline:test-amd64-amd64-qemuu-nested-intel:xen-boot/l1:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=9c2647f75004c4f7d64c9c0ec55f8c6f0739a8b1 X-Osstest-Versions-That: qemuu=1d806cef0e38b5db8347a8e12f214d543204a314 From: osstest service owner Date: Sat, 03 Jul 2021 14:58:24 +0000 flight 163235 qemu-mainline real [real] flight 163270 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/163235/ http://logs.test-lab.xenproject.org/osstest/logs/163270/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-qemuu-nested-amd 16 xen-boot/l1 fail REGR. vs. 152631 test-amd64-amd64-qemuu-nested-intel 16 xen-boot/l1 fail REGR. vs. 152631 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152631 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 152631 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 152631 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152631 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152631 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 152631 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152631 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass version targeted for testing: qemuu 9c2647f75004c4f7d64c9c0ec55f8c6f0739a8b1 baseline version: qemuu 1d806cef0e38b5db8347a8e12f214d543204a314 Last test of basis 152631 2020-08-20 09:07:46 Z 317 days Failing since 152659 2020-08-21 14:07:39 Z 316 days 580 attempts Testing same since 163228 2021-07-02 17:08:27 Z 0 days 2 attempts ------------------------------------------------------------ 554 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 182071 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Jul 03 17:12:12 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 03 Jul 2021 17:12:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149550.276628 (Exim 4.92) (envelope-from ) id 1lzjBW-0001DT-PM; Sat, 03 Jul 2021 17:12:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149550.276628; Sat, 03 Jul 2021 17:12:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzjBW-0001Ae-H8; Sat, 03 Jul 2021 17:12:06 +0000 Received: by outflank-mailman (input) for mailman id 149550; Sat, 03 Jul 2021 17:12:05 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzjBV-0000rQ-2j for xen-devel@lists.xenproject.org; Sat, 03 Jul 2021 17:12:05 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzjBT-0007c2-FM; Sat, 03 Jul 2021 17:12:03 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=ufe34d9ed68d054.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lzjBT-0005vs-6h; Sat, 03 Jul 2021 17:12:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=2pkpvyGryxTS4uBplOORxJnDBZlpgWoUp7jdUVlTkUk=; b=PsTwUivc5yu22Oe9pxT9BLzvy k0g6AirkHbuRzdlKfdYTloWhxO6D+Mx9hrsSY0OdqAOQJByi7WjKJAvRVmFYtflr3dt1GM1NNhBWQ g0DUfCflztgPKFN9OGedj1wtuzDkfaS9zl78dzASKACE17rKh08kOZXcKjG6CG6CbSM3k=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: julien@xen.org, Julien Grall , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , George Dunlap , Ian Jackson , Stefano Stabellini Subject: [PATCH v5 2/4] xen: arm: Stop returning a bogus GFN for the shared info Date: Sat, 3 Jul 2021 18:11:50 +0100 Message-Id: <20210703171152.15874-3-julien@xen.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210703171152.15874-1-julien@xen.org> References: <20210703171152.15874-1-julien@xen.org> From: Julien Grall While Arm never had a M2P, the implementation of mfn_to_gfn() is pretty bogus as we directly return the MFN passed in parameter. The last use of mfn_to_gfn() on Arm is in getdomaininfo(). It looks like this is mostly used for mapping the P2M Of PV guest. Furthermore, the structure on Arm doesn't seem to contain a lot of useful information. Therefore it is unclear whether we want to allow the toolstack to map it. As there is a high change that RISC-V will not implement an M2P, provide a new wrapper that will by default return an invalid GFN and move the code to find the GFN in an x86 specific helper. If in the future we want to map the shared info, then we should consider to do it using the acquire hypercall. Note that as INVALID_GFN is unsigned long, we can't return directly because the value would differ between 64-bit and 32-bit. Instead, a fixed value needs to be introduced. While the fixed value could be shared with other field storing a GFN, we unfortunately use a mix of type (unsigned long, uint64_t) for exposing it externally. So to avoid any misuse, it is better to define a fixed value for just the shared_info_gfn field. Signed-off-by Julien Grall --- I am not comfortable with introduce a generic invalid GFN fixed value because we don't use a common type. I also didn't get any feedback on whether it would be acceptable to focus on one type. So the fixed value has not been changed. I think this is acceptable because this a DOMCTL and therefore not stable. If someone still disagree, then please provide concrete steps how to solve the mixing of type. Changes in v5: - This was originally "xen: Introduce HAS_M2P config and use to protect mfn_to_gmfn call". - Rebase to the latest Xen. - Rename the helper to arch_shared_info_gfn() - The default stub now return INVALID_GFN rather than using the M2P Changes in v4: - The IOMMU code doesn't use the M2P anymore, so this can be dropped. - Reword the commit message - Fix rebase conflict Changes in v3: - Move the BUG_ON() in domain_shared_info_gfn() - Use a fixed value when the field shared_info_frame is not supported. - Add an ASSERT_UNREACHABLE in iommu_hwdom_init + move printk within the #ifdef. Changes in v2: - Add a warning in public headers - Constify local variable in domain_shared_info_gfn - Invert the naming (_d / d) in domain_shared_info_gfn - Use -EOPNOTSUPP rather than -ENOSYS - Rework how the memory_exchange hypercall is removed from Arm --- xen/arch/x86/domain.c | 9 +++++++++ xen/common/Kconfig | 3 +++ xen/common/domctl.c | 10 +++++++--- xen/include/asm-x86/domain.h | 3 +++ xen/include/public/domctl.h | 6 ++++++ xen/include/xen/domain.h | 7 +++++++ 6 files changed, 35 insertions(+), 3 deletions(-) diff --git a/xen/arch/x86/domain.c b/xen/arch/x86/domain.c index ef1812dc1402..b3f216cd6f51 100644 --- a/xen/arch/x86/domain.c +++ b/xen/arch/x86/domain.c @@ -2553,6 +2553,15 @@ void domain_pause_for_debugger(void) #endif } +gfn_t arch_shared_info_gfn(const struct domain *d) +{ + gfn_t gfn = mfn_to_gfn(d, _mfn(__virt_to_mfn(d->shared_info))); + + BUG_ON(SHARED_M2P(gfn_x(gfn))); + + return gfn; +} + /* * Local variables: * mode: C diff --git a/xen/common/Kconfig b/xen/common/Kconfig index 0ddd18e11af3..cd5b89f2f02e 100644 --- a/xen/common/Kconfig +++ b/xen/common/Kconfig @@ -64,6 +64,9 @@ config MEM_ACCESS Framework to configure memory access types for guests and receive related events in userspace. +config HAS_M2P + bool + config NEEDS_LIBELF bool diff --git a/xen/common/domctl.c b/xen/common/domctl.c index 12d6144d2896..834a2183fda1 100644 --- a/xen/common/domctl.c +++ b/xen/common/domctl.c @@ -68,6 +68,7 @@ void getdomaininfo(struct domain *d, struct xen_domctl_getdomaininfo *info) u64 cpu_time = 0; int flags = XEN_DOMINF_blocked; struct vcpu_runstate_info runstate; + gfn_t shared_info_frame; info->domain = d->domain_id; info->max_vcpu_id = XEN_INVALID_MAX_VCPU_ID; @@ -111,9 +112,12 @@ void getdomaininfo(struct domain *d, struct xen_domctl_getdomaininfo *info) info->outstanding_pages = d->outstanding_pages; info->shr_pages = atomic_read(&d->shr_pages); info->paged_pages = atomic_read(&d->paged_pages); - info->shared_info_frame = - gfn_x(mfn_to_gfn(d, _mfn(virt_to_mfn(d->shared_info)))); - BUG_ON(SHARED_M2P(info->shared_info_frame)); + + shared_info_frame = arch_shared_info_gfn(d); + if ( gfn_eq(shared_info_frame, INVALID_GFN) ) + info->shared_info_frame = XEN_INVALID_SHARED_INFO_FRAME; + else + info->shared_info_frame = gfn_x(shared_info_frame); info->cpupool = cpupool_get_id(d); diff --git a/xen/include/asm-x86/domain.h b/xen/include/asm-x86/domain.h index 92d54de0b9a1..912a545c93f6 100644 --- a/xen/include/asm-x86/domain.h +++ b/xen/include/asm-x86/domain.h @@ -756,6 +756,9 @@ static inline void pv_inject_sw_interrupt(unsigned int vector) : is_pv_32bit_domain(d) ? PV32_VM_ASSIST_MASK \ : PV64_VM_ASSIST_MASK) +gfn_t arch_shared_info_gfn(const struct domain *d); +#define arch_shared_info_gfn arch_shared_info_gfn + #endif /* __ASM_DOMAIN_H__ */ /* diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h index 4dbf107785c3..02a2bfa969ec 100644 --- a/xen/include/public/domctl.h +++ b/xen/include/public/domctl.h @@ -141,6 +141,12 @@ struct xen_domctl_getdomaininfo { uint64_aligned_t outstanding_pages; uint64_aligned_t shr_pages; uint64_aligned_t paged_pages; +#define XEN_INVALID_SHARED_INFO_FRAME (~(uint64_t)0) + /* + * GFN of shared_info struct. Some architectures (e.g Arm) may not + * provide a mappable address in the field. In that case, the field + * will be set to XEN_INVALID_SHARED_INFO_FRAME. + */ uint64_aligned_t shared_info_frame; /* GMFN of shared_info struct */ uint64_aligned_t cpu_time; uint32_t nr_online_vcpus; /* Number of VCPUs currently online. */ diff --git a/xen/include/xen/domain.h b/xen/include/xen/domain.h index 1708c369642e..d8044b7936ae 100644 --- a/xen/include/xen/domain.h +++ b/xen/include/xen/domain.h @@ -133,4 +133,11 @@ static inline void vnuma_destroy(struct vnuma_info *vnuma) { ASSERT(!vnuma); } extern bool vmtrace_available; +#ifndef arch_shared_info_gfn +static inline gfn_t arch_shared_info_gfn(const struct domain *d) +{ + return INVALID_GFN; +} +#endif + #endif /* __XEN_DOMAIN_H__ */ -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Sat Jul 03 17:12:12 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 03 Jul 2021 17:12:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149551.276641 (Exim 4.92) (envelope-from ) id 1lzjBZ-0001eJ-0U; Sat, 03 Jul 2021 17:12:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149551.276641; Sat, 03 Jul 2021 17:12:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzjBY-0001e6-SB; Sat, 03 Jul 2021 17:12:08 +0000 Received: by outflank-mailman (input) for mailman id 149551; Sat, 03 Jul 2021 17:12:07 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzjBX-0001Wu-HV for xen-devel@lists.xenproject.org; Sat, 03 Jul 2021 17:12:07 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzjBW-0007ce-5b; Sat, 03 Jul 2021 17:12:06 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=ufe34d9ed68d054.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lzjBV-0005vs-TO; Sat, 03 Jul 2021 17:12:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=aIWtWhcuPOkNdbKN38vfGnv+lqziWSfdZNPE+Udjlj8=; b=Vf9Vm+yQSPcRJdNGq9MMtxp0c OwQStU5yFNCZGF9m4yO8Pu6lx/vbibpnPWFR9QnVeKuAkEiUFDn6XVxdISUM3N4mXJ4NHvMMt04dy sE4oKpjcoW3XIFTKfFmtGH+k0h9mh0kWm9Zj3Ax4nVGFt6J66u2ZlfhKRuclXqXTypGnc=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: julien@xen.org, Julien Grall , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , George Dunlap , Ian Jackson , Stefano Stabellini , Volodymyr Babchuk Subject: [PATCH v5 4/4] xen/mm: Provide dummy M2P-related helpers when the M2P is not supported Date: Sat, 3 Jul 2021 18:11:52 +0100 Message-Id: <20210703171152.15874-5-julien@xen.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210703171152.15874-1-julien@xen.org> References: <20210703171152.15874-1-julien@xen.org> From: Julien Grall At the moment, Arm is providing a dummy implementation for the M2P helpers used in common code. However, they are quite isolated and could be used by other architecture in the future. So move the helpers necessary for compilation in xen/mm.h and gate them with a new config !HAS_M2P. The other M2P related helpers are removed. Take the opportunity to encode that CONFIG_MEM_SHARING requires the M2P. It is done in the header rather than the Kconfig because the option is not defined in the common Kconfig. Signed-off-by: Julien Grall --- INVALID_M2P_ENTRY needs to be defined because it is a parameter of set_gpfn_from_mfn(). The alternative would be to not evaluate the parameter 'pfn' (e.g. leave the helper as a macro) however this is a bit risky. Changes in v5: - Check that MEM_SHARING is not enabled without the M2P. Changes in v4: - The tags were dropped as the previous version was sent a long time ago. Changes in v3: - Add Stefano's reviewed-by - Add George's acked-by Changes in v2: - Patch added --- xen/arch/x86/Kconfig | 1 + xen/include/asm-arm/mm.h | 11 ----------- xen/include/xen/mm.h | 17 +++++++++++++++++ 3 files changed, 18 insertions(+), 11 deletions(-) diff --git a/xen/arch/x86/Kconfig b/xen/arch/x86/Kconfig index 9b164db64187..a083d8194680 100644 --- a/xen/arch/x86/Kconfig +++ b/xen/arch/x86/Kconfig @@ -16,6 +16,7 @@ config X86 select HAS_FAST_MULTIPLY select HAS_IOPORTS select HAS_KEXEC + select HAS_M2P select HAS_NS16550 select HAS_PASSTHROUGH select HAS_PCI diff --git a/xen/include/asm-arm/mm.h b/xen/include/asm-arm/mm.h index 07c24654a0b6..beff43786bda 100644 --- a/xen/include/asm-arm/mm.h +++ b/xen/include/asm-arm/mm.h @@ -318,17 +318,6 @@ static inline void *page_to_virt(const struct page_info *pg) struct page_info *get_page_from_gva(struct vcpu *v, vaddr_t va, unsigned long flags); -/* - * Arm does not have an M2P, but common code expects a handful of - * M2P-related defines and functions. Provide dummy versions of these. - */ -#define INVALID_M2P_ENTRY (~0UL) -#define SHARED_M2P_ENTRY (~0UL - 1UL) -#define SHARED_M2P(_e) ((_e) == SHARED_M2P_ENTRY) - -/* We don't have a M2P on Arm */ -#define set_gpfn_from_mfn(mfn, pfn) do { (void) (mfn), (void)(pfn); } while (0) - /* Arch-specific portion of memory_op hypercall. */ long arch_memory_op(int op, XEN_GUEST_HANDLE_PARAM(void) arg); diff --git a/xen/include/xen/mm.h b/xen/include/xen/mm.h index 667f9dac83a4..b98a1a7f423f 100644 --- a/xen/include/xen/mm.h +++ b/xen/include/xen/mm.h @@ -612,4 +612,21 @@ static inline void put_page_alloc_ref(struct page_info *page) } } +/* + * Dummy implementation of M2P-related helpers for common code when + * the architecture doesn't have an M2P. + */ +#ifndef CONFIG_HAS_M2P + +#ifdef CONFIG_MEM_SHARING +# error "Memory sharing depends on the M2P" +#endif + +#define INVALID_M2P_ENTRY (~0UL) +#define SHARED_M2P(_e) ((void)(_e), false) + +static inline void set_gpfn_from_mfn(unsigned long mfn, unsigned long pfn) {} + +#endif + #endif /* __XEN_MM_H__ */ -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Sat Jul 03 17:12:12 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 03 Jul 2021 17:12:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149549.276620 (Exim 4.92) (envelope-from ) id 1lzjBW-00014u-5H; Sat, 03 Jul 2021 17:12:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149549.276620; Sat, 03 Jul 2021 17:12:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzjBW-00014n-1z; Sat, 03 Jul 2021 17:12:06 +0000 Received: by outflank-mailman (input) for mailman id 149549; Sat, 03 Jul 2021 17:12:04 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzjBU-0000oO-Ne for xen-devel@lists.xenproject.org; Sat, 03 Jul 2021 17:12:04 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzjBU-0007cA-Fg; Sat, 03 Jul 2021 17:12:04 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=ufe34d9ed68d054.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lzjBU-0005vs-7I; Sat, 03 Jul 2021 17:12:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=FR0yQDCD2iJpaV70AOOT+E3zRKLyD/84/EMXzs8PXvw=; b=zZ9vO3J39ZF/biDQHuJOiEOO7 4ShvOFdqg6iNCoF7G/1vB3Zbg+oEe4b8sh2XDSLlkE9CdpFbfo1c8aTAAzK0eRUrxcm7IIrQG2557 eTV9edB03YJBc5W8D8aZ/alX34kzdIOMlRt6xwND8xrjoLgnMKLYrukvjO6xAZdzpKz20=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: julien@xen.org, Julien Grall , Stefano Stabellini , Volodymyr Babchuk Subject: [PATCH v5 3/4] xen: arm: Remove mfn_to_gfn() macro Date: Sat, 3 Jul 2021 18:11:51 +0100 Message-Id: <20210703171152.15874-4-julien@xen.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210703171152.15874-1-julien@xen.org> References: <20210703171152.15874-1-julien@xen.org> From: Julien Grall The current implementation of mfn_to_gfn() is completely bogus and there are no plan to implement an M2P on Arm. As there are no more users, drop the helper. At the same time rework a comment in Arm code that does not make sense. Signed-off-by: Julien Grall --- Changes in v5: - Rebase to the latest Xen - The patch is now arm only because mfn_to_gmfn() has been dropped on x86 and the arm helper was renamed to mfn_to_gfn(). Changes in v4: - Remove acks as the patch is old Changes in v2: - Add Jan's and Stefano's acked-by --- xen/include/asm-arm/mm.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/xen/include/asm-arm/mm.h b/xen/include/asm-arm/mm.h index ded74d29da0c..07c24654a0b6 100644 --- a/xen/include/asm-arm/mm.h +++ b/xen/include/asm-arm/mm.h @@ -326,9 +326,8 @@ struct page_info *get_page_from_gva(struct vcpu *v, vaddr_t va, #define SHARED_M2P_ENTRY (~0UL - 1UL) #define SHARED_M2P(_e) ((_e) == SHARED_M2P_ENTRY) -/* Xen always owns P2M on ARM */ +/* We don't have a M2P on Arm */ #define set_gpfn_from_mfn(mfn, pfn) do { (void) (mfn), (void)(pfn); } while (0) -#define mfn_to_gfn(d, mfn) ((void)(d), _gfn(mfn_x(mfn))) /* Arch-specific portion of memory_op hypercall. */ long arch_memory_op(int op, XEN_GUEST_HANDLE_PARAM(void) arg); -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Sat Jul 03 17:12:13 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 03 Jul 2021 17:12:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149548.276609 (Exim 4.92) (envelope-from ) id 1lzjBU-0000oa-UO; Sat, 03 Jul 2021 17:12:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149548.276609; Sat, 03 Jul 2021 17:12:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzjBU-0000oT-Pc; Sat, 03 Jul 2021 17:12:04 +0000 Received: by outflank-mailman (input) for mailman id 149548; Sat, 03 Jul 2021 17:12:03 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzjBT-0000YD-BV for xen-devel@lists.xenproject.org; Sat, 03 Jul 2021 17:12:03 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzjBR-0007bT-Ta; Sat, 03 Jul 2021 17:12:01 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=ufe34d9ed68d054.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lzjBR-0005vs-KR; Sat, 03 Jul 2021 17:12:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=Mi7EgN/CRi27LYrSm9zQaxJ46g16tr2Wj55yCnIlKA4=; b=I/EuoQBYvNK1bKaRntBYRnGvh FJ43TXmrBKZj4zbksjE7SIxxWCUKk6nfjSWCj0x0iJJ7YgMKjcCmrz8/L0gJwva1bxEltPCOYbypW buNjjooGqQMKG6EXQ6nAueboG2EfwBVx6u/Sn0arGUPWI1///rBxo1zrPXvaKuBnFnhK0=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: julien@xen.org, Julien Grall , Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Stefano Stabellini , Wei Liu Subject: [PATCH v5 1/4] xen: XENMEM_exchange should only be used/compiled for arch supporting PV guest Date: Sat, 3 Jul 2021 18:11:49 +0100 Message-Id: <20210703171152.15874-2-julien@xen.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210703171152.15874-1-julien@xen.org> References: <20210703171152.15874-1-julien@xen.org> From: Julien Grall XENMEM_exchange can only be used by PV guest but the check is well hidden in steal_page(). This is because paging_model_external() will return false only for PV domain. To make clearer this is PV only, add a check at the beginning of the implementation. In a follow-up patch, mfn_to_gfn() will be completely removed for arch not supporting M2P as it is a call for trouble to use it. Take the opportunity to compile out the code if CONFIG_PV is not set. Ideally, we would want to to move the hypercall implementation in arch/x86/pv/mm.c. But this is incredibly tangled. Signed-off-by: Julien Grall --- Ideally we would want to move the hypercall implementation in arch/x86/pv/mm.c. But this is a bit messy. So for now just #ifdef it. Changes in v5: - Removed the #ifdef CONFIG_X86 as they are not necessary anymore - Used paging_mode_translate() rather than is_pv_domain() - Reword the commit message to explain why the #ifdef rather than implementing mfn_to_gfn() using a BUG_ON() or moving the code to arch/x86/pv. Changes in v4: - Patch added --- xen/common/memory.c | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/xen/common/memory.c b/xen/common/memory.c index e07bd9a5ea4b..9bc78aae35db 100644 --- a/xen/common/memory.c +++ b/xen/common/memory.c @@ -522,6 +522,7 @@ static bool propagate_node(unsigned int xmf, unsigned int *memflags) static long memory_exchange(XEN_GUEST_HANDLE_PARAM(xen_memory_exchange_t) arg) { +#ifdef CONFIG_PV struct xen_memory_exchange exch; PAGE_LIST_HEAD(in_chunk_list); PAGE_LIST_HEAD(out_chunk_list); @@ -609,6 +610,13 @@ static long memory_exchange(XEN_GUEST_HANDLE_PARAM(xen_memory_exchange_t) arg) goto fail_early; } + if ( paging_mode_translate(d) ) + { + rc = -EOPNOTSUPP; + rcu_unlock_domain(d); + goto fail_early; + } + rc = xsm_memory_exchange(XSM_TARGET, d); if ( rc ) { @@ -648,7 +656,6 @@ static long memory_exchange(XEN_GUEST_HANDLE_PARAM(xen_memory_exchange_t) arg) for ( k = 0; k < (1UL << exch.in.extent_order); k++ ) { -#ifdef CONFIG_X86 p2m_type_t p2mt; /* Shared pages cannot be exchanged */ @@ -659,14 +666,9 @@ static long memory_exchange(XEN_GUEST_HANDLE_PARAM(xen_memory_exchange_t) arg) rc = -ENOMEM; goto fail; } -#else /* !CONFIG_X86 */ - mfn = gfn_to_mfn(d, _gfn(gmfn + k)); -#endif if ( unlikely(!mfn_valid(mfn)) ) { -#ifdef CONFIG_X86 put_gfn(d, gmfn + k); -#endif rc = -EINVAL; goto fail; } @@ -676,16 +678,12 @@ static long memory_exchange(XEN_GUEST_HANDLE_PARAM(xen_memory_exchange_t) arg) rc = steal_page(d, page, MEMF_no_refcount); if ( unlikely(rc) ) { -#ifdef CONFIG_X86 put_gfn(d, gmfn + k); -#endif goto fail; } page_list_add(page, &in_chunk_list); -#ifdef CONFIG_X86 put_gfn(d, gmfn + k); -#endif } } @@ -768,8 +766,7 @@ static long memory_exchange(XEN_GUEST_HANDLE_PARAM(xen_memory_exchange_t) arg) guest_physmap_add_page(d, _gfn(gpfn), mfn, exch.out.extent_order); - if ( !paging_mode_translate(d) && - __copy_mfn_to_guest_offset(exch.out.extent_start, + if ( __copy_mfn_to_guest_offset(exch.out.extent_start, (i << out_chunk_order) + j, mfn) ) rc = -EFAULT; @@ -815,6 +812,9 @@ static long memory_exchange(XEN_GUEST_HANDLE_PARAM(xen_memory_exchange_t) arg) if ( __copy_field_to_guest(arg, &exch, nr_exchanged) ) rc = -EFAULT; return rc; +#else /* !CONFIG_PV */ + return -EOPNOTSUPP; +#endif } int xenmem_add_to_physmap(struct domain *d, struct xen_add_to_physmap *xatp, -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Sat Jul 03 17:12:13 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 03 Jul 2021 17:12:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149547.276598 (Exim 4.92) (envelope-from ) id 1lzjBT-0000YQ-KW; Sat, 03 Jul 2021 17:12:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149547.276598; Sat, 03 Jul 2021 17:12:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzjBT-0000YI-Gt; Sat, 03 Jul 2021 17:12:03 +0000 Received: by outflank-mailman (input) for mailman id 149547; Sat, 03 Jul 2021 17:12:02 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzjBS-0000Y7-9U for xen-devel@lists.xenproject.org; Sat, 03 Jul 2021 17:12:02 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzjBQ-0007bO-Ff; Sat, 03 Jul 2021 17:12:00 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=ufe34d9ed68d054.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lzjBQ-0005vs-5R; Sat, 03 Jul 2021 17:12:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Message-Id:Date:Subject:Cc:To:From; bh=vTIblyBJkpB3RsYgL5DJmQYV9pVCyJkl3ZpMr+Zl/bY=; b=qibpoE9J4RlwAnl6LmKai9Kq6R HeBOO/oWwtwGxjM5OEv5/PgsxaIAB1vwYh4BJOjIQQhx5ilym+0MCFFpHmSPinch9Yy23nhrUvKGk 70xot3ergBj8VyVDZOoC3ol8DFsTyTBY77Ec4QLIePcq6Lz2npq60s5RNBkxa1BQSzLU=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: julien@xen.org, Julien Grall , Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Stefano Stabellini , Wei Liu , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Volodymyr Babchuk Subject: [PATCH v5 0/4] xen/arm: Properly disable M2P on Arm Date: Sat, 3 Jul 2021 18:11:48 +0100 Message-Id: <20210703171152.15874-1-julien@xen.org> X-Mailer: git-send-email 2.17.1 From: Julien Grall Hi all, Arm never supported a M2P yet there are some helpers implemented to deal with the common code. However, the implementation of mfn_to_gmfn is completely bogus. This series aims to properly disable the M2P on Arm. Cheers, Julien Grall (4): xen: XENMEM_exchange should only be used/compiled for arch supporting PV guest xen: arm: Stop returning a bogus GFN for the shared info xen: arm: Remove mfn_to_gfn() macro xen/mm: Provide dummy M2P-related helpers when the M2P is not supported xen/arch/x86/Kconfig | 1 + xen/arch/x86/domain.c | 9 +++++++++ xen/common/Kconfig | 3 +++ xen/common/domctl.c | 10 +++++++--- xen/common/memory.c | 24 ++++++++++++------------ xen/include/asm-arm/mm.h | 12 ------------ xen/include/asm-x86/domain.h | 3 +++ xen/include/public/domctl.h | 6 ++++++ xen/include/xen/domain.h | 7 +++++++ xen/include/xen/mm.h | 17 +++++++++++++++++ 10 files changed, 65 insertions(+), 27 deletions(-) -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Sat Jul 03 17:17:55 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 03 Jul 2021 17:17:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149570.276656 (Exim 4.92) (envelope-from ) id 1lzjH4-0003k1-QF; Sat, 03 Jul 2021 17:17:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149570.276656; Sat, 03 Jul 2021 17:17:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzjH4-0003ju-Ma; Sat, 03 Jul 2021 17:17:50 +0000 Received: by outflank-mailman (input) for mailman id 149570; Sat, 03 Jul 2021 17:17:49 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzjH3-0003jo-Fs for xen-devel@lists.xenproject.org; Sat, 03 Jul 2021 17:17:49 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzjH1-0007lM-LK; Sat, 03 Jul 2021 17:17:47 +0000 Received: from [54.239.6.185] (helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lzjH1-0006Hx-Ep; Sat, 03 Jul 2021 17:17:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=3UfzSvMMnZkxcyV4Kvv08/v+z5+aqf8C6iBaDyXpPcM=; b=K5ELL+7YlduhIpK/sI+E1DPzeC KFxa7HiFU2JbztqXPVClRqDSJgKhFf5sgDhcJb1HKETr/ndBJdUMALy95+PXcMdgAtcHBeFv+i3G5 HbBcvyzpzyXBsUrFoqnBL+DM+uQGeUuhI5jfNjKtO8UEm2FcXG0wbR4FiwrsN14QNlZU=; Subject: Re: Uses of /hypervisor memory range (was: FreeBSD/Xen/ARM issues) To: Oleksandr Andrushchenko , Stefano Stabellini Cc: Elliott Mitchell , xen-devel@lists.xenproject.org, Roger Pau Monn?? , Mitchell Horne , Andrew Cooper , Artem Mygaiev , Anastasiia Lukianenko References: <54427968-9b13-36e6-0001-27fb49f85635@xen.org> <93936406-574f-7fd0-53bf-3bafaa4b1947@xen.org> <2d18f588-5e76-e3da-e7df-5c754516f8d6@gmail.com> From: Julien Grall Message-ID: Date: Sat, 3 Jul 2021 18:17:45 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <2d18f588-5e76-e3da-e7df-5c754516f8d6@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit On 18/06/2021 13:19, Oleksandr Andrushchenko wrote: > Hi, all! Hi, Sorry for the late reply. > What do we need in order to move on on this? The next steps would be 1) Write a PoC to confirm the approach is feasible 2) Write a design document Unfortunately, I will not have time to work on it any time soon. Is it something you plan to work on? Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sat Jul 03 17:32:53 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 03 Jul 2021 17:32:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149581.276673 (Exim 4.92) (envelope-from ) id 1lzjVY-00066n-5k; Sat, 03 Jul 2021 17:32:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149581.276673; Sat, 03 Jul 2021 17:32:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzjVY-00066g-2j; Sat, 03 Jul 2021 17:32:48 +0000 Received: by outflank-mailman (input) for mailman id 149581; Sat, 03 Jul 2021 17:32:47 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzjVX-00066a-CU for xen-devel@lists.xenproject.org; Sat, 03 Jul 2021 17:32:47 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzjVV-00084K-K9; Sat, 03 Jul 2021 17:32:45 +0000 Received: from [54.239.6.185] (helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lzjVV-0007Gb-Dx; Sat, 03 Jul 2021 17:32:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=3Tza1UvXeufzHbNeU33KlJq7y0V7wQ/yltCLXkHqNMw=; b=zjHKeanavASjFJ6MALVKr2cEwn rXrcD9cn6UiDzTNkCQgBksG8jpDVAtcUV62yxOCOz3HjreoFf80Yo58Tx+9s5Bk9zmLlp65gZULuh hjbgHLcv0h4ZzW2GdFV07KjqtlpE7Bd9fk6anKajX/WYSc+9ECx2DC/1QdBLQmE/GzBE=; Subject: Re: [PATCH RFCv2 02/15] xen/arm: lpae: Use the generic helpers to defined the Xen PT helpers To: Stefano Stabellini Cc: xen-devel@lists.xenproject.org, Wei.Chen@arm.com, Henry.Wang@arm.com, Penny.Zheng@arm.com, Bertrand.Marquis@arm.com, Julien Grall , Volodymyr Babchuk References: <20210425201318.15447-1-julien@xen.org> <20210425201318.15447-3-julien@xen.org> <94e364a7-de40-93ab-6cde-a2f493540439@xen.org> From: Julien Grall Message-ID: <9397d94d-5a22-c026-7c66-400b7397c2fa@xen.org> Date: Sat, 3 Jul 2021 18:32:43 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi Stefano, Sorry for the late answer. On 13/05/2021 23:44, Stefano Stabellini wrote: > On Wed, 12 May 2021, Julien Grall wrote: >> Hi Stefano, >> >> On 12/05/2021 22:30, Stefano Stabellini wrote: >>> On Wed, 12 May 2021, Julien Grall wrote: >>>>>> +#define LPAE_SHIFT LPAE_SHIFT_GS(PAGE_SHIFT) >>>>>> +#define LPAE_ENTRIES LPAE_ENTRIES_GS(PAGE_SHIFT) >>>>>> +#define LPAE_ENTRY_MASK LPAE_ENTRY_MASK_GS(PAGE_SHIFT) >>>>>> >>>>>> +#define LEVEL_SHIFT(lvl) LEVEL_SHIFT_GS(PAGE_SHIFT, lvl) >>>>>> +#define LEVEL_ORDER(lvl) LEVEL_ORDER_GS(PAGE_SHIFT, lvl) >>>>>> +#define LEVEL_SIZE(lvl) LEVEL_SIZE_GS(PAGE_SHIFT, lvl) >>>>>> +#define LEVEL_MASK(lvl) (~(LEVEL_SIZE(lvl) - 1)) >>>>> >>>>> I would avoid adding these 4 macros. It would be OK if they were just >>>>> used within this file but lpae.h is a header: they could end up be used >>>>> anywhere in the xen/ code and they have a very generic name. My >>>>> suggestion would be to skip them and just do: >>>> >>>> Those macros will be used in follow-up patches. They are pretty useful to >>>> avoid introduce static array with the different information for each >>>> level. >>>> >>>> Would prefix them with XEN_ be better? >>> >>> Maybe. The concern I have is that there are multiple page granularities >>> (4kb, 16kb, etc) and multiple page sizes (4kb, 2mb, etc). If I just see >>> LEVEL_ORDER it is not immediately obvious what granularity and what size >>> we are talking about. >> >> I am a bit puzzled with your answer. AFAIU, you are happy with the existing >> macros (THIRD_*, SECOND_*) but not with the new macros. >> >> In reality, there is no difference because THIRD_* doesn't tell you the exact >> size but only "this is a level 3 mapping". >> >> So can you clarify what you are after? IOW is it reworking the current naming >> scheme? > > You are right -- there is no real difference between THIRD_*, SECOND_* > and LEVEL_*. > > The original reason for my comments is that I hadn't read the following > patches, and the definition of LEVEL_* macros is simple, they could be > open coded. It looked like they were only going to be used to make the > definition of THIRD_*, SECOND_* a bit easier. So, at first, I was > wondering if they were needed at all. > > Secondly, I realized that they were going to be used in *.c files by > other patches. That's why they are there. But I started thinking whether > we should find a way to make it a bit clearer that they are for Xen > pages, currently at 4KB granularity. THIRD_*, SECOND_*, etc. are already > generic names which don't convey the granularity or whether they are Xen > pages at all. But LEVEL_* seem even more generic. > > As I mentioned, I don't have any good suggestions for changes to make > here, so unless you can come up with a good idea let's keep it as is. I am thinking to use the following naming (diff on top of this patch): -#define LPAE_SHIFT LPAE_SHIFT_GS(PAGE_SHIFT) -#define LPAE_ENTRIES LPAE_ENTRIES_GS(PAGE_SHIFT) -#define LPAE_ENTRY_MASK LPAE_ENTRY_MASK_GS(PAGE_SHIFT) +#define XEN_PT_SHIFT LPAE_SHIFT_GS(PAGE_SHIFT) +#define XEN_PT_ENTRIES LPAE_ENTRIES_GS(PAGE_SHIFT) +#define XEN_PT_ENTRY_MASK LPAE_ENTRY_MASK_GS(PAGE_SHIFT) -#define LEVEL_SHIFT(lvl) LEVEL_SHIFT_GS(PAGE_SHIFT, lvl) -#define LEVEL_ORDER(lvl) LEVEL_ORDER_GS(PAGE_SHIFT, lvl) -#define LEVEL_SIZE(lvl) LEVEL_SIZE_GS(PAGE_SHIFT, lvl) -#define LEVEL_MASK(lvl) (~(LEVEL_SIZE(lvl) - 1)) +#define XEN_PT_LEVEL_SHIFT(lvl) LEVEL_SHIFT_GS(PAGE_SHIFT, lvl) +#define XEN_PT_LEVEL_ORDER(lvl) LEVEL_ORDER_GS(PAGE_SHIFT, lvl) +#define XEN_PT_LEVEL_SIZE(lvl) LEVEL_SIZE_GS(PAGE_SHIFT, lvl) +#define XEN_PT_LEVEL_MASK(lvl) (~(LEVEL_SIZE(lvl) - 1)) /* Convenience aliases */ -#define THIRD_SHIFT LEVEL_SHIFT(3) -#define THIRD_ORDER LEVEL_ORDER(3) -#define THIRD_SIZE LEVEL_SIZE(3) -#define THIRD_MASK LEVEL_MASK(3) - -#define SECOND_SHIFT LEVEL_SHIFT(2) -#define SECOND_ORDER LEVEL_ORDER(2) -#define SECOND_SIZE LEVEL_SIZE(2) -#define SECOND_MASK LEVEL_MASK(2) - -#define FIRST_SHIFT LEVEL_SHIFT(1) -#define FIRST_ORDER LEVEL_ORDER(1) -#define FIRST_SIZE LEVEL_SIZE(1) -#define FIRST_MASK LEVEL_MASK(1) - -#define ZEROETH_SHIFT LEVEL_SHIFT(0) -#define ZEROETH_ORDER LEVEL_ORDER(0) -#define ZEROETH_SIZE LEVEL_SIZE(0) -#define ZEROETH_MASK LEVEL_MASK(0) +#define THIRD_SHIFT XEN_PT_LEVEL_SHIFT(3) +#define THIRD_ORDER XEN_PT_LEVEL_ORDER(3) +#define THIRD_SIZE XEN_PT_LEVEL_SIZE(3) +#define THIRD_MASK XEN_PT_LEVEL_MASK(3) + +#define SECOND_SHIFT XEN_PT_LEVEL_SHIFT(2) +#define SECOND_ORDER XEN_PT_LEVEL_ORDER(2) +#define SECOND_SIZE XEN_PT_LEVEL_SIZE(2) +#define SECOND_MASK XEN_PT_LEVEL_MASK(2) + +#define FIRST_SHIFT XEN_PT_LEVEL_SHIFT(1) +#define FIRST_ORDER XEN_PT_LEVEL_ORDER(1) +#define FIRST_SIZE XEN_PT_LEVEL_SIZE(1) +#define FIRST_MASK XEN_PT_LEVEL_MASK(1) + +#define ZEROETH_SHIFT XEN_PT_LEVEL_SHIFT(0) +#define ZEROETH_ORDER XEN_PT_LEVEL_ORDER(0) +#define ZEROETH_SIZE XEN_PT_LEVEL_SIZE(0) +#define ZEROETH_MASK XEN_PT_LEVEL_MASK(0) I don't plan to modify the nameing for ZEROETH*, FIRST*, SECOND*, THIRD*. Let me know if you prefer it over the currrent naming. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sat Jul 03 17:57:31 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 03 Jul 2021 17:57:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149588.276690 (Exim 4.92) (envelope-from ) id 1lzjtL-0008Ov-EX; Sat, 03 Jul 2021 17:57:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149588.276690; Sat, 03 Jul 2021 17:57:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzjtL-0008Oo-BF; Sat, 03 Jul 2021 17:57:23 +0000 Received: by outflank-mailman (input) for mailman id 149588; Sat, 03 Jul 2021 17:57:21 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzjtJ-0008Oi-Mk for xen-devel@lists.xenproject.org; Sat, 03 Jul 2021 17:57:21 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzjtE-0008Uk-Nj; Sat, 03 Jul 2021 17:57:16 +0000 Received: from [54.239.6.185] (helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lzjtE-0000vw-Gj; Sat, 03 Jul 2021 17:57:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=FRoQj8C3a/dd4DePsdlLWSExr9beT/irMjZWmijnTms=; b=GlSU7MO5pQkAJ80zHghZQJdXMJ 4NmTGQSIq/Sh5GpysruccZSB6tZyNovC5m0eX6YI+LVrk0f4jJVTaYhmrCXjKsETc0kmZ0WCN9XT+ 44n6XVqRffAcgDAqeLmrG1owUYZk4eR1vBtW+TSoPD4pjMlg++yVrcamKfauzdmh3FwQ=; Subject: Re: [PATCH RFCv2 12/15] xen/arm: add Persistent Map (PMAP) infrastructure To: "Xia, Hongyan" , "xen-devel@lists.xenproject.org" Cc: "Penny.Zheng@arm.com" , "Bertrand.Marquis@arm.com" , "Wei.Chen@arm.com" , "sstabellini@kernel.org" , "wei.liu2@citrix.com" , "andrew.cooper3@citrix.com" , "roger.pau@citrix.com" , "Volodymyr_Babchuk@epam.com" , "hongyax@amazon.com" , "Henry.Wang@arm.com" , "wl@xen.org" , "Grall, Julien" , "jbeulich@suse.com" References: <20210425201318.15447-1-julien@xen.org> <20210425201318.15447-13-julien@xen.org> From: Julien Grall Message-ID: Date: Sat, 3 Jul 2021 18:57:13 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi Hongyan, On 26/04/2021 10:41, Xia, Hongyan wrote: > On Sun, 2021-04-25 at 21:13 +0100, Julien Grall wrote: >> From: Wei Liu >> >> The basic idea is like Persistent Kernel Map (PKMAP) in Linux. We >> pre-populate all the relevant page tables before the system is fully >> set up. >> >> We will need it on Arm in order to rework the arm64 version of >> xenheap_setup_mappings() as we may need to use pages allocated from >> the boot allocator before they are effectively mapped. >> >> This infrastructure is not lock-protected therefore can only be used >> before smpboot. After smpboot, map_domain_page() has to be used. >> >> This is based on the x86 version [1] that was originally implemented >> by Wei Liu. >> >> Take the opportunity to switch the parameter attr from unsigned to >> unsigned int. >> >> [1] < >> e92da4ad6015b6089737fcccba3ec1d6424649a5.1588278317.git.hongyxia@amazon.com >>> >> >> Signed-off-by: Wei Liu >> Signed-off-by: Hongyan Xia >> [julien: Adapted for Arm] >> Signed-off-by: Julien Grall > > [...] > >> diff --git a/xen/arch/arm/pmap.c b/xen/arch/arm/pmap.c >> new file mode 100644 >> index 000000000000..702b1bde982d >> --- /dev/null >> +++ b/xen/arch/arm/pmap.c >> @@ -0,0 +1,101 @@ >> +#include >> +#include >> + >> +#include >> +#include >> +#include >> + >> +/* >> + * To be able to use FIXMAP_PMAP_BEGIN. >> + * XXX: move fixmap definition in a separate header >> + */ >> +#include >> + >> +/* >> + * Simple mapping infrastructure to map / unmap pages in fixed map. >> + * This is used to set up the page table for mapcache, which is used >> + * by map domain page infrastructure. >> + * >> + * This structure is not protected by any locks, so it must not be >> used after >> + * smp bring-up. >> + */ >> + >> +/* Bitmap to track which slot is used */ >> +static unsigned long __initdata inuse; >> + >> +/* XXX: Find an header to declare it */ >> +extern lpae_t xen_fixmap[LPAE_ENTRIES]; >> + >> +void *__init pmap_map(mfn_t mfn) >> +{ >> + unsigned long flags; >> + unsigned int idx; >> + vaddr_t linear; >> + unsigned int slot; >> + lpae_t *entry, pte; >> + >> + BUILD_BUG_ON(sizeof(inuse) * BITS_PER_LONG < NUM_FIX_PMAP); > > This seems wrong to me. It should multiply with something like > BITS_PER_BYTE. Good spot! I have updated my tree. > > I noticed this line was already present before the Arm version so > probably my fault :(, which also needs to be fixed. This should be taken care as the next version will create the pmap in common code :). > >> + >> + ASSERT(system_state < SYS_STATE_smp_boot); >> + >> + local_irq_save(flags); >> + >> + idx = find_first_zero_bit(&inuse, NUM_FIX_PMAP); >> + if ( idx == NUM_FIX_PMAP ) >> + panic("Out of PMAP slots\n"); >> + >> + __set_bit(idx, &inuse); >> + >> + slot = idx + FIXMAP_PMAP_BEGIN; >> + ASSERT(slot >= FIXMAP_PMAP_BEGIN && slot <= FIXMAP_PMAP_END); >> + > > From here... > >> + linear = FIXMAP_ADDR(slot); >> + /* >> + * We cannot use set_fixmap() here. We use PMAP when there is no >> direct map, >> + * so map_pages_to_xen() called by set_fixmap() needs to map >> pages on >> + * demand, which then calls pmap() again, resulting in a loop. >> Modify the >> + * PTEs directly instead. The same is true for pmap_unmap(). >> + */ >> + entry = &xen_fixmap[third_table_offset(linear)]; >> + >> + ASSERT(!lpae_is_valid(*entry)); >> + >> + pte = mfn_to_xen_entry(mfn, PAGE_HYPERVISOR_RW); >> + pte.pt.table = 1; >> + write_pte(entry, pte); >> + > > ...to here, I wonder if we can move this chunk into arch (like void > *arch_write_pmap_slot(slot)). Such an arch function hides how fixmap is > handled and how page table entry is written behind arch, and the rest > can just be common. This is similar to what I had in mind. Let me give a try for the next version. > >> + local_irq_restore(flags); >> + >> + return (void *)linear; >> +} >> + >> +void __init pmap_unmap(const void *p) >> +{ >> + unsigned long flags; >> + unsigned int idx; >> + lpae_t *entry; >> + lpae_t pte = { 0 }; >> + unsigned int slot = third_table_offset((vaddr_t)p); >> + >> + ASSERT(system_state < SYS_STATE_smp_boot); >> + ASSERT(slot >= FIXMAP_PMAP_BEGIN && slot <= FIXMAP_PMAP_END); >> + >> + idx = slot - FIXMAP_PMAP_BEGIN; >> + local_irq_save(flags); >> + >> + __clear_bit(idx, &inuse); >> + entry = &xen_fixmap[third_table_offset((vaddr_t)p)]; >> + write_pte(entry, pte); >> + flush_xen_tlb_range_va_local((vaddr_t)p, PAGE_SIZE); > > and the same for the above, something like arch_clear_pmap(void *) and > the rest into common. > > From a quick glance, I don't think x86 and Arm share any useful TLB > flush helpers? So the TLB flush probably should be behind arch as well. We could potential define flush_tlb_one_local() on Arm. But, I am not sure this is worth it because the page table manipulation is mainly happening in arch code so far. Although, this might change in the future. > >> + >> + local_irq_restore(flags); >> +} >> + >> +/* >> + * Local variables: >> + * mode: C >> + * c-file-style: "BSD" >> + * c-basic-offset: 4 >> + * indent-tabs-mode: nil >> + * End: >> + */ > > [...] > >> diff --git a/xen/include/asm-arm/pmap.h b/xen/include/asm-arm/pmap.h >> new file mode 100644 >> index 000000000000..8e1dce93f8e4 >> --- /dev/null >> +++ b/xen/include/asm-arm/pmap.h >> @@ -0,0 +1,10 @@ >> +#ifndef __ASM_PMAP_H__ >> +#define __ARM_PMAP_H__ > > This line doesn't seem to match the #ifndef, but if the functions are > moved to common, this header can be moved to common as well. Stefano pointed out the same. I have fixed it in my tree but I will likely rename the guard as the header will be moved in common. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sat Jul 03 18:01:17 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 03 Jul 2021 18:01:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149600.276723 (Exim 4.92) (envelope-from ) id 1lzjx6-0001j6-Be; Sat, 03 Jul 2021 18:01:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149600.276723; Sat, 03 Jul 2021 18:01:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzjx6-0001iz-8l; Sat, 03 Jul 2021 18:01:16 +0000 Received: by outflank-mailman (input) for mailman id 149600; Sat, 03 Jul 2021 18:01:15 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzjx5-0001ip-Ac; Sat, 03 Jul 2021 18:01:15 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzjx5-0000Ff-3a; Sat, 03 Jul 2021 18:01:15 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzjx4-0001mK-Nb; Sat, 03 Jul 2021 18:01:14 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lzjx4-0001TB-N8; Sat, 03 Jul 2021 18:01:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=+E1MTzXRSG5qBKjaS0paHjhAHKaobaobHcoFLIXDobU=; b=WP/1WFx100EdS6xdk2hmzZuql1 LBSxyXVaimUrs3a5d6enijsX2q1QZo4KorDBhn4ZyXpZyLdU+1ZsHyo+MBDiIItAQED9OjyHcsPEx Udj1/5UPt2YBExOHaNWUx8zffDL74vV72lvbdWfbwkYlhiJyeTJQKzblP9mim1iPrPZY=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 163239: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=74d044d51b19bb697eac5c3deafa140f6afafec8 X-Osstest-Versions-That: xen=f95b7b37cfc6d4613721df9357090d14712013c0 From: osstest service owner Date: Sat, 03 Jul 2021 18:01:14 +0000 flight 163239 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/163239/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail REGR. vs. 163219 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 163219 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 163219 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 163219 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 163219 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 163219 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 163219 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 163219 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 163219 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 163219 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 163219 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 163219 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 74d044d51b19bb697eac5c3deafa140f6afafec8 baseline version: xen f95b7b37cfc6d4613721df9357090d14712013c0 Last test of basis 163219 2021-07-02 01:52:38 Z 1 days Failing since 163231 2021-07-02 18:06:46 Z 0 days 2 attempts Testing same since 163239 2021-07-03 06:48:53 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Anthony PERARD Ian Jackson Olaf Hering jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git f95b7b37cf..74d044d51b 74d044d51b19bb697eac5c3deafa140f6afafec8 -> master From xen-devel-bounces@lists.xenproject.org Sat Jul 03 18:06:47 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 03 Jul 2021 18:06:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149611.276738 (Exim 4.92) (envelope-from ) id 1lzk2O-0002Ph-1s; Sat, 03 Jul 2021 18:06:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149611.276738; Sat, 03 Jul 2021 18:06:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzk2N-0002Pa-Ty; Sat, 03 Jul 2021 18:06:43 +0000 Received: by outflank-mailman (input) for mailman id 149611; Sat, 03 Jul 2021 18:06:43 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzk2N-0002PQ-7I; Sat, 03 Jul 2021 18:06:43 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzk2N-0000LW-1P; Sat, 03 Jul 2021 18:06:43 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzk2M-0001wl-Qw; Sat, 03 Jul 2021 18:06:42 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lzk2M-0006PI-QM; Sat, 03 Jul 2021 18:06:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=xfPByzuy9ya9E1B0xTyj3b3FsRny4iojOhnChI8sIck=; b=YFDVt0v/7y3VOjMfAQytvZ1rpq bqX6k4tTz8P3nyFbNkBAno5g4UipqWEGULgWpOjZpc0l4IrrD3zHT7kvVrK00tiE1X6F+TkVIPy+C ujWnVAsT3GAUTTF6DzQGPevhR5uo0944EUhJjq8U9zJncE7vaKtUE2luGswCHlPdwiEk=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 163259: regressions - FAIL X-Osstest-Failures: ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:debian-hvm-install:fail:regression ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:debian-hvm-install:fail:regression X-Osstest-Versions-This: ovmf=fea7901dba72eeac526f3ef12a4ad4c539622373 X-Osstest-Versions-That: ovmf=c410ad4da4b7785170d3d42a3ba190c2caac6feb From: osstest service owner Date: Sat, 03 Jul 2021 18:06:42 +0000 flight 163259 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/163259/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 162359 test-amd64-amd64-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 162359 version targeted for testing: ovmf fea7901dba72eeac526f3ef12a4ad4c539622373 baseline version: ovmf c410ad4da4b7785170d3d42a3ba190c2caac6feb Last test of basis 162359 2021-06-04 03:40:08 Z 29 days Failing since 162368 2021-06-04 15:42:59 Z 29 days 79 attempts Testing same since 163216 2021-07-01 22:42:29 Z 1 days 9 attempts ------------------------------------------------------------ People who touched revisions under test: Abner Chang Agrawal, Sachin Alexandru Elisei Anthony PERARD Ard Biesheuvel Daniel Schaefer Daoxiang Li Dov Murik DunTan gaoliming Guo Dong Hao A Wu Jian J Wang Kaaira Gupta Ken Lautner Kenneth Lautner Kun Qin Laszlo Ersek Leif Lindholm Liming Gao Loo Tung Lun Loo, Tung Lun Manickavasakam Karpagavinayagam Maurice Ma Ni, Ray Patrick Rudolph Pierre Gondois Ray Ni Rebecca Cran Rebecca Cran Sachin Agrawal Sami Mujawar Scottie Kuo Sean Brogan Sean Brogan Sumana Venur Sunil V L xueshengfeng Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-i386-xl-qemuu-ovmf-amd64 fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 3224 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Jul 03 21:53:34 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 03 Jul 2021 21:53:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149618.276755 (Exim 4.92) (envelope-from ) id 1lznZf-0005Dd-H5; Sat, 03 Jul 2021 21:53:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149618.276755; Sat, 03 Jul 2021 21:53:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lznZf-0005DW-Dl; Sat, 03 Jul 2021 21:53:19 +0000 Received: by outflank-mailman (input) for mailman id 149618; Sat, 03 Jul 2021 21:53:17 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lznZd-0005DJ-To; Sat, 03 Jul 2021 21:53:17 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lznZd-00041u-L3; Sat, 03 Jul 2021 21:53:17 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lznZd-0003Qc-9M; Sat, 03 Jul 2021 21:53:17 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lznZd-0001E2-8s; Sat, 03 Jul 2021 21:53:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=kpWidmv6G5muS/aDPN4JUP0+KDlVisU0eWHEbtZqsIE=; b=CbEGjlE0XZ99okxZ6R/TnWXbnG dCZBxdpu1+kiMrFbXm4mKdR2ykZ4q5yASKEEgkJP6Ow+qjROa3bGGPVO8jJiIrMOcaNcnxWKxYWBa PfeQa5hKskmruva1GqZaKUiVCbhe3VoZL1BhAyC52/0nPeQz7CKXdjZbbAZBhSivyoTQ=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 163247: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-i386-xl-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-coresched-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-examine:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-pvshim:xen-install:fail:regression linux-linus:test-amd64-i386-xl-raw:xen-install:fail:regression linux-linus:test-amd64-i386-xl-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-i386:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-xsm:xen-install:fail:regression linux-linus:test-arm64-arm64-xl-seattle:debian-install:fail:regression linux-linus:test-amd64-amd64-libvirt-vhd:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-credit1:debian-install:fail:regression linux-linus:test-arm64-arm64-xl-credit2:debian-install:fail:regression linux-linus:test-arm64-arm64-xl-thunderx:debian-install:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-arm64-arm64-xl-xsm:debian-install:fail:regression linux-linus:test-amd64-amd64-amd64-pvgrub:guest-stop:fail:regression linux-linus:test-arm64-arm64-xl:debian-install:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:debian-install:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-amd64-amd64-i386-pvgrub:guest-stop:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qcow2:guest-start:fail:regression linux-linus:test-amd64-amd64-xl:guest-start/debian.repeat:fail:regression linux-linus:test-armhf-armhf-xl-cubietruck:debian-install:fail:regression linux-linus:test-amd64-amd64-qemuu-freebsd12-amd64:guest-start/freebsd.repeat:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:debian-di-install:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:debian-install:fail:regression linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=4b820e167bf6f410ace479d8df5b15a574000e75 X-Osstest-Versions-That: linux=deacdb3e3979979016fcd0ffd518c320a62ad166 From: osstest service owner Date: Sat, 03 Jul 2021 21:53:17 +0000 flight 163247 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/163247/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-coresched-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-examine 6 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-pvshim 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-raw 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-i386 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-xsm 7 xen-install fail REGR. vs. 152332 test-arm64-arm64-xl-seattle 12 debian-install fail REGR. vs. 152332 test-amd64-amd64-libvirt-vhd 13 guest-start fail REGR. vs. 152332 test-arm64-arm64-xl-credit1 12 debian-install fail REGR. vs. 152332 test-arm64-arm64-xl-credit2 12 debian-install fail REGR. vs. 152332 test-arm64-arm64-xl-thunderx 12 debian-install fail REGR. vs. 152332 test-armhf-armhf-examine 8 reboot fail REGR. vs. 152332 test-arm64-arm64-xl-xsm 12 debian-install fail REGR. vs. 152332 test-amd64-amd64-amd64-pvgrub 20 guest-stop fail REGR. vs. 152332 test-arm64-arm64-xl 12 debian-install fail REGR. vs. 152332 test-arm64-arm64-libvirt-xsm 12 debian-install fail REGR. vs. 152332 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 152332 test-amd64-amd64-i386-pvgrub 20 guest-stop fail REGR. vs. 152332 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 152332 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 152332 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 152332 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 152332 test-amd64-amd64-xl-qcow2 13 guest-start fail REGR. vs. 152332 test-amd64-amd64-xl 22 guest-start/debian.repeat fail REGR. vs. 152332 test-armhf-armhf-xl-cubietruck 12 debian-install fail REGR. vs. 152332 test-amd64-amd64-qemuu-freebsd12-amd64 21 guest-start/freebsd.repeat fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 152332 test-armhf-armhf-xl-vhd 12 debian-di-install fail REGR. vs. 152332 test-armhf-armhf-xl-multivcpu 12 debian-install fail REGR. vs. 152332 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 152332 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 152332 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152332 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152332 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass version targeted for testing: linux 4b820e167bf6f410ace479d8df5b15a574000e75 baseline version: linux deacdb3e3979979016fcd0ffd518c320a62ad166 Last test of basis 152332 2020-07-31 19:41:23 Z 337 days Failing since 152366 2020-08-01 20:49:34 Z 336 days 572 attempts Testing same since 163247 2021-07-03 08:35:18 Z 0 days 1 attempts ------------------------------------------------------------ 6531 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl fail test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-i386-xl fail test-amd64-coresched-i386-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm fail test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm fail test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck fail test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine fail test-amd64-i386-examine fail test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel fail test-amd64-i386-qemuu-rhel6hvm-intel fail test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-amd64-pvgrub fail test-amd64-amd64-i386-pvgrub fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 fail test-armhf-armhf-libvirt-raw fail test-amd64-i386-xl-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow fail test-arm64-arm64-xl-thunderx fail test-amd64-amd64-libvirt-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1883242 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Jul 03 22:30:26 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 03 Jul 2021 22:30:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149626.276768 (Exim 4.92) (envelope-from ) id 1lzo9U-0000j3-II; Sat, 03 Jul 2021 22:30:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149626.276768; Sat, 03 Jul 2021 22:30:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzo9U-0000iw-FR; Sat, 03 Jul 2021 22:30:20 +0000 Received: by outflank-mailman (input) for mailman id 149626; Sat, 03 Jul 2021 22:30:18 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzo9S-0000im-S5; Sat, 03 Jul 2021 22:30:18 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzo9S-0004cq-Kq; Sat, 03 Jul 2021 22:30:18 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzo9S-0004XG-Bq; Sat, 03 Jul 2021 22:30:18 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lzo9S-0004HW-BL; Sat, 03 Jul 2021 22:30:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=DxHshweDV9gVaRgSXRGNByA/bCajxFexYwqS2ILhYvk=; b=Hk1x9zhN9bGWQDgaTCBaa2zOL5 KK2I/643QiC8Y/YQZ/3A2x9gBKkKyvQ30dxjWY05iouiIoiJTcO4aXq1Wpq6hTfnR51rmuywoGBeq TcjgjAZ/1s5+q2PeHV85eO3lrhFsr85G0GXUgr4DAYL6GK2XxW2WHuEFt/IPlP1TfDRI=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 163289: regressions - FAIL X-Osstest-Failures: ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:debian-hvm-install:fail:regression ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:debian-hvm-install:fail:regression X-Osstest-Versions-This: ovmf=fea7901dba72eeac526f3ef12a4ad4c539622373 X-Osstest-Versions-That: ovmf=c410ad4da4b7785170d3d42a3ba190c2caac6feb From: osstest service owner Date: Sat, 03 Jul 2021 22:30:18 +0000 flight 163289 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/163289/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 162359 test-amd64-amd64-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 162359 version targeted for testing: ovmf fea7901dba72eeac526f3ef12a4ad4c539622373 baseline version: ovmf c410ad4da4b7785170d3d42a3ba190c2caac6feb Last test of basis 162359 2021-06-04 03:40:08 Z 29 days Failing since 162368 2021-06-04 15:42:59 Z 29 days 80 attempts Testing same since 163216 2021-07-01 22:42:29 Z 1 days 10 attempts ------------------------------------------------------------ People who touched revisions under test: Abner Chang Agrawal, Sachin Alexandru Elisei Anthony PERARD Ard Biesheuvel Daniel Schaefer Daoxiang Li Dov Murik DunTan gaoliming Guo Dong Hao A Wu Jian J Wang Kaaira Gupta Ken Lautner Kenneth Lautner Kun Qin Laszlo Ersek Leif Lindholm Liming Gao Loo Tung Lun Loo, Tung Lun Manickavasakam Karpagavinayagam Maurice Ma Ni, Ray Patrick Rudolph Pierre Gondois Ray Ni Rebecca Cran Rebecca Cran Sachin Agrawal Sami Mujawar Scottie Kuo Sean Brogan Sean Brogan Sumana Venur Sunil V L xueshengfeng Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-i386-xl-qemuu-ovmf-amd64 fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 3224 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Jul 04 00:58:21 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 04 Jul 2021 00:58:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149633.276782 (Exim 4.92) (envelope-from ) id 1lzqSW-0005Hy-Jm; Sun, 04 Jul 2021 00:58:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149633.276782; Sun, 04 Jul 2021 00:58:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzqSW-0005Hr-Gm; Sun, 04 Jul 2021 00:58:08 +0000 Received: by outflank-mailman (input) for mailman id 149633; Sun, 04 Jul 2021 00:58:07 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzqSV-0005Hh-DZ; Sun, 04 Jul 2021 00:58:07 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzqSV-0007bF-7N; Sun, 04 Jul 2021 00:58:07 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzqSU-0002uT-RX; Sun, 04 Jul 2021 00:58:06 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lzqSU-0000MF-R4; Sun, 04 Jul 2021 00:58:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=dr4DmJAIpCZEcSxOHf+lHSnW6VpHuG5UrtrdXd5oV/s=; b=vThNbRnUUdGUZ5sPLBSl7RBlI4 kYHyLl1HzQ8Awo0lwgzcLy7RzqZwfwkclqZl2dVBDUEVs/9AXLQlf41iKTLas2dF9gAzmdGcG+Avs ybaxDJLgxg6rB2Qr2ToqEVc3T/fSAND9VV0U9BQkebyjCTG+sKi3DkrQNF9tCU1fUEg8=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 163276: regressions - FAIL X-Osstest-Failures: qemu-mainline:test-amd64-amd64-qemuu-nested-amd:xen-boot/l1:fail:regression qemu-mainline:test-amd64-amd64-qemuu-nested-intel:xen-boot/l1:fail:regression qemu-mainline:test-armhf-armhf-xl-rtds:guest-start:fail:heisenbug qemu-mainline:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=9c2647f75004c4f7d64c9c0ec55f8c6f0739a8b1 X-Osstest-Versions-That: qemuu=1d806cef0e38b5db8347a8e12f214d543204a314 From: osstest service owner Date: Sun, 04 Jul 2021 00:58:06 +0000 flight 163276 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/163276/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-qemuu-nested-amd 16 xen-boot/l1 fail REGR. vs. 152631 test-amd64-amd64-qemuu-nested-intel 16 xen-boot/l1 fail REGR. vs. 152631 Tests which are failing intermittently (not blocking): test-armhf-armhf-xl-rtds 14 guest-start fail pass in 163235 Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail in 163235 like 152631 test-armhf-armhf-xl-rtds 15 migrate-support-check fail in 163235 never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail in 163235 never pass test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152631 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 152631 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152631 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152631 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 152631 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152631 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass version targeted for testing: qemuu 9c2647f75004c4f7d64c9c0ec55f8c6f0739a8b1 baseline version: qemuu 1d806cef0e38b5db8347a8e12f214d543204a314 Last test of basis 152631 2020-08-20 09:07:46 Z 317 days Failing since 152659 2020-08-21 14:07:39 Z 316 days 581 attempts Testing same since 163228 2021-07-02 17:08:27 Z 1 days 3 attempts ------------------------------------------------------------ 554 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 182071 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Jul 04 02:47:13 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 04 Jul 2021 02:47:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149640.276797 (Exim 4.92) (envelope-from ) id 1lzs9s-0007wy-9H; Sun, 04 Jul 2021 02:47:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149640.276797; Sun, 04 Jul 2021 02:47:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzs9s-0007wj-2n; Sun, 04 Jul 2021 02:47:00 +0000 Received: by outflank-mailman (input) for mailman id 149640; Sun, 04 Jul 2021 02:46:59 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzs9r-0007wa-NG; Sun, 04 Jul 2021 02:46:59 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzs9r-0001wS-GE; Sun, 04 Jul 2021 02:46:59 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzs9q-00062b-Mb; Sun, 04 Jul 2021 02:46:58 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lzs9q-0001e3-M7; Sun, 04 Jul 2021 02:46:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=tzQHLeM8RxlSuQ50k4+KUxzQGvcEKXSclTzHf1i8xX4=; b=Aq5tZ4JpNtSk22QV33APk6GCwJ PpAZBGzyD1JAd0WX/pKipi9hzHlwY0fAH32P5+Y+C3tHGOkCZ2SSwwZGi0iYxLnCRAJz1tdxu13O4 7qxfSLkLyS5ZRkZHFaHJa3zGRz9jWc+yAS5ej9BCdmYt6sUlRkzfV0JhjToSFXUt+hE8=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 163291: regressions - FAIL X-Osstest-Failures: ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:debian-hvm-install:fail:regression ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:debian-hvm-install:fail:regression X-Osstest-Versions-This: ovmf=fea7901dba72eeac526f3ef12a4ad4c539622373 X-Osstest-Versions-That: ovmf=c410ad4da4b7785170d3d42a3ba190c2caac6feb From: osstest service owner Date: Sun, 04 Jul 2021 02:46:58 +0000 flight 163291 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/163291/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 162359 test-amd64-amd64-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 162359 version targeted for testing: ovmf fea7901dba72eeac526f3ef12a4ad4c539622373 baseline version: ovmf c410ad4da4b7785170d3d42a3ba190c2caac6feb Last test of basis 162359 2021-06-04 03:40:08 Z 29 days Failing since 162368 2021-06-04 15:42:59 Z 29 days 81 attempts Testing same since 163216 2021-07-01 22:42:29 Z 2 days 11 attempts ------------------------------------------------------------ People who touched revisions under test: Abner Chang Agrawal, Sachin Alexandru Elisei Anthony PERARD Ard Biesheuvel Daniel Schaefer Daoxiang Li Dov Murik DunTan gaoliming Guo Dong Hao A Wu Jian J Wang Kaaira Gupta Ken Lautner Kenneth Lautner Kun Qin Laszlo Ersek Leif Lindholm Liming Gao Loo Tung Lun Loo, Tung Lun Manickavasakam Karpagavinayagam Maurice Ma Ni, Ray Patrick Rudolph Pierre Gondois Ray Ni Rebecca Cran Rebecca Cran Sachin Agrawal Sami Mujawar Scottie Kuo Sean Brogan Sean Brogan Sumana Venur Sunil V L xueshengfeng Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-i386-xl-qemuu-ovmf-amd64 fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 3224 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Jul 04 05:47:06 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 04 Jul 2021 05:47:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149647.276811 (Exim 4.92) (envelope-from ) id 1lzuxt-0007Bi-LG; Sun, 04 Jul 2021 05:46:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149647.276811; Sun, 04 Jul 2021 05:46:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzuxt-0007BG-Cz; Sun, 04 Jul 2021 05:46:49 +0000 Received: by outflank-mailman (input) for mailman id 149647; Sun, 04 Jul 2021 05:46:47 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzuxr-0007B6-Pg; Sun, 04 Jul 2021 05:46:47 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzuxr-0005Ks-HL; Sun, 04 Jul 2021 05:46:47 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzuxq-0005S5-CN; Sun, 04 Jul 2021 05:46:46 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lzuxq-00009a-9v; Sun, 04 Jul 2021 05:46:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=p71YwfGylOGfGFyzTAPeA9Lwilpxz59pOib2pROUSkU=; b=e+zn5kQIkLyHEW7bgptATjPVcZ ZIz+C4ECQvz3+zJ1P86bo+eJsgeyIAfdPQJnPA+IujNuSSir5C5wG6hdDGe4pT5itsOANB9fsYUA+ o6vjV5eChQ8WpRo9O1Je6U2VdZWySZ5h4gZn/se0iWU8QTmlJXp77tDwpTqyPAeHMWhc=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 163290: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-i386-xl-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-coresched-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-xl-qemut-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-examine:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-pvshim:xen-install:fail:regression linux-linus:test-amd64-i386-xl-raw:xen-install:fail:regression linux-linus:test-amd64-i386-xl-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-i386:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-xsm:xen-install:fail:regression linux-linus:test-arm64-arm64-xl-seattle:debian-install:fail:regression linux-linus:test-amd64-amd64-libvirt-vhd:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-credit2:debian-install:fail:regression linux-linus:test-arm64-arm64-xl-credit1:debian-install:fail:regression linux-linus:test-arm64-arm64-xl-thunderx:debian-install:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-arm64-arm64-xl-xsm:debian-install:fail:regression linux-linus:test-amd64-amd64-amd64-pvgrub:guest-stop:fail:regression linux-linus:test-arm64-arm64-xl:debian-install:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:debian-install:fail:regression linux-linus:test-amd64-amd64-i386-pvgrub:guest-stop:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qcow2:guest-start:fail:regression linux-linus:test-armhf-armhf-xl-cubietruck:debian-install:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:debian-di-install:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:debian-install:fail:regression linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=303392fd5c160822bf778270b28ec5ea50cab2b4 X-Osstest-Versions-That: linux=deacdb3e3979979016fcd0ffd518c320a62ad166 From: osstest service owner Date: Sun, 04 Jul 2021 05:46:46 +0000 flight 163290 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/163290/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-coresched-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-xl-qemut-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-examine 6 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-pvshim 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-raw 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-i386 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-xsm 7 xen-install fail REGR. vs. 152332 test-arm64-arm64-xl-seattle 12 debian-install fail REGR. vs. 152332 test-amd64-amd64-libvirt-vhd 13 guest-start fail REGR. vs. 152332 test-arm64-arm64-xl-credit2 12 debian-install fail REGR. vs. 152332 test-arm64-arm64-xl-credit1 12 debian-install fail REGR. vs. 152332 test-arm64-arm64-xl-thunderx 12 debian-install fail REGR. vs. 152332 test-armhf-armhf-examine 8 reboot fail REGR. vs. 152332 test-arm64-arm64-xl-xsm 12 debian-install fail REGR. vs. 152332 test-amd64-amd64-amd64-pvgrub 20 guest-stop fail REGR. vs. 152332 test-arm64-arm64-xl 12 debian-install fail REGR. vs. 152332 test-arm64-arm64-libvirt-xsm 12 debian-install fail REGR. vs. 152332 test-amd64-amd64-i386-pvgrub 20 guest-stop fail REGR. vs. 152332 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 152332 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 152332 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 152332 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 152332 test-amd64-amd64-xl-qcow2 13 guest-start fail REGR. vs. 152332 test-armhf-armhf-xl-cubietruck 12 debian-install fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 152332 test-armhf-armhf-xl-vhd 12 debian-di-install fail REGR. vs. 152332 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 152332 test-armhf-armhf-xl-multivcpu 12 debian-install fail REGR. vs. 152332 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 152332 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 152332 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152332 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152332 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass version targeted for testing: linux 303392fd5c160822bf778270b28ec5ea50cab2b4 baseline version: linux deacdb3e3979979016fcd0ffd518c320a62ad166 Last test of basis 152332 2020-07-31 19:41:23 Z 337 days Failing since 152366 2020-08-01 20:49:34 Z 336 days 573 attempts Testing same since 163290 2021-07-03 22:11:05 Z 0 days 1 attempts ------------------------------------------------------------ 6537 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-i386-xl fail test-amd64-coresched-i386-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm fail test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm fail test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck fail test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine fail test-amd64-i386-examine fail test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel fail test-amd64-i386-qemuu-rhel6hvm-intel fail test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-amd64-pvgrub fail test-amd64-amd64-i386-pvgrub fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 fail test-armhf-armhf-libvirt-raw fail test-amd64-i386-xl-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow fail test-arm64-arm64-xl-thunderx fail test-amd64-amd64-libvirt-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1888347 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Jul 04 08:02:20 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 04 Jul 2021 08:02:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149656.276824 (Exim 4.92) (envelope-from ) id 1lzx4o-0003D3-HM; Sun, 04 Jul 2021 08:02:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149656.276824; Sun, 04 Jul 2021 08:02:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzx4o-0003Cw-EI; Sun, 04 Jul 2021 08:02:06 +0000 Received: by outflank-mailman (input) for mailman id 149656; Sun, 04 Jul 2021 08:02:04 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzx4m-0003Cm-As; Sun, 04 Jul 2021 08:02:04 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzx4m-00086L-5D; Sun, 04 Jul 2021 08:02:04 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzx4l-0003nu-TU; Sun, 04 Jul 2021 08:02:03 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lzx4l-00028o-Sg; Sun, 04 Jul 2021 08:02:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=AyK5t5UnC6eQpnf4fejdlq1si7G7IhWMNiwN9ooEdIg=; b=QG+XmoAW7pJaHIhI0iUcdN0xvo JcHbIu4xU/GuQ9Rn/nGVbZWOaIO9ohlV+WwZl/2jPqj/5v6HpKgcmiaAt/4xGpZogG6O6d2+ReGd9 Rgfwx6RzkGn7mFnfBp5ocoqJRmDw4IYFxILqtEMJpMXAMUpJu4NExUaQbkFDQC+Sj6Dc=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 163295: regressions - FAIL X-Osstest-Failures: libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=45f94690d2a89fc03c1a4eaea5c1ee398447a4b8 X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Sun, 04 Jul 2021 08:02:03 +0000 flight 163295 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/163295/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a version targeted for testing: libvirt 45f94690d2a89fc03c1a4eaea5c1ee398447a4b8 baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 359 days Failing since 151818 2020-07-11 04:18:52 Z 358 days 350 attempts Testing same since 163236 2021-07-03 04:20:01 Z 1 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Andika Triwidada Andrea Bolognani Balázs Meskó Barrett Schonefeld Bastian Germann Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Bjoern Walk Boris Fiuczynski Brian Turek Bruno Haible Chris Mayo Christian Ehrhardt Christian Schoenebeck Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Dmytro Linkin Eiichi Tsukata Eric Farman Erik Skultety Fabian Affolter Fabian Freyer Fabiano Fidêncio Fangge Jin Farhan Ali Fedora Weblate Translation gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Hela Basa Helmut Grohne Ian Wienand Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen Jean-Baptiste Holcroft Jianan Gao Jim Fehlig Jin Yan Jiri Denemark John Ferlan Jonathan Watt Jonathon Jongsma Julio Faracco Ján Tomko Kashyap Chamarthy Kevin Locke Kristina Hanicova Laine Stump Laszlo Ersek Lee Yarwood Liao Pingfang Lin Ma Lin Ma Lin Ma Liu Yiding Luke Yue Luyao Zhong Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Markus Schade Martin Kletzander Masayoshi Mizuma Matt Coleman Matt Coleman Mauro Matteo Cascella Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Muha Aliss Nathan Neal Gompa Nick Shyrokovskiy Nickys Music Group Nico Pache Nikolay Shirokovskiy Olaf Hering Olesya Gerasimenko Orion Poplawski Pany Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Ricky Tigg Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Shambarger Sebastian Mitterle SeongHyun Jo Shalini Chellathurai Saroja Shaojun Yang Shi Lei simmon Simon Chopin Simon Gaiser Stefan Bader Stefan Berger Stefan Berger Stefan Hajnoczi Szymon Scholz Thomas Huth Tim Wiederhake Tomáš Golembiovský Tomáš Janoušek Tuguoyi Ville Skyttä Wang Xin WangJian Weblate Wei Liu Wei Liu William Douglas Yalei Li <274268859@qq.com> Yalei Li Yang Hang Yanqiu Zhang Yaroslav Kargin Yi Li Yi Wang Yuri Chornoivan Zbigniew Jędrzejewski-Szmek Zheng Chuan zhenwei pi Zhenyu Zheng jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 63952 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Jul 04 09:34:41 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 04 Jul 2021 09:34:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149663.276838 (Exim 4.92) (envelope-from ) id 1lzyWC-0002wh-S1; Sun, 04 Jul 2021 09:34:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149663.276838; Sun, 04 Jul 2021 09:34:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzyWC-0002wa-P1; Sun, 04 Jul 2021 09:34:28 +0000 Received: by outflank-mailman (input) for mailman id 149663; Sun, 04 Jul 2021 09:34:27 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzyWB-0002wO-0K; Sun, 04 Jul 2021 09:34:27 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzyWA-00017z-R6; Sun, 04 Jul 2021 09:34:26 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzyWA-0001tC-ED; Sun, 04 Jul 2021 09:34:26 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lzyWA-0001fA-DU; Sun, 04 Jul 2021 09:34:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=ZGL/v4vv8FQWnqCuoisJ6crTio/E6QL/PClZ5VvCcWc=; b=wWlpDdj4tm1eTacJ80f3zu0asl o6dsWwWIC1J7TdE+7P5u3Ki4D64ZL9zlbfV0bm2f04ctn430c516dCzHus+LVJ5VCoIkQbPPPNxLp riRKZPNIHO2i97muHqtDNAeYoHelFQqrqndFqy2Pb/bW5S9gu+B1XSYu2Y7xMBNF+HIU=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 163292: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=9c2647f75004c4f7d64c9c0ec55f8c6f0739a8b1 X-Osstest-Versions-That: qemuu=1d806cef0e38b5db8347a8e12f214d543204a314 From: osstest service owner Date: Sun, 04 Jul 2021 09:34:26 +0000 flight 163292 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/163292/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152631 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152631 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 152631 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152631 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152631 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 152631 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152631 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass version targeted for testing: qemuu 9c2647f75004c4f7d64c9c0ec55f8c6f0739a8b1 baseline version: qemuu 1d806cef0e38b5db8347a8e12f214d543204a314 Last test of basis 152631 2020-08-20 09:07:46 Z 318 days Failing since 152659 2020-08-21 14:07:39 Z 316 days 582 attempts Testing same since 163228 2021-07-02 17:08:27 Z 1 days 4 attempts ------------------------------------------------------------ 554 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 1d806cef0e..9c2647f750 9c2647f75004c4f7d64c9c0ec55f8c6f0739a8b1 -> upstream-tested From xen-devel-bounces@lists.xenproject.org Sun Jul 04 09:59:32 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 04 Jul 2021 09:59:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149669.276853 (Exim 4.92) (envelope-from ) id 1lzyuM-0005Fu-0e; Sun, 04 Jul 2021 09:59:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149669.276853; Sun, 04 Jul 2021 09:59:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzyuL-0005Fn-TW; Sun, 04 Jul 2021 09:59:25 +0000 Received: by outflank-mailman (input) for mailman id 149669; Sun, 04 Jul 2021 09:59:24 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzyuK-0005Fd-70; Sun, 04 Jul 2021 09:59:24 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzyuJ-0001Vx-Vf; Sun, 04 Jul 2021 09:59:23 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lzyuJ-0002uv-M6; Sun, 04 Jul 2021 09:59:23 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lzyuJ-00020b-Lf; Sun, 04 Jul 2021 09:59:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=V/EigjgZn+tf/83AHSyx4rFygNlFfT+Y9bS6F0eTaN4=; b=Tl161iJnEMTx2j+mG2rIWCGsdD k5mgBSwrJIoxHydLb2X0kZrEQEbiYQKiV5Aatl5oe1SFwJdRslmeDLTOLeLKmGpWkyO8xusg3m2oV QPYaYlf83BV+gbN9rJwlwr5DoOvNDeLIPHKtUKKA4p7YX8HPntMxTSdTvHaBqC1Bqei8=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-coverity test] 163297: all pass - PUSHED X-Osstest-Versions-This: xen=74d044d51b19bb697eac5c3deafa140f6afafec8 X-Osstest-Versions-That: xen=f95b7b37cfc6d4613721df9357090d14712013c0 From: osstest service owner Date: Sun, 04 Jul 2021 09:59:23 +0000 flight 163297 xen-unstable-coverity real [real] http://logs.test-lab.xenproject.org/osstest/logs/163297/ Perfect :-) All tests in this flight passed as required version targeted for testing: xen 74d044d51b19bb697eac5c3deafa140f6afafec8 baseline version: xen f95b7b37cfc6d4613721df9357090d14712013c0 Last test of basis 163196 2021-06-30 09:18:32 Z 4 days Testing same since 163297 2021-07-04 09:20:47 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Anthony PERARD Ian Jackson Olaf Hering jobs: coverity-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git f95b7b37cf..74d044d51b 74d044d51b19bb697eac5c3deafa140f6afafec8 -> coverity-tested/smoke From xen-devel-bounces@lists.xenproject.org Sun Jul 04 11:58:09 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 04 Jul 2021 11:58:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149675.276867 (Exim 4.92) (envelope-from ) id 1m00kj-0007Vf-1u; Sun, 04 Jul 2021 11:57:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149675.276867; Sun, 04 Jul 2021 11:57:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m00ki-0007VY-Uy; Sun, 04 Jul 2021 11:57:36 +0000 Received: by outflank-mailman (input) for mailman id 149675; Sun, 04 Jul 2021 11:57:34 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m00kg-0007VO-QT; Sun, 04 Jul 2021 11:57:34 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m00kg-0003Rx-K9; Sun, 04 Jul 2021 11:57:34 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m00kg-000873-AE; Sun, 04 Jul 2021 11:57:34 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1m00kg-0000XL-9f; Sun, 04 Jul 2021 11:57:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=QQ/HPssXFRRoYYbVC37VvY1bR4Tpf8+dhJosMkL2nus=; b=dgZjtL9gxle4HAUxQTWfsiJon1 IKLEQlJge94q0+rg301syLr/vJ2AAZJ0GpPfs7aZ5+KB+TSrnGYQ8Iz6KYh41N384L+LKdSIyPbSg ++KP338J5BQHqTf5C0RN/nmnFKsC7KPEWUJEj9LEaJ0ARW3ZIMb2/qd16Y2OUWcFizX4=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 163294: regressions - FAIL X-Osstest-Failures: ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:debian-hvm-install:fail:regression ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:debian-hvm-install:fail:regression X-Osstest-Versions-This: ovmf=fea7901dba72eeac526f3ef12a4ad4c539622373 X-Osstest-Versions-That: ovmf=c410ad4da4b7785170d3d42a3ba190c2caac6feb From: osstest service owner Date: Sun, 04 Jul 2021 11:57:34 +0000 flight 163294 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/163294/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 162359 test-amd64-amd64-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 162359 version targeted for testing: ovmf fea7901dba72eeac526f3ef12a4ad4c539622373 baseline version: ovmf c410ad4da4b7785170d3d42a3ba190c2caac6feb Last test of basis 162359 2021-06-04 03:40:08 Z 30 days Failing since 162368 2021-06-04 15:42:59 Z 29 days 82 attempts Testing same since 163216 2021-07-01 22:42:29 Z 2 days 12 attempts ------------------------------------------------------------ People who touched revisions under test: Abner Chang Agrawal, Sachin Alexandru Elisei Anthony PERARD Ard Biesheuvel Daniel Schaefer Daoxiang Li Dov Murik DunTan gaoliming Guo Dong Hao A Wu Jian J Wang Kaaira Gupta Ken Lautner Kenneth Lautner Kun Qin Laszlo Ersek Leif Lindholm Liming Gao Loo Tung Lun Loo, Tung Lun Manickavasakam Karpagavinayagam Maurice Ma Ni, Ray Patrick Rudolph Pierre Gondois Ray Ni Rebecca Cran Rebecca Cran Sachin Agrawal Sami Mujawar Scottie Kuo Sean Brogan Sean Brogan Sumana Venur Sunil V L xueshengfeng Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-i386-xl-qemuu-ovmf-amd64 fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 3224 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Jul 04 15:22:05 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 04 Jul 2021 15:22:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149682.276881 (Exim 4.92) (envelope-from ) id 1m03wN-0000Da-VR; Sun, 04 Jul 2021 15:21:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149682.276881; Sun, 04 Jul 2021 15:21:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m03wN-0000DT-Rg; Sun, 04 Jul 2021 15:21:51 +0000 Received: by outflank-mailman (input) for mailman id 149682; Sun, 04 Jul 2021 15:21:50 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m03wM-0000DE-Pd; Sun, 04 Jul 2021 15:21:50 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m03wM-0006lR-Gf; Sun, 04 Jul 2021 15:21:50 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m03wM-0006x9-71; Sun, 04 Jul 2021 15:21:50 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1m03wM-0001k5-6Y; Sun, 04 Jul 2021 15:21:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=YHUp7QBuPrUrD4sePcxo8oZB531nfZ+S80wYpyaL3ds=; b=sqjorhZUCD+Tpnv3cX65FhjWnz sq25N9WqbUlGxI6MN1gNrOnfgIoikGxQSl4RCK6Ugx3vKsKB/cdC+yJRR61AW7J82PjlkOGXns7lF oyzj8OZJ9tOveBqNztxN4jl4NQevjjw0EsF/QZNdY/SZI+3z3ggSyxbUk+r95FPEnw50=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 163298: regressions - FAIL X-Osstest-Failures: ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:debian-hvm-install:fail:regression ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:debian-hvm-install:fail:regression X-Osstest-Versions-This: ovmf=fea7901dba72eeac526f3ef12a4ad4c539622373 X-Osstest-Versions-That: ovmf=c410ad4da4b7785170d3d42a3ba190c2caac6feb From: osstest service owner Date: Sun, 04 Jul 2021 15:21:50 +0000 flight 163298 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/163298/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 162359 test-amd64-amd64-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 162359 version targeted for testing: ovmf fea7901dba72eeac526f3ef12a4ad4c539622373 baseline version: ovmf c410ad4da4b7785170d3d42a3ba190c2caac6feb Last test of basis 162359 2021-06-04 03:40:08 Z 30 days Failing since 162368 2021-06-04 15:42:59 Z 29 days 83 attempts Testing same since 163216 2021-07-01 22:42:29 Z 2 days 13 attempts ------------------------------------------------------------ People who touched revisions under test: Abner Chang Agrawal, Sachin Alexandru Elisei Anthony PERARD Ard Biesheuvel Daniel Schaefer Daoxiang Li Dov Murik DunTan gaoliming Guo Dong Hao A Wu Jian J Wang Kaaira Gupta Ken Lautner Kenneth Lautner Kun Qin Laszlo Ersek Leif Lindholm Liming Gao Loo Tung Lun Loo, Tung Lun Manickavasakam Karpagavinayagam Maurice Ma Ni, Ray Patrick Rudolph Pierre Gondois Ray Ni Rebecca Cran Rebecca Cran Sachin Agrawal Sami Mujawar Scottie Kuo Sean Brogan Sean Brogan Sumana Venur Sunil V L xueshengfeng Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-i386-xl-qemuu-ovmf-amd64 fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 3224 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Jul 04 15:41:30 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 04 Jul 2021 15:41:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149689.276895 (Exim 4.92) (envelope-from ) id 1m04FG-0002VE-Jq; Sun, 04 Jul 2021 15:41:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149689.276895; Sun, 04 Jul 2021 15:41:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m04FG-0002V7-GQ; Sun, 04 Jul 2021 15:41:22 +0000 Received: by outflank-mailman (input) for mailman id 149689; Sun, 04 Jul 2021 15:41:22 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m04FG-0002Ux-4D; Sun, 04 Jul 2021 15:41:22 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m04FF-00074D-PT; Sun, 04 Jul 2021 15:41:21 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m04FF-0007k0-GD; Sun, 04 Jul 2021 15:41:21 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1m04FF-0002iD-Fg; Sun, 04 Jul 2021 15:41:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=YTpRxhyHmmj5jJhXdtiJBUjkQFoLj6MOzuJZ1wIuhQI=; b=1z7XuB47+wzB9ms1m4NNKXPFVf P2Xo4c4w6LVRF8LviOAKvAUDbC41FVrZd8tBU1vQFQtOE74frH+ylVZGvfKnhe3dRpdHtW5pw5RhT CaBnKnXaw8t0b/H+8kmGJSmC7p4KsnZCixJIiEYgSwbdPn6b/yRPPnNFVvHOQOAfe8jU=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 163293: tolerable FAIL X-Osstest-Failures: xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:heisenbug xen-unstable:test-amd64-amd64-libvirt-vhd:guest-saverestore:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=74d044d51b19bb697eac5c3deafa140f6afafec8 X-Osstest-Versions-That: xen=74d044d51b19bb697eac5c3deafa140f6afafec8 From: osstest service owner Date: Sun, 04 Jul 2021 15:41:21 +0000 flight 163293 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/163293/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail in 163239 pass in 163293 test-amd64-amd64-libvirt-vhd 16 guest-saverestore fail pass in 163239 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 163239 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 163239 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 163239 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 163239 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 163239 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 163239 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 163239 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 163239 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 163239 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 163239 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 163239 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 163239 test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 74d044d51b19bb697eac5c3deafa140f6afafec8 baseline version: xen 74d044d51b19bb697eac5c3deafa140f6afafec8 Last test of basis 163293 2021-07-04 01:52:08 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd fail test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Sun Jul 04 18:22:06 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 04 Jul 2021 18:22:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149700.276909 (Exim 4.92) (envelope-from ) id 1m06ka-00006C-C5; Sun, 04 Jul 2021 18:21:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149700.276909; Sun, 04 Jul 2021 18:21:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m06ka-000065-8s; Sun, 04 Jul 2021 18:21:52 +0000 Received: by outflank-mailman (input) for mailman id 149700; Sun, 04 Jul 2021 18:21:50 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m06kY-00005u-D5; Sun, 04 Jul 2021 18:21:50 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m06kY-0001nC-33; Sun, 04 Jul 2021 18:21:50 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m06kX-00075T-QA; Sun, 04 Jul 2021 18:21:49 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1m06kX-0004dr-Pe; Sun, 04 Jul 2021 18:21:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=dx33L3hCC56N6mawbpgp7oljCH4GJSMNor+k1047G+E=; b=J6G8xPkpuFR975deGr7cbAHkXR hEITtVPgAh6gKq1R0TDIy6HjgG6X3mrMw+FlIdu64HIAJHOfsKttTrcbbxnGIwvkq09BVim5RuOVe X3qO6kwauGc89JSzkrqqz4DwtRaCEnK9Vt4cK+qMaZgzeIJGsumGYf7wPXYWP2YN75js=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 163296: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-i386-xl-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-coresched-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-xl-qemut-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-examine:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-pvshim:xen-install:fail:regression linux-linus:test-amd64-i386-xl-raw:xen-install:fail:regression linux-linus:test-amd64-i386-xl-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-i386:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-xsm:xen-install:fail:regression linux-linus:test-arm64-arm64-xl-seattle:debian-install:fail:regression linux-linus:test-amd64-amd64-libvirt-vhd:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-credit2:debian-install:fail:regression linux-linus:test-arm64-arm64-xl-credit1:debian-install:fail:regression linux-linus:test-arm64-arm64-xl-thunderx:debian-install:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-arm64-arm64-xl-xsm:debian-install:fail:regression linux-linus:test-amd64-amd64-amd64-pvgrub:guest-stop:fail:regression linux-linus:test-arm64-arm64-xl:debian-install:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:debian-install:fail:regression linux-linus:test-amd64-amd64-i386-pvgrub:guest-stop:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qcow2:guest-start:fail:regression linux-linus:test-armhf-armhf-xl-cubietruck:debian-install:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:debian-di-install:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:debian-install:fail:regression linux-linus:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:heisenbug linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=303392fd5c160822bf778270b28ec5ea50cab2b4 X-Osstest-Versions-That: linux=deacdb3e3979979016fcd0ffd518c320a62ad166 From: osstest service owner Date: Sun, 04 Jul 2021 18:21:49 +0000 flight 163296 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/163296/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-coresched-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-xl-qemut-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-examine 6 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-pvshim 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-raw 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-i386 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-xsm 7 xen-install fail REGR. vs. 152332 test-arm64-arm64-xl-seattle 12 debian-install fail REGR. vs. 152332 test-amd64-amd64-libvirt-vhd 13 guest-start fail REGR. vs. 152332 test-arm64-arm64-xl-credit2 12 debian-install fail REGR. vs. 152332 test-arm64-arm64-xl-credit1 12 debian-install fail REGR. vs. 152332 test-arm64-arm64-xl-thunderx 12 debian-install fail REGR. vs. 152332 test-armhf-armhf-examine 8 reboot fail REGR. vs. 152332 test-arm64-arm64-xl-xsm 12 debian-install fail REGR. vs. 152332 test-amd64-amd64-amd64-pvgrub 20 guest-stop fail REGR. vs. 152332 test-arm64-arm64-xl 12 debian-install fail REGR. vs. 152332 test-arm64-arm64-libvirt-xsm 12 debian-install fail REGR. vs. 152332 test-amd64-amd64-i386-pvgrub 20 guest-stop fail REGR. vs. 152332 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 152332 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 152332 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 152332 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 152332 test-amd64-amd64-xl-qcow2 13 guest-start fail REGR. vs. 152332 test-armhf-armhf-xl-cubietruck 12 debian-install fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 152332 test-armhf-armhf-xl-vhd 12 debian-di-install fail REGR. vs. 152332 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 152332 test-armhf-armhf-xl-multivcpu 12 debian-install fail REGR. vs. 152332 Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-rtds 20 guest-localmigrate/x10 fail pass in 163290 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 152332 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 152332 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152332 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152332 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass version targeted for testing: linux 303392fd5c160822bf778270b28ec5ea50cab2b4 baseline version: linux deacdb3e3979979016fcd0ffd518c320a62ad166 Last test of basis 152332 2020-07-31 19:41:23 Z 337 days Failing since 152366 2020-08-01 20:49:34 Z 336 days 574 attempts Testing same since 163290 2021-07-03 22:11:05 Z 0 days 2 attempts ------------------------------------------------------------ 6537 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-i386-xl fail test-amd64-coresched-i386-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm fail test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm fail test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck fail test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine fail test-amd64-i386-examine fail test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel fail test-amd64-i386-qemuu-rhel6hvm-intel fail test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-amd64-pvgrub fail test-amd64-amd64-i386-pvgrub fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 fail test-armhf-armhf-libvirt-raw fail test-amd64-i386-xl-raw fail test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow fail test-arm64-arm64-xl-thunderx fail test-amd64-amd64-libvirt-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1888347 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Jul 04 18:50:52 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 04 Jul 2021 18:50:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149710.276922 (Exim 4.92) (envelope-from ) id 1m07CW-0003Go-U8; Sun, 04 Jul 2021 18:50:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149710.276922; Sun, 04 Jul 2021 18:50:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m07CW-0003Gh-RE; Sun, 04 Jul 2021 18:50:44 +0000 Received: by outflank-mailman (input) for mailman id 149710; Sun, 04 Jul 2021 18:50:43 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m07CV-0003GX-Qt; Sun, 04 Jul 2021 18:50:43 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m07CV-0002Ey-JS; Sun, 04 Jul 2021 18:50:43 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m07CV-000804-As; Sun, 04 Jul 2021 18:50:43 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1m07CV-0005G1-AL; Sun, 04 Jul 2021 18:50:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=nJmrZIR6Zytt4njVbacmOyYtAJCgG4zmI+AaUc7OGlY=; b=5kddQ3bHcKcJAe+kTeckFpaS8Z SjCFk1705p2ZdGS8CEG/PuapX5lL27XiVa7lXoltEBExBJt9uRxT/hHPoAJUIfbc3TZRKHKPfw5vd beoIZEEaZ/i8yCqcKLk3QwhOeQiedAsoZiOikswpnGzLscJrdvj6N85dO6hoVsbyfxhc=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 163300: regressions - FAIL X-Osstest-Failures: ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:debian-hvm-install:fail:regression ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:debian-hvm-install:fail:regression X-Osstest-Versions-This: ovmf=fea7901dba72eeac526f3ef12a4ad4c539622373 X-Osstest-Versions-That: ovmf=c410ad4da4b7785170d3d42a3ba190c2caac6feb From: osstest service owner Date: Sun, 04 Jul 2021 18:50:43 +0000 flight 163300 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/163300/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 162359 test-amd64-amd64-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 162359 version targeted for testing: ovmf fea7901dba72eeac526f3ef12a4ad4c539622373 baseline version: ovmf c410ad4da4b7785170d3d42a3ba190c2caac6feb Last test of basis 162359 2021-06-04 03:40:08 Z 30 days Failing since 162368 2021-06-04 15:42:59 Z 30 days 84 attempts Testing same since 163216 2021-07-01 22:42:29 Z 2 days 14 attempts ------------------------------------------------------------ People who touched revisions under test: Abner Chang Agrawal, Sachin Alexandru Elisei Anthony PERARD Ard Biesheuvel Daniel Schaefer Daoxiang Li Dov Murik DunTan gaoliming Guo Dong Hao A Wu Jian J Wang Kaaira Gupta Ken Lautner Kenneth Lautner Kun Qin Laszlo Ersek Leif Lindholm Liming Gao Loo Tung Lun Loo, Tung Lun Manickavasakam Karpagavinayagam Maurice Ma Ni, Ray Patrick Rudolph Pierre Gondois Ray Ni Rebecca Cran Rebecca Cran Sachin Agrawal Sami Mujawar Scottie Kuo Sean Brogan Sean Brogan Sumana Venur Sunil V L xueshengfeng Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-i386-xl-qemuu-ovmf-amd64 fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 3224 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Jul 04 20:39:10 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 04 Jul 2021 20:39:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149718.276937 (Exim 4.92) (envelope-from ) id 1m08tC-0003t3-2A; Sun, 04 Jul 2021 20:38:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149718.276937; Sun, 04 Jul 2021 20:38:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m08tB-0003sw-Ux; Sun, 04 Jul 2021 20:38:53 +0000 Received: by outflank-mailman (input) for mailman id 149718; Sun, 04 Jul 2021 20:38:52 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m08tA-0003sm-PC; Sun, 04 Jul 2021 20:38:52 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m08tA-00044u-HM; Sun, 04 Jul 2021 20:38:52 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m08tA-0004e8-6H; Sun, 04 Jul 2021 20:38:52 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1m08tA-0005Ef-5p; Sun, 04 Jul 2021 20:38:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=NJCsu7xn5KcQ3UMIMSh+3+49cbVisrLWJTtgfKqNI6M=; b=DkaX+wvyr+S+7c86Ku3PCNHpIh ZCQ7f68BVmrBbxRG6K9EUxGcSb94f30yZdPEEhhZd6aXuQh6AR7mrZIqoau2M+cdPb46eIHZSOjvJ uB4sFNIiOe5nhlvuHRcOcxlI2JrrnuPFo07W9J7CPZrXJ6sSz5ir6usUp0/OnyyWujYQ=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 163299: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=73c8bf4ccff8951d228b8a0d49968c56e32da4de X-Osstest-Versions-That: qemuu=9c2647f75004c4f7d64c9c0ec55f8c6f0739a8b1 From: osstest service owner Date: Sun, 04 Jul 2021 20:38:52 +0000 flight 163299 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/163299/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 163292 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 163292 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 163292 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 163292 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 163292 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 163292 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 163292 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: qemuu 73c8bf4ccff8951d228b8a0d49968c56e32da4de baseline version: qemuu 9c2647f75004c4f7d64c9c0ec55f8c6f0739a8b1 Last test of basis 163292 2021-07-04 01:11:27 Z 0 days Testing same since 163299 2021-07-04 13:37:55 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Joe Komlodi Maxim Uvarov Nolan Leake Patrick Venture Peter Maydell Philippe Mathieu-Daudé jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 9c2647f750..73c8bf4ccf 73c8bf4ccff8951d228b8a0d49968c56e32da4de -> upstream-tested From xen-devel-bounces@lists.xenproject.org Sun Jul 04 22:54:10 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 04 Jul 2021 22:54:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149727.276951 (Exim 4.92) (envelope-from ) id 1m0Azt-0007Zw-QJ; Sun, 04 Jul 2021 22:53:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149727.276951; Sun, 04 Jul 2021 22:53:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0Azt-0007Zp-N5; Sun, 04 Jul 2021 22:53:57 +0000 Received: by outflank-mailman (input) for mailman id 149727; Sun, 04 Jul 2021 22:53:56 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0Azs-0007Zf-7N; Sun, 04 Jul 2021 22:53:56 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0Azs-0006DM-06; Sun, 04 Jul 2021 22:53:56 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0Azr-0000lV-Nj; Sun, 04 Jul 2021 22:53:55 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1m0Azr-0006GE-NE; Sun, 04 Jul 2021 22:53:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=MvhZm8XBhvbvkC8X5UM4UYbKZEtFV8lndOSAxq1uSIk=; b=00ZDk25KP4fpYYg0ICL8SmSZJu vcYtwlP6ycB5efCZUenLy0w6HGRhvM34BBuYAXFk6RA9BS8vCx5ZXvvGc66iHRbEDRxvrXtGNdtSo Q62592khSTkT+iIjXWvIMmKA9HVrsaE1BYL+WouYVuPI6X0SULNyAjxRdbV/ef+KVaew=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 163302: regressions - FAIL X-Osstest-Failures: ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:debian-hvm-install:fail:regression ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:debian-hvm-install:fail:regression X-Osstest-Versions-This: ovmf=fea7901dba72eeac526f3ef12a4ad4c539622373 X-Osstest-Versions-That: ovmf=c410ad4da4b7785170d3d42a3ba190c2caac6feb From: osstest service owner Date: Sun, 04 Jul 2021 22:53:55 +0000 flight 163302 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/163302/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 162359 test-amd64-amd64-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 162359 version targeted for testing: ovmf fea7901dba72eeac526f3ef12a4ad4c539622373 baseline version: ovmf c410ad4da4b7785170d3d42a3ba190c2caac6feb Last test of basis 162359 2021-06-04 03:40:08 Z 30 days Failing since 162368 2021-06-04 15:42:59 Z 30 days 85 attempts Testing same since 163216 2021-07-01 22:42:29 Z 3 days 15 attempts ------------------------------------------------------------ People who touched revisions under test: Abner Chang Agrawal, Sachin Alexandru Elisei Anthony PERARD Ard Biesheuvel Daniel Schaefer Daoxiang Li Dov Murik DunTan gaoliming Guo Dong Hao A Wu Jian J Wang Kaaira Gupta Ken Lautner Kenneth Lautner Kun Qin Laszlo Ersek Leif Lindholm Liming Gao Loo Tung Lun Loo, Tung Lun Manickavasakam Karpagavinayagam Maurice Ma Ni, Ray Patrick Rudolph Pierre Gondois Ray Ni Rebecca Cran Rebecca Cran Sachin Agrawal Sami Mujawar Scottie Kuo Sean Brogan Sean Brogan Sumana Venur Sunil V L xueshengfeng Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-i386-xl-qemuu-ovmf-amd64 fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 3224 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Jul 05 01:39:13 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Jul 2021 01:39:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149737.276965 (Exim 4.92) (envelope-from ) id 1m0DZa-0006Hk-P5; Mon, 05 Jul 2021 01:38:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149737.276965; Mon, 05 Jul 2021 01:38:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0DZa-0006Hc-Jk; Mon, 05 Jul 2021 01:38:58 +0000 Received: by outflank-mailman (input) for mailman id 149737; Mon, 05 Jul 2021 01:38:57 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0DZZ-0006HS-1a; Mon, 05 Jul 2021 01:38:57 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0DZY-0001dt-Mm; Mon, 05 Jul 2021 01:38:56 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0DZY-00087l-9g; Mon, 05 Jul 2021 01:38:56 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1m0DZY-0006cO-9B; Mon, 05 Jul 2021 01:38:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=FK9ykQ+2iPycUwlEc+W7N0u90UBBN0OfqfC3rLYvRmM=; b=TEteGQ8l4SmnwkbNt+h/5LTcwz HDBrbdyo+JHobxbf0FTU8lgdyDmlsP4CDtuobgcXtyvE6DDxoNGnBx924Vu4BTu3g1BEJII01f3aM 2elCtfx465Td2LuoxdsVoFKfiat+VSsDYtHEi7HtKyrisdYOm5AFXjvjoMJKaNorNvNU=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 163301: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-i386-xl-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt:xen-install:fail:regression linux-linus:test-amd64-coresched-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-xl-qemut-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-examine:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-pvshim:xen-install:fail:regression linux-linus:test-amd64-i386-xl-raw:xen-install:fail:regression linux-linus:test-amd64-i386-xl-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-i386:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-xsm:xen-install:fail:regression linux-linus:test-arm64-arm64-xl-seattle:debian-install:fail:regression linux-linus:test-amd64-amd64-libvirt-vhd:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-credit1:debian-install:fail:regression linux-linus:test-arm64-arm64-xl-credit2:debian-install:fail:regression linux-linus:test-arm64-arm64-xl-thunderx:debian-install:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-arm64-arm64-xl-xsm:debian-install:fail:regression linux-linus:test-amd64-amd64-amd64-pvgrub:guest-stop:fail:regression linux-linus:test-arm64-arm64-xl:debian-install:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:debian-install:fail:regression linux-linus:test-amd64-amd64-i386-pvgrub:guest-stop:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qcow2:guest-start:fail:regression linux-linus:test-armhf-armhf-xl-cubietruck:debian-install:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:debian-di-install:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:debian-install:fail:regression linux-linus:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:heisenbug linux-linus:test-amd64-amd64-xl-rtds:guest-localmigrate:fail:heisenbug linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=303392fd5c160822bf778270b28ec5ea50cab2b4 X-Osstest-Versions-That: linux=deacdb3e3979979016fcd0ffd518c320a62ad166 From: osstest service owner Date: Mon, 05 Jul 2021 01:38:56 +0000 flight 163301 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/163301/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt 7 xen-install fail REGR. vs. 152332 test-amd64-coresched-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-xl-qemut-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-examine 6 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-pvshim 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-raw 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-i386 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-xsm 7 xen-install fail REGR. vs. 152332 test-arm64-arm64-xl-seattle 12 debian-install fail REGR. vs. 152332 test-amd64-amd64-libvirt-vhd 13 guest-start fail REGR. vs. 152332 test-arm64-arm64-xl-credit1 12 debian-install fail REGR. vs. 152332 test-arm64-arm64-xl-credit2 12 debian-install fail REGR. vs. 152332 test-arm64-arm64-xl-thunderx 12 debian-install fail REGR. vs. 152332 test-armhf-armhf-examine 8 reboot fail REGR. vs. 152332 test-arm64-arm64-xl-xsm 12 debian-install fail REGR. vs. 152332 test-amd64-amd64-amd64-pvgrub 20 guest-stop fail REGR. vs. 152332 test-arm64-arm64-xl 12 debian-install fail REGR. vs. 152332 test-arm64-arm64-libvirt-xsm 12 debian-install fail REGR. vs. 152332 test-amd64-amd64-i386-pvgrub 20 guest-stop fail REGR. vs. 152332 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 152332 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 152332 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 152332 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 152332 test-amd64-amd64-xl-qcow2 13 guest-start fail REGR. vs. 152332 test-armhf-armhf-xl-cubietruck 12 debian-install fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 152332 test-armhf-armhf-xl-vhd 12 debian-di-install fail REGR. vs. 152332 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 152332 test-armhf-armhf-xl-multivcpu 12 debian-install fail REGR. vs. 152332 Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-rtds 20 guest-localmigrate/x10 fail in 163296 pass in 163290 test-amd64-amd64-xl-rtds 18 guest-localmigrate fail pass in 163296 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 163296 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 152332 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 152332 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152332 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152332 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass version targeted for testing: linux 303392fd5c160822bf778270b28ec5ea50cab2b4 baseline version: linux deacdb3e3979979016fcd0ffd518c320a62ad166 Last test of basis 152332 2020-07-31 19:41:23 Z 338 days Failing since 152366 2020-08-01 20:49:34 Z 337 days 575 attempts Testing same since 163290 2021-07-03 22:11:05 Z 1 days 3 attempts ------------------------------------------------------------ 6537 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-i386-xl fail test-amd64-coresched-i386-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm fail test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm fail test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck fail test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine fail test-amd64-i386-examine fail test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel fail test-amd64-i386-qemuu-rhel6hvm-intel fail test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-amd64-pvgrub fail test-amd64-amd64-i386-pvgrub fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 fail test-armhf-armhf-libvirt-raw fail test-amd64-i386-xl-raw fail test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow fail test-arm64-arm64-xl-thunderx fail test-amd64-amd64-libvirt-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1888347 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Jul 05 02:40:16 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Jul 2021 02:40:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149746.276979 (Exim 4.92) (envelope-from ) id 1m0EWf-00040Q-Fa; Mon, 05 Jul 2021 02:40:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149746.276979; Mon, 05 Jul 2021 02:40:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0EWf-0003zs-Ak; Mon, 05 Jul 2021 02:40:01 +0000 Received: by outflank-mailman (input) for mailman id 149746; Mon, 05 Jul 2021 02:40:00 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0EWe-0003wk-ER; Mon, 05 Jul 2021 02:40:00 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0EWe-0003A5-6v; Mon, 05 Jul 2021 02:40:00 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0EWd-0002Vn-Sl; Mon, 05 Jul 2021 02:39:59 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1m0EWd-0000li-SE; Mon, 05 Jul 2021 02:39:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=/OptFA5HxTTJ9k6r4ee3hkkWmACw8J1FQ7f2BqfFiZw=; b=1fkBV4UiocDOvt5sS5vgA6xIEi K91ekTQw/7SiuhTQ7s2JXT7XQ4nb70teDqHhquP90PSDGaOA3a4G4BTeq6EOKnHUGNI+p00QYd06E vr9BV9eX2g1TEE7roGvNlvOpibhI5Vzzib8hRLTtUXstg7iuSbrlYQBvrpcjc/BXZ6FU=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 163304: regressions - FAIL X-Osstest-Failures: ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:debian-hvm-install:fail:regression ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:debian-hvm-install:fail:regression X-Osstest-Versions-This: ovmf=fea7901dba72eeac526f3ef12a4ad4c539622373 X-Osstest-Versions-That: ovmf=c410ad4da4b7785170d3d42a3ba190c2caac6feb From: osstest service owner Date: Mon, 05 Jul 2021 02:39:59 +0000 flight 163304 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/163304/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 162359 test-amd64-amd64-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 162359 version targeted for testing: ovmf fea7901dba72eeac526f3ef12a4ad4c539622373 baseline version: ovmf c410ad4da4b7785170d3d42a3ba190c2caac6feb Last test of basis 162359 2021-06-04 03:40:08 Z 30 days Failing since 162368 2021-06-04 15:42:59 Z 30 days 86 attempts Testing same since 163216 2021-07-01 22:42:29 Z 3 days 16 attempts ------------------------------------------------------------ People who touched revisions under test: Abner Chang Agrawal, Sachin Alexandru Elisei Anthony PERARD Ard Biesheuvel Daniel Schaefer Daoxiang Li Dov Murik DunTan gaoliming Guo Dong Hao A Wu Jian J Wang Kaaira Gupta Ken Lautner Kenneth Lautner Kun Qin Laszlo Ersek Leif Lindholm Liming Gao Loo Tung Lun Loo, Tung Lun Manickavasakam Karpagavinayagam Maurice Ma Ni, Ray Patrick Rudolph Pierre Gondois Ray Ni Rebecca Cran Rebecca Cran Sachin Agrawal Sami Mujawar Scottie Kuo Sean Brogan Sean Brogan Sumana Venur Sunil V L xueshengfeng Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-i386-xl-qemuu-ovmf-amd64 fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 3224 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Jul 05 03:09:57 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Jul 2021 03:09:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149754.276993 (Exim 4.92) (envelope-from ) id 1m0EzV-0007XW-Ss; Mon, 05 Jul 2021 03:09:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149754.276993; Mon, 05 Jul 2021 03:09:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0EzV-0007XP-Pj; Mon, 05 Jul 2021 03:09:49 +0000 Received: by outflank-mailman (input) for mailman id 149754; Mon, 05 Jul 2021 03:09:48 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0EzT-0007XJ-NW for xen-devel@lists.xenproject.org; Mon, 05 Jul 2021 03:09:47 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (unknown [40.107.15.80]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id dbd37de5-cea5-4b67-a6f6-007332e21343; Mon, 05 Jul 2021 03:09:44 +0000 (UTC) Received: from DB6P193CA0006.EURP193.PROD.OUTLOOK.COM (2603:10a6:6:29::16) by VE1PR08MB4848.eurprd08.prod.outlook.com (2603:10a6:802:a7::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.27; Mon, 5 Jul 2021 03:09:41 +0000 Received: from DB5EUR03FT045.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:29:cafe::30) by DB6P193CA0006.outlook.office365.com (2603:10a6:6:29::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.21 via Frontend Transport; Mon, 5 Jul 2021 03:09:41 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT045.mail.protection.outlook.com (10.152.21.164) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.22 via Frontend Transport; Mon, 5 Jul 2021 03:09:41 +0000 Received: ("Tessian outbound f29a5a293366:v97"); Mon, 05 Jul 2021 03:09:41 +0000 Received: from eb2d3a3425a8.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 2983975C-BBAA-46B7-918F-BB8C0C493DE3.1; Mon, 05 Jul 2021 03:09:34 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id eb2d3a3425a8.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 05 Jul 2021 03:09:34 +0000 Received: from VE1PR08MB5215.eurprd08.prod.outlook.com (2603:10a6:803:10a::33) by VI1PR08MB5392.eurprd08.prod.outlook.com (2603:10a6:803:131::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.23; Mon, 5 Jul 2021 03:09:32 +0000 Received: from VE1PR08MB5215.eurprd08.prod.outlook.com ([fe80::2807:2ff9:e371:2918]) by VE1PR08MB5215.eurprd08.prod.outlook.com ([fe80::2807:2ff9:e371:2918%7]) with mapi id 15.20.4287.033; Mon, 5 Jul 2021 03:09:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dbd37de5-cea5-4b67-a6f6-007332e21343 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9xVWplOtYYC77d8mpvdrZFeZ/VyCcv1cqSvaZfi6Ieg=; b=9ocUjIbGQZvPA2JMrUlD6e0pwRaA4jtjuET4r+4q2dUNqtpZqaaeNmFaBCzIPRa7j5Lux9euTQcrCOTL65ccQaXbRVxOuG6z5LahyNiy4kmS2KaHJAJPR8AmUiXroee4IvZh8u1+We6KhpuSbluAIJB+4uPs3rfz+aChmF15T/Y= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mNUMXFM+0MT/PkCH0pWa57hQxQ/QyCqWTAyxm5nv3XlbgfR83ut+mLEj9bI59fYXlSU5zv2EsoiLGEGHlf3O2Zp1g50MR2Jm+mV749xSPg7SPASdhnZtG79dXM4Usont1aCa36hrT472cgIm9CejB4sst2EBW1rcxpgcHe32LsMe/hEopV4jodcyVe4KT+s9tyAjRLewR/u3IJQd90ytMi0SBB2FDd+2r86649bMhet6iHutFOiCVuCz5oX6cEawPqYNMfS42xc5fTLd68yGZk5QHJRTYQxHT/7ZqxhNKFq4HaI/uH6KJtqKP8UXwXFKHRsWOLYDBIl2kvimD29HcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9xVWplOtYYC77d8mpvdrZFeZ/VyCcv1cqSvaZfi6Ieg=; b=L7cC3f+feDMKAxguBPNPNyqydLwjFVxekOUiqe4f/BjbKr88BjvxIr/Ui7AlGt9bSyqApnV6UVGpkz+P7BuWIBkS0NBetyQJz3kGfiSiHHfvL310hofGGVLtnxeP7E1MU3aobGEs9xdar/gc3ZUrK2/XgKRzuCpBYegQg9YyqdyotKiHqn9Vzbje5CD1Dp5zKVQV1HgulSZj49TLDwtSLA5qkLsikOMO6QJWa4zo0mW+x1q6zzUe0bxeSPGVGLt+Bje8cukFhxLlCHQqYy0FYylv5WKv3FXJjG09rbjZoFrVtUvYAuR3WJiPMRhM2yuvi4dk56+dTNMgRTi6ITVjSA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9xVWplOtYYC77d8mpvdrZFeZ/VyCcv1cqSvaZfi6Ieg=; b=9ocUjIbGQZvPA2JMrUlD6e0pwRaA4jtjuET4r+4q2dUNqtpZqaaeNmFaBCzIPRa7j5Lux9euTQcrCOTL65ccQaXbRVxOuG6z5LahyNiy4kmS2KaHJAJPR8AmUiXroee4IvZh8u1+We6KhpuSbluAIJB+4uPs3rfz+aChmF15T/Y= From: Penny Zheng To: Julien Grall , "xen-devel@lists.xenproject.org" , "sstabellini@kernel.org" , "jbeulich@suse.com" CC: Bertrand Marquis , Wei Chen Subject: RE: [PATCH 2/9] xen/arm: introduce PGC_reserved Thread-Topic: [PATCH 2/9] xen/arm: introduce PGC_reserved Thread-Index: AQHXW0bwHTQXl1IIhEKAMxa4O5onFKss+IkAgAbmToA= Date: Mon, 5 Jul 2021 03:09:31 +0000 Message-ID: References: <20210607024318.3988467-1-penny.zheng@arm.com> <20210607024318.3988467-3-penny.zheng@arm.com> <1f1c1567-1a53-3b6a-2868-b7673d9180b3@xen.org> In-Reply-To: <1f1c1567-1a53-3b6a-2868-b7673d9180b3@xen.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 0020D2901BDBC644AFD49EC76997419B.0 x-checkrecipientchecked: true Authentication-Results-Original: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com; x-originating-ip: [203.126.0.113] x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: 0915e13d-4faf-49ac-35d6-08d93f62550b x-ms-traffictypediagnostic: VI1PR08MB5392:|VE1PR08MB4848: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:4125;OLM:4125; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: if3dEiRB+uxo3tWzY0MrZwMBZUGHz/6fBvYmQFWbq5oKbsNpR3gHQ2TqWmhJeeH0It4Nk0C1CaufF/GtMZC55Yidw2QtY3M6DPlyeOMMBoqXk8cuCgzWANj5/y4LUqGNlPFtxaBUQnVaicolbGc9nYkwL9his7FLtMuXpqKGbW/xfPqtH/Uf+n7/SMxdIMAQMy9lElRnhu0vJumMPFrFvKLqLomwlHQ7GdC6yMjmeZ9TpaN4rU3kS8qP1Vbez21YRyn/FyWnCDxkTy9/I4YG8kz2lQg+qgt4Xm1YfsOkMxhlAnYVjudYSjI0/rj7gCYXVyCwYjNLrvvqFnsOZBzImE/rEFPdJX7GFdA3DviE1uul2lO/oUdfKSoDgM7jkTjzruK4KwHp5cOwwDEPR4CRD3ILCH94+xf7PtijAKzLRMRcCANOMuLp6jPYNmywJ4KnZEjENrhKrKt/YYVsqlKeyRwKXgEM5HvXeZh6NrGmmfmkhyRZhQ1AF7EPdqPCrA2fMYWFF7V4zxY6uwCioaKC5gvBLE+32D6OKE5my0a48hazqiID29cg69vw86g6cW3e7igBPA+R+iAK6IDguesOqxuw/LH/S0abHlEU/IYhMC/fJMUvGdCcDHCid07QKS+QbH+kK+7pzMknFJOkehb9ag== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR08MB5215.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(376002)(396003)(346002)(39850400004)(366004)(7696005)(186003)(8936002)(2906002)(33656002)(5660300002)(6506007)(53546011)(83380400001)(8676002)(52536014)(9686003)(66446008)(76116006)(66946007)(66476007)(66556008)(86362001)(122000001)(64756008)(38100700002)(26005)(55016002)(54906003)(110136005)(316002)(71200400001)(478600001)(4326008);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?VDE4OW55MmtEVEIyWU1Demx1VVY1c1FjZEE3R2dkZi9lRVQ4NUh5SkhYUG5O?= =?utf-8?B?UXVwTWxFd2dkRGVSVnE3SUd3R2M5M2E3VGduMEJJbmtyUTd2SWhxNVBYUXgw?= =?utf-8?B?QlR1OXNRdTVaUklsTVJGZDB4Rzh0a1NReWJRTVpzM1R2K1NCb2tXYnRYWjFH?= =?utf-8?B?bHozS2E4dnBBbVdoOXZva2ZQS2s4S1pVYjE3eHhmL01saFF0SFNNUERrdmEy?= =?utf-8?B?L2RNVTJEQkpTVkZ4NlZESS9nZzE4TkpiVWJmYWxqRkQ0ZjVpd3FaaWJqMkFN?= =?utf-8?B?MVJydTFkczUyeWpWWExGclhsMGhqeXhUWVJRdXVOdnU5VVQ5eklqaW04OHVM?= =?utf-8?B?OVJHWmhSeDRlbDFxUm5OQ2NWakl3UGRQUUo1MzhzQ1dyODlxZFVFdk5IY3dJ?= =?utf-8?B?ZHMwVVYzSjBCL1dDa2Vib21yUWJub0JCYkx5RTdDZDJWQjZrOWpuRVFKVDN1?= =?utf-8?B?MGdOeTBNSndPTll6U3ViSHZpOHFjaDZGKyt2WkRFclNzdGRiSDhCWXJINVhF?= =?utf-8?B?aXRTZUdDdXdJVzJ5VlJSdFV3bm5BTGNuT2RZejcrcG8yZ2x4TnhIeXB5ZzdB?= =?utf-8?B?dW1mVzFneWFtZTFQaGNEaGRUMHRZdkN1S2Y3NHR1blJGdmhUVXE0MThDb3Jh?= =?utf-8?B?R09xNDBXVWdqMG85TkxEdncrZ0Z2eTMwUkFFRCtlcnBNQ0dCRXlEWko0U2FE?= =?utf-8?B?NTFFQVRxZnFqdHNuT2NzYnErMEsrWE5GZUxOeG8rRTJlT1RjY2JiR2JHVith?= =?utf-8?B?T0NOVEgyL1JKbXBub01Id0xNOHNTRXZmWnBvdCszMUdueWxVaVZXME5pQ1VG?= =?utf-8?B?eUJJVDQ3S2ZNRi9BcS84MDhBczN6b3VINWpWcVFVMDR3b3NnVWNZME04YWdu?= =?utf-8?B?YmpBSmJ0c2RrdmF6dkhDeWVaNVJnbjNUMENETmFSOS95c3QxT2hRUU50bC95?= =?utf-8?B?aHN3NDFuMUZLeVdleGJPU2Jsa0I0a2tCUjZnV0RqUE1MK1h0YTU3MTNPekVP?= =?utf-8?B?Ym9oTFdsQ1gzNERXdjhXcHh2SXo4bVZjL0VMemZRbUwrY2RkMFpjS2d0WFJB?= =?utf-8?B?ZW1GM1ROWDh1NnNpZXBTWXByblNmT3AvaXlIMVhjMkE3WndBSFllazBEaWdu?= =?utf-8?B?Ym5PTnQvWU1NYTcrZkJhMHJHakFEb3RpMkdJL2tRVjRrVDNMd0RkR0RUdXcr?= =?utf-8?B?WVB5M0t3YkprME02cTl2SWI4SEh5QWluaGZHbUhhRnJSSG5kdkh3SXQ2TS9q?= =?utf-8?B?VSs4ZFZYT3RBVWQ4bWhxYjk1MVgzNnR3dHVybWRwUER3UDhTNlphb2NHdXVs?= =?utf-8?B?RGE0c3pLbllzcWtSc1Q0REh6bERKOTZVRThScGNvTTZBTHlvT3VkN1MxMkZy?= =?utf-8?B?WERhV1ZsaFoyd0FUY0oxSHhOYVhKT0lBcUhnY0swc0E4R0hPQm5ZUnJNd3Y1?= =?utf-8?B?UkJmL0dRTTNpdmpOOUtITUEwdnNJSGNyWGh1V1ZMSm5VcmV5N1RUd0VyS0dq?= =?utf-8?B?SktxRFB5eUtCVm9PUzhoWW5reVNMcTR4c0xySUtPWk9jY2pRUjhZTFpaL2sv?= =?utf-8?B?OHArYWl0RUp0MHZLcG5XdTU2SFgwR0FvelRqVVRiY3lOVkpDb25qcDJhRW84?= =?utf-8?B?MjRObFFJcUlSRksyTFRpc2ZGdGhtbng0QzFyYlprQ05QYnBQRjJjeHJtSW9z?= =?utf-8?B?ekFNZlFhS0d1OU5oMDlsVFV4b1ZxWDI1bDQ2WDBPQ0o2enJra3p4UUVJdisv?= =?utf-8?Q?h/yorh+oilpeFMTBt0=3D?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB5392 Original-Authentication-Results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT045.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 6d8b8a36-8466-4673-6926-08d93f624f60 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cbpMzkf4y4BLHiiFRF/n4HHjR9SjLbYON/oDMn5zJKA0Zcsh6OfJzyFr4COzI4HLL0G5XrGoq7mySOm8o1RAS8Umq0EgYp+J78dg6SPbr1CtrMreuMJsryRdmzEq3mLd29wYAyWhBcI82ohybLyx7zBDkp06SCA8lJzPBFcYjvomBo4oiJhzRdeTzpxf1S1IgbQqgqq5bhmTL5oUVndEUX7NuABKni7dUvFI3FaIwLL9wIYKai6aeKdjT/DQD0A4iZwaAtKxsMyNbfSxd7Bm9/jL+f1H3SEEuSxu3V04P20S0JJZR583zxJtLdYEzt7Y9KlgU7EYnuHI2jG68dPwwqse6qc49+u5aSId9S4fuaB6IYNdkwy3DZDJPLE2mBYcE6II23CehXupe3iV3bua/Uz2XhyFyhu0SDTZIHnyi71cFqpbeTUwL6WNJe2q8geMIIs/5tXVUi/5POiqca1IdO78Y5XZgf1+gGUBC6EOZ6ShrBRROSS3HbDRRn2oav53tK116/Gkl/15Dk5GbwydgQ2I7+a/udPRJSyPdhfOujq8W/GFvGAPB9BLOZ6gnTYv82MoGy8K7ID3oL5KQhYIxygmJlwMHl51MVrXrWXcy0jTrtCQRN3jRWWxMTmYaxgNvDBVva6wJO42/CJNi+zZpdzLfyejOolOKVF9rU0XNlJ4/04/VIRe6eHbx5AJy3kynWE17zG9hdSKLnYRA9glPQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(39850400004)(396003)(136003)(376002)(346002)(46966006)(36840700001)(4326008)(36860700001)(82310400003)(70586007)(7696005)(70206006)(8676002)(5660300002)(47076005)(336012)(478600001)(186003)(8936002)(83380400001)(86362001)(33656002)(54906003)(356005)(53546011)(6506007)(110136005)(9686003)(52536014)(2906002)(81166007)(55016002)(82740400003)(316002)(26005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2021 03:09:41.5698 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0915e13d-4faf-49ac-35d6-08d93f62550b X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT045.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB4848 SGkgSnVsaWVuDQoNClNvcnJ5IGZvciBzbyBsb25nIHRvIHJlc3BvbmQsIGp1c3QgYmFjayBmcm9t IGEgbG9uZyBob2xpZGF5LiDwn5iJDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4g RnJvbTogSnVsaWVuIEdyYWxsIDxqdWxpZW5AeGVuLm9yZz4NCj4gU2VudDogVGh1cnNkYXksIEp1 bHkgMSwgMjAyMSAxOjQ0IEFNDQo+IFRvOiBQZW5ueSBaaGVuZyA8UGVubnkuWmhlbmdAYXJtLmNv bT47IHhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZzsNCj4gc3N0YWJlbGxpbmlAa2VybmVs Lm9yZzsgamJldWxpY2hAc3VzZS5jb20NCj4gQ2M6IEJlcnRyYW5kIE1hcnF1aXMgPEJlcnRyYW5k Lk1hcnF1aXNAYXJtLmNvbT47IFdlaSBDaGVuDQo+IDxXZWkuQ2hlbkBhcm0uY29tPg0KPiBTdWJq ZWN0OiBSZTogW1BBVENIIDIvOV0geGVuL2FybTogaW50cm9kdWNlIFBHQ19yZXNlcnZlZA0KPiAN Cj4gSGkgUGVubnksDQo+IA0KPiBPbiAwNy8wNi8yMDIxIDAzOjQzLCBQZW5ueSBaaGVuZyB3cm90 ZToNCj4gPiBJbiBvcmRlciB0byBkaWZmZXJlbnRpYXRlIHBhZ2VzIG9mIHN0YXRpYyBtZW1vcnks IGZyb20gdGhvc2UgYWxsb2NhdGVkDQo+ID4gZnJvbSBoZWFwLCB0aGlzIHBhdGNoIGludHJvZHVj ZXMgYSBuZXcgcGFnZSBmbGFnIFBHQ19yZXNlcnZlZCB0byB0ZWxsLg0KPiANCj4gSSB3b3VsZCBw cmVmZXIgaWYgdGhpcyBwYXRjaCBpcyBmb2xkZWQgaW4gdGhlIHBhdGNoIGZpcnN0IHVzaW5nIGl0 LiBUaGlzIHdpbGwgYmUNCj4gZWFzaWVyIHRvIHVuZGVyc3RhbmQgaG93IHRoaXMgZmxhZyB3aWxs IGJlIHVzZWQuDQo+IA0KPiBDaGVlcnMsDQoNClN1cmUsIEknbGwgcmUtb3JnYW5pemUgdGhpcyBj b21taXQuDQoNCj4gDQo+ID4NCj4gPiBTaWduZWQtb2ZmLWJ5OiBQZW5ueSBaaGVuZyA8cGVubnku emhlbmdAYXJtLmNvbT4NCj4gPiAtLS0NCj4gPiBjaGFuZ2VzIHYyOg0KPiA+IC0gcmVtb3ZlIHVu dXNlZCByZXNlcnZlZCBmaWVsZCBpbiBzdHJ1Y3QgcGFnZV9pbmZvDQo+ID4gLSByZW1vdmUgdW51 c2VkIGhlbHBlciBwYWdlX2dldF9yZXNlcnZlZF9vd25lciBhbmQNCj4gPiBwYWdlX3NldF9yZXNl cnZlZF9vd25lcg0KPiA+IC0tLQ0KPiA+ICAgeGVuL2luY2x1ZGUvYXNtLWFybS9tbS5oIHwgMyAr KysNCj4gPiAgIDEgZmlsZSBjaGFuZ2VkLCAzIGluc2VydGlvbnMoKykNCj4gPg0KPiA+IGRpZmYg LS1naXQgYS94ZW4vaW5jbHVkZS9hc20tYXJtL21tLmggYi94ZW4vaW5jbHVkZS9hc20tYXJtL21t LmgNCj4gaW5kZXgNCj4gPiAwYjdkZTMxMDJlLi43MDM0ZmFlMWI2IDEwMDY0NA0KPiA+IC0tLSBh L3hlbi9pbmNsdWRlL2FzbS1hcm0vbW0uaA0KPiA+ICsrKyBiL3hlbi9pbmNsdWRlL2FzbS1hcm0v bW0uaA0KPiA+IEBAIC0xMDgsNiArMTA4LDkgQEAgc3RydWN0IHBhZ2VfaW5mbw0KPiA+ICAgICAv KiBQYWdlIGlzIFhlbiBoZWFwPyAqLw0KPiA+ICAgI2RlZmluZSBfUEdDX3hlbl9oZWFwICAgICBQ R19zaGlmdCgyKQ0KPiA+ICAgI2RlZmluZSBQR0NfeGVuX2hlYXAgICAgICBQR19tYXNrKDEsIDIp DQo+ID4gKyAgLyogUGFnZSBpcyByZXNlcnZlZCAqLw0KPiA+ICsjZGVmaW5lIF9QR0NfcmVzZXJ2 ZWQgICAgIFBHX3NoaWZ0KDMpDQo+ID4gKyNkZWZpbmUgUEdDX3Jlc2VydmVkICAgICAgUEdfbWFz aygxLCAzKQ0KPiA+ICAgLyogLi4uICovDQo+ID4gICAvKiBQYWdlIGlzIGJyb2tlbj8gKi8NCj4g PiAgICNkZWZpbmUgX1BHQ19icm9rZW4gICAgICAgUEdfc2hpZnQoNykNCj4gPg0KPiANCj4gLS0N Cj4gSnVsaWVuIEdyYWxsDQoNCg0KQ2hlZXJzDQoNCi0tDQpQZW5ueSBaaGVuZw0K From xen-devel-bounces@lists.xenproject.org Mon Jul 05 03:17:10 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Jul 2021 03:17:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149762.277004 (Exim 4.92) (envelope-from ) id 1m0F6X-0000Z1-TN; Mon, 05 Jul 2021 03:17:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149762.277004; Mon, 05 Jul 2021 03:17:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0F6X-0000Yu-Pd; Mon, 05 Jul 2021 03:17:05 +0000 Received: by outflank-mailman (input) for mailman id 149762; Mon, 05 Jul 2021 03:17:05 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0F6X-0000Yo-0w for xen-devel@lists.xenproject.org; Mon, 05 Jul 2021 03:17:05 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (unknown [40.107.22.52]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 32530c8a-8f39-421c-8548-e82f639e6859; Mon, 05 Jul 2021 03:17:02 +0000 (UTC) Received: from AM5PR0701CA0063.eurprd07.prod.outlook.com (2603:10a6:203:2::25) by DBBPR08MB4316.eurprd08.prod.outlook.com (2603:10a6:10:c6::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.23; Mon, 5 Jul 2021 03:16:59 +0000 Received: from AM5EUR03FT027.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:2:cafe::f8) by AM5PR0701CA0063.outlook.office365.com (2603:10a6:203:2::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4308.8 via Frontend Transport; Mon, 5 Jul 2021 03:16:59 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT027.mail.protection.outlook.com (10.152.16.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.22 via Frontend Transport; Mon, 5 Jul 2021 03:16:59 +0000 Received: ("Tessian outbound 80741586f868:v97"); Mon, 05 Jul 2021 03:16:59 +0000 Received: from 1337886d1385.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id BF0E60CF-C531-4486-B880-0FA62D4363E7.1; Mon, 05 Jul 2021 03:16:49 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 1337886d1385.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 05 Jul 2021 03:16:49 +0000 Received: from VE1PR08MB5215.eurprd08.prod.outlook.com (2603:10a6:803:10a::33) by VI1PR08MB5392.eurprd08.prod.outlook.com (2603:10a6:803:131::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.23; Mon, 5 Jul 2021 03:16:47 +0000 Received: from VE1PR08MB5215.eurprd08.prod.outlook.com ([fe80::2807:2ff9:e371:2918]) by VE1PR08MB5215.eurprd08.prod.outlook.com ([fe80::2807:2ff9:e371:2918%7]) with mapi id 15.20.4287.033; Mon, 5 Jul 2021 03:16:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 32530c8a-8f39-421c-8548-e82f639e6859 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jnVNcCm/QzGCSGwzbXT6ZdtSblAWVZ7Mm2ZbLdBHPQA=; b=08BybUnxuXT78ffxsnn17m4+lTNHNxdnrf+O2qtGVEVkI1vd2IDK49M0LbEjRErj5YXZSlc4JpGA9sK5nj2uYT4nrx10h70HcS92ihLcsgk+a38iWpnJ3Y3PKQwu6sR2qhZ8zQDWcUHJftU58KMFKKIcQBLu9oDAMaS2eU7eO7Y= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FqoC8OqlGTDVXRCFytDoLvJ1iyUZzOy683TXJIEHSJkuoLnagbyz43uXIEQFhz1Nocq9xhN5LqNtVMpHssQjKT3toct8yXH/Jh2xuvJ1vtCLpVCNT5r6ASybE9epwBgY1XVG9udn2OG92e69QVTfXiHsej3YWMLSRArrwP+wvv4XdLG66F3Esi9X/07bGhsuZEJH1Z+KzPhtpDO5tJH3G71/lnfBstTikxNDFfus5hOneq9+6wl7vbUCOpaMjtqxCs5DN4vKLu/tXFcDV5jtvqIVkjbbB08kNRagw235vgMc+Q5FJvoy0NG8Mn4aBYiF63TzRj9ghlCeToLGFtcs5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jnVNcCm/QzGCSGwzbXT6ZdtSblAWVZ7Mm2ZbLdBHPQA=; b=ZayfpNC8QPWg/VyMRdsxPVLrefIt/bzWMjyAF8VHycyAR26OFsAQCO68cJwtOrsstRFpoUB/yEIhRfgUUzs2z9OnhM8FBB15OJXJ+Nl2V2hQuXMX24iq3KheEeOhYJpZaDlWGT/Se+DPH6vHRGWB/ByrLSqGoYmClnsnWG2jOL60jhK8y9AtK87YE3j0NwFK7vAmAhj+gXZ0X82mgJ4S4VPKK4rrR70tzUjXfgGpumm65MeCiY18Rpi1cAHysW1zS5wJKQ3hMkoI2NyHisWOHYbRWSdKzGsgzy+G1TLT1P93kD++Jgtxy/QpVaQCcJsZz9ikLUtpkfKp80+J32uUsw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jnVNcCm/QzGCSGwzbXT6ZdtSblAWVZ7Mm2ZbLdBHPQA=; b=08BybUnxuXT78ffxsnn17m4+lTNHNxdnrf+O2qtGVEVkI1vd2IDK49M0LbEjRErj5YXZSlc4JpGA9sK5nj2uYT4nrx10h70HcS92ihLcsgk+a38iWpnJ3Y3PKQwu6sR2qhZ8zQDWcUHJftU58KMFKKIcQBLu9oDAMaS2eU7eO7Y= From: Penny Zheng To: Julien Grall , "xen-devel@lists.xenproject.org" , "sstabellini@kernel.org" , "jbeulich@suse.com" CC: Bertrand Marquis , Wei Chen Subject: RE: [PATCH 3/9] xen/arm: introduce CONFIG_STATIC_ALLOCATION Thread-Topic: [PATCH 3/9] xen/arm: introduce CONFIG_STATIC_ALLOCATION Thread-Index: AQHXW0b0CeS4ToPVJE2MjFHfl516uass+MuAgAbnTUA= Date: Mon, 5 Jul 2021 03:16:46 +0000 Message-ID: References: <20210607024318.3988467-1-penny.zheng@arm.com> <20210607024318.3988467-4-penny.zheng@arm.com> <2b604aba-1d12-7957-ad9b-114f6ad1f857@xen.org> In-Reply-To: <2b604aba-1d12-7957-ad9b-114f6ad1f857@xen.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 485948836F92834993335243B6FEA32D.0 x-checkrecipientchecked: true Authentication-Results-Original: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com; x-originating-ip: [203.126.0.113] x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: f6b452ad-3003-43e5-8096-08d93f635a30 x-ms-traffictypediagnostic: VI1PR08MB5392:|DBBPR08MB4316: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:3513;OLM:3513; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 4QP0DlyVVWOzZTecZYA5Rbph7fC5qXWk9Mbj9snnY8NpBXdWWBFNvmTOTnWVxt3oueKIgeDd7nlGoX4YVVmgMaV2JYbtWYozbq9BVrFp1WQDMy2T0emIywmkmwsOhDRWSzwTdM0qU7aHg6vkw4MyBlgXE763zsmPKMLfYsLOuMHQwsk2YBlqTIVz5zmgv28rsylBPfH4TObEuZshHzSiUdE1+ijV+BisFIqMTyhXhG8n8uVum3mcxQFNJVtGCVYDUOk0AvWLncs4Cgjk9FtRZEeW6ZC1HS0FLU9Q2W9HerumVYCB1Ejx0U/1iViHpgP5EJTvgXKYvxc6jXfeVIrVxuSbkwD2slZXgdISurKYaSztkzRj8XuBYr13RIdYLBP9yV3nrfZnxbkC0HRgT2nr/KVfBzUJPRA1Nf/uHV+t06zwfrQU/rRxSsyhhcpC1i6ztKCKw5ozv34wug4dj35ar3YJMBUvXfXA4XL6127ZPEQEdmfVu4gYFWXnk79jBnJL1RqtJaiA1nBBg453AuV7U3EffCiO7tuG+Ag44QKvFs9yBYUOgnyDqC+pNu2WChnif4qpthWqBNs6y/NVtV4BdGIeRJVR1CvcuxDNIePcrhVTxndPbKKGqf/6tvk18SbWWlTUzW+i6oP5ok7WQhG01Q== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR08MB5215.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(346002)(396003)(376002)(136003)(39850400004)(71200400001)(54906003)(110136005)(316002)(4326008)(478600001)(2906002)(33656002)(8936002)(6506007)(53546011)(5660300002)(7696005)(186003)(76116006)(66946007)(66476007)(66556008)(66446008)(26005)(55016002)(38100700002)(86362001)(122000001)(64756008)(83380400001)(9686003)(8676002)(52536014);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?VDUzOTFvY3ZmRTZZUWpkbnVuUis2SGk2VEN0bTNWYTZicTgvUTdOT2g0ankv?= =?utf-8?B?czJTcFNwb2tzT2lqaTluczZSVy8yTms0ZW94YTFuL0JNSFBqUDJ3OTZBMklM?= =?utf-8?B?aUFoYzlOclU3M01za00zZXV0ZEJiME96bjJzS3dwdUpCdy9TMm1BZXVNWDFo?= =?utf-8?B?bGI2cTRJZzZXWlBSU2hzYWk4aWk4MFhFQjl4aWNvd1BGL3ZIWU5aeC9tNHNC?= =?utf-8?B?MW00bWR2R0JRY1BESklraVNJYnlIeTdranl2cy9qNVZEUUNiQnJuUHFBamhY?= =?utf-8?B?Vnc2djVYV1VDZ1RyN014RE9mVXNZTU9OclJ5Y2I4S2tsbU8zZHJvcjhyNkVB?= =?utf-8?B?Y01HMlczaE9ESzlVcW5hend2cGJTN01tekZYM212TW9Mcyt2Ymp6VGVXdTU4?= =?utf-8?B?RFBodHFWT1V3ZTkzODZseDRSbFFOeG1DSzNDeGsrM3pEMGoxRExDcUVDT0JO?= =?utf-8?B?VjVuOWZTRHZvNjA4M3dKZytxT3hYY3pNWDlncDBaaERNTW1meGNMWWF0UDht?= =?utf-8?B?Z2dIZWlTUGpxQy9iMWVCdnJUTjU0V054dkRrMGlpQXd3Z05LOTh3Rmo5WWpC?= =?utf-8?B?NjdWMkNIUDBXcGJwRCtLUWRvQVJDU1ljMFJiOWMzdG9kQmhRd1Y2cWZVQ2ln?= =?utf-8?B?WmMrZE1ONkM5N0lOdWo0K3dlWWhHUFNVNGEzVysxSGpYYmVFMlYzR1RNQUV2?= =?utf-8?B?TUVWZUk0ODhxazd0SHV6RGcrWHdMdHVNVWhlenpRTlYydDB2bnNnRDlpZGJX?= =?utf-8?B?MTJsSjJ3VHRMaXByaXQ3SmxTS1o3UGIzZGNFa2kwYWRra29hamZ4UWZwb1RK?= =?utf-8?B?WldvN2VSb1FRUW1CL3cyMVJDZWRYUHBPQjFIY1h4MDZWNmtWak9tSTc1NlB5?= =?utf-8?B?NnRFQi9EQlExMUIyVmRUNVFIMTNLR1c0eWVpOExiVVZvbG9kRkhubllPL1Jh?= =?utf-8?B?S0dLMnpQRTMyV2dlaEtqMVMwWklvMFFoVjJYeE15NmNoa3k5U0RLQ0VEaUtP?= =?utf-8?B?SzZkVXQ1RitReHk3aHZ4OFlOUjRyQ09TVldzY2RrZXlMVU44dVh1eDlXSE1x?= =?utf-8?B?U1JuRDBuSlVTVVZZYzhjRkhsNFBhc1hFK1lUbUtBRTQ3TmNBRnNybDMwb2J0?= =?utf-8?B?SEVPbFIrb2NWczNQS2UrVzE2K3YwQ2QxVWVMd01aSnpiOFQzUTN0YU1KYUM5?= =?utf-8?B?czJzTmZZQ0NEZi96MkgrS0VkWDFiYzJJOWtDeC9neG41dy9HVXpsdlg0Y1FQ?= =?utf-8?B?T2FlcEo3aTNBL01yaFV2NXZOSmg4Q29iaHRnKzRndWdkOUdLbi9BSi9zNjFV?= =?utf-8?B?K0p6cmFmZlg0VGVsUmFpRFRYTUxYZU5nckY4bmhwMnU0RFVDOUthQTNBcEVn?= =?utf-8?B?MlppRG1aZi96WEp6Y2N6VUVtSUlJVzFYYkVrNmw2Tm5lSWJUMTgxSkFMbm9q?= =?utf-8?B?R3FGV202MzE1MDhmUHRKa01YVno4cVcyNkNsNXVRWE5zMXU1L0NJM3lQSUxa?= =?utf-8?B?YldtaTV3MjFjL2xqOTF0UWpJSVhtN1Y4dmVEcklWOXBJdU1ZVUZFdE5sVkJy?= =?utf-8?B?WmxoR0hXYlZxcVJJNUxUV20vRjNLSkFRWWJCelBqZGg3Rm9JSkRyY091M0VZ?= =?utf-8?B?eHNjK1pZVFVlM2JkM2ZzYXhHUjM5VHVsVDhQTHNNODhnY2FqSDJmMXVYWWxQ?= =?utf-8?B?YkMvTjI2eXYreHBwTEl3cFp4Ri84cXlGcGUwL0h2WSszVVdMUmtxU2xSRzhK?= =?utf-8?Q?I7BgtregN+UwJa4Ob2lvPK76GpMmb3REG+mnH7N?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB5392 Original-Authentication-Results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT027.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 108bf1b6-4e62-492e-84fd-08d93f6352b2 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4OaXcgDA4vVXfzh9CxS7izIOmnkIclINveAoTs4V3q43aa2QNX86wj+3RPl5kt0ewEfguRFyuyS8ikiMJkzQT6Ov7PQLqj7Wlycy7FSmUBHobzG5quHpbUFeBvZrnClo4e+wU5Y819tyIx0UFcrQkftpGRa/45yp81SunKWSQQFe7AtECk+h+jF8suKcItRd0LEQ8FzvkCefkjp3/kbpnVNB/cadU3/HSvZcRVL1uTlVwYa+oK/xhm2+p3cyLwvLw382OJgyDMqWe1O62MyGr9P4wC70MB6Qaf4CX95/cO7TCESTYf8EFEShhfL43S9yABGpHnmoehYt3eapOlXVlkvRbRTySQcR/Qvi3uoDyzRRf0PBrHfX3QgJGx8pMPmpIgpj/osHHpm5eo3lYsdFEEGMxNq78mfvi1O/oBc4ULyJ/joYI0++3EGQrng0HiiQlJ/p+hlkQIQOHinCXzVoyxCtcsWgtY+zHzM6YpnWGMbaHvwD6DAGXA3giKuZn/X6KUr9bPKD1xK4Gyzs8yxkbuehfOWLTTQn3ZJBKcWcLfEtgNYJsx/PSoX1aNKGwARep1IVaWZ343KOjZ7+pKMcosET/kULzcKYtG4ta4W1BJ3AINFAVPJzAsbN53EkgTv44y4aOqpbiW680u3EzYM2yJSnGkGIxdJ71LuzaM1mKqciib5bfEKwfI7NY1fme2GHQxwmd/GUsoy5Rpw7pNrxog== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(396003)(39850400004)(136003)(346002)(376002)(46966006)(36840700001)(52536014)(47076005)(2906002)(82740400003)(70586007)(186003)(70206006)(82310400003)(36860700001)(86362001)(110136005)(5660300002)(8936002)(7696005)(83380400001)(33656002)(8676002)(336012)(53546011)(55016002)(54906003)(6506007)(9686003)(316002)(478600001)(4326008)(26005)(81166007)(356005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2021 03:16:59.6446 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f6b452ad-3003-43e5-8096-08d93f635a30 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT027.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB4316 SGkgSnVsaWVuDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogSnVsaWVu IEdyYWxsIDxqdWxpZW5AeGVuLm9yZz4NCj4gU2VudDogVGh1cnNkYXksIEp1bHkgMSwgMjAyMSAx OjQ1IEFNDQo+IFRvOiBQZW5ueSBaaGVuZyA8UGVubnkuWmhlbmdAYXJtLmNvbT47IHhlbi1kZXZl bEBsaXN0cy54ZW5wcm9qZWN0Lm9yZzsNCj4gc3N0YWJlbGxpbmlAa2VybmVsLm9yZzsgamJldWxp Y2hAc3VzZS5jb20NCj4gQ2M6IEJlcnRyYW5kIE1hcnF1aXMgPEJlcnRyYW5kLk1hcnF1aXNAYXJt LmNvbT47IFdlaSBDaGVuDQo+IDxXZWkuQ2hlbkBhcm0uY29tPg0KPiBTdWJqZWN0OiBSZTogW1BB VENIIDMvOV0geGVuL2FybTogaW50cm9kdWNlIENPTkZJR19TVEFUSUNfQUxMT0NBVElPTg0KPiAN Cj4gSGkgUGVubnksDQo+IA0KPiBPbiAwNy8wNi8yMDIxIDAzOjQzLCBQZW5ueSBaaGVuZyB3cm90 ZToNCj4gPiBGb3Igbm93LCBzaW5jZSB0aGUgZmVhdHVyZSBvZiBEb21haW4gb24gU3RhdGljIEFs bG9jYXRpb24gaXMgb25seQ0KPiA+IHN1cHBvcnRlZCBvbiBBUk0gQXJjaGl0ZWN0dXJlLCB0aGlz IGNvbW1pdCBpbnRyb2R1Y2VzIG5ldw0KPiA+IENPTkZJR19TVEFUSUNfQUxMT0NBVElPTiB0byBh dm9pZCBicmluZ2luZyBkZWFkIGNvZGVzIGluIG90aGVyIGFyY2hzLg0KPiANCj4gU2ltaWxhcmx5 IHRvIHBhdGNoICMyLCBJIHRoaW5rIGl0IHdvdWxkIGJlIGJldHRlciB0byBpbnRyb2R1Y2UgdGhp cyBLY29uZmlnIHdoZW4NCj4gaXQgaXMgdXNlZCBvciBhZnRlciB0aGUgY29tbW9uIGNvZGUgaXMg aW50cm9kdWNlZC4gVGhpcyB3b3VsZCBwcmV2ZW50IGRlYWQNCj4gS2NvbmZpZy4NCj4gDQoNCnN1 cmUsIEknbGwgcmVtb3ZlIHRoaXMgY29tbWl0LCBhbmQgY29tYmluZSBpdCB3aXRoIHRoZSBjb2Rl cyB3aGVyZSB0aGlzIGNvbmZpZyBpcyBmaXJzdGx5IHVzZWQuDQoNCkNoZWVycw0KDQo+IENoZWVy cywNCj4gDQo+ID4gU2lnbmVkLW9mZi1ieTogUGVubnkgWmhlbmcgPHBlbm55LnpoZW5nQGFybS5j b20+DQo+ID4gLS0tDQo+ID4gY2hhbmdlcyB2MjoNCj4gPiAtIG5ldyBjb21taXQNCj4gPiAtLS0N Cj4gPiAgIHhlbi9hcmNoL2FybS9LY29uZmlnIHwgMyArKysNCj4gPiAgIDEgZmlsZSBjaGFuZ2Vk LCAzIGluc2VydGlvbnMoKykNCj4gPg0KPiA+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vS2Nv bmZpZyBiL3hlbi9hcmNoL2FybS9LY29uZmlnIGluZGV4DQo+ID4gZWNmYTY4MjJlNC4uZjE2NWRi OGVjZCAxMDA2NDQNCj4gPiAtLS0gYS94ZW4vYXJjaC9hcm0vS2NvbmZpZw0KPiA+ICsrKyBiL3hl bi9hcmNoL2FybS9LY29uZmlnDQo+ID4gQEAgLTI3OCw2ICsyNzgsOSBAQCBjb25maWcgQVJNNjRf RVJSQVRVTV8xMjg2ODA3DQo+ID4NCj4gPiAgIAkgIElmIHVuc3VyZSwgc2F5IFkuDQo+ID4NCj4g PiArY29uZmlnIFNUQVRJQ19BTExPQ0FUSU9ODQo+ID4gKyAgICBkZWZfYm9vbCB5DQo+ID4gKw0K PiA+ICAgZW5kbWVudQ0KPiA+DQo+ID4gICBjb25maWcgQVJNNjRfSEFSREVOX0JSQU5DSF9QUkVE SUNUT1INCj4gPg0KPiANCj4gLS0NCj4gSnVsaWVuIEdyYWxsDQoNCi0tDQpQZW5ueSBaaGVuZw0K From xen-devel-bounces@lists.xenproject.org Mon Jul 05 04:47:18 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Jul 2021 04:47:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149769.277015 (Exim 4.92) (envelope-from ) id 1m0GVa-0000Lv-FQ; Mon, 05 Jul 2021 04:47:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149769.277015; Mon, 05 Jul 2021 04:47:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0GVa-0000Lo-AL; Mon, 05 Jul 2021 04:47:02 +0000 Received: by outflank-mailman (input) for mailman id 149769; Mon, 05 Jul 2021 04:47:00 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0GVY-0000Li-OF for xen-devel@lists.xenproject.org; Mon, 05 Jul 2021 04:47:00 +0000 Received: from smtp-out1.suse.de (unknown [195.135.220.28]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 07de7eac-dd4c-11eb-8438-12813bfff9fa; Mon, 05 Jul 2021 04:46:59 +0000 (UTC) Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 12390226C8; Mon, 5 Jul 2021 04:46:58 +0000 (UTC) Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap1.suse-dmz.suse.de (Postfix) with ESMTPS id DADF013418; Mon, 5 Jul 2021 04:46:57 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap1.suse-dmz.suse.de with ESMTPSA id 2YCAM8GO4mAjBgAAGKfGzw (envelope-from ); Mon, 05 Jul 2021 04:46:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 07de7eac-dd4c-11eb-8438-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1625460418; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/Km2dS5zjKyg+Dq8IqCDYsh2P1T0EACyZgZYYwwx928=; b=tyLD2F5ijKTx1xkWBZDv4m3bJpYpZ5WKiUb4YmB/TjJdDl3u2tkBl7NR1ZPs7AE47Envur eYbw2Ndwna/fewJCkVWM9KjbgtgJtVJzqKv32VfS6BNcyPYeP/qqj/NMtd0PjdIXr6FI/s Oznrk/SLFcqssUbVo7kuz9CataSzRjA= Subject: Re: [XEN PATCH] MAINTAINERS: Updating after change to tools/include/ To: Anthony PERARD , xen-devel@lists.xenproject.org Cc: Ian Jackson , Wei Liu References: <20210701155232.792978-1-anthony.perard@citrix.com> From: Juergen Gross Message-ID: <3b617ddd-773a-5321-9485-8815bdc69e9a@suse.com> Date: Mon, 5 Jul 2021 06:46:57 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <20210701155232.792978-1-anthony.perard@citrix.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="U91K0s5BeczmSENTuuaFlbFQXq0DOqQEB" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --U91K0s5BeczmSENTuuaFlbFQXq0DOqQEB Content-Type: multipart/mixed; boundary="kQcxdNuidNUnHcJvWJdR0HPSW1XxKOQo5"; protected-headers="v1" From: Juergen Gross To: Anthony PERARD , xen-devel@lists.xenproject.org Cc: Ian Jackson , Wei Liu Message-ID: <3b617ddd-773a-5321-9485-8815bdc69e9a@suse.com> Subject: Re: [XEN PATCH] MAINTAINERS: Updating after change to tools/include/ References: <20210701155232.792978-1-anthony.perard@citrix.com> In-Reply-To: <20210701155232.792978-1-anthony.perard@citrix.com> --kQcxdNuidNUnHcJvWJdR0HPSW1XxKOQo5 Content-Type: multipart/mixed; boundary="------------A9A438DAC6AA6759B1DDF9A9" Content-Language: en-US This is a multi-part message in MIME format. --------------A9A438DAC6AA6759B1DDF9A9 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 01.07.21 17:52, Anthony PERARD wrote: > The LIBS section doesn't mention the headers associated with the > libraries, same for LIBXENLIGHT section. >=20 > They aren't any ':' in other section names, so remove it. >=20 > Fixes: 4664034cdc72 ("tools/libs: move official headers to common direc= tory") > Fixes: f7079d7ef69f ("MAINTAINERS: add myself as tools/libs reviewer") > Signed-off-by: Anthony PERARD Reviewed-by: Juergen Gross Juergen --------------A9A438DAC6AA6759B1DDF9A9 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Description: OpenPGP public key Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------A9A438DAC6AA6759B1DDF9A9-- --kQcxdNuidNUnHcJvWJdR0HPSW1XxKOQo5-- --U91K0s5BeczmSENTuuaFlbFQXq0DOqQEB Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmDijsEFAwAAAAAACgkQsN6d1ii/Ey/Z /ggAiVENLbIp6/VjelCwAKngvUtq+nYuA/58tref4RbxSmBMje0uEeHC9QCf04175uJX92Y3fb9z q0+yYaJqvKKCbpdV1HNUJsjrgKCQdnmmfugW+IQUVq29P159jEuZXyxWqvfnMvyQ3GOxjBwJxGl5 3a8DZZcQ/5bHpJ4JqqbWt9n9Pb/a8IyVsPTFec53CO2k5akSsfiFiXveesFOh9HYOpEN9REoQaqn rtNuSjsoFsE+39UAG9rT3yV17t909NBCjHslG/X6fTa7FkOxpaJnga7qfRGjrvK/CU2zDFGSI8zj G+OW8+VMok/hy6J7w9cLGsjgzl7h8vqqqz3zplRl0w== =F9Z7 -----END PGP SIGNATURE----- --U91K0s5BeczmSENTuuaFlbFQXq0DOqQEB-- From xen-devel-bounces@lists.xenproject.org Mon Jul 05 05:07:01 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Jul 2021 05:07:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149776.277026 (Exim 4.92) (envelope-from ) id 1m0Goq-0002vS-33; Mon, 05 Jul 2021 05:06:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149776.277026; Mon, 05 Jul 2021 05:06:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0Gop-0002vL-Vl; Mon, 05 Jul 2021 05:06:55 +0000 Received: by outflank-mailman (input) for mailman id 149776; Mon, 05 Jul 2021 05:06:54 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0Goo-0002vB-Gx; Mon, 05 Jul 2021 05:06:54 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0Goo-0006W5-9Q; Mon, 05 Jul 2021 05:06:54 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0Gon-00088P-Tl; Mon, 05 Jul 2021 05:06:54 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1m0Gon-0000RV-TD; Mon, 05 Jul 2021 05:06:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=W0l0vfoWX20htbHCM2fNfAgbjfRtRENZsHYGVPct0aw=; b=UQTjRqSI07Ul959yUqTwwrdvOr hO/oW4qXLFNMOlmZeS+KR92ZkgfDr0wqzv/bmcDuBv7ZtfRNU+nlXpOabClZQt36aeEPSuaUOdJp7 gE5VlMeN53lmKhhSfXvxe8Kus+Z2MoSmyyuXvWgLIuzSzQTpZE+HL45tBfWgcV0W6Xe8=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 163303: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=711c0418c8c1ce3a24346f058b001c4c5a2f0f81 X-Osstest-Versions-That: qemuu=73c8bf4ccff8951d228b8a0d49968c56e32da4de From: osstest service owner Date: Mon, 05 Jul 2021 05:06:53 +0000 flight 163303 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/163303/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 163299 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 163299 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 163299 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 163299 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 163299 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 163299 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 163299 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: qemuu 711c0418c8c1ce3a24346f058b001c4c5a2f0f81 baseline version: qemuu 73c8bf4ccff8951d228b8a0d49968c56e32da4de Last test of basis 163299 2021-07-04 13:37:55 Z 0 days Testing same since 163303 2021-07-04 21:08:01 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: BALATON Zoltan Finn Thain Mark Cave-Ayland Peter Maydell Philippe Mathieu-Daudé jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 73c8bf4ccf..711c0418c8 711c0418c8c1ce3a24346f058b001c4c5a2f0f81 -> upstream-tested From xen-devel-bounces@lists.xenproject.org Mon Jul 05 05:22:34 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Jul 2021 05:22:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149784.277040 (Exim 4.92) (envelope-from ) id 1m0H3r-0005DA-Hp; Mon, 05 Jul 2021 05:22:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149784.277040; Mon, 05 Jul 2021 05:22:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0H3r-0005D3-EE; Mon, 05 Jul 2021 05:22:27 +0000 Received: by outflank-mailman (input) for mailman id 149784; Mon, 05 Jul 2021 05:22:26 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0H3q-0005Cx-4J for xen-devel@lists.xenproject.org; Mon, 05 Jul 2021 05:22:26 +0000 Received: from EUR03-AM5-obe.outbound.protection.outlook.com (unknown [40.107.3.81]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id fa53cf44-dd50-11eb-8439-12813bfff9fa; Mon, 05 Jul 2021 05:22:23 +0000 (UTC) Received: from DU2PR04CA0255.eurprd04.prod.outlook.com (2603:10a6:10:28e::20) by DB7PR08MB3628.eurprd08.prod.outlook.com (2603:10a6:10:44::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.31; Mon, 5 Jul 2021 05:22:21 +0000 Received: from DB5EUR03FT054.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:28e:cafe::ef) by DU2PR04CA0255.outlook.office365.com (2603:10a6:10:28e::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.22 via Frontend Transport; Mon, 5 Jul 2021 05:22:21 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT054.mail.protection.outlook.com (10.152.20.248) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.22 via Frontend Transport; Mon, 5 Jul 2021 05:22:21 +0000 Received: ("Tessian outbound 2e56506fe389:v97"); Mon, 05 Jul 2021 05:22:21 +0000 Received: from f073af98f6a2.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id E3C03425-9106-426A-BC87-38A17EA73601.1; Mon, 05 Jul 2021 05:22:11 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f073af98f6a2.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 05 Jul 2021 05:22:11 +0000 Received: from VE1PR08MB5215.eurprd08.prod.outlook.com (2603:10a6:803:10a::33) by VI1PR08MB5535.eurprd08.prod.outlook.com (2603:10a6:803:13e::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4264.19; Mon, 5 Jul 2021 05:22:07 +0000 Received: from VE1PR08MB5215.eurprd08.prod.outlook.com ([fe80::2807:2ff9:e371:2918]) by VE1PR08MB5215.eurprd08.prod.outlook.com ([fe80::2807:2ff9:e371:2918%7]) with mapi id 15.20.4287.033; Mon, 5 Jul 2021 05:22:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fa53cf44-dd50-11eb-8439-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2OGhvD8CfzA774M3J3ivX1/+nTSAE75dy61AKqLYvS8=; b=8fGFTknBODM4oK0YtE0sOx9A5MR6+EeNvOBGMGvp7G3BBJAjT1X6ZNaPq055E2u18yH35+/dXWssQR4eX5gobTwu/nl6M3eouk3Rv+FI6ypj9BnqpBnFAjFaQFOljOsnuFfql72S8cxLHUpVuVbsVEMQtMWi3qeWIe98+C9jJ5E= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=J9Z7gKZZrhJenUcIadU2b6knDTGDYZ67kDVeqNlLzAZt/JlmcCgeQXLSuHRe+M2fSxlRKv3MmZbl9pk6KAnvrEcZs/5wTrZKbrymkBWEswjyjGZCERBHt04h9Vv5VTKflf1Z3qJpX8D/JgM0QD+3mQrHCBlniPPK+Y5zERa0Qpw6PlfzGuAw4b/ilxHWrQJ45kizsrs+8motvwEJiCr+5miYox4cHpLiR1HSAAL2u49KqTRXpfv9IOCZ45H/ODWpVrMoU8z3keJq1fv+5YA2+noPi7rj/w5rtwoJSlsj14cKOjIOXhLIuCx15RN6ggvmuL3OwpRv8e3+z8m49uApZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2OGhvD8CfzA774M3J3ivX1/+nTSAE75dy61AKqLYvS8=; b=M0UMzMWdzkGfhPCrl8TcIJE+ObcOmN5+me6xZ3oDR8Y2/o4Y2YSxT+8OR80+B2DEcnmMcNZ8+H+LSXAHt4fuDoKmu288SD0pGsNQrQJDo0Vm2Kb8IsZLwWDgjpMzHN6Y21+aRjAlfi6g5WiVRRuIakK/dAJOAkRJayYIwe3ifNHfboSCgno5O8jjZv4TQcAE10F5nnqYQrK8W81zLavCZ2tav18++w9iXhP6Y9UzuCJiaxv8i97v32Fpd45o7Rc4gIZIyRHlg3NQNcDOzb95JcuueEGiUZ0GT7MD9f3BhFo5en3e+OTaVvTRICquoYp0Sv4If+lP9xy/OeIcLYiITg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2OGhvD8CfzA774M3J3ivX1/+nTSAE75dy61AKqLYvS8=; b=8fGFTknBODM4oK0YtE0sOx9A5MR6+EeNvOBGMGvp7G3BBJAjT1X6ZNaPq055E2u18yH35+/dXWssQR4eX5gobTwu/nl6M3eouk3Rv+FI6ypj9BnqpBnFAjFaQFOljOsnuFfql72S8cxLHUpVuVbsVEMQtMWi3qeWIe98+C9jJ5E= From: Penny Zheng To: Julien Grall , Jan Beulich CC: Bertrand Marquis , Wei Chen , "xen-devel@lists.xenproject.org" , "sstabellini@kernel.org" Subject: RE: [PATCH 4/9] xen/arm: static memory initialization Thread-Topic: [PATCH 4/9] xen/arm: static memory initialization Thread-Index: AQHXW0b3OiAcoe7xDE2AVcNY0dwUCqsNAWAAgB/3qYCABuqiQA== Date: Mon, 5 Jul 2021 05:22:07 +0000 Message-ID: References: <20210607024318.3988467-1-penny.zheng@arm.com> <20210607024318.3988467-5-penny.zheng@arm.com> <7f77349f-015e-83d3-d646-af9897e31348@xen.org> In-Reply-To: <7f77349f-015e-83d3-d646-af9897e31348@xen.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 7786580DF9C5D843A331F94601885256.0 x-checkrecipientchecked: true Authentication-Results-Original: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com; x-originating-ip: [203.126.0.113] x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: f8ef3700-517e-4836-4def-08d93f74dd79 x-ms-traffictypediagnostic: VI1PR08MB5535:|DB7PR08MB3628: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:8882;OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: a/wPqC2HRjyacr7JbeXWqkVzwT994y1wJaAvJjcNLoq7xbZsKqCdgdxllfgWdmuQTKHXoMyfDkZZGKNqXNJYfw8Z7rQJgGdxvzC1fNTbgE116dgRTArO59p4zsKzIG0KmawHWUypZ6Kc0DVFThjY5aCPhUG3C2YFjH/Jj2H1JRmEBWATEmKehTiKZUH5tJCHLVYonzyso5vEfhsNmGfhAUp5wq8eoI9058JcfScmytJltMYzkE7wLA67ouwVGrd1RmXwb4eW7QPLlIDUGahPkk2McEh43cTh0hzTpmtmbRj4zM+tQltYlRg2as/W+DVGg50uAxe5L2ZtRtv4txxx/XVVNIQrzj4SSXVOzzA53kKUsEwnrRAdcd8PW0LJEXWym55AdpmpFSZXvp6TXDZ/75t8qjGN1uuEhJN4jCzWqqqcFQICvt4AqBfEUhkPS4w+Pq6tiRAU1Pqxh6N/eMlhooBVTPlqqEFYd38vjbwNn0bxucHg+2FnzEfMqOYVtTQ7mmThkGyM1r8LQeMc1euRtdb4rMinhMVwxNO/BQCpmG3bo+/MeQ44mUQf6FHE1DsbbRmT8LtdN/16ITFL++rKpDGddiAMs0EmKZBNYIiJEWdA/C9yjBxBtjux1ux5zVbg/zDUvq0jCP2F7xdQU7I8xw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR08MB5215.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(376002)(346002)(366004)(39850400004)(396003)(5660300002)(7696005)(8936002)(478600001)(6506007)(66946007)(66446008)(66476007)(53546011)(66556008)(64756008)(26005)(33656002)(54906003)(8676002)(4326008)(76116006)(71200400001)(122000001)(55016002)(9686003)(110136005)(86362001)(83380400001)(38100700002)(2906002)(52536014)(316002)(186003);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?ZzdaQ2Zlc2xtOWU0M1pjS2FjUm1pbkg4dlByQ2VOcTlJak1PSXVOblN2Q1F2?= =?utf-8?B?TGl0NmZhT1VPNURIMkU3QVJJK1pGdVdSVkcxa3RjT05qcURyc3NLQ0dDWTBx?= =?utf-8?B?c3l1My9QRWFOd083TzY1V01mTTRFa3E1U2x2OG8ycEE0TUlsY201QVJTMWFK?= =?utf-8?B?U3ZXSWpucjFSY1JLR3lYUXQ4VXIxOWZSY1FZenhjekxETDAzTTNVSlVpL3Vp?= =?utf-8?B?WG5TcSsyQVlPbXpQZ05LWVEyS2k1TVZLVG5QbWpSU25Gd1BwWWxZS1lnUUVi?= =?utf-8?B?VWRDNEEvcWh3MTJIdFhucE51SWVTVmpPemw4SVN0N2YzYWdNVm9FOWtaK1E3?= =?utf-8?B?TXN5VG5BVGFVdEJzaFE0cTJwYmY3ZlN4WW1RVHdYR3FpRG1Wa1VuNTV4SUsw?= =?utf-8?B?UHFianRwdFZ3Y0N6Zi80V0ZIQUkvSnlKSGRIMEYxZGhIUWgzOXhobWtIZHgy?= =?utf-8?B?OGdrQzdtMGtTclJYQ0dKdEVmeVdndG5KMFJYUVBsVFVPS3E4OWZBWnFNRWdx?= =?utf-8?B?NXUyUmphWDRtcW5KQkhKbXRqbDdYVFRqUUNMTzhvWHNsMHAxOEtKTGhkZ3dH?= =?utf-8?B?T0wrbUtGRVB2a1BOdjlKTzBJWkMrUCtkWnU0K1BaemR3YnYrWnQzRTdTMUo2?= =?utf-8?B?VHI3ZG5kMHVqak1GSCswM2gxdmo1S25uZWpUNFhGbmhnSXNLeXlyOGFaQThP?= =?utf-8?B?T2pFYmd0ZGU3YktaZjhJQ3ZoYnNXWGxKaThsamdWS2xPaXJRMERXS2tEbU5i?= =?utf-8?B?TEZiK1FaL2F6NjVjbk83aFdqTlo2SHd3RUhucnlINTQwRC9CWVl0bEpDdGVO?= =?utf-8?B?eTNqbml6Tk1QdVppOWI4WHI0K2RCS3hDNlQyWERTVEFkclpIRWZjL2NIVlM2?= =?utf-8?B?b1BQRC9iVjExa3o4bU5EdURUakoxMXpPVmtpVmUvZDMzZzM4NzVkMmdnOVBr?= =?utf-8?B?d0xxQjMwL3VBVVJHMzhzMHdielZ3U0ZZcDZPVkh1Z29tUklKV2VKREgySW0r?= =?utf-8?B?ckkwR0M3dTBkdS9NeE01bGRLVzB4MnNrbTl4cFpxejZvcjF2NE0yWEdXMG5h?= =?utf-8?B?d2gzUmJIajhtdlJ4MkNYQ3hlOW1RU3IxREZmVC9GRjZDK0toU3h2Qzd3Yngy?= =?utf-8?B?eUJZZXhBYnlmUm5VVHQ0MCtNWVpBdjR0UllTTmtwaDZMMm1JWW9maHBvTm95?= =?utf-8?B?aWw0SHplTE1uR24zRjhjNzcya2JrK0hJOC9xU21ydklLcHJHc1I5UDM0c0Vl?= =?utf-8?B?V0JOeXh1Y3ZRYmp1UFZqZGtDVnRBZTFxRFZHUEdYNW9pRnZHRmMrY05hT2Ra?= =?utf-8?B?N0lyb2Frc3RadVhxOWVCd0l2VHU4bGJmekVkbVZ1eFBYcDl5WVdQYjVkL2RK?= =?utf-8?B?NHdXRXZEczFtRFVraWRaVzdDMVM5Mno1WjBWTkFxeW14RWJ6K0JwUE9TV2pP?= =?utf-8?B?eFVVT3V4ajFiTGdjbWU4UlNwUjdqbnRMUGxwSGRTN0RoUWNUNnFaSXhPU1hi?= =?utf-8?B?ZktnQ25nakJzeXJSa3ZWTHdNQmR3WFlWc0xiU3dYRmR2Uk01TzI3MTFFQWlT?= =?utf-8?B?d1lnSmJUK250UHp5L0E4d3lCVnlKSWZyVkZLQngwYWI1S01lcHNmMmtnR0k4?= =?utf-8?B?UGdBSHRvcVROVGxMeXROS1VCeUtaUi9FbzZBbkFPOGFXcVJaRk1UajIyV29K?= =?utf-8?B?RVZKSDFUSytPMW9va1pnMHV0RmdNMXpJYjlRT1luVjBST0Z5ZnRaWDhSS1M2?= =?utf-8?Q?lYMIYPhns62cRXMnxg9dLIU9VnALfARATqII3xx?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB5535 Original-Authentication-Results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT054.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: c12c467a-298c-4b38-0172-08d93f74d539 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7/kKs6aknlsowqzNKyn8VMMXoV+CCzQ7Xz+SvoX6iRbzTKwriIg3pnxwJuBJVf+K1iP8PdqtoCUnmkdZ+8kD7GF74l4b4AWMXeIfMhw2fW+/ZooLADOfnLLoCJPgHLALYCGv3dXtcR5DKn/Vbx4o0js5B2+VPx/tSwmzdSZKy4kX5EhajPl8BD7dLPk+mPFTAQyEhSU3p0xnnIyA2bdfJP0ur3yCJlvTVw6snvXGpdfniq8pUfEwh+b0W/3vVx3jxsoW7yShaXtzmH3yi0WEqEZDCLu0ZYHTehuP1yh3sgAy28glGJwB6txzFW+OFv9ejW5XmHMIJi44Y+McUUlanGKwnQkrTrXJzGmdP/cVhjxhdC4861f99JsDXxWogIz2PSqqY88RkO+AlEzKHrtuKoaMtMEsH5SsMvkSquDBe1013pzlKQYHKEY5Qptgka2W1wzEbabN2P4ANps8I5pOVfHn6PmiVFFkVw47p4nnmv62455c8/oSrk7ZezPsS4ODWGMkXZzE7s+kfyaNW5z+V7VGpm2hKv0r2W1d4E7B6mO9UoFbwfQB+Cxhc0IFgrcZ38mwuOErSaPPeYQwj+akV/WcrSEmjdZmXWO/ZZxuSH/b18Ibi8t+qlyNRj3FC09NZVb7WUO3JFoQUvmHHRT1LLxB87mfMmhBPB+nTWKk9BqioU5/3Qnl3NPdUIFeUarvHml11/rO4cN5CWJipQ3jOA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(376002)(39850400004)(396003)(346002)(136003)(46966006)(36840700001)(47076005)(2906002)(186003)(36860700001)(9686003)(8936002)(82740400003)(478600001)(55016002)(26005)(33656002)(82310400003)(107886003)(86362001)(110136005)(52536014)(70586007)(5660300002)(54906003)(8676002)(81166007)(336012)(53546011)(4326008)(83380400001)(316002)(6506007)(7696005)(70206006)(356005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2021 05:22:21.4016 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f8ef3700-517e-4836-4def-08d93f74dd79 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT054.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3628 SGkgSnVsaWVuIGFuZCBKYW4NCg0KPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9t OiBKdWxpZW4gR3JhbGwgPGp1bGllbkB4ZW4ub3JnPg0KPiBTZW50OiBUaHVyc2RheSwgSnVseSAx LCAyMDIxIDE6NDYgQU0NCj4gVG86IEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT47IFBl bm55IFpoZW5nIDxQZW5ueS5aaGVuZ0Bhcm0uY29tPg0KPiBDYzogQmVydHJhbmQgTWFycXVpcyA8 QmVydHJhbmQuTWFycXVpc0Bhcm0uY29tPjsgV2VpIENoZW4NCj4gPFdlaS5DaGVuQGFybS5jb20+ OyB4ZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmc7DQo+IHNzdGFiZWxsaW5pQGtlcm5lbC5v cmcNCj4gU3ViamVjdDogUmU6IFtQQVRDSCA0LzldIHhlbi9hcm06IHN0YXRpYyBtZW1vcnkgaW5p dGlhbGl6YXRpb24NCj4gDQo+IEhpLA0KPiANCj4gT24gMTAvMDYvMjAyMSAxMDozNSwgSmFuIEJl dWxpY2ggd3JvdGU6DQo+ID4gT24gMDcuMDYuMjAyMSAwNDo0MywgUGVubnkgWmhlbmcgd3JvdGU6 DQo+ID4+IC0tLSBhL3hlbi9hcmNoL2FybS9zZXR1cC5jDQo+ID4+ICsrKyBiL3hlbi9hcmNoL2Fy bS9zZXR1cC5jDQo+ID4+IEBAIC02MTEsNiArNjExLDMwIEBAIHN0YXRpYyB2b2lkIF9faW5pdCBp bml0X3BkeCh2b2lkKQ0KPiA+PiAgICAgICB9DQo+ID4+ICAgfQ0KPiA+Pg0KPiA+PiArLyogU3Rh dGljIG1lbW9yeSBpbml0aWFsaXphdGlvbiAqLw0KPiA+PiArc3RhdGljIHZvaWQgX19pbml0IGlu aXRfc3RhdGljbWVtX3BhZ2VzKHZvaWQpIHsNCj4gPj4gKyAgICBpbnQgYmFuazsNCj4gPg0KPiA+ IFdoaWxlIEknbSBub3QgYSBtYWludGFpbmVyIG9mIHRoaXMgY29kZSwgSSdkIHN0aWxsIGxpa2Ug dG8gcG9pbnQgb3V0DQo+ID4gdGhhdCB3aGVyZXZlciBwb3NzaWJsZSB3ZSBwcmVmZXIgInVuc2ln bmVkIGludCIgd2hlbiBkZWFsaW5nIHdpdGggb25seQ0KPiA+IG5vbi1uZWdhdGl2ZSB2YWx1ZXMs IGFuZCBldmVuIG1vcmUgc28gd2hlbiB1c2luZyB0aGVtIGFzIGFycmF5DQo+ID4gaW5kZXhlcy4N Cj4gDQo+ICsxLg0KPg0KDQpVbmRlcnN0b29kLiBUaHguDQoNCj4gPg0KPiA+PiArICAgIC8qDQo+ ID4+ICsgICAgICogVE9ETzogQ29uc2lkZXJpbmcgTlVNQS1zdXBwb3J0IHNjZW5hcmlvLg0KPiA+ PiArICAgICAqLw0KPiA+DQo+ID4gTml0OiBDb21tZW50IHN0eWxlLg0KPiA+DQoNClN1cmUsIHRo eC4NCg0KPiA+PiBAQCAtODcyLDYgKzg5Niw5IEBAIHZvaWQgX19pbml0IHN0YXJ0X3hlbih1bnNp Z25lZCBsb25nDQo+IGJvb3RfcGh5c19vZmZzZXQsDQo+ID4+ICAgICAgIGNtZGxpbmVfcGFyc2Uo Y21kbGluZSk7DQo+ID4+DQo+ID4+ICAgICAgIHNldHVwX21tKCk7DQo+ID4+ICsgICAgLyogSWYg ZXhpc3RzLCBTdGF0aWMgTWVtb3J5IEluaXRpYWxpemF0aW9uLiAqLw0KPiA+PiArICAgIGlmICgg Ym9vdGluZm8uc3RhdGljX21lbS5ucl9iYW5rcyA+IDAgKQ0KPiA+PiArICAgICAgICBpbml0X3N0 YXRpY21lbV9wYWdlcygpOw0KPiA+DQo+ID4gSSBkb24ndCB0aGluayB0aGUgY29uZGl0aW9uYWwg aXMgcmVhbGx5IG5lZWRlZCBoZXJlPw0KPiA+DQoNClN1cmUsIHJpZ2h0LiANCkxpa2Ugd2hhdCBK dWxpZW4gc3VnZ2VzdHMsICBpbml0X3N0YXRpY21lbV9wYWdlcygpIGlzIGFscmVhZHkgYWJsZSB0 byBjb3BlIHdpdGggbnJfYmFua3MgPT0gMC4NCg0KPiA+PiAtLS0gYS94ZW4vY29tbW9uL3BhZ2Vf YWxsb2MuYw0KPiA+PiArKysgYi94ZW4vY29tbW9uL3BhZ2VfYWxsb2MuYw0KPiA+PiBAQCAtMTM3 Niw2ICsxMzc2LDM3IEBAIGJvb2wgc2NydWJfZnJlZV9wYWdlcyh2b2lkKQ0KPiA+PiAgICAgICBy ZXR1cm4gbm9kZV90b19zY3J1YihmYWxzZSkgIT0gTlVNQV9OT19OT0RFOw0KPiA+PiAgIH0NCj4g Pj4NCj4gPj4gK3N0YXRpYyB2b2lkIGZyZWVfcGFnZShzdHJ1Y3QgcGFnZV9pbmZvICpwZywgYm9v bCBuZWVkX3NjcnViKSB7DQo+ID4+ICsgICAgbWZuX3QgbWZuID0gcGFnZV90b19tZm4ocGcpOw0K PiA+DQo+ID4gV2l0aCBwZHggY29tcHJlc3Npb24gdGhpcyBpcyBhIG5vbi10cml2aWFsIGNvbnZl cnNpb24uIFRoZSBmdW5jdGlvbg0KPiA+IGJlaW5nIGFuIGludGVybmFsIGhlbHBlciBhbmQgdGhl IGNhbGxlciBhbHJlYWR5IGhvbGRpbmcgdGhlIE1GTiwgSQ0KPiA+IHRoaW5rIGl0IHdvdWxkIGJl IHByZWZlcmFibGUgaWYgdGhlIE1GTiB3YXMgcGFzc2VkIGluIGhlcmUuIElmIGRvbmUNCj4gPiB0 aGlzIHdheSwgeW91IG1heSB3YW50IHRvIGNvbnNpZGVyIGFkZGluZyBhbiBBU1NFUlQoKSB0byBk b3VibGUgY2hlY2sNCj4gPiBib3RoIHBhc3NlZCBpbiBhcmd1bWVudHMgbWF0Y2ggdXAuDQo+ID4N Cg0KVGhhbmsgZm9yIHRoZSBzdWdnZXN0aW9ufg0KDQo+ID4+ICsgICAgLyogSWYgYSBwYWdlIGhh cyBubyBvd25lciBpdCB3aWxsIG5lZWQgbm8gc2FmZXR5IFRMQiBmbHVzaC4gKi8NCj4gPj4gKyAg ICBwZy0+dS5mcmVlLm5lZWRfdGxiZmx1c2ggPSAocGFnZV9nZXRfb3duZXIocGcpICE9IE5VTEwp Ow0KPiA+PiArICAgIGlmICggcGctPnUuZnJlZS5uZWVkX3RsYmZsdXNoICkNCj4gPj4gKyAgICAg ICAgcGFnZV9zZXRfdGxiZmx1c2hfdGltZXN0YW1wKHBnKTsNCj4gPj4gKw0KPiA+PiArICAgIC8q IFRoaXMgcGFnZSBpcyBub3QgYSBndWVzdCBmcmFtZSBhbnkgbW9yZS4gKi8NCj4gPj4gKyAgICBw YWdlX3NldF9vd25lcihwZywgTlVMTCk7IC8qIHNldF9ncGZuX2Zyb21fbWZuIHNub29wcyBwZyBv d25lcg0KPiAqLw0KPiA+PiArICAgIHNldF9ncGZuX2Zyb21fbWZuKG1mbl94KG1mbiksIElOVkFM SURfTTJQX0VOVFJZKTsNCj4gPj4gKw0KPiA+PiArI2lmZGVmIENPTkZJR19BUk0NCj4gPg0KPiA+ IElmIGF2b2lkYWJsZSB0aGVyZSBzaG91bGQgYmUgbm8gYXJjaC1zcGVjaWZpYyBjb2RlIGFkZGVk IHRvIHRoaXMgZmlsZS4NCj4gPiBBc3N1bWluZyBhbm90aGVyIGFyY2ggZ2FpbmVkIFBHQ19yZXNl cnZlZCwgd2hhdCdzIHdyb25nIHdpdGggZW5hYmxpbmcNCj4gPiB0aGlzIGNvZGUgcmlnaHQgYXdh eSBmb3IgdGhlbSBhcyB3ZWxsPyBJLmUuIHVzZSBQR0NfcmVzZXJ2ZWQgaGVyZQ0KPiA+IGluc3Rl YWQgb2YgQ09ORklHX0FSTT8gQWx0ZXJuYXRpdmVseSB0aGlzIG1heSB3YW50IHRvIGJlDQo+ID4g Q09ORklHX1NUQVRJQ19BTExPQ0FUSU9OLCBhc3N1bWluZyB3ZSBjb25zaWRlciBQR0NfcmVzZXJ2 ZWQgdGllZCB0bw0KPiA+IGl0Lg0KPiA+DQoNClRvIG5vdCBicmluZyBkZWFkIGNvZGVzIGluIG90 aGVyIGFyY2hzLCBJJ2xsIHVzZSBtb3JlIGdlbmVyaWMgb3B0aW9uIENPTkZJR19TVEFUSUNfQUxM T0NBVElPTi4NCg0KPiA+PiArICAgIGlmICggcGctPmNvdW50X2luZm8gJiBQR0NfcmVzZXJ2ZWQg KQ0KPiA+PiArICAgIHsNCj4gPj4gKyAgICAgICAgLyogVE9ETzogYXN5bmNocm9ub3VzIHNjcnVi YmluZy4gKi8NCj4gPj4gKyAgICAgICAgaWYgKCBuZWVkX3NjcnViICkNCj4gPj4gKyAgICAgICAg ICAgIHNjcnViX29uZV9wYWdlKHBnKTsNCj4gPj4gKyAgICAgICAgcmV0dXJuOw0KPiA+PiArICAg IH0NCj4gPj4gKyNlbmRpZg0KPiA+PiArICAgIGlmICggbmVlZF9zY3J1YiApDQo+ID4NCj4gPiBO aXQ6IFBsZWFzZSBoYXZlIGEgYmxhbmsgbGluZSBiZXR3ZWVuIHRoZXNlIGxhc3QgdHdvLg0KPiA+ DQoNClN1cmUuIFdpbGwgZG8uDQoNCj4gPj4gKyAgICB7DQo+ID4+ICsgICAgICAgIHBnLT5jb3Vu dF9pbmZvIHw9IFBHQ19uZWVkX3NjcnViOw0KPiA+PiArICAgICAgICBwb2lzb25fb25lX3BhZ2Uo cGcpOw0KPiA+PiArICAgIH0NCj4gPj4gKw0KPiA+PiArICAgIHJldHVybjsNCj4gPg0KPiA+IFBs ZWFzZSBvbWl0IHJldHVybiBzdGF0ZW1lbnRzIGF0IHRoZSBlbmQgb2YgZnVuY3Rpb25zIHJldHVy bmluZyB2b2lkLg0KPiA+DQoNClN1cmUsIHRoeA0KDQo+ID4+ICt9DQo+ID4NCj4gPiBPbiB0aGUg d2hvbGUsIGJpa2Ugc2hlZGRpbmcgb3Igbm90LCBJJ20gYWZyYWlkIHRoZSBmdW5jdGlvbidzIG5h bWUNCj4gPiBkb2Vzbid0IG1hdGNoIHdoYXQgaXQgZG9lczogVGhlcmUncyBubyBmcmVlaW5nIG9m IGEgcGFnZSBoZXJlLiBXaGF0DQo+ID4gZ2V0cyBkb25lIGlzIG1hcmtpbmcgb2YgYSBwYWdlIGFz IGZyZWUuIEhlbmNlIG1heWJlIG1hcmtfcGFnZV9mcmVlKCkNCj4gPiBvciBtYXJrX2ZyZWVfcGFn ZSgpIG9yIHNvbWUgc3VjaD8NCj4gPg0KDQpPay4gVGh4LiBBbHdheXMgbm90IGdvb2QgYXQgZ2l2 aW5nIG5hbWVzLiBJJ2xsIHRha2UgbWFya19wYWdlX2ZyZWUoKQ0KDQo+ID4+IEBAIC0xNTEyLDYg KzE1MzAsMzggQEAgc3RhdGljIHZvaWQgZnJlZV9oZWFwX3BhZ2VzKA0KPiA+PiAgICAgICBzcGlu X3VubG9jaygmaGVhcF9sb2NrKTsNCj4gPj4gICB9DQo+ID4+DQo+ID4+ICsjaWZkZWYgQ09ORklH X1NUQVRJQ19BTExPQ0FUSU9ODQo+ID4+ICsvKiBFcXVpdmFsZW50IG9mIGZyZWVfaGVhcF9wYWdl cyB0byBmcmVlIG5yX21mbnMgcGFnZXMgb2Ygc3RhdGljDQo+ID4+ICttZW1vcnkuICovIHZvaWQg X19pbml0IGZyZWVfc3RhdGljbWVtX3BhZ2VzKHN0cnVjdCBwYWdlX2luZm8gKnBnLA0KPiB1bnNp Z25lZCBsb25nIG5yX21mbnMsDQo+ID4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBib29sIG5lZWRfc2NydWIpIHsNCj4gPj4gKyAgICBtZm5fdCBtZm4gPSBwYWdlX3RvX21mbihw Zyk7DQo+ID4+ICsgICAgdW5zaWduZWQgbG9uZyBpOw0KPiA+PiArDQo+ID4+ICsgICAgZm9yICgg aSA9IDA7IGkgPCBucl9tZm5zOyBpKysgKQ0KPiA+PiArICAgIHsNCj4gPj4gKyAgICAgICAgc3dp dGNoICggcGdbaV0uY291bnRfaW5mbyAmIFBHQ19zdGF0ZSApDQo+ID4+ICsgICAgICAgIHsNCj4g Pj4gKyAgICAgICAgY2FzZSBQR0Nfc3RhdGVfaW51c2U6DQo+ID4+ICsgICAgICAgICAgICBCVUdf T04ocGdbaV0uY291bnRfaW5mbyAmIFBHQ19icm9rZW4pOw0KPiA+PiArICAgICAgICAgICAgLyog TWFyayBpdCBmcmVlIGFuZCByZXNlcnZlZC4gKi8NCj4gPj4gKyAgICAgICAgICAgIHBnW2ldLmNv dW50X2luZm8gPSBQR0Nfc3RhdGVfZnJlZSB8IFBHQ19yZXNlcnZlZDsNCj4gPj4gKyAgICAgICAg ICAgIGJyZWFrOw0KPiA+PiArDQo+ID4+ICsgICAgICAgIGRlZmF1bHQ6DQo+ID4+ICsgICAgICAg ICAgICBwcmludGsoWEVOTE9HX0VSUg0KPiA+PiArICAgICAgICAgICAgICAgICAgICJQYWdlIHN0 YXRlIHNoYWxsIGJlIG9ubHkgaW4gUEdDX3N0YXRlX2ludXNlLiAiDQo+ID4NCj4gPiBXaHk/IEEg cGFnZSAoc3RhdGljIG9yIG5vdCkgY2FuIGJlY29tZSBicm9rZW4gd2hpbGUgaW4gdXNlLiBJT1cg SQ0KPiA+IGRvbid0IHRoaW5rIHlvdSBjYW4gYXZvaWQgaGFuZGxpbmcgUEdDX3N0YXRlX29mZmxp bmluZyBoZXJlLiBBdCB3aGljaA0KPiA+IHBvaW50IHRoaXMgY29kZSB3aWxsIG1hdGNoIGZyZWVf aGVhcF9wYWdlcygpJ2VzLCBhbmQgaGVuY2UgbGlrZWx5IHdpbGwNCj4gPiB3YW50IGZvbGRpbmcg YXMgd2VsbC4NCj4gPg0KDQpZZWFoLCBJIHdhcyBmb2xsb3dpbmcgdGhlIGxvZ2ljIGluIGZyZWVf aGVhcF9wYWdlcy4NCkhtbW0sIEkgY291bGQgbm90IHRoaW5rIG9mIGFueSBzY2VuYXJpbyB0aGF0 IHdpbGwgbGVhZCB0byBQR0Nfc3RhdGVfb2ZmbGluaW5nLCB0aGF0J3Mgd2h5DQpJIHdhcyBub3Qg aW5jbHVkaW5nIGl0IGF0IHRoZSBmaXJzdCBwbGFjZS4NCkZvciBicm9rZW4gaXNzdWUsIHRiaCwg SSBqdXN0IGNvcHkgdGhlIGJ1Z19vbiBmcm9tIGZyZWVfaGVhcF9wYWdlcywgYWZ0ZXIgcXVpdGUg YSB0aW1lIHRoaW5raW5nLA0KSSBhbHNvIGNvdWxkIG5vdCBmaW5kIGFueSBzY2VuYXJpbyB3aGVu IGEgcGFnZShzdGF0aWMgb3Igbm90KSBjYW4gYmVjb21lIGJyb2tlbiB3aGlsZSBpbiB1c2UuIDsv DQoNCj4gPj4gLS0tIGEveGVuL2luY2x1ZGUveGVuL21tLmgNCj4gPj4gKysrIGIveGVuL2luY2x1 ZGUveGVuL21tLmgNCj4gPj4gQEAgLTg1LDYgKzg1LDEyIEBAIGJvb2wgc2NydWJfZnJlZV9wYWdl cyh2b2lkKTsNCj4gPj4gICB9IHdoaWxlICggZmFsc2UgKQ0KPiA+PiAgICNkZWZpbmUgRlJFRV9Y RU5IRUFQX1BBR0UocCkgRlJFRV9YRU5IRUFQX1BBR0VTKHAsIDApDQo+ID4+DQo+ID4+ICsjaWZk ZWYgQ09ORklHX0FSTQ0KPiA+DQo+ID4gSVRZTSBDT05GSUdfU1RBVElDX0FMTE9DQVRJT04gaGVy ZT8NCj4gPg0KPiA+IEphbg0KPiA+DQo+IA0KPiAtLQ0KPiBKdWxpZW4gR3JhbGwNCg0KQ2hlZXJz DQoNCi0tDQpQZW5ueSBaaGVuZw0K From xen-devel-bounces@lists.xenproject.org Mon Jul 05 06:40:21 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Jul 2021 06:40:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149790.277051 (Exim 4.92) (envelope-from ) id 1m0IGx-0003dV-Ok; Mon, 05 Jul 2021 06:40:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149790.277051; Mon, 05 Jul 2021 06:40:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0IGx-0003d0-Ld; Mon, 05 Jul 2021 06:40:03 +0000 Received: by outflank-mailman (input) for mailman id 149790; Mon, 05 Jul 2021 06:40:02 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0IGw-0003Qf-FD for xen-devel@lists.xenproject.org; Mon, 05 Jul 2021 06:40:02 +0000 Received: from foss.arm.com (unknown [217.140.110.172]) by us1-rack-iad1.inumbo.com (Halon) with ESMTP id cb8c6b69-9592-4f35-b71b-af600618acb3; Mon, 05 Jul 2021 06:40:00 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1BA1C1063; Sun, 4 Jul 2021 23:40:00 -0700 (PDT) Received: from e123311-lin.arm.com (unknown [10.57.13.212]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8E0103F694; Sun, 4 Jul 2021 23:39:57 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cb8c6b69-9592-4f35-b71b-af600618acb3 From: Michal Orzel To: xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Wei Liu , Tamas K Lengyel , Alexandru Isaila , Petre Pircalabu , bertrand.marquis@arm.com Subject: [PATCH v4] arm64: Change type of hsr, cpsr, spsr_el1 to uint64_t Date: Mon, 5 Jul 2021 08:39:52 +0200 Message-Id: <20210705063952.25629-1-michal.orzel@arm.com> X-Mailer: git-send-email 2.29.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit AArch64 registers are 64bit whereas AArch32 registers are 32bit or 64bit. MSR/MRS are expecting 64bit values thus we should get rid of helpers READ/WRITE_SYSREG32 in favour of using READ/WRITE_SYSREG. We should also use register_t type when reading sysregs which can correspond to uint64_t or uint32_t. Even though many AArch64 registers have upper 32bit reserved it does not mean that they can't be widen in the future. Modify type of hsr, cpsr, spsr_el1 to uint64_t. Previously we relied on the padding after spsr_el1. As we removed the padding, modify the union to be 64bit so we don't corrupt spsr_fiq. No need to modify the assembly code because the accesses were based on 64bit registers as there was a 32bit padding after spsr_el1. Remove 32bit padding in cpu_user_regs before spsr_fiq as it is no longer needed due to upper union being 64bit now. Add 64bit padding in cpu_user_regs before spsr_el1 because the kernel frame should be 16-byte aligned. Change type of cpsr to uint64_t in the public outside interface "public/arch-arm.h" to allow ABI compatibility between 32bit and 64bit. Increment XEN_DOMCTL_INTERFACE_VERSION. Change type of cpsr to uint64_t in the public outside interface "public/vm_event.h" to allow ABI compatibility between 32bit and 64bit. Signed-off-by: Michal Orzel --- Changes since v3: -Fix comment about padding -Remove duplicated printk Changes since v2: -Remove _res0 members from structures inside hsr union -Update commit message -Modify type of cpsr to uint64_t in public/arch-arm.h -Increment XEN_DOMCTL_INTERFACE_VERSION Changes since v1: -Modify type of cpsr, spsr_el1 -Remove ifdefery in hsr union protecting _res0 members -Fix formatting of printk calls --- xen/arch/arm/arm64/entry.S | 4 ++-- xen/arch/arm/arm64/traps.c | 2 +- xen/arch/arm/arm64/vsysreg.c | 3 ++- xen/arch/arm/domain.c | 2 +- xen/arch/arm/traps.c | 28 ++++++++++++++------------- xen/arch/arm/vcpreg.c | 13 +++++++------ xen/include/asm-arm/arm64/processor.h | 11 ++++++----- xen/include/asm-arm/hsr.h | 2 +- xen/include/public/arch-arm.h | 4 ++-- xen/include/public/domctl.h | 2 +- xen/include/public/vm_event.h | 3 +-- 11 files changed, 39 insertions(+), 35 deletions(-) diff --git a/xen/arch/arm/arm64/entry.S b/xen/arch/arm/arm64/entry.S index ab9a65fc14..fc3811ad0a 100644 --- a/xen/arch/arm/arm64/entry.S +++ b/xen/arch/arm/arm64/entry.S @@ -155,7 +155,7 @@ add x21, sp, #UREGS_CPSR mrs x22, spsr_el2 mrs x23, esr_el2 - stp w22, w23, [x21] + stp x22, x23, [x21] .endm @@ -432,7 +432,7 @@ return_from_trap: msr daifset, #IFLAGS___I_ /* Mask interrupts */ ldr x21, [sp, #UREGS_PC] /* load ELR */ - ldr w22, [sp, #UREGS_CPSR] /* load SPSR */ + ldr x22, [sp, #UREGS_CPSR] /* load SPSR */ pop x0, x1 pop x2, x3 diff --git a/xen/arch/arm/arm64/traps.c b/xen/arch/arm/arm64/traps.c index babfc1d884..9113a15c7a 100644 --- a/xen/arch/arm/arm64/traps.c +++ b/xen/arch/arm/arm64/traps.c @@ -36,7 +36,7 @@ void do_bad_mode(struct cpu_user_regs *regs, int reason) union hsr hsr = { .bits = regs->hsr }; printk("Bad mode in %s handler detected\n", handler[reason]); - printk("ESR=0x%08"PRIx32": EC=%"PRIx32", IL=%"PRIx32", ISS=%"PRIx32"\n", + printk("ESR=%#"PRIregister": EC=%"PRIx32", IL=%"PRIx32", ISS=%"PRIx32"\n", hsr.bits, hsr.ec, hsr.len, hsr.iss); local_irq_disable(); diff --git a/xen/arch/arm/arm64/vsysreg.c b/xen/arch/arm/arm64/vsysreg.c index 41f18612c6..caf17174b8 100644 --- a/xen/arch/arm/arm64/vsysreg.c +++ b/xen/arch/arm/arm64/vsysreg.c @@ -368,7 +368,8 @@ void do_sysreg(struct cpu_user_regs *regs, sysreg.op2, sysreg.read ? "=>" : "<=", sysreg.reg, regs->pc); - gdprintk(XENLOG_ERR, "unhandled 64-bit sysreg access %#x\n", + gdprintk(XENLOG_ERR, + "unhandled 64-bit sysreg access %#"PRIregister"\n", hsr.bits & HSR_SYSREG_REGS_MASK); inject_undef_exception(regs, hsr); return; diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c index c021a03c61..74bdbb9082 100644 --- a/xen/arch/arm/domain.c +++ b/xen/arch/arm/domain.c @@ -845,7 +845,7 @@ static int is_guest_pv32_psr(uint32_t psr) #ifdef CONFIG_ARM_64 -static int is_guest_pv64_psr(uint32_t psr) +static int is_guest_pv64_psr(uint64_t psr) { if ( psr & PSR_MODE_BIT ) return 0; diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c index e7384381cc..4ccb6e7d18 100644 --- a/xen/arch/arm/traps.c +++ b/xen/arch/arm/traps.c @@ -546,7 +546,7 @@ void inject_undef64_exception(struct cpu_user_regs *regs, int instr_len) PSR_IRQ_MASK | PSR_DBG_MASK; regs->pc = handler; - WRITE_SYSREG32(esr.bits, ESR_EL1); + WRITE_SYSREG(esr.bits, ESR_EL1); } /* Inject an abort exception into a 64 bit guest */ @@ -580,7 +580,7 @@ static void inject_abt64_exception(struct cpu_user_regs *regs, regs->pc = handler; WRITE_SYSREG(addr, FAR_EL1); - WRITE_SYSREG32(esr.bits, ESR_EL1); + WRITE_SYSREG(esr.bits, ESR_EL1); } static void inject_dabt64_exception(struct cpu_user_regs *regs, @@ -717,7 +717,7 @@ struct reg_ctxt { uint64_t vttbr_el2; }; -static const char *mode_string(uint32_t cpsr) +static const char *mode_string(register_t cpsr) { uint32_t mode; static const char *mode_strings[] = { @@ -762,7 +762,7 @@ static void show_registers_32(const struct cpu_user_regs *regs, printk(" %pS", _p(regs->pc)); printk("\n"); #endif - printk("CPSR: %08"PRIx32" MODE:%s\n", regs->cpsr, + printk("CPSR: %"PRIregister" MODE:%s\n", regs->cpsr, mode_string(regs->cpsr)); printk(" R0: %08"PRIx32" R1: %08"PRIx32" R2: %08"PRIx32" R3: %08"PRIx32"\n", regs->r0, regs->r1, regs->r2, regs->r3); @@ -846,7 +846,7 @@ static void show_registers_64(const struct cpu_user_regs *regs, { printk("SP: %016"PRIx64"\n", regs->sp); } - printk("CPSR: %08"PRIx32" MODE:%s\n", regs->cpsr, + printk("CPSR: %016"PRIx64" MODE:%s\n", regs->cpsr, mode_string(regs->cpsr)); printk(" X0: %016"PRIx64" X1: %016"PRIx64" X2: %016"PRIx64"\n", regs->x0, regs->x1, regs->x2); @@ -919,7 +919,7 @@ static void _show_registers(const struct cpu_user_regs *regs, printk(" HCR_EL2: %"PRIregister"\n", READ_SYSREG(HCR_EL2)); printk(" TTBR0_EL2: %016"PRIx64"\n", READ_SYSREG64(TTBR0_EL2)); printk("\n"); - printk(" ESR_EL2: %08"PRIx32"\n", regs->hsr); + printk(" ESR_EL2: %"PRIregister"\n", regs->hsr); printk(" HPFAR_EL2: %"PRIregister"\n", READ_SYSREG(HPFAR_EL2)); #ifdef CONFIG_ARM_32 @@ -1599,7 +1599,7 @@ static const unsigned short cc_map[16] = { int check_conditional_instr(struct cpu_user_regs *regs, const union hsr hsr) { - unsigned long cpsr, cpsr_cond; + register_t cpsr, cpsr_cond; int cond; /* @@ -1661,7 +1661,7 @@ int check_conditional_instr(struct cpu_user_regs *regs, const union hsr hsr) void advance_pc(struct cpu_user_regs *regs, const union hsr hsr) { - unsigned long itbits, cond, cpsr = regs->cpsr; + register_t itbits, cond, cpsr = regs->cpsr; bool is_thumb = psr_mode_is_32bit(regs) && (cpsr & PSR_THUMB); if ( is_thumb && (cpsr & PSR_IT_MASK) ) @@ -2004,13 +2004,15 @@ static void do_trap_stage2_abort_guest(struct cpu_user_regs *regs, break; default: - gprintk(XENLOG_WARNING, "Unsupported FSC: HSR=%#x DFSC=%#x\n", + gprintk(XENLOG_WARNING, + "Unsupported FSC: HSR=%#"PRIregister" DFSC=%#x\n", hsr.bits, xabt.fsc); } inject_abt: - gdprintk(XENLOG_DEBUG, "HSR=0x%x pc=%#"PRIregister" gva=%#"PRIvaddr - " gpa=%#"PRIpaddr"\n", hsr.bits, regs->pc, gva, gpa); + gdprintk(XENLOG_DEBUG, + "HSR=%#"PRIregister" pc=%#"PRIregister" gva=%#"PRIvaddr" gpa=%#"PRIpaddr"\n", + hsr.bits, regs->pc, gva, gpa); if ( is_data ) inject_dabt_exception(regs, gva, hsr.len); else @@ -2204,7 +2206,7 @@ void do_trap_guest_sync(struct cpu_user_regs *regs) default: gprintk(XENLOG_WARNING, - "Unknown Guest Trap. HSR=0x%x EC=0x%x IL=%x Syndrome=0x%"PRIx32"\n", + "Unknown Guest Trap. HSR=%#"PRIregister" EC=0x%x IL=%x Syndrome=0x%"PRIx32"\n", hsr.bits, hsr.ec, hsr.len, hsr.iss); inject_undef_exception(regs, hsr); } @@ -2242,7 +2244,7 @@ void do_trap_hyp_sync(struct cpu_user_regs *regs) break; } default: - printk("Hypervisor Trap. HSR=0x%x EC=0x%x IL=%x Syndrome=0x%"PRIx32"\n", + printk("Hypervisor Trap. HSR=%#"PRIregister" EC=0x%x IL=%x Syndrome=0x%"PRIx32"\n", hsr.bits, hsr.ec, hsr.len, hsr.iss); do_unexpected_trap("Hypervisor", regs); } diff --git a/xen/arch/arm/vcpreg.c b/xen/arch/arm/vcpreg.c index 55351fc087..f0cdcc8a54 100644 --- a/xen/arch/arm/vcpreg.c +++ b/xen/arch/arm/vcpreg.c @@ -385,7 +385,7 @@ void do_cp15_32(struct cpu_user_regs *regs, const union hsr hsr) "%s p15, %d, r%d, cr%d, cr%d, %d @ 0x%"PRIregister"\n", cp32.read ? "mrc" : "mcr", cp32.op1, cp32.reg, cp32.crn, cp32.crm, cp32.op2, regs->pc); - gdprintk(XENLOG_ERR, "unhandled 32-bit CP15 access %#x\n", + gdprintk(XENLOG_ERR, "unhandled 32-bit CP15 access %#"PRIregister"\n", hsr.bits & HSR_CP32_REGS_MASK); inject_undef_exception(regs, hsr); return; @@ -454,7 +454,8 @@ void do_cp15_64(struct cpu_user_regs *regs, const union hsr hsr) "%s p15, %d, r%d, r%d, cr%d @ 0x%"PRIregister"\n", cp64.read ? "mrrc" : "mcrr", cp64.op1, cp64.reg1, cp64.reg2, cp64.crm, regs->pc); - gdprintk(XENLOG_ERR, "unhandled 64-bit CP15 access %#x\n", + gdprintk(XENLOG_ERR, + "unhandled 64-bit CP15 access %#"PRIregister"\n", hsr.bits & HSR_CP64_REGS_MASK); inject_undef_exception(regs, hsr); return; @@ -585,7 +586,7 @@ void do_cp14_32(struct cpu_user_regs *regs, const union hsr hsr) "%s p14, %d, r%d, cr%d, cr%d, %d @ 0x%"PRIregister"\n", cp32.read ? "mrc" : "mcr", cp32.op1, cp32.reg, cp32.crn, cp32.crm, cp32.op2, regs->pc); - gdprintk(XENLOG_ERR, "unhandled 32-bit cp14 access %#x\n", + gdprintk(XENLOG_ERR, "unhandled 32-bit cp14 access %#"PRIregister"\n", hsr.bits & HSR_CP32_REGS_MASK); inject_undef_exception(regs, hsr); return; @@ -627,7 +628,7 @@ void do_cp14_64(struct cpu_user_regs *regs, const union hsr hsr) "%s p14, %d, r%d, r%d, cr%d @ 0x%"PRIregister"\n", cp64.read ? "mrrc" : "mcrr", cp64.op1, cp64.reg1, cp64.reg2, cp64.crm, regs->pc); - gdprintk(XENLOG_ERR, "unhandled 64-bit CP14 access %#x\n", + gdprintk(XENLOG_ERR, "unhandled 64-bit CP14 access %#"PRIregister"\n", hsr.bits & HSR_CP64_REGS_MASK); inject_undef_exception(regs, hsr); } @@ -658,7 +659,7 @@ void do_cp14_dbg(struct cpu_user_regs *regs, const union hsr hsr) "%s p14, %d, r%d, r%d, cr%d @ 0x%"PRIregister"\n", cp64.read ? "mrrc" : "mcrr", cp64.op1, cp64.reg1, cp64.reg2, cp64.crm, regs->pc); - gdprintk(XENLOG_ERR, "unhandled 64-bit CP14 DBG access %#x\n", + gdprintk(XENLOG_ERR, "unhandled 64-bit CP14 DBG access %#"PRIregister"\n", hsr.bits & HSR_CP64_REGS_MASK); inject_undef_exception(regs, hsr); @@ -692,7 +693,7 @@ void do_cp10(struct cpu_user_regs *regs, const union hsr hsr) "%s p10, %d, r%d, cr%d, cr%d, %d @ 0x%"PRIregister"\n", cp32.read ? "mrc" : "mcr", cp32.op1, cp32.reg, cp32.crn, cp32.crm, cp32.op2, regs->pc); - gdprintk(XENLOG_ERR, "unhandled 32-bit CP10 access %#x\n", + gdprintk(XENLOG_ERR, "unhandled 32-bit CP10 access %#"PRIregister"\n", hsr.bits & HSR_CP32_REGS_MASK); inject_undef_exception(regs, hsr); return; diff --git a/xen/include/asm-arm/arm64/processor.h b/xen/include/asm-arm/arm64/processor.h index 81dfc5e615..c749f80ad9 100644 --- a/xen/include/asm-arm/arm64/processor.h +++ b/xen/include/asm-arm/arm64/processor.h @@ -63,18 +63,19 @@ struct cpu_user_regs /* Return address and mode */ __DECL_REG(pc, pc32); /* ELR_EL2 */ - uint32_t cpsr; /* SPSR_EL2 */ - uint32_t hsr; /* ESR_EL2 */ + uint64_t cpsr; /* SPSR_EL2 */ + uint64_t hsr; /* ESR_EL2 */ + + /* The kernel frame should be 16-byte aligned. */ + uint64_t pad0; /* Outer guest frame only from here on... */ union { - uint32_t spsr_el1; /* AArch64 */ + uint64_t spsr_el1; /* AArch64 */ uint32_t spsr_svc; /* AArch32 */ }; - uint32_t pad1; /* Doubleword-align the user half of the frame */ - /* AArch32 guests only */ uint32_t spsr_fiq, spsr_irq, spsr_und, spsr_abt; diff --git a/xen/include/asm-arm/hsr.h b/xen/include/asm-arm/hsr.h index 29d4531f40..9b91b28c48 100644 --- a/xen/include/asm-arm/hsr.h +++ b/xen/include/asm-arm/hsr.h @@ -16,7 +16,7 @@ enum dabt_size { }; union hsr { - uint32_t bits; + register_t bits; struct { unsigned long iss:25; /* Instruction Specific Syndrome */ unsigned long len:1; /* Instruction length */ diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h index 713fd65317..64a2ca30da 100644 --- a/xen/include/public/arch-arm.h +++ b/xen/include/public/arch-arm.h @@ -267,10 +267,10 @@ struct vcpu_guest_core_regs /* Return address and mode */ __DECL_REG(pc64, pc32); /* ELR_EL2 */ - uint32_t cpsr; /* SPSR_EL2 */ + uint64_t cpsr; /* SPSR_EL2 */ union { - uint32_t spsr_el1; /* AArch64 */ + uint64_t spsr_el1; /* AArch64 */ uint32_t spsr_svc; /* AArch32 */ }; diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h index 4dbf107785..d576bfabd6 100644 --- a/xen/include/public/domctl.h +++ b/xen/include/public/domctl.h @@ -38,7 +38,7 @@ #include "hvm/save.h" #include "memory.h" -#define XEN_DOMCTL_INTERFACE_VERSION 0x00000013 +#define XEN_DOMCTL_INTERFACE_VERSION 0x00000014 /* * NB. xen_domctl.domain is an IN/OUT parameter for this operation. diff --git a/xen/include/public/vm_event.h b/xen/include/public/vm_event.h index 36135ba4f1..bb003d21d0 100644 --- a/xen/include/public/vm_event.h +++ b/xen/include/public/vm_event.h @@ -266,8 +266,7 @@ struct vm_event_regs_arm { uint64_t ttbr1; uint64_t ttbcr; uint64_t pc; - uint32_t cpsr; - uint32_t _pad; + uint64_t cpsr; }; /* -- 2.29.0 From xen-devel-bounces@lists.xenproject.org Mon Jul 05 07:15:13 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Jul 2021 07:15:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149797.277062 (Exim 4.92) (envelope-from ) id 1m0Ios-0007Sc-L8; Mon, 05 Jul 2021 07:15:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149797.277062; Mon, 05 Jul 2021 07:15:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0Ios-0007SV-Gv; Mon, 05 Jul 2021 07:15:06 +0000 Received: by outflank-mailman (input) for mailman id 149797; Mon, 05 Jul 2021 07:15:05 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0Ior-0007SP-6K for xen-devel@lists.xenproject.org; Mon, 05 Jul 2021 07:15:05 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (unknown [40.107.8.40]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id b776510b-dd60-11eb-843e-12813bfff9fa; Mon, 05 Jul 2021 07:15:03 +0000 (UTC) Received: from AM6P195CA0014.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:81::27) by AM5PR0801MB1892.eurprd08.prod.outlook.com (2603:10a6:203:4d::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.23; Mon, 5 Jul 2021 07:15:00 +0000 Received: from VE1EUR03FT005.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:81:cafe::db) by AM6P195CA0014.outlook.office365.com (2603:10a6:209:81::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.22 via Frontend Transport; Mon, 5 Jul 2021 07:15:00 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT005.mail.protection.outlook.com (10.152.18.172) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.22 via Frontend Transport; Mon, 5 Jul 2021 07:15:00 +0000 Received: ("Tessian outbound 5d90d3e3ebc7:v97"); Mon, 05 Jul 2021 07:14:59 +0000 Received: from cc79ab84d0a9.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 9AF69E76-84EC-48E3-B1FE-0B9ED816F679.1; Mon, 05 Jul 2021 07:14:53 +0000 Received: from EUR03-AM5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id cc79ab84d0a9.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 05 Jul 2021 07:14:53 +0000 Received: from VE1PR08MB5215.eurprd08.prod.outlook.com (2603:10a6:803:10a::33) by VE1PR08MB5598.eurprd08.prod.outlook.com (2603:10a6:800:1a2::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4242.18; Mon, 5 Jul 2021 07:14:51 +0000 Received: from VE1PR08MB5215.eurprd08.prod.outlook.com ([fe80::2807:2ff9:e371:2918]) by VE1PR08MB5215.eurprd08.prod.outlook.com ([fe80::2807:2ff9:e371:2918%7]) with mapi id 15.20.4287.033; Mon, 5 Jul 2021 07:14:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b776510b-dd60-11eb-843e-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=U6qdP3mMKvnmKn7YyujD+j/ep41Pw1sRSneXiEsdZm0=; b=jXUI1zG96aW6fVQn4ElU/IbZRIn7XuWoyXZqtZNWdPcZztLYpshdvUpHhaNetMeyau2hOIyzflu8em8PQOoCoYO5nG8RN/B/wApuxLqyJL3uHQ8jZc/ObScohG+o7v1ulN0JBF9NrQPesjtKFGyTUIRRkMRR1v+KuHwHPwzZ4dc= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jLTUpNp0S8gqELKpuxGpt40jzEH1to5NEe1K5KtiNGtofHERIjGrYRvH5WfD8zzu09aYWaL1/iSKhej9ZLClS98IUdze4vCb/ZjV9hbB1jjDg72OmhacgGNmuIwsq7QEdqgnMqLDue/pwPlTOKiyLjw8lz4wcg07Sm/XSZQBKEXlkxSej8Ckb+CNa/ksiZOtFMmjLQnTUYw/UacPJFWe1jdQxtFzbve7PPJbc6eQuJK1dPy5SbBxCnlI1/5hx8OufhXs4FfY7IBjiScB3fy/UDTTP/Lx4MsJt/wl2+WcZ7b2Z0s4HpThXP6jV56W5yzIDyoW5UJopxow1DIf+OUddw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=U6qdP3mMKvnmKn7YyujD+j/ep41Pw1sRSneXiEsdZm0=; b=OZR+SZHF/OLQ4By/b9gupxdEuZ0uZlDhSaBNI/F+qG4RYofY5Q+LSW6P83OKUJn/6w35VFmCaCg403u9GOoWMJ+4SWKfwFLB98N9JISOub/fYFIWh4tKYgY23XmlzcayOLahgVyNqNSKCjguWxZbc2fsB6PmlOIFCxNf8ooRh7h7J8AGQzcgaSjpUS86yojmYMC6mO9+/p5uFS94nQqQJGury7ASpteRjjbox/NuXqdWvR/J4ByNfPvQS23KOvp6tB7Rgk8q+O6Af0Wh8wRhx9EAQCSwEqSQJSkiOBg63oFdkQCLDuCR6jINjZsHoJB4YG1N6tydmvV8dvVj38rMnw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=U6qdP3mMKvnmKn7YyujD+j/ep41Pw1sRSneXiEsdZm0=; b=jXUI1zG96aW6fVQn4ElU/IbZRIn7XuWoyXZqtZNWdPcZztLYpshdvUpHhaNetMeyau2hOIyzflu8em8PQOoCoYO5nG8RN/B/wApuxLqyJL3uHQ8jZc/ObScohG+o7v1ulN0JBF9NrQPesjtKFGyTUIRRkMRR1v+KuHwHPwzZ4dc= From: Penny Zheng To: Jan Beulich CC: Bertrand Marquis , Wei Chen , "xen-devel@lists.xenproject.org" , "sstabellini@kernel.org" , Julien Grall Subject: RE: [PATCH 4/9] xen/arm: static memory initialization Thread-Topic: [PATCH 4/9] xen/arm: static memory initialization Thread-Index: AQHXW0b3OiAcoe7xDE2AVcNY0dwUCqsNAWAAgB/3qYCABuqiQIAANggw Date: Mon, 5 Jul 2021 07:14:51 +0000 Message-ID: References: <20210607024318.3988467-1-penny.zheng@arm.com> <20210607024318.3988467-5-penny.zheng@arm.com> <7f77349f-015e-83d3-d646-af9897e31348@xen.org> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: B630EF36C6B0AB4983EA6A5DD2F2D3EF.0 x-checkrecipientchecked: true Authentication-Results-Original: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [203.126.0.113] x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: 6a035659-f4e9-45a0-0cba-08d93f849a20 x-ms-traffictypediagnostic: VE1PR08MB5598:|AM5PR0801MB1892: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:8882;OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: N7vDkgRI8+BncMjQvH23gcCuDyiRzpFmKZvgjpOxFSWnX/Kh+MMeyRL0m/qzy/umFSQmt8mYGe9j37bOsHBaItbTN5qF9dn1WW2Pt6FcM0TaB/16IkHbBKtTyAP+Xkpc53O6lwqAykJOV5J23putfLOBevLmLsNg6KU3a6U94aLxrR4QTo2ca2yoGBB9nvJu579Sm3DFzqdTtnVqVNhexIQK0QWdKjKdoZtKMPXuh6e2O01noC5W9WKkNJjH1Sk0KTvm8mjsYLxjGvgrmuROXX1m6lY4oU3CvGszDwcWmRQNjAZgR/V8aq6n0xomBgfWlO5+g1drw7hCsVANq2FINCq9R9FBR7JMHKjd+MZVs9v+QZQ7UNWGONPWMeOWd+ZyA8GLzXo03cx3Au7y9DSfYcdRxlC72CRH4I9UGrizgVYhWnxTyjo//1UaWNBNuuF+9/372FT4bdq5GqiA7/LidZPOLe2/etmbmMJw37/rXO3Z0Eu4C7y/VNOKj1KwaIE/FUsvheTAeN7Nii3C6v2nwLXr3cEH46kz7H3/pnoIkusV91icTfUfcQnIIkWB11kb5Qs0kZ+3/zzb/OHLr5PVY+swlprCA5PDgqLod/6BahNlesZwhqVUmwpf5d9tv9VMYEiL1CiMOe0cyshDTiOt/g== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR08MB5215.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(346002)(376002)(396003)(39840400004)(136003)(26005)(186003)(55016002)(478600001)(53546011)(54906003)(2940100002)(122000001)(9686003)(52536014)(83380400001)(7696005)(8676002)(5660300002)(38100700002)(6916009)(71200400001)(316002)(66946007)(66476007)(76116006)(64756008)(66446008)(4326008)(2906002)(66556008)(6506007)(33656002)(8936002)(86362001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?QUM0OTFlUjkwcUU1VTZzWjI1NTdHVnZmNVllTWJrMXU1dm1YVlR6WFdrMGI3?= =?utf-8?B?MDdFMmZMZGhlOUN1Q3NIdE5zbnlUYnRETzNjazhYSVZLbmd2QXZZbjJUUmhY?= =?utf-8?B?ZVA2MnphaWc3ZmFJa2tDdWwvUVJ5ejAvYmcxTElqbHFIZkdsNjFHNzdLMDQ2?= =?utf-8?B?QTVIUC9UMkRNa05YM2ZZWVYwckdZN29UbWpWZ3FwSEVLdjZWWU81dUJHQTFN?= =?utf-8?B?TTBKL3ZvSXRxWUNXWnRCZFRUU21qSE8rby9iNERCQ3hidFczQlFzUFNXOUww?= =?utf-8?B?WW9hczNxT25XdEFicHdBd0lhOUpFMkFtdXdnK2FSM1dwZ3dWOGpETGZ4cmhJ?= =?utf-8?B?amFYeWFUTlRzb3RNMFVsNEV5Rk1XNnVTM1ZCMm9wcE5oamdUdWFxYnA3RVhu?= =?utf-8?B?dmtaTHltUmRyVGJnaUdyenN3K3JOR0hWUHIydStqRTEvb2hCSS9ubmxlK2pQ?= =?utf-8?B?WjBLNitTSmZ5YWxINkRaMzV4MEhkNUxmR1UrbmpqZFRzN1B6ZVZPOE9KVkdX?= =?utf-8?B?RVlGYjZUa3ZFa3dGSXduS2J0dVFJKzBJYVUwa1l3Q1lESDFzOENJMlhCUDlK?= =?utf-8?B?bGxRUDk4a0ZxMDZTcHZMNUlFWVFVbDhXVWRvTnRvSmxGRXJqVE0zUDNDck9F?= =?utf-8?B?cnMvZGZQS0oybnRwTjdxV2Z3c3BHTEMxT2dVWm1KQ3dxUCtqTzhNVnp1eEhW?= =?utf-8?B?UXd5bU5Nczk3Q0JmelpoRG91L3NFNDVMSlV0ZXRFZnd0TEdlL1lNV3hPV2Jn?= =?utf-8?B?SitKbHpPalgwS0ZKaDFud1Y3NitTK1ZYWmVhbXJ4UlJMRDM2TXRZLzBOaE9H?= =?utf-8?B?UC81dzUvaG9SOE9SVFFydTFkQTVyNWZ6eHVWa3VPMlI2U2Q3aFFLUWMvSjQ3?= =?utf-8?B?TXh0Y0hKY3pnUmFIWmlOdU5TNTlUT1FxWnI3V0lFSll6blV3Smw5WmhUbzNl?= =?utf-8?B?dmdpQkQ1UnE0WTFvQ0ZEaVRvOHNDOWhUWVp3R01GZzEzN3VISzhIWmtsOW5x?= =?utf-8?B?QThsMno2T0piZEY5eHFvZW1BbTF4WTByM0lMcUNib3FqRWZUSlNwV3dIR0U2?= =?utf-8?B?SjNpdjJyL3NsQ2kxSU52NElPUEs2VWhRTlR5R1hRT1JvcHRlKzFVOVZJMjFN?= =?utf-8?B?WWk4WUowZ0ppc0grRHE0V28xTDJFMSt6djh2T2sxbkEvZ0t6WlVNdVd2RUVi?= =?utf-8?B?RlZhWXo5ck5LcHNZbldPaFhNR3l1bTBOTFJIT2xSNjJwVUM5Mms0dElrMmpn?= =?utf-8?B?ZU0rUkl5NFcwcjlMeWE0VWtyeXdvcVNEYTY3YTFWbVZtU0hPem04Nk1wSmpZ?= =?utf-8?B?TGdRTEljU2hOUGlQT3NLRkduSlFiVlprM1ZNU0M2TklrdmtWOEdBY2t0Wld1?= =?utf-8?B?VEp3aWgzTXc3a2VsVEhzbjRadlJNdFFpQWRFY2tmOG91bjFxTzdRUnBvckVN?= =?utf-8?B?b3k4SzFMYnU2eG8vcGNuRHk4Z0hPNEk2ZGRGekJCNkRyTDRidmZPa0lPRkxR?= =?utf-8?B?OTZkVEJPSVZqUm5INm9BMGdYZTNSalhvRm1XNXZ0YUVyQlJZVjNFM2dFTXFS?= =?utf-8?B?czh3QnpFMWFNWmNsRExZQWVVdVdZODVqWjVoK0pNSCt0VGlGUlZIZ2FqMmlC?= =?utf-8?B?RnIzWFdxeUtXZElsUGtyQnB3Sm82dURsOE9ncDhkYmljSjhWWEo5cHZ6VlRZ?= =?utf-8?B?N2dGL1JlSHBVR0pYWEVCUzBrUFF3UW1KS2cwQTY3MGpCRjNVMm9mTjR3Tlhp?= =?utf-8?Q?aHLGJl5FW3TWGRCldnjELvhKTqD52mbpGQ/bM4I?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5598 Original-Authentication-Results: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT005.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: f0f5a155-5d02-4973-983c-08d93f8494ca X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8Y8yfUNpdKkqiPSwK4BpIe4sGmzqPiZI+Ty+JWNDczxPV6OkTC7YdSNuOe6BP9b7MLQLKOQfScfkS4vsb5lgdSAs4poWRLZqe9JgvBPo3RFHUItq7L3vBVwjnAOPx0Kb1qcDpzVrqnNG7HF6cdRwVBgkv3am4RSzuHWt/aC8IMi9zR0zemhUSDay0UpePF89xTwBkJEIxcvyicnAIL7AoKEwbAwYC9vEkBcbKWwJaUsVikVVk+GctRNyI4KX9QGFuM6AbfoxlHVlu55dKCFCoOc1DpDNlbvplIFPwsCfXvJ1ize+tsuL1W2ds7nIzDFn3ubIgW68s6a97KYZldUolfGDBbr/s+W6fXHZ9aXlU0q2Bl5aJILSXfEHGqd4FGXXkTwyXfgsglZ+06klLz92y7iCSVJ528l69qki3ly3DDY/pKD3GOSMzMuTvrChkApqRNp7XsSFbo3zlWh5BnsmqRk9iqw4SW+wvaXixT0rV4mwtSF7Cx+41iDA/FHhQWG5a2GURV6CMnE7wUXGI5dluU3mQ9hXbSYIH3XSE56B3pYSCdtJefuPaPnpALUZuITn9y/D6y81OsOw/rOMZ87LpDKp0DnT8oN1UAMykqgWTm3nWX/P951mrHOTRj6mIJoKqWmwbt3sTSOlVDHI03/ANb0GUSM9JLE6xQFs6oCslLiTbPjfY2TwHWijLRnpWWTw2AkiJLhwduuDKGxQb00ijA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(396003)(346002)(376002)(136003)(39850400004)(46966006)(36840700001)(4326008)(8676002)(86362001)(47076005)(2940100002)(7696005)(356005)(8936002)(33656002)(336012)(81166007)(54906003)(83380400001)(6862004)(316002)(70206006)(82310400003)(82740400003)(9686003)(70586007)(478600001)(53546011)(6506007)(186003)(52536014)(55016002)(36860700001)(2906002)(26005)(5660300002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2021 07:15:00.2461 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6a035659-f4e9-45a0-0cba-08d93f849a20 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT005.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0801MB1892 SGkgSmFuIA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IFBlbm55IFpo ZW5nDQo+IFNlbnQ6IE1vbmRheSwgSnVseSA1LCAyMDIxIDE6MjIgUE0NCj4gVG86IEp1bGllbiBH cmFsbCA8anVsaWVuQHhlbi5vcmc+OyBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+DQo+ IENjOiBCZXJ0cmFuZCBNYXJxdWlzIDxCZXJ0cmFuZC5NYXJxdWlzQGFybS5jb20+OyBXZWkgQ2hl bg0KPiA8V2VpLkNoZW5AYXJtLmNvbT47IHhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZzsN Cj4gc3N0YWJlbGxpbmlAa2VybmVsLm9yZw0KPiBTdWJqZWN0OiBSRTogW1BBVENIIDQvOV0geGVu L2FybTogc3RhdGljIG1lbW9yeSBpbml0aWFsaXphdGlvbg0KPiANCj4gSGkgSnVsaWVuIGFuZCBK YW4NCj4gDQo+ID4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gPiBGcm9tOiBKdWxpZW4g R3JhbGwgPGp1bGllbkB4ZW4ub3JnPg0KPiA+IFNlbnQ6IFRodXJzZGF5LCBKdWx5IDEsIDIwMjEg MTo0NiBBTQ0KPiA+IFRvOiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+OyBQZW5ueSBa aGVuZw0KPiA8UGVubnkuWmhlbmdAYXJtLmNvbT4NCj4gPiBDYzogQmVydHJhbmQgTWFycXVpcyA8 QmVydHJhbmQuTWFycXVpc0Bhcm0uY29tPjsgV2VpIENoZW4NCj4gPiA8V2VpLkNoZW5AYXJtLmNv bT47IHhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZzsNCj4gPiBzc3RhYmVsbGluaUBrZXJu ZWwub3JnDQo+ID4gU3ViamVjdDogUmU6IFtQQVRDSCA0LzldIHhlbi9hcm06IHN0YXRpYyBtZW1v cnkgaW5pdGlhbGl6YXRpb24NCj4gPg0KPiA+IEhpLA0KPiA+DQo+ID4gT24gMTAvMDYvMjAyMSAx MDozNSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+ID4gPiBPbiAwNy4wNi4yMDIxIDA0OjQzLCBQZW5u eSBaaGVuZyB3cm90ZToNCj4gPiA+PiAtLS0gYS94ZW4vYXJjaC9hcm0vc2V0dXAuYw0KPiA+ID4+ ICsrKyBiL3hlbi9hcmNoL2FybS9zZXR1cC5jDQo+ID4gPj4gQEAgLTYxMSw2ICs2MTEsMzAgQEAg c3RhdGljIHZvaWQgX19pbml0IGluaXRfcGR4KHZvaWQpDQo+ID4gPj4gICAgICAgfQ0KPiA+ID4+ ICAgfQ0KPiA+ID4+DQo+ID4gPj4gKy8qIFN0YXRpYyBtZW1vcnkgaW5pdGlhbGl6YXRpb24gKi8g c3RhdGljIHZvaWQgX19pbml0DQo+ID4gPj4gK2luaXRfc3RhdGljbWVtX3BhZ2VzKHZvaWQpIHsN Cj4gPiA+PiArICAgIGludCBiYW5rOw0KPiA+ID4NCj4gPiA+IFdoaWxlIEknbSBub3QgYSBtYWlu dGFpbmVyIG9mIHRoaXMgY29kZSwgSSdkIHN0aWxsIGxpa2UgdG8gcG9pbnQgb3V0DQo+ID4gPiB0 aGF0IHdoZXJldmVyIHBvc3NpYmxlIHdlIHByZWZlciAidW5zaWduZWQgaW50IiB3aGVuIGRlYWxp bmcgd2l0aA0KPiA+ID4gb25seSBub24tbmVnYXRpdmUgdmFsdWVzLCBhbmQgZXZlbiBtb3JlIHNv IHdoZW4gdXNpbmcgdGhlbSBhcyBhcnJheQ0KPiA+ID4gaW5kZXhlcy4NCj4gPg0KPiA+ICsxLg0K PiA+DQo+IA0KPiBVbmRlcnN0b29kLiBUaHguDQo+IA0KPiA+ID4NCj4gPiA+PiArICAgIC8qDQo+ ID4gPj4gKyAgICAgKiBUT0RPOiBDb25zaWRlcmluZyBOVU1BLXN1cHBvcnQgc2NlbmFyaW8uDQo+ ID4gPj4gKyAgICAgKi8NCj4gPiA+DQo+ID4gPiBOaXQ6IENvbW1lbnQgc3R5bGUuDQo+ID4gPg0K PiANCj4gU3VyZSwgdGh4Lg0KPiANCj4gPiA+PiBAQCAtODcyLDYgKzg5Niw5IEBAIHZvaWQgX19p bml0IHN0YXJ0X3hlbih1bnNpZ25lZCBsb25nDQo+ID4gYm9vdF9waHlzX29mZnNldCwNCj4gPiA+ PiAgICAgICBjbWRsaW5lX3BhcnNlKGNtZGxpbmUpOw0KPiA+ID4+DQo+ID4gPj4gICAgICAgc2V0 dXBfbW0oKTsNCj4gPiA+PiArICAgIC8qIElmIGV4aXN0cywgU3RhdGljIE1lbW9yeSBJbml0aWFs aXphdGlvbi4gKi8NCj4gPiA+PiArICAgIGlmICggYm9vdGluZm8uc3RhdGljX21lbS5ucl9iYW5r cyA+IDAgKQ0KPiA+ID4+ICsgICAgICAgIGluaXRfc3RhdGljbWVtX3BhZ2VzKCk7DQo+ID4gPg0K PiA+ID4gSSBkb24ndCB0aGluayB0aGUgY29uZGl0aW9uYWwgaXMgcmVhbGx5IG5lZWRlZCBoZXJl Pw0KPiA+ID4NCj4gDQo+IFN1cmUsIHJpZ2h0Lg0KPiBMaWtlIHdoYXQgSnVsaWVuIHN1Z2dlc3Rz LCAgaW5pdF9zdGF0aWNtZW1fcGFnZXMoKSBpcyBhbHJlYWR5IGFibGUgdG8gY29wZQ0KPiB3aXRo IG5yX2JhbmtzID09IDAuDQo+IA0KPiA+ID4+IC0tLSBhL3hlbi9jb21tb24vcGFnZV9hbGxvYy5j DQo+ID4gPj4gKysrIGIveGVuL2NvbW1vbi9wYWdlX2FsbG9jLmMNCj4gPiA+PiBAQCAtMTM3Niw2 ICsxMzc2LDM3IEBAIGJvb2wgc2NydWJfZnJlZV9wYWdlcyh2b2lkKQ0KPiA+ID4+ICAgICAgIHJl dHVybiBub2RlX3RvX3NjcnViKGZhbHNlKSAhPSBOVU1BX05PX05PREU7DQo+ID4gPj4gICB9DQo+ ID4gPj4NCj4gPiA+PiArc3RhdGljIHZvaWQgZnJlZV9wYWdlKHN0cnVjdCBwYWdlX2luZm8gKnBn LCBib29sIG5lZWRfc2NydWIpIHsNCj4gPiA+PiArICAgIG1mbl90IG1mbiA9IHBhZ2VfdG9fbWZu KHBnKTsNCj4gPiA+DQo+ID4gPiBXaXRoIHBkeCBjb21wcmVzc2lvbiB0aGlzIGlzIGEgbm9uLXRy aXZpYWwgY29udmVyc2lvbi4gVGhlIGZ1bmN0aW9uDQo+ID4gPiBiZWluZyBhbiBpbnRlcm5hbCBo ZWxwZXIgYW5kIHRoZSBjYWxsZXIgYWxyZWFkeSBob2xkaW5nIHRoZSBNRk4sIEkNCj4gPiA+IHRo aW5rIGl0IHdvdWxkIGJlIHByZWZlcmFibGUgaWYgdGhlIE1GTiB3YXMgcGFzc2VkIGluIGhlcmUu IElmIGRvbmUNCj4gPiA+IHRoaXMgd2F5LCB5b3UgbWF5IHdhbnQgdG8gY29uc2lkZXIgYWRkaW5n IGFuIEFTU0VSVCgpIHRvIGRvdWJsZQ0KPiA+ID4gY2hlY2sgYm90aCBwYXNzZWQgaW4gYXJndW1l bnRzIG1hdGNoIHVwLg0KPiA+ID4NCj4gDQo+IFRoYW5rIGZvciB0aGUgc3VnZ2VzdGlvbn4NCj4g DQoNCldoaWxlIGFwcGx5aW5nIHlvdXIgc3VnZ2VzdGlvbiBoZXJlLCBpZiBhZGRpbmcgYW4gQVNT RVJUKCkgdG8gZG91YmxlIGNoZWNrIGJvdGggcGFzc2VkLWluDQphcmd1bWVudHMgbWF0Y2ggdXAs IGVpdGhlciB1c2UgbGlrZSBwYWdlX3RvX21mbiB0byBlc3RhYmxpc2ggY29ubmVjdGlvbiwgd2hp Y2ggaXMgYWJzb2x1dGVseQ0KdW5hY2NlcHRhYmxlLCBvciBwYXNzIG1vcmUgcGFyYW1ldGVycyBs aWtlIGJhc2UgcGFnZS9tZm4gdG8gY29tcGFyZSB0aGUgb2Zmc2V0LiBIbW1tLA0KSSBhbSBub3Qg aW4gZmF2b3Igb2YgdGhpcywgIHNpbmNlIGJvdGggZXh0cmEgcGFyYW1ldGVycyBhcmUgb25seSB1 c2VkIGluIGFzc2VydGlvbiBvbmx5LiANCiANCj4gPiA+PiArICAgIC8qIElmIGEgcGFnZSBoYXMg bm8gb3duZXIgaXQgd2lsbCBuZWVkIG5vIHNhZmV0eSBUTEIgZmx1c2guICovDQo+ID4gPj4gKyAg ICBwZy0+dS5mcmVlLm5lZWRfdGxiZmx1c2ggPSAocGFnZV9nZXRfb3duZXIocGcpICE9IE5VTEwp Ow0KPiA+ID4+ICsgICAgaWYgKCBwZy0+dS5mcmVlLm5lZWRfdGxiZmx1c2ggKQ0KPiA+ID4+ICsg ICAgICAgIHBhZ2Vfc2V0X3RsYmZsdXNoX3RpbWVzdGFtcChwZyk7DQo+ID4gPj4gKw0KPiA+ID4+ ICsgICAgLyogVGhpcyBwYWdlIGlzIG5vdCBhIGd1ZXN0IGZyYW1lIGFueSBtb3JlLiAqLw0KPiA+ ID4+ICsgICAgcGFnZV9zZXRfb3duZXIocGcsIE5VTEwpOyAvKiBzZXRfZ3Bmbl9mcm9tX21mbiBz bm9vcHMgcGcgb3duZXINCj4gPiAqLw0KPiA+ID4+ICsgICAgc2V0X2dwZm5fZnJvbV9tZm4obWZu X3gobWZuKSwgSU5WQUxJRF9NMlBfRU5UUlkpOw0KPiA+ID4+ICsNCj4gPiA+PiArI2lmZGVmIENP TkZJR19BUk0NCj4gPiA+DQo+ID4gPiBJZiBhdm9pZGFibGUgdGhlcmUgc2hvdWxkIGJlIG5vIGFy Y2gtc3BlY2lmaWMgY29kZSBhZGRlZCB0byB0aGlzIGZpbGUuDQo+ID4gPiBBc3N1bWluZyBhbm90 aGVyIGFyY2ggZ2FpbmVkIFBHQ19yZXNlcnZlZCwgd2hhdCdzIHdyb25nIHdpdGgNCj4gPiA+IGVu YWJsaW5nIHRoaXMgY29kZSByaWdodCBhd2F5IGZvciB0aGVtIGFzIHdlbGw/IEkuZS4gdXNlDQo+ ID4gPiBQR0NfcmVzZXJ2ZWQgaGVyZSBpbnN0ZWFkIG9mIENPTkZJR19BUk0/IEFsdGVybmF0aXZl bHkgdGhpcyBtYXkgd2FudA0KPiA+ID4gdG8gYmUgQ09ORklHX1NUQVRJQ19BTExPQ0FUSU9OLCBh c3N1bWluZyB3ZSBjb25zaWRlciBQR0NfcmVzZXJ2ZWQNCj4gPiA+IHRpZWQgdG8gaXQuDQo+ID4g Pg0KPiANCj4gVG8gbm90IGJyaW5nIGRlYWQgY29kZXMgaW4gb3RoZXIgYXJjaHMsIEknbGwgdXNl IG1vcmUgZ2VuZXJpYyBvcHRpb24NCj4gQ09ORklHX1NUQVRJQ19BTExPQ0FUSU9OLg0KPiANCj4g PiA+PiArICAgIGlmICggcGctPmNvdW50X2luZm8gJiBQR0NfcmVzZXJ2ZWQgKQ0KPiA+ID4+ICsg ICAgew0KPiA+ID4+ICsgICAgICAgIC8qIFRPRE86IGFzeW5jaHJvbm91cyBzY3J1YmJpbmcuICov DQo+ID4gPj4gKyAgICAgICAgaWYgKCBuZWVkX3NjcnViICkNCj4gPiA+PiArICAgICAgICAgICAg c2NydWJfb25lX3BhZ2UocGcpOw0KPiA+ID4+ICsgICAgICAgIHJldHVybjsNCj4gPiA+PiArICAg IH0NCj4gPiA+PiArI2VuZGlmDQo+ID4gPj4gKyAgICBpZiAoIG5lZWRfc2NydWIgKQ0KPiA+ID4N Cj4gPiA+IE5pdDogUGxlYXNlIGhhdmUgYSBibGFuayBsaW5lIGJldHdlZW4gdGhlc2UgbGFzdCB0 d28uDQo+ID4gPg0KPiANCj4gU3VyZS4gV2lsbCBkby4NCj4gDQo+ID4gPj4gKyAgICB7DQo+ID4g Pj4gKyAgICAgICAgcGctPmNvdW50X2luZm8gfD0gUEdDX25lZWRfc2NydWI7DQo+ID4gPj4gKyAg ICAgICAgcG9pc29uX29uZV9wYWdlKHBnKTsNCj4gPiA+PiArICAgIH0NCj4gPiA+PiArDQo+ID4g Pj4gKyAgICByZXR1cm47DQo+ID4gPg0KPiA+ID4gUGxlYXNlIG9taXQgcmV0dXJuIHN0YXRlbWVu dHMgYXQgdGhlIGVuZCBvZiBmdW5jdGlvbnMgcmV0dXJuaW5nIHZvaWQuDQo+ID4gPg0KPiANCj4g U3VyZSwgdGh4DQo+IA0KPiA+ID4+ICt9DQo+ID4gPg0KPiA+ID4gT24gdGhlIHdob2xlLCBiaWtl IHNoZWRkaW5nIG9yIG5vdCwgSSdtIGFmcmFpZCB0aGUgZnVuY3Rpb24ncyBuYW1lDQo+ID4gPiBk b2Vzbid0IG1hdGNoIHdoYXQgaXQgZG9lczogVGhlcmUncyBubyBmcmVlaW5nIG9mIGEgcGFnZSBo ZXJlLiBXaGF0DQo+ID4gPiBnZXRzIGRvbmUgaXMgbWFya2luZyBvZiBhIHBhZ2UgYXMgZnJlZS4g SGVuY2UgbWF5YmUgbWFya19wYWdlX2ZyZWUoKQ0KPiA+ID4gb3IgbWFya19mcmVlX3BhZ2UoKSBv ciBzb21lIHN1Y2g/DQo+ID4gPg0KPiANCj4gT2suIFRoeC4gQWx3YXlzIG5vdCBnb29kIGF0IGdp dmluZyBuYW1lcy4gSSdsbCB0YWtlIG1hcmtfcGFnZV9mcmVlKCkNCj4gDQo+ID4gPj4gQEAgLTE1 MTIsNiArMTUzMCwzOCBAQCBzdGF0aWMgdm9pZCBmcmVlX2hlYXBfcGFnZXMoDQo+ID4gPj4gICAg ICAgc3Bpbl91bmxvY2soJmhlYXBfbG9jayk7DQo+ID4gPj4gICB9DQo+ID4gPj4NCj4gPiA+PiAr I2lmZGVmIENPTkZJR19TVEFUSUNfQUxMT0NBVElPTg0KPiA+ID4+ICsvKiBFcXVpdmFsZW50IG9m IGZyZWVfaGVhcF9wYWdlcyB0byBmcmVlIG5yX21mbnMgcGFnZXMgb2Ygc3RhdGljDQo+ID4gPj4g K21lbW9yeS4gKi8gdm9pZCBfX2luaXQgZnJlZV9zdGF0aWNtZW1fcGFnZXMoc3RydWN0IHBhZ2Vf aW5mbyAqcGcsDQo+ID4gdW5zaWduZWQgbG9uZyBucl9tZm5zLA0KPiA+ID4+ICsgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBib29sIG5lZWRfc2NydWIpIHsNCj4gPiA+PiArICAgIG1m bl90IG1mbiA9IHBhZ2VfdG9fbWZuKHBnKTsNCj4gPiA+PiArICAgIHVuc2lnbmVkIGxvbmcgaTsN Cj4gPiA+PiArDQo+ID4gPj4gKyAgICBmb3IgKCBpID0gMDsgaSA8IG5yX21mbnM7IGkrKyApDQo+ ID4gPj4gKyAgICB7DQo+ID4gPj4gKyAgICAgICAgc3dpdGNoICggcGdbaV0uY291bnRfaW5mbyAm IFBHQ19zdGF0ZSApDQo+ID4gPj4gKyAgICAgICAgew0KPiA+ID4+ICsgICAgICAgIGNhc2UgUEdD X3N0YXRlX2ludXNlOg0KPiA+ID4+ICsgICAgICAgICAgICBCVUdfT04ocGdbaV0uY291bnRfaW5m byAmIFBHQ19icm9rZW4pOw0KPiA+ID4+ICsgICAgICAgICAgICAvKiBNYXJrIGl0IGZyZWUgYW5k IHJlc2VydmVkLiAqLw0KPiA+ID4+ICsgICAgICAgICAgICBwZ1tpXS5jb3VudF9pbmZvID0gUEdD X3N0YXRlX2ZyZWUgfCBQR0NfcmVzZXJ2ZWQ7DQo+ID4gPj4gKyAgICAgICAgICAgIGJyZWFrOw0K PiA+ID4+ICsNCj4gPiA+PiArICAgICAgICBkZWZhdWx0Og0KPiA+ID4+ICsgICAgICAgICAgICBw cmludGsoWEVOTE9HX0VSUg0KPiA+ID4+ICsgICAgICAgICAgICAgICAgICAgIlBhZ2Ugc3RhdGUg c2hhbGwgYmUgb25seSBpbiBQR0Nfc3RhdGVfaW51c2UuICINCj4gPiA+DQo+ID4gPiBXaHk/IEEg cGFnZSAoc3RhdGljIG9yIG5vdCkgY2FuIGJlY29tZSBicm9rZW4gd2hpbGUgaW4gdXNlLiBJT1cg SQ0KPiA+ID4gZG9uJ3QgdGhpbmsgeW91IGNhbiBhdm9pZCBoYW5kbGluZyBQR0Nfc3RhdGVfb2Zm bGluaW5nIGhlcmUuIEF0DQo+ID4gPiB3aGljaCBwb2ludCB0aGlzIGNvZGUgd2lsbCBtYXRjaCBm cmVlX2hlYXBfcGFnZXMoKSdlcywgYW5kIGhlbmNlDQo+ID4gPiBsaWtlbHkgd2lsbCB3YW50IGZv bGRpbmcgYXMgd2VsbC4NCj4gPiA+DQo+IA0KPiBZZWFoLCBJIHdhcyBmb2xsb3dpbmcgdGhlIGxv Z2ljIGluIGZyZWVfaGVhcF9wYWdlcy4NCj4gSG1tbSwgSSBjb3VsZCBub3QgdGhpbmsgb2YgYW55 IHNjZW5hcmlvIHRoYXQgd2lsbCBsZWFkIHRvIFBHQ19zdGF0ZV9vZmZsaW5pbmcsDQo+IHRoYXQn cyB3aHkgSSB3YXMgbm90IGluY2x1ZGluZyBpdCBhdCB0aGUgZmlyc3QgcGxhY2UuDQo+IEZvciBi cm9rZW4gaXNzdWUsIHRiaCwgSSBqdXN0IGNvcHkgdGhlIGJ1Z19vbiBmcm9tIGZyZWVfaGVhcF9w YWdlcywgYWZ0ZXINCj4gcXVpdGUgYSB0aW1lIHRoaW5raW5nLCBJIGFsc28gY291bGQgbm90IGZp bmQgYW55IHNjZW5hcmlvIHdoZW4gYSBwYWdlKHN0YXRpYyBvcg0KPiBub3QpIGNhbiBiZWNvbWUg YnJva2VuIHdoaWxlIGluIHVzZS4gOy8NCj4gDQo+ID4gPj4gLS0tIGEveGVuL2luY2x1ZGUveGVu L21tLmgNCj4gPiA+PiArKysgYi94ZW4vaW5jbHVkZS94ZW4vbW0uaA0KPiA+ID4+IEBAIC04NSw2 ICs4NSwxMiBAQCBib29sIHNjcnViX2ZyZWVfcGFnZXModm9pZCk7DQo+ID4gPj4gICB9IHdoaWxl ICggZmFsc2UgKQ0KPiA+ID4+ICAgI2RlZmluZSBGUkVFX1hFTkhFQVBfUEFHRShwKSBGUkVFX1hF TkhFQVBfUEFHRVMocCwgMCkNCj4gPiA+Pg0KPiA+ID4+ICsjaWZkZWYgQ09ORklHX0FSTQ0KPiA+ ID4NCj4gPiA+IElUWU0gQ09ORklHX1NUQVRJQ19BTExPQ0FUSU9OIGhlcmU/DQo+ID4gPg0KPiA+ ID4gSmFuDQo+ID4gPg0KPiA+DQo+ID4gLS0NCj4gPiBKdWxpZW4gR3JhbGwNCj4gDQo+IENoZWVy cw0KPiANCj4gLS0NCj4gUGVubnkgWmhlbmcNCg== From xen-devel-bounces@lists.xenproject.org Mon Jul 05 07:28:32 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Jul 2021 07:28:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149803.277072 (Exim 4.92) (envelope-from ) id 1m0J1n-0000XK-OR; Mon, 05 Jul 2021 07:28:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149803.277072; Mon, 05 Jul 2021 07:28:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0J1n-0000XD-LP; Mon, 05 Jul 2021 07:28:27 +0000 Received: by outflank-mailman (input) for mailman id 149803; Mon, 05 Jul 2021 07:28:25 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0J1l-0000X7-RW for xen-devel@lists.xenproject.org; Mon, 05 Jul 2021 07:28:25 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (unknown [40.107.20.63]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 94c6fa04-dd62-11eb-843e-12813bfff9fa; Mon, 05 Jul 2021 07:28:24 +0000 (UTC) Received: from DU2PR04CA0049.eurprd04.prod.outlook.com (2603:10a6:10:234::24) by AM0PR08MB5284.eurprd08.prod.outlook.com (2603:10a6:208:12a::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.31; Mon, 5 Jul 2021 07:28:21 +0000 Received: from DB5EUR03FT063.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:234:cafe::c) by DU2PR04CA0049.outlook.office365.com (2603:10a6:10:234::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.21 via Frontend Transport; Mon, 5 Jul 2021 07:28:21 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT063.mail.protection.outlook.com (10.152.20.209) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.22 via Frontend Transport; Mon, 5 Jul 2021 07:28:21 +0000 Received: ("Tessian outbound 80741586f868:v97"); Mon, 05 Jul 2021 07:28:21 +0000 Received: from 4b6eb623dbe7.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 1E58D255-31A6-4774-9E61-2234FCF6FD14.1; Mon, 05 Jul 2021 07:28:15 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 4b6eb623dbe7.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 05 Jul 2021 07:28:15 +0000 Received: from VE1PR08MB5215.eurprd08.prod.outlook.com (2603:10a6:803:10a::33) by VI1PR0802MB2493.eurprd08.prod.outlook.com (2603:10a6:800:b3::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.23; Mon, 5 Jul 2021 07:28:12 +0000 Received: from VE1PR08MB5215.eurprd08.prod.outlook.com ([fe80::2807:2ff9:e371:2918]) by VE1PR08MB5215.eurprd08.prod.outlook.com ([fe80::2807:2ff9:e371:2918%7]) with mapi id 15.20.4287.033; Mon, 5 Jul 2021 07:28:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 94c6fa04-dd62-11eb-843e-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EOIWWZIrA5H/6udCiFdhijsfZ4QzQqtstw3sX2CDyjo=; b=jzJ8Glsd5TE93jVEexXc0Ppmvk1ft/F5RUVt4Yp2b19ktb2WIAJPomRAXUeGAqq9xu8zrntJ9Zow54QjFDg9i49G9PrBlFIYLazyziGJsJPvW8ZjzMztR1s5ssGfWiKnpGvh27RdImZadnn39ImHSOanTF/UTq+1fUvMKU0D4o4= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QqT51YNvTis+Cidhhs2eKfDWWUZ+a8IaE4+HYYCTU2fcfmHsmDMr33UrVmpa0vwn6sDwi0VsLUWmNyxyAGBX6fkPZxIrl2tX80tqq7KktDo8QhqW9IW9IAg9WUq4ZTB6KU7PEPqhwLECbY90ricYM3ZQ2tFavpAH98V4tY6PJqhAgrLdIAcUW94GDgp2pOWp5NQmD4572Yy7BNAzyscuSyr13oW1kFVOGeKVbOaezDirkqvs7j0OJPSgSSEZ4BrsAdy+0StN7A5Qy+a9M8wyizdgMj0BUIBB9MMj1XNsY8gxG6PeqtJ0yRaQxvSQs2EIHoCczSrV8n2SyW1F+7BAgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EOIWWZIrA5H/6udCiFdhijsfZ4QzQqtstw3sX2CDyjo=; b=TlYVm6JO41qat4h/IB7tP8cLggbCUqHP8XjczAAPIdqYJwcsiY0ci1veJ9AZpmpCqRwc8i+iKdJGFPaqSb9IKjCkSrj3ZUg6mSQMrfHE9W7bbp2m/pN0aUtDC83mRPb+aMsHpRgqSAkj4I4fPdIV4vf/l3eq8dWIwDUCS6RW2usXCBgtrro/rIJcU8xvWN0miVZVwz0FuxPLz7wwF6t4Zi8giZo+pnXB2iAL1qyOvhQbe+HSOP9dwpHrH3nZrWYakbTicMXSWjKtLklL44Oc+htrnCOOPMySF2ymCasmcTWG+OIwkpz9MaGkpj9Hp12//yU7k2uHI3L7ZrmdvQt2cQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EOIWWZIrA5H/6udCiFdhijsfZ4QzQqtstw3sX2CDyjo=; b=jzJ8Glsd5TE93jVEexXc0Ppmvk1ft/F5RUVt4Yp2b19ktb2WIAJPomRAXUeGAqq9xu8zrntJ9Zow54QjFDg9i49G9PrBlFIYLazyziGJsJPvW8ZjzMztR1s5ssGfWiKnpGvh27RdImZadnn39ImHSOanTF/UTq+1fUvMKU0D4o4= From: Penny Zheng To: Julien Grall , "xen-devel@lists.xenproject.org" , "sstabellini@kernel.org" , "jbeulich@suse.com" CC: Bertrand Marquis , Wei Chen Subject: RE: [PATCH 4/9] xen/arm: static memory initialization Thread-Topic: [PATCH 4/9] xen/arm: static memory initialization Thread-Index: AQHXW0b3OiAcoe7xDE2AVcNY0dwUCqss/50AgAck2tA= Date: Mon, 5 Jul 2021 07:28:12 +0000 Message-ID: References: <20210607024318.3988467-1-penny.zheng@arm.com> <20210607024318.3988467-5-penny.zheng@arm.com> <1c6530bf-a362-0993-c4c5-953ee2afb1bf@xen.org> In-Reply-To: <1c6530bf-a362-0993-c4c5-953ee2afb1bf@xen.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 44ABA79DCBF4E44C96E21CA8D1C1C337.0 x-checkrecipientchecked: true Authentication-Results-Original: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com; x-originating-ip: [203.126.0.113] x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: 18dcb552-6dc6-438e-627c-08d93f867788 x-ms-traffictypediagnostic: VI1PR0802MB2493:|AM0PR08MB5284: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:4502;OLM:4502; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: JLSqBzp9+hxGVj+9cDFYa9RnOwUpP9kEZpjE5eRnyt8n4wUiGTPbFmAqmLvPKjuP8xvPBF8O69LTci5aC5titWecHbaH/o/kubVbNJaP5NBTXqbKtEyWMH8P6U7hlsg/weToF1tAWkn0trS2O8BBvEujs3NtvvLzcYObNne0XV7F7fsprwgoJsz8Bcdj9xTYZxNmkho8E3f8Rks3esKvWBudUTYqljaM0Vr0GtjMSoGsw+lNYtHCtA3kX1oqxoOM/TC3/HAmMDnZUBVElcCsEFTFqThKH5TwoNAe+T5FKBL/GAwD1RGN4fDyjmoG1rZe/8w310clHp73sguatLgBJUUM6zDKEa1NbBGkJC41l2hgbIENwX46s5k55xe/yzkPPKSfBSW4XS46xO4GFMBaAvwKjRsUtUrC0/E98D4BvZZDwDrFWDSrMTIwzhCeSFm6d/I+P7Z2I6M7/pBFdzJwX3hcak/VgSEUul3sgat6xzlVGpF75ADqrvWEzEEuTCHuZzEn2WoMk0KaaF856HL1324LtCgsKzNx/9qmnIskXjJjC7WxO/p956p1+uZ1QsCjlKkMJch6WGPEl0P7KPgQCcSCAnK5LuTN8rUMqKIWk9e21k0l8l3cVlwX+Y160NL3zmyoJkcM11nDnZm85vsPBQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR08MB5215.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(39850400004)(396003)(366004)(136003)(346002)(316002)(83380400001)(54906003)(110136005)(52536014)(9686003)(6506007)(53546011)(66476007)(7696005)(478600001)(55016002)(66446008)(64756008)(76116006)(26005)(66556008)(86362001)(66946007)(8936002)(71200400001)(2906002)(4326008)(122000001)(8676002)(33656002)(5660300002)(186003)(38100700002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: 6YhfUM2kUWcd34/sv02JtyDcAmRJ8KWRYxIpNBomLYqwYkMwuZc+bmg56uJVq+Hxfw5xOdLYWVv1uW7zETFLPjx+UIxHt685l1bcRZY2srENLe9Jq6cZ2OjLr7Xqw+OgL5HQUUM0FCJdXGg3Qf8zCo1Dnpuaj83jVcoSIixu6943P+t2i+JK+OzcDwA42FAVBQMIpHZr+87ilJeJJH+EYotdBMn/RY0SfkRSSNMhuDx5Q73m4ubtQlA6ruq9rJFDjjIzuEhF8I0OQIDIwTSCr7/JTkuSklnaGNFyPUWIeDqEkoF8uZZwPbmAQVBJVF3Fd1lzPyjuSaa8JUr1/WmJPCC9v0VTL13KWs/UWE0eMP78xmdpTfkMXTAFFNNnU+4CrDe27pX4lUeyleUGE38T0upH9XqJK2KimDguoyY68LZWo80bJHbivth1xA1IVfW+RWGsHNGt4E+E2LDTI7gKQV71SJ8zakfB+OTB30lBU/G5UirIILwF3PyVVxj7DeMbKEiJ6kJl+CPO1XTW4Ju/9JBHH2zXUH2Tf89Lz4Bv+gXKBdSJsGdRIANC9Rf/cdQcXOzdbF9g7m5Q3Y2w8wfGD8NvzmTYiyCl2xcnQh/ulu5MfJtGDYF9mBXfn7/WM3L1Mwaq0cxM6e1M3TZJd+RuXYaNl4iJifYnxAZCpLpsSPR79G6Ixp+BNO3oyHU6dLolksa4nx/U2RRBuzgh5uvgVS7K58WkEvlyuKnVhievBig= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0802MB2493 Original-Authentication-Results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT063.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: c4d2a849-028f-430a-510e-08d93f867239 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: phnXyqBPR7Q0wi0E0PeZxa2mXnHFjztrLkCnSFJI4jXObyttMBr7ykdDa2HMjDKWSH9ifhPwuvfNh/tHp39sGclabsGfhlbtzeSn27NKmtB8Fc+6GrGaXXLjiDaG/oB7nnNuEqS2gmGbSDD8iNV3wjF51UgM4TBYqtJGT5Zt+VE3QWpgVqAEzwXjZNo3oEVOw7Ff1xpjsYEqtoraHAli9iRKFk/TJPTTuFaXcEIpkxs7mnW+/s8WUFl+JYjctmXiah8XY2Q0GjnCbTp2qgmxDCvy6YbL+iqhbPmiHLPpKl60HGazuu4pvgCriOaMyH4MbBi8nYherpaXOf6PRlXVOg0mLvPIRukkyRVzvP44Ej+rYjcMs/AGxMBH0/iE2CdSxCqVIMblUJJObDnVi7mXg3jItjN/bhf2dNwt//keSjydmrr3CfJsOjxDd8+qnhGXe6bZxl4mrqoFFbKhiI7LlYEm0WilUIckDDddAbRfkF5DFZnnPvN9/G0hTOb5m0dqR5fPTQZ0QvrcoPlyDtOLmwzDsNOg4Hpy2B/qHk6oj3+noUlz9HKGwcucheFr+Vm5sZJx3OyleWD4qSp8dtteLuOrnDVFhn5XtqXvJjir4vcjA49OTVeK9dJQqN0umpaeHl//j+GsISGxArKwfq0P0Y+/XmfAv32eGZ5CUwxqytrYbxRDpwdcse5GUr9orN6bAFjfX4F+v74WfUJpU0ahPQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(376002)(396003)(39850400004)(136003)(346002)(36840700001)(46966006)(478600001)(7696005)(316002)(4326008)(47076005)(110136005)(81166007)(336012)(54906003)(83380400001)(70206006)(2906002)(70586007)(8936002)(8676002)(356005)(55016002)(5660300002)(36860700001)(9686003)(33656002)(26005)(82310400003)(186003)(86362001)(53546011)(52536014)(6506007)(82740400003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2021 07:28:21.3150 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 18dcb552-6dc6-438e-627c-08d93f867788 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT063.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB5284 SGkgSnVsaWVuDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogSnVsaWVu IEdyYWxsIDxqdWxpZW5AeGVuLm9yZz4NCj4gU2VudDogVGh1cnNkYXksIEp1bHkgMSwgMjAyMSAy OjEwIEFNDQo+IFRvOiBQZW5ueSBaaGVuZyA8UGVubnkuWmhlbmdAYXJtLmNvbT47IHhlbi1kZXZl bEBsaXN0cy54ZW5wcm9qZWN0Lm9yZzsNCj4gc3N0YWJlbGxpbmlAa2VybmVsLm9yZzsgamJldWxp Y2hAc3VzZS5jb20NCj4gQ2M6IEJlcnRyYW5kIE1hcnF1aXMgPEJlcnRyYW5kLk1hcnF1aXNAYXJt LmNvbT47IFdlaSBDaGVuDQo+IDxXZWkuQ2hlbkBhcm0uY29tPg0KPiBTdWJqZWN0OiBSZTogW1BB VENIIDQvOV0geGVuL2FybTogc3RhdGljIG1lbW9yeSBpbml0aWFsaXphdGlvbg0KPiANCj4gSGkg UGVubnksDQo+IA0KPiBPbiAwNy8wNi8yMDIxIDAzOjQzLCBQZW5ueSBaaGVuZyB3cm90ZToNCj4g PiBUaGlzIHBhdGNoIGludHJvZHVjZXMgc3RhdGljIG1lbW9yeSBpbml0aWFsaXphdGlvbiwgZHVy aW5nIHN5c3RlbSBSQU0gYm9vdA0KPiB1cC4NCj4gDQo+IFRoZSB3b3JkICJSQU0iIGxvb2tzIHNw dXJpb3VzLg0KPiANCg0KVGh4LiBJIGNoZWNrIHRoZSAic3B1cmlvdXMiIGluIGRpY3Rpb25hcnks IGl0IG1lYW5zIGZha2U/IFNvIEkgd2lsbCBsZWF2ZSAiZHVyaW5nIHN5c3RlbSBib290IHVwIg0K aGVyZS4NCg0KPiA+IE5ldyBmdW5jIGluaXRfc3RhdGljbWVtX3BhZ2VzIGlzIHJlc3BvbnNpYmxl IGZvciBzdGF0aWMgbWVtb3J5DQo+IGluaXRpYWxpemF0aW9uLg0KPiANCj4gcy9OZXcgZnVuYy9U aGUgbmV3IGZ1bmN0aW9uLw0KPg0KIA0KU3VyZS4gdGh4DQoNCj4gPiBIZWxwZXIgZnJlZV9zdGF0 aWNtZW1fcGFnZXMgaXMgdGhlIGVxdWl2YWxlbnQgb2YgZnJlZV9oZWFwX3BhZ2VzLCB0bw0KPiA+ IGZyZWUgbnJfbWZucyBwYWdlcyBvZiBzdGF0aWMgbWVtb3J5Lg0KPiA+DQo+ID4gVGhpcyBjb21t aXQgZGVmaW5lcyBhIG5ldyBoZWxwZXIgZnJlZV9wYWdlIHRvIGV4dHJhY3QgY29tbW9uIGNvZGUN Cj4gPiBiZXR3ZWVuIGZyZWVfaGVhcF9wYWdlcyBhbmQgZnJlZV9zdGF0aWNtZW1fcGFnZXMsIGxp a2UgZm9sbG93aW5nIHRoZQ0KPiA+IHNhbWUgY2FjaGUvVExCIGNvaGVyZW5jeSBwb2xpY3kuDQo+ ID4NCj4gPiBGb3IgZWFjaCBwYWdlLCBmcmVlX3N0YXRpY21lbV9wYWdlcyBpbmNsdWRlcyB0aGUg Zm9sbG93aW5nIGV4dHJhIHN0ZXBzDQo+ID4gdG8NCj4gPiBpbml0aWFsaXplOg0KPiA+IDEuIGNo YW5nZSBwYWdlIHN0YXRlIGZyb20gaW51c2UgdG8gZnJlZSBzdGF0ZSBhbmQgZ3JhbnQgUEdDX3Jl c2VydmVkLg0KPiANCj4gSSB0aGluayB5b3UgbWVhbiAic2V0IiByYXRoZXIgdGhhbiAiZ3JhbnQi Lg0KPiANCg0KWWVhaC4gIEknbGwgY2hhbmdlIHRvIHNldCBoZXJlfg0KDQo+ID4gMi4gc2NydWIg dGhlIHBhZ2UgaW4gbmVlZCBzeW5jaHJvbm91c2x5Lg0KPiANCj4gQ2FuIHlvdSBleHBsYWluIHdo eSB0aGlzIGlzIG5lY2Vzc2FyeT8NCj4NCg0KU2luY2UgSSdtIGJvcnJvd2luZyB0aGUgbG9naWMg aW4gZnJlZV9oZWFwX3BhZ2VzLCBJJ20gYWxzbyB0cnlpbmcgdG8gY292ZXIgYWxsIHRoZSBzY2Vu YXJpb3MgaGVyZSBsaWtlIGl0IGRvZXMuDQpTbyBJIGFzc3VtZSB0aGF0IGZyZWVfc3RhdGljbWVt X3BhZ2Ugd2lsbCBub3Qgb25seSBiZSB1c2VkIG9uIGluaXRpYWxpemF0aW9uLCBidXQgYWxzbyB3 aGVuIGRlc3Ryb3lpbmcvcmVib290aW5nIHRoZSBkb21haW4uDQpPbiB0aGVzZSBjYXNlcywgaXQg aXMgbmVjZXNzYXJ5IHRvIHNjcnViIHRoZSBwYWdlLCBpZy4NCiANCj4gPg0KPiA+IFNpZ25lZC1v ZmYtYnk6IFBlbm55IFpoZW5nIDxwZW5ueS56aGVuZ0Bhcm0uY29tPg0KPiA+IC0tLQ0KPiA+IGNo YW5nZXMgdjI6DQo+ID4gLSByZW5hbWUgdG8gbnJfbWZucw0KPiA+IC0gZXh0cmFjdCBjb21tb24g Y29kZSBmcm9tIGZyZWVfaGVhcF9wYWdlcyBhbmQgZnJlZV9zdGF0aWNtZW1fcGFnZXMNCj4gPiAt IHJlbW92ZSBkZWFkIGNvZGVzIGluIG90aGVyIGFyY2hzLCBpbmNsdWRpbmcgbW92ZSBzb21lIHRv DQo+ID4gYXJtLXNwZWNpZmljIGZpbGUsIGFuZCBwdXQgc29tZSB1bmRlciBDT05GSUdfQVJNDQo+ ID4gLSBtYXJrIGZyZWVfc3RhdGljbWVtX3BhZ2VzIF9faW5pdA0KPiA+IC0tLQ0KPiA+ICAgeGVu L2FyY2gvYXJtL3NldHVwLmMgICAgfCAyNyArKysrKysrKysrKysrKw0KPiANCj4gSSB0aGluayBp dCB3b3VsZCBiZSBiZXN0IHRvIHNwbGl0IHRoZSBhcm0gdXNlIGluIGEgc2VwYXJhdGUgcGF0Y2gu DQoNClN1cmUsIEknbGwgbW92ZSB0aGVtIHRvIGFub3RoZXIgY29tbWl0Lg0KDQo+IA0KPiA+ICAg eGVuL2NvbW1vbi9wYWdlX2FsbG9jLmMgfCA3OCArKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKystLS0NCj4gLS0tLS0NCj4gPiAgIHhlbi9pbmNsdWRlL3hlbi9tbS5oICAgIHwgIDYgKysr Kw0KPiA+ICAgMyBmaWxlcyBjaGFuZ2VkLCA5NyBpbnNlcnRpb25zKCspLCAxNCBkZWxldGlvbnMo LSkNCj4gPg0KPiA+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vc2V0dXAuYyBiL3hlbi9hcmNo L2FybS9zZXR1cC5jIGluZGV4DQo+ID4gMDBhYWQxYzE5NC4uZGFhZmVhMGFiYiAxMDA2NDQNCj4g PiAtLS0gYS94ZW4vYXJjaC9hcm0vc2V0dXAuYw0KPiA+ICsrKyBiL3hlbi9hcmNoL2FybS9zZXR1 cC5jDQo+ID4gQEAgLTYxMSw2ICs2MTEsMzAgQEAgc3RhdGljIHZvaWQgX19pbml0IGluaXRfcGR4 KHZvaWQpDQo+ID4gICAgICAgfQ0KPiA+ICAgfQ0KPiA+DQo+ID4gKy8qIFN0YXRpYyBtZW1vcnkg aW5pdGlhbGl6YXRpb24gKi8NCj4gPiArc3RhdGljIHZvaWQgX19pbml0IGluaXRfc3RhdGljbWVt X3BhZ2VzKHZvaWQpIHsNCj4gPiArICAgIGludCBiYW5rOw0KPiA+ICsNCj4gPiArICAgIC8qDQo+ ID4gKyAgICAgKiBUT0RPOiBDb25zaWRlcmluZyBOVU1BLXN1cHBvcnQgc2NlbmFyaW8uDQo+ID4g KyAgICAgKi8NCj4gPiArICAgIGZvciAoIGJhbmsgPSAwIDsgYmFuayA8IGJvb3RpbmZvLnN0YXRp Y19tZW0ubnJfYmFua3M7IGJhbmsrKyApDQo+ID4gKyAgICB7DQo+ID4gKyAgICAgICAgcGFkZHJf dCBiYW5rX3N0YXJ0ID0gYm9vdGluZm8uc3RhdGljX21lbS5iYW5rW2JhbmtdLnN0YXJ0Ow0KPiA+ ICsgICAgICAgIHBhZGRyX3QgYmFua19zaXplID0gYm9vdGluZm8uc3RhdGljX21lbS5iYW5rW2Jh bmtdLnNpemU7DQo+ID4gKyAgICAgICAgcGFkZHJfdCBiYW5rX2VuZCA9IGJhbmtfc3RhcnQgKyBi YW5rX3NpemU7DQo+ID4gKw0KPiA+ICsgICAgICAgIGJhbmtfc3RhcnQgPSByb3VuZF9wZ3VwKGJh bmtfc3RhcnQpOw0KPiA+ICsgICAgICAgIGJhbmtfZW5kID0gcm91bmRfcGdkb3duKGJhbmtfZW5k KTsNCj4gPiArICAgICAgICBpZiAoIGJhbmtfZW5kIDw9IGJhbmtfc3RhcnQgKQ0KPiA+ICsgICAg ICAgICAgICByZXR1cm47DQo+ID4gKw0KPiA+ICsgICAgICAgIGZyZWVfc3RhdGljbWVtX3BhZ2Vz KG1hZGRyX3RvX3BhZ2UoYmFua19zdGFydCksDQo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAoYmFua19lbmQgLSBiYW5rX3N0YXJ0KSA+PiBQQUdFX1NISUZULCBmYWxzZSk7DQo+ID4g KyAgICB9DQo+ID4gK30NCj4gPiArDQo+ID4gICAjaWZkZWYgQ09ORklHX0FSTV8zMg0KPiA+ICAg c3RhdGljIHZvaWQgX19pbml0IHNldHVwX21tKHZvaWQpDQo+ID4gICB7DQo+ID4gQEAgLTg3Miw2 ICs4OTYsOSBAQCB2b2lkIF9faW5pdCBzdGFydF94ZW4odW5zaWduZWQgbG9uZw0KPiBib290X3Bo eXNfb2Zmc2V0LA0KPiA+ICAgICAgIGNtZGxpbmVfcGFyc2UoY21kbGluZSk7DQo+ID4NCj4gPiAg ICAgICBzZXR1cF9tbSgpOw0KPiA+ICsgICAgLyogSWYgZXhpc3RzLCBTdGF0aWMgTWVtb3J5IElu aXRpYWxpemF0aW9uLiAqLw0KPiA+ICsgICAgaWYgKCBib290aW5mby5zdGF0aWNfbWVtLm5yX2Jh bmtzID4gMCApDQo+IA0KPiBUaGlzIGNoZWNrIHNlZW1zIGEgcG9pbnRsZXNzIGJlY2F1c2UgaW5p dF9zdGF0aWNtZW1fcGFnZXMoKSBpcyBhbHJlYWR5IGFibGUNCj4gdG8gY29wZSB3aXRoIG5yX2Jh bmtzID09IDAuDQo+IA0KPiA+ICsgICAgICAgIGluaXRfc3RhdGljbWVtX3BhZ2VzKCk7DQo+IEkg d291bGQgcHJlZmVyIGlmIHRoaXMgaXMgZm9sZGVkIGluIHNldHVwX21tKCkuDQo+DQoNClN1cmUu DQogDQo+ID4NCj4gPiAgICAgICAvKiBQYXJzZSB0aGUgQUNQSSB0YWJsZXMgZm9yIHBvc3NpYmxl IGJvb3QtdGltZSBjb25maWd1cmF0aW9uICovDQo+ID4gICAgICAgYWNwaV9ib290X3RhYmxlX2lu aXQoKTsNCj4gPiBkaWZmIC0tZ2l0IGEveGVuL2NvbW1vbi9wYWdlX2FsbG9jLmMgYi94ZW4vY29t bW9uL3BhZ2VfYWxsb2MuYyBpbmRleA0KPiA+IDk1OGJhMGNkOTIuLjhjMDAyNjJjMDQgMTAwNjQ0 DQo+ID4gLS0tIGEveGVuL2NvbW1vbi9wYWdlX2FsbG9jLmMNCj4gPiArKysgYi94ZW4vY29tbW9u L3BhZ2VfYWxsb2MuYw0KPiA+IEBAIC0xMzc2LDYgKzEzNzYsMzcgQEAgYm9vbCBzY3J1Yl9mcmVl X3BhZ2VzKHZvaWQpDQo+ID4gICAgICAgcmV0dXJuIG5vZGVfdG9fc2NydWIoZmFsc2UpICE9IE5V TUFfTk9fTk9ERTsNCj4gPiAgIH0NCj4gPg0KPiA+ICtzdGF0aWMgdm9pZCBmcmVlX3BhZ2Uoc3Ry dWN0IHBhZ2VfaW5mbyAqcGcsIGJvb2wgbmVlZF9zY3J1Yikgew0KPiA+ICsgICAgbWZuX3QgbWZu ID0gcGFnZV90b19tZm4ocGcpOw0KPiA+ICsNCj4gPiArICAgIC8qIElmIGEgcGFnZSBoYXMgbm8g b3duZXIgaXQgd2lsbCBuZWVkIG5vIHNhZmV0eSBUTEIgZmx1c2guICovDQo+ID4gKyAgICBwZy0+ dS5mcmVlLm5lZWRfdGxiZmx1c2ggPSAocGFnZV9nZXRfb3duZXIocGcpICE9IE5VTEwpOw0KPiA+ ICsgICAgaWYgKCBwZy0+dS5mcmVlLm5lZWRfdGxiZmx1c2ggKQ0KPiA+ICsgICAgICAgIHBhZ2Vf c2V0X3RsYmZsdXNoX3RpbWVzdGFtcChwZyk7DQo+ID4gKw0KPiA+ICsgICAgLyogVGhpcyBwYWdl IGlzIG5vdCBhIGd1ZXN0IGZyYW1lIGFueSBtb3JlLiAqLw0KPiA+ICsgICAgcGFnZV9zZXRfb3du ZXIocGcsIE5VTEwpOyAvKiBzZXRfZ3Bmbl9mcm9tX21mbiBzbm9vcHMgcGcgb3duZXIgKi8NCj4g PiArICAgIHNldF9ncGZuX2Zyb21fbWZuKG1mbl94KG1mbiksIElOVkFMSURfTTJQX0VOVFJZKTsN Cj4gPiArDQo+ID4gKyNpZmRlZiBDT05GSUdfQVJNDQo+IA0KPiBUbyBlY2hvIHdoYXQgSmFuIGFs cmVhZHkgd3JvdGUsIEkgYW0gbm90IGluIGZhdm9yIG9mIGFkZGluZyBuZXcgI2lmZGVmDQo+IENP TkZJR188YXJjaD4gaW4gY29tbW9uIGNvZGUuIEkgd291bGQgZXhwZWN0IHRoZSBsb2dpYyBmb3Ig c3RhdGljIG1lbW9yeQ0KPiB0byBiZSB0aGUgc2FtZSBmb3IgZWFjaCBhcmNoLCBzbyB0aGlzIHNo b3VsZCBiZSBwcm90ZWN0ZWQgd2l0aCBhIGdlbmVyaWMNCj4gS2NvbmZpZy4NCj4gDQo+ID4gKyAg ICBpZiAoIHBnLT5jb3VudF9pbmZvICYgUEdDX3Jlc2VydmVkICkNCj4gPiArICAgIHsNCj4gPiAr ICAgICAgICAvKiBUT0RPOiBhc3luY2hyb25vdXMgc2NydWJiaW5nLiAqLw0KPiA+ICsgICAgICAg IGlmICggbmVlZF9zY3J1YiApDQo+ID4gKyAgICAgICAgICAgIHNjcnViX29uZV9wYWdlKHBnKTsN Cj4gPiArICAgICAgICByZXR1cm47DQo+ID4gKyAgICB9DQo+ID4gKyNlbmRpZg0KPiA+ICsgICAg aWYgKCBuZWVkX3NjcnViICkNCj4gPiArICAgIHsNCj4gPiArICAgICAgICBwZy0+Y291bnRfaW5m byB8PSBQR0NfbmVlZF9zY3J1YjsNCj4gPiArICAgICAgICBwb2lzb25fb25lX3BhZ2UocGcpOw0K PiA+ICsgICAgfQ0KPiA+ICsNCj4gPiArICAgIHJldHVybjsNCj4gPiArfQ0KPiA+ICsNCj4gPiAg IC8qIEZyZWUgMl5Ab3JkZXIgc2V0IG9mIHBhZ2VzLiAqLw0KPiA+ICAgc3RhdGljIHZvaWQgZnJl ZV9oZWFwX3BhZ2VzKA0KPiA+ICAgICAgIHN0cnVjdCBwYWdlX2luZm8gKnBnLCB1bnNpZ25lZCBp bnQgb3JkZXIsIGJvb2wgbmVlZF9zY3J1YikgQEANCj4gPiAtMTQyNSwyMCArMTQ1Niw3IEBAIHN0 YXRpYyB2b2lkIGZyZWVfaGVhcF9wYWdlcygNCj4gPiAgICAgICAgICAgICAgIEJVRygpOw0KPiA+ ICAgICAgICAgICB9DQo+ID4NCj4gPiAtICAgICAgICAvKiBJZiBhIHBhZ2UgaGFzIG5vIG93bmVy IGl0IHdpbGwgbmVlZCBubyBzYWZldHkgVExCIGZsdXNoLiAqLw0KPiA+IC0gICAgICAgIHBnW2ld LnUuZnJlZS5uZWVkX3RsYmZsdXNoID0gKHBhZ2VfZ2V0X293bmVyKCZwZ1tpXSkgIT0gTlVMTCk7 DQo+ID4gLSAgICAgICAgaWYgKCBwZ1tpXS51LmZyZWUubmVlZF90bGJmbHVzaCApDQo+ID4gLSAg ICAgICAgICAgIHBhZ2Vfc2V0X3RsYmZsdXNoX3RpbWVzdGFtcCgmcGdbaV0pOw0KPiA+IC0NCj4g PiAtICAgICAgICAvKiBUaGlzIHBhZ2UgaXMgbm90IGEgZ3Vlc3QgZnJhbWUgYW55IG1vcmUuICov DQo+ID4gLSAgICAgICAgcGFnZV9zZXRfb3duZXIoJnBnW2ldLCBOVUxMKTsgLyogc2V0X2dwZm5f ZnJvbV9tZm4gc25vb3BzIHBnDQo+IG93bmVyICovDQo+ID4gLSAgICAgICAgc2V0X2dwZm5fZnJv bV9tZm4obWZuX3gobWZuKSArIGksIElOVkFMSURfTTJQX0VOVFJZKTsNCj4gPiAtDQo+ID4gLSAg ICAgICAgaWYgKCBuZWVkX3NjcnViICkNCj4gPiAtICAgICAgICB7DQo+ID4gLSAgICAgICAgICAg IHBnW2ldLmNvdW50X2luZm8gfD0gUEdDX25lZWRfc2NydWI7DQo+ID4gLSAgICAgICAgICAgIHBv aXNvbl9vbmVfcGFnZSgmcGdbaV0pOw0KPiA+IC0gICAgICAgIH0NCj4gPiArICAgICAgICBmcmVl X3BhZ2UoJnBnW2ldLCBuZWVkX3NjcnViKTsNCj4gPiAgICAgICB9DQo+ID4NCj4gPiAgICAgICBh dmFpbFtub2RlXVt6b25lXSArPSAxIDw8IG9yZGVyOyBAQCAtMTUxMiw2ICsxNTMwLDM4IEBAIHN0 YXRpYw0KPiA+IHZvaWQgZnJlZV9oZWFwX3BhZ2VzKA0KPiA+ICAgICAgIHNwaW5fdW5sb2NrKCZo ZWFwX2xvY2spOw0KPiA+ICAgfQ0KPiA+DQo+ID4gKyNpZmRlZiBDT05GSUdfU1RBVElDX0FMTE9D QVRJT04NCj4gPiArLyogRXF1aXZhbGVudCBvZiBmcmVlX2hlYXBfcGFnZXMgdG8gZnJlZSBucl9t Zm5zIHBhZ2VzIG9mIHN0YXRpYw0KPiA+ICttZW1vcnkuICovIHZvaWQgX19pbml0IGZyZWVfc3Rh dGljbWVtX3BhZ2VzKHN0cnVjdCBwYWdlX2luZm8gKnBnLA0KPiB1bnNpZ25lZCBsb25nIG5yX21m bnMsDQo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGJvb2wgbmVlZF9zY3J1 Yikgew0KPiA+ICsgICAgbWZuX3QgbWZuID0gcGFnZV90b19tZm4ocGcpOw0KPiA+ICsgICAgdW5z aWduZWQgbG9uZyBpOw0KPiA+ICsNCj4gPiArICAgIGZvciAoIGkgPSAwOyBpIDwgbnJfbWZuczsg aSsrICkNCj4gPiArICAgIHsNCj4gPiArICAgICAgICBzd2l0Y2ggKCBwZ1tpXS5jb3VudF9pbmZv ICYgUEdDX3N0YXRlICkNCj4gPiArICAgICAgICB7DQo+ID4gKyAgICAgICAgY2FzZSBQR0Nfc3Rh dGVfaW51c2U6DQo+ID4gKyAgICAgICAgICAgIEJVR19PTihwZ1tpXS5jb3VudF9pbmZvICYgUEdD X2Jyb2tlbik7DQo+ID4gKyAgICAgICAgICAgIC8qIE1hcmsgaXQgZnJlZSBhbmQgcmVzZXJ2ZWQu ICovDQo+ID4gKyAgICAgICAgICAgIHBnW2ldLmNvdW50X2luZm8gPSBQR0Nfc3RhdGVfZnJlZSB8 IFBHQ19yZXNlcnZlZDsNCj4gPiArICAgICAgICAgICAgYnJlYWs7DQo+ID4gKw0KPiA+ICsgICAg ICAgIGRlZmF1bHQ6DQo+ID4gKyAgICAgICAgICAgIHByaW50ayhYRU5MT0dfRVJSDQo+ID4gKyAg ICAgICAgICAgICAgICAgICAiUGFnZSBzdGF0ZSBzaGFsbCBiZSBvbmx5IGluIFBHQ19zdGF0ZV9p bnVzZS4gIg0KPiA+ICsgICAgICAgICAgICAgICAgICAgInBnWyVsdV0gTUZOICUiUFJJX21mbiIg Y291bnRfaW5mbz0lI2x4DQo+IHRsYmZsdXNoX3RpbWVzdGFtcD0lI3guXG4iLA0KPiA+ICsgICAg ICAgICAgICAgICAgICAgaSwgbWZuX3gobWZuKSArIGksDQo+ID4gKyAgICAgICAgICAgICAgICAg ICBwZ1tpXS5jb3VudF9pbmZvLA0KPiA+ICsgICAgICAgICAgICAgICAgICAgcGdbaV0udGxiZmx1 c2hfdGltZXN0YW1wKTsNCj4gPiArICAgICAgICAgICAgQlVHKCk7DQo+ID4gKyAgICAgICAgfQ0K PiA+ICsNCj4gPiArICAgICAgICBmcmVlX3BhZ2UoJnBnW2ldLCBuZWVkX3NjcnViKTsNCj4gPiAr ICAgIH0NCj4gPiArfQ0KPiA+ICsjZW5kaWYNCj4gPg0KPiA+ICAgLyoNCj4gPiAgICAqIEZvbGxv d2luZyBydWxlcyBhcHBsaWVkIGZvciBwYWdlIG9mZmxpbmU6DQo+ID4gZGlmZiAtLWdpdCBhL3hl bi9pbmNsdWRlL3hlbi9tbS5oIGIveGVuL2luY2x1ZGUveGVuL21tLmggaW5kZXgNCj4gPiA2Njdm OWRhYzgzLi5kZjI1ZTU1OTY2IDEwMDY0NA0KPiA+IC0tLSBhL3hlbi9pbmNsdWRlL3hlbi9tbS5o DQo+ID4gKysrIGIveGVuL2luY2x1ZGUveGVuL21tLmgNCj4gPiBAQCAtODUsNiArODUsMTIgQEAg Ym9vbCBzY3J1Yl9mcmVlX3BhZ2VzKHZvaWQpOw0KPiA+ICAgfSB3aGlsZSAoIGZhbHNlICkNCj4g PiAgICNkZWZpbmUgRlJFRV9YRU5IRUFQX1BBR0UocCkgRlJFRV9YRU5IRUFQX1BBR0VTKHAsIDAp DQo+ID4NCj4gPiArI2lmZGVmIENPTkZJR19BUk0NCj4gPiArLyogU3RhdGljIEFsbG9jYXRpb24g Ki8NCj4gPiArdm9pZCBmcmVlX3N0YXRpY21lbV9wYWdlcyhzdHJ1Y3QgcGFnZV9pbmZvICpwZywg dW5zaWduZWQgbG9uZyBucl9tZm5zLA0KPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgIGJv b2wgbmVlZF9zY3J1Yik7ICNlbmRpZg0KPiA+ICsNCj4gPiAgIC8qIE1hcCBtYWNoaW5lIHBhZ2Ug cmFuZ2UgaW4gWGVuIHZpcnR1YWwgYWRkcmVzcyBzcGFjZS4gKi8NCj4gPiAgIGludCBtYXBfcGFn ZXNfdG9feGVuKA0KPiA+ICAgICAgIHVuc2lnbmVkIGxvbmcgdmlydCwNCj4gPg0KPiANCj4gLS0N Cj4gSnVsaWVuIEdyYWxsDQoNCg0KQ2hlZXJzDQpQZW5ueSBaaGVuZw0K From xen-devel-bounces@lists.xenproject.org Mon Jul 05 07:30:03 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Jul 2021 07:30:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149809.277084 (Exim 4.92) (envelope-from ) id 1m0J3L-0001VC-Aa; Mon, 05 Jul 2021 07:30:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149809.277084; Mon, 05 Jul 2021 07:30:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0J3L-0001Ue-5A; Mon, 05 Jul 2021 07:30:03 +0000 Received: by outflank-mailman (input) for mailman id 149809; Mon, 05 Jul 2021 07:30:01 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0J3J-0001FO-Jv for xen-devel@lists.xenproject.org; Mon, 05 Jul 2021 07:30:01 +0000 Received: from mail-pf1-x429.google.com (unknown [2607:f8b0:4864:20::429]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 702f6c54-ffd1-49b2-b710-ae2a79d9f25a; Mon, 05 Jul 2021 07:30:00 +0000 (UTC) Received: by mail-pf1-x429.google.com with SMTP id w22so12309991pff.5 for ; Mon, 05 Jul 2021 00:30:00 -0700 (PDT) Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com. [209.85.215.171]) by smtp.gmail.com with ESMTPSA id s15sm11879290pfu.97.2021.07.05.00.29.57 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 Jul 2021 00:29:58 -0700 (PDT) Received: by mail-pg1-f171.google.com with SMTP id g22so17490857pgl.7 for ; Mon, 05 Jul 2021 00:29:57 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 702f6c54-ffd1-49b2-b710-ae2a79d9f25a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Z8aOTxpCpkipy5n3d0JHyfRjSSgUP3aCWoPMsdbSOV4=; b=MJjJv9vXGkq68MzcWqJ8Lqqow7NxZ75tHGPZbYF1jhN9Bhg/MWiZ0zY75eGHeJNh5Z PszBTQni1VZca3yQMBDVtTmKafxxH3GNCEriEJqlKouIDe5e4/R1nL0etnQNDybC+N/V LRgX2z3bSUPhZ4K1Wms/UIusjY+z2apf3AHmo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Z8aOTxpCpkipy5n3d0JHyfRjSSgUP3aCWoPMsdbSOV4=; b=UH1Z9k+wPbL0CiezMW61kN4b656e8gZT5JinId7SP2BS9TwCpOCTrCInQhj/ZPVPcc B5Lczi7TIQb1U4WdoXp4cIVkCC73XQ4iX2sBHlIlDzYqXsq1yEUuWRabP2YXOh19Wss/ GZlIH/gKLwB2Ba5JG/k2X608WMwUiOioFBLnI4vMDunkJVI7qACQttT4CTsTi1o6OS3u DFRMoR+XXfBveQXvlxHaYimkKcnOVlIgBYObhDWvHAL4w+qFxiW5+nJjWh8B6Knb2Dbv faXq54EFegFWy9O4nPC/6WHr7hWRja1IGtzcKHU1AHHlojwcPKBs4W+xHfm3Bkn5xRtq XRAg== X-Gm-Message-State: AOAM533oBXQtWEF+Rt0DV0KnbUO/CvmmbR9YVAZdYrzPK28jF7GmT5/4 FydYLSFKGJ5JnfuyiLRscUek6rs3apQYvA== X-Google-Smtp-Source: ABdhPJx2yZMmjHVybKWROgzYM78vdzP/2HMB58SzgCyEqZx6AXYDtNzhi4UZl0UnNU9Y2NzsMU434Q== X-Received: by 2002:a65:6a46:: with SMTP id o6mr13956099pgu.305.1625470199045; Mon, 05 Jul 2021 00:29:59 -0700 (PDT) X-Received: by 2002:a92:d10:: with SMTP id 16mr9764177iln.189.1625470185557; Mon, 05 Jul 2021 00:29:45 -0700 (PDT) MIME-Version: 1.0 References: <20210624155526.2775863-1-tientzu@chromium.org> <20210624155526.2775863-7-tientzu@chromium.org> <20210630114348.GA8383@willie-the-truck> <20210701074045.GA9436@willie-the-truck> <20210702135856.GB11132@willie-the-truck> <0f7bd903-e309-94a0-21d7-f0e8e9546018@arm.com> In-Reply-To: From: Claire Chang Date: Mon, 5 Jul 2021 15:29:34 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v15 06/12] swiotlb: Use is_swiotlb_force_bounce for swiotlb data bouncing To: Nathan Chancellor Cc: Robin Murphy , Will Deacon , Rob Herring , mpe@ellerman.id.au, Joerg Roedel , Frank Rowand , Konrad Rzeszutek Wilk , boris.ostrovsky@oracle.com, jgross@suse.com, Christoph Hellwig , Marek Szyprowski , benh@kernel.crashing.org, paulus@samba.org, "list@263.net:IOMMU DRIVERS" , Stefano Stabellini , grant.likely@arm.com, xypron.glpk@gmx.de, Thierry Reding , mingo@kernel.org, bauerman@linux.ibm.com, peterz@infradead.org, Greg KH , Saravana Kannan , "Rafael J . Wysocki" , heikki.krogerus@linux.intel.com, Andy Shevchenko , Randy Dunlap , Dan Williams , Bartosz Golaszewski , linux-devicetree , lkml , linuxppc-dev@lists.ozlabs.org, xen-devel@lists.xenproject.org, Nicolas Boichat , Jim Quinlan , Tomasz Figa , bskeggs@redhat.com, Bjorn Helgaas , chris@chris-wilson.co.uk, Daniel Vetter , airlied@linux.ie, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, jani.nikula@linux.intel.com, Jianxiong Gao , joonas.lahtinen@linux.intel.com, linux-pci@vger.kernel.org, maarten.lankhorst@linux.intel.com, matthew.auld@intel.com, rodrigo.vivi@intel.com, thomas.hellstrom@linux.intel.com, Tom Lendacky , Qian Cai Content-Type: text/plain; charset="UTF-8" On Sat, Jul 3, 2021 at 1:55 PM Nathan Chancellor wrote: > > Hi Will and Robin, > > On Fri, Jul 02, 2021 at 04:13:50PM +0100, Robin Murphy wrote: > > On 2021-07-02 14:58, Will Deacon wrote: > > > Hi Nathan, > > > > > > On Thu, Jul 01, 2021 at 12:52:20AM -0700, Nathan Chancellor wrote: > > > > On 7/1/2021 12:40 AM, Will Deacon wrote: > > > > > On Wed, Jun 30, 2021 at 08:56:51AM -0700, Nathan Chancellor wrote: > > > > > > On Wed, Jun 30, 2021 at 12:43:48PM +0100, Will Deacon wrote: > > > > > > > On Wed, Jun 30, 2021 at 05:17:27PM +0800, Claire Chang wrote: > > > > > > > > `BUG: unable to handle page fault for address: 00000000003a8290` and > > > > > > > > the fact it crashed at `_raw_spin_lock_irqsave` look like the memory > > > > > > > > (maybe dev->dma_io_tlb_mem) was corrupted? > > > > > > > > The dev->dma_io_tlb_mem should be set here > > > > > > > > (https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/pci/probe.c#n2528) > > > > > > > > through device_initialize. > > > > > > > > > > > > > > I'm less sure about this. 'dma_io_tlb_mem' should be pointing at > > > > > > > 'io_tlb_default_mem', which is a page-aligned allocation from memblock. > > > > > > > The spinlock is at offset 0x24 in that structure, and looking at the > > > > > > > register dump from the crash: > > > > > > > > > > > > > > Jun 29 18:28:42 hp-4300G kernel: RSP: 0018:ffffadb4013db9e8 EFLAGS: 00010006 > > > > > > > Jun 29 18:28:42 hp-4300G kernel: RAX: 00000000003a8290 RBX: 0000000000000000 RCX: ffff8900572ad580 > > > > > > > Jun 29 18:28:42 hp-4300G kernel: RDX: ffff89005653f024 RSI: 00000000000c0000 RDI: 0000000000001d17 > > > > > > > Jun 29 18:28:42 hp-4300G kernel: RBP: 000000000a20d000 R08: 00000000000c0000 R09: 0000000000000000 > > > > > > > Jun 29 18:28:42 hp-4300G kernel: R10: 000000000a20d000 R11: ffff89005653f000 R12: 0000000000000212 > > > > > > > Jun 29 18:28:42 hp-4300G kernel: R13: 0000000000001000 R14: 0000000000000002 R15: 0000000000200000 > > > > > > > Jun 29 18:28:42 hp-4300G kernel: FS: 00007f1f8898ea40(0000) GS:ffff890057280000(0000) knlGS:0000000000000000 > > > > > > > Jun 29 18:28:42 hp-4300G kernel: CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > > > > > > > Jun 29 18:28:42 hp-4300G kernel: CR2: 00000000003a8290 CR3: 00000001020d0000 CR4: 0000000000350ee0 > > > > > > > Jun 29 18:28:42 hp-4300G kernel: Call Trace: > > > > > > > Jun 29 18:28:42 hp-4300G kernel: _raw_spin_lock_irqsave+0x39/0x50 > > > > > > > Jun 29 18:28:42 hp-4300G kernel: swiotlb_tbl_map_single+0x12b/0x4c0 > > > > > > > > > > > > > > Then that correlates with R11 holding the 'dma_io_tlb_mem' pointer and > > > > > > > RDX pointing at the spinlock. Yet RAX is holding junk :/ > > > > > > > > > > > > > > I agree that enabling KASAN would be a good idea, but I also think we > > > > > > > probably need to get some more information out of swiotlb_tbl_map_single() > > > > > > > to see see what exactly is going wrong in there. > > > > > > > > > > > > I can certainly enable KASAN and if there is any debug print I can add > > > > > > or dump anything, let me know! > > > > > > > > > > I bit the bullet and took v5.13 with swiotlb/for-linus-5.14 merged in, built > > > > > x86 defconfig and ran it on my laptop. However, it seems to work fine! > > > > > > > > > > Please can you share your .config? > > > > > > > > Sure thing, it is attached. It is just Arch Linux's config run through > > > > olddefconfig. The original is below in case you need to diff it. > > > > > > > > https://raw.githubusercontent.com/archlinux/svntogit-packages/9045405dc835527164f3034b3ceb9a67c7a53cd4/trunk/config > > > > > > > > If there is anything more that I can provide, please let me know. > > > > > > I eventually got this booting (for some reason it was causing LD to SEGV > > > trying to link it for a while...) and sadly it works fine on my laptop. Hmm. > > Seems like it might be something specific to the amdgpu module? > > > > Did you manage to try again with KASAN? > > Yes, it took a few times to reproduce the issue but I did manage to get > a dmesg, please find it attached. I build from commit 7d31f1c65cc9 ("swiotlb: > fix implicit debugfs declarations") in Konrad's tree. Looking at the logs, the use-after-free bug looked somehow relevant (and it's nvme again. Qian's crash is about nvme too): [ 2.468288] BUG: KASAN: use-after-free in __iommu_dma_unmap_swiotlb+0x64/0xb0 [ 2.468288] Read of size 8 at addr ffff8881d7830000 by task swapper/0/0 [ 2.468288] CPU: 0 PID: 0 Comm: swapper/0 Not tainted 5.12.0-rc3-debug #1 [ 2.468288] Hardware name: HP HP Desktop M01-F1xxx/87D6, BIOS F.12 12/17/2020 [ 2.468288] Call Trace: [ 2.468288] [ 2.479433] dump_stack+0x9c/0xcf [ 2.479433] print_address_description.constprop.0+0x18/0x130 [ 2.479433] ? __iommu_dma_unmap_swiotlb+0x64/0xb0 [ 2.479433] kasan_report.cold+0x7f/0x111 [ 2.479433] ? __iommu_dma_unmap_swiotlb+0x64/0xb0 [ 2.479433] __iommu_dma_unmap_swiotlb+0x64/0xb0 [ 2.479433] nvme_pci_complete_rq+0x73/0x130 [ 2.479433] blk_complete_reqs+0x6f/0x80 [ 2.479433] __do_softirq+0xfc/0x3be [ 2.479433] irq_exit_rcu+0xce/0x120 [ 2.479433] common_interrupt+0x80/0xa0 [ 2.479433] [ 2.479433] asm_common_interrupt+0x1e/0x40 [ 2.479433] RIP: 0010:cpuidle_enter_state+0xf9/0x590 I wonder if this ended up unmapping something wrong and messing up the dev->dma_io_tlb_mem (i.e. io_tlb_default_mem)? Could you try this patch on top of 7d31f1c65cc9? This patch helps check if we try to unmap the wrong address. ``` diff --git a/kernel/dma/swiotlb.c b/kernel/dma/swiotlb.c index b7f76bca89bf..5ac08d50a394 100644 --- a/kernel/dma/swiotlb.c +++ b/kernel/dma/swiotlb.c @@ -613,6 +613,21 @@ void swiotlb_tbl_unmap_single(struct device *dev, phys_addr_t tlb_addr, size_t mapping_size, enum dma_data_direction dir, unsigned long attrs) { + struct io_tlb_mem *mem = dev->dma_io_tlb_mem; + unsigned int offset = swiotlb_align_offset(dev, tlb_addr); + int index; + + if (!is_swiotlb_buffer(dev, tlb_addr - offset)) { + dev_err(dev, "%s: attempt to unmap invalid address (0x%llx, offset=%u)\n", __func__, tlb_addr, offset); + return; + } + + index = (tlb_addr - offset - mem->start) >> IO_TLB_SHIFT; + if (mem->slots[index].orig_addr == INVALID_PHYS_ADDR) { + dev_err(dev, "%s: memory is not mapped before (0x%llx, offset=%u)\n", __func__, tlb_addr, offset); + return; + } + /* * First, sync the memory before unmapping the entry */ ``` It might be useful to have CONFIG_SLUB_DEBUG=y, CONFIG_SLUB_DEBUG_ON=y and line numbers (scripts/decode_stacktrace.sh) too. Thank you so much for helping! > > > > It might also be worth taking the IOMMU out of the equation, since that > > > interfaces differently with SWIOTLB and I couldn't figure out the code path > > > from the log you provided. What happens if you boot with "amd_iommu=off > > > swiotlb=force"? > > > > Oh, now there's a thing... the chat from the IOMMU API in the boot log > > implies that the IOMMU *should* be in the picture - we see that default > > domains are IOMMU_DOMAIN_DMA default and the GPU 0000:0c:00.0 was added to a > > group. That means dev->dma_ops should be set and DMA API calls should be > > going through iommu-dma, yet the callstack in the crash says we've gone > > straight from dma_map_page_attrs() to swiotlb_map(), implying the inline > > dma_direct_map_page() path. > > > > If dev->dma_ops didn't look right in the first place, it's perhaps less > > surprising that dev->dma_io_tlb_mem might be wild as well. It doesn't seem > > plausible that we should have a race between initialising the device and > > probing its driver, so maybe the whole dev pointer is getting trampled > > earlier in the callchain (or is fundamentally wrong to begin with, but from > > a quick skim of the amdgpu code it did look like adev->dev and adev->pdev > > are appropriately set early on by amdgpu_pci_probe()). > > > > > (although word of warning here: i915 dies horribly on my laptop if I pass > > > swiotlb=force, even with the distro 5.10 kernel) > > > > FWIW I'd imagine you probably need to massively increase the SWIOTLB buffer > > size to have hope of that working. > > Is it worth trying this still then? > > Cheers, > Nathan From xen-devel-bounces@lists.xenproject.org Mon Jul 05 07:35:46 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Jul 2021 07:35:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149816.277095 (Exim 4.92) (envelope-from ) id 1m0J8n-0002av-Uu; Mon, 05 Jul 2021 07:35:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149816.277095; Mon, 05 Jul 2021 07:35:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0J8n-0002ao-QF; Mon, 05 Jul 2021 07:35:41 +0000 Received: by outflank-mailman (input) for mailman id 149816; Mon, 05 Jul 2021 07:35:40 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0J8m-0002ai-AT for xen-devel@lists.xenproject.org; Mon, 05 Jul 2021 07:35:40 +0000 Received: from mo4-p00-ob.smtp.rzone.de (unknown [81.169.146.217]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 98152248-dd63-11eb-843e-12813bfff9fa; Mon, 05 Jul 2021 07:35:39 +0000 (UTC) Received: from sender by smtp.strato.de (RZmta 47.28.1 AUTH) with ESMTPSA id 30791cx657ZWKQR (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Mon, 5 Jul 2021 09:35:32 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 98152248-dd63-11eb-843e-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1625470532; s=strato-dkim-0002; d=aepfle.de; h=References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Cc:Date: From:Subject:Sender; bh=iwAZHz+bN1CxIaMVu8XWz95smJ4SdKtO2YuzCZDyDc0=; b=JRbSzXG4HwjR5Ey1z38rVJaZiZMc0Rcklf6cr/BcvNqk1Rv7v96MWvyFvJ9As6T5AT Vim1kUjv7P7DW6eUVoAhR14zCfyhLGYHVejdCvwiCflKE09RkbS6LyYspS0mrWlblZ5X QfVbV7YGprdQ4m+M8qFsAxZcfgVPhkTOmqg5uA5WeKdHH4s+QEtS1/AKtDGANzg9g4pz 6kNCR/GqlXYZIWIG2kUUtDYj0oErkeb/TMcfNRxiwltYScXnZHoj3a27OR7t6nueE6Ut Ct/PAb57hx24/s2jFKjR1nOf1raRISodq6fmueuyrETnZ+NT6TYASSrRTfCNyyutlXkN lXaQ== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QLpd5ylWvMDX3y/OuD5rXVisF+Ax6FOE3sSy9BcWAcR/hQoAs9MGk67vg1baqX" X-RZG-CLASS-ID: mo00 Date: Mon, 5 Jul 2021 09:35:14 +0200 From: Olaf Hering To: Andrew Cooper Cc: Xen-devel , Jan Beulich , Roger Pau =?UTF-8?B?TW9ubsOp?= , Wei Liu , Ian Jackson Subject: Re: [PATCH] tools/libxenguest: Fix max_extd_leaf calculation for legacy restore Message-ID: <20210705093514.45be9be8.olaf@aepfle.de> In-Reply-To: <20210702190334.31271-1-andrew.cooper3@citrix.com> References: <20210702190334.31271-1-andrew.cooper3@citrix.com> X-Mailer: Claws Mail 2021.05.27 (GTK+ 2.24.32; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/JbMqPY3W6G1h2t=4_+wlXLO"; protocol="application/pgp-signature"; micalg=pgp-sha256 --Sig_/JbMqPY3W6G1h2t=4_+wlXLO Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Am Fri, 2 Jul 2021 20:03:34 +0100 schrieb Andrew Cooper : > Fixes: 34990446ca91 ("libxl: don't ignore the return value from xc_cpuid_= apply_policy") I think it fixes 111c8c33a8a18588f3da3c5dbb7f5c63ddb98ce5 ("x86/cpuid: do n= ot expand max leaves on restore"), 34990446ca91 just revealed the bug? Either way, this new variant is what I had tested last week. But with a tra= iling "u" for the constant. This detail may not make a difference in practi= ce. Olaf --Sig_/JbMqPY3W6G1h2t=4_+wlXLO Content-Type: application/pgp-signature Content-Description: Digitale Signatur von OpenPGP -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEE97o7Um30LT3B+5b/86SN7mm1DoAFAmDitjIACgkQ86SN7mm1 DoAnjBAAiRZuQDEjjVhMLjPjG3ICG49Zl+hTzwfvwXHmJW54vN+/LQJjoIcNVrhB 0cS1ZPwZ43fbB8aR5/3m5fcNfRAnDcCGF3obEilhubYuQ7TLVGEpC0Wb/0kYkvsF uB3HrWlUYWFlq0+FUYtl99rHgahcAKx+nA9C2Ak9clm8eTwkLKRpc42KE6SqZ467 nc93wXGn+YJJfBPLM6L8jMF9jW7e8Ia8WZIgCJlQNftQ87ofDHMLRK1By/8555Ns ZI2qJ/eAd4WFnjFdLlw/LRgNZgNlYcKSPuYnyuezTYn0DzP3yLdl013GeCmry64N rMwepRTrNVPNkNTAc4Hwi63X6mwmBud+tTK+Z3uHhT5cTHDwk61Cs1rqRbaAZ2AV dJsa01rg+ptYPfp3+Xu4sQG2j3KfAhU99DzkrpNi7xP2Yrkxt3vylAbVzi0VSkEQ z3h4oXqBLgti5lz/OOZBYUeEv08VZ+klmuj7pLRUb3nuEkgasOeFYP9ozjYF+cL4 JjFshN6aYcKiaG8DaUvWtqPt5VSgrvP5+f88TzuzG0I0v+7yML6h6j9oAmdeIwf3 2H8/jieUgeRksq0oywpI1gRCl6k/eMtWGwHxPstegrWw4RrnYWTVH+LvQ3da/JGa wQhTdn2Ovnil36HgGuQ0VTpeKgVqNjTDOBg+0MSturiRty7lRVE= =qeNW -----END PGP SIGNATURE----- --Sig_/JbMqPY3W6G1h2t=4_+wlXLO-- From xen-devel-bounces@lists.xenproject.org Mon Jul 05 07:48:50 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Jul 2021 07:48:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149822.277105 (Exim 4.92) (envelope-from ) id 1m0JLH-000451-1v; Mon, 05 Jul 2021 07:48:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149822.277105; Mon, 05 Jul 2021 07:48:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0JLG-00044u-Ux; Mon, 05 Jul 2021 07:48:34 +0000 Received: by outflank-mailman (input) for mailman id 149822; Mon, 05 Jul 2021 07:48:33 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0JLF-00044o-0T for xen-devel@lists.xenproject.org; Mon, 05 Jul 2021 07:48:33 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 640a733e-dd65-11eb-843e-12813bfff9fa; Mon, 05 Jul 2021 07:48:31 +0000 (UTC) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05lp2106.outbound.protection.outlook.com [104.47.17.106]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-6-LtSUoOP_M9uh3XynrMA9MA-1; Mon, 05 Jul 2021 09:48:29 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR0402MB3936.eurprd04.prod.outlook.com (2603:10a6:803:23::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.22; Mon, 5 Jul 2021 07:48:26 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::99d3:99cd:8adf:3eea]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::99d3:99cd:8adf:3eea%5]) with mapi id 15.20.4287.033; Mon, 5 Jul 2021 07:48:26 +0000 Received: from [10.156.60.236] (37.24.206.209) by AM9P195CA0005.EURP195.PROD.OUTLOOK.COM (2603:10a6:20b:21f::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.22 via Frontend Transport; Mon, 5 Jul 2021 07:48:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 640a733e-dd65-11eb-843e-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1625471310; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=379muhCbVU28mtoZW/NN4A3h4S25XYXXLW+AQ/yDtGY=; b=YNN1mInCyQQEpiVYaTy3WS1cW2h/Ja8FCEhGv8tuveyHdDJlisVQUj3p3ISsUn5FwHEA/4 Z/ZNSHwZNI6rH8aJDfhYSIbuokv4i9LjjpO3fSKvYjSxY+de4JoMNIaRpU71vE5z2Hh52m a7gJihh4F1R++7zUN4AtxpTp0fX7nu4= X-MC-Unique: LtSUoOP_M9uh3XynrMA9MA-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=U1oW4cccrSM7ihy0ffe9bulXVCPr/QHMVtZwOpRN3XQF8SGLAIsFobSXOHmH++i7N5/t+RmR2UT/J7c/V/V5kp0Q0HwJUj1MlHImY3EIUgJimfhOw3SiyK+6M47uQPJcT2d1w6qb9DpLIqXZuRWhHt7VbUirDpvvBcLo8OPXP0TeGxrEvWnkyrkLBCA0A9KrwN8wX5o1ol/+NuwzeDidBopKfSWpTjpmoXRSc6tvZOTcL+FZIPvSFMyPbIR9uZ+8GwOzAh/5QMD0QxXbUKM4IU4tLyimeNSOHdLnjKIOXGvFP5Gfb+idfctSnI3shr6k2mzrYoxtejvcE9oNTOLbZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=379muhCbVU28mtoZW/NN4A3h4S25XYXXLW+AQ/yDtGY=; b=iOY/Lv7Oj/9fFGgY7WSJhqlpx6c9e4xgAoHzDaiiOPuOz3EHtk1kKVbBinxe3ctd/ceDsvyOCZp0mp71fZLaF5XxBieWXk38LaOpQPtNWhvc1bL51wNzQc1PLuXarnvYrdrVBEP2DyXDsDwHd8SVinKK9KpXCtRq0QS9i3Wuy6H26wO2UGJUVozu0S6MN7gWYXBQkj1AASOkkLkHSxm867C4bQzuZQA4iFEnIu558eVN9yMFxklGMr2Qmrj/kcuLJOHQC58fJeHeTcdQY+H3CsJZoKS0lGIsNrlb5LRgWI1Qwr1OFXxGatEMrtM3XqHYFPwj01lhTlSRJpEF5J4SWQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=suse.com; Subject: Re: [PATCH 4/9] xen/arm: static memory initialization To: Penny Zheng Cc: Bertrand Marquis , Wei Chen , "xen-devel@lists.xenproject.org" , "sstabellini@kernel.org" , Julien Grall References: <20210607024318.3988467-1-penny.zheng@arm.com> <20210607024318.3988467-5-penny.zheng@arm.com> <7f77349f-015e-83d3-d646-af9897e31348@xen.org> From: Jan Beulich Message-ID: <13bf976c-20af-f6d5-5532-5f11e75333b0@suse.com> Date: Mon, 5 Jul 2021 09:48:24 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [37.24.206.209] X-ClientProxiedBy: AM9P195CA0005.EURP195.PROD.OUTLOOK.COM (2603:10a6:20b:21f::10) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0e4465c7-2cbe-4c92-e275-08d93f8945ec X-MS-TrafficTypeDiagnostic: VI1PR0402MB3936: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wbJ3G3/IaSoU9MEc2A0fh0A9/89YYslc37aipzhjXx6rzJ6g+kgqkMdnYTH1hn3743XtjujHfInLw9cthrM1TKfC6m1UVFRmpoGsYYT9gM8HcM7ODl5u0JnZyPWblZBWG5b+L3PtsFgrb2nWPNiamr1lRSqRnJcXRGRYCXwxjPOxc1Pl13aSfj+Z03gZ8/ozqJs26oLPka9RSOhZx7i+uWXySmOETeLJREZRPeuN60z7u1WUGaRHUXVLhyNKGaaDjC/LQsHWuiGh0qec5Yxx24vL44IP2dlAwk8y/J0t8+fi69gP8WDCaDouNY8EVuSDL5b55WCTbcUmaq3I+uYvNURfyY13BftKqlO+5w4fzZLo+r1A2J3AkkyKaniqXaqtOKjJQeVANpT0OFQCHImUWC5niUuJd8eO5Vj2P+5qrTDSOZo7THjObdkJUSIBWXIKv5TcYS3go71HxBsGJR1sVwFFB+gb8/y+SrTHjiMx8IQzmXvHENdZ1JxHnBniip8SuVSVU0MpbxXtAX7r0jOOVCuBGJOCEquZ6n52X1p2xKUWQFUk9UlHkr8gVHNLimonpPX5nFWklYfkgw/gGHah4rK5TzXm471fV4P05SHJCisEF6h4/dxPdUqPIQsLoiAKZ0QXx+lHBqPxVTBwQG0ncAU7GmfNt8fW8QjZEwmhe4J3Rc1J6xLq5LxiDM6l0ZwBFzGJJ+l5jxH+l8J4t3Xqbd2qvRVkxM6RghhiD57JpG0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(136003)(366004)(396003)(346002)(39850400004)(376002)(16576012)(8936002)(6486002)(8676002)(66476007)(66946007)(5660300002)(66556008)(4326008)(54906003)(956004)(6916009)(186003)(2616005)(26005)(86362001)(316002)(53546011)(16526019)(36756003)(31696002)(38100700002)(2906002)(478600001)(83380400001)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZzUySGJYek5BZEIzT1ZFeHJBdElLRFVibEp5Y25BM2VpcUNLUit0RHByQ1pK?= =?utf-8?B?UDBHaEZZeEZadHBVSFh4b1RIL3JrTUxsSjQ5TEQrcExnUkN4eTQ0blJNNXor?= =?utf-8?B?QlV5TXpqK2M3YzZpM3BkWlY3Tk1jVm5XUUVWNjhOUUdFaWovUTlOeFR6ZjlK?= =?utf-8?B?cEdJTTNBNmhDTlp0TW5GNkV0aFNNOVhQQmpYL2ZBQkR3SWNuUGRIcHdVZnNB?= =?utf-8?B?ZnFNS3hmRWdzbzA2NUNEandGOEY3ZUVIcFQ5RHRMZzVudnZtTXVLdGFOQ0dh?= =?utf-8?B?RHNQeDlhMnVWcm9ydVFxOE4xSEtJWnloQlpMb2h5ZC9JM1hZWVJTYUtaSkZv?= =?utf-8?B?OEtVN2JTdFo3Wlp1Qy9DK1VNNE8yeXB6NWtZenZmRGplVzlEQlVOaTFlMGV0?= =?utf-8?B?MEdWTmd4cXlDYnVqYktlNFF3ZFJmc2gwWVJDOVpBYWs4VGE3VFhiRU9zdGxj?= =?utf-8?B?R3JVUDAvVko4amdkdDFndzVaTExHKzdtd2ZGNER3OUhjdkdhYmw2OXpxVnBC?= =?utf-8?B?OFpCNllmVUVBYllFY0Y3OVB3aDdrdVV6TUpiT0t5QVRyOUZjekk0MVlDUmhS?= =?utf-8?B?OUp3N1RyOUZLUFJXOXFIeUVWdlYwMm1MbEl3U011bUJnMTdHS3htaTVseDFl?= =?utf-8?B?YVdTajlIRFU1N3dacUduemxBZEtZVmo2REJDQ1dQRHF2c0Q1dnVCZVhkcHdm?= =?utf-8?B?RlZiL21UNXJabis5L0pZZXZDb2wvZTIvYVlhMVRmNEd4T1pWSnZGOTF1N2la?= =?utf-8?B?T1N5Szk0YUdKN2hlTE9Pb0lDT3JodjFnQ0tkdFdWWmZ2alc4bzF4eWR4WkFt?= =?utf-8?B?c0w0L2VVSFZvV3BBQ25XWUJrL001S3VGVUM5MDVSOUxhalVXcTdoeitHVUs5?= =?utf-8?B?cE1PalgwcDVHU3VkTEk1UG9WdFhpc0Y5a2dkRE9HUVlwSTNGaXFkeUE4Mnds?= =?utf-8?B?eVI3L2E0aEZ3VW9LUUJFZEN4MDl3YndoMitoNTkvT3dWMW1Ic3JOS0k4Mk95?= =?utf-8?B?L0N4Z2tZUklQUWRaMUJqV0N2TWcrdThHeS9IY0JmdFFqMWoycWpxdlEwTW9i?= =?utf-8?B?b3RKSnlTZjJVT1FPOFVZQmsraWZhM1RLK1E0d1lhdzh2d0JZU3hOTXEzbWll?= =?utf-8?B?ZEhqR1VhUVVRYmljcWNLNkdsNTVqYzZkcE5MUkcxYWtJT3FTVXZULzlORkxX?= =?utf-8?B?RGFNalpKeDh6OURDZ004TEhoWDZVdElXMGlTUFFzTFBmTnJnUUloYzV6elhY?= =?utf-8?B?TVhnS2dvWHd3Qjh3YmJITXhTbFM0Rnd6cUpaK0hCL3RWamJyZDJYWmdPK0Vr?= =?utf-8?B?ZE1qYU1LMVZDUFgydVY0aEt6S2t5QkdncWEvdTVNZk9ucVErTmsxN3FWUzFZ?= =?utf-8?B?Y3lpTHoxQXRpSDh4MGNNV3loN3J3S002TnFxSlJjUE0wNmxxcVZZZktpdzN6?= =?utf-8?B?a2ZyVm4wbFJ0cHU2ajY2MFpKallWTG1pNjNmQ1VmMHdMV2VIRVFFYUpsWHdO?= =?utf-8?B?RkVJWU9WV25POHkvQU9PSUF2WHVFQXFWTXJQZy84WFdnTlNkSDFQNlZ2LzNy?= =?utf-8?B?VnVoSXI5Ui9rd1VSdWRoYnRxTVZWamlYelUyZENwdElsOTRsZk1TdmVVQ1pi?= =?utf-8?B?ODNTL3Bva3FLT1p5akhsY0I1WFRLZXJVcUo0UXBlMTFMYnZsc0xyWFpzVnFk?= =?utf-8?B?V3ZYalUzbmNGR09PZEcxZUtPZlpIVUViemUyMmVCUkdUaDcwT2dxQjFpdWd0?= =?utf-8?Q?BtjhKyIYL2HBlpTUcrhJbjQe/noy5dkPhjj5I6h?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0e4465c7-2cbe-4c92-e275-08d93f8945ec X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2021 07:48:26.6867 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xl271Z8+VQaEF8kYlrVhrHgxDShJwX5K19dCPQxap/mlS/xamFQAF8ZnfUhRmkvbo0zSEW6SlrouCg/dyTjb9A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3936 On 05.07.2021 07:22, Penny Zheng wrote: >> From: Julien Grall >> Sent: Thursday, July 1, 2021 1:46 AM >> >> On 10/06/2021 10:35, Jan Beulich wrote: >>> On 07.06.2021 04:43, Penny Zheng wrote: >>>> @@ -1512,6 +1530,38 @@ static void free_heap_pages( >>>> spin_unlock(&heap_lock); >>>> } >>>> >>>> +#ifdef CONFIG_STATIC_ALLOCATION >>>> +/* Equivalent of free_heap_pages to free nr_mfns pages of static >>>> +memory. */ void __init free_staticmem_pages(struct page_info *pg, >> unsigned long nr_mfns, >>>> + bool need_scrub) { >>>> + mfn_t mfn = page_to_mfn(pg); >>>> + unsigned long i; >>>> + >>>> + for ( i = 0; i < nr_mfns; i++ ) >>>> + { >>>> + switch ( pg[i].count_info & PGC_state ) >>>> + { >>>> + case PGC_state_inuse: >>>> + BUG_ON(pg[i].count_info & PGC_broken); >>>> + /* Mark it free and reserved. */ >>>> + pg[i].count_info = PGC_state_free | PGC_reserved; >>>> + break; >>>> + >>>> + default: >>>> + printk(XENLOG_ERR >>>> + "Page state shall be only in PGC_state_inuse. " >>> >>> Why? A page (static or not) can become broken while in use. IOW I >>> don't think you can avoid handling PGC_state_offlining here. At which >>> point this code will match free_heap_pages()'es, and hence likely will >>> want folding as well. >>> > > Yeah, I was following the logic in free_heap_pages. > Hmmm, I could not think of any scenario that will lead to PGC_state_offlining, that's why > I was not including it at the first place. > For broken issue, tbh, I just copy the bug_on from free_heap_pages, after quite a time thinking, > I also could not find any scenario when a page(static or not) can become broken while in use. ;/ I can see that what you say may be true for Arm, but we're in generic code here with an arch-independent CONFIG_STATIC_ALLOCATION conditional around. Hence you want to avoid deliberately not handling a case that can occur on e.g. x86 (see mark_page_offline() and further related handling elsewhere). I'd perhaps view this differently if you were introducing completely new code, but you've specifically said you're cloning existing code (where the case is being handled). Plus, as said, you'll likely be able to actually share code by not excluding the case here. Jan From xen-devel-bounces@lists.xenproject.org Mon Jul 05 07:50:46 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Jul 2021 07:50:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149828.277117 (Exim 4.92) (envelope-from ) id 1m0JNN-0005SQ-Hf; Mon, 05 Jul 2021 07:50:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149828.277117; Mon, 05 Jul 2021 07:50:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0JNN-0005SJ-Ec; Mon, 05 Jul 2021 07:50:45 +0000 Received: by outflank-mailman (input) for mailman id 149828; Mon, 05 Jul 2021 07:50:44 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0JNM-0005SD-Sd for xen-devel@lists.xenproject.org; Mon, 05 Jul 2021 07:50:44 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id b33554d8-dd65-11eb-843e-12813bfff9fa; Mon, 05 Jul 2021 07:50:44 +0000 (UTC) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05lp2111.outbound.protection.outlook.com [104.47.18.111]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-21-5WlD1HSmPfGMa39KOacAsQ-1; Mon, 05 Jul 2021 09:50:42 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB4191.eurprd04.prod.outlook.com (2603:10a6:803:45::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.22; Mon, 5 Jul 2021 07:50:41 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::99d3:99cd:8adf:3eea]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::99d3:99cd:8adf:3eea%5]) with mapi id 15.20.4287.033; Mon, 5 Jul 2021 07:50:41 +0000 Received: from [10.156.60.236] (37.24.206.209) by PR0P264CA0176.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1c::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.21 via Frontend Transport; Mon, 5 Jul 2021 07:50:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b33554d8-dd65-11eb-843e-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1625471443; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=K4VFUC7j4ITjPhqjm08Uxuw/7MzYYMilatT3HOIvgcs=; b=Wger7dibg4GdO+wDwzDb9ajkZVyf2GDBfu9EW+Gm5RigyuKhKOuTokmIWE2rjGK9hn7Ir2 mvPh0mdYUSJGtqs1aAjrh61ipGhlWARFmMT5KCVkhKVPQdNIEKV1UNBSvrDsrkFVpE6qtO LA2h168OV1PdHuvvb4vGjJh3vWalZhQ= X-MC-Unique: 5WlD1HSmPfGMa39KOacAsQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Law7G9xve01VCz72no8K/eLehy7F0cF3OShdPrjv9/e5mzp2iW70+kHB+zmks0Ksd4pim5DwsCJhzjDjTbHJ6qZ8vuzJpfAevLOJ4Cr3vrVJcZU7UcaIvbhJJWI6c8psBHkVsPD0n45xoSkE4R+Ruja9g4t9F16XeS18bdFiycQzE0kBZRptPwasmnpx/3OaSEl7GbEq52wFqRd+wloEnQ40sVae3KpkumOmsF6HDaDOKd5BzGY/wRCntryVb3sf/la69y1tAFG7Lrbu9rW3uHzXZlsswiqFIcGNbpxLvSKc4GALR5Xm1uR2KDD5KTvyRKS+uJumM8HQQo0or+jNow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=K4VFUC7j4ITjPhqjm08Uxuw/7MzYYMilatT3HOIvgcs=; b=kMqcHWNO0YJ4Dv91ZvbZFhZH00dknkQrYUYkAVRFAVpRfx36LkMnIkMV3y5OrCPVsAZ+XCpm+hGbfmvCjydWvQ22GsKVW4ifD4jH422VKQprZosSsKf/tHseyN2aOFK2QBQDoaqcQ6sANQcE7CLGTxM/im9q14EoeeyH3MfBxj7uPKPFvl4oFZp73oWj/8yvnpwgP0JC6M4wE34sVLMxrt8Pb0fnBnl8T55FCoksSrAiApxjmwhZBVQOlp2I/1Sd3RxCZr3FcALirJKmpPzG52l3tk3bAwf+2dfM7U3WT9P3UBZ6HCTuxgDntsbcPsIE7er+Ks66seuVVdUIaMl3Hg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=suse.com; Subject: Re: [PATCH 4/9] xen/arm: static memory initialization To: Penny Zheng Cc: Bertrand Marquis , Wei Chen , "xen-devel@lists.xenproject.org" , "sstabellini@kernel.org" , Julien Grall References: <20210607024318.3988467-1-penny.zheng@arm.com> <20210607024318.3988467-5-penny.zheng@arm.com> <7f77349f-015e-83d3-d646-af9897e31348@xen.org> From: Jan Beulich Message-ID: <5ce26bab-9ebf-f3c5-44a3-7918227f3afd@suse.com> Date: Mon, 5 Jul 2021 09:50:39 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [37.24.206.209] X-ClientProxiedBy: PR0P264CA0176.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1c::20) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1fa5bff1-0ac9-429f-01ab-08d93f899607 X-MS-TrafficTypeDiagnostic: VI1PR04MB4191: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7rKsitMDyxekzeuZPEa2HyClNtioE+hPcT+pNfvDPYvfP7NHQPQ4taDGYJSW1QFSEer8ptPIoQ/sQnx+8Xarp1BlA8cEW7UOywJo0RpJIMNxQQudxA6qIsjC11S7rlA3t4/BG0WuoKndinVXJxgqOI+SWts75u+zlUZHsx10yi8dtZ4vQjtkvTDeZsRPbmoM4qqqXMlebmjQp5ICeHQKyktC/mVKT4GRjYGni+f8S3rumkSSmJQwxBKubicgxiFg0d869SbRCL4egoTF4i7bJvwuJIf3Az8q3NnM2PGZuNPQTZHz5ZTPKV9XRls0eCY+GhuHbMQSod4ZkZNeLCgAJUeK+hJ7UADMmqmNhDtycrkbabTx6Wfk2MeqTXBXaPW1h72XMKCs7Mgtrj4ynLdSSF31NxoVQigt0+sxqpyG1IbTSQb6SxiGPAxP3nDL1FSoejwJTg4frdxs0ZHArJ8igbRRxjHnnRoqHBpc+UtulwMZjIl89mRpAhdYhrWkG0ie9sPGQDnyCYs1rh+YtH/Uyk80w3VtViB20sJO+9vZOizKULvZD0imJpMFOmlDHxoDolCzrUmHWVFyISgF6NbitfLIIrAakg63qDMsF7w5o3ilS++DOzSOWdRmzZ0CIbUfeDoWgmAkSJchAqkYB92qdGFVD54KNQQ6daAagBpmzuF2IDwCShmRenKJSvcR0EfzxlXKJcYmo44nTQ6ZYLYQsPigXqsROFKPxRg3godsBo4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(39840400004)(366004)(136003)(346002)(396003)(376002)(16576012)(8936002)(6486002)(8676002)(66556008)(26005)(66476007)(5660300002)(66946007)(4326008)(54906003)(186003)(956004)(6916009)(2616005)(316002)(86362001)(83380400001)(53546011)(36756003)(31696002)(38100700002)(2906002)(478600001)(16526019)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?My9tMldheXZVdVYycnA4T2RoMjhheFVydDVhZHJsaXRZTVdQc1RMN2JlU2gy?= =?utf-8?B?MkcxbFluTW0wazhOQkpVc2JBYUlGKzluMXQ1NHlzcnFkL3lzTVJXTHZrd0ZU?= =?utf-8?B?TkZLTkpQZ280T0JvWVJyVTFXUHN5YlEvSTZsTURpK3lFc3ZrY3EzUFU1dVUr?= =?utf-8?B?a255VGNjc2N5RUkrTm9VTHhHUFRyQ2l4K3N4WTlQSU9lbitJWis0WVBPbGtG?= =?utf-8?B?dlNGL0VPNXg3UHlOUnlWdHlCZlczUHFweksxR2RMTjc0Qzc4UUdYU1R5bmVt?= =?utf-8?B?RTByc1NLUXh1Z240ZzZNZ1A2cFRwbnpCTTZsRXVMcnlDMzVsUDJwaVRCS0Fa?= =?utf-8?B?dGxIMEFRdWtkNzBQTkJic0VaZSs5YUNSRjNtQW5lNFhMMVg1SEVXYmZwakI0?= =?utf-8?B?TzNMUWpXMmpXTEY5RXdMdnNXZVU3Yyt4MDFZVE1JYlg5c3UrTGVzUVgwUXk1?= =?utf-8?B?RGVSSVJnVW90VDY1Q1ZrUTI5WXd6ZmNIdDJXVG5TQW1yQlMzUmhWQkIzQXB3?= =?utf-8?B?bTNsSytkOG02bE4xSVJ0ZjFacWJvN0Q3cC94czJNUHJFNlZ1KzM0TEttQ3Qy?= =?utf-8?B?YlVtWlhIY1dUOVN2RkZHWmQ1TU9EMXppcWo1UVUrQWQzK2hpZ1d5THVEMmxF?= =?utf-8?B?SVZZYWdMaG5WRk16NDV5RlpvNkwrNklqa25YeENuTitYZ2NqWVorb3J0V2Fh?= =?utf-8?B?N0cxNGZCNVRzUlBmTUFpUjBjVFFpWTBIUFFWOHdjR0VtVzRES0Y0SDZSeGlM?= =?utf-8?B?UkNJb2JPcFJLS0N4YnlRbi9meUxuYmFsYVNpM0M3R0pDQk5CR2tYbE1iMjM2?= =?utf-8?B?MG82RHVxNVI1aUoyTGo0VDYxNFlmYUhyYUt5Tm04MGk3ZG01S201eE9sOWJo?= =?utf-8?B?dEhaOUh6ektQZHRYVkJCMkJjNmNobWZKbE9ySFhJajZTdXVHQ2I4cXpkd2l0?= =?utf-8?B?dy9qeU4xV0l5VFY1dGdoKzRJWXFkZ3VMemtwRit2cEdhTjNFOWFCS3R3V1RN?= =?utf-8?B?TU1Welpucnlrc0YvazN4UGVodENLbUgzSCtjRys3OGNnd2FlR014eHJPdC9t?= =?utf-8?B?WVFDQzlvTEZnNFVzRUw5S081bFA2VS8vQzdUZnk0dHl3TzVkK0d0OS9GemJQ?= =?utf-8?B?OVVKZ0FsMEVsL3ZNSHhodjZoV1E0YWVwRndhU3VrOC9PWmZvZEtuL1BXblAw?= =?utf-8?B?U01sT0RLeSthNm9iQ3RxQ0JVMXVVTXdOczBwUDl3RWpRZTQvdFlzRVJsNUZR?= =?utf-8?B?eEkxK1M3R0hZZ2h5OHZmdWNaa0srZHAydEVMQ3N2TERUM1Jpa2JaVlNrbFpG?= =?utf-8?B?TVNYNkJ4NVlzRE9TZDVrOW1tekl5Wm9jRjcvMWNLZHRKV2UvbmhNVUVWNTFh?= =?utf-8?B?azZKcGQ4K1VCRXR1NENRZjcySWhQL1psUjFyakRkSlpQN2VQNW5CUjg5N2w3?= =?utf-8?B?Zk9DbmdJbENzUWNlaXdRdmhaUFVCNXVlUVN3bTg0UElQQm5rQ1BTMnl2cUJJ?= =?utf-8?B?V3FhaW1JZTFNV1dLNUdJUzhQc1c4M0pycnEvR0hqcjhIbk1vZWM3NmQ2ZE9J?= =?utf-8?B?N25ZSU16b0lHNUhRd3laalMrMWRtbHM4bTNZbk5KUFErcHdURVk4RmRqQjRs?= =?utf-8?B?MGxPVyt4dXhLY1M3eDNSZzM3R0FBOVErOUFlRU90WmNXZENoSENMc1dTSEN1?= =?utf-8?B?ZzhaS00rYWVxUkhxUkVTNk1ZY1hxRC8vSEFiUEx1RzVycXdYOVEzdkpJVzIy?= =?utf-8?Q?MAkHDH3nTaKuegxroGlB/8hYhhsJApmIxI9QKqY?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1fa5bff1-0ac9-429f-01ab-08d93f899607 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2021 07:50:41.0776 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FcDxyYrXE592S1cuXQSL59mA/AnfhPUs/ywrQU5MFSJxQOYZ+iNKsLZtF6fz+15y91z4a+OTiVeVJiDH31vZLw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4191 On 05.07.2021 09:14, Penny Zheng wrote: >> From: Penny Zheng >> Sent: Monday, July 5, 2021 1:22 PM >> >>> From: Julien Grall >>> Sent: Thursday, July 1, 2021 1:46 AM >>> >>> On 10/06/2021 10:35, Jan Beulich wrote: >>>> On 07.06.2021 04:43, Penny Zheng wrote: >>>>> @@ -1512,6 +1530,38 @@ static void free_heap_pages( >>>>> spin_unlock(&heap_lock); >>>>> } >>>>> >>>>> +#ifdef CONFIG_STATIC_ALLOCATION >>>>> +/* Equivalent of free_heap_pages to free nr_mfns pages of static >>>>> +memory. */ void __init free_staticmem_pages(struct page_info *pg, >>> unsigned long nr_mfns, >>>>> + bool need_scrub) { >>>>> + mfn_t mfn = page_to_mfn(pg); >>>>> + unsigned long i; >>>>> + >>>>> + for ( i = 0; i < nr_mfns; i++ ) >>>>> + { >>>>> + switch ( pg[i].count_info & PGC_state ) >>>>> + { >>>>> + case PGC_state_inuse: >>>>> + BUG_ON(pg[i].count_info & PGC_broken); >>>>> + /* Mark it free and reserved. */ >>>>> + pg[i].count_info = PGC_state_free | PGC_reserved; >>>>> + break; >>>>> + >>>>> + default: >>>>> + printk(XENLOG_ERR >>>>> + "Page state shall be only in PGC_state_inuse. " >>>> >>>> Why? A page (static or not) can become broken while in use. IOW I >>>> don't think you can avoid handling PGC_state_offlining here. At >>>> which point this code will match free_heap_pages()'es, and hence >>>> likely will want folding as well. >>>> >> >> Yeah, I was following the logic in free_heap_pages. >> Hmmm, I could not think of any scenario that will lead to PGC_state_offlining, >> that's why I was not including it at the first place. >> For broken issue, tbh, I just copy the bug_on from free_heap_pages, after >> quite a time thinking, I also could not find any scenario when a page(static or >> not) can become broken while in use. ;/ I'm, afraid I don't understand. Using page_to_mfn(), expensive or not, in ASSERT() is quite fine. The (expensive) expression won't be evaluated in release builds. This is specifically different from BUG_ON(). Jan From xen-devel-bounces@lists.xenproject.org Mon Jul 05 07:53:55 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Jul 2021 07:53:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149835.277128 (Exim 4.92) (envelope-from ) id 1m0JQM-00068F-US; Mon, 05 Jul 2021 07:53:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149835.277128; Mon, 05 Jul 2021 07:53:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0JQM-000688-Qr; Mon, 05 Jul 2021 07:53:50 +0000 Received: by outflank-mailman (input) for mailman id 149835; Mon, 05 Jul 2021 07:53:50 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0JQM-00067y-6M; Mon, 05 Jul 2021 07:53:50 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0JQM-0000sP-16; Mon, 05 Jul 2021 07:53:50 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0JQL-0000q1-JW; Mon, 05 Jul 2021 07:53:49 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1m0JQL-0002ah-J0; Mon, 05 Jul 2021 07:53:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=mJ0dQEI43kT8l3SkzHd+o7tDZjp0Jawk5HyYEZyYf2M=; b=qj8+cR4+D5bJ0KQHlUTv3woE/8 Tuan3srZsdtrcGsHqLu++1glvkypW0j7EHLbtIUKDPucwBn1Ev5UlnR1nZfDC/iM7wSYYlQ99ZOCN KxKYVMg0FOZx1oyPYOqdgm/73vc9SJBTcFQSAXOgrrP9dFOhCTi7UfhxThMc8JAQILTc=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 163308: regressions - FAIL X-Osstest-Failures: libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=45f94690d2a89fc03c1a4eaea5c1ee398447a4b8 X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Mon, 05 Jul 2021 07:53:49 +0000 flight 163308 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/163308/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a version targeted for testing: libvirt 45f94690d2a89fc03c1a4eaea5c1ee398447a4b8 baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 360 days Failing since 151818 2020-07-11 04:18:52 Z 359 days 351 attempts Testing same since 163236 2021-07-03 04:20:01 Z 2 days 3 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Andika Triwidada Andrea Bolognani Balázs Meskó Barrett Schonefeld Bastian Germann Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Bjoern Walk Boris Fiuczynski Brian Turek Bruno Haible Chris Mayo Christian Ehrhardt Christian Schoenebeck Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Dmytro Linkin Eiichi Tsukata Eric Farman Erik Skultety Fabian Affolter Fabian Freyer Fabiano Fidêncio Fangge Jin Farhan Ali Fedora Weblate Translation gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Hela Basa Helmut Grohne Ian Wienand Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen Jean-Baptiste Holcroft Jianan Gao Jim Fehlig Jin Yan Jiri Denemark John Ferlan Jonathan Watt Jonathon Jongsma Julio Faracco Ján Tomko Kashyap Chamarthy Kevin Locke Kristina Hanicova Laine Stump Laszlo Ersek Lee Yarwood Liao Pingfang Lin Ma Lin Ma Lin Ma Liu Yiding Luke Yue Luyao Zhong Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Markus Schade Martin Kletzander Masayoshi Mizuma Matt Coleman Matt Coleman Mauro Matteo Cascella Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Muha Aliss Nathan Neal Gompa Nick Shyrokovskiy Nickys Music Group Nico Pache Nikolay Shirokovskiy Olaf Hering Olesya Gerasimenko Orion Poplawski Pany Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Ricky Tigg Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Shambarger Sebastian Mitterle SeongHyun Jo Shalini Chellathurai Saroja Shaojun Yang Shi Lei simmon Simon Chopin Simon Gaiser Stefan Bader Stefan Berger Stefan Berger Stefan Hajnoczi Szymon Scholz Thomas Huth Tim Wiederhake Tomáš Golembiovský Tomáš Janoušek Tuguoyi Ville Skyttä Wang Xin WangJian Weblate Wei Liu Wei Liu William Douglas Yalei Li <274268859@qq.com> Yalei Li Yang Hang Yanqiu Zhang Yaroslav Kargin Yi Li Yi Wang Yuri Chornoivan Zbigniew Jędrzejewski-Szmek Zheng Chuan zhenwei pi Zhenyu Zheng jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 63952 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Jul 05 07:54:09 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Jul 2021 07:54:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149838.277142 (Exim 4.92) (envelope-from ) id 1m0JQf-0006Ya-7J; Mon, 05 Jul 2021 07:54:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149838.277142; Mon, 05 Jul 2021 07:54:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0JQf-0006YT-4A; Mon, 05 Jul 2021 07:54:09 +0000 Received: by outflank-mailman (input) for mailman id 149838; Mon, 05 Jul 2021 07:54:08 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0JQe-0006Wy-Ck for xen-devel@lists.xenproject.org; Mon, 05 Jul 2021 07:54:08 +0000 Received: from mo4-p01-ob.smtp.rzone.de (unknown [85.215.255.51]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 927b3d5d-f83d-4132-a77f-c0d8e077d985; Mon, 05 Jul 2021 07:54:07 +0000 (UTC) Received: from sender by smtp.strato.de (RZmta 47.28.1 AUTH) with ESMTPSA id 30791cx657s1KWz (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Mon, 5 Jul 2021 09:54:01 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 927b3d5d-f83d-4132-a77f-c0d8e077d985 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1625471642; s=strato-dkim-0002; d=aepfle.de; h=References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Cc:Date: From:Subject:Sender; bh=JV+LJl7nJl9afvBx8gXKE9+tqVLRE/Strneb576nBkM=; b=Vq3CZncIhD2KBHvbI/569Mdl7TdD/J58OoZX72jJu3rYVpnEsxB3YTLyyMnhegDuHB HPshcmKTNZOc0KpKh4Fi8afXFnIZHUJseK+oHNfL/JGeN9sRuqqMySESCeHV7jPcPFjX IU3hpPepe4c6ARsPPotSDJ2HczGnZKHvTkQtiQ52hiMfZDwnXLHjaLxbIbv9+YNV1qBc jdXbUn9nc9inyMTfuMO3Mlj1lgZ+14r1YCKc5OY4KJFfQUgS/M+jnVK8T7qhW1+TWUiT 3pW9vcGXbBvt6XvzqmNfKI3g7zxky9nN6bXYCx1zbrb9jbdJJ/M84ylW92gQJ8eG5u2A r6ww== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QLpd5ylWvMDX3y/OuD5rXVisF+Ax6FOE3sSy9BcWAcR/hQoAs9MGk67vg1baqX" X-RZG-CLASS-ID: mo00 Date: Mon, 5 Jul 2021 09:53:53 +0200 From: Olaf Hering To: Andrew Cooper Cc: Xen-devel , Ian Jackson , Wei Liu Subject: Re: [PATCH] tools/libxenguest: Fix migration's debug option Message-ID: <20210705095353.6ff58d0f.olaf@aepfle.de> In-Reply-To: <20210702190342.31319-1-andrew.cooper3@citrix.com> References: <20210702190342.31319-1-andrew.cooper3@citrix.com> X-Mailer: Claws Mail 2021.05.27 (GTK+ 2.24.32; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/vTUTvSUi3yzBKNd.k+04xVq"; protocol="application/pgp-signature"; micalg=pgp-sha256 --Sig_/vTUTvSUi3yzBKNd.k+04xVq Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Am Fri, 2 Jul 2021 20:03:42 +0100 schrieb Andrew Cooper : > The code has gone through many refactors, but the first refactor was the = one > which broke it by inverting the check with respect to checkpointed stream= s. >=20 > Fixes: 7449fb36c6c8 ("migration/save: pass checkpointed_stream from libxl= to libxc") > Reported-by: Olaf Hering > Signed-off-by: Andrew Cooper Acked-by: Olaf Hering Olaf --Sig_/vTUTvSUi3yzBKNd.k+04xVq Content-Type: application/pgp-signature Content-Description: Digitale Signatur von OpenPGP -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEE97o7Um30LT3B+5b/86SN7mm1DoAFAmDiupEACgkQ86SN7mm1 DoDIXRAAglTWm3uEwsF1P8g2OClf5p+bXwBXOHbMeCLJSFj9FZDEoapFvZO2/uGB Txey2rEWf6njre5/AGGHLCJ0czPAbpGxFSf1H4/XeRrhdn/bWmNPvrW38pmCvKjH vbseyCp4IaF0s2Ub/lBImE45Bxn23LzaVCrIqy+lP/fGlTW1sjfBs+c2pczdnxwX P+/t5hfuYVhB+oU1b14u9Pg9VMDgzeaVPLPOwfGjrO4X5rJmPHLaE2CKzeL8TfVh w/9F/zI1VzrlYCQ23exrdK4rU+7odnltxNer5LsURDj+1Qompt1NvGJ69pEcc950 LLX8goyPjhEl4Y0J+dhJaqFcAe254f4Yi/XKiaJdLYQXb8ve5P8QyQGjjyPe5rtS x/KQNDQkw7IarQ+QZJvsnTkJI933bycHTBCpN7W7xujVPyMvE/z0HzdU0UWn7PAj M0hVrQ5jXKym4z6NTX3X/Xy5t+4K0RVgAAKdx1PTwGECqPOnw2wpdO8sMZbQvuGr /Uvl6zazYtjeAXXrjdd1c7ugDRbmUoyeVtrXZaS0hlUhtceok+ijtIm1tNfcmjwa uGzQDpZ6ozCEdvLE6eg8qMlHpCWq3PpwuZbNbZa/X8icOt3mZ8F3MK7RqwbyYzGl EZyUxgiVLSR5OJ0VAjtjDcTqpP08xHiqDX3R8p1fwQFe2DED5lw= =krAC -----END PGP SIGNATURE----- --Sig_/vTUTvSUi3yzBKNd.k+04xVq-- From xen-devel-bounces@lists.xenproject.org Mon Jul 05 07:57:31 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Jul 2021 07:57:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149849.277153 (Exim 4.92) (envelope-from ) id 1m0JTt-0007Sj-TL; Mon, 05 Jul 2021 07:57:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149849.277153; Mon, 05 Jul 2021 07:57:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0JTt-0007Sc-Q6; Mon, 05 Jul 2021 07:57:29 +0000 Received: by outflank-mailman (input) for mailman id 149849; Mon, 05 Jul 2021 07:57:28 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0JTs-0007SW-Ld for xen-devel@lists.xenproject.org; Mon, 05 Jul 2021 07:57:28 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 4f6fd98c-e388-48de-bcd3-23975511afbe; Mon, 05 Jul 2021 07:57:27 +0000 (UTC) Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-am5eur02lp2050.outbound.protection.outlook.com [104.47.4.50]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-32-WhUkcdjWPrCmmsqHuORxBw-1; Mon, 05 Jul 2021 09:57:25 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR0401MB2445.eurprd04.prod.outlook.com (2603:10a6:800:55::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.22; Mon, 5 Jul 2021 07:57:23 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::99d3:99cd:8adf:3eea]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::99d3:99cd:8adf:3eea%5]) with mapi id 15.20.4287.033; Mon, 5 Jul 2021 07:57:23 +0000 Received: from [10.156.60.236] (37.24.206.209) by FR3P281CA0047.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4308.8 via Frontend Transport; Mon, 5 Jul 2021 07:57:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4f6fd98c-e388-48de-bcd3-23975511afbe DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1625471846; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kDakExeGU87B0Ei+ei/sjyL0MKjhCwbbAD1XFe3zn7o=; b=Oh/9cwlA60s5WIzqO0HjuspXGpV2gXDOMCf36Rj5krzvyyv17czxKufG/9/XfvI6ZPK4zi LJyEpFRyUpq9OsKxEcSYkNOJy2yT//glT6E7E5lki+79p29tD/unnqtrKM5si1cTEKDpiZ mNFldAzfxKrNRpPZgWCeQJXMeicjRjY= X-MC-Unique: WhUkcdjWPrCmmsqHuORxBw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C2mfF9NRTqm8qMt/aDU8xdS0rYprOLo+idq0pjAZUTvKlkP2ONNranpuEcrObJdco1yFdE/K9xcwE1Z6GclHytF8ttendTQ8+Y7HHaj7oVs6cqtobGKoHCbws2n9yyYXl2akEJtIdy2FmTow2IfWSlMCdkovgdhvRq7RyAzzfYQO199wjOWUEoQC1f9pZOy5uCuydH1//s9FW4XTtPJOnT3RRzkylX41YU+kSxmX4iwiNsQICfU5VkEiXUAzj8j4tf6PuyntojCU0pTppW6GM9u8Zw30svjPNN7z242imgP89LaPfIFK7+Fpdvu92s4ZRuXnWh5t+8gjYH3oP6d49A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kDakExeGU87B0Ei+ei/sjyL0MKjhCwbbAD1XFe3zn7o=; b=W0hkntrt2Czsj8Z/hodmvxJK3ZeOLw5Ay57lcqmykKOrZZgoZxpZmlRCzLfr0O8RwStKVDfK8IG5uxHzHB9or65zIlZtjX4214iqrlh09IVfO4T250gOW46ZL7YumyeRCHgzlPhV0TSuE/pI1z4UgAmxwxKikayGRqB2nGMRpLWwPYt2VcLIDWZlcP6wgMi6VpqvZ7ff6LNe9hT/JTu+1BnBB01/aWiWbC/WgnaRuj5R4YSY1YW+X0RKPtNTw/Jl+bfWDNXYLfiFtu3zjuKMGzIzua3f3hN9DQWFBT35JmrUuSDQRRYLosdWspseTS/cLMQGFHsvCE4qiJjPmkRvkA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com; Subject: Re: [PATCH] tools/libxenguest: Fix migration's debug option To: Andrew Cooper Cc: Ian Jackson , Wei Liu , Olaf Hering , Xen-devel References: <20210702190342.31319-1-andrew.cooper3@citrix.com> From: Jan Beulich Message-ID: <06968742-355f-ad37-0681-e51eea256414@suse.com> Date: Mon, 5 Jul 2021 09:57:21 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 In-Reply-To: <20210702190342.31319-1-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [37.24.206.209] X-ClientProxiedBy: FR3P281CA0047.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::10) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d8cc0c70-e2a0-4607-1fbe-08d93f8a85e5 X-MS-TrafficTypeDiagnostic: VI1PR0401MB2445: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4303; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: m67B1s4LOZ18c52XINyM5OqW/NrQ9UNSFA6cNXoAPWuC1bYfOpAdU6GEXqNzZP3FlIzKPlEaERSlo3m1rD6rcaCAPgydXvTNW39SBbjcKtgktdMgzRujGvotujhCVSER92rGKCevaTaOXbcUr/P8aekAgeedJBNSng+QiUNhDUOiPx25ltnCC5N6lcMM5boYPtwhJKwJn5qSG/+ysZT367oCM1eO4gGOc39WoQ7d6mnexQbIA6+ov2dfTitrvyvXxH43IsJSpP/xxPgaarrq9UIKY3WH7f+Ta+LZay+giudmmOnnE1xCC2PTwghY1f3La5hVab9INoGQzxzi6xcpgEm/bAdo344A6hVgMkxPLZvuPP/dRzY5AZxxhq0JlCTblE/IBSrAP8r3H5vRdeX3OeX7peAIIUypiocHWRV7sXrZccH3bJ75IdsYYuvTF4InChhYy/rg6T6PQeaGLtYz8YkR4H9kZC7D/bodODpX/rzY/xWxEd4PGrW9kMm2TL3hE15xl+T8vHp8gxDbZgyM71cz2Oe4KxJi6urzDUvAOickZ5kXHHBON/LjSw7PW9MlOl1cI4heR8MHKw+KqZ7jbm5+JI1QpvHiYxAPNbTGbKvX+hujpjOvNIkDskn/VTi2w+SpvJDxMFxujxoViCOgfrauFtbWy3GI1+//tFrKOR+dx8JJ3fpgrF6lnI5hU8sE1urkZRNOQpK1bpIhCI7Mu2EuYxg8i1XqGNQY/wejKeGgCl6dMy+ZphLoWOf2mq6q X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(136003)(346002)(376002)(396003)(366004)(39850400004)(38100700002)(956004)(31696002)(2616005)(16576012)(2906002)(16526019)(54906003)(4326008)(186003)(316002)(6916009)(478600001)(36756003)(66946007)(66476007)(66556008)(8936002)(31686004)(26005)(8676002)(6486002)(86362001)(53546011)(5660300002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?REZ4NUt4SERDSDY0c0hjOFg1bUxQT1htSEtEUGF3MFlYOHc1enhWTXRyaHNs?= =?utf-8?B?aDI2c1E5ZENINEIzZUE0VmptamVIdlVIdkFZWExwbXIwMTJsTFV6RlBrc0dD?= =?utf-8?B?QVdYdndLb0ZodlFKaFhzYmZuTW03MHUrTHJnWDVieWVLT2pKN3JKZlExMExa?= =?utf-8?B?N2tMZ01GME5kbjNZS0tmcVFSVjBHWmR2VUVSZ3h1aEhndzYvMkZza3NxQXdw?= =?utf-8?B?UTY1TGlXWWRaUWFaNC9CQ2NrbW53VWt3cFFrZHU5YXE0VEhQVGJXV3ZzdFZl?= =?utf-8?B?THhwZlVUQ2xQS1ljakhUejJvTnpid1RMYW50QVlIbzJrNmt6Z3VockZBN2hv?= =?utf-8?B?dDN5NWk0VVAxU2NrbFBtTzhxY0hTd090V3JEL3pSOXBlYk1EWCtUWlRGOWRT?= =?utf-8?B?RmtFMU94VXpqeWc5ZzZSUnNSWFNqekZYVGJmQ29DeWt5Z1RzdUFFalhvOXNw?= =?utf-8?B?Q21wc2hPRUdyTm9GcXlxelR0OWYwamU3ZWR0MmNWVUZBMzVQM2FtUllsc3Zl?= =?utf-8?B?NHNzdndyQk1WT1FCY0hvVmJYd3RTMnpYRVo4eWVvdm80K29TaGhoSDU5cTNw?= =?utf-8?B?NXZmdml2ZzNVMjVFRWR3eExPSGM3WXNiK2VIUExlMjhyL3lMNXVXWmpJOWF4?= =?utf-8?B?U2FxaFFGL2RhemFvdllzc3puQ2dkRnZUL0RCd2JENlJMNS8rbE9iZ21oenhU?= =?utf-8?B?VVE1NmdvektzREh1R0h0ZWR5cUxLdVFTR1J5R0dhemY5azR5bDkvMXVJZy8w?= =?utf-8?B?Wit5S2pER004aXNhbkRJNHJJVXg5LzBNMzkyY3VoWlFWRWV0S3NSWC9DQ2s1?= =?utf-8?B?cFBRV0VVSnF1ZjlraE9rQ3o5M0xpcktObXcrbWtYZExFOTlVYzFQUVMwUTBS?= =?utf-8?B?WXVtNVFBaHZBRllxOXRlRHJDMG5ubUF5OEhFa1dzQkxqVmwzRzJ6VzRGTkJU?= =?utf-8?B?MGFuM0QwRkN2bUd1Y3cvbHhMY2dqQUdrRFgyL1lPN1VyVGZrT2FGZXZESC9C?= =?utf-8?B?WkxtMGlSOWtXM0RCVU5pNHlJWmh4N0ZaL0VUMWFJWUYyZExjbkxCMVJ1S2dE?= =?utf-8?B?K3RZREpVeSs1ZTBZUzZvNkswQW5GV3dHQldENnRDa0MvbjNzckd0bUt2bU5G?= =?utf-8?B?SGhPT2daZUNISnBWRkRKNTF5eDJkU1lpbWlKZ0NpMmQvaWRnVGlYWm1hWlhp?= =?utf-8?B?VHRFeFN5VG1uVVBuOXZOUVU5b3pCZ2dIUHM3N2VYTldiaGxGRnB6VEd2MmZi?= =?utf-8?B?MDlEcEpmbUU4c1BITlZCUlFQNVdXeUtpUzl0YURLWnJ2MENDWUxOUVBKZ2lU?= =?utf-8?B?TlpzTVBIcXZXYVlmTFRKdGFQTGsvbzhhS2JKOUxiS3BnVDE3ci9UWmlZbWdx?= =?utf-8?B?ZVhKeHpWR1UxeFdja0tST1JxR1hSbkpVNnAwMTBSVHBXYW05enBCZ3JVRm5J?= =?utf-8?B?TThRelVIWnZWdmxmT1VWRW9oVVpDUlJnT3R2aGdXZEl5elZIOXVQM0JET3cx?= =?utf-8?B?dXJBNVJBNXB2Snd4TytnalhzTHl3UGI4Z2xmZjY1eldldG8xQ2lqR0pPZlgy?= =?utf-8?B?MW9MQmJkZmQ0RlMreHAxSHhpNTZLSHJYdURNYlFXMENTOVVxRlNXRzhMQ0dT?= =?utf-8?B?N0ZvN2JMNFdCMGJROVg2SmZ5WlpudEQwcWQyVWl3dVd4WmpiMzBtRURMUnR3?= =?utf-8?B?WFJIVWIxTHR4ZktkcHE3WVNjSTRBS2dIUGtSazh4Ri95NVorcUF3UGpKcG9B?= =?utf-8?Q?X4gBvIjWbqFuqgCVk/XMCmJ54U0E0JNl6bL46zf?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d8cc0c70-e2a0-4607-1fbe-08d93f8a85e5 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2021 07:57:23.4997 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: zcVVI/OFWkVs4NqRQ3GvZPp8LCxKbfwAK3gHL4Gayzr8C8I80uMHRQwLDd/k0BZdISkXSS7ynHI6sTNzfsYlcg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2445 On 02.07.2021 21:03, Andrew Cooper wrote: > The code has gone through many refactors, but the first refactor was the one > which broke it by inverting the check with respect to checkpointed streams. > > Fixes: 7449fb36c6c8 ("migration/save: pass checkpointed_stream from libxl to libxc") > Reported-by: Olaf Hering > Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich > --- > CC: Ian Jackson > CC: Wei Liu > CC: Olaf Hering > > `xl migrate --debug` might not be perfect, but this at least brings it back to > mostly working. > > I don't think dropping it is a sensible move. In particular, it is invaluable > for testing the logdirty infrastructure when migrating a memtest VM. > > If anyone has a clever idea to fix the grant problem, then we can. It is > after all a debug option, without any specific prescribed behaviour. What is "the grant problem" referring to here? Neither anything above nor the offending original commit has any reference to grants, or a problem with them. Jan From xen-devel-bounces@lists.xenproject.org Mon Jul 05 08:01:10 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Jul 2021 08:01:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149857.277164 (Exim 4.92) (envelope-from ) id 1m0JXO-0000wu-JT; Mon, 05 Jul 2021 08:01:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149857.277164; Mon, 05 Jul 2021 08:01:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0JXO-0000wn-G3; Mon, 05 Jul 2021 08:01:06 +0000 Received: by outflank-mailman (input) for mailman id 149857; Mon, 05 Jul 2021 08:01:05 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0JXN-0000wf-IB for xen-devel@lists.xenproject.org; Mon, 05 Jul 2021 08:01:05 +0000 Received: from smtp-out2.suse.de (unknown [195.135.220.29]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 10557889-e206-4b85-b62c-dc3152fd6907; Mon, 05 Jul 2021 08:01:04 +0000 (UTC) Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 75D791FE10; Mon, 5 Jul 2021 08:01:03 +0000 (UTC) Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap1.suse-dmz.suse.de (Postfix) with ESMTPS id 4C9DA139A1; Mon, 5 Jul 2021 08:01:03 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap1.suse-dmz.suse.de with ESMTPSA id QSxPET+84mD5LgAAGKfGzw (envelope-from ); Mon, 05 Jul 2021 08:01:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 10557889-e206-4b85-b62c-dc3152fd6907 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1625472063; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zCG1o1PoHWgd44Q4byX5kHQ41zaAVuorzbR1iXUBkd0=; b=DGk4atwdt7kKtr+EZhtgn9O/plJKHRKbq9nkZzEDN2FiCDVnEcYK91OwaOwflqi39Stm2n FN2xI2Y7jC9I6Pn+OKTF76RtNS/Vr7WLT6/qKOAsG7LaQt3so6xJ/jfsAVz03yRlimuKXb dotKik+Qz9CW19vNYpZfBQckDTAiONs= Subject: Re: [PATCH -next] xen: Use DEVICE_ATTR_*() macro To: YueHaibing , boris.ostrovsky@oracle.com, sstabellini@kernel.org Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org References: <20210526141019.13752-1-yuehaibing@huawei.com> From: Juergen Gross Message-ID: Date: Mon, 5 Jul 2021 10:01:02 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <20210526141019.13752-1-yuehaibing@huawei.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="EtmeGcJPJZcXsKIlHqF5OFNd2RoHRw5R9" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --EtmeGcJPJZcXsKIlHqF5OFNd2RoHRw5R9 Content-Type: multipart/mixed; boundary="tBOwrfiwH6vWztjNsO7LDxZno6xcwWQ2E"; protected-headers="v1" From: Juergen Gross To: YueHaibing , boris.ostrovsky@oracle.com, sstabellini@kernel.org Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Message-ID: Subject: Re: [PATCH -next] xen: Use DEVICE_ATTR_*() macro References: <20210526141019.13752-1-yuehaibing@huawei.com> In-Reply-To: <20210526141019.13752-1-yuehaibing@huawei.com> --tBOwrfiwH6vWztjNsO7LDxZno6xcwWQ2E Content-Type: multipart/mixed; boundary="------------38A98B3C80FA94D29300F6F4" Content-Language: en-US This is a multi-part message in MIME format. --------------38A98B3C80FA94D29300F6F4 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 26.05.21 16:10, YueHaibing wrote: > Use DEVICE_ATTR_*() helper instead of plain DEVICE_ATTR(), > which makes the code a bit shorter and easier to read. >=20 > Signed-off-by: YueHaibing Pushed to xen/tip.git for-linus-5.14 Juergen --------------38A98B3C80FA94D29300F6F4 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Description: OpenPGP public key Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------38A98B3C80FA94D29300F6F4-- --tBOwrfiwH6vWztjNsO7LDxZno6xcwWQ2E-- --EtmeGcJPJZcXsKIlHqF5OFNd2RoHRw5R9 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmDivD4FAwAAAAAACgkQsN6d1ii/Ey8q Mwf+NF8idU9BsY+BSFf/2P5xnabC58++xUwUpeVX9mIqb79Jy94887c5EDT6EkMBDAZKUy3W/TCf OKsNRuQg6qKA6Am7IN2WJgRmRz28ZVIXawmDnO3XZq++Idr9pVROG6xLxmw34vs0PnL6QTQ+4e5D SsmlmmMLLIF7A7/GkZ45dd/QzEIMyTeFNc6NAnhmccMQaVyVavCLSKSZNrTky+y9+xOGmP1S+ZDK kwje71XNi77tMb9tZAELo6XBGsZsCoTweXWejh+uyYDDMktUAqFfyr6IVZqZmab9pP5LSi+c2kph mI379lzsFgfJ6XsjfmQRch4bsEMDP1rC2QwKzO+IGw== =r57y -----END PGP SIGNATURE----- --EtmeGcJPJZcXsKIlHqF5OFNd2RoHRw5R9-- From xen-devel-bounces@lists.xenproject.org Mon Jul 05 08:01:59 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Jul 2021 08:01:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149863.277175 (Exim 4.92) (envelope-from ) id 1m0JYE-0001X5-Tw; Mon, 05 Jul 2021 08:01:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149863.277175; Mon, 05 Jul 2021 08:01:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0JYE-0001Wy-Q2; Mon, 05 Jul 2021 08:01:58 +0000 Received: by outflank-mailman (input) for mailman id 149863; Mon, 05 Jul 2021 08:01:57 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0JYD-0001Wo-62 for xen-devel@lists.xenproject.org; Mon, 05 Jul 2021 08:01:57 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 80c7ca93-bd35-409a-a1e5-06daf2cf20fc; Mon, 05 Jul 2021 08:01:56 +0000 (UTC) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01lp2054.outbound.protection.outlook.com [104.47.2.54]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-32-OfGckfCGNp6ZLuaYdH6WKA-1; Mon, 05 Jul 2021 10:01:54 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR0401MB2445.eurprd04.prod.outlook.com (2603:10a6:800:55::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.22; Mon, 5 Jul 2021 08:01:53 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::99d3:99cd:8adf:3eea]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::99d3:99cd:8adf:3eea%5]) with mapi id 15.20.4287.033; Mon, 5 Jul 2021 08:01:53 +0000 Received: from [10.156.60.236] (37.24.206.209) by PR0P264CA0208.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1f::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.21 via Frontend Transport; Mon, 5 Jul 2021 08:01:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 80c7ca93-bd35-409a-a1e5-06daf2cf20fc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1625472115; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JOFJxj8avjEiD9E0J0VJqC4QnGcKRQ3TOuePJrJC76g=; b=SEMVfs9QrA/u53JSWsMJPOdSP9TsRSkNN1LR2vw29IhaRwSpzvim65O11ElVzNfNTuFnXI n1vhHUFnYx33MI5Agn5mXdS0KyuPH9sVL6heNQEHzP0chmMrMN4zgphXldgOcFg5nmoTtw /4s8J5Z2Abqj8YQ5tnBjOGL2Y8u4iZg= X-MC-Unique: OfGckfCGNp6ZLuaYdH6WKA-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gP3dY94oL876o9YnWUUZ4ls7V7Wvd4vpaCx+dvEVWRmLcY1E0flOrNx5Fbn18JwjEc1ri5iJmhRWkAyN9s7iZ4FhFbF2NCD0AMvMd4WDqjGp5RW3xRxONt1NogMa98HXzqlbywvx7/XGXND3Dz3dR5hceu01wnZ0/veo124oGOu8IUKRv0HXb3/TYopPMhJkG2Kvnb5/g4ZdI3uKZWG+Ck7JPTpwawhuCQyVumS5MoCIBCKBG7u6nfazKSAaQTAfpmnLweXp/R/g152u4Ge1gRh5r2QLKCweqgN3wCHIkOZEjNoiTa8snjtryLI1AA3QUn1JnXyxCxHfJfIXSwPmAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JOFJxj8avjEiD9E0J0VJqC4QnGcKRQ3TOuePJrJC76g=; b=KaYxCvg/cNzyQ2qa7rjA678zQmZGDo5QzDvFu34daVjqYO72Bl7FQJXqUHQO/YIDEHZ3VPPSs4NUv8gii5ETxbNzk1+yZ7dEclb4P+QEHUBb3e9ArHqBxf3L+UVMQJr7Syiq0n4Ofo09lfhRnSa7sSM1pSKtQErXf4GbCaYIJTtTf4gjF4jWO8N/gb/8Ma8PO+c9/WZm4G5k1vq5VHVxkIirI7hyruYp0buLsioJxAmgJJcdmrSNfbQHEBKLg0kN91irc+a08Ew/FwuqLZU9GQ3UPp8237FifFwa9N7R6jgIvegooCpvhxuZqho/JkeaZANTXmc+sfqHeJAvyMamlw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com; Subject: Re: [PATCH] tools/libxenguest: Fix max_extd_leaf calculation for legacy restore To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Ian Jackson , Olaf Hering , Xen-devel References: <20210702190334.31271-1-andrew.cooper3@citrix.com> From: Jan Beulich Message-ID: <5de9c8cf-de15-ac50-16c5-7c786e8963c3@suse.com> Date: Mon, 5 Jul 2021 10:01:51 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 In-Reply-To: <20210702190334.31271-1-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [37.24.206.209] X-ClientProxiedBy: PR0P264CA0208.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1f::28) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 58c98bf4-083c-4f9d-e913-08d93f8b269d X-MS-TrafficTypeDiagnostic: VI1PR0401MB2445: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RlLJpJ3lnEidsYPUeFCs6NPV3t3SvNcl1OI/8JU3IC/rppjg3GqL+VF4chHrlhcyKBuLvrwvYcP29UhdTraVPxrgsxq2FDShRWFB9xkZCcuUCR6xQIyVCX9ewp91MN3ZO2+BvHy4r+IQoJZ2nUcq3IDB+AhziS9YbXe6v3RLmcC7DhdgvXe6sOOwUzOyc5Yl1dM88NsNUtTJ3kFAfADe38nmsR8ehr7/vdh0WU3cvT6JTblSXFQbovtVcB3eh7jPncdyiqWyRRYTIz/9NQiy3Gc58/Tat571PrG2i1sQWQp1a3M5yVJbT9zwRjf7B29lf1mAhdhOq946TTBkl96R5xbta0si+zGwd1hBHQeW3r8uSQ/5WAY5ToISNzYw9lDQbIu+0fyDBlmOmgFgPeaUkwhlSH6Hm0RRB+2xxDk6jhWd5CSsBk2Ukq2Q0ZVEjzzfSNE3x70fd9HO7IOzWf6vkj9auWKyMkJ7N0ISfv3Vtczm4XBuacmSwmjh8yf7w3QaTeqMLwzUHWSSKHXf3SsFtsGi12A1CQrKBYtAdLQ+skQyNY/qgYhzW7rQgVQs4Wvcc9IwBTDfDthbGBDA6GeiK+KV9ISNjvTPszYs1Vn2GNUlfwCvDIXdgV0tOtDfv2/vN2+mE323yd8IlTKzXsHvzvNqzyOeKMv+KCQJvWVzBd/vX+DU6Bo3ZPycyaCcjWH5KnkHWQnNBwBn480MHm6AtUCHgVk4RxenB+FpzN+R6zYusCUM3MjwsKtQySCSqQGd X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(39850400004)(396003)(376002)(346002)(136003)(366004)(4744005)(31686004)(8936002)(36756003)(83380400001)(66946007)(478600001)(66556008)(66476007)(6916009)(6486002)(86362001)(26005)(8676002)(53546011)(5660300002)(316002)(2906002)(38100700002)(31696002)(2616005)(16576012)(956004)(54906003)(4326008)(186003)(16526019)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RlBuc0IvdDIrcWlzZ2MyUjlNWmFXQ3pWbVRkRWVLVTBZK1Ivb09BMEt4eHMx?= =?utf-8?B?dFdhMDhCdkxVTzBJMlp0OEc5QUk3TVhrNXVqNitsVXZZdjlGQkRzQ1h4MEVL?= =?utf-8?B?UmZqQ003cWRuTmZQTGE3RzlRb2FSK3psUTVxWTVlTXRKZGU2ZmNOc1pVS2lm?= =?utf-8?B?VXEvUG1La09RV1ZncW95WklldExjVTlHY01ZbjJKWCtVUjltZTdrWnNhalBa?= =?utf-8?B?M21HUHJvb0gxNDVBbVhUbHFYakRiMGFMS05QSjJSdnlIUXArSVhjeGV0S3N5?= =?utf-8?B?WExUaVYrV2VNQVd2c21ZOHFpdk12YnlOaStJYXlVYk92Q3N6amVpNElFTkhj?= =?utf-8?B?UU1vVHpDOGxQM2Q0aVJmQnBsejRwa1RiaGc3aldsb0E5cDdrcHRaOWNPTExz?= =?utf-8?B?aFR2dXQrUVp0Sjl1TkswOVRtcEdGVmV3bVFCRmorR2JXcmdyQmVRNzl4aFNk?= =?utf-8?B?Vm9qQTFhemFCNm54ZVpvbmxabTNKS3JFUmFBeWRUaTlTNVpBbTV3S29WRmV0?= =?utf-8?B?dGtjdlV4WmRkQ3NpY1M1Q29MR2pRaXFYWHNDeHYvS3hrdHgwb1BKdzlYM2h2?= =?utf-8?B?WGdDZk5iNEZvd3Z3RWZZQ1lDK1Bac2dCRW1kSm4wbWNncDdsdmFVRjBWMjI4?= =?utf-8?B?NW4xZmFUcUJ1RHBUdGF0WTdNUklOOFVWTm9aMmFOVTIxWm9keE1adlBnZEZR?= =?utf-8?B?bEloZEtZUlBQbnNUNFBwVVpyL0krdmFFSTNXckRwQkNhNUd5OE5BZVBiU21U?= =?utf-8?B?dlRTQWs3R2dDZEtlaE9WcndSN0xHakVEMGQ5MzRITlc1Tkd3QlRWKzlPSnlK?= =?utf-8?B?aStaNzNwQ3MwcVhKMEgzTmIwbjJ5NXcrTVRxbFFuNVdxZ2g4VGpWOUU3V3la?= =?utf-8?B?MjBGTGRKK3lwQTVXb3N5UHJsV0hNRWI2RVVkZitaNmpNbjY1MVcvT0VIcU9v?= =?utf-8?B?TVgrdldtdjFlcHRmVkE0WDVDWE83aG84TGhweU1uQStwUkxKcGhqWHJYNWV0?= =?utf-8?B?ZjNmQzYzR2NMK2xndC84ZlJWMlBwYWFoMnMwS3UrQXZSMlRZSTBnakVDZ2pF?= =?utf-8?B?VzkyT1BMTVBsbEpBbVpUYVlueFFSTGh4ZVJhVldMeTM4TFhDQS9vUXRTQUp5?= =?utf-8?B?MmhSekR3WERMVGk0emxlMHhJWDB6bkt1WjVCcjliMVpRSTVTK2RNbW9NVXVo?= =?utf-8?B?TjIraUdueGxWb1lGYnZpZlZiOHpaWTk3Y2VCWWxIS0U4OWplcExUVXF5S2or?= =?utf-8?B?cU9EdXE5U1NacTVCLzMyMitxWTkrT0pZMUF3RjRpamRXc3lOZ1FTYVlDdGRp?= =?utf-8?B?R3lCenBpeWhLNW1XbTJCcTUrQ081a1RwQTIxRkp3OURqK3NEdzlVMkNkNXdW?= =?utf-8?B?UVZZd2ZwcmhzSVlSQnJJcm1XMGl3MXllV0VhRi9hYU51U29RYnYvQU1aWU5X?= =?utf-8?B?bVR0Tis0bit2SG51b1hyOGZ3eU1XUlpDYXNDY3hvM2hOYXFyeDduY3dPZkZE?= =?utf-8?B?WGVhdG1uMW5YTnEwUVEvTE55SWQ2bGhzaEZNQWFldjdPM0k1K0dpcEdZSlN0?= =?utf-8?B?VXI5aCszM0JLcTJMc3hEN3NLSFJBbWJPMDNiSmtRa3V5dFpmbFVlTWZ1aC82?= =?utf-8?B?bFBRM0hqdmEwc0p0Zko1cGNwdmxsNmxxVTdON3UrdXZXaHRuOVE4dC9QNkFU?= =?utf-8?B?eS92dmpxOVRjMHIxdUVUbUxuTTVDdmVuT1NySWxSMkl3RW4vRmkzVWRnbjBm?= =?utf-8?Q?UNRCqThJxOwoJ38slR8EwmOOte8LIDL3d4HXPyQ?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 58c98bf4-083c-4f9d-e913-08d93f8b269d X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2021 08:01:53.2421 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: RuOpot4j9hnLohGPagNV7gBUuvEBVeRQ+CzLji+2pAzltrxD1gOniCPBGGxRxklvMrgNdOtc54BgVehK1gTk6Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2445 On 02.07.2021 21:03, Andrew Cooper wrote: > 0x1c is lower than any value which will actually be observed in > p->extd.max_leaf, but higher than the logical 9 leaves worth of extended data > on Intel systems, causing x86_cpuid_copy_to_buffer() to fail with -ENOBUFS. > > Correct the calculation. > > The problem was first noticed in c/s 34990446ca9 "libxl: don't ignore the > return value from xc_cpuid_apply_policy" but introduced earlier. > > Fixes: 34990446ca91 ("libxl: don't ignore the return value from xc_cpuid_apply_policy") > Reported-by: Olaf Hering > Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich perhaps with, as suggested by Olaf, the Fixes: line changed. Jan From xen-devel-bounces@lists.xenproject.org Mon Jul 05 08:02:35 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Jul 2021 08:02:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149867.277185 (Exim 4.92) (envelope-from ) id 1m0JYp-00028T-62; Mon, 05 Jul 2021 08:02:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149867.277185; Mon, 05 Jul 2021 08:02:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0JYp-00028M-2z; Mon, 05 Jul 2021 08:02:35 +0000 Received: by outflank-mailman (input) for mailman id 149867; Mon, 05 Jul 2021 08:02:33 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0JYn-000289-FM for xen-devel@lists.xenproject.org; Mon, 05 Jul 2021 08:02:33 +0000 Received: from mo4-p01-ob.smtp.rzone.de (unknown [81.169.146.164]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 59806caa-dd67-11eb-843e-12813bfff9fa; Mon, 05 Jul 2021 08:02:32 +0000 (UTC) Received: from sender by smtp.strato.de (RZmta 47.28.1 AUTH) with ESMTPSA id 30791cx6582UKaQ (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Mon, 5 Jul 2021 10:02:30 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 59806caa-dd67-11eb-843e-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1625472151; s=strato-dkim-0002; d=aepfle.de; h=References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Cc:Date: From:Subject:Sender; bh=2a35YCiZlYF+krv9oSYPP0qwc7dNF0JWN07wu+SYq0I=; b=g81ylTiAx4n9ra+L0C5ZvJkBTOMFvEO9rnW3zkuwkFEomNx5ojU0NMnDo+dujVKQQ2 +RjH/pgf/HfxbhJKyk2N7WxY5Lx6Amk4ghWso4Rc4ACpDtRJ2zbXG0OQ1Klpd6L/Pv0I uw/UbZx9U/q10Quyml2oE18CqbHjlKSWRXYL83laaB2FnDN3cRYDouR1WgONDId6MbX1 l7+suYInxLzcfZjGbOdcRTxHvmI1/dgEx79vgmBZqfIdcxJupf+9cD38n2PPLq6R5v7h cGwXaICsKcrCLc3nIdgiJ3Fa8oT9WgnGlMqAiCHEoc0UnKclFBeiIunCqu0oY2XYN2ps e8bQ== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QLpd5ylWvMDX3y/OuD5rXVisF+Ax6FOE3sSy9BcWAcR/hQoAs9MGk67vg1baqX" X-RZG-CLASS-ID: mo00 Date: Mon, 5 Jul 2021 10:02:28 +0200 From: Olaf Hering To: Jan Beulich Cc: Andrew Cooper , Ian Jackson , Wei Liu , Xen-devel Subject: Re: [PATCH] tools/libxenguest: Fix migration's debug option Message-ID: <20210705100228.4947ed4e.olaf@aepfle.de> In-Reply-To: <06968742-355f-ad37-0681-e51eea256414@suse.com> References: <20210702190342.31319-1-andrew.cooper3@citrix.com> <06968742-355f-ad37-0681-e51eea256414@suse.com> X-Mailer: Claws Mail 2021.05.27 (GTK+ 2.24.32; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/bl.bklON165KmYyWfGn78yU"; protocol="application/pgp-signature"; micalg=pgp-sha256 --Sig_/bl.bklON165KmYyWfGn78yU Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Am Mon, 5 Jul 2021 09:57:21 +0200 schrieb Jan Beulich : > What is "the grant problem" referring to here? Neither anything above > nor the offending original commit has any reference to grants, or a > problem with them. When the guest is paused during final transit, the backends will continue t= o write into domU memory. As a result the final additional iteration to ver= ify memory on both sides will always see errors. The code has no way to kno= w for which pfn such mismatches in page content can safely be ignored. Olaf --Sig_/bl.bklON165KmYyWfGn78yU Content-Type: application/pgp-signature Content-Description: Digitale Signatur von OpenPGP -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEE97o7Um30LT3B+5b/86SN7mm1DoAFAmDivJQACgkQ86SN7mm1 DoCxqxAAk7WabDn5fjrO+RWOBvCAdMST89Qxyyox0g8uwbThD3CHKjHKWGMLHfyi GvMACwgD8s6AX2kFXp2G6jKUJExAfjIvjaQylebdvSP3KqEBqOkqKDopF5RwOyO6 m0WOXq9uGUqXIieuhdLcAQ93hBLRziG/uLN6/RSiN1fAQAWVkcc7dg3S1SgQFfNx FqVBX1ncYCfWkW5W3CyMWQlIRA+R9HcdA514OXzIERDcGYlDvandICx/RTGAVfvo lnXzebWZe1ZihY4OZnNdAO7gWiQrSUHNdtD44PBVBmpo4GU6xSKoMpBLWjD+lHBK 8rJrxbf7VRxcIMaBaEdO6omft0uZXBC0vEZ4/GjNI6eKVSpxxFLA5fouSHW64hEc V99nZkz1Va9bJvrwC5c3i2RkbBd7VaCTusTBiT8LztsPUOmpn4Xgfsj1+2BrdvyG AMLTG1+35ssqhmQ7Xxa3XBQFMwPh4Qu1EWx1EYvSqxM6+7Rm5HkFxMBb8ToYkmqg 7lBHfUEezH6CkF1JWyLXJ8agL4/BnBWnsJnAbjMH85dGPmdA+cUy6D7PwDUC6oXH QaZQ2Bg0RCiIuD4QuwLq2GUy/CghHvK+QG9vZNnbyNiMWygduCwitMWcRuCqZJYB drnUmG/iqnIsKleD3jNePYRggnNgUZRKDXV/twSLahkkeGRoS8Y= =ZKzQ -----END PGP SIGNATURE----- --Sig_/bl.bklON165KmYyWfGn78yU-- From xen-devel-bounces@lists.xenproject.org Mon Jul 05 08:07:20 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Jul 2021 08:07:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149877.277197 (Exim 4.92) (envelope-from ) id 1m0JdL-0002wz-TN; Mon, 05 Jul 2021 08:07:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149877.277197; Mon, 05 Jul 2021 08:07:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0JdL-0002ws-PS; Mon, 05 Jul 2021 08:07:15 +0000 Received: by outflank-mailman (input) for mailman id 149877; Mon, 05 Jul 2021 08:07:14 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0JdK-0002wT-6g for xen-devel@lists.xenproject.org; Mon, 05 Jul 2021 08:07:14 +0000 Received: from mo4-p01-ob.smtp.rzone.de (unknown [85.215.255.52]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 00ca41c0-dd68-11eb-843e-12813bfff9fa; Mon, 05 Jul 2021 08:07:13 +0000 (UTC) Received: from sender by smtp.strato.de (RZmta 47.28.1 AUTH) with ESMTPSA id 30791cx65878KcO (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Mon, 5 Jul 2021 10:07:08 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 00ca41c0-dd68-11eb-843e-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1625472429; s=strato-dkim-0002; d=aepfle.de; h=References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Cc:Date: From:Subject:Sender; bh=wvYRUUMW0u1lIS0ClKqX6IV//60D9uj9l3nt/CtcKzI=; b=PT9oG4Vy7eSnKIUIissGUwerOTr55ViFVDgJsfo0SYdcXuig5DCegMgWG486SIsvR0 T/SLEtZE6FidhjPN+1UovF/lL1J++X8Qq4I3YFkYnrNCfqqDieX07ayEKOgRSd0VWPYu C8RcluCJymERLa2x4GaCl014XqLZwgy9Dec1vfZEIeBvfYJRFECQYIfqqKSzH0YpQ+e9 2S3cpympss2Kq5pGuLcrHnZILTz381zcM15Lmd2vr0J0t8QPPzoSFVhS7GFloEZBOMnD eEFooiYMnICmIWi6wpPrqnEKmeixBp1w9v4CkFciLsYr4Mlc8tynW7047QHqsUQPSMZN lJ4Q== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QLpd5ylWvMDX3y/OuD5rXVisF+Ax6FOE3sSy9BcWAcR/hQoAs9MGk67vg1baqX" X-RZG-CLASS-ID: mo00 Date: Mon, 5 Jul 2021 10:07:06 +0200 From: Olaf Hering To: Marek =?UTF-8?B?TWFyY3p5a293c2tpLUfDs3JlY2tp?= Cc: xen-devel@lists.xenproject.org, Ian Jackson , Wei Liu Subject: Re: [PATCH v20210701 06/40] tools: fix Python3.4 TypeError in format string Message-ID: <20210705100706.48b4a1ef.olaf@aepfle.de> In-Reply-To: References: <20210701095635.15648-1-olaf@aepfle.de> <20210701095635.15648-7-olaf@aepfle.de> X-Mailer: Claws Mail 2021.05.27 (GTK+ 2.24.32; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/nTvfTfR5Apkq/O5_Q/rDeFU"; protocol="application/pgp-signature"; micalg=pgp-sha256 --Sig_/nTvfTfR5Apkq/O5_Q/rDeFU Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Am Fri, 2 Jul 2021 18:19:39 +0200 schrieb Marek Marczykowski-G=C3=B3recki : > Why bytes()? Encode does already return bytes type. You are right, this works as well: i =3D 123 b =3D ("str/%x" % (i, )).encode('utf-8') Any preference regarding the "encoding"? I picked UTF8, but 'ascii' might b= e more correct in this context. In practice it may not matter. Olaf --Sig_/nTvfTfR5Apkq/O5_Q/rDeFU Content-Type: application/pgp-signature Content-Description: Digitale Signatur von OpenPGP -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEE97o7Um30LT3B+5b/86SN7mm1DoAFAmDivaoACgkQ86SN7mm1 DoCzuQ/+MfTkkPlSqy3JgXyaZo7J6r6wsH7zFTtot3KMyWvYI6DVyyFL5n4XjE4T 1l0v/02/6DDGa1qNBkXa+1UpZzgEgt5Z5w61bMD/NPwoi1PjgY8A0Zhxgjp+i+y7 wpolbrTc0eNcz0twNbfpsvdco3XqujsSXK0zm2jPmtupDfGRrLjr996V+ikv1Wx6 hCJk91DXUK0piycdffC+apWSzoALXvB5mDgjPMhMhUvc7m23lDwO9fzJFp+NM3Q2 idGZUw+u3F6WjZkssjP+63F0lKYZgyBvOheXaH+un6cMbDfBrNEhqgvmdatG3OJs hhcguB1/WypQ+/DySgFi2+H0eO+xdjdsZyVe3dVKXnTNbXchgueEZfGoGp60CXyT 7/D2DvuvqZ/CjrXqFRplTHeJes0urZnqStZ6YMJ8Pvtc9sA5e+49VKuJRX6P7Fqr tV9uaiRWj/vmsJ+BamB6CNQLL3u00mImZUfE8FyxTD2JKSmqPm69RLlpdbWHiiii A2QsWqpItLiU7Pw0Q6wwtdUUk7JM6ehKdopJWAKSlENiUriPW4d6jDzJjas9ke8E MHwzVPSbyp3Hj8p4k0d6SlctmICZS2XV0kcIKf4+ple3EFl3Sy33V0gzXLez2hTb +YThiiEm25BFkOVxuY2fdo7kavyys4b5oM0l7eHfX44LqETw3Is= =1CbD -----END PGP SIGNATURE----- --Sig_/nTvfTfR5Apkq/O5_Q/rDeFU-- From xen-devel-bounces@lists.xenproject.org Mon Jul 05 08:09:46 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Jul 2021 08:09:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149882.277207 (Exim 4.92) (envelope-from ) id 1m0Jfl-0003aW-9m; Mon, 05 Jul 2021 08:09:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149882.277207; Mon, 05 Jul 2021 08:09:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0Jfl-0003aP-6g; Mon, 05 Jul 2021 08:09:45 +0000 Received: by outflank-mailman (input) for mailman id 149882; Mon, 05 Jul 2021 08:09:43 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0Jfj-0003aJ-Rm for xen-devel@lists.xenproject.org; Mon, 05 Jul 2021 08:09:43 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 5a115912-dd68-11eb-843e-12813bfff9fa; Mon, 05 Jul 2021 08:09:43 +0000 (UTC) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04lp2057.outbound.protection.outlook.com [104.47.12.57]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-17-uI4kHMqNM8ylFR3BHhTijw-1; Mon, 05 Jul 2021 10:09:40 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VE1PR04MB6669.eurprd04.prod.outlook.com (2603:10a6:803:125::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.31; Mon, 5 Jul 2021 08:09:38 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::99d3:99cd:8adf:3eea]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::99d3:99cd:8adf:3eea%5]) with mapi id 15.20.4287.033; Mon, 5 Jul 2021 08:09:38 +0000 Received: from [10.156.60.236] (37.24.206.209) by AM3PR07CA0058.eurprd07.prod.outlook.com (2603:10a6:207:4::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4308.8 via Frontend Transport; Mon, 5 Jul 2021 08:09:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5a115912-dd68-11eb-843e-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1625472582; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=L3ukqdqargNajk7QomIvgd+mfoUGfHQ8FSpzdFZYCqQ=; b=TcSUy3mq8zB0Vu2kIMHXPXZq6RPCiFhIlzXG8MbNxkM166T+FENnOFw3SRgiJ4TuneZP33 PCziMRHxqeyA3zhR+icrZVcFa19GrjtJNmfcEUYii3m5hoDG4We8RFDgZzwUwK+3uDCjMc brcK93qNuI2436XfBpzyoJTnSh/B1vY= X-MC-Unique: uI4kHMqNM8ylFR3BHhTijw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Se/4kbrB4gyekeCJKQbnUfzb+maUEUaooM6gS5iBcyMGaarmIBZeWjRGDtZm0xqplKNXZyuoxkIq0du6XKVgdopAPzzh3wi6Hv4xIgi9DNNuvhLYCd/k095RpdGhkQuVNpP8mvmSzk7FVt32FEJk3/RRpASfMYoyCJLlx9u8ybX6jyF4lAZP1+8BQNLH8wTtImlrh2pylx+UAy35ZTVE/wwcSnC8ySb4v2fW9Jp6JaB0qLxbrf/Oziwv+N/ant23FcOYvYahu3zSex2es9p9bGfNpZpKnPVts7+JinJIV81Ji/4/hvzuLqgqw9I96AoGJpGqvpQZCXcb9OgZ+K3LHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=L3ukqdqargNajk7QomIvgd+mfoUGfHQ8FSpzdFZYCqQ=; b=GbrempDH+y3B1s39Eo6j5ZweAGdGDxDLE+1ES593WnUYNRcGLyeQfy9Usq1aCGf25hqExG0nzsLMZam+2N7D59RGhZl/aNKrIXA/B2o2gmbcM9DnCSLT440th9i/2ttQtuseMAydgC39x9JBjmZqAZwFsanl+ck4+CbQQuY9TUWg5yqbp7gvv4N6gzSuLc12WYg8UYadvv+A2ZYuH4QvSLSCSFyDR9BQE3fNW04g1zejvpupmE1bcAoSVCDoeuXvilv3ge+htimC7CiDAD1rTYY3J7hW5L3p4l7VZ72uKwxMF3cD+s4ltFBZwhn3rZc1lt6Jjwv040GOvA1LwcLeRw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=suse.com; Subject: Re: [PATCH] xen/Makefile: drop -Werror To: Elliott Mitchell Cc: Andrew Cooper , xen-devel@lists.xenproject.org, Fabrice Fontaine References: <20210702170602.890817-1-fontaine.fabrice@gmail.com> From: Jan Beulich Message-ID: <4dbc8f6f-a283-a5c6-4779-40c39ffb568e@suse.com> Date: Mon, 5 Jul 2021 10:09:36 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [37.24.206.209] X-ClientProxiedBy: AM3PR07CA0058.eurprd07.prod.outlook.com (2603:10a6:207:4::16) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f058d210-73df-4606-1d23-08d93f8c3bf2 X-MS-TrafficTypeDiagnostic: VE1PR04MB6669: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JeS1cpS1mPGPfLdzb5xNvf4i10TzA091I/+w954PVbBi1QuQpRD6BGxrTpx700Jb+1tIYFyDDL8O7QN3BxeX8nJ7ZBzwk18a9nDkUfektTnozsdru7d4X6+OlElE8yenLJDT8f27ON2tnNcH53rWL5sarDT2Z0memIrnNiXm55QQrtjWB0ld1+U7MPTT7ZPyfVPgh5El0VMkuAQPxzvtOQyq9hHexB+8UjrZp6wk2qNnLitvyjceqUA0Ovtvt1i2POR6j30oZ3jl+akt8FoFG4AVAt3jScgV/peGeigJqNoMFKYsUmxixQgmyFVgfZwSb6oiBk1PXWoephGd6efbCv3AGrSfzH/7XfnPWbXFGmHTQejHlwh4qUx4nY+6+QfnVgRk2YZZ5RSnktNFPw3F34wTZ/mdQaoAQyazBhG4Vj43TYdVczfCHRHq1YLvuo0djJAKf+FNvRZWyt7TPlhClLQbJpZVDkL113rgDUDBVy208mq6iecCQbF/hpwUcxbKIX/UQACxy9YkMmfjfqiiK7lwus/+fy82OuHS5snGI9f0kFeTp0EKAmN3OwiJKJLtPoQdVqpAS89C/VOl4S+04T9Jv7tiZbHDUNk7SeubUFYTI6ZMSdOznYMJbpVZVJ7QxOd2G4YD1JiJPpCQsSa5XyaPfc5V+fbBXwkxVxApPK7/BTLpO8KniE8nOXndQ+K1gbppSWW0489d8GoLbSXtLIdVgl8N1M/1ZIlY7q0kOG4RnsX3KmNqixa885j76DT8M/skm+Dmeby95XskbXPSDCUk9qKu9kLskfOjAHv73cfq05OuVbsgw/NkPxUTJu+u X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(346002)(396003)(136003)(376002)(39850400004)(16526019)(2616005)(956004)(966005)(186003)(31696002)(36756003)(16576012)(316002)(86362001)(6486002)(26005)(31686004)(54906003)(66946007)(66556008)(66476007)(2906002)(38100700002)(8676002)(4326008)(8936002)(478600001)(53546011)(83380400001)(5660300002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RlN4WG1ZOUJIaG1IQlMxZ0QyRUdUTzF5a1NNVTFneDhoTk9CT3lGaVRNdE03?= =?utf-8?B?U1lUSUM0R2lLeXlISzNBNlRjQVE4MFdUaW1haHU5VlMwVEpBbU5zcmdIZUov?= =?utf-8?B?d0ZscGx0YnNVRm5SSDJoZU1MQXo2Mnl5OXhCUmtDdkxvbk1pNkgzaEprN0RL?= =?utf-8?B?NmYvQ1VUcE1HN1UzODhtOVVuYVNVYncvVzc2ZlQwUEJRdStJL0wzZmxieHpO?= =?utf-8?B?TDJKdmQrTEJqRGJ5MkhvVVlUNHhidzA1aUV6aVpzTERYcmx6anZKdkpHczFR?= =?utf-8?B?T2VhUFI3YVBRNGo3UFBLcGRzUTNVZ3NyRmd0Yjl2a0tTUlpBNUt5V2RBODFm?= =?utf-8?B?M3NNV2N4eThnM3N0bEFZZFZhQnNKNWZ0SHFhU3hMc1ZjcTBSeGhkblllQTNw?= =?utf-8?B?eHpiMzlTbzdhZTdpejQ2TDkwY2ZvZHNucng4UFM4c0Nwd20zRHlIcHI4dStS?= =?utf-8?B?aFFZZ0lUVEJHWlQyZndJaHVDRSs0MjlyUHREMkQzR0EzNEIxc3VpNnBGQW1l?= =?utf-8?B?RXZ2VFdtRWFtbys2V2Y2MFJvUVVXTjVHMHhMdDlIUEk2NHRGeFBjWVpWeWRa?= =?utf-8?B?NG52MnlBdjlCWGxsZTU0b211WkFMcWt3T1lyNnpCZGJiZkhKZFN0L3M0U2h2?= =?utf-8?B?eDBadldVYTh5Mk9qSHRycmZXNHRWaEtSRkhHck5sSy9VdHVjT3praldnazlh?= =?utf-8?B?MGxKR0dlR2VsR0dneVpockhUcU83SUhmaXdRR3lxWEJQRXJ1T0N4a3NyNnhG?= =?utf-8?B?TlpSSGl6YXlzRm5kdWw4aStWbEtWeU54S0lUQTF0U0U5Z2RTYnlEOC9Tb25k?= =?utf-8?B?M0J3VnAyTHl2QWRxTnZOZUJyYXc5OFk2ekFXVzZhRXFkVS9IeVpaSnVUK3VD?= =?utf-8?B?enBwajh3bzc4aXU5dVYyK0dtWEhRN2hhN09qYkZIOEFBR3lCWEVnWUVtQWVq?= =?utf-8?B?aisvcFIzMVpaMGtVcWxreitubHZKUER2ZFBkV096SzllTXBzWHZSb1lZQ3hU?= =?utf-8?B?WnpNYTFxNWx0R0hPaWhOUEhKZ2djTXVhSHJtR0NuL2UyOHFpZ1hBNHpDTFBt?= =?utf-8?B?Vk1WbzdUZ0pnOWxUYitDd2RVbVM2UElaTGpmdGRyU0tPUEFLM1UwZlc3bi84?= =?utf-8?B?OS8zSldKeTB3ODh0SHQ5Z0ZPRStEc2w5bjZxMDYxR3VwL2xRUFYzNjU0Sm80?= =?utf-8?B?SmJLTCtNS3c2TnFnQW4zaGRuSmFjY2JlVmlqdCtBTU83NGo2cjVXLyswb3lY?= =?utf-8?B?N2JiTGJTZjR4WjJHUlNBOFNLYndiZ1pBU0tEM0lDTzVBYUZrZ3I4cTE4OXVr?= =?utf-8?B?OVhJWW5vQlFINll0MGNTYThvWVNPbHNDY0F1eFVTZnJNRk40Mjg5VGRlNGgy?= =?utf-8?B?V3l0cWsyb2ozekVxbnNjQkN6OHhXYXI1N1RmTHNVTG5MT1dvSlpCaXVXVDRh?= =?utf-8?B?bW1QRW5wMzgxaFdsM3hEcXhHWDVJWkZtUWpFY01jTndxTkVEUnpYMGhORW5h?= =?utf-8?B?NHJreVBLNCsrc21EM3lXMkZHclJDSXJKME4xWmdFUUVLcGRCYS9wVXZRMXc0?= =?utf-8?B?WXZJWDc4dktod01SMWNXUVBnZjEwUjB2Q2NidnhMWWlscS9kY3oyVi9QcEJw?= =?utf-8?B?WFB6WE9uTitGdk9BWjF2M3pOWWk4QWF0WTR0SDJSWjdMY2U2cU94WlZXM0dY?= =?utf-8?B?dW5FNUFkMnBDdnZaWklneCtkb3ZZdnJKbzkxbC83ekJuQ1U1YWk1c0wxNkhO?= =?utf-8?Q?OYp5zZ3gZDZRy1HGZsF3rdDpMxyv2+hpvZ245WG?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: f058d210-73df-4606-1d23-08d93f8c3bf2 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2021 08:09:38.4849 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: x/aDs50u8X+xdfNANgF1DarQDuFF6Qq22Fc0+C5msszpSkx2bHcKDAm2WPsveJlAVugYPrxiJzmTXBC2WrcADQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6669 On 02.07.2021 20:52, Elliott Mitchell wrote: > On Fri, Jul 02, 2021 at 07:51:55PM +0200, Fabrice Fontaine wrote: >> >> I do agree that setting -Werror is generally perfectly valid for upstream. >> However, for downstream packager, it is generally seen as an issue as >> it will always raise unexepected build failures with older, newer, or >> exotic toolchains, see >> https://embeddedartistry.com/blog/2017/05/22/werror-is-not-your-friend. >> It would be good to, at least, have an option to disable -Werror for >> example through a XEN_DISABLE_WERROR. > > Two people don't make it a majority opinion, but if this was a meeting > this opinion would get a second. > > I don't know where everyone is on the spectrum, but I also strongly > dislike -Werror yet do like -Wall and tend to get rid of warnings. > -Werror is good for continuous integration systems, not so great for > releases or active development. Well, my experience with Linux (when I started working there alongside working on Xen, many years ago) was that many people don't care at all about compiler warnings their code changes introduce. While Linux has improved some, I'm still carrying a fair size patch to silence all the warnings that I observe on various build systems (i.e. with various compiler versions). I do this because in a build with (perhaps many) pre-existing warnings it is far easier to miss the one you accidentally introduce with some code change. -Werror is an imo very appropriate measure to get people to at least address the warnings they can easily observe about everywhere. IOW I've always been appreciating Xen being different from Linux in this regard. Jan From xen-devel-bounces@lists.xenproject.org Mon Jul 05 08:16:44 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Jul 2021 08:16:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149889.277219 (Exim 4.92) (envelope-from ) id 1m0JmR-00050A-41; Mon, 05 Jul 2021 08:16:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149889.277219; Mon, 05 Jul 2021 08:16:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0JmR-000503-0g; Mon, 05 Jul 2021 08:16:39 +0000 Received: by outflank-mailman (input) for mailman id 149889; Mon, 05 Jul 2021 08:16:37 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0JmP-0004zv-O0 for xen-devel@lists.xenproject.org; Mon, 05 Jul 2021 08:16:37 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 696cd4ad-1918-44cc-999e-e09b143261ec; Mon, 05 Jul 2021 08:16:36 +0000 (UTC) Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-am5eur02lp2051.outbound.protection.outlook.com [104.47.4.51]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-30-sgVTTz8FNU2OOCCQhsMMZw-1; Mon, 05 Jul 2021 10:16:34 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB3295.eurprd04.prod.outlook.com (2603:10a6:802:f::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.23; Mon, 5 Jul 2021 08:16:33 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::99d3:99cd:8adf:3eea]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::99d3:99cd:8adf:3eea%5]) with mapi id 15.20.4287.033; Mon, 5 Jul 2021 08:16:33 +0000 Received: from [10.156.60.236] (37.24.206.209) by FR3P281CA0016.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1d::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4308.7 via Frontend Transport; Mon, 5 Jul 2021 08:16:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 696cd4ad-1918-44cc-999e-e09b143261ec DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1625472995; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=s4bKf5hBbXgEo6a5rVtd54OMqS2mdJQCMJAA/Bq7mGw=; b=HFzJL0U9e6VY9li11eMf0BfssvFw/iCWpMWwP5QJ2kaL8nYxVqhBM6zfrfOQOf0LUQldl5 Wh4mIAzRaQJ0L05QsklxbouwyOWzUNr2zph7tMg9iUiBrcy8i1t16bw7HZurzJ3k0bz4fP fxNdHI/penldpnmFSj4eQGHbUI5J/AM= X-MC-Unique: sgVTTz8FNU2OOCCQhsMMZw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=b8OuvjGo2WBn4reXFgbCk9ESC1683XMZTjE0OYuPvlvEh/xhsjdhKixQR0IG4lP7REOPb0ZVRa3KRqmqMhts88JyvPG81bactes/x6oaXwtVr1DgNTlV0fbHFbE4eJCay+Wd3YyKRuaTGtMJuAjfhuzCqJ8yzJokPh7ui/xOt9D+cHNmj+nh7C9EoSnuT1kvoysxqO1gYNaLzxel5AqOciBEn1AWWVFvn+HNnNycwvMxIYzryvt4GXevuyqUF+yPfePYRxRsDpaAM2BsjbI2uwB+GDpahiNsdmvICwtLXNAA5nzlnRS+lv7PXR4IhkLxzxHAGk6OUSQqiACUkOHU8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=c9CNVMBAy2PKdkWdmPmAm2tOflzPZitdmZ52sv7Jn/M=; b=jy4Aw4JyCOzNuTFx4U0n8MYDpGG6gN8ujwa2x1vkHHqAqw+8L6Hh9GaH0fhqNLUar0KhzIVe7JN393iyGQURuNeOWPH53MHeN0d14tiPLAuYz0PotF/tO3yRSuWEgE6cPh5c9s2hHDkGe+5A3IGDq4HFm1oFYtkTp8ZQt21sviqxakOiyvgqN+Dd24Tm3+MXHkPmXGkTC+6JnfiDh72i2rvJOKuiQ2xJp6Pk8CSW3J/oCVfznv/u6j1v2LnEQvjQygH99FJqewCqZ+wjBvzHjJy+P675HHkp6h2U88INVkJlekTSDD+Lb2mtofF+mCjv5A1/urRAzExNq666ylwMTg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: citrix.com; dkim=none (message not signed) header.d=none;citrix.com; dmarc=none action=none header.from=suse.com; Subject: Re: [PATCH] xen/Makefile: drop -Werror To: Fabrice Fontaine CC: xen-devel@lists.xenproject.org, Andrew Cooper References: <20210702170602.890817-1-fontaine.fabrice@gmail.com> From: Jan Beulich Message-ID: Date: Mon, 5 Jul 2021 10:16:31 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Originating-IP: [37.24.206.209] X-ClientProxiedBy: FR3P281CA0016.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1d::21) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 391d14e2-f72d-4c2c-b6e1-08d93f8d330a X-MS-TrafficTypeDiagnostic: VI1PR04MB3295: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3276; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: am+6zSCHFwha9591gd5o+rObWULFTHXg4CUFMr+iUMzGC5aYpsmHDyzyZ6lkv4rT4qPddfvYayQVTvvlZGGPhlS6+cziD8ykJw+wXAkCERwqtMZ+rut6NN4wktNkwMJpQNWp2lQPKt592t3bfZOEhUdM0QM4G8lSdZQ7jGyF2v0/NauPZ7vpc0tXrXMSeGjkDGZauH6jb6g5S+oyilh3OB/227YMGMkT1A8F4EYnekglKiU2ZxhxzpuxP3WGQ4jkXPLqMOQHcdEOSBvkvCVFEalcxf3rZYLv/upXq/USSR5HSJJMPcZFjMlqgPcWimzMT2DkDulbdim3N8fRJAsGuV327a/Q8elRf/nv7aeFvcqY/PWnEp2JvdNQNfFoy2BY+Gvv9K/gtOkHobn0FefhFaoVFUotXKvJygVVny/0edW0fowplHpiSAx9rE1/1cOwFfBEtjFqQjO//edbNqVm85r7uEE/nSJgS93xUhwJoYd4TrtrV+cIz/5v2xES1EFuqNn6xGT+HkLRAVqqr8FyErZyGf9n2vLmUGZGJmtTv555vcMnPEUTzbKDI8BgnHlB1JbIZ6QjXXIGbHfrURubE2QztXkRh80rHeaBSNuinK/E7ar1oJintXnLTovBuPSNhsxPfgwyua6NONL+va8QJmrNnpXyIRDLXU2hc/2LuWumkwEg2lPe/An9gmSw6W2POqcdi0Yzpke4pbftbDDNrjVXBTsSlN/tJahxGKizRGNArFGiEyIbR8F0x39tn7soiNbHAXt8LCesZ/dkhXvPJfgPulUG2p6vr7EnU7MztOIcWHlQ1yUoku3JAC2iRXTe X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(396003)(39850400004)(376002)(346002)(366004)(136003)(66946007)(66476007)(66556008)(66574015)(956004)(53546011)(2616005)(83380400001)(38100700002)(966005)(86362001)(6486002)(8676002)(4326008)(478600001)(2906002)(31696002)(26005)(31686004)(36756003)(316002)(8936002)(6916009)(5660300002)(16526019)(186003)(16576012)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?3euCP8dflLixAMhamcGdQFxH1QN86a9W7IKADArUDOCeh82bQ45TYST8RT+C?= =?us-ascii?Q?urAa010GFF0CDNvHK+Up8RQfdBpXdRZmwKMnKL6RACxXB4W4C+br3P8aRCUG?= =?us-ascii?Q?pBAOGBdGxYKjNvH7wuJ64DDP7fbO3hVAlQE6wQ+D2AwpSve1CTKxE3tORd8e?= =?us-ascii?Q?iTrfHNGD0mi7WJK0lduSGPDWJ5HzkHTOFvBi0CrbRrXDMvxRzqjLIEK40aro?= =?us-ascii?Q?HH635AaKtsghJJ6sfPXdFYtrjD7tZglqujaOMEFB4c/aAlUIUq2REq/CVpHZ?= =?us-ascii?Q?/F+7ct1CXxtqEBw0b3h3v16SSpaHANPRaq6d6Fu94PM/FIJrlaSLoTX1UfZv?= =?us-ascii?Q?M/RmIv1LKCShU2+UL/YPytvnDz9aG1NBnosX5ID5RXudb9I/x97NC1KBGBB6?= =?us-ascii?Q?bc60AstpcBXcqCjjVWy4tslSaNxyCXxofDKDpFx+dw+DdEOmI5ntfY8+2Hi/?= =?us-ascii?Q?s9+7et0T2zs8nd3/OxA164AI2DKdWLW0p+UXGM60ULyfKqerT/NblBrBvUJw?= =?us-ascii?Q?w2c2ROVDzGt2dhnm8m35G7t1XuU//MdhPV52h4/UiM1do1MNaM1yP4O6OeGP?= =?us-ascii?Q?PM03346leNxmVzNB3rZO1wjSfhXTMqt9fMAjCMl7XgJE3s9yjEK/WqRjGf/i?= =?us-ascii?Q?k6PC4I2MbTFSzGemzTZe9+8iQPm7+MsFbJ1TH7t4iMDiUlUDEvjfbLo3rE8W?= =?us-ascii?Q?4AWK9t9Qc0bDYoZOq5WqD7uWaDR8d/yDprV5IUa+G4BIuCFw1/SURp3huhaZ?= =?us-ascii?Q?zQKrjadMtTTOYHWU+OIxq0B3/JpvQ6vLuf0UrsmZ2x3Qo1mOA3y2G/4O+Wl4?= =?us-ascii?Q?z6KN8a5j4u6GFSLZSWZrnSZ0kPqWFVt8rJ8Rr0cUmITWDZYUTX1y4wz3riz3?= =?us-ascii?Q?EI9b/L5s1JwgiaXe1k0yLLRa7YDA+9aPcfInuDZ+taTwH3GnJICSFOETrZLG?= =?us-ascii?Q?FAG6aR7r74jfh7a/6+hdXSPiYNq3DBBTXgsIGV96bKJRKw0HTn69EULq6fJr?= =?us-ascii?Q?A7kPj3tG7cyX896xzQV0fLcoQTYoC+z3kzJlspqjkANc/RCLd9URiEt0rfu3?= =?us-ascii?Q?MMg5nRybOCOBtTww+0HrtRVMouxFRUQH/JIWz8HQw1QmE8+NnPI+imM2Qzbp?= =?us-ascii?Q?2zNVu+RyXg87yEPSHVOkj+8u+Xx3nso70R85AwzEXabJlwh6/dZLPgonriC9?= =?us-ascii?Q?xiYo3KQzLSbMvxAf00V2Fwi3Cf4sW0XG974tjuifWszKNP49WpwmmMqm2JOM?= =?us-ascii?Q?TcL98SVjXTOvK+qjkb9dQiIO3zPJUYPMZwUR8RRgl5UMNKSAxirRAtD/DLtx?= =?us-ascii?Q?y/CtMJQ57PTLs/TDy7Sdu9LX?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 391d14e2-f72d-4c2c-b6e1-08d93f8d330a X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2021 08:16:33.0583 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: uae/tD/rspd66FK2AmluqWm03eFdXcww89PzMI6MnWWX8pOwtRZRL8iX0GCorQ/FCFP+mvmkR7WCidz+bwD/ZA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB3295 On 02.07.2021 19:51, Fabrice Fontaine wrote: > Le ven. 2 juil. 2021 =C3=A0 19:34, Andrew Cooper > a =C3=A9crit : >> >> On 02/07/2021 18:06, Fabrice Fontaine wrote: >>> Drop -Werror to avoid the following build failure with -DNDEBUG: >>> >>> In file included from :0:0: >>> /usr/lfs/hdd_v1/rc-buildroot-test/scripts/instance-0/output-1/build/xen= -4.14.2/xen/include/xen/config.h:94:0: error: "NDEBUG" redefined [-Werror] >>> #define NDEBUG >>> >>> :0:0: note: this is the location of the previous definiti= on >>> >>> Fixes: >>> - http://autobuild.buildroot.org/results/66573ad0abc4244c0dfeac8b684a7= bfcc31c0d4d >>> >>> Signed-off-by: Fabrice Fontaine >> >> For better or worse, It is Xen's policy that -Werror will remain. 95% >> of the time, it is the right thing. We will however build failures >> whenever they crop up. >> >> This one is weird though. How is NDEBUG getting in twice? What does >> the rest of this build environment look like? > NDEBUG is added by buildroot in the command line if the user sets > BR2_ENABLE_RUNTIME_DEBUG to false since > https://git.buildroot.net/buildroot/commit/?id=3D5a8c50fe05afacc3cbe8e734= 7e238da9f242fab0 I suppose the build environment setting is really intended for user mode code. I question its applicability to the building of kernels or hypervisors, but I can see that opinions may vary here. If we wanted to honor a pre-existing NDEBUG, how about simply making xen/config.h have #if !defined(CONFIG_DEBUG) && !defined(NDEBUG) #define NDEBUG #endif ? This then raises the question though how an external environment could achieve the opposite effect of suppressing NDEBUG's definition despite CONFIG_DEBUG being set. (The main point - hence my view expressed above - is that we switched to Kconfig to centralize where settings get established, moving away from taking ones from environment or make command line.) Jan From xen-devel-bounces@lists.xenproject.org Mon Jul 05 08:18:54 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Jul 2021 08:18:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149894.277230 (Exim 4.92) (envelope-from ) id 1m0Job-0005ed-Gd; Mon, 05 Jul 2021 08:18:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149894.277230; Mon, 05 Jul 2021 08:18:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0Job-0005eW-DV; Mon, 05 Jul 2021 08:18:53 +0000 Received: by outflank-mailman (input) for mailman id 149894; Mon, 05 Jul 2021 08:18:52 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0Joa-0005eQ-5o for xen-devel@lists.xenproject.org; Mon, 05 Jul 2021 08:18:52 +0000 Received: from mo4-p02-ob.smtp.rzone.de (unknown [81.169.146.168]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id a08dc4ba-dd69-11eb-843f-12813bfff9fa; Mon, 05 Jul 2021 08:18:50 +0000 (UTC) Received: from sender by smtp.strato.de (RZmta 47.28.1 AUTH) with ESMTPSA id 30791cx658IjKh5 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Mon, 5 Jul 2021 10:18:45 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a08dc4ba-dd69-11eb-843f-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1625473125; s=strato-dkim-0002; d=aepfle.de; h=References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Cc:Date: From:Subject:Sender; bh=p+Os4nWW2/EfYs3AdH+v+c1xdUv0OHbHha3a92jlNLA=; b=YPJUKZIsn94iV0CtlRLYy+mp5fwwISb0QRsOWgktxznHJPswp4D7pd9Mo2iaG2YJn1 CMKN6MYSXlF45k96Q4TiqiMOrMvXj8iIc0N+2JhMy6Yh6sn3MXQwKrMO6pRt1k/Utc9f ByKPopAZBOJgC1IQoCz6qUm1GeDvl/RwjFp9Pn7MOBI2r7tFaf+okH/sW1szDnseniCC 8DcvyAiZY8n4wZQ7XaJsgmIPEc0tf2NNOlNI5bFDQVO5RB5xBtEaQ3HJVqfNGU0EYDfz fNFf8oXKkzKb9z2l/e60Dw40j2zOBH3c9VemwpYST9PvJ9BXhSVKJLQ9DNB3kCA23Zod LH0A== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QLpd5ylWvMDX3y/OuD5rXVisF+Ax6FOE3sSy9BcWAcR/hQoAs9MGk67vg1baqX" X-RZG-CLASS-ID: mo00 Date: Mon, 5 Jul 2021 10:18:38 +0200 From: Olaf Hering To: Andrew Cooper Cc: Marek =?UTF-8?B?TWFyY3p5a293c2tpLUfDs3JlY2tp?= , , Ian Jackson , Wei Liu Subject: Re: [PATCH v20210701 06/40] tools: fix Python3.4 TypeError in format string Message-ID: <20210705101838.2f760ed9.olaf@aepfle.de> In-Reply-To: References: <20210701095635.15648-1-olaf@aepfle.de> <20210701095635.15648-7-olaf@aepfle.de> X-Mailer: Claws Mail 2021.05.27 (GTK+ 2.24.32; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/vjqlvP02Sqe5JcDvh8/KeO2"; protocol="application/pgp-signature"; micalg=pgp-sha256 --Sig_/vjqlvP02Sqe5JcDvh8/KeO2 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Am Fri, 2 Jul 2021 17:39:54 +0100 schrieb Andrew Cooper : > However, the % (phys, ) with the trailing comma is deliberate to work > around a common python error, so wants to remain if you're keeping the > %-formatting. What error is that? Olaf --Sig_/vjqlvP02Sqe5JcDvh8/KeO2 Content-Type: application/pgp-signature Content-Description: Digitale Signatur von OpenPGP -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEE97o7Um30LT3B+5b/86SN7mm1DoAFAmDiwF4ACgkQ86SN7mm1 DoCZEw//RgDM8GOUVPL5r5QukLmJy/ZteSw8A6QzvLK4Trtsk+0ASHNCyjdmAY/2 tgK0+PMZcsZUykwA5DDoV0fBKytaMrQG3MRKSCNCtlJkBZq87BngUQI6WCKBqitc zrfT38gAC/B51Oh9PEjj4G2C/99VkQsAYuMsBepfkcu50Sh04KhBrmAh1h/ZXscd E2n0qO/ohZWcuEx0eR5nBksju3CPXeo22qv2H3dFNPfsqaSZk1ICtzEQDCtjJ+HN yYEeQmxlGsikhOq3pJ+H4lE4ZmMj+bcMt+bq3Vch/+74uRNBWBghCsTeLwEvNJHQ f89/J1LAnxOFPf6/4dDOU2aMGNbTOSMWa529uDOSkyXocWCixl4Rqq4Wam9SYvno qdNFyKgoMpg4rj9SurxNBcy4zOkuiivHuqmoostUIhzd1t0yTri2p54Zswizl8Hw U91Btmn+JwR2LTnFUf/wiEuNvTuJxKm3FlRK2adeBpL4a+s7tsPl9DUBLz03e921 T/HG7LFgAmsh4EXvx9FukYGMZSS22sa1s1T2BvYTof6HAkqeQqvRugFbaAUkPfl4 sufhk0z6DS9npMT4BjWrQ0lrQZBOQoaUctu+/y2FwaHL1PtUsSRNXp+I465d8eCC ajmR9yg5xBgW7IGueIlU3q0ayT/ZlpRoTC+iO0RgRVLTANgtAQw= =ChGU -----END PGP SIGNATURE----- --Sig_/vjqlvP02Sqe5JcDvh8/KeO2-- From xen-devel-bounces@lists.xenproject.org Mon Jul 05 08:22:45 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Jul 2021 08:22:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149902.277240 (Exim 4.92) (envelope-from ) id 1m0JsH-00077B-4r; Mon, 05 Jul 2021 08:22:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149902.277240; Mon, 05 Jul 2021 08:22:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0JsH-000774-1S; Mon, 05 Jul 2021 08:22:41 +0000 Received: by outflank-mailman (input) for mailman id 149902; Mon, 05 Jul 2021 08:22:39 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0JsF-00076y-Db for xen-devel@lists.xenproject.org; Mon, 05 Jul 2021 08:22:39 +0000 Received: from mo4-p02-ob.smtp.rzone.de (unknown [85.215.255.80]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 2860f092-dd6a-11eb-843f-12813bfff9fa; Mon, 05 Jul 2021 08:22:38 +0000 (UTC) Received: from sender by smtp.strato.de (RZmta 47.28.1 AUTH) with ESMTPSA id 30791cx658MWKif (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Mon, 5 Jul 2021 10:22:32 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2860f092-dd6a-11eb-843f-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1625473353; s=strato-dkim-0002; d=aepfle.de; h=References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Cc:Date: From:Subject:Sender; bh=TTZhBPHaLZHYqgrLV6CgQpnqgWoQZfzZzROPIhu2JMs=; b=oK8oCkZO00ccyeQLKj013PBi/qR7VwIpyYgMf9bK5Z6doerTQVMZ+4TYdukudELITF 82VqpnorjyMS5EWbnpz+7iIILAR4d5gXYerIkXJvFH9QdPob7n7JEIhy7ff0erUjM5MI R6r56TiaZ7f7AaydwAmimzb3bgVVy0Ug9tWpOaKSrErvjJpwEp+5hwc/yOeafunKdHCK BMDSRpk6pXUOr3sdluVBYqgnH3NTm0W4tK2JvOqkBD6q3DPnMJJc66RbRvFpJR5I23z9 JLdwEoOmUqad1gspSzm3lv87+C7xZJruTFyZc/PTUXLTSPi2WWP7b3Xw0+eiuLaV6HB7 UlMA== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QLpd5ylWvMDX3y/OuD5rXVisF+Ax6FOE3sSy9BcWAcR/hQoAs9MGk67vg1baqX" X-RZG-CLASS-ID: mo00 Date: Mon, 5 Jul 2021 10:22:30 +0200 From: Olaf Hering To: Andrew Cooper Cc: , Ian Jackson , Wei Liu , Juergen Gross Subject: Re: [PATCH v20210701 10/40] tools: add xc_is_known_page_type to libxenctrl Message-ID: <20210705102230.48a86473.olaf@aepfle.de> In-Reply-To: <3c0efa9b-aaff-b4b7-0fd5-9eed32b20e01@citrix.com> References: <20210701095635.15648-1-olaf@aepfle.de> <20210701095635.15648-11-olaf@aepfle.de> <3c0efa9b-aaff-b4b7-0fd5-9eed32b20e01@citrix.com> X-Mailer: Claws Mail 2021.05.27 (GTK+ 2.24.32; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/LXSuzQd6=G1afiLJ6WN7rZ1"; protocol="application/pgp-signature"; micalg=pgp-sha256 --Sig_/LXSuzQd6=G1afiLJ6WN7rZ1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Am Fri, 2 Jul 2021 20:20:08 +0100 schrieb Andrew Cooper : > Subject needs correcting after v2. Apparently I missed some places while removing the old "xc_" prefix. > However, given that this is in the save/restore common header, does it > really need a prefix?=C2=A0 Simply is_known_page_type() seems good enough. Sure, the possibility of clashes is probably low. > > +/* Sanitiy check for types returned by Xen */ > > +static inline bool sr_is_known_page_type(xen_pfn_t type) =20 > uint32_t Why is this better than returning 'bool'? > I can fix up everything on commit if you're happy with the suggestions. Yes, I'm certainly fine with it. Olaf --Sig_/LXSuzQd6=G1afiLJ6WN7rZ1 Content-Type: application/pgp-signature Content-Description: Digitale Signatur von OpenPGP -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEE97o7Um30LT3B+5b/86SN7mm1DoAFAmDiwUYACgkQ86SN7mm1 DoAFhhAAlAs5jdLBG/51YrRTD7/0TLw1xlnNkmG63DhqGiVBsDvTjjMSo6AjBvq+ I0t+/ytpMuGsiUsMuck3qaW1Gj0EXEXVugqOrBeRClC6YrU00E5ITXh6YDdiRgG/ NdodWDYfu2aBBQ2E+BIRv3oOMSWUi/oEnTzSb9gx7lgVfwjnr3F2nadv79C9Q3Zg r8Xac52brDzINigl5DAe4ycZDSDGo2tydQVBxLRNCd5T0FB3gRVm1ILLtDjmoorP sw+qdFWzfRZU/KT+KYBG+1V0guTqPp2wfWRRE3scHaxHlkPqwKcQ0UJpj90Hr60A HcJ+KcMK1xvDDoBtNsVMVdHUAievcS57YG2LBjWxdf9ni6B6Ha0CKoyMTo237dkW beqxHvQb2kc15yQ6M3DiYehaLp5NgzNDkKu2UYHWO1h2aPeofcwWvd1fKicL8cHD H36wz3QvIt9MuVLO+8pMWCKBFJH1mDhg89m2iV9BVMLG+2Unwgjr/LFiGEKTLtWO ny9ZX8KPJwcJ/v93CuRR7PmG5jj2PfvF3yo6ADo7YDS1ywH3voN+o0k18V7CwXVA Sc31Go1L58yUHKqgI88jQ8PTQ37U/RfN+1Clu6T6AkEcvDTzXMW5ihEc+DKbLn0I z6H/1/H7cphjXsletWrACqKlhETfQiivUUwLIGR+qoVfcGF4bk0= =reY6 -----END PGP SIGNATURE----- --Sig_/LXSuzQd6=G1afiLJ6WN7rZ1-- From xen-devel-bounces@lists.xenproject.org Mon Jul 05 08:23:07 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Jul 2021 08:23:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149906.277251 (Exim 4.92) (envelope-from ) id 1m0Jsh-0007dB-D5; Mon, 05 Jul 2021 08:23:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149906.277251; Mon, 05 Jul 2021 08:23:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0Jsh-0007d4-9t; Mon, 05 Jul 2021 08:23:07 +0000 Received: by outflank-mailman (input) for mailman id 149906; Mon, 05 Jul 2021 08:23:06 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0Jsg-0007cu-K0 for xen-devel@lists.xenproject.org; Mon, 05 Jul 2021 08:23:06 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 38488aa6-dd6a-11eb-843f-12813bfff9fa; Mon, 05 Jul 2021 08:23:05 +0000 (UTC) Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-ve1eur03lp2054.outbound.protection.outlook.com [104.47.9.54]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-4-NCa0M6c4Nf--oMymD_jP1A-1; Mon, 05 Jul 2021 10:23:03 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB4381.eurprd04.prod.outlook.com (2603:10a6:803:6d::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.23; Mon, 5 Jul 2021 08:23:01 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::99d3:99cd:8adf:3eea]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::99d3:99cd:8adf:3eea%5]) with mapi id 15.20.4287.033; Mon, 5 Jul 2021 08:23:01 +0000 Received: from [10.156.60.236] (37.24.206.209) by FR0P281CA0067.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:49::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4308.8 via Frontend Transport; Mon, 5 Jul 2021 08:23:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 38488aa6-dd6a-11eb-843f-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1625473384; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6I6mIlcgCPFdIPQ9lBmvmFHFSFqhliUgJ9G7du5aNmQ=; b=T78Q3AXumWgU8aiw7Kdnvl7FxJxeFovOp8YFR2XQ2f8UZhlbYaozj5sIHQCyFm+jRN8aMA BAexTAOWEz/JK/KImjCuhzlEU7CK5RLNAGIM2k9YQDQwnJdHHM7O7snldNLVq13KO3ArDp QYFGKguf9Pv/Uf1oOnwUKS0FZyLGv2s= X-MC-Unique: NCa0M6c4Nf--oMymD_jP1A-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LDxzAHj0c/X+8UcvDdLaub8tfE/nr6K5tklmYhUfUlBkp7Nl7ZSducvurAEhkOcSo+8pdd2uuNLdIy6Rp/aXPTnup7QmW5BUR8DQwM7b9BEykr3rq7qvet4DG8btCPNzuB4qc72zJglMBo6WoMY+r/9tWLtf04Nu+Hl+2hfcOBuG0cQSNA7ll7DDBxjh4Lt4Rg/pl5XhtGGanc3l+Ece3XUROIJZKHJi0WMEcszcrg40GbBIw5d5w57G3ploScd3jTL/9O29JeeGKUQcb0szTcEAdtICVF5Q3EUB1fjt+pAwUZiwdQd583kk+iu28UAgeeqpf9l2cqaQLs826daSmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6I6mIlcgCPFdIPQ9lBmvmFHFSFqhliUgJ9G7du5aNmQ=; b=UjN7+91zY+GR9dMtgkY0rjIgA7k44ugslwV33lkMWh7ETzcn6gCWbEb0s2d2WlwM3C/DviKMv4Hw9+N+aHaLbK0ft7m2H4ruVDa5Peo5xU+zWjG6Ukm1crB+mWwlmzcuoiUcttQ43jN7tUO/b+D01GkqhXBUdg7KRwgEG3/w6AeXBkil4BHnT5nG/tlbeNHU1c5gohRQrT7RwAzHD51IakoQb9uGqniOescbUvwf7bH2l6eYVWlx+HwT+Jhd84UAz2XSjNGGKFn5QJ3Oqi1FkzRg3XIK5Agxjgmg/R0mx3XzF5CGgkgpxSns7QBVShzoyEg5JvLrVvUrLJs88zkX/g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com; Subject: Re: [PATCH] tools/libxenguest: Fix migration's debug option To: Olaf Hering Cc: Andrew Cooper , Ian Jackson , Wei Liu , Xen-devel References: <20210702190342.31319-1-andrew.cooper3@citrix.com> <06968742-355f-ad37-0681-e51eea256414@suse.com> <20210705100228.4947ed4e.olaf@aepfle.de> From: Jan Beulich Message-ID: Date: Mon, 5 Jul 2021 10:23:00 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 In-Reply-To: <20210705100228.4947ed4e.olaf@aepfle.de> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [37.24.206.209] X-ClientProxiedBy: FR0P281CA0067.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:49::21) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 804f2bdb-9019-4642-e7b6-08d93f8e1ab6 X-MS-TrafficTypeDiagnostic: VI1PR04MB4381: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3826; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: u3+ZdEfZ2ZD8gB3F/Hdv0cm1w2XTfjwON5dIQeLFI8o47/Ki0uREJOcw1KNbdCnqDTepgFILYh1sXiXLRv5kPmPdTuVm9+4bQ1epwW9VlYX1wz+9JLR9hPszrGP9ykoNhck+UDkM5nt6T53+to5wQvK+Iz32Z4PVsqBVlCzpjfz+YGU7Bhp62nbbTrMmvGfDGhWDWoGPfcyA5aQQrERViDoKGJ/w5WQuTWjRQWiB2Z5wjZNUn8d+nnPFrY9hAvThzr+cf7XjoT5ljJLbinA6gTYGbCRrbEgs+CB2sNhNF03l1ooWsUQgqY5yOtDNhLO4npVnSbYziY9FIALmMgJqtDXgLbvzdWRoJXb5v+IRy0rEfJ6Gr02kzCvSDijDoPo7ymPGHsqjeCrWt4j+HopTIyFpOr1cx/G6IN6Ul58eAjzeJ3BweCOuwd4M5Bo2enaUkcWd1MmLvyNvJgZVeK4f3Uxi7i43Gb/iIsA1XkiMoJA0eph9RkYh+yitSUUM5qgs0yFG+zEC9di7qIu6horoujJy30hI+jycXaIzwEOV0TZ9ELOHmAJDDneTMLh4evEOCefY+QxbEHz0uFERHj5W3runUYuIMsetsReRW0Inwx5ZGcf1TN6TKCqxrf51OnjB3nCwrr0LRu9zajqNyekhHibiOnNC6h7vgvNPXqi9b+KV+hGgeiUJPvQHCvpOvjdPbsy3oeKL6asZs3OoWGfeLWKR3A2m+Ueye0EJV0Si4pU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(396003)(376002)(346002)(136003)(366004)(39850400004)(2616005)(38100700002)(6916009)(956004)(54906003)(16526019)(66946007)(186003)(6486002)(31686004)(4744005)(26005)(66476007)(66556008)(478600001)(8936002)(36756003)(8676002)(5660300002)(4326008)(86362001)(316002)(83380400001)(2906002)(16576012)(53546011)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?Windows-1252?Q?QirCUJ1fU/GF3JnVxbZLBACr1/b8d+TmGc5gj2Dv0m6W0QxkpOgJCI6G?= =?Windows-1252?Q?rqaj46R19yNvQ6Kx+BiS8OMa4NjI+KXzBEpYIcPBFmFgPpYh2R9pQS9M?= =?Windows-1252?Q?fwejlBfgLdtf/dlp+iifUsiTqXAo/ZaN986eW2uk/VVqgLK7Nf6eSO/f?= =?Windows-1252?Q?JmhYCRRpleuvTZIfqjvBUXHU//hgzPAt2XAzJl1wWJC3mkTXLf0rgqmr?= =?Windows-1252?Q?6Fs1CAtOsTzNBINALX4UGVlwqEcfiQOpSAHZuKSb2ILxK5jjcmBnZuns?= =?Windows-1252?Q?CfmZd2S4oMX/Dth2UNm5/rHJoyubyz4tXSLBpaRYjLMotrxAF6UZlOYr?= =?Windows-1252?Q?PPepFEBKW7OUW6CUY255UDAPiFHFUtnIL3dZWd8T1E32UpSW/mmnEQ8d?= =?Windows-1252?Q?A/UK7nDADuZGXEgMjNtLpa3txMgWrOK9r98zmswWlDfiy284HHGwy5cu?= =?Windows-1252?Q?Im+f3iyZZ4uSnbDxSZ4hhH64EnEvVKuQ+sS6c+3l0nXsbGjcgnORdVuz?= =?Windows-1252?Q?Gud7icAIKQfCR608H3uxlUc5Sr4NbZsgPbRQ0scLUZ3KRJ+t35t67roD?= =?Windows-1252?Q?ZQ+Oif4iklzr8/pXarYJGeXncZvB891Tm2OrFzYsibjz2vtJTgW/l65u?= =?Windows-1252?Q?+N+wbCynrJAqqFzhr/iWg0AsXAlT263/XymiirHC7GXbcyFIAHjMhLrQ?= =?Windows-1252?Q?R60R+zjIYDQyz/zAymcG2zrCHibZBlT+wo1ebwdJvQtM09xx4Mq9jOt+?= =?Windows-1252?Q?Vmo8BzQOROz9h8G1EaTlGasaxzljGOqcUIUeQaElAzbhKPnb3Vhl+xS5?= =?Windows-1252?Q?k9atMdmLCIJ/mEdaPsDFyq2N6lZVlGMuPS7Q4ZlC3xYKjdQr6lbvtrdn?= =?Windows-1252?Q?ySGm5u5GhIwQNAD/Z2Uqt6gJ9CcuQGBJwypaWuqZJ1HoxweyoJWI7YDa?= =?Windows-1252?Q?pRpFG3Ys7CApNJeDokHmbeYxFGq0Pl/yTo9xZIn4EXoAi2abCZDAzS91?= =?Windows-1252?Q?TC8qnS4Pw7mWz8g4R8L8LkKmaCYO7Bqz5K+YCNjiOHAtiIIH4c3SI09I?= =?Windows-1252?Q?IgZBEmNlDk2QQU2MEcZwmF0fEeu3hIpBiX0nuWawJ75SYBlwHLRcZRyx?= =?Windows-1252?Q?aN8SGHL129A0FVgbwotdTi+QcyJDmj81G99U+n3U+hZUQQthR/R+zN8R?= =?Windows-1252?Q?G4XioFjHfgoVul15trlcX+l3ew2mRrGJ8C8+ZZXyr/Zxwj1EzB0bzSRz?= =?Windows-1252?Q?bU3Mo9QymM6i8+lDU59dJ9gFAD47x1/8/YsIUCbIbOrHWtNuO4p5A9Wx?= =?Windows-1252?Q?oU7BCWZzilgz+kDi3aUzxVFMpD1IxW5KmzwkcKAi6PZJEjwz16Na8YZw?= =?Windows-1252?Q?rQDqMBsXLPu6benV36O3uFhH2fGGvNEVmhY0YYzNJw+gNUseh9GvFIp6?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 804f2bdb-9019-4642-e7b6-08d93f8e1ab6 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2021 08:23:01.6795 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: DKTN5XDcF/2Bs4OmP9cBjBFODbijo9ghvDFecwj9IDMbi4QlZ8Elh4XW/1R6KVU1eXzYLBPzp9kbY+GMpLPJ9Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4381 On 05.07.2021 10:02, Olaf Hering wrote: > Am Mon, 5 Jul 2021 09:57:21 +0200 > schrieb Jan Beulich : > >> What is "the grant problem" referring to here? Neither anything above >> nor the offending original commit has any reference to grants, or a >> problem with them. > > When the guest is paused during final transit, the backends will > continue to write into domU memory. As a result the final additional > iteration to verify memory on both sides will always see errors. I see. A similar problem then exists with at least the FIFO event channel per-vCPU control blocks? > The code has no way to know for which pfn such mismatches in page > content can safely be ignored. Well, in principle this can be known, but it's expensive: For a paused domain the grant table can't change anymore. Any pages referenced by a valid non-r/o grant table entry could in principle change. Jan From xen-devel-bounces@lists.xenproject.org Mon Jul 05 08:24:24 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Jul 2021 08:24:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149912.277263 (Exim 4.92) (envelope-from ) id 1m0Jtv-0008JB-Om; Mon, 05 Jul 2021 08:24:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149912.277263; Mon, 05 Jul 2021 08:24:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0Jtv-0008J4-LJ; Mon, 05 Jul 2021 08:24:23 +0000 Received: by outflank-mailman (input) for mailman id 149912; Mon, 05 Jul 2021 08:24:23 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0Jtu-0008Iy-QM for xen-devel@lists.xenproject.org; Mon, 05 Jul 2021 08:24:22 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (unknown [40.107.22.80]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 65a38be0-dd6a-11eb-843f-12813bfff9fa; Mon, 05 Jul 2021 08:24:21 +0000 (UTC) Received: from AM7PR02CA0013.eurprd02.prod.outlook.com (2603:10a6:20b:100::23) by AM9PR08MB6802.eurprd08.prod.outlook.com (2603:10a6:20b:308::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.33; Mon, 5 Jul 2021 08:24:19 +0000 Received: from VE1EUR03FT005.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:100:cafe::c9) by AM7PR02CA0013.outlook.office365.com (2603:10a6:20b:100::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.22 via Frontend Transport; Mon, 5 Jul 2021 08:24:19 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT005.mail.protection.outlook.com (10.152.18.172) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.22 via Frontend Transport; Mon, 5 Jul 2021 08:24:18 +0000 Received: ("Tessian outbound 5d90d3e3ebc7:v97"); Mon, 05 Jul 2021 08:24:18 +0000 Received: from f1e79c82518b.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id AC153FE1-2DB6-43C6-86DC-8DFF67DD35E2.1; Mon, 05 Jul 2021 08:24:11 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f1e79c82518b.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 05 Jul 2021 08:24:11 +0000 Received: from PAXPR08MB6816.eurprd08.prod.outlook.com (2603:10a6:102:130::10) by PAXPR08MB6589.eurprd08.prod.outlook.com (2603:10a6:102:159::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.23; Mon, 5 Jul 2021 08:24:10 +0000 Received: from PAXPR08MB6816.eurprd08.prod.outlook.com ([fe80::4a9:5afa:372e:97f5]) by PAXPR08MB6816.eurprd08.prod.outlook.com ([fe80::4a9:5afa:372e:97f5%3]) with mapi id 15.20.4287.033; Mon, 5 Jul 2021 08:24:10 +0000 Received: from smtpclient.apple (82.8.129.65) by LO4P123CA0461.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1aa::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.22 via Frontend Transport; Mon, 5 Jul 2021 08:24:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 65a38be0-dd6a-11eb-843f-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tEl4brartcAHQUPbgw9ZN9Araas3hK5D+e7rf16BL8U=; b=qTAvGIb8pc+5GZqweFCFqFdSvU3clQ4SsKOMe+73X98hE/QV7ZUigq/f11r+z+a/U7FUXzKpxf52coQHQoMi5wWJPXjXLWpMZPewKfPWi6zMHk2DkOLMOAt/isRI4QXpUvuhrRVEflAhLlGu1mkJmBBGqlYZtFQo7NI09j3H2EU= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: 0d3061f4468de5f4 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FTM334XLOVzTICEGsc2PyISJGN+4eM/70cByTZVuNWl25N6rIrh8z6U/qCdOn/ZoZw6xpTdhpf44OFYRy8nzT293wqlkSIZpXvbbJsoqEob3SyBwjzIOVD+6lQe0bjei2WEww5EkseswITxP9PpPcGg0FcWdn8QuRhNu14HpNZgdqnotijdZs6JycwFFDaPO9ZhI40JaQB24aeKjQVwxbDmiSvKBuV8cGB+8nTK2Lod4i7onNYHmCRp+sU7iqASe0ZK8WJw8AB8743xzV/C2BZP9KA/kuBKUQ5LfkxaEkeIE7ox2oEKLYZ0GiOZHB/q5erDAZu3Atr29fUZSLm4ivg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tEl4brartcAHQUPbgw9ZN9Araas3hK5D+e7rf16BL8U=; b=DqQrucEqNsK8Gk7LjELBg5rkoyFaYLxXZNcuMbu95HjyzZULmGWbFfnjyNyyZYDOetFXlzZG6bnI697g99oz4wA+nGYsgFTn71wt1rdief61tnnO3tMYAAasOhxSURAGDxpShGuVtHdHpj03Ol/oMFWviZY9xTn2kxLuH465ZVLfv8/nUZs2W5FzV+/06ZAlk91wMGGgecFe6viP0fjsQuSV9nEVF+6p80/IXyBgZSFCQ2/wTiXHSZh7D2f7DquxxuUEvahsEAIEAnk5U+4DOC0Mcw2dvgXKyuzycjqNjmt1HV3H7wVKbOyFxp1L3/R6ibi5pw92Y5mNViw4VRl4+A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tEl4brartcAHQUPbgw9ZN9Araas3hK5D+e7rf16BL8U=; b=qTAvGIb8pc+5GZqweFCFqFdSvU3clQ4SsKOMe+73X98hE/QV7ZUigq/f11r+z+a/U7FUXzKpxf52coQHQoMi5wWJPXjXLWpMZPewKfPWi6zMHk2DkOLMOAt/isRI4QXpUvuhrRVEflAhLlGu1mkJmBBGqlYZtFQo7NI09j3H2EU= Authentication-Results-Original: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com; Content-Type: text/plain; charset=us-ascii Subject: Re: [PATCH] tools/xenstored: Stash the correct request in lu_status->in From: Luca Fancellu In-Reply-To: <20210701140307.2516-1-julien@xen.org> Date: Mon, 5 Jul 2021 09:24:04 +0100 Cc: xen-devel@lists.xenproject.org, raphning@amazon.co.uk, doebel@amazon.de, Julien Grall , Ian Jackson , Wei Liu , Juergen Gross Content-Transfer-Encoding: quoted-printable Message-Id: <42DD523A-826E-4404-9B50-2BF0494F882B@arm.com> References: <20210701140307.2516-1-julien@xen.org> To: Julien Grall X-Mailer: Apple Mail (2.3654.100.0.2.22) X-Originating-IP: [82.8.129.65] X-ClientProxiedBy: LO4P123CA0461.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1aa::16) To PAXPR08MB6816.eurprd08.prod.outlook.com (2603:10a6:102:130::10) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 24b16ae6-a2d8-43e4-c966-08d93f8e48ca X-MS-TrafficTypeDiagnostic: PAXPR08MB6589:|AM9PR08MB6802: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:4941;OLM:4941; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 8koR8Qwg/F0YE+u6TeQCr0UIRT8GHT9ln/fw41Uw6eUt2DpluJznsOOgdneFfn2wjGsBs35MPeTD2WRxGsaJ28Not/GTfqYpdE8iH5RbW5+SpwilITevhWLYxEJh4f62RO2inmmUSGiBwX1EcPuCr0bWHZafhcsKaucPsO8hteRvQ8yU53qs0Kh8mjRFic3Gq5vC7js2Rpl+3Rycj6C7Jm0GEuubkpS3zOSkQPJwMlNkgon5qsmzqoQQrfqLwrQJRphKbSozkwWR77taxUQ4cvi3BQf7IIlezBfvc7BsRmMDh7MsWtjAT3/e6hj3jE0LFnJY+eU3Am75VbOx5JD1Sm1fhuJD8Ri/aWF8+ivuV55Q1cUJk02wwK/gJ8TLjyEAV6hbaQMqt8rWMfzLPtAbYUbLguSE5H6U/htxpNOH+NTMEZKF2c1btM2KDC2Q9CDgdp2yWjKgItoPaUSPmm31CuWDL2yFmgWWcMZm54eBi1GSnVs+n8mtTTuX07oKPnb3lUS822ftjoVRCJQThxN/b86ge58G/2Uk3PSNcz5y9dXArC2EI+t3JPjmUzICjdjt5h9sn89N0N/JJ6zS4eyutPIy4h4I8gV78OfMNRAGezMlMS47kp7tf4FOqsVlFZk9rp8wFQeyvcpbu8dIZ7z9OWqDef/SAWBTGH2VWG8PoS5ML7wo/fKEcV6L3mz2x+VrdKsVLtf6UdvG/Tb37W6vfXiH+jc1WG3A72tdHFdFhaQ= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB6816.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39850400004)(346002)(366004)(136003)(376002)(396003)(86362001)(2906002)(6506007)(478600001)(66476007)(6666004)(36756003)(186003)(16526019)(26005)(66946007)(66556008)(53546011)(5660300002)(38350700002)(38100700002)(6486002)(6512007)(8936002)(54906003)(956004)(6916009)(4326008)(33656002)(44832011)(8676002)(52116002)(2616005)(316002)(83380400001)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?N0psGr8S/FxZJ/DkFBVQU/fABub+huovF+Kc2F10Q0Ye1gytExRS21OtKTXR?= =?us-ascii?Q?bQ59TEHLFS6/QOHWnAIHkFSemfK+RS2Ldu9a1U0sdbzgpfQVmC1ytMW8k1NG?= =?us-ascii?Q?44RYin2RQtuXOvK5DXWfA9oslVpxa+80KArcwPmSUz5j5SH0NSiwkEbREMzD?= =?us-ascii?Q?zOg8gyLfyOSrLU8f8+IfuqTTQV5Hb+eoK3BytDM/UpGEQRb202aS2FogyMk5?= =?us-ascii?Q?YFIN5q596ul7yCjVK1jm+cS0YQr1eG6JAp8+fH1H4yvrdaLBuBBm2rucIK19?= =?us-ascii?Q?mHHup2jQprC0LEJafrFUeMog3plsAmAVO3a1M21ak8UK7s/fTjWLzis0ivO1?= =?us-ascii?Q?F55jQu54CgZxBYw4qjifr239KpaGJ7r/ZT/ACDRvK57kjMJ8U7VhWTsTGdwj?= =?us-ascii?Q?4Wm6o91pn5u1XDPqhh6wtStMG9LPbvQYnrmNNg7P6pqYbz3QNnYtkcj8wUk+?= =?us-ascii?Q?93bVa33HEMnmXWbK7mRrPmYgmw5g93TeZQtmJ8uJDyIlQjkACL3JgwQPMQMj?= =?us-ascii?Q?dRMpNDwZoilxLUy5G2VPa/Po9eHQa0+dZV6rjmxPOSWtKXtslWaCfAfYO+W4?= =?us-ascii?Q?E7E2DDbr/3n73ueBujPkc6LhY9K9lpWUKoOzZ8VVhFCuTAUfFlUQEn3FcUIY?= =?us-ascii?Q?4UJ1D2dVtCj8u9sjHB52pNZTs/pOfZfEcIO4lLUx5FXijw410f+ZTsismsmt?= =?us-ascii?Q?rw5b7K/VTTURg7BiM5Q9yla64uqJvF/m13hilxoqfdzH2OhVhXIKfh1CcDBa?= =?us-ascii?Q?gQ2Ednu36Jej1CM8OnZ/ckJhGoDo4IYObABYpKf3+33KaVwRK57+B9NR+j08?= =?us-ascii?Q?7ONQOmGm34xIR0CH9oIl7/j+eNCOM3bd/OZp7e8TYD4SaO2kzLt0eYxCHWTX?= =?us-ascii?Q?+YqDiSSk5YBPY1ddq/a3Pji+vwrSL4/qkq24R1EntT0IN6bK6x7q5hiQyvge?= =?us-ascii?Q?qnc3XHvcqPjYbMRrZo2j4zuCxnH6XH0g0MouBN38fdlVUS/cDxoeXZo5Ae4L?= =?us-ascii?Q?eVPr02MQdGd4/qoEoNKuqAfpxUkoPN9zPrP+b4H4KONQ7MQ2WLS75ap6Z+Bv?= =?us-ascii?Q?iEqonH9SsfvIOfGS5LHJyG2nMvM2nBfCTLDURhgwuYEA8/iyGORx/9VfXtYX?= =?us-ascii?Q?5VC0G4tubtj/XB2iORACuMK9cg4kgGsNbyf5sacvIvsC0zuFFfWS7UDDjQP3?= =?us-ascii?Q?AgXfKjCC5CJ03LKeVt9ufHNmhxl6y7+2MPFb3Slxp2SveqI0zD6jw7sPpA5a?= =?us-ascii?Q?SS+g85Ci0FKk15p2eYWWvD20yYXhxC3fWsdBOUsnwQC1P4hzIoYfKgM8BVNv?= =?us-ascii?Q?x54URYqZcxERkJ+HphmAD0If?= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6589 Original-Authentication-Results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT005.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 9018e6d4-41e6-4f5f-b42b-08d93f8e43c1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TiexPKlLHeVLqbOJuxEUK3kbhZWwGlhnMvQ5b16D9Ik5/VCfYW9d37zisjgiING223TAKTWK9xcRHmEYd7ZZBiIh/YkEdlq/Jo4O3h0idE0GuX4TNV5D1gT6hGQyaIRvs+99CIRsMrBzkJBoOVDczBrY4z1RHG8XTWNoLaANjAgts7nD46Kv5ADLGKetMxgKW0ybz5gx5jlsunmv/T4iHMgDVXQEOtSQ61vkcRK97EfrpIvRDBmXka/MLfbmG97bpcaKGO89QhYyBbeD+IjHYM1ywNFObzN+Dt0D/ocWrL0KLMen+cuvQ9y+WCOUoJ2mLhUFwhPsO5CZrEXtBDWvSN61De7kE8yw0d3xCV/WkF4dWVwp8AZtHnzIkDoMXNa0+7ErIFkMROEnn2s8gf0iCJRK136xl7iwXBeZhKl8sq1Q18dOUpFZE9YUO6Wt42lr6HXo14jqODvLt5NrFWTC42Myfe84mTayQhZIwQWch7m9GWEsbFOys7/HxWKgIUpTZ95A+xU4N97/icwaJxHzFNHtLmdwbJJJ0waajwE3tlOqD4jLe7wCMyxugC6HxY40PZxooBCooLXe7kJ1Koxhu+aBruLIp5CKUVX7w6HijtfuuyL0ZElzvpvpYlALRCbaXckC/wxq2cm3mGP0s7iEOc4ACX5q+EwiTW2xmTbpum932WmWFqYL1mzIRDAbWv+AMpChlz4I1k4FpgwUOo60Tw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(346002)(376002)(39850400004)(136003)(396003)(46966006)(36840700001)(53546011)(44832011)(82740400003)(6506007)(6512007)(107886003)(4326008)(186003)(86362001)(16526019)(6486002)(356005)(6666004)(26005)(33656002)(6862004)(81166007)(36860700001)(47076005)(2906002)(478600001)(336012)(54906003)(5660300002)(316002)(36756003)(83380400001)(70586007)(70206006)(8676002)(2616005)(956004)(82310400003)(8936002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2021 08:24:18.7601 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 24b16ae6-a2d8-43e4-c966-08d93f8e48ca X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT005.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6802 > On 1 Jul 2021, at 15:03, Julien Grall wrote: >=20 > From: Julien Grall >=20 > When Live-Updating with some load, Xenstored may hit the assert > req->in =3D=3D lu_status->in in do_lu_start(). >=20 > This is happening because the request is stashed when Live-Update > begins. This happens in a different request (see call lu_begin() > when select the new binary) from the one performing Live-Update. >=20 > To avoid the problem, stash the request in lu_start(). >=20 > Fixes: 65f19ed62aa1 ("tools/xenstore: Don't assume conn->in points to the= LU request") > Reported-by: Michael Kurth > Signed-off-by: Julien Grall Reviewed-by: luca.fancellu@arm.com >=20 > ---- >=20 > This was sadly missed because the on my testing the 2 requests were > residing at the same place in memory. >=20 > This was reproduced by creating domain while Live-Updating. Without > the patch, Xenstored will crash. > --- > tools/xenstore/xenstored_control.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/tools/xenstore/xenstored_control.c b/tools/xenstore/xenstore= d_control.c > index a1b1bd5a718d..ff9863c17fa4 100644 > --- a/tools/xenstore/xenstored_control.c > +++ b/tools/xenstore/xenstored_control.c > @@ -103,7 +103,6 @@ static const char *lu_begin(struct connection *conn) > if (!lu_status) > return "Allocation failure."; > lu_status->conn =3D conn; > - lu_status->in =3D conn->in; > talloc_set_destructor(lu_status, lu_destroy); >=20 > return NULL; > @@ -757,6 +756,7 @@ static const char *lu_start(const void *ctx, struct c= onnection *conn, > lu_status->force =3D force; > lu_status->timeout =3D to; > lu_status->started_at =3D time(NULL); > + lu_status->in =3D conn->in; >=20 > errno =3D delay_request(conn, conn->in, do_lu_start, conn, false); >=20 > --=20 > 2.17.1 >=20 >=20 From xen-devel-bounces@lists.xenproject.org Mon Jul 05 08:25:16 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Jul 2021 08:25:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149918.277274 (Exim 4.92) (envelope-from ) id 1m0Jul-0000XU-6Z; Mon, 05 Jul 2021 08:25:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149918.277274; Mon, 05 Jul 2021 08:25:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0Jul-0000XN-3H; Mon, 05 Jul 2021 08:25:15 +0000 Received: by outflank-mailman (input) for mailman id 149918; Mon, 05 Jul 2021 08:25:14 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0Juj-0000Ws-Ua for xen-devel@lists.xenproject.org; Mon, 05 Jul 2021 08:25:13 +0000 Received: from mo4-p02-ob.smtp.rzone.de (unknown [85.215.255.83]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 7dd2b95b-1338-4fa8-945d-0abb6118bcb6; Mon, 05 Jul 2021 08:25:12 +0000 (UTC) Received: from sender by smtp.strato.de (RZmta 47.28.1 AUTH) with ESMTPSA id 30791cx658P7Kjz (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Mon, 5 Jul 2021 10:25:07 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7dd2b95b-1338-4fa8-945d-0abb6118bcb6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1625473507; s=strato-dkim-0002; d=aepfle.de; h=References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Cc:Date: From:Subject:Sender; bh=ekgrVn9piLsvyOQyD78NTGf1aHgwIbptsXJ4pzNW4R4=; b=ZdfLvjSKitZyBpAWb7w3TvnmDq0NuibztZgKjE4jBOj4cwZYhO588gyMw9RgKqsksl Vj9YdC2W4739qwDEyySokt2Txiq8p+3rGuS4BXuWOhJKdYPneTwQfjICP31HXAbMOmlN ocIMH7VSOx0U34+MUqNq9tHlrZXhc0OxLe+VOxJijFNsNY9z5XPNa6+UKSRziZd5GreC CxwGtvbrzc47MYFkIWMIZ3SGg7eA+qDe5em/Kq03fHcNZKuoiwec7U4JD4Fwo06mLV85 XkoRmGhfvMv2xHz5SfkiUSj2h/W/oj/4h8uuJtCkQqPuDHOEIK56IyfCjy9lOXO9uN03 eDpg== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QLpd5ylWvMDX3y/OuD5rXVisF+Ax6FOE3sSy9BcWAcR/hQoAs9MGk67vg1baqX" X-RZG-CLASS-ID: mo00 Date: Mon, 5 Jul 2021 10:25:05 +0200 From: Olaf Hering To: Andrew Cooper Cc: , Juergen Gross , Ian Jackson , Wei Liu Subject: Re: [PATCH v20210701 11/40] tools: use sr_is_known_page_type Message-ID: <20210705102505.41712140.olaf@aepfle.de> In-Reply-To: References: <20210701095635.15648-1-olaf@aepfle.de> <20210701095635.15648-12-olaf@aepfle.de> X-Mailer: Claws Mail 2021.05.27 (GTK+ 2.24.32; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/CGcRpi7WEaCSzBdx5ZFnTRn"; protocol="application/pgp-signature"; micalg=pgp-sha256 --Sig_/CGcRpi7WEaCSzBdx5ZFnTRn Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Am Fri, 2 Jul 2021 20:27:21 +0100 schrieb Andrew Cooper : > Any reason this isn't folded into the previous patch, like your > subsequent two page type helper patches are? I think I wanted to separate this for simpler review, but I forgot to split= the followup change as well. > > + ERROR("Wrong type %#"PRIpfn" for pfn %#"PRIpfn, types[i], = mfns[i]); =20 > "Unknown type" would be more accurate. Yes, this is better. Thanks. Olaf --Sig_/CGcRpi7WEaCSzBdx5ZFnTRn Content-Type: application/pgp-signature Content-Description: Digitale Signatur von OpenPGP -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEE97o7Um30LT3B+5b/86SN7mm1DoAFAmDiweEACgkQ86SN7mm1 DoCr9w//dGrxVzPUox2VfyW4LChcH/L4cHRhNoCFq8nDUEDBKLJ8AT112EFjmDnK qlUmxjSFrXIN10CkPazYqsGY7maKe8jb2SbDI3Z47CZuyWV4mRoapaxVvVYWe40f cHXgzgp2NvX3bDpFyKb34kUovZvnCOTVH8RdZzO9Bg0BhmonTQ6tNTt1oo8SVfB/ yv9CpAc+wYKYpOHaiXADsRcCA2MqIJ/FCiLZw3QIRUJsLN71hX8WD5m9UZU9dPVx MArR6ysAMQLKujTmJ8ephBKbgowUH5Ndk9g3dOlyolpdfAXe/2DH69WcQdgu3DcO crbn/WArlVlQjfYMj0UWs7HWFfqhErtYaY6Wsyn4aBcuMSi0/rT07WlppsQ1UmHw poScS5CvOwRYrTyPUBRYmvSHuajUbSNASaqiuXUYnOTydY27cjqx964M7FT2aTSu dE49Rt9vHlnf4tMPIrAb7PKNDRaaOh0QBrTFXv4NYnQYoWWa6t9HVu5RVJ07klER qRBt7PUcP1RaMTVW0BcIInClmeIa0ZzDDT8oc2SRXvtwOnDYGEFm0KY2YkSOkdXe Gf+z6ScEpFPLG+CV6Tthxpt3T9yNYdAwh7s5faQbggyC7xY4LWlpbRRB1REv3s8s Xj6hLobeM+NGRT98JXeJkdqdyGn9jHzulsMdylmDEewbNPgAX0M= =L8Xq -----END PGP SIGNATURE----- --Sig_/CGcRpi7WEaCSzBdx5ZFnTRn-- From xen-devel-bounces@lists.xenproject.org Mon Jul 05 08:32:35 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Jul 2021 08:32:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149927.277284 (Exim 4.92) (envelope-from ) id 1m0K1m-00022R-Qq; Mon, 05 Jul 2021 08:32:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149927.277284; Mon, 05 Jul 2021 08:32:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0K1m-00022K-Ni; Mon, 05 Jul 2021 08:32:30 +0000 Received: by outflank-mailman (input) for mailman id 149927; Mon, 05 Jul 2021 08:32:29 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0K1l-00022C-4C for xen-devel@lists.xenproject.org; Mon, 05 Jul 2021 08:32:29 +0000 Received: from mo4-p02-ob.smtp.rzone.de (unknown [85.215.255.84]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id efc23c29-cedd-42a0-b1f2-035551992620; Mon, 05 Jul 2021 08:32:27 +0000 (UTC) Received: from sender by smtp.strato.de (RZmta 47.28.1 AUTH) with ESMTPSA id 30791cx658WQKn9 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Mon, 5 Jul 2021 10:32:26 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: efc23c29-cedd-42a0-b1f2-035551992620 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1625473946; s=strato-dkim-0002; d=aepfle.de; h=References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Cc:Date: From:Subject:Sender; bh=+WR0Grpii3a1Rkx/QcBQ9lUKVcEax2K181Wqa4C+VMY=; b=ttD72Er+ueuQ14qrQ3c3/2ebG3E56jVm+ILNdyULlz/996gq7G48fgg91aTScFHyL3 5w1VR1YgtPfP20FyYX9GyGnuzATuplJBoASPcSELdQk7mHJJaRiPgTzscIxXlMuPa+Zg /64BmYW+fMm9LHpDF2JXyTrZBHEF4DUuCcAI/zXISj+/VsVdfiUD1CK+FXDjpqr0hEWv EreEsLKAHyH6ZiJHkEiFshhKXhxwAk/RyRiep+oDE1W7s5YDNhCLdxIvD9VzpMUnAs4z lEyllarSEFVZM0RzgHqspIkrLBcUokA1MR5IN4KL0qWmkB+2o9H1NT4eNNYA02sBOKDt A/0Q== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QLpd5ylWvMDX3y/OuD5rXVisF+Ax6FOE3sSy9BcWAcR/hQoAs9MGk67vg1baqX" X-RZG-CLASS-ID: mo00 Date: Mon, 5 Jul 2021 10:32:24 +0200 From: Olaf Hering To: Jan Beulich Cc: Andrew Cooper , Ian Jackson , Wei Liu , Xen-devel Subject: Re: [PATCH] tools/libxenguest: Fix migration's debug option Message-ID: <20210705103224.26f3835d.olaf@aepfle.de> In-Reply-To: References: <20210702190342.31319-1-andrew.cooper3@citrix.com> <06968742-355f-ad37-0681-e51eea256414@suse.com> <20210705100228.4947ed4e.olaf@aepfle.de> X-Mailer: Claws Mail 2021.05.27 (GTK+ 2.24.32; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/_tSAvO78fL=Hc3r7J1Cc_lx"; protocol="application/pgp-signature"; micalg=pgp-sha256 --Sig_/_tSAvO78fL=Hc3r7J1Cc_lx Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Am Mon, 5 Jul 2021 10:23:00 +0200 schrieb Jan Beulich : > I see. A similar problem then exists with at least the FIFO event > channel per-vCPU control blocks? I have not done any debugging how the pages differ and what they are actual= ly used for. My guess was that it might be activity from the backends, particularly netb= ack. I found no API to query the usage of a page, so I declared the interfa= ce broken.. Olaf --Sig_/_tSAvO78fL=Hc3r7J1Cc_lx Content-Type: application/pgp-signature Content-Description: Digitale Signatur von OpenPGP -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEE97o7Um30LT3B+5b/86SN7mm1DoAFAmDiw5gACgkQ86SN7mm1 DoCpsw//cHJIb+i/s61t77mQZB5eToYHtekdEt6Kfj65jY2rKlI/akXkL0RHAHRA ZQAfFvVg7E0N+FlQK1FXxbBugrZDaC+xiKDvZU/nV1Tx1F5iBGPgAlURk0cOK8YZ J7amLS377pmHq3KcQNE2Pk+BhqAckWWO+SekgGSLiEGYMypKqgwstmqBG0Fa6DiJ gdurZgBlHs0gWawUaF8XuQs92W1O1idiqckR5+Vl9aF9vZUqvn0SgZJtqNW7JVNQ zGQkjJZ65sP57tSEelLGo98JxupoPbuSphZihQng71uPalCvZykxCPLMekfP6xKo Eui5fjUrb8AgsA90p7xrG+4h/UVGc2MkOa33X6l/drAjbq2BBvwaJsjuSVWvRKVs DkpWBoB2uynb/EQjmIR6dUDIT6UfO9RbwiOfzQhQbs214rT+R1DypQjCG2dXjaSV Ll1KeUTF/baDA9pbQGOfdxKBaSG/p/fwAFPa5SAlqCzzf9+xUm40fA/lEau+/sTr uERx1vHCQSsDs5q7TZQ+bJVrtcXVaou7PRPkvOLI6ONGrJ84nAjDFxCXKTu2nuGL MUqb2ZBhcVEE5fJt2sKxrBUo6AVLviuDUORZnbwNikJ5YpG7audCJgx/wESZIMzN /v/hFg0v8O+QHE7qY00PEjjvysZrjeiO6XL30hMeZ1D6R/sJW6Y= =0ZiK -----END PGP SIGNATURE----- --Sig_/_tSAvO78fL=Hc3r7J1Cc_lx-- From xen-devel-bounces@lists.xenproject.org Mon Jul 05 08:41:58 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Jul 2021 08:41:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149933.277296 (Exim 4.92) (envelope-from ) id 1m0KAr-0003Tp-Ob; Mon, 05 Jul 2021 08:41:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149933.277296; Mon, 05 Jul 2021 08:41:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0KAr-0003Ti-LJ; Mon, 05 Jul 2021 08:41:53 +0000 Received: by outflank-mailman (input) for mailman id 149933; Mon, 05 Jul 2021 08:41:51 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0KAp-0003Tc-OJ for xen-devel@lists.xenproject.org; Mon, 05 Jul 2021 08:41:51 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id d70bfc8e-dd6c-11eb-843f-12813bfff9fa; Mon, 05 Jul 2021 08:41:50 +0000 (UTC) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04lp2058.outbound.protection.outlook.com [104.47.12.58]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-38-Lo65KnIfNPmdJLEGrGc3dg-1; Mon, 05 Jul 2021 10:41:48 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB4190.eurprd04.prod.outlook.com (2603:10a6:803:4b::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.23; Mon, 5 Jul 2021 08:41:46 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::99d3:99cd:8adf:3eea]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::99d3:99cd:8adf:3eea%5]) with mapi id 15.20.4287.033; Mon, 5 Jul 2021 08:41:46 +0000 Received: from [10.156.60.236] (37.24.206.209) by FR3P281CA0040.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4308.16 via Frontend Transport; Mon, 5 Jul 2021 08:41:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d70bfc8e-dd6c-11eb-843f-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1625474509; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Qi0/A/ZDdzvWCMcpib3gmxbhoynEIspq/aq0JQvdtrs=; b=ifwnemfjErIEqyKuxkzTHRMahzT/ggxTpQKgb3HqMZdWE4BOVDn3FnZ9Kc9nOCMxqR+I1d r7RGGzGCyKH0Dd86Dt/+yyAGx0EaDMYXQCpD135ulz2VbMLbk9w5ODaZ3KZXbjZeBnndRh XbfRYZCg+RAwuxpqaqfF7ZwyCxwkRJI= X-MC-Unique: Lo65KnIfNPmdJLEGrGc3dg-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NWQkJElLYjG8sFAen/WyPc6hNfr9ropa+4mNxpgK5X6nUqEnqzU3JcLARCsGwHI/ULJwETfDKEuqHolopBLvlHacM1/GbQfLs9MQlZ3qnIDwbV0Qwps9SwVS5Rm8skfisMr29OmVHdlg9pb0X/9ShMzKvublN7YBLcG9Gba6wltiubB0imhsUZ+wi/gtjj0V+IDpUVntfmt2uVGzF7vCURcBZVSVShfTnVZFg9K+gSvlI2MmjlFNMYMp8medAtTlXydfWtDK8MReJQ7rBcmkL9Y1QsqRKS6OPt55fQO8yWKlehRE/TTJcUQiQOioqh9zTOUh1XiIGB5TjVtBV4ADbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Qi0/A/ZDdzvWCMcpib3gmxbhoynEIspq/aq0JQvdtrs=; b=OJtRFTJbZlrBp8hKa+NVSNYoRK1F4bBxc9btoXMDILIcylIVn59ncm2JjHgi7PqUo6sDARf/EHlxxMuHrEA3lYsIYF9vPfsZv0JP1ozJeEYpmWYvp4f77QlxDKCN1BWJW1Tg7JvsN4JMnNOI6U3V4w1T0l6vnZgchbQO8zYWmWJ8Q4pDssH4TaJgjqt6sjH4Lbme/fsyOHcFo8Ijk0pOglSUTggwi9gB+bO4YJJ/y7yjsj9V9Gh6IbSbsGdDO+hyclNKWaUMveqbv96fCsT9BS2l7MvMpnA1TS/P8Ju9NewQ1UcVLDJoTtCvf2m20lZFA1TEa64VcE7FzVp5GxJL0g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com; Subject: Re: [PATCH v5 1/4] xen: XENMEM_exchange should only be used/compiled for arch supporting PV guest To: Julien Grall Cc: Julien Grall , Andrew Cooper , George Dunlap , Ian Jackson , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20210703171152.15874-1-julien@xen.org> <20210703171152.15874-2-julien@xen.org> From: Jan Beulich Message-ID: <8c0100ab-dfd7-9c64-c89d-338db62cf20b@suse.com> Date: Mon, 5 Jul 2021 10:41:44 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 In-Reply-To: <20210703171152.15874-2-julien@xen.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [37.24.206.209] X-ClientProxiedBy: FR3P281CA0040.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::8) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8891937b-9e82-461b-3dc6-08d93f90b8e8 X-MS-TrafficTypeDiagnostic: VI1PR04MB4190: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9zsPOcYznqGYoVNrmEC3voAUDi1gyhGySeQpNo6/yctJtjbPbhxd/uNaNYnO0O8X+Kd9rjzGNDk+jlv9AdYwac5TiobrfVszeBPsn0iZcyJn+L6tQ/S9HdTtM7b6AlTTiS1hOAZ9hGR2IihR61l86kSlC/pmChXtBFw9AvijHb9/KgJ9bG+S1OANgD+oz7+6VRs5OnL7zvJBorJXskX295jONX6Fev3iDWjk4bNW2nhN5hawjoXYDfqYTnBbqmFRbuNOWBE1K02RLvS3vX/zELHcvfzNNfjOsm0hbbVjWl6hi0IiWUBrbRqxWdpeTHJAm0SHlxDzRG2x4FqmSHgnTIa6znfa++5k/oVxwax/Uut8Y+21vd0cUYoSAmYZmEF0Iw3mqJKjjch699cQQkLlxtBoUR5IaoXye0PkB3/PkKwa0WF4R2o1A72Ipjf4Wu8dsD+VFmmiYabu3/oRs6pc18dUCCfpKuKI3UEjCys3kKg6t55x8Bi4D1Bnx5bMsiIzPuOAi3laHjre1qKJ/FPJ4JmlY4DCJARo4nE1k0iLCc3fpE1bwX0WVgLwU8txgs5fSoK0oM+G8vVjdSYBtJOEBD8RgWF9k0WDhP40YHPKdGLBQVUzLCZ7Om7MCSj64jqlA8ye+traw0Sca2m9r71dzXzzSB5w9OU8D0eqnODSxYJ9SUzORnCNGB7X7t1Bz5kvfig9xFMjgNnr0is7EDF6n22CsgLp14bpbDgJn/sHc/s= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(136003)(39850400004)(376002)(396003)(366004)(346002)(316002)(16576012)(6916009)(54906003)(53546011)(66476007)(956004)(4744005)(478600001)(66556008)(6486002)(26005)(16526019)(31696002)(86362001)(2906002)(4326008)(66946007)(5660300002)(38100700002)(186003)(36756003)(31686004)(8936002)(8676002)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SEF3ZzlHV1JQcEJuZW5TVE5BOHRGbW1sbXlJd1hwbnpVZHNzSUoxWDJiSXVz?= =?utf-8?B?aFdYNUx1UUs4cHgwNHNtalRtN0RUaG96ZHJDWG9FZ0dYMUp6U0tLeVZuQllq?= =?utf-8?B?WlJaR2VLaFIvR0RyTmlxOE1HWEhMeWdhdkpMbUU0MW5BWHkxUU1CbWdPVVcy?= =?utf-8?B?OHlHZ2xFQVpFYVhCUGxFWFRpd1BqaDROOFRIUzVNZkFxZ0pCdkxHMW9lUTJG?= =?utf-8?B?TXlpdEtMYS84WG4vZWttOXg3Tm1oZjFqZ084UjAzL3lHNHd5bjJTbzliQ1VR?= =?utf-8?B?OVdyeEZwYkhEYUVoTjV0aEpxVExYS3EvVHVYWGUrWTg5K3NUMmJMUWNrTXN3?= =?utf-8?B?Ym0zOUlORzNmYm9YTXc4eEFtaWhPOGdDOFhYV3RUNWoyV3lZZE1sL25XdWwy?= =?utf-8?B?Wjc3MGFzOWRVS3FsWGJCS3MyMHR2Yk5SNHNpOXB3amR4K0t1clplUUFyVi9O?= =?utf-8?B?cm1qMENxR3lRK1k4R2hBK1hFY204aDJiajlNR3ZpSnhpcHd3bnJaWmpCcVRR?= =?utf-8?B?V3VTZ1RjZkE4dXkyenVMVHlGMWlwb01neFpjKys2Wmt5NXZWTzBVSnZmNFBv?= =?utf-8?B?ZnZNdTBSNC9KVEpHWlRNOGJBN1JrSVREdUUycjBKeG1lNzlITUZ4WUQvbDlX?= =?utf-8?B?dkl4QXA5YXFrTDFBZVU0WnVyZ1Q1bmVLTDFIK2pndFlGbFYzazFKSzYvN0F2?= =?utf-8?B?Nll4dFdOL2lwQmtvdmQvUVNKOHpRWVhMQVhDczgxb2k3NHlOZnJ0WThsRWJI?= =?utf-8?B?ZkxvUVI0ajVoMFN0T0F0K00xbVFmdzVLMUhONm5pMVU1aFJ1emljZ3BIMWwz?= =?utf-8?B?RDRZM0Q1dnFSZlRld3lXUmhmNDRCbFl1a2p6Zm4wQnFRbmRhLzNUM2NVbHo1?= =?utf-8?B?Q1VteWZ6eHlIZXExcjZEZ0FscEh6KzRjdG9tQWhqeitMTUVkdUllTHY5Tmdm?= =?utf-8?B?RGQraFBBdGgxaFhMWXhoMHdFaHFBQnVVZm4vSFY4ZHZjL1g3UFg0Y3N4elcr?= =?utf-8?B?cm1qR2dRd0x0YmttUkdsS2dzVWdKRlUveFFvcm1IdmVINHZYd1UrK0VWT1Er?= =?utf-8?B?ZURzTnlXSVVqRUwxTVVhY2NWVDdack9BYzAwcDRNUERJV1VOT0t5WFg5TWZr?= =?utf-8?B?dlZ4aStkMGJtR3FTQjZlU0tWelRIT2V3VDNNLzduNDNCanpRK2ZJdmIrRDNH?= =?utf-8?B?YXJ6VTh1N1lvRFBHRWl0cjdudlVrb1VpMnVNZHBHMVM5Kzg5L3JoWXV4NTZK?= =?utf-8?B?SEpkN2NUY0RuUHh5Z3hCOXQ4U1FobmlJWDljdGp1QXlrMmtFVE5pVkZtaVQy?= =?utf-8?B?QlZ6NURIbHRaM21HV0R4U09pV21kbjdCc250MzdnZHFGME9mYnpyVy81N3ZG?= =?utf-8?B?YkR3WldPQVJqOXhVWGFsUkJhT3RBUlZDcVVyRzlxd2x0THRpQ0FVTGM3dnIv?= =?utf-8?B?RGlwbmptRDlRcjY1ajl2Z3RvNTloeFNwT0JlOHNFUis4VXF0SFZHUDQ4eDlF?= =?utf-8?B?UENkcXJuWFNwa1RWY2Z2TVBha1A5aDNmNXhITFd0ckoxdG00SkQ4d1J6a3Zq?= =?utf-8?B?cUtkUDNvZ2NXWnRoQ25yYzVmUndtNUtSNUpJZmdUc3kxMmJveDE4d09OZ0Yw?= =?utf-8?B?N0VhcGlqTGZIZk1Rckd2aDdsR1dWbXRadStNVGZBOVAvelJuWFoxSGZKdk5h?= =?utf-8?B?OTF0Y09BV01sbVJyYnc3aXIvRHVIR3NZTzJZY2NnUnJTVzJzQUhseGtyTG45?= =?utf-8?Q?FInAa9uvOe/bivYdzGHZ0vpW4md+ZB7yCFubjiB?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8891937b-9e82-461b-3dc6-08d93f90b8e8 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2021 08:41:46.0753 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +9jBKADDzvXF2K5amDJs3baUo5bJAKgs6EIt6apRs6mWIgRAusYnazdPgGYNE0vOKzHBzASb9ZE9Fy7mrOcEQw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4190 On 03.07.2021 19:11, Julien Grall wrote: > Changes in v5: > - Removed the #ifdef CONFIG_X86 as they are not necessary anymore > - Used paging_mode_translate() rather than is_pv_domain() Is there a particular reason you use this in favor of steal_page()'s paging_mode_external()? > @@ -815,6 +812,9 @@ static long memory_exchange(XEN_GUEST_HANDLE_PARAM(xen_memory_exchange_t) arg) > if ( __copy_field_to_guest(arg, &exch, nr_exchanged) ) > rc = -EFAULT; I'm afraid that for correctness of the interface you need to keep this part even in the !PV case. Seeing the 2nd use of steal_page() I wonder if it was too much to ask you to do a similar transformation for gnttab_transfer(), even if it's not directly related to the immediate purpose of this series. If you're not going to do so, I guess I'd put it on my list (perhaps together with moving x86'es steal_page() and dropping Arm's stub). Jan From xen-devel-bounces@lists.xenproject.org Mon Jul 05 08:56:53 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Jul 2021 08:56:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149939.277306 (Exim 4.92) (envelope-from ) id 1m0KPA-0004zx-4P; Mon, 05 Jul 2021 08:56:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149939.277306; Mon, 05 Jul 2021 08:56:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0KPA-0004zq-1M; Mon, 05 Jul 2021 08:56:40 +0000 Received: by outflank-mailman (input) for mailman id 149939; Mon, 05 Jul 2021 08:56:39 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0KP9-0004zk-81 for xen-devel@lists.xenproject.org; Mon, 05 Jul 2021 08:56:39 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id e7d65991-dd6e-11eb-8440-12813bfff9fa; Mon, 05 Jul 2021 08:56:37 +0000 (UTC) Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-ve1eur03lp2051.outbound.protection.outlook.com [104.47.9.51]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-18-avi9yhP5MEWRDkxYy2pj0w-1; Mon, 05 Jul 2021 10:56:35 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR0401MB2445.eurprd04.prod.outlook.com (2603:10a6:800:55::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.22; Mon, 5 Jul 2021 08:56:34 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::99d3:99cd:8adf:3eea]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::99d3:99cd:8adf:3eea%5]) with mapi id 15.20.4287.033; Mon, 5 Jul 2021 08:56:34 +0000 Received: from [10.156.60.236] (37.24.206.209) by PR0P264CA0150.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1b::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.22 via Frontend Transport; Mon, 5 Jul 2021 08:56:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e7d65991-dd6e-11eb-8440-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1625475396; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Z0sX9UpPBwTe/WeXStrn0hiBmxMPQ2Y9eVf+kywyPpQ=; b=dDgOqpDtd8i1Kyld3vGYKlefHBXfBX1wLLa67qIC/ngYpyYiF9LzgGrotWNalnka8Pk00x A97nyPho0pJXeKr6AAwUpqFwvjzBZEoatfWpuEZZIG3HdpDAZ1gcqaFATeIOcjBk4MErwf 57CkiVGozcBoNd9NJq0b/Qoft4qyK2I= X-MC-Unique: avi9yhP5MEWRDkxYy2pj0w-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VRYHgJEusGCctAee6pxQtMWmJwy1B34921t/gHVTi7PifZfwVzX4AMaHgGB5mdBx9mv0xmNkDaXyb8g42GFrVPtHVAtFMHJ0/FQeRWrcYbPUOVk0AJCfrvwE0d8ti+nlAtQ/cqQ9GzifLnjYE7zUDMlM0VVqhSzNRxbVzd5oOMyIRwdw5tVhaehHUDhPTvvqJLC6+1UBfxj0S7YIzCszJJBqpdiLdYL70I9+qDSVhsT3z9Bo8PFKpBbmQmFL3YsvWsDFcUBHiOZXqhQZk0wc6qrm5wJXNvTNjDto91pWKEXdVRAbXF/eSkf0xRUHFHxpQ22/bKLcD8gGlYBwOobmbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Z0sX9UpPBwTe/WeXStrn0hiBmxMPQ2Y9eVf+kywyPpQ=; b=j/Pp5yGScaOqJrlauDCAB6BfMiySh0TifiiOFa25k/0WbJ1wxQeQX7QSLVeWNeeXRS61V3M7InZ2OUSV3U4S2JOhSWuwobyGswsaZk066Jltt2xh4RO/wlCrvzYNRG8ZH+HIrnMUIggv7ezjhv5cvBAMr/ykgOxTeWibxybsMFgKgikwGFogWFvsLjTW/5yQivWwQNXrnY8llkNFlZNCKrPKNRmlT4R6em85QQsFUbVy2KJefLnBfl8Vo2DANQ5dNH6vijKY9VDAPAMfzWAm4SlLHuqvp10hlp4YOLie+C6Ev087YOaAdgS1Jzsub8AhyLatrkXCnw+saZ7t92ZgoA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com; Subject: Re: [PATCH v5 2/4] xen: arm: Stop returning a bogus GFN for the shared info To: Julien Grall Cc: Julien Grall , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , George Dunlap , Ian Jackson , Stefano Stabellini , xen-devel@lists.xenproject.org References: <20210703171152.15874-1-julien@xen.org> <20210703171152.15874-3-julien@xen.org> From: Jan Beulich Message-ID: <33b32da4-2b25-1dd2-27d3-16ea73ebab48@suse.com> Date: Mon, 5 Jul 2021 10:56:31 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 In-Reply-To: <20210703171152.15874-3-julien@xen.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [37.24.206.209] X-ClientProxiedBy: PR0P264CA0150.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1b::18) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f0d766b4-fdc9-4ac4-4243-08d93f92ca62 X-MS-TrafficTypeDiagnostic: VI1PR0401MB2445: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: UV8wZYisAEptIfxF0NAMu1z482W16N8grrMoIrFgbJ3CoJL0QwwROWwTuW9xg8EXRyvD/GnWKpkPZScvOetZyh5mXwDqJYDAtv4nog2cZP4rhm2ygEzzr2HNtTLIWVnTgvtuN2enrTC1Crq6x5/OtjdJW0Wds695VjZMmZcsSUvgds435Wz3bOsxjZEmkIdc+Nn6pUYrVZVtWc3/3DXMZUdSUkgZB7IuwxBLN/i46l4FH3HWZD3LsuAceks9h1GE5KOfmFiasVh6AIxlD/jparQm1QG4J1RK99NchJH5+uPWXzozDAkpV08Jzl14Ey1deP2E7ojRT/bj8I8WshwoIvA0nWWH+vnCEzFUex/b80W12XXXMkmfO/Ptt5pMwv+bWtyQSiJl9ZEDqQOAiGvnCjxZeD8v7ciTHDE+M2T5LY4o89J1LeZoeXPiq96LERpz2fZUnuncYvo13AiBC9X+D81CVisFvlqIY27bcR9ah1SQ+mxkXMsh2qtmzEZ6a2K7SEQF+uk8Et5sTEKrpouDKn7aHkmNFGLu1t0nlufROlF50EyP/UcruUy375fb1n8RB048TW0sYl1oex3HMcj8uSQu2Q7/NCfkdUaRySodWwXii4II7LLTpBHOmSSWB37b+DbRFrVTVYcnUib+27S+z1ooVZ9p700Aq+ssSQ+58Frd/ykxCztY7c+XHol5qDJj3pnG1OqTAEOmJ1yur+hrWX2W2YvpH2IWaSfxl6zIB9M= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(396003)(366004)(346002)(136003)(39860400002)(376002)(38100700002)(956004)(31696002)(2616005)(16576012)(2906002)(316002)(186003)(4326008)(54906003)(16526019)(478600001)(66946007)(36756003)(83380400001)(66476007)(66556008)(31686004)(8936002)(26005)(8676002)(6486002)(86362001)(53546011)(5660300002)(6916009)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?em84R3JFeFlDZ3NMc3Qvc2FCK3RmMk1INmRrM3NZV21rVVZTQTROVk5PTVpV?= =?utf-8?B?azZTUVRSeHJOaVJyUjJHZXNTeTY2SXZWTEdDUW84bFNaMU1nQk5jVXM4ZFJY?= =?utf-8?B?MHJ0dSsrKzk3MDlMbzFyWS9VUFR6RXc4RWswN0MzMDB3cWFSS3QzVGhFZGZh?= =?utf-8?B?ekt4N1BVZnBveFMyYmM2MXNsYmc2eDdMR1RJdy81L0pveE9SaXpmQmxjbjc2?= =?utf-8?B?cVJKcVByWVNHbjFDa0prQWVvdHVmVExYVkRlaVRXbkRZa1puK3R5V1QrM21w?= =?utf-8?B?aVdYb3NTTFdUQ3dkZmhoWDA4dGlWdnRLLzVYdjNWU2NXY2o2UnlzRy9KeHhL?= =?utf-8?B?TUQrdnBiY1V1bGl6TjN4ZnNnMkp0ckkzaU9ua1FDSTRkRWIyM0I4YmtYNEFE?= =?utf-8?B?UnBSMWRwM01PeHpNVTFyWTJBc1B2dXVUZy9vRC8rZ0tQZ1hHWm1CWWJHREtJ?= =?utf-8?B?QXBTZGxZRUszZkNKZzF3azZKTUlUTEJIWUdLcHJrYVVHUHZSWi9ydjFkcEhp?= =?utf-8?B?U0x5cUhJSDFkWVlSMWhoN0VaYm1oTEw3bE93WTRTRkxHeCtaQU94Z3I5ZTA1?= =?utf-8?B?WkVCVEdBeXVpdDZKWWFpbTBLWkhiVm9UWUQxZ2c3WUhyT3dVWG9pci9HU3hu?= =?utf-8?B?cms4M1p5UmVWVHBLTzB1YVUrT3pLbnF4VncwYjFDZXJyYUZ1bzluVDVWMnk2?= =?utf-8?B?bldPOFovZkdtVlJCWDE2SGN0c21pTCtDZ2I3WFR4Y2ZIMmZnR25lTWVOQTRj?= =?utf-8?B?SVQ3bS9TYnk5aUwrMG1DUzBGTWJOZ09tRlFwbkgvMjN3ZEFEMnZUQmM0b0tR?= =?utf-8?B?cFFoRGNoVVg4K2xtV2x5bHlZY2FOWE5qWGlFKzMrYnpIblJ4ODNBcmlsN0pK?= =?utf-8?B?TXJOeDB1dG1jVEFjWTJ4ZkZXRVJOZSs2QWpYUExxa21NYmE4Z2FFK3QvZEMw?= =?utf-8?B?TkJJY3ppbGNYWWJoaVNzd2ZyTzB4UDByS25mWEpUc3cwK211VmNESjBhdkk1?= =?utf-8?B?UU1SUnR0MUNvN1dreDU0NEZpaU1uWWNSMmRZNUZRVmVXUk9SV3Z4em1TZ3RD?= =?utf-8?B?VU9xN2xKRXNzOGMyVEs4TWsvUEl1OEUwZDNWWnc2QWprS2E3bVlLV2RPaUI4?= =?utf-8?B?bjhsMzR2N3ZsRS9oRnBpT3d2UGRaR1lYVTFIOTAxUXlJTi9XQlRtN2NnWGRt?= =?utf-8?B?LzhLZE5ySUtRUzRVMFJqdHhOK3ljOUhyMXo0Yytyc3czbkRiZ2RPRkdpcy9M?= =?utf-8?B?YVptZll3NFNBU0oxQzg5bURRVlJCY2J6ci9pSGpmbW9Jb3BnRnVtbFpTdncr?= =?utf-8?B?eWFNT1A1UlRDMGZ3b2tBdlB6Qk1DRU9wZGdTUmdzY2JSMUdwK09JTVhucnBS?= =?utf-8?B?R1RHTENIRFI2RmsyWmN0VTg1SzcwVTdNNEtjdlNYN01uRXo1eGlkRWFaMVkw?= =?utf-8?B?cTY2cHByeGxDWmh4VTcwWk5OSnJHcms0KzNZcy9QbEMzS0FHNjlRZXVtaWVT?= =?utf-8?B?UkVKNXkweCthTzdWZlZMam1mM25GTzEra09wMjgvNkttcEFUTkFkWko3RkZo?= =?utf-8?B?VHVBbUZ0RFFHYTNZaU5XQjlubnVUVGg5VjlnZlpWcFpVd3lYRWwrSlVFT2JR?= =?utf-8?B?TDk5Q0NFb3VuekgranUybUxFTFFxaElhRWg0ZWVuSU5OVDl3N2NsSCtpejdN?= =?utf-8?B?TmFDeDhXQkFkNmsvd05uTzcvZ1pGVFk0S0twUm9SWjFjKzhPeGZyaEhSUm01?= =?utf-8?Q?pVLShz2haJ+RezAksX8OvGYTVHEE5BtKe8E+M29?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: f0d766b4-fdc9-4ac4-4243-08d93f92ca62 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2021 08:56:34.3577 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Dc4lZzJ2VVkgqQoObsxFLuDMjS3S5T5Axl3bbwCFIl8vcBNgjmjWqKaUMpl0X1JjzZj9ngGQjLQBYb1NmVReLw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2445 On 03.07.2021 19:11, Julien Grall wrote: > From: Julien Grall > > While Arm never had a M2P, the implementation of mfn_to_gfn() is pretty > bogus as we directly return the MFN passed in parameter. > > The last use of mfn_to_gfn() on Arm is in getdomaininfo(). It looks > like this is mostly used for mapping the P2M Of PV guest. Furthermore, > the structure on Arm doesn't seem to contain a lot of useful > information. Therefore it is unclear whether we want to allow the > toolstack to map it. > > As there is a high change that RISC-V will not implement an M2P, > provide a new wrapper that will by default return an invalid GFN and > move the code to find the GFN in an x86 specific helper. > > If in the future we want to map the shared info, then we should > consider to do it using the acquire hypercall. > > Note that as INVALID_GFN is unsigned long, we can't return directly > because the value would differ between 64-bit and 32-bit. Instead, > a fixed value needs to be introduced. > > While the fixed value could be shared with other field storing a > GFN, we unfortunately use a mix of type (unsigned long, uint64_t) > for exposing it externally. So to avoid any misuse, it is better to > define a fixed value for just the shared_info_gfn field. > > Signed-off-by Julien Grall > > --- > I am not comfortable with introduce a generic invalid GFN fixed > value because we don't use a common type. I also didn't get any > feedback on whether it would be acceptable to focus on one type. It's been quite a while since the prior discussion, so "I am not comfortable" may refer to something you do here but that you'd prefer not to do, or something that you elected not to do because you dislike it. Unfortunately "because we don't use a common type" is insufficient context to tell, and hence I can't very well support your view or object to it. > So the fixed value has not been changed. I think this is acceptable > because this a DOMCTL and therefore not stable. If someone still > disagree, then please provide concrete steps how to solve > the mixing of type. Mixing of which types? You have explicit translation between internal and external representation in getdomaininfo() - this looks okay to me, fwiw. > --- a/xen/arch/x86/domain.c > +++ b/xen/arch/x86/domain.c > @@ -2553,6 +2553,15 @@ void domain_pause_for_debugger(void) > #endif > } > > +gfn_t arch_shared_info_gfn(const struct domain *d) > +{ > + gfn_t gfn = mfn_to_gfn(d, _mfn(__virt_to_mfn(d->shared_info))); In order to be able to easily and immediately spot these once virt_to_mfn() finally becomes a global type-safe wrapper around __virt_to_mfn(), please retain the prior use of the not- underscore-prefixed variant. > --- a/xen/common/Kconfig > +++ b/xen/common/Kconfig > @@ -64,6 +64,9 @@ config MEM_ACCESS > Framework to configure memory access types for guests and receive > related events in userspace. > > +config HAS_M2P > + bool > + > config NEEDS_LIBELF > bool > Stale change? > --- a/xen/include/public/domctl.h > +++ b/xen/include/public/domctl.h > @@ -141,6 +141,12 @@ struct xen_domctl_getdomaininfo { > uint64_aligned_t outstanding_pages; > uint64_aligned_t shr_pages; > uint64_aligned_t paged_pages; > +#define XEN_INVALID_SHARED_INFO_FRAME (~(uint64_t)0) > + /* > + * GFN of shared_info struct. Some architectures (e.g Arm) may not > + * provide a mappable address in the field. In that case, the field > + * will be set to XEN_INVALID_SHARED_INFO_FRAME. > + */ > uint64_aligned_t shared_info_frame; /* GMFN of shared_info struct */ Since you repeat it anyway in the new comment, may I ask that you drop the old one, thus getting rid of one more instance of "GMFN"? > --- a/xen/include/xen/domain.h > +++ b/xen/include/xen/domain.h > @@ -133,4 +133,11 @@ static inline void vnuma_destroy(struct vnuma_info *vnuma) { ASSERT(!vnuma); } > > extern bool vmtrace_available; > > +#ifndef arch_shared_info_gfn > +static inline gfn_t arch_shared_info_gfn(const struct domain *d) > +{ > + return INVALID_GFN; > +} > +#endif This doesn't need to live in a header, does it? I don't think there's any remote expectation that a 2nd caller may surface. Jan From xen-devel-bounces@lists.xenproject.org Mon Jul 05 08:59:42 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Jul 2021 08:59:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149945.277317 (Exim 4.92) (envelope-from ) id 1m0KS4-0005iV-N2; Mon, 05 Jul 2021 08:59:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149945.277317; Mon, 05 Jul 2021 08:59:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0KS4-0005iO-K3; Mon, 05 Jul 2021 08:59:40 +0000 Received: by outflank-mailman (input) for mailman id 149945; Mon, 05 Jul 2021 08:59:39 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0KS3-0005iG-G9 for xen-devel@lists.xenproject.org; Mon, 05 Jul 2021 08:59:39 +0000 Received: from mo4-p02-ob.smtp.rzone.de (unknown [81.169.146.171]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 53bbcd84-dd6f-11eb-8440-12813bfff9fa; Mon, 05 Jul 2021 08:59:38 +0000 (UTC) Received: from sender by smtp.strato.de (RZmta 47.28.1 AUTH) with ESMTPSA id 30791cx658xWKxT (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Mon, 5 Jul 2021 10:59:32 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 53bbcd84-dd6f-11eb-8440-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1625475572; s=strato-dkim-0002; d=aepfle.de; h=References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Cc:Date: From:Subject:Sender; bh=bEbVxWBeCflnuHit0eKhOuE3HAcewAG2Gvvb7jVrBts=; b=R0O5u7TZDRNjMw3phGHsDcQnzgvaRtA8YNLWy5AIBGrGpwpibqk9ybcOPpmA0UGqFM 4iGs9sVcW3r/6u/o2rXHIbToyrFRM53D62tWHHQ7lxDF6qja2RJVCw1SgxUU1GciSsBZ VDNXw+DpihHmUMTPYjk4zbuBrvFh3jUGsoAUOGY5sRwkosG1lkbNzS3dLhUZd9pvnBbt Cs7uyYlUWUHhBKru1LFvlSbcZM1v5mtLaNNTEbGNpnwneXBLZM1ir5eRpJwXmWzqk+BT Ybslxe6Va5z7pVkRAcJT06iSasSJ2SERM3Rva9w1k9mY3OByaPGmq9O+FJchMDkZBN4w MYwg== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QLpd5ylWvMDX3y/OuD5rXVisF+Ax6FOE3sSy9BcWAcR/hQoAs9MGk67vg1baqX" X-RZG-CLASS-ID: mo00 Date: Mon, 5 Jul 2021 10:59:17 +0200 From: Olaf Hering To: Andrew Cooper Cc: , Ian Jackson , Wei Liu , Juergen Gross Subject: Re: [PATCH v20210701 12/40] tools: unify type checking for data pfns in migration stream Message-ID: <20210705105917.132793c9.olaf@aepfle.de> In-Reply-To: <9db50e05-233b-e279-307d-548fc23d0115@citrix.com> References: <20210701095635.15648-1-olaf@aepfle.de> <20210701095635.15648-13-olaf@aepfle.de> <9db50e05-233b-e279-307d-548fc23d0115@citrix.com> X-Mailer: Claws Mail 2021.05.27 (GTK+ 2.24.32; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/xqhvDPGS.iJwfKNB=6Q_0nZ"; protocol="application/pgp-signature"; micalg=pgp-sha256 --Sig_/xqhvDPGS.iJwfKNB=6Q_0nZ Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Am Fri, 2 Jul 2021 20:43:13 +0100 schrieb Andrew Cooper : > Anyone adding a new page type is going to have to audit/edit each of > these helpers.=C2=A0 I think it would be better to write all the true cas= es > explicitly. You mean the check if a page has data or needs to be populated should look = like sr_is_known_page_type, where each known variant is listed? Olaf --Sig_/xqhvDPGS.iJwfKNB=6Q_0nZ Content-Type: application/pgp-signature Content-Description: Digitale Signatur von OpenPGP -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEE97o7Um30LT3B+5b/86SN7mm1DoAFAmDiyeUACgkQ86SN7mm1 DoCljg//arNFhP+kCrV1rOksDQaAaAwSF+UHNujyD7RyQCLQY154FOYrDAE1pcCe NSq1KtGc6behnrxusAF1TrT2CXv52vC+1elQCjsIkx8ZifRHkZZSvV0hy/LpVEaG j9+ql3A4oMvpPTljI8eXOdkR/8r4pc491w1yQy5QtwphBZdrJpnrdji/aVBmEzGP 0YwLDx9kawNzE1FbTguMx3+0raWeCfFAaopiSj/s7PN0+UO0dsHUYf5vOT5kkxto hEtyEJKHzRkyNcO4DdnP+vkWgRBHbW1XcJLT0ByvrW6Jbanuru1RBquWqc6zP/3I wNRZrEUCX68WcIU+FY/7xxtjF7jUaIDYYALEs89oKroi65rpyYgjNr66TkBMO4uJ mC+lA/2v5H4D50Uo5w+NxUFHJscEiBNjq4BZn8nqNzi4NkkKVRI7po/zv80Z2Ahc EheNFoYJNDpultmkSI08JScqfNahuMfrpZU7ppVcqzQXlm4b+bRakA/PJidZku2x I22JSt+g+cfVVJcG2IW94zD+btqM5wEvHcoyYG58evh1oyFHRylbDXuZvHaSpeyf A7DkaqLuVL1CHydXtA9QLRHPUGltJ8D352Aj22SA2Ez3qNeK1QZl8K/Y8qd+/uva pzaJC9A1NDg5+uUhR2joYMeNLHa8WHuzzCqpm7YHhkJGB/d+v+w= =EoB+ -----END PGP SIGNATURE----- --Sig_/xqhvDPGS.iJwfKNB=6Q_0nZ-- From xen-devel-bounces@lists.xenproject.org Mon Jul 05 09:00:17 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Jul 2021 09:00:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149950.277328 (Exim 4.92) (envelope-from ) id 1m0KSf-00070s-3m; Mon, 05 Jul 2021 09:00:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149950.277328; Mon, 05 Jul 2021 09:00:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0KSf-00070l-0Z; Mon, 05 Jul 2021 09:00:17 +0000 Received: by outflank-mailman (input) for mailman id 149950; Mon, 05 Jul 2021 09:00:15 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0KSd-0006zF-RP for xen-devel@lists.xenproject.org; Mon, 05 Jul 2021 09:00:15 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 695d0bb2-dd6f-11eb-8440-12813bfff9fa; Mon, 05 Jul 2021 09:00:14 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 695d0bb2-dd6f-11eb-8440-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1625475614; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=gpO5L/u3UREsXqa+45yj/y5IgBmcrphWeBHKfwFoxyU=; b=Jru943seSsk1fSyOX+KotrQZ6mabhAopNlZIJlqVnbNZlOO5w0kdouvU JWj1WcmlsRso8+xWzOd3ZUR+A2GpAHyMJa0VmjZ9++Mio1k9riOuCUXkv 1x3v36ZrVU/DsmgINC9JAsL/hsQTYtNNXZijPziyQT4pqCr3sOxtjkCQF E=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: yAvmx3gRms4eoTLKidZquDxJgStGcrFGo3KXYKeFxjc8KgZLmpWIGNMk5ApCKEVqkS5fe6i97H 2S4gql+jqdeG0yMEB5M9+W09Xu6R0Z1vcNifRPqIcRQFFhCOOymfE2DSVsNOlzV4l8MyCSYDcy SY7Nwbr1lZIVgKSvcya3OwSlr+Mq/K/ITySj/1Pp+gGBO2adfg/n7P4qsMO9CEeOzULhc3zUar G7w2hHcqc3Cb8+fS379AHbyXwheAcyxRb15j6lKdMPUrVPXweSd5vOqWrhc+tOIm3NgqCSL9Jg 6hQ= X-SBRS: 5.1 X-MesageID: 49192802 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:032I/qASyTEq38blHemQ55DYdb4zR+YMi2TC1yhKJiC9Afbo8f xG+85rrCMc6QxhP03I9urwW5VoLUm8yXcx2/h0AV7AZniChILLFuFfBOLZqlWKcREWtNQy6U 4JSdkHNDSaNzVHZKjBjDVQX+xQouW6zA== X-IronPort-AV: E=Sophos;i="5.83,325,1616472000"; d="scan'208";a="49192802" Subject: Re: [PATCH] xen/events: reset active flag for lateeoi events later To: Juergen Gross , , CC: Boris Ostrovsky , Stefano Stabellini , Julien Grall References: <20210623130913.9405-1-jgross@suse.com> From: Ross Lagerwall Message-ID: <41f6aeaa-583f-9b00-7789-d8a6f751b49d@citrix.com> Date: Mon, 5 Jul 2021 10:00:11 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210623130913.9405-1-jgross@suse.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit On 2021-06-23 14:09, Juergen Gross wrote: > In order to avoid a race condition for user events when changing > cpu affinity reset the active flag only when EOI-ing the event. > > This is working fine as all user events are lateeoi events. Note that > lateeoi_ack_mask_dynirq() is not modified as there is no explicit call > to xen_irq_lateeoi() expected later. > > Reported-by: Julien Grall > Fixes: b6622798bc50b62 ("xen/events: avoid handling the same event on two cpus at the same time") > Tested-by: Julien Grall > Signed-off-by: Juergen Gross > --- Hi Juergen, Are you planning on backporting this fix to releases <= 5.10? I think the fix may need some minor adjustment to make it work after "xen/events: fix setting irq affinity" since both lateeoi_ack_dynirq() and lateeoi_mask_ack_dynirq() were adjusted to call ack_dynirq(). Thanks, Ross From xen-devel-bounces@lists.xenproject.org Mon Jul 05 09:15:24 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Jul 2021 09:15:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149959.277339 (Exim 4.92) (envelope-from ) id 1m0KhD-00007b-EW; Mon, 05 Jul 2021 09:15:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149959.277339; Mon, 05 Jul 2021 09:15:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0KhD-00007U-BY; Mon, 05 Jul 2021 09:15:19 +0000 Received: by outflank-mailman (input) for mailman id 149959; Mon, 05 Jul 2021 09:15:18 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0KhC-00007O-HK for xen-devel@lists.xenproject.org; Mon, 05 Jul 2021 09:15:18 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 7150d127-b075-4fa9-bb64-d6f9a3c60fbb; Mon, 05 Jul 2021 09:15:17 +0000 (UTC) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05lp2174.outbound.protection.outlook.com [104.47.17.174]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-36-9fWCEHhDONO6oCatPwrvPA-1; Mon, 05 Jul 2021 11:15:15 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB4384.eurprd04.prod.outlook.com (2603:10a6:803:6f::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.23; Mon, 5 Jul 2021 09:15:13 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::99d3:99cd:8adf:3eea]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::99d3:99cd:8adf:3eea%5]) with mapi id 15.20.4287.033; Mon, 5 Jul 2021 09:15:13 +0000 Received: from [10.156.60.236] (37.24.206.209) by AM4PR0902CA0017.eurprd09.prod.outlook.com (2603:10a6:200:9b::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.22 via Frontend Transport; Mon, 5 Jul 2021 09:15:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7150d127-b075-4fa9-bb64-d6f9a3c60fbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1625476516; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IICWLUsZFk3qAn5agg44BauByHfkS0qV/OmbhxwFnu8=; b=MRj5xTI1nwPHYgOB4SntH377D0wgyeYofoHlP6OacgFTQWCsUGMUEp9H6ClO5jBrTkD1+o G4UTEnUFu6lOjLJKlpzmcZ+7AhNpIbUAOkEGqEMpxjV+WhWsRS+mcQlLXLegdd/WDDq8rI p8o24v7BsScXtkWsjc2vyYk6cj3yvIs= X-MC-Unique: 9fWCEHhDONO6oCatPwrvPA-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DlPilxXecUCNS8BgTowHDK6fcqTQOoQMtcdjUVEgCk1Q+YIlkuu04lL0YmJcw58c7rfhDyUX4vf4cqfw276pfeeP0fwpSsH+Kgg2Y8nQb+iJb2MmPIua1Q/qUTYwfsqjO8/AGDAon43Gy5KMsZB2+/6DULh/jHmO9qjKyEj41KFtPy85VQmq9JmHbRUaolF23Nc993FkCWD5WWkGbOeC9XlJv1Wo64U7NPXnOcQqDrSXQwcQbzvdYh8Qy8kWnxHW9N4LGdhhXOifpDs8bFzf81LWui/N6ocl42fJeEUXRrohtzVTVkl/kw2T2pOGuZJ63FXP4kLP9hHaqPFIZjyOnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IICWLUsZFk3qAn5agg44BauByHfkS0qV/OmbhxwFnu8=; b=fBYCNizfKu5i8U6dSepy9a1XKazxYeFCUF0kNZ+dVhmRE50DTdfLslY6W9/QLt+q032tQdKs3TXBABZ6dd2vlZGRp8Iu/EeaSDCxTO+8tHL2PaElTB893YPOmxRLmCmGvTIwExEjkT6ENf6MSYb9E9I6AzhNzvwjNPlYm3kCPBcEUl78QSoAAE/Ie+4Itq+idSytOGOiKyD8SOXuNufr07yermGEg2uFSLwDyy8AVGgkvgIfHxxj8BzYsV6x1wz77woLIsoRsptei03Zp1ahRgCPHbvRRan6LB3hizpQhy6PaTa0U76zOC7h7h8QwYRGJTtUj8kijOdtLIxy7lk8oQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com; Subject: Re: [PATCH v5 4/4] xen/mm: Provide dummy M2P-related helpers when the M2P is not supported To: Julien Grall Cc: Julien Grall , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , George Dunlap , Ian Jackson , Stefano Stabellini , Volodymyr Babchuk , xen-devel@lists.xenproject.org References: <20210703171152.15874-1-julien@xen.org> <20210703171152.15874-5-julien@xen.org> From: Jan Beulich Message-ID: <3ee1496f-aa3d-8784-3d8c-f152958dbfbc@suse.com> Date: Mon, 5 Jul 2021 11:15:11 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 In-Reply-To: <20210703171152.15874-5-julien@xen.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [37.24.206.209] X-ClientProxiedBy: AM4PR0902CA0017.eurprd09.prod.outlook.com (2603:10a6:200:9b::27) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 44344902-adcd-4505-9230-08d93f95653f X-MS-TrafficTypeDiagnostic: VI1PR04MB4384: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7219; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pqN/slZkid4y4KQ0D41/M7zhP82UUuD5f+fIFidvTzukMMkzWnq0/uwTyWUgPE3f/7BbGBpdIvF2YJ5rUYBtdRavgDqXLgQOeRL8fPm3BpnOUWuo23oAlSjoNsj1N34IcP1skDBiHTLNcF4dCXMuFF0NyUbqj01UUTw36B3KN2Npe2ZugCZxW9LmaIP4Zbz8zGp/pM3/wv0mSCQoOwSNJsumMJDY7L4B0JDQW/PLyIjlUmUdutT+CPx63EEYVMJ2GLioi/fO1vAwQKN+Vri0mrTP1i6zBR5g7P5BGgM83fCeieZzQt86r+WZs9kKg5iwXQM2LsMA+aFBvJPoCe3wUQYmQ3PiiQB7BfFHN6jXM4ETKTets6S/rXkAidSTHJ4Mv6SGc6mMVN/ZY/6n4zClegsAH3H35iFYmnVjKKfHxrQF/YooYyLMGmTQ/BqFwZ4OwqH/ejhulti+rT3dww373r6+REJmDUqdnbBJV04olLHceWitwHvKNi3sX0toXJAxgT2hh+LRX1GCDdIf8yPUq1Bv0OC6kFH7FgcKsrqfw1Kn74dSqjKMBNBoKPWUIhV1q3iE5mk5YmsL1EQRlcabI5UlT+3mEU0i3SkJ4XDjO/ZCSqpFBHaxpkLESDu8rFX3sX49R7LemJ6Ht0bWD01Ra8e9E12EcOvxNf33Q2Be0upzwiii+QDduE6XrBDMNmFAYXugQiyOUT3zVSq1Cb5DqaMp/pTvtgI9lRMotZ+K+KE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(39860400002)(136003)(376002)(366004)(346002)(396003)(66946007)(38100700002)(478600001)(36756003)(26005)(5660300002)(2906002)(6486002)(31696002)(16526019)(186003)(66556008)(53546011)(66476007)(31686004)(7416002)(4326008)(86362001)(6916009)(8676002)(956004)(54906003)(316002)(16576012)(2616005)(4744005)(8936002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aVVmODV3b2lpN1R2aGRmUmZlVkpOeldJTTV3Tm9UU3RMd2FKVDVraDJrTlNr?= =?utf-8?B?Y014WWQzd0RvTnU0LzBVaWFYVUg5dk5oZ1NPS0tDN3VQc0lsZmhQNTJsczlp?= =?utf-8?B?Szk4bVphMVkxc0ZiL2JLT0lFOGtWeFhpcGFLSVdmTE93L2ZxcHRWNDd6TlJw?= =?utf-8?B?WTFkditjYUxIVEx5K296TjNQTzVpdjg0Yitxdmd5VTFSbXRxNkdhRmV3N3I1?= =?utf-8?B?ZWNHNTZKKzdYUEorTzkzc3NUVFNRWTA5NzZ0cVpLdDZ0TDVCWWR4bkRZTXdm?= =?utf-8?B?YTlPMlVNUHdqM0wvZnFrVkdjNGNGa29kOHBDWTZuVGVDLzM0YkozVDFuaFhs?= =?utf-8?B?OEpyOWNmbHBmZzE4Mlg0Tm0rZmNjVThudVdMZXNYMHRBTXo2S0FINkxjZ01G?= =?utf-8?B?V1kzYzQzVVZVSStqL2x1MW1qUmk2cjhxcllKYzA2aDM0dTdqaWI3VkNsTUwx?= =?utf-8?B?ZVppQWltSmNsTm1oeTZBclpqNzNBdUpDeG9LOWMyVlFzaUlWU0dCWlVia3lL?= =?utf-8?B?ZTNmNXlrMUh0enJnbkt0dWQwWGdSKzdOVk1Ccmk4SUZFSU1GQXNDVTFwQnZ5?= =?utf-8?B?TU1OQkVsMDJ1NWtNMlBYZ3o0R3RIWnY4SFhKaFNlN3dMZzBCNnU5Nkd6MExO?= =?utf-8?B?eGxJdUFyTFU3T0w4aXVkWHM4T0VJQlZ0NVJQVWxrOEdUQmhDNnFUUVY5SzBW?= =?utf-8?B?RXJPNlM3dWpJQ2p1VlhObmxzbysvVlRmOEZzSW1HTDdnam5ZaVcvWGlFUWlN?= =?utf-8?B?YklwVklHV3AxQmdySFNEOGtzMDc5WGdlTkltRmh4ZFhTSUNnMTFmWUVhTjNh?= =?utf-8?B?a1lBejdFbHA1Qzk4QmhHVVB2dG9LZTNYSTg3dHRxUk95YUJUaW80cWxFOWVi?= =?utf-8?B?SGRFNXFpMjNQY3N5TUJ5MUxhRjNHVFpUWmtYUzROWldaZzIzUHo5U0lxTzQ1?= =?utf-8?B?S0JtZlhQdUkxMmc5TjZTY3ZMejVPZExKaW9Vbmo4SlhFRWI3V0M0bVYrV1lH?= =?utf-8?B?STl2UVplZ0FWS0dOVXZuUkdhYUtHOE40Mi81OEJoSEJXWDd1ai9TcTVTd3Rj?= =?utf-8?B?WFJybEJjL0plS1Z1ZWVZUVVSQy9oeEUrV3VqME9iTndralNmYmY1MUhVc0M0?= =?utf-8?B?MFpIZ2R5V2gyYlZuSUFJUGdLSVFUek5VS1hxcnpNaVBoalh0d0FTZkNMKzll?= =?utf-8?B?YUUyQW55NGFLM2oybkpSNVFsNG9MQSt0Mkd1YlgvUEdLNkFXY2FwVFhYekRG?= =?utf-8?B?bEEwTlMrV3FVUHdwZTZLRmhIVDc4K1JFSDIvWU8vNE1ZT1YwbWpjMnF0TXd3?= =?utf-8?B?NnFaQTVzQVhOclJkUFRFRDB2MXN5bUlVVkcrVXJSSURUZ3h1NkFVTkwxQ3o2?= =?utf-8?B?R2o1aXlObHR2NSt4UzQyWXh4WU5aWkFhM0lQVXk1RWM5TVJSTERqTDhKcU1y?= =?utf-8?B?ZVhVUjFXSEI4dWRSdExsVW5zbmZsRzhlL1d0Z1RhMXVKcDltcTdYdWNpajJS?= =?utf-8?B?QWVRT09NeGh5Mitsb1ZLbENtTUNVMldQa3QvZVFnQ2c3bWozN3BMZkQ5TEZr?= =?utf-8?B?Z3RYZEd0RzdJbnV5UHdyaUpRb211M2RYWWpUNVN5RHBMZ1dUV2R2ZnZ0SXFT?= =?utf-8?B?dkp0Q1ErR2g2enVhTjdDNFNIdW00OXljclg0ZWdML3FER0pvbVd4UWY3ZWpl?= =?utf-8?B?RllPUS9LODNsZG5sK0JlOE01dnJwR0NlRk45UkQrMVhCZEpKYi9xeE4xaTdx?= =?utf-8?Q?1XcdsZkpR6zPL6AiSMeRoUJPna3A1Nvjp6FpppE?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 44344902-adcd-4505-9230-08d93f95653f X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2021 09:15:13.1997 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Fw2ce7cQJxCJRChQqD9FGvzcLj7n1MJGdJy3Zy3nVKPoVpeohRrxf0ZsewgDKsVAdSg9XJztiqdeTexlxnMOWw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4384 On 03.07.2021 19:11, Julien Grall wrote: > From: Julien Grall > > At the moment, Arm is providing a dummy implementation for the M2P > helpers used in common code. However, they are quite isolated and could > be used by other architecture in the future. So move the helpers > necessary for compilation in xen/mm.h and gate them with a new config > !HAS_M2P. The other M2P related helpers are removed. > > Take the opportunity to encode that CONFIG_MEM_SHARING requires > the M2P. It is done in the header rather than the Kconfig because > the option is not defined in the common Kconfig. > > Signed-off-by: Julien Grall With the other Kconfig hunk moved here (from the earlier patch) Reviewed-by: Jan Beulich Jan From xen-devel-bounces@lists.xenproject.org Mon Jul 05 09:16:47 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Jul 2021 09:16:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149964.277351 (Exim 4.92) (envelope-from ) id 1m0Kic-0000if-S4; Mon, 05 Jul 2021 09:16:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149964.277351; Mon, 05 Jul 2021 09:16:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0Kic-0000iY-OK; Mon, 05 Jul 2021 09:16:46 +0000 Received: by outflank-mailman (input) for mailman id 149964; Mon, 05 Jul 2021 09:16:45 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0Kib-0000iO-H4 for xen-devel@lists.xenproject.org; Mon, 05 Jul 2021 09:16:45 +0000 Received: from smtp-out1.suse.de (unknown [195.135.220.28]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id b9e2d87c-01f7-4094-831c-083a1ba081fa; Mon, 05 Jul 2021 09:16:44 +0000 (UTC) Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 05DDC22622; Mon, 5 Jul 2021 09:16:44 +0000 (UTC) Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap1.suse-dmz.suse.de (Postfix) with ESMTPS id AFAA6139A1; Mon, 5 Jul 2021 09:16:43 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap1.suse-dmz.suse.de with ESMTPSA id TuELKfvN4mARSAAAGKfGzw (envelope-from ); Mon, 05 Jul 2021 09:16:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b9e2d87c-01f7-4094-831c-083a1ba081fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1625476604; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FKzinTSRNuqJ/0cne276ylTKasgO+NhrI52GsfjHrsc=; b=dfAa3dfanPAOQ3AV3UxbeqjaZz7cHclNR5QejhMWNf8TWXWMvY8y/o47a/c/vIoh1E5TlR 4uB7/ugslreIsPPddQM6By3gTvOt2rAHN58wYvQtPjgxfU3A3xS5X/kvk8NWvvP3ZU/VMQ rm3P7M6EQAywv0bdvqAQ8ZJIPF+hf2Y= Subject: Re: [PATCH] xen/events: reset active flag for lateeoi events later To: Ross Lagerwall , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Cc: Boris Ostrovsky , Stefano Stabellini , Julien Grall References: <20210623130913.9405-1-jgross@suse.com> <41f6aeaa-583f-9b00-7789-d8a6f751b49d@citrix.com> From: Juergen Gross Message-ID: Date: Mon, 5 Jul 2021 11:16:43 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <41f6aeaa-583f-9b00-7789-d8a6f751b49d@citrix.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="x1aACQPEPpalHO3aMzmGsOJpPFY7hqvjU" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --x1aACQPEPpalHO3aMzmGsOJpPFY7hqvjU Content-Type: multipart/mixed; boundary="NyN0xPKmib9zdzVTUVSMxwGt6rt4Q0QBd"; protected-headers="v1" From: Juergen Gross To: Ross Lagerwall , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Cc: Boris Ostrovsky , Stefano Stabellini , Julien Grall Message-ID: Subject: Re: [PATCH] xen/events: reset active flag for lateeoi events later References: <20210623130913.9405-1-jgross@suse.com> <41f6aeaa-583f-9b00-7789-d8a6f751b49d@citrix.com> In-Reply-To: <41f6aeaa-583f-9b00-7789-d8a6f751b49d@citrix.com> --NyN0xPKmib9zdzVTUVSMxwGt6rt4Q0QBd Content-Type: multipart/mixed; boundary="------------0DCB1735DA5DDD533E680C3E" Content-Language: en-US This is a multi-part message in MIME format. --------------0DCB1735DA5DDD533E680C3E Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 05.07.21 11:00, Ross Lagerwall wrote: > On 2021-06-23 14:09, Juergen Gross wrote: >> In order to avoid a race condition for user events when changing >> cpu affinity reset the active flag only when EOI-ing the event. >> >> This is working fine as all user events are lateeoi events. Note that >> lateeoi_ack_mask_dynirq() is not modified as there is no explicit call= >> to xen_irq_lateeoi() expected later. >> >> Reported-by: Julien Grall >> Fixes: b6622798bc50b62 ("xen/events: avoid handling the same event on = two cpus at the same time") >> Tested-by: Julien Grall >> Signed-off-by: Juergen Gross >> --- >=20 > Hi Juergen, >=20 > Are you planning on backporting this fix to releases <=3D 5.10? It is on my todo list. :-) Juergen --------------0DCB1735DA5DDD533E680C3E Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Description: OpenPGP public key Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------0DCB1735DA5DDD533E680C3E-- --NyN0xPKmib9zdzVTUVSMxwGt6rt4Q0QBd-- --x1aACQPEPpalHO3aMzmGsOJpPFY7hqvjU Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmDizfsFAwAAAAAACgkQsN6d1ii/Ey8g AQf/S8AU56191xN6vEeRnV0l+vdq5e2nMzj8f13Y8Cfk1ZPmQIru3bza+8f4Pny87w6Z4EVnX5lc EytV0p5hPRmaNh29zzTr9ubgSzScztsnqJJCGut5MDAfvU1oJMIdGcAss1RHCWhYRh3eVKlCe4NO EYqu/+AJ/Wf0bVoo7XDCfvlwHviFWMJc8ucgde+ba8BflMwQEM+Zwuox+88iZm/8Zc+JI6ouZjkg g87FKsVkhXZFK7IEHgMMh9zwbcsW6cnnp8iSYYMg9tOmv2SXdVoN+hUNbNrb0BrAEFjr5N+I6ZPY a0/EYlY+ZrEhDbD5NW2NFFUO/rXz8pY36vN37tec2g== =u8FY -----END PGP SIGNATURE----- --x1aACQPEPpalHO3aMzmGsOJpPFY7hqvjU-- From xen-devel-bounces@lists.xenproject.org Mon Jul 05 09:19:53 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Jul 2021 09:19:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149971.277362 (Exim 4.92) (envelope-from ) id 1m0Kld-0001Ov-CJ; Mon, 05 Jul 2021 09:19:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149971.277362; Mon, 05 Jul 2021 09:19:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0Kld-0001Oo-86; Mon, 05 Jul 2021 09:19:53 +0000 Received: by outflank-mailman (input) for mailman id 149971; Mon, 05 Jul 2021 09:19:52 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0Klc-0001Oi-4N for xen-devel@lists.xenproject.org; Mon, 05 Jul 2021 09:19:52 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com (unknown [40.107.2.78]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 365991ed-1566-43ac-8cfc-ea3f69af8f99; Mon, 05 Jul 2021 09:19:49 +0000 (UTC) Received: from DB7PR03CA0106.eurprd03.prod.outlook.com (2603:10a6:10:72::47) by DB6PR0802MB2424.eurprd08.prod.outlook.com (2603:10a6:4:a0::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.23; Mon, 5 Jul 2021 09:19:47 +0000 Received: from DB5EUR03FT043.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:72:cafe::76) by DB7PR03CA0106.outlook.office365.com (2603:10a6:10:72::47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.21 via Frontend Transport; Mon, 5 Jul 2021 09:19:47 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT043.mail.protection.outlook.com (10.152.20.236) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.22 via Frontend Transport; Mon, 5 Jul 2021 09:19:47 +0000 Received: ("Tessian outbound 1763b1d84bc3:v97"); Mon, 05 Jul 2021 09:19:47 +0000 Received: from e20f7bc9831d.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id E9B9BAF0-2501-4D08-AEC0-3C921FB15A77.1; Mon, 05 Jul 2021 09:19:41 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e20f7bc9831d.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 05 Jul 2021 09:19:41 +0000 Received: from VE1PR08MB5215.eurprd08.prod.outlook.com (2603:10a6:803:10a::33) by VI1PR08MB5391.eurprd08.prod.outlook.com (2603:10a6:803:138::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.23; Mon, 5 Jul 2021 09:19:40 +0000 Received: from VE1PR08MB5215.eurprd08.prod.outlook.com ([fe80::2807:2ff9:e371:2918]) by VE1PR08MB5215.eurprd08.prod.outlook.com ([fe80::2807:2ff9:e371:2918%7]) with mapi id 15.20.4287.033; Mon, 5 Jul 2021 09:19:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 365991ed-1566-43ac-8cfc-ea3f69af8f99 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7gaTWNqi+pumqiUecLj+Puq7S7mc3t6LC8iqwbHyXaw=; b=yyK4onSM2Sfu5RVAEn+xzb2e6MuSjzeOpodWfPauhPWt7VwMaxk3RJ+FBAddZVcvraebTUUEOoAQh5/nwHYyB0LH8dvoAgH4QOjrxVappYuwgnvChFHCDCKJiPLxGsa7P09QkjPJxq4LvUMnB3amXhK6LC30ZBrdaP81dAbGFj8= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dcZxeB9LoRd21R0CL/dZXQQZTTckIrYudD5EMl16A24gDfLNWdrmh19Gvo22iOmmI+WhbsPny4Cb4d+NuctU708v3bn9BxzgTjxAeZD5oDj4bfPNaOgDH74oLZuWXTpQZSVZ0DO47VNhaPTEcW/nMJZl1YRvBz8FtPe/i8H+n2hJW6NZNcUAObnF+b2u6Vc1yZjXx/POg2MF8EtvLPvjx3Lw4bPJkiHCTXr1d+uJDbTZ2cwi0v/bRv0M4Fl1fWuDLrB/eDiLlv8YFgCzHQKhlf0dTLfDwKap+3wqtIvOLI9ziExfB3xjB0vK1+lR4ztOWhZTcLs9lhcI+eGi8eoZuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7gaTWNqi+pumqiUecLj+Puq7S7mc3t6LC8iqwbHyXaw=; b=Xxj3XSxzdKHPSWO9VVNVD3oOCdGaFO1eACui5GYYI/jW/XXAdjO5vJf36FOXyFDhdNn345hMWbbZBbBWcApS49H6/WUqrvcB+6InqknbvK7JxHGu+vQiz0ataDz9b/QkVo9mRDSG+w4/V5XRRba2G32MQEq/CMKD1A5ukJKf8RNAiwShz+hJN5fPlZJAN0043IyNn7J1NWTFRSUkGnO8JXzQebHtszJ0c0K72ViTxXZquTqYcGNSTB6n7bannNr5Gi0Emh3lVqOkN2b/9qRx7mOzEfLslEH9O1eXfjJetKKkAf/LLZQB0ZtiahqxUfjo1PUg1mS69FQ/fZkJ5BGtgw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7gaTWNqi+pumqiUecLj+Puq7S7mc3t6LC8iqwbHyXaw=; b=yyK4onSM2Sfu5RVAEn+xzb2e6MuSjzeOpodWfPauhPWt7VwMaxk3RJ+FBAddZVcvraebTUUEOoAQh5/nwHYyB0LH8dvoAgH4QOjrxVappYuwgnvChFHCDCKJiPLxGsa7P09QkjPJxq4LvUMnB3amXhK6LC30ZBrdaP81dAbGFj8= From: Penny Zheng To: Jan Beulich CC: Bertrand Marquis , Wei Chen , "xen-devel@lists.xenproject.org" , "sstabellini@kernel.org" , Julien Grall Subject: RE: [PATCH 4/9] xen/arm: static memory initialization Thread-Topic: [PATCH 4/9] xen/arm: static memory initialization Thread-Index: AQHXW0b3OiAcoe7xDE2AVcNY0dwUCqsNAWAAgB/3qYCABuqiQIAANggwgAAUo4CAABh8YA== Date: Mon, 5 Jul 2021 09:19:40 +0000 Message-ID: References: <20210607024318.3988467-1-penny.zheng@arm.com> <20210607024318.3988467-5-penny.zheng@arm.com> <7f77349f-015e-83d3-d646-af9897e31348@xen.org> <5ce26bab-9ebf-f3c5-44a3-7918227f3afd@suse.com> In-Reply-To: <5ce26bab-9ebf-f3c5-44a3-7918227f3afd@suse.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: A2A50A4422C42740B82F6382A645C5B3.0 x-checkrecipientchecked: true Authentication-Results-Original: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [203.126.0.113] x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: 8fa349e3-887c-454e-08b5-08d93f9608dc x-ms-traffictypediagnostic: VI1PR08MB5391:|DB6PR0802MB2424: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:8882;OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: +r4k56Wv3vb2mQXryeNGwAG7+TYcDm+8slTDl8Jm+6GuJUWiay7DU+DxmWv3BFf3MuIZoIY9g8XcjGIUs4UwhakJQbmYeBP9l12JCGDdXa3wwsbRyDuSnCGm1SU35opK5VONgDDUQTFs5ha79yx3othXyV1tm1nIipJlKmx9FgIPizZyfm4j2z4IXFV9cPQt6FzwmU+5zhZAjZ2tyWzPFBQTwdPrCk5Q9oAOvpY24IBD1HuDQdQzcc+zXSD3Xe6NwAgD2Ugv2azMZTMBS+Iuhje2zJ+e25pAJSi9QvK03QIKQQiiPlq21cVDJU5buThSHDG82aqI8MlQGY6wAv6S79+1KeqigBYh0/l65k0bi15cTYgCukKyl88Z4N8cJZTQb7mi3A2yp6Zic5G/KdtXtRtWKLIAjY33OdlSfHJOmvDqZUw/sb55Gxl3OMtT6hpL1j/cYFM9B9qJpH2qj5i68dsx42x0gTTQgwJ28h8vltNfmAq8eaHZ5xNw9GTRUz33MjV2KSwtCFiMZZIKHUYTRqI/7GKczI4x4uDzDM7JiG3CMS5CiyQfpAQgLks1XYsVta0hbGlLOX1ho/XZKeburQ81ip3ib8KcDd4S6PwJbPycCXR5tQPUkraRIiJvpOs56dg6n5X/heVnB7evUpDgiA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR08MB5215.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39850400004)(366004)(396003)(136003)(376002)(346002)(8676002)(4326008)(38100700002)(53546011)(66446008)(316002)(8936002)(6916009)(52536014)(55016002)(86362001)(5660300002)(6506007)(66946007)(66476007)(478600001)(9686003)(33656002)(122000001)(71200400001)(83380400001)(76116006)(54906003)(7696005)(186003)(66556008)(64756008)(2906002)(26005);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?RHpOcXRHZ0pJcnUzVWlLTE1ZR1NHRi9tYjdXSno4MXFwSGcwRmE2Y0hNNmdK?= =?utf-8?B?WWlkbEllcStxN1ZPaXNYT1FqL1FlVG5VbW1yUkNmcDdWaUZlVURaWjR5ZUFV?= =?utf-8?B?NUJjOWcyTDFocVp0Z1g1YUJUT2tYcHRqZEpjL2MvMmJNKzJkTXdMMWcwVk5T?= =?utf-8?B?aXE4Wld6M0Y5QjRlZzhCQlU1NDhQRmFsMEZsUCtLNXBnd1o0VzdqMlBXZUda?= =?utf-8?B?Wlc1K2oyQ1ZUMVgwQkp0Q1Z3c1VxNWRoRlcyMFU5TVNCNi9IV2FhdVpiT05G?= =?utf-8?B?UlJoQWwxWEErNEhITDlVS1ovem15R1h6SHFzTzlsMGR2aGkzWlN1YWQwM3FY?= =?utf-8?B?YTNNb05IODh1OXk1YmhlcnlBaVViQmlCWXRkNlgvcGlUQ1p4QnVyWC9tdi9h?= =?utf-8?B?cDgzTXROaXM3ZmNMYTRFSlpwSWVwenhaUkdBNGJoVFJxMlZOamdzK0NQdGJD?= =?utf-8?B?dk1UVXNEZi9DQ2U5L1NGNXdidUFpWU1OdWhjb0VEOGl3YU9LYmFML2lRckVF?= =?utf-8?B?QUxjTEV4OC9aRXBQd2s5YzRQY09OSEVmMWJGOHBUUDNnckp4VUdzRDJVUGZq?= =?utf-8?B?cmV3T1prb0laUzZpcnFOcHpvZm0zaGRZaUM3TUxDdDFNOXBoeGNYVmVHODIv?= =?utf-8?B?bXNoQ2VLVWhxbVRrWnVobm0zcHF4dE8ydGkyVU9acDF2Q1dSVUhrd1pjSVht?= =?utf-8?B?c29qNXl3OGVoK0h2VW9PanZIaWREN2didEphT3hkZ1lzSHgyekdOZ3RNK25h?= =?utf-8?B?RTg1WE11ZEVaSy9xUkQ1emlCWTdqa0ptcmFHaGl4Z1pvSllGTG5JRjR0c1VM?= =?utf-8?B?czBtR1dHdjNVTjlvMHE2T3orcDBaYkcvc0REU2E4ZnBSQkh1OTUzSElZbnBl?= =?utf-8?B?MHByYkxiTC9VQVlSbnRZTTRKakc4TW5PNU95NDdkN2gzeEFCa0hmUE1EeEFY?= =?utf-8?B?eG1FU1p6RVZRUlVKWHl1MkpzbWF4SnFoMlgxMXpHZkVhSXc3WlpiRW1OVFUy?= =?utf-8?B?clVhZi85dW55ZGEvMDhjVjVLVHJ6bXJpM2xqZStQS1JZV1dPZmRWaUEwemoy?= =?utf-8?B?RTcydE9oR1pFTHdEZElNVm8rbE1xbWU4R1VFdHVvM0NSL0FXYTBsS01YcUxP?= =?utf-8?B?Q25mMXF5anBZRmdaZjRKNUtYQmFHVXVkcFIxcHZDV3p6bVJjTmR5cnc2OHlX?= =?utf-8?B?aEI3MUdITkt2K2JNN2pRU0ZPM01ocFJ0bG1BRzdBVE5UdFpYSnhUM3ZoTEg0?= =?utf-8?B?cjRzMkhBeDNacEpJOTIwMUZzSlZSaW5mandhY3NPTFk2SGRyT0tYT3p5K1Nw?= =?utf-8?B?SlVldm9EVHJONnNBaCtWNy9GSmVNRnpydldqZVRxVmh1STFmNzVKOEJ5Um9K?= =?utf-8?B?SUxuQVE3NjFqcGZ4aXBkaXBNTDVvY3dDNnJZNkNtOWl0bGFEYmxmRFlrTktE?= =?utf-8?B?R291T1lZTHlLcHhib2tDdFBabHFoVGx3dG1mY1JoWnJwbkFoRkkyS04yTk9N?= =?utf-8?B?bVF3SXY5bnlPMkVlUkRSTVluYWtNVzBZblNFck1FOEswTml5QThNVVZOZWZk?= =?utf-8?B?UVZSUEhXR3p5b0wxOCtocm9lQjNGZjZMQkJKUzdaMmllaVUzbHFhaFlXL0Jq?= =?utf-8?B?OVlUTnd4eldFR3UrUWMyUHlxNG11eStWeXF6dnltZmtQTml4emdRcmx5U2Fh?= =?utf-8?B?ZHYreHpIMEoxaVBlSGpwRExPVUN6RU4rUGhzV0J4RFU0VVNRMHlGeUtMQXZj?= =?utf-8?Q?sEigkywNAKPra2689x172A5RvB40Y6jE94bdLKu?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB5391 Original-Authentication-Results: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT043.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: d5d60963-af9b-414d-a05d-08d93f960472 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JOIHbRUS3I8JI1qnfYrnfZgu9mcPnxtY1os12YZklCFHDAyTVrtTBM3NMpUFhsmsVQjRgKLb7BcdVM8YhldhsM28fVQJnyIvs0oUE7PjkrOXqZPPrLc95CioZ+XIEG02ZcXGWNfv0TDo2Dm/wyevMvf/yrXD1nKPRyv3aaqNHYadH0RMHTYUTt8Lx1ZjZ8KFE5vPEjYZY+4+MNlnwgCyu1pl79ibzICkj/GopLEG8cui8yNBRA/3lpT11YjB+r/vfeXX+1QNzzUeoAO/hw7E400DvRWJZzVOSCgQeJb7uO/dDsw8NIjoK/7n7s8Se5m13kHgJEKrV8en9DKwMCaWZVHaO3iGkptyOGtdQNIz/UOsXBK7ytlZ9aehS3ma0uVZRwhqOy+AannH5pC78XI8m/alrnMLE569dxKYklJH3459HbsOugJx4AtbCsh/HdBd/kq+U7DvlQKtUB/GXeB+nIxvazNV5nZ3lJR/KdVm8pzFmtTuFmvyvuwGFqPO+bJbFBtyYpB6W6WigkhjZMvfGOuTLH/7bbFNv7uabKb+Cv69G7KtXJsta3J7/V/NVYUdw7XXgBoD1zQOsK4J0oIbg/1buRthDraiBR709Grqs6iJeXpXfcCYetFWSeAUaECar4+CKTAb0R2btjcJE1ViFLzNxLLoS2Z/lba95dfTOI5EHPgRHuDNaRta569se8KsMefysr8bOI+E2ieLs49JUw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(376002)(136003)(396003)(39850400004)(346002)(46966006)(36840700001)(26005)(356005)(55016002)(2906002)(9686003)(81166007)(52536014)(186003)(47076005)(53546011)(6506007)(8676002)(82310400003)(82740400003)(70586007)(54906003)(8936002)(4326008)(7696005)(86362001)(478600001)(83380400001)(70206006)(316002)(33656002)(6862004)(336012)(5660300002)(36860700001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2021 09:19:47.5843 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8fa349e3-887c-454e-08b5-08d93f9608dc X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT043.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0802MB2424 SGkgSmFuDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPg0KPiBTZW50OiBNb25kYXksIEp1bHkgNSwgMjAyMSAzOjUx IFBNDQo+IFRvOiBQZW5ueSBaaGVuZyA8UGVubnkuWmhlbmdAYXJtLmNvbT4NCj4gQ2M6IEJlcnRy YW5kIE1hcnF1aXMgPEJlcnRyYW5kLk1hcnF1aXNAYXJtLmNvbT47IFdlaSBDaGVuDQo+IDxXZWku Q2hlbkBhcm0uY29tPjsgeGVuLWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnOw0KPiBzc3RhYmVs bGluaUBrZXJuZWwub3JnOyBKdWxpZW4gR3JhbGwgPGp1bGllbkB4ZW4ub3JnPg0KPiBTdWJqZWN0 OiBSZTogW1BBVENIIDQvOV0geGVuL2FybTogc3RhdGljIG1lbW9yeSBpbml0aWFsaXphdGlvbg0K PiANCj4gT24gMDUuMDcuMjAyMSAwOToxNCwgUGVubnkgWmhlbmcgd3JvdGU6DQo+ID4+IEZyb206 IFBlbm55IFpoZW5nDQo+ID4+IFNlbnQ6IE1vbmRheSwgSnVseSA1LCAyMDIxIDE6MjIgUE0NCj4g Pj4NCj4gPj4+IEZyb206IEp1bGllbiBHcmFsbCA8anVsaWVuQHhlbi5vcmc+DQo+ID4+PiBTZW50 OiBUaHVyc2RheSwgSnVseSAxLCAyMDIxIDE6NDYgQU0NCj4gPj4+DQo+ID4+PiBPbiAxMC8wNi8y MDIxIDEwOjM1LCBKYW4gQmV1bGljaCB3cm90ZToNCj4gPj4+PiBPbiAwNy4wNi4yMDIxIDA0OjQz LCBQZW5ueSBaaGVuZyB3cm90ZToNCj4gPj4+Pj4gQEAgLTE1MTIsNiArMTUzMCwzOCBAQCBzdGF0 aWMgdm9pZCBmcmVlX2hlYXBfcGFnZXMoDQo+ID4+Pj4+ICAgICAgIHNwaW5fdW5sb2NrKCZoZWFw X2xvY2spOw0KPiA+Pj4+PiAgIH0NCj4gPj4+Pj4NCj4gPj4+Pj4gKyNpZmRlZiBDT05GSUdfU1RB VElDX0FMTE9DQVRJT04NCj4gPj4+Pj4gKy8qIEVxdWl2YWxlbnQgb2YgZnJlZV9oZWFwX3BhZ2Vz IHRvIGZyZWUgbnJfbWZucyBwYWdlcyBvZiBzdGF0aWMNCj4gPj4+Pj4gK21lbW9yeS4gKi8gdm9p ZCBfX2luaXQgZnJlZV9zdGF0aWNtZW1fcGFnZXMoc3RydWN0IHBhZ2VfaW5mbyAqcGcsDQo+ID4+ PiB1bnNpZ25lZCBsb25nIG5yX21mbnMsDQo+ID4+Pj4+ICsgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICBib29sIG5lZWRfc2NydWIpIHsNCj4gPj4+Pj4gKyAgICBtZm5fdCBtZm4gPSBw YWdlX3RvX21mbihwZyk7DQo+ID4+Pj4+ICsgICAgdW5zaWduZWQgbG9uZyBpOw0KPiA+Pj4+PiAr DQo+ID4+Pj4+ICsgICAgZm9yICggaSA9IDA7IGkgPCBucl9tZm5zOyBpKysgKQ0KPiA+Pj4+PiAr ICAgIHsNCj4gPj4+Pj4gKyAgICAgICAgc3dpdGNoICggcGdbaV0uY291bnRfaW5mbyAmIFBHQ19z dGF0ZSApDQo+ID4+Pj4+ICsgICAgICAgIHsNCj4gPj4+Pj4gKyAgICAgICAgY2FzZSBQR0Nfc3Rh dGVfaW51c2U6DQo+ID4+Pj4+ICsgICAgICAgICAgICBCVUdfT04ocGdbaV0uY291bnRfaW5mbyAm IFBHQ19icm9rZW4pOw0KPiA+Pj4+PiArICAgICAgICAgICAgLyogTWFyayBpdCBmcmVlIGFuZCBy ZXNlcnZlZC4gKi8NCj4gPj4+Pj4gKyAgICAgICAgICAgIHBnW2ldLmNvdW50X2luZm8gPSBQR0Nf c3RhdGVfZnJlZSB8IFBHQ19yZXNlcnZlZDsNCj4gPj4+Pj4gKyAgICAgICAgICAgIGJyZWFrOw0K PiA+Pj4+PiArDQo+ID4+Pj4+ICsgICAgICAgIGRlZmF1bHQ6DQo+ID4+Pj4+ICsgICAgICAgICAg ICBwcmludGsoWEVOTE9HX0VSUg0KPiA+Pj4+PiArICAgICAgICAgICAgICAgICAgICJQYWdlIHN0 YXRlIHNoYWxsIGJlIG9ubHkgaW4gUEdDX3N0YXRlX2ludXNlLiAiDQo+ID4+Pj4NCj4gPj4+PiBX aHk/IEEgcGFnZSAoc3RhdGljIG9yIG5vdCkgY2FuIGJlY29tZSBicm9rZW4gd2hpbGUgaW4gdXNl LiBJT1cgSQ0KPiA+Pj4+IGRvbid0IHRoaW5rIHlvdSBjYW4gYXZvaWQgaGFuZGxpbmcgUEdDX3N0 YXRlX29mZmxpbmluZyBoZXJlLiBBdA0KPiA+Pj4+IHdoaWNoIHBvaW50IHRoaXMgY29kZSB3aWxs IG1hdGNoIGZyZWVfaGVhcF9wYWdlcygpJ2VzLCBhbmQgaGVuY2UNCj4gPj4+PiBsaWtlbHkgd2ls bCB3YW50IGZvbGRpbmcgYXMgd2VsbC4NCj4gPj4+Pg0KPiA+Pg0KPiA+PiBZZWFoLCBJIHdhcyBm b2xsb3dpbmcgdGhlIGxvZ2ljIGluIGZyZWVfaGVhcF9wYWdlcy4NCj4gPj4gSG1tbSwgSSBjb3Vs ZCBub3QgdGhpbmsgb2YgYW55IHNjZW5hcmlvIHRoYXQgd2lsbCBsZWFkIHRvDQo+ID4+IFBHQ19z dGF0ZV9vZmZsaW5pbmcsIHRoYXQncyB3aHkgSSB3YXMgbm90IGluY2x1ZGluZyBpdCBhdCB0aGUg Zmlyc3QgcGxhY2UuDQo+ID4+IEZvciBicm9rZW4gaXNzdWUsIHRiaCwgSSBqdXN0IGNvcHkgdGhl IGJ1Z19vbiBmcm9tIGZyZWVfaGVhcF9wYWdlcywNCj4gPj4gYWZ0ZXIgcXVpdGUgYSB0aW1lIHRo aW5raW5nLCBJIGFsc28gY291bGQgbm90IGZpbmQgYW55IHNjZW5hcmlvIHdoZW4NCj4gPj4gYSBw YWdlKHN0YXRpYyBvcg0KPiA+PiBub3QpIGNhbiBiZWNvbWUgYnJva2VuIHdoaWxlIGluIHVzZS4g Oy8NCj4gDQo+IEknbSwgYWZyYWlkIEkgZG9uJ3QgdW5kZXJzdGFuZC4gVXNpbmcgcGFnZV90b19t Zm4oKSwgZXhwZW5zaXZlIG9yIG5vdCwgaW4NCj4gQVNTRVJUKCkgaXMgcXVpdGUgZmluZS4gVGhl IChleHBlbnNpdmUpIGV4cHJlc3Npb24gd29uJ3QgYmUgZXZhbHVhdGVkIGluDQo+IHJlbGVhc2Ug YnVpbGRzLiBUaGlzIGlzIHNwZWNpZmljYWxseSBkaWZmZXJlbnQgZnJvbSBCVUdfT04oKS4NCj4g DQoNClRoYW5rcyBmb3IgdGhlIGV4cGxhbmF0aW9uLiDwn5iJDQpJJ2xsIHVzZSB0aGUgQVNTRVJU KCkgdG8gZG8gdGhlIGNoZWNrLg0KDQo+IEphbg0KDQpDaGVlcnMNCg0KUGVubnkgWmhlbmcNCg== From xen-devel-bounces@lists.xenproject.org Mon Jul 05 09:20:06 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Jul 2021 09:20:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149973.277372 (Exim 4.92) (envelope-from ) id 1m0Klq-0002TR-OP; Mon, 05 Jul 2021 09:20:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149973.277372; Mon, 05 Jul 2021 09:20:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0Klq-0002TK-LB; Mon, 05 Jul 2021 09:20:06 +0000 Received: by outflank-mailman (input) for mailman id 149973; Mon, 05 Jul 2021 09:20:05 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0Klp-0002KC-Db for xen-devel@lists.xenproject.org; Mon, 05 Jul 2021 09:20:05 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 2e4ad8a8-dd72-11eb-8440-12813bfff9fa; Mon, 05 Jul 2021 09:20:04 +0000 (UTC) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05lp2171.outbound.protection.outlook.com [104.47.17.171]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-1-oOeDK2uuNx6hhAsZyM1agA-1; Mon, 05 Jul 2021 11:20:02 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VE1PR04MB7375.eurprd04.prod.outlook.com (2603:10a6:800:1a8::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4242.21; Mon, 5 Jul 2021 09:20:01 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::99d3:99cd:8adf:3eea]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::99d3:99cd:8adf:3eea%5]) with mapi id 15.20.4287.033; Mon, 5 Jul 2021 09:20:01 +0000 Received: from [10.156.60.236] (37.24.206.209) by PR3P251CA0011.EURP251.PROD.OUTLOOK.COM (2603:10a6:102:b5::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.22 via Frontend Transport; Mon, 5 Jul 2021 09:20:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2e4ad8a8-dd72-11eb-8440-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1625476803; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aE2e9I9ykhO9ORR0cizNPluzBg1KOXSa8syIJgFqcac=; b=EKlIfNTAc9toIEqHIsXsblxnvX9+vWxYIG4hfpgPc+P6beK0ub7LKQG9xAVA1NjXe5fQN7 SqgTiILGEwq8vb66AJ36SsLptoZxK5Y4UhKg+D21Brb4wiI3+DzRXAi9jm/IIThObPsF2k dwejevughPk0Xsb9g90enRiwZiauQTY= X-MC-Unique: oOeDK2uuNx6hhAsZyM1agA-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hHEAlIJhydj66wlvkPhJ1VmTGJNRlrfSuA1UGIWXMKAS+migzvWDP+EoB7BVKS+x5xu5ZfM8KGQKkbTroSTVfJqq8xoyuYrR+v/mVTxUzZNDAQUu0H10p+mSL8aFgtKfZWI+v3CTLNuFfuEND6ggjYlwV9OeWUcAzeyMeE8uasjao7GvIQSgRpIhnz4FdrlVmA4431O38rKrIsAW37pSSELeBO309DaqEb41/vOI82Dk7OCzUV/JZeWjghGt7+9B5g8SWA2+KgRM+QbEZ25RV9sa6qDqkex8fmOZDZkkyderxW/l0S+Q2kgy+deyBxbYzpF28niSqKipGVpxKWRFRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aE2e9I9ykhO9ORR0cizNPluzBg1KOXSa8syIJgFqcac=; b=oVUJdXtreh1Cc/r4TrL2GhntsaNyudtmKeT97Ic1M0iyj4hDea++xvKiz6fvQb1qtqvd3iD/Pftt9NJNmdVJBrMrgnGxhqTjsP1EENeq8ZBfEiShtBer6/QhjyS5GWuQ9wjhYsSjBCJ0hqraFgZzI4oghGAX+tHH8dLJJocF9OGgZamB19n7UjoOJtgA6lgBxqG8CImafgnPj2V5hhWEjnNjtUzAC/K4YJ2QPfgMofBgFlc5BvEOD4xo5ADl85YFnZugdhnduGRPbq3sUB9xJKr6L/I2vYjGIxmncQSuE6xb4KzRFL4mb5gW25vwBlviPQLxEbbTWPMRrZS2PNVLXw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com; Subject: Re: [PATCH] tools/libxenguest: Fix migration's debug option To: Olaf Hering Cc: Andrew Cooper , Ian Jackson , Wei Liu , Xen-devel References: <20210702190342.31319-1-andrew.cooper3@citrix.com> <06968742-355f-ad37-0681-e51eea256414@suse.com> <20210705100228.4947ed4e.olaf@aepfle.de> <20210705103224.26f3835d.olaf@aepfle.de> From: Jan Beulich Message-ID: <1e2a3967-06e5-75ec-3aa5-1f39b6700e63@suse.com> Date: Mon, 5 Jul 2021 11:19:59 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 In-Reply-To: <20210705103224.26f3835d.olaf@aepfle.de> Content-Type: text/plain; charset=UTF-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [37.24.206.209] X-ClientProxiedBy: PR3P251CA0011.EURP251.PROD.OUTLOOK.COM (2603:10a6:102:b5::21) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 279c6ece-704d-48c3-2d95-08d93f9610e9 X-MS-TrafficTypeDiagnostic: VE1PR04MB7375: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 626IT4OZjeSPolmjiXWPBn+TZIb+6gYUbelKU0iuE2dYiodXOm5b8ci0O7X1cVfBFerhT2WYq1VBJ/dABv5UPTEGwLjW90QZThyWsLJhoWKnIHR4Mt3x370ThwPkzk6mgCYm8iRWSoQAL3qY8ENxuh0W9RjbF/c5a8/ZRCA1Ptd1HV3YIK9GmE1UfTAV3NsHI7vHoE1TtlClLTAXU/o6zrA7qP23aehzrV1+vSohB8/8p56Pblm+FVkXpgxycd1MTSX2moZ3SW53NnWaqlRmgpCeWa7MhGDu5khGbmac9wKtL188NYKA9992IGy8p9cLqq02v9Karbw1ZmHnFMu9BW1tsi7VzvnZVQOZTWgNnNMZLnPzZ+68suBBhAfRR+1c4Vp8YbxaKhMkXvgOjhPfRKI6O6PkM3dJY1kgUqcmGzssmVQcwOsbj6la3x8qe9hilsH/nLusyYLeoiLqtHKUAuT3qNG2Xs9rTMtFvV1SPDY6ZTCLK2PAw8uJz+rkl7dFqZh4fYJtN7hpnNiMy5lbQF8Ig15wb1SFcyXA98YbYUmRuPE0gUYXjjYorXMIbj3fcZSW2BI5XEc2nA4W5sFv1vDYOTNLz1bQE92wbKB/v4x3qxxg6QzKK+Z8nSsRbnzjJ6bdzhZK+5W9bkSemGe9fUjnFfqFQGrU6dviVQAH1Gi26HzUNqCIj/nNgSU6pYDTCw9lxKlyTV6avsbsO8+ibqtGiVkYp460Pt3rPVhrTG8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(39860400002)(136003)(366004)(396003)(346002)(376002)(2906002)(16526019)(83380400001)(26005)(53546011)(54906003)(36756003)(38100700002)(478600001)(8676002)(31696002)(186003)(16576012)(86362001)(8936002)(31686004)(66946007)(316002)(956004)(2616005)(66476007)(6916009)(4326008)(6486002)(4744005)(66556008)(5660300002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WkgxamxKcG52ZVVUU1hPZWtUelI1cGFpOUhrRzJncVJkYlB0N2RXZmd0eUtK?= =?utf-8?B?TVRpMW11OFBacjFGUkdPSW1FcjF1c2RQbElkaVl1ekg1Z0hPcmQ4TWZxVWZi?= =?utf-8?B?QSs4aTN2NXpNV1dUUjhnMXhuNkRZRWw3Ynk0NXRpMXV3dTk1djFvL3cyeWJD?= =?utf-8?B?M3pDMi8xTzVoNGd1RjRXVnIvZ1RXOG4zT1pxL0FEalp5Q0VXeitIS0NiK2d5?= =?utf-8?B?dU9lYmVCMlBGekZ6cU5KeUVDMjdiTlQ3Z2pYSGhqbW5SMFlVdnFEZldmeWwx?= =?utf-8?B?MmZPTThpRmJFRVRHUEtMMzd4M0ZLL1BmbFNaT0s0Vmx2dktab1ZORWNPRFNJ?= =?utf-8?B?VDMvK3VlZFNuQllwaHE0STF2ZnI0dkpwZDNsYjdRNWw5byt6d0d3QUNiYkEv?= =?utf-8?B?cEpvdFZUdjRiMkRYajk5bjMwaENpSzM3SFU4NzNMZ2N3dlRNYnBiSzJ5VlFH?= =?utf-8?B?YWdOMDMvRm5CR3lPVGljQWlnTkRjcDZ2OFNRWlNvdXBnRGRqMmdiaXdWS0Fq?= =?utf-8?B?Zm9vZXlodXFVakdueWtMSmZrRGVuS2NnQkZzTFFmay9GQXIvMDBIb0dXNm9X?= =?utf-8?B?akp1VnJjalZscUVqTTNCdXZNREZYS3R6T1VFbnhRTVdTZE9jYUN0Uzl2b1Bu?= =?utf-8?B?VTh4MzJvWDJWc2dudlo2WHlOZXlpbllkaUo4VjNYZkk0b1J3U3Q0LzJnVnRO?= =?utf-8?B?T1ZEaWRRbGNLcGRmeVBDRmI1VzFvY01PN1NlSXFyVU0zTUtsYzBJNW53MzRo?= =?utf-8?B?THBJYTRaZzlQVDl4WElJd3gvbTl6VTR3Y3I0ZENya2pYckhXYzBxczRBQWcr?= =?utf-8?B?NE5YQnlEUWVKQndpYzE2OE5PbnppYTVuei9WRjV2Wll1NytwczhtcHNKK29l?= =?utf-8?B?aEZtbm5YZzloak5YRlhTOXArOG9DaTFRcUR1RG91dHEyaWRwRzdIQnpYdVIz?= =?utf-8?B?elpuS1drRTdWOHJBYXcyRHRuS3pIVExEcEdFUW43dG5UdlcvbXBhNzlXNTg1?= =?utf-8?B?akVZdW1SOW1FLytvMTF5aU5HMW1kNTU0L3JNRG9RZEV2SFpRaGdEYzUzOEwx?= =?utf-8?B?MG1IY25SRERQbk8vVzc1dXJQYWE5ZXBSelU3NHpabHNoem5NNk1OZVo3TlFZ?= =?utf-8?B?M1pSUVhaQWRHM0hDVEp3bDlZZ0pGQXpvRXkwaTRsNU9UeWVUcWVtSVQ3ZFlM?= =?utf-8?B?Z3Nvbng5ZmRkSTM1bXpJZXZOU0hYWjhOclZYOGZqbDFWTGprQ1l0NStmM2py?= =?utf-8?B?b0hGUVN2NlJhTnhXUG5ndzdwYzdXMjdyODRvc0x2SXBKOHVDZC9QOHpvZTda?= =?utf-8?B?ZEJVem9VTFFXTU45S1pza2lFYXpBZzFCbnBHUUhKVFY3Y0x5U0sxa2dhUzUx?= =?utf-8?B?OXVKOTJiUlBsNHBTUFhTMXVJdUJHcHBTRHpZUUU0b3RGczFJTit4Zmt4ZjJH?= =?utf-8?B?OXYxM1R2eHRIZzZyWWwzUGVqZUcvSmkzdUpramZ3VjdPT2JnM1Y0TnJRcXE1?= =?utf-8?B?MENsVVdpSjc2UThJdFRVaktyMDBlTEFFaFdmR3VZWnhtNEI3bTdrN21adEFt?= =?utf-8?B?NzVCdmRWS2dJUjNxNmxPR3lwRC9GcTViUlc3QnI2dUFmQ0R6dm9oeXY2eDZ2?= =?utf-8?B?bXlPU2hSZkNXQXBMSTJXbldLbzIyenh6SnBrVzVHMkJmUnpiMHloa29rWnNX?= =?utf-8?B?WW1KQ3E0NnhBcnVDRitZLzBNanFlWUtWcDJVR3JqK2RnaXU2NFNROEdsd2hV?= =?utf-8?Q?FGTEE3RLpU502OZOTGk/LFCJdH0ZsKovHEGZDpq?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 279c6ece-704d-48c3-2d95-08d93f9610e9 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2021 09:20:01.1916 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: sq4X54mWjhb9xM//qx2JteHUMR0HzTCKUKonmtSEDue4bMh8SEqRC2UbKwUVqEDMoNSgfyyEI4Itj6g7gz1srA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB7375 On 05.07.2021 10:32, Olaf Hering wrote: > Am Mon, 5 Jul 2021 10:23:00 +0200 > schrieb Jan Beulich : > >> I see. A similar problem then exists with at least the FIFO event >> channel per-vCPU control blocks? > > I have not done any debugging how the pages differ and what they are actually used for. > > My guess was that it might be activity from the backends, particularly > netback. I found no API to query the usage of a page, so I declared the > interface broken.. "The interface" being which one? The tool stack can map the guest's grant table, so it is in the position to find out about all grants without further hypervisor help. Afaict the same isn't true for the FIFO event channel control blocks, though, and maybe there are further ways by which pages may get modified for a paused guest. Jan From xen-devel-bounces@lists.xenproject.org Mon Jul 05 09:26:04 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Jul 2021 09:26:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149984.277383 (Exim 4.92) (envelope-from ) id 1m0KrX-0003RX-Ej; Mon, 05 Jul 2021 09:25:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149984.277383; Mon, 05 Jul 2021 09:25:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0KrX-0003RQ-Bd; Mon, 05 Jul 2021 09:25:59 +0000 Received: by outflank-mailman (input) for mailman id 149984; Mon, 05 Jul 2021 09:25:58 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0KrW-0003RK-3P for xen-devel@lists.xenproject.org; Mon, 05 Jul 2021 09:25:58 +0000 Received: from mo4-p01-ob.smtp.rzone.de (unknown [81.169.146.166]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 005eda2e-dd73-11eb-8440-12813bfff9fa; Mon, 05 Jul 2021 09:25:56 +0000 (UTC) Received: from sender by smtp.strato.de (RZmta 47.28.1 AUTH) with ESMTPSA id 30791cx659PtL7z (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Mon, 5 Jul 2021 11:25:55 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 005eda2e-dd73-11eb-8440-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1625477155; s=strato-dkim-0002; d=aepfle.de; h=References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Cc:Date: From:Subject:Sender; bh=y0Ymbe55rYi3lkV6wS54ZVsWy94bGThXvZ8g5xKRpic=; b=VgLFOS80X5gvfv57/M11wD4kwWdFYC1W3T91umskJzNop/4MVki0aXXim68nQ3alM8 qnMQw7ZQaaXW7omQzOne09REDhLdjWHXB5+aaKHEcY3byJ1qVhzoCpnfxg314LV11GUv IawnPQk1P2n7AX9N+K5BTGSxvhrx5K9eHUoaYZnQSASR34vLD4dHIstCo1yttQmxFOqC u2+528OBf1lTrvPBsgju1TPf1Vu3fs5qKj0GZ2gBwnvVtQcoWQSCg/ghkTZfm9P3q3AI R9nNqdRRNvm7zzHLOU8Ovn2XdWWZl6UXoouccs2osod3+yIfXnKezPT31YtSTXIgr8vE FMKQ== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QLpd5ylWvMDX3y/OuD5rXVisF+Ax6FOE3sSy9BcWAcR/hQoAs9MGk67vg1baqX" X-RZG-CLASS-ID: mo00 Date: Mon, 5 Jul 2021 11:25:48 +0200 From: Olaf Hering To: Jan Beulich Cc: Andrew Cooper , Ian Jackson , Wei Liu , Xen-devel Subject: Re: [PATCH] tools/libxenguest: Fix migration's debug option Message-ID: <20210705112548.22ae6d20.olaf@aepfle.de> In-Reply-To: <1e2a3967-06e5-75ec-3aa5-1f39b6700e63@suse.com> References: <20210702190342.31319-1-andrew.cooper3@citrix.com> <06968742-355f-ad37-0681-e51eea256414@suse.com> <20210705100228.4947ed4e.olaf@aepfle.de> <20210705103224.26f3835d.olaf@aepfle.de> <1e2a3967-06e5-75ec-3aa5-1f39b6700e63@suse.com> X-Mailer: Claws Mail 2021.05.27 (GTK+ 2.24.32; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/HqW.YTqH9FVj8uTMxbBlZOI"; protocol="application/pgp-signature"; micalg=pgp-sha256 --Sig_/HqW.YTqH9FVj8uTMxbBlZOI Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Am Mon, 5 Jul 2021 11:19:59 +0200 schrieb Jan Beulich : > "The interface" being which one? The tool stack can map the guest's > grant table, so it is in the position to find out about all grants > without further hypervisor help. The interface means the code behind verify_frames. If there are indeed ways to query which pages belong to grants, how would t= he toolstack need to do that? Olaf --Sig_/HqW.YTqH9FVj8uTMxbBlZOI Content-Type: application/pgp-signature Content-Description: Digitale Signatur von OpenPGP -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEE97o7Um30LT3B+5b/86SN7mm1DoAFAmDi0BwACgkQ86SN7mm1 DoALlg/+LTM1mpqsWTwWf4F9+rmU+/lb34pFDxy9Vc1/LJe5b8CFUF3EavWN8VXY J3asCPJR7FHXxL74dSAJ+8K4xQM5TRvflIp+7CFVPS7vAKM3x2mQG2KQ/6H+Cfzw Qc2C1BlRjtBCsudAsBFN6cDFYPVAPmKVPLkOPpikrkHVpePKRz+llCFzQ/DpWGGU cyboCxgcjzZE9649oHmdPkBTSYjwsRDTjA593wiTXnWgqC63Y5kKZJCPD589o09X JNsQL02DpkF4+X/m1j4/POENEO6ZC1/51xSNv6Mg3pAMmFq1Rn7g2XayZ+v/C+i+ e8jdLB+gPb/ZXd/TrgmIK/gzBQqazyoIoevwRinl5ZMkFQi7c7S7LjGHg5kN1Uz2 398ns6TyNe6s0KcPDAFAR2QKlObyD2gVQuWHc2iqeq8jb2CaD9x6+drVzNSNTn/1 SjhyKyEmWFrbMtHjrmOfFe+SSeim5sgD/odLUltZy6+7uaZJX0PqQJ9YK9yiLhFu /IDEdt8bifnKyS88n8J1aGbV34Sv6wy4alQ2O8uOSojnQleQz4yGb2muwnEGMwKq uiB+5+TYGPjVS2wrG/fu2OXbWr8W5BhNc8GCD/b5Kb1xWubnY5p/jWk0E4eXen/g 6F4cjL/9lVMMxuWBWr99LlTUkoi6JuLFd20R8fO79FNaRXrJDnQ= =nU6Z -----END PGP SIGNATURE----- --Sig_/HqW.YTqH9FVj8uTMxbBlZOI-- From xen-devel-bounces@lists.xenproject.org Mon Jul 05 09:27:57 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Jul 2021 09:27:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149989.277395 (Exim 4.92) (envelope-from ) id 1m0KtQ-00044D-SJ; Mon, 05 Jul 2021 09:27:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149989.277395; Mon, 05 Jul 2021 09:27:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0KtQ-000446-OD; Mon, 05 Jul 2021 09:27:56 +0000 Received: by outflank-mailman (input) for mailman id 149989; Mon, 05 Jul 2021 09:27:55 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0KtP-00043z-Ln for xen-devel@lists.xenproject.org; Mon, 05 Jul 2021 09:27:55 +0000 Received: from mail-lj1-x234.google.com (unknown [2a00:1450:4864:20::234]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 1e4d5ce3-02e1-43d0-a266-bea790de399f; Mon, 05 Jul 2021 09:27:54 +0000 (UTC) Received: by mail-lj1-x234.google.com with SMTP id t30so3825368ljo.5 for ; Mon, 05 Jul 2021 02:27:54 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1e4d5ce3-02e1-43d0-a266-bea790de399f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=P+qSy8IGAGojkMhIacuBSum3i+RiyiSZGBv9wxV91Ms=; b=Do1+2UKaUX7IiK952BaVIqSw0Oa/VSNTMcnqbBcXoPB0/X5gU+RMGW4UzqiS0wmRtw YgjQzjQUp0UnLoryUTiBZFLsLfuiLV8z5SJCaYvePxtKSGl+HxY4zaWD0tl/AjLApKPI PQeiHWXJoLGrtoix1u4W9twM4sFL+aTCQPElUMj+E4I9/wuGlautT/TbVVX6kD9dPvJS rOK9YVJElP2vZmC2+u+8N8wQa9oKbBZnlAdMTfR/UNt4UuD/DQrVGxWpE7KdPGQ4hkDz gp4f+rjq7HlheG4YFlBjWqqpczQBGxaYDon8xxed+QwwvXsuW864ue+VL6WR84WvOzhR 4T7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=P+qSy8IGAGojkMhIacuBSum3i+RiyiSZGBv9wxV91Ms=; b=k866lad7YsPv4yuWQe6447YgnO5p+FuwCdm0hNxEufRcdHCeWDr4DSA3Sa5EUFVk81 OtUlQlSdW0l6aNf0ki8xxV1VuYgHM1LjvDPycEMtvXgBmZe7x7P4ILEwKx9nWR5eWPnT OIKCQWA6S/11vnKsW+zaNLh7DuxKd/sFiEsnHkVZQPqCvChaLb35tu81feoF1dEDJQSe pGWjHOZkzM98ydQwBuOjcqzOZC4H7cUG/dTDjuIHqsoTWZ2Sra3J2YITUYwb3rx7/5aj S/f1MKHKK5aodEaoSEwCmfrgU4meT0EdxG59nnMCkywT3q9j8oj6pf2q2754eJbSMRg7 RENA== X-Gm-Message-State: AOAM532abi3BR9DN4lQ4aP11meUHmjaxBdySoJwFgqV2DQ5f58b95OeD socl+wBVwMLe8PPqT7Bz8HmQ/KLanXNrSm+/580= X-Google-Smtp-Source: ABdhPJxJfBUkXqCdbeU9gCFObz8I8U4281eSs2/ewnjIIzNaQqe4Dp7JmeSUIWCQ5Xwi6J6qyut7CF9W+kGH8+8nsiU= X-Received: by 2002:a2e:8596:: with SMTP id b22mr10373383lji.63.1625477273720; Mon, 05 Jul 2021 02:27:53 -0700 (PDT) MIME-Version: 1.0 References: <20210702170602.890817-1-fontaine.fabrice@gmail.com> In-Reply-To: From: Fabrice Fontaine Date: Mon, 5 Jul 2021 11:27:42 +0200 Message-ID: Subject: Re: [PATCH] xen/Makefile: drop -Werror To: Jan Beulich Cc: xen-devel@lists.xenproject.org, Andrew Cooper Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Dear all, Le lun. 5 juil. 2021 =C3=A0 10:16, Jan Beulich a =C3=A9= crit : > > On 02.07.2021 19:51, Fabrice Fontaine wrote: > > Le ven. 2 juil. 2021 =C3=A0 19:34, Andrew Cooper > > a =C3=A9crit : > >> > >> On 02/07/2021 18:06, Fabrice Fontaine wrote: > >>> Drop -Werror to avoid the following build failure with -DNDEBUG: > >>> > >>> In file included from :0:0: > >>> /usr/lfs/hdd_v1/rc-buildroot-test/scripts/instance-0/output-1/build/x= en-4.14.2/xen/include/xen/config.h:94:0: error: "NDEBUG" redefined [-Werror= ] > >>> #define NDEBUG > >>> > >>> :0:0: note: this is the location of the previous defini= tion > >>> > >>> Fixes: > >>> - http://autobuild.buildroot.org/results/66573ad0abc4244c0dfeac8b684= a7bfcc31c0d4d > >>> > >>> Signed-off-by: Fabrice Fontaine > >> > >> For better or worse, It is Xen's policy that -Werror will remain. 95% > >> of the time, it is the right thing. We will however build failures > >> whenever they crop up. > >> > >> This one is weird though. How is NDEBUG getting in twice? What does > >> the rest of this build environment look like? > > NDEBUG is added by buildroot in the command line if the user sets > > BR2_ENABLE_RUNTIME_DEBUG to false since > > https://git.buildroot.net/buildroot/commit/?id=3D5a8c50fe05afacc3cbe8e7= 347e238da9f242fab0 > > I suppose the build environment setting is really intended for user mode > code. I question its applicability to the building of kernels or > hypervisors, but I can see that opinions may vary here. If we wanted to > honor a pre-existing NDEBUG, how about simply making xen/config.h have > > #if !defined(CONFIG_DEBUG) && !defined(NDEBUG) > #define NDEBUG > #endif > > ? This then raises the question though how an external environment could > achieve the opposite effect of suppressing NDEBUG's definition despite > CONFIG_DEBUG being set. (The main point - hence my view expressed above - > is that we switched to Kconfig to centralize where settings get > established, moving away from taking ones from environment or make > command line.) FYI, we have reverted the commit that allowed the user to set -DNDEBUG as it was raising too many build failures: https://git.buildroot.net/buildroot/commit/?id=3Da1c7cff1a081765c082c196bd9= e6c1e72ceee797 So, this patch is not needed anymore on buildroot side. > > Jan > Best Regards, Fabrice From xen-devel-bounces@lists.xenproject.org Mon Jul 05 09:31:21 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Jul 2021 09:31:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.149996.277406 (Exim 4.92) (envelope-from ) id 1m0Kwf-0005R5-CC; Mon, 05 Jul 2021 09:31:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 149996.277406; Mon, 05 Jul 2021 09:31:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0Kwf-0005Qy-7r; Mon, 05 Jul 2021 09:31:17 +0000 Received: by outflank-mailman (input) for mailman id 149996; Mon, 05 Jul 2021 09:31:16 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0Kwe-0005Qs-9i for xen-devel@lists.xenproject.org; Mon, 05 Jul 2021 09:31:16 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 68704eec-e8b3-449c-8e79-657a0882a3a5; Mon, 05 Jul 2021 09:31:15 +0000 (UTC) Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-db5eur03lp2057.outbound.protection.outlook.com [104.47.10.57]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-12--4m3hvj5OEuo4V2gMVtPoQ-1; Mon, 05 Jul 2021 11:31:13 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB6174.eurprd04.prod.outlook.com (2603:10a6:803:fa::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4264.18; Mon, 5 Jul 2021 09:31:11 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::99d3:99cd:8adf:3eea]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::99d3:99cd:8adf:3eea%5]) with mapi id 15.20.4287.033; Mon, 5 Jul 2021 09:31:11 +0000 Received: from [10.156.60.236] (37.24.206.209) by PR3P251CA0003.EURP251.PROD.OUTLOOK.COM (2603:10a6:102:b5::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.22 via Frontend Transport; Mon, 5 Jul 2021 09:31:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 68704eec-e8b3-449c-8e79-657a0882a3a5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1625477474; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VSS7ab6faEUx22k8Q5SlASYn33rjfL9dM86O77nepwY=; b=jQgafPXUV0YDVkqOxhnJaryrKWCXjUQAv3BRspTXAFo7BIZFtORK2K7FRps+fXNkVWh4dW 3Hou3cuDQSqTRA6DFOhx7+BrHfJ8e87hq+tFKfwD/sjHLnVeNWEIyDGb7Tpg5R9mQ2ifPX LBho1JZIb+dDyaP7VkYYmgLcAxzkEIY= X-MC-Unique: -4m3hvj5OEuo4V2gMVtPoQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=b0zbW8vcPROfrUgGbH4VVd9gv7H+hQ3oUcoJN/sVSn/UYT9R2Bd8YVCKlpygukYPga+WSVk4UWGl3ixAqSzlKxGdqCdZ0mhqXNY4qw4/DZo+W0bEGIUReun6Yvc7gTYHzThbI3jk7JycF5rRSYtBsjdnmyTdjzpmEssE5UaOUj5husPt1vKdDPJc65zGgjmnFsA5B30A84agOWV2D4bRneBxamEmtjAoV6Rt6hUJHMDPZSBek1b0+9/MuvpdRdDI6Uf5TgdxQv1xM74FTt3shiMFspu9+WV56GwrekU5OgwXlTP7rhPMC33T8drovrmiH1PwWrCyjkszLjf2dkLHFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VSS7ab6faEUx22k8Q5SlASYn33rjfL9dM86O77nepwY=; b=ILx7CrcJnCkT9RlseQcVRu/19o5r/sDzUQlw6das65AzZyY1D0/M02G+pinNakC1Bbyzg8J3ufTPtxzYItt6NrAJhxu90RJB5KpuxqU43HkRdonNOS5uKKJlpa9hiIhgvubL+HuOfXkaktL2eqgyhlc5uNFNAGOC18oV8XsA54X5QX4CF6h95vqD2hTlpmdX01mX0MsZh9yVSXUkcmSbWoVAbBYrwtl9lQpwjMJJvUY94LmY36j7/JRPxTUGXt05WViQNLZDFKtEwuD7Iy0ocHAIiLSC1l15MuPOjTIOZP1VYtEKkUSAAIi+vyI5mYXSKc6NqdrdQ/SWMgqdOTRWEw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com; Subject: Re: [PATCH] tools/libxenguest: Fix migration's debug option To: Olaf Hering Cc: Andrew Cooper , Ian Jackson , Wei Liu , Xen-devel References: <20210702190342.31319-1-andrew.cooper3@citrix.com> <06968742-355f-ad37-0681-e51eea256414@suse.com> <20210705100228.4947ed4e.olaf@aepfle.de> <20210705103224.26f3835d.olaf@aepfle.de> <1e2a3967-06e5-75ec-3aa5-1f39b6700e63@suse.com> <20210705112548.22ae6d20.olaf@aepfle.de> From: Jan Beulich Message-ID: <5e4986ad-d3ec-18af-b1ea-ccbce57a70ff@suse.com> Date: Mon, 5 Jul 2021 11:31:09 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 In-Reply-To: <20210705112548.22ae6d20.olaf@aepfle.de> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [37.24.206.209] X-ClientProxiedBy: PR3P251CA0003.EURP251.PROD.OUTLOOK.COM (2603:10a6:102:b5::6) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b1fc3aaa-abe4-4c88-af14-08d93f97a028 X-MS-TrafficTypeDiagnostic: VI1PR04MB6174: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1AWOWL0iL9vknBiTC8WY0qBv/BZt0FsYV5xEZZmMD6R2PaSnX/GmdL3cZr29m0XWy34S07w1N5MuFJpURwYXhctO189BXhovvarkSDJP9jNFyvVHWwUXeJ43jZXzNVbj98NjFyQReBsHFDu624hKac088fjX70IUh2RV8X0oJagYJ2JlY+NYcSPeRv72fuY6JnGDe1CIltn2OZeWole+uo+MaS55Cl3GaokA6iOUwb8D6jdz5GNIxd0ARpjgdXoeubSBz+s2KMFUG9WfgLZHE0iKKhv/iwXUtJYL7CBnfoNzf9CZduRJZ6HkUpd7mpPT8f3EltHlgpQQiPQGM+vWQXsDLE+FSurQzUzWavvs6oRQJ3VpbsRU6x9I9tIKNabcBD3UQ2DoUeXEX/H+XjVsOHHXtph1/nJyMDHHe8qfsKXvvPCM7V8HID0qm1trx0hTBm3JKULWcB0r+pkP2wEvlsLwOrVRe4ADNdmZ7P2uHTkrZxDjrJVpwYEVrY05Bd3yuDCYxdBRLUQqKjokhLZpPJLw91PrTuAoWZJblEdQCpdHBuiDIqlMHTTKerRRtA0krpLAOkiWSJiXJaA3o4SZvUxRcqK9BXCb+rpunC8iBpwTt7ZeuwZaC9EBQcNwfez7x74riarQWoIx/hW5nA7kN4pGYON2tLIkJtfIG7+d7VkQWJrywoHioiba201VIJCjiNhJ9RMbGEJEtuw3jVKJ49gHyO25Kn3Ja/4YZXetFog= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(39860400002)(376002)(136003)(366004)(346002)(396003)(31686004)(4744005)(31696002)(186003)(16526019)(8676002)(8936002)(6486002)(86362001)(26005)(83380400001)(4326008)(2616005)(36756003)(38100700002)(478600001)(316002)(66946007)(6916009)(956004)(66556008)(5660300002)(53546011)(66476007)(16576012)(54906003)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?Windows-1252?Q?UXtAP66G2EkheIjuy3gCUZEBoTjsPEZsS/YQp/vr/DgDEs+Sdca6qK76?= =?Windows-1252?Q?lt+PiJB/uaEH07Qj+z/7ezpFX1/lt/0evMa/pNMoL7ERjyVMy/aHzCR+?= =?Windows-1252?Q?zLrQbvckbdEGwV3oDosREEJSAFGHInA0ANyaKgrXpHJKleP3VkZk3yZA?= =?Windows-1252?Q?hq2jhgRVCaWPfPXVlB6hn0OorOUbP4aQYrQz+E1jQNFhIhH3g9rQ57Hd?= =?Windows-1252?Q?/cYd3vCyvt1EWsH83Jv0EanklUUUZcwbc2N1fchwz2UwGUIzRfHQBFVk?= =?Windows-1252?Q?5XUkKI+v0Mo9Orz06323pOrbeGsyGcvKLCdRwqRSVI0Q97aoZugzMJAn?= =?Windows-1252?Q?8QQrW+E1aqY+OYj05+BTYOuV/pIc/jCeI9MAXr9sjVFETLfYGmCfRGV+?= =?Windows-1252?Q?JR3Co1c8yxJFqA5beqsMVdNtz3U8uvyfl1ZvXLhLj+G5xCAql7B8+CAP?= =?Windows-1252?Q?MKcmXPoZjigRL/62QC61SAD3802hEWIxuHLAM7cVGmgpROxQubLDGUS7?= =?Windows-1252?Q?2/ovP090wkkdoqwZjU1/SRaPcu2us9vfkHFG3w/yrclXrmdsH+XjanUU?= =?Windows-1252?Q?G7X21149rNELXVUdpGfwc/VnGGtgAf/NSS8/1Qwp0AgG0+aAMA4nzMLQ?= =?Windows-1252?Q?2bbbmyur+kY42TAf7bY81v8VrSwmBRf4DVR+9sX5Nkj5Y5J4pc7iTuQ1?= =?Windows-1252?Q?zNB7jbPZ2m4fbm7hfHSuWjWcvy6PZrrPEnaiFNsCbT09dt/xi647J2XO?= =?Windows-1252?Q?TT1EU6E1USorKEgCGJWphycoo4bEqnRlcJ495qv7R7mRuNto87dIxGTc?= =?Windows-1252?Q?nK5+sZhh/x5g6XNjchaDa7I3oUKBDNx67LrBck8JseX+kCWNgzjf14vn?= =?Windows-1252?Q?AswO2A3IvVuNcfk0tI8ZskouLiT/rUxX2kJl+x+T3YcHMHPC5pBjw+3m?= =?Windows-1252?Q?EOQYaN5Zk96Bu/MoV17Dd5luY8LhmELedVw/W6aaUCDnR7KlpMANSho7?= =?Windows-1252?Q?xiP5J2F3tStAsxSfvFXVcXJuKGZX9RQ7G3VArHKccDo/kJHbAYtanTt/?= =?Windows-1252?Q?KgNYAy5ipKwx33Xe5ADrWzjFdbOcbSPDTnEyjz3Xth1w6Qor896Vlgeu?= =?Windows-1252?Q?QrCd9XjHaYQaqhPL2ZuZlJMcxFNKzlxUeUpdqOCUZ1Sd/DX/vBCy/PG9?= =?Windows-1252?Q?I/S4hA3nIUXj4cwpeNOS4Tk0waH9+uLaUX0TKZmFFxSom4iZg4gpY0pH?= =?Windows-1252?Q?MxGgjK7MO7iZni3r/J7bBRGPDnNe1UIihUkzemJmv+dqK/F8XKuT3cI7?= =?Windows-1252?Q?Hop2H1DrHstS8rkt/9mbQf8kgp4PCkMbuf9F1HlpraNuReGZWF55sL7l?= =?Windows-1252?Q?zCShD0r3T2XOyoKK++qjHi64pr6f7yWttAHHQ9XKzPA2kYqTGDl32DY2?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: b1fc3aaa-abe4-4c88-af14-08d93f97a028 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2021 09:31:11.0287 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: IzkzVIMz/gMZRRYQQ/Yaz5YVD6yXUQTxoh+Xp1eo5onazmuoFVYhxgdv28wgV2Fn5biCXGpolXEfiqLF+tpzgQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6174 On 05.07.2021 11:25, Olaf Hering wrote: > Am Mon, 5 Jul 2021 11:19:59 +0200 > schrieb Jan Beulich : > >> "The interface" being which one? The tool stack can map the guest's >> grant table, so it is in the position to find out about all grants >> without further hypervisor help. > > The interface means the code behind verify_frames. > > If there are indeed ways to query which pages belong to grants, how would the toolstack need to do that? Map the grant table of the guest and walk it, recording any MFN for which at least one valid r/w grant exists. Jan From xen-devel-bounces@lists.xenproject.org Mon Jul 05 09:41:55 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Jul 2021 09:41:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.150007.277416 (Exim 4.92) (envelope-from ) id 1m0L6s-0006ws-Hc; Mon, 05 Jul 2021 09:41:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 150007.277416; Mon, 05 Jul 2021 09:41:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0L6s-0006wl-EF; Mon, 05 Jul 2021 09:41:50 +0000 Received: by outflank-mailman (input) for mailman id 150007; Mon, 05 Jul 2021 09:41:48 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0L6q-0006wf-8Y for xen-devel@lists.xenproject.org; Mon, 05 Jul 2021 09:41:48 +0000 Received: from EUR03-DB5-obe.outbound.protection.outlook.com (unknown [40.107.4.77]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 364ecdcc-dd75-11eb-8440-12813bfff9fa; Mon, 05 Jul 2021 09:41:46 +0000 (UTC) Received: from PR0P264CA0101.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:19::17) by AM0PR08MB3329.eurprd08.prod.outlook.com (2603:10a6:208:57::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.27; Mon, 5 Jul 2021 09:41:43 +0000 Received: from VE1EUR03FT013.eop-EUR03.prod.protection.outlook.com (2603:10a6:100:19:cafe::5d) by PR0P264CA0101.outlook.office365.com (2603:10a6:100:19::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.22 via Frontend Transport; Mon, 5 Jul 2021 09:41:43 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT013.mail.protection.outlook.com (10.152.19.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.22 via Frontend Transport; Mon, 5 Jul 2021 09:41:43 +0000 Received: ("Tessian outbound 71a9bd19c2b9:v97"); Mon, 05 Jul 2021 09:41:42 +0000 Received: from ea1444c9712e.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 60D9B237-B688-4DF7-99C6-486BA435B146.1; Mon, 05 Jul 2021 09:41:22 +0000 Received: from EUR03-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id ea1444c9712e.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 05 Jul 2021 09:41:22 +0000 Received: from PAXPR08MB6816.eurprd08.prod.outlook.com (2603:10a6:102:130::10) by PAXPR08MB6543.eurprd08.prod.outlook.com (2603:10a6:102:12f::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.23; Mon, 5 Jul 2021 09:41:20 +0000 Received: from PAXPR08MB6816.eurprd08.prod.outlook.com ([fe80::4a9:5afa:372e:97f5]) by PAXPR08MB6816.eurprd08.prod.outlook.com ([fe80::4a9:5afa:372e:97f5%3]) with mapi id 15.20.4287.033; Mon, 5 Jul 2021 09:41:20 +0000 Received: from smtpclient.apple (82.8.129.65) by LO2P265CA0401.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:f::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.22 via Frontend Transport; Mon, 5 Jul 2021 09:41:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 364ecdcc-dd75-11eb-8440-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HrAsSx0rfTEqLNvV8qc3N0KETcG70S8EnjOVMqOd7yQ=; b=TYOBDuGShVx+HNUgzJp8N0Y+I1jz8rH4pUlUlMfThXfNnP8RyFcgJZlcwV7cnndI7BEUvJTDVWHgBNQsV9qg61JUnnIDpgx5AWFhl685kGVb3Twh+3XlPzhgH+NgNH07/gNhEqKrWDmvXkI6oaCNm4bzJKesa9sR+YLpamkwE8c= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: 18d00f3ab4701cae X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UiWTkMZIzwrjl6UqEWmMO3L4AkU/0QcsUeEpwVPwYRebX9cxpwyg8acXa10zTXNRsXn2HRkIhNNleriMrIp++9TojOcqucHhscGdXQ9Jw8rdUKW2R7LL1myT2DtJ7e17MSGqlokTulMtSK2L1ctQyM5O3Vd6knAT8Fx9J9eYpBx6CYRifdYYhaQEquc39fqgNOAjxBMGk4D6lZfyXxXS3GG33mQHAYgXMLPJ90gM1L6GA8XSjK5WCqVR0+ExBphOlsJS5BLJb/Cci2nPNaRSR9RrVehbwE8WlbAdnMqCqgkL3rVFW0V91Xdqv8a74EwIAVM39vutCjmSnna2am9RnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HrAsSx0rfTEqLNvV8qc3N0KETcG70S8EnjOVMqOd7yQ=; b=i0HsNKVCc9B3h4LndvRxfnM4aT2JWRpBdo9AGpXsA5g0nLsC3kAYoL20EIBAHei3oS5wknqeGkCFMHymnu8nFKTuYPxiOEbWI+a9vGdXPlKr6qzqmVmIdLDNdX5gnLKZabNG5uwZ7YvR6LiW+rCWtxacemJH+7EETQ085SiofZdTAnqDA+R5bmndFYtuLxLCRyi72jvCRRwc9L1XiXrpDw70e/58Gj6CDK7GWNCTziP0N2AgSe5e02aqNMJxdcUl6wXrhbHcKgx1Xb0l+Ko0zyR/dyXdQZnrQ8giE3tfbqt4YfoKJXxhfJJb0wp09fNR6f3xcKa8jpy7TGjZYJelFA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HrAsSx0rfTEqLNvV8qc3N0KETcG70S8EnjOVMqOd7yQ=; b=TYOBDuGShVx+HNUgzJp8N0Y+I1jz8rH4pUlUlMfThXfNnP8RyFcgJZlcwV7cnndI7BEUvJTDVWHgBNQsV9qg61JUnnIDpgx5AWFhl685kGVb3Twh+3XlPzhgH+NgNH07/gNhEqKrWDmvXkI6oaCNm4bzJKesa9sR+YLpamkwE8c= Authentication-Results-Original: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=arm.com; Content-Type: text/plain; charset=utf-8 Subject: Re: [PATCH v6 7/9] docs: Change Makefile and sphinx configuration for doxygen From: Luca Fancellu In-Reply-To: Date: Mon, 5 Jul 2021 10:41:13 +0100 Cc: xen-devel@lists.xenproject.org, Bertrand Marquis , wei.chen@arm.com, Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Julien Grall , Wei Liu Content-Transfer-Encoding: quoted-printable Message-Id: <9C2F15B2-2B24-4C23-9902-8FE355C01201@arm.com> References: <20210510084105.17108-1-luca.fancellu@arm.com> <20210510084105.17108-8-luca.fancellu@arm.com> <1FC1E8DF-8AED-4ABD-BE9A-DBBD9D66EDBB@arm.com> <7C3269F1-3C61-4F39-82F9-9DE4C563849B@arm.com> To: Stefano Stabellini X-Mailer: Apple Mail (2.3654.100.0.2.22) X-Originating-IP: [82.8.129.65] X-ClientProxiedBy: LO2P265CA0401.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:f::29) To PAXPR08MB6816.eurprd08.prod.outlook.com (2603:10a6:102:130::10) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: bec5dace-d9aa-4840-1c0b-08d93f991933 X-MS-TrafficTypeDiagnostic: PAXPR08MB6543:|AM0PR08MB3329: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:10000;OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: eTS+uPfKWQIGqVHg3orVhv8K7PLzIPuvKHFNBJ/qFb4o3BlhvxlQ5kcfnjkQMxYMa/ByS6pGIGzYWfn+Z8/R/6POFJksph4ztCjbIKSxgO/8q/Z1FbWiRdl8wDCdQDJ23lGi0NRhg6XZeFjlH2w4TdKfyBWgOvc3gWMorogoRxky5PVtDa5ImZlGgh+vQ1NgX94FTzP80NNdZoM4vGE10gVHsEmAvRpDL3W6qHzd7n/86IeCg2kwlp4CUDQ8iy44WJDkaO69i+lWLDsOJ8jqxBOrUpnBLEezpPPMMeN4HKM/QSYvfNC4Y0YuRVx1ujuO8nl8V/d21ktwKVHqX4MHxHlVRSXSy99jG5nyWJEMsNf2su0+n76Yk55/+DRL4qaFCzZREzHq5OMGrlWwUXh6DgOJ1PGPQOFBT2zPI9dHk1yCB2QMCNdU21twiOqUAyZIZqykSaJh5XLr1P4vlqA36BseSJsAWlaAK/t4AeXmH9AfOjGO1yVcNXrm2pvLoGod6/Hyn1eFMQX31m5tCVp1MstrWgh86RRBtOwdkKd3JO+C8mVaXHcseVhNagBQnMZlzGNfHnmal9HyxU5dlwgE6i2G1kvaQNiILq6SpVofTqSXy9txX7utJm5vujlfXilzZXKnJfzdP5sRjnYLKYkVPxUugrncehD0nSANPnMHheL5nEmW9NkXREaGkiXbYQSjrAdyWEe6zcTgQCcFxpkG4d8mkxm2O1G1mMOHqjVBJnBBwdVarhXiBKxdVPL8sT91 X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB6816.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(39850400004)(346002)(366004)(136003)(376002)(478600001)(8676002)(66556008)(66476007)(66946007)(16526019)(2616005)(5660300002)(44832011)(956004)(4326008)(8936002)(38100700002)(38350700002)(54906003)(186003)(83380400001)(26005)(6666004)(6512007)(6486002)(2906002)(36756003)(52116002)(316002)(6506007)(53546011)(86362001)(6916009)(33656002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Sm00azRDSTZyOGNjdUZZY0xIYmZsZjlaSVRZR3JRMHRiY0JlTnR4NC9ZWU1u?= =?utf-8?B?TzRDUHB6TDhBeXUrRlUwdVhvWGptdEV1N0gzRWdLdWRmRGQzclZza0JHeFp4?= =?utf-8?B?Y1IxaGpXTEIzZllsaFdQRmhiRUIyaWFXMFpZSTJoV2E5OXZrWTdqN0dxVFFn?= =?utf-8?B?Vk5YUnJ5blZpR2Y5OFBacFJKUmIxazY0WURNaGk4dGVlaHJsUTZtUXNuWWpG?= =?utf-8?B?eWdyZWVHMzI2bVVGOGdEdEQxbEhDemppbXV3dVVZMWZZdTZaL05uaHYvRzRw?= =?utf-8?B?Zk85SlZ0eUpXSUM5VDNpb1dOQTJwb0VUc2hsZTBmMVo4bEdZdkJ6b2JYc0hX?= =?utf-8?B?RG9UZHFraXRrbzBKbmp0U2l3d1lnMy9DV3Q5ZkwwTThJeWRBdzlJMTFOalhN?= =?utf-8?B?ejlmRy9IUWtSNzR1dVkvaCtPTFdEMFFibzJGUC9ibkg2MjVCNml4SlZGVVFJ?= =?utf-8?B?KzF4ckpnOHcxOHFmWk5GZnI1TXhDUFJlVVlBUEp1cER1RlpkNDlzMHVIdity?= =?utf-8?B?SklKQ3QwYTJNb1h6b0w2UEZVNUs3NGwrNHFNVllkZm1hT0FRMzkvdFRCN1ZS?= =?utf-8?B?VmxRY29VcjA2dWd3c2dpdm4rWTgvTk1OcjhhYnFzVVd0b09qS1kyWDlaanpx?= =?utf-8?B?WGN1UldzTEFhY3ljVnhrcHk1b0JZQ0YvSkg1U08yTlJkclg2bkxRdGN0NzJK?= =?utf-8?B?d1ZyeVZHRnptYjNhSDEvVHVVM2xpNmUrWENlUEpUMXRZa2k5Ym5yeWtMVUdR?= =?utf-8?B?SG9jODlxVVZHTWg0dXNKMnFnOHNYYUNwYjRITVJJdlRtQUNFVWZLaUxEbGJE?= =?utf-8?B?emVLaHB1WUxucXJlWG9QQTRnOFBlVzdmSUNhUE5oaGpXckMrVElhNDFadFpJ?= =?utf-8?B?ZzVYYXpKNWZJOGR0dTBMWDBXVDZwaGZMdFo2cVgydTA1UitjZDgxOEVSNnRV?= =?utf-8?B?TkIvTDV2ZkZvSzhyT0dMLzBOUFpTYzgxb1pIRjRtQjBTZmZGYWFiSmFkL3Z1?= =?utf-8?B?MHBqZVRyTWhsdFB5Tys0YnRnQ0l1a2JhaEwzM1lraWJJUC9sK3V1VnkxdEhq?= =?utf-8?B?OXB3MC9QdEc0OWxwbXk0TWpJLzUvdWRLUHY0UUlOeXMxMlllRkczTVVtb1lC?= =?utf-8?B?MDBJdEFPaVhvRkk1U3UvZWxDU1RwdS9sZjh0b2JwSVBrRkJ1SmNFYzdoSWpX?= =?utf-8?B?Qm1Ob3ZTcGx6RG9nUll2d0t6bklteE1EdFpCZWs3MlhMME1jeHZrVVBsUGVa?= =?utf-8?B?eXlWRWFLdFBidVArQXNiYnArT3dtRlp4K3hGSlE4YUhRb3NmazAvTWlYU2c3?= =?utf-8?B?OWVjQzNYYkRMR0swRTl6UkgrZkJoRFhtMHRIK2ZLUndXdXpRZ0dianZ4eWR0?= =?utf-8?B?djU4Zlh3NW9yalpFZHpuQXhjYS8rcmloRTFRNmE0Q3R2bnJwb3hsZml0WFcy?= =?utf-8?B?VjR0eWZoYjhoVkZDa3UvdG1EaGFydXJXbXZtSmprOFdrdi9ncEU0Q3V5Y0hZ?= =?utf-8?B?WnVNUThISG5IV2NzZkQrQ2VwNzFSWDg0Z2JQQmJJRnQvYVNTdFUwZzQrRTUx?= =?utf-8?B?cDkyamc0TFhEZGovZGp4WWxtZ0pJWm9VeTUxakNvd2lJNVFpYzdNNm0vVElE?= =?utf-8?B?T3ViWURBQnhiL2tGOGRFNW55eDFwajU0R2tNRDh0SkpZZkZLN1doWC80NSs2?= =?utf-8?B?NUJhRHhZZGZUeks3c2pEcHZjaEwra0ZxdmxFTFRITkJjT0dZQU0vYW1mR3Nj?= =?utf-8?Q?fDHCVVbuqrdY9cBPaR8aDt72wwmFP04s9Q/epA/?= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6543 Original-Authentication-Results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT013.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 7f7c21b9-bb60-4209-47eb-08d93f990b46 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: elR7CDNrEN9GRgyMfswsjbkiSG5FyW6G1o6dukSMtPq55pixMPzT8kkY4tgxQ/fj/lxpFsedblIcIz8JYli5Qs78l7dfs17OIbRRZhjqA9yUljFz3q82GWadgTfypDMpYALwSfeh1vKEPMWw1ZZgyfdX+VqStZWylOyFkH2A2xQXXfWVDdKP3Au1m2XJDlHzoXk79mXYyFGjCHrZN8vGoa2r6WUIMH+gmHB5iTfhvkA92WamZVdraLsRRJYzO0OWDZ53vbLMqOMIkQjh063ciXdZ7qEIye1bleYEk2cLHwQioAUujDqCjUnnlg6rOz5JN07r1ATS4kIhdnzNCLD759t6m16W9mXeRxmYzeDrDFTgN/R114+PBIAlD8PBClt9nOl40X27psrnP3i6+ngIuG1I8H2Tw4rDSH6CwWAelcHO/p75avp7cz623vaPQ3oKk2zsyMkWBgDrYF+RaIzxr4m97sQ1Ue7Vmy52uiP7oaEc+UYHpVPqHA58ACYyhO+R5um8cscxoTYRE2Z/XdEOftPvFfvEH2DYF0zTZA5y7xlmk46CsoqHPZaA8+bgpPpNbdbznSA3R/IBk8wHAlnyhHjj+hl4TSPG6USFHFMxKpEE+6angkPd+ue7gRUPkP7EFW4Laa+IaZhB3SKfKSVzHwt9n299Mv1nz0FSCQHF+YRMfGEAQlVkN/vwXIi0eAbxNJVP6x0Fso5ivdqjgfUWFQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(376002)(39850400004)(136003)(346002)(396003)(36840700001)(46966006)(6512007)(82310400003)(36756003)(956004)(86362001)(2616005)(5660300002)(8676002)(2906002)(70586007)(47076005)(8936002)(336012)(70206006)(186003)(16526019)(53546011)(83380400001)(6506007)(82740400003)(4326008)(356005)(36860700001)(478600001)(54906003)(81166007)(6862004)(6666004)(26005)(33656002)(6486002)(44832011)(316002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2021 09:41:43.3402 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: bec5dace-d9aa-4840-1c0b-08d93f991933 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT013.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3329 > On 2 Jul 2021, at 23:23, Stefano Stabellini wrot= e: >=20 > On Fri, 2 Jul 2021, Luca Fancellu wrote: >>> On 1 Jul 2021, at 18:43, Stefano Stabellini wr= ote: >>>=20 >>> On Thu, 1 Jul 2021, Luca Fancellu wrote: >>>>> On 24 Jun 2021, at 00:33, Stefano Stabellini = wrote: >>>>>=20 >>>>> On Mon, 10 May 2021, Luca Fancellu wrote: >>>>>> Modify docs/Makefile to call doxygen and generate sphinx >>>>>> html documentation given the doxygen XML output. >>>>>>=20 >>>>>> Modify docs/conf.py sphinx configuration file to setup >>>>>> the breathe extension that works as bridge between >>>>>> sphinx and doxygen. >>>>>>=20 >>>>>> Add some files to the .gitignore to ignore some >>>>>> generated files for doxygen. >>>>>>=20 >>>>>> Signed-off-by: Luca Fancellu >>>>>> --- >>>>>> .gitignore | 6 ++++++ >>>>>> docs/Makefile | 42 +++++++++++++++++++++++++++++++++++++++--- >>>>>> docs/conf.py | 48 +++++++++++++++++++++++++++++++++++++++++++++--- >>>>>> 3 files changed, 90 insertions(+), 6 deletions(-) >>>>>>=20 >>>>>> diff --git a/.gitignore b/.gitignore >>>>>> index 1c2fa1530b..d271e0ce6a 100644 >>>>>> --- a/.gitignore >>>>>> +++ b/.gitignore >>>>>> @@ -58,6 +58,12 @@ docs/man7/ >>>>>> docs/man8/ >>>>>> docs/pdf/ >>>>>> docs/txt/ >>>>>> +docs/doxygen-output >>>>>> +docs/sphinx >>>>>> +docs/xen.doxyfile >>>>>> +docs/xen.doxyfile.tmp >>>>>> +docs/xen-doxygen/doxygen_include.h >>>>>> +docs/xen-doxygen/doxygen_include.h.tmp >>>>>> extras/mini-os* >>>>>> install/* >>>>>> stubdom/*-minios-config.mk >>>>>> diff --git a/docs/Makefile b/docs/Makefile >>>>>> index 8de1efb6f5..2f784c36ce 100644 >>>>>> --- a/docs/Makefile >>>>>> +++ b/docs/Makefile >>>>>> @@ -17,6 +17,18 @@ TXTSRC-y :=3D $(sort $(shell find misc -name '*.t= xt' -print)) >>>>>>=20 >>>>>> PANDOCSRC-y :=3D $(sort $(shell find designs/ features/ misc/ proces= s/ specs/ \( -name '*.pandoc' -o -name '*.md' \) -print)) >>>>>>=20 >>>>>> +# Directory in which the doxygen documentation is created >>>>>> +# This must be kept in sync with breathe_projects value in conf.py >>>>>> +DOXYGEN_OUTPUT =3D doxygen-output >>>>>> + >>>>>> +# Doxygen input headers from xen-doxygen/doxy_input.list file >>>>>> +DOXY_LIST_SOURCES !=3D cat "xen-doxygen/doxy_input.list" >>>>>> +DOXY_LIST_SOURCES :=3D $(realpath $(addprefix $(XEN_ROOT)/,$(DOXY_L= IST_SOURCES))) >>>>=20 >>>> Hi Stefano, >>>>=20 >>>>>=20 >>>>> I cannot find exactly who is populating doxy_input.list. I can see it= is >>>>> empty in patch #6. Does it get populated during the build? >>>>=20 >>>> doxy_input.list is the only file that should be modified by the develo= per when he/she wants to add documentation >>>> for a new file to be parsed by Doxygen, in my patch about documenting = grant_tables.h you can see I add >>>> there the path =E2=80=9Cxen/include/public/grant_table.h" >>>=20 >>> OK, thanks. I missed that addition. >>>=20 >>>=20 >>>>>=20 >>>>>> +DOXY_DEPS :=3D xen.doxyfile \ >>>>>> + xen-doxygen/mainpage.md \ >>>>>> + xen-doxygen/doxygen_include.h >>>>>> + >>>>>> # Documentation targets >>>>>> $(foreach i,$(MAN_SECTIONS), \ >>>>>> $(eval DOC_MAN$(i) :=3D $(patsubst man/%.$(i),man$(i)/%.$(i), \ >>>>>> @@ -46,8 +58,28 @@ all: build >>>>>> build: html txt pdf man-pages figs >>>>>>=20 >>>>>> .PHONY: sphinx-html >>>>>> -sphinx-html: >>>>>> - sphinx-build -b html . sphinx/html >>>>>> +sphinx-html: $(DOXY_DEPS) $(DOXY_LIST_SOURCES) >>>>>> +ifneq ($(SPHINXBUILD),no) >>>>>=20 >>>>> This check on SPHINXBUILD is new, it wasn't there before. Why do we n= eed >>>>> it now? We are not really changing anything in regards to Sphinx, jus= t >>>>> adding Doxygen support. Or was it a mistake that it was missing even >>>>> before this patch? >>>>=20 >>>> Yes this is new, I saw that we didn=E2=80=99t look if sphinx was insta= lled in the system, so now we did >>>=20 >>> In that case, I think anything related to SPHINXBUILD and whether sphin= x >>> is installed or not, should be a separate patch at the beginning of the >>> series. It could be committed independently before the rest of the >>> series. When we get to this patch, SPHINXBUILD should be already there. >>=20 >> I=E2=80=99ve introduced SPHINXBUILD in this patch: [PATCH v6 5/9] docs: = add checks to configure for sphinx and doxygen, >> In your commend do you mean that you would like it to be outside this se= rie and this serie to be based on top of that one? >=20 Hi Stefano, > I totally missed patches 4 and 5. Can you please CC me to the whole > series next time? Yes, I think the script add_maintainers.pl didn=E2=80=99t add you in CC on = these patches, for the next version I will add you manually Cheers, Luca >=20 > I meant as a separate patch, like you have done in patch #5. It doesn't > necessarily need to be at the beginning of the series so what you have > already done is OK. From xen-devel-bounces@lists.xenproject.org Mon Jul 05 09:47:41 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Jul 2021 09:47:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.150013.277428 (Exim 4.92) (envelope-from ) id 1m0LCS-0007di-6g; Mon, 05 Jul 2021 09:47:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 150013.277428; Mon, 05 Jul 2021 09:47:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0LCS-0007db-3X; Mon, 05 Jul 2021 09:47:36 +0000 Received: by outflank-mailman (input) for mailman id 150013; Mon, 05 Jul 2021 09:47:34 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0LCQ-0007dV-NA for xen-devel@lists.xenproject.org; Mon, 05 Jul 2021 09:47:34 +0000 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 93fe4a2a-b445-4d1c-8f9e-0a2cbdf1354a; Mon, 05 Jul 2021 09:47:33 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 93fe4a2a-b445-4d1c-8f9e-0a2cbdf1354a DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1625478453; h=to:cc:references:from:subject:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=iUtEilgZoF8dQmmEdjYe8oevo8CDCXJko0OWxJ4UjF0=; b=QwGYiDlogq9byEMo8hpS4x6FX2gpyA9atS2AlLnvsh3DVFLEpaPYu52+ oScAUG2NSjCyvK2adrS0BpWdVPD6bojMdqgRIOjgGvbE6zclgaN+TSEdn nzHY1v3OqUTF3UDKX/giHpzZwP5Kho6Ny/9pOu4hRQTZVqyHqAd2B6tZ0 M=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: wdPBSu6NDlD1ib6zE6ZAWrajWYg5BTXeOo9a3xYPpCToVg+BkniB+8BSBHl17/Ii0nuZ3tDzvi kaAzUUOUN9jcTLsXvu+BLqVwIhjQq13ICwRZd2nQsE5fzGh4vE7+6AXeWeI5uW/RZEm1BY9OsG aCwk5WfrmP7xf5QDUis0IkNOQrQzjOZkxaAMvlKibDs5m0Gcst32eYGRm/hrTzncjmX2CfPK0q haEoTV9rqBm+6NXF5Ob6tRk8n6dY+PcV2jsoLnJNlDsLKr1ChPso+lQzwp6Zm0e03tlJugB5+7 UCg= X-SBRS: 5.1 X-MesageID: 47571795 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:N3KXM6Br1RucqonlHehHsceALOsnbusQ8zAXPh9KJiC9I/b1qy nxppkmPH/P6Qr4WBkb6LW90dq7MAzhHPlOkPUs1NaZLXTbUQ6TQr2KgrGSuwEIdxeOkdK1kJ 0QCZSWa+eAfmSS7/yKmTVQeuxIqLLskNHK9JLjJjVWPGVXgslbnndE422gYytLrWd9dPgE/d anl7F6T23KQwVnUi33PAhIY8Hz4/nw0L72ax8PABAqrCGIkDOT8bb/VzyVxA0XXT9jyaortT GtqX222oyT99WAjjPM3W7a6Jpb3PPn19t4HcSJzuwYMC/lhAqEbJloH5eCoDc2iuey70tCqq iCnz4Qe+BIr1/BdGC8phXgnyP61iw11nPkwViExVP+vM3QXlsBeol8rLMcViGcx1srvdl63q 4O9XmerYBrARTJmzm4z8TUVittilG/rRMZ4K4uZkRkIM4jgYJq3MgiFBs/KuZGIMu60vFnLA BWNrCf2B4MGmnqKUww1wJUsa6RtndaJGbMfqFNgL3N79FspgEP86Iv/r1Wop4xzuNId3B63Z WzDk1JrsAFciZEV9MxOA8+KfHHQ1AlFii8Tl56Z26XTJ06Bw== X-IronPort-AV: E=Sophos;i="5.83,325,1616472000"; d="scan'208";a="47571795" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZFAhf0F0Uu9DtQyuF8ZwpptS2bIRP0K2k2oWhl4G6ku5WzbLVycE29vrEdtMM6vcDRVZ3bS+qqNHNW9R3WKoKpW78y0ofBcu5JuQsqyTuaM3wQP5GofxJmxaBcRouoCrfMGCGVSZ/8AkNwO/KcqHQBQyds5ADmguFIKwKmZzqq61oppv/E9JzpThpLU9Z58fO/QdkJyl98hfvmUVaTPjAlFPfVmb7Pw6ycMo4OlpnJ1fintNC+LmnIe0OME7B+c92kag25Yihgsm2KHcD+cvbhCx819myJX4KZ+itBlBehYuswf/UIlSN4JSg8NGKlky+xc6DQkAGEEiHgQXQNNENg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iUtEilgZoF8dQmmEdjYe8oevo8CDCXJko0OWxJ4UjF0=; b=kHqsCQGeJwLcvtqVzXb6V3HJflwU0VUKOegrMu9tSeEXUVX4tcIvkuYwlaN/qZKQvKSFlrMBI+cq4hUgs5G2OgYsKqIWtKeDlSIujuy0ui2EEB6nRXOnYc3ef9rIXw4XBdQhp1eGTK4p2n85Ad9V36NKllsBn8quZJyMjhdVElLHkP/VTcfXp4Lq33NJOM1bUkJeeuMlb7o8lng+Bs1o6OXFk7LfHM94uIy5dU7Czx54T9gHQrqHa0OcLjYNZpRwgiuvn2ve9XgVZkZQ8o4pFBLaVV5ZDBYhd27VeOwoBnVYk6y6k/K89ySZXv9qXAn0BplEQeE/ijpKewAfbmlwAQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iUtEilgZoF8dQmmEdjYe8oevo8CDCXJko0OWxJ4UjF0=; b=tkrMWhEYj7uRfK3+Qxm+RW31AljkzoYSJxtuhn42615p0Goy6p+lw3V7uLlOODYbZVxatHmeZsPpn1rAOlBunnmROY9BHhfxqangs17Oho8Tobu/h/ej18cE9jcJO714A9hbMjgCSDDnEyJPjDOy4t97mwUNM3NpLWXpsyAj/wM= To: Olaf Hering CC: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , , Ian Jackson , Wei Liu References: <20210701095635.15648-1-olaf@aepfle.de> <20210701095635.15648-7-olaf@aepfle.de> <20210705101838.2f760ed9.olaf@aepfle.de> From: Andrew Cooper Subject: Re: [PATCH v20210701 06/40] tools: fix Python3.4 TypeError in format string Message-ID: Date: Mon, 5 Jul 2021 10:47:22 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 In-Reply-To: <20210705101838.2f760ed9.olaf@aepfle.de> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Content-Language: en-GB X-ClientProxiedBy: LO4P123CA0277.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:195::12) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9301c23e-a7e1-4570-00ab-08d93f99e737 X-MS-TrafficTypeDiagnostic: BYAPR03MB4550: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1148; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wxBaZB0NAKBFSEdHo89/g+SkfzktpZtTNqapBKJx/Gq3MPNmbtHkllB6p8dDQC6UUFBxPuW7XKRmSKTtKWLEjzS/Gqg19T2g+CfOpskwq7aVYlXVXehjJVfCUNwgYh6mLNBlcMAU9yQ/IQNU/fsSzi1drx0857gEasRTzkV6q6fTwrnwZkIFhrtvKZPTN8OoUpV7TXLjyDmG6B1x07FKX0jp4cd2cbrN4FQNNUdVN7DVIdQJ334VaMtjD/PBF/oEhkZafUs9OHlSgvrp4mXNU2ZUTy9XcMqTgLcXiioBEiX8V4plT5ozxwvZcZzCvqiLkPGtLBflXfIJox4lce4vBoEyU/LPAFFzkk8S11fC09ZWgOa3RVPOkad9xQ5SAD+Yi3NW+2e6jrdgk9bVlZdIxa0zpBti/iiaNQs1Rxk/HxKL/qz96Cl30hyx0qY6RsgnRoIXncK8WacuSdriPmhSHamRi8VUDIbg0b3i1zybDjBJGf/F1QPdh4L3bfp3HOOG3zbCYKx6UnurhRphOg32Sixu37rf2DaPnvQgOenHSKeAHgjqN9CYBQ6Se7AkdkodnQ1Blsl+MHb42l+NJB7CVLjFTvbTfPnqXtvQKLaKuqgLF/hvSSjclUdDpnGMstLddUbGY9yZqFF91Xa7VSN+vnsxDqIIHRqIhjlOkH1bmZeeYljIT26mJlONeWbyjiNroI54Jf0GEv0X/o8KlifNvHJo6DfkdNb3M7Ftk/d46ec= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(376002)(39860400002)(366004)(136003)(346002)(2906002)(31696002)(316002)(16576012)(36756003)(66946007)(54906003)(6486002)(53546011)(26005)(16526019)(8676002)(8936002)(478600001)(6666004)(38100700002)(66476007)(66556008)(186003)(956004)(31686004)(6916009)(86362001)(2616005)(4744005)(5660300002)(4326008)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?Windows-1252?Q?rs/w2KrYAUP6WVB6elX5xtdHeJaV7aWRhSMEZmP/lpGE/RsP6BesjVuh?= =?Windows-1252?Q?RJaLU03pRL5ZQwswekoh4KJ8IKSM2g+1YuqpdzQzgTRT5ZvY9/zKEx+j?= =?Windows-1252?Q?+mpnTO0Dj8DKZ2ircjCnIqp+FK2OH1GSoutRLKlrzzLf5QSuQ5Dek1MY?= =?Windows-1252?Q?+tiN2ZYvohrIfTah9ET9/LaIvd0ek/76JWBEbZ96GpglY5RlVz3Bi2I9?= =?Windows-1252?Q?waSK6tQUU9CpM784vqTpk/k3Pb4J4ld1yGzPCUZHe0cUdRd1T34+Zkq1?= =?Windows-1252?Q?C4Bo/2vZdcPWvjWVZARaa8T55ufyv3ttVRLfqAhLQQZZsbxDhEgUJCYY?= =?Windows-1252?Q?LA2GVYzYZAOWO+d1d5u3BCfGmwKSwNMggjK4nqgyFFKeKeD+g+soMADm?= =?Windows-1252?Q?RscimEMPUvlR58dsUjhkM9yyqOBqgj+fYhdVTy9OOwo+QI5iJJcWkXuW?= =?Windows-1252?Q?glUiU/Rk2NfFIexfO3grEB3GrLU9lxupGS8ibewAZ8u+NaMPtTkfVdY/?= =?Windows-1252?Q?gcSsGs/I6MzzKAKjn4EOSdNp/7xqaE/xLwL2UbWd2SvAK9Tp9SZRFYJA?= =?Windows-1252?Q?5r61JtVSpvENONQCTcAvwxyrE6k3uMgSCLU2GUsV37VsU8d4ZCPS2JW/?= =?Windows-1252?Q?MFM/Pf47bXgitb3ZKtcv6ZYR2dnXNMsCPIFvzDNrlC6rrC7+ZOSofnH3?= =?Windows-1252?Q?K5GP1rAcRTDtawhWUVXup2NFJwWwMAFa7NNrZzhEu4Z2hKIJab1VRfAj?= =?Windows-1252?Q?9sn1t/3svm4OKxKRQ8Mx+L5wsLb0nYzRsPbrOyCC0qlIJSU+32CoURdL?= =?Windows-1252?Q?XYAneuHzeG9InmfNNnuow2HMIYTJ7oopODCfLa8PUId0wEAOI+PCbYES?= =?Windows-1252?Q?dnDRF2RFSt9KouVfC2N1Wgxp7tVzUSxVFr0v4QlPGE8BSZUcN4Ycioks?= =?Windows-1252?Q?4d5riw2smOZSaFwal4fW02wr6E9aoGpLZ+lZqHJz84krZkpjra4qDH8S?= =?Windows-1252?Q?3MF+Y9KDm+UIAJrLb8hzhhTKns1LYkT4PwMwio3Jax1cbGnpgN0gHZ0d?= =?Windows-1252?Q?zs9jBGrLKB14U/jfdufyg3fgNsLMdja/KkKhg+9R4Xkl4M9Nzc02Eu1p?= =?Windows-1252?Q?AfkFwX1I1WKleOvAu8qzTfr3Cw6VFYys3+QBnDLIF1npUGvP2OJ0WoJN?= =?Windows-1252?Q?QwQBVGRc5lE4akWy8D+5mAgqkXm+gp8jgonloiAJ8SVnvzHwYmzP9HSc?= =?Windows-1252?Q?DDH1hjPdpIS7cAuqozqcE5CSVh5yT/FR/XZY9FFx/aS6Ui6Txc3CRO/x?= =?Windows-1252?Q?74vJmmqRAdKNEpnY0ff3xfX/1W3iQP7cp5q6Mr3OlhhGmmnxTpP/KQlH?= =?Windows-1252?Q?zc3boCRGXb9DteUIxu/auECxFQ8FwCgOUfxaN/Ma45ajKZ+cOjZOlQuC?= X-MS-Exchange-CrossTenant-Network-Message-Id: 9301c23e-a7e1-4570-00ab-08d93f99e737 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2021 09:47:29.3942 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fy2voBRv9jszifVhvr67A6YNSDgFTwifwpJk+u/eO9BvqNXOn/DbvzQvjLbqflKW/ogz/P6F7MhkC/06alRcdCjDxVoGTePkxPqVc/vJ3+w= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB4550 X-OriginatorOrg: citrix.com On 05/07/2021 09:18, Olaf Hering wrote: > Am Fri, 2 Jul 2021 17:39:54 +0100 > schrieb Andrew Cooper : > >> However, the % (phys, ) with the trailing comma is deliberate to work >> around a common python error, so wants to remain if you're keeping the >> %-formatting. > What error is that? >>> def p1(arg): ...=A0 =A0=A0 print("%s" % arg) >>> def p2(arg): ...=A0 =A0=A0 print("%s" % (arg, )) >>> p1("foo") foo >>> p2("foo") foo >>> p1(("foo", "bar")) Traceback (most recent call last): =A0 File "", line 1, in =A0 File "", line 2, in p1 TypeError: not all arguments converted during string formatting >>> p2(("foo", "bar")) ('foo', 'bar') The % operator has some type ambiguity with how it works.=A0 (foo, ) forces arg to be a 1-tuple as far as formatting is concerned. ~Andrew From xen-devel-bounces@lists.xenproject.org Mon Jul 05 09:52:31 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Jul 2021 09:52:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.150019.277439 (Exim 4.92) (envelope-from ) id 1m0LH1-0000YJ-Pj; Mon, 05 Jul 2021 09:52:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 150019.277439; Mon, 05 Jul 2021 09:52:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0LH1-0000YC-MV; Mon, 05 Jul 2021 09:52:19 +0000 Received: by outflank-mailman (input) for mailman id 150019; Mon, 05 Jul 2021 09:52:18 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0LH0-0000Y6-9I for xen-devel@lists.xenproject.org; Mon, 05 Jul 2021 09:52:18 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id e68924fa-086a-49a4-8478-b552487331c5; Mon, 05 Jul 2021 09:52:17 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e68924fa-086a-49a4-8478-b552487331c5 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1625478737; h=subject:to:cc:references:from:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=wBv0Ys6SYdFppmKuo9xep9r9u++Dchky4Xw4n8bKPL4=; b=Be8NBDQBNOAwTRD3WSM4apiwL8BdRbetjYyyuYCHoWZlvPkXIMvxQO6G ehZCzbbY85hGuTXVesvoGLr/DLnz8hR5hwMxuWcbXIX9aQ+gJYT7I62gE yY5L3biLwQ9/JGzJiQCSX8+9ARCaaIwRT5CGz9HrxCLa9ougNo5fskL5z Q=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: 4ZNjjD5IQ9ScxIZyWxaqYdJLHVl1GvBroQfhRI93h+dzUsVg7fapXLoaIgSXAjWMiHzo6S3xIv 43VWkX6/bpBZkKyGkZXeS8V45CpQuZN0nGOeF+JE/nw7YveZAR6YtVQkFYRY9Xuk+XTtIO6M+/ 1aetUu9fFWFlIJrdFMiG4uYyoXNwx3lUIg5P98yY0ErzU+yH8UU+bZhX1k1k98/tVz9M/Rd9Nx 2ZgzmW3gJQT8P460I6vGK2D9mCC11BqrqNBZc5L6RcJxKTTPAQSeoozxqB6nx6w43RGoqauZkG yRE= X-SBRS: 5.1 X-MesageID: 47944738 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:Xj0ma6j7s2ZirqfdkIQYAGqU33BQX2d13DAbv31ZSRFFG/FwyP rOoB1L73HJYWgqN03IwerwR5VpQRvnhPlICPoqTMmftWjdySuVxeRZjbcKrAeQYBEWmtQtsJ uINpIOdOEYbmIKzvoSgjPIaerIqePvmMvD6IuurAYOcegpUdAc0+4TMHf8LqQCfng/OXNPLu vk2iMonUvFRV0nKuCAQlUVVenKoNPG0Lj8ZwQdOhIh4A6SyRu19b/TCXGjr1UjegIK5Y1n3X nOkgT/6Knmmeq80AXg22ja6IkTsMf9y+FEGNeHhqEuW3DRY0eTFcBcso+5zXYISdKUmQ8XeR 730k8d1vFImjTsl6eO0EDQMkfboWwTAjTZuC6laDPY0LzErXQBepd8bUYzSGqH16Lm1+sMjJ 6jlljpxaa+R3n77VfAzsmNWBdwmkWup30+1eYVknxESIMbLKRctIoF4SpuYdg99Q/Bmc0a+d NVfY3hDTdtABunRmGcunMqzM2nX3w1EBvDSk8eutaN2zwTmHxi1UMXyMEWg39FrfsGOth5zv WBNr4tmKBFT8cQY644DOAdQdGvAmiIRR7XKmqdLVnuCalCMXPQrJz85qkz+YiRCdI1JVsJ6d 78uXZjxCcPkm7VeLqzNaxwg1vwqT+GLEDQI+lllu5EU5PHNc/WDRE= X-IronPort-AV: E=Sophos;i="5.83,325,1616472000"; d="scan'208";a="47944738" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SXWPcv3skpAFv0IvhqPmaf1sYlhPKmTrFji5OpnLfige1pZkQZoYarHU1deVVKR48rXUK3hfUZQWNyWjftSY0yABGR5Ea/j/fm/VfKTRlK/u6KED2FMr+YDjZNZOcfyh+lAeAybqqm4O8NwZDcEA5Q9e5JFMp9u3XIngCxgizlSSKbpbsQ3mafucZikdPRpe6/fGbdB47dUZ6hyP6yDAeSc++rj7robY8GriuwUGyvakiLCdX26en7BPu1TjDEUjNzecGX5RJy4RPG/SX4vOef6dgtlvSKJtBGvkXUhdHngDXzfmmxPHnAy1u80lmqRHLS/wcJVVTrGLe5Pgga+fbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=w6chlBY/ISf0K7dfNK7yktQk8072F0L0VK+2+ixf0Ac=; b=FnfVBi6FNR6AM8523j4vID67eUFL6OXDXG5tIUycWDXV6SNRwxBPpJCULYhHK/CcIVuxTx73dHrpHJUOm6kd5yuEiYDcFNJJjxYWmkbgmxw65rIZPjpLmacLAHwEjKIEnaTn2zCXM3MpMVZIVUNL/WzotTGFBeIQ/rIUzUGkq1QfZ9DdYO965Alb1dh8T+1ndvJzGYlAkL1C5ecp9G0XSrnlu9oirRX77KwhHW895+etp18Vsk/9bBKq4iu04+JPfav2J6W7T+GwwWdLJDEcni2rpEVI21gyGRjAgXpa90rPKf9WSPam6cfAzBuG7SDE4CBa1WS3uhnuzv4IqyS5vg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=w6chlBY/ISf0K7dfNK7yktQk8072F0L0VK+2+ixf0Ac=; b=Bo2P7iclEuMchvHQnVSX76eMldDzJ5BBmS5NpWOODpUvuci7qfLx7TTxlb6wDC4Js6rKNsOYdTtV5QzHBevpMoctGb5QWxBdDeU9SxZJV6NfWALfADTK4sX5UD/FiH7bV7tkOVRVRG4vy6k7wyomaUsxdmW/viEa5Q0uN2GUAP4= Subject: Re: [PATCH v20210701 10/40] tools: add xc_is_known_page_type to libxenctrl To: Olaf Hering CC: , Ian Jackson , Wei Liu , Juergen Gross References: <20210701095635.15648-1-olaf@aepfle.de> <20210701095635.15648-11-olaf@aepfle.de> <3c0efa9b-aaff-b4b7-0fd5-9eed32b20e01@citrix.com> <20210705102230.48a86473.olaf@aepfle.de> From: Andrew Cooper Message-ID: <8762eaaf-a8bc-430b-470d-b84f68c06b5b@citrix.com> Date: Mon, 5 Jul 2021 10:51:50 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 In-Reply-To: <20210705102230.48a86473.olaf@aepfle.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-GB X-ClientProxiedBy: LO2P265CA0178.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a::22) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a8f32f40-96ba-4866-6195-08d93f9a8790 X-MS-TrafficTypeDiagnostic: BYAPR03MB4806: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:419; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yAHxlcO0Et4vQNS8+BAN0FVIsnOqOYgTuga4G84oWzFxRkJLn3wQM2kjtnvD7ZzGy4YEhIEVkDQpR/peDQJq3e8CGERYJ9YvK5B3O1zgNyUxIApGljmknhVrOrJH7RlPkuEv8tAVahioEj8iLrp7CSpACFl00G9EWDipx2NpoMtONUDX4Z9BD4WK8KxyIzLK0Dee47c/+jWH2i8lkwzxB4XDVrGu0v44vrZcpY1q04cCZoSUmx9wNyZBfaX/y+O4+Vw4y7U9vD4gg2JZ5RkRQylTa1yG7+qV5W5ZWlsLG+21YlBObo5k+ohPBjni7YK+4EmTszBIbt+UVRV2q/DW3mNNGB4KJ4b1deyd/Mto9E9VswEPFXgMX58My1TQPNOtsgwQGdHw5OF7xHjVrAHHovjZrNimXbWKj6RpdGOdAX19rn4DVcce7eegt1gB3JNCrVqRoQNIJbLLPv7LvQuHWfnbYDDl6GF56wet777sGFVgyBsBRl3qclYYWWca4gxKcc/eaVRwNV2sKeKjw8LaokfwMsdXyzvZzzxmDjPvO3qhyfXgF5oNVS+s8K+yhdvSHfN/Zr/LXixn8FPqLKqC4g0+0F0mYl7dQOPkoJ0XDiFIeOTqQhawDDxC8s2dnSEzvhWqUrxDAijIHUw7GJvkP+bAD7JwuTW2vsaRlnDX45mBCUMlLajeHfRfCf0NyhscMNoNLSYlM+HK5ThA0OU5k6y5wLO9wv56SNF7A8B15Vo= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(366004)(376002)(39860400002)(396003)(136003)(53546011)(36756003)(8676002)(66556008)(6486002)(66946007)(66476007)(6666004)(31686004)(5660300002)(16526019)(478600001)(6916009)(4744005)(31696002)(316002)(38100700002)(16576012)(86362001)(2906002)(26005)(8936002)(186003)(4326008)(2616005)(956004)(54906003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Kys3VVFsdEZUZ1lLMXIyTjhNYVpnbjFIaEJQNThmZDcwWVpaYVJ3ZzZvek4v?= =?utf-8?B?bkNGdUZlYlBDZzBBOEE5cFg3Sk93SVB0R3R3UHk1cUlZMFdLN1dkOWdkZEd2?= =?utf-8?B?UUhJWWtJNHVRQTYyaWJsRk5BQW4wS1pLSXR5blc1ZlFWMlpuZ29reGJheGJ4?= =?utf-8?B?UVdkMnlCdjRwTnQrOHowTEVNQ1NCMzlVTVRPRDFnZitSWStHUVVLb3RYL0lC?= =?utf-8?B?NE1sNndvOWZZdUNseUFiOEhqQktZTi9OdytJa3BIZm5WeTBiZjhlWGtXZVpS?= =?utf-8?B?YytEaFhucGY2dmVUQlFPVFBjMDNIUzdNUWRaVnVOV2xIaWkzd0FDZDdVSGt2?= =?utf-8?B?b3JneVFzVW0yQ2JtQXhVbm45SDlUbDR6dU5VY2wxWG5VZWdhQ1NTdmVqbkQ3?= =?utf-8?B?czU4cnBlZGxRZzAzZCtROFBvTTB3dkVGNGxYeUtxYU9CdzU0Y0MvVGF5Tnpa?= =?utf-8?B?U2dER0JqUFpGZWU3OEZoZkFkNnkvbVROUHRJUldHMk4rRFZuU3o1aDdKVTFx?= =?utf-8?B?TUdFbFhySVBzcGJXdDZxZW1WeUZxTTFVMnNFaGFHcm8zM0d0Vy9KbXBkdlM0?= =?utf-8?B?c1MyeldzWTU3bVhpWnpJMWk1Y2pzc0tpZUJiR0loTXI4M3hFRjNQSUlzM0NE?= =?utf-8?B?Ryttd3RjcjI0dW1JMEV2ck9tQ0N4WURsQTJNdVJqeXFrK2gxNzJUZEp1MHZX?= =?utf-8?B?YnZTK3FkQ01tbkczd2IxSTVsVVByK2ZiWkl4V1Y1bjhVZHZyTWJqNTVxZGlJ?= =?utf-8?B?WWE2ckM4LzJ0T3QxUk1LN1NjTmxEL21rWUt4ZUMyZXY3Y2xNNWQ5MFlReWho?= =?utf-8?B?dFFRbk1kYXFYZ3dMeGRxQW5wNzAyTUtvTWZmNFVVREFXSkJGQVhUN2ZtOE5r?= =?utf-8?B?anVubWE5VDQ0M3MrbEtlNkJRM2FNUXZmRzFxWjJhOGtySGI1THNhdWo5TVVr?= =?utf-8?B?ZGtKWUI5Y3hIaC8ybXpZczBFNDhwWlhHYWthU0Q1azlpT0FObCtBcVhDNitq?= =?utf-8?B?L0prRnA4dy93UnR3THIxbHB4T1hHMDJESXRLUElJZlU0YzlSUngwVVpIYkQw?= =?utf-8?B?eEh0OUp3blRnQ1FSTVlXWmhwNldqY3hHWERwNFJJeXlOaytsVGIzZ2hkamdV?= =?utf-8?B?QmliSzhvSFlPWnJVL1VPSGg3VUxOTjQvSzdjRUx4REo4SzdaNUNOU1NYaFFj?= =?utf-8?B?bHBJVHlSbHRMTWtKNFFaQVRZeFJSMzY0UWtad2gwcUNuQTA5cUdBNzFBczk5?= =?utf-8?B?WVM0QVU4a1pveXc2VVB2b3NOWWl4eTRpSVVESTNPQWg2MDZydmVaRmRQRUQ3?= =?utf-8?B?M3VlcDFzbThYQXZyeXV5Q09QQ1FTZ053aGRQZ2RLTTBUMVo5a08vVDJETGZo?= =?utf-8?B?NFNHV1hwc054cjdRWW9jS3I1V0dlRlNIZm5wbGt1bzF6ak0rTE1Mc1RSTlpI?= =?utf-8?B?WmIwa0Fra2c1cGQxaFZwTjBPMU8xSHBXVnBSbldzdHpWbC94d3QvZ1hCOStV?= =?utf-8?B?RzFDRy81RzRQQ1NhY1JueU9UcCtuaDRJQ0VhbW5iOHRwZW1aSFZvUzBoSnR6?= =?utf-8?B?UEJUWkFZY3BDMC93K0Yyc1RHc0pOeldhOGJWaVprdkZ6YVJsUGg1QlN1a250?= =?utf-8?B?QWh6bXYzSGM2U0RrQkV5L1Z0MjFxOWtrS3UzL01FMWIwVkRBelpTNERZMHlX?= =?utf-8?B?eUpTOGdXWTlTN3RxMVJ2T1pNcnByaW1UOU12WEFCdTAzcFZEY2VKSUxIcXUw?= =?utf-8?Q?WuASwTv6BdlN2fWSnFA5uLpkgyRr+q0jzsdDXE8?= X-MS-Exchange-CrossTenant-Network-Message-Id: a8f32f40-96ba-4866-6195-08d93f9a8790 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2021 09:51:58.2575 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Jx2wu9ISbSxYiKsS7nC+3GHrB8KmLE+cLPp1rlf8WmAbSMuEqc9ZIx3YGK6ruOB126JCannTaZuwXQrz+asPaHf0zyT8DGiqpcTmMoQZdcM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB4806 X-OriginatorOrg: citrix.com On 05/07/2021 09:22, Olaf Hering wrote: > Am Fri, 2 Jul 2021 20:20:08 +0100 > schrieb Andrew Cooper : >>> +/* Sanitiy check for types returned by Xen */ >>> +static inline bool sr_is_known_page_type(xen_pfn_t type) >> uint32_t > Why is this better than returning 'bool'? For the parameter sorry, not the return type. All type fields are uniformly uint32_t elsewhere. > >> I can fix up everything on commit if you're happy with the suggestions. > Yes, I'm certainly fine with it. Ok - I'll put together a branch. ~Andrew From xen-devel-bounces@lists.xenproject.org Mon Jul 05 09:53:40 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Jul 2021 09:53:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.150025.277450 (Exim 4.92) (envelope-from ) id 1m0LII-0001Ee-Ak; Mon, 05 Jul 2021 09:53:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 150025.277450; Mon, 05 Jul 2021 09:53:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0LII-0001EX-6j; Mon, 05 Jul 2021 09:53:38 +0000 Received: by outflank-mailman (input) for mailman id 150025; Mon, 05 Jul 2021 09:53:36 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0LIG-0001EO-9s for xen-devel@lists.xenproject.org; Mon, 05 Jul 2021 09:53:36 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id dd028cb6-dd76-11eb-8440-12813bfff9fa; Mon, 05 Jul 2021 09:53:35 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dd028cb6-dd76-11eb-8440-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1625478815; h=subject:to:cc:references:from:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=PYPDtw6MLZ21uv8oxqQtqBSsJIFckV4tBbGj9jJKtMI=; b=JBqk9gaiqr0gBEuOQmFmwd77u9PcGKTnOxr7H8NLZVkMJbyTQv6fMZJH lE5/EsqCVUdfn7DMXV7qC3AbK9tPkzXjiUmwV411VVLRpAmhqKpBxl6+c lPdZBy06Dp7S5x1bTeU1c1UJRiHSRyOJRBKdM7413gpRCZ2HmY3GnYYBM 8=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=hardfail (body hash did not verify [final]) header.i=@citrix.onmicrosoft.com IronPort-SDR: RJJIH12niI1/DUbz45NHXMRahcvlpmHfpF4EicFekbEGSjKqG7xMPd8fcRJRFLB+tHYE767Utq R0Hpb4nQ7MX+9qs8KhBT/+xuyabzVwjmy/xZ9YDsFvSYcwHZSfPzvNW1vhpCZvzvCO6EcIPyXk aZa7cA18HUIpHuKmsgm6f+B/PO+y4xjXXP/pf/QYEylhCxOTe2kN26JUltGX2ezd25+zI6NXRa V7S/hKDmnahEmEMEOAPd55pEKgt0mYCkj1yIMGNvvJ9RBC/S0swq3Zh2WmjcDnUO6d2ndgtbDr IB0= X-SBRS: 5.1 X-MesageID: 49195818 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:q+s7fq0PxUgJKOe7u+axdwqjBVlyeYIsimQD101hICG9Lfb2qy n+ppgmPEHP5Qr5OEtApTiBUJPwJU80hqQFnrX5Wo3SIDUO2VHYUb2KiLGN/9SOIVyHygcw79 YHT0E6MqyLMbEYt7eI3ODbKadY/DDvysnB7o2/vhQdOD2CKZsQiDuRYjzrYnGeLzM2Z6bReq Dsg/av6wDQAkj+Oa+Adwg4tqX41pH2vaOjRSRDKw8s6QGIgz/twLnmEyKA1hNbdz9U278t/U XMjgS8v8yYwr+G4y6Z81WWw4VdmdPnxNcGLMuQivINIjGprgqzfoxuV5CLoThwiuCy71QBls XKvn4bTotOwkKUWlvwjQrm2gHm3jprwWTl00WkjXzqptG8bC4mCuJa7LgpMSfx2g4FhpVRwa hL12WWu958FhXbhhnw4NDOSlVDile0m3w/iuQe5kYvEbf2UIUh6LD3wXklVKvpREnBmcca+a hVfYDhDc9tABGnhyuzhBgo/DTENU5DbCtvQSA5y4eoOnZt7SlEJnAjtbsid0E7hdoAoql/lp D525tT5cdzp+8tHOhA7bQ6MIaK4lKke2OEDIvEGyWYKEhAAQOUl6LK X-IronPort-AV: E=Sophos;i="5.83,325,1616472000"; d="scan'208";a="49195818" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=F397DwiyIw4lI82I8wJmw93aaSl2ky6jBug4BmUmtukaAw12OUk1pake2oVkUJjlekELrxX6uPmWYT61CTM7seNiuPtGzrT7S5AnoubH00Yo5b1zbuNf0s6y1EiGAoMBxj22Ib/2ciAL/xY9GFrxwW8bQzuMwnuofc6b/qGNP3HnED7kk+Djg6WvnUPHVNhpjium6d6M10mM82N88Nb0R/Vbi0Wx/Whl3o3jN+B+UFx4IijQudhYneN4bQFY5KY24/JduP0GaCW7rRxPdsv7BRfbxpHnYCjQdX4nP0hNIrPkcJKz1V+ovTWGg4iM6n9/UBMPXgo0wl5sdgx+/1/Pgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rGHLu1ry1POJGU3WUjTWuDM+pYHXRzmMY7QF6rI9q9A=; b=KR9U8greMHT0d9PDh0T444bsAhJK6FeuItDCnrW5zW2Y2d7673Hsoh6IZv9wSTDYIM5lD1htBY2R0FuBBG4f25g6z9iHB24Sk71s/Poj2sPBLSllVgLypqS66dZTI79UzKGQEYrJvV3a+H2qtAXjYV8uhG0mlFQpS2p5BYSMdJ0wAas6uPtrITwNQ/408bhOAEex4fFtW0fEpNB1Y/XoLE72/BRsIyhqjfc9RbhZ++q01F+Eww9OvoUt2Lo9ovV+EhFqU2PlV1n84tuWWUX4jNmoze2nLtEZvXaIb4TKjyKN/DOECD1t0fcHeg1uzjyW4wEAPDBDHeBrNYSm/klAuQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rGHLu1ry1POJGU3WUjTWuDM+pYHXRzmMY7QF6rI9q9A=; b=hoxRypP7Ig9uTbjGg/3V5N/QwZ/GIAnB1PZuD2bN3yX8LXZ8ce+L5JoAzA/761MFpmadxZyEskyyPlQ/YpGtXGutTgMBtSewzOZrVFYW5KNdXl4kKy0Bem/bP6uwz6NlbHcelD29MtePrDot5tgLc8s7Ed4wJdtyGHWmXehuV0g= Subject: Re: [PATCH v20210701 11/40] tools: use sr_is_known_page_type To: Olaf Hering CC: , Juergen Gross , Ian Jackson , Wei Liu References: <20210701095635.15648-1-olaf@aepfle.de> <20210701095635.15648-12-olaf@aepfle.de> <20210705102505.41712140.olaf@aepfle.de> From: Andrew Cooper Message-ID: <2c390d97-aa12-5cff-1e21-43c9cd29f317@citrix.com> Date: Mon, 5 Jul 2021 10:53:25 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 In-Reply-To: <20210705102505.41712140.olaf@aepfle.de> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Content-Language: en-GB X-ClientProxiedBy: LO2P265CA0059.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:60::23) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 090e2d53-0d1a-4e59-6d9b-08d93f9abf57 X-MS-TrafficTypeDiagnostic: BYAPR03MB4806: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7219; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QX/HV6eZJf6Otbn/LWD0VTJlCvlxwnWQnQaph9XV6RDUaSycwYnkX81dHo5XQToYII6DkoyXC8WrHAD9Vv0oXnxT2j0v/eyistiEUwGXHy9KOAa664dtbGLSKMg0I3j2EOBAVvbhchw6ANTVzBLU1u8fKMPsNI3i4jcgztwTkvEjpwRL2Ix08Ejb7MbXVYjnBXm9u3KSJK7HDyGh2/IzchBWxj0Z5CyHL+rJIa3rja4ix9FFSfgI4FFktHCW1EDga1dslC+shh/TxI6616EN+Ds44pDUnqHhGfZLudFQ0cG+wphi4OyvhRzzQAKE+wVrUfktdotqVSv8CVK5nv6e6LaeYR01AcrhA9yGJBc5txFdC2jD/GHhchGws4lg07O3KRrioY6+bUGWR9aCqkQZpQ8LLvfoDL5t0mJGdFigeyTT+Cd0rIHfA2J2/g39swE4hXV28axihvfwI8klxFJ6Usq+A34yEMUJcUVgDJgKEqGhMnE7/jXjKa64Mkm92YmjG813N5qe26k/px4cZSeVU6LRb55ljRvWqs10HP9uPnHCFY6q5sDeZMOnYnXe+OR7uqb8hC0gLGsoP/N9/uib8xCN0Ts8VSmQXw4C4cgzV8hBb8sD2K+rKYN3D1JzIiXnKgaym1jKJ0N6UQIEVqhD4/m/6yYKwI6Pei0JPnd4e8vPj2CoHGjNQ8JYu/LzVyGBdHcxG5ZWt90cfOCTxPFsti8VjY10kI6gaFClMczJJjA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(366004)(376002)(39860400002)(396003)(136003)(53546011)(36756003)(8676002)(66556008)(6486002)(66946007)(66476007)(6666004)(31686004)(5660300002)(16526019)(478600001)(6916009)(4744005)(31696002)(316002)(38100700002)(16576012)(86362001)(2906002)(26005)(8936002)(186003)(4326008)(2616005)(956004)(54906003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?Windows-1252?Q?hsBoy/wnfnKxrkEa5+5WG3yvuif+krGqRNFAC33fdK717IlVO95F4VBf?= =?Windows-1252?Q?uJQQbexzYSxMJah68q9KlVdJJzzHb9Nw6XYJsWeNiTL9ua4wuIJ2tprr?= =?Windows-1252?Q?D5UYHU+wfebfV1++J1vJV7bqiMTDW3bnoPScEqElvkVlDjHqA1DtHsSv?= =?Windows-1252?Q?9R/6K8aYQKl760aew7rL3VnB2fUnpoigASmIcLUpgDcDvCXp4O0HafdX?= =?Windows-1252?Q?prPhtaBc86Jbrp4ovjA2nVio1CXhF/FN/tImEvBtJrD9PhzTiN65H/mx?= =?Windows-1252?Q?IHUewHJ6QWr9jL/noIF5eMsaaup72mowm4m3ZJFEwUjEOZhqHOmCHvcL?= =?Windows-1252?Q?dnmByaqaaO+bZHZPLnNw2jFu6gX8UVjgvw6mE1fgpmWclNfxcJLqMPo3?= =?Windows-1252?Q?+au7Ixw2hGEFXAFo1+oh5At22gxgglOSwdOtszWcS9JRBacQraFFaqe+?= =?Windows-1252?Q?Loi85mFR2y7Q+oh7thaU4bed6MsVy9dMy930TwtC8KOV2i1UQ+VQYbv5?= =?Windows-1252?Q?ONqiPa6eh+PSVjx/MgOmAt9YLY5Fqi1KJhoqF7u1AeDVmE2+MWsxLR/h?= =?Windows-1252?Q?Fql9XndNE5fPvFgJP/v16V/CRxlTczDK8FJPNp/1VMNC/Oz+7Tl0sHF5?= =?Windows-1252?Q?vNJVBHQAF4Uu1WZ+vxYxMTiytmJxlVMFQxcrcjjIvEEk1V9w6YdAPIWY?= =?Windows-1252?Q?6feBQmvxfdsvZGDDr3PTUCC1fJIY9t2sR6ljgk0ANd+Zzn2NTk8JEMOa?= =?Windows-1252?Q?HEAWPZQSoT9od7TFKASB6aJ0UGZn5iR1e6lufU5J/uaMx3WHsxPukhM8?= =?Windows-1252?Q?vUnnOo92VdYAp7xkFJa3reoXK8GnSSEt6xtjQN/ZBLiJ7H/nG1BJLeR7?= =?Windows-1252?Q?UfT8T0QgMkd2sGwtHInxr0U6Qk5q2ZZYCaSiZSN+BA42G6ebT5R2iq3+?= =?Windows-1252?Q?GJlFhGTv2stpEmnVbFd3MyTtlqlrozDTfExc6KcQ9o2MHPyNIakAW/yF?= =?Windows-1252?Q?Z9GaCdhcU5NLAowHVVnXT8jPJdMW8z9+GsQnB/saRVReZFJ2+RCWKgTx?= =?Windows-1252?Q?4V76GL6ZAqI7TUKyyZDrcSs3Gvs2dbHSdQWGkcTmRowkeAn8cjfialWA?= =?Windows-1252?Q?KDdLw0ofDbonOK+afCx8DQXvsAJvdEsALyQgLVuhG6UrhOBpdQdAzgnI?= =?Windows-1252?Q?24GcWFdHYOAVwpdRevhjv0DY5+270b2ftHr38pRZZ5ahLXxSsUUozn2l?= =?Windows-1252?Q?6cHG+BnTd+TlLcLoIOOQ4NeWdZ0A/6VsAz0kAH+i9E8fXla2iBPtok5X?= =?Windows-1252?Q?fGH9EjBOmtLKm0uaXuyuU/kroFpRvcTex6qos/+ZjIeINYQDeu1dO6TM?= =?Windows-1252?Q?jZnSTedktn4xSWHztRXdARPQacbB8XBPCyCWrmtsEWxyqOmbIsVcTcbR?= X-MS-Exchange-CrossTenant-Network-Message-Id: 090e2d53-0d1a-4e59-6d9b-08d93f9abf57 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2021 09:53:31.8226 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: cw2JbI+o+fdL5sBCkLa6rt9KR67eCjAf3hRdTDmgGyrzweJqlTpf1Y9Gba/ZNuzL3ov42WzYTih0ibl3/1cPhadj+BldMmgvuaQfXYT7zpQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB4806 X-OriginatorOrg: citrix.com On 05/07/2021 09:25, Olaf Hering wrote: > Am Fri, 2 Jul 2021 20:27:21 +0100 > schrieb Andrew Cooper : > >> Any reason this isn't folded into the previous patch, like your >> subsequent two page type helper patches are? > I think I wanted to separate this for simpler review, but I forgot to split the followup change as well. All patches are largely mechanical changes. It's easier to review together, rather than split, because you can only judge the correctness of the new helper in terms of the code it is replacing. ~Andrew From xen-devel-bounces@lists.xenproject.org Mon Jul 05 09:54:15 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Jul 2021 09:54:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.150030.277461 (Exim 4.92) (envelope-from ) id 1m0LIt-0001nM-JY; Mon, 05 Jul 2021 09:54:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 150030.277461; Mon, 05 Jul 2021 09:54:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0LIt-0001nF-GO; Mon, 05 Jul 2021 09:54:15 +0000 Received: by outflank-mailman (input) for mailman id 150030; Mon, 05 Jul 2021 09:54:15 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0LIt-0001n8-5K for xen-devel@lists.xenproject.org; Mon, 05 Jul 2021 09:54:15 +0000 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id f41ec073-dd76-11eb-8440-12813bfff9fa; Mon, 05 Jul 2021 09:54:14 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f41ec073-dd76-11eb-8440-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1625478853; h=subject:to:cc:references:from:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=/9C459icUbgkKjFDP9Oja5oWJTL1qOW2C24GH7Zbt7c=; b=YivnDXo+hnArbdDQbHgzWaMi4/PU9XxXG5Wl4nnDkBtb5xkO9z7epgva DVTis1LIxGVYb8T8fuwk0waU0CD3rLXGjLrj9Vt4xFGY5CSzCBCzBWbV+ pwvxDjmWBoqnMySoLb4tn5o7vr+e51ros9NLhvPGsLbDDklpUBdjGxSgt k=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: Me6upqrVxExRVWC/yWJPKlk+nOeVk/G8vvhNnTrL9ou/2duBElbyHHnbLOIVqRaII2SpT+/nJU heSb1nTpOkQxcJd7ePda4odd2CB9r8arnt2KbWnaLe7t8dpBYhPlsgOI8oplca9raquosOUXaj TMlXUk/KqntWDXSYKFsoHgmCqYhc0gE33vycUMQGKZ+Y/750FY1bBRCAieqjnFr4IW+Pe0LA91 ND/oZQ8i1LE7N/0QHb/M7xGcARFcav/y8uJg9XBng4w7pgxrmp1Y/7dBdWu8twymqwnmaM5ucm rEI= X-SBRS: 5.1 X-MesageID: 47633831 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:suIryKDkeaPV13PlHehHsceALOsnbusQ8zAXPh9KJiC9I/b1qy nxppkmPH/P6Qr4WBkb6LS90dq7MAzhHPlOkPUs1NaZLXTbUQ6TQr2KgrGSuwEIdxeOkNK1kJ 0QCZSWa+eAfmSS7/yKmTVQeuxIqLLskNHK9JLjJjVWPGZXgslbnndE422gYy9LrWd9dP8E/d anl7F6T23KQwVnUi33PAhIY8Hz4/nw0L72ax8PABAqrCGIkDOT8bb/VzyVxA0XXT9jyaortT GtqX222oyT99WAjjPM3W7a6Jpb3PPn19t4HcSJzuwYMC/lhAqEbJloH5eCoDc2iuey70tCqq iCnz4Qe+BIr1/BdGC8phXgnyP61iw11nPkwViExVP+vM3QXlsBeol8rLMcViGcx1srvdl63q 4O9XmerYBrARTJmzm4z8TUVittilG/rRMZ4K4uZkRkIM4jgYJq3MgiFBs/KuZGIMu60vFnLA BWNrCf2B4MGmnqKUww1wJUsa6RtndaJGbMfqFNgL3N79FspgEP86Iv/r1Wop4xzuNId3B63Z WzDk1JrsAFciZEV9MxOA8+KfHHQ1AlFii8Tl56Z26XTJ06Bw== X-IronPort-AV: E=Sophos;i="5.83,325,1616472000"; d="scan'208";a="47633831" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cBG7RNrtl206LrkSGlx7H8ihLbbXqqBxsLnQAkKW99B8RytaxPrXC1fleaKQDWVYcEdCt4RqtZLEyZq12EXfdBYyMtf2t6phJMc4Y4SkBUS5AK9IjDu0gcuez/Dd/xCIyaFP/++TOmEm6kXbcTiaYic0QYk3y/yBc0n/nBTk3yUdrZNzSXtjWlmOR8RwMxv5/4TYE73+bFcTw0EUsTizfnpQcPwkbjEyUl9GlbjvQyjRYBoniLDdmIMeBw5fntJkurnV0Uzc4LaXnNtgxuR2E1j0awGLOv5et5zgasTEa47qKgUnwo0OLTV01kmfPyRYHm2NzSdIYxdTMRt6DslqXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/9C459icUbgkKjFDP9Oja5oWJTL1qOW2C24GH7Zbt7c=; b=C1RoFX2O3s2ta1jjmYG9Ov5GKQcl3brpmRIBGxEIoLe1ja+YU5Vynz37rGDi/2fSitvEyQFnEEoV7PpP5lrlJIU3SvfatU12nxBALadeb6LkXNo20TZyXGSPWAWaOC9lnhIZcSU/afhFzQKIh9nRi70ofR/663wY/yfgrNzRQ/7ArLqjoFM1QPza5vKnSWKjGhYyWzeJV3B0M2JvWH1qTvimNCI/By6Ctw96tEXPZa0bJc8Ybtil7S5astUKN63YALjia7Q6Fr94aUaH9S3CxR1xyY8kxY6LFiqKfQtOOZMsXOuEmq+qq0wC/H4jurJlVgEGgFtpY429KXrFRDsYUg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/9C459icUbgkKjFDP9Oja5oWJTL1qOW2C24GH7Zbt7c=; b=pXswqywguVTdgT0YNtoDe6aE0is/m8tocaK3Yzn6Q8eAvW0HcvqLTnLJCq7sXiVguEd37eD+MAXqAVF1Z45n65lbYnJiO/j1C8+fnf7zZz/nSCsxGb++u5Yy5OhLN3OFLyJTLoKzWR0ofdeicCwuE2SHvkzyV+AooBADd9419So= Subject: Re: [PATCH v20210701 12/40] tools: unify type checking for data pfns in migration stream To: Olaf Hering CC: , Ian Jackson , Wei Liu , Juergen Gross References: <20210701095635.15648-1-olaf@aepfle.de> <20210701095635.15648-13-olaf@aepfle.de> <9db50e05-233b-e279-307d-548fc23d0115@citrix.com> <20210705105917.132793c9.olaf@aepfle.de> From: Andrew Cooper Message-ID: <23314695-f84f-59c0-dcb0-62f553efc62e@citrix.com> Date: Mon, 5 Jul 2021 10:53:59 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 In-Reply-To: <20210705105917.132793c9.olaf@aepfle.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-GB X-ClientProxiedBy: LO2P265CA0071.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:60::35) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 84d40e02-31c8-491d-9b16-08d93f9ad38d X-MS-TrafficTypeDiagnostic: BYAPR03MB4806: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:5797; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +FRUNX2/3iZK/A8W4aGPzrhPmgTpQN3SRLUbSD4eXK5A/kD2SBkNlfDi7tzTLBlpd9DN0GTcppDOU5ItIDnvrwP/EbOdEvHh83/UUBIejGaFFktAjsmUv35lvl3bp2jnnK+HD4B3a6fLXDRz8FY3i8z4B0R81hQe6WQGmiqh/sG/10D9oot20GxiS3TWWWMucXor352BKGwctfWJYuntdFFniccSAKO45EDEvf7RMzAShakN2mlF7T08hoBocR40CC9c4rXEb/h1ZpgzhgB4mvnNqSLmKIiBFzm4NDiA83rWjF6DWCkiWYLVCCETttrghN0uT5nf2xjyfTas3WZ55eIg7c5Q5P7HE2/EzniZOPTmidFlgAWW75Kgz9FfLrmyAFto9WooUIucWcWlwZ5Y8/n7cDlIv1j0mDkJKHwHhRQDX96e1XmvDmNf9/tVDqvvGvhrdvs6XlAZCRL90cjcOZwc6txx4aQq8f/WYGEfdznlmYJ634pNH1C6YX3X9DWtqKATtyiAkryT4ztYpVMVilU2fHpR2TNm0BHEsFO8c2xPv4vZcdYu9fqng27vd3uK3aHJrd3N8O7yXeao7saIg8QSxdNH6I0p2j0gT/VYi7siAmwywIxXzrO5Tylrevn5iRz0Sag02RP+XsuoI3J06ya+gAKYX1qYR0RdkquOy0T6L3LzjbaEK0u1+wqtcPquZ705C3y8QiDwwqjvcWZTAHA+EPo5sbwA25aUjrFLV+U= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(366004)(376002)(39860400002)(396003)(136003)(53546011)(36756003)(8676002)(66556008)(6486002)(66946007)(66476007)(6666004)(31686004)(5660300002)(16526019)(478600001)(6916009)(4744005)(31696002)(316002)(38100700002)(16576012)(86362001)(2906002)(26005)(8936002)(186003)(4326008)(2616005)(956004)(54906003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Z3p3UzhFc3NIWFdxbE5nUjhGbnVWanJMQzcxNUlsbmc2RVdNNkNYdnRrUWk4?= =?utf-8?B?ZndTM0tZMzRBWXIzdFM2L2puOXA3M0hMbXBnd3Fha1VEMnprSkhhYzZqRUJm?= =?utf-8?B?VmQyWFJ4TWVTUy93SHJVVU95RFQ4eS8wRFV0WUVYNHN4SzVrTk1rMzlBc1JK?= =?utf-8?B?NVAxODk0d2s1ODNMUDVhak5iWlRuSjMvTXoxeE5UYjlNbEVmL1ZldWRIWWFo?= =?utf-8?B?RE5aMk40eGhmZnZqOXZtSFZHd2VqVUVlVjViRDNsbkN2dFNHYWF0M3lyM0FX?= =?utf-8?B?eTFVZ2l0cUxOWDJjckF5VTlXaWg5TExYQXE4T0ZsYVpSVXdIOC9Pc1Z5c2lG?= =?utf-8?B?UjZxSXdNVGZmQkU5TjFiTE5nbmIzbjZEeWxHdmwxbjlLbE9UaC9zdUhrbXZl?= =?utf-8?B?VjJQTFRWdCtsdjh0ZVUzcEdJTFpxOUtOWExjckZ2amhjSkN4YzJlaDRXek9q?= =?utf-8?B?ZlpldURSUEFCOVdNdjF6czlMaVAyL1lnRDJrd3dZK2czVFpFL2hUcWF1R3d6?= =?utf-8?B?TS9FSFB4OUxmMTN3NTdLcHA3RDloVURWWTYyUElaWDJwSXNVUVNoRlFvZW5Q?= =?utf-8?B?R1ZzZG01aUJpN2ZQYi9mWUxidFRXQ09NOWRXTnE1UjdhV1pETjM2Y0Mvb2w2?= =?utf-8?B?YWdlbTNlQTFFUVJzVW5pQ3d5b2VPTzd4RkxpcGo1SXM4c245VHJXa2t0RkJ4?= =?utf-8?B?LzNEUnFudWIrRXJNUkhHS0IvelhKN2NFdiszYjNXOGdGMlBpRHYzK3liSUpP?= =?utf-8?B?YXN0RUNTVlRVanRlL2p2RithUTRlVEZqaGdnL3ZDSTdNaVlacGxhMENZSVdx?= =?utf-8?B?dTZ0azI1ckZVRzlMRDBLY3hiVVVvazk2VmFsZjJPZVl4UGJCWWRRZnJ6Ni9O?= =?utf-8?B?UFovSnR0ekZsOVlEL09LRzNkTWN6Q3VNQmZ0UVA3SkZXUUt3R2ZOQmJJL2NO?= =?utf-8?B?RTQ0VE1JbDBjbzI0SHA0ZkpoSkhTT2Jsc0FSUzJGclVTWTRPK005NEZyVWZz?= =?utf-8?B?eFBUSDhSZ1NTY1B2VE5RNGc0WC94RjVLYi8rUWwrNm0wcTJyTDQwWjdQZ2ZS?= =?utf-8?B?Yk52WUY5UmJGTW9WYW53Y1NWN0tqL29uZGxSdldlT0U0WTd4b3ZVbnFtWWla?= =?utf-8?B?VHRkQmNOd1pyMUdQR3RVZU1XT2RKYXI1cG9rUkM1MHhXM2VQbWtmOWduRFFL?= =?utf-8?B?Rm15eEhJaFJhWUxHZTlZRmx0NHhnNUlTcXFNWHA0MFJvaUxEOW9QQ09HR2gv?= =?utf-8?B?ODJkY2I2MCs4U2xrOHcveW1GNVQ5d1BlUXZCTkJweWZVZ0ladGxkNTBFeW1i?= =?utf-8?B?TncyaWxBTi9qaC9PamdEYWlVNmQ1SWcxTkczdEM0Wmo0T2E5RVhwZCt6NVl3?= =?utf-8?B?YUMzWjUyWHBZSzcvQ3pOOWg0OUFHajdUUUtrcmZzYUFHRnhadkcvelliTWxG?= =?utf-8?B?Y0tteTlhdWY4dGJjdXhLRCtIQUM5dlNzbUZKamUzSUxOeklIejZyR0h0eUNO?= =?utf-8?B?QWllTDcxWDdlMTFFa2t1YzlHRVFodml4TWlXblJPRThOSnNiV1dmOHh5ZzUx?= =?utf-8?B?QlZuUzJkMjBuQTJSQUVVeDJ3b1RHWU5qY2NleXhnNXJqSjB3RkxhUXE0UUpQ?= =?utf-8?B?N3RqS2Q2RTU5Z1d2NTduZWdLQXRaVjg0TzhHNTh6L2FvbmJHM3ZZSmZnN1pI?= =?utf-8?B?QzlPSC94RTg4WmJ4VGhld0RXb2drL1V5T3FxaDBzNnNXNFlVWlg5SnlMQWEy?= =?utf-8?Q?t6YGs1gQMjdNxqaiTVzbH4JgX+Kls+1b+ddlrX7?= X-MS-Exchange-CrossTenant-Network-Message-Id: 84d40e02-31c8-491d-9b16-08d93f9ad38d X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2021 09:54:05.7361 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: z8I5rgl0tIRrYNsfnn9/lbUZ0pkcUmZwqlla9+x9pWIq7a2t99Wn44sHAoNLMJd2QzVykRYCF5NFH4kZXl2OnRpAWMor6YiefHipI7il2u0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB4806 X-OriginatorOrg: citrix.com On 05/07/2021 09:59, Olaf Hering wrote: > Am Fri, 2 Jul 2021 20:43:13 +0100 > schrieb Andrew Cooper : > >> Anyone adding a new page type is going to have to audit/edit each of >> these helpers.  I think it would be better to write all the true cases >> explicitly. > You mean the check if a page has data or needs to be populated should look like sr_is_known_page_type, where each known variant is listed? Yes.  I think that is a safer approach overall. ~Andrew From xen-devel-bounces@lists.xenproject.org Mon Jul 05 10:03:15 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Jul 2021 10:03:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.150049.277492 (Exim 4.92) (envelope-from ) id 1m0LR6-0003e5-QM; Mon, 05 Jul 2021 10:02:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 150049.277492; Mon, 05 Jul 2021 10:02:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0LR6-0003dy-Mh; Mon, 05 Jul 2021 10:02:44 +0000 Received: by outflank-mailman (input) for mailman id 150049; Mon, 05 Jul 2021 10:02:43 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0LR5-0003ds-0g for xen-devel@lists.xen.org; Mon, 05 Jul 2021 10:02:43 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (unknown [40.107.15.88]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id ca0f0aac-8aba-467e-b2fb-a8dd77029a55; Mon, 05 Jul 2021 10:02:39 +0000 (UTC) Received: from AM6P191CA0007.EURP191.PROD.OUTLOOK.COM (2603:10a6:209:8b::20) by VI1PR0801MB1773.eurprd08.prod.outlook.com (2603:10a6:800:5c::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.23; Mon, 5 Jul 2021 10:02:36 +0000 Received: from VE1EUR03FT012.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:8b:cafe::2f) by AM6P191CA0007.outlook.office365.com (2603:10a6:209:8b::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.21 via Frontend Transport; Mon, 5 Jul 2021 10:02:35 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT012.mail.protection.outlook.com (10.152.18.211) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.22 via Frontend Transport; Mon, 5 Jul 2021 10:02:35 +0000 Received: ("Tessian outbound 3362253f4878:v97"); Mon, 05 Jul 2021 10:02:34 +0000 Received: from f771a61da606.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 598829BA-C7D1-4D66-8DD4-4D17EE04D847.1; Mon, 05 Jul 2021 10:02:24 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f771a61da606.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 05 Jul 2021 10:02:24 +0000 Received: from DB9PR08MB6857.eurprd08.prod.outlook.com (2603:10a6:10:2a2::7) by DB8PR08MB4169.eurprd08.prod.outlook.com (2603:10a6:10:ab::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.22; Mon, 5 Jul 2021 10:02:23 +0000 Received: from DB9PR08MB6857.eurprd08.prod.outlook.com ([fe80::c45:7e0b:231:b050]) by DB9PR08MB6857.eurprd08.prod.outlook.com ([fe80::c45:7e0b:231:b050%7]) with mapi id 15.20.4287.033; Mon, 5 Jul 2021 10:02:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ca0f0aac-8aba-467e-b2fb-a8dd77029a55 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=t8WYC9/PLQjP8kV7Y7mA5BpRxtBZYzCL9by16pMHtvs=; b=vMBNPkZ6BHUMvroIKsXVRyKd6+DjoyukhTRTPYDAI0ko/xilhAib6HsFP+F78OdFHAtukRpmT857cVWT/XS0FsR6eFfiSGcIKCp7gaW5mx81QaxFRast0UmQbsDgN5Ln4/gRsaiMKmT6U6hezuNIYdm2UV1OLAGwHEXwDb7qjB4= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.xen.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.xen.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cWE7GCZ69Ll1otZozqLduWrrN0gVIr/IiAhwSSjObRj/0hUJuMgdNmVqFgULgrNxbosSuwxj/9UoNTfI6T+NLZoUu/A5WQyoClEldaBsnDOy3SJ/gYLyloNZ6sdzXbEs76SbzOl4xV6mUmZd0w+I6DCeGuknI0yXRrUzjX6dG/gDsPWhAecyHd3F4u7OMXZ1LIsIZFR3zUFTd2vef3pFPQNg+vmVrpv0r2U2ktWagHqYZ2KDqlgnEBf3+UDKrg6Kus9PjOgdDb1ndkEumSh8OWb8GbXCya6q3Hbu7MIedXt1jxm9jYqDOGbQ3agFVrl7C7paAqprSXhJFwyQa9Fkbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=t8WYC9/PLQjP8kV7Y7mA5BpRxtBZYzCL9by16pMHtvs=; b=TLlGWgXBmi9+0bx3c4Mx6bLnSrWjiVHsjVYbrhE7tGuTRc+DOO2G85sjqL/v2P7uQ4rd39n0ZlVjmMSEKTlNTzxKhb2xqtKQfDTrfihjdnArAqeuBiMzwaDR1zl6FryzkDR3U6//JzcBVfdgnpt9yUV+JrkcgQ5MkxujI6HHXl24KNFg4I9eYGEBHssZU/QDlQtTaQHGp5yzm1GU3oPXWroiizkMw8VFJMmeBqtbhHxPx5xZMQ3vyDh9bY6UAF2paaydexujzj2vE/9C2F+6jLz+qmq/NG9Oa3fHjE+ly0BAzN6NMc2ewGX5A0UKxe29E4cnD9PvUVN7uhM4UVinfg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=t8WYC9/PLQjP8kV7Y7mA5BpRxtBZYzCL9by16pMHtvs=; b=vMBNPkZ6BHUMvroIKsXVRyKd6+DjoyukhTRTPYDAI0ko/xilhAib6HsFP+F78OdFHAtukRpmT857cVWT/XS0FsR6eFfiSGcIKCp7gaW5mx81QaxFRast0UmQbsDgN5Ln4/gRsaiMKmT6U6hezuNIYdm2UV1OLAGwHEXwDb7qjB4= From: Wei Chen To: Stefano Stabellini , "will@kernel.org" , "julien.thierry.kdev@gmail.com" CC: "kvm@vger.kernel.org" , "xen-devel@lists.xen.org" , "jean-philippe@linaro.org" , Julien Grall , Andre Przywara , Marc Zyngier , Oleksandr Tyshchenko Subject: RE: [Kvmtool] Some thoughts on using kvmtool Virtio for Xen Thread-Topic: [Kvmtool] Some thoughts on using kvmtool Virtio for Xen Thread-Index: Addhq3Jd+FbZaJt0R6WdbgcPW7X96wLnXxMAAQ3e1FA= Date: Mon, 5 Jul 2021 10:02:23 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: E5171D5CC7165840B76CBCBC8CE87F61.0 x-checkrecipientchecked: true Authentication-Results-Original: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=arm.com; x-originating-ip: [203.126.0.111] x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: 94b232bb-1a39-4df6-5bc5-08d93f9c039d x-ms-traffictypediagnostic: DB8PR08MB4169:|VI1PR0801MB1773: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: sGKq2nrpyGMZ1JxXBugecHXfFPqV0Tysr0YO2AKejse5aFUZPT1yXjQeWgHlDuyQlwjXBqR438WKTesK+rL+5TBIh+n0m6roTt2vKloVcNNT8rTX1VFDsyVgQkHv/Ddgwzzj43R/9k6C5QKAYmvlr86wvZ6SMQc0lIyl2Ti8Duy3a/oR+CugfFrPgMto8vaSyu97ntHz0LrMxQRpliGDBLEKOjKSzUkyXxUMZnUcYWsFz/d2wz5zi1PxZSfV3Uqilo6CdvliVAFWcyot8pK58mcs3eUlUdb1/20+9qaClL6Erhrc2uz8GPugzRcWjWrU8HX1lKSSvAiiSeg7iKBcvNYUk7+9Z9p1dKuSbpw0eAObj4Iy2OS1PpSOqUsATlhurLjxJ3DXiVW8hmhftJHHNggeZ3BzGuxlk8qnlC/rXSjGg1nlKRgMtEozaNaAOOmRV/N5al2So5leTcqI3xgn6aE9bdwDEnN9joXWPFaYiW27r35C1ZlejBEpQufVNdcPs+Oo1ooJNWFucd8rSZIrPveE/HEPHfkO1q4B39M8YOE5m76iOyiR8YTXPIy+I1hvD8gcgrh3vh3SaAN4pM9D0xHMDvv9vfx59GcUhQ+2fIUpf091dNZ3QwU87TzhsocW6Qw3+3JOIT+amh1HkDqxsR6gsEEeskuKgS7TcEdtlWbP26boe6vw6g4J8xagspA6c03pt9Uaa7ThkWa4Dx3NwkULq6J6tzuFE1t6wHjATeCH1fAp8RbbjB1UvoxzTnqlA0crSxhUxeX7EG6Cu2BaJA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB9PR08MB6857.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(366004)(376002)(346002)(39850400004)(396003)(83380400001)(966005)(4326008)(5660300002)(9686003)(8936002)(71200400001)(316002)(33656002)(66476007)(2906002)(76116006)(64756008)(66556008)(66946007)(55016002)(7696005)(478600001)(6506007)(110136005)(122000001)(54906003)(86362001)(53546011)(52536014)(30864003)(26005)(66446008)(8676002)(38100700002)(186003);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?gb2312?B?R21sL21nSmprZ0FpZUdLcXVET3ZOeDIwVG5DZHhEdEU3T09xMUtFZzlpV2h1?= =?gb2312?B?cmNDRlVudDlnVVhmalc0N1E4d2cyazRVRUpzb3QrYkpyb0JiZ2FDVFNKRTdr?= =?gb2312?B?bG5VZ3MyYS9xSytPU0RCcEE5cUJZR2NWdE42aDRPSnZDdGRIRlV1SDNEODNT?= =?gb2312?B?ZUlkaE1BME5rY1ZrVTJmYW1pMTZnZ2RjTDM0dk1oUnMwOWRZNGpFTkxNTnlH?= =?gb2312?B?MlBiNDlHVEdKOUxVdWdpbC9YaEl6N1BWL1l3OG9RVWR6aFNoSlM0NDA5U2Uv?= =?gb2312?B?NUJLQXZVNzlVeVlsUGFOQ2RUSE1MeWM0eUxSUWtVMzN5cEFOa3NLNzFXUlVX?= =?gb2312?B?VURFeHJCMkVuMzhWbmxGc3dPZFphSS82Zk0yaFIrUXErb09Eak9WcjdwaHFo?= =?gb2312?B?NnVraTU2UHRlZVUyeEF5aW0rUTlPa0V2UklXNU4yUmdHMHF5dHgwdE1TNzdI?= =?gb2312?B?YS91SlVoWG1IeittbWI3WHhscTdxSmpIbndHWTd4ZzNVWDlRUVJIa1lvWnZx?= =?gb2312?B?dVNFY3ZVNDV1K2lHdGZVQ2pLTk5jWXNsd2l0bXZaQmwxUTlRSFErcENCN2tw?= =?gb2312?B?UXV6dlovZEtzcTVPRkJnN01idXNRRFRFVC96dnc2WmRqSkUrazJiZW5MeXlW?= =?gb2312?B?WncvTksrU0pjdjNFZldSQlJUUjUwMVAxVUR1SHpac3ZMVWJTVDZXZit5M1cx?= =?gb2312?B?Q2g1KzU3K05ZVjhRdkJ4K20rOVFWcDEzeStpM0RqZW9VdXMwakVDRUFYUWo0?= =?gb2312?B?WkNXaXVPV2FwUm02TUZWTGd4R1dGcG91UjQzODBreWxzNnlKcjdtRXk4aC9N?= =?gb2312?B?MytvTDluSVBMRU8yMHZUMThyd2hyVHNPZU5Qek1LdDFZeVM4SnlhSWozZ1cy?= =?gb2312?B?NG41UlNVV0E3cG5wWmJVdG1hKytaTHZxV1c2NzR2NVVDRytBRXRSK1RaeTNP?= =?gb2312?B?U3lhTzVwU1NtVGFoN1oxdEFSYlU1c2dyNEtLMXVSSDVheGNqZEhDb0FDMDFF?= =?gb2312?B?eDI1c0dZT3AxOWRRS1JCbEczY09RUFRmc1RHMlpncEpYTEJ0TmRaZGFDamE4?= =?gb2312?B?Y3ZtRmhSWXJPYjJES3E4d21KMTNNWXhmcWlLckhUSFZTeEppQW5rdUhKc1Z6?= =?gb2312?B?WWdVNnRMcisyaXhtTFo0UDYxSVBkcWhvL0dZYzkxNDRQcUk5TGZXL0xEUVF4?= =?gb2312?B?TkNGMVBFc0t5VHR3MUZXRHF4b2hDK1Q3NHppcFhrdk0yMlpkVXRqWUFIK1RG?= =?gb2312?B?dk5NL0FuZ25HZHBxWXFsVnE2aHlGUitKNWVpQ2hwWnM5dTRVSlh6dSswZjRY?= =?gb2312?B?Q0pjeXErVi83a21wbS9NQlBtRGNRUnBYQlJPaFFYQUdRU1ZDMDZoVUN3clVR?= =?gb2312?B?Q0sybTBNK2wxYUpMWnZGQis2RjNIcnRGSnUwWHRhUXJYWkJ5ZlBCZUNEN2hQ?= =?gb2312?B?SUp3dFVXRlg4bzZDY2J1ckszM1RQd3pzUk5RWlJzbjhVK1dUN0pmS1RJTDJl?= =?gb2312?B?eWcwcG9HWG1zM01ha3dqUnRXODVSbGdmWEdqcVFPb2ltTEE5YmZXa2RMR2gr?= =?gb2312?B?RFgzR3ZRQ3c1TUxkUHI0RXVpT0pwNnhKdlNNS2RMdnZ3VFZ6QmtTVmtvemNo?= =?gb2312?B?Tzl6UE01bTUreEV4aW1DS210ZHZtZmFRNXdVUkVrdkJNM21sVHlHM1RPMlJP?= =?gb2312?B?ZWQ5NTRQbFlUNlVjRzNrb0tlRW96UXhuY1U1T2ZHY3dyOWdRZm4xb2g1bjBF?= =?gb2312?Q?mnFtGrx3etZSfdjJp6P7XC/m5msldca+YCBd8/Y?= Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB4169 Original-Authentication-Results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT012.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: cbf13193-67d2-424d-6f0e-08d93f9bfc4f X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hlV+6KejMd/yMnH+HcF6p+PxTTmz0BA/L34qX9k4YQ3qkdUhddYhgWHOMjHzJuRlYnLgEuTUZCTdT9BblEQZikDyMfJgjSRqTYgVCUJKAWjiOGd20f/cHmCLlnXpA72kscLkwV9Jty5uV+JOfP3BWmwHrDaQAE4TJerUFTNj6fGN7O2FDOywLoT/csW2DVbGtAL8YMNBwRGsXi7MULJSBUro1VvQagKERngvtavjTwtI9OuNs73QJUrbQ5sL1d3MjFGvwUX8LNjqqoAoL/fL8Gun4zT/CEJg4vcVMbNzUEjsWmn0k9GIVOR0C1DnSDVyQ91ohlFPOeJwS96vGyNtSjXMMhQiUH1YNZwtAby/qRQB2o2o5sBwbQU9uqCMyx4qShqJSuN374qQF9/H4HLBd9LGI0d8kFUjd5coqpjSyuGuOCgHTEXRYba7l3fPDxKuaoiT0ZF6aqiBLxu+l9ISX5+EYNIyhQxAh3DM7b0L8upFR2KC8Tq7MgfWGBCmGGXjQCuNJ3hJRuqekN2rn6EAwZOe9V9P6rdxKFu2wAUlaucJv01cO4dP412DaJkusjRr5XLEHd0pdLW43rf/hXghaZK30vrkLTiXsmfK5jJCJoYXoU/Bikaok4SY7IgR7TWmHfhZC/ZgRw66i3bG+9U/xkdRHFBCTaBGcVE98zgr8IuHhFPK+Wf7YRKGT9JoqIfsGwCv/1Q4Vwbioo8Gid8ARmSFw9WMeutup+/j1R+QMMyKLkgDBn0XER9h/p16dN+KmIgGU9/3kh35CpCBmeSJqOmkVWAnaRXKIt0rB1mfQT8ubvrDzXQbkh7CttZtTuoGhdPy3INzIA5X1PRM1rGJQQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(376002)(396003)(39850400004)(136003)(346002)(36840700001)(46966006)(83380400001)(47076005)(966005)(5660300002)(478600001)(8936002)(8676002)(30864003)(52536014)(70206006)(70586007)(4326008)(82310400003)(36860700001)(107886003)(55016002)(9686003)(336012)(316002)(110136005)(54906003)(53546011)(6506007)(26005)(186003)(82740400003)(86362001)(7696005)(356005)(81166007)(33656002)(2906002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2021 10:02:35.6009 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 94b232bb-1a39-4df6-5bc5-08d93f9c039d X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT012.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0801MB1773 SGkgU3RlZmFubywNCg0KVGhhbmtzIGZvciB5b3VyIGNvbW1lbnRzLg0KDQo+IC0tLS0tT3JpZ2lu YWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IFN0ZWZhbm8gU3RhYmVsbGluaSA8c3N0YWJlbGxpbmlA a2VybmVsLm9yZz4NCj4gU2VudDogMjAyMcTqNtTCMzDI1SA4OjQzDQo+IFRvOiB3aWxsQGtlcm5l bC5vcmc7IGp1bGllbi50aGllcnJ5LmtkZXZAZ21haWwuY29tOyBXZWkgQ2hlbg0KPiA8V2VpLkNo ZW5AYXJtLmNvbT4NCj4gQ2M6IGt2bUB2Z2VyLmtlcm5lbC5vcmc7IHhlbi1kZXZlbEBsaXN0cy54 ZW4ub3JnOyBqZWFuLXBoaWxpcHBlQGxpbmFyby5vcmc7DQo+IEp1bGllbiBHcmFsbCA8anVsaWVu QHhlbi5vcmc+OyBBbmRyZSBQcnp5d2FyYSA8QW5kcmUuUHJ6eXdhcmFAYXJtLmNvbT47DQo+IE1h cmMgWnluZ2llciA8bWF6QGtlcm5lbC5vcmc+OyBTdGVmYW5vIFN0YWJlbGxpbmkgPHNzdGFiZWxs aW5pQGtlcm5lbC5vcmc+Ow0KPiBPbGVrc2FuZHIgVHlzaGNoZW5rbyA8T2xla3NhbmRyX1R5c2hj aGVua29AZXBhbS5jb20+DQo+IFN1YmplY3Q6IFJlOiBbS3ZtdG9vbF0gU29tZSB0aG91Z2h0cyBv biB1c2luZyBrdm10b29sIFZpcnRpbyBmb3IgWGVuDQo+DQo+IEhpIFdlaSwNCj4NCj4gU29ycnkg Zm9yIHRoZSBsYXRlIHJlcGx5Lg0KPg0KPg0KPiBPbiBUdWUsIDE1IEp1biAyMDIxLCBXZWkgQ2hl biB3cm90ZToNCj4gPiBIaSwNCj4gPg0KPiA+IEkgaGF2ZSBzb21lIHRob3VnaHRzIG9mIHVzaW5n IGt2bXRvb2wgVmlydGlvIGltcGxlbWVudGF0aW9uDQo+ID4gZm9yIFhlbi4gSSBjb3BpZWQgbXkg bWFya2Rvd24gZmlsZSB0byB0aGlzIGVtYWlsLiBJZiB5b3UgaGF2ZQ0KPiA+IHRpbWUsIGNvdWxk IHlvdSBwbGVhc2UgaGVscCBtZSByZXZpZXcgaXQ/DQo+ID4NCj4gPiBBbnkgZmVlZGJhY2sgaXMg d2VsY29tZSENCj4gPg0KPiA+ICMgU29tZSB0aG91Z2h0cyBvbiB1c2luZyBrdm10b29sIFZpcnRp byBmb3IgWGVuDQo+ID4gIyMgQmFja2dyb3VuZA0KPiA+DQo+ID4gWGVuIGNvbW11bml0eSBpcyB3 b3JraW5nIG9uIGFkZGluZyBWSVJUSU8gY2FwYWJpbGl0eSB0byBYZW4uIEFuZCB3ZSdyZQ0KPiB3 b3JraW5nDQo+ID4gb24gVklSVElPIGJhY2tlbmQgb2YgWGVuLiBCdXQgZXhjZXB0IFFFTVUgY2Fu IHN1cHBvcnQgdmlydGlvLW5ldCBmb3INCj4geDg2LXhlbiwNCj4gPiB0aGVyZSBpcyBub3QgYW55 IFZJUlRJTyBiYWNrZW5kIGNhbiBzdXBwb3J0IFhlbi4gQmVjYXVzZSBvZiB0aGUNCj4gY29tbXVu aXR5J3MNCj4gPiBzdHJvbmcgdm9pY2Ugb2YgT3V0LW9mLVFFTVUsIHdlIHdhbnQgdG8gZmluZCBh IGxpZ2h0IHdlaWdodCBWSVJUSU8NCj4gYmFja2VuZCB0bw0KPiA+IHN1cHBvcnQgWGVuLg0KPiA+ DQo+ID4gV2UgaGF2ZSBhbiBpZGVhIG9mIHV0aWxpemluZyB0aGUgdmlydGlvIGltcGxlbWVudGF0 b24gb2Yga3ZtdG9vbCBmb3IgWGVuLg0KPiBBbmQNCj4gPiBXZSBrbm93IHRoZXJlIHdhcyBzb21l IGFncmVlbWVudCB0aGF0IGt2bXRvb2wgd29uJ3QgdHJ5IHRvIGJlIGEgZnVsbA0KPiBRRU1VDQo+ ID4gYWx0ZXJuYXRpdmUuIFNvIHdlIGhhdmUgd3JpdHRlbiB0d28gcHJvcG9zYWxzIGluIGZvbGxv d2luZyBjb250ZW50IGZvcg0KPiA+IGNvbW11bml0aWVzIHRvIGRpc2N1c3MgaW4gcHVibGljOg0K PiA+DQo+ID4gIyMgUHJvcG9zYWxzDQo+ID4gIyMjIDEuIEludHJvZHVjZSBhIG5ldyAiZG0tb25s eSIgY29tbWFuZA0KPiA+IDEuIEludHJvZHVjZSBhIG5ldyAiZG0tb25seSIgY29tbWFuZCB0byBw cm92aWRlIGEgcHVyZSBkZXZpY2UgbW9kZWwgbW9kZS4NCj4gSW4NCj4gPiAgICB0aGlzIG1vZGUs IGt2bXRvb2wgb25seSBoYW5kbGVzIElPIHJlcXVlc3QuIFZNIGNyZWF0aW9uIGFuZA0KPiBpbml0 aWFsaXphdGlvbg0KPiA+ICAgIHdpbGwgYmUgYnlwYXNzZWQuDQo+ID4NCj4gPiAgICAgKiBXZSB3 aWxsIHJld29yayB0aGUgaW50ZXJmYWNlIGJldHdlZW4gdGhlIHZpcnRpbyBjb2RlIGFuZCB0aGUg cmVzdA0KPiBvZg0KPiA+ICAgICBrdm10b29sLCB0byB1c2UganVzdCB0aGUgbWluaW1hbCBzZXQg b2YgaW5mb3JtYXRpb24uIEF0IHRoZSBlbmQsDQo+IHRoZXJlDQo+ID4gICAgIHdvdWxkIGJlIE1N SU8gYWNjZXNzZXMgYW5kIHNoYXJlZCBtZW1vcnkgdGhhdCBjb250cm9sIHRoZSBkZXZpY2UNCj4g bW9kZWwsDQo+ID4gICAgIHNvIHRoYXQgY291bGQgYmUgYWJzdHJhY3RlZCB0byBkbyBhd2F5IHdp dGggYW55IEtWTSBzcGVjaWZpY3MgYXQgYWxsLg0KPiBJZg0KPiA+ICAgICB0aGlzIGlzIHdvcmth YmxlLCB3ZSB3aWxsIHNlbmQgdGhlIGZpcnN0IHNldCBvZiBwYXRjaGVzIHRvIGludHJvZHVjZQ0K PiB0aGlzDQo+ID4gICAgIGludGVyZmFjZSwgYW5kIGFkYXB0IHRoZSBleGlzdGluZyBrdm10b29s IHRvIGl0LiBUaGVuIGxhdGVyIHdlIHdpbGwNCj4gY2FuDQo+ID4gICAgIGFkZCBYZW4gc3VwcG9y dCBvbiB0b3Agb2YgaXQuDQo+ID4NCj4gPiAgICAgQWJvdXQgWGVuIHN1cHBvcnQsIHdlIHdpbGwg ZGV0ZWN0IHRoZSBwcmVzZW5jZSBvZiBYZW4gbGlicmFyaWVzLA0KPiBhbHNvDQo+ID4gICAgIGFs bG93IHBlb3BsZSB0byBpZ25vcmUgdGhlbSwgYXMga3ZtdG9sbCBkbyB3aXRoIG9wdGlvbmFsIGZl YXR1cmVzDQo+IGxpa2UNCj4gPiAgICAgbGlieiBvciBsaWJhaW8uDQo+ID4NCj4gPiAgICAgSWRl YWx5LCB3ZSB3YW50IHRvIG1vdmUgYWxsIGNvZGUgcmVwbHlpbmcgb24gWGVuIGxpYnJhcmllcyB0 byBhIHNldA0KPiBvZg0KPiA+ICAgICBuZXcgZmlsZXMuIEluIHRoaXMgY2FzZSwgdGhlcyBmaWxl cyBjYW4gb25seSBiZSBjb21waWxlZCB3aGVuIFhlbg0KPiA+ICAgICBsaWJyYXJpZXMgYXJlIGRl dGVjdGVkLiBCdXQgaWYgd2UgY2FuJ3QgZGVjb3VwbGUgdGhpcyBjb2RlDQo+IGNvbXBsZXRlbHks DQo+ID4gICAgIHdlIG1heSBpbnRyb2R1Y2UgYSBiaXQgb2YgI2lmZGVmcyB0byBwcm90ZWN0IHRo aXMgY29kZS4NCj4gPg0KPiA+ICAgICBJZiBrdm0gb3Igb3RoZXIgVk1NIGRvIG5vdCBuZWVkICJk bS1vbmx5IiBtb2RlLiBPciAiZG0tb25seSIgY2FuIG5vdA0KPiA+ICAgICB3b3JrIHdpdGhvdXQg WGVuIGxpYnJhcmllcy4gV2Ugd2lsbCBtYWtlICJkbS1vbmx5IiBjb21tYW5kIGRlcGVuZHMNCj4g b24NCj4gPiAgICAgdGhlIHByZXNlbmNlIG9mIFhlbiBsaWJyYXJpZXMuDQo+ID4NCj4gPiAgICAg U28gYSBub3JtYWwgY29tcGlsZSAod2l0aG91dCB0aGUgWGVuIGxpYnJhcmllcyBpbnN0YWxsZWQp IHdvdWxkDQo+IGNyZWF0ZQ0KPiA+ICAgICBhIGJpbmFyeSBhcyBjbG9zZSBhcyBwb3NzaWJsZSB0 byB0aGUgY3VycmVudCBjb2RlLCBhbmQgb25seSB0aGUNCj4gcGVvcGxlDQo+ID4gICAgIHdobyBo YXZpbmcgWGVuIGxpYnJhcmllcyBpbnN0YWxsZWQgd291bGQgZXZlciBnZW5lcmF0ZSBhICJkbS1v bmx5Ig0KPiA+ICAgICBjYXBhYmxlIGt2bXRvb2wuDQo+ID4NCj4gPiAjIyMgMi4gQWJzdHJhY3Qg a3ZtdG9vbCB2aXJ0aW8gaW1wbGVtZW50YXRpb24gYXMgYSBsaWJyYXJ5DQo+ID4gMS4gQWRkIGEg a3ZtdG9vbCBNYWtlZmlsZSB0YXJnZXQgdG8gZ2VuZXJhdGUgYSB2aXJ0aW8gbGlicmFyeS4gSW4g dGhpcw0KPiA+ICAgIHNjZW5hcmlvLCBub3QganVzdCBYZW4sIGJ1dCBhbnkgcHJvamVjdCBlbHNl IHdhbnQgdG8gcHJvdmlkZSBhDQo+ID4gICAgdXNlcnNwYWNlIHZpcnRpbyBiYWNrZW5kIHNlcnZp Y2UgY2FuIGxpbmsgdG8gdGhpcyB2aXJ0aW8gbGlicmFyaXMuDQo+ID4gICAgVGhlc2UgdXNlcnMg d291bGQgYmVuZWZpdCBmcm9tIHRoZSBWSVJUSU8gaW1wbGVtZW50YXRpb24gb2Yga3ZtdG9vbA0K PiA+ICAgIGFuZCB3aWxsIHBhcnRpY2lwYXRlIGluIGltcHJvdmVtZW50cywgdXBncmFkZXMsIGFu ZCBtYWludGVuYW5jZSBvZg0KPiA+ICAgIHRoZSBWSVJUSU8gbGlicmFyaWVzLg0KPiA+DQo+ID4g ICAgICogSW4gdGhpcyBjYXNlLCBYZW4gcGFydCBjb2RlIHdpbGwgbm90IHVwc3RyZWFtIHRvIGt2 bXRvb2wgcmVwbywNCj4gPiAgICAgICBpdCB3b3VsZCB0aGVuIGJlIG5hdHVyYWwgcGFydHMgb2Yg dGhlIHhlbiByZXBvLCBpbiB4ZW4vdG9vbHMgb3INCj4gPiAgICAgICBtYWludGFpbmVkIGluIG90 aGVyIHJlcG8uDQo+ID4NCj4gPiAgICAgICBXZSB3aWxsIGhhdmUgYSBjb21wbGV0ZWx5IHNlcGFy YXRlIFZJUlRJTyBiYWNrZW5kIGZvciBYZW4sIGp1c3QNCj4gPiAgICAgICBsaW5raW5nIHRvIGt2 bXRvb2wncyBWSVJUSU8gbGlicmFyeS4NCj4gPg0KPiA+ICAgICAqIFRoZSBtYWluIGNoYW5nZXMg b2Yga3ZtdG9vbCB3b3VsZCBiZToNCj4gPiAgICAgICAgIDEuIFN0aWxsIG5lZWQgdG8gcmV3b3Jr IHRoZSBpbnRlcmZhY2UgYmV0d2VlbiB0aGUgdmlydGlvIGNvZGUNCj4gPiAgICAgICAgICAgIGFu ZCB0aGUgcmVzdCBvZiBrdm10b29sLCB0byBhYnN0cmFjdCB0aGUgd2hvbGUgdmlydGlvDQo+ID4g ICAgICAgICAgICBpbXBsZW1lbnRhdGlvbiBpbnRvIGEgbGlicmFyeQ0KPiA+ICAgICAgICAgMi4g TW9kaWZ5IGN1cnJlbnQgYnVpbGQgc3lzdGVtIHRvIGFkZCBhIG5ldyB2aXJ0aW8gbGlicmFyeQ0K PiB0YXJnZXQuDQo+DQo+DQo+IEkgZG9uJ3QgcmVhbGx5IGhhdmUgYSBwcmVmZXJlbmNlIGJldHdl ZW4gdGhlIHR3by4NCj4NCj4gRnJvbSBteSBwYXN0IGV4cGVyaWVuY2Ugd2l0aCBYZW4gZW5hYmxl bWVudCBpbiBRRU1VLCBJIGNhbiBzYXkgdGhhdCB0aGUNCj4gWGVuIHBhcnQgb2YgcmVjZWl2aW5n IElPIGVtdWxhdGlvbiByZXF1ZXN0cyBpcyBhY3R1YWxseSBwcmV0dHkgbWluaW1hbC4NCg0KWWVz LCB3ZSBoYXZlIGRvbmUgc29tZSBwcm90b3R5cGluZywgYW5kIHRoZSBjb2RlIG9mIFhlbiByZWNl aXZlIElPUkVRDQpzdXBwb3J0IGNhbiBiZSBpbXBsZW1lbnRlZCBpbiBhIHNlcGFyYXRlIG5ldyBm aWxlIHdpdGhvdXQgaW52YXNpb24gaW50bw0KdGhlIGV4aXN0aW5nIGt2bXRvb2wuDQoNClRoZSBw b2ludCBpcyB0aGF0IHRoZSBkZXZpY2UgaW1wbGVtZW50YXRpb24gY2FsbHMgdGhlIGh5cGVydmlz b3IgaW50ZXJmYWNlcw0KdG8gaGFuZGxlIHRoZXNlIElPUkVRcywgYW5kIGlzIGN1cnJlbnRseSB0 aWdodGx5IGNvdXBsZWQgdG8gTGludXgtS1ZNIGluIHRoZQ0KaW1wbGVtZW50YXRpb24gb2YgZWFj aCBkZXZpY2UuIFdpdGhvdXQgc29tZSBhYnN0cmFjdCB3b3JrLCB0aGVzZSBhZGFwdGF0aW9ucw0K Y2FuIGxlYWQgdG8gbW9yZSBpbnRydXNpdmUgbW9kaWZpY2F0aW9ucy4NCg0KPiBTZWUgYXMgYSBy ZWZlcmVuY2UNCj4gaHR0cHM6Ly9naXRodWIuY29tL3FlbXUvcWVtdS9ibG9iLzEzZDVmODdjYzNi OTRiZmNjYzUwMTE0MmRmNGE3YjEyZmVlM2E2ZTcNCj4gL2h3L2kzODYveGVuL3hlbi1odm0uYyNM MTE2My4NCg0KPiBUaGUgbW9kaWZpY2F0aW9ucyB0byByZXdvcmsgdGhlIGludGVybmFsIGludGVy ZmFjZXMgdGhhdCB5b3UgbGlzdGVkDQo+IGJlbG93IGFyZSBmYXIgbW9yZSAiaW50ZXJlc3Rpbmci IHRoYW4gdGhlIGNvZGUgbmVjZXNzYXJ5IHRvIHJlY2VpdmUNCj4gZW11bGF0aW9uIHJlcXVlc3Rz IGZyb20gWGVuLg0KPg0KDQpJJ20gZ2xhZCB0byBoZWFyIHRoYXQgOiApDQoNCj4gU28gaXQgbG9v a3MgbGlrZSBvcHRpb24tMSB3b3VsZCBiZSBsZXNzIGVmZm9ydHMgYW5kIGZld2VyIGNvZGUgY2hh bmdlcw0KPiBvdmVyYWxsIHRvIGt2bXRvb2xzLiBPcHRpb24tMiBpcyBtb3JlIHdvcmsuIFRoZSBs aWJyYXJ5IGNvdWxkIGJlIG5pY2UgdG8NCj4gaGF2ZSBidXQgdGhlbiB3ZSB3b3VsZCBoYXZlIHRv IGJlIHZlcnkgY2FyZWZ1bCBhYm91dCB0aGUgQVBJL0FCSSwNCj4gY29tcGF0aWJpbGl0eSwgZXRj Lg0KPg0KPiBXaWxsIERlYWNvbiBhbmQgSnVsaWVuIFRoaWVycnkgbWlnaHQgaGF2ZSBhbiBvcGlu aW9uLg0KPg0KPg0KDQpMb29raW5nIGZvcndhcmQgdG8gV2lsbCBhbmQgSnVsaWVuJ3MgY29tbWVu dHMuDQoNCj4NCj4gPiAjIyBSZXdvcmtpbmcgdGhlIGludGVyZmFjZSBpcyB0aGUgY29tbW9uIHdv cmsgZm9yIGFib3ZlIHByb3Bvc2Fscw0KPiA+ICoqSW4ga3ZtdG9vbCwgb25lIHZpcnR1YWwgZGV2 aWNlIGNhbiBiZSBzZXBhcmF0ZWQgaW50byB0aHJlZSBsYXllcnM6KioNCj4gPg0KPiA+IC0gQSBk ZXZpY2UgdHlwZSBsYXllciB0byBwcm92aWRlIGFuIGFic3RyYWN0DQo+ID4gICAgIC0gUHJvdmlk ZSBpbnRlcmZhY2UgdG8gY29sbGVjdCBhbmQgc3RvcmUgZGV2aWNlIGNvbmZpZ3VyYXRpb24uDQo+ ID4gICAgICAgICBVc2luZyBibG9jayBkZXZpY2UgYXMgYW4gZXhhbXBsZSwga3ZtdG9vbCBpcyB1 c2luZyBkaXNrX2ltYWdlIHRvDQo+ID4gICAgICAgICAtICBjb2xsZWN0IGFuZCBzdG9yZSBkaXNr IHBhcmFtZXRlcnMgbGlrZToNCj4gPiAgICAgICAgICAgICAtICBiYWNrZW5kIGltYWdlIGZvcm1h dDogcmF3LCBxY293IG9yIGJsb2NrIGRldmljZQ0KPiA+ICAgICAgICAgICAgIC0gIGJhY2tlbmQg YmxvY2sgZGV2aWNlIG9yIGZpbGUgaW1hZ2UgcGF0aA0KPiA+ICAgICAgICAgICAgIC0gIFJlYWRv bmx5LCBkaXJlY3QgYW5kIGV0Yw0KPiA+ICAgICAtIFByb3ZpZGUgb3BlcmF0aW9ucyB0byBpbnRl cmFjdCB3aXRoIHJlYWwgYmFja2VuZCBkZXZpY2VzIG9yDQo+IHNlcnZpY2VzOg0KPiA+ICAgICAg ICAgLSBwcm92aWRlIGJhY2tlbmQgZGV2aWNlIG9wZXJhdGlvbnM6DQo+ID4gICAgICAgICAgICAg LSBibG9jayBkZXZpY2Ugb3BlcmF0aW9ucw0KPiA+ICAgICAgICAgICAgIC0gcmF3IGltYWdlIG9w ZXJhdGlvbnMNCj4gPiAgICAgICAgICAgICAtIHFjb3cgaW1hZ2Ugb3BlcmF0aW9ucw0KPiA+IC0g SHlwZXJ2aXNvciBpbnRlcmZhY2VzDQo+ID4gICAgIC0gR3Vlc3QgbWVtb3J5IG1hcHBpbmcgYW5k IHVubWFwcGluZyBpbnRlcmZhY2VzDQo+ID4gICAgIC0gVmlydHVhbCBkZXZpY2UgcmVnaXN0ZXIg aW50ZXJmYWNlDQo+ID4gICAgICAgICAtIE1NSU8vUElPIHNwYWNlIHJlZ2lzdGVyDQo+ID4gICAg ICAgICAtIElSUSByZWdpc3Rlcg0KPiA+ICAgICAtIFZpcnR1YWwgSVJRIGluamVjdCBpbnRlcmZh Y2UNCj4gPiAgICAgLSBIeXBlcnZpc29yIGV2ZW50ZmQgaW50ZXJmYWNlDQo+DQo+IFRoZSAiaHlw ZXJ2aXNvciBpbnRlcmZhY2VzIiBhcmUgdGhlIG9uZXMgdGhhdCBhcmUgbW9zdCBpbnRlcmVzdGlu ZyBhcyB3ZQ0KPiBuZWVkIGFuIGFsdGVybmF0aXZlIGltcGxlbWVudGF0aW9uIGZvciBYZW4gZm9y IGVhY2ggb2YgdGhlbS4gVGhpcyBpcw0KPiB0aGUgcGFydCB0aGF0IHdhcyBhIGJpdCBtb3JlIGRl bGljYXRlIHdoZW4gd2UgYWRkZWQgWGVuIHN1cHBvcnQgdG8gUUVNVS4NCj4gRXNwZWNpYWxseSB0 aGUgbWVtb3J5IG1hcHBpbmcgYW5kIHVubWFwcGluZy4gQWxsIGRvYWJsZSBidXQgd2UgbmVlZA0K PiBwcm9wZXIgYWJzdHJhY3Rpb25zLg0KPg0KDQpZZXMuIEd1ZXN0IG1lbW9yeSBtYXBwaW5nIGFu ZCB1bm1hcHBpbmcsIGlmIHdlIHVzZSBvcHRpb24jMSwgdGhpcyB3aWxsIGJlIGENCmEgYmlnIGNo YW5nZSBpbnRyb2R1Y2VkIGluIEt2bXRvb2wuIFNpbmNlIExpbnV4LUtWTSBndWVzdCBtZW1vcnkg aW4ga3ZtdG9vbA0KaXMgZmxhdCBtYXBwZWQgaW4gYWR2YW5jZSwgaXQgZG9lcyBub3QgcmVxdWly ZSBkeW5hbWljIEd1ZXN0IG1lbW9yeSBtYXBwaW5nDQphbmQgdW5tYXBwaW5nLiBBIHByb3BlciBh YnN0cmFjdCBpbnRlcmZhY2UgY2FuIGJyaWRnZSB0aGlzIGdhcC4NCg0KPg0KPiA+IC0gQW4gaW1w bGVtZW50YXRpb24gbGF5ZXIgdG8gaGFuZGxlIGd1ZXN0IElPIHJlcXVlc3QuDQo+ID4gICAgIC0g S3ZtdG9vbCBwcm92aWRlcyB2aXJ0dWFsIGRldmljZXMgZm9yIGd1ZXN0LiBTb21lIHZpcnR1YWwg ZGV2aWNlcw0KPiB0d28NCj4gPiAgICAgICBraW5kcyBvZiBpbXBsZW1lbnRhdGlvbnM6DQo+ID4g ICAgICAgICAtIFZJUlRJTyBpbXBsZW1lbnRhdGlvbg0KPiA+ICAgICAgICAgLSBSZWFsIGhhcmR3 YXJlIGVtdWxhdGlvbg0KPiA+DQo+ID4gRm9yIGV4YW1wbGUsIGt2bXRvb2wgY29uc29sZSBoYXMg dmlydGlvIGNvbnNvbGUgYW5kIDgyNTAgc2VyaWFsIHR3bw0KPiBraW5kcw0KPiA+IG9mIGltcGxl bWVudGF0aW9ucy4gVGhlc2UgaW1wbGVtZW50YXRpb24gZGVwZW5kcyBvbiBkZXZpY2UgdHlwZQ0K PiBwYXJhbWV0ZXJzDQo+ID4gdG8gY3JlYXRlIGRldmljZXMsIGFuZCBkZXBlbmRzIG9uIGRldmlj ZSB0eXBlIG9wcyB0byBmb3J3YXJkIGRhdGENCj4gZnJvbS90bw0KPiA+IHJlYWwgZGV2aWNlLiBB bmQgdGhlIGltcGxlbWVudGF0aW9uIHdpbGwgaW52b2tlIGh5cGVydmlzb3IgaW50ZXJmYWNlcyB0 bw0KPiA+IG1hcC91bm1hcCByZXNvdXJjZXMgYW5kIG5vdGlmeSBndWVzdC4NCj4gPg0KPiA+IElu IHRoZSBjdXJyZW50IGt2bXRvb2wgY29kZSwgdGhlIGJvdW5kYXJpZXMgYmV0d2VlbiB0aGVzZSB0 aHJlZSBsYXllcnMNCj4gYXJlDQo+ID4gcmVsYXRpdmVseSBjbGVhciwgYnV0IHRoZXJlIGFyZSBh IGZldyBwaWVjZXMgb2YgY29kZSB0aGF0IGFyZSBzb21ld2hhdA0KPiA+IGludGVybGVhdmVkLCBm b3IgZXhhbXBsZToNCj4gPiAtIEluIHZpcnRpb19ibGtfX2luaXQoLi4uKSBmdW5jdGlvbiwgdGhl IGNvZGUgd2lsbCB1c2UgZGlza19pbWFnZQ0KPiBkaXJlY3RseS4NCj4gPiAgIFRoaXMgZGF0YSBp cyBrdm10b29sIHNwZWNpZmllZC4gSWYgd2Ugd2FudCB0byBtYWtlIFZJUlRJTw0KPiBpbXBsZW1l bnRhdGlvbg0KPiA+ICAgYmVjb21lIGh5cGVydmlzb3IgYWdub3N0aWMuIFN1Y2gga2luZCBvZiBj b2RlIHNob3VsZCBiZSBtb3ZlZCB0byBvdGhlcg0KPiA+ICAgcGxhY2UuIE9yIHdlIGp1c3Qga2Vl cCBjb2RlIGZyb20gdmlydGlvX2Jsa19faW5pdF9vbmUoLi4uKSBpbiB2aXJ0aW8NCj4gYmxvY2sN Cj4gPiAgIGltcGxlbWVudGF0aW9uLCBidXQga2VlcCB2aXJ0aW9fYmxrX19pbml0KC4uLikgaW4g a3ZtdG9vbCBzcGVjaWZpZWQNCj4gcGFydA0KPiA+ICAgY29kZS4NCj4gPg0KPiA+IEhvd2V2ZXIs IGluIHRoZSBjdXJyZW50IFZJUlRJTyBkZXZpY2UgY3JlYXRpb24gYW5kIGRhdGEgaGFuZGxpbmcg cHJvY2VzcywNCj4gPiB0aGUgZGV2aWNlIHR5cGUgYW5kIGh5cGVydmlzb3IgQVBJIHVzZWQgYXJl IGJvdGggZXhjbHVzaXZlIHRvIGt2bXRvb2wNCj4gYW5kDQo+ID4gS1ZNLiBJZiB3ZSB3YW50IHRv IHVzZSBjdXJyZW50IFZJUlRJTyBpbXBsZW1lbnRhdGlvbiBmb3Igb3RoZXIgZGV2aWNlDQo+ID4g bW9kZWxzIGFuZCBoeXBlcnZpc29ycywgaXQgaXMgdW5saWtlbHkgdG8gd29yayBwcm9wZXJseS4N Cj4gPg0KPiA+IFNvLCB0aGUgbWFqb3Igd29yayBvZiByZXdvcmtpbmcgaW50ZXJmYWNlIGlzIGRl Y291cGxpbmcgVklSVElPDQo+IGltcGxlbWVudGF0aW9uDQo+ID4gZnJvbSBrdm10b29sIGFuZCBL Vk0uDQo+ID4NCj4gPiAqKkludHJvZHVjZSBzb21lIGludGVybWVkaWF0ZSBkYXRhIHN0cnVjdHVy ZXMgdG8gZG8gZGVjb3VwbGU6KioNCj4gPiAxLiBJbnRyb2R1Y2UgaW50ZXJtZWRpZGF0ZSB0eXBl IGRhdGEgc3RydWN0dXJlcyBsaWtlIGB2aXJ0aW9fZGlza190eXBlYCwNCj4gPiAgICBgdmlydGlv X25ldF90eXBlYCwgYHZpcnRpb19jb25zb2xlX3R5cGVgIGFuZCBldGMuIFRoZXNlIGRhdGENCj4g c3RydWN0dXJlcw0KPiA+ICAgIHdpbGwgYmUgdGhlIHN0YW5kYXJkIGRldmljZSB0eXBlIGludGVy ZmFjZXMgYmV0d2VlbiB2aXJ0aW8gZGV2aWNlDQo+ID4gICAgaW1wbGVtZW50YXRpb24gYW5kIGh5 cGVydmlzb3IuICBVc2luZyB2aXJ0aW9fZGlza190eXBlIGFzIGFuIGV4YW1wbGU6DQo+ID4gICAg IH5+fn4NCj4gPiAgICAgc3RydWN0IHZpcnRpb19kaXNrX3R5cGUgew0KPiA+ICAgICAgICAgLyoN Cj4gPiAgICAgICAgICAqIEVzc2VudGlhbCBjb25maWd1cmF0aW9uIGZvciB2aXJ0aW8gYmxvY2sg ZGV2aWNlIGNhbiBiZSBnb3QNCj4gZnJvbQ0KPiA+ICAgICAgICAgICoga3ZtdG9vbCBkaXNrX2lt YWdlLiBPdGhlciBoeXBlcnZpc29yIGRldmljZSBtb2RlbCBhbHNvIGNhbg0KPiB1c2UNCj4gPiAg ICAgICAgICAqIHRoaXMgZGF0YSBzdHJ1Y3R1cmUgdG8gcGFzcyBuZWNlc3NhcnkgcGFyYW1ldGVy cyBmb3IgY3JlYXRpbmcNCj4gPiAgICAgICAgICAqIGEgdmlydGlvIGJsb2NrIGRldmljZS4NCj4g PiAgICAgICAgICAqLw0KPiA+ICAgICAgICAgc3RydWN0IHZpcnRpb19ibGtfY2ZnIHZibGtfY2Zn Ow0KPiA+ICAgICAgICAgLyoNCj4gPiAgICAgICAgICAqIFZpcnRpbyBibG9jayBkZXZpY2UgTU1J TyBhZGRyZXNzIGFuZCBJUlEgbGluZS4gVGhlc2UgdHdvDQo+IG1lbWJlcnMNCj4gPiAgICAgICAg ICAqIGFyZSBvcHRpb25hbC4gSWYgaHlwZXJ2aXNvciBwcm92aWRlcyBhbGxvY2F0ZV9tbWlvX3Nw YWNlIGFuZA0KPiA+ICAgICAgICAgICogYWxsb2NhdGVfaXJxX2xpbmUgY2FwYWJpbGl0eSBhbmQg ZGV2aWNlIG1vZGVsIGRvZXNuJ3Qgc2V0DQo+IHRoZXNlDQo+ID4gICAgICAgICAgKiB0d28gZmll bGRzLCB2aXJ0aW8gYmxvY2sgaW1wbGVtZW50YXRpb24gd2lsbCB1c2UgaHlwZXJ2aXNvcg0KPiBB UElzDQo+ID4gICAgICAgICAgKiB0byBhbGxvY2F0ZSBNTUlPIGFkZHJlc3MgYW5kIElSUSBsaW5l LiBJZiB0aGVzZSB0d28gZmllbGRzDQo+IGFyZQ0KPiA+ICAgICAgICAgICogY29uZmlndXJlZCwg dmlydGlvIGJsb2NrIGltcGxlbWVudGF0aW9uIHdpbGwgdXNlIHRoZW0uDQo+ID4gICAgICAgICAg Ki8NCj4gPiAgICAgICAgIHBhZGRyX3QgYWRkcjsNCj4gPiAgICAgICAgIHVpbnQzMl90IGlycTsN Cj4gPiAgICAgICAgIC8qDQo+ID4gICAgICAgICAgKiBJbiBrdm10b29sLCB0aGlzIG9wcyB3aWxs IGNvbm5lY3QgdG8gZGlza19pbWFnZSBBUElzLiBPdGhlcg0KPiA+ICAgICAgICAgICogaHlwZXJ2 aXNvciBkZXZpY2UgbW9kZWwgc2hvdWxkIHByb3ZpZGUgc2ltaWxhciBBUElzIGZvciB0aGlzDQo+ ID4gICAgICAgICAgKiBvcHMgdG8gaW50ZXJhY3Qgd2l0aCByZWFsIGJhY2tlbmQgZGV2aWNlLg0K PiA+ICAgICAgICAgICovDQo+ID4gICAgICAgICBzdHJ1Y3QgZGlza190eXBlX29wcyB7DQo+ID4g ICAgICAgICAgICAgLnJlYWQNCj4gPiAgICAgICAgICAgICAud3JpdGUNCj4gPiAgICAgICAgICAg ICAuZmx1c2gNCj4gPiAgICAgICAgICAgICAud2FpdA0KPiA+ICAgICAgICAgICAgIC4uLg0KPiA+ ICAgICAgICAgfSBvcHM7DQo+ID4gICAgIH07DQo+ID4gICAgIH5+fn4NCj4gPg0KPiA+IDIuIElu dHJvZHVjZSBhIGludGVybWVkaWF0ZSBoeXBlcnZpc29yIGRhdGEgc3RydWN0dXJlLiBUaGlzIGRh dGENCj4gc3RydWN0dXJlDQo+ID4gICAgcHJvdmlkZXMgYSBzZXQgb2Ygc3RhbmRhcmQgaHlwZXJ2 aXNvciBBUEkgaW50ZXJmYWNlcy4gSW4gdmlydGlvDQo+ID4gICAgaW1wbGVtZW50YXRpb24sIHRo ZSBLVk0gc3BlY2lmaWVkIEFQSXMsIGxpa2Uga3ZtX3JlZ2lzdGVyX21taW8sIHdpbGwNCj4gbm90 DQo+ID4gICAgYmUgaW52b2tlZCBkaXJlY3RseS4gVGhlIHZpcnRpbyBpbXBsZW1lbnRhdGlvbiB3 aWxsIHVzZSB0aGVzZQ0KPiBpbnRlcmZhY2VzDQo+ID4gICAgdG8gYWNjZXNzIGh5cGVydmlzb3Ig c3BlY2lmaWVkIEFQSXMuIGZvciBleGFtcGxlIGBzdHJ1Y3Qgdm1tX2ltcGxgOg0KPiA+ICAgICB+ fn5+DQo+ID4gICAgIHN0cnVjdCB2bW1faW1wbCB7DQo+ID4gICAgICAgICAvKg0KPiA+ICAgICAg ICAgICogUG9pbnRlciB0aGF0IGxpbmsgdG8gcmVhbCBoeXBlcnZpc29yIGhhbmRsZSBsaWtlIGBz dHJ1Y3Qga3ZtDQo+ICprdm1gLg0KPiA+ICAgICAgICAgICogVGhpcyBwb2ludGVyIHdpbGwgYmUg cGFzc2VkIHRvIHRoZSB2bW0gb3BzOw0KPiA+ICAgICAgICAgICovDQo+ID4gICAgICAgICB2b2lk ICp2bW07DQo+ID4gICAgICAgICBhbGxvY2F0ZV9pcnFfbGluZV9mbl90KHZvaWQqIHZtbSwgLi4u KTsNCj4gPiAgICAgICAgIGFsbG9jYXRlX21taW9fc3BhY2VfZm5fdCh2b2lkKiB2bW0sIC4uLik7 DQo+ID4gICAgICAgICByZWdpc3Rlcl9tbWlvX2ZuX3Qodm9pZCogdm1tLCAuLi4pOw0KPiA+ICAg ICAgICAgbWFwX2d1ZXN0X3BhZ2VfZm5fdCh2b2lkKiB2bW0sIC4uLik7DQo+ID4gICAgICAgICB1 bm1hcF9ndWVzdF9wYWdlX2ZuX3Qodm9pZCogdm1tLCAuLi4pOw0KPiA+ICAgICAgICAgdmlydHVh bF9pcnFfaW5qZWN0X2ZuX3Qodm9pZCogdm1tLCAuLi4pOw0KPiA+ICAgICB9Ow0KPiA+ICAgICB+ fn5+DQo+DQo+IEFyZSB0aGUgbWFwX2d1ZXN0X3BhZ2UgYW5kIHVubWFwX2d1ZXN0X3BhZ2UgZnVu Y3Rpb25zIGFscmVhZHkgY2FsbGVkIGF0DQo+IHRoZSBhcHByb3ByaWF0ZSBwbGFjZXMgZm9yIEtW TT8NCg0KQXMgSSBoYWQgbWVudGlvbmVkIGluIGFib3ZlLCBLVk0gZG9lc24ndCBuZWVkIG1hcF9n dWVzdF9wYWdlIGFuZCB1bm1hcF9ndWVzdF9wYWdlDQpkeW5hbWljYWxseSB3aGlsZSBoYW5kbGlu ZyB0aGUgSU9SRVEuIFRoZXNlIHR3byBpbnRlcmZhY2VzIGNhbiBiZSBwb2ludGVkIHRvIE5VTEwN Cm9yIGVtcHR5IGZ1bmN0aW9ucyBmb3IgS1ZNLg0KDQo+DQo+IElmIG5vdCwgdGhlIG1haW4gaXNz dWUgaXMgZ29pbmcgdG8gYmUgYWRkaW5nIHRoZQ0KPiBtYXBfZ3Vlc3RfcGFnZS91bm1hcF9ndWVz dF9wYWdlIGNhbGxzIHRvIHRoZSB2aXJ0aW8gZGV2aWNlDQo+IGltcGxlbWVudGF0aW9ucy4NCj4N Cg0KWWVzLCB3ZSBjYW4gcGxhY2UgdGhlbSB0byB2aXJ0aW8gZGV2aWNlIGltcGxlbWVudGF0aW9u cywgYW5kIGtlZXAgTk9QDQpvcGVyYXRpb24gZm9yIEtWTS4gT3RoZXIgVk1NcyBjYW4gYmUgaW1w bGVtZW50ZWQgYXMgdGhlIGNhc2UgbWF5IGJlDQoNCj4NCj4gPiAzLiBBZnRlciBkZWNvdXBsZWQg d2l0aCBrdm10b29sLCBhbnkgaHlwZXJ2aXNvciBjYW4gdXNlIHN0YW5kYXJkDQo+IGB2bW1faW1w bGANCj4gPiAgICBhbmQgYHZpcnRpb194eHh4X3R5cGVgIGludGVyZmFjZXMgdG8gaW52b2tlIHN0 YW5kYXJkIHZpcnRpbw0KPiBpbXBsZW1lbnRhdGlvbg0KPiA+ICAgIGludGVyZmFjZXMgdG8gY3Jl YXRlIHZpcnRpbyBkZXZpY2VzLg0KPiA+ICAgICB+fn5+DQo+ID4gICAgIC8qIFByZXBhcmUgVk1N IGludGVyZmFjZSAqLw0KPiA+ICAgICBzdHJ1Y3Qgdm1tX2ltcGwgKnZtbSA9IC4uLjsNCj4gPiAg ICAgdm1tLT5yZWdpc3Rlcl9tbWlvX2ZuX3QgPSBrdm1fX3JlZ2lzdGVyX21taW87DQo+ID4gICAg IC8qIGt2bV9fbWFwX2d1c2V0X3BhZ2UgaXMgYSB3cmFwcGVyIGd1ZXN0X2ZsYXRfdG9faG9zdCAq Lw0KPiA+ICAgICB2bW0tPm1hcF9ndWVzdF9wYWdlX2ZuX3QgPSBrdm1fX21hcF9ndXNldF9wYWdl Ow0KPiA+ICAgICAuLi4NCj4gPg0KPiA+ICAgICAvKiBQcmVwYXJlIHZpcnRpb19kaXNrX3R5cGUg Ki8NCj4gPiAgICAgc3RydWN0IHZpcnRpb19kaXNrX3R5cGUgKnZkaXNrX3R5cGUgPSAuLi47DQo+ ID4gICAgIHZkaXNrX3R5cGUtPnZibGtfY2ZnLmNhcGFjaXR5ID0gZGlza19pbWFnZS0+c2l6ZSAv IFNFQ1RPUl9TSVpFOw0KPiA+ICAgICAuLi4NCj4gPiAgICAgdmRpc2tfdHlwZS0+b3BzLT5yZWFk ID0gZGlza19pbWFnZV9fcmVhZDsNCj4gPiAgICAgdmRpc2tfdHlwZS0+b3BzLT53cml0ZSA9IGRp c2tfaW1hZ2VfX3dyaXRlOw0KPiA+ICAgICAuLi4NCj4gPg0KPiA+ICAgICAvKiBJbnZva2UgVklS VElPIGltcGxlbWVudGF0aW9uIEFQSSB0byBjcmVhdGUgYSB2aXJ0aW8gYmxvY2sgZGV2aWNlDQo+ ICovDQo+ID4gICAgIHZpcnRpb19ibGtfX2luaXRfb25lKHZtbSwgdmRpc2tfdHlwZSk7DQo+ID4g ICAgIH5+fn4NCj4gPg0KPiA+IFZJUlRJTyBibG9jayBkZXZpY2Ugc2ltcGxlIGZsb3cgYmVmb3Jl IHJld29ya2luZyBpbnRlcmZhY2U6DQo+ID4NCj4gaHR0cHM6Ly9kcml2ZS5nb29nbGUuY29tL2Zp bGUvZC8xazBHcmQ0UlN1Q21oS1VQa3RIajlGUmFtRVlyUENGa1gvdmlldz91c3ANCj4gPXNoYXJp bmcNCj4gPiAhW2ltYWdlXShodHRwczovL2RyaXZlLmdvb2dsZS5jb20vdWM/ZXhwb3J0PXZpZXcm aWQ9MWswR3JkNFJTdUNtaEtVUGt0SGoNCj4gOUZSYW1FWXJQQ0ZrWCkNCj4gPg0KPiA+IFZJUlRJ TyBibG9jayBkZXZpY2Ugc2ltcGxlIGZsb3cgYWZ0ZXIgcmV3b3JraW5nIGludGVyZmFjZToNCj4g Pg0KPiBodHRwczovL2RyaXZlLmdvb2dsZS5jb20vZmlsZS9kLzFyTVhSdnVsd2xSTzM5anVXZjA4 V2drM0cxTlp0RzJuTC92aWV3P3VzcA0KPiA9c2hhcmluZw0KPiA+ICFbaW1hZ2VdKGh0dHBzOi8v ZHJpdmUuZ29vZ2xlLmNvbS91Yz9leHBvcnQ9dmlldyZpZD0xck1YUnZ1bHdsUk8zOWp1V2YwOA0K PiBXZ2szRzFOWnRHMm5MKQ0KPiA+DQo+ID4NCj4gPiBUaGFua3MsDQo+ID4gV2VpIENoZW4NCj4g PiBJTVBPUlRBTlQgTk9USUNFOiBUaGUgY29udGVudHMgb2YgdGhpcyBlbWFpbCBhbmQgYW55IGF0 dGFjaG1lbnRzIGFyZQ0KPiBjb25maWRlbnRpYWwgYW5kIG1heSBhbHNvIGJlIHByaXZpbGVnZWQu IElmIHlvdSBhcmUgbm90IHRoZSBpbnRlbmRlZA0KPiByZWNpcGllbnQsIHBsZWFzZSBub3RpZnkg dGhlIHNlbmRlciBpbW1lZGlhdGVseSBhbmQgZG8gbm90IGRpc2Nsb3NlIHRoZQ0KPiBjb250ZW50 cyB0byBhbnkgb3RoZXIgcGVyc29uLCB1c2UgaXQgZm9yIGFueSBwdXJwb3NlLCBvciBzdG9yZSBv ciBjb3B5IHRoZQ0KPiBpbmZvcm1hdGlvbiBpbiBhbnkgbWVkaXVtLiBUaGFuayB5b3UuDQo+ID4N CklNUE9SVEFOVCBOT1RJQ0U6IFRoZSBjb250ZW50cyBvZiB0aGlzIGVtYWlsIGFuZCBhbnkgYXR0 YWNobWVudHMgYXJlIGNvbmZpZGVudGlhbCBhbmQgbWF5IGFsc28gYmUgcHJpdmlsZWdlZC4gSWYg eW91IGFyZSBub3QgdGhlIGludGVuZGVkIHJlY2lwaWVudCwgcGxlYXNlIG5vdGlmeSB0aGUgc2Vu ZGVyIGltbWVkaWF0ZWx5IGFuZCBkbyBub3QgZGlzY2xvc2UgdGhlIGNvbnRlbnRzIHRvIGFueSBv dGhlciBwZXJzb24sIHVzZSBpdCBmb3IgYW55IHB1cnBvc2UsIG9yIHN0b3JlIG9yIGNvcHkgdGhl IGluZm9ybWF0aW9uIGluIGFueSBtZWRpdW0uIFRoYW5rIHlvdS4NCg== From xen-devel-bounces@lists.xenproject.org Mon Jul 05 10:07:08 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Jul 2021 10:07:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.150056.277503 (Exim 4.92) (envelope-from ) id 1m0LVL-0004La-Hw; Mon, 05 Jul 2021 10:07:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 150056.277503; Mon, 05 Jul 2021 10:07:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0LVL-0004LT-EI; Mon, 05 Jul 2021 10:07:07 +0000 Received: by outflank-mailman (input) for mailman id 150056; Mon, 05 Jul 2021 10:07:05 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0LVJ-0004LN-Ho for xen-devel@lists.xenproject.org; Mon, 05 Jul 2021 10:07:05 +0000 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 705301ed-8c48-4a0a-a951-f2d9a3fa495c; Mon, 05 Jul 2021 10:07:04 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 705301ed-8c48-4a0a-a951-f2d9a3fa495c DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1625479624; h=to:cc:references:from:subject:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=vD5+6S7g5mH2XywkXQZuyOwCvE48NX2okNQE1cctsxY=; b=MfMPhytjXFMtLi4waMEl9jDLBzzSsvy4rEZCjQW+VshHZvl5Pu1Kb6S2 Mqr/URNF6mk4kf1vFZgKb2Jhu3dwpe9erp45C0YLaFKU9SeZnwYuBOQ2O TVSF5VJKra2OLKd+hCXmHDC2OecP+K3fuJTw8RrP5H+pylUnwTZVofSKq U=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: g3eDuLWzwRcBNxi8TYNY6KahRQEBanD0AS+5+eBBGCHOGQic7EK4fEZyLj87huJmfyXyea/YkM NSN9UGOE4PM1XYA2RA3xKjDdavGJh5DEu6Ik/e/Fz+fgwjPN7nlAj6kdiDIx6G2cc83NVQKEv8 eFTZr29TnOVHVDj3UUDq2whDSR/BS6gPzi2Pj/XYEcF2qimzzLHcUN0UZu19cSZb5aY3xXU8RG c70a5pSYK+5o3fWIjTqgMq663kDSRtCCtW4ssIivaVNLyAKOIck5RCCpMTxOlU0orFZ2Cl0J4T I3g= X-SBRS: 5.1 X-MesageID: 47572914 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:LxCkrKCfSlmUAYflHehBsceALOsnbusQ8zAXPh9KJyC9I/b2qy nxppgmPH/P6Ar4WBkb6LS90dq7MA3hHPlOkPYs1NaZLXXbUQ6TTb2KgrGSuAEIdxeOkNK1kJ 0QDpSWa+eAf2SS7/yKmDVQeuxIqLLsndHK9IWuu0uFDzsaDJ2Ihz0JeTpzeXcGPTWua6BJca Z0qvA33QZJLh8sH7SG7zQ+Lqf+juyOsKijTQ8NBhYh5gXLpTS06ITiGxzd+hsFSTtAzZor7G CAymXCl+SemsD+7iWZ+37Y7pxQltek4txfBPaUgsxQDjn3kA6naKloRrXHljEop+OE7kosjb D30lkdFvU2z0mUUnC+oBPr1QWl+i0p8WXexViRhmamidDlRRohYvAxx75xQ1/80Q4Nrdt82K VE0yayrJxMFy7Nmyz7+pzhSwxqrEypunAv+NRjzEC3abFuLIO5kLZvu3+8SPw7bWTHAcEcYa lT5fjnlbNrmQjwVQGBgoEHq+bcK0jaHX+9MwI/U4KuomBrdUtCvj0lLfok7zw9HaIGOu55Dt v/Q+1VfZF1P4IrhPFGdas8qfXeMB2EffuaChPiHb2gLtBdB07w X-IronPort-AV: E=Sophos;i="5.83,325,1616472000"; d="scan'208";a="47572914" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CjjFveKX+f3OQGdrqQKJPq5ANq1vAO9ZqDf7/aOcR9ylhprbfPGny6YyNwtT8yVLB+6mteKeRRNDzqJ2rtgWFahuHlVzeedpfQm3iOtTDJmgSrwdPQn+k5/DrSk5QvWH7vzWCUdS5j6wEX0gtSWvExRvSzixf0O0fQXrA+zASxl8E4Ft9IczQHWO1uEvY8X/asTsqYl788Xlx6lvN6I7zpk2lux1Fn+W8ffuE4l3SdYzBQK7dvfh82icC/ZBWuDt6LrEf77+knR1AdoWL+4P+EJ0l0tCVGrZzxj7K7QZEJx4acsIN4drh9Kae9RpAuIbqHenLUYci9KbizE8ZqnRzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vD5+6S7g5mH2XywkXQZuyOwCvE48NX2okNQE1cctsxY=; b=nQbkuhtZLY2Uml1lpk5XXdquih3JSRajkG5OS0KLJD+Jfp0aqyArzYHztjsW5YxVRLM4uGtDtqzBbaOntKseHIEq5dadhU4mT7j1h5RyRNcyzfHXWzFG7XevL2rLmA8zwppvaHf+jFyhxUjLYwAeNPnPZNZl0Xmd0DjDpr5wQoq/x6FQk0sdDW0MIyGwRpNX+JEB/Aeo5CWLUxDSpfi6q3lD6CE2wGwLsF7wdqjlIhQoTr4pCFMxtii0oOmUA2mmFQj+K6XoqpJ04TScYmZz3H1YWz/o+gIS2DmuTPCYuGzwFRMO9LC17i/9ayIIZNx5cEed3Kau6vUPjbAEPcqDcg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vD5+6S7g5mH2XywkXQZuyOwCvE48NX2okNQE1cctsxY=; b=m386p22YELbCmRz3oesAV1oOayGwGcdvWWCQXiQ8WEVBhnmHP65bwLGNPlHWTVZ/UtG3qIZYundrLobauyATGlK1QrOT8S7T7IbN4ckv3voZZrVZy//pifQb9InAtfZG16Zc87ju+HcSQsXG5oWfW8BRrdgi+T3ZAI7DwnN8d0g= To: Jan Beulich , Olaf Hering CC: Ian Jackson , Wei Liu , Xen-devel References: <20210702190342.31319-1-andrew.cooper3@citrix.com> <06968742-355f-ad37-0681-e51eea256414@suse.com> <20210705100228.4947ed4e.olaf@aepfle.de> <20210705103224.26f3835d.olaf@aepfle.de> <1e2a3967-06e5-75ec-3aa5-1f39b6700e63@suse.com> <20210705112548.22ae6d20.olaf@aepfle.de> <5e4986ad-d3ec-18af-b1ea-ccbce57a70ff@suse.com> From: Andrew Cooper Subject: Re: [PATCH] tools/libxenguest: Fix migration's debug option Message-ID: Date: Mon, 5 Jul 2021 11:06:43 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 In-Reply-To: <5e4986ad-d3ec-18af-b1ea-ccbce57a70ff@suse.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Content-Language: en-GB X-ClientProxiedBy: LO2P265CA0097.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:c::13) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 063d4c7c-3093-42b6-a338-08d93f9c9da8 X-MS-TrafficTypeDiagnostic: BYAPR03MB4245: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HgLc8G0W7P2qK0BxA8MnJA8fwIHuPTQZna+HkSajNHj7QMNSC4bGLhFUBMlQvZWjMt4JocrWScZdktsyULQ0fXJp1Exzf17a3C78FKo4NcX5/Y7j2fydX6264WAoWHEgTY3gDDI6upTGapUsrWvp+Su1DzjCkqmk/hokLkzqVSp4TZ7frFzai/IzVP3BKxSs6X/uCd4HgWchv/iksYwaiUgI7yByEq9+9rok/McSNfpmr4ZeLGy6sUEVm5GepRc4w8e+QNQDGYRya0MWP/IHWhcO2R6WRfwZkyv7yY3PYvYDWO4GNJXSyGAmrbe5FGcu2PvVmPax21xZhdZYT1mBqgLPx1jhupRW8Isd8kOJBUm0+7IldjBxWo+sb1HR/GopXts91aWDokZof5I8UjIWCX1v3o6cDatO+eLQXHugR+aTmEGtQ7DZFK9GS2nIemXrQhp38ZPQLA/Gu9H+iiAN4H6xmPLan0a1zTzUnRnlwLVlg4DZuFeuf7FU5krVRczOQFf0T3jBhuYQ2wDF0ASGYpa0Teq47du4ziXVR2rf+brzisACS92nhtYbPVJuebukR79zn5GWez+MCX3hQoLoW00dG2kdGU1EbP6RhILoMT67J6kzJeyAGNNVpRxu1d6IzB0uNMClJl4mueIURm04r1SK7PnQte/yOPASmrmmxY8RRZO+gPeoi6xcsK6ZIF9nG0NSzngMhtYLyzmlAQn7KD6WqjaaLkJsvFekGVcY5bk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(346002)(136003)(376002)(366004)(396003)(4326008)(66556008)(66476007)(478600001)(66946007)(110136005)(86362001)(6666004)(956004)(2616005)(38100700002)(316002)(16576012)(8936002)(16526019)(83380400001)(2906002)(8676002)(53546011)(31696002)(6486002)(31686004)(26005)(54906003)(36756003)(5660300002)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?Windows-1252?Q?M4ygjH277D/R5Ce4gMaomhJWmRSP/EFPW2txTVTmH2kTM6SizzTWpbf/?= =?Windows-1252?Q?ZzR8+Pa2Oek2eAE+cKKhNcha0u/CBbZNxRiYZUH0+rEAeFWJtmtYonFT?= =?Windows-1252?Q?flmpuSYPNpeA6GBySZDMlId29vGnLipIes7wpkXctlCj8beBpZZMEUk6?= =?Windows-1252?Q?YsvWqVlOpDPmvducZgPBriaPT31fKHHweKNR3R4iHrs8lqesiJWg8xpO?= =?Windows-1252?Q?HCfRhyZxtEqGxOpP3UZX1mIAv4NZHuMF4K+UJJ0iR2xgrAKFMJ5Z8+8+?= =?Windows-1252?Q?cXFPtzlFOGwlu1al5EypH4EZJivs7Ygj+IrlYAJsT8KB0BT/vxnxgWzb?= =?Windows-1252?Q?U0TMxLBVvf9RVTWqJM1LMmptq1+e+bJirogrNHH9WPEudeahKr1F+wpF?= =?Windows-1252?Q?LswlVxFsHJWIhrgSRcUfGN/krJoNneiKacCu+7Gjke19vDf4gXUZs/sR?= =?Windows-1252?Q?k8ZZ2zyQFt/JK0q4PJX/kibuLRHSWDokr77MnmxUptlbcd/ul8/hBo6O?= =?Windows-1252?Q?pqIVYtryTSbrstPxNlXopLASxHpfv7PYbU4sbkdwIOVSLKPE1wY45GV7?= =?Windows-1252?Q?zhikuobjQOaSbxLP78+6VaFzSTFW+PuUIBcCpDEE4h8av7BSLNUyF6qC?= =?Windows-1252?Q?ZuDW4FxNAiTWsaQEH+GOzVJIBvaEDKgl5kZFAWVhGmmuQGv54Zbc2P/h?= =?Windows-1252?Q?SKtSQqzhZ0fOCh13OFituGEFaBywM2PP7H/nhcmRL8YPeQ1EtxZS0YEu?= =?Windows-1252?Q?/wLcJJtb+kxbZiI1DrPn+Z5ZUc/h5uPOkDADyAmruLCECp9qgDgR49KA?= =?Windows-1252?Q?LpPfHuyxlQ9eGN4YF6om7IZXhTHMt/aQhkj6WNTkLdgJXVBBfIcB5Fcc?= =?Windows-1252?Q?aHhZUWDTbWnGT3afvcJyeTwGF3zUXT4ig1tJx+otaQsXjZJiLFdtDoMI?= =?Windows-1252?Q?Bk2Jpw2E8pAuHqrj97UkZkRL5q2GQbvwBYaZMWfBtHMfOvE8KTTcURpJ?= =?Windows-1252?Q?0M/0N65zlC83mbR/CEfNaztkGDLGQfp8wMaD45PxhSrigxRa/debuYNr?= =?Windows-1252?Q?7Kht1/FJidHFmtVCfb/vMyQvzA9sb6KrlSuPOtvt4OX0EHzGdiIf90hh?= =?Windows-1252?Q?K3sE1lPj5fvr+B8pqF+wwg81xnZ2DcwnUk7HhSXmPdgGPxv0f/iBjHs2?= =?Windows-1252?Q?pzLyODU5MY3DepBi9Cl5W+rHaTj10oQXNFMFJkPDwe4BYnU2ygcDCptt?= =?Windows-1252?Q?cSqruudRs1pmQ3MzuACZQlY+4j+ZHnhejYrbwCL0QJeeaNhdzfqL588g?= =?Windows-1252?Q?flB96SO0mYK1vLUUFLPcI8YHdU5p8EZv15W0spM70O9VIJY+jR383Ty1?= =?Windows-1252?Q?PSFUMwyifyprbngUa1FrrrfSu5TJOQzgyCklYFVSNqNJiUdq2xgzaWja?= X-MS-Exchange-CrossTenant-Network-Message-Id: 063d4c7c-3093-42b6-a338-08d93f9c9da8 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2021 10:06:54.3327 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BPNq34/7jiz8T4FZimfmhBxYoLslPBKTFFWikqtYANUbmamnVAyhv43IjTr3fqXhS7XtzoeqEJXh3jH5pt43kO0GuCt2dYnNnydxt9XRJC4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB4245 X-OriginatorOrg: citrix.com On 05/07/2021 10:31, Jan Beulich wrote: > On 05.07.2021 11:25, Olaf Hering wrote: >> Am Mon, 5 Jul 2021 11:19:59 +0200 >> schrieb Jan Beulich : >> >>> "The interface" being which one? The tool stack can map the guest's >>> grant table, so it is in the position to find out about all grants >>> without further hypervisor help. >> The interface means the code behind verify_frames. >> >> If there are indeed ways to query which pages belong to grants, how woul= d the toolstack need to do that? > Map the grant table of the guest and walk it, recording any MFN for > which at least one valid r/w grant exists. That doesn't help - Its still racy with in-flight IO.=A0 Also with updates from Xen such as the wallclocks. The only way to fix the IO problem is to disconnect the blk/net rings before doing the final sweep for frames, but that clobbers any ability to restart the VM on the source side if things go wrong at the destination. I don't have an answer at all for the vcpu info frames. ~Andrew From xen-devel-bounces@lists.xenproject.org Mon Jul 05 10:10:34 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Jul 2021 10:10:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.150062.277513 (Exim 4.92) (envelope-from ) id 1m0LYd-0005if-1N; Mon, 05 Jul 2021 10:10:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 150062.277513; Mon, 05 Jul 2021 10:10:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0LYc-0005iY-UQ; Mon, 05 Jul 2021 10:10:30 +0000 Received: by outflank-mailman (input) for mailman id 150062; Mon, 05 Jul 2021 10:10:30 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0LYc-0005iS-60 for xen-devel@lists.xenproject.org; Mon, 05 Jul 2021 10:10:30 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 392cffc5-dd79-11eb-8441-12813bfff9fa; Mon, 05 Jul 2021 10:10:29 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 392cffc5-dd79-11eb-8441-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1625479829; h=to:cc:references:from:subject:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=q78QIUoA7VlmEij5JowzrPOe2BnFLm5XQRvTXXSlPd8=; b=VWbRofk5Z8wUuyKM4QPo+T3Kxmktq1e/g1vn5UjSiYct5aUN4ULlwPrx JW/e2jmoG1xvLUqJ3rXQPnVkz6zLkj7c8ovU4sn/hUryfK993pAVpc/pB I+m9dQap6DXEnMKsT9fRgNQdPOvRe6aUKK+VEaHs4LxLxl4p83k55MIHA c=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: 6pJXLkKwMTQdcKmN/B4CG/qgE5tJoR2os4hOBPbSbLjUYKHlP5oBCMr7gW40+oA767JrP599jj All81qetr3tvfvuBymzUbvlXYcTs1lQ9P9ujP2Evc+J73cvqvxcmJ7tT8EXsisXeNLzYXzhHN+ pG/VcmNSPxCQ/qYdCs8EsAd0rXr9lRixl43b29fiiPc36sudZm+kAdG+xg0hOc3dK147KRmo6q MEYySXnRGcoHDLVov/ICMisVA5PzgqyRZcPxaRH57puOsHDheC2LO8conPj/hLEB5wHvKj1Cjt OuA= X-SBRS: 5.1 X-MesageID: 47945855 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:yzrV9Kg7zW7k8wHT7fiTPJajiXBQXzd13DAbv31ZSRFFG/FwyP rBoB1L73DJYWgqNE3I+erhBEGBKUmskaKdkrNhQ4tKOzOWx1dATbsSkbcKpgeAJ8SQzJ8n6U 4NSdkZNDS0NykGsS+Y2njLLz9D+qj+zEnAv463pB0BPGIaCdAV0+46MHf9LqQffng0OXNTLu vk2iMonUvERZ1aVLXAOpFTNNKz1+Ej2aiWLiIuNloC0k2jnDmo4Ln1H1yx2QofaSpGxfMH/X LemwL0y62/u7XjoyWsllP73tBzop/M29FDDMuDhow8LSjtsB+hYMBEV6eZtD44jemz4BIBkc XKoT0nI8NvgkmhMF2dkF/I4U3NwTwu43jtxRuzmn34u/H0Qzo8Fo5omZ9ZWgGx0TtjgPhMlI Zwm06JvZteCh3N2A7n4cLTah1snk2o5VI/jO8oiWBFW4d2Us4TkWUmxjIQLH48JlO81Gh+e9 MeSv00pcwmMW9yVkqp+1WGm7eXLy0O9n7seDl2hiSXuwIm1kyRgXFonPD3pU1wgq7VfaM0rN gsAp4Y442mcfVmJJ6VJN1xDPdfWVa9DS4lDgqpUBza/fY8SgPwQtjMke4I2N0= X-IronPort-AV: E=Sophos;i="5.83,325,1616472000"; d="scan'208";a="47945855" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dKp6XM3hGw6Lg36PrNAqUZ9xCiWJgfPqjxzFVOv6fu75SmR8fy1L51MX3K+OkA5sU8vCvFuduag/ALHz0aCKyxIN6fE/H4J7UpHQYMxhAKKig7sN0jCf5lXHzCa1Va/QuY+Bz7CIs++T49YRcESpzzC/c7dHjgGNtcEdL8BNGqPTbAW0XbgFdOY3eV0T6uhktzBFbErbS88ofxhXyKcgMVh0cmsabrmCfjQuiYlz2orTawtDlMEaiU5DanzNdPjSz2q9ftsxzlbPj+uSJsUwsBbf8UUL3fIBtFrDgoJXbn1EW64WyYFnV1OQ2lEUVjDXKgjYZxVV0d8rYpTFOgxPjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xnY+PPET+F2zt6L6l2G5TzAbdbu8ra6zr0Lt9KHC+Ac=; b=VvM9VEoOEC8jcNLIWi2UDMbp/3DBy34kho30+6X5RN6fIxZSCVCiT58vFb5Pn/RUxX/WlRwdMDsYZEoZZUPoKV2FYI7g78KE4EOnzu6Wauby3YGxLH50ah49tCh2G5B1OZYZVrnjGB641F6ca5mNyEiUD5nHOx/ycSsR/VvzNfbAnI2GTdwEFNoGNVtyplOY/JgEKpdyQadt49sbP0WCCR8P4g10T2/v8U81gYmyC+lSbMVCTFVvxGgBJ9v/mhsj5n3qX/5e6awQ5KaEO2PaMu9qx/uGqN6v3wXF3xAD2rH04JAU6SrmiTXtq/A6jJzzHLSquW/zjM0HDEl5zQRY2Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xnY+PPET+F2zt6L6l2G5TzAbdbu8ra6zr0Lt9KHC+Ac=; b=G+ii/3tap9BMy7MsenBgEK5WtDZalcP5dXC66yj3Fb4ACxSNv8eG0q6berk206F0OWvAdMmC+0d8J3na7o7k4kaxGl6eikqJr5k9SXxVTgdHFtAhUfIluy8HV3vX5LuGLaRrf+c8rjLD3mXhdKe3LrpibtOFS4T9gFuViO5zetQ= To: Olaf Hering , =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= CC: , Ian Jackson , "Wei Liu" References: <20210701095635.15648-1-olaf@aepfle.de> <20210701095635.15648-7-olaf@aepfle.de> <20210705100706.48b4a1ef.olaf@aepfle.de> From: Andrew Cooper Subject: Re: [PATCH v20210701 06/40] tools: fix Python3.4 TypeError in format string Message-ID: Date: Mon, 5 Jul 2021 11:10:18 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 In-Reply-To: <20210705100706.48b4a1ef.olaf@aepfle.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-GB X-ClientProxiedBy: LO2P265CA0278.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a1::26) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fc916899-2d18-4eba-d51f-08d93f9d1b91 X-MS-TrafficTypeDiagnostic: BYAPR03MB4245: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:669; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xqvT2Vj7wjrPsSeVTfFVnmVkSgZiawo94XACtpnHUD96EHWwUYNL469wYoeVEBPPIDriE9kK/dR4x7gn85VDqe9p7Kch9SqcghKsNW00vdsFVqXWecroXRDVGlPx6FSvuCOoznuNCArdX6N38wi7TEZo7RjoeXgDLw79Yi2AN/SGbE4hUr61doprTMYgQ0Mi6K4685RqQIbeHTn6NOqAkbfkOBnkofcsVmK4+EEvWERYcfBDpPLbkzBhQ1PSFtJOkdWPBalvnHfJPa0z1BXK4CKkAxkNStRsJyuGNL7XRK7fwBrcPDIft6CsNmE2lmi1DTfSZgExxc+h6SYqkChfA7e+Jv0cCg+yG7v2adK7QfMLdGswJD0j1cyZcT0NfUODCB5tSfUNhpnoEzRoz90voPnd242rjv9jyfQkFxI4p+ukJ7eiH6+RDwE7YYS2xgH44PjmzDGUcaeKy5PnOv23v500cVPkjV/H56j8UZzLsgqe+02VOu0VRo0E6teLy8V4QSrc2jjdYgmX8v78kM/EWwTsrv+D7OolkmMAxlDshjQkbIT9uBXt/ElZQ4BKlY5odDg8Tl69TfRTIr/tIl1ZwO4pI84ADDy699jEtB3WsrSdmVj/iMcp3ubfvGfj0Md0JrVCZyyI+XHAeKOpVEQYNv1en0UTeW8IEEeLFu9142zQ1F3DaQW3gbCkPDktKIR95uxlinLgJ/mtxtMGTorxLBIzVtgyT8XDtiaZTYttENs= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(346002)(136003)(376002)(366004)(396003)(4326008)(66556008)(66476007)(478600001)(66946007)(110136005)(86362001)(6666004)(956004)(2616005)(38100700002)(316002)(16576012)(8936002)(16526019)(2906002)(8676002)(53546011)(31696002)(6486002)(31686004)(26005)(4744005)(54906003)(36756003)(5660300002)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L1dGcnJ1QVVDeVhKRnpUU1V0VWRtNnZZRmdPR25QeHNSK2MyUW9nMHVZSW45?= =?utf-8?B?MTZVa3VEN05YSVRSYzBmdWJkVUl3aUVPOCtLcUNJVDhqem9lV29pMjlwbWd0?= =?utf-8?B?Y0MxMkNXZmZqNjhvNTR0dS83dGFmVUtmZHgxcGUwcVdpcktabVhhRXNpejE2?= =?utf-8?B?SWZUQnJZYXdnQlZLS1lQLzVLbDNRYjQ0OHcrbVZzUDZjT0VYYzZwcXJ0MVVv?= =?utf-8?B?aHZuNXNKWHNnU0R0Q3F0YTY0aHZCV3pyOXhaVUNra0RNTEIzOTZrL2VWMjZn?= =?utf-8?B?b0ZkOUtjcmZkSHo1aXJBREVEc2NGaDJXbHhobDhvNEgrT1ZXSlJxeWlJL2Rj?= =?utf-8?B?bTFabXBRSVpZbTFOejRIQ1BnV0dVODdCNHI4RTlnSXMzNmNSMG5VMkduQmRX?= =?utf-8?B?K1hxcGV5RmF0WHhpWmExTHlRK09XWDdSNGJoeDMwY1o5S3lnanhxSnVRenJS?= =?utf-8?B?dFhiRDhsUjR2WVB4amZ2UC93cjEwRC9DdnpReXZPNkZveGlkSGFzM0FmeTNw?= =?utf-8?B?QW92U0svZXRMMmVqSnRVWWFoamI3MnJhT0kxdnlCWVdGRjJhaEdubTVtSE1l?= =?utf-8?B?dWdPanNrMXJLODNXaUVuMklNSzdXS1F1UEZBUkx6ZThsOE1mWXdEVWhLU2Rx?= =?utf-8?B?d0VKd0JocUxQelZhdTF2Wm1zR3BwbVBLSTNManRpOE11NGVrNlNhdmJPVFpw?= =?utf-8?B?aXNHWWFnaE16Qk1qVXBwT1p4REtXS0NHUjVjeTBwYlQyVnFGRXlpWS8zMlc1?= =?utf-8?B?NHRaRXhRTmJqMHVvMld1Z0FaR3B3cEZqbmdCalpoN0cvTFZwY213UU1JYWk3?= =?utf-8?B?K3Fqa0FrWVBKRjVwMVJ0QmErbXc5Sld0SnQ1TEZZRmVqaWFHT3pObXZrMjdF?= =?utf-8?B?MzZydnNNR1g4aWhzRWw5ajNDTk1ib0puVkoycUFveEdUVXZXRVVBWUxhNm8x?= =?utf-8?B?bG90eXNmMnJ3ZFVmYk8xdldGd1pleTYrN0JzK2wvdEdJemNjdGFQeFViZEdN?= =?utf-8?B?RGNYckk3QXM4VlBDQ1dmYVMvUktGTW5aV285Ri9rOTBYcW9yV0ZjVUF5UFVI?= =?utf-8?B?cVgzSm5rOUhmc3VHSnpBVXY4NHBSaEhQYmZZVkhuZFlDY1djUUV5UnRvbDZp?= =?utf-8?B?RGx2TFBGSmt1VGg0b3FkaFd6M3pCQmJxRmJiT3Z4aUxnWDFxNi9scHk2QllS?= =?utf-8?B?UzFEVFBYemdQc3RDeTliK294cHJyajJnWndoZ3E2VGRSNlVEWml3SkdaU0t0?= =?utf-8?B?NFg5NGRXK0pSalNSWkVlNDJxN1V6VUdaS3J5RmZlNjgwSkw3eW1PU1cwTUtY?= =?utf-8?B?ZmRVK2VvVlVFTjVvM254U2VFQkZoTWMyQVA1T0VYdytUODBSdm9JbjlFUTZM?= =?utf-8?B?b3NyL2xFNzRldG5sVlAyUlc0MzBSRkV1cTkzZ3B4WlRMdVBmREFEWmNZVEpt?= =?utf-8?B?TFEvSFhhN2FISll0YWdhbURBb0hpV3U3ZXhUVXlLZVpmYVljbE56dTdRTkQz?= =?utf-8?B?Q2J4STJrOERzOHM3TThwZkxaYjV5REsvMWQvUnhHeUovTVUwMWhTZERFdU12?= =?utf-8?B?SVBWVlNKUEplbXVGOGt6K1RBRnQ2RWxaMkR4UG1DSUFKdEppdFRMakZ6QmtL?= =?utf-8?B?WGtZNEJHWFdWRm00a2t6Zmh1ekZtM0ZLRW9nak5FVVJ3QmxUL0VySGNPcTEw?= =?utf-8?B?RHBnaUJnNkxSd1VBZGlDRDlCNHgwTlQ0dHExaFdMenBTTTNCMUlEYm90R1JZ?= =?utf-8?Q?fu5Hiu4yehX8wH9Wf3ThHI/hTWseV4SptS9QoNp?= X-MS-Exchange-CrossTenant-Network-Message-Id: fc916899-2d18-4eba-d51f-08d93f9d1b91 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2021 10:10:25.6302 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: RnjfRPDCHgdHDItahXbcFcdlwF1svcuzxhMso2ieqF9zQhCVsSaY1Zf82Fttk+Ajbnk6xuCTYiHZfFiHmyjq+NZyVTiWdAV/WTIZymCszq0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB4245 X-OriginatorOrg: citrix.com On 05/07/2021 09:07, Olaf Hering wrote: > Am Fri, 2 Jul 2021 18:19:39 +0200 > schrieb Marek Marczykowski-G=C3=B3recki = : > >> Why bytes()? Encode does already return bytes type. > You are right, this works as well: > i =3D 123 > b =3D ("str/%x" % (i, )).encode('utf-8') > > Any preference regarding the "encoding"? I picked UTF8, but 'ascii' might= be more correct in this context. In practice it may not matter. I suspect you're right and it doesn't matter, but ascii feels like a safer option. ~Andrew From xen-devel-bounces@lists.xenproject.org Mon Jul 05 10:26:48 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Jul 2021 10:26:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.150068.277525 (Exim 4.92) (envelope-from ) id 1m0LoJ-0007DU-A1; Mon, 05 Jul 2021 10:26:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 150068.277525; Mon, 05 Jul 2021 10:26:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0LoJ-0007DN-74; Mon, 05 Jul 2021 10:26:43 +0000 Received: by outflank-mailman (input) for mailman id 150068; Mon, 05 Jul 2021 10:26:42 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0LoI-0007DH-GI for xen-devel@lists.xenproject.org; Mon, 05 Jul 2021 10:26:42 +0000 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 7cbed756-dd7b-11eb-8441-12813bfff9fa; Mon, 05 Jul 2021 10:26:41 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7cbed756-dd7b-11eb-8441-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1625480801; h=subject:to:cc:references:from:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=4kbApuj5NGTzEu7+bawpz+6DL+1+MSwUB5lOFyJYLMc=; b=dI1WXW9YDUbWE1KB+8fPxLYBgtXwBJJj2Z8cHi0yAY5ASdOiwyZwvKUo BAIpNaf9AAO1acZ4CtfG5wuq1AlsXzQINkciF0nsz9tIZ1QWoLSUaeZun ItxSaGPK8hX5hvpLbanRjwTiK6csT/K409J/vsyvHTeeCjbNxY5pf3GI+ w=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=hardfail (body hash did not verify [final]) header.i=@citrix.onmicrosoft.com IronPort-SDR: 939O6f42u88o3HqymiMS/n5catIRZo8ync97JO9hFpz62CRa2nxOucz9WKo2AOFCdmRlfDPX7G skOiSmatjcTeblHSnSJWMVI9uaqFupIGYrIkWFJPNGr82513D2ctwjRNT65HcODaA8Zl8bHrbU M8pCkNWC9Nng/AFjJjvT+IMn/sbX2dSEZ354D5/HG405mMenzbXoYQbDcRgUy1kKaoiTqwSckw 4qwbUg+vxhAGzxqsVbv5rZtfsewy2z2yG0/lR7xyX0/qcapsZNIXLSZ8lWMEkCaoUShqbfZSoI DLk= X-SBRS: 5.1 X-MesageID: 47573804 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:XEMBj6DyUKXXJvblHemi55DYdb4zR+YMi2TDtnocdfUxSKelfq +V88jzuSWbtN9yYhEdcKG7WZVoKEm0nfQZ3WB7B8bAYOCJghrMEKhSqafk3j38C2nf24dmpM NdmnFFeb/NMWQ= X-IronPort-AV: E=Sophos;i="5.83,325,1616472000"; d="scan'208";a="47573804" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=X4OFsTj4H4arsur/22GsgmrYPudbtVeRiySAzeLDMqVZebCE+3IV3jY/xim7hRM6oFH3GLrl+TmSU5bAgKvnEgqaUHROX7gs4+EAwS1cUQBN3NdQzS/2o8GQ+qqxYCdORcUDmNCoqwjwipn+VwOmq81n3kyiCbzNhzSNJ0hX1aHZEqPyct0CQFpF9M/vAbYo/pZPLkaI7kcDCt9MCNkumPYxV7aNHed8GYX+NGZFL29JJ29d71iimX5KDidzLYNu6hlbGmhs7dBdfIzYZEZGNtc1Q7CO+Hv66nM91PfAk8U8UzJsVfFQg2Ea8023/C0zz+VCrD/4/c5M5zFzhbJx+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xtycx29JKBGCYECyiI+oR4jzzwt4Bm61OsfO7gVru4Q=; b=NF3R8i5/vUyeTa4dD+vWdvebDdOl+2KvjNmzAD8+Hwt0KS8oQfsLydtaOj1JsP+xYOXZWiufhX6RTOuOFIZIbFg+7Gcyo4SXPWCH+uBnZgGIyG2kfPUK0+hLmbwQ4Q7jnxJFraF9f9hurRVwNGaOPdkD7Q22EazAuSRoMbpmzqujCALdivswPgrqMgacmXlgAD2mJboXY1xrWlQdrBYXSJ0xYKd1ekYYAsYhKUah/Ul4OsGY4RUMXkdssNK+p7um+cPaHeMMgaQ7FcgqoUrKWt4C6acad9f/Rrv3cFxTlX+jUXPySc0t2OB1BgqKet3K0lymiccPTW0mB9eRDPMp1A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xtycx29JKBGCYECyiI+oR4jzzwt4Bm61OsfO7gVru4Q=; b=GdDsYlZ6rKdM6iN5WmNKulugoHSZ6jQXIlsAyZWs1rqJkoBl61+HmOvuvBtK7m9WM7TUdPeAAd3id+PHW2ddQ94ww7QDh2LewDLjDNVd29Dcr2Lc9hIMgCIrJLUrDK77QxcBgAjJo2FapN5RS2p6aje7NJu+CkIB3mqxF41imaU= Subject: Re: [PATCH] tools/libxenguest: Fix max_extd_leaf calculation for legacy restore To: Olaf Hering CC: Xen-devel , Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Ian Jackson References: <20210702190334.31271-1-andrew.cooper3@citrix.com> <20210705093514.45be9be8.olaf@aepfle.de> From: Andrew Cooper Message-ID: Date: Mon, 5 Jul 2021 11:26:29 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 In-Reply-To: <20210705093514.45be9be8.olaf@aepfle.de> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Content-Language: en-GB X-ClientProxiedBy: LO4P123CA0385.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18f::12) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: cb9fba98-18ca-423b-61c7-08d93f9f5dfe X-MS-TrafficTypeDiagnostic: BYAPR03MB4245: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wzF+kRBczHPqaaFuCJoACAgJlupjrn3byssOHbYJBycREF73ID6O7KWvh2+KVFHrtdh43rw4IToWm71VFkOhCU49L6dLOKY3WySRxjGFFB9N211pNcgQFcckH4YJuG5rZynRpRuNC1hPAwwYE0WYJHvpRQ0jMyb6SptzsaLJdwamJjSkAfqk7zon3NkFGjqbA6t4lLgSvYjGSK94vR6vsicTCK8OEg87hhbuY+Fq1pqTi4W1khb8f/o3H/+Q7IUgbKUqMUMZSz4fxbusdHTlIcWTbO9PXlOVJjGcs9VBK1Dfqb/Q0p3G0uxzy4wmMLB9XJkKdMTlu9Wt5bZYesCYvjzd2kywiAhc1EpepqR797smeTqU6n5DPugiWQ1P+Pyr37rlk2AoD85Ch0JpDN4tX5FAVkU4f83n1DaX6h6ZoT5IDX4ks6cgXBKuZyi4EBTmqh4vprWJDT5ixdx/KfqPIz/uKv0uaD0BIWiN3RyFBPoupAKO8JU4eTUJlgQVqGmMeVSl9lsKtFfbW6xzu7Yukz8xnyts5LF6yzF9NAFt9q3rSU4msUUBWUO1Quywyth6NmGC43pie/YUlankgSqlw4HWKBHlk5L9dYnQg7BlL0WwFcTrMxdAbQ5hT8JYtWmdaUf4ohMy4x8M3XWVB/HInA6lnkjZ4HgFAh3UjzMnT6w2x22E8lNjUIWYgi/TCC3sFQepHUh8Ap75iZxLz0BHfhwXac9qPaG+m/Tek3qzNwM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(396003)(366004)(136003)(376002)(39860400002)(2906002)(83380400001)(8676002)(53546011)(31696002)(8936002)(16526019)(4744005)(54906003)(186003)(36756003)(5660300002)(6486002)(31686004)(26005)(956004)(86362001)(6666004)(66556008)(66476007)(4326008)(478600001)(66946007)(316002)(16576012)(6916009)(2616005)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?Windows-1252?Q?mVMOiy3/1PhNQqZsI69NcoS3KVSfvqm8THGEwwVekrC7dOXBq/8wxZHT?= =?Windows-1252?Q?6AGMilxNI83/AR7E+ZdtTsQYUQtSaVe3P54CQ+1jEA2Jc9K6ZRzn+KW/?= =?Windows-1252?Q?f37MDzACKdWyMq1LQFCbT7JZOnYHDfxbKxynFpeX8cNtw9cue4q+54nt?= =?Windows-1252?Q?DY1NJKUuK6RBZ3/7ooecPQLs7Musndk13LRCLcCooXRHNin3kgXnEDu8?= =?Windows-1252?Q?kJq7xuFFqwoYHYSYRVZBOzwHzqx7b/x/Spvqf1FKdTadFX0kkjgFMHij?= =?Windows-1252?Q?nTZBDX3fdJcL9fvTfJCE+OKxx51enn382U+UD/vh2DoTNSMmtOhK5AS3?= =?Windows-1252?Q?TFvhsVu1f4leopmu1FjJa9OrYJJ9AA4bFmKac3146bebw65q6lNIv74H?= =?Windows-1252?Q?nzusWaFNSfvUkpuvGytXZc+ZnW2iZAisQqQDlHiHIAJlQydbB7ihiAcm?= =?Windows-1252?Q?SmRJ/WpJIxqHsstbSFRFZpBNOL6A4Xzr8viMyTFQwCenMDA0hv0ShQ6G?= =?Windows-1252?Q?ViQioW/3eOwUMcx2du0SU7z+sDmvu1KuLJcLC/wAPHpLnQtVke+f4ToW?= =?Windows-1252?Q?tuwIew27As3NxZ85bkJhFM3pqNe2AmSQZhHhRtZt0kznusoKhbxKIKQY?= =?Windows-1252?Q?FsmZUML26WMd7rgxTp1hPtBxIu//cQRO9GNXFmYQomYrTLBaVsXb52n+?= =?Windows-1252?Q?WqX9xkkYn+mbTR1bVu+aWGTizUjlkXqBpZkL4JSZiRs0Ip1cW82nRoPk?= =?Windows-1252?Q?O3cGHPB40rFbyO3fLMXZR7Qf0mxDJrWY9uDXAhd+VMOqHU4yZZcUpvK9?= =?Windows-1252?Q?nn+O22ceCJF7Dl4V80+bV+kxjKRx7QKNZz1Kp3W4bWrFP0mAylPmRGaW?= =?Windows-1252?Q?UlxF0v6FRw3S5ucbce/bqthSc1XpbTkrr5Clj6iexfle/77Sl/vxj8K1?= =?Windows-1252?Q?zV2de6gLHZacDaPnTlOw6cJKAl/i17FakJBZv692G4iR0izPBmgQpCEL?= =?Windows-1252?Q?0QKYzRqvQ2thMgLxsIygvXduJONYSraJb1v/8q4EDOYHb+oHf78WpnjZ?= =?Windows-1252?Q?iqMTm/+M+lI7taFCbXwYPJe9S3i3BNl/iZ2XFj1Hqu1npuEA1jjGYacc?= =?Windows-1252?Q?lakSBuoWkNQBIRVvP7GGihyeYfBQnYujYOLdRiX3m7LLsM5MKM209zD2?= =?Windows-1252?Q?DWR8E9WvdMx88BUgs7OiJQNpfAu4LAbobb0zAGbszt078daEPgzEH/19?= =?Windows-1252?Q?3k44hytG5F+TpLyncqyL5ezOd7acWklS9xTSPlzCvbD0Qqo6eG5yAAIb?= =?Windows-1252?Q?4QjHj8n2ryJxarurJhT3ohFOIzueX46Qm+YaXIfi8vhr0VqUUTI0HVrO?= =?Windows-1252?Q?9JtA7Rfn5S15sxPtotVNdKVWMHcYzTWfdpMaFVezoZC0sIKItexrpO4M?= X-MS-Exchange-CrossTenant-Network-Message-Id: cb9fba98-18ca-423b-61c7-08d93f9f5dfe X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2021 10:26:35.9987 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bE9O93zGMUc3f1CDWSCGUobOmrUsAITbkqIs3ZI5/rjRHpIo9h2rJ+aT7NCby+cNYx9k8xl+oTod3qC0jkDb4cx73EEwCF8PD9NuTNid6+g= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB4245 X-OriginatorOrg: citrix.com On 05/07/2021 08:35, Olaf Hering wrote: > Am Fri, 2 Jul 2021 20:03:34 +0100 > schrieb Andrew Cooper : > >> Fixes: 34990446ca91 ("libxl: don't ignore the return value from xc_cpuid_apply_policy") > I think it fixes 111c8c33a8a18588f3da3c5dbb7f5c63ddb98ce5 ("x86/cpuid: do not expand max leaves on restore"), 34990446ca91 just revealed the bug? Urgh... That's what I intended to write here. I'll fix up. > Either way, this new variant is what I had tested last week. But with a trailing "u" for the constant. This detail may not make a difference in practice. The trailing u doesn't matter in this case. Furthermore, the way min() is written, the compiler will object if it were to be wrong. ~Andrew From xen-devel-bounces@lists.xenproject.org Mon Jul 05 10:36:34 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Jul 2021 10:36:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.150075.277536 (Exim 4.92) (envelope-from ) id 1m0Lxk-0000H3-Bu; Mon, 05 Jul 2021 10:36:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 150075.277536; Mon, 05 Jul 2021 10:36:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0Lxk-0000Gu-8y; Mon, 05 Jul 2021 10:36:28 +0000 Received: by outflank-mailman (input) for mailman id 150075; Mon, 05 Jul 2021 10:36:26 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0Lxi-0000Gm-KX for xen-devel@lists.xenproject.org; Mon, 05 Jul 2021 10:36:26 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 2bf36da5-c6d8-4bf5-b689-5563d0c6c8e6; Mon, 05 Jul 2021 10:36:25 +0000 (UTC) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05lp2107.outbound.protection.outlook.com [104.47.17.107]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-11-aKa-JLfHNIuexfCe-1UwkQ-1; Mon, 05 Jul 2021 12:36:23 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB6176.eurprd04.prod.outlook.com (2603:10a6:803:f6::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.23; Mon, 5 Jul 2021 10:36:22 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::99d3:99cd:8adf:3eea]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::99d3:99cd:8adf:3eea%5]) with mapi id 15.20.4287.033; Mon, 5 Jul 2021 10:36:22 +0000 Received: from [10.156.60.236] (37.24.206.209) by FR0P281CA0006.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:15::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4308.8 via Frontend Transport; Mon, 5 Jul 2021 10:36:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2bf36da5-c6d8-4bf5-b689-5563d0c6c8e6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1625481384; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mtCzWCvJajjEEo4vUf4P1VGPydBh2pXvIVqjdjaqRGg=; b=P8tTCnak8yhYHxLWdfA1kPxnMNcq4tQ4DcDyBfJl4fO7D1ii8Vnt67CszZCGdoraijSlEp LFWoPwmP90rusv6QYmYCytQUhXPis1p2Ruz4LRzX4YAwnHKKqK9Uy/NHoVfancuehrA/c6 qiF5wj8SLUnZoxCCnoafDeyVI//PjSs= X-MC-Unique: aKa-JLfHNIuexfCe-1UwkQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ONtv0ruDm2jhst+xEX2fjutqcfNcYgwQc69Rk/VcWxqriP+FXbGatS6pCfV0SNX3jhwTTcZoB/yme0i8XnNJY8bNpMTl4WD/5px46gAfnLIs61+3rFvX/z+PWIC8EMxcaH2WtXmXmjGotn1qoWbkLmMUD3ZxCUelwdGWu1VuKO7JpFJS1j1UI6UW8Qe0JWfJ+EWm2GKv97SZK0DA+tSOhLaQ7Ev5bQRyRHdqoSLkp93pWmZPF6+2E/srsFmnx9Cn2PFZdzDNG70Vh+G9qOE7MZL528zYKSnDPGqtQjItENyIffz70S8Lu6P6GCNN7hAv6OwZbK0itGWxF+qEVufF7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aDEIsMLkQL72Ggr9E7dr6K9o9lL1gTynJ5Heyl/v4ZM=; b=UKxMEytV4yYG91+5/pJa8LFktuvXNYpThQaWStktXekC4YneEJikTf9o+XUvSKCguxj97QTgx1b5yRMfiAW5/zpR3eY26+HaIkgPOu/hn8AGDVuD7NO0BNqBKUHJ/xRQ79nrEYXngL1/Q82mfsijKd+/tVL29uyvkwUTv2r2hmvI4SBFcBympe4/FKGV5fd4MeXFDO3kv8gietTdiTAnkusrY7R/AvZREdiprq7kYYbkmQRILW3FDMrAfh/aU1OZ14gDpjUyuj4oP3G7vhtn+qiyHVS6nGVyfh6ix/RdshS6bPMmWJEXU82a8UX5GJrVWA7hCQ0C/6oBGgU0/MMYWg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: aepfle.de; dkim=none (message not signed) header.d=none;aepfle.de; dmarc=none action=none header.from=suse.com; Subject: Re: [PATCH] tools/libxenguest: Fix migration's debug option To: Andrew Cooper CC: Ian Jackson , Wei Liu , Xen-devel , Olaf Hering References: <20210702190342.31319-1-andrew.cooper3@citrix.com> <06968742-355f-ad37-0681-e51eea256414@suse.com> <20210705100228.4947ed4e.olaf@aepfle.de> <20210705103224.26f3835d.olaf@aepfle.de> <1e2a3967-06e5-75ec-3aa5-1f39b6700e63@suse.com> <20210705112548.22ae6d20.olaf@aepfle.de> <5e4986ad-d3ec-18af-b1ea-ccbce57a70ff@suse.com> From: Jan Beulich Message-ID: Date: Mon, 5 Jul 2021 12:36:20 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Originating-IP: [37.24.206.209] X-ClientProxiedBy: FR0P281CA0006.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:15::11) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 39b8e781-35f3-4f06-8596-08d93fa0bb36 X-MS-TrafficTypeDiagnostic: VI1PR04MB6176: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8C06n86aI3kUJXT951aWaGsou4CSCarTs0cDFdZ7Kry9HBgjVzC+p6avjHE8uA7HP7J7+cEzOTyI6/EgwioiaqqSqvV/f7t7cFoPalkGye+bILddiJTej2mqZfJXmr1YPXmH+iPXDr1yY2W1UoPVt+37aX0mgiujkxWhlGOmgqIx40LlvpD9p03Gk8wugdbGIq8WV6DqGEXMmsK/KRzOmuWMLzoKCJCOn+QFWsDm0WoPfWWpqyq41WfugrBprUiJ6sURbtasPMbOPHbGYfvkeul8kQfqWUtg5wEaAUPWPal6tQNi9dqYRdnP22tyhXoK/vuGgj82zbO32EwYZ3Ai4UOE+D4Qz+Vdij7m6bIcpcRARqXlz8cd3CxQrBfbvlNfzTCyr1uqvLfzim0iNQrzfofNicGLdT9kJI4Qg9SMLN0wCW2eBh4IE0LRp2KQPinGHDSV+hA5FNTajoIT/JDFvim+23Q8KrfZEBCBaB1u2sx9EsAi3uj3/4c9aGnSJk1++862sNcuX/maAYPwWKyLC8miXMHrpw/Zu4iC69H6Z0KI8QQ/XT1e6jCQ/z7fwRBQKkCPBc+NwU2AtBKPWhQnbn4qF3yjpsDSwGAlK7sCAX6/nYpeB1OIASHV/rIN1+CjCnTxargTV49ztk/D7BbiY5cf8bIpU29HbtX3qbdZWrYGoLTgK5yI7gjQa71GC6G5rPIaEbRPSp6frt0jy6AnyxshPBYB6tM8FII3cHQOdr8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(346002)(366004)(39850400004)(396003)(136003)(376002)(478600001)(66946007)(38100700002)(2616005)(6486002)(956004)(31686004)(2906002)(36756003)(66476007)(26005)(66556008)(8676002)(186003)(16526019)(8936002)(5660300002)(86362001)(6916009)(4326008)(53546011)(31696002)(83380400001)(316002)(54906003)(16576012)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?e/Juk4y7+BOjp13cXhHIwVu9ZDbuMp18kuoQR0cTCQe2R/9/lByYfw8zEkV7?= =?us-ascii?Q?q9wEZdcdE1UdVvqH9AeqMT1YaGNeMndLTBSQgJR7W+RSDF75Z/ZDY3V26FMA?= =?us-ascii?Q?PLP/9Tsl4sSzpBTBVJz599HLKigSe3+Vor6UyU0Z0kIUY1/oLkBtWQ3IADGU?= =?us-ascii?Q?m6IffpkMxmkQAul9JFIqf8cXIshXjs9lKk3YEZV2b/1TI9CElDOqkcye6oxs?= =?us-ascii?Q?FjVQOhygdvAmnmwe5elCdxLqlGccEiEscqpUi/eEMOOXUf0bd79bFAGX66k4?= =?us-ascii?Q?LjJV9jdMpDxEUn/MtFtGKxjlMHEosI5L3fSNhNm6O69v1bFrvPpRlkcUZzIl?= =?us-ascii?Q?WMgpZwyOr1u4cw5KVO4XpDrzEg61/Zi7cFU+hNuuo5bakY/OfViUCx1dIaiw?= =?us-ascii?Q?dINnpuYEVBnlXGGQETUmCYHNCFq6EaysVAhLbaE7k+WiC396UkCpEueZbZ1A?= =?us-ascii?Q?8j+SEaQDgdrU3iO14BkfUKOyAbHv6vJpRsVV9oAWaTRTpDV1ardcDQ7KpgTh?= =?us-ascii?Q?oFqcxA22EqBmQ3ZANMAcr+qdKvejdLA8z54zXtfGhELhYJy8kMURhh2NOcZU?= =?us-ascii?Q?+hbKXUnw8mOv/UeZlf2Ds+oXoJzJkR4w7fw7B6Pe90iGz+qAFmA1XFjT/v+5?= =?us-ascii?Q?0uuqGKM1rOvXMPmG6w3vGIxl/Vm8GznIib7/ZP+bA41WChy7aLaJ2gSIW+4q?= =?us-ascii?Q?MTbJHiaGDCMexhzOhHt3bDq68LlbGYv5cnL0MLj2uz1CGGSAES/lG4b+19kz?= =?us-ascii?Q?itI2ctv5IjkG3gwa+f2VnTTch6DF2F3nO3Xclu3gEYq+SGJBYxPPQpRmH5eM?= =?us-ascii?Q?pm9h9RoqxRgQv0tOhhpGtkJMm/zgHuCU/Yna2JxTfhrdaEtn0TtgXg1jCzdO?= =?us-ascii?Q?7eDu3VSiJXDQScX3la5YKPZGeRzRfUx1txw/G0nd18iejo8aDRooD/AVd8Bc?= =?us-ascii?Q?kCjLSq78+gMf8G+cUJDuxCwXAmq438Sz2yOtWoWex4dPCbcGHaFBJR2x8gn5?= =?us-ascii?Q?su2ZHq2LdIVoqVMMAjMULrAHQW67t7UKhcRTDjXYWAswAdlqgg2osEEClfAH?= =?us-ascii?Q?y33fJ68fiIiq13fm8k04Xtr08iZxD9XJBCgzgaNLAjknW+j5NZH2Id5dZqH/?= =?us-ascii?Q?FfRTVE1QEHqcVcqI7bWDTILubEeclwBCEQ6x4EX9HF2s8i9YnDSqchUx9a4S?= =?us-ascii?Q?ghNbMM1owAoHN0B9xbOO1tKNO+trSenZQkGl4AKwTzJlIXmAaYHvFqjh5zIq?= =?us-ascii?Q?VN/fpeVwNIycbsNiywSecR4bKclDsdkmDFSrfLS5FgVSZbNPtoPo64RIgtD0?= =?us-ascii?Q?HznIvrNSbNWbAz7kFVTE3Fpf?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 39b8e781-35f3-4f06-8596-08d93fa0bb36 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2021 10:36:21.9124 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: GcMztUMeHx+0PqKccm11Lgj6ISKnVi80vC/PeV3aFHMwTaoiel4V9eVWYu6+sYI5yQghau+Vl7NT83k95VI30w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6176 On 05.07.2021 12:06, Andrew Cooper wrote: > On 05/07/2021 10:31, Jan Beulich wrote: >> On 05.07.2021 11:25, Olaf Hering wrote: >>> Am Mon, 5 Jul 2021 11:19:59 +0200 >>> schrieb Jan Beulich : >>> >>>> "The interface" being which one? The tool stack can map the guest's >>>> grant table, so it is in the position to find out about all grants >>>> without further hypervisor help. >>> The interface means the code behind verify_frames. >>> >>> If there are indeed ways to query which pages belong to grants, how wou= ld the toolstack need to do that? >> Map the grant table of the guest and walk it, recording any MFN for >> which at least one valid r/w grant exists. >=20 > That doesn't help - Its still racy with in-flight IO. Well, I meant the recorded data to be used to simply not verify those frames. >=A0 Also with updates from Xen such as the wallclocks. This doesn't occur for a paused domain, does it? > The only way to fix the IO problem is to disconnect the blk/net rings > before doing the final sweep for frames, but that clobbers any ability > to restart the VM on the source side if things go wrong at the destinatio= n. >=20 > I don't have an answer at all for the vcpu info frames. Yeah, they fall in the same category as the FIFO control pages, as they contain evtchn_{pending_sel,upcall_pending}. Jan From xen-devel-bounces@lists.xenproject.org Mon Jul 05 10:44:49 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Jul 2021 10:44:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.150081.277547 (Exim 4.92) (envelope-from ) id 1m0M5l-0001gt-5H; Mon, 05 Jul 2021 10:44:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 150081.277547; Mon, 05 Jul 2021 10:44:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0M5l-0001gm-1N; Mon, 05 Jul 2021 10:44:45 +0000 Received: by outflank-mailman (input) for mailman id 150081; Mon, 05 Jul 2021 10:44:43 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0M5j-0001gg-6O for xen-devel@lists.xenproject.org; Mon, 05 Jul 2021 10:44:43 +0000 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 00a3a1dc-dd7e-11eb-8443-12813bfff9fa; Mon, 05 Jul 2021 10:44:41 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 00a3a1dc-dd7e-11eb-8443-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1625481881; h=to:cc:references:from:subject:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=WZgoO/N88GXBS4EXddYYKtNt5r8CubHfiMkmIG34IQY=; b=SaWXqiEL28e7a/+9ak4td8Ro4K62K+cyS6h4aP/+WryIxolDTIhnNlQ0 aFcrjhilXcXP6kZO2iZDEjmIcpOINAeF7BaBE9vCAthXDPhHLVJclROUv ha9hOcnp3SWJbYZjodQRRoRPTiwlf2S5vvQsvR9lj5Ly1RH1nkaJ7O9TQ 0=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: aZGOkHAP65Z7TLCZ3y+92o3HukE3WNTpIBNfCSoUw6t4JPqkbXpXj+Sh7L2/Po50EsxSlkfn/V FXOM1GvEbbv2pX53raBYmzIiVXKuYktWfD29DxG1zE+jai+rQCivSgeiIgZJ6LPmyAuZRWudU1 ADGIVz8P0+MNQH5R1yyHY2RVNX/eVkNkQuwbPrO37FIpk2MEcQMbfZOhtxbivIxB2Ihluet55G kwGOJPhllk+VLEqR34mfasj2I6n31WVyeIaQ2ghu+/J7soiFsLxSIc9d0GGdGKV440sFpv2tSa fPY= X-SBRS: 5.1 X-MesageID: 47574651 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:YYfz4a4to6hCpMw4nQPXwSOBI+orL9Y04lQ7vn2ZFiY7TiXIra yTdaoguCMc6AxxZJkh8erwXZVoMkmsiqKdhrNhQYtKPTOWxVdASbsN0WKM+UyZJ8STzJ876U 4kSdkFNDSSNykIsS+Z2njALz9I+rDum8rJ9ISuukuFDzsaD52Ihz0JejpzeXcGIjWua6BJdq Z0qvA33AZJLh8sH7WG7zQ+LqT+juyOsKijTQ8NBhYh5gXLpTS06ITiGxzd+hsFSTtAzZor7G CAymXCl+uemsD+7iWZ+37Y7pxQltek4txfBPaUgsxQDjn3kA6naKloRrXHljEop+OE7kosjb D30lgdFvU2z0mUUnC+oBPr1QWl+i0p8WXexViRhmamidDlRRohYvAxxr5xQ1/80Q4Nrdt82K VE0yayrJxMFy7Nmyz7+pzhSwxqrEypunAv+NRjz0C3abFuLYO5kLZvuH+8SPw7bWXHAcEcYa hT5fjnlbRrmQjwVQGegoEHq+bcLEjaHX+9MwM/U4KuomFrdUtCvjwlLfok7z89HaIGOu15Dt v/Q9JVfZF1P4UrhPFGdao8qfXeMB2FffuaChPtHb2gLtBeB07w X-IronPort-AV: E=Sophos;i="5.83,325,1616472000"; d="scan'208";a="47574651" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XqsGZoKNrtJELy6wMxAjFx4GZm3e1vwXRuVHc/Ouz6u8RhfXbfI5fsEidk209of5Dg+lsFhrRqdPi1XvZqviHzGkk56DXy0ELXpDQkcXIDv7D7lxDtqpuRqte8UnfBmWp+k2vPhk4lCq9f75UNAcY0JhL5oEaXJxUVa0/0koUIfPK2ElyKcxB2F8m1d5xeSIeJoMz3Ljwo7TRXsyoO3/yn6rrb6r0NmlxnWMvHJ5vWc0MzNkaJdLg/+xd3yapgx8HVJOe4hIY4XTtkyZhkFgawXACkLfUMlx2PWbL155Jc1454nj4XpzmB52+ZxrIRHksxgRo1WxolW/2IACFZBG9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WZgoO/N88GXBS4EXddYYKtNt5r8CubHfiMkmIG34IQY=; b=TA0auydDUJTXLmMaGS4kSlxN+kgf5164FH3TPFDvNyzXohjVMPgI4Gk2L+hdwQ01TW5AZu1HgxbTHct4u7lhZi+aqbfEjduRQ3VUOZHPE2GoHycrOAuHdPN+3RBIC0k+rDJm6wbdnQXkL9IehhfzJojLK3WxDjr5BIJcuZSfr9LeB30xo4AqFiwdqLneE5cbvaWz9bjLqtwvFhRzTPZKtGOR0/oh3aesHqw6htWhR1JDAvyWQaHzAz1rfx5CyKuEdOWRLdQ+3xhD2sKgfYaXAcEN8H2a9XfZoHxMEz7tHnO1yDbK0GxhYKNjEixhrroBEuOLSN5irihBRCYBEYuPOA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WZgoO/N88GXBS4EXddYYKtNt5r8CubHfiMkmIG34IQY=; b=Uwp9rmKeAJUGnTBTckYrKyVyi29D1aaCIaUc3N0GOLOlVZnQsjlSo4W4TPCf8rZtIBtuDIdtClwWb5sR5FSft5uz7ayF71dvyfYIntHndc4giVGZcmvhBjS8UcF9Bi2zDGYPwLwZRhKGppz1QE5/SyR6lSMi40XOUeVSITsqDAo= To: Olaf Hering , CC: Ian Jackson , Wei Liu , Juergen Gross References: <20210701095635.15648-1-olaf@aepfle.de> <20210701095635.15648-16-olaf@aepfle.de> From: Andrew Cooper Subject: Re: [PATCH v20210701 15/40] tools: prepare to allocate saverestore arrays once Message-ID: <644a7a4c-4fab-07be-2e69-2637254de859@citrix.com> Date: Mon, 5 Jul 2021 11:44:30 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 In-Reply-To: <20210701095635.15648-16-olaf@aepfle.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-GB X-ClientProxiedBy: LO2P265CA0376.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a3::28) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5c8151df-3452-4295-17fb-08d93fa1e250 X-MS-TrafficTypeDiagnostic: BY5PR03MB4999: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VK59J1gdmUNYuqZ6grJJ9qufdllN7yyGqBzQYXJdNHoK/Kno47F1O5YSatg4aFKiJZRfY4Hn5QoqAocHnvKkH9/bE+4bAf8nsVecEyPADYYlT7oAocGgw5QNZNK4a9RaBALR/RvQM+/2V9mjkAbF30B9Ebdvy62s6siq1c+L6fVwAd2oKds0Fku2SoGzqa/RqvVFNFrjevZO7JEuydsrzaUzKkcSEWqoCOdpmY8NggZe1Oqx/6npn5K6i2OBOFR5SIUjHqbFm67mrtJf7jYsjIUl3tcDSFc477p734niM8JaIQ+84yLhALKjwMC6mITJtCi2xjCAofP7j6b19jT6qWApKc3jhxk0vBhnQdKl/auedzSu+IYrQ4g5My3Jvnrumae2z5YLUtw+wzH+JuKx7vTi5652+bIqkoeXpG6X2hoeCxym/Su+33irOU78M1y6LlYlXTiK06tMUNiCz4GwX3cvk4lEkikD2ZwrSWtVSsIgA+E9acKcB+YZ7SKytFHCYu929UbHgtr4EhA1YhsWV+Ve/X7/SBm5paYdNr/YZ2Seeux2HB7nQj56PRPC1KfU5gstfe69IZLQbNWaLipZTgc7pT8VaSYInWQq72JkUdMLPdhxx0dFvkWiRxPb53bZF6gKJC+zGW1a2xu++WbtiBJz5rOGps4a6wyI/GzWPUBD1WrLM9AdS9fQryQLiGPhKh/3lg3lDv4YujGEn0wA8wFGyB5rB4vzT7De0zdC8Zw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(136003)(396003)(39860400002)(376002)(366004)(16576012)(31696002)(2616005)(8676002)(86362001)(2906002)(16526019)(36756003)(4326008)(54906003)(8936002)(956004)(53546011)(31686004)(83380400001)(38100700002)(186003)(66946007)(5660300002)(66556008)(66476007)(26005)(478600001)(6666004)(316002)(4001150100001)(6486002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?czVCQUdRSkFaSFl4UHhlTzJVMWI4dnh2UGJqeHFHTUZDN1pNQlVicmZ0K2RC?= =?utf-8?B?ZVg3cHh2cjh2cUY3bUN1TTFrN1pQZHFzRFFaWkZDcUxxazNwcW1oRDBBWW9m?= =?utf-8?B?R1MvaEJqb2tXdENEaDZKcjZERXNkMTdCMUlBQ20yblpIYmUzaGV5MTJTdXVl?= =?utf-8?B?L1hlUGN2TXIxakI5RlJyNzZCT283UlEwR0g4dFIvamVOaGYzdHZ3UTFuTDFj?= =?utf-8?B?ZVV0d2xET2lScVZKakZaM001cmxqOHpKRFcxWXgzV2xTdHpMVCs4ZzhmSjlq?= =?utf-8?B?NlN3bkVNVE02QWF6KzBvTDJPNUkycURETWdhODRuSEdWcW8rc09VRjF0bEdL?= =?utf-8?B?NTIwQVlxdFErUjV0dkxHd3EwSTdjSStldEdOSlVxelh0eml2ZTJOaHJQbC80?= =?utf-8?B?L0pwVjd6UFdCaWJEYmhzSHdCZG1POVM0SVQ0RG5ydGZUNFV1bUJzRjB4ckRO?= =?utf-8?B?OE82RFcwUmFpbTRZOHhZS1VCa2grM3VQOTZkR3kxKzE5SEc4MTV1NmVUN3NU?= =?utf-8?B?bjJNZDJGaDB2SUM4c1pEV2NYMXRNcHYxd1VWOEs5Nzg3ZWc4ZTZKcWdQaGUz?= =?utf-8?B?RVBqTVJnU09NOTkycHIzSmtWSE9LUlVvZWVpT2p5OEx0VitLWU5BYm9SZzNy?= =?utf-8?B?eWNobW94clVQblBTTll5b0FoMjJ1cFhUTDFjSzF6QnBJcDlnNGIrVnhSdWxl?= =?utf-8?B?bEVTODUvY2xSbVhsN3NDay9JN0lZMUM5NGRyU0dRM0gzeGxTSmZrVmpHZWg3?= =?utf-8?B?aitzL3ljby8zQ2dTT2cxY2ZINmhlS0xyYXAzam9uYmFPMVBDZzBPLzVNYlZz?= =?utf-8?B?NG9jNW8rWUhtRUV3a0VCZndQa3NZR2VHN3dFeTBNUmZScHdwa05XNEJOVlJw?= =?utf-8?B?ck9BeHNpalkxb1hPcUx3Skx6Skd4akRabm9UZUlUckorNG11M25TejJvaURx?= =?utf-8?B?QllGS1NEM2FFdzRhYTQ2a2NIU3pXbmpKRm5tMTJheVVaS0ZZOG9aS2hLWW5v?= =?utf-8?B?dVR4Ky9BeVRPQ2tLU1VtRktSMTg3aGRzMmFJN1N3K3FDamZpTk5xZHpNbjBZ?= =?utf-8?B?UXhxa2Q5cmxMcmo2Qk9kZGVrd1FSdDdoR1NlMW5CVmxSVmFOVXVlZHBSZ1pr?= =?utf-8?B?QkhKUHMxTkxiRUNIK1AyZ2N0NU9zTDNxTG1qdDVQazdJTGx2MFBxdVVrQ3R2?= =?utf-8?B?d2x1MS9YZU1Oa0pPTGVUYzFiUEk5M1VseGdZRXo2MllvU2ttaWZQQUIzVUZM?= =?utf-8?B?TTNyMExTV2cwbXBWUFNWRWVyLzVFbGJCWTUxbmsya3k4d2d1VDBOSkwyN05h?= =?utf-8?B?ZW1JNlZtZnVRYlFYMnJ5bERUcFJIZDlnVXI0TldPRFJiN0swSHJ1YjhwSjdI?= =?utf-8?B?MlVoRVl4a3pRMElTMzcwYmVxazByeWU0YWkzcFdMSG05bHhNK0dzMXFvZXhB?= =?utf-8?B?TUNJaFN4aTFYbWlQc3BCUGxBUHhvRys5cWFuNjlZOWEwcUNwWTkwRUFDTUMx?= =?utf-8?B?b3hrZDVUUXlTaEIrbnRXdk05QWo0UElvay8vdk83Uk5BcEs1ZVpkakdia0p6?= =?utf-8?B?QmM1aGs1K0xGVlNNZkRzaUgxM2orb0xTQ1RLeGtrZDF0cVVINlFWVmV6dGhD?= =?utf-8?B?bVY4S3prK1BOVThlcWRydjZlSmRaeTJTOXBRQUR2c3RKb3VQVVFlM1kvUThN?= =?utf-8?B?MytqYlhDbU9zNFIwWm4vWXIyclc5WHpnWEtKcU0rVjB1SzNaL1R1bnVHcnE1?= =?utf-8?Q?ykTs3epoS7MFISICitlhljIzEVPxZCnwqjMwsL3?= X-MS-Exchange-CrossTenant-Network-Message-Id: 5c8151df-3452-4295-17fb-08d93fa1e250 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2021 10:44:37.0739 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wQfLL0Qr7+PU3GC3+KoiKMlSbohfAyy1AODzKxVU6zaxYvUyKBlIwnG4M+yGUZ80ry36Cxqf9CteEHVhWRtp9arhZ6Dpd8+qcD3maDCj4Os= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR03MB4999 X-OriginatorOrg: citrix.com On 01/07/2021 10:56, Olaf Hering wrote: > The hotpath 'send_dirty_pages' is supposed to do just one thing: sending. > The other end 'handle_page_data' is supposed to do just receiving. > > But instead both do other costly work like memory allocations and data mo= ving. > Do the allocations once, the array sizes are a compiletime constant. > Avoid unneeded copying of data by receiving data directly into mapped gue= st memory. There is a reason why the logic was written that way, which was good at the time.=C2=A0 It was so valgrind could spot bugs with the memory handling in these functions (And it did indeed find many bugs during development). These days, its ASAN is perhaps the preferred tool, but both depend on dynamic allocations to figure out the actual size of various objects. I agree that the repeated alloc/free of same-sized memory regions on each iteration is a waste.=C2=A0 However, if we are going to fix this by using one-off allocations, then we want to compensate with logic such as the call to VALGRIND_MAKE_MEM_UNDEFINED() in flush_batch(), and I think we still need individual allocations to let the tools work properly. > > This patch is just prepartion, subsequent changes will populate the array= s. > > Once all changes are applied, migration of a busy HVM domU changes like t= hat: > > Without this series, from sr650 to sr950 (xen-4.15.20201027T173911.16a209= 63b3 xen_testing): > 2020-10-29 10:23:10.711+0000: xc: show_transfer_rate: 23663128 bytes + 28= 79563 pages in 55.324905335 sec, 203 MiB/sec: Internal error > 2020-10-29 10:23:35.115+0000: xc: show_transfer_rate: 16829632 bytes + 20= 97552 pages in 24.401179720 sec, 335 MiB/sec: Internal error > 2020-10-29 10:23:59.436+0000: xc: show_transfer_rate: 16829032 bytes + 20= 97478 pages in 24.319025928 sec, 336 MiB/sec: Internal error > 2020-10-29 10:24:23.844+0000: xc: show_transfer_rate: 16829024 bytes + 20= 97477 pages in 24.406992500 sec, 335 MiB/sec: Internal error > 2020-10-29 10:24:48.292+0000: xc: show_transfer_rate: 16828912 bytes + 20= 97463 pages in 24.446489027 sec, 335 MiB/sec: Internal error > 2020-10-29 10:25:01.816+0000: xc: show_transfer_rate: 16836080 bytes + 20= 98356 pages in 13.447091818 sec, 609 MiB/sec: Internal error > > With this series, from sr650 to sr950 (xen-4.15.20201027T173911.16a20963b= 3 xen_unstable): > 2020-10-28 21:26:05.074+0000: xc: show_transfer_rate: 23663128 bytes + 28= 79563 pages in 52.564054368 sec, 213 MiB/sec: Internal error > 2020-10-28 21:26:23.527+0000: xc: show_transfer_rate: 16830040 bytes + 20= 97603 pages in 18.450592015 sec, 444 MiB/sec: Internal error > 2020-10-28 21:26:41.926+0000: xc: show_transfer_rate: 16830944 bytes + 20= 97717 pages in 18.397862306 sec, 445 MiB/sec: Internal error > 2020-10-28 21:27:00.339+0000: xc: show_transfer_rate: 16829176 bytes + 20= 97498 pages in 18.411973339 sec, 445 MiB/sec: Internal error > 2020-10-28 21:27:18.643+0000: xc: show_transfer_rate: 16828592 bytes + 20= 97425 pages in 18.303326695 sec, 447 MiB/sec: Internal error > 2020-10-28 21:27:26.289+0000: xc: show_transfer_rate: 16835952 bytes + 20= 98342 pages in 7.579846749 sec, 1081 MiB/sec: Internal error These are good numbers, and clearly show that there is some value here, but shouldn't they be in the series header?=C2=A0 They're not terribly relevant to this patch specifically. Also, while I can believe that the first sample is slower than the later ones (in particular, during the first round, we've got to deal with the non-RAM regions too and therefore spend more time making hypercalls), I'm not sure I believe the final sample.=C2=A0 Given the byte/page count, t= he substantially smaller elapsed time looks suspicious. > Note: the performance improvement depends on the used network cards, > wirespeed and the host: > - No improvement is expected with a 1G link. > - Improvement can be seen as shown above on a 10G link. > - Just a slight improvment can be seen on a 100G link. Are these observations with an otherwise idle dom0? Even if CPU time in dom0 wasn't the bottlekneck with a 1G link, the reduction in CPU time you observe at higher link speeds will still be making a difference at 1G, and will probably be visible if you perform multiple concurrent migrations. ~Andrew From xen-devel-bounces@lists.xenproject.org Mon Jul 05 10:54:07 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Jul 2021 10:54:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.150087.277558 (Exim 4.92) (envelope-from ) id 1m0MEl-000391-1A; Mon, 05 Jul 2021 10:54:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 150087.277558; Mon, 05 Jul 2021 10:54:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0MEk-00038u-UD; Mon, 05 Jul 2021 10:54:02 +0000 Received: by outflank-mailman (input) for mailman id 150087; Mon, 05 Jul 2021 10:54:01 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0MEj-00038l-2A for xen-devel@lists.xenproject.org; Mon, 05 Jul 2021 10:54:01 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (unknown [40.107.6.76]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 4d73b6ca-dd7f-11eb-8443-12813bfff9fa; Mon, 05 Jul 2021 10:53:59 +0000 (UTC) Received: from DB6PR0301CA0047.eurprd03.prod.outlook.com (2603:10a6:4:54::15) by AM0PR08MB5379.eurprd08.prod.outlook.com (2603:10a6:208:182::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.22; Mon, 5 Jul 2021 10:53:57 +0000 Received: from DB5EUR03FT045.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:54:cafe::99) by DB6PR0301CA0047.outlook.office365.com (2603:10a6:4:54::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.30 via Frontend Transport; Mon, 5 Jul 2021 10:53:57 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT045.mail.protection.outlook.com (10.152.21.164) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.22 via Frontend Transport; Mon, 5 Jul 2021 10:53:57 +0000 Received: ("Tessian outbound c836dc7aad98:v97"); Mon, 05 Jul 2021 10:53:57 +0000 Received: from b2bb8182882d.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id A201E4F7-8D6C-4B6C-B8AD-CCA53AF65E40.1; Mon, 05 Jul 2021 10:53:31 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b2bb8182882d.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 05 Jul 2021 10:53:31 +0000 Received: from PAXPR08MB6446.eurprd08.prod.outlook.com (2603:10a6:102:12d::10) by PA4PR08MB5885.eurprd08.prod.outlook.com (2603:10a6:102:e6::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4242.18; Mon, 5 Jul 2021 10:53:30 +0000 Received: from PAXPR08MB6446.eurprd08.prod.outlook.com ([fe80::3184:5465:27b6:f27d]) by PAXPR08MB6446.eurprd08.prod.outlook.com ([fe80::3184:5465:27b6:f27d%9]) with mapi id 15.20.4264.026; Mon, 5 Jul 2021 10:53:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4d73b6ca-dd7f-11eb-8443-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OkcsiJcP6F56XnhvPG/wsuNtb6bp6G9uGerpnhBC/Fo=; b=DLEI/R/XNWstmfw63jxaj72witILXBsCz6/J3BLTCwRhpIeeUsGH05e56dF2pSqOY1DlxXTwSlJQX4hUjzjaab7nf+H2JgrZ9VscQFaFTr4EOv4gi/Q9KtJYsYWRcxKHl5rlaijIfycQ+BZWJHhhTRw7C2jL5rPbS2Q4574B8bw= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: 6a701badbc3a8e21 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IwBQOilq8RLXfby6JXkBkrWvhdRvf13K4zs/29IDJrzEiy7isPS5AH19luLly6a8BPRY0+7XWLDqFo2iZ+uxVtt9mV+RoMN+Gx0/95wGbji4RZD/jYjLDAUGVlqzg50W2izxTvf7hXYdf3VVbdKb+eLKWqCzDjUSk0uZj1inoASX0jFNGkl5K4uZhf9z/auLpsqjmaR9z+/dkOI3AeEOL9W/As9Sv65dpmHbaBvnSIj1DFWKLuPH5k/yipmKSPPn5h5rREcKygIo56lndd7MfE30VN+XJ1z67U/ZfIxauWlZ75cu4teVKbPg7YtQ7/sknneRZCtKFtqqCxaNaMvdqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OkcsiJcP6F56XnhvPG/wsuNtb6bp6G9uGerpnhBC/Fo=; b=CrpNsbvtPzmF3e2nlHQD/QWNUaT6uw8ZYihR2OF494V0rUK9rp9XG+dm88izp0EpfcfCS/I2BVWG6hUQpuoqSZdQAVk6PbIG0TD3LvvZSfqKdFjdVAKTWmW692szYavQb8MKkhgQX8xaPyBMAdbdKXjdIY1Jxl72WAFXUW+F/OmBUuegh3jLKzhNH/huOHEh7Igj/W3X2ea2tFhQJZ2PIYCLpfGyn0HA/PeVVBjzE7LJ5rmqsg4u2c+XHLBh+ueIduqABf5kjUbjiWrvLOZWjQDdfBAOytv6DQ0p7uBvs4VucyzIQ0qErupfPMN82TNVXvZhjuHCiA5zt+LuQhaZTg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OkcsiJcP6F56XnhvPG/wsuNtb6bp6G9uGerpnhBC/Fo=; b=DLEI/R/XNWstmfw63jxaj72witILXBsCz6/J3BLTCwRhpIeeUsGH05e56dF2pSqOY1DlxXTwSlJQX4hUjzjaab7nf+H2JgrZ9VscQFaFTr4EOv4gi/Q9KtJYsYWRcxKHl5rlaijIfycQ+BZWJHhhTRw7C2jL5rPbS2Q4574B8bw= From: Bertrand Marquis To: Michal Orzel CC: Xen-devel , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Wei Liu , Tamas K Lengyel , Alexandru Isaila , Petre Pircalabu Subject: Re: [PATCH v4] arm64: Change type of hsr, cpsr, spsr_el1 to uint64_t Thread-Topic: [PATCH v4] arm64: Change type of hsr, cpsr, spsr_el1 to uint64_t Thread-Index: AQHXcWiahpKBxAk9M0KFlQxmBieLeqs0NScA Date: Mon, 5 Jul 2021 10:53:30 +0000 Message-ID: <25CEAEF8-F0B3-4950-9465-9D1896C8266E@arm.com> References: <20210705063952.25629-1-michal.orzel@arm.com> In-Reply-To: <20210705063952.25629-1-michal.orzel@arm.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3654.100.0.2.22) Authentication-Results-Original: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [81.2.158.121] x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: 70481a3f-9a80-4a4c-560c-08d93fa3304c x-ms-traffictypediagnostic: PA4PR08MB5885:|AM0PR08MB5379: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:529;OLM:529; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: xFLtQ2tTmCh4ZGiJn/DE4OcLkzYLZVMsKnC5dFJ8KXGtHf82aaM+L7EdIX1zNxFI4t/agcakbI0VTkXwdFpnoGtNbGc77UonpnrQEFMcdlolzV41NeTyv3yRDw8u3dhEacxFCP21WbhaH9/LxfkupcGJmMncZLCQMh3+7xp0q2S1vfDBJJya1I55iZgQvqZJt4eW9kC+Dha/lKd7aAMEsdWAxG1QHcj3mJu2EEo/Zot5hXy0EYbHUlCuHb8lYxbWMnz3kMuN2TEyeanpIZfwoNHAtojn/iLfxZxC8a9OLWtcLVU0KzAr5m99d/LS8HU4pDUBCDZNA+xkL9p3pEhBGE1i3OHeJuUt88pSNg9McrrGHXszUUxycooq7FdufmW3BcCUKTq09Y7D5lmiI71fBqj3CnvpXNoklVRqpBiGpeLNi76WLf6TgHeWrdKUNB42SeKkJTdApSC57LvjOILSef1iBePBII0hsIc1Et5mQGpjNSBQw8WdLKkG9z7vgTs23dGoJNIMUV9pQM26qt9/D6ZBBqsRptEMDIzEDvhApfLeen8UfwAZrnm+7ZA5+tGGUrXTZfPs4e8GX+7btGJZODy9YYhtco4wdaSXvUkbSMvbZnJKi8F+D7NQJRMdcJvP2y/PYWrT6VH8rTxK6F/60+DHu07axmftJfHydke4aBSUUD9XIhI/Zth3CrCJmMtn/nDt5nnU6nPMFI6zjK/FsQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB6446.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(396003)(136003)(346002)(366004)(39860400002)(122000001)(33656002)(36756003)(6512007)(7416002)(66946007)(6636002)(478600001)(8936002)(6486002)(5660300002)(83380400001)(2906002)(4326008)(6862004)(316002)(86362001)(66446008)(6506007)(71200400001)(2616005)(66556008)(26005)(53546011)(8676002)(54906003)(38100700002)(66476007)(37006003)(64756008)(91956017)(76116006)(186003)(30864003)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?N97vyftYVlliRprFCkCP7b/Xfm2oYk23MgYc8ZVp7bs3HV1Qawczg4OipwLQ?= =?us-ascii?Q?BgB0NlFscnJzHGy1RVkz3V/zyZFXQ/WYb/7yYBJoYM0Q6YCe+x4DGV+Ngku5?= =?us-ascii?Q?RwLFdyuAEYh29qeTnvoX3oK+kQTYYA/sxJeAQB75qZZdtDoU073vE5hj7Vgo?= =?us-ascii?Q?RzOgPTUobqAAq+iF2HX7GkTHw6eu8CJv1ApyL7ogmT85Wi2HvE4DY8GsxPz1?= =?us-ascii?Q?rDUdu8rvmoLCMbDWws/enspelqOL8WffXwyZ0INt8wgSsEE8ESokbRh58uWJ?= =?us-ascii?Q?FNCNqgbqSUmaLYAXBgamjPZdLEcrCxob9jqPcIn7mB7K33jt70stlnnW6dn4?= =?us-ascii?Q?kGryJTPcfE2bZQ8wz9SXl6tf4MRcncEYPmc5VccniBMlPvYmntaecdHb1NuH?= =?us-ascii?Q?5ghDA5zsc3/v34tA681OwooJTG7UdcO/Y87zXENQvIJ7ZXw8SDkVYgWdAbaq?= =?us-ascii?Q?zEgL8RxdOXr7273vSoIKSisuY7yfWTdzr6HpltlxlX71luGVRR2zgKkjYbix?= =?us-ascii?Q?tRxOEqpGKtbsXODnjPWDvO0F0IJO+hHUjpmgMaegVJwhnNkIx9C54RIy7dmI?= =?us-ascii?Q?6Ab4PIGxm4QXoZ5Mu2DifHsrbWiHk9YelDSb1W8RM0a/yd2TrMMoTp0r0rRI?= =?us-ascii?Q?iIkEyQRpshW/9McI8pFbXireIyIPjPlF2tRC6Fniojz07F9b5kJ6l4Iq/H68?= =?us-ascii?Q?c3uC3lApGGpb57hPqASqvKLBQxiaR6mwscLhyxdG9MKcHiO7+NcN5Fg+5h9l?= =?us-ascii?Q?2G1JIgur6goghYsb4LA3Dr6gFqezQmvb5TZk2wAe6zu6n0UtqvViqbWkhpjK?= =?us-ascii?Q?yIkYSYpifuxugX8jfzu/rty+v7K8Nh3KNaibv7HQAEtqSBp6mRdl/E136s7w?= =?us-ascii?Q?ey0k3g6qgO5f3rm/4XfxSXv0+tKNsAU3+6QUBZUYbF8qCkDBbG9SlAiXe4Gc?= =?us-ascii?Q?b1F4QLgwkHnOSUayI9EH+SQmdiPfAm5Kd7eDG29LVRm2xnU0IMD+PkeZYiPw?= =?us-ascii?Q?29MFeFvRmIII2DfHMDNtfPocZRj0w7jAE+73UF+4vTjRaj6Y5xM378GuFxnz?= =?us-ascii?Q?8fsIuV6CeYzCTW7S77Ze+VoQbb07M2IrpxkGGzGJjYqzH6R3RFkS77pxg0VX?= =?us-ascii?Q?9BCIgN2dTqmrDr3L8V21jA+8aU6B7QPKiYsR43Wezkkqd41C8aZdV1gBOt3c?= =?us-ascii?Q?5SztWRqcgIrd+mgK0Lw8am55VQMgImwUHEQvzbr9vIG5slak0bsFxn+Fk+my?= =?us-ascii?Q?LFOZ5CDd85e/dckt0pVihb2Y/jcmE58LpExGNCG6qr6bW3ritmqX3X3iKRun?= =?us-ascii?Q?XWQb8ZhySsyPy8YfXOsL+7+m?= Content-Type: multipart/alternative; boundary="_000_25CEAEF8F0B3495094659D1896C8266Earmcom_" MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB5885 Original-Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT045.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: a0387a28-1b91-46b5-4b41-08d93fa32039 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KefQUNq0cvzeD7sSmh0/RMGL9YdGNR0nLfZZpGzTXylSvSswj/81RgxoZ56KN4zKXqeKjs4Spv+PfHfzgP2bqPkipARjKm5KJ7+WnU8GOkIawAkGSszxu8Mr3GMwHZj/CumfFkQFQZxDAXr3i8+Fuw7Ca20Y5BiApEK5NzmlSJ8of/fQ7P0AV84EcnjwUD1g14cPBR4Pv/xsEogkCN8SJ5kMGwyodd8ldAUYSqgzRRSrK7eax8eaQ0JEpVB8VqRYvV32Bk7g+lYT8PtIqgXvBHZz4nTZf9tIWNKR3aLQNuIPBqFdmwO8eH+iMBP0+F0WkiPzE+Ghh07J8ZglBvYB68SbeSq/C3xBwck0U0zeFSV0i5JjJ5lcnMP8K/2JY70kVl2agvFn4YePZtHCG9uqoc1zvgzZDDs9s0AZ8Quf/fM/hvp4gXrmSgN3rY+hi5b+5gO+iEkk5nv+p3WSb2Pdz23teKJzdHzxGShj0eflddvkVsYL0jeWoOJQbzweDsweDf2zl3uVzwS1JMJz9Hx3BUGMLqfk+p4cYExpCiDrkZlAewMQJDG9fxGCTLZvi/zVSWjeTtyyt8MaauPPKb3eWYzdiYI4etSweJGpXjZjBQ14Tig576/+kfGy22mlGl7tpdJRQ6kf3QZt/Nf5qCDEV+g/1PaVUw9dZi3Ef+LKOdkHfWmvVrXFUl+NIHc4vM2x5wc/F3eZX2nQUgk2w9g9nQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(376002)(396003)(346002)(136003)(39860400002)(46966006)(36840700001)(6506007)(81166007)(86362001)(2906002)(47076005)(82740400003)(36756003)(36860700001)(53546011)(30864003)(33656002)(82310400003)(2616005)(107886003)(45080400002)(83380400001)(5660300002)(6512007)(336012)(4326008)(6862004)(54906003)(316002)(356005)(478600001)(37006003)(70586007)(6636002)(186003)(26005)(8936002)(70206006)(8676002)(6486002)(579004);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2021 10:53:57.2084 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 70481a3f-9a80-4a4c-560c-08d93fa3304c X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT045.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB5379 --_000_25CEAEF8F0B3495094659D1896C8266Earmcom_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Michal, On 5 Jul 2021, at 07:39, Michal Orzel > wrote: AArch64 registers are 64bit whereas AArch32 registers are 32bit or 64bit. MSR/MRS are expecting 64bit values thus we should get rid of helpers READ/WRITE_SYSREG32 in favour of using READ/WRITE_SYSREG. We should also use register_t type when reading sysregs which can correspond to uint64_t or uint32_t. Even though many AArch64 registers have upper 32bit reserved it does not mean that they can't be widen in the future. Modify type of hsr, cpsr, spsr_el1 to uint64_t. Previously we relied on the padding after spsr_el1. As we removed the padding, modify the union to be 64bit so we don't corrupt= spsr_fiq. No need to modify the assembly code because the accesses were based on 64bi= t registers as there was a 32bit padding after spsr_el1. Remove 32bit padding in cpu_user_regs before spsr_fiq as it is no longer needed due to upper union being 64bit now. Add 64bit padding in cpu_user_regs before spsr_el1 because the kernel frame should be 16-byte aligned. Change type of cpsr to uint64_t in the public outside interface "public/arch-arm.h" to allow ABI compatibility between 32bit and 64bit. Increment XEN_DOMCTL_INTERFACE_VERSION. Change type of cpsr to uint64_t in the public outside interface "public/vm_event.h" to allow ABI compatibility between 32bit and 64bit. Signed-off-by: Michal Orzel > Reviewed-by: Bertrand Marquis > Cheers Bertrand --- Changes since v3: -Fix comment about padding -Remove duplicated printk Changes since v2: -Remove _res0 members from structures inside hsr union -Update commit message -Modify type of cpsr to uint64_t in public/arch-arm.h -Increment XEN_DOMCTL_INTERFACE_VERSION Changes since v1: -Modify type of cpsr, spsr_el1 -Remove ifdefery in hsr union protecting _res0 members -Fix formatting of printk calls --- xen/arch/arm/arm64/entry.S | 4 ++-- xen/arch/arm/arm64/traps.c | 2 +- xen/arch/arm/arm64/vsysreg.c | 3 ++- xen/arch/arm/domain.c | 2 +- xen/arch/arm/traps.c | 28 ++++++++++++++------------- xen/arch/arm/vcpreg.c | 13 +++++++------ xen/include/asm-arm/arm64/processor.h | 11 ++++++----- xen/include/asm-arm/hsr.h | 2 +- xen/include/public/arch-arm.h | 4 ++-- xen/include/public/domctl.h | 2 +- xen/include/public/vm_event.h | 3 +-- 11 files changed, 39 insertions(+), 35 deletions(-) diff --git a/xen/arch/arm/arm64/entry.S b/xen/arch/arm/arm64/entry.S index ab9a65fc14..fc3811ad0a 100644 --- a/xen/arch/arm/arm64/entry.S +++ b/xen/arch/arm/arm64/entry.S @@ -155,7 +155,7 @@ add x21, sp, #UREGS_CPSR mrs x22, spsr_el2 mrs x23, esr_el2 - stp w22, w23, [x21] + stp x22, x23, [x21] .endm @@ -432,7 +432,7 @@ return_from_trap: msr daifset, #IFLAGS___I_ /* Mask interrupts */ ldr x21, [sp, #UREGS_PC] /* load ELR */ - ldr w22, [sp, #UREGS_CPSR] /* load SPSR */ + ldr x22, [sp, #UREGS_CPSR] /* load SPSR */ pop x0, x1 pop x2, x3 diff --git a/xen/arch/arm/arm64/traps.c b/xen/arch/arm/arm64/traps.c index babfc1d884..9113a15c7a 100644 --- a/xen/arch/arm/arm64/traps.c +++ b/xen/arch/arm/arm64/traps.c @@ -36,7 +36,7 @@ void do_bad_mode(struct cpu_user_regs *regs, int reason) union hsr hsr =3D { .bits =3D regs->hsr }; printk("Bad mode in %s handler detected\n", handler[reason]); - printk("ESR=3D0x%08"PRIx32": EC=3D%"PRIx32", IL=3D%"PRIx32", ISS=3D%"= PRIx32"\n", + printk("ESR=3D%#"PRIregister": EC=3D%"PRIx32", IL=3D%"PRIx32", ISS=3D= %"PRIx32"\n", hsr.bits, hsr.ec, hsr.len, hsr.iss); local_irq_disable(); diff --git a/xen/arch/arm/arm64/vsysreg.c b/xen/arch/arm/arm64/vsysreg.c index 41f18612c6..caf17174b8 100644 --- a/xen/arch/arm/arm64/vsysreg.c +++ b/xen/arch/arm/arm64/vsysreg.c @@ -368,7 +368,8 @@ void do_sysreg(struct cpu_user_regs *regs, sysreg.op2, sysreg.read ? "=3D>" : "<=3D", sysreg.reg, regs->pc); - gdprintk(XENLOG_ERR, "unhandled 64-bit sysreg access %#x\n", + gdprintk(XENLOG_ERR, + "unhandled 64-bit sysreg access %#"PRIregister"\n", hsr.bits & HSR_SYSREG_REGS_MASK); inject_undef_exception(regs, hsr); return; diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c index c021a03c61..74bdbb9082 100644 --- a/xen/arch/arm/domain.c +++ b/xen/arch/arm/domain.c @@ -845,7 +845,7 @@ static int is_guest_pv32_psr(uint32_t psr) #ifdef CONFIG_ARM_64 -static int is_guest_pv64_psr(uint32_t psr) +static int is_guest_pv64_psr(uint64_t psr) { if ( psr & PSR_MODE_BIT ) return 0; diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c index e7384381cc..4ccb6e7d18 100644 --- a/xen/arch/arm/traps.c +++ b/xen/arch/arm/traps.c @@ -546,7 +546,7 @@ void inject_undef64_exception(struct cpu_user_regs *reg= s, int instr_len) PSR_IRQ_MASK | PSR_DBG_MASK; regs->pc =3D handler; - WRITE_SYSREG32(esr.bits, ESR_EL1); + WRITE_SYSREG(esr.bits, ESR_EL1); } /* Inject an abort exception into a 64 bit guest */ @@ -580,7 +580,7 @@ static void inject_abt64_exception(struct cpu_user_regs= *regs, regs->pc =3D handler; WRITE_SYSREG(addr, FAR_EL1); - WRITE_SYSREG32(esr.bits, ESR_EL1); + WRITE_SYSREG(esr.bits, ESR_EL1); } static void inject_dabt64_exception(struct cpu_user_regs *regs, @@ -717,7 +717,7 @@ struct reg_ctxt { uint64_t vttbr_el2; }; -static const char *mode_string(uint32_t cpsr) +static const char *mode_string(register_t cpsr) { uint32_t mode; static const char *mode_strings[] =3D { @@ -762,7 +762,7 @@ static void show_registers_32(const struct cpu_user_reg= s *regs, printk(" %pS", _p(regs->pc)); printk("\n"); #endif - printk("CPSR: %08"PRIx32" MODE:%s\n", regs->cpsr, + printk("CPSR: %"PRIregister" MODE:%s\n", regs->cpsr, mode_string(regs->cpsr)); printk(" R0: %08"PRIx32" R1: %08"PRIx32" R2: %08"PRIx32" R3: %08"PR= Ix32"\n", regs->r0, regs->r1, regs->r2, regs->r3); @@ -846,7 +846,7 @@ static void show_registers_64(const struct cpu_user_reg= s *regs, { printk("SP: %016"PRIx64"\n", regs->sp); } - printk("CPSR: %08"PRIx32" MODE:%s\n", regs->cpsr, + printk("CPSR: %016"PRIx64" MODE:%s\n", regs->cpsr, mode_string(regs->cpsr)); printk(" X0: %016"PRIx64" X1: %016"PRIx64" X2: %016"PRIx64"\n", regs->x0, regs->x1, regs->x2); @@ -919,7 +919,7 @@ static void _show_registers(const struct cpu_user_regs = *regs, printk(" HCR_EL2: %"PRIregister"\n", READ_SYSREG(HCR_EL2)); printk(" TTBR0_EL2: %016"PRIx64"\n", READ_SYSREG64(TTBR0_EL2)); printk("\n"); - printk(" ESR_EL2: %08"PRIx32"\n", regs->hsr); + printk(" ESR_EL2: %"PRIregister"\n", regs->hsr); printk(" HPFAR_EL2: %"PRIregister"\n", READ_SYSREG(HPFAR_EL2)); #ifdef CONFIG_ARM_32 @@ -1599,7 +1599,7 @@ static const unsigned short cc_map[16] =3D { int check_conditional_instr(struct cpu_user_regs *regs, const union hsr hsr= ) { - unsigned long cpsr, cpsr_cond; + register_t cpsr, cpsr_cond; int cond; /* @@ -1661,7 +1661,7 @@ int check_conditional_instr(struct cpu_user_regs *reg= s, const union hsr hsr) void advance_pc(struct cpu_user_regs *regs, const union hsr hsr) { - unsigned long itbits, cond, cpsr =3D regs->cpsr; + register_t itbits, cond, cpsr =3D regs->cpsr; bool is_thumb =3D psr_mode_is_32bit(regs) && (cpsr & PSR_THUMB); if ( is_thumb && (cpsr & PSR_IT_MASK) ) @@ -2004,13 +2004,15 @@ static void do_trap_stage2_abort_guest(struct cpu_u= ser_regs *regs, break; default: - gprintk(XENLOG_WARNING, "Unsupported FSC: HSR=3D%#x DFSC=3D%#x\n", + gprintk(XENLOG_WARNING, + "Unsupported FSC: HSR=3D%#"PRIregister" DFSC=3D%#x\n", hsr.bits, xabt.fsc); } inject_abt: - gdprintk(XENLOG_DEBUG, "HSR=3D0x%x pc=3D%#"PRIregister" gva=3D%#"PRIva= ddr - " gpa=3D%#"PRIpaddr"\n", hsr.bits, regs->pc, gva, gpa); + gdprintk(XENLOG_DEBUG, + "HSR=3D%#"PRIregister" pc=3D%#"PRIregister" gva=3D%#"PRIvaddr= " gpa=3D%#"PRIpaddr"\n", + hsr.bits, regs->pc, gva, gpa); if ( is_data ) inject_dabt_exception(regs, gva, hsr.len); else @@ -2204,7 +2206,7 @@ void do_trap_guest_sync(struct cpu_user_regs *regs) default: gprintk(XENLOG_WARNING, - "Unknown Guest Trap. HSR=3D0x%x EC=3D0x%x IL=3D%x Syndrome= =3D0x%"PRIx32"\n", + "Unknown Guest Trap. HSR=3D%#"PRIregister" EC=3D0x%x IL=3D= %x Syndrome=3D0x%"PRIx32"\n", hsr.bits, hsr.ec, hsr.len, hsr.iss); inject_undef_exception(regs, hsr); } @@ -2242,7 +2244,7 @@ void do_trap_hyp_sync(struct cpu_user_regs *regs) break; } default: - printk("Hypervisor Trap. HSR=3D0x%x EC=3D0x%x IL=3D%x Syndrome=3D0= x%"PRIx32"\n", + printk("Hypervisor Trap. HSR=3D%#"PRIregister" EC=3D0x%x IL=3D%x S= yndrome=3D0x%"PRIx32"\n", hsr.bits, hsr.ec, hsr.len, hsr.iss); do_unexpected_trap("Hypervisor", regs); } diff --git a/xen/arch/arm/vcpreg.c b/xen/arch/arm/vcpreg.c index 55351fc087..f0cdcc8a54 100644 --- a/xen/arch/arm/vcpreg.c +++ b/xen/arch/arm/vcpreg.c @@ -385,7 +385,7 @@ void do_cp15_32(struct cpu_user_regs *regs, const union= hsr hsr) "%s p15, %d, r%d, cr%d, cr%d, %d @ 0x%"PRIregister"\n", cp32.read ? "mrc" : "mcr", cp32.op1, cp32.reg, cp32.crn, cp32.crm, cp32.op2, regs->pc= ); - gdprintk(XENLOG_ERR, "unhandled 32-bit CP15 access %#x\n", + gdprintk(XENLOG_ERR, "unhandled 32-bit CP15 access %#"PRIregister"= \n", hsr.bits & HSR_CP32_REGS_MASK); inject_undef_exception(regs, hsr); return; @@ -454,7 +454,8 @@ void do_cp15_64(struct cpu_user_regs *regs, const union= hsr hsr) "%s p15, %d, r%d, r%d, cr%d @ 0x%"PRIregister"\n", cp64.read ? "mrrc" : "mcrr", cp64.op1, cp64.reg1, cp64.reg2, cp64.crm, regs->pc); - gdprintk(XENLOG_ERR, "unhandled 64-bit CP15 access %#x\n", + gdprintk(XENLOG_ERR, + "unhandled 64-bit CP15 access %#"PRIregister"\n", hsr.bits & HSR_CP64_REGS_MASK); inject_undef_exception(regs, hsr); return; @@ -585,7 +586,7 @@ void do_cp14_32(struct cpu_user_regs *regs, const union= hsr hsr) "%s p14, %d, r%d, cr%d, cr%d, %d @ 0x%"PRIregister"\n", cp32.read ? "mrc" : "mcr", cp32.op1, cp32.reg, cp32.crn, cp32.crm, cp32.op2, regs->p= c); - gdprintk(XENLOG_ERR, "unhandled 32-bit cp14 access %#x\n", + gdprintk(XENLOG_ERR, "unhandled 32-bit cp14 access %#"PRIregister"= \n", hsr.bits & HSR_CP32_REGS_MASK); inject_undef_exception(regs, hsr); return; @@ -627,7 +628,7 @@ void do_cp14_64(struct cpu_user_regs *regs, const union= hsr hsr) "%s p14, %d, r%d, r%d, cr%d @ 0x%"PRIregister"\n", cp64.read ? "mrrc" : "mcrr", cp64.op1, cp64.reg1, cp64.reg2, cp64.crm, regs->pc); - gdprintk(XENLOG_ERR, "unhandled 64-bit CP14 access %#x\n", + gdprintk(XENLOG_ERR, "unhandled 64-bit CP14 access %#"PRIregister"\n", hsr.bits & HSR_CP64_REGS_MASK); inject_undef_exception(regs, hsr); } @@ -658,7 +659,7 @@ void do_cp14_dbg(struct cpu_user_regs *regs, const unio= n hsr hsr) "%s p14, %d, r%d, r%d, cr%d @ 0x%"PRIregister"\n", cp64.read ? "mrrc" : "mcrr", cp64.op1, cp64.reg1, cp64.reg2, cp64.crm, regs->pc); - gdprintk(XENLOG_ERR, "unhandled 64-bit CP14 DBG access %#x\n", + gdprintk(XENLOG_ERR, "unhandled 64-bit CP14 DBG access %#"PRIregister"= \n", hsr.bits & HSR_CP64_REGS_MASK); inject_undef_exception(regs, hsr); @@ -692,7 +693,7 @@ void do_cp10(struct cpu_user_regs *regs, const union hs= r hsr) "%s p10, %d, r%d, cr%d, cr%d, %d @ 0x%"PRIregister"\n", cp32.read ? "mrc" : "mcr", cp32.op1, cp32.reg, cp32.crn, cp32.crm, cp32.op2, regs->pc= ); - gdprintk(XENLOG_ERR, "unhandled 32-bit CP10 access %#x\n", + gdprintk(XENLOG_ERR, "unhandled 32-bit CP10 access %#"PRIregister"= \n", hsr.bits & HSR_CP32_REGS_MASK); inject_undef_exception(regs, hsr); return; diff --git a/xen/include/asm-arm/arm64/processor.h b/xen/include/asm-arm/ar= m64/processor.h index 81dfc5e615..c749f80ad9 100644 --- a/xen/include/asm-arm/arm64/processor.h +++ b/xen/include/asm-arm/arm64/processor.h @@ -63,18 +63,19 @@ struct cpu_user_regs /* Return address and mode */ __DECL_REG(pc, pc32); /* ELR_EL2 */ - uint32_t cpsr; /* SPSR_EL2 */ - uint32_t hsr; /* ESR_EL2 */ + uint64_t cpsr; /* SPSR_EL2 */ + uint64_t hsr; /* ESR_EL2 */ + + /* The kernel frame should be 16-byte aligned. */ + uint64_t pad0; /* Outer guest frame only from here on... */ union { - uint32_t spsr_el1; /* AArch64 */ + uint64_t spsr_el1; /* AArch64 */ uint32_t spsr_svc; /* AArch32 */ }; - uint32_t pad1; /* Doubleword-align the user half of the frame */ - /* AArch32 guests only */ uint32_t spsr_fiq, spsr_irq, spsr_und, spsr_abt; diff --git a/xen/include/asm-arm/hsr.h b/xen/include/asm-arm/hsr.h index 29d4531f40..9b91b28c48 100644 --- a/xen/include/asm-arm/hsr.h +++ b/xen/include/asm-arm/hsr.h @@ -16,7 +16,7 @@ enum dabt_size { }; union hsr { - uint32_t bits; + register_t bits; struct { unsigned long iss:25; /* Instruction Specific Syndrome */ unsigned long len:1; /* Instruction length */ diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h index 713fd65317..64a2ca30da 100644 --- a/xen/include/public/arch-arm.h +++ b/xen/include/public/arch-arm.h @@ -267,10 +267,10 @@ struct vcpu_guest_core_regs /* Return address and mode */ __DECL_REG(pc64, pc32); /* ELR_EL2 */ - uint32_t cpsr; /* SPSR_EL2 */ + uint64_t cpsr; /* SPSR_EL2 */ union { - uint32_t spsr_el1; /* AArch64 */ + uint64_t spsr_el1; /* AArch64 */ uint32_t spsr_svc; /* AArch32 */ }; diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h index 4dbf107785..d576bfabd6 100644 --- a/xen/include/public/domctl.h +++ b/xen/include/public/domctl.h @@ -38,7 +38,7 @@ #include "hvm/save.h" #include "memory.h" -#define XEN_DOMCTL_INTERFACE_VERSION 0x00000013 +#define XEN_DOMCTL_INTERFACE_VERSION 0x00000014 /* * NB. xen_domctl.domain is an IN/OUT parameter for this operation. diff --git a/xen/include/public/vm_event.h b/xen/include/public/vm_event.h index 36135ba4f1..bb003d21d0 100644 --- a/xen/include/public/vm_event.h +++ b/xen/include/public/vm_event.h @@ -266,8 +266,7 @@ struct vm_event_regs_arm { uint64_t ttbr1; uint64_t ttbcr; uint64_t pc; - uint32_t cpsr; - uint32_t _pad; + uint64_t cpsr; }; /* -- 2.29.0 --_000_25CEAEF8F0B3495094659D1896C8266Earmcom_ Content-Type: text/html; charset="us-ascii" Content-ID: <2C7FA049B28F4A4BB5F98B5C5F421812@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable Hi Michal,

On 5 Jul 2021, at 07:39, Michal Orzel <michal.orzel@arm.com> wrote:

AArch64 registers are 64bit whereas AArch32 registers
are 32bit or 64bit. MSR/MRS are expecting 64bit values thus
we should get rid of helpers READ/WRITE_SYSREG32
in favour of using READ/WRITE_SYSREG.
We should also use register_t type when reading sysregs
which can correspond to uint64_t or uint32_t.
Even though many AArch64 registers have upper 32bit reserved
it does not mean that they can't be widen in the future.

Modify type of hsr, cpsr, spsr_el1 to uint64_t.
Previously we relied on the padding after spsr_el1.
As we removed the padding, modify the union to be 64bit so we don't corrupt= spsr_fiq.
No need to modify the assembly code because the accesses were based on 64bi= t
registers as there was a 32bit padding after spsr_el1.

Remove 32bit padding in cpu_user_regs before spsr_fiq
as it is no longer needed due to upper union being 64bit now.
Add 64bit padding in cpu_user_regs before spsr_el1
because the kernel frame should be 16-byte aligned.

Change type of cpsr to uint64_t in the public outside interface
"public/arch-arm.h" to allow ABI compatibility between 32bit and = 64bit.
Increment XEN_DOMCTL_INTERFACE_VERSION.

Change type of cpsr to uint64_t in the public outside interface
"public/vm_event.h" to allow ABI compatibility between 32bit and = 64bit.

Signed-off-by: Michal Orzel <michal.orzel@arm.com>
Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>

Cheers
Bertrand

---
Changes since v3:
-Fix comment about padding
-Remove duplicated printk
Changes since v2:
-Remove _res0 members from structures inside hsr union
-Update commit message
-Modify type of cpsr to uint64_t in public/arch-arm.h
-Increment XEN_DOMCTL_INTERFACE_VERSION
Changes since v1:
-Modify type of cpsr, spsr_el1
-Remove ifdefery in hsr union protecting _res0 members
-Fix formatting of printk calls
---
xen/arch/arm/arm64/entry.S         =    |  4 ++--
xen/arch/arm/arm64/traps.c         =    |  2 +-
xen/arch/arm/arm64/vsysreg.c        &nbs= p; |  3 ++-
xen/arch/arm/domain.c          = ;       |  2 +-
xen/arch/arm/traps.c          =         | 28 ++++++++++++++--------= -----
xen/arch/arm/vcpreg.c          = ;       | 13 +++++++------
xen/include/asm-arm/arm64/processor.h | 11 ++++++-----
xen/include/asm-arm/hsr.h         &= nbsp;   |  2 +-
xen/include/public/arch-arm.h        &nb= sp;|  4 ++--
xen/include/public/domctl.h         = ;  |  2 +-
xen/include/public/vm_event.h        &nb= sp;|  3 +--
11 files changed, 39 insertions(+), 35 deletions(-)

diff --git a/xen/arch/arm/arm64/entry.S b/xen/arch/arm/arm64/entry.S
index ab9a65fc14..fc3811ad0a 100644
--- a/xen/arch/arm/arm64/entry.S
+++ b/xen/arch/arm/arm64/entry.S
@@ -155,7 +155,7 @@
        add     = ;x21, sp, #UREGS_CPSR
        mrs     = ;x22, spsr_el2
        mrs     = ;x23, esr_el2
-        stp     w22= , w23, [x21]
+        stp     x22= , x23, [x21]

        .endm

@@ -432,7 +432,7 @@ return_from_trap:
        msr     = ;daifset, #IFLAGS___I_ /* Mask interrupts */

        ldr     = ;x21, [sp, #UREGS_PC]          = ;  /* load ELR */
-        ldr     w22= , [sp, #UREGS_CPSR]          /= * load SPSR */
+        ldr     x22= , [sp, #UREGS_CPSR]          /= * load SPSR */

        pop     = ;x0, x1
        pop     = ;x2, x3
diff --git a/xen/arch/arm/arm64/traps.c b/xen/arch/arm/arm64/traps.c
index babfc1d884..9113a15c7a 100644
--- a/xen/arch/arm/arm64/traps.c
+++ b/xen/arch/arm/arm64/traps.c
@@ -36,7 +36,7 @@ void do_bad_mode(struct cpu_user_regs *regs, int reason)<= br class=3D"">     union hsr hsr =3D { .bits =3D regs->hsr };

    printk("Bad mode in %s handler detected\n"= ;, handler[reason]);
-    printk("ESR=3D0x%08"PRIx32":  EC=3D= %"PRIx32", IL=3D%"PRIx32", ISS=3D%"PRIx32"\n&= quot;,
+    printk("ESR=3D%#"PRIregister":  EC= =3D%"PRIx32", IL=3D%"PRIx32", ISS=3D%"PRIx32"= \n",
           hsr.bits,= hsr.ec, hsr.len, hsr.iss);

    local_irq_disable();
diff --git a/xen/arch/arm/arm64/vsysreg.c b/xen/arch/arm/arm64/vsysreg.c index 41f18612c6..caf17174b8 100644
--- a/xen/arch/arm/arm64/vsysreg.c
+++ b/xen/arch/arm/arm64/vsysreg.c
@@ -368,7 +368,8 @@ void do_sysreg(struct cpu_user_regs *regs,
            &nb= sp;        sysreg.op2,
            &nb= sp;        sysreg.read ? "=3D&= gt;" : "<=3D",
            &nb= sp;        sysreg.reg, regs->pc)= ;
-            gdprint= k(XENLOG_ERR, "unhandled 64-bit sysreg access %#x\n",
+            gdprint= k(XENLOG_ERR,
+             &= nbsp;       "unhandled 64-bit sysre= g access %#"PRIregister"\n",
            &nb= sp;        hsr.bits & HSR_SYSRE= G_REGS_MASK);
            inj= ect_undef_exception(regs, hsr);
            ret= urn;
diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
index c021a03c61..74bdbb9082 100644
--- a/xen/arch/arm/domain.c
+++ b/xen/arch/arm/domain.c
@@ -845,7 +845,7 @@ static int is_guest_pv32_psr(uint32_t psr)


#ifdef CONFIG_ARM_64
-static int is_guest_pv64_psr(uint32_t psr)
+static int is_guest_pv64_psr(uint64_t psr)
{
    if ( psr & PSR_MODE_BIT )
        return 0;
diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c
index e7384381cc..4ccb6e7d18 100644
--- a/xen/arch/arm/traps.c
+++ b/xen/arch/arm/traps.c
@@ -546,7 +546,7 @@ void inject_undef64_exception(struct cpu_user_regs *reg= s, int instr_len)
        PSR_IRQ_MASK | PSR_DBG_MASK= ;
    regs->pc =3D handler;

-    WRITE_SYSREG32(esr.bits, ESR_EL1);
+    WRITE_SYSREG(esr.bits, ESR_EL1);
}

/* Inject an abort exception into a 64 bit guest */
@@ -580,7 +580,7 @@ static void inject_abt64_exception(struct cpu_user_regs= *regs,
    regs->pc =3D handler;

    WRITE_SYSREG(addr, FAR_EL1);
-    WRITE_SYSREG32(esr.bits, ESR_EL1);
+    WRITE_SYSREG(esr.bits, ESR_EL1);
}

static void inject_dabt64_exception(struct cpu_user_regs *regs,
@@ -717,7 +717,7 @@ struct reg_ctxt {
    uint64_t vttbr_el2;
};

-static const char *mode_string(uint32_t cpsr)
+static const char *mode_string(register_t cpsr)
{
    uint32_t mode;
    static const char *mode_strings[] =3D {
@@ -762,7 +762,7 @@ static void show_registers_32(const struct cpu_user_reg= s *regs,
        printk(" %pS", _p= (regs->pc));
    printk("\n");
#endif
-    printk("CPSR:   %08"PRIx32" MO= DE:%s\n", regs->cpsr,
+    printk("CPSR:   %"PRIregister"= MODE:%s\n", regs->cpsr,
           mode_stri= ng(regs->cpsr));
    printk("     R0: %08"= PRIx32" R1: %08"PRIx32" R2: %08"PRIx32" R3: %08&qu= ot;PRIx32"\n",
           regs->= r0, regs->r1, regs->r2, regs->r3);
@@ -846,7 +846,7 @@ static void show_registers_64(const struct cpu_user_reg= s *regs,
    {
        printk("SP:  &nbs= p;  %016"PRIx64"\n", regs->sp);
    }
-    printk("CPSR:   %08"PRIx32" MO= DE:%s\n", regs->cpsr,
+    printk("CPSR:   %016"PRIx64" M= ODE:%s\n", regs->cpsr,
           mode_stri= ng(regs->cpsr));
    printk("     X0: %016"= ;PRIx64"  X1: %016"PRIx64"  X2: %016"PRIx64&q= uot;\n",
           regs->= x0, regs->x1, regs->x2);
@@ -919,7 +919,7 @@ static void _show_registers(const struct cpu_user_regs = *regs,
    printk("   HCR_EL2: %"PRIregist= er"\n", READ_SYSREG(HCR_EL2));
    printk(" TTBR0_EL2: %016"PRIx64"\n&q= uot;, READ_SYSREG64(TTBR0_EL2));
    printk("\n");
-    printk("   ESR_EL2: %08"PRIx32"= ;\n", regs->hsr);
+    printk("   ESR_EL2: %"PRIregister&q= uot;\n", regs->hsr);
    printk(" HPFAR_EL2: %"PRIregister"\n= ", READ_SYSREG(HPFAR_EL2));

#ifdef CONFIG_ARM_32
@@ -1599,7 +1599,7 @@ static const unsigned short cc_map[16] =3D {

int check_conditional_instr(struct cpu_user_regs *regs, const union hsr hsr= )
{
-    unsigned long cpsr, cpsr_cond;
+    register_t cpsr, cpsr_cond;
    int cond;

    /*
@@ -1661,7 +1661,7 @@ int check_conditional_instr(struct cpu_user_regs *reg= s, const union hsr hsr)

void advance_pc(struct cpu_user_regs *regs, const union hsr hsr)
{
-    unsigned long itbits, cond, cpsr =3D regs->cpsr;
+    register_t itbits, cond, cpsr =3D regs->cpsr;
    bool is_thumb =3D psr_mode_is_32bit(regs) &&= ; (cpsr & PSR_THUMB);

    if ( is_thumb && (cpsr & PSR_IT_MASK) )=
@@ -2004,13 +2004,15 @@ static void do_trap_stage2_abort_guest(struct cpu_u= ser_regs *regs,

        break;
    default:
-        gprintk(XENLOG_WARNING, "U= nsupported FSC: HSR=3D%#x DFSC=3D%#x\n",
+        gprintk(XENLOG_WARNING,
+             &= nbsp;  "Unsupported FSC: HSR=3D%#"PRIregister" DFS= C=3D%#x\n",
            &nb= sp;   hsr.bits, xabt.fsc);
    }

inject_abt:
-    gdprintk(XENLOG_DEBUG, "HSR=3D0x%x pc=3D%#"PR= Iregister" gva=3D%#"PRIvaddr
-             &= quot; gpa=3D%#"PRIpaddr"\n", hsr.bits, regs->pc, gva, gpa= );
+    gdprintk(XENLOG_DEBUG,
+             &= quot;HSR=3D%#"PRIregister" pc=3D%#"PRIregister" gva=3D%= #"PRIvaddr" gpa=3D%#"PRIpaddr"\n",
+             h= sr.bits, regs->pc, gva, gpa);
    if ( is_data )
        inject_dabt_exception(regs,= gva, hsr.len);
    else
@@ -2204,7 +2206,7 @@ void do_trap_guest_sync(struct cpu_user_regs *regs)
    default:
        gprintk(XENLOG_WARNING,
-             &= nbsp;  "Unknown Guest Trap. HSR=3D0x%x EC=3D0x%x IL=3D%x Syn= drome=3D0x%"PRIx32"\n",
+             &= nbsp;  "Unknown Guest Trap. HSR=3D%#"PRIregister" = EC=3D0x%x IL=3D%x Syndrome=3D0x%"PRIx32"\n",
            &nb= sp;   hsr.bits, hsr.ec, hsr.len, hsr.iss);
        inject_undef_exception(regs= , hsr);
    }
@@ -2242,7 +2244,7 @@ void do_trap_hyp_sync(struct cpu_user_regs *regs)
        break;
    }
    default:
-        printk("Hypervisor Trap. H= SR=3D0x%x EC=3D0x%x IL=3D%x Syndrome=3D0x%"PRIx32"\n",
+        printk("Hypervisor Trap. H= SR=3D%#"PRIregister" EC=3D0x%x IL=3D%x Syndrome=3D0x%"PRIx32= "\n",
            &nb= sp;  hsr.bits, hsr.ec, hsr.len, hsr.iss);
        do_unexpected_trap("Hy= pervisor", regs);
    }
diff --git a/xen/arch/arm/vcpreg.c b/xen/arch/arm/vcpreg.c
index 55351fc087..f0cdcc8a54 100644
--- a/xen/arch/arm/vcpreg.c
+++ b/xen/arch/arm/vcpreg.c
@@ -385,7 +385,7 @@ void do_cp15_32(struct cpu_user_regs *regs, const union= hsr hsr)
            &nb= sp;    "%s p15, %d, r%d, cr%d, cr%d, %d @ 0x%"= ;PRIregister"\n",
            &nb= sp;    cp32.read ? "mrc" : "mcr",             &nb= sp;    cp32.op1, cp32.reg, cp32.crn, cp32.crm, cp32.op2= , regs->pc);
-        gdprintk(XENLOG_ERR, "unha= ndled 32-bit CP15 access %#x\n",
+        gdprintk(XENLOG_ERR, "unha= ndled 32-bit CP15 access %#"PRIregister"\n",
            &nb= sp;    hsr.bits & HSR_CP32_REGS_MASK);
        inject_undef_exception(regs= , hsr);
        return;
@@ -454,7 +454,8 @@ void do_cp15_64(struct cpu_user_regs *regs, const union= hsr hsr)
            &nb= sp;        "%s p15, %d, r%d, r= %d, cr%d @ 0x%"PRIregister"\n",
            &nb= sp;        cp64.read ? "mrrc&q= uot; : "mcrr",
            &nb= sp;        cp64.op1, cp64.reg1, cp6= 4.reg2, cp64.crm, regs->pc);
-            gdprint= k(XENLOG_ERR, "unhandled 64-bit CP15 access %#x\n",
+            gdprint= k(XENLOG_ERR,
+             &= nbsp;       "unhandled 64-bit CP15 = access %#"PRIregister"\n",
            &nb= sp;        hsr.bits & HSR_CP64_= REGS_MASK);
            inj= ect_undef_exception(regs, hsr);
            ret= urn;
@@ -585,7 +586,7 @@ void do_cp14_32(struct cpu_user_regs *regs, const union= hsr hsr)
            &nb= sp;    "%s p14, %d, r%d, cr%d, cr%d, %d @ 0x%"= ;PRIregister"\n",
            &nb= sp;     cp32.read ? "mrc" : "mcr&qu= ot;,
            &nb= sp;     cp32.op1, cp32.reg, cp32.crn, cp32.crm, cp= 32.op2, regs->pc);
-        gdprintk(XENLOG_ERR, "unha= ndled 32-bit cp14 access %#x\n",
+        gdprintk(XENLOG_ERR, "unha= ndled 32-bit cp14 access %#"PRIregister"\n",
            &nb= sp;    hsr.bits & HSR_CP32_REGS_MASK);
        inject_undef_exception(regs= , hsr);
        return;
@@ -627,7 +628,7 @@ void do_cp14_64(struct cpu_user_regs *regs, const union= hsr hsr)
            &nb= sp;"%s p14, %d, r%d, r%d, cr%d @ 0x%"PRIregister"\n",             &nb= sp;cp64.read ? "mrrc" : "mcrr",
            &nb= sp;cp64.op1, cp64.reg1, cp64.reg2, cp64.crm, regs->pc);
-    gdprintk(XENLOG_ERR, "unhandled 64-bit CP14 access= %#x\n",
+    gdprintk(XENLOG_ERR, "unhandled 64-bit CP14 access= %#"PRIregister"\n",
            &nb= sp;hsr.bits & HSR_CP64_REGS_MASK);
    inject_undef_exception(regs, hsr);
}
@@ -658,7 +659,7 @@ void do_cp14_dbg(struct cpu_user_regs *regs, const unio= n hsr hsr)
            &nb= sp;"%s p14, %d, r%d, r%d, cr%d @ 0x%"PRIregister"\n",             &nb= sp;cp64.read ? "mrrc" : "mcrr",
            &nb= sp;cp64.op1, cp64.reg1, cp64.reg2, cp64.crm, regs->pc);
-    gdprintk(XENLOG_ERR, "unhandled 64-bit CP14 DBG ac= cess %#x\n",
+    gdprintk(XENLOG_ERR, "unhandled 64-bit CP14 DBG ac= cess %#"PRIregister"\n",
            &nb= sp;hsr.bits & HSR_CP64_REGS_MASK);

    inject_undef_exception(regs, hsr);
@@ -692,7 +693,7 @@ void do_cp10(struct cpu_user_regs *regs, const union hs= r hsr)
            &nb= sp;    "%s p10, %d, r%d, cr%d, cr%d, %d @ 0x%"= ;PRIregister"\n",
            &nb= sp;    cp32.read ? "mrc" : "mcr",             &nb= sp;    cp32.op1, cp32.reg, cp32.crn, cp32.crm, cp32.op2= , regs->pc);
-        gdprintk(XENLOG_ERR, "unha= ndled 32-bit CP10 access %#x\n",
+        gdprintk(XENLOG_ERR, "unha= ndled 32-bit CP10 access %#"PRIregister"\n",
            &nb= sp;    hsr.bits & HSR_CP32_REGS_MASK);
        inject_undef_exception(regs= , hsr);
        return;
diff --git a/xen/include/asm-arm/arm64/processor.h b/xen/include/asm-arm/ar= m64/processor.h
index 81dfc5e615..c749f80ad9 100644
--- a/xen/include/asm-arm/arm64/processor.h
+++ b/xen/include/asm-arm/arm64/processor.h
@@ -63,18 +63,19 @@ struct cpu_user_regs

    /* Return address and mode */
    __DECL_REG(pc,       =     pc32);        &n= bsp;    /* ELR_EL2 */
-    uint32_t cpsr;       &nbs= p;            &= nbsp;         /* SPSR_EL2 */ -    uint32_t hsr;        = ;            &n= bsp;          /* ESR_EL2 = */
+    uint64_t cpsr;       &nbs= p;            &= nbsp;         /* SPSR_EL2 */ +    uint64_t hsr;        = ;            &n= bsp;          /* ESR_EL2 = */
+
+    /* The kernel frame should be 16-byte aligned. */
+    uint64_t pad0;

    /* Outer guest frame only from here on... */

    union {
-        uint32_t spsr_el1;   =     /* AArch64 */
+        uint64_t spsr_el1;   =     /* AArch64 */
        uint32_t spsr_svc;  &n= bsp;    /* AArch32 */
    };

-    uint32_t pad1; /* Doubleword-align the user half of the= frame */
-
    /* AArch32 guests only */
    uint32_t spsr_fiq, spsr_irq, spsr_und, spsr_abt;
diff --git a/xen/include/asm-arm/hsr.h b/xen/include/asm-arm/hsr.h
index 29d4531f40..9b91b28c48 100644
--- a/xen/include/asm-arm/hsr.h
+++ b/xen/include/asm-arm/hsr.h
@@ -16,7 +16,7 @@ enum dabt_size {
};

union hsr {
-    uint32_t bits;
+    register_t bits;
    struct {
        unsigned long iss:25;  = ;/* Instruction Specific Syndrome */
        unsigned long len:1;  =  /* Instruction length */
diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h<= br class=3D""> index 713fd65317..64a2ca30da 100644
--- a/xen/include/public/arch-arm.h
+++ b/xen/include/public/arch-arm.h
@@ -267,10 +267,10 @@ struct vcpu_guest_core_regs

    /* Return address and mode */
    __DECL_REG(pc64,      &nbs= p;  pc32);          =    /* ELR_EL2 */
-    uint32_t cpsr;       &nbs= p;            &= nbsp;         /* SPSR_EL2 */ +    uint64_t cpsr;       &nbs= p;            &= nbsp;         /* SPSR_EL2 */
    union {
-        uint32_t spsr_el1;   =     /* AArch64 */
+        uint64_t spsr_el1;   =     /* AArch64 */
        uint32_t spsr_svc;  &n= bsp;    /* AArch32 */
    };

diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h
index 4dbf107785..d576bfabd6 100644
--- a/xen/include/public/domctl.h
+++ b/xen/include/public/domctl.h
@@ -38,7 +38,7 @@
#include "hvm/save.h"
#include "memory.h"

-#define XEN_DOMCTL_INTERFACE_VERSION 0x00000013
+#define XEN_DOMCTL_INTERFACE_VERSION 0x00000014

/*
 * NB. xen_domctl.domain is an IN/OUT parameter for this operation. diff --git a/xen/include/public/vm_event.h b/xen/include/public/vm_event.h<= br class=3D""> index 36135ba4f1..bb003d21d0 100644
--- a/xen/include/public/vm_event.h
+++ b/xen/include/public/vm_event.h
@@ -266,8 +266,7 @@ struct vm_event_regs_arm {
    uint64_t ttbr1;
    uint64_t ttbcr;
    uint64_t pc;
-    uint32_t cpsr;
-    uint32_t _pad;
+    uint64_t cpsr;
};

/*
--
2.29.0


--_000_25CEAEF8F0B3495094659D1896C8266Earmcom_-- From xen-devel-bounces@lists.xenproject.org Mon Jul 05 10:55:21 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Jul 2021 10:55:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.150095.277577 (Exim 4.92) (envelope-from ) id 1m0MG0-0003rX-Hx; Mon, 05 Jul 2021 10:55:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 150095.277577; Mon, 05 Jul 2021 10:55:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0MG0-0003rQ-Eh; Mon, 05 Jul 2021 10:55:20 +0000 Received: by outflank-mailman (input) for mailman id 150095; Mon, 05 Jul 2021 10:55:19 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0MFz-0003rB-DL for xen-devel@lists.xenproject.org; Mon, 05 Jul 2021 10:55:19 +0000 Received: from foss.arm.com (unknown [217.140.110.172]) by us1-rack-iad1.inumbo.com (Halon) with ESMTP id e51cca4b-a6c1-4dc9-af93-d15b89961689; Mon, 05 Jul 2021 10:55:18 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E3B781042; Mon, 5 Jul 2021 03:55:17 -0700 (PDT) Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com [10.1.197.16]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 90D943F5A1; Mon, 5 Jul 2021 03:55:16 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e51cca4b-a6c1-4dc9-af93-d15b89961689 From: Luca Fancellu To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, wei.chen@arm.com, Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v7 0/9] Use Doxygen and sphinx for html documentation Date: Mon, 5 Jul 2021 11:50:54 +0100 Message-Id: <20210705105103.14509-1-luca.fancellu@arm.com> X-Mailer: git-send-email 2.17.1 This serie introduce doxygen in the sphinx html docs generation. One benefit is to keep most of the documentation in the source files of xen so that it's more maintainable, on the other hand there are some limitation of doxygen that should be addressed modifying the current codebase (for example doxygen can't parse anonymous structure/union). To reproduce the documentation xen must be compiled because most of the headers are generated on compilation time from the makefiles. Here follows the steps to generate the sphinx html docs, some package may be required on your machine, everything is suggested by the autoconf script. Here I'm building the arm64 docs (the only introduced for now by this serie): ./configure make -C xen XEN_TARGET_ARCH="arm64" CROSS_COMPILE="aarch64-linux-gnu-" defconfig make -C docs XEN_TARGET_ARCH="arm64" sphinx-html now in docs/sphinx/html/ we have the generated docs starting from the index.html page. I've created a preview showing the html pages: https://luca.fancellu.gitlab.io/xen-docs/hypercall-interfaces/arm64.html The browser will show you a warning about the certificate, that's because my gitlab username contains a dot, this is a known limitation of gitlab pages so there is nothing to worry about. Luca Fancellu (9): docs: add doxygen configuration file docs: add Xen png logo for the doxygen documentation docs: add doxygen templates m4/python: add function to docs_tool.m4 and new m4 module docs: add checks to configure for sphinx and doxygen docs: add doxygen preprocessor and related files docs: Change Makefile and sphinx configuration for doxygen docs: hypercalls sphinx skeleton for generated html docs/doxygen: doxygen documentation for grant_table.h .gitignore | 7 + config/Docs.mk.in | 2 + docs/Makefile | 47 +- docs/conf.py | 43 +- docs/configure | 258 ++ docs/configure.ac | 15 + docs/hypercall-interfaces/arm32.rst | 32 + docs/hypercall-interfaces/arm64.rst | 33 + .../common/grant_tables.rst | 9 + docs/hypercall-interfaces/index.rst.in | 7 + docs/hypercall-interfaces/x86_64.rst | 32 + docs/index.rst | 8 + docs/xen-doxygen/customdoxygen.css | 36 + docs/xen-doxygen/doxy-preprocessor.py | 116 + docs/xen-doxygen/doxy_input.list | 1 + docs/xen-doxygen/doxygen_include.h.in | 32 + docs/xen-doxygen/footer.html | 21 + docs/xen-doxygen/header.html | 56 + docs/xen-doxygen/mainpage.md | 5 + docs/xen-doxygen/xen_project_logo_165x67.png | Bin 0 -> 18223 bytes docs/xen.doxyfile.in | 2316 +++++++++++++++++ m4/ax_python_module.m4 | 56 + m4/docs_tool.m4 | 9 + xen/include/public/grant_table.h | 459 ++-- 24 files changed, 3412 insertions(+), 188 deletions(-) create mode 100644 docs/hypercall-interfaces/arm32.rst create mode 100644 docs/hypercall-interfaces/arm64.rst create mode 100644 docs/hypercall-interfaces/common/grant_tables.rst create mode 100644 docs/hypercall-interfaces/index.rst.in create mode 100644 docs/hypercall-interfaces/x86_64.rst create mode 100644 docs/xen-doxygen/customdoxygen.css create mode 100755 docs/xen-doxygen/doxy-preprocessor.py create mode 100644 docs/xen-doxygen/doxy_input.list create mode 100644 docs/xen-doxygen/doxygen_include.h.in create mode 100644 docs/xen-doxygen/footer.html create mode 100644 docs/xen-doxygen/header.html create mode 100644 docs/xen-doxygen/mainpage.md create mode 100644 docs/xen-doxygen/xen_project_logo_165x67.png create mode 100644 docs/xen.doxyfile.in create mode 100644 m4/ax_python_module.m4 -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Mon Jul 05 10:55:25 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Jul 2021 10:55:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.150096.277588 (Exim 4.92) (envelope-from ) id 1m0MG5-0004Aw-QZ; Mon, 05 Jul 2021 10:55:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 150096.277588; Mon, 05 Jul 2021 10:55:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0MG5-0004An-ND; Mon, 05 Jul 2021 10:55:25 +0000 Received: by outflank-mailman (input) for mailman id 150096; Mon, 05 Jul 2021 10:55:24 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0MG4-0003rB-C9 for xen-devel@lists.xenproject.org; Mon, 05 Jul 2021 10:55:24 +0000 Received: from foss.arm.com (unknown [217.140.110.172]) by us1-rack-iad1.inumbo.com (Halon) with ESMTP id 6062de5e-c79e-4810-9b92-f4ceedd30a03; Mon, 05 Jul 2021 10:55:21 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6DA8612FC; Mon, 5 Jul 2021 03:55:21 -0700 (PDT) Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com [10.1.197.16]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1D9183F5A1; Mon, 5 Jul 2021 03:55:20 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6062de5e-c79e-4810-9b92-f4ceedd30a03 From: Luca Fancellu To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, wei.chen@arm.com, Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v7 2/9] docs: add Xen png logo for the doxygen documentation Date: Mon, 5 Jul 2021 11:50:56 +0100 Message-Id: <20210705105103.14509-3-luca.fancellu@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210705105103.14509-1-luca.fancellu@arm.com> References: <20210705105103.14509-1-luca.fancellu@arm.com> Add the xen-doxygen folder for the doxygen template and add the Xen png logo in it. Signed-off-by: Luca Fancellu Acked-by: Stefano Stabellini --- docs/xen-doxygen/xen_project_logo_165x67.png | Bin 0 -> 18223 bytes 1 file changed, 0 insertions(+), 0 deletions(-) create mode 100644 docs/xen-doxygen/xen_project_logo_165x67.png diff --git a/docs/xen-doxygen/xen_project_logo_165x67.png b/docs/xen-doxygen/xen_project_logo_165x67.png new file mode 100644 index 0000000000000000000000000000000000000000..7244959d59cdeb9f23c5202160ea45508dfc7265 GIT binary patch literal 18223 zcmV+NKn=f%P)1^@s6{Wir#00004XF*Lt006O$ zeEU(80000WV@Og>004&%004{+008|`004nN004b?008NW002DY000@xb3BE2000U( zX+uL$P-t&-Z*ypGa3D!TLm+T+Z)Rz1WdHz3$DNjUR8-d%htIutdZEoQ0#b(FyTAa_ zdy`&8VVD_UC<6{NG_fI~0ue<-nj%P0#DLLIBvwSR5EN9f2P6n6F&ITuEN@2Ei>|D^ z_ww@lRz|vC zuzLs)$;-`!o*{AqUjza0dRV*yaMRE;fKCVhpQKsoe1Yhg01=zBIT!&C1$=TK@rP|Ibo3vKKm@PqnO#LJhq6%Ij6Hz*<$V$@wQAMN5qJ)hzm2h zoGcOF60t^#FqJFfH{#e-4l@G)6iI9sa9D{VHW4w29}?su;^hF~NC{tY+*d5%WDCTX za!E_i;d2ub1#}&jF5T4HnnCyEWTkKf0>c0%E1Ah>(_PY1)0w;+02c53Su*0<(nUqK zG_|(0G&D0Z{i;y^b@OjZ+}lNZ8Th$p5Uu}MTtq^NHl*T1?CO*}7&0ztZsv2j*bmJyf3G7=Z`5B*PvzoDiKdLpOAxi2$L0#SX*@cY z_n(^h55xYX#km%V()bZjV~l{*bt*u9?FT3d5g^g~#a;iSZ@&02Abxq_DwB(I|L-^b zXThc7C4-yrInE_0gw7K3GZ**7&k~>k0Z0NWkO#^@9q0fwx1%qj zZ=)yBuQ3=54Wo^*!gyjLF-e%Um=erBOdIALW)L%unZshS@>qSW9o8Sq#0s#5*edK% z>{;v(b^`kbN5rY%%y90wC>#%$kE_5P!JWYk;U;klcqzOl-UjcFXXA75rT9jCH~u<) z0>40zCTJ7v2qAyk54cquI@7b&LHdZ`+zlTss6bJ7%PQ)z$cROu4wBhpu-r)01) zS~6}jY?%U?gEALn#wiFzo#H}aQ8rT=DHkadR18&{>P1bW7E`~Y4p3)hWn`DhhRJ5j z*2tcg9i<^OEt(fCg;q*CP8+7ZTcWhYX$fb^_9d-LhL+6BEtPYWVlfKTBusSTASKKb%HuWJzl+By+?gkLq)?+BTu761 zjmyXF)a;mc^>(B7bo*HQ1NNg1st!zt28YLv>W*y3CdWx9U8f|cqfXDAO`Q48?auQq zHZJR2&bcD49Ip>EY~kKEPV6Wm+eXFV)D)_R=tM0@&p?(!V*Qu1PXHG9o^ zTY0bZ?)4%01p8F`JoeS|<@=<@RE7GY07EYX@lwd>4oW|Yi!o+Su@M`;WuSK z8LKk71XR(_RKHM1xJ5XYX`fk>`6eqY>qNG6HZQwBM=xi4&Sb88?zd}EYguc1@>KIS z<&CX#T35dwS|7K*XM_5Nf(;WJJvJWRMA($P>8E^?{IdL4o5MGE7bq2MEEwP7v8AO@ zqL5!WvekBL-8R%V?zVyL=G&{be=K4bT`e{#t|)$A!YaA?jp;X)-+bB;zhj`(vULAW z%ue3U;av{94wp%n<(7@__S@Z2PA@Mif3+uO&y|X06?J#oSi8M;ejj_^(0<4Lt#wLu#dYrva1Y$6_o(k^&}yhSh&h;f@JVA>W8b%o zZ=0JGnu?n~9O4}sJsfnnx7n(>`H13?(iXTy*fM=I`sj`CT)*pTHEgYKqqP+u1IL8N zo_-(u{qS+0<2@%BCt82d{Gqm;(q7a7b>wu+b|!X?c13m#p7cK1({0<`{-e>4hfb-U zsyQuty7Ua;Ou?B?XLHZaol8GAb3Wnxcu!2v{R_`T4=x`(GvqLI{-*2AOSimk zUAw*F_TX^n@STz9kDQ z$NC=!KfXWC8h`dn#xL(D3Z9UkR7|Q&Hcy#Notk!^zVUSB(}`#4&lYA1f0h2V_PNgU zAAWQEt$#LRcH#y9#i!p(Udq2b^lI6wp1FXzN3T;~FU%Lck$-deE#qz9yYP3D3t8{6 z?<+s(e(3(_^YOu_)K8!O1p}D#{JO;G(*OVf32;bRa{vGf4*&oQ4*`<-1El}}02*{f zSaefwW^{L9a%BKeVQFr3E>1;MAa*k@H7+qQF!XYv002BXNkl1$+-w06x=a`rA|vr~**(wFP#~E32=hh>6`k4PSh1Z`vdHU@7wd+^* z?%lU7ARy4EXV0EvkdBI3DMdQ~?D{JKrGd}%nSMu>im&!4}Ld-qc1+`03zf8TytnYch*H?@DaIi{(_{Yrpb#JFO=|E zS&WyBYw34aC9jU}(WB>Bq)!HAH&01S-IQv=XXgA&3Y7=gowf(q#gZ8{6ILWFefi?m zi=3QX0Yl2ehmXK)mt@z@J(7@+D3Oto;^X5hvuDqiY15{Ot*xyM~Pi0 zyJ{LP>{f?_hJ^ZOJbd&pCtJWoSqd}Vx^-JFT(}^|jvWJ&?UVKE*GpVnoP>mg$btn6 z#MRYRoSd9w)~s2wXwf1G4GmT9uUofHcJACMM~)m(q$;H=r7RgUH%EZnoC60AZ12*g zi>hmg{Yuu}m=I^Jg!?kdGxJ;}N9f zLon1mxpL)-!eC@hV)N$Bl9-q$HOYuPMn^}>#*G_g|Ni}Q>eMMoNlB3tCr-%Kt5+pG zJzbtXd!}^hxw%q6Z$O(iZAz|MwdzQeh5BY=fDPs|WBwl@TD;W(4%JY19GaB4CNc9( zj=X-IDNmm~lSdhk!IaMxqa_#IL*0-Jb?Ve<*}8SBczJor`0?XKPft$<4<0PNdi4@W zJL%rNy9^jGKr}Tq#n8}Drc9Y4OO`B=-Me?o_3Jla{5+9YuU<(`4#ec!1SY+E_wLO; zefn6SOl&C4fbW1(z-Rg&CQ3*e6|}6?t5m6?bNJBllxI(0%Hzk+APv*xe)@fMvCkDg zfdG@+w{I)bjuJ6EJY2lJy~V}FMXar@MPFZEh7KJny?ghTK7IO1zkdBiU0q#9j2Iy% zCMF6~y1BW@;>C-VxLdYtQKT&;<=e#WoV@zv@zZCMCQX`w@=={=18_9pGh_ab(zgI5 zq{5KhyY;lVaQ^C@jEtv}mYObCuUu2QXi7yg<;|Nnm9Co1xMIZ$S+;DM!dQO3{^IB` zJ=Z|rI9o?&RF~5hlZe>LjW=+M+QE3<^N;E3jG1-45({q zYTI49c;i`m+5@?M?WUYPdrofL$m?Ej-MXbPV@ynp0vap{2?^rk?U!w3W&Og`)HD@F z&FO^;7j6#-2uO&ChzO63ja{^S`SN+d0x)kdbj!G)prDN~dX6|dJ6{LGKD4#5e-#(E zJcs%w^hZVSgps4D1srN(xBl|QOQ;ZU6f6Dps~lOgYQt)jmyF2)cMchSw#xs9h(-e? z&Y*T}J6N1Je(uT58@J`mnR9aZ@L@TB{=6a?j~+cLU@Qp^4i+$*BHe-lgR;#`&F+B_ zkDwcl0mIEmPEOX}yLayZ#Os!kk>p94`7A_)MQT(Xin#OaH1>f6(8yWpC=GOIM*M9#@8Is4tQ!XpH#!`YQULpP!!u z2ZiRKJ5B{7?E^zCTC--2{^`@FyMcLHg83Q(wSj5?8U8nvf4vsa0B8mY+#Y!hg>;+_ zD}4iW%?m&V8Ip{z=$o6j$b$zD6dm^Z_3M%f{WedMr-`$Zn=g{3Rn8e8>cw9HpXn1N zcH7h=y92`m1D700NjWLowr&@6xys-+CDzKsmCE3^gM)+2m@z}_Y#m>Y9z8k*U2iCu z)Er%MA9UgEAw8QQ9Zp4l`>%if>r2qTaQ>Hw3<@dQ77}#mx^?T^U@&b4)1M0q4a??O zCk-M>=rd=|$e}}rWbfX6N@F>CPe_PoAs{?a+EAIK0!P%P%i*epy>vdn*i> zXhTE85HP48ENu@0hRkepb92YirAt#CC=15?f*Ji40%MlUXU+~MPMk1>L{8|^rOR18 zJ-y6f!-mPAL4#!M*s;ni5od>-ojF4^UuHPFilxQGr~Uf%OGda59UUDn#F?)u6Jcy@ z>}G9kJsD~SJ(EiQod)xn{&Per$?3zs)vMPu3k!*UwPVLlRQ3#6jBfh;wQJyy52wiJ z=mSW*Go(_fzsmrShV{I>yn3svt1mj0U@;mb)SRR&(;D46& z+~rG3*)QF=ro=sa`68wNm69b(+9K^1#flaC_A^s{e8h^U_jm7>E!xfSobMx>Hg1uH z3l}PL)n;a9^1}~5$lm??<=*}KayLC)uEW5%1nGJ4>Q%W6L*tK-@${*}nAdLKe$}v1 zqp8T}M=-%3>T&r@LY=R}gb5R(pFMl_hG|@d)z5t2m5-`CJTlzPyLXlHrote)hce&7 z|C1+A=4feYokO~AKriI;1MoHQx%>Xeh)VxYfaVw@t204?q2li!AfBF{io*mQCu-HI zC2DGFas?Hhp7Btgym+qQ;giSm;PE3c-V+6no;@vq>KgB>Xz$*=cae_*>oE%6(o-y`QdF>6MT%74#u=^XAPLwQJWNkG!jbIf~)PvBNHoj*f}1UcLIg z2gY9{&Wm%lhjZn-cI}ep&6~>)RjZ3ygGO7?0Qvw`07Zv{RHl?19 zbE*)fAkm9`3=GV2;6VMKfO>}x9V`tD4CYLlG$|PR z^J=Io>j-rBt4vKzeKa*Soe^#rK!;+E;gVs?fU)1JhmwIooJFGl0P~_#3-ja3&UX3N z=$l#?%>g=4Q}Z@SIhhoyZDh8P%3%9k&%lsiw-_mukenq)R<(j;ug zj2WxfuU~)W%9ShksYc`{@u!rUn)+nt&Yc&1eSJ4}?%a7Yo}Ua>jm-Bp1K>ZIsj8)= zr6bCdcJ=Djbmm9w-o5)W^M4x~Hf%V(Wy_XhXc!)dOU7rtv_YB8{QdnmpE`Bw_RE(q zl@W+{5uQIA@9-A%^_Aaz^9>j9{gAJpe{xg;;5wI)n#1(&I63Ccim1A7yi`R>jvA$x zHDJI1&Ev<9*FSpnXc@fpvUp&&cKgAD2VWpF(82dZ2=Q`J;ji-l{%s;dqO!;|oR`m~ zWJkFaAI-jf`zn&2&vEkP$^01q9)hlV50aE~?37>?@J(;I3$ZYwy|1#aUaU-LD|Nc%$rw)XzqO*TWL`hk_SkYoeqxDR(X1cnI zOMchQp&(W&nR0}d_7z=S-A>RUE8&@GF;mB)YZzBDdZ0^BfAr{)(tZ9XiTWe;TDs4z zS+gb!68B8Sij{KMZMSOG3JuIzVc7Q(nSg1qK`E|q2uq2}=lH9Vf8)lD=c-n%s*U$h z1@A=Z(s86OD(CEfbprj1q@$yA7}EIU-;v_)A{dG<)YR0>Q4Sh)pVSBgC1sszKh$tC zG%yp-`FV@FIG0R)l3h2^s#UvS3k!?-cvj9uE8P`9>y_(vxa>6$UHkK=PoFB4{C6l9 zznntDMSn&N`})mm1$15GaLLZP#N!psvr#{i`%zv zE8Q*Qs=#=Kk(HgLluJeErr+6$ScbxRzD=t8ET8fpWe*7nIfHU^LYY1(FDY7bYCkn? z9WYAQ2s-2(MUSKd1_#c`kQ@#wS+dkHbVZf%tX~2uX+XxL70cxkTF~JVH*MaOdHe1i zx&QD%0Ukce_#GZ(Je2eY_Y2Nd;Z$*W?d|{f(o*Hto!fHl#&x;M>CTH6;^NLD{x48#xD=yq%T}$t8D5o!3aV#PL6s)& zJ>moajw~C?e)IM%B@gDOdLM<;QlW79_>4^NHl7y^_6^FSU#wU$TIinyQKVB+Hfhtk z)AG@JW5A4a6^7*aB$<=?*zn<+)X}=c$H$kzyZ=o$0EYYmD2azw!(Wp+b?ffhzI%7h zNl2ZPQ>WxOq}2&XpLgNd>C;LWLUqogDh`jTG*X}s9yoeb_8vSaJNE36&D*z2d_qEY z^A;^mBHy{lUlT|5zWw^epc~G8imvz|!XHdYkt4^C7o?-YiTq<+Lc*JGOPA*O<$S;b z5>6jSOTY(Ab>Y)fio~4(+?wwZMjUwNFa}-8e)nK_ z*rEW3NI0xv)4fNJbK7?A0`u&ZUHkUS?)?Ye3*Ik`x9{!PvrjqSzI%^s*s@htt=}L? zYu3t4_t~$?SE#TV`Po4-(f6}W^%^zo($dmiK6vs>wjlp)yLQXYy?OC@WLiA#IdD)x z%E{BxxJi>kh&vhO{~1sNIPKU7X>t)-`1(zovsn(tD_lm^k!fy4UfcPs_^&-`)EdO& z4jzM?oSmo#qcgjK6^hiVLa`0cmfayoP?u(y4Oj;VYeRaoZz zHh7)oRAJA-LvrZoF=^De@nWRG=lUe{N-`LS44QZ9(0$9OQAP?=a$1qzQdl#y zaoGq%@1gfT6dss{PX)9{F2i-#H!@D!unjMH%QjiNdFuyZ&897~X5(h%xN5^DiBC+D z*cFMQJ6iuC^5Bw(v5=6h(HJ;de0pPlx-T=oUx%{ld>x7zNJ=EKgo7A(2rzU?Qpk{(u#pPZ#fW9L}R$X1PCSS>BaS zVJK+=49hZ=D_?#N8d;rBg(*p#1!&x{efKSTU`mfUbCo5r1SKWM`NoYKmxC}Il;zOE zd%FNUGz}jP7LNc{dk2NQiC?uwmL;wFV8pIWmS`~JQZS=mXhcrycI`O;&XzwMc~P>_ z-L8JK7A+RAtNIVRa*SNeDzv6ef0)6Ovr|D^YqfCOBt#$L=|xD zA@AMFcp^*USG*UI%i<*h;CURFYRE9neSH3srAoOjO<0-ByqIUifO^Ux3%F#@_zk_6)R3&vu4fRhgpIbogiVc z@gI!vWy^6~E-tg@Wqx0!%6_Cj9g?GWer3^Fn1)(cQ_Jxe_oSSX;H9w=8WSfWOP49f z!fC0l^E@Pa8PZ-Mu}N!W1te?I#;uYJ$-*O%uzr(7tw@rfs2K4JUm^h!OWz6qh$!(1 zi4ecAB}(2s`t;q2@));l(>8(WheRV!pl~?~gZEgjV3cQ3U`P(6eiY)9AvyI*Ba*5S zhu(Db$C}4W&i&Dl???mL;IF<8n)U^9}VY2UHq|H~4~CVKlPnZ>j6-KIchf{7NN1e=y5C^ToA*$Y|y0 z8y+RzA>lxT_=2GrCm=trUsx0vF-kf235^8PMJi$52JbQcqQFq`3JAfqNNLr!{aTb~ z!cff-CpYXl@cy#omq)pebLM9?#qJ5>+Toe%0R^)}IC6e_l=W1{^yTX|y+1ty_xOwi z%h;n&KN^BVkOrrcKYjv376mBXsx)fYJV0}}t~feQld!NbWw|U@3=SMPP(jtI)l3nN zFNfWIfwaWK@|=v(aq{HJu`gb{$UJiXI$AB6DPBQn%<>OHSnLW}w_~4VWQ$C&wZDTr z%m7Nr!WG7qkrRTJEXxgxS)s%WiGF{cED!JdM?`~}!o<@zP!{+FgQ>#sKU}iOt2!bNXZUjAXPmnJ~({FCS7F=#2IFY>PTWA!-1?SOPBP(FSFLly%# zrdIZcsx|C}Ym5>r%LxiIMny$Qe0;pJFpG=B3=PN7AgBhAi4|!HsYM2*XU(9<$jBo| zOSbG!k?^=giNecMVQJ!;LiqK1-o3Z){}!>y>*e;7Ou6$kQ-*43(-*QGDv2WoN`;{e zKb9?9&Lw8$x`Mp^DBb9lNHb}@jJ2Hbs!qN7x9T=fyHHQ9;aQ@7A-w&+@b$vsmGcH_ zJU`l`S&Nk@78|d#PgvBOgbmvY%JgpJzXM>&@+4{6yybet{RPj(*&u~*&PHGVr{*m~ zmaW==@~>6my*s^MpFINUc?E`1pLE4LYJhY;ovB9fQMts##LC5r7E>QOSSL$=w2?$c zL@GO7aFYRUNX5N>X3UtGhTvQ-OE)g|*JRE*jT<+%IC}J`GJ>42Zkt5L!6?CtSq5f` zNnEQi0MB_OY#{MsW;W(W~3%*bF z8a4gnR&A6xFp(<%cR^LY=!7*A616-Bmi9b6PZK;B->pJ8=jcdBjS)Hr_MSMe#8JJQ zcY)8nEO`SA!_{JK>qvca9MYgO^LuT9kB(5+oWSq8xc|6J$I zHQgE-8ZvdNJ%@!jRKn>q>L)FAbaWP_r>DQTl=?(MqtRucy9kR-1altn>7h%(ShF3{U?&Yo<@1RMKX zTMry7c&z;5g(p)_tMxOETM^ zrOEq?f+CP^gw(22kLm;s!%st>R1w~5DWI08r)T?mbs8hS$c_Je!eV9Sd>?UJ;3u;e1G8L{(Ntl>6uqP_l5rA?iHZqvwVG?)J3Dai0AS{eEnX%dO2{#VKT|XtI@gzr=CthGS-e>;r1>S`#%IW6mD-E0c z#M!CtV4%YKB$=~jC8#I!eM4myo7)AOlB9sF?k@ZnCi zYSq#lqOS8?M_W%B7UIrn1n0tk`Q;aB)~p#lSe|W8xg^u(ERv}+=ZT~H0_EIkwwD5) zzx|&_`CYD18BE_p0rR$V1(f_2NND^zd7-f8uf+e6Nn6BazHdRk z3`;o70^B^s-fg~2MLJVZ_Q}Y{*lNnlij}{MLH^vdwMB_Us3KAQHC*GMB!Sr~X?jc%wV>s(&i8MIp z{pskFDneaUc>MTrYdbr;kzG3V-mjx=Aof!olzk@IjdQxOXRlsz<>5nF9JN}k>}LUP zGQn}SSWlZP6P)JAL}Hpp9`gSy_YlT%s+*YGx{A4tih&u+!o84gO|j@&h>fevgPRjVF1jmU%!4%UA4wyU@=9;T04sA zWM>&?GadQPz%d_FW}qxCO8HfJsnS-Rk9Tla?pxZ;MA>IDAH;PLvnkWX#M((rCOV0} zxlL}Hj$PBf_@XGMI}Opzvg>YNuVK?TzMpXjtDtb+Z@~;@F`eWr!*s_yMO@Cm*8mFZ zlXRBp(`(T1OP2OCmHhua&FNx>=SJB$RmoW|cK@Fqfho%Zjgyj+hBs^0%3W7`Ozvn{ z;XXb-Vr69|4({%<>w2b4a`O>`@s46J!AXoK%@E_sGsI}pbmcf^vWs$5uIJw~oH$MN z5q`9ly^J!q6J0YK89LfLr^=5tFCyEd;$MBWXYeS~tkG5uO4zs4D-6{=p7UrubFqZ3 zKPm%98qHG+$31xm-_S`C@osH5zm;l;=S^)j2b^fG{@S= z2(zi8ZSEl2;~Zq0Ig+CchZ<>UZ+uup!!YQoUYTT z`K{Uwo2C5`5aw=!W^K<^`0fX9#N_~Yfj&vXe=Zp7-l$c_O?4Z$yofk=-%jIg)NRz_ zR>Kw@jw7BK^li=zeUfW*6arIL;+~MuB_~w*{)gn6YOQiZc3cvB?|2z*YAYIGn&BpP zq6KF76<|IbHNi{-|7)5~m0@7Up~hfFFq^vm1R11nB`rJmc~Z1!u>@o_4qY89vpyJ; z^XYEQI`()l)MygYw=GC3FTM9e6ODuUIf5z8oEJ%@s?}xW$dMAYBuZJu$Tc}_+qRS1 zHS0;SqF;0Rj?-=XzA05YrF`Wo=YFi)=vFPYW~uo|%SURB`c3ZO{sk}!!_$+U`l1)W zu}C`0_C?uS0i0RlrdV`B;dEzlJP+48@l!7RFaXsG?!r+RGvC5AfU{KHVUSSwE6^uN z_|K_ZuE*zUPYyY;F}$6|+u*n<8$5@)*maZ9IpoKoE_!-#*o&hUAHSZ-LZUKTjvhVQ zX_&G3`Gix?#d204m<)^v1{g_6W$6S=%LmU@$h*cc3`^!34#v~~W2!?6)oap;rTJXoS=PI0Z<_NGjaba>k@O(jQo@S~aUGRjSwnj)h=fwrp7r%Ig7r!N8P^Edb88 zd=Kz_e35eMWDy0YPbq1FxJZw>W@Dfwzy|S0_z9q!8W*y$>sAX33yVofNx6FT=+SFS zVq%UpP*dxSM)39N^XH44ICEOb@5qT`MGhZJDRTHkN|B={Pbk-U|J>z^Mb2Njtbpfd zE}SoN^4uAvd-F&>Y|pYMkajg5mtcLc{wf4BPccZ34c%BxzdPMxuSF)>%R zTz(}J-Mqzc5_CD6nKH(9mU1+j;;J0q2Co}J*E4`#rVqVL4|=37bT$n`tL*Qq)!+aw z$2SL|Ae@O&_U&Pz0IqH3dgd`zs@FQAHy#GWMCf+ZA>WZtVW`T&vQ2XLm#7`*(Cv;D zOX$E*LBz;#tQZ?v$iM-^PFq`ByDnO^sE?_sDJzW5uG9f}PNpbaq5R(rpvxG`%1yY) zgk%hs^}QPs;5w&1JD}n(K7aoFH8gRDgN15*dzbx&I6dM`x8{s8=q57_xHh+WRNYof9yN>^X2C1NR0);+IK# z^r*-kZaAH4-$yLzG3zvI)d&j!FyK|Sj zf(3TJBiulP{TD5~1|2(gv^#U=Oxor%sp2>r~!IQ_5 zn($>?boBBpu6BCnARM@NS$FGWqUxaW>%*E4BrqA<{X&#Hk z*~43$=Xxvu-v!=d7>+mE&+?T1L$#h4EA}Ow3#QgbP?CF3SL zX8u`zDk$NA8S{K)j&HaexR5Gq_nZ{9#y?5FzQeP%N9yi`O5$++`gQKP{=0qF|6PRg zv!T_fSFheIyvM9JS((ZzOEmJ_Lx&FK9653%hhIAE%Y0|_F@i_R; zvQc+z#B>18F0rel{>MdmR2NhYghGTXNV&@gzv@fpYlf=~CRFxDBID$jsalO1HOxni z8nu7u(4iN#w6sn)Yu3z%@o=9#78#e!!Tgv8m%K1N4sU%|I6Z>QhN80pQp#}_jJ+HM z3RfFYU*-4Rxh#e~FI9)OFgOFisLEPpeqyG3_wK5%cW|`;pCym-3(Ps}K2}rgcgL;U zni~)mC*Gk;Wl>P1EbtGN`M$w2&nHOc;mGqp0>gML4wPA5zS6d17cMd2a0y-Tbtnb# zaD36s?{~z92H4&30gda_Z;&!)ae&PA4SHu@Z$ni^mf1TrT0&x1icfg7RH#_#KDzPH zy?gie!u$9U_{UcBq3o=Lmiqeo>-h4yZX69E7fg4%Ql&~qDp#(2pjNF~7kqqtUh*E7 zzCsG|V^&Fs*LBR8G2_>*TXz5w{V4QdR+{d#Y12ZFA3uH(|Ci%`9lS$Ua*fiZOZRtj za*Eixb?aGfh5*LDla!QnOixdbIx*KsmCk>sEK@z`((ZwQfz125gM$NoQVqd0RAI;v zbVY2Vt*z~nkdSbMJ8+yofBxQ#PJef|2iQdjuTay0JRwW~#NaPU?% zx@(s&UrvY4dSmI*rMrIm=_eXloUU!@>+8F2|Ni|2-2% zP^jXKnl^1UXQB78$hZ{}xP*?ak>aiR2L{OkKl&KvVWIz@!z&~=%j+~g3Bl} z&CJX~@glh_f*AtAql`#^8Kz?aYEz5Dj<%fx$LhU;AaLwB}$sK|3% z6VHtfC`kU3)Edv#%Y~=wxlnya$;Cy$TEG#ViE?&Htt^@=X-YkI| z7l28qE^&s7j6@x`y=sRJ=6L}6B(9BsK1lB|$qV!6&*$hv zD+m^{cSMM&E?QyNzbzaq| zRVx>ew}Eidu3bB2NQR$G=4X=Wi;0SPk(`{&Zk!u0DIccK2c0S2#t<+jEmNoB#fz^% z{+IqJ&-VdwGEx4tZasQ#)*C%qFDfdE7V}@y3qO=l$&|vQQR&Lgu-xzq@8CYJ*&^@O zxZf1#hLC2;=3U$X0Tq^`rl!WF4-R|w?77eDB(58xH035;+{O^yUj)J!LF(+{ebx4c z+&qCgBAHvYT@EYW%F2pESPhXcrQpyF8#X9AbWnAG6;976EucZurcK8{!rdp6a5IK0 zSFZ5;NZCxAd61wx=5*=Og`0b+RE$B8eAn{t$(=iQlyY!)5`H>{arp&0dwcu!RjO2( z&yU8kY%CYkWEhs29|eOXW@DqOkVhymsUnzw4g{2B#sG&(3i}mWRjXEQT8kDf=JxH| zH?CK&UdI|YYI3`GuR+;^25QKlL4(D}$XFa59hJ2_bPC?FV}~3(cu-caUafq-jz@mp zWc&8*a^%R-H@J5d*H@#^9G_#pDkfF;_xJZh7q)NBnlgm$kprD`A(?j%tPgQU$}fZD-{*` z01TFnisOzS=$_xKSh0fskPFSmjoV5_xPAAo!T`{dU!Xp2v~Jz{s*R1!$|t^+{w*Aqj(O9k9WNn;eSTM>gg8{ph$3*0}?wIb@8Ze+qPGJ{`uz{kkT)> zZ8uaH8gO>it5%T^Xs-#9zDiSsm9Wlawm@AT=@%F9ek zOH*3;rAwEUk3aFdJ76^BJKpQpuU9^0$ImMh{1_;~uiWy;dt_vKC(-+z>xAfN%&<(0 zpI+X!ZJPuI1ssWRTm8kj6r7Ph%)DEH7^ZvwMULqiz=iQOFKXE#RO>K~*0^qUMA zI53f$C0xKeAX7#}MBGDnej+F+=n$U$0=lfst$2oHyoYso);|6E9Y#C{95?Mda)e*0 zke&PX$-2#(bARd9?KaX)#{C7QN|o|WTD$humYq9=m}Fx^M+@qr+&p0pkZ5af|717f z?}0$redthD{RRy<*4h>6MDIO(SoWu+$N`{DyLMbZWH4mdu;pYfUfZ~Rdls1S1g=xU z1_GO0-QAxaI&ne{9X~Gf7B0MoYsQ^AclNywX50+Hvu)3w+-^O3(AAC~Rd5G9P~Na6 zO`B5xr8^*dKHb`N>TG1*e7?Ph4oTBy&A5dOXRqiF+X;+L1NT=#B2OKg;8XaL9boA zu6#O=l9UXrVo-hvl#IylE)pt9O9p4Rz^;HyPO(o3!TY|xe&XilE^e-K08g>Ab<5Nq zIqEW)Fg`judJN*Xg7VL)zrQu4^PzKemXp{{_1p^53a9S06ed{W-h;QoWuInh81nFfO)(%pOF z{1u5!TqWU4NAA@|m0NnF(QqMkpFRom-QC6&8CvhuRW&c>C26eiT+Ipi? z4jezFTt~i{rM~@^3}NLm+vDz`6K7=4(c^OA!iCJx(9qOn%a+}MFt`R|<<5cQr(eh8 zIpUMn%H*jIHxS2loaMv|2Tq)pWr@k+;pO!L*Mia0a&m!|dA+z_HC^k@$7)6h{L zrZqC<$mt7`xOSr~iCvyuu3Y&gxIP&7Dex!|OW^;96W(tP=m#yJ$ZA2F`MJ2b92sM5 zmNwJHD=R2qse}YAk?^o3vSssDxpDo5qU@6?sUK0vrtU%sLQv6VcS43r%Jddh# z>MhiFjzR)OL`2F0&xJC7-Xigw?<;d>`{$aOT0b*08+Qg0DHzgLGc`4}3Cc+&{y#=| zv7GZBq(9c|O7dnjn$SpD96~2!7>z-pvM3-FhFA~`FMqL|Z2OXHc@UlqNwvjf!j!4^ zLSvT;R~}BZwO1+|P)E8P^3k<%bWTm)x>LAZ*W7wCrKAfa3Kl9jT{(jmwaI zLLKylnTTgYo z8!(Lhu8o2iVN2qXqKd~{SS1(w#PUxC8TU%RSH5qI1c)|RT zoUo8(5*iHaH!@lh(drK#JOriorov!k%s(PBEv-Lp$45rx=j_(6-yk6&q5K-IEb{Ub z??re~USVQA!SNOJ+1t=}wn1{c9y@ldKcur7lKE|S@E;(&WLowHGv_aQ#Fd1;s8oAb z_iP=5F)v0LnLO3eH-6lIutsVGOSqUPUfX2IH*|^X+$;q9CW>)%aIZ4T|Nqa7ZxbrN9;8`2FwO|*iwhPnUcAS`!s5nw zt0^zMy&`fWLYGTK*fLof6)(|C`I+S;=!ARa*sy4Hex8CEYnqh^? z+BNGSaU=QhQ3-&Q3Gk1QK>sKS^otgUsqSw^k2bhBb?VgpFowL){p%o|wkS^>;2#?t ze;?(y^y<}X)SMl$JSm&2I74DrNT*-A(VcD;zz+>@JdR_C<4_meWPr079J8(WeU++i zp)o76!sAy$0vZ^_qX!4HN7*{NJfJi?b0bZjym*nLuCC5ir5w%ZQm0NG z8yHNtqgJez;AoCBM`o4!wlpQ}i0Uv*UWSG z@w3vi-++6#PD_|00nuQxHKwMfbVi8<_-#v_ufP7- zm)(P7q)@-Mlq^}2Lw|g>>XpCy-Wd%ob0r$n@yoXadyWP(E(M|`EF=a@9S>%Vkr~tHW}BOhe`RE7lnx_?pK1<(@nir- z?g-U@U&iIk$A5+JVmY_lvUArS>-;0)WUhCR%=Zq;tx>Z!H>Dbj+dTm~b0~Tiz{=oM zCdUw)x9|LOvUl(jna6lO!MQbS*QHyWYQ%uUO#M6m(*5XcFMpZm6D%C`gN~jFPR=VgwOhD0ZbowM873Kc7Hw4rhBy7hhL`G(~BghmVJur6J?^Z`8v!ucXR zF8Pk@yv1j}EnSAsND2GT5b~=5G=c8-%Yg$2j8?8(xiBOoWFsv03lkjqigI&(EDZ zcOxwEg-tINJF3x7rb&Se9 zbuKa@r&(2wC}heW1BQ+`&v=ua+{9#p?JLA_MqK(pQs1K68i(xMwDgRhO>}S(+v&5# z(cMd?&&!)$wRfE-Q=DgsrHxZ|{f13a5Y`Toj#GZ>y#@?94pFHrL$R`Re)IL$CESrd zcY_;Pvv$3W7B)_~)($h3r4tUbJjHR=0%f_#B$Q>6(=5>%J?32T;$P82O8KI3`3jX{ z%qBVHaJdPWT;xsf`iS$K#WEFn*dxA?x%IWuWy(@lZeF!o^+jBk!t^FP&lX!(4<_~OaY;HhTJhouLf~2spFpq?U1QUL|{`T$L9UvLW zjK5Az{g(+ZmQ!wh`VJd)edwsMZ-$IA$?VcwokJ*kxJOTzcj`|071FcM5S=TGH&o9I z@dnc(r{gf)*i@q;oa0t6Rl00+o6bER4AC8%r8{nlj5fEE(UwzXu=beO?Ys85U#46I zcE22op*7wN7^i7um2Ny~x)_XiklsUeXykDHcU>?h=d~@X)vUX}TYrt`T85Un+GDLn z*L1RsFdm=Xd+^A|4V$&$Yzy7&=t)%$(o&fM{=Qm`9l!J)@(gL`j><2Gj@gu)K0|e$ zG-=hIT|RwITO*H##fp7t*12c@JHzzNb4HGxDB30ybMbzj)UMw+3}MA7pyu9553t+ND!%|O?)AU;0cFE%z7{2IO#T|h*1bhLj=OpIq-T-3&fzFrrxa{f z?91X-h~o=z+duknva(cj*914CrIQ0c88{o^lgd@9a;S3E>c`8JuSETmdLNf$=z$U1 z7cE+>ZS#&j9CXIdI5;gZDR-#RWEld~ZQ7ci=p2fnV+^-zr1J!wivvo2TV`9uDnA~r zROQD*B}#tF;U=!`tq8_R0*U{W;X(SN|gF`3&J0(_XbR93oGE0N$iuf2B}0`KLAp~JH(9?z9{ z=F=AzF?050ICl5+5aI+!J1`TyYseU!OCOD{o-SzZ0L7P}e5LOVM@^XadeWRA(Kfdi zP17kdP}l6u*WZ-n_$1W{su9ea!#8SRc=~km0|L}T#{irc?}2-K1~Me)yeYLw^j5Er z`;^9f#D6{~9gr0(9oIfS0@GCm{-fiH|4zb- zWra~!q*UY>oobwp760C058eab8_y#srie#CbP;#IC56M%BIovilrnTc=5h=&4%47+ zTcbgvpXN+)oiF2^+{I$5ix^qiX4bCXkZYoJ!4RBKASoV102zn*@;VuXpi?uik$D;B zU$gzASO&&X%>t648BP_4@!6Odhs3a|GLw;6W;QDN(=u(<809}YsqvZqCau`8waD^y zn~N-4y|GA4^7Nk5Z?4!zMr3>KU6{8m>Jmwa) Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Jul 2021 10:55:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.150097.277599 (Exim 4.92) (envelope-from ) id 1m0MGA-0004Vz-9v; Mon, 05 Jul 2021 10:55:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 150097.277599; Mon, 05 Jul 2021 10:55:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0MGA-0004Vq-5i; Mon, 05 Jul 2021 10:55:30 +0000 Received: by outflank-mailman (input) for mailman id 150097; Mon, 05 Jul 2021 10:55:28 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0MG8-0004Tv-CT for xen-devel@lists.xenproject.org; Mon, 05 Jul 2021 10:55:28 +0000 Received: from foss.arm.com (unknown [217.140.110.172]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTP id 7d83253a-dd7f-11eb-8443-12813bfff9fa; Mon, 05 Jul 2021 10:55:20 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DE9141063; Mon, 5 Jul 2021 03:55:19 -0700 (PDT) Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com [10.1.197.16]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 231C63F5A1; Mon, 5 Jul 2021 03:55:18 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7d83253a-dd7f-11eb-8443-12813bfff9fa From: Luca Fancellu To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, wei.chen@arm.com, Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v7 1/9] docs: add doxygen configuration file Date: Mon, 5 Jul 2021 11:50:55 +0100 Message-Id: <20210705105103.14509-2-luca.fancellu@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210705105103.14509-1-luca.fancellu@arm.com> References: <20210705105103.14509-1-luca.fancellu@arm.com> Add xen.doxyfile.in as template for the doxygen configuration file, it will be used to generate the doxygen documentation. Signed-off-by: Luca Fancellu Acked-by: Stefano Stabellini --- docs/xen.doxyfile.in | 2316 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 2316 insertions(+) create mode 100644 docs/xen.doxyfile.in diff --git a/docs/xen.doxyfile.in b/docs/xen.doxyfile.in new file mode 100644 index 0000000000..00969d9b78 --- /dev/null +++ b/docs/xen.doxyfile.in @@ -0,0 +1,2316 @@ +# Doxyfile 1.8.13 + +# This file describes the settings to be used by the documentation system +# doxygen (www.doxygen.org) for a project. +# +# All text after a double hash (##) is considered a comment and is placed in +# front of the TAG it is preceding. +# +# All text after a single hash (#) is considered a comment and will be ignored. +# The format is: +# TAG = value [value, ...] +# For lists, items can also be appended using: +# TAG += value [value, ...] +# Values that contain spaces should be placed between quotes (\" \"). +# +# This file is base on doc/zephyr.doxyfile.in zephry 2.3 + +#--------------------------------------------------------------------------- +# Project related configuration options +#--------------------------------------------------------------------------- + +# This tag specifies the encoding used for all characters in the config file +# that follow. The default is UTF-8 which is also the encoding used for all text +# before the first occurrence of this tag. Doxygen uses libiconv (or the iconv +# built into libc) for the transcoding. See +# https://www.gnu.org/software/libiconv/ for the list of possible encodings. +# The default value is: UTF-8. + +DOXYFILE_ENCODING = UTF-8 + +# The PROJECT_NAME tag is a single word (or a sequence of words surrounded by +# double-quotes, unless you are using Doxywizard) that should identify the +# project for which the documentation is generated. This name is used in the +# title of most generated pages and in a few other places. +# The default value is: My Project. + +PROJECT_NAME = "Xen Project" + +# The PROJECT_NUMBER tag can be used to enter a project or revision number. This +# could be handy for archiving the generated documentation or if some version +# control system is used. + +PROJECT_NUMBER = + +# Using the PROJECT_BRIEF tag one can provide an optional one line description +# for a project that appears at the top of each page and should give viewer a +# quick idea about the purpose of the project. Keep the description short. + +PROJECT_BRIEF = "An Open Source Type 1 Hypervisor" + +# With the PROJECT_LOGO tag one can specify a logo or an icon that is included +# in the documentation. The maximum height of the logo should not exceed 55 +# pixels and the maximum width should not exceed 200 pixels. Doxygen will copy +# the logo to the output directory. + +PROJECT_LOGO = "xen-doxygen/xen_project_logo_165x67.png" + +# The OUTPUT_DIRECTORY tag is used to specify the (relative or absolute) path +# into which the generated documentation will be written. If a relative path is +# entered, it will be relative to the location where doxygen was started. If +# left blank the current directory will be used. + +OUTPUT_DIRECTORY = @DOXY_OUT@ + +# If the CREATE_SUBDIRS tag is set to YES then doxygen will create 4096 sub- +# directories (in 2 levels) under the output directory of each output format and +# will distribute the generated files over these directories. Enabling this +# option can be useful when feeding doxygen a huge amount of source files, where +# putting all generated files in the same directory would otherwise causes +# performance problems for the file system. +# The default value is: NO. + +CREATE_SUBDIRS = NO + +# The OUTPUT_LANGUAGE tag is used to specify the language in which all +# documentation generated by doxygen is written. Doxygen will use this +# information to generate all constant output in the proper language. +# Possible values are: Afrikaans, Arabic, Armenian, Brazilian, Catalan, Chinese, +# Chinese-Traditional, Croatian, Czech, Danish, Dutch, English (United States), +# Esperanto, Farsi (Persian), Finnish, French, German, Greek, Hungarian, +# Indonesian, Italian, Japanese, Japanese-en (Japanese with English messages), +# Korean, Korean-en (Korean with English messages), Latvian, Lithuanian, +# Macedonian, Norwegian, Persian (Farsi), Polish, Portuguese, Romanian, Russian, +# Serbian, Serbian-Cyrillic, Slovak, Slovene, Spanish, Swedish, Turkish, +# Ukrainian and Vietnamese. +# The default value is: English. + +OUTPUT_LANGUAGE = English + +# If the BRIEF_MEMBER_DESC tag is set to YES, doxygen will include brief member +# descriptions after the members that are listed in the file and class +# documentation (similar to Javadoc). Set to NO to disable this. +# The default value is: YES. + +BRIEF_MEMBER_DESC = YES + +# If the REPEAT_BRIEF tag is set to YES, doxygen will prepend the brief +# description of a member or function before the detailed description +# +# Note: If both HIDE_UNDOC_MEMBERS and BRIEF_MEMBER_DESC are set to NO, the +# brief descriptions will be completely suppressed. +# The default value is: YES. + +REPEAT_BRIEF = YES + +# This tag implements a quasi-intelligent brief description abbreviator that is +# used to form the text in various listings. Each string in this list, if found +# as the leading text of the brief description, will be stripped from the text +# and the result, after processing the whole list, is used as the annotated +# text. Otherwise, the brief description is used as-is. If left blank, the +# following values are used ($name is automatically replaced with the name of +# the entity):The $name class, The $name widget, The $name file, is, provides, +# specifies, contains, represents, a, an and the. + +ABBREVIATE_BRIEF = YES + +# If the ALWAYS_DETAILED_SEC and REPEAT_BRIEF tags are both set to YES then +# doxygen will generate a detailed section even if there is only a brief +# description. +# The default value is: NO. + +ALWAYS_DETAILED_SEC = YES + +# If the INLINE_INHERITED_MEMB tag is set to YES, doxygen will show all +# inherited members of a class in the documentation of that class as if those +# members were ordinary class members. Constructors, destructors and assignment +# operators of the base classes will not be shown. +# The default value is: NO. + +INLINE_INHERITED_MEMB = YES + +# If the FULL_PATH_NAMES tag is set to YES, doxygen will prepend the full path +# before files name in the file list and in the header files. If set to NO the +# shortest path that makes the file name unique will be used +# The default value is: YES. + +FULL_PATH_NAMES = YES + +# The STRIP_FROM_PATH tag can be used to strip a user-defined part of the path. +# Stripping is only done if one of the specified strings matches the left-hand +# part of the path. The tag can be used to show relative paths in the file list. +# If left blank the directory from which doxygen is run is used as the path to +# strip. +# +# Note that you can specify absolute paths here, but also relative paths, which +# will be relative from the directory where doxygen is started. +# This tag requires that the tag FULL_PATH_NAMES is set to YES. + +STRIP_FROM_PATH = @XEN_BASE@ + +# The STRIP_FROM_INC_PATH tag can be used to strip a user-defined part of the +# path mentioned in the documentation of a class, which tells the reader which +# header file to include in order to use a class. If left blank only the name of +# the header file containing the class definition is used. Otherwise one should +# specify the list of include paths that are normally passed to the compiler +# using the -I flag. + +STRIP_FROM_INC_PATH = + +# If the SHORT_NAMES tag is set to YES, doxygen will generate much shorter (but +# less readable) file names. This can be useful is your file systems doesn't +# support long names like on DOS, Mac, or CD-ROM. +# The default value is: NO. + +SHORT_NAMES = NO + +# If the JAVADOC_AUTOBRIEF tag is set to YES then doxygen will interpret the +# first line (until the first dot) of a Javadoc-style comment as the brief +# description. If set to NO, the Javadoc-style will behave just like regular Qt- +# style comments (thus requiring an explicit @brief command for a brief +# description.) +# The default value is: NO. + +JAVADOC_AUTOBRIEF = NO + +# If the QT_AUTOBRIEF tag is set to YES then doxygen will interpret the first +# line (until the first dot) of a Qt-style comment as the brief description. If +# set to NO, the Qt-style will behave just like regular Qt-style comments (thus +# requiring an explicit \brief command for a brief description.) +# The default value is: NO. + +QT_AUTOBRIEF = NO + +# The MULTILINE_CPP_IS_BRIEF tag can be set to YES to make doxygen treat a +# multi-line C++ special comment block (i.e. a block of //! or /// comments) as +# a brief description. This used to be the default behavior. The new default is +# to treat a multi-line C++ comment block as a detailed description. Set this +# tag to YES if you prefer the old behavior instead. +# +# Note that setting this tag to YES also means that rational rose comments are +# not recognized any more. +# The default value is: NO. + +MULTILINE_CPP_IS_BRIEF = NO + +# If the INHERIT_DOCS tag is set to YES then an undocumented member inherits the +# documentation from any documented member that it re-implements. +# The default value is: YES. + +INHERIT_DOCS = YES + +# If the SEPARATE_MEMBER_PAGES tag is set to YES then doxygen will produce a new +# page for each member. If set to NO, the documentation of a member will be part +# of the file/class/namespace that contains it. +# The default value is: NO. + +SEPARATE_MEMBER_PAGES = YES + +# The TAB_SIZE tag can be used to set the number of spaces in a tab. Doxygen +# uses this value to replace tabs by spaces in code fragments. +# Minimum value: 1, maximum value: 16, default value: 4. + +TAB_SIZE = 8 + +# This tag can be used to specify a number of aliases that act as commands in +# the documentation. An alias has the form: +# name=value +# For example adding +# "sideeffect=@par Side Effects:\n" +# will allow you to put the command \sideeffect (or @sideeffect) in the +# documentation, which will result in a user-defined paragraph with heading +# "Side Effects:". You can put \n's in the value part of an alias to insert +# newlines. + +ALIASES = "rst=\verbatim embed:rst:leading-asterisk" \ + "endrst=\endverbatim" \ + "keepindent=\code" \ + "endkeepindent=\endcode" + +ALIASES += req{1}="\ref XEN_\1 \"XEN-\1\" " +ALIASES += satisfy{1}="\xrefitem satisfy \"Satisfies requirement\" \"Requirement Implementation\" \1" +ALIASES += verify{1}="\xrefitem verify \"Verifies requirement\" \"Requirement Verification\" \1" + +# Set the OPTIMIZE_OUTPUT_FOR_C tag to YES if your project consists of C sources +# only. Doxygen will then generate output that is more tailored for C. For +# instance, some of the names that are used will be different. The list of all +# members will be omitted, etc. +# The default value is: NO. + +OPTIMIZE_OUTPUT_FOR_C = YES + +# Set the OPTIMIZE_OUTPUT_JAVA tag to YES if your project consists of Java or +# Python sources only. Doxygen will then generate output that is more tailored +# for that language. For instance, namespaces will be presented as packages, +# qualified scopes will look different, etc. +# The default value is: NO. + +OPTIMIZE_OUTPUT_JAVA = NO + +# Set the OPTIMIZE_FOR_FORTRAN tag to YES if your project consists of Fortran +# sources. Doxygen will then generate output that is tailored for Fortran. +# The default value is: NO. + +OPTIMIZE_FOR_FORTRAN = NO + +# Set the OPTIMIZE_OUTPUT_VHDL tag to YES if your project consists of VHDL +# sources. Doxygen will then generate output that is tailored for VHDL. +# The default value is: NO. + +OPTIMIZE_OUTPUT_VHDL = NO + +# Doxygen selects the parser to use depending on the extension of the files it +# parses. With this tag you can assign which parser to use for a given +# extension. Doxygen has a built-in mapping, but you can override or extend it +# using this tag. The format is ext=language, where ext is a file extension, and +# language is one of the parsers supported by doxygen: IDL, Java, Javascript, +# C#, C, C++, D, PHP, Objective-C, Python, Fortran (fixed format Fortran: +# FortranFixed, free formatted Fortran: FortranFree, unknown formatted Fortran: +# Fortran. In the later case the parser tries to guess whether the code is fixed +# or free formatted code, this is the default for Fortran type files), VHDL. For +# instance to make doxygen treat .inc files as Fortran files (default is PHP), +# and .f files as C (default is Fortran), use: inc=Fortran f=C. +# +# Note: For files without extension you can use no_extension as a placeholder. +# +# Note that for custom extensions you also need to set FILE_PATTERNS otherwise +# the files are not read by doxygen. + +EXTENSION_MAPPING = + +# If the MARKDOWN_SUPPORT tag is enabled then doxygen pre-processes all comments +# according to the Markdown format, which allows for more readable +# documentation. See http://daringfireball.net/projects/markdown/ for details. +# The output of markdown processing is further processed by doxygen, so you can +# mix doxygen, HTML, and XML commands with Markdown formatting. Disable only in +# case of backward compatibilities issues. +# The default value is: YES. + +MARKDOWN_SUPPORT = YES + +# When enabled doxygen tries to link words that correspond to documented +# classes, or namespaces to their corresponding documentation. Such a link can +# be prevented in individual cases by putting a % sign in front of the word or +# globally by setting AUTOLINK_SUPPORT to NO. +# The default value is: YES. + +AUTOLINK_SUPPORT = YES + +# If you use STL classes (i.e. std::string, std::vector, etc.) but do not want +# to include (a tag file for) the STL sources as input, then you should set this +# tag to YES in order to let doxygen match functions declarations and +# definitions whose arguments contain STL classes (e.g. func(std::string); +# versus func(std::string) {}). This also make the inheritance and collaboration +# diagrams that involve STL classes more complete and accurate. +# The default value is: NO. + +BUILTIN_STL_SUPPORT = NO + +# If you use Microsoft's C++/CLI language, you should set this option to YES to +# enable parsing support. +# The default value is: NO. + +CPP_CLI_SUPPORT = YES + +# Set the SIP_SUPPORT tag to YES if your project consists of sip (see: +# https://www.riverbankcomputing.com/software/sip/intro) sources only. Doxygen +# will parse them like normal C++ but will assume all classes use public instead +# of private inheritance when no explicit protection keyword is present. +# The default value is: NO. + +SIP_SUPPORT = NO + +# For Microsoft's IDL there are propget and propput attributes to indicate +# getter and setter methods for a property. Setting this option to YES will make +# doxygen to replace the get and set methods by a property in the documentation. +# This will only work if the methods are indeed getting or setting a simple +# type. If this is not the case, or you want to show the methods anyway, you +# should set this option to NO. +# The default value is: YES. + +IDL_PROPERTY_SUPPORT = YES + +# If member grouping is used in the documentation and the DISTRIBUTE_GROUP_DOC +# tag is set to YES then doxygen will reuse the documentation of the first +# member in the group (if any) for the other members of the group. By default +# all members of a group must be documented explicitly. +# The default value is: NO. + +DISTRIBUTE_GROUP_DOC = NO + +# Set the SUBGROUPING tag to YES to allow class member groups of the same type +# (for instance a group of public functions) to be put as a subgroup of that +# type (e.g. under the Public Functions section). Set it to NO to prevent +# subgrouping. Alternatively, this can be done per class using the +# \nosubgrouping command. +# The default value is: YES. + +SUBGROUPING = YES + +# When the INLINE_GROUPED_CLASSES tag is set to YES, classes, structs and unions +# are shown inside the group in which they are included (e.g. using \ingroup) +# instead of on a separate page (for HTML and Man pages) or section (for LaTeX +# and RTF). +# +# Note that this feature does not work in combination with +# SEPARATE_MEMBER_PAGES. +# The default value is: NO. + +INLINE_GROUPED_CLASSES = NO + +# When the INLINE_SIMPLE_STRUCTS tag is set to YES, structs, classes, and unions +# with only public data fields or simple typedef fields will be shown inline in +# the documentation of the scope in which they are defined (i.e. file, +# namespace, or group documentation), provided this scope is documented. If set +# to NO, structs, classes, and unions are shown on a separate page (for HTML and +# Man pages) or section (for LaTeX and RTF). +# The default value is: NO. + +INLINE_SIMPLE_STRUCTS = YES + +# When TYPEDEF_HIDES_STRUCT tag is enabled, a typedef of a struct, union, or +# enum is documented as struct, union, or enum with the name of the typedef. So +# typedef struct TypeS {} TypeT, will appear in the documentation as a struct +# with name TypeT. When disabled the typedef will appear as a member of a file, +# namespace, or class. And the struct will be named TypeS. This can typically be +# useful for C code in case the coding convention dictates that all compound +# types are typedef'ed and only the typedef is referenced, never the tag name. +# The default value is: NO. + +TYPEDEF_HIDES_STRUCT = NO + +# The size of the symbol lookup cache can be set using LOOKUP_CACHE_SIZE. This +# cache is used to resolve symbols given their name and scope. Since this can be +# an expensive process and often the same symbol appears multiple times in the +# code, doxygen keeps a cache of pre-resolved symbols. If the cache is too small +# doxygen will become slower. If the cache is too large, memory is wasted. The +# cache size is given by this formula: 2^(16+LOOKUP_CACHE_SIZE). The valid range +# is 0..9, the default is 0, corresponding to a cache size of 2^16=65536 +# symbols. At the end of a run doxygen will report the cache usage and suggest +# the optimal cache size from a speed point of view. +# Minimum value: 0, maximum value: 9, default value: 0. + +LOOKUP_CACHE_SIZE = 9 + +#--------------------------------------------------------------------------- +# Build related configuration options +#--------------------------------------------------------------------------- + +# If the EXTRACT_ALL tag is set to YES, doxygen will assume all entities in +# documentation are documented, even if no documentation was available. Private +# class members and static file members will be hidden unless the +# EXTRACT_PRIVATE respectively EXTRACT_STATIC tags are set to YES. +# Note: This will also disable the warnings about undocumented members that are +# normally produced when WARNINGS is set to YES. +# The default value is: NO. + +EXTRACT_ALL = YES + +# If the EXTRACT_PRIVATE tag is set to YES, all private members of a class will +# be included in the documentation. +# The default value is: NO. + +EXTRACT_PRIVATE = NO + +# If the EXTRACT_PACKAGE tag is set to YES, all members with package or internal +# scope will be included in the documentation. +# The default value is: NO. + +EXTRACT_PACKAGE = YES + +# If the EXTRACT_STATIC tag is set to YES, all static members of a file will be +# included in the documentation. +# The default value is: NO. + +EXTRACT_STATIC = YES + +# If the EXTRACT_LOCAL_CLASSES tag is set to YES, classes (and structs) defined +# locally in source files will be included in the documentation. If set to NO, +# only classes defined in header files are included. Does not have any effect +# for Java sources. +# The default value is: YES. + +EXTRACT_LOCAL_CLASSES = YES + +# This flag is only useful for Objective-C code. If set to YES, local methods, +# which are defined in the implementation section but not in the interface are +# included in the documentation. If set to NO, only methods in the interface are +# included. +# The default value is: NO. + +EXTRACT_LOCAL_METHODS = YES + +# If this flag is set to YES, the members of anonymous namespaces will be +# extracted and appear in the documentation as a namespace called +# 'anonymous_namespace{file}', where file will be replaced with the base name of +# the file that contains the anonymous namespace. By default anonymous namespace +# are hidden. +# The default value is: NO. + +EXTRACT_ANON_NSPACES = NO + +# If the HIDE_UNDOC_MEMBERS tag is set to YES, doxygen will hide all +# undocumented members inside documented classes or files. If set to NO these +# members will be included in the various overviews, but no documentation +# section is generated. This option has no effect if EXTRACT_ALL is enabled. +# The default value is: NO. + +HIDE_UNDOC_MEMBERS = NO + +# If the HIDE_UNDOC_CLASSES tag is set to YES, doxygen will hide all +# undocumented classes that are normally visible in the class hierarchy. If set +# to NO, these classes will be included in the various overviews. This option +# has no effect if EXTRACT_ALL is enabled. +# The default value is: NO. + +HIDE_UNDOC_CLASSES = NO + +# If the HIDE_FRIEND_COMPOUNDS tag is set to YES, doxygen will hide all friend +# (class|struct|union) declarations. If set to NO, these declarations will be +# included in the documentation. +# The default value is: NO. + +HIDE_FRIEND_COMPOUNDS = NO + +# If the HIDE_IN_BODY_DOCS tag is set to YES, doxygen will hide any +# documentation blocks found inside the body of a function. If set to NO, these +# blocks will be appended to the function's detailed documentation block. +# The default value is: NO. + +HIDE_IN_BODY_DOCS = NO + +# The INTERNAL_DOCS tag determines if documentation that is typed after a +# \internal command is included. If the tag is set to NO then the documentation +# will be excluded. Set it to YES to include the internal documentation. +# The default value is: NO. + +INTERNAL_DOCS = NO + +# If the CASE_SENSE_NAMES tag is set to NO then doxygen will only generate file +# names in lower-case letters. If set to YES, upper-case letters are also +# allowed. This is useful if you have classes or files whose names only differ +# in case and if your file system supports case sensitive file names. Windows +# and Mac users are advised to set this option to NO. +# The default value is: system dependent. + +CASE_SENSE_NAMES = YES + +# If the HIDE_SCOPE_NAMES tag is set to NO then doxygen will show members with +# their full class and namespace scopes in the documentation. If set to YES, the +# scope will be hidden. +# The default value is: NO. + +HIDE_SCOPE_NAMES = NO + +# If the SHOW_INCLUDE_FILES tag is set to YES then doxygen will put a list of +# the files that are included by a file in the documentation of that file. +# The default value is: YES. + +SHOW_INCLUDE_FILES = YES + +# If the SHOW_GROUPED_MEMB_INC tag is set to YES then Doxygen will add for each +# grouped member an include statement to the documentation, telling the reader +# which file to include in order to use the member. +# The default value is: NO. + +SHOW_GROUPED_MEMB_INC = YES + +# If the FORCE_LOCAL_INCLUDES tag is set to YES then doxygen will list include +# files with double quotes in the documentation rather than with sharp brackets. +# The default value is: NO. + +FORCE_LOCAL_INCLUDES = NO + +# If the INLINE_INFO tag is set to YES then a tag [inline] is inserted in the +# documentation for inline members. +# The default value is: YES. + +INLINE_INFO = YES + +# If the SORT_MEMBER_DOCS tag is set to YES then doxygen will sort the +# (detailed) documentation of file and class members alphabetically by member +# name. If set to NO, the members will appear in declaration order. +# The default value is: YES. + +SORT_MEMBER_DOCS = YES + +# If the SORT_BRIEF_DOCS tag is set to YES then doxygen will sort the brief +# descriptions of file, namespace and class members alphabetically by member +# name. If set to NO, the members will appear in declaration order. Note that +# this will also influence the order of the classes in the class list. +# The default value is: NO. + +SORT_BRIEF_DOCS = NO + +# If the SORT_MEMBERS_CTORS_1ST tag is set to YES then doxygen will sort the +# (brief and detailed) documentation of class members so that constructors and +# destructors are listed first. If set to NO the constructors will appear in the +# respective orders defined by SORT_BRIEF_DOCS and SORT_MEMBER_DOCS. +# Note: If SORT_BRIEF_DOCS is set to NO this option is ignored for sorting brief +# member documentation. +# Note: If SORT_MEMBER_DOCS is set to NO this option is ignored for sorting +# detailed member documentation. +# The default value is: NO. + +SORT_MEMBERS_CTORS_1ST = NO + +# If the SORT_GROUP_NAMES tag is set to YES then doxygen will sort the hierarchy +# of group names into alphabetical order. If set to NO the group names will +# appear in their defined order. +# The default value is: NO. + +SORT_GROUP_NAMES = YES + +# If the SORT_BY_SCOPE_NAME tag is set to YES, the class list will be sorted by +# fully-qualified names, including namespaces. If set to NO, the class list will +# be sorted only by class name, not including the namespace part. +# Note: This option is not very useful if HIDE_SCOPE_NAMES is set to YES. +# Note: This option applies only to the class list, not to the alphabetical +# list. +# The default value is: NO. + +SORT_BY_SCOPE_NAME = YES + +# If the STRICT_PROTO_MATCHING option is enabled and doxygen fails to do proper +# type resolution of all parameters of a function it will reject a match between +# the prototype and the implementation of a member function even if there is +# only one candidate or it is obvious which candidate to choose by doing a +# simple string match. By disabling STRICT_PROTO_MATCHING doxygen will still +# accept a match between prototype and implementation in such cases. +# The default value is: NO. + +STRICT_PROTO_MATCHING = YES + +# The GENERATE_TODOLIST tag can be used to enable (YES) or disable (NO) the todo +# list. This list is created by putting \todo commands in the documentation. +# The default value is: YES. + +GENERATE_TODOLIST = NO + +# The GENERATE_TESTLIST tag can be used to enable (YES) or disable (NO) the test +# list. This list is created by putting \test commands in the documentation. +# The default value is: YES. + +GENERATE_TESTLIST = NO + +# The GENERATE_BUGLIST tag can be used to enable (YES) or disable (NO) the bug +# list. This list is created by putting \bug commands in the documentation. +# The default value is: YES. + +GENERATE_BUGLIST = NO + +# The GENERATE_DEPRECATEDLIST tag can be used to enable (YES) or disable (NO) +# the deprecated list. This list is created by putting \deprecated commands in +# the documentation. +# The default value is: YES. + +GENERATE_DEPRECATEDLIST= YES + +# The ENABLED_SECTIONS tag can be used to enable conditional documentation +# sections, marked by \if ... \endif and \cond +# ... \endcond blocks. + +ENABLED_SECTIONS = YES + +# The MAX_INITIALIZER_LINES tag determines the maximum number of lines that the +# initial value of a variable or macro / define can have for it to appear in the +# documentation. If the initializer consists of more lines than specified here +# it will be hidden. Use a value of 0 to hide initializers completely. The +# appearance of the value of individual variables and macros / defines can be +# controlled using \showinitializer or \hideinitializer command in the +# documentation regardless of this setting. +# Minimum value: 0, maximum value: 10000, default value: 30. + +MAX_INITIALIZER_LINES = 300 + +# Set the SHOW_USED_FILES tag to NO to disable the list of files generated at +# the bottom of the documentation of classes and structs. If set to YES, the +# list will mention the files that were used to generate the documentation. +# The default value is: YES. + +SHOW_USED_FILES = YES + +# Set the SHOW_FILES tag to NO to disable the generation of the Files page. This +# will remove the Files entry from the Quick Index and from the Folder Tree View +# (if specified). +# The default value is: YES. + +SHOW_FILES = YES + +# Set the SHOW_NAMESPACES tag to NO to disable the generation of the Namespaces +# page. This will remove the Namespaces entry from the Quick Index and from the +# Folder Tree View (if specified). +# The default value is: YES. + +SHOW_NAMESPACES = YES + +# The FILE_VERSION_FILTER tag can be used to specify a program or script that +# doxygen should invoke to get the current version for each file (typically from +# the version control system). Doxygen will invoke the program by executing (via +# popen()) the command command input-file, where command is the value of the +# FILE_VERSION_FILTER tag, and input-file is the name of an input file provided +# by doxygen. Whatever the program writes to standard output is used as the file +# version. For an example see the documentation. + +FILE_VERSION_FILTER = + +# The LAYOUT_FILE tag can be used to specify a layout file which will be parsed +# by doxygen. The layout file controls the global structure of the generated +# output files in an output format independent way. To create the layout file +# that represents doxygen's defaults, run doxygen with the -l option. You can +# optionally specify a file name after the option, if omitted DoxygenLayout.xml +# will be used as the name of the layout file. +# +# Note that if you run doxygen from a directory containing a file called +# DoxygenLayout.xml, doxygen will parse it automatically even if the LAYOUT_FILE +# tag is left empty. + +LAYOUT_FILE = + +# The CITE_BIB_FILES tag can be used to specify one or more bib files containing +# the reference definitions. This must be a list of .bib files. The .bib +# extension is automatically appended if omitted. This requires the bibtex tool +# to be installed. See also https://en.wikipedia.org/wiki/BibTeX for more info. +# For LaTeX the style of the bibliography can be controlled using +# LATEX_BIB_STYLE. To use this feature you need bibtex and perl available in the +# search path. See also \cite for info how to create references. + +CITE_BIB_FILES = + +#--------------------------------------------------------------------------- +# Configuration options related to warning and progress messages +#--------------------------------------------------------------------------- + +# The QUIET tag can be used to turn on/off the messages that are generated to +# standard output by doxygen. If QUIET is set to YES this implies that the +# messages are off. +# The default value is: NO. + +QUIET = YES + +# The WARNINGS tag can be used to turn on/off the warning messages that are +# generated to standard error (stderr) by doxygen. If WARNINGS is set to YES +# this implies that the warnings are on. +# +# Tip: Turn warnings on while writing the documentation. +# The default value is: YES. + +WARNINGS = YES + +# If the WARN_IF_UNDOCUMENTED tag is set to YES then doxygen will generate +# warnings for undocumented members. If EXTRACT_ALL is set to YES then this flag +# will automatically be disabled. +# The default value is: YES. + +WARN_IF_UNDOCUMENTED = YES + +# If the WARN_IF_DOC_ERROR tag is set to YES, doxygen will generate warnings for +# potential errors in the documentation, such as not documenting some parameters +# in a documented function, or documenting parameters that don't exist or using +# markup commands wrongly. +# The default value is: YES. + +WARN_IF_DOC_ERROR = YES + +# This WARN_NO_PARAMDOC option can be enabled to get warnings for functions that +# are documented, but have no documentation for their parameters or return +# value. If set to NO, doxygen will only warn about wrong or incomplete +# parameter documentation, but not about the absence of documentation. +# The default value is: NO. + +WARN_NO_PARAMDOC = NO + +# The WARN_FORMAT tag determines the format of the warning messages that doxygen +# can produce. The string should contain the $file, $line, and $text tags, which +# will be replaced by the file and line number from which the warning originated +# and the warning text. Optionally the format may contain $version, which will +# be replaced by the version of the file (if it could be obtained via +# FILE_VERSION_FILTER) +# The default value is: $file:$line: $text. + +WARN_FORMAT = "$file:$line: $text" + +# The WARN_LOGFILE tag can be used to specify a file to which warning and error +# messages should be written. If left blank the output is written to standard +# error (stderr). + +WARN_LOGFILE = + +#--------------------------------------------------------------------------- +# Configuration options related to the input files +#--------------------------------------------------------------------------- + +# The INPUT tag is used to specify the files and/or directories that contain +# documented source files. You may enter file names like myfile.cpp or +# directories like /usr/src/myproject. Separate the files or directories with +# spaces. See also FILE_PATTERNS and EXTENSION_MAPPING +# Note: If this tag is empty the current directory is searched. + +INPUT = "@XEN_BASE@/docs/xen-doxygen/mainpage.md" + +# This tag can be used to specify the character encoding of the source files +# that doxygen parses. Internally doxygen uses the UTF-8 encoding. Doxygen uses +# libiconv (or the iconv built into libc) for the transcoding. See the libiconv +# documentation (see: https://www.gnu.org/software/libiconv/) for the list of +# possible encodings. +# The default value is: UTF-8. + +INPUT_ENCODING = UTF-8 + +# If the value of the INPUT tag contains directories, you can use the +# FILE_PATTERNS tag to specify one or more wildcard patterns (like *.cpp and +# *.h) to filter out the source-files in the directories. +# +# Note that for custom extensions or not directly supported extensions you also +# need to set EXTENSION_MAPPING for the extension otherwise the files are not +# read by doxygen. +# +# If left blank the following patterns are tested:*.c, *.cc, *.cxx, *.cpp, +# *.c++, *.java, *.ii, *.ixx, *.ipp, *.i++, *.inl, *.idl, *.ddl, *.odl, *.h, +# *.hh, *.hxx, *.hpp, *.h++, *.cs, *.d, *.php, *.php4, *.php5, *.phtml, *.inc, +# *.m, *.markdown, *.md, *.mm, *.dox, *.py, *.pyw, *.f90, *.f95, *.f03, *.f08, +# *.f, *.for, *.tcl, *.vhd, *.vhdl, *.ucf and *.qsf. + +# This MUST be kept in sync with DOXY_SOURCES in doc/CMakeLists.txt +# for incremental (and faster) builds to work correctly. +FILE_PATTERNS = "*.c" \ + "*.h" \ + "*.S" \ + "*.md" + +# The RECURSIVE tag can be used to specify whether or not subdirectories should +# be searched for input files as well. +# The default value is: NO. + +RECURSIVE = YES + +# The EXCLUDE tag can be used to specify files and/or directories that should be +# excluded from the INPUT source files. This way you can easily exclude a +# subdirectory from a directory tree whose root is specified with the INPUT tag. +# +# Note that relative paths are relative to the directory from which doxygen is +# run. + +EXCLUDE = @XEN_BASE@/include/nothing.h + +# The EXCLUDE_SYMLINKS tag can be used to select whether or not files or +# directories that are symbolic links (a Unix file system feature) are excluded +# from the input. +# The default value is: NO. + +EXCLUDE_SYMLINKS = NO + +# If the value of the INPUT tag contains directories, you can use the +# EXCLUDE_PATTERNS tag to specify one or more wildcard patterns to exclude +# certain files from those directories. +# +# Note that the wildcards are matched against the file with absolute path, so to +# exclude all test directories for example use the pattern */test/* + +EXCLUDE_PATTERNS = + +# The EXCLUDE_SYMBOLS tag can be used to specify one or more symbol names +# (namespaces, classes, functions, etc.) that should be excluded from the +# output. The symbol name can be a fully qualified name, a word, or if the +# wildcard * is used, a substring. Examples: ANamespace, AClass, +# AClass::ANamespace, ANamespace::*Test +# +# Note that the wildcards are matched against the file with absolute path, so to +# exclude all test directories use the pattern */test/* + +# Hide internal names (starting with an underscore, and doxygen-generated names +# for nested unnamed unions that don't generate meaningful sphinx output anyway. +EXCLUDE_SYMBOLS = +# _* *.__unnamed__ z_* Z_* + +# The EXAMPLE_PATH tag can be used to specify one or more files or directories +# that contain example code fragments that are included (see the \include +# command). + +EXAMPLE_PATH = + +# If the value of the EXAMPLE_PATH tag contains directories, you can use the +# EXAMPLE_PATTERNS tag to specify one or more wildcard pattern (like *.cpp and +# *.h) to filter out the source-files in the directories. If left blank all +# files are included. + +EXAMPLE_PATTERNS = + +# If the EXAMPLE_RECURSIVE tag is set to YES then subdirectories will be +# searched for input files to be used with the \include or \dontinclude commands +# irrespective of the value of the RECURSIVE tag. +# The default value is: NO. + +EXAMPLE_RECURSIVE = YES + +# The IMAGE_PATH tag can be used to specify one or more files or directories +# that contain images that are to be included in the documentation (see the +# \image command). + +IMAGE_PATH = + +# The INPUT_FILTER tag can be used to specify a program that doxygen should +# invoke to filter for each input file. Doxygen will invoke the filter program +# by executing (via popen()) the command: +# +# +# +# where is the value of the INPUT_FILTER tag, and is the +# name of an input file. Doxygen will then use the output that the filter +# program writes to standard output. If FILTER_PATTERNS is specified, this tag +# will be ignored. +# +# Note that the filter must not add or remove lines; it is applied before the +# code is scanned, but not when the output code is generated. If lines are added +# or removed, the anchors will not be placed correctly. +# +# Note that for custom extensions or not directly supported extensions you also +# need to set EXTENSION_MAPPING for the extension otherwise the files are not +# properly processed by doxygen. + +INPUT_FILTER = + +# The FILTER_PATTERNS tag can be used to specify filters on a per file pattern +# basis. Doxygen will compare the file name with each pattern and apply the +# filter if there is a match. The filters are a list of the form: pattern=filter +# (like *.cpp=my_cpp_filter). See INPUT_FILTER for further information on how +# filters are used. If the FILTER_PATTERNS tag is empty or if none of the +# patterns match the file name, INPUT_FILTER is applied. +# +# Note that for custom extensions or not directly supported extensions you also +# need to set EXTENSION_MAPPING for the extension otherwise the files are not +# properly processed by doxygen. + +FILTER_PATTERNS = *.h="\"@XEN_BASE@/docs/xen-doxygen/doxy-preprocessor.py\"" + +# If the FILTER_SOURCE_FILES tag is set to YES, the input filter (if set using +# INPUT_FILTER) will also be used to filter the input files that are used for +# producing the source files to browse (i.e. when SOURCE_BROWSER is set to YES). +# The default value is: NO. + +FILTER_SOURCE_FILES = NO + +# The FILTER_SOURCE_PATTERNS tag can be used to specify source filters per file +# pattern. A pattern will override the setting for FILTER_PATTERN (if any) and +# it is also possible to disable source filtering for a specific pattern using +# *.ext= (so without naming a filter). +# This tag requires that the tag FILTER_SOURCE_FILES is set to YES. + +FILTER_SOURCE_PATTERNS = + +# If the USE_MDFILE_AS_MAINPAGE tag refers to the name of a markdown file that +# is part of the input, its contents will be placed on the main page +# (index.html). This can be useful if you have a project on for instance GitHub +# and want to reuse the introduction page also for the doxygen output. + +USE_MDFILE_AS_MAINPAGE = "mainpage.md" + +#--------------------------------------------------------------------------- +# Configuration options related to source browsing +#--------------------------------------------------------------------------- + +# If the SOURCE_BROWSER tag is set to YES then a list of source files will be +# generated. Documented entities will be cross-referenced with these sources. +# +# Note: To get rid of all source code in the generated output, make sure that +# also VERBATIM_HEADERS is set to NO. +# The default value is: NO. + +SOURCE_BROWSER = NO + +# Setting the INLINE_SOURCES tag to YES will include the body of functions, +# classes and enums directly into the documentation. +# The default value is: NO. + +INLINE_SOURCES = NO + +# Setting the STRIP_CODE_COMMENTS tag to YES will instruct doxygen to hide any +# special comment blocks from generated source code fragments. Normal C, C++ and +# Fortran comments will always remain visible. +# The default value is: YES. + +STRIP_CODE_COMMENTS = YES + +# If the REFERENCED_BY_RELATION tag is set to YES then for each documented +# function all documented functions referencing it will be listed. +# The default value is: NO. + +REFERENCED_BY_RELATION = NO + +# If the REFERENCES_RELATION tag is set to YES then for each documented function +# all documented entities called/used by that function will be listed. +# The default value is: NO. + +REFERENCES_RELATION = NO + +# If the REFERENCES_LINK_SOURCE tag is set to YES and SOURCE_BROWSER tag is set +# to YES then the hyperlinks from functions in REFERENCES_RELATION and +# REFERENCED_BY_RELATION lists will link to the source code. Otherwise they will +# link to the documentation. +# The default value is: YES. + +REFERENCES_LINK_SOURCE = YES + +# If SOURCE_TOOLTIPS is enabled (the default) then hovering a hyperlink in the +# source code will show a tooltip with additional information such as prototype, +# brief description and links to the definition and documentation. Since this +# will make the HTML file larger and loading of large files a bit slower, you +# can opt to disable this feature. +# The default value is: YES. +# This tag requires that the tag SOURCE_BROWSER is set to YES. + +SOURCE_TOOLTIPS = YES + +# If the USE_HTAGS tag is set to YES then the references to source code will +# point to the HTML generated by the htags(1) tool instead of doxygen built-in +# source browser. The htags tool is part of GNU's global source tagging system +# (see https://www.gnu.org/software/global/global.html). You will need version +# 4.8.6 or higher. +# +# To use it do the following: +# - Install the latest version of global +# - Enable SOURCE_BROWSER and USE_HTAGS in the config file +# - Make sure the INPUT points to the root of the source tree +# - Run doxygen as normal +# +# Doxygen will invoke htags (and that will in turn invoke gtags), so these +# tools must be available from the command line (i.e. in the search path). +# +# The result: instead of the source browser generated by doxygen, the links to +# source code will now point to the output of htags. +# The default value is: NO. +# This tag requires that the tag SOURCE_BROWSER is set to YES. + +USE_HTAGS = NO + +# If the VERBATIM_HEADERS tag is set the YES then doxygen will generate a +# verbatim copy of the header file for each class for which an include is +# specified. Set to NO to disable this. +# See also: Section \class. +# The default value is: YES. + +VERBATIM_HEADERS = YES + +#--------------------------------------------------------------------------- +# Configuration options related to the alphabetical class index +#--------------------------------------------------------------------------- + +# If the ALPHABETICAL_INDEX tag is set to YES, an alphabetical index of all +# compounds will be generated. Enable this if the project contains a lot of +# classes, structs, unions or interfaces. +# The default value is: YES. + +ALPHABETICAL_INDEX = YES + +# The COLS_IN_ALPHA_INDEX tag can be used to specify the number of columns in +# which the alphabetical index list will be split. +# Minimum value: 1, maximum value: 20, default value: 5. +# This tag requires that the tag ALPHABETICAL_INDEX is set to YES. + +COLS_IN_ALPHA_INDEX = 2 + +# In case all classes in a project start with a common prefix, all classes will +# be put under the same header in the alphabetical index. The IGNORE_PREFIX tag +# can be used to specify a prefix (or a list of prefixes) that should be ignored +# while generating the index headers. +# This tag requires that the tag ALPHABETICAL_INDEX is set to YES. + +IGNORE_PREFIX = + +#--------------------------------------------------------------------------- +# Configuration options related to the HTML output +#--------------------------------------------------------------------------- + +# If the GENERATE_HTML tag is set to YES, doxygen will generate HTML output +# The default value is: YES. + +GENERATE_HTML = YES + +# The HTML_OUTPUT tag is used to specify where the HTML docs will be put. If a +# relative path is entered the value of OUTPUT_DIRECTORY will be put in front of +# it. +# The default directory is: html. +# This tag requires that the tag GENERATE_HTML is set to YES. + +HTML_OUTPUT = html + +# The HTML_FILE_EXTENSION tag can be used to specify the file extension for each +# generated HTML page (for example: .htm, .php, .asp). +# The default value is: .html. +# This tag requires that the tag GENERATE_HTML is set to YES. + +HTML_FILE_EXTENSION = .html + +# The HTML_HEADER tag can be used to specify a user-defined HTML header file for +# each generated HTML page. If the tag is left blank doxygen will generate a +# standard header. +# +# To get valid HTML the header file that includes any scripts and style sheets +# that doxygen needs, which is dependent on the configuration options used (e.g. +# the setting GENERATE_TREEVIEW). It is highly recommended to start with a +# default header using +# doxygen -w html new_header.html new_footer.html new_stylesheet.css +# YourConfigFile +# and then modify the file new_header.html. See also section "Doxygen usage" +# for information on how to generate the default header that doxygen normally +# uses. +# Note: The header is subject to change so you typically have to regenerate the +# default header when upgrading to a newer version of doxygen. For a description +# of the possible markers and block names see the documentation. +# This tag requires that the tag GENERATE_HTML is set to YES. + +HTML_HEADER = xen-doxygen/header.html + +# The HTML_FOOTER tag can be used to specify a user-defined HTML footer for each +# generated HTML page. If the tag is left blank doxygen will generate a standard +# footer. See HTML_HEADER for more information on how to generate a default +# footer and what special commands can be used inside the footer. See also +# section "Doxygen usage" for information on how to generate the default footer +# that doxygen normally uses. +# This tag requires that the tag GENERATE_HTML is set to YES. + +HTML_FOOTER = + +# The HTML_STYLESHEET tag can be used to specify a user-defined cascading style +# sheet that is used by each HTML page. It can be used to fine-tune the look of +# the HTML output. If left blank doxygen will generate a default style sheet. +# See also section "Doxygen usage" for information on how to generate the style +# sheet that doxygen normally uses. +# Note: It is recommended to use HTML_EXTRA_STYLESHEET instead of this tag, as +# it is more robust and this tag (HTML_STYLESHEET) will in the future become +# obsolete. +# This tag requires that the tag GENERATE_HTML is set to YES. + +HTML_STYLESHEET = + +# The HTML_EXTRA_STYLESHEET tag can be used to specify additional user-defined +# cascading style sheets that are included after the standard style sheets +# created by doxygen. Using this option one can overrule certain style aspects. +# This is preferred over using HTML_STYLESHEET since it does not replace the +# standard style sheet and is therefore more robust against future updates. +# Doxygen will copy the style sheet files to the output directory. +# Note: The order of the extra style sheet files is of importance (e.g. the last +# style sheet in the list overrules the setting of the previous ones in the +# list). For an example see the documentation. +# This tag requires that the tag GENERATE_HTML is set to YES. + +HTML_EXTRA_STYLESHEET = xen-doxygen/customdoxygen.css + +# The HTML_EXTRA_FILES tag can be used to specify one or more extra images or +# other source files which should be copied to the HTML output directory. Note +# that these files will be copied to the base HTML output directory. Use the +# $relpath^ marker in the HTML_HEADER and/or HTML_FOOTER files to load these +# files. In the HTML_STYLESHEET file, use the file name only. Also note that the +# files will be copied as-is; there are no commands or markers available. +# This tag requires that the tag GENERATE_HTML is set to YES. + +HTML_EXTRA_FILES = + +# The HTML_COLORSTYLE_HUE tag controls the color of the HTML output. Doxygen +# will adjust the colors in the style sheet and background images according to +# this color. Hue is specified as an angle on a colorwheel, see +# https://en.wikipedia.org/wiki/Hue for more information. For instance the value +# 0 represents red, 60 is yellow, 120 is green, 180 is cyan, 240 is blue, 300 +# purple, and 360 is red again. +# Minimum value: 0, maximum value: 359, default value: 220. +# This tag requires that the tag GENERATE_HTML is set to YES. + +HTML_COLORSTYLE_HUE = + +# The HTML_COLORSTYLE_SAT tag controls the purity (or saturation) of the colors +# in the HTML output. For a value of 0 the output will use grayscales only. A +# value of 255 will produce the most vivid colors. +# Minimum value: 0, maximum value: 255, default value: 100. +# This tag requires that the tag GENERATE_HTML is set to YES. + +HTML_COLORSTYLE_SAT = + +# The HTML_COLORSTYLE_GAMMA tag controls the gamma correction applied to the +# luminance component of the colors in the HTML output. Values below 100 +# gradually make the output lighter, whereas values above 100 make the output +# darker. The value divided by 100 is the actual gamma applied, so 80 represents +# a gamma of 0.8, The value 220 represents a gamma of 2.2, and 100 does not +# change the gamma. +# Minimum value: 40, maximum value: 240, default value: 80. +# This tag requires that the tag GENERATE_HTML is set to YES. + +HTML_COLORSTYLE_GAMMA = + +# If the HTML_TIMESTAMP tag is set to YES then the footer of each generated HTML +# page will contain the date and time when the page was generated. Setting this +# to YES can help to show when doxygen was last run and thus if the +# documentation is up to date. +# The default value is: NO. +# This tag requires that the tag GENERATE_HTML is set to YES. + +HTML_TIMESTAMP = YES + +# If the HTML_DYNAMIC_SECTIONS tag is set to YES then the generated HTML +# documentation will contain sections that can be hidden and shown after the +# page has loaded. +# The default value is: NO. +# This tag requires that the tag GENERATE_HTML is set to YES. + +HTML_DYNAMIC_SECTIONS = YES + +# With HTML_INDEX_NUM_ENTRIES one can control the preferred number of entries +# shown in the various tree structured indices initially; the user can expand +# and collapse entries dynamically later on. Doxygen will expand the tree to +# such a level that at most the specified number of entries are visible (unless +# a fully collapsed tree already exceeds this amount). So setting the number of +# entries 1 will produce a full collapsed tree by default. 0 is a special value +# representing an infinite number of entries and will result in a full expanded +# tree by default. +# Minimum value: 0, maximum value: 9999, default value: 100. +# This tag requires that the tag GENERATE_HTML is set to YES. + +HTML_INDEX_NUM_ENTRIES = 100 + +# If the GENERATE_DOCSET tag is set to YES, additional index files will be +# generated that can be used as input for Apple's Xcode 3 integrated development +# environment (see: https://developer.apple.com/tools/xcode/), introduced with +# OSX 10.5 (Leopard). To create a documentation set, doxygen will generate a +# Makefile in the HTML output directory. Running make will produce the docset in +# that directory and running make install will install the docset in +# ~/Library/Developer/Shared/Documentation/DocSets so that Xcode will find it at +# startup. See https://developer.apple.com/tools/creatingdocsetswithdoxygen.html +# for more information. +# The default value is: NO. +# This tag requires that the tag GENERATE_HTML is set to YES. + +GENERATE_DOCSET = YES + +# This tag determines the name of the docset feed. A documentation feed provides +# an umbrella under which multiple documentation sets from a single provider +# (such as a company or product suite) can be grouped. +# The default value is: Doxygen generated docs. +# This tag requires that the tag GENERATE_DOCSET is set to YES. + +DOCSET_FEEDNAME = "Doxygen generated docs" + +# This tag specifies a string that should uniquely identify the documentation +# set bundle. This should be a reverse domain-name style string, e.g. +# com.mycompany.MyDocSet. Doxygen will append .docset to the name. +# The default value is: org.doxygen.Project. +# This tag requires that the tag GENERATE_DOCSET is set to YES. + +DOCSET_BUNDLE_ID = org.doxygen.Project + +# The DOCSET_PUBLISHER_ID tag specifies a string that should uniquely identify +# the documentation publisher. This should be a reverse domain-name style +# string, e.g. com.mycompany.MyDocSet.documentation. +# The default value is: org.doxygen.Publisher. +# This tag requires that the tag GENERATE_DOCSET is set to YES. + +DOCSET_PUBLISHER_ID = org.doxygen.Publisher + +# The DOCSET_PUBLISHER_NAME tag identifies the documentation publisher. +# The default value is: Publisher. +# This tag requires that the tag GENERATE_DOCSET is set to YES. + +DOCSET_PUBLISHER_NAME = Publisher + +# If the GENERATE_HTMLHELP tag is set to YES then doxygen generates three +# additional HTML index files: index.hhp, index.hhc, and index.hhk. The +# index.hhp is a project file that can be read by Microsoft's HTML Help Workshop +# (see: http://www.microsoft.com/en-us/download/details.aspx?id=21138) on +# Windows. +# +# The HTML Help Workshop contains a compiler that can convert all HTML output +# generated by doxygen into a single compiled HTML file (.chm). Compiled HTML +# files are now used as the Windows 98 help format, and will replace the old +# Windows help format (.hlp) on all Windows platforms in the future. Compressed +# HTML files also contain an index, a table of contents, and you can search for +# words in the documentation. The HTML workshop also contains a viewer for +# compressed HTML files. +# The default value is: NO. +# This tag requires that the tag GENERATE_HTML is set to YES. + +GENERATE_HTMLHELP = NO + +# The CHM_FILE tag can be used to specify the file name of the resulting .chm +# file. You can add a path in front of the file if the result should not be +# written to the html output directory. +# This tag requires that the tag GENERATE_HTMLHELP is set to YES. + +CHM_FILE = NO + +# The HHC_LOCATION tag can be used to specify the location (absolute path +# including file name) of the HTML help compiler (hhc.exe). If non-empty, +# doxygen will try to run the HTML help compiler on the generated index.hhp. +# The file has to be specified with full path. +# This tag requires that the tag GENERATE_HTMLHELP is set to YES. + +HHC_LOCATION = + +# The GENERATE_CHI flag controls if a separate .chi index file is generated +# (YES) or that it should be included in the master .chm file (NO). +# The default value is: NO. +# This tag requires that the tag GENERATE_HTMLHELP is set to YES. + +GENERATE_CHI = NO + +# The CHM_INDEX_ENCODING is used to encode HtmlHelp index (hhk), content (hhc) +# and project file content. +# This tag requires that the tag GENERATE_HTMLHELP is set to YES. + +CHM_INDEX_ENCODING = + +# The BINARY_TOC flag controls whether a binary table of contents is generated +# (YES) or a normal table of contents (NO) in the .chm file. Furthermore it +# enables the Previous and Next buttons. +# The default value is: NO. +# This tag requires that the tag GENERATE_HTMLHELP is set to YES. + +BINARY_TOC = YES + +# The TOC_EXPAND flag can be set to YES to add extra items for group members to +# the table of contents of the HTML help documentation and to the tree view. +# The default value is: NO. +# This tag requires that the tag GENERATE_HTMLHELP is set to YES. + +TOC_EXPAND = NO + +# If the GENERATE_QHP tag is set to YES and both QHP_NAMESPACE and +# QHP_VIRTUAL_FOLDER are set, an additional index file will be generated that +# can be used as input for Qt's qhelpgenerator to generate a Qt Compressed Help +# (.qch) of the generated HTML documentation. +# The default value is: NO. +# This tag requires that the tag GENERATE_HTML is set to YES. + +GENERATE_QHP = NO + +# If the QHG_LOCATION tag is specified, the QCH_FILE tag can be used to specify +# the file name of the resulting .qch file. The path specified is relative to +# the HTML output folder. +# This tag requires that the tag GENERATE_QHP is set to YES. + +QCH_FILE = + +# The QHP_NAMESPACE tag specifies the namespace to use when generating Qt Help +# Project output. For more information please see Qt Help Project / Namespace +# (see: http://doc.qt.io/qt-4.8/qthelpproject.html#namespace). +# The default value is: org.doxygen.Project. +# This tag requires that the tag GENERATE_QHP is set to YES. + +QHP_NAMESPACE = org.doxygen.Project + +# The QHP_VIRTUAL_FOLDER tag specifies the namespace to use when generating Qt +# Help Project output. For more information please see Qt Help Project / Virtual +# Folders (see: http://doc.qt.io/qt-4.8/qthelpproject.html#virtual-folders). +# The default value is: doc. +# This tag requires that the tag GENERATE_QHP is set to YES. + +QHP_VIRTUAL_FOLDER = doc + +# If the QHP_CUST_FILTER_NAME tag is set, it specifies the name of a custom +# filter to add. For more information please see Qt Help Project / Custom +# Filters (see: http://doc.qt.io/qt-4.8/qthelpproject.html#custom-filters). +# This tag requires that the tag GENERATE_QHP is set to YES. + +QHP_CUST_FILTER_NAME = + +# The QHP_CUST_FILTER_ATTRS tag specifies the list of the attributes of the +# custom filter to add. For more information please see Qt Help Project / Custom +# Filters (see: http://doc.qt.io/qt-4.8/qthelpproject.html#custom-filters). +# This tag requires that the tag GENERATE_QHP is set to YES. + +QHP_CUST_FILTER_ATTRS = + +# The QHP_SECT_FILTER_ATTRS tag specifies the list of the attributes this +# project's filter section matches. Qt Help Project / Filter Attributes (see: +# http://doc.qt.io/qt-4.8/qthelpproject.html#filter-attributes). +# This tag requires that the tag GENERATE_QHP is set to YES. + +QHP_SECT_FILTER_ATTRS = + +# The QHG_LOCATION tag can be used to specify the location of Qt's +# qhelpgenerator. If non-empty doxygen will try to run qhelpgenerator on the +# generated .qhp file. +# This tag requires that the tag GENERATE_QHP is set to YES. + +QHG_LOCATION = + +# If the GENERATE_ECLIPSEHELP tag is set to YES, additional index files will be +# generated, together with the HTML files, they form an Eclipse help plugin. To +# install this plugin and make it available under the help contents menu in +# Eclipse, the contents of the directory containing the HTML and XML files needs +# to be copied into the plugins directory of eclipse. The name of the directory +# within the plugins directory should be the same as the ECLIPSE_DOC_ID value. +# After copying Eclipse needs to be restarted before the help appears. +# The default value is: NO. +# This tag requires that the tag GENERATE_HTML is set to YES. + +GENERATE_ECLIPSEHELP = NO + +# A unique identifier for the Eclipse help plugin. When installing the plugin +# the directory name containing the HTML and XML files should also have this +# name. Each documentation set should have its own identifier. +# The default value is: org.doxygen.Project. +# This tag requires that the tag GENERATE_ECLIPSEHELP is set to YES. + +ECLIPSE_DOC_ID = org.doxygen.Project + +# If you want full control over the layout of the generated HTML pages it might +# be necessary to disable the index and replace it with your own. The +# DISABLE_INDEX tag can be used to turn on/off the condensed index (tabs) at top +# of each HTML page. A value of NO enables the index and the value YES disables +# it. Since the tabs in the index contain the same information as the navigation +# tree, you can set this option to YES if you also set GENERATE_TREEVIEW to YES. +# The default value is: NO. +# This tag requires that the tag GENERATE_HTML is set to YES. + +DISABLE_INDEX = NO + +# The GENERATE_TREEVIEW tag is used to specify whether a tree-like index +# structure should be generated to display hierarchical information. If the tag +# value is set to YES, a side panel will be generated containing a tree-like +# index structure (just like the one that is generated for HTML Help). For this +# to work a browser that supports JavaScript, DHTML, CSS and frames is required +# (i.e. any modern browser). Windows users are probably better off using the +# HTML help feature. Via custom style sheets (see HTML_EXTRA_STYLESHEET) one can +# further fine-tune the look of the index. As an example, the default style +# sheet generated by doxygen has an example that shows how to put an image at +# the root of the tree instead of the PROJECT_NAME. Since the tree basically has +# the same information as the tab index, you could consider setting +# DISABLE_INDEX to YES when enabling this option. +# The default value is: NO. +# This tag requires that the tag GENERATE_HTML is set to YES. + +GENERATE_TREEVIEW = YES + +# The ENUM_VALUES_PER_LINE tag can be used to set the number of enum values that +# doxygen will group on one line in the generated HTML documentation. +# +# Note that a value of 0 will completely suppress the enum values from appearing +# in the overview section. +# Minimum value: 0, maximum value: 20, default value: 4. +# This tag requires that the tag GENERATE_HTML is set to YES. + +ENUM_VALUES_PER_LINE = 4 + +# If the treeview is enabled (see GENERATE_TREEVIEW) then this tag can be used +# to set the initial width (in pixels) of the frame in which the tree is shown. +# Minimum value: 0, maximum value: 1500, default value: 250. +# This tag requires that the tag GENERATE_HTML is set to YES. + +TREEVIEW_WIDTH = 250 + +# If the EXT_LINKS_IN_WINDOW option is set to YES, doxygen will open links to +# external symbols imported via tag files in a separate window. +# The default value is: NO. +# This tag requires that the tag GENERATE_HTML is set to YES. + +EXT_LINKS_IN_WINDOW = NO + +# Use this tag to change the font size of LaTeX formulas included as images in +# the HTML documentation. When you change the font size after a successful +# doxygen run you need to manually remove any form_*.png images from the HTML +# output directory to force them to be regenerated. +# Minimum value: 8, maximum value: 50, default value: 10. +# This tag requires that the tag GENERATE_HTML is set to YES. + +FORMULA_FONTSIZE = 10 + +# Use the FORMULA_TRANPARENT tag to determine whether or not the images +# generated for formulas are transparent PNGs. Transparent PNGs are not +# supported properly for IE 6.0, but are supported on all modern browsers. +# +# Note that when changing this option you need to delete any form_*.png files in +# the HTML output directory before the changes have effect. +# The default value is: YES. +# This tag requires that the tag GENERATE_HTML is set to YES. + +FORMULA_TRANSPARENT = YES + +# Enable the USE_MATHJAX option to render LaTeX formulas using MathJax (see +# https://www.mathjax.org) which uses client side Javascript for the rendering +# instead of using pre-rendered bitmaps. Use this if you do not have LaTeX +# installed or if you want to formulas look prettier in the HTML output. When +# enabled you may also need to install MathJax separately and configure the path +# to it using the MATHJAX_RELPATH option. +# The default value is: NO. +# This tag requires that the tag GENERATE_HTML is set to YES. + +USE_MATHJAX = NO + +# When MathJax is enabled you can set the default output format to be used for +# the MathJax output. See the MathJax site (see: +# http://docs.mathjax.org/en/latest/output.html) for more details. +# Possible values are: HTML-CSS (which is slower, but has the best +# compatibility), NativeMML (i.e. MathML) and SVG. +# The default value is: HTML-CSS. +# This tag requires that the tag USE_MATHJAX is set to YES. + +MATHJAX_FORMAT = HTML-CSS + +# When MathJax is enabled you need to specify the location relative to the HTML +# output directory using the MATHJAX_RELPATH option. The destination directory +# should contain the MathJax.js script. For instance, if the mathjax directory +# is located at the same level as the HTML output directory, then +# MATHJAX_RELPATH should be ../mathjax. The default value points to the MathJax +# Content Delivery Network so you can quickly see the result without installing +# MathJax. However, it is strongly recommended to install a local copy of +# MathJax from https://www.mathjax.org before deployment. +# The default value is: http://cdn.mathjax.org/mathjax/latest. +# This tag requires that the tag USE_MATHJAX is set to YES. + +MATHJAX_RELPATH = http://cdn.mathjax.org/mathjax/latest + +# The MATHJAX_EXTENSIONS tag can be used to specify one or more MathJax +# extension names that should be enabled during MathJax rendering. For example +# MATHJAX_EXTENSIONS = TeX/AMSmath TeX/AMSsymbols +# This tag requires that the tag USE_MATHJAX is set to YES. + +MATHJAX_EXTENSIONS = + +# The MATHJAX_CODEFILE tag can be used to specify a file with javascript pieces +# of code that will be used on startup of the MathJax code. See the MathJax site +# (see: http://docs.mathjax.org/en/latest/output.html) for more details. For an +# example see the documentation. +# This tag requires that the tag USE_MATHJAX is set to YES. + +MATHJAX_CODEFILE = + +# When the SEARCHENGINE tag is enabled doxygen will generate a search box for +# the HTML output. The underlying search engine uses javascript and DHTML and +# should work on any modern browser. Note that when using HTML help +# (GENERATE_HTMLHELP), Qt help (GENERATE_QHP), or docsets (GENERATE_DOCSET) +# there is already a search function so this one should typically be disabled. +# For large projects the javascript based search engine can be slow, then +# enabling SERVER_BASED_SEARCH may provide a better solution. It is possible to +# search using the keyboard; to jump to the search box use + S +# (what the is depends on the OS and browser, but it is typically +# , /